platform/upstream/dotnet/runtime.git
5 years agoAdd nullable annotations to System.Reflection.Emit.ILGeneration (dotnet/corefx#38514)
Santiago Fernandez Madero [Mon, 24 Jun 2019 19:24:43 +0000 (14:24 -0500)]
Add nullable annotations to System.Reflection.Emit.ILGeneration (dotnet/corefx#38514)

* Add nullable annotations to System.Reflection.Emit.ILGeneration

* API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/792bebecab6a7c5fc721939891a844d8e94df3c8

5 years agoMerge pull request dotnet/corefx#38832 from dotnet/stephentoub-disabletest
Cory Nelson [Mon, 24 Jun 2019 18:59:06 +0000 (11:59 -0700)]
Merge pull request dotnet/corefx#38832 from dotnet/stephentoub-disabletest

Disable Http2_FlowControl_ClientDoesNotExceedWindows test

Commit migrated from https://github.com/dotnet/corefx/commit/db1ef41efc7757bc88c52f46141092611855f2b0

5 years agoMinor follow-ups/cleanups in Http2Connection and Http2Stream (dotnet/corefx#38817)
Stephen Toub [Mon, 24 Jun 2019 18:58:09 +0000 (14:58 -0400)]
Minor follow-ups/cleanups in Http2Connection and Http2Stream (dotnet/corefx#38817)

- Fix/adjust several uses of string interpolation in SocketsHttpHandler.
- Remove a Task.WhenAny allocation from SendAsync in the common case where there is no request content or where the request content sending completes synchronously.
- In GetWaiterTask use CT.UnsafeRegister instead of Register, as ExecutionContext, as the callback doesn't need context flowed.
- In GetWaiterTask, avoid allocating an unnecessary Task for the _waitSource if the token isn't cancelable.
- In GetWaiter task's cancellation callback, avoid allocating an OCE not associated with the wait.  Instead, just complete the waiter, and then rely on the subsequent cancellation check to propagate cancellation appropriately.
- Use CompareExchange to write to _abortException so that _abortException never changes its value once it's non-null.  We currently have several code paths that check the type of _abortException and then do something based on it, and that could cause issues if its type could change between the check and the action.
- Clean up HTTP2 SendAsync method, e.g. remove unnecessary tmps, remove duplicated await, use slightly more descriptive variable names, only wrap OCE with one for cancellationToken if cancellationToken has had cancellation requested.
- Replace a use of ExceptionDispatchInfo.Throw with just throw.  The former should be used when and only when throwing an exception object that may previously have been thrown; in this case we're throwing a new object that was never thrown before.
- Add detailed comment describing thread-safety around Http2Stream._waitSource
- Clean up a few comments
- Add some missing .ConfigureAwait(false) in loopback servers

Commit migrated from https://github.com/dotnet/corefx/commit/e771af6f93fe4bdc9e6172563e42422d5fdd30ff

5 years agoDisable Http2_FlowControl_ClientDoesNotExceedWindows test
Stephen Toub [Mon, 24 Jun 2019 18:53:53 +0000 (14:53 -0400)]
Disable Http2_FlowControl_ClientDoesNotExceedWindows test

Commit migrated from https://github.com/dotnet/corefx/commit/99d5257629744a6683ed3724fb8fa24852a4af86

5 years agoAdd nullable annotations to System.Resources.ResourceManager ref assembly (dotnet...
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:49:43 +0000 (13:49 -0500)]
Add nullable annotations to System.Resources.ResourceManager ref assembly (dotnet/corefx#38518)

* Add nullable annotations to System.Resources.ResourceManager ref assembly

* Address API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ae7b3970bb2c8d76004ea397083ce7ceb1238133

5 years agoAdd nullable attributes to System.Runtime ref (dotnet/corefx#38732)
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:32:36 +0000 (13:32 -0500)]
Add nullable attributes to System.Runtime ref (dotnet/corefx#38732)

Commit migrated from https://github.com/dotnet/corefx/commit/d3d1ab1c58862ebebe09d387631393a70982fe9a

5 years agoUpdating System.Text.Json package description (dotnet/corefx#38691)
Jose Perez Rodriguez [Mon, 24 Jun 2019 18:06:01 +0000 (11:06 -0700)]
Updating System.Text.Json package description (dotnet/corefx#38691)

* Updating System.Text.Json package description

* Fix ordering and namespace

* Fix description

Commit migrated from https://github.com/dotnet/corefx/commit/eebe43224d8994b5b47bc2906c271ea6f256728b

5 years agoFix overread when decoding X509KeyUsage extension on Windows
Jeremy Barton [Mon, 24 Jun 2019 17:44:37 +0000 (10:44 -0700)]
Fix overread when decoding X509KeyUsage extension on Windows

CryptDecodeObject on X509_KEY_USAGE always sets cbStructInfo to 32 (or 20 on x86),
reporting 8 bytes (both architectures) more than needed for the CRYPT_BIT_BLOB
structure (0 bytes more than the structure when transporting pbData=NULL).

However, that value is over-representative of the number of bytes actually
written (modified) in this case.  The CRYPT_BIT_BLOB contains a cbData saying
how long the actual payload is (0 (pbData==NULL), 1, or 2 bytes), but
DecodeX509KeyUsageExtension didn't read it, just blindly read the value as a DWORD,
implicitly counting on the zero-init of arrays (and Win32's choice of values
combined with Little Endian layout).

By respecting the decoded cbData value (and not over-reading) the helper no
longer needs to manually clear the stackalloc.

Commit migrated from https://github.com/dotnet/corefx/commit/0a05173f98493547d40b1865808481e76ede1212

5 years agoHTTP2: Fix InboundWindowSize_Exceeded_Throw failure under load (dotnet/corefx#38736)
Cory Nelson [Mon, 24 Jun 2019 17:43:58 +0000 (10:43 -0700)]
HTTP2: Fix InboundWindowSize_Exceeded_Throw failure under load (dotnet/corefx#38736)

* Resolves dotnet/corefx#38708. Test tegression caused by different behavior under high load.

* Improve comment explaining inconsistency of exception source.

Commit migrated from https://github.com/dotnet/corefx/commit/6a81e6195005a9edb125d67e5865b1db1403838c

5 years agoRemove redundant tests and cleanup file (dotnet/corefx#38800)
Maryam Ariyan [Mon, 24 Jun 2019 17:43:13 +0000 (10:43 -0700)]
Remove redundant tests and cleanup file (dotnet/corefx#38800)

Commit migrated from https://github.com/dotnet/corefx/commit/b0c55b4aa644baa82f0f51b45bf3e5dc56a731ba

5 years agofollow up on duplex operation for HTTP/2 (dotnet/corefx#38226)
Tomas Weinfurt [Sun, 23 Jun 2019 21:42:52 +0000 (14:42 -0700)]
follow up on duplex operation for HTTP/2 (dotnet/corefx#38226)

* follow up on duplex operation

* updates

* add test for cancelation

* log responseHeadersTask if bodyTask fails first

* improve cancelation

* feedback from review

* update SendAsync_ConcurentSendReceive_Fail test

* feedback from review

* update SendSettingsAckAsync

* more HTTP/2 cancelation tests

* update test to accept any derivative from OperationCanceledException

* feedback from review

* roll-back changes in AcceptConnectionAsync

Commit migrated from https://github.com/dotnet/corefx/commit/cad5159981f518f455be3528d0ee8eca2e00742a

5 years agoUpdated SDK and cmake version
Viktor Hofer [Sun, 23 Jun 2019 19:44:44 +0000 (21:44 +0200)]
Updated SDK and cmake version

Commit migrated from https://github.com/dotnet/corefx/commit/4f54051ba4ceeb7ce5d05f5896378b2e8c293d2e

5 years agoFix SslStream client auth with intermediate certificates on Linux (dotnet/corefx...
David Shulman [Sun, 23 Jun 2019 04:12:35 +0000 (21:12 -0700)]
Fix SslStream client auth with intermediate certificates on Linux (dotnet/corefx#38789)

On Linux, a client TLS certificate chaining to multiple intermediate certificates wasn't
sending the complete list of intermediates because the final one in the chain wasn't
trusted. This differs from Windows behavior. This was causing the application to fail
to authenticate to the payment provider in the repro.

This PR fixes SslStream so that it will send the complete list of intermediates if the
chain build operation results in a "PartialChain" instead of a fully trusted chain.

Due to the complexity of this scenario, I didn't write a standalone CI test. But I was
able to run the original repro (using a docker container) to validate the fix.

Fixes dotnet/corefx#37927

Commit migrated from https://github.com/dotnet/corefx/commit/3b39190472c73ef0c4da485bfba0aa57f9ae3b37

5 years agoRemove Serialization Guard public APIs (dotnet/corefx#38739)
Levi Broderick [Sun, 23 Jun 2019 02:48:00 +0000 (19:48 -0700)]
Remove Serialization Guard public APIs (dotnet/corefx#38739)

* Remove Serialization Guard public APIs
- Also refactors reflection helpers into separate file

* PR feedback - remove DeserializationBlockedException refs entirely

Commit migrated from https://github.com/dotnet/corefx/commit/8b73a6dfacccefa8d160077ebff11007ff72fda3

5 years agoPrefer ILLinkTrim.xml over InternalsVisibleTo (System.Text.Encodings.Web) (dotnet...
Levi Broderick [Sun, 23 Jun 2019 00:19:02 +0000 (17:19 -0700)]
Prefer ILLinkTrim.xml over InternalsVisibleTo (System.Text.Encodings.Web) (dotnet/corefx#38787)

Commit migrated from https://github.com/dotnet/corefx/commit/22ce0f6e236001f8280c5f8639f546a301a89a6c

5 years agoFix helper thread stack size for Alpine (dotnet/corefx#38743)
Jan Vorlicek [Sat, 22 Jun 2019 22:06:44 +0000 (00:06 +0200)]
Fix helper thread stack size for Alpine (dotnet/corefx#38743)

* Fix helper thread stack size for Alpine

CoreFX creates a helper thread for handling some signals. This thread is
created using pthread API without explicit setting of stack size. That
means that on Alpine, it gets only 85kB of stack. We have hit stack
overflow in one of our coreclr tests in checked build due to that.

This change sets the default stack size of that thread to 512kB,
which should be sufficient.

* Make the stack size setting non-release build only

In release build, the stack is sufficient.
I've also spotted that in the previous commit, I've actually missed
passing the attributes to the pthread_create, so I am fixing that.

Commit migrated from https://github.com/dotnet/corefx/commit/627c1007a297e947962c2d5269dbe20063144fbf

5 years agoFix multiple remarks in System.Text.Json Xml docs (dotnet/corefx#38690)
Ganbarukamo41 [Sat, 22 Jun 2019 22:03:40 +0000 (07:03 +0900)]
Fix multiple remarks in System.Text.Json Xml docs (dotnet/corefx#38690)

* Fix multiple remarks in System.Text.Json Xml docs

* Remove unnecessary paragraph tags

* Use returns tag instead of remarks

Commit migrated from https://github.com/dotnet/corefx/commit/be73988bed4a904a3f1f66db752b6ae209ca28f1

5 years agoAdd support for NumericString to X500DistinguishedName
Jeremy Barton [Sat, 22 Jun 2019 03:59:30 +0000 (20:59 -0700)]
Add support for NumericString to X500DistinguishedName

An X500DN which contains a valid NumericString will now not cause the
entire string to turn into the empty string; which (per the tests) matches the
Windows/NetFX behavior.

Certificates with NumericString subjects do not load on macOS, because the OS considers them invalid.

Commit migrated from https://github.com/dotnet/corefx/commit/d7631df16a92da0e21bcb64240d5007f0dab95ed

5 years agoAdd UTF-8 support to TextEncoder (dotnet/corefx#38356)
Levi Broderick [Sat, 22 Jun 2019 03:38:05 +0000 (20:38 -0700)]
Add UTF-8 support to TextEncoder (dotnet/corefx#38356)

Commit migrated from https://github.com/dotnet/corefx/commit/9b486c1ea7bcfe7d09206ae449bffb049754ade5

5 years agoRevert "Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/coref...
David Shulman [Fri, 21 Jun 2019 23:51:34 +0000 (16:51 -0700)]
Revert "Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)" (dotnet/corefx#38764)

This reverts commit dotnet/corefx@3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4.

Commit migrated from https://github.com/dotnet/corefx/commit/42ecf717478504fd7cc072f3586c6edd1ba57daa

5 years agoSwitch from IndexOf(string) to Contains(string) for better readability and performanc...
Andrii Siriak [Fri, 21 Jun 2019 22:25:09 +0000 (01:25 +0300)]
Switch from IndexOf(string) to Contains(string) for better readability and performance (dotnet/corefx#38757)

* Fix performance IndexOf(string) -> Contains(string)

* Make comparison ordinal

Commit migrated from https://github.com/dotnet/corefx/commit/8e23fa839544c1d0c18e3f728b439bf66cf125f3

5 years agoFix nested objects in object arrays (dotnet/corefx#38527)
Jeremy Kuhne [Fri, 21 Jun 2019 21:48:31 +0000 (14:48 -0700)]
Fix nested objects in object arrays (dotnet/corefx#38527)

We weren't recognizing polymorphism for json objects nested in .NET object arrays.

This change also hides the debugger backing field for clarity.

Commit migrated from https://github.com/dotnet/corefx/commit/8be1263dc00a0ce14b5c2dfb4077d4a92cbf6d3b

5 years agoImprove code coverage: Struct, value type test (dotnet/corefx#38403)
buyaa-n [Fri, 21 Jun 2019 20:02:44 +0000 (13:02 -0700)]
Improve code coverage: Struct, value type test (dotnet/corefx#38403)

Code coverage: Struct, value type tests

Commit migrated from https://github.com/dotnet/corefx/commit/c181ec76bbaf2d85883bef1328a7f61e5cbf8016

5 years agoadd path to assert (dotnet/corefx#38709)
Dan Moseley [Fri, 21 Jun 2019 17:04:56 +0000 (10:04 -0700)]
add path to assert (dotnet/corefx#38709)

Commit migrated from https://github.com/dotnet/corefx/commit/adfa9d3fab65929262aa1419289794282de95b44

5 years agoAdd Activity.SetIdFormat (dotnet/corefx#38628)
Liudmila Molkova [Fri, 21 Jun 2019 16:54:13 +0000 (09:54 -0700)]
Add Activity.SetIdFormat  (dotnet/corefx#38628)

* Add Activity.SetIdFormat dotnet/corefx#36999

* separate individual tests and run ones that access statics in remote executor

* Exception messages to Resources

* Review comments

* Fix tests

Commit migrated from https://github.com/dotnet/corefx/commit/1fa8627a53115e5244e2f17310fb3b5b8685ec7a

5 years agoAdditional custom converter support for System.Object (dotnet/corefx#38741)
Steve Harter [Fri, 21 Jun 2019 16:38:20 +0000 (09:38 -0700)]
Additional custom converter support for System.Object (dotnet/corefx#38741)

Commit migrated from https://github.com/dotnet/corefx/commit/f3ee3e12107597b27e3be31b81732e266a1c60c5

5 years agoImprove comment explaining inconsistency of exception source.
Cory Nelson [Fri, 21 Jun 2019 16:31:41 +0000 (09:31 -0700)]
Improve comment explaining inconsistency of exception source.

Commit migrated from https://github.com/dotnet/corefx/commit/0f966e368fef859e578c55b45bbdd7539a42405d

5 years agoMerge pull request dotnet/corefx#38746 from imcarolwang/wcfissue3408
Stephen Bonikowsky [Fri, 21 Jun 2019 16:10:45 +0000 (09:10 -0700)]
Merge pull request dotnet/corefx#38746 from imcarolwang/wcfissue3408

Config ReaderQotas.MaxStringContentLength has no effect for some test…

Commit migrated from https://github.com/dotnet/corefx/commit/7f4bbeb0e21c55d489d848440d92d7ff93cffb0c

5 years agoAdd netcoreapp3.0 ref to System.IO.Pipelines package (dotnet/corefx#38731)
Jose Perez Rodriguez [Fri, 21 Jun 2019 16:03:48 +0000 (09:03 -0700)]
Add netcoreapp3.0 ref to System.IO.Pipelines package (dotnet/corefx#38731)

* Add netcoreapp3.0 ref to System.IO.Pipelines package

* Removing Exclude Compile from package dependencies

* Apply PR Feedback

* Move the import of the Packaging.targets

Commit migrated from https://github.com/dotnet/corefx/commit/df62e8f9110c263a69d491bf771c210860209d4c

5 years agoRegenerate ref assembly against implementation and add nullable annotations for Syste...
Santiago Fernandez Madero [Fri, 21 Jun 2019 07:16:04 +0000 (00:16 -0700)]
Regenerate ref assembly against implementation and add nullable annotations for System.Reflection.Primitives (dotnet/corefx#38517)

* Regenerate ref assembly against implementation

* Add nullable annotations to System.Reflection.Primitives

Commit migrated from https://github.com/dotnet/corefx/commit/e5aa6a5b6df5593e17b794dfcf5cf7ec87e9ef1d

5 years agoAdd nullable annotations to System.Diagnostics.StackTrace ref (dotnet/corefx#38428)
Santiago Fernandez Madero [Fri, 21 Jun 2019 06:05:24 +0000 (23:05 -0700)]
Add nullable annotations to System.Diagnostics.StackTrace ref (dotnet/corefx#38428)

* Add nullable annotations to System.Diagnostics.StackTrace ref

* Address nullable feedback from API Review

Commit migrated from https://github.com/dotnet/corefx/commit/f0b1b6ee70a36a13d097582bf7c982b7b9e8530d

5 years agoAdd nullable annotations to System.Diagnostics.Tracing ref (dotnet/corefx#38434)
Santiago Fernandez Madero [Fri, 21 Jun 2019 06:01:57 +0000 (23:01 -0700)]
Add nullable annotations to System.Diagnostics.Tracing ref (dotnet/corefx#38434)

* Add nullable annotations to System.Diagnostics.Tracing ref

* Address API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/96fe425e1ae8e16dcd726b6bea7bf4bd6295ba6c

5 years agoRegenerate ref assembly and add nullable annotations for System.Reflection.Emit.Light...
Santiago Fernandez Madero [Fri, 21 Jun 2019 04:45:36 +0000 (21:45 -0700)]
Regenerate ref assembly and add nullable annotations for System.Reflection.Emit.Lightweight (dotnet/corefx#38515)

* Regenerate ref assembly against implementation

* Add nullable attributes to System.Reflection.Emit.LightWeight ref

Commit migrated from https://github.com/dotnet/corefx/commit/32d256ed4bf4daeab4b6b866fdef9fe921c8aa5f

5 years agoConfig ReaderQotas.MaxStringContentLength has no effect for some test data on NetCore.
imcarolwang [Fri, 21 Jun 2019 04:22:36 +0000 (21:22 -0700)]
Config ReaderQotas.MaxStringContentLength has no effect for some test data on NetCore.

Commit migrated from https://github.com/dotnet/corefx/commit/1a36d8c5a33bb1d8288e4fcb765d1f1b2576bf5e

5 years agoFix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok (dotnet/corefx#38742)
Krzysztof Wicher [Fri, 21 Jun 2019 04:07:00 +0000 (21:07 -0700)]
Fix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok (dotnet/corefx#38742)

* PostAsyncExpect100Continue: Keep client alive until server finishes

* replace MRE with ShutdownIgnoringErrorsAsync

Commit migrated from https://github.com/dotnet/corefx/commit/bff9c7b2ac6b0608f555b0d4b82b5ffb983a8f2f

5 years agoFix for issue where iterating over directories ending in a dot would unexpectedly...
Carlos Sanchez Lopez [Fri, 21 Jun 2019 02:58:33 +0000 (19:58 -0700)]
Fix for issue where iterating over directories ending in a dot would unexpectedly throw (dotnet/corefx#38489)

Issue
In Windows, when iterating over the files of a directory whose name ends in a dot, the iteration fails by throwing an unexpected exception, even when using the proper prefix "\\?\" for the full directory path.

Fix
Add a new boolean argument at the end of the enumeration function signatures that will indicate if the passed path is normalized or not. If it is normalized (which only happens when the path is created by us, not by the user), then we can create the handle using that path. If it's not normalized, we attempt to get its full path before creating the handle, which will throw if a full path can't be obtained.

Added a new unit test to verify the fixed behavior and updated some others whose behavior changed with this fix.

Commit migrated from https://github.com/dotnet/corefx/commit/8e95261ef710e0df980a6d46923eb3c0e8b0bc83

5 years agoImprove AssertExtensions.Equal performance for large arrays (dotnet/corefx#38725)
Jan Kotas [Fri, 21 Jun 2019 01:37:04 +0000 (18:37 -0700)]
Improve AssertExtensions.Equal performance for large arrays (dotnet/corefx#38725)

Assert.Equals on arrays boxes each element and then performs a complex
operation to compare each box. This is slow for large arrays, and extremely
slow for large arrays on checked CoreCLR.

Use AssertExtensions.Equal for large arrays in File.Copy tests to make
them reasonably fast on checked CoreCLR.

Commit migrated from https://github.com/dotnet/corefx/commit/c53300f0696c4817bc06a8ef8711a0bb46f362ec

5 years agoFix factory converters used as attributes (dotnet/corefx#38740)
Jeremy Kuhne [Thu, 20 Jun 2019 23:50:02 +0000 (16:50 -0700)]
Fix factory converters used as attributes (dotnet/corefx#38740)

* Fix factory converters used as attributes

Need to unpack the type specific converter when associating directly with a property.

Add default constructor to StringEnum converter.

* Move the factory unpack per feedback

Commit migrated from https://github.com/dotnet/corefx/commit/c6c1890ecd8e258f4a6e97a94e23881ed7a88392

5 years agoAdd support for Uri to JsonSerializer (dotnet/corefx#38655)
Layomi Akinrinade [Thu, 20 Jun 2019 22:38:10 +0000 (18:38 -0400)]
Add support for Uri to JsonSerializer (dotnet/corefx#38655)

* Add support for Uri to JsonSerializer

* Address review feedback

* Original string -> ToString

Commit migrated from https://github.com/dotnet/corefx/commit/b2aee04410ad2f3d4cd372b84b74bb246cb04e7d

5 years agoAdd nullable annotations to System.Security.Principal ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:36:27 +0000 (15:36 -0700)]
Add nullable annotations to System.Security.Principal ref assembly (dotnet/corefx#38519)

Commit migrated from https://github.com/dotnet/corefx/commit/fb38d14bd501f05dbd2f8c3c85ac262b821d97ca

5 years agoRegenerate ref assembly and add nullable annotations to ref assembly for System.Text...
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:35:53 +0000 (15:35 -0700)]
Regenerate ref assembly and add nullable annotations to ref assembly for System.Text.Encoding.Extensions (dotnet/corefx#38520)

* Regenerate ref assembly against implementation

* Add nullable annotations to ref assembly

Commit migrated from https://github.com/dotnet/corefx/commit/1f4de5dff6dbfad36662af015142db5f6cb317f7

5 years agoUpdate StringTests for Span.ToLower/Upper with null culture (dotnet/corefx#38692)
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:18:57 +0000 (15:18 -0700)]
Update StringTests for Span.ToLower/Upper with null culture (dotnet/corefx#38692)

* Update StringTests for Span.ToLower/Upper with null culture

* Darc update for dotnet/coreclr from build 20190619.2

* Darc update for dotnet/coreclr from build 20190620.2

Commit migrated from https://github.com/dotnet/corefx/commit/149bde31df743ba2a3d79a1944de411a8016acb4

5 years agoAdding validation to ensure all runtime-only files are present on all runtime-specifi...
Jose Perez Rodriguez [Thu, 20 Jun 2019 20:20:10 +0000 (13:20 -0700)]
Adding validation to ensure all runtime-only files are present on all runtime-specific packages (dotnet/corefx#38730)

Commit migrated from https://github.com/dotnet/corefx/commit/f80d2324feaf77b902ea93d76a3aa5236b0e2f27

5 years agoAdding unit test to cover NullReferenceException when passing null to a collection...
David Cantu [Thu, 20 Jun 2019 20:12:18 +0000 (13:12 -0700)]
Adding unit test to cover NullReferenceException when passing null to a collection (dotnet/corefx#38566)

* Adding unit test to cover NullReferenceException when passing null to a collaction (issue dotnet/corefx#37078)

* Adding Peer Review suggestions.

* Splitting referece type and value type test scenarios into separate methods.

Commit migrated from https://github.com/dotnet/corefx/commit/e044c800294595ad3abc6b6f3b4ff739a5b3c83a

5 years agoString enum converter (dotnet/corefx#38702)
Jeremy Kuhne [Thu, 20 Jun 2019 19:07:20 +0000 (12:07 -0700)]
String enum converter (dotnet/corefx#38702)

* String enum converter

Adds public converter for converting enums to strings and vice-versa.

* Address feedback.

* Missing a readonly

* Fix exception and swtich to ConcurrentDictionary

* Merge fixup

Commit migrated from https://github.com/dotnet/corefx/commit/66a18944db6d64b67adb1320d41004a9140babc1

5 years agoResolves dotnet/corefx#38708. Test tegression caused by different behavior under...
Cory Nelson [Thu, 20 Jun 2019 18:31:31 +0000 (11:31 -0700)]
Resolves dotnet/corefx#38708. Test tegression caused by different behavior under high load.

Commit migrated from https://github.com/dotnet/corefx/commit/9182532968d95f74be7df222318e52cc0834553f

5 years ago Increase sample size of random number generation tests
Kevin Jones [Thu, 20 Jun 2019 18:25:09 +0000 (14:25 -0400)]
 Increase sample size of random number generation tests

Commit migrated from https://github.com/dotnet/corefx/commit/ddb08d9df0b6206833f5ba143403a0a52cca2f40

5 years agoImprove test coverage for Convert.FromBase64 (dotnet/corefx#38724)
Jan Kotas [Thu, 20 Jun 2019 18:15:44 +0000 (11:15 -0700)]
Improve test coverage for Convert.FromBase64 (dotnet/corefx#38724)

Commit migrated from https://github.com/dotnet/corefx/commit/707b15859af2fb23e17acfdc915d4cb5ee9112ad

5 years ago[Tests]: JsonSerializer.ToString serialization tests containing Enum (dotnet/corefx...
Maryam Ariyan [Thu, 20 Jun 2019 17:49:32 +0000 (10:49 -0700)]
[Tests]: JsonSerializer.ToString serialization tests containing Enum (dotnet/corefx#38531)

Commit migrated from https://github.com/dotnet/corefx/commit/046dbada036d786f420a7775ebcfd51a2a777add

5 years agosupporting duplicate using hashsets (dotnet/corefx#38705)
Anirudh Agnihotry [Thu, 20 Jun 2019 17:47:42 +0000 (10:47 -0700)]
supporting duplicate using hashsets (dotnet/corefx#38705)

Commit migrated from https://github.com/dotnet/corefx/commit/24e81ed6260fabf1211510a93c24385204f08323

5 years agoFix exception tests to match CoreCLR change (dotnet/corefx#38727)
Dan Moseley [Thu, 20 Jun 2019 17:21:08 +0000 (10:21 -0700)]
Fix exception tests to match CoreCLR change (dotnet/corefx#38727)

Commit migrated from https://github.com/dotnet/corefx/commit/41f0787f93d6c51baf3cd90b39b6e572ce5c6582

5 years agoSocket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)
Tom Deseyn [Thu, 20 Jun 2019 16:31:19 +0000 (18:31 +0200)]
Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)

* Socket: Linux: unblock synchronous socket operations on Dispose

* Fix windows build

* TryUnblockSocket: always do an abortive close for TCP

* TryUnblockSocket: experiment, always call Shutdown

* SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close

* Fix build

* Revert always shutdown to compare CI results

* PR feedback

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II

* Fix test

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III

* TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync

* Also perform abortive close when canceling async send/receive

* Fix aborted set to true

* Check what fails on OSX with Shutdown

* Revert "Check what fails on OSX with Shutdown"

This reverts commit dotnet/corefx@5ab7fce93c9f95a07ce8a1a3cdd3839ca4e6eb31.

* Don't perform abortive close for operations that were already canceled

* interrup  Accept/Listen on OSX

* Find out what Disconnectx does for different tests on CI machines

* Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX

* Trigger CI

* TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode

* TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx

* Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx"

This reverts commit dotnet/corefx@a8d5b02724d650866388b816cde58cb082a53d6e.

* TcpReceiveSendGetsCanceledByDispose: fix test for OSX

* call CancelIoEx to kick out pending operations

* Socket interop: replace IntPtr with SafeHandle

* Windows: RST close when operations were canceled

* Extend tests to check local SocketError

* test: update expected SocketErrors

* update tests: Apm API throws ObjectDisposedException instead of SocketException

* Extend asserts

* Update expected result for ConnectTask

* Update tests based on Windows behavior (https://github.com/dotnet/corefx/pull/37706)

* Map SocketErrors in Socket.cs

* Rewrite nullable asserts

* Fix test for Mac

* Handle SendFile SocketError

* SyncSendFileGetsCanceledByDispose: change how we generate the large file

* SyncSendFileGetsCanceledByDispose: ensure unique filename

* Fix NETFX build

* SyncSendFileGetsCanceledByDispose: skip on NetFramework

* PR feedback

* Fix broken build

* Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option

Commit migrated from https://github.com/dotnet/corefx/commit/3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4

5 years agoFix sequencing of MakeCommonResourcesPriFile (dotnet/corefx#38707)
Viktor Hofer [Thu, 20 Jun 2019 14:45:26 +0000 (16:45 +0200)]
Fix sequencing of MakeCommonResourcesPriFile (dotnet/corefx#38707)

* Fix sequencing of MakeCommonResourcesPriFile

* Disable pri file generation on allconfigs

* Disable testhost binplacing on allconfigurations

* Disable uap tool restore without testhost

* Manual darc update from build '20190421.1'

Commit migrated from https://github.com/dotnet/corefx/commit/375ba8f48581e36b02ee99691f55380bb42557c5

5 years agoEnforce JsonSerializerOptions.MaxDepth on write (dotnet/corefx#38706)
Steve Harter [Thu, 20 Jun 2019 14:41:49 +0000 (07:41 -0700)]
Enforce JsonSerializerOptions.MaxDepth on write (dotnet/corefx#38706)

Commit migrated from https://github.com/dotnet/corefx/commit/10a074131a98a41ee4542ac4ea7039f1f41b212b

5 years agoFix ipv6 address parsing with leading compressor (dotnet/corefx#38654)
Marco Rossignoli [Thu, 20 Jun 2019 14:24:33 +0000 (16:24 +0200)]
Fix ipv6 address parsing with leading compressor (dotnet/corefx#38654)

* fix ipv6 parse

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/600469a826ecd26ea5710847557819eff78e3759

5 years agoDisable SocketsHttpHandlerTest_Http2.InboundWindowSize_Exceeded_Throw (dotnet/corefx...
Eric StJohn [Thu, 20 Jun 2019 13:56:15 +0000 (06:56 -0700)]
Disable SocketsHttpHandlerTest_Http2.InboundWindowSize_Exceeded_Throw (dotnet/corefx#38722)

Test is consistently failing in CI.

Commit migrated from https://github.com/dotnet/corefx/commit/468355e66daf9eaeb1978703fa6365cd1e37e644

5 years agoupdates to packaging APIs and fixes (dotnet/corefx#38699)
Steven Kirbach [Thu, 20 Jun 2019 05:09:50 +0000 (22:09 -0700)]
updates to packaging APIs and fixes (dotnet/corefx#38699)

* updates to packaging APIs and fixes

* removing checks entirely and fixing tests

* removing newline

* skipping tests on desktop

Commit migrated from https://github.com/dotnet/corefx/commit/74032a608cf39d8eaa2955cc46d0ac677e3ae12c

5 years agoRemove extended option in System.Reflection.AssemblyNameTests.FullName (dotnet/corefx...
Ryan Lucia [Thu, 20 Jun 2019 03:18:55 +0000 (23:18 -0400)]
Remove extended option in System.Reflection.AssemblyNameTests.FullName (dotnet/corefx#38687)

* Remove extended option in System.Reflection.AssemblyNameTests.FullName

* Remove ToLowerInvariant calls

* Remove another ToLowerInvariant call

* Remove another 'extended' option

Commit migrated from https://github.com/dotnet/corefx/commit/6c95084f64df294b645729aea9934f72271292eb

5 years agoAdd nullable annotations to System.Diagnostics.Tools ref (dotnet/corefx#38432)
Santiago Fernandez Madero [Thu, 20 Jun 2019 02:43:27 +0000 (19:43 -0700)]
Add nullable annotations to System.Diagnostics.Tools ref (dotnet/corefx#38432)

Commit migrated from https://github.com/dotnet/corefx/commit/f99d24a5eef5aeaa897e62b471c1815ea0175b9e

5 years agoAdding New Idictionary tests and fixing test name and input for type Mismatch (dotnet...
Anirudh Agnihotry [Thu, 20 Jun 2019 02:23:25 +0000 (19:23 -0700)]
Adding New Idictionary tests and fixing test name and input for type Mismatch (dotnet/corefx#38660)

* Adding New Idictionary tests and fixing test name and inout for type mismatch

* Changing name of the variable

Commit migrated from https://github.com/dotnet/corefx/commit/36678a0eabe03d786a5f16563ee04abd4b640d24

5 years agoUpdate unix-instructions.md (dotnet/corefx#38703)
Dan Moseley [Thu, 20 Jun 2019 01:56:10 +0000 (18:56 -0700)]
Update unix-instructions.md (dotnet/corefx#38703)

* Update unix-instructions.md

* Update unix-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/055052f451d01c6f00209a682cac6f354caaa888

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38679)
dotnet-maestro[bot] [Thu, 20 Jun 2019 01:50:19 +0000 (01:50 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38679)

* Update dependencies from https://github.com/dotnet/coreclr build 20190618.4

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19318.4
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19318.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19318.4

* IndexOfAny ZeroLength values

* Test updates for relaxed Array.Copy type checks

Fixes dotnet/corefx#38535

Commit migrated from https://github.com/dotnet/corefx/commit/51a9c8f1dc56d366f5eb435f231052e2614c7a76

5 years agoAdd nullable annotations to System.Diagnostics.Debug ref (dotnet/corefx#38427)
Santiago Fernandez Madero [Thu, 20 Jun 2019 01:25:48 +0000 (18:25 -0700)]
Add nullable annotations to System.Diagnostics.Debug ref (dotnet/corefx#38427)

Commit migrated from https://github.com/dotnet/corefx/commit/8f98894f55cafc2f51adf40b380fcd194c596bb8

5 years agoAdd nullable annotations to System.Diagnostics.Contracts ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Thu, 20 Jun 2019 00:26:05 +0000 (17:26 -0700)]
Add nullable annotations to System.Diagnostics.Contracts ref assembly (dotnet/corefx#38288)

Commit migrated from https://github.com/dotnet/corefx/commit/eaa0079941923b4f903344130315f4cd332b84fe

5 years agoAdd additional deserialization array tests (dotnet/corefx#38693)
Steve Harter [Thu, 20 Jun 2019 00:15:39 +0000 (17:15 -0700)]
Add additional deserialization array tests (dotnet/corefx#38693)

Commit migrated from https://github.com/dotnet/corefx/commit/d612cbe52cd8213fb3f8141ca20b50fdf380b521

5 years agoAdd back KeyValuePair functionality (dotnet/corefx#38700)
Steve Harter [Wed, 19 Jun 2019 23:57:42 +0000 (16:57 -0700)]
Add back KeyValuePair functionality (dotnet/corefx#38700)

Commit migrated from https://github.com/dotnet/corefx/commit/98a5211f1e2b14ab42e52c28f9ca54d41d8e8751

5 years agoAdd test support for multiple connections in Http2 (dotnet/corefx#38561)
Krzysztof Wicher [Wed, 19 Jun 2019 23:34:29 +0000 (16:34 -0700)]
Add test support for multiple connections in Http2 (dotnet/corefx#38561)

* Add test support for multiple connections in Http2

* manual merge conflict fix, fix recently broken test (also in dotnet/corefx#38694)

Commit migrated from https://github.com/dotnet/corefx/commit/290a6e54a482ee950c4b812ad85f8de2d795932f

5 years agoUpdate sln configurations (dotnet/corefx#38698)
Viktor Hofer [Wed, 19 Jun 2019 21:28:19 +0000 (23:28 +0200)]
Update sln configurations (dotnet/corefx#38698)

Commit migrated from https://github.com/dotnet/corefx/commit/5ec88f81af71d253cfa74f9982abf748ccbd529b

5 years agoFix http2 tests (SettingsFrame does not propagate flags) (dotnet/corefx#38694)
Krzysztof Wicher [Wed, 19 Jun 2019 20:30:05 +0000 (13:30 -0700)]
Fix http2 tests (SettingsFrame does not propagate flags) (dotnet/corefx#38694)

Commit migrated from https://github.com/dotnet/corefx/commit/37a56121a88d8e67da75e2e5201f2c1c87c7b551

5 years agoCustom converter feature for JSON serializer (dotnet/corefx#38578)
Steve Harter [Wed, 19 Jun 2019 18:27:09 +0000 (11:27 -0700)]
Custom converter feature for JSON serializer (dotnet/corefx#38578)

Commit migrated from https://github.com/dotnet/corefx/commit/6b41813015ad0db7740523d65acfcd6a6d7b2df5

5 years agoDisable running tests on ilproj non test projects (dotnet/corefx#38680)
Viktor Hofer [Wed, 19 Jun 2019 17:40:49 +0000 (19:40 +0200)]
Disable running tests on ilproj non test projects (dotnet/corefx#38680)

Commit migrated from https://github.com/dotnet/corefx/commit/376408d6d3768660b7f9bc184c4d3b695221c37b

5 years agoAdd HTTP2 receive window size enforcement test. (dotnet/corefx#38623)
Cory Nelson [Wed, 19 Jun 2019 17:38:22 +0000 (10:38 -0700)]
Add HTTP2 receive window size enforcement test. (dotnet/corefx#38623)

* Add test for inbound window size enforcement. Resolves dotnet/corefx#35653.
* Correct timeout handling of Http2LoopbackServer.

Commit migrated from https://github.com/dotnet/corefx/commit/3863ec17c8ea61e72ef2240f23e4518788a2e8ae

5 years agoAdd nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref (dotnet...
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:32:59 +0000 (10:32 -0700)]
Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref (dotnet/corefx#38003)

* Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref

* Apply nullable attributes

Commit migrated from https://github.com/dotnet/corefx/commit/36ff261d4ec19933dde77c11c78256f62a5a4487

5 years agoAdd nullable annotations to System.Runtime.InteropServices ref assembly (dotnet/coref...
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:30:56 +0000 (10:30 -0700)]
Add nullable annotations to System.Runtime.InteropServices ref assembly (dotnet/corefx#37987)

* Add nullable annotations to System.Runtime.InteropServices ref assembly

* Add nullable attributes

* Address nullable feedback from API Review, object -> notnull constraint

Commit migrated from https://github.com/dotnet/corefx/commit/e1454c1aee299a4f96f718083c89f1b2b952f26c

5 years agoShrink System.Diagnostics.Activity by 40 bytes (dotnet/corefx#37395)
Ben Adams [Wed, 19 Jun 2019 14:21:25 +0000 (15:21 +0100)]
Shrink System.Diagnostics.Activity by 40 bytes (dotnet/corefx#37395)

* Shrink Activity

* fix threading issues

* Handle parsing issues

* Fix

Commit migrated from https://github.com/dotnet/corefx/commit/edc88b0fe55278ee43c821ab05707d8bb0befded

5 years agoGuard for large array support in System.Drawing.Common tests (dotnet/corefx#38672)
Filip Navara [Wed, 19 Jun 2019 10:32:08 +0000 (12:32 +0200)]
Guard for large array support in System.Drawing.Common tests (dotnet/corefx#38672)

Commit migrated from https://github.com/dotnet/corefx/commit/fd9801068f1baf8d69893da2a414eee7556e51b0

5 years agoAdd debugging info for sporadic Dns.GetHostEntry("") CI failures (dotnet/corefx#38665)
Stephen Toub [Wed, 19 Jun 2019 08:31:31 +0000 (04:31 -0400)]
Add debugging info for sporadic Dns.GetHostEntry("") CI failures (dotnet/corefx#38665)

Commit migrated from https://github.com/dotnet/corefx/commit/a3fc1b83b5f1d70d6b8529a9ec55178d959fa70d

5 years agoPort DynamicMetaObjectProviderDebugView (dotnet/corefx#38656)
Charles Stoner [Wed, 19 Jun 2019 08:26:05 +0000 (01:26 -0700)]
Port DynamicMetaObjectProviderDebugView (dotnet/corefx#38656)

* Port DynamicMetaObjectProviderDebugView

* Remove System.Diagnostics.CodeAnalysis.SuppressMessage attributes

* Add explicit private modifier

Commit migrated from https://github.com/dotnet/corefx/commit/af04307b356e38e2b74df1f05f735ebc462850da

5 years agowriting to too small buffer should throw an exception (dotnet/corefx#37661)
Adam Sitnik [Wed, 19 Jun 2019 08:06:28 +0000 (10:06 +0200)]
writing to too small buffer should throw an exception  (dotnet/corefx#37661)

fixes dotnet/corefx#35231

Commit migrated from https://github.com/dotnet/corefx/commit/721a570b005c53a839947603dcf76f8a3e5fc56a

5 years agoUpdate the PackageReferences for crypto OOBs in netstandard.depproj
Jeremy Barton [Wed, 19 Jun 2019 05:18:35 +0000 (22:18 -0700)]
Update the PackageReferences for crypto OOBs in netstandard.depproj

The 4.5.0 ref/netstandard2.0 had three properties declared get/set which were
actually get-only.  Updating the depproj version allows removal of the
ApiCompat errors in the shims.

While only 4.5.1 is required, the consensus was to just upgrade all of these
references to the latest versions.  Cng (4.5.0) is already at the newest.

Commit migrated from https://github.com/dotnet/corefx/commit/8b16e3ebf4f4c8be6ed6d744451c512a4d927750

5 years agoDisable InvokeOnEventsThreadRunsAsynchronously test on netfx (dotnet/corefx#38662)
Stephen Toub [Wed, 19 Jun 2019 02:25:24 +0000 (22:25 -0400)]
Disable InvokeOnEventsThreadRunsAsynchronously test on netfx (dotnet/corefx#38662)

And avoid the whole suite from hanging by changing an ~3hr timeout to a 30s timeout.

Commit migrated from https://github.com/dotnet/corefx/commit/818465ad8624c0231262dba6e7c3a0fc4ca42a7a

5 years agoAdd nullable annotations to System.Collections.Concurrent ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Wed, 19 Jun 2019 01:35:07 +0000 (18:35 -0700)]
Add nullable annotations to System.Collections.Concurrent ref assembly (dotnet/corefx#38189)

* Add nullable annotations to System.Collections.Concurrent ref assembly

* Re-run GenAPI after some attribute fixes

* Update attributes and object -> notnull constraint

Commit migrated from https://github.com/dotnet/corefx/commit/1494abacb0ec55e7065282311966b1c32329a1f5

5 years agoupdate system.transaction owner names (dotnet/corefx#38664)
Hong Li [Wed, 19 Jun 2019 00:34:13 +0000 (17:34 -0700)]
update system.transaction owner names (dotnet/corefx#38664)

Commit migrated from https://github.com/dotnet/corefx/commit/c0ed16860e62eea24620b7144ef72d5819ddb2b2

5 years agoAdd nullable annotations to System.Memory ref assembly (dotnet/corefx#38299)
Santiago Fernandez Madero [Tue, 18 Jun 2019 23:16:18 +0000 (16:16 -0700)]
Add nullable annotations to System.Memory ref assembly (dotnet/corefx#38299)

* Add nullable annotations to System.Memory ref assembly

* Nullable feedback

* Include where T inside pragma to be consistent with sources

* Make CultureInfo nullable in ToLower/Upper to match updates we did on String

* Revert comparer nullable change in BinarySearch per pr feedback in implementation

Commit migrated from https://github.com/dotnet/corefx/commit/ad961d0dc9d9054942c6a7e3a8c96c8684dd16cc

5 years agoAdapt existing HttpClientMiniStress tests to support HTTP/2 (dotnet/corefx#38619)
Stephen Toub [Tue, 18 Jun 2019 22:08:38 +0000 (18:08 -0400)]
Adapt existing HttpClientMiniStress tests to support HTTP/2 (dotnet/corefx#38619)

This adapts the existing HttpClientMiniStress tests to run with HTTP/2 as well as HTTP/1.1.  Some caveats, though:
- All of these existing tests spin up a new server per request, so they're not stressing arguably the most important aspect of the client's HTTP/2 implementation, that of sharing the single connection across all requests.  Our loopback server is not currently robust enough to handle concurrent requests; we should look at switching over to using Kestrel.
- The tests run really slowly, ~40x slower than for HTTP/1.1.  However, the HTTP/1.1 tests are non-SSL, these are of course SSL, and it looks like that's actually the difference.  In particular, something about how our test server gets its test certificate appears to be taking the vast majority of the time. (We should separately see if we could tweak that, not just for this purpose, but more so to help speed up the whole suite.)

Commit migrated from https://github.com/dotnet/corefx/commit/a7c893ab3d3e50b11c7fa2338882c8964e0a290d

5 years agoTry to make MonitoringIsEnabled more stable (dotnet/corefx#38651)
Stephen Toub [Tue, 18 Jun 2019 22:08:20 +0000 (18:08 -0400)]
Try to make MonitoringIsEnabled more stable (dotnet/corefx#38651)

Add a GC.Collect call to ensure the GC.GetMemoryInfo sees the object being kept alive.

Commit migrated from https://github.com/dotnet/corefx/commit/471edf259604905535f147ddfb2c8fe5a37ce81d

5 years agoFix GetLogInformation_UsingLogName_DoesNotThrow test (dotnet/corefx#38653)
Stephen Toub [Tue, 18 Jun 2019 22:06:45 +0000 (18:06 -0400)]
Fix GetLogInformation_UsingLogName_DoesNotThrow test (dotnet/corefx#38653)

The test was doing multiple reads from the underlying log and expecting them to be equivalent.  That's not guaranteed, as it's a global machine resource.

Commit migrated from https://github.com/dotnet/corefx/commit/475056abaaf3b1e9e29088c992157b415a800e54

5 years agoDisable System.Drawing.Common tests for RedHat6 (dotnet/corefx#38649)
Santiago Fernandez Madero [Tue, 18 Jun 2019 18:44:55 +0000 (11:44 -0700)]
Disable System.Drawing.Common tests for RedHat6 (dotnet/corefx#38649)

Commit migrated from https://github.com/dotnet/corefx/commit/a7e0c8d9e14a4f814a7e08ddfd0316353c37dd95

5 years agoremove active issues (dotnet/corefx#38411)
Marco Rossignoli [Tue, 18 Jun 2019 06:26:21 +0000 (08:26 +0200)]
remove active issues (dotnet/corefx#38411)

Commit migrated from https://github.com/dotnet/corefx/commit/1fca079ddec2aabf56e256dab03e39b31b5036c7

5 years agoFixed CaseSenstive Issues (dotnet/corefx#38532)
Erhan Atesoglu [Tue, 18 Jun 2019 05:32:43 +0000 (22:32 -0700)]
Fixed CaseSenstive Issues (dotnet/corefx#38532)

Commit migrated from https://github.com/dotnet/corefx/commit/dc9a0f2c5c3e1718a75a9ed508e8a06309c174fb

5 years agoAdd nullable annotations to System.Numerics.Vectors ref assembly (dotnet/corefx#38511)
Santiago Fernandez Madero [Tue, 18 Jun 2019 04:22:06 +0000 (21:22 -0700)]
Add nullable annotations to System.Numerics.Vectors ref assembly (dotnet/corefx#38511)

* Add nullable annotations to System.Numerics.Vectors ref assembly

* Fix various missing ? on ToString(string format)

Commit migrated from https://github.com/dotnet/corefx/commit/85a2e0c1a3eebf0c937d26de1aafe4e4687b2d4f

5 years agoAdd nullable annotations to System.Runtime.Loader ref (dotnet/corefx#38417)
Santiago Fernandez Madero [Tue, 18 Jun 2019 03:47:53 +0000 (20:47 -0700)]
Add nullable annotations to System.Runtime.Loader ref (dotnet/corefx#38417)

Commit migrated from https://github.com/dotnet/corefx/commit/753ae3bca0330fbf80cf20bed0a676d317eefa08

5 years agoHave consistent Dispose behaviors for AsymmetricAlgorithm objects
Jeremy Barton [Tue, 18 Jun 2019 01:25:56 +0000 (18:25 -0700)]
Have consistent Dispose behaviors for AsymmetricAlgorithm objects

The AsymmetricAlgorithm types weren't consistent in how they handled Dispose. There were four predominant behaviors on use-after-Dispose

* NullReferenceException (mainly from the OpenSsl implementations)
* Generate a new key, like the object was fresh (the public Cng implementations)
* Not notice that anything was Disposed, keep on keepin' on (the private Cng implementations in Algorithms)
* Indirect ObjectDisposedExceptions 95% of the time (the Windows CSP types)

This change makes all of the types consistently go into (and stay in) a Disposed state, throwing ObjectDisposedExceptions when asked to do work in that state.

Commit migrated from https://github.com/dotnet/corefx/commit/fb81332b9643ecf8c0bb34d7938da97aa5e13e03

5 years agoProviding support for duplicate keys in dictionary (dotnet/corefx#38524)
Anirudh Agnihotry [Mon, 17 Jun 2019 22:48:41 +0000 (15:48 -0700)]
Providing support for duplicate keys in dictionary (dotnet/corefx#38524)

* providing support for duplicate keys in dictionary

* Improving failure message

* fixing merge conflicts

Commit migrated from https://github.com/dotnet/corefx/commit/ef0578fd6abeba406ddffbb1591c1a618bca9dae

5 years agoRemove StructLayoutAttribute from GdipImageCodecInfo (dotnet/corefx#38607)
Santiago Fernandez Madero [Mon, 17 Jun 2019 21:52:19 +0000 (14:52 -0700)]
Remove StructLayoutAttribute from GdipImageCodecInfo (dotnet/corefx#38607)

* Remove StructLayoutAttribute from GdipImageCodecInfo

* PR Feedback

* Remove wrong comment

Commit migrated from https://github.com/dotnet/corefx/commit/422e295955841aa2d87d41812e7eef1a755f1e0e

5 years agoRemoving the Manual reference file from System.Text.Json (dotnet/corefx#38409)
Jose Perez Rodriguez [Mon, 17 Jun 2019 21:10:20 +0000 (14:10 -0700)]
Removing the Manual reference file from System.Text.Json (dotnet/corefx#38409)

* Removing the Manual reference file from System.Text.Json

* Readd the netcoreapp and uap configurations so that we don't have to bring AsyncInterfaces package into the shared framework closure

* Revert param name change as per PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5b3d41c1c63c4ebd93af7e6482e954e104827884

5 years agoAdd missing .ConfigureAwait(false) in HttpConnectionPool (dotnet/corefx#38610)
Stephen Toub [Mon, 17 Jun 2019 20:25:38 +0000 (16:25 -0400)]
Add missing .ConfigureAwait(false) in HttpConnectionPool (dotnet/corefx#38610)

Commit migrated from https://github.com/dotnet/corefx/commit/3b2707b4b672af99d9d7ac3d57352099f1ff3ff1

5 years agoChange DiagnosticsHandler to special-case base cancellation exception (dotnet/corefx...
Stephen Toub [Mon, 17 Jun 2019 20:25:23 +0000 (16:25 -0400)]
Change DiagnosticsHandler to special-case base cancellation exception (dotnet/corefx#38601)

It should be treating all OperationCanceledExceptions as cancellation, not just TaskCanceledException.

Commit migrated from https://github.com/dotnet/corefx/commit/dd6b0669bec5ac3b72b2b3a015f42c403c3ec0f1

5 years agoRe-generate System.Collections.Immutable ref assembly and fix a param name (dotnet...
Santiago Fernandez Madero [Mon, 17 Jun 2019 16:12:53 +0000 (09:12 -0700)]
Re-generate System.Collections.Immutable ref assembly and fix a param name (dotnet/corefx#38264)

* Re-generate System.Collections.Immutable ref assembly and fix a param name

* Use builder as the param name instead

Commit migrated from https://github.com/dotnet/corefx/commit/2e6661d4cceeff2549b0299ec54e9f3b34c09b20

5 years agoMerge pull request dotnet/corefx#38593 from ViktorHofer/YamlOfficialFix
Viktor Hofer [Mon, 17 Jun 2019 14:55:45 +0000 (16:55 +0200)]
Merge pull request dotnet/corefx#38593 from ViktorHofer/YamlOfficialFix

Fix leg configurations in official builds and converge redhat6 with linux

Commit migrated from https://github.com/dotnet/corefx/commit/c7178a34416ceb17240b9b3312a5740616555527