Jeremy Koritzinsky [Thu, 3 Aug 2023 18:50:08 +0000 (11:50 -0700)]
Add the interop tags to the "add to the AppModel project" automation (#89221)
Jan Vorlicek [Thu, 3 Aug 2023 18:36:16 +0000 (20:36 +0200)]
Fix isIPAdjusted setting during exception handling (#89930)
* Fix isIPAdjusted setting during exception handling
The CrawlFrame::isIPAdjusted flag is set to true for all frames
when handling software exceptions. That is not correct, as the IP is not
adjusted in those cases.
I've also cleaned up the values the flag is set to at various places to
use the real type of the member, which is `bool`. It was being set to
TRUE / FALSE or even 0 / 1 at some places.
As a related cleanup, I've removed the FRAME_ATTR_OUT_OF_LINE flag as it
was never set anywhere and still was being tested at few places.
* Add regression test
Tomas Weinfurt [Thu, 3 Aug 2023 18:13:59 +0000 (11:13 -0700)]
preserve TargetHostName even if we do not send it out via SNI (#89289)
* preserve TargetHostName even if we do not send it out via SNI
* Update src/libraries/System.Net.Security/src/System/Net/Security/Pal.OSX/SafeDeleteSslContext.cs
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
* quic
* test
---------
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Parker Bibus [Thu, 3 Aug 2023 17:40:54 +0000 (10:40 -0700)]
Remove any triggers. (#89947)
Eirik Tsarpalis [Thu, 3 Aug 2023 17:07:32 +0000 (20:07 +0300)]
Fix race condition in JsonSerializerOptions initialization. (#89935)
Anton Firszov [Thu, 3 Aug 2023 17:06:55 +0000 (19:06 +0200)]
Adjust System.Net.Http metrics (#89809)
Adjust System.Net.Http metrics naming and semantics according to the outcome of the discussion in lmolkova/semantic-conventions#1
dotnet-maestro[bot] [Thu, 3 Aug 2023 17:04:55 +0000 (19:04 +0200)]
[main] Update dependencies from dotnet/source-build-reference-packages dotnet/arcade dotnet/emsdk (#89858)
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230731.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23266.3 -> To Version 8.0.0-alpha.1.23381.3
* Update SourceBuildPrebuiltBaseline.xml
* Update dependencies from https://github.com/dotnet/arcade build
20230802.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23401.3 -> To Version 8.0.0-beta.23402.2
* Update dependencies from https://github.com/dotnet/emsdk build
20230802.3
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23401.2 -> To Version 8.0.0-rc.1.23402.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Michal Strehovský [Thu, 3 Aug 2023 16:40:02 +0000 (01:40 +0900)]
Trigger a rebuild if ILC command line changes (#89911)
Incremental build wouldn't consider things like `OptimizationPreference` property changing as a thing that should trigger a rebuild. I feel like this is more a MSBuild bug, but it has been like this for a long time.
Turns out we can use `WriteIlcRspFileForCompilation` target as a sentinel:
* Run the target always. We only actually write out the file if it's different (`WriteOnlyWhenDifferent` is already set to `true`).
* ILC execution already specifies the RSP as one of its inputs. So if the RSP is more recent than the output, it will trigger a build.
Fixes #88725.
Pavel Savara [Thu, 3 Aug 2023 16:04:57 +0000 (18:04 +0200)]
[browser] high level documentation of WASM features (#89469)
Co-authored-by: Katelyn Gadd <kg@luminance.org>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
dotnet-maestro[bot] [Thu, 3 Aug 2023 15:39:22 +0000 (10:39 -0500)]
[main] Update dependencies from dotnet/roslyn (#89903)
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23402.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23402.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230803.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23402.8 -> To Version 4.8.0-1.23403.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ankit Jain [Thu, 3 Aug 2023 15:32:07 +0000 (11:32 -0400)]
[wasm] WBT: Fix up AppTest tests to fix missed testing cases (#89833)
* [wasm] Update WBT AppTests to use the common infrastructure for building, and running apps
* [wasm] WasmApp.targets - add $(WasmAssemblyExtension)
* AppTests should respect UseWebcil
* Fix tests to work for no-webcil case
Tomas Weinfurt [Thu, 3 Aug 2023 14:53:17 +0000 (07:53 -0700)]
fix Accept assert (#89901)
Filip Navara [Thu, 3 Aug 2023 14:50:32 +0000 (16:50 +0200)]
[NativeAOT] macOS/iOS: Emit simple compact unwinding information (#88724)
* Generate compact unwind sequence for methods with frame and no saved registers
* Store prolog length in LSDA data when compact unwinding is used
* Remove prolog length, detect prologs from instruction stream
* Update comments
Matt Mitchell [Thu, 3 Aug 2023 14:00:30 +0000 (07:00 -0700)]
Tie llvm to emsdk's version (#89865)
* Tie llvm to emsdk's version
This avoids incoherency that will cause the .NET build drop to be too large to fit on the staging pipeline disk.
* Update to latest emsdk flow
---------
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Milena Hristova [Thu, 3 Aug 2023 13:41:35 +0000 (15:41 +0200)]
Remove duplicated argument (#89912)
Alexander Köplinger [Thu, 3 Aug 2023 13:25:55 +0000 (15:25 +0200)]
Disable failing outerloop tests and fix a build issue in MonoAOTCompiler (#89922)
See https://github.com/dotnet/runtime/issues/89921 for the test failures.
Additionally, the Android build was failing while compiling an AOT test due to this error:
```
/__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes]
void register_aot_modules ()
^
```
This is because we turned on `-Werror=missing-prototypes` in https://github.com/dotnet/runtime/pull/89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c
Fixes https://github.com/dotnet/runtime/issues/89566
Layomi Akinrinade [Thu, 3 Aug 2023 13:03:49 +0000 (06:03 -0700)]
Fix binder gen nullability issue wrt binding ref type members (#89900)
Steve Harter [Thu, 3 Aug 2023 12:31:31 +0000 (07:31 -0500)]
For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory (#89573)
Johan Lorensson [Thu, 3 Aug 2023 11:06:22 +0000 (13:06 +0200)]
[Mono] Fix deadlock during gcdump when using interp full AOT fallback. (#89726)
GC thread doing gcdump will dump the EventPipe events after world
has restarted but before releasing GC lock. There was one case
where we logged a bulk type during that face where a type didn't
have its finalizer data initialized and at the same time main thread
running interpreter held loader lock and tried to acquire GC lock,
that triggers a deadlock since the GC thread (still holding the GC lock)
would trigger logic to initialize the finalizer data, but that in turn
requires the GC lock.
Fix delays the fire of GC dump events until after we completed GC.
All GC dump events have been cached into a temp file and will be
written into EventPipe, the only potential issue with this is that
we keep vtable pointers in cache that will be resolved when emitting
EventPipe event, after releasing GC lock, but since we currently
won't unload vtables, that is not an issue, but needs to be addressed
if/when we implement ability to unload vtables. We would then need
to root the vtables while stored in temporary cache.
Commit also enable GC dump test on Mono platforms.
Jan Vorlicek [Thu, 3 Aug 2023 07:53:20 +0000 (09:53 +0200)]
Fix handling ThreadAbortException at the end of catch (#89781)
* Fix handling ThreadAbortException at the end of catch
After the catch handler for ThreadAbortException exits, the
exception needs to be rethrown immediatelly. This change
makes that work.
* arm64 stuff
* Enable arm
* Fix macOS x64 and enable one ControlledExecutionTest path for Unix
* Update src/coreclr/vm/amd64/redirectedhandledjitcase.S
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
* Fix macOS x64
The non-local label was preventing unwinding through \stub\()_RspAligned
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Jan Vorlicek [Thu, 3 Aug 2023 07:42:20 +0000 (09:42 +0200)]
Fix IsFixupPrecodeByASM and StubPrecode::IsStubPrecodeByASM (#89899)
These functions use memcmp that can internally be optimized
by vectorization. It can thus read more bytes than necessary
for the purpose of this function. In edge cases it can end up
reading from unmapped memory and crashing with access violation.
The fix is to compare the data byte by byte and early out as soon
as a mismatch is found.
Johan Lorensson [Thu, 3 Aug 2023 07:25:34 +0000 (09:25 +0200)]
Specify callback calling convention for callbacks on Windows x86 causes crashes on Mono. (#89571)
Fixes #88992. Explicit specify callback calling convention on Windows x86.
CoreCLR runtime build uses stdcall while Mono uses cdecl (default). If a native runtime function takes a reverse pivnoke callback, this difference will cause issues for Mono on Windows x86 since reverse pinvoke callbacks have stdcall on Windows x86, but callbacks have been prototyped to use the calling convention setup in build.
Since CoreCLR already uses stdcall on Windows x86 this change won't change anything, while on Mono it will fixes the crashes observed in #8892.
Levi Broderick [Thu, 3 Aug 2023 06:38:13 +0000 (23:38 -0700)]
Improve zlib defenses on mono (#89898)
- Mono defines HOST_WIN32, not CLR_CMAKE_HOST_WIN32
- Follow same pattern from src\native\eventpipe\CMakeLists.txt
Parker Bibus [Thu, 3 Aug 2023 05:48:11 +0000 (22:48 -0700)]
[PERF] Setup scheduled once a day runs rather than constant runs (#89884)
Ankit Jain [Thu, 3 Aug 2023 04:55:20 +0000 (00:55 -0400)]
[wasm] Fix condition to use latest chrome for testing (#89890)
* [wasm] Fix condition to use latest chrome for testing
* [wasm] CI: Trigger WBT on changes in ProvisioningVersions.props
* [wasm] runtime: Fix creating the stack trace for a ManagedError
With the latest chrome (`115.*`) the following code in
`runtime/marshal.ts` fails because `this.superStack.value` is no longer
available:
```js
getSuperStack() {
if (this.superStack) {
return this.superStack.value;
}
return super.stack; // this works on FF
}
```
This causes the final error to not have the original managed error
message, and also have a `"undefined"` at the end of the string.
Truncated error missing the native part of the stack, and the message:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_271731536(JSMarshalerArgument* __arguments_buffer)
undefined
```
With the fix:
```
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.ThrowFromJSExport(String message)
at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTestHelper.__Wrapper_ThrowFromJSExport_817705034(JSMarshalerArgument* __arguments_buffer)
Error: -t-e-s-t-
at sr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:33284)
at Br (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:42679)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:40825
at Module.catch1stack (http://127.0.0.1:60345/JavaScriptTestHelper.mjs:132:9)
at http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:36627
at mr (http://127.0.0.1:60345/_framework/dotnet.runtime.js:3:37821)
at do_icall (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[221]:0x19711)
at do_icall_wrapper (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[108]:0x157bc)
at mono_interp_exec_method (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[101]:0x9c92)
at interp_runtime_invoke (http://127.0.0.1:60345/_framework/dotnet.native.wasm:wasm-function[141]:0x16cd7)
```
Thanks to @kg for the fix.
Michal Strehovský [Thu, 3 Aug 2023 02:32:33 +0000 (11:32 +0900)]
Rebaseline failing pri0 tests (#89835)
* We don't throw PNSE for unguarded HW intrinsic use. We could translate illegal instruction to PNSE but it feels too big of a hammer. We could do something more sophisticated such as disassemble the instruction and compare with "known problematic" ones. But it doesn't feel worth the effort.
* Non-zero lower bounds are not supported.
* Corner case weird enums like `enum Foo : double { }` are not supported.
Michal Strehovský [Thu, 3 Aug 2023 02:10:29 +0000 (11:10 +0900)]
Escape both CR and LF in IL disassembler (#89886)
Noticed this because lines were off with `--ildump`.
Thays Grazia [Thu, 3 Aug 2023 02:02:27 +0000 (23:02 -0300)]
[wasm][debugger] Fix failed to fetch debugger MT tests (#89737)
* Run the tests in debug mode to get more information.
* Adding log messages
* Fix build
* Adding more messages
* Adding more logs
* Removing task.delay.
* Reducing maxParallelDownloads
* Adding more messages
* Fix compilation
* Trying to fix CI.
* Setting the maxParallelDownloads to 10.
Michal Strehovský [Thu, 3 Aug 2023 00:29:40 +0000 (09:29 +0900)]
Fix analysis issue in LDTOKEN dependencies (#89757)
This was found in Pri0 testing. The LDTOKEN data structures didn't have enough information for generic method instantiation arguments. The Pri0 test was around generic virtual methods, but this is a more general issue so adding an extra test for that.
I'm also changing how `NodeFactory.ReflectedMethod` works - it will now require being called with canonical things explicitly (and asserts if it isn't) instead of canonicalizing behind the scenes. This was obscuring the problem.
Mark Plesko [Thu, 3 Aug 2023 00:16:34 +0000 (17:16 -0700)]
Clarifications in botr gc section (#89888)
dotnet-maestro[bot] [Thu, 3 Aug 2023 00:08:17 +0000 (19:08 -0500)]
[main] Update dependencies from dotnet/roslyn (#89860)
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230802.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23401.10 -> To Version 4.8.0-1.23402.8
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Jackson Schuster [Wed, 2 Aug 2023 23:48:58 +0000 (16:48 -0700)]
[ComInterfaceGenerator] Guaranteed unmarshal before managed call in unmanaged to managed stubs (#89583)
Move guaranteed unmarshalling to the correct place in unmanaged to managed stucs
Thays Grazia [Wed, 2 Aug 2023 23:36:03 +0000 (20:36 -0300)]
Fixing side effect of 89741 (#89873)
Will Smith [Wed, 2 Aug 2023 22:42:15 +0000 (15:42 -0700)]
Create temp directory for SuperPMI JIT when running crossgen2 collections (#89875)
* Create a temporary directory for crossgen2 SuperPMI collections to hold a JIT binary
* Print superpmi jit path for logging purposes
* Added fallback
* Ignore cleanup errors
* Do not cleanup in handling an the exception
* Using existing temp location
* Feedback
* Remove extra logging
Jan Kotas [Wed, 2 Aug 2023 22:16:44 +0000 (15:16 -0700)]
Fix optimizations for comparers corner cases in native AOT (#89829)
Fixes #89767
Vladimir Sadov [Wed, 2 Aug 2023 22:10:25 +0000 (15:10 -0700)]
[NativeAOT] A few scalability fixes for the fat Lock (#88633)
Adeel Mujahid [Wed, 2 Aug 2023 22:07:56 +0000 (01:07 +0300)]
Add `CompressSymbols` opt-out option in NativeAOT (#85192)
* Add `CompressSymbols` opt-out option in NativeAOT
* Report what went wrong in dwarfdump test
* Update src/tests/nativeaot/SmokeTests/DwarfDump/Program.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Tanner Gooding [Wed, 2 Aug 2023 20:51:36 +0000 (13:51 -0700)]
Utilize the new `ref readonly` language feature (#89736)
* Updating the Roslyn toolset compiler to v4.8.0-1.23378.8
* Changing signatures from `in` to `ref readonly`
* Changing signatures from `ref` to `in`
* Changing signatures from `ref` to `ref readonly`
* Fix case missed for Unix build
* Ensure an xml comment works for .NET or .NET Framework
* Ensure tests properly handle `ref readonly` changes
Mike McLaughlin [Wed, 2 Aug 2023 20:04:48 +0000 (13:04 -0700)]
Fix DAC GetFlags() function for SOS (#89679)
Jackson Schuster [Wed, 2 Aug 2023 19:50:53 +0000 (12:50 -0700)]
Add test types (#89864)
Adds a number of test interfaces to ComInterfaceGenerator tests.
Eirik Tsarpalis [Wed, 2 Aug 2023 18:11:51 +0000 (21:11 +0300)]
Apply mitigations for a recent STJ performance regression (#89856)
Pavel Savara [Wed, 2 Aug 2023 17:17:58 +0000 (19:17 +0200)]
[browser] fix for delayed WS close event on NodeJs (#89847)
Pavel Savara [Wed, 2 Aug 2023 17:07:17 +0000 (19:07 +0200)]
remove active issue https://github.com/dotnet/runtime/issues/77334 (#89676)
Badre BSAILA [Wed, 2 Aug 2023 16:26:52 +0000 (18:26 +0200)]
Improve enum parsing in config binder generator (#89823)
Sven Boemer [Wed, 2 Aug 2023 16:23:16 +0000 (09:23 -0700)]
Update prepare-artifacts.proj (#89803)
* Update prepare-artifacts.proj
Don't pass AssetsTemporaryDirectory
* Remove TmpWorkingDir
And PublishingVersion, per PR feedback
dotnet-maestro[bot] [Wed, 2 Aug 2023 15:58:02 +0000 (17:58 +0200)]
[main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/arcade dotnet/xharness dotnet/runtime-assets dotnet/emsdk (#89810)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tarek Mahmoud Sayed [Wed, 2 Aug 2023 15:55:49 +0000 (08:55 -0700)]
Fix Globalization Invariant string comparisons with ordinal ignore casing (#89660)
dotnet-maestro[bot] [Wed, 2 Aug 2023 14:50:34 +0000 (07:50 -0700)]
[main] Update dependencies from dotnet/roslyn (#89593)
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230727.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23377.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230728.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23378.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230731.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23381.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.1
* Resolving new warnings around InlineArray
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230801.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23373.1 -> To Version 4.8.0-1.23401.10
* Suppress the new SizeConst warning for the MetadataLoadContext sample metadata
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Milena Hristova [Wed, 2 Aug 2023 14:13:15 +0000 (16:13 +0200)]
enable binskim scan (#89728)
Pavel Savara [Wed, 2 Aug 2023 09:25:27 +0000 (11:25 +0200)]
[browser] fix loading assets (#89687)
Ilona Tomkowicz [Wed, 2 Aug 2023 09:14:30 +0000 (11:14 +0200)]
[wasm] Assure name starts with `icudt` + fix testing scenario. (#89719)
* Asure name starts with `icudt` + fix full + custom ICU scenario.
* Feedback.
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
---------
Co-authored-by: Ankit Jain <radical@gmail.com>
Dong-Heon Jung [Wed, 2 Aug 2023 09:00:07 +0000 (18:00 +0900)]
[RISC-V][JIT] Fix assetion in System.Threading.LowLevelLifoSemaphore.Wait (#89826)
* [RISC-v][JIT] Update 4 bytes value in JCMP
* Fix some mistakes
Jakob Botsch Nielsen [Wed, 2 Aug 2023 08:53:18 +0000 (10:53 +0200)]
JIT: Consistently use '0x' as the hex specifier (#89773)
Fix #81329
Jakob Botsch Nielsen [Wed, 2 Aug 2023 08:39:05 +0000 (10:39 +0200)]
SPMI: Gracefully handle managed exceptions during replay (#89654)
Various JIT-EE APIs are expected to be able to throw exceptions, which SPMI will
record and rethrow during replay. This change makes us handle managed exception
that escapes from CILJit::compileMethod gracefully by not considering them as
replay failures.
The expectation is that an exception with this exception code will never be
thrown due to a JIT bug, and is always thrown as a result of a recorded
exception that the JIT itself did not want to handle.
Also do a small amount of cleanup for the EH in SPMI.
Johan Lorensson [Wed, 2 Aug 2023 08:37:52 +0000 (10:37 +0200)]
Align GetProcessinfo3 diagnostics command for MacCatalyst. (#89780)
Fixes #88325.
Johan Lorensson [Wed, 2 Aug 2023 07:21:09 +0000 (09:21 +0200)]
Fix iOS/Android sample diagnostics config (#89725)
Johan Lorensson [Wed, 2 Aug 2023 07:20:23 +0000 (09:20 +0200)]
Add more verification in EventPipe rundownvalidation test. (#89623)
Subtle changes like:
https://github.com/dotnet/runtime/commit/
2f2aaae4e4fc1c33d6a7db316fcc0cac4df7af3f
Knocked out a couple of rundown events on Mono that was detected and
fixed in https://github.com/dotnet/runtime/pull/88634.
It would been ideal to catch this issue as part of CI, but turns out
that our existing rundownvalidation test only tests a couple of rundown
events, and not any of the module/assembly events that was affected by
above change.
This commit adds validation that the following additional rundown events
are included in the rundown event stream:
RuntimeStart
MethodDCStopInit
MethodDCStopComplete
LoaderModuleDCStop
LoaderDomainModuleDCStop
LoadAssemblyDCStop
LoadAppDomainDCStop
Michal Strehovský [Wed, 2 Aug 2023 06:43:41 +0000 (15:43 +0900)]
Move SVM regression tests to a shorter path (#89838)
`C:\git\runtime\artifacts\tests\coreclr/obj/windows.x64.Checked/Managed/Loader\classloader\StaticVirtualMethods\RegressionTests\RecursiveConstraintOnDefaultImplementationOfStaticAbstractMember\RecursiveConstraintOnDefaultImplementationOfStaticAbstractMember.dll` crosses over `MAX_PATH` and something doesn't like that. I don't think `C:\git\runtime` is an unreasonably long prefix.
Michal Strehovský [Wed, 2 Aug 2023 06:06:53 +0000 (15:06 +0900)]
Add an option to run ILC with workstation GC (#89836)
This should help fixing "docker killing container due to memory use" woes.
We could consider dropping parallelism at MSBuild level instead, but this has less of a throughput impact.
Gérald Barré [Wed, 2 Aug 2023 06:02:55 +0000 (02:02 -0400)]
Add FileAttributes.None (#89130)
Radek Zikmund [Wed, 2 Aug 2023 05:49:29 +0000 (07:49 +0200)]
Change microsoft.com to www.github.com in test (#89792)
Kevin Jones [Wed, 2 Aug 2023 04:35:18 +0000 (00:35 -0400)]
Don't access AlgorithmGroup until necessary
Accessing CNG properties is relatively slow to a cryptographic operation itself. This avoids eagerly reading the AlgorithmGroup property.
Will Smith [Wed, 2 Aug 2023 03:46:02 +0000 (20:46 -0700)]
Make test `HugeField2` optimization sensitive for ARM32 to disable JitStress modes. Changed ARM32 assertion to a limitation error. (#89824)
Tomas Weinfurt [Wed, 2 Aug 2023 03:14:39 +0000 (20:14 -0700)]
avoid allocating SocketAddress GCHandle for every ReceiveFromAsync (#89808)
* avoid allocating GCHandle for ReceiveFromAsync
* feedback
Michal Strehovský [Wed, 2 Aug 2023 00:14:27 +0000 (09:14 +0900)]
Debloat serialization guard (#89706)
Use `UnsafeAccessor` instead of a delegate.
Shrinks the size of a `PublishAot` app that just `Process.Start`s a new process from 2.2 MB to 1.7 MB. It's still half a MB bigger than what I would expect but now it's `Process`'s fault (the `ToString()` brings some serious amount of garbage and we can't practically trim `ToString`).
Fixes #87470.
Thays Grazia [Wed, 2 Aug 2023 00:09:28 +0000 (21:09 -0300)]
[wasm][debugger] Do not pause on exceptions from our framework js files if JMC is enabled (#89741)
* avoid pausing on exceptions from framework js files if JMC is enabled
* using one if
* Fix test failure
Jackson Schuster [Tue, 1 Aug 2023 23:15:21 +0000 (16:15 -0700)]
Add Info warning for int return values (#89601)
Adds an 'info' level diagnostic if a GeneratedComInterface method returns int, enum, or a type name "HR" or "HResult" to tell the user that the generated code will put the managed return value as an 'out' parameter on the COM definition.
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
JoshLove-msft [Tue, 1 Aug 2023 23:09:27 +0000 (16:09 -0700)]
Add MediaType to BinaryData (#89605)
* Add BinaryData.ContentType
* PR fb
* Fix ctor formatting
* Add null validation for stream overloads
* Use Theory for tests
* More test updates
* couple more test cases for defaulting application/json
* more test clean up
---------
Co-authored-by: Alexander Radchenko <radchenkosasha@gmail.com>
Tanner Gooding [Tue, 1 Aug 2023 22:20:32 +0000 (15:20 -0700)]
Don't have getVectorTByteLength() return 0 for the time being (#89802)
Andy Ayers [Tue, 1 Aug 2023 22:15:25 +0000 (15:15 -0700)]
JIT: don't dead store OSR exposed locals (#89743)
The local var ref count for OSR locals can be misleading, since some
of the appearances may be in the "tier0" parts of the methods and
won't be visible once we trim the OSR method down to just the part
we're going to compile.
Fix by giving OSR-exposed locals an implicit ref count.
Fixes #89666.
Layomi Akinrinade [Tue, 1 Aug 2023 21:49:02 +0000 (14:49 -0700)]
Flow binder gen diag locations correctly & pick up more bind input patterns (#89537)
* Flow binder gen diag locations correctly & pick up more bind input patterns
* Fix CI issue
* Temporarily remove LOC failing on Build browser-wasm linux Release LibraryTests_EAT to unblock PR.
* Disable failing test for browser + reflection impl
Ivan Diaz Sanchez [Tue, 1 Aug 2023 21:14:54 +0000 (14:14 -0700)]
Remove Crossgen2's -O option in Test Builds Wherever Possible (#89223)
* Removed the Crossgen2 -O option from CLRTest.CrossGen.targets file.
* Removed the remaining Crossgen2-related -O's I could find. Not sure if
all of them should be removed though.
* Restored the ReadyToRunCompiler -O option because some NativeAOT tests
apparently are not happy without it.
* Restored crossgen-corelib.proj's -O because extra-platforms is still complaining.
* Restored the -O in a python script to see if Mono stops being an
annoying pain.
* Restored even the original change just to see whether there is
actually a problem with the extra-platforms, or they're just trolling
at this point.
* Removed the -O's from Crossgen2 again after discovering the
extra-platforms pipelines are super broken right now.
Jakob Botsch Nielsen [Tue, 1 Aug 2023 20:16:26 +0000 (22:16 +0200)]
Reenable Deserialize test for GCStress (#89770)
The issue was fixed by 30db9b7.
Miha Zupan [Tue, 1 Aug 2023 19:46:21 +0000 (21:46 +0200)]
Improve HTTP/2 MultipleConnectionsEnabled tests (#89788)
* Cleanup test helpers
* Temp
* Remove temporary test changes
Thays Grazia [Tue, 1 Aug 2023 18:19:36 +0000 (15:19 -0300)]
[wasm][debugger] Support NO_PROXY": "localhost" in launchSettings.json (#88884)
* bypass proxy for local addresses.
* Using @radical suggestion
* Support "NO_PROXY": "localhost" on launchSettings.json
* Fix null pointer exception
* Adding comment.
Jiri Cincura ↹ [Tue, 1 Aug 2023 17:28:09 +0000 (19:28 +0200)]
Longer timeouts for perf slow jobs (#89762)
Jeremy Koritzinsky [Tue, 1 Aug 2023 17:00:22 +0000 (10:00 -0700)]
Fix COM object leak (#89745)
Miha Zupan [Tue, 1 Aug 2023 16:27:17 +0000 (18:27 +0200)]
Fix ConnectCallback_UseNamedPipe_Success test (#89748)
* Fix ConnectCallback_UseNamedPipe_Success test
* Extend the test to HTTP 1
* Workaround HTTP/1 over TLS over NamedPipe issue
Filip Navara [Tue, 1 Aug 2023 16:23:37 +0000 (18:23 +0200)]
Add workaround for broken SPNEGO in IBM WebSphere (#89268)
dotnet-maestro[bot] [Tue, 1 Aug 2023 16:21:14 +0000 (11:21 -0500)]
[main] Update dependencies from dotnet/arcade dotnet/icu (#89772)
* Update dependencies from https://github.com/dotnet/arcade build
20230731.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23378.2 -> To Version 8.0.0-beta.23381.1
* Update dependencies from https://github.com/dotnet/icu build
20230731.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23377.1 -> To Version 8.0.0-rc.1.23381.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ankit Jain [Tue, 1 Aug 2023 16:19:18 +0000 (12:19 -0400)]
[wasm] CI: Add support for running WBT with multithreaded runtime installed too (#89611)
* [wasm] Rename GlobalizationMode.Default to GlobalizationMode.Sharded
.. to be similar to the values in `src/mono/wasm/runtime/dotnet.d.ts`.
The other values are not changed as the names in the tests map better to
the terms used in the build.
Based on feedback from @maraf .
* [wasm] WBT: Add BlazorRunOptions
* cleanup
* [wasm] WBT: Add $(PreparePackagesForWorkloadInstall) to control
.. preparing the required nugets for wbt
* Add new `mono.wasmworkload` subset
* [wasm] CI: rename wasm-build-tests.yml to simple-wasm-build-tests.yml
* CI: Add preBuildSteps parameter to global-build-job.yml
* [wasm] CI: Add support for building, and publishing from multiple wasm
.. jobs.
- `wasm-build-only.yml`:
- Use the new `mono.wasmworkload` subset to prepare some nugets
needed for WBT
- Build WBT, and generate the zip file, but don't generate the sdk
- After the build, run:
- `wasm-post-build-steps.yml` - Publishes the nugets, some tasks
needed for WBT job, and archive of `Wasm.Build.Tests`.
* [wasm] CI: Add support for running WBT with multiple runtime packs
This depends on two other builds:
1. A single threaded build run from wasm-build-only, which publishes
its nugets, and other artifacts.
2. A multi threaded build
The actual WBT job does not build anything now. Instead:
1. Downloads the artifacts from the two builds
2. Downloads Wasm.Build.Tests.zip
2. Sets up `artifacts/` to enable the steps below
3. Prepare the sdk for workload testing
4. Run the zip from (2) with sdk from (3).
* [wasm] WBT: Add a blazor test for multithreaded build
* [wasm] add WasmBuild.sln path for vscode workspace
* WBT: Condition the MT tests to run only when MT is available
.. and complain if it is not available on CI.
* Fix mt test runs with no workload, and local runs
Alexander Köplinger [Tue, 1 Aug 2023 16:17:05 +0000 (18:17 +0200)]
[mono] Enable sourcelink for native bits on MSVC (#89777)
Viktor Hofer [Tue, 1 Aug 2023 15:49:03 +0000 (17:49 +0200)]
Flow TasksConfiguration in build & specify generator config (#84931)
* Propagate TasksConfiguration when building tests
* Mark tasks projects as non-source projects and default to Release for CI/official builds(#84488)
* Update paths when copying to CORE_ROOT
* Flow TasksConfiguration in build & specify generator config
1. Flow the TasksConfiguration in the root build (Subsets.props)
2. Specify the LibrariesConfiguration explicitly when building the
LibraryImport source generators.
3. Set tasks configuration to debug by default.
* Include the Subsets.props change
* Update tasks.proj
---------
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Jiri Cincura ↹ [Tue, 1 Aug 2023 15:40:55 +0000 (17:40 +0200)]
Temporarily increase timeouts for perf jobs, because of limited capacity in "ubuntu.1804.amd64.tiger.perf" queue. (#89764)
Sven Boemer [Tue, 1 Aug 2023 15:31:20 +0000 (08:31 -0700)]
Use latest ILC to AOT-compile ILC (#89655)
We need to build with a recent enough ILC that has the fix from
b78345e5296c171dc3f43443a83dcf8df0800b83. This sets up a
dependency on the runtime -> runtime package flow to build using
the latest ILC package.
The macOS builds have been updated to machines with XCode 14 that
is required to link against nativeaot framework libraries that
were built using XCode 14 on the official build machines.
---------
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Shay Rojansky [Tue, 1 Aug 2023 15:06:41 +0000 (17:06 +0200)]
Add missing namespace to CreateParameter() (#89775)
Steve Harter [Tue, 1 Aug 2023 14:06:08 +0000 (09:06 -0500)]
Add [DebuggerGuidedStepThrough] to new invoker methods (#89596)
Zoltan Varga [Tue, 1 Aug 2023 13:51:02 +0000 (09:51 -0400)]
[mono] Fix more memory leaks in aot+interp mode. (#89580)
Shay Rojansky [Tue, 1 Aug 2023 12:06:41 +0000 (14:06 +0200)]
Add CreateParameter() to DbBatchCommand (#89503)
Closes #82326
Qiao Pengcheng [Tue, 1 Aug 2023 10:43:52 +0000 (18:43 +0800)]
[LoongArch64] fix the compiling errors by GCC. (#89753)
Meri Khamoyan [Tue, 1 Aug 2023 10:31:44 +0000 (14:31 +0400)]
[iOS] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString (#89296)
Implement missing locale properties for GlobalizationNative_GetLocaleInfoString
Jakob Botsch Nielsen [Tue, 1 Aug 2023 09:26:09 +0000 (11:26 +0200)]
JIT: Fix RBO introducing data races (#89710)
RBO cannot safely duplicate a GTF_GLOB_REF tree without additional
checks because this may introduce data races. To be able to duplicate
such a tree we need to verify that the local defined it is truly dead
after the transformation.
Fix #78713
Michal Strehovský [Tue, 1 Aug 2023 06:07:21 +0000 (15:07 +0900)]
Fix building with GVM_RESOLUTION_TRACE (#89758)
This got broken when we got rid of reflection blocking.
Tomas Weinfurt [Tue, 1 Aug 2023 05:49:38 +0000 (22:49 -0700)]
add SendTo/ReceiveFrom with SocketAddress (#88970)
* check
* update
* update
* set length
* feedback
* update to match approved API
* quic
* update
* fixes
* GetHashCode
* cleanup
* PalTests
* GetMaximumAddressSize
* wasi
* feedback
* feedback
* loose ends
* feedback
Sven Boemer [Tue, 1 Aug 2023 02:21:07 +0000 (19:21 -0700)]
Use live illink for trimming tests (#88929)
* Use live illink for trimming tests
Remove the PackageReference that was updated by dependency flow,
and replace it with an import of the live ILLink build props, overriding
the path to the ILLink.Tasks assembly.
Elinor Fung [Tue, 1 Aug 2023 01:45:55 +0000 (18:45 -0700)]
Stop using computed RID for RUNTIME_IDENTIFIER property (#89598)
Update the property to use the host RID instead of the computed current RID. This is in line with the .NET 8 change for selecting RID-specific assets using the host RID instead of a computed RID.
This also moves updates the shared helper to stop using the computed RID as the current RID - that is moved into the deps resolving, which needs it. Other places use the build-time RID.
This means that `RuntimeInformation.RuntimeIdentifier` (populated by the `RUNTIME_IDENTIFIER` property) will return the RID of platform for which the runtime is built, rather than a RID that is computed at runtime (or a fallback if it could not be computed). For example, for a portable build, on Windows 11, it will be win-x64 instead of win10-x64 or on Ubuntu 20.04 linux-x64 instead of ubuntu.20.04-x64.
Levi Broderick [Tue, 1 Aug 2023 00:22:20 +0000 (17:22 -0700)]
[Perf] Cache key size in CngKey (#89599)
Sven Boemer [Tue, 1 Aug 2023 00:01:20 +0000 (17:01 -0700)]
Add top level statement trimming tests (#89606)
This adds support for top-level statements to the
illink/nativeaot/trim-analyzer test infrastructure. Each file
with top-level statements gets compiled into its own testcase
assembly, which is placed into a subdirectory of the
Mono.Linker.Tests.Cases build output.
Will Smith [Mon, 31 Jul 2023 23:36:02 +0000 (16:36 -0700)]
Superpmi collect asyncio fix (#89663)
* Make a copy of 'clrjit' binary for use in SuperPMI collect to avoid heap errors when the same 'clrjit' binary is used
* Feedback
* Feedback
* Fixed asyncio get_running_loop error
Parker Bibus [Mon, 31 Jul 2023 22:18:32 +0000 (15:18 -0700)]
Remove now unnecessary fix for building perf tools. Cleaning up per: https://github.com/dotnet/performance/issues/3153. (#89738)