David Steele [Wed, 12 Jun 2024 10:47:03 +0000 (10:47 +0000)]
Merge changes Iaa1223c6,If1796779 into devel/master
* changes:
Move image/ text / npatch relative class under each visual folder
Use ProcessorOnce feature for some cases who only need process once
Eunki, Hong [Wed, 12 Jun 2024 06:03:38 +0000 (15:03 +0900)]
Move image/ text / npatch relative class under each visual folder
For example, npatch-loader only be used for npatch-helper and npatch-visual,
we don't need to keep it under 'visuals' folder directly.
Similarly, text-visual-shader-factory only be used at text-visual.
image-visual-shader used several visuals, but all of them are used for image,
so move them under image folder is not a bad job.
To make clear ownership of logic, let we move files into each folder.
Change-Id: Iaa1223c687425041a9a62e11792b0940ea8429cb
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Chihun Jeong [Wed, 12 Jun 2024 06:34:48 +0000 (06:34 +0000)]
Revert "Fix TextLabel's padding was not applied during Cutout."
This reverts commit
a0c9161fba687f3492678ada33761bd37a800210.
Reason for revert: Wrong merge
Change-Id: I648683aeb79e95a549840d84cd4a3d7ad6f3f68a
ANZ1217 [Wed, 12 Jun 2024 06:24:13 +0000 (15:24 +0900)]
Fix TextLabel's padding was not applied during Cutout.
Change-Id: Ie05f3c72359505269a19bfc97f9ac8e8098b9634
Eunki, Hong [Wed, 12 Jun 2024 05:37:47 +0000 (14:37 +0900)]
Use ProcessorOnce feature for some cases who only need process once
Now we allow to use ProcessorInterface execute only 1 times per each loop.
After use this feature, we don't need to unregister processor during processor
execute.
Change-Id: If1796779b8c76a06b500847406ec71d5a9f7ee7e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Seungho Baek [Mon, 10 Jun 2024 05:55:51 +0000 (14:55 +0900)]
Change precision of position related uniform of 3D shader to highp
Change-Id: I9d4d0afe93172113e7de03acdb54f6b0b1c37e5f
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Adeel Kazmi [Fri, 7 Jun 2024 17:26:13 +0000 (18:26 +0100)]
DALi Version 2.3.27
Change-Id: If5ae365861eac4a553b5ec49600a048fcc0b73b7
Adeel Kazmi [Fri, 31 May 2024 10:52:16 +0000 (10:52 +0000)]
Merge "DALi Version 2.3.26" into devel/master
Adeel Kazmi [Fri, 31 May 2024 10:45:28 +0000 (11:45 +0100)]
DALi Version 2.3.26
Change-Id: Ibba83c877cd952765fe31d4543a8e90b8de323e8
sunghyun kim [Fri, 31 May 2024 07:14:38 +0000 (07:14 +0000)]
Merge "Ignore FittingMode for text-visual" into devel/master
sunghyun kim [Fri, 31 May 2024 03:02:34 +0000 (12:02 +0900)]
Ignore FittingMode for text-visual
text visual use transformMap when it is scrolling.
To avoid this issue, i added this patch
Change-Id: Ief1e82a4d06fe62330272fd7d25ee90c37af6ef1
ANZ1217 [Thu, 30 May 2024 18:43:55 +0000 (03:43 +0900)]
Fix bug that DefaultFonts are infinitely cached
Change-Id: Ibef331df698cad816e6d4ac3cf64f1b85f33ce0b
Eunki Hong [Wed, 29 May 2024 09:27:35 +0000 (09:27 +0000)]
Merge changes Ic28f8ec1,If8d817c4 into devel/master
* changes:
Do not re-rasterize when visual size is floating point
Remove case divide by zero at fitting mode setup + Remove useless pixel area calculation
Eunki, Hong [Wed, 29 May 2024 06:46:55 +0000 (15:46 +0900)]
Do not re-rasterize when visual size is floating point
Since we request svg rasterize when size changed, and the size is floating value,
useless rasterization could be happened if visual size is not integer point.
To avoid this case, let we convert as integer scale before check re-rasterization.
Change-Id: Ic28f8ec10f2e4c3bca3bd2bc6eb4756a46ab9764
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 29 May 2024 06:31:33 +0000 (15:31 +0900)]
Remove case divide by zero at fitting mode setup + Remove useless pixel area calculation
It was possible that natural size is zero.
If so, we should not throw exception, and just calculate like size is zero.
And also, if we don't need to calculate pixel area size, we don't need to
do some float-division calculation.
Change-Id: If8d817c46425285e8fe7a6a2818696c3e79c064e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Seungho Baek [Tue, 30 Apr 2024 07:39:13 +0000 (16:39 +0900)]
Adds SceneView Capture
Change-Id: I9f6dc69f5bf8d53082997c089325398f1b95e10a
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Eunki Hong [Wed, 29 May 2024 04:01:34 +0000 (04:01 +0000)]
Merge changes I020eec7f,I173020e4,I60f63d55,I974a89fc into devel/master
* changes:
Support SVG / N_PATCH / Lottie even if we use AnimatedImageVisual
Make AnimatedImageVisual use single fixed image cache if it is not gif/webp + Fix several bugs at fixed image cache
Make option to create ImageVisual even if we use webp / gif
Allow to call Visual::Base::DoAction for public + Remove useless copy operation
sunghyun kim [Tue, 12 Mar 2024 10:06:42 +0000 (19:06 +0900)]
FittingMode Refactoring
1. Transfer the function implemented in ImageView to the control side
2. Reduce the desired calculation part implemented in the NUI ImageView side to dali.
3. Remove the part where the file was opened to obtain the original image size in the process
Change-Id: Ifbd260b14477c2f327b82b9310a084da689d06fd
Eunki, Hong [Tue, 28 May 2024 04:44:02 +0000 (13:44 +0900)]
Implement ProcessorOnce
Since unregister processor during Process will give overhead,
we'd better make another container to process only once time
during ProcessCoreEvent.
Change-Id: Iba6de22000328329b036018481b90f98a961d6b9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 17 May 2024 04:20:24 +0000 (13:20 +0900)]
Support SVG / N_PATCH / Lottie even if we use AnimatedImageVisual
Let we allow to choose given special visuals even if we use AnimatedImageVisual forcibly.
Change-Id: I020eec7f3e07bd93d55ddad00d8f7241025359ba
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 16 May 2024 07:50:39 +0000 (16:50 +0900)]
Make AnimatedImageVisual use single fixed image cache if it is not gif/webp + Fix several bugs at fixed image cache
It is possible that mImageCache is NULL if url suffix is not gif or webp.
In this case, mImageCache become null, so we should show broken image.
But also, we 'might' need to show non-animatable image even if we use
non-animatable image (like jpg), and set it to animated image visual forcibly.
To resolve general cases, let we make AnimatedImageVisual with non-animatable format image
just use image sequence with length 1.
===
Also, there was several bugs when we use fixed image cache, with cached texture manager image.
Before, we don't consider full-scenario when LoadComplete callback comes
during TextureManager.Load.
Change-Id: I173020e42d6447ff43e56e19f25ea8e06c7bbfc1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 15 May 2024 23:31:03 +0000 (08:31 +0900)]
Make option to create ImageVisual even if we use webp / gif
Let we make some way to use ImageVisual forcibly even if url suffix is animated.
Change-Id: I60f63d55c386e64c82b41d74632af2889e2cb707
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 14 May 2024 12:44:30 +0000 (21:44 +0900)]
Allow to call Visual::Base::DoAction for public + Remove useless copy operation
Let we allow to call DoAction by action-id for public, not only for internal.
And also, let we remove copy operation when we call DoAction to visual.
Change-Id: I974a89fc9a0749ee34de8a3f2f173330b6ddd281
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Richard Huang [Fri, 24 May 2024 11:33:21 +0000 (12:33 +0100)]
DALi Version 2.3.25
Change-Id: I5c049d3c42d6302006bde9770fbe9daf368310fd
Eunki, Hong [Thu, 23 May 2024 08:52:00 +0000 (17:52 +0900)]
Control core policy as one flag
Let we collect core creation status, instead of parameter increasement.
It will be useful when we add more features of Core.
Change-Id: Ic2e90a2ddd5ee8b8531c67a05d081f1f18e914b0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 22 May 2024 12:43:07 +0000 (12:43 +0000)]
Merge "Do not throw exception when facial image file is invalid." into devel/master
Chihun Jeong [Wed, 22 May 2024 06:03:44 +0000 (06:03 +0000)]
Merge "Blending algorithm optimized when cutout" into devel/master
ANZ1217 [Tue, 21 May 2024 10:14:15 +0000 (19:14 +0900)]
Blending algorithm optimized when cutout
Change-Id: Ice2f96bdd96d721fde00063ca22fcc42efb79e4a
Eunki, Hong [Tue, 21 May 2024 04:30:41 +0000 (13:30 +0900)]
Do not throw exception when facial image file is invalid.
Let we do not throw exception if facial animation file is invalid.
Instead, just return empty animation data.
Change-Id: I16b464f73db44c6653a9d2145630d0891731ee25
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Mon, 20 May 2024 16:08:17 +0000 (17:08 +0100)]
Fix coverity error in shader-generator
Change-Id: Iebff30df062f13b2ef263a10c53c0f393d9d3545
Adam Bialogonski [Mon, 20 May 2024 10:01:17 +0000 (11:01 +0100)]
Fixed signed/unsigned comparison
Change-Id: Icc5e4c3547458d230bf90ca814c204d99c8d51bc
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
sunghyun kim [Mon, 20 May 2024 01:22:01 +0000 (01:22 +0000)]
Merge "Adding a Property for ImageView's Transition Effect Setting" into devel/master
David Steele [Fri, 17 May 2024 11:11:10 +0000 (12:11 +0100)]
DALi Version 2.3.24
Change-Id: I6b0ebf6165d96c36acfa39bc332d8fee76326738
sunghyun kim [Thu, 9 May 2024 05:12:06 +0000 (14:12 +0900)]
Adding a Property for ImageView's Transition Effect Setting
Adding a new property specifically designed for ImageView's transition effect settings.
With this feature, users will have greater control over how images are displayed and animated within our app.
Change-Id: Id53f5b0c9887c8a652cc0d64e715e9c0fd8df887
Adeel Kazmi [Mon, 13 May 2024 16:12:55 +0000 (17:12 +0100)]
(shader-generator) Only generate shaders if input shader has changed/added
Change-Id: Ic165328a6e32876436220a2ebe3fe2356267e3cc
Eunki Hong [Tue, 14 May 2024 12:14:45 +0000 (12:14 +0000)]
Merge "Fix svace issue (std::string::size_type might not 32bit)" into devel/master
Eunki Hong [Tue, 14 May 2024 12:14:35 +0000 (12:14 +0000)]
Merge "Fix svace issue (Setup initialize values for GlyphRun and LineRun struct)" into devel/master
Bowon Ryu [Tue, 14 May 2024 09:34:00 +0000 (09:34 +0000)]
Merge "Change the precision of position in text atlas shader" into devel/master
Eunki, Hong [Tue, 14 May 2024 05:33:51 +0000 (14:33 +0900)]
Fix svace issue (Setup initialize values for GlyphRun and LineRun struct)
Change-Id: Ib1fc67360b9b5990e417273c69f6115455a9cdf4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 14 May 2024 05:47:43 +0000 (14:47 +0900)]
Fix svace issue (std::string::size_type might not 32bit)
Change-Id: I19666cf46c41ca957ca9798e201cc47c21caf3c9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Tue, 14 May 2024 06:35:23 +0000 (15:35 +0900)]
Change the precision of position in text atlas shader
There are some visual artifact when too many glyhps in editable text.
Change mediump to highp to fix issue.
Change-Id: I0f89447160f6bce0107c6ae5de5efeb9b4436afc
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
ANZ1217 [Mon, 13 May 2024 10:14:45 +0000 (19:14 +0900)]
Fix vertical position error when cutout enabled.
Change-Id: I611529b2540a8aaabe008c188cc18fcc6b8a613e
Chihun Jeong [Mon, 13 May 2024 09:55:11 +0000 (09:55 +0000)]
Merge "Introduce CUTOUT Property" into devel/master
Adeel Kazmi [Fri, 10 May 2024 11:16:02 +0000 (11:16 +0000)]
Merge "DALi Version 2.3.23" into devel/master
Adeel Kazmi [Fri, 10 May 2024 10:02:18 +0000 (11:02 +0100)]
DALi Version 2.3.23
Change-Id: I7618b7ecdcf0b905a1b7068e3bc9a1d517d88acd
ANZ1217 [Tue, 2 Apr 2024 10:49:46 +0000 (19:49 +0900)]
Introduce CUTOUT Property
Change-Id: I195f3cb85415ec957b600c52080c02dcaca8020a
Seungho Baek [Thu, 9 May 2024 02:52:35 +0000 (11:52 +0900)]
Returns -1 for frameCount before until animated image loading finished.
Change-Id: I368d076116b8e9716d2b3ce0f64a42c559585823
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
David Steele [Wed, 8 May 2024 12:46:02 +0000 (12:46 +0000)]
Merge "Make depth-index as 'AUTO' instead of CONTENT change as default, and clamp depth-index" into devel/master
Eunki, Hong [Wed, 8 May 2024 07:53:45 +0000 (16:53 +0900)]
Fix ShadowMap doesn't apply blendshape
There was some issue that blendshape with position doesn't works well
when we use shadow.
Change-Id: I9278a02229ef2701c7e0cf3313b06f5cab51a833
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 3 May 2024 09:07:30 +0000 (09:07 +0000)]
Merge "DALi Version 2.3.22" into devel/master
Adam Bialogonski [Fri, 3 May 2024 08:26:51 +0000 (09:26 +0100)]
DALi Version 2.3.22
Change-Id: I6bd823f92057b56174cae0a6425b7a14a6424602
Eunki, Hong [Tue, 16 Apr 2024 04:14:49 +0000 (13:14 +0900)]
Make depth-index as 'AUTO' instead of CONTENT change as default, and clamp depth-index
Let we set depth index as auto if user doesn't set visual's depth index.
Previously we use same behavior if user doesn't set, or user set depth index as CONTENT.
So if user set as 0, it might not works well.
To avoid this confuse logic, let we seperate whether user didn't set the property or not.
Furthermore, let we hard-clamp the range of DepthIndex for VisualBase.
The case of AUTO_INDEX is only for special cases, and otherwise, let we use normal values
what user set.
---
We allow to use RegisterVisual use depth-index as AUTO_INDEX. If this case, it will works
like what we don't set the depth index.
Change-Id: If19b0757b5e27e0a94a37fc8bc0f57c6824d0b16
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 3 May 2024 06:33:58 +0000 (06:33 +0000)]
Merge "Do not remove-and-add default renderer if text-visual relayout" into devel/master
Seungho BAEK [Fri, 3 May 2024 05:09:42 +0000 (05:09 +0000)]
Merge "Let we use OrderedSet for VectorAnimationManager / SceneView" into devel/master
Eunki, Hong [Fri, 3 May 2024 04:53:04 +0000 (13:53 +0900)]
Do not remove-and-add default renderer if text-visual relayout
We don't need to remove and re-add the renderer.
AddRenderer / RemoveRenderer send some messages to UpdateRender thread.
After this patch, we can reduce those useless messages.
Change-Id: Ifd7eadee1e7f9739ef23c4bbbca027758253e385
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Thu, 2 May 2024 10:56:14 +0000 (19:56 +0900)]
Add blur radius to text outline
it uses the same Gaussian blur as the text shadow.
Change-Id: I3b7d7534c68cfae5de55747158b4f74ffcaa2e88
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Tue, 30 Apr 2024 01:56:04 +0000 (10:56 +0900)]
Fix text autoscroll multi line issue
This patch fixes issues that arise when relayout is executed during auto-scrolling.
- relayout not executed after the scroll finish callback
- stop scrolling fails in certain situations in finish loop mode
- scroll finish being called twice during immediate mode stop
Change-Id: Ib44883380a79ad13c576d18c11171ae9f1f670c3
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Seungho BAEK [Mon, 29 Apr 2024 07:18:27 +0000 (07:18 +0000)]
Merge "Change to use InheritedVisibilityChangedSignal" into devel/master
Eunki, Hong [Thu, 18 Apr 2024 08:20:54 +0000 (17:20 +0900)]
Let we use OrderedSet for VectorAnimationManager / SceneView
Some containers that triggered only one times could be optimized by OrderedSet feature.
Let we make Add/Remove time faster.
Change-Id: I3a4864a6e76671fa89f851b3b4382e74893ba130
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Mon, 29 Apr 2024 01:18:40 +0000 (01:18 +0000)]
Merge "Add offset to text outline" into devel/master
Bowon Ryu [Thu, 25 Apr 2024 11:28:13 +0000 (20:28 +0900)]
Add offset to text outline
Change-Id: I280ed148384325cfa83e2d48fae15a387bc81fcd
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Richard Huang [Fri, 26 Apr 2024 09:42:59 +0000 (10:42 +0100)]
DALi Version 2.3.21
Change-Id: Iee3f73027b8d239c187ed2aef18c7fa1501188aa
Seungho Baek [Wed, 24 Apr 2024 09:19:57 +0000 (18:19 +0900)]
Change to use InheritedVisibilityChangedSignal
- instead of VisibilityChangedSignal to control Play and Pause.
Change-Id: Ic98abd6f5cddd68a1cfc18b4df351b11e6e91936
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Adam Bialogonski [Tue, 23 Apr 2024 08:16:51 +0000 (09:16 +0100)]
Fixes analysis hub issues
Change-Id: I1b55b6d635bec59ecf843fc56574044a2ccfcbab
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Lukasz Oleksak [Mon, 22 Apr 2024 12:22:33 +0000 (12:22 +0000)]
Merge "[AT-SPI] Use Accessible::IsHighlighted()" into devel/master
Chihun Jeong [Mon, 22 Apr 2024 09:02:42 +0000 (09:02 +0000)]
Merge "Add INSET Property to TextField and TextEditor" into devel/master
ANZ1217 [Mon, 22 Apr 2024 03:53:20 +0000 (12:53 +0900)]
Add INSET Property to TextField and TextEditor
Add the REMOVE_FRONT_INSET and REMOVE_BACK_INSET properties
to TextField and TextEditor as well, which were in TextLabel.
Change-Id: Ie5a417f22fb24423fde139e57c078dc45337099f
Bowon Ryu [Mon, 22 Apr 2024 05:07:12 +0000 (05:07 +0000)]
Merge "Text controller checks data type of the clipboard" into devel/master
Bowon Ryu [Thu, 18 Apr 2024 07:46:55 +0000 (16:46 +0900)]
Text controller checks data type of the clipboard
IsClipboardEmpty works meaningfully.
Temporary code has been applied to paste html type.
Once multiple types and data can be stored in the clipboard, this code should be removed.
Change-Id: I29b279acf19dd1c3397568b55e0567d314c41990
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Thu, 18 Apr 2024 09:02:25 +0000 (18:02 +0900)]
Do not create unneccessary sampler
We can 'skip' sampler for TextureSet if we want to use default wrap mode.
So usual cases, we don't need to create and set Sampler objects.
Change-Id: Ic1d0cf21d80e62f5bdf8209402e2a3a4612bd598
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 20 Apr 2024 07:46:13 +0000 (07:46 +0000)]
Merge "Remove TextureManager / VectorAnimationManaver lifecycle observing" into devel/master
Eunki Hong [Sat, 20 Apr 2024 07:44:15 +0000 (07:44 +0000)]
Merge "Less call mAnimatedImageLoading.GetImageCount() who might load file synchronously" into devel/master
David Steele [Fri, 19 Apr 2024 09:47:18 +0000 (10:47 +0100)]
DALi Version 2.3.20
Change-Id: If3d8b1e01d9c5a1c9061b59be05c05f52c47064c
Eunki, Hong [Fri, 19 Apr 2024 07:43:38 +0000 (16:43 +0900)]
Remove TextureManager / VectorAnimationManaver lifecycle observing
Since we can use Dali::Adaptor::IsAvailable(), we don't need to check
whether manager itself is alive or not.
Since both of them are member value of VisualFactoryCache, and VisualFactory
is singletone class what will be destructed at Adaptor stop timing,
Dali::Adaptor::IsAvailabe() is enough.
Add/Remove observer will give some overhead for usual cases.
So just remove it, and check adaptor vailables intead.
Change-Id: Ib26df2d607d2871626cda956d86524f74afd424b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 19 Apr 2024 04:14:36 +0000 (13:14 +0900)]
Less call mAnimatedImageLoading.GetImageCount() who might load file synchronously
Since AnimatedImageLoading might not load imagefile if we use
cached texture.
In this case, If we try to call 'GetImageCount()' or similar API, it will
try to load file synchronously, what user never notify.
For example, when we call DoCreatePropertyMap, it will call that API
what we can use some other cached value.
Change-Id: I77d30b985efd86d09663dfd51e885ba6227adbc9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Artur Świgoń [Thu, 18 Apr 2024 09:28:12 +0000 (11:28 +0200)]
[AT-SPI] Use Accessible::IsHighlighted()
This helper allows to simplify multiple comparisons of Self() to
GetCurrentlyHighlightedActor() to simply checking IsHighlighted().
Some new usages of IsHighlighted() are also introduced before event
emission in order to reduce D-Bus traffic.
Change-Id: I5d8906db22c84764de3e8df631df4d4cf8062c2f
Seungho Baek [Wed, 17 Apr 2024 12:48:50 +0000 (21:48 +0900)]
Disconnect DevelWindow::VisibilityChangedSignal when off scene
Change-Id: I0b7faee8af24b04a496c4f5695767b454493fce6
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Eunki Hong [Wed, 17 Apr 2024 06:36:26 +0000 (06:36 +0000)]
Merge "Remove BaseHandle / BaseObject TypeTraits is trivialgit" into devel/master
Eunki Hong [Wed, 17 Apr 2024 06:11:19 +0000 (06:11 +0000)]
Merge "Fix potential of UTC fail after notify patch merged" into devel/master
Eunki, Hong [Tue, 16 Apr 2024 01:44:15 +0000 (10:44 +0900)]
Reduce the number of UpdateOnce call after rasterization
Previous code request UpdateOnce by each visuals.
But this don't need to spend the number of requests.
So let we just use only one single request API for it.
Change-Id: I5b11ee7ad19dc7c32945c0cfc637f7c65cfe3a77
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 13 Apr 2024 16:49:27 +0000 (01:49 +0900)]
Fix potential of UTC fail after notify patch merged
A lots of vector animated image visual UTC failed due to 'ForceRenderOnce' required event thread trigger.
Since force render once might execute with 'load complete' or 'animation finished' signal,
Several UTC might not synchronized.
Let we change those cases and now works well anyway.
List of UTC failed:
Test case UtcDaliAnimatedVectorImageVisualGetPropertyMap01 failed: 1
Test case UtcDaliVisualFactoryGetAnimatedVectorImageVisual03 failed: 1
Test case UtcDaliVisualFactoryGetAnimatedVectorImageVisual04 failed: 1
Test case UtcDaliAnimatedVectorImageVisualPlayRange failed: 1
Test case UtcDaliAnimatedVectorImageVisualUpdateProperty failed: 1
Test case UtcDaliAnimatedVectorImageVisualNotifyAfterRasterization failed: 1
For example log:
[Pass case]
BEGIN: AsyncTask[VectorAnimationTask] Process
Add event trigger callback with id : 0
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Adaptor::UnregisterProcessor : VectorAnimationManager
BEGIN: AsyncTask[VectorAnimationTask] Process
mNeedForceRenderOnceTrigger due to mCurrentFrame is not start (0 -> 1)
Add event trigger callback with id : 1110
END: AsyncTask[VectorAnimationTask] Process
INFO: scene-graph-scene.cpp: SetSurfaceRect(154) > update surfce rect in scene-graph, from width[0], height[0], to width[480], height[800]. Changed count [1]
Execute callback with id : 0
Execute callback with id : 1110
Trigger finished
Adaptor::RegisterProcessor : VectorAnimationManager
Adaptor::UnregisterProcessor : VectorAnimationManager
BEGIN: AsyncTask[VectorAnimationTask] Process
END: AsyncTask[VectorAnimationTask] Process
[Fail case]
BEGIN: AsyncTask[VectorAnimationTask] Process
Add event trigger callback with id : 0
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Execute callback with id : 0
Trigger finished
BEGIN: AsyncTask[VectorAnimationTask] Process
mNeedForceRenderOnceTrigger due to mCurrentFrame is not start (0 -> 1)
Add event trigger callback with id : 1110
Trigger!
END: AsyncTask[VectorAnimationTask] Process
Adaptor::RegisterProcessor : VectorAnimationManager
Adaptor::UnregisterProcessor : VectorAnimationManager
Warning, TestGraphicsReflection::GetSamplers is unimplemented
Execute callback with id : 1110
Trigger finished
Test failed in utc-Dali-AnimatedVectorImageVisual.cpp:1452, checking 1 == 0
Change-Id: I7d7cc5a78428bc3e6f192a75def142ace0f92cb6
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
David Steele [Mon, 15 Apr 2024 11:40:01 +0000 (11:40 +0000)]
Merge "(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use UpdateOnce instead of KeepRendering" into devel/master
Youngsun Suh [Mon, 15 Apr 2024 08:03:54 +0000 (08:03 +0000)]
Merge "Add imgSrc to GetAttribute return map if available" into devel/master
Youngsun Suh [Fri, 12 Apr 2024 07:19:18 +0000 (16:19 +0900)]
Add imgSrc to GetAttribute return map if available
Change-Id: I9f9df3905ab13442e5ff12a04414484a25f3d41b
Eunki, Hong [Fri, 5 Apr 2024 03:16:25 +0000 (12:16 +0900)]
(Vector) Add NOTIFY_AFTER_RASTERIZATION property for low fps file + Use UpdateOnce instead of KeepRendering
Let we change renderer rendering behavior is IF_REQUIRED.
It will be useful if app try to render lottie file which has less than 60fps.
+
Let we use UpdateOnce() API for force-rendering instead of KeepRendering().
KeepRendering will make ProcessCoreEvents forcely, which might not be need for animated vector cases.
Change-Id: Iaece9a5ff9e135acfdac404f68bdc690e6a7be8c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 15 Apr 2024 04:23:21 +0000 (13:23 +0900)]
Remove BaseHandle / BaseObject TypeTraits is trivialgit
Since Dali::Vector doesn't call destructor, BaseHandle / BaseObject
shoudl 'not' be used as Dali::Vector.
To avoid some memory leak mistake, let we remove some mis implementations
Change-Id: I001993d10812bddc0beb888d41e6bc316301484b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 12 Apr 2024 13:07:07 +0000 (22:07 +0900)]
Force call KeepRendering when lottie animation stopped, or frame changed
Change-Id: Ie9c44a8a3997a644080c934d36e99c8aee804bf2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 12 Apr 2024 10:25:43 +0000 (19:25 +0900)]
Revert "Do not call malloc during terminate"
This reverts commit
cc221e4f8a66b6748e5c737e5dbde82c68db8d48.
Change-Id: Ib0dd44b9ca2a82738bfb1cc1a12528803327b1fa
Richard Huang [Fri, 12 Apr 2024 09:52:26 +0000 (10:52 +0100)]
DALi Version 2.3.19
Change-Id: I496a510356a3c578585d9898198d4080f980f1e7
ANZ1217 [Mon, 8 Apr 2024 11:46:52 +0000 (20:46 +0900)]
Fix Crash when the InsertText event is executed multiple times between Relayout.
When using IME, InsertText may be executed multiple times within one relayout.
Fix the problem that length of the text cannot be calculated correctly.
Change-Id: Id47f7bbacf90a098055fc7b6ae0d4931a9facde2
sunghyun kim [Mon, 8 Apr 2024 06:10:10 +0000 (06:10 +0000)]
Merge "Fix bug in transition effect" into devel/master
Eunki, Hong [Fri, 5 Apr 2024 13:28:08 +0000 (22:28 +0900)]
(Vector) Let we send finished signal only for matched sent play/stop from visual
It is possible that AnimationFinished trigger comes "after" event thread Play action comes.
If then, user's Play action be skipped.
To avoid this case, let we give the id when play state changed to Play / Pause / Stop.
And send finished signal only if the id is matched what visual know.
Change-Id: I03409e65d2f6b947940ea5591959b106ff8de2bd
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Wed, 27 Mar 2024 07:33:59 +0000 (16:33 +0900)]
Fix bug in transition effect
Image view provides transitoin effect when image is replaced.
but this function has some bugs, so i fixed them.
Below is the issue list
1.Sometimes, some of view play transition effect when image is not replaced.
2.Sometimes, Don't play transition effect when image is replaced.
3.Focus items show transition effect even if resource is not changed.
Change-Id: I610ef472c3046177c5e3f76dd4d854497805168c
David Steele [Fri, 5 Apr 2024 09:57:43 +0000 (10:57 +0100)]
DALi Version 2.3.18
Change-Id: I104ee21bd9fe23e4fe03f4edfde6681fc11c20ac
huiyu.eun [Wed, 3 Apr 2024 06:08:22 +0000 (15:08 +0900)]
Fix hit-test RenderTask error
There is a problem that the hit-test does not work properly because the
RenderTask is always fetched with a fixed index from the RenderTaskList.
It is fixed by passing the corresponding SceneView's RenderTask.
Change-Id: Id114c839455613fc4ed6437e2cb8482ee6677be9
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Youngsun Suh [Fri, 29 Mar 2024 05:36:08 +0000 (14:36 +0900)]
Remove unused AccessibilityActivate method
Change-Id: I2ab634421bf9eb81327f7fee0c96a1f6ccac30b8
Adeel Kazmi [Thu, 28 Mar 2024 09:29:44 +0000 (09:29 +0000)]
DALi Version 2.3.17
Change-Id: I9f4993940f0b0ab230d3eaf88013c72cdb739b66
sunghyun kim [Mon, 25 Mar 2024 01:23:56 +0000 (01:23 +0000)]
Merge "Apply premultiply on initial time in animated visual" into devel/master
Adam Bialogonski [Fri, 22 Mar 2024 10:32:15 +0000 (10:32 +0000)]
DALi Version 2.3.16
Change-Id: Ib3f94717e7af660bc16ab47fffb235db0457c63f
sunghyun kim [Thu, 21 Mar 2024 05:13:48 +0000 (14:13 +0900)]
Apply premultiply on initial time in animated visual
Change-Id: I7ce10be72455c659f5b5d09c3ce303f39dd13102