Kazu Hirata [Sun, 7 Aug 2022 07:16:14 +0000 (00:16 -0700)]
[llvm] Fix comment typos (NFC)
Kazu Hirata [Sun, 7 Aug 2022 07:16:13 +0000 (00:16 -0700)]
[mlir] Remove redundaunt return statements (NFC)
Identified with readability-redundant-control-flow.
Kazu Hirata [Sun, 7 Aug 2022 07:16:11 +0000 (00:16 -0700)]
[llvm] Drop unnecessary const from return types (NFC)
Identified with readability-const-return-type.
Slava Gurevich [Fri, 5 Aug 2022 20:54:08 +0000 (13:54 -0700)]
[LLDB][NFC] Reliability fixes to TCPSocket code
Patch the following issues found by static code inspection:
- Unchecked return values from lib calls
- Passing potentially negative arg into a function that requires non-negative input
- Possible socket double-close
Differential Revision: https://reviews.llvm.org/D131294
John Demme [Sun, 7 Aug 2022 04:58:46 +0000 (21:58 -0700)]
[MLIR] Add MlirValue to PybindAdapters
Allows out-of-tree users to automatically cast to/from MlirValue.
YingChi Long [Sun, 7 Aug 2022 04:42:15 +0000 (12:42 +0800)]
[clang][docs] use `Fixes` instead of `This fixes` in ReleaseNotes [NFC]
Jacques Pienaar [Sun, 7 Aug 2022 02:24:40 +0000 (19:24 -0700)]
[mlir][tosa] Flip to prefixed form.
Flipped to _Both 2 weeks ago, flipping to _Prefixed now.
Fangrui Song [Sun, 7 Aug 2022 00:26:33 +0000 (00:26 +0000)]
[llvm] LLVM_NODISCARD => [[nodiscard]]. NFC
With C++17 there is no Clang pedantic warning.
Fangrui Song [Sun, 7 Aug 2022 00:02:35 +0000 (00:02 +0000)]
[lld] LLVM_FALLTHROUGH => [[fallthrough]]. NFC
With C++17 there is no Clang pedantic warning or MSVC C5051.
Fangrui Song [Sat, 6 Aug 2022 23:48:23 +0000 (16:48 -0700)]
Revert "[SampleProfileInference] Work around odr-use of const non-inline static data member to fix -O0 builds after D120508"
This reverts commit
48c74bb2e2a72830f1068823bfc2f6fd4b53d427.
With C++17 the workaround is no longer needed.
Fangrui Song [Sat, 6 Aug 2022 23:44:14 +0000 (16:44 -0700)]
Revert "[lld-macho] Work around odr-use of const non-inline static data member to fix -O0 build after D128298"
This reverts commit
20b2d3260d4a1878ca2a37cee6ee335a21a12d0f.
The workaround is no longer needed for C++17.
Fangrui Song [Sat, 6 Aug 2022 23:12:18 +0000 (23:12 +0000)]
[clang-tidy] Fix g++ -DCMAKE_CXX_STANDARD=17 build
`constexpr std::initializer_list<llvm::StringRef>` leads to
```
error: modification of '<temporary>' is not a constant expression
```
Related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102921
Fangrui Song [Sat, 6 Aug 2022 22:48:41 +0000 (22:48 +0000)]
[ADT] Fix signature of StringSet::insert
to match StringMap and unordered_set.
Shilei Tian [Sat, 6 Aug 2022 20:50:30 +0000 (16:50 -0400)]
[Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause
Currently if an OpenMP program uses `linear` clause, and is compiled with
optimization, `llvm.lifetime.end` for variables listed in `linear` clause are
emitted too early such that there could still be uses after that. Let's take the
following code as example:
```
// loop.c
int j;
int *u;
void loop(int n) {
int i;
for (i = 0; i < n; ++i) {
++j;
u = &j;
}
}
```
We compile using the command:
```
clang -cc1 -fopenmp-simd -O3 -x c -triple x86_64-apple-darwin10 -emit-llvm loop.c -o loop.ll
```
The following IR (simplified) will be generated:
```
@j = local_unnamed_addr global i32 0, align 4
@u = local_unnamed_addr global ptr null, align 8
define void @loop(i32 noundef %n) local_unnamed_addr {
entry:
%j = alloca i32, align 4
%cmp = icmp sgt i32 %n, 0
br i1 %cmp, label %simd.if.then, label %simd.if.end
simd.if.then: ; preds = %entry
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %j)
store ptr %j, ptr @u, align 8
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %j)
%0 = load i32, ptr %j, align 4
store i32 %0, ptr @j, align 4
br label %simd.if.end
simd.if.end: ; preds = %simd.if.then, %entry
ret void
}
```
The most important part is:
```
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %j)
%0 = load i32, ptr %j, align 4
store i32 %0, ptr @j, align 4
```
`%j` is still loaded after `@llvm.lifetime.end.p0(i64 4, ptr nonnull %j)`. This
could cause the backend incorrectly optimizes the code and further generates
incorrect code. The root cause is, when we emit a construct that could have
`linear` clause, it usually has the following pattern:
```
EmitOMPLinearClauseInit(S)
{
OMPPrivateScope LoopScope(*this);
...
EmitOMPLinearClause(S, LoopScope);
...
(void)LoopScope.Privatize();
...
}
EmitOMPLinearClauseFinal(S, [](CodeGenFunction &) { return nullptr; });
```
Variables that need to be privatized are added into `LoopScope`, which also
serves as a RAII object. When `LoopScope` is destructed and if optimization is
enabled, a `@llvm.lifetime.end` is also emitted for each privatized variable.
However, the writing back to original variables in `linear` clause happens after
the scope in `EmitOMPLinearClauseFinal`, causing the issue we see above.
A quick "fix" seems to be, moving `EmitOMPLinearClauseFinal` inside the scope.
However, it doesn't work. That's because the local variable map has been updated
by `LoopScope` such that a variable declaration is mapped to the privatized
variable, instead of the actual one. In that way, the following code will be
generated:
```
%0 = load i32, ptr %j, align 4
store i32 %0, ptr %j, align 4
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %j)
```
Well, now the life time is correct, but apparently the writing back is broken.
In this patch, a new function `OMPPrivateScope::restoreMap` is added and called
before calling `EmitOMPLinearClauseFinal`. This can make sure that
`EmitOMPLinearClauseFinal` can find the orignal varaibls to write back.
Fixes #56913.
Reviewed By: ABataev
Differential Revision: https://reviews.llvm.org/D131272
Tom Stellard [Sat, 6 Aug 2022 13:22:19 +0000 (09:22 -0400)]
lld/cmake: Drop use of llvm-config for LLVM install discovery
This has been deprecated since D116492 earlier in 2022.
That seems recent, but with the recent cut of LLVM 15 that is still two releases (14 and 15). Meanwhile Clang has deprecated `llvm-config` for a lot longer, and since it is likely that LLD users are also Clang users, this serves as an extra "heads up" that `llvm-config` is on its way out.
Remove it in favor of using CMake's find_package() function.
Reviewed By: MaskRay, mgorny
Differential Revision: https://reviews.llvm.org/D131144
Tom Stellard [Sat, 6 Aug 2022 13:22:05 +0000 (09:22 -0400)]
clang/cmake: Drop use of llvm-config for LLVM install discovery
This has been deprecated for a while, since D51714 in 2018.
Remove it in favor of using CMake's find_package() function.
Reviewed By: phosek, mgorny
Differential Revision: https://reviews.llvm.org/D128777
Benjamin Kramer [Sat, 6 Aug 2022 19:47:44 +0000 (21:47 +0200)]
[bazel] Switch to C++17
LLVM switched to C++17 in
b1356504e63ae821cccf1e051a0d2526bdfef2b0
Aarush Bhat [Sat, 6 Aug 2022 19:42:16 +0000 (03:42 +0800)]
clang: fix typo availbility
- Fixes [[ https://github.com/llvm/llvm-project/issues/56787 | #56787 ]].
I am fixing the spelling of availability.
I am unsure if this change will have any side effects. If someone can
help on how to check if it has any side effects, I can test those out as
well.
Reviewed By: inclyc
Differential Revision: https://reviews.llvm.org/D131277
Krzysztof Parzyszek [Sat, 6 Aug 2022 19:29:19 +0000 (14:29 -0500)]
[RDF] Use default TargetOperandInfo if not given in constructor
All current in-tree users use the default implementation.
Thorsten Schütt [Sat, 6 Aug 2022 18:51:40 +0000 (20:51 +0200)]
[bolt] silence unused variables warnings
Krzysztof Parzyszek [Sat, 6 Aug 2022 17:09:18 +0000 (12:09 -0500)]
[RDF] Remove explicit template arguments from Print
CTAD takes care of it.
Kazu Hirata [Sat, 6 Aug 2022 18:21:39 +0000 (11:21 -0700)]
Use value instead of getValue (NFC)
Kazu Hirata [Sat, 6 Aug 2022 18:12:47 +0000 (11:12 -0700)]
[mlir, flang] Use has_value instead of hasValue (NFC)
Aaron Ballman [Sat, 6 Aug 2022 15:52:28 +0000 (11:52 -0400)]
Update the status of some more C DRs
Update some of the C99-era DRs starting in the 300s.
Benjamin Kramer [Sat, 6 Aug 2022 14:08:48 +0000 (16:08 +0200)]
Adrian Vogelsgesang [Sat, 6 Aug 2022 13:09:50 +0000 (15:09 +0200)]
[libc++] Remove `operator!=` from `type_info` in C++20
Implements part of:
* P1614R2 The Mothership has Landed
Reviewed By: #libc, Mordante
Differential Revision: https://reviews.llvm.org/D130853
Adrian Vogelsgesang [Sat, 6 Aug 2022 13:04:38 +0000 (15:04 +0200)]
[libc++] Implement `operator<=>` for `unique_ptr`
Implements part of:
- P1614R2 The Mothership has Landed
Fixes LWG3426
Reviewed By: #libc, Mordante
Differential Revision: https://reviews.llvm.org/D130838
Chen Zheng [Tue, 19 Jul 2022 08:24:49 +0000 (04:24 -0400)]
[NFC] add test cases for D123366
Chen Zheng [Tue, 12 Jul 2022 11:28:19 +0000 (07:28 -0400)]
[PowerPC] fix stack size allocated for float point argument
This is for https://github.com/llvm/llvm-project/issues/56469
Allocate 4 bytes for float point arguments on PPC32.
Reviewed By: nemanjai
Differential Revision: https://reviews.llvm.org/D129558
Nico Weber [Sat, 6 Aug 2022 12:36:01 +0000 (08:36 -0400)]
Nico Weber [Sat, 6 Aug 2022 12:29:11 +0000 (08:29 -0400)]
[gn build] Try to fix build on linux after std=c++17 switch
glibc annotates `process_vm_readv` with `__THROW`.
lldb/include/lldb/Host/linux/Uio.h and
lldb/source/Host/linux/LibcGlue.cpp don't.
Having a mismatch causes an error with c++17:
../../lldb/source/Host/linux/LibcGlue.cpp:18:9:
error: 'process_vm_readv' is missing exception specification 'throw()'
ssize_t process_vm_readv(::pid_t pid, const struct iovec *local_iov,
^
../../lldb/include/lldb/Host/linux/Uio.h:18:9:
note: previous declaration is here
ssize_t process_vm_readv(::pid_t pid, const struct iovec *local_iov,
^
The diagnostic is a bit misleading, since the previous declaration
in the sysroot (in usr/include/x76_64-linux-gnu/bits/uio-ext.h) is
what has the `__THROW`.
In the cmake build, cmake sets `HAVE_PROCESS_VM_READV` correctly based
on header probing.
In the GN build, just set it to 1 unconditionally on linux. If that
turns out to not be good enough everywhere, we'll have to add a GN arg
for this.
(I'm also setting it to 1 on Android. I'm not sure if that's correct --
but we don't build lldb for Android anyways.)
Markus Böck [Sat, 6 Aug 2022 11:31:48 +0000 (13:31 +0200)]
[llvm] Remove uses of deprecated `std::iterator`
std::iterator has been deprecated in C++17 and some standard library implementations such as MS STL or libc++ emit deperecation messages when using the class.
Since LLVM has now switched to C++17 these will emit warnings on these implementations, or worse, errors in build configurations using -Werror.
This patch fixes these issues by replacing them with LLVMs own llvm::iterator_facade_base which offers a superset of functionality of std::iterator.
Differential Revision: https://reviews.llvm.org/D131320
Markus Böck [Wed, 3 Aug 2022 21:43:41 +0000 (23:43 +0200)]
[mlir][tblgen] Refact mlir-tblgen main into its own library
This has previously been done for `mlir-opt` and `mlir-reduce` and roughly the same approach has been done here.
The use case for having a separate library is that it is easier for downstream to make custom TableGen backends/executable that work on top of the utilities that are defined in `mlir/TableGen`.
The customization point here is the same one as for any upstream TableGen backends: One can add a new generator by simply creating a global instance of `mlir::GenRegistration`.
Differential Revision: https://reviews.llvm.org/D131112
Nico Weber [Sat, 6 Aug 2022 11:54:43 +0000 (07:54 -0400)]
[gn build] port
b1356504e63ae better (c++17)
Nico Weber [Sat, 6 Aug 2022 11:51:06 +0000 (07:51 -0400)]
[gn build] port
b1356504e63ae (c++17)
Benjamin Kramer [Sat, 6 Aug 2022 09:34:24 +0000 (11:34 +0200)]
Fangrui Song [Sat, 6 Aug 2022 08:00:06 +0000 (01:00 -0700)]
[ELF] toString(const InputFile *): synchronize toStringCache
The function may be called currently for diagnostics.
Leon Clark [Sat, 6 Aug 2022 07:57:12 +0000 (08:57 +0100)]
Transform illegal intrinsics to V_ILLEGAL
Related tasks:
- SWDEV-240194
- SWDEV-309417
- SWDEV-334876
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D123693
Tobias Hieta [Fri, 5 Aug 2022 19:45:55 +0000 (21:45 +0200)]
[LLVM] Update C++ standard to 17
Also make the soft toolchain requirements hard. This allows
us to use C++17 features in LLVM now.
If we find patterns with C++17 that improve readability
it should be recommended in the coding standards.
Reviewed By: jhenderson, cor3ntin, MaskRay
Differential Revision: https://reviews.llvm.org/D130689
Jun Zhang [Sat, 6 Aug 2022 03:36:02 +0000 (11:36 +0800)]
[Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.
In the case of static compilation the file system is pretty much read-only
and taking a snapshot of it usually is sufficient. In the interactive C++
case the compilation is longer and people can create and include files, etc.
In that case we often do not want to open files or cache failures unless is
absolutely necessary.
This patch extends the original API call by forwarding some optional flags,
so we can continue use it in the previous way with no breakage.
Signed-off-by: Jun Zhang <jun@junz.org>
Differential Revision: https://reviews.llvm.org/D131241
Chen Zheng [Tue, 12 Jul 2022 11:41:49 +0000 (07:41 -0400)]
[NFC] add test case for D129558
Slava Gurevich [Sat, 6 Aug 2022 01:15:45 +0000 (18:15 -0700)]
[LLDB] Missing break in a switch statement alters the execution flow.
Looks like a typo from the past code changes.
Differential Revision: https://reviews.llvm.org/D131244
Fangrui Song [Sat, 6 Aug 2022 01:24:53 +0000 (18:24 -0700)]
[ELF][AArch64] Fix potentially corrupted section content for PAC
D74537 introduced a bug: if `(config->andFeatures & GNU_PROPERTY_AARCH64_FEATURE_1_PAC) != 0`
with -z pac-plt unspecified, we incorrectly use AArch64BtiPac, whose writePlt will make
out-of-bounds write after the .plt section. This is often benign because the
output section after .plt will usually overwrite the content.
This is very difficult to test without D131247 (Parallelize writes of different OutputSections).
Fangrui Song [Sat, 6 Aug 2022 01:20:23 +0000 (18:20 -0700)]
[ELF] Keep only getTarget() call. NFC
The place from D61712 seems unneeded now. We can just use the place added by
D62609 (support AArch64 BTI/PAC).
Argyrios Kyrtzidis [Sat, 6 Aug 2022 00:26:51 +0000 (17:26 -0700)]
[test/Modules/cxx20-export-import.cpp] Pre-clean the modules cache directory of the test, NFC
Fangrui Song [Sat, 6 Aug 2022 00:08:37 +0000 (17:08 -0700)]
[ELF] mergeCmp: work around irreflexivity bug
Some tests (e.g. aarch64-feature-pac.s) segfault in libstdc++ _GLIBCXX_DEBUG
builds (enabled by LLVM_ENABLE_EXPENSIVE_CHECKS).
dyn_cast<ThunkSection> is incorrectly true for any SyntheticSection. std::merge
transitively calls mergeCmp(x, x) (due to __glibcxx_requires_irreflexive_pred)
and will segfault in `ta->getTargetInputSection()`. The dyn_cast<ThunkSection>
issue should be eventually fixed properly, bug `a != b` is robust enough for now.
Nico Weber [Fri, 5 Aug 2022 23:50:23 +0000 (19:50 -0400)]
unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV=OFF after
6635f48e4aba
See revision
b8b7a9dcdcbc for prior art.
Xiang Li [Sun, 31 Jul 2022 22:16:24 +0000 (15:16 -0700)]
[HLSL] emit-obj when set output.
When not set output, set default output to stdout.
When set output with -Fo and no -fcgl, set -emit-obj to generate dx container.
Reviewed By: beanz
Differential Revision: https://reviews.llvm.org/D130858
Joseph Huber [Fri, 5 Aug 2022 18:43:23 +0000 (14:43 -0400)]
[CUDA] Fix output name being replaced in device-only mode
When performing device only compilation, there was an issue where
`cubin` outputs were being renamed to `cubin` despite the user's name.
This is required in a normal compilation flow as the Nvidia tools only
understand specific filenames instead of checking magic bytes for some
unknown reason. We do not want to perform this transformation when the
user is performing device only compilation.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D131278
Argyrios Kyrtzidis [Wed, 3 Aug 2022 22:24:25 +0000 (15:24 -0700)]
[Serialization] Remove `ORIGINAL_PCH_DIR` record
Use of `ORIGINAL_PCH_DIR` record has been superseeded by making PCH/PCM files with relocatable paths at write time.
Removing this record is useful for producing an output-path-independent PCH file and enable sharing of the same PCH file even
when it was intended for a different output path.
Differential Revision: https://reviews.llvm.org/D131124
Keith Smiley [Fri, 5 Aug 2022 20:26:24 +0000 (13:26 -0700)]
[Sanitizer][Darwin] Support OS versions before DRIVERKIT
Fixes https://github.com/llvm/llvm-project/issues/56960
Differential Revision: https://reviews.llvm.org/D131288
Fangrui Song [Fri, 5 Aug 2022 22:22:57 +0000 (15:22 -0700)]
[ELF][PPC64] Fix potentially corrupted section content with empty .got
D91426 makes .got possibly empty while needed. If .got and .data have the same
address, and .got's content is written after .data, the first word of .data will
be corrupted.
The bug is not testable without D131247.
Eugene Zhulenev [Fri, 5 Aug 2022 20:52:18 +0000 (13:52 -0700)]
[mlir] Use SymbolTableCollection to lookup referenced symbol in AddressOfOp
Depends On D131285
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D131291
Konstantin Varlamov [Fri, 5 Aug 2022 21:02:50 +0000 (14:02 -0700)]
[libc++][ranges][NFC] Mark the completed Ranges papers and issues as done.
The newly-completed papers:
- P0896R4 ("The One Ranges Proposal");
- P1243R4 ("Rangify New Algorithms");
- P1252R2 ("Ranges Design Cleanup");
- P1716R3 ("Range Comparison Algorithms Are Over-Constrained");
- P1871R1 ("Concept traits should be named after concepts");
- P2106R0 ("Alternative wording for GB315 and GB316").
Differential Revision: https://reviews.llvm.org/D131234
Filipp Zhinkin [Fri, 5 Aug 2022 20:56:45 +0000 (16:56 -0400)]
[DAGCombiner] Hoist funnel shifts from logic operation
Hoist funnel shift from logic op:
logic_op (FSH x0, x1, s), (FSH y0, y1, s) --> FSH (logic_op x0, y0), (logic_op x1, y1), s
The transformation improves code generated for some cases related to
issue https://github.com/llvm/llvm-project/issues/49541.
Reduced amount of funnel shifts can also improve throughput on x86 CPUs by utilizing more
available ports: https://quick-bench.com/q/gC7AKkJJsDZzRrs_JWDzm9t_iDM
Transformation correctness checks:
https://alive2.llvm.org/ce/z/TKPULH
https://alive2.llvm.org/ce/z/UvTd_9
https://alive2.llvm.org/ce/z/j8qW3_
https://alive2.llvm.org/ce/z/7Wq7gE
https://alive2.llvm.org/ce/z/Xr5w8R
https://alive2.llvm.org/ce/z/D5xe_E
https://alive2.llvm.org/ce/z/2yBZiy
Differential Revision: https://reviews.llvm.org/D130994
Konstantin Varlamov [Fri, 5 Aug 2022 21:01:46 +0000 (14:01 -0700)]
[libc++][ranges][NFC] Make sure all implemented algorithms are enabled in "robust" tests.
Also fix `std::find_first_of` (which accidentally copied the predicate
in the implementation).
Differential Revision: https://reviews.llvm.org/D131235
Lang Hames [Fri, 5 Aug 2022 19:03:34 +0000 (12:03 -0700)]
[ORC] Fix a memory leak in LLVMOrcIRTransformLayerSetTransform.
This function heap-allocates a ThreadSafeModule (the current C bindings assume
that TSMs are always heap-allocated), but was failing to free it.
Should fix http://llvm.org/PR56953.
Lang Hames [Fri, 5 Aug 2022 18:41:38 +0000 (11:41 -0700)]
[examples][ORC] Add missing call to LLVMDisposeBuilder to example.
The missing call was pointed out in https://llvm.org/PR56953, though it's not
the focus of that issue.
Eugene Zhulenev [Fri, 5 Aug 2022 20:08:08 +0000 (13:08 -0700)]
[mlir] Implement SymbolUserOpInterface in LLVM::CallOp
Avoid expensive calls to `SymbolTable::lookupNearestSymbolFrom` in verifier
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D131285
Jakub Kuderski [Fri, 5 Aug 2022 20:45:32 +0000 (16:45 -0400)]
[mlir][spirv] Define spv.IAddCarry
Based on `spv.ISubBorrow` from D127909.
Also resolved some clang-tidy warnings.
Reviewed By: antiagainst, ThomasRaoux
Differential Revision: https://reviews.llvm.org/D131281
Vitaly Buka [Wed, 3 Aug 2022 22:04:26 +0000 (15:04 -0700)]
[NFC][Inliner] Add Load/Store handler
This is an additional signal which may benefit sanitizers.
Reviewed By: kda
Differential Revision: https://reviews.llvm.org/D131129
Ruobing Han [Fri, 5 Aug 2022 20:17:26 +0000 (20:17 +0000)]
[test][SimpleLoopUnswitch] Precommit test for D129599
Florian Mayer [Fri, 5 Aug 2022 19:09:05 +0000 (12:09 -0700)]
[HWASan] Remove incorrect unreachable.
This function could be called wih access_info & 0x20 or with
flags()->halt_on_error, in which case HandleTagMismatch returns (is not
fatal).
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D131279
Amaury Séchet [Fri, 5 Aug 2022 19:46:26 +0000 (19:46 +0000)]
[NFC] Regenerates X86's win64-bool.ll
Slava Zakharin [Thu, 4 Aug 2022 19:07:35 +0000 (12:07 -0700)]
[flang] Lower MOD to Fortran runtime call.
This change removes dependency on pgmath mod, and also allows
Fortran runtime to issue a diagnostic message in case of zero
denominator.
Differential Revision: https://reviews.llvm.org/D131192
Craig Topper [Fri, 5 Aug 2022 19:41:28 +0000 (12:41 -0700)]
[RISCV] Don't use li+sh3add for constants that can use lui+add.
If we're adding a constant that can't use addi we try a few tricks,
one of which is using li+sh3add. We should not do this if lui+add
would work. For example adding 8192. Using sh3add prevents folding
a sext.w to form addw, thus increasing instruction count.
Tobias Hieta [Fri, 5 Aug 2022 19:44:56 +0000 (21:44 +0200)]
[llvm][macos] Fix usage of std::shared_mutex on old macOS SDK versions
When setting CMAKE_CXX_STANDARD to 17 and targeting a macOS version
under 10.12 the ifdefs would try to use std::shared_mutex because
the of the C++ standard. This should also check the targeted SDK.
See discussion in: https://reviews.llvm.org/D130689
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D131063
Rashmi Mudduluru [Fri, 5 Aug 2022 19:35:44 +0000 (12:35 -0700)]
fixes clang-tidy/checks/list.rst: a line was accidentally removed in
95a92995d45fc6fada43ecd91eba3e7aea90487a
Ben Langmuir [Tue, 2 Aug 2022 20:26:01 +0000 (13:26 -0700)]
[clang][modules] Don't depend on sharing FileManager during module build
Sharing the FileManager between the importer and the module build should
only be an optimization. Add a cc1 option -fno-modules-share-filemanager
to allow us to test this. Fix the path to modulemap files, which
previously depended on the shared FileManager when using path mapped to
an external file in a VFS.
Differential Revision: https://reviews.llvm.org/D131076
Ben Langmuir [Fri, 5 Aug 2022 17:56:56 +0000 (10:56 -0700)]
[clang] Fix redirection behaviour for cached FileEntryRef
In
6a79e2ff1989b we changed Filemanager::getEntryRef() to return the
redirecting FileEntryRef instead of looking through the redirection.
This commit fixes the case when looking up a cached file path to also
return the redirecting FileEntryRef. This mainly affects the behaviour
of calling getNameAsRequested() on the resulting entry ref.
Differential Revision: https://reviews.llvm.org/D131273
Jack Kirk [Fri, 5 Aug 2022 18:41:47 +0000 (11:41 -0700)]
[CUDA] Fixed sm version constrain for __bmma_m8n8k128_mma_and_popc_b1.
As stated in
https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#warp-level-matrix-instructions-wmma-mma:
".and operation in single-bit wmma requires sm_80 or higher."
tra@: Fixed a bug in builtins-nvptx-mma.py test generator and regenerated the tests.
Differential Revision: https://reviews.llvm.org/D131265
Philip Reames [Fri, 5 Aug 2022 19:08:03 +0000 (12:08 -0700)]
[RISCVInsertVSETVLI] Remove an unsound optimization
This fixes a bug reported privately by @craig.topper. Here's an example which illustrates the problem:
vsetivli a1, a0, e32, m1, ta, mu # both DefInfo and PrevInfo
vsetivli a2, a1, e32, m4, ta, mu
With the unsound result being:
vsetivli a1, a0, e32, m1, ta, mu
vsetivli a2, a0, e32, m4, ta, mu
Consider the case where this is running on a machine with VLEN=512,. For this case, the VLMAXs are 16 and 64 respectively.
Consider for a0 = 33. The correct result is: a1 = 16, and a2 = 16
After the unsound optimization: a1 = 16 and a2 = 33
This particular example used VLMAXs which differed by more than a power of two. With a difference of only one power of two, there's another form of this bug which involves the AVL < 2 x VLMAX special case, but that ones more complicated to construct as many examples turn out accidentally sound.
This patch takes the approach of simply removing the unsound optimization, but there are multiple sound sub-cases of it. I plan to return to at least a couple of them, but figured it was cleaner to remove the unsound optimization (for ease of backporting), and then review the new optimizations on their own.
Differential Revision: https://reviews.llvm.org/D131264
Zhaoshi Zheng [Fri, 8 Jul 2022 18:48:44 +0000 (11:48 -0700)]
[WinEH][ARM64] Split Unwind Info for Fucntions Larger than 1MB
Create function segments and emit unwind info of them.
A segment must be less than 1MB and no prolog or epilog is splitted between two
segments.
This patch should generate correct, though not optimal, unwind info for large
functions. Currently it only generate pacted info (.pdata) only for functions
that are less than 1MB (single-segment functions). This is NFC from before this
patch.
The next step is to enable (.pdata) only unwind info for the first segment or
segments that have neither prolog or epilog in a multi-segment function.
Another future work item is to further split segments that require more than 255
code words or have more than 65535 epilogs.
Reference:
https://docs.microsoft.com/en-us/cpp/build/arm64-exception-handling#function-fragments
Differential Revision: https://reviews.llvm.org/D130049
Slava Zakharin [Wed, 20 Jul 2022 03:39:58 +0000 (20:39 -0700)]
[flang] Propagate lowering options from driver.
This commit addresses concerns raised in D129497.
Propagate lowering options from driver to expressions lowering
via AbstractConverter instance. A single use case so far is
using optimized TRANSPOSE lowering with O1/O2/O3.
bbc does not support optimization level switches, so it uses
default LoweringOptions (e.g. optimized TRANSPOSE lowering
is enabled by default, but an engineering -opt-transpose=false
option can still override this).
Differential Revision: https://reviews.llvm.org/D130204
Jonas Devlieghere [Fri, 5 Aug 2022 18:17:18 +0000 (11:17 -0700)]
[lldb] Improve EXC_RESOURCE exception reason
Jason noted that the stop message we print for a memory high water mark
notification (EXC_RESOURCE) could be clearer. Currently, the stop
reason looks like this:
* thread #3, queue = 'com.apple.CFNetwork.LoaderQ', stop reason =
EXC_RESOURCE RESOURCE_TYPE_MEMORY (limit=14 MB, unused=0x0)
It's hard to read the message because the exception and the type
(EXC_RESOURCE RESOURCE_TYPE_MEMORY) blend together. Additionally, the
"observed=0x0" should not be printed for memory limit exceptions.
I wanted to continue to include the resource type from
<kern/exc_resource.h> while also explaining what it actually is. I used
the wording from the comments in the header. With this path, the stop
reason now looks like this:
* thread #5, stop reason = EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high
watermark memory limit exceeded) (limit=14 MB)
rdar://
40466897
Differential revision: https://reviews.llvm.org/D131130
Jeff Bailey [Fri, 5 Aug 2022 06:24:43 +0000 (06:24 +0000)]
[libc] Update look and feel of libc.llvm.org
This design is borrowed from the lldb folks (thank you!) to declutter
the page.
* The version number at the top is removed.
* Links are pushed over to a sidebar
* The sidebar has headings
There are other minor changes:
* The warning about this project not being ready is now an RST "warning"
* Links to the Bug Reports and the Source Code are Added
* Refer to this project as either "The LLVM C LIbrary" or "The libc"
Tested:
Built locally
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D131242
Jim Ingham [Wed, 27 Jul 2022 16:27:51 +0000 (09:27 -0700)]
Reapply the commits to enable accurate hit-count detection for watchpoints.
This commit combines the initial commit (
7c240de609af), a fix for x86_64 Linux
(
3a0581501e76) and a fix for thinko in a last minute rewrite that I really
should have run the testsuite on.
Also, make sure that all the "I need to step over watchpoint" plans execute
before we call a public stop. Otherwise, e.g. if you have N watchpoints and
a Signal, the signal stop info will get us to stop with the watchpoints in a
half-done state.
Differential Revision: https://reviews.llvm.org/D130674
Eugene Zhulenev [Fri, 5 Aug 2022 17:35:39 +0000 (10:35 -0700)]
[mlir] Use SymbolUserOpInterface in LLVM::AddressOfOp verifier
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D131271
Lei Zhang [Fri, 5 Aug 2022 16:24:14 +0000 (12:24 -0400)]
[mlir][spirv] Add default Vulkan memory space to storage class mapping
Reviewed By: ThomasRaoux, kuhar
Differential Revision: https://reviews.llvm.org/D131128
Lei Zhang [Fri, 5 Aug 2022 16:10:38 +0000 (12:10 -0400)]
[mlir][spirv] Add a pass to map memref memory space
MemRef types now can carry an attribute to represent the memory
space. Still, upper layers in the compilation stack mostly use
nuemric values. They don't mean much (other than differentiating
separate memory domains) in MLIR's multi-level settings. Those
numeric memory space inside MemRef types need to be translated
into concrete SPIR-V storage classes during lowering to pin down
to concrete memory types.
Thus far we have been hardcoding an arbitrary mapping from memory
space to storage class for converting MemRef types. This works fine
for only targeting Vulkan; it falls apart if we want to target other
SPIR-V consumers like OpenCL, as different consumers might want
different storage classes for the buffer/variable of the same
lifetime. For example, StorageClass in Vulkan vs. CrossWorkgroup
in OpenCL.
So putting up a new pass to let the user to control how to map
MemRef memory spaces into SPIR-V storage classes. This provides
more flexibility and can address the awkwardness in the current
SPIR-V type converter. This pass should be the prelimiary step
towards lowering MemRef related types/ops into SPIR-V.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D130317
Sanjay Patel [Fri, 5 Aug 2022 15:51:59 +0000 (11:51 -0400)]
[InstSimplify] make uses of isImpliedCondition more efficient (NFCI)
As suggested in the post-commit comments for
019d76196f79fcff3c148,
this makes the usage symmetric with the 'and' patterns and should
be more efficient.
Paul Walker [Fri, 29 Jul 2022 17:49:10 +0000 (18:49 +0100)]
[SVE] Expand DUPM patterns to handle all integer vector types.
NOTE: i8 vector splats are ignored because the immediate range of
DUP already has full coverage.
Differential Revision: https://reviews.llvm.org/D131078
Than McIntosh [Fri, 5 Aug 2022 12:16:17 +0000 (08:16 -0400)]
tsan: fix bug in shadow reset introduced in D128909
Correct a bug in the code that resets shadow memory introduced as part
of a previous change for the Go race detector (D128909). The bug was
that only the most recently added shadow segment was being reset, as
opposed to the entire extent of the segment created so far. This
fixes a bug identified in Google internal testing (b/
240733951).
Differential Revision: https://reviews.llvm.org/D131256
Sanjay Patel [Fri, 5 Aug 2022 14:59:09 +0000 (10:59 -0400)]
[InstSimplify] use isImpliedCondition() instead of semi-duplicated code
We get a couple of improvements from recognizing swapped
operand patterns that were not handled by the replicated
code.
This should also enable simplifying larger patterns as
seen in issue #56653 and issue #56654, but that requires
enhancements to isImpliedCondition() itself.
Filipp Zhinkin [Fri, 5 Aug 2022 14:20:59 +0000 (10:20 -0400)]
[x86] add tests for bitwise logic of funnel shifts; NFC
Baseline tests for D130994
Nikita Popov [Tue, 2 Aug 2022 13:34:42 +0000 (15:34 +0200)]
Revert "[compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux"
As mentioned in https://reviews.llvm.org/D121379#3690593, this
change broke the build of compiler-rt targeting powerpc using GCC.
The 32-bit powerpc target is not supposed to emit 128-bit libcalls
-- if it does, then that's a backend bug and needs to be fixed there.
This reverts commit
8f24a56a3a9363f353c8da318d97491a6818781d.
Differential Revision: https://reviews.llvm.org/D130988
Tue Ly [Mon, 1 Aug 2022 13:57:29 +0000 (09:57 -0400)]
[libc] Implement sincosf function correctly rounded to all rounding modes.
Refactor common range reductions and evaluations for sinf, cosf, and
sincosf. Added exhaustive tests for sincosf.
Performance before the patch:
```
System LIBC reciprocal throughput : 30.205
LIBC reciprocal throughput : 30.533
System LIBC latency : 67.961
LIBC latency : 61.564
```
Performance after the patch:
```
System LIBC reciprocal throughput : 30.409
LIBC reciprocal throughput : 20.273
System LIBC latency : 67.527
LIBC latency : 61.959
```
Reviewed By: orex
Differential Revision: https://reviews.llvm.org/D130901
Mirko Brkusanin [Thu, 4 Aug 2022 17:24:31 +0000 (19:24 +0200)]
[AMDGPU] Remove unused MIMG tablegen variants
There are no AMDGPUSampleVariant versions for _G16, it is treated more like a
modifier for derivatives (_D) (also for intrinsics where it is overloaded type
instead of part of instrinsic name) so we ended up making more variants for
these instruction then we actually needed.
32-bit derivatives need 6 dwords at most, while 16-bit need 4 at most. Using
same AMDGPUSampleVariant for both, we ended up creating 2 extra variants per
instruction than were necessary.
In total this deletes 260 unused tablegen records.
Differential Revision: https://reviews.llvm.org/D131252
Aaron Ballman [Fri, 5 Aug 2022 13:16:37 +0000 (09:16 -0400)]
Removing redundant code; NFC
The same predicate is checked on line 12962 just above the removed code.
Alexander Belyaev [Fri, 5 Aug 2022 12:53:35 +0000 (14:53 +0200)]
Revert "[mlir] Extract offsets-sizes-strides computation from `makeTiledShape(s)`."
This reverts commit
56d94b3b902e21ff79b1ce9a6fb606a3f7c1c4db.
Dawid Jurczak [Thu, 4 Aug 2022 16:26:18 +0000 (18:26 +0200)]
[NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T
Extracted from https://reviews.llvm.org/D129781 and address comment:
https://reviews.llvm.org/D129781#3655571
Differential Revision: https://reviews.llvm.org/D130268
David Green [Fri, 5 Aug 2022 10:19:37 +0000 (11:19 +0100)]
[ConstProp] Don't fallthorugh for poison constants on vctp and active_lane_mask.
Given a poison constant as input, the dyn_cast to a ConstantInt would
fail so we would fall through to the generic code that attempts to fold
each element of the input vectors. The inputs to these intrinsics are
not vectors though, leading to a compile time crash. Instead bail out
properly for poison values by returning nullptr. This doesn't try to
define what poison means for these intrinsics.
Fixes #56945
David Spickett [Wed, 20 Jul 2022 15:55:36 +0000 (15:55 +0000)]
[llvm][IROutliner] Account for return void in sort comparator
This fixes 69 llvm tests that failed when EXPENSIVE_CHECKS was enabled.
llvm/test/Transforms/IROutliner/outlining-commutative-operands-opposite-order.ll
is one example.
When we have EXPENSIVE_CHECKS, _GLIBCXX_DEBUG is defined. This means
that libstdc++ will call the compare function to check if it is
implemented correctly (that !(a < a) is true).
This happens even if there is only one item and here, we expect
to see one return void or multiple return constant integer.
Don't sort if we have 1 item, but do assert that it is the 1
ret void we expect. In the comparator, assert that neither
Value is a nullptr in case one ended up in a the list somehow.
Reviewed By: AndrewLitteken
Differential Revision: https://reviews.llvm.org/D130230
Phoebe Wang [Fri, 5 Aug 2022 08:36:33 +0000 (01:36 -0700)]
[X86] Move getting module flag into `runOnMachineFunction` to reduce compile-time. NFCI
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D131245
Dimitry Andric [Thu, 4 Aug 2022 19:04:35 +0000 (21:04 +0200)]
[CMake] Find python before searching for python modules
In the top-level llvm `CMakeLists.txt`, we need to call
`find_package(Python3)` *before* including `config-ix.cmake`, otherwise
the latter will not be able to successfully search for python modules
using `find_python_module()`. Also set `LLVM_MINIMUM_PYTHON_VERSION`
before calling `find_package(Python3)`, moving it to `CMakeLists.txt`
from `HandleLLVMOptions.cmake`.
Reviewed By: compnerd
Differential Revision: https://reviews.llvm.org/D131191
Chuanqi Xu [Fri, 5 Aug 2022 08:44:38 +0000 (16:44 +0800)]
[NFC] Requires x86-registered-target for test/pr56919.cpp
Balázs Kéri [Fri, 5 Aug 2022 08:05:34 +0000 (10:05 +0200)]
[clang][analyzer] Add more wide-character functions to CStringChecker
Support for functions wmempcpy, wmemmove, wmemcmp is added to the checker.
The same tests are copied that exist for the non-wide versions, with
non-wide functions and character types changed to the wide version.
Reviewed By: martong
Differential Revision: https://reviews.llvm.org/D130470
Nathan James [Fri, 5 Aug 2022 07:42:51 +0000 (08:42 +0100)]
[clangd] Change the url for clang-tidy check documentation
In https://github.com/llvm/llvm-project/commit/
6e566bc5523f743bc34a7e26f050f1f2b4d699a8, The directory structure of the documentation for clang-tidy checks was changed, however clangd wasn't updated.
Now all the links generated will point to old dead pages.
This updated clangd to use the new page structure.
Reviewed By: sammccall, kadircet
Differential Revision: https://reviews.llvm.org/D128379
wanglei [Fri, 5 Aug 2022 06:48:37 +0000 (14:48 +0800)]
[LoongArch] Implement more of the ABI
According to the description of the LoongArch abi documentation,
(https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html)
the calling convention of LoongArch is almost the same as the RISCV's
(except for the vector part), so we borrow the implementation of RISCV.
This patch only guarantees the correctness of lp64d, because only the
part of lp64d is described in detail in the documentation.
Differential Revision: https://reviews.llvm.org/D130249
David Green [Fri, 5 Aug 2022 07:11:57 +0000 (08:11 +0100)]
[AArch64] Tone down the number of repeated fmov N2 scheduling tests. NFC