Claudius Ellsel [Sun, 3 Feb 2019 22:39:34 +0000 (23:39 +0100)]
Add another entry for MX Master to 70-mouse.hwdb (#11633)
Frantisek Sumsal [Sun, 3 Feb 2019 12:33:47 +0000 (13:33 +0100)]
Merge pull request #11637 from yuwata/fix-test-network
test-network: fix test_dhcp_server() and test_ipv6_prefix_delegation()
Evgeny Vereshchagin [Sun, 3 Feb 2019 05:07:23 +0000 (06:07 +0100)]
travis: stop using the official upstream-systemd-ci repository
Turns out the key for the repository hasn't been propagated properly
so let's restore the kludge that was removed in https://github.com/systemd/systemd/pull/11582.
Of course it's ugly but at least it works.
The issue was kind of reported to the maintainers of the repository
in https://github.com/systemd/systemd/pull/11531#issuecomment-
460023474.
Yu Watanabe [Sun, 3 Feb 2019 03:37:51 +0000 (04:37 +0100)]
test-network: add or drop whitespace
Yu Watanabe [Sun, 3 Feb 2019 03:36:36 +0000 (04:36 +0100)]
test-network: fix test_dhcp_server() and test_ipv6_prefix_delegation()
The tests have been broken since
30d3b54ebad41082e99cabbee815cb113aa0b5c4.
YmrDtnJu [Fri, 1 Feb 2019 10:38:35 +0000 (11:38 +0100)]
shared: Revert commit
49fe5c099 in parts for function parse_acl.
Too much code has been removed while replacing startswith with STARTSWITH_SET
so that every ACL specified e.g. in tmpfiles.d was parsed as a default ACL.
Taro Yamada [Sat, 2 Feb 2019 04:05:42 +0000 (13:05 +0900)]
test: (ArchLinux) Replace initramfs-linux.img with initramfs-linux-fallback.img.
Currently /boot/initramfs-linux.img is used as the default initrd for ArchLinux.
Although, since the kernel modules that are not necessary for the host environment are removed from
initramfs-linux.img by mkinitcpio 's autodetect hook, the kernel modules necessary for qemu may be missing.
(ata_piix, ext4, and so on in my case.)
As a result, the test environment may not be built properly and the test will be failed.
initramfs-linux-fallback.img will skip this autodetect hook, so the test will run successfully in more
environments.
Both initramfs-linux.img and initramfs-linux-fallback.img are generated by default.
Yu Watanabe [Fri, 1 Feb 2019 11:49:26 +0000 (12:49 +0100)]
test-execute: unset $HOME before testing
Otherwise, test for %h specifier may fail.
Fixes #11609.
Lennart Poettering [Wed, 23 Jan 2019 16:00:09 +0000 (17:00 +0100)]
pager: improve english a bit
govwin [Thu, 31 Jan 2019 04:43:14 +0000 (05:43 +0100)]
Add Lenovo Yoga 500-14IBD, 80N4 GlidePoint Touchpad (#11606)
Touchpad size as listed by kernel was 102x28mm. Update changes it to 106x71mm.
User measured (actual size): 108x72mm.
Lennart Poettering [Wed, 30 Jan 2019 18:02:00 +0000 (19:02 +0100)]
More NEWS prep for v241
Susant Sahani [Wed, 30 Jan 2019 11:52:37 +0000 (12:52 +0100)]
test-network: skip erspan test if not available
Evgeny Vereshchagin [Wed, 30 Jan 2019 13:24:18 +0000 (16:24 +0300)]
Merge pull request #11592 from evverx/ignore-memory-leaks-in-dbus
tests: ignore memory leaks in dbus-daemon and also crash PID1 if UBSan is unhappy
Ronnie P. Thomas [Wed, 30 Jan 2019 04:32:05 +0000 (23:32 -0500)]
Fixed minor typo in man/tmpfiles.d.xml
Evgeny Vereshchagin [Wed, 30 Jan 2019 02:16:14 +0000 (03:16 +0100)]
tests: crash PID1 if UBSan is unhappy
Now that https://github.com/systemd/systemd/issues/10332 is unlikely to happen
it should be totally fine to try to crash PID1 :-)
Evgeny Vereshchagin [Wed, 30 Jan 2019 01:19:45 +0000 (02:19 +0100)]
tests: ignore memory leaks in dbus-daemon
Otherwise, the test fails on Fedora 28 with
```
Jan 30 01:42:35 systemd-testsuite dbus-daemon[61]: [system] Successfully activated service 'org.freedesktop.systemd1'
Jan 30 01:42:35 systemd-testsuite systemd[61]: dbus.service: Kernel keyring access prohibited, ignoring.
Jan 30 01:42:35 systemd-testsuite systemd[61]: dbus.service: Executing: /usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation --syslog-only
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: =================================================================
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: ==61==ERROR: LeakSanitizer: detected memory leaks
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: Direct leak of 72 byte(s) in 1 object(s) allocated from:
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #0 0x7f21f9e29088 in __interceptor_realloc (/usr/lib64/libasan.so.5+0xef088)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #1 0x7f21f9b1b23c (/lib64/libdbus-1.so.3+0x3323c)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #2 0x240000001b (<unknown module>)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: Direct leak of 16 byte(s) in 1 object(s) allocated from:
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #0 0x7f21f9e29088 in __interceptor_realloc (/usr/lib64/libasan.so.5+0xef088)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #1 0x7f21f9b1b23c (/lib64/libdbus-1.so.3+0x3323c)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: #2 0x7ffffffff (<unknown module>)
Jan 30 01:42:50 systemd-testsuite dbus-daemon[61]: SUMMARY: AddressSanitizer: 88 byte(s) leaked in 2 allocation(s).
```
The leaks were reported and fixed in https://bugs.freedesktop.org/show_bug.cgi?id=107320.
Evgeny Vereshchagin [Tue, 29 Jan 2019 02:19:43 +0000 (03:19 +0100)]
travis: switch to the "official" systemd-ci repository
Now that add-apt-repository hasn't failed for almost two days on Semaphore
it should be safe to assume that the key has been propagated properly
and the repository is ready to be used on Travis CI.
Lennart Poettering [Tue, 29 Jan 2019 10:27:42 +0000 (11:27 +0100)]
Merge pull request #11540 from taro-yamada/mytest
ReFix #11128
Lennart Poettering [Tue, 29 Jan 2019 10:25:55 +0000 (11:25 +0100)]
Merge pull request #11569 from yuwata/first-step-11307
util-lib: warn if address is specified without prefix length
Yu Watanabe [Mon, 28 Jan 2019 14:47:25 +0000 (15:47 +0100)]
test-network: set missing prefixlen
Yu Watanabe [Mon, 28 Jan 2019 14:29:54 +0000 (15:29 +0100)]
network: warn if Address= is specified without prefixlen
This is the first step for #11307.
Yu Watanabe [Mon, 28 Jan 2019 14:28:05 +0000 (15:28 +0100)]
util: add a new mode for in_addr_prefix_from_string_auto_internal() which refuses address without prefixlen
This also drops in_addr_default_prefix_from_string(), as it is only
used by test-in-addr.
Taro Yamada [Sun, 27 Jan 2019 04:50:04 +0000 (13:50 +0900)]
Add a warning about the difference in permissions between existing directories and unit settings.
To follows the intent of 30c81ce, this change does not execute chmod() and just add warnings.
Lennart Poettering [Mon, 28 Jan 2019 15:57:08 +0000 (16:57 +0100)]
Merge pull request #11580 from yuwata/fix-11579
network/wireguard: fix sending wireguard peers
Franck Bui [Mon, 28 Jan 2019 11:07:37 +0000 (12:07 +0100)]
units: make sure initrd-cleanup.service terminates before switching to rootfs
A follow-up for commit
a8cb1dc3e0fa81aff.
Commit
a8cb1dc3e0fa81aff made sure that initrd-cleanup.service won't be stopped
when initrd-switch-root.target is isolated.
However even with this change, it might happen that initrd-cleanup.service
survives the switch to rootfs (since it has no ordering constraints against
initrd-switch-root.target) and is stopped right after when default.target is
isolated. This led to initrd-cleanup.service entering in failed state as it
happens when oneshot services are stopped.
This patch along with
a8cb1dc3e0fa81aff should fix issue #4343.
Fixes: #4343
Frantisek Sumsal [Sat, 26 Jan 2019 16:03:34 +0000 (17:03 +0100)]
test-barrier: skip the test in virtualized/containerized environments
Yu Watanabe [Mon, 28 Jan 2019 11:27:37 +0000 (12:27 +0100)]
network/wireguard: use sd_netlink_message_append_sockaddr_in{,6}()
Lennart Poettering [Mon, 28 Jan 2019 11:19:36 +0000 (12:19 +0100)]
Merge pull request #11566 from poettering/alloca-assert
add a safety size assert() on most alloca() calls
Yu Watanabe [Mon, 28 Jan 2019 11:19:29 +0000 (12:19 +0100)]
sd-netlink: introduce sd_netlink_message_append_sockaddr_in{,6}()
Yu Watanabe [Mon, 28 Jan 2019 09:09:22 +0000 (10:09 +0100)]
test-network: add more checks in NetworkdNetDevTests.test_wireguard
Yu Watanabe [Mon, 28 Jan 2019 08:42:35 +0000 (09:42 +0100)]
network/wireguard: fixes sending wireguard peer settings
This fixes a bug introduced by
e1f717d4a02e15ae11a191dd4962b2f4d117678d.
Fixes #11579.
Marc-Antoine Perennou [Sun, 27 Jan 2019 16:32:21 +0000 (17:32 +0100)]
kernel-install: fix dracut initrd detection (240 backward compatibility) (#11570)
* kernel-install: fix initrd when called as installkernel
Running make install from the kernel runs e.g.:
installkernel 4.20.5 arch/x86/boot/bzImage System.map "/boot"
Since
0912c0b80eb24fb9a4e1cc4abf274a1358b9943d this would
cal 90-loaderentry.install with those arguments:
add 4.20.5 /boot/... arch/x86/boot/bzImage System.map "/boot"
The two last arguments would then be handled as the initrd files.
As System.map exists in current directory but not in /boot/...
it would get copied there, and used as initrd intead of the initrd
which has been generated by dracut.
With this change, nothing changes when kernel-install is called
directly, but when it's called as installkernel, we now pass
thos arguments to 90-loaderentry.install:
add 4.20.5 /boot/... arch/x86/boot/bzImage initrd
initrd is thus detected as the file to use for the initrd, and as it
exists, nothing is copied over and the initrd line generated is
consistent with what one would expect
* kernel-install: fix dracut initrd detection when called directly
This brings back the systemd 240 behaviour when called directly too
* kernel-install: unify initrd fallback
* kernel-install: move initrd fallback handling to 90-loaderentry.install
* kernel-install: move initrd fallback just before creating loader entry
Taro Yamada [Sun, 27 Jan 2019 04:43:30 +0000 (13:43 +0900)]
Revert "Fixes #11128"
This reverts commit
0bf05f0122f0f13cd0c0bc35a31861875d2ead31 because it breaks 30c81ce.
Please see #11540.
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jan 2019 15:43:20 +0000 (16:43 +0100)]
Merge pull request #11513 from poettering/cryptsetup-msg
improve cryptsetup messaging
Lennart Poettering [Sat, 26 Jan 2019 14:52:18 +0000 (15:52 +0100)]
tree-wide: use newa() instead of alloca() wherever we can
Typesafety is nice. And this way we can take benefit of the new size
assert() the previous commit added.
Lennart Poettering [Sat, 26 Jan 2019 14:42:35 +0000 (15:42 +0100)]
alloc-util: whenever any of our alloca() wrappers is used to allocate overly large memory blocks, hit an assert()
Of course, this should never happen, but let's better be safe than
sorry, and abort rather than continue when a too large memory block is
allocated, simply asa safety precaution.
An early abort is better than continuing with a likely memory corruption
later.
Lennart Poettering [Sat, 26 Jan 2019 14:41:06 +0000 (15:41 +0100)]
Merge pull request #11460 from yuwata/fix-11458
network: update address when static address was already configured by DHCP
Zbigniew Jędrzejewski-Szmek [Thu, 10 Jan 2019 21:29:01 +0000 (22:29 +0100)]
build-sys: bump package/library versions
We added sd_bus_close_unref().
Lennart Poettering [Sat, 26 Jan 2019 13:46:48 +0000 (14:46 +0100)]
Merge pull request #11562 from yuwata/fix-11558
core/mount: do not add Before=local-fs.target or remote-fs.target if nofail mount option is set
Lennart Poettering [Sat, 26 Jan 2019 13:42:02 +0000 (14:42 +0100)]
Merge pull request #11466 from keszybz/fix-loop-remounts
pid1: fix cleanup of stale implicit deps based on /proc/self/mountinfo
Zbigniew Jędrzejewski-Szmek [Thu, 17 Jan 2019 15:09:13 +0000 (16:09 +0100)]
pid1: fix cleanup of stale implicit deps based on /proc/self/mountinfo
The problem was introduced in
a37422045fbb68ad68f734e5dc00e0a5b1759773:
we have a unit which has a fragment, and when we'd update it based on
/proc/self/mountinfo, we'd say that e.g. What=/dev/loop8 has origin-fragment.
This commit changes two things:
- origin-fragment is changed to origin-mountinfo-implicit
- when we stop a unit, mountinfo information is flushed and all deps based
on it are dropped.
The second step is important, because when we restart the unit, we want to
notice that we have "fresh" mountinfo information. We could keep the old info
around and solve this in a different way, but keeping stale information seems
inelegant.
Fixes #11342.
Lennart Poettering [Sat, 26 Jan 2019 12:55:55 +0000 (13:55 +0100)]
Merge pull request #11530 from keszybz/journal-cache-trimming
Journal cache trimming
Lennart Poettering [Sat, 26 Jan 2019 12:55:32 +0000 (13:55 +0100)]
Merge pull request #11545 from xnox/ppc64el
test-functions: fixup PPC64 testing
Lennart Poettering [Sat, 26 Jan 2019 10:37:06 +0000 (11:37 +0100)]
units: drop conditionalization of systemd-tmpfiles-setup-dev.service
Currently, tmpfiles runs in two separate services at boot. /dev is
populated by systemd-tmpfiles-setup-dev.service and everything else by
systemd-tmpfiles-setup.service. The former was so far conditionalized by
CAP_SYS_MODULES. The reasoning was that the primary purpose of
populating /dev was to create device nodes based on the static device
node info exported in kernel modules through MODALIAS. And without the
privs to load kernel modules doing so is unnecessary. That thinking is
incomplete however, as there might be reason to create stuff in /dev
outside of the static modalias usecase. Thus, let's drop the
conditionalization to ensure that tmpfiles.d rules are always executed
at least once under all conditions.
Fixes: #11544
Lennart Poettering [Sat, 26 Jan 2019 11:18:16 +0000 (12:18 +0100)]
nspawn: ignore SIGPIPE for nspawn itself
Let's not abort due to a dead stdout.
Fixes: #11533
Michal Sekletar [Tue, 22 Jan 2019 13:29:50 +0000 (14:29 +0100)]
process-util: don't use overly large buffer to store process command line
Allocate new string as a return value and free our "scratch pad"
buffer that is potentially much larger than needed (up to
_SC_ARG_MAX).
Fixes #11502
Yu Watanabe [Sat, 26 Jan 2019 12:05:27 +0000 (13:05 +0100)]
man: update DefaultDependency= in systemd.mount(5)
Follow-up for
d54bab90e64f70c1ecf9b0683a98adb8485ed09e and the
previous commit.
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 16:30:48 +0000 (17:30 +0100)]
journald: periodically drop cache for all dead PIDs
In normal use, this allow us to drop dead entries from the cache and reduces
the cache size so that we don't evict entries unnecessarily. The time limit is
there mostly to serve as a guard against malicious logging from many different
PIDs.
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 15:12:52 +0000 (16:12 +0100)]
journal: limit the number of entries in the cache based on available memory
This is far from perfect, but should give mostly reasonable values. My
assumption is that if somebody has a few hundred MB of memory, they are
unlikely to have thousands of processes logging. A hundred would already be a
lot. So let's scale the cache size propritionally to the total memory size,
with clamping on both ends.
The formula gives 64 cache entries for each GB of RAM.
Zbigniew Jędrzejewski-Szmek [Sat, 26 Jan 2019 10:27:18 +0000 (11:27 +0100)]
basic/prioq: add prioq_peek_item()
zsergeant77 [Thu, 24 Jan 2019 21:03:30 +0000 (00:03 +0300)]
Update 60-sensor.hwdb
Added mount matrix for Digma CITI E203 hybrid
Yu Watanabe [Sat, 26 Jan 2019 11:00:04 +0000 (12:00 +0100)]
core/mount: do not add Before=local-fs.target or remote-fs.target if nofail mount option is set
Follow-up for
d54bab90e64f70c1ecf9b0683a98adb8485ed09e.
Fixes #11558.
Jonathan Roemer [Sat, 26 Jan 2019 00:46:15 +0000 (18:46 -0600)]
Add missing dash to --all option in the timedatectl man page
Dimitri John Ledkov [Tue, 20 Feb 2018 12:01:40 +0000 (12:01 +0000)]
test/test-functions: on PPC64 use hvc0 console
Dimitri John Ledkov [Mon, 19 Feb 2018 20:47:41 +0000 (20:47 +0000)]
test/test-functions: on PP64 use vmlinux
At least on Ubuntu, ppc64el uses vmlinux-, not vmlinuz. With this, it should be
possible to run qemu tests on ppc64el as part of Ubuntu autopkgtests.
Thomas Haller [Fri, 25 Jan 2019 10:24:06 +0000 (11:24 +0100)]
dhcp/trivial: fix spelling error in comment
Lennart Poettering [Thu, 24 Jan 2019 23:18:45 +0000 (00:18 +0100)]
Merge pull request #11547 from yuwata/network-cosmetic-fixes
network: trivial fix and cleanup
Niklas Hambüchen [Thu, 24 Jan 2019 19:52:01 +0000 (20:52 +0100)]
timesyncd: Improve sync log message. Fixes #11548.
This makes it clear that the user should not expect more log messages
each time the time is synchronised.
Lennart Poettering [Thu, 24 Jan 2019 09:19:33 +0000 (10:19 +0100)]
test-bpf: check if we can mlock() before trying bpf
Yu Watanabe [Thu, 24 Jan 2019 05:33:58 +0000 (14:33 +0900)]
network: fix an error log
Yu Watanabe [Thu, 24 Jan 2019 03:07:41 +0000 (12:07 +0900)]
network: make link_up() static
Lennart Poettering [Mon, 21 Jan 2019 19:19:11 +0000 (20:19 +0100)]
cryptsetup: rework how we log about activation failures
First of all let's always log where the errors happen, and not in an
upper stackframe, in all cases. Previously we'd do this somethis one way
and sometimes another, which resulted in sometimes duplicate logging and
sometimes none.
When we cannot activate something due to bad password the kernel gives
us EPERM. Let's uniformly return this EAGAIN, so tha the next password
is tried. (previously this was done in most cases but not in all)
When we get EPERM let's also explicitly indicate that this probably
means the password is simply wrong.
Fixes: #11498
Lennart Poettering [Mon, 21 Jan 2019 19:20:35 +0000 (20:20 +0100)]
cryptsetup: add comment what EAGAIN means when activating
Lennart Poettering [Mon, 21 Jan 2019 19:19:57 +0000 (20:19 +0100)]
cryptsetup: downgrade a log message we ignore
Lennart Poettering [Mon, 21 Jan 2019 19:14:42 +0000 (20:14 +0100)]
cryptsetup: don't line-break so aggressively
Lennart Poettering [Mon, 21 Jan 2019 19:13:11 +0000 (20:13 +0100)]
cryptsetup: add some commenting about EAGAIN generation
Lennart Poettering [Mon, 21 Jan 2019 19:02:33 +0000 (20:02 +0100)]
cryptsetup: modernize some log message invocations
Lennart Poettering [Mon, 21 Jan 2019 19:01:38 +0000 (20:01 +0100)]
cryptsetup: use free_and_replace() where appropriate
Lennart Poettering [Wed, 23 Jan 2019 22:35:38 +0000 (23:35 +0100)]
Merge pull request #11536 from yuwata/fix-11529
sd-device-monitor: use SO_DETACH_FILTER to remove BPF program
Chris Lamb [Wed, 23 Jan 2019 21:33:29 +0000 (22:33 +0100)]
Correct more spelling errors.
Ayman Bagabas [Tue, 22 Jan 2019 04:50:35 +0000 (23:50 -0500)]
hwdb: fix duplicate events on Huawei MACH-WX9
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
Yu Watanabe [Wed, 23 Jan 2019 06:03:37 +0000 (15:03 +0900)]
test: add test for sd_device_monitor_filter_remove()
Yu Watanabe [Wed, 23 Jan 2019 05:27:17 +0000 (14:27 +0900)]
sd-device-monitor: use SO_DETACH_FILTER to remove BPF program
Fixes #11529.
Filipe Brandenburger [Tue, 22 Jan 2019 19:52:04 +0000 (11:52 -0800)]
README: remove Coverity Scan badge
The badge is currently serving a broken image, since Coverity Scan is currently
having an outage. See Issue #11185 for more details. We can restore the badge
by reverting this commit once their service is up again.
Chris Lamb [Mon, 21 Jan 2019 23:43:22 +0000 (23:43 +0000)]
hwdb: Add support for Purism Librem 13 V4 keyboards
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 14:43:07 +0000 (15:43 +0100)]
procfs-util: expose functionality to query total memory
procfs_memory_get_current is renamed to procfs_memory_get_used, because
"current" can mean anything, including total memory, used memory, and free
memory, as long as the value is up to date.
No functional change.
Louis Taylor [Mon, 21 Jan 2019 21:45:36 +0000 (21:45 +0000)]
meson: make version a dependency and use it in libbasic
This should hopefully ensure it gets generated before basic build
happens.
Fixes #11483.
Lennart Poettering [Tue, 22 Jan 2019 10:57:06 +0000 (11:57 +0100)]
Merge pull request #11501 from yuwata/fix-9426
sd-device: do not save e.g., DEVPATH or INTERFACE properties to udev database
Taro Yamada [Tue, 22 Jan 2019 02:47:45 +0000 (11:47 +0900)]
Fixes #11128
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 09:33:27 +0000 (10:33 +0100)]
hwdb: update
Looks to be additions and corrections again. It seems somebody removed
some whitespace in variuos places by mistake, let's hope this gets corrected
upstream. Doing such corrections downstream is not worth the trouble.
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 09:07:52 +0000 (10:07 +0100)]
Merge pull request #11448 from poettering/rlimit-pid1-fixo
RLIMIT_MEMLOCK fixes
Lennart Poettering [Tue, 22 Jan 2019 08:57:49 +0000 (09:57 +0100)]
resolved: preferably route single-label lookups to unicast DNS scopes with search domains (#11485)
Fixes: #11391
Yu Watanabe [Tue, 22 Jan 2019 06:52:39 +0000 (15:52 +0900)]
man: udevadm: clarify the behavior when multiple matching rules are specified
Closes #2995.
Zbigniew Jędrzejewski-Szmek [Tue, 22 Jan 2019 07:30:26 +0000 (08:30 +0100)]
Merge pull request #11519 from yuwata/udevadm-info-2476
udevadm info: make -P imply -x and update man page
Michal Sekletar [Mon, 21 Jan 2019 22:05:46 +0000 (23:05 +0100)]
man: document db_persist udev rules OPTION
Fixes #1551
Yu Watanabe [Tue, 22 Jan 2019 06:05:55 +0000 (15:05 +0900)]
man: add more explanation about options for "udevadm test"
Closes #2476.
Yu Watanabe [Tue, 22 Jan 2019 06:00:33 +0000 (15:00 +0900)]
udevadm info: make --export-prefix imply --export
Setting --export without --export-prefix is meaningless.
Yu Watanabe [Tue, 22 Jan 2019 03:02:48 +0000 (12:02 +0900)]
core/device: fix log message
Yu Watanabe [Tue, 22 Jan 2019 02:45:40 +0000 (11:45 +0900)]
sd-device: do not save e.g., DEVPATH or INTERFACE properties to udev database
Previously, device_copy_properties() copies all properties to both
sd_device::properties and ::properties_db. Thus, on move uevent,
also tentative properties, e.g. DEVPATH or INTERFACE, are stored to
::properties_db, and saved to udev database.
This makes such tentative properties be copied to only ::properties,
and thus not saved to udev database.
Fixes #9426.
Yu Watanabe [Fri, 18 Jan 2019 22:59:17 +0000 (07:59 +0900)]
wait-online: do not fail if we receive invalid messages
Fixes #11486.
Yu Watanabe [Fri, 18 Jan 2019 03:55:15 +0000 (12:55 +0900)]
network: unset Network::manager when loading .network file fails
Otherwise, LIST_REMOVE() in network_free() fails.
This fixes the following assertion:
```
systemd-networkd[2595]: Bus bus-api-network: changing state UNSET → OPENING
systemd-networkd[2595]: Bus bus-api-network: changing state OPENING → AUTHENTICATING
systemd-networkd[2595]: timestamp of '/etc/systemd/network' changed
systemd-networkd[2595]: /etc/systemd/network/10-hoge.network:1: Invalid section header '[Network]Address=192.168.0.1'
systemd-networkd[2595]: /etc/systemd/network/10-hoge.network:1: Failed to parse file: Bad message
systemd-networkd[2595]: Assertion '*_head == _item' failed at ../../home/watanabe/git/systemd/src/network/networkd-network.c:378, function network_free(). Aborting.
valgrind[2595]: ==2595==
valgrind[2595]: ==2595== Process terminating with default action of signal 6 (SIGABRT): dumping core
valgrind[2595]: ==2595== at 0x4BCA53F: raise (in /usr/lib64/libc-2.28.so)
valgrind[2595]: ==2595== by 0x4BB4894: abort (in /usr/lib64/libc-2.28.so)
valgrind[2595]: ==2595== by 0x4955F09: log_assert_failed_realm (log.c:795)
valgrind[2595]: ==2595== by 0x417101: network_free (networkd-network.c:378)
valgrind[2595]: ==2595== by 0x415E99: network_freep (networkd-network.h:282)
valgrind[2595]: ==2595== by 0x416AB2: network_load_one (networkd-network.c:101)
valgrind[2595]: ==2595== by 0x416C39: network_load (networkd-network.c:293)
valgrind[2595]: ==2595== by 0x414031: manager_load_config (networkd-manager.c:1502)
valgrind[2595]: ==2595== by 0x40B258: run (networkd.c:82)
valgrind[2595]: ==2595== by 0x40B74A: main (networkd.c:117)
valgrind[2595]: ==2595==
valgrind[2595]: ==2595== HEAP SUMMARY:
valgrind[2595]: ==2595== in use at exit: 32,621 bytes in 201 blocks
valgrind[2595]: ==2595== total heap usage: 746 allocs, 545 frees, 241,027 bytes allocated
valgrind[2595]: ==2595==
valgrind[2595]: ==2595== LEAK SUMMARY:
valgrind[2595]: ==2595== definitely lost: 0 bytes in 0 blocks
valgrind[2595]: ==2595== indirectly lost: 0 bytes in 0 blocks
valgrind[2595]: ==2595== possibly lost: 0 bytes in 0 blocks
valgrind[2595]: ==2595== still reachable: 32,621 bytes in 201 blocks
valgrind[2595]: ==2595== suppressed: 0 bytes in 0 blocks
valgrind[2595]: ==2595== Reachable blocks (those to which a pointer was found) are not shown.
valgrind[2595]: ==2595== To see them, rerun with: --leak-check=full --show-leak-kinds=all
valgrind[2595]: ==2595==
valgrind[2595]: ==2595== For counts of detected and suppressed errors, rerun with: -v
valgrind[2595]: ==2595== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
systemd-coredump[2600]: Process 2595 (memcheck-amd64-) of user 192 dumped core.
```
Yu Watanabe [Wed, 16 Jan 2019 22:25:14 +0000 (07:25 +0900)]
man: mention that 'udevadm control --exit' restarts systemd-udevd.service
Closes #1802.
Mike Gilbert [Sun, 20 Jan 2019 16:32:45 +0000 (11:32 -0500)]
test-process-util: do not assume PID 1 has UID=0
Gentoo's Portage package manager uses a PID namespace for process
isolation and cleanup. In this namespace, PID 1 has UID=250 (portage).
Bug: https://bugs.gentoo.org/674458
Jonathon Kowalski [Thu, 17 Jan 2019 18:28:20 +0000 (18:28 +0000)]
Enable some more debug logging for transaction building
Topi Miettinen [Fri, 18 Jan 2019 21:32:28 +0000 (23:32 +0200)]
Document weaknesses with MDWE and suggest hardening
Closes #11473
Frantisek Sumsal [Fri, 18 Jan 2019 19:49:29 +0000 (20:49 +0100)]
test: mark plymouth as optional dependency
rescue.service pulls in /bin/plymouth, which doesn't exist on some
distributions (e.g. Arch Linux). Let's mark it as optional, as it's not
even required by the referencing unit and causes unwanted fails in the
integration testsuite.
Louis Taylor [Fri, 18 Jan 2019 19:40:52 +0000 (19:40 +0000)]
NEWS: add section about backslashes in EnvironmentFile
As a follow-up from #11427.
Frantisek Sumsal [Fri, 18 Jan 2019 21:32:42 +0000 (22:32 +0100)]
meson: bump timeout for test-udev to 180s
On some (mainly virtual) machines the last test takes more than 30
seconds, which causes unnecessary fails, as the test itself is working
properly.
Zbigniew Jędrzejewski-Szmek [Mon, 21 Jan 2019 07:21:27 +0000 (08:21 +0100)]
Revert "hwdb: Fix secondary backslash on MSI GS65 laptop"
This reverts commit
e05c8b44622afe4256f3bb361cfb2c7db32fff8e.
The key in question is labeled as "|\" in the US version, and e.g. "<>" in
European version. In the US version there are two keys with the same label
and they are both mapped to the same keycode. Let's revert the patch, to unbreak
the non-US users.
US users should apply some local work-around, possibly simply keeping the
contents of the patch as a file in hwdb.d/.
Louis Taylor [Fri, 18 Jan 2019 21:41:15 +0000 (21:41 +0000)]
mkosi: add qrencode to arch package list
Before adding this, I got errors about the library being missing such
as:
journalctl: error while loading shared libraries: libqrencode.so.4: cannot open shared object file: No such file or directory
Fixes #7367.