inforithmics [Mon, 20 May 2019 18:00:46 +0000 (20:00 +0200)]
fixes BindableLayout DataTemplate - XamlC #5486 (#6178)
fixes #5651
fixes #5486
* Update TypeReferenceExtensions.cs
Stephane Delcroix [Mon, 20 May 2019 06:57:51 +0000 (08:57 +0200)]
Merge branch '4.0.0'
Stephane Delcroix [Sat, 18 May 2019 12:19:09 +0000 (05:19 -0700)]
move imports to Directory.Build.[props|targets] (#6212)
E.Z. Hart [Fri, 17 May 2019 00:21:16 +0000 (17:21 -0700)]
Height -> Width; fixes #6168 (#6213)
puppetSpace [Wed, 15 May 2019 21:54:13 +0000 (23:54 +0200)]
Created UITest for issue B43527 (#5898)
* Add UITest to issue B43527
* Cleanup of Bugzilla43527
* change unit test to use WaitForNoElement
Rui Marinho [Tue, 14 May 2019 21:19:34 +0000 (14:19 -0700)]
[UITests] Remove flaky test
Kangho Hur [Tue, 14 May 2019 19:30:55 +0000 (04:30 +0900)]
[Tizen] Support new Named Font Sizes for Tizen (#6113)
Rui Marinho [Tue, 14 May 2019 19:29:12 +0000 (12:29 -0700)]
Merge branch '4.0.0'
E.Z. Hart [Tue, 14 May 2019 19:20:29 +0000 (12:20 -0700)]
InvalidateLayout after reload to avoid iOS 10 crash (#6190)
Oliver Brown [Sat, 11 May 2019 19:43:01 +0000 (20:43 +0100)]
Make NSScrollView for NSTableView not draw background, and add test case. (#6050)
fixes #6021
Samantha Houts [Sat, 11 May 2019 19:14:20 +0000 (12:14 -0700)]
Merge branch '4.0.0'
Samantha Houts [Sat, 11 May 2019 19:12:26 +0000 (12:12 -0700)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Sat, 11 May 2019 19:09:10 +0000 (12:09 -0700)]
item template attached, fix icon propagations (#6173)
* item template attached, fix icon propagations
* tabs
Samantha Houts [Sat, 11 May 2019 19:08:21 +0000 (12:08 -0700)]
[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)
* Add repro for #5888
Co-Authored-By: melimion <melimion@users.noreply.github.com>
* [iOS] Fix HasUnevenRows for iOS11+
Co-Authored-By: melimion <melimion@users.noreply.github.com>
fixes #5888
Shane Neuville [Sat, 11 May 2019 19:07:49 +0000 (12:07 -0700)]
remove safe area from inset (#6169)
Rui Marinho [Sat, 11 May 2019 01:33:50 +0000 (18:33 -0700)]
[iOS] Fix NRE when looking for internal buttons (#6170)
Samantha Houts [Fri, 10 May 2019 20:57:55 +0000 (13:57 -0700)]
[iOS] Shell _headerView can apparently be null (#6164)
Samantha Houts [Fri, 10 May 2019 20:38:39 +0000 (13:38 -0700)]
[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText... (#6165)
* [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText
But more concerning is that the `shellIconTextDescription` isn't used at all. Is it leftover code, or is this a mistake?
* [Android] Remove dead code from shellIconTextDescripion
Samantha Houts [Fri, 10 May 2019 04:14:54 +0000 (21:14 -0700)]
Merge branch '4.0.0'
Shane Neuville [Fri, 10 May 2019 04:08:14 +0000 (21:08 -0700)]
stack the elevation of elements (#6108)
* stack the elevation of elements
* only layer implicit elevations
* check elevation of incoming elemelements
* fix api 19
fixes #2989
fixes #3543
Shane Neuville [Fri, 10 May 2019 03:58:04 +0000 (20:58 -0700)]
fix up shell menu items, fix templates, fix bindings (#6117)
* fix up shell menu items, fix templates, fix bindings
* propagate bindingcontext changed on menu items
* address feedback
fixes #4399
fixes #5707
Shane Neuville [Thu, 9 May 2019 21:18:04 +0000 (14:18 -0700)]
Remove experimental flag for shell and change a few apis (#6086) fixes #2415
* api changes for shell official
* Update Xamarin.Forms.Core/Shell/Shell.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellSection.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItem.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix compile errors
* fix ui test
* fix ui test
* removed some more properties
* remove a couple more
Shane Neuville [Thu, 9 May 2019 21:17:30 +0000 (14:17 -0700)]
[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956
* create an actual logical child structure for page to use for propagation
* JustTheLogicalChildren
* only iterate over ActuallyLogicalChildren
* fix naming
* reuse ChildrenNotDrawnByThisElement
* testing
* fix unit test
Shane Neuville [Thu, 9 May 2019 21:16:52 +0000 (14:16 -0700)]
[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109) fixes #3875
* fix the flyout header to size based on content opposed to a fixed height
* update storeshell
* added height slider into storeshell
* resize header if underlying measure changes
* unsubscribe
Adam Patridge [Thu, 9 May 2019 20:06:04 +0000 (14:06 -0600)]
Fix comment typo (#6148)
Samantha Houts [Thu, 9 May 2019 18:00:14 +0000 (11:00 -0700)]
[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)
* Add tests for #6132 and #6130
* [Android] Fix EnableZoomControl BP name and fix helper methods
fixes #6132
fixes #6130
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
Daniel Luberda [Thu, 9 May 2019 17:57:59 +0000 (19:57 +0200)]
[Android] VisualElementRenderer and ElevationHelper should be public (#6131)
* VisualElementRenderer and ElevationHelper should be public
* ElevationHelper.SetElevation should be public
* remove comment
Rui Marinho [Thu, 9 May 2019 17:42:19 +0000 (10:42 -0700)]
[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchHandler (#5810)
* [Shell,iOS] Add Colors, Font , HorizontalAlignment and keyboard support to SearchHandler
* {Android]Allow set colors and customize text on Shell SearchHandler
* [Android] Update icons color on SearchView
* [Android] Update Placeholdericon color from one place
* [iOS] Update shell cancel button colours
* [iOS,Android] Update IconPlaceholder color
* [Core] Fix missing region
* [Controls] Add shell SearchHandlerPage
* [iOS] Fix alignment changes on SearchHandlerAppearanceTraccker
* [Shell,Core] Add focus to SearchHandler
* [Android] Add SearchHandler focus
* [iOS] Add SearchHandler focus
* [Controls] Reuse dynamic gallery for SearchHandler
* [Controls] Fixes to gallery
* [Android] Remove cancel button code
* [Android] Add extension point for SearchHandlerAppearanceTracker
* [Android] Fix spelling
* fix bad merge
fixes #3125
fixes #5768
Pavel Yakovlev [Thu, 9 May 2019 16:49:01 +0000 (19:49 +0300)]
Added memory leak gallery (#5795)
* Added memory leak gallery
* fixes getting content
Pavel Yakovlev [Thu, 9 May 2019 16:20:37 +0000 (19:20 +0300)]
[Android] Fix Frame size (#6115) fixes #5766
Shane Neuville [Thu, 9 May 2019 16:17:59 +0000 (10:17 -0600)]
4.0 ABI Fixes (#6133) fixes #6123
* fix background image type
* additional abi fixes
* updated 4915 to test nav icon
* uwp fixes
* Update Xamarin.Forms.Platform.UAP/TabbedPageStyle.xaml
Rui Marinho [Thu, 9 May 2019 16:14:25 +0000 (09:14 -0700)]
[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items (#5758) fixes #5132
* [Controls,Shell] Add automation properties to FlyoutIcon
* [iOS] Set accessibility properties from flyout icon on ShellPageRenderer
* [Android] Add accessibility features to Shell flyout icon
* [Android] Add accessibility to shell toolbar and button items
* [Controls] Add uitest for issue #5132
* [Controls] Fix uitest android
* [Controls] Use new types
* [UItests] Only run on iOS and Android
Co-Authored-By: rmarinho <me@ruimarinho.net>
* [Controls] Add scrollview to test page
* [Android] Set icon AutomationId using NavigationContentDescription
* [Android] Restore code on AutomationPropertiesProvider
* [Android] Set help text or AutomationID for toolbar navigation content description
* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs
Shane Neuville [Thu, 9 May 2019 07:05:57 +0000 (01:05 -0600)]
[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)
* add DesignerFlyoutRenderer
* private and hack comment
* internal
Shane Neuville [Wed, 8 May 2019 23:15:43 +0000 (17:15 -0600)]
remove route params from shell (#6081)
* remove route params from shell
* Update Xamarin.Forms.Core.UnitTests/ShellTests.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix unit test
Shane Neuville [Wed, 8 May 2019 23:15:18 +0000 (17:15 -0600)]
[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)
* add tab bar and promote implicit tabs to same tabbar
* - remove parent
* remove tab bar from flyout
* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
E.Z. Hart [Wed, 8 May 2019 23:14:18 +0000 (17:14 -0600)]
Make Android CollectionView smarter about recycling elements/renderers (#5980)
kicsiede [Wed, 8 May 2019 17:41:08 +0000 (19:41 +0200)]
[iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)
* Fix: memoryleak when Navigation.RemovePage is used
The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)
* + unit test
* fix issue attribute
E.Z. Hart [Wed, 8 May 2019 16:02:14 +0000 (10:02 -0600)]
[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089) fixes #5793
* Add missing call to ReloadData on INCC Reset; fixes #5793
* Automated test for INCC Reset
kingces95 [Tue, 7 May 2019 20:12:00 +0000 (10:12 -1000)]
Profiler v11; No man init (#6087)
Rui Marinho [Tue, 7 May 2019 17:07:23 +0000 (10:07 -0700)]
Merge branch '4.0.0'
Shane Neuville [Tue, 7 May 2019 16:52:53 +0000 (10:52 -0600)]
Apply round corners shape based on radius (#6099)
* Apply round corners shape based on radius
* update gallery
* apply to SmallComponentShape
* add color scheme back
* basic fixes
* - make corner radius default the same
- reapply theme on ios so corner is changeable
- force set ios border width to size
* fix border width for default and remove extra call to bgcolor
Stephane Delcroix [Tue, 7 May 2019 07:21:27 +0000 (09:21 +0200)]
better exception message (#6101)
Shane Neuville [Tue, 7 May 2019 01:44:00 +0000 (19:44 -0600)]
return from designer earlier (#6102)
* return from designer earlier
* - initialize fake coordinator layout for designer
* change to a non appcompat compatible layout
E.Z. Hart [Mon, 6 May 2019 22:27:43 +0000 (16:27 -0600)]
Update screen size info after orientation change on Android/iOS (#5975)
* Update Android screen size info in Device when changing orientation;
Fixes #4992
* Add test instructions
* Update iOS screen size on orientation change
* Fix build error in UI Test projects
* Fix errors with #if directives in iOS/macOS projects
* Update Xamarin.Forms.Platform.MacOS/MacDeviceInfo.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.Android/Forms.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.iOS/IOSDeviceInfo.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
Andrei Nitescu [Mon, 6 May 2019 21:49:10 +0000 (00:49 +0300)]
Templated view GetTemplateChild(string) (#5691)
* TemplatedView.GetTemplateChild(string)
* Small refactoring
fixes #1620
fixes #5674
closes #5343
Shane Neuville [Mon, 6 May 2019 20:31:06 +0000 (14:31 -0600)]
rename SearchBoxVisibility (#6103)
E.Z. Hart [Mon, 6 May 2019 20:29:27 +0000 (14:29 -0600)]
Hopefully fix the mdoc issues with the localization typo (#6105)
Shane Neuville [Mon, 6 May 2019 17:13:36 +0000 (11:13 -0600)]
[Android] Image load fixes (#6062)
* fix loading for lollipop
* cache
* fix some loading behavior
* requested changes
* cache fixes
* API 19 fix
* fix sizeof and use lazy
* add better management over requests to same key
* add caching validity checks
* remove remove and fire and forget put
* synchronous put
* add disposed check for bitmap data
* max memory
E.Z. Hart [Mon, 6 May 2019 17:05:29 +0000 (11:05 -0600)]
[iOS] Add missing null check to `SelectableItemsViewRenderer.SetupNewElement`. (#6057)
* Reproduction
* Automate test
* Handle null element in SetupElement in the SelectableItemsViewRenderer
Fixes #5949
* Add manual test instructions
* Fix build errors
Stephane Delcroix [Mon, 6 May 2019 09:29:04 +0000 (11:29 +0200)]
Merge branch '4.0.0'
Stephane Delcroix [Tue, 23 Apr 2019 20:03:10 +0000 (22:03 +0200)]
IVT HotReload
Shane Neuville [Fri, 3 May 2019 18:38:46 +0000 (12:38 -0600)]
changes transition to enter mask (#6066)
fixes #5216
Stephane Delcroix [Fri, 3 May 2019 18:29:08 +0000 (20:29 +0200)]
report file location on error (#6024)
Akihiko Odaki [Fri, 3 May 2019 18:25:03 +0000 (03:25 +0900)]
[Xaml[C]] Allow to connect to static event handler (#5119)
jcmanke [Fri, 3 May 2019 18:20:04 +0000 (13:20 -0500)]
Changed error message when Map.ItemTemplate is a DataTemplateSelector to direct the user to the ItemTemplateSelector property (#5944)
Stephane Delcroix [Thu, 2 May 2019 15:51:12 +0000 (17:51 +0200)]
[X] pass the instance along the rlq (#6007)
allow resourceprovider to track lifecycle of xaml-generated object
Shane Neuville [Thu, 2 May 2019 10:26:42 +0000 (04:26 -0600)]
[Android] Fix previewer exceptions with shell (#5955)
* shell preivewer
* nonappcompat hack
* - moove up null check
* internal IsDesignerContext
mkieres [Wed, 1 May 2019 18:42:21 +0000 (04:42 +1000)]
Add B40005 test case (#5912)
fixes #2339
Shane Neuville [Wed, 1 May 2019 16:12:41 +0000 (10:12 -0600)]
retain local variable of page so not collected (#6054)
Morten Nielsen [Wed, 1 May 2019 15:11:46 +0000 (08:11 -0700)]
Adds the image resouces iOS and Android gallery apps already had to UWP (#6000)
Pavel Yakovlev [Wed, 1 May 2019 15:03:30 +0000 (18:03 +0300)]
[UWP] fix ListView renderer (#5144)
James Clancey [Wed, 1 May 2019 14:36:06 +0000 (06:36 -0800)]
Added new named Font Sizes, iOS Named fonts now all AutoScale based on Accessibility Options (#5985) fixes #5474
* Added new named Font Sizes, iOS Named fonts now all AutoScale
We now use the iOS Prefered Font Scaling stuff so fonts are magical
* Added new named font sizes to the FontSizeConverter
Stephane Delcroix [Wed, 1 May 2019 14:23:54 +0000 (16:23 +0200)]
[Core] Simplify App.Current (#5994)
Samantha Houts [Mon, 29 Apr 2019 23:45:21 +0000 (16:45 -0700)]
Merge branch '4.0.0'
Samantha Houts [Mon, 29 Apr 2019 23:42:15 +0000 (16:42 -0700)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Mon, 29 Apr 2019 23:40:12 +0000 (17:40 -0600)]
fix global routes to push onto stack correctly (#6025)
fixes #6016
Muzib [Mon, 29 Apr 2019 21:39:45 +0000 (03:39 +0600)]
Addresses issue #5854 (#5855)
fixes #5854
Carbaholic [Mon, 29 Apr 2019 21:37:41 +0000 (15:37 -0600)]
Fixes _child.Element null reference exception (#5756)
* Fixes _child.Element null reference exception
* Update ListViewRenderer.cs
fixes #5700
ShaneN [Mon, 29 Apr 2019 20:14:45 +0000 (14:14 -0600)]
merge tweaks
ShaneN [Mon, 29 Apr 2019 20:14:19 +0000 (14:14 -0600)]
merge 4.0.0 in master
Shane Neuville [Sat, 27 Apr 2019 19:21:30 +0000 (13:21 -0600)]
additional proguard rules for shell (#6032)
* additional proguard rules for shell
* add property to disable file
fixes #5799
Shane Neuville [Sat, 27 Apr 2019 19:18:33 +0000 (13:18 -0600)]
add check for null track drawable (#6029)
fixes #5970
Shane Neuville [Sat, 27 Apr 2019 19:18:08 +0000 (13:18 -0600)]
[Android] set dialog to null when dismissed (#6031)
fixes #5945
Samantha Houts [Sat, 27 Apr 2019 19:15:39 +0000 (12:15 -0700)]
[Android] Use Fast Renderers by Default (#5926)
* [Android] Unseal FastRenderers
* [Android] Flip experimental flag to legacy flag
* Flip flag for testing both renderers & set up custom renderers for testing
* Undo build arg change
This reverts commit
8447fec03b4dff16d8ca96544ec83159670b80d7.
* Fix whitespace
* restore workaround for #2520
* Only use workaround for fast renderers (crashes legacy)
fixes #5724
Shane Neuville [Sat, 27 Apr 2019 17:48:26 +0000 (11:48 -0600)]
fix tizen obsolete errors (#6030)
Shane Neuville [Sat, 27 Apr 2019 03:29:42 +0000 (21:29 -0600)]
[iOS] remove SetPaddingInsets api and just have it pad content and flyout by default (#5990)
* remove content setting api and just set by default
* - address comments and centralize window insets check
* add check if height < 0
Johannes Egger [Fri, 26 Apr 2019 23:00:59 +0000 (01:00 +0200)]
`WpfHelper.FindChildren`: Pass `forceUsingTheVisualTreeHelper` to recursive calls. (#5922)
fixes #5921
Matthew Leibowitz [Fri, 26 Apr 2019 20:46:13 +0000 (00:46 +0400)]
[WIP] Unify the image handling (#4915)
* Initial code to get unifiied image handling
- not yet tested
- still using FileImageSource in some areas
* Updated the button renderers and added tests for Android
* Updated a few more of the Android renderers
- also added an `IsEmpty` property to the ImageSource to indicate if this source actually contains data that can be used to try and load an image
- added a few more "tests"
- includes the changes for #4916
* A few more changes
* Keep the default page for the sample app
* Changing everything to ImageSource and going from there
- Android, iOS, UWP and WPF are compiling
- GTK, Mac and Tizen are not yet finished
- Added a new interface for UWP to return an IconElement in addition to ImageSource (for app bar buttons)
- not tested yet, nor are there any tests
* Renamed the property to be more useful
* All of Android is now async
- still only minimal tests
- also removed the bits that are in https://github.com/xamarin/Xamarin.Forms/pull/4948
* Update Xamarin.Forms.Platform.cs
* A few fixes to whitespace and nameof()
* Updated iOS and UWP wirth async image sources
* A few fixes and WPF support
* A few fixes for Android after the big merge
* Updated a few more loaders:
- ios
- macos
- tizen
- gtk
* Fix a few things after the merge
* - cast type to FileImageSource
* fix setting of title content if icon doesn't load
* fix IButtonLayoutManager to return correct control
* remove cast and add pack api
* - fix timing issues with layout/invalidation
* - remove aggresive element invalidations for now
* first set of api changes
* obsolete old apis and create new ones for ImageSource
* obsolete messages and static ordering fix
* add tests
* switch default on windows to show images on tabs
* - XStatic obsolete fix
* fix NPC test and bring back alert check on uwp
Fixes #3207
Fixes #4689
Matt Soucoup [Fri, 26 Apr 2019 16:15:04 +0000 (18:15 +0200)]
Add null check in iOS ShadowEffect OnDetached (#5952)
Added a null check in iOS ShadowEffect OnDetached
fixes #5951
Kangho Hur [Mon, 15 Apr 2019 16:55:56 +0000 (01:55 +0900)]
[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)
* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual
* Update Tizen.NET.MaterialComponent for applying color scheme
* Don't build XF.Material.Tzien on iPhone and iPhoneSimulator
* Fix MCanvas build issue
* Update build-windows.yml for XF.Material.Tizen
yourina [Mon, 8 Apr 2019 16:54:41 +0000 (01:54 +0900)]
Add the ShellRenderer for Tizen (#5818)
Shane Neuville [Thu, 25 Apr 2019 00:36:19 +0000 (18:36 -0600)]
Shell hamburger (#5961)
* Draw the hamburger if the user hasn't supplied an icon
* move variable
* remove excess code
* remove public
Shane Neuville [Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)]
fix infinite loops and remove public apis (#5954)
* fix infinite loops and remove public apis
* - remove comments, fix location to not have implicit
* force uri to be relative on ios when no scheme specified
* address PR comments
* add error message
* reformat absolute uris
* additional suggestions
* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
E.Z. Hart [Wed, 24 Apr 2019 18:30:02 +0000 (12:30 -0600)]
Allow CollectionView items to resize with their content (#5905)
* Add gallery for reproing expanding DataTemplate content;
Allow ItemContentView on Android to expand with content;
Allow ItemContentView on iOS to expand with content;
Fixes #5647
* Improve instructions
Fixes #5721
Fixes #5521
* Apply suggestions from code review
Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Clear binding contexts before recycling cells/viewholders.
Pavel Yakovlev [Wed, 24 Apr 2019 02:33:09 +0000 (05:33 +0300)]
[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)
* [Shell, Android] added tab order on Shell flyout menu items
* [iOS mac] fix build
* support iOS
Andrei Nitescu [Wed, 24 Apr 2019 01:00:49 +0000 (04:00 +0300)]
Refactoring Map.ItemsSource to use NotifyCollectionChangedEventArgsExtensions (#5689)
Stanislav [Wed, 24 Apr 2019 00:58:11 +0000 (03:58 +0300)]
[GTK] Fix Padding/Margin properties of Frame element (#5533) (#5764)
Frame's content wrapped into a Gtk.Fixed container since Gtk.Frame itself can't position it's content.
fixes #5533
jcmanke [Wed, 24 Apr 2019 00:57:22 +0000 (19:57 -0500)]
[Maps] Add MapClicked event (#5317)
* Add MapClicked event to Map
* Android MapClicked implementation
* iOS MapClicked implementation
* UWP implementation of MapClicked
* Null check before sending MapClicked event from renderers
* Rewrote MapGallery page in XAML
Samantha Houts [Wed, 24 Apr 2019 00:09:20 +0000 (17:09 -0700)]
Add unit tests for TabIndexExtensions (#5722)
* Add check to FindNextElement
* Add unit tests for TabIndexExtensions
Jonathan Peppers [Tue, 23 Apr 2019 19:21:21 +0000 (14:21 -0500)]
Remove Xamarin.Android.Support.v7.MediaRouter (#5941)
Context: https://github.com/xamarin/xamarin-android/issues/2982
The Blank Xamarin.Forms app template in VS 2019 takes longer to build
than in VS 2017. A little research is showing that this is due to use
of the 28.x support libraries... For example, the build includes ~20
*more* jar files in the template from 2019 than 2017. The
`_CompileDex` step alone goes from ~15.2s to ~18.2s.
This lead me down the road of investigating if we can remove any
support libraries by default in Xamarin.Forms apps. I am also seeing
if there is more we can do in Xamarin.Android for this problem, in
general.
It looks like we can remove:
* Xamarin.Android.Support.v7.MediaRouter
* Xamarin.Android.Support.Media.Compat
Neither of these appear to be used, but have been listed as
dependencies of Xamarin.Forms for a long time.
~~ Results ~~
I made these changes, then did a `Debug` build of
`Xamarin.Forms.ControlGallery.Android.csproj` for comparison.
Comparing dex file sizes (in bytes):
Before:
3428092 classes.dex
3265616 classes2.dex
6693708 total
After:
4938000 classes.dex
1098772 classes2.dex
6036772 total
This looks like it could potentially save ~600KB of compiled dex code
on every Xamarin.Forms app.
Comparing methods:
Before:
classes.dex 11,492 methods
classes2.dex 19,451 methods
total 30,943 methods
After:
classes.dex 22,171 methods
classes2.dex 7,635 methods
total 29,806 methods
~1,137 methods removed, which should help with the dex limit.
Comparing APK sizes (in bytes):
Before:
26442597 AndroidControlGallery.AndroidControlGallery-Signed.apk
After:
25741701 AndroidControlGallery.AndroidControlGallery-Signed.apk
~700KB smaller APK, due to less .NET assemblies & dex code.
Comparing build time (this was using dx):
Before:
19785 ms CompileToDalvik 1 calls
After:
18532 ms CompileToDalvik 1 calls
Looks like it saved over a second of build time for this project.
Seems like an "easy win", let's do this!
Morten Nielsen [Tue, 23 Apr 2019 17:18:19 +0000 (10:18 -0700)]
Avoid LINQ exception (#5933)
* Avoid LINQ exception
If the back button in UWP is pressed, but there's nothing in the backstack, the `Last()` LINQ query will throw `System.InvalidOperationException: 'Sequence contains no elements`
This change avoids that, and just returns false that Forms didn't handle the event.
* Change to use LastOrDefault
Shane Neuville [Tue, 23 Apr 2019 17:13:20 +0000 (11:13 -0600)]
add delay to 2951 (#5972)
E.Z. Hart [Mon, 22 Apr 2019 22:44:12 +0000 (16:44 -0600)]
[UWP] Allow embedding Forms page in secondary window (#5658)
* Make secondary window work in UWP (fixes #2229)
* Update Xamarin.Forms.Core/Internals/Ticker.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
puppetSpace [Mon, 22 Apr 2019 21:05:54 +0000 (23:05 +0200)]
Add UITest for issue 1763 (#5907)
* Add UITest for issue 1763
* Removed restriction for Windows Only. Also added the PreserveAttribute on the classes the test used.
E.Z. Hart [Mon, 22 Apr 2019 00:41:10 +0000 (18:41 -0600)]
Testing a theory about an unreliable memory leak test (#5964)
Rui Marinho [Thu, 18 Apr 2019 15:27:58 +0000 (16:27 +0100)]
Merge branch '4.0.0'
Shane Neuville [Thu, 18 Apr 2019 15:25:58 +0000 (09:25 -0600)]
[Android] move runtime registration of renderers to its own method (#5946)
* move renderer registration to its own method
* - move to static
Shane Neuville [Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)]
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501
* propagate bindingcontext
* - add exception message and fix poorly named xaml file
* add ui test automation
* - fix unit test to represent new code
* - changed from ui test to unit test
* - propagate visual, parent, bc to titleview
* - style fixes
Rui Marinho [Thu, 18 Apr 2019 15:15:48 +0000 (16:15 +0100)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 18 Apr 2019 15:14:47 +0000 (16:14 +0100)]
[Build] Fixes to yaml public build (#5948)
* [Build] Don't sign on public builds
* [Build] Use vmImages
* [Build] Fix pool specification
* [Build] Revert back to pool name
* [Build] add osx demands
* [Build] Fix indentation
* [Build] Add more demands
* [Build] Try using certs
* [Build] Try use name
* cert password
* [Build] Add endpoint back
* [Build] Add VSTS feed as variable
* [Build] Add signing stuff
* Fix
* [Build] Try simplify Windows build
* [Build] Publish android apps
* [Build] Add signVmImage