platform/upstream/gstreamer.git
2 years agowpe: Use `about:blank` as default URL to support only using load-bytes
Thibault Saunier [Tue, 4 Jan 2022 18:49:35 +0000 (15:49 -0300)]
wpe: Use `about:blank` as default URL to support only using load-bytes

WebKit is not going to render anything until a URI is set, leading to a
WPE posting a `WPE View did not render a buffer` error message. To avoid
requiring the user to know it if they only want to use
`wpesrc::load-bytes` we can just use `about:blank` as default and
everything will work as users would expect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1492>

2 years agovalidate:scenario: Support args in the `emit-signal` action
Thibault Saunier [Tue, 4 Jan 2022 17:53:06 +0000 (14:53 -0300)]
validate:scenario: Support args in the `emit-signal` action

This was never needed before but it is generally useful and there
was a todo about it

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1492>

2 years agowebrtc_sendrecv.py: Link pads instead of elements
Nirbheek Chauhan [Wed, 23 Mar 2022 09:59:55 +0000 (15:29 +0530)]
webrtc_sendrecv.py: Link pads instead of elements

This was not a problem here because even if we end up accidentally
linking to the wrong pad, things will work out eventually as long as
one pad-added is emitted for each pad that is added.

But it will be a huge problem if someone copies this code and changes
something that requires different handling for different sorts of
pads. The resultant code will be racy. Let's not do this, it's a bad
example.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2008>

2 years agoREADME: update documentation for macOS
Stéphane Cerveau [Fri, 25 Feb 2022 14:03:11 +0000 (15:03 +0100)]
README: update documentation for macOS

Give hints regarding the certificates
needed by Python.

urllib.error.URLError: urlopen error [SSL ..

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1794>

2 years agofakevideosink,fakeaudiosink: Proxy handoff and preroll-handoff signals
Seungha Yang [Thu, 27 Jan 2022 14:54:34 +0000 (23:54 +0900)]
fakevideosink,fakeaudiosink: Proxy handoff and preroll-handoff signals

Proxy signals for application to be able to consume them

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1585>

2 years agoaom: av1enc: Specify Temporal Unit alignment
Seungha Yang [Fri, 24 Dec 2021 10:49:34 +0000 (19:49 +0900)]
aom: av1enc: Specify Temporal Unit alignment

Encoded bitstream consists of leading Temporal delimiter OBU
with frame, that's Temporal Unit alignment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1471>

2 years agoqsvencoder: Clear caps after debug print
Seungha Yang [Wed, 23 Mar 2022 17:52:45 +0000 (02:52 +0900)]
qsvencoder: Clear caps after debug print

Otherwise debug function will print (null) for alread cleared pointer

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2012>

2 years agoqsvh264enc: Fix profile and level setting in codec data
Seungha Yang [Wed, 23 Mar 2022 17:43:43 +0000 (02:43 +0900)]
qsvh264enc: Fix profile and level setting in codec data

The profile field in SPS is located after header byte

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2012>

2 years agonvcodec: Add new Direct3D11/CUDA mode encoder implementation
Seungha Yang [Tue, 15 Mar 2022 19:58:16 +0000 (04:58 +0900)]
nvcodec: Add new Direct3D11/CUDA mode encoder implementation

Adding new encoder elements nvd3d11{h264,h265}enc for Direct3D11
input support and re-written nvcuda{h264,h265}enc elements.
Newly writeen elements have some differences compared with old
nv{h264,h265}enc including non-backward compatible changes.

* RGBA is not a supported input format any more:
  New elements will support only YUV formats to avoid implicit conversion
  done by hardware. Ideally it should be done by upstream element
  in order to have more control on it. Moreover, RGBA support can cause
  redundant RGBA -> YUV conversion if multiple encoders are
  used for the same RGBA input
* Subsampled planar format support is dropped:
  I420 and YV12 format are not supported formats for Direct3D11.
  Although it's supported in CUDA mode, it's not a hardware friendly
  memory layout and it will waste GPU memory since UV planes
  will have large padding due to the memory layout requirement of NVENC.
* GL support is dropped: Similar to the RGBA case,
  GL support in encoder would be suboptimal if GL input is
  used by multiple encoders, because each encoder will copy GL memory
  into CUDA memory.
  Upstream cudaupload element can be used for GL <-> CUDA
  interop instead.
* No more pre-allocation of encoder input surfaces. New implementation
  will use input CUDA memory without copy (zero-copy) or
  will copy into a NVENC's input buffer struct in case of
  system memory input.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1997>

2 years agoqt: Add touch event support
Vivienne Watermeier [Wed, 23 Feb 2022 11:53:04 +0000 (12:53 +0100)]
qt: Add touch event support

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agogtk: Add touch event support
Vivienne Watermeier [Mon, 21 Feb 2022 19:16:06 +0000 (20:16 +0100)]
gtk: Add touch event support

Add a handler for touch events to gtkbasewidget.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agowpevideosrc: Add touch event support
Vivienne Watermeier [Thu, 10 Feb 2022 09:21:01 +0000 (10:21 +0100)]
wpevideosrc: Add touch event support

Dispatches a list of active touch events to the wpe view on each
received TOUCH_FRAME event. Touch inputs currently only move the cursor,
since wpe doesn't seem to support clicking/scrolling or zooming with
touch input.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agoxvimagesink: Add touch event support
Vivienne Watermeier [Tue, 22 Mar 2022 20:13:31 +0000 (21:13 +0100)]
xvimagesink: Add touch event support

Send touch events for XI_TouchBegin, XI_TouchEnd, and XI_TouchUpdate
events, grouping events with identical timestamps into one TOUCH_FRAME.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agoximagesink: Add touch event support
Vivienne Watermeier [Thu, 3 Feb 2022 14:01:46 +0000 (15:01 +0100)]
ximagesink: Add touch event support

Send touch events for XI_TouchBegin, XI_TouchEnd, and XI_TouchUpdate
events, grouping events with identical timestamps into one TOUCH_FRAME.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agonavigationtest: Display touchscreen events, log all events
Vivienne Watermeier [Wed, 2 Feb 2022 14:46:57 +0000 (15:46 +0100)]
navigationtest: Display touchscreen events, log all events

Represents touchscreen events as a trail of black squares, one for each
reported position. Additionally, this adds the `display-mouse` and
`display-touch` properties to toggle visibility of mouse/touchscreen
events, since touchscreens often emulate mouse events, as well as
logging for all received navigation events.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agonavigation: Add API for touchscreen events
Vivienne Watermeier [Mon, 31 Jan 2022 19:25:23 +0000 (20:25 +0100)]
navigation: Add API for touchscreen events

Add 5 new navigation event types for touchscreen events, with the same
naming and meaning as in libinput - touch-down, touch-motion, touch-up,
touch-frame and touch-cancel - as well as constructors and parse
functions for them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agoall: Use new navigation interface and API
Vivienne Watermeier [Mon, 14 Feb 2022 15:08:23 +0000 (16:08 +0100)]
all: Use new navigation interface and API

Use and implement the new navigation interface in all relevant sink elements,
and use API functions everywhere instead of directy accessing the event structure.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agonavigation: Add coordinate helper functions
Vivienne Watermeier [Mon, 14 Feb 2022 13:22:29 +0000 (14:22 +0100)]
navigation: Add coordinate helper functions

Add a function to get x/y coordinates from suitable navigation events,
and one to create a copy with given coordinate values.

For e.g. translating event coordinates, this avoids having to either
switch on the event type to select the right parse function, or
having to rely on implementation details of the underlying event
structure.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agonavigation: Improve interface to avoid exposing implementation details
Vivienne Watermeier [Mon, 14 Feb 2022 13:06:12 +0000 (14:06 +0100)]
navigation: Improve interface to avoid exposing implementation details

This deprecates the current send_event interface, and the wrapper
functions based on it, replacing it with a send_event_simple interface and
wrapper function. Together with the new event constructors, this avoids
implementations having to directly access the underlying structure.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1633>

2 years agomsdkenc: add macro definitions to avoid the gst-inspect error
Tong Wu [Tue, 22 Mar 2022 02:37:59 +0000 (10:37 +0800)]
msdkenc: add macro definitions to avoid the gst-inspect error

Since the strings are empty for GST_MSDK_CAPS_MAKE_WITH_DMABUF_FEATURE
and GST_MSDK_CAPS_MAKE_WITH_VA_FEATURE, when excuting
gst-inspect-1.0.exe msdkh265enc, there will be convert static caps error
because of the extra semicolon between two empty strings. Now macro
definitions are added to avoid this issue.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2004>

2 years agowavparse: handle query in any parse state
Stéphane Cerveau [Fri, 18 Mar 2022 14:20:49 +0000 (15:20 +0100)]
wavparse: handle query in any parse state

In order to create the stream_id, we need to
pass the query to the default query handler.

If the parse state is different from GST_WAVPARSE_DATA
the query should be passed to the default query
handler.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1987>

2 years agoflvmux: Clean up aggregate's control flow
Jan Alexander Steffens (heftig) [Sun, 13 Sep 2020 00:17:59 +0000 (02:17 +0200)]
flvmux: Clean up aggregate's control flow

This unifies exits to go through a single out label. It mostly
simplifies how EOS is handled.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1035>

2 years agomsdkdec: Check width and height of mfxVideoParam before allocation
Mengkejiergeli Ba [Wed, 26 Jan 2022 06:55:51 +0000 (14:55 +0800)]
msdkdec: Check width and height of mfxVideoParam before allocation

DecodeHeader must be called to fill the mfxVideoParam before allocation,
and thus the check for width and height in mfxVideoParam is necessary.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1817>

2 years agodoc: Update cache after NV12_8L128 addition
Nicolas Dufresne [Fri, 18 Mar 2022 20:34:38 +0000 (16:34 -0400)]
doc: Update cache after NV12_8L128 addition

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1379>

2 years agov4l2: Add NV12_8L128 and NV12_10BE_8L128
Ming Qian [Tue, 19 Oct 2021 06:41:04 +0000 (14:41 +0800)]
v4l2: Add NV12_8L128 and NV12_10BE_8L128

These formats are used by i.MX 8QXP/8QM VPU.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1379>

2 years agovideo: Add support for linear 8x128 NV12 tiles and 10bit BE tiles
Ming Qian [Thu, 12 Aug 2021 03:00:11 +0000 (11:00 +0800)]
video: Add support for linear 8x128 NV12 tiles and 10bit BE tiles

This adds linear 8x128 NV12 based tiles and NV12 10bit big endian tiles.
These formats are used by i.MX 8QXP/8QM VPU and exposed in V4L2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1379>

2 years agov4l2codecs: Fix memory leak
Benjamin Gaignard [Mon, 21 Mar 2022 12:01:03 +0000 (13:01 +0100)]
v4l2codecs: Fix memory leak

Free pending_requests array when releasing decoder to avoid memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2000>

2 years agoav1decoder: Sync duplicate_picture with VP9 one
Daniel Almeida [Wed, 2 Feb 2022 13:05:16 +0000 (10:05 -0300)]
av1decoder: Sync duplicate_picture with VP9 one

Pass the current frame to the duplicate_picture callback. This makes it easier
to set the frame's output_buffer if we already have one available. Also
documented that unlike VP9, it is not optional to implement this as the
picture will populate the DPB if it is a key-frame. To ensure this, remove the
default implementation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1992>

2 years agovp9decoder: Copy system_frame_number in duplicate_picture
Nicolas Dufresne [Fri, 18 Mar 2022 19:59:21 +0000 (15:59 -0400)]
vp9decoder: Copy system_frame_number in duplicate_picture

Just like AV1, copy the system_frame_number from the original picture to make
it clear they reference the same data.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1992>

2 years agocdoecs: av1: Copy system_frame_number in duplicate_picture
Nicolas Dufresne [Wed, 9 Mar 2022 21:35:56 +0000 (16:35 -0500)]
cdoecs: av1: Copy system_frame_number in duplicate_picture

The system_frame_number is notably used by V4L2 decoder as a unique
indentifier for the frame that was decoded. This value is used to tell driver
which frame to reference, as V4L2 does not have an efficient mechanism to
otherwise pass back the frames.

For this reason, and because it is more ligical, copy the original
system_frame_number into the duplicate picture instead of using the current
frame.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1992>

2 years agomeson: va: Define GST_USE_UNSTABLE_API
Seungha Yang [Mon, 21 Mar 2022 13:03:53 +0000 (22:03 +0900)]
meson: va: Define GST_USE_UNSTABLE_API

Remove extra_c_args which is not defined in this meson file at all,
and define GST_USE_UNSTABLE_API to avoid build warnings

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1999>

2 years agortpmanager/rtx: implement initial support for reading/writing rid extensions
Matthew Waters [Thu, 9 Sep 2021 13:43:33 +0000 (23:43 +1000)]
rtpmanager/rtx: implement initial support for reading/writing rid extensions

Two RTP Header extensions are very relevant for rtprtxsend/receive.
1. "urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id": will always be removed
2. "urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id": will be written
    instead of the "rtp-stream-id" header extension.

Currently it's only a simple replacement of one header extension for
another however a future change would only add the relevant extension
based on some heuristics (like, video frames only on one of the rtp key
frame buffers, or only until the rtx ssrc has been validated by the peer)
in order to reduce the required bandwidth.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>

2 years agotest: add tests for sdes-based RTP header extensions
Matthew Waters [Wed, 25 Aug 2021 06:59:40 +0000 (16:59 +1000)]
test: add tests for sdes-based RTP header extensions

mid, stream id and repaired stream id.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>

2 years agortpmanager: add support for RFC8852 (rid) RTP header extensions
Matthew Waters [Wed, 25 Aug 2021 06:58:16 +0000 (16:58 +1000)]
rtpmanager: add support for RFC8852 (rid) RTP header extensions

Both for regular RID and for adding on a repaired (RTX) etc stream.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>

2 years agortpmanager: add support for writing RFC8843 (BUNDLE mid) RTP header extension
Matthew Waters [Wed, 25 Aug 2021 06:38:44 +0000 (16:38 +1000)]
rtpmanager: add support for writing RFC8843 (BUNDLE mid) RTP header extension

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>

2 years agocodecs: av1: Fix state when we show existing keyframe
Nicolas Dufresne [Wed, 16 Mar 2022 17:17:21 +0000 (13:17 -0400)]
codecs: av1: Fix state when we show existing keyframe

Showing existing keyframe have special meaning in AV1. All the references
frame will be refreshed with the original keyframe information. The refresh
process (7.20) is implemented by saving data from the frame_header into the
state. To fix this special case, load all the relevant information into the
frame_header.

As there is nothing happening in between this and the loading of the key-frame
into the state, this patch also remove the separate API function, using it
internally instead.

Fixes #1090

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1971>

2 years agovideocrop: Add support for v210
Sebastian Dröge [Fri, 18 Mar 2022 17:33:00 +0000 (19:33 +0200)]
videocrop: Add support for v210

Like UYVY and similar formats this is rounding down to the start of the
previous macro-pixel to not mix up the different components.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>

2 years agovideocrop: Use GST_ROUND_DOWN_2 instead of re-defining a local version
Sebastian Dröge [Fri, 18 Mar 2022 17:06:05 +0000 (19:06 +0200)]
videocrop: Use GST_ROUND_DOWN_2 instead of re-defining a local version

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>

2 years agovideocrop: Rename PACKED_COMPLEX to PACKED_YVYU
Sebastian Dröge [Fri, 18 Mar 2022 17:03:57 +0000 (19:03 +0200)]
videocrop: Rename PACKED_COMPLEX to PACKED_YVYU

It's not handling any kind of complex packed format, only formats that
are like YVYU.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>

2 years agod3d11: Fix some typos
Jakub Adam [Fri, 18 Mar 2022 12:04:59 +0000 (13:04 +0100)]
d3d11: Fix some typos

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1985>

2 years agovalidate: Totally hide media descriptor node types from the API
Thibault Saunier [Fri, 18 Mar 2022 12:07:48 +0000 (09:07 -0300)]
validate: Totally hide media descriptor node types from the API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1986>

2 years agomeson: Fix warning about build_root() and source_root()
Nirbheek Chauhan [Fri, 18 Mar 2022 08:13:00 +0000 (13:43 +0530)]
meson: Fix warning about build_root() and source_root()

```
../meson.build:384: WARNING: Project targeting '>= 0.60.0' but tried to use feature deprecated since '0.56.0': meson.build_root. use meson.project_build_root() or meson.global_build_root() instead.
../meson.build:385: WARNING: Project targeting '>= 0.60.0' but tried to use feature deprecated since '0.56.0': meson.source_root. use meson.project_source_root() or meson.global_source_root() instead.
...
WARNING: Deprecated features used:
 * 0.56.0: {'meson.source_root', 'meson.build_root'}
 ```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>

2 years agomeson: Bump all meson requirements to 0.60
Nirbheek Chauhan [Fri, 18 Mar 2022 08:12:27 +0000 (13:42 +0530)]
meson: Bump all meson requirements to 0.60

Lots of new warnings ever since
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1934

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>

2 years agoopenexr: Fix some warnings
Nirbheek Chauhan [Fri, 18 Mar 2022 08:07:30 +0000 (13:37 +0530)]
openexr: Fix some warnings

```
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:46:24: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
   46 |   virtual Int64 tellg ();
      |                        ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
   23 | typedef IMATH_NAMESPACE::Int64 Int64;
      |                                ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:47:32: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
   47 |   virtual void seekg (Int64 pos);
      |                                ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
   23 | typedef IMATH_NAMESPACE::Int64 Int64;
      |                                ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:67:26: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
   67 | Int64 MemIStream::tellg ()
      |                          ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
   23 | typedef IMATH_NAMESPACE::Int64 Int64;
      |                                ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:73:29: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
   73 | MemIStream::seekg (Int64 pos)
      |                             ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
   23 | typedef IMATH_NAMESPACE::Int64 Int64;
      |                                ^~~~~
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>

2 years agosubprojects/avtp: Update to latest avtp 0.2.0
Nirbheek Chauhan [Fri, 18 Mar 2022 08:05:56 +0000 (13:35 +0530)]
subprojects/avtp: Update to latest avtp 0.2.0

Fixes some meson warnings too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>

2 years agocodecparsers: av1parser: Fix a typo in FilmGrainParams comment.
He Junyan [Fri, 18 Mar 2022 01:48:46 +0000 (09:48 +0800)]
codecparsers: av1parser: Fix a typo in FilmGrainParams comment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1974>

2 years agodiscoverer: chain up to parent finalize methods in all our types
Matthew Waters [Fri, 18 Mar 2022 09:43:24 +0000 (20:43 +1100)]
discoverer: chain up to parent finalize methods in all our types

Fixes a memory leak:

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x5ac5cd in malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3
    #1 0x1007007 in g_malloc /work/glib-2.72.0/_builddir/../glib/gmem.c:125:13
    #2 0xf82e82 in g_data_set_internal /work/glib-2.72.0/_builddir/../glib/gdataset.c:464:8
    #3 0xf833f7 in g_datalist_id_set_data_full /work/glib-2.72.0/_builddir/../glib/gdataset.c:670:3
    #4 0xef81be in g_object_notify_queue_freeze /work/glib-2.72.0/_builddir/../gobject/gobject.c:295:7
    #5 0xef79c6 in g_object_unref /work/glib-2.72.0/_builddir/../gobject/gobject.c:3632:16
    #6 0x5e58bf in LLVMFuzzerTestOneInput /src/gstreamer/ci/fuzzing/gst-discoverer.c:132:5
    #7 0x4dd1a2 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #8 0x4dc98a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:514:3
    #9 0x4de6c4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:809:5
    #10 0x4dea29 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3
    #11 0x4ce4a0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
    #12 0x4f6f52 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #13 0x7f1c709980b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1984>

2 years agod3d11screencapturesrc: Allow capturing screen sub-area
Jakub Adam [Thu, 10 Mar 2022 16:37:26 +0000 (17:37 +0100)]
d3d11screencapturesrc: Allow capturing screen sub-area

Adds crop-x, crop-y, crop-width, crop-height properties specifying the
screen area to capture.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1932>

2 years agowebrtcbin: Warn when offer didn't intersect with transceiver caps
Nirbheek Chauhan [Tue, 15 Mar 2022 11:31:59 +0000 (17:01 +0530)]
webrtcbin: Warn when offer didn't intersect with transceiver caps

We were silently falling back to creating a recvonly offer if the caps
didn't intersect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc-sendrecv: Fix create-answer caps negotiation
Nirbheek Chauhan [Tue, 15 Mar 2022 11:01:56 +0000 (16:31 +0530)]
webrtc-sendrecv: Fix create-answer caps negotiation

We need to parse the payload type map provided by the offer SDP and
set those values on the payloader, otherwise webrtcbin will create
a recvonly answer SDP and we won't send anything to the browser.

Fixed it for both C and Python sendrecv examples.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Add picture-id-mode to rtpvp8pay
Nirbheek Chauhan [Tue, 15 Mar 2022 08:30:48 +0000 (14:00 +0530)]
webrtc_sendrecv.py: Add picture-id-mode to rtpvp8pay

This doesn't just make TWCC stats perform better, it also fixes
stuttery video playback in Chrome.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Print an error on unknown JSON message
Nirbheek Chauhan [Sat, 5 Mar 2022 15:03:48 +0000 (20:33 +0530)]
webrtc_sendrecv.py: Print an error on unknown JSON message

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Add missing copyright headers
Nirbheek Chauhan [Sat, 5 Mar 2022 14:51:53 +0000 (20:21 +0530)]
webrtc_sendrecv.py: Add missing copyright headers

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Implement all negotiation modes
Nirbheek Chauhan [Sat, 5 Mar 2022 14:36:37 +0000 (20:06 +0530)]
webrtc_sendrecv.py: Implement all negotiation modes

Earlier, the example only supported one negotiation mode:
* Browser client is running, gstreamer starts a call and sends offer

Now these three modes are also supported:
* Browser client is running, gstreamer starts a call and sends an
  offer request
* gstreamer connects and waits for browser client to start a call and
  send an offer
* gstreamer connects and waits for browser client to start a call and
  send an offer request

The following features are still missing:
* Data channel support
* TWCC support + stats logging

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Make it executable
Nirbheek Chauhan [Tue, 1 Mar 2022 18:37:52 +0000 (00:07 +0530)]
webrtc_sendrecv.py: Make it executable

Why wasn't it already. Tired of typing 'python webrtc_sendrecv.py'.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Fix event loop usage for messages
Nirbheek Chauhan [Tue, 1 Mar 2022 18:33:29 +0000 (00:03 +0530)]
webrtc_sendrecv.py: Fix event loop usage for messages

Instead of creating a new loop, we should just be fetching the running
loop, then doing a blocking network call inside the callback, schedule
it on the event loop. This is what the C example does too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agowebrtc_sendrecv.py: Use default arg for server URL
Nirbheek Chauhan [Tue, 1 Mar 2022 18:23:32 +0000 (23:53 +0530)]
webrtc_sendrecv.py: Use default arg for server URL

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>

2 years agoci/fuzzing: update glib version to 2.72.0
Matthew Waters [Fri, 18 Mar 2022 07:35:05 +0000 (18:35 +1100)]
ci/fuzzing: update glib version to 2.72.0

Fixes an issue where on configure, glib's internal gnulib was tripping
up the undefined behaviour sanitizer with a divide by 0.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1976>

2 years agoglvideomixerelement: send translated navigation events to the relevant sink pads
Vivienne Watermeier [Mon, 17 Jan 2022 15:10:37 +0000 (16:10 +0100)]
glvideomixerelement: send translated navigation events to the relevant sink pads

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1495>

2 years agocompositor: send translated navigation events to the relevant sink pads
Vivienne Watermeier [Wed, 5 Jan 2022 18:33:06 +0000 (19:33 +0100)]
compositor: send translated navigation events to the relevant sink pads

Fixes #888

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1495>

2 years agoci/fuzzling: fix oss-fuzz build
Matthew Waters [Fri, 18 Mar 2022 02:16:42 +0000 (13:16 +1100)]
ci/fuzzling: fix oss-fuzz build

gst-plugins-base doesn't have a cairo option anymore.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1975>

2 years agovalidate: Cleanup ABI and make it ready to be stabilized this cycle
Thibault Saunier [Mon, 7 Mar 2022 20:21:48 +0000 (17:21 -0300)]
validate: Cleanup ABI and make it ready to be stabilized this cycle

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Introspect gst-validate-runner.c
Thibault Saunier [Mon, 7 Mar 2022 19:29:19 +0000 (16:29 -0300)]
validate: Introspect gst-validate-runner.c

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Add getters for ValidateReports
Thibault Saunier [Thu, 3 Mar 2022 01:21:40 +0000 (22:21 -0300)]
validate: Add getters for ValidateReports

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Change IssueId type to guint32
Philippe Normand [Wed, 2 Mar 2022 12:52:37 +0000 (12:52 +0000)]
validate: Change IssueId type to guint32

Which is a bit more bindings-friendly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: ssim: Respect requested dump recurrence parameter
Philippe Normand [Wed, 2 Mar 2022 10:54:17 +0000 (10:54 +0000)]
validate: ssim: Respect requested dump recurrence parameter

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Keep scenario alive enough when executing actions
Philippe Normand [Wed, 2 Mar 2022 10:27:10 +0000 (10:27 +0000)]
validate: Keep scenario alive enough when executing actions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Introspection annotation cleanups
Philippe Normand [Wed, 2 Mar 2022 13:11:43 +0000 (13:11 +0000)]
validate: Introspection annotation cleanups

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Fix padding and constants
Philippe Normand [Mon, 28 Feb 2022 10:58:41 +0000 (10:58 +0000)]
validate: Fix padding and constants

Without this the Rust -sys validate crate tests don't pass.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Expose all public headers in main header
Philippe Normand [Mon, 28 Feb 2022 10:57:55 +0000 (10:57 +0000)]
validate: Expose all public headers in main header

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agovalidate: Fix pkgconfig name
Philippe Normand [Mon, 28 Feb 2022 10:56:59 +0000 (10:56 +0000)]
validate: Fix pkgconfig name

Making it consistent with the reset of GStreamer. This also means that
anyone wanting to target -validate >= 1.22 needs to change the way they
link against it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>

2 years agortpjitterbuffer: Fix invalid memory access in rtp_jitter_buffer_pop()
Sangchul Lee [Tue, 15 Mar 2022 06:44:17 +0000 (15:44 +0900)]
rtpjitterbuffer: Fix invalid memory access in rtp_jitter_buffer_pop()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1973>

2 years agodocumentation: improve misleading wording
Vivienne Watermeier [Wed, 23 Feb 2022 16:39:18 +0000 (17:39 +0100)]
documentation: improve misleading wording

The documentation for several gst_*_writable_structure functions stated
that they would never return NULL, without making clear that the passed
object is required to be writable. This changes the wording in those
cases to make that requirement more clear.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1784>

2 years agoccconverter: drop data with a warning if scratch buffers overflow
Matthew Waters [Thu, 17 Mar 2022 02:36:25 +0000 (13:36 +1100)]
ccconverter: drop data with a warning if scratch buffers overflow

Instead of asserting which could bring down the entire application.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1972>

2 years agov4l2videodec: set frame duration according to framerate
Hou Qi [Mon, 14 Mar 2022 08:19:33 +0000 (16:19 +0800)]
v4l2videodec: set frame duration according to framerate

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1953>

2 years agouri: Build doubly-linked list by prepending items
Philippe Normand [Thu, 10 Mar 2022 18:22:49 +0000 (18:22 +0000)]
uri: Build doubly-linked list by prepending items

As outlined in the API documentation, g_list_append() iterates over the whole
list, which can quickly introduce performance issues when the list becomes very
big, such as for data URIs for instance.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1909>

2 years agotypefind: Skip parsing of data URIs
Philippe Normand [Tue, 8 Mar 2022 12:04:41 +0000 (12:04 +0000)]
typefind: Skip parsing of data URIs

Commit a46ab2ced20d757e0e770d4de1edc3a152cc4f2f introduced a regression,
breaking typefinding for media content muxed in mp4 container and serialized to
data URIs. For this case it doesn't make sense to look for a file extension, so
skip URI parsing.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1909>

2 years agobasesink: Fix annotations
Corentin Noël [Tue, 15 Mar 2022 13:00:06 +0000 (14:00 +0100)]
basesink: Fix annotations

We should annotate the Class and not the object itself.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>

2 years agogst-plugins-base: Fix several annotations
Corentin Noël [Tue, 15 Mar 2022 12:59:16 +0000 (13:59 +0100)]
gst-plugins-base: Fix several annotations

Add annotations for virtual methods when possible.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>

2 years agovalidate: Fix typo in get_reports
Corentin Noël [Tue, 15 Mar 2022 12:57:11 +0000 (13:57 +0100)]
validate: Fix typo in get_reports

Return without s isn't taken into account for the introspection.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>

2 years agortspsrc: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer
Tim-Philipp Müller [Tue, 15 Mar 2022 13:49:09 +0000 (13:49 +0000)]
rtspsrc: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer

When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.

This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>

2 years agortpbin: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer
Tim-Philipp Müller [Tue, 15 Mar 2022 11:56:28 +0000 (11:56 +0000)]
rtpbin: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer

When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.

This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>

2 years agortpjitterbuffer: add "add-reference-timestamp-meta" property
Tim-Philipp Müller [Tue, 15 Mar 2022 01:35:17 +0000 (01:35 +0000)]
rtpjitterbuffer: add "add-reference-timestamp-meta" property

When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.

This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>

2 years agowpe: Reintroduce persistent WebContext
Philippe Normand [Fri, 11 Mar 2022 17:02:55 +0000 (17:02 +0000)]
wpe: Reintroduce persistent WebContext

A WebContext leak was introduced in MR
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2252.
If we wanted one WebContext per WebView we should also unref the
WebKitWebContext when destroying the WebView.

This patch reintroduces the persistent WebContext, initially part of
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1484.

Fixes #1084

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1933>

2 years agoopusenc: change default bitrate-type from cbr to constrained-vbr
Tim-Philipp Müller [Thu, 16 Dec 2021 18:41:38 +0000 (18:41 +0000)]
opusenc: change default bitrate-type from cbr to constrained-vbr

Which is the default in libopus itself as well, with a comment
that constrained-vbr is considered "safer for real-time use".

Unclear why CBR was the default in the first place.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1451>

2 years agowebrtcbin: fix deadlock when setting up FEC encoder
Mathieu Duponchelle [Tue, 15 Mar 2022 23:05:19 +0000 (00:05 +0100)]
webrtcbin: fix deadlock when setting up FEC encoder

We bind transceivers' fec_percentage property to the FEC encoder
percentage property, and with the binding bidirectional a deadlock
was introduced by the latest changes from !1762:

We take hold of the transceiver's object lock, then add the binding
and set the property to its initial value on the encoder, which causes
set_property to deadlock in the transceiver when the binding kicks in.

Changing the binding type to DEFAULT (source to target) is enough
to address the deadlock and still serves the original intent.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1967>

2 years agodoc: handy-elements: fix audiotestsrc description
MGlolenstine [Tue, 15 Mar 2022 15:01:39 +0000 (15:01 +0000)]
doc: handy-elements: fix audiotestsrc description

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1966>

2 years agowebrtcbin: Check data channel transport for notifying 'ice-gathering-state'
Sangchul Lee [Thu, 10 Mar 2022 10:22:52 +0000 (19:22 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'

Previously, it did not care about data channel's. It is fixed by adding
some conditions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1957>

2 years agortpbuffer: The out args for rtp extension data are optional
Nirbheek Chauhan [Tue, 15 Mar 2022 07:27:49 +0000 (12:57 +0530)]
rtpbuffer: The out args for rtp extension data are optional

The code checks that these are != NULL before dereferencing them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1962>

2 years agov4l2videodec: safely retrun from video_dec_loop with stream unlock
Hou Qi [Tue, 15 Mar 2022 01:49:59 +0000 (09:49 +0800)]
v4l2videodec: safely retrun from video_dec_loop with stream unlock

This is to avoid decoder hang when doing trick play between
different resolutions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1960>

2 years agortpjitterbuffer: Improve accuracy of RFC7273 clock time calculations
Sebastian Dröge [Mon, 14 Mar 2022 11:59:37 +0000 (13:59 +0200)]
rtpjitterbuffer: Improve accuracy of RFC7273 clock time calculations

Previously the result of the calculations included inaccuracies caused
by the NTP clock estimation, which caused the timestamps to jitter
+/- 1/clockrate.

By reorganizing the calculations it is possible to get rid of this
inaccuracy and calculate deterministic and exact packet timestamps based
on the actual NTP clock as long as the estimation is not off by more
than 2**31 clockrate units.

The only remaining inaccuracy that is introduced now is caused by the
conversion from the NTP clock to the pipeline clock.

Also split up debug output, demote many messages to the trace debug
level and output more intermediate results.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1955>

2 years agotwcc: Add some logging to debug TWCC feedback
Nirbheek Chauhan [Mon, 14 Mar 2022 06:59:04 +0000 (12:29 +0530)]
twcc: Add some logging to debug TWCC feedback

This should allow people to debug when TWCC feedback is not enabled
because they haven't set the extmap in the caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1952>

2 years agotwcc: Note that packet-loss-pct can count reordering as loss
Nirbheek Chauhan [Mon, 14 Mar 2022 08:15:36 +0000 (13:45 +0530)]
twcc: Note that packet-loss-pct can count reordering as loss

This is difficult to encounter in ordinary networks, but is
encountered when using tc-netem to add random delays to packets, and
also when your UDP stream is bonded over multiple links with varying
characteristics.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1952>

2 years agonvcodec: Move CUDA <-> GL, D3D11, NVMM copy function to utils
Seungha Yang [Sun, 13 Mar 2022 16:19:53 +0000 (01:19 +0900)]
nvcodec: Move CUDA <-> GL, D3D11, NVMM copy function to utils

This method can be used in other elements as well.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1945>

2 years agonvh265sldec: Add support for delayed output
Seungha Yang [Fri, 11 Mar 2022 16:12:25 +0000 (01:12 +0900)]
nvh265sldec: Add support for delayed output

Delay 4 frames in case of non-live to improve throughput

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>

2 years agoh265decoder: Add support for delayed output
Seungha Yang [Sat, 12 Mar 2022 12:54:45 +0000 (21:54 +0900)]
h265decoder: Add support for delayed output

Functionally identical to the other decoder baseclasses.
Delayed output can improve throughput depending on decoding APIs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>

2 years agoh265decoder: Update documentation
Seungha Yang [Fri, 11 Mar 2022 15:53:04 +0000 (00:53 +0900)]
h265decoder: Update documentation

Sync up with other baseclasses

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>

2 years agoh265decoder: Drain decoder on new_sequence()
Seungha Yang [Fri, 11 Mar 2022 19:45:22 +0000 (04:45 +0900)]
h265decoder: Drain decoder on new_sequence()

Holding previously decoded but not outputted pictures even after
new_sequence is not a safe approach in various aspect.
However, we cannot drain out DPB on new_sequence() unconditionally,
because there is a case where decoder should drop decoded pictures
if NoOutputOfPriorPicsFlag is set.

To detect NoOutputOfPriorPicsFlag before the new_sequence() call,
this patch splits decoding process into two path, one for nal unit parsing
in order to detect NoOutputOfPriorPicsFlag and then each nal unit
will be decoded.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>

2 years agoh265decoder: Remove unused pts variable
Seungha Yang [Fri, 11 Mar 2022 18:15:48 +0000 (03:15 +0900)]
h265decoder: Remove unused pts variable

We can know timestamp from associated GstVideoCodecFrame

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>

2 years agoconvertframe: Add support for GL-memory backend GstFrame input
Bastien Nocera [Thu, 10 Mar 2022 09:25:53 +0000 (10:25 +0100)]
convertframe: Add support for GL-memory backend GstFrame input

Add "gldownload" early in the pipeline so that GL-memory backed raw
frames can be downloaded and processed on the CPU.

Closes: #1073
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1916>