Wim Taymans [Tue, 7 Jan 2014 11:14:15 +0000 (12:14 +0100)]
stream: add method to check supported transport
Add a method to check if a transport is supported
Sebastian Dröge [Fri, 27 Dec 2013 12:11:45 +0000 (13:11 +0100)]
configure.ac: Only check for gstreamer-check, not check
We include check in gstreamer-check since quite some time now.
Wim Taymans [Thu, 26 Dec 2013 16:02:50 +0000 (17:02 +0100)]
stream: return clock-rate from get_rtpinfo
And use it to correct the rtptime to the requested start-time.
See https://bugzilla.gnome.org/show_bug.cgi?id=712198
Wim Taymans [Thu, 26 Dec 2013 15:28:59 +0000 (16:28 +0100)]
session-media: calculate start-time
Wim Taymans [Thu, 26 Dec 2013 13:43:35 +0000 (14:43 +0100)]
stream: also return the running-time
Return the running-time in the rtpinfo as well.
Wim Taymans [Thu, 26 Dec 2013 14:41:14 +0000 (15:41 +0100)]
session-media: let the session-media make the RTPInfo
Add method to create the RTPInfo for a stream-transport.
Add method to create the RTPInfo for all stream-transports in a
session-media.
Use the session-media RTPInfo code in client. This allows us to refactor
another method to link the TCP callbacks.
Aleix Conchillo Flaqué [Sat, 21 Dec 2013 00:39:07 +0000 (16:39 -0800)]
mount-points: sort sequence before g_sequence_lookup
* gst/rtsp-server/rtsp-mount-points.c (gst_rtsp_mount_points_remove_factory):
sort sequence if dirty, otherwise lookup will fail.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720855
Tim-Philipp Müller [Sun, 22 Dec 2013 23:16:56 +0000 (23:16 +0000)]
configure: rename package from gst-rtsp to gst-rtsp-server
To match git module name and avoid confusion with the
rtsp lib in gst-plugins-base and rtsp plugin in -good.
Tim-Philipp Müller [Sun, 22 Dec 2013 23:15:02 +0000 (23:15 +0000)]
configure: bump core/base/good requirement to 1.2.0
Bump to released stable version and make implicit
requirements explicit.
Tim-Philipp Müller [Sun, 22 Dec 2013 23:04:48 +0000 (23:04 +0000)]
Fix broken gettext setup which is not used anyway
Tim-Philipp Müller [Sun, 22 Dec 2013 22:36:06 +0000 (22:36 +0000)]
Automatic update of common submodule
From dbedaa0 to d48bed3
Aleix Conchillo Flaqué [Wed, 18 Dec 2013 15:37:27 +0000 (16:37 +0100)]
media: add setup_sdp vmethod
gst/rtsp-server/rtsp-media.[ch]: added setup_sdp vmethod and public
gst_rtsp_media_setup_sdp.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720155
Edward Hervey [Thu, 19 Dec 2013 13:26:34 +0000 (14:26 +0100)]
rtsp-stream: Check return value of sscanf
streamid is only valid if sscanf matched something.
Edward Hervey [Thu, 19 Dec 2013 13:24:54 +0000 (14:24 +0100)]
rtsp-client: Fix iteration
Wouldn't even enter the code block otherwise (i++ was used as the check
and not the postfix).
Wim Taymans [Wed, 18 Dec 2013 14:57:03 +0000 (15:57 +0100)]
client: add vmethod to configure media and streams
Implement a vmethod that can be used to configure the media and the
streams based on the current context. Handle the blocksize handling in
the default handler.
See https://bugzilla.gnome.org/show_bug.cgi?id=720667
Tim-Philipp Müller [Thu, 12 Dec 2013 00:38:07 +0000 (00:38 +0000)]
Make git ignore more unit test binaries
Tim-Philipp Müller [Thu, 12 Dec 2013 00:36:07 +0000 (00:36 +0000)]
rtsp-server: add padding to many public structures
Not mini objects though, since they are not subclassable
anyway, nor kept on the stack or inlined in a structure.
Aleix Conchillo Flaqué [Tue, 3 Dec 2013 19:54:42 +0000 (11:54 -0800)]
media: add new create_rtpbin vmethod
* gst/rtsp-server/rtsp-media.[ch]: add new create_rtpbin vmethod.
https://bugzilla.gnome.org/show_bug.cgi?id=719734
Sebastian Rasmussen [Mon, 2 Dec 2013 23:34:52 +0000 (00:34 +0100)]
tests: fix memory leak, free test's thread pool
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=719733
Wim Taymans [Fri, 29 Nov 2013 14:50:52 +0000 (15:50 +0100)]
stream-transport: free url in finalize
Ognyan Tonchev [Fri, 29 Nov 2013 14:50:23 +0000 (15:50 +0100)]
media: also do state change in suspended state
Wim Taymans [Fri, 29 Nov 2013 09:53:08 +0000 (10:53 +0100)]
media: also handle prepare and range in suspended state
When we are suspended, we are already prepared.
We can get the range in the suspended state.
Branko Subasic [Wed, 27 Nov 2013 14:04:04 +0000 (15:04 +0100)]
check: add test for uri in setup
Added unit tests for the new functionality in GstRTSPStreamTransport.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=715168
Wim Taymans [Thu, 28 Nov 2013 16:47:18 +0000 (17:47 +0100)]
client: store setup uri and use in PLAY response
Store the uri used when doing the setup and use that in the PLAY
response.
fixes https://bugzilla.gnome.org/show_bug.cgi?id=715168
Wim Taymans [Thu, 28 Nov 2013 16:35:45 +0000 (17:35 +0100)]
stream-transport: add method to get/set url
Wim Taymans [Thu, 28 Nov 2013 13:14:35 +0000 (14:14 +0100)]
client: suspend after SDP and unsuspend before PLAYING
Based on patches by Ognyan Tonchev <ognyan@axis.com>
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711257
Wim Taymans [Thu, 28 Nov 2013 13:10:19 +0000 (14:10 +0100)]
media: add suspend modes
Add support for different suspend modes. The stream is suspended right after
producing the SDP and after PAUSE. Different suspend modes are available that
affect the state of the pipeline. NONE leaves the pipeline state unchanged and
is the current and old behaviour, PAUSE will set the pipeline to the PAUSED
state and RESET will bring the pipeline to the NULL state.
A stream is also unsuspended when it goes back to PLAYING, for RESET streams,
this means that the pipeline needs to be prerolled again.
Base on patches by Ognyan Tonchev <ognyan@axis.com>
See https://bugzilla.gnome.org/show_bug.cgi?id=711257
Wim Taymans [Thu, 28 Nov 2013 13:06:53 +0000 (14:06 +0100)]
media: start live streams in blocked state
Start live streams in the blocked state and make them preroll using the
messages. This ensure that no data is played by the sink until we explicitly
unblock the stream right before going to PLAYING.
See https://bugzilla.gnome.org/show_bug.cgi?id=711257
Wim Taymans [Thu, 28 Nov 2013 12:58:05 +0000 (13:58 +0100)]
media: refactor starting and waiting for preroll
Based on patches from Ognyan Tonchev <ognyan@axis.com>
See https://bugzilla.gnome.org/show_bug.cgi?id=711257
Wim Taymans [Thu, 28 Nov 2013 12:42:21 +0000 (13:42 +0100)]
stream: add API to block streams
Add an API to block on the streams and make it post a message.
Based on patch by Ognyan Tonchev <ognyan@axis.com>
See https://bugzilla.gnome.org/show_bug.cgi?id=711257
Edward Hervey [Wed, 27 Nov 2013 14:42:45 +0000 (15:42 +0100)]
docs: Specify the override file
Even if it's empty (for now) it avoids make distcheck complaining
Wim Taymans [Tue, 26 Nov 2013 16:23:04 +0000 (17:23 +0100)]
media: move default implementations to where they are used
Wim Taymans [Tue, 26 Nov 2013 15:25:37 +0000 (16:25 +0100)]
media: take the right lock in gst_rtsp_media_set_pipeline_state()
We need to take the state_lock when calling this method.
Wim Taymans [Tue, 26 Nov 2013 15:24:35 +0000 (16:24 +0100)]
media: handle add-added on non-bins too
Handle dynamic payloaders that are not bins, as used in the unit-test.
Sebastian Rasmussen [Fri, 22 Nov 2013 00:30:53 +0000 (01:30 +0100)]
rtsp-media/-factory: Fix request pad name comments
These must be escaped for gtk-doc to parse the comments without warnings.
Aleix Conchillo Flaque [Wed, 20 Nov 2013 23:51:54 +0000 (15:51 -0800)]
rtsp-media: remove transports if media is in error status
* gst/rtsp-server/rtsp-media.c (gst_rtsp_media_set_state): if we are
trying to change to GST_STATE_NULL and media is in error status, we
remove all transports.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712776
Wim Taymans [Fri, 22 Nov 2013 10:16:20 +0000 (11:16 +0100)]
rtsp-media: use element metadata to find payloader
Use the element metadata to find the payloader instead of checking
for the base class.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712396
Aleix Conchillo Flaque [Fri, 15 Nov 2013 20:14:32 +0000 (12:14 -0800)]
rtsp-stream: add getter for payload type
* gst/rtsp-server/rtsp-stream.c: add new method gst_rtsp_stream_get_pt.
* gst/rtsp-server/rtsp-media.c (pad_added_cb): find real payloader
element and create the stream with this one instead of the dynpay%d
element.
https://bugzilla.gnome.org/show_bug.cgi?id=712396
Sebastian Rasmussen [Fri, 22 Nov 2013 01:28:28 +0000 (02:28 +0100)]
rtsp-*: Refer to NULL as a constant in comments
Plus one typo fix.
https://bugzilla.gnome.org/show_bug.cgi?id=714988
Sebastian Rasmussen [Fri, 22 Nov 2013 02:10:01 +0000 (03:10 +0100)]
rtsp-*: Fix type name typos in comments
* rtsp-auth: Refer to GstRTSPToken, not GstRTSPtoken
* rtsp-auth: Refer to part of constant name as text
* rtsp-auth/-permissions/-token: Refer to Permissions not Permission
* rtsp-session-media: Fix GstRTSPSessionMedia typo
* rtsp-stream: Fix typo when refering to GstBin
https://bugzilla.gnome.org/show_bug.cgi?id=714988
Sebastian Rasmussen [Thu, 21 Nov 2013 23:45:17 +0000 (00:45 +0100)]
docs: Improve documentation
* Include annotation-glossary to quiet gtk-doc
* Rename remaining ClientState -> Context
* Rename object hierarchy file
* Remove stale chapter references
* Add missing function and object references
* Include missing GstRTSPAddressPoolResult
https://bugzilla.gnome.org/show_bug.cgi?id=714988
Tim-Philipp Müller [Mon, 18 Nov 2013 10:47:04 +0000 (10:47 +0000)]
rtsp-server: sprinkle some allow-none annotations for g-i
Wim Taymans [Mon, 18 Nov 2013 10:18:15 +0000 (11:18 +0100)]
stream: add method to filter transports
Add a method to safely iterate and collect the stream transports
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711664
Wim Taymans [Fri, 15 Nov 2013 15:35:05 +0000 (16:35 +0100)]
rtsp: allow NULL func in filters
Passing a null function make the filters return a list of
refcounted objects.
Wim Taymans [Tue, 12 Nov 2013 15:52:35 +0000 (16:52 +0100)]
address-pool: fix address increment
Use a guint instead of guint8 to increment the address. It's still not
completely correct because a guint might not be able to hold the complete
address range, but that's an enhacement for later.
Add unit test to test improved behaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=708237
Patricia Muscalu [Tue, 12 Nov 2013 09:55:14 +0000 (10:55 +0100)]
client: allow absolute path in requests
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711689
Patricia Muscalu [Thu, 7 Nov 2013 12:22:09 +0000 (13:22 +0100)]
client: make make_path_from_uri a vmethod
Wim Taymans [Tue, 12 Nov 2013 11:04:55 +0000 (12:04 +0100)]
stream: Add functions to get rtp and rtcp sockets
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710100
Wim Taymans [Tue, 12 Nov 2013 10:21:55 +0000 (11:21 +0100)]
context: defing a GType for the context
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710018
Sebastian Pölsterl [Sat, 12 Oct 2013 21:56:00 +0000 (23:56 +0200)]
Fixed several GIR warnings
Wim Taymans [Tue, 12 Nov 2013 10:15:46 +0000 (11:15 +0100)]
auth: small typos
Sebastian Rasmussen [Sat, 19 Oct 2013 17:25:27 +0000 (19:25 +0200)]
tests: Add unit tests for token
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710520
Sebastian Rasmussen [Sat, 19 Oct 2013 17:24:34 +0000 (19:24 +0200)]
token: Validate args for gst_rtsp_token_is_allowed
See https://bugzilla.gnome.org/show_bug.cgi?id=710520
Sebastian Rasmussen [Sat, 19 Oct 2013 17:21:53 +0000 (19:21 +0200)]
token: Fix bug when creating empty token
We always want to have a valid GstStructure in the token.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710520
Wim Taymans [Tue, 12 Nov 2013 09:28:55 +0000 (10:28 +0100)]
thread-pool: avoid race in shutdown
If we call g_main_loop_quit before the thread has entered g_main_loop_run, we
don't actually stop the mainloop ever. Solve this race by adding an idle source
to the mainloop that calls the _quit. This way we immediately exit the mainloop
if quit was called before we started it.
Sebastian Rasmussen [Sat, 19 Oct 2013 15:36:05 +0000 (17:36 +0200)]
tests: Add unit tests for permissions
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710202
Sebastian Rasmussen [Tue, 15 Oct 2013 16:50:47 +0000 (18:50 +0200)]
tests: Test mediafactory permissions
See https://bugzilla.gnome.org/show_bug.cgi?id=710202
Sebastian Rasmussen [Sat, 19 Oct 2013 15:39:35 +0000 (17:39 +0200)]
permissions: Fix refcounting when adding/removing roles
Previously a role that was removed was unreffed twice, and when
replacing an existing role the replaced role was freed while still being
referenced. Both bugs are now fixed.
See https://bugzilla.gnome.org/show_bug.cgi?id=710202
Sebastian Rasmussen [Tue, 15 Oct 2013 16:01:38 +0000 (18:01 +0200)]
tests: Check gst_rtsp_url_parse return value
See https://bugzilla.gnome.org/show_bug.cgi?id=710202
Tim-Philipp Müller [Tue, 5 Nov 2013 11:22:51 +0000 (11:22 +0000)]
Automatic update of common submodule
From 865aa20 to dbedaa0
Ognyan Tonchev [Mon, 14 Oct 2013 10:03:07 +0000 (12:03 +0200)]
rtsp-server: Fix socket leak
https://bugzilla.gnome.org/show_bug.cgi?id=710088
Sebastian Dröge [Wed, 30 Oct 2013 21:16:54 +0000 (22:16 +0100)]
rtsp-session-pool: Make sure session IDs are properly URI-escaped
https://bugzilla.gnome.org/show_bug.cgi?id=643812
Aleix Conchillo Flaque [Tue, 15 Oct 2013 23:37:34 +0000 (16:37 -0700)]
examples: fix compilation when WITH_AUTH is defined
https://bugzilla.gnome.org/show_bug.cgi?id=710228
Sebastian Dröge [Wed, 30 Oct 2013 18:10:59 +0000 (19:10 +0100)]
gitignore: Add new test binary
Ognyan Tonchev [Wed, 9 Oct 2013 13:19:12 +0000 (15:19 +0200)]
thread-pool: Add unit test for the thread pools
https://bugzilla.gnome.org/show_bug.cgi?id=710228
Ognyan Tonchev [Wed, 9 Oct 2013 13:25:10 +0000 (15:25 +0200)]
thread-pool: Fix thread leak when reusing threads
https://bugzilla.gnome.org/show_bug.cgi?id=709730
Patricia Muscalu [Mon, 14 Oct 2013 06:30:33 +0000 (08:30 +0200)]
tests: fixed racy behavior in rtspserver tests
https://bugzilla.gnome.org/show_bug.cgi?id=710078
Sebastian Rasmussen [Mon, 14 Oct 2013 17:36:24 +0000 (19:36 +0200)]
tests: Improve address pool unit tests
Add a range with mixed IPV4 and IPV6 addresses to pool.
Get an IPV4 address from an IPV6-only pool.
Get an IPV6 address from an IPV4-only pool.
Reserve a IPV6 address from an IPV4-only pool.
Check for unicast addresses in multicast-only pool.
Check for unicast addresses in uni-/multicast-mixed pool.
https://bugzilla.gnome.org/show_bug.cgi?id=710128
Wim Taymans [Fri, 4 Oct 2013 04:29:30 +0000 (06:29 +0200)]
client: append query string in PAUSE/PLAY/TEARDOWN as well
Jonas Holmberg [Tue, 1 Oct 2013 12:04:17 +0000 (14:04 +0200)]
client: Add query to control path
If the SETUP url contains a query it must be appended to the control
path so that it matches any already created stream in the media. The
query will also be appended to the session media path.
Wim Taymans [Fri, 4 Oct 2013 03:48:52 +0000 (05:48 +0200)]
rtsp-media: remove old line
Jonas Holmberg [Tue, 1 Oct 2013 11:15:19 +0000 (13:15 +0200)]
stream: Correct control comparison
https://bugzilla.gnome.org/show_bug.cgi?id=709176
Youness Alaoui [Tue, 10 Sep 2013 01:51:44 +0000 (21:51 -0400)]
media: Check dynamically if the pipeline supports seeking
We should not depend on whether or not the pipeline state change
returned NO_PREROLL or not. A media could dynamically change its
element and switch from seekable to non seekable so it's best to test
the seekable nature of the pipeline dynamically when we try to do a seek.
Youness Alaoui [Tue, 10 Sep 2013 01:51:23 +0000 (21:51 -0400)]
media: Return FALSE if seeking is not supported
Wim Taymans [Tue, 1 Oct 2013 15:16:11 +0000 (17:16 +0200)]
rtsp-media: don't seek accurate by default
Accurate seeking is perhaps a little overkill in the most common situation and
causes some formats (mp3) over slow media to seek extremely slowly.
Ognyan Tonchev [Thu, 26 Sep 2013 12:36:58 +0000 (14:36 +0200)]
tests: fix unit test
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708742
Jonas Holmberg [Thu, 26 Sep 2013 09:20:05 +0000 (11:20 +0200)]
client: Reply 400 if media cannot be constructed
Reply 400 Bad Request instead of 503 Service Unavailable if media
cannot be constructed in SETUP.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708821
Jonas Holmberg [Thu, 26 Sep 2013 07:41:10 +0000 (09:41 +0200)]
client: Send setup reply once only
If find_media() failed in handle_setup_request() two replies was sent.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708819
Tim-Philipp Müller [Tue, 24 Sep 2013 17:35:36 +0000 (18:35 +0100)]
Automatic update of common submodule
From 6b03ba7 to 865aa20
Jonas Holmberg [Mon, 23 Sep 2013 12:28:04 +0000 (14:28 +0200)]
server: Emit client-connected signal earlier
Emit client-connected before the client ref is given to a GSource,
otherwise client-connected can be emitted after the client object has
been freed.
Patrick Radizi [Tue, 24 Sep 2013 15:30:18 +0000 (17:30 +0200)]
addresspool: return reason of failure
Let gst_rtsp_address_pool_reserve_address() return the reason why
the address could not be reserved.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708229
Edward Hervey [Fri, 20 Sep 2013 14:47:56 +0000 (16:47 +0200)]
autogen.sh: Sync behaviour with other GStreamer modules
Allows building from outside of tree amongst other things
Edward Hervey [Fri, 20 Sep 2013 14:18:54 +0000 (16:18 +0200)]
Automatic update of common submodule
From b613661 to 6b03ba7
Tim-Philipp Müller [Thu, 19 Sep 2013 17:46:14 +0000 (18:46 +0100)]
Automatic update of common submodule
From 74a6857 to b613661
Tim-Philipp Müller [Thu, 19 Sep 2013 16:39:24 +0000 (17:39 +0100)]
Automatic update of common submodule
From 01a7a46 to 74a6857
Jonas Holmberg [Thu, 19 Sep 2013 13:44:26 +0000 (15:44 +0200)]
client: Do not read beyond end of path string
If the setup was done without a control url, make sure we don't try to read the
non-existing control string and crash.
Wim Taymans [Tue, 17 Sep 2013 12:39:44 +0000 (14:39 +0200)]
client: Fix RTPInfo header
Refactor the method to make the content_base.
Use the content-base and the control url to construct the RTPInfo
url.
Wim Taymans [Tue, 17 Sep 2013 10:21:02 +0000 (12:21 +0200)]
client: map url to path only in describe
Only map the request url to a path in the DESCRIBE method. The SDP then
contains the base and control urls that should be used to SETUP/PAUSE/
PLAY/TEARDOWN the media.
Wim Taymans [Tue, 17 Sep 2013 09:41:57 +0000 (11:41 +0200)]
Revert "client: map URL to path in requests"
This reverts commit
e3fded2cec897a2ec003450607b916cc1601fd2d.
This is not correct, we only remap the URL to a path in DESCRIBE, the SDP then
contains the base and control urls which are used in the SETUP, PLAY,
PAUSE and TEARDOWN requests.
Wim Taymans [Mon, 16 Sep 2013 15:16:49 +0000 (17:16 +0200)]
client: map URL to path in requests
Wim Taymans [Mon, 16 Sep 2013 14:47:40 +0000 (16:47 +0200)]
mount-points: make vmethod to make path from uri
Make a vmethod to transform an url into a path. The path is then used to lookup
the factory. This makes it possible to also use other bits of the url, such as
the query parameters, to locate the factory.
Ognyan Tonchev [Mon, 9 Sep 2013 09:05:26 +0000 (11:05 +0200)]
thread-pool: Add cleanup to wait for the threadpool to finish
Also fix race condition if two threads are asking for the first
thread from the thread pool at once. This would case two internal
GThreadPools to be created.
https://bugzilla.gnome.org/show_bug.cgi?id=707753
Jonas Holmberg [Thu, 5 Sep 2013 06:56:02 +0000 (08:56 +0200)]
client: free threadpool
https://bugzilla.gnome.org/show_bug.cgi?id=707638
Jonas Holmberg [Fri, 6 Sep 2013 15:23:20 +0000 (17:23 +0200)]
mountpoints tests: unref matched factories
https://bugzilla.gnome.org/show_bug.cgi?id=707638
Jonas Holmberg [Thu, 5 Sep 2013 16:01:18 +0000 (18:01 +0200)]
media tests: unref thread pool and caps
https://bugzilla.gnome.org/show_bug.cgi?id=707638
Jonas Holmberg [Thu, 5 Sep 2013 06:53:55 +0000 (08:53 +0200)]
auth, media, media-factory: unref permissions
https://bugzilla.gnome.org/show_bug.cgi?id=707638
Wim Taymans [Fri, 23 Aug 2013 13:15:12 +0000 (15:15 +0200)]
Makefile: add rule for appsrc example
Wim Taymans [Fri, 23 Aug 2013 13:14:29 +0000 (15:14 +0200)]
tests: add appsrc example
Add an example on how to use appsrc to feed the server pipeline with data.
Patricia Muscalu [Thu, 22 Aug 2013 10:10:39 +0000 (12:10 +0200)]
rtsp-client: remove query part from content-base string
Make sure that after the control url has been resolved, it's
not a part of the query-string.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=706568
Wim Taymans [Fri, 23 Aug 2013 08:38:43 +0000 (10:38 +0200)]
client: don't check url in response
There is no url or method in the response to check