Jindrich Novy [Wed, 2 Apr 2008 16:14:47 +0000 (18:14 +0200)]
Simplify message key creation in i18nTag()
Panu Matilainen [Thu, 3 Apr 2008 05:04:22 +0000 (08:04 +0300)]
Shut up a few silly compiler warnings that have crept in
- missing cast in python header subscript
- (false) warning about uninitialized variable, unused variable in rpmfc
- missing include in rpmio
Panu Matilainen [Wed, 2 Apr 2008 13:52:44 +0000 (16:52 +0300)]
Further streamline / simplify rpmVerifySignatures()
- Use more meaningful variable names than res2 and res3
- In verbose mode we just dump whatever rpmVerifySignature() returns,
error or not. Otherwise the output depends on the result. Make this
obvious in the code.
Panu Matilainen [Wed, 2 Apr 2008 13:30:21 +0000 (16:30 +0300)]
Make signature verification result not depend on rpm verbosity level, ick
Panu Matilainen [Wed, 2 Apr 2008 12:42:21 +0000 (15:42 +0300)]
Further redundancy / copy-paste coding elimination
Panu Matilainen [Wed, 2 Apr 2008 12:36:00 +0000 (15:36 +0300)]
Collapse the huge sigtag switch in rpmVerifySignatures() a bit
- move the tag names from a helper functions
- collapse similar cases to just one
Panu Matilainen [Wed, 2 Apr 2008 12:02:31 +0000 (15:02 +0300)]
Simplify missing/untrusted keys logging
Panu Matilainen [Wed, 2 Apr 2008 11:25:51 +0000 (14:25 +0300)]
Revert "Disable signature and digest checks on query modes (rhbz#438625)"
This reverts commit
5a684f5527bc7f32fca9ba7878802519bb515e93.
All the sigchecking on database queries is mostly waste of time, but
this disables signature checks on queries of non-installed, untrusted
packages too. Separate vsflags for db / non-db operations or such needed
before this can change.
Jindrich Novy [Tue, 1 Apr 2008 14:37:42 +0000 (16:37 +0200)]
Fix off-by one in urlOpen()
- the former implementation didn't take the ending '\0' into account
Panu Matilainen [Tue, 1 Apr 2008 12:40:07 +0000 (15:40 +0300)]
Updated German translation from Fabian Affolter
Panu Matilainen [Tue, 1 Apr 2008 10:35:16 +0000 (13:35 +0300)]
Enhance error message on failed ts lock acquire (rhbz#427064)
- adds strerror() output to the failure log message, this should give
sufficient hint as to what's wrong (eg "permission denied")
Panu Matilainen [Tue, 1 Apr 2008 10:32:57 +0000 (13:32 +0300)]
Convert rpmlock.c to general rpm indentation style
Panu Matilainen [Mon, 31 Mar 2008 14:06:47 +0000 (17:06 +0300)]
Avoid entirely unnecessary static buffer + string copy.
Jindrich Novy [Mon, 31 Mar 2008 12:13:59 +0000 (14:13 +0200)]
Make ExcludeArch/ExclusiveArch/ExcludeOS/ExclusiveOS actually work
Panu Matilainen [Mon, 31 Mar 2008 10:31:03 +0000 (13:31 +0300)]
Avoid static sprintf buffer in rpmReadHeader()
Panu Matilainen [Mon, 31 Mar 2008 10:12:29 +0000 (13:12 +0300)]
Avoid static buffer for error messages in rpmReadSignature()
Panu Matilainen [Mon, 31 Mar 2008 09:07:37 +0000 (12:07 +0300)]
Make rpmLeadCheck() return error msg instead of direct logging
- allows silent checking of lead and differentiating between
non-rpm files and incompatible rpms, avoiding bogus "not an rpm package"
message on manifests
Panu Matilainen [Mon, 31 Mar 2008 07:44:23 +0000 (10:44 +0300)]
Dead code removal (macro stuff)
Panu Matilainen [Mon, 31 Mar 2008 07:41:07 +0000 (10:41 +0300)]
Dead code removal (popt switches)
Panu Matilainen [Mon, 31 Mar 2008 06:56:24 +0000 (09:56 +0300)]
Simplify rpmdsThis() code
- use rasprintf() to construct [e:]v-r string instead of stpcpy games
- use str2hge() for N + EVR
Panu Matilainen [Mon, 31 Mar 2008 06:25:18 +0000 (09:25 +0300)]
Copy N + EVR into ds in rpmdsSingle() instead of just referring
- previously a ds created by rpmdsSingle() would turn invalid as soon as
the N and EVR strings were freed by caller (or went out of scope), ick
- convert the N + EVR strings passed to rpmdsSingle() to similar construct
as is returned by headerGetEntry so headerFreeData will free both the
pointers + contents.
Panu Matilainen [Mon, 31 Mar 2008 05:42:33 +0000 (08:42 +0300)]
Bunch of formatting & indentation fixes to rpmds
Panu Matilainen [Sat, 29 Mar 2008 13:22:45 +0000 (15:22 +0200)]
Fixup for rpmfcSaveArg() no longer freeing key
Jindrich Novy [Sat, 29 Mar 2008 10:18:30 +0000 (11:18 +0100)]
Don't use static buffer ptr as return value in doUntar()
Jindrich Novy [Fri, 28 Mar 2008 16:49:56 +0000 (17:49 +0100)]
Don't use static buffer in rpmfcELF(), make code more comprehensive
Jindrich Novy [Fri, 28 Mar 2008 16:21:47 +0000 (17:21 +0100)]
Remove unneeded buffer operations
Jindrich Novy [Fri, 28 Mar 2008 15:15:48 +0000 (16:15 +0100)]
Add rpmfcAddFileDep() to handle file dependencies securely
Panu Matilainen [Wed, 26 Mar 2008 14:32:30 +0000 (16:32 +0200)]
Simplify changelog entry additions
Jindrich Novy [Wed, 26 Mar 2008 10:52:07 +0000 (11:52 +0100)]
Remove unneeded free()
Jindrich Novy [Wed, 26 Mar 2008 08:21:30 +0000 (09:21 +0100)]
Use rasprintf() in rpmfcHelper() and rpmfcGenerateDepends()
Jindrich Novy [Tue, 25 Mar 2008 14:21:47 +0000 (15:21 +0100)]
Don't use static buffers to communicate between funcs, avoid buffer overflows.
Jindrich Novy [Tue, 25 Mar 2008 13:57:37 +0000 (14:57 +0100)]
Use rasprintf() for NVR construction to remove BUFSIZ limit.
Jindrich Novy [Tue, 25 Mar 2008 12:54:36 +0000 (13:54 +0100)]
Avoid artificial limits on tag name.
Panu Matilainen [Tue, 25 Mar 2008 05:49:47 +0000 (07:49 +0200)]
Disable signature and digest checks on query modes (rhbz#438625)
Panu Matilainen [Mon, 24 Mar 2008 21:58:43 +0000 (23:58 +0200)]
Avoid couple of static buffers in psm script functions
Panu Matilainen [Mon, 24 Mar 2008 21:47:41 +0000 (23:47 +0200)]
Avoid static buffer for sql commands
Panu Matilainen [Mon, 24 Mar 2008 20:42:34 +0000 (22:42 +0200)]
Remove bogus const from rpmRelocation struct
Panu Matilainen [Mon, 24 Mar 2008 20:25:26 +0000 (22:25 +0200)]
Remove bogus consts from rpmte_s
Panu Matilainen [Mon, 24 Mar 2008 20:23:01 +0000 (22:23 +0200)]
Revert rpmhash changes from previous commit
- rpmhash key + data actually sometimes point to const data.. pff
Panu Matilainen [Mon, 24 Mar 2008 20:13:45 +0000 (22:13 +0200)]
Remove bogus consts from rpmdb and dbi structs
Panu Matilainen [Mon, 24 Mar 2008 19:05:05 +0000 (21:05 +0200)]
Remove bogus consts from pgpDigParams_s structure
Panu Matilainen [Mon, 24 Mar 2008 18:44:48 +0000 (20:44 +0200)]
Remove bogus consts from urlinfo_s structure
Panu Matilainen [Mon, 24 Mar 2008 17:03:20 +0000 (19:03 +0200)]
Eliminate bogus const's from spec structure
Panu Matilainen [Mon, 24 Mar 2008 17:03:00 +0000 (19:03 +0200)]
Eliminate bogus const's from OFI_t and spectags structs
Panu Matilainen [Mon, 24 Mar 2008 17:02:44 +0000 (19:02 +0200)]
Eliminate bogus const from expression value
Panu Matilainen [Mon, 24 Mar 2008 17:01:29 +0000 (19:01 +0200)]
Use regular stream functions instead of rpmio in spec sanity check
Panu Matilainen [Mon, 24 Mar 2008 17:01:12 +0000 (19:01 +0200)]
Eliminate wtf pointer games with rpmGetPath result.
Panu Matilainen [Mon, 24 Mar 2008 17:00:48 +0000 (19:00 +0200)]
Avoid entirely silly rpmio use in addFileToTagAux()
Jindrich Novy [Sun, 23 Mar 2008 12:51:53 +0000 (13:51 +0100)]
Fix buffer overflow while creating patch script, avoid fixed sized buffers.
Jindrich Novy [Sun, 23 Mar 2008 12:50:07 +0000 (13:50 +0100)]
Use rasprintf() to prevent overflows and remove BUFSIZ buffer limit.
Jindrich Novy [Sun, 23 Mar 2008 12:48:49 +0000 (13:48 +0100)]
Fix writeRPM, use dynamic allocation, remove bogus const.
Panu Matilainen [Thu, 20 Mar 2008 08:59:17 +0000 (10:59 +0200)]
Adjust maintainer makefile for hg -> git switchover
Panu Matilainen [Wed, 19 Mar 2008 07:30:33 +0000 (09:30 +0200)]
Remove bunch of double consts. What have I've been thinking?
Panu Matilainen [Tue, 18 Mar 2008 11:22:15 +0000 (13:22 +0200)]
Erm, off-by-one in rasprintf()
- should probably change the comment to "simple, stupid and buggy" ;)
Panu Matilainen [Tue, 18 Mar 2008 08:28:57 +0000 (10:28 +0200)]
Bump up sonames, we're not exactly ABI compatible with 4.4 anymore..
Panu Matilainen [Tue, 18 Mar 2008 08:18:08 +0000 (10:18 +0200)]
Use rasprintf() in rpmps to properly fix mdvbz#31680
Panu Matilainen [Tue, 18 Mar 2008 08:17:03 +0000 (10:17 +0200)]
Add custom asprintf() clone to rpmstring
Panu Matilainen [Tue, 18 Mar 2008 07:10:13 +0000 (09:10 +0200)]
Minimal namespacing for locale-insensitive x*() string functions
Panu Matilainen [Tue, 18 Mar 2008 06:55:05 +0000 (08:55 +0200)]
More xstr[n]casecmp to rpmstring along the other string-stuff...
Panu Matilainen [Mon, 17 Mar 2008 14:03:51 +0000 (16:03 +0200)]
Refactor running of pre/post scriptlets out of rpmtsRun()
Panu Matilainen [Mon, 17 Mar 2008 13:48:25 +0000 (15:48 +0200)]
Add missing popt include
Panu Matilainen [Mon, 17 Mar 2008 12:36:43 +0000 (14:36 +0200)]
Remove rollback and repackage from documentation
Panu Matilainen [Mon, 17 Mar 2008 12:27:03 +0000 (14:27 +0200)]
Nuke leftover rollback test program, update translations
Panu Matilainen [Mon, 17 Mar 2008 12:10:11 +0000 (14:10 +0200)]
Remove repackage support to finish off with rollback
The two main classes of rollback/repackage need are
1) Gimme back the previous version, this broke XYZ on my system.
This is better handled by downgrading to the previous version of original
package instead of repackaged garbage. We should maintain real package
(version) history somewhere.
2) Upgrade messed up my configuration.
Instead of repackaging everything we could be far more intelligent
wrt config files, stick them into real version control or at least have
hooks to do so.
RPMCALLBACK_REPACKAGE_* and RPMTRANS_FLAG_REPACKAGE definitions left around
to avoid needlessly breaking everybodys callbacks (for now)
Panu Matilainen [Mon, 17 Mar 2008 09:53:27 +0000 (11:53 +0200)]
Remove rollback support
- not possible to do reliably within rpm
- effort is better wasted on investigating fs-level snapshots, which
is way beyond rpm scope except for hooks to interact with the snapshot
mechanism to communicate beginning/end of transaction and such
Panu Matilainen [Mon, 17 Mar 2008 10:04:39 +0000 (12:04 +0200)]
Remove support for automatic rollback on failure
- doing this reliably from rpm is simply not possible as there's no way
to undo script actions, might as well not pretend we can
- for a feature that's not generally usable it complicates mainline code
way too much
Panu Matilainen [Fri, 14 Mar 2008 12:55:44 +0000 (14:55 +0200)]
Make arch conditional in default queryformat
- gpg-pubkey's dont have arch, argh...
Panu Matilainen [Fri, 14 Mar 2008 12:27:01 +0000 (14:27 +0200)]
Revert RPMTAG_FILEDIGESTS -> FILEMD5's for now
Panu Matilainen [Fri, 14 Mar 2008 12:18:43 +0000 (14:18 +0200)]
Type missing for RPMTAG_HEADERI18NTABLE
Panu Matilainen [Thu, 13 Mar 2008 07:20:24 +0000 (09:20 +0200)]
Don't process objdump sections after "Version References"
autodeps/linux.req expects the 'Version References' section to be
the very last section in objdump -p output and nothing else to follow
it, but at least on Linux/ARM, you can get output a la:
Version References:
required from ld-linux.so.3:
0x0d696914 0x00 06 GLIBC_2.4
required from libacl.so.1:
0x05822450 0x00 05 ACL_1.0
required from libgcc_s.so.1:
0x0b792655 0x00 04 GCC_3.5
required from librt.so.1:
0x0d696914 0x00 03 GLIBC_2.4
required from libc.so.6:
0x0d696914 0x00 02 GLIBC_2.4
private flags = 4000002: [Version4 EABI] [has entry point]
This causes the built package (if the external dep generator is
used) to end up with bogus dependencies.
Issue found by Rabeeh Khoury <rabeeh@marvell.com>
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Panu Matilainen [Wed, 12 Mar 2008 13:34:49 +0000 (15:34 +0200)]
Remove rpmio internal copy of poptParseArgvString() & friends
- the old included version segfaults with funky input and whatnot...
- link rpmio to real popt instead
Panu Matilainen [Wed, 12 Mar 2008 11:20:47 +0000 (13:20 +0200)]
Refcount dbiTags on db open+close, automatically free
- avoids rpmdb_internal include in rpmqv.c and memleak in API clients
- avoids having to export dbiTags(Max) at all
Panu Matilainen [Tue, 11 Mar 2008 09:33:04 +0000 (11:33 +0200)]
Update translations
Panu Matilainen [Tue, 11 Mar 2008 09:32:37 +0000 (11:32 +0200)]
Dust off Finnish translation
Panu Matilainen [Tue, 11 Mar 2008 06:42:34 +0000 (08:42 +0200)]
Updated Polish translation (Piotr Drąg)
Panu Matilainen [Fri, 7 Mar 2008 13:07:06 +0000 (15:07 +0200)]
Remove support for automatically importing pubkeys from keyservers
- causes hideous load on keyservers and autoimporting without user approval
isn't a very good idea, especially as long as imported == trusted
- nothing wrong with supporting hkp lookups on manual --import though...
- curl doesn't know about hkp:// but http on appropriate port works just
fine, lets re-enable it
Panu Matilainen [Fri, 7 Mar 2008 12:05:28 +0000 (14:05 +0200)]
Remove BDB copy from the repository, it doesn't belong there
Panu Matilainen [Fri, 7 Mar 2008 11:34:20 +0000 (13:34 +0200)]
Stop insecurely covering up for lack of snprintf and vsnprintf
- we require C99 anyway
- snprintf is used unconditionally all around the tree
- if absolutely needed for portability, having insecure wrappers littered
over the source is not the best way
Panu Matilainen [Fri, 7 Mar 2008 11:04:46 +0000 (13:04 +0200)]
Drop librpmbuild from rpm.pc
- next to nothing actually uses librpmbuild, avoid dragging it in needlessly
- if needed, add a separate .pc for rpmbuild later
Panu Matilainen [Fri, 7 Mar 2008 10:36:22 +0000 (12:36 +0200)]
Remove unused RPMUSER, GROUP etc from configure.ac
Panu Matilainen [Fri, 7 Mar 2008 07:47:51 +0000 (09:47 +0200)]
Log message adjustments
- dont waste translator time by having them translate obscure debug messages
- adjust some suspect looking logging levels
- mark some non-debug messages for translation where missing..
Panu Matilainen [Fri, 7 Mar 2008 06:29:03 +0000 (08:29 +0200)]
Further constants made readonly...
Panu Matilainen [Fri, 7 Mar 2008 06:21:55 +0000 (08:21 +0200)]
Make _cacheDependsRC static, not needed outside depends.c
Panu Matilainen [Fri, 7 Mar 2008 06:20:03 +0000 (08:20 +0200)]
Another pile of read-only constants marked as such..
Panu Matilainen [Fri, 7 Mar 2008 06:15:03 +0000 (08:15 +0200)]
Mark another pile of header_magic duplicates as read-only
Panu Matilainen [Thu, 6 Mar 2008 18:47:17 +0000 (20:47 +0200)]
Make yet more build tables readonly
- preambleList and partList are modified runtime for silly reasons,
reminders to fix later..
Panu Matilainen [Thu, 6 Mar 2008 18:25:43 +0000 (20:25 +0200)]
Make headerCopyTags() tag list const, the list isn't modified..
Panu Matilainen [Thu, 6 Mar 2008 18:17:20 +0000 (20:17 +0200)]
Mark bunch of static build-related tables as read-only
Panu Matilainen [Thu, 6 Mar 2008 17:57:01 +0000 (19:57 +0200)]
Make rpmfc token and apply tables readonly
Panu Matilainen [Thu, 6 Mar 2008 17:51:06 +0000 (19:51 +0200)]
Mark rpm tag tables read-only as far as we can..
Panu Matilainen [Thu, 6 Mar 2008 17:50:41 +0000 (19:50 +0200)]
Mark various header tables and definitions as read-only
Panu Matilainen [Thu, 6 Mar 2008 17:49:08 +0000 (19:49 +0200)]
Make the rpmdb vectors readonly
Panu Matilainen [Thu, 6 Mar 2008 17:27:19 +0000 (19:27 +0200)]
Mark bunch of misc. tables & such read-only in librpmio
Panu Matilainen [Thu, 6 Mar 2008 17:25:46 +0000 (19:25 +0200)]
Make rpmio vectors read-only
Panu Matilainen [Thu, 6 Mar 2008 17:24:56 +0000 (19:24 +0200)]
Further read-only tables in rpmpgp..
Panu Matilainen [Thu, 6 Mar 2008 16:56:38 +0000 (18:56 +0200)]
Mark various pgp value tables read-only as they should be
Panu Matilainen [Tue, 4 Mar 2008 07:26:27 +0000 (09:26 +0200)]
PreReq -> Requires in ordering debug output (Pascal Rigaux)
Panu Matilainen [Tue, 4 Mar 2008 06:16:02 +0000 (08:16 +0200)]
Add super-H arch support (rhbz#432496)
Patch from Masaki Chikama
Panu Matilainen [Thu, 28 Feb 2008 10:46:45 +0000 (12:46 +0200)]
Add missing leading underscores to names passed to rpmMkdirPath()
- mostly cosmetical, leading to slightly misleading error messages
Panu Matilainen [Tue, 26 Feb 2008 20:42:46 +0000 (22:42 +0200)]
Another unnecessarily exported internal variable..