Jihoon Lee [Mon, 10 May 2021 02:53:39 +0000 (11:53 +0900)]
[Permute] Add permute layer forward/backward
This patch implements forward/backward with a following test
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
jijoong.moon [Fri, 21 May 2021 02:53:36 +0000 (11:53 +0900)]
[ RNN ] Add unittest case & return_sequence
This PR includes.
. unittest of rnn layer
. support of return sequence of rnn layer
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Jihoon Lee [Wed, 26 May 2021 12:15:44 +0000 (21:15 +0900)]
[Recorder] Add multiout equivalent in transLayer
When getting gradient from `gradientTape` it adds all derivatives of the
dependent layer. While this behavior is true, we need to measure to what
extent each layer contributed to the layer.
This patch adds a multiout layer which consists of some stublayer that
seperates derivatives one by one.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
jijoong.moon [Thu, 27 May 2021 11:20:32 +0000 (20:20 +0900)]
[ LSTM ] Add Multi-Layerd LSTM Unittest
This commit includes,
. Multi-Layerd LSTM Unit test.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Jihoon Lee [Thu, 6 May 2021 12:22:57 +0000 (21:22 +0900)]
[Permute] Implement peripheral functions
This patch implements initialize, export and setProperty of permute
layer
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 09:17:58 +0000 (18:17 +0900)]
[layer] Move distribute to LayerNode
move distribute to LayerNode from layer
Further, the distribute layer is now supposed to be used
as a wrapper of a layer maintained by the LayerNode,
and must not be maintained externally.
Rather, use getDistribute() to check if the node is distributed
and treat the layer as a regular layer.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Tue, 4 May 2021 01:50:09 +0000 (10:50 +0900)]
[Layer] Add permute layer scaffolding
This patch adds permute layer scaffolding
**Minor Fix**
- Add error handling for transpose tensordim
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
jijoong.moon [Thu, 27 May 2021 04:43:41 +0000 (13:43 +0900)]
[ LSTM ] Add More Unit Test Cases
This Commit inclues,
. Additional unittest
- with return sequneces
- with multiple batch size
- with multiple batch + return sequences
- with multiple batch + return sequences + multi-iteration
. Fixed initialization bug during training
. Remove check for tensor dot product to support multi-dimension
tensor.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
jijoong.moon [Mon, 24 May 2021 05:54:44 +0000 (14:54 +0900)]
[ LSTM ] Add Unit test for LSTM Layer
This commit includes,
. unit test case for lstm layer
. fixup of potential bug : tanh prime calculation
.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
jijoong.moon [Tue, 18 May 2021 01:25:52 +0000 (10:25 +0900)]
[ LSTM ] Add return_sequence
This commit includes,
. impelementation of return_sequence. If it is true, then it
generate all the output of time iteration and if it false, then
only last output is available.
. add 'return_sequence' keyward
Resolves:
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
jijoong.moon [Tue, 18 May 2021 01:24:54 +0000 (10:24 +0900)]
[ LSTM ] LSTM Unit Test Cases
This PR includes,
. LSTM Unittest Case
. python code in genModels
Resolves:
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
jijoong.moon [Thu, 13 May 2021 04:03:49 +0000 (13:03 +0900)]
[ LSTM ] Fix implementation & add backwarding testcase
This commits includes:
. fix implementation ( apply actvation )
. add one unittest to check functionality of backwarding
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Jihoon Lee [Fri, 30 Apr 2021 10:34:06 +0000 (19:34 +0900)]
[Exporter] Implement saving fc node
**Changes proposed in this PR:**
- This patch add saving fullyconnected layer with node_exporter
- add dedeicated buffer to `TfNode`
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Tue, 8 Jun 2021 06:11:54 +0000 (15:11 +0900)]
[app] reduce Logistic regression application epochs
Reduce logistic regression application epochs.
This application is to check working than verify accuracy and can
run with fewer epochs.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Wed, 26 May 2021 12:09:29 +0000 (21:09 +0900)]
[Recorder] Add Input map generation
There was a bug that layer input is directly from the previous layer.
If the model is not sequential, this assumption is not true, making
Addition test fail.
This patch build `model.recoder__input_maps` to correctly locate
the input tensor with some minor clean ups
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Thu, 20 May 2021 05:22:08 +0000 (14:22 +0900)]
[meson] Enable tflite-interpreter by default
Enable tflite-interpreter by default as tflite layer is
already enabled.
Move flatc dependency out to the main meson.build
Also add proper path for the generated tf_schema
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Tue, 18 May 2021 05:44:09 +0000 (14:44 +0900)]
[layer] Move flatten property to layerNode
Move flatten property out to layerNode
also prepare for moving other properties out to layerNode
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Thu, 29 Apr 2021 06:31:33 +0000 (15:31 +0900)]
[Refactor] Delegate tfNode creation to exporter
This patch enables delegating exporting logic to exporter.
Note that this is supposed to be 1:1 mapping, if it has to be m:n
mapping, it should be directly handled by the interpreter, which
actually can see the node.
Also s/`save_result`/`saveResult` and `get_result`/`getResult`
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
[Android] Add tflite interpreter option
This patch add tflite interpreter option to ndk build
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
hyeonseok lee [Tue, 1 Jun 2021 04:52:09 +0000 (13:52 +0900)]
[Fix] Initialize member variable
- Initialize member variable sorted
- Catch exception when create the tensor
resolves: 1231330, 1143556
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
Parichay Kapoor [Fri, 4 Jun 2021 05:54:46 +0000 (14:54 +0900)]
[deb/pkg] Reduce error tolerance for release build
Reduce error tolerance for release builds to succeed build on launchpad and tizen builds.
The default error tolerance is only reduced for all release builds for all tests that use defined tolerance.
However, the CI will run at original tolerance for all the builds and will ensure that
values are matched with original precision.
The tolerance has to be reduced because different os
have different versions and implementations of the blas
which results in minor difference in the results of the float
operations. However, when the difference is accumulated over
a range of operations, the unittests fail to match the
exact values.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Wed, 28 Apr 2021 10:46:58 +0000 (19:46 +0900)]
[Tflite] Separate `tfopnode`
This patch separates tfopnode to a file.
tfOpNode will be directly built from the exporter if it doesn't need to
be fused.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Wed, 2 Jun 2021 12:44:31 +0000 (21:44 +0900)]
[tflite] Update dependency from tflite to tf2lite
Update dependency from tensorflow-lite to tensorflow2-lite.
This is done for Tizen and Debian build. It has already been done for Android.
Tensorflow2-lite header is dependent on flatbuffer, so flatbuffers-devel
is additionally added as a build-dependency.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 00:55:10 +0000 (09:55 +0900)]
[pkg/spec] Update spec packaging for tflite layer
Update spec packaging for tflite layer with tflite dependency
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Thu, 3 Jun 2021 05:15:27 +0000 (14:15 +0900)]
[test] Remove run_unittests
Remove run_unittests
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Thu, 3 Jun 2021 05:13:13 +0000 (14:13 +0900)]
[deb/pkg] Minor update to deb packaging
Update debian packaging:
- update the unittests to use meson tests
- update dh_missing to fail than give warnings
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Thu, 3 Jun 2021 03:34:47 +0000 (12:34 +0900)]
[unittest] Update unittest tolerance for debian build
Update unittest tolerance to be 1e-5 for debian build to match
across platforms (bionic, focal) and architectures.
Similar issues have occured for i586 tizen as well.
So, this patch lowers the tolerance for all ccapi and capi test.
This issue occurs to os and library versioning issues.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Thu, 3 Jun 2021 01:59:44 +0000 (10:59 +0900)]
[deb/pkg] Add nnstreamer filter and update testing
Add nnstreamer filter in the packaging
Also update the unittests to use the meson tests
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
jijoong.moon [Wed, 2 Jun 2021 13:15:52 +0000 (22:15 +0900)]
[ Release ] NNTrainer 0.2.0 Release
NNTrainer v0.2.0 is released.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Parichay Kapoor [Wed, 2 Jun 2021 12:51:52 +0000 (21:51 +0900)]
[deb/pkg] Update debian install filenames
Update debian install filenames for the capi and ccapi.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Wed, 2 Jun 2021 06:42:00 +0000 (15:42 +0900)]
[Product Ratings] Fix inconsistent batch
This patch fixes inconcistent batch size between source file and model
configuration.
Also found a bug #1238, which will be dealt seperately.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Wed, 2 Jun 2021 04:50:16 +0000 (13:50 +0900)]
[debian] Refactor debian packaging
Refactor debian package to make separate packages for capi and ccapi, along with their devels.
Other bug fixes/improvements are:
- Update the names of the packages in pkg-config files for the capi and ccapi
- Update the installed files based on the requirement by the devel headers
(this might be even expanded). This will be refactored again once layer_internal and neuralnet
cleanup is performed.
- Update the included headers
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Tue, 1 Jun 2021 12:11:36 +0000 (21:11 +0900)]
[APP] Change embeding to product rating
This patch changes embedding application to product rating application
which is more practical use-case
**Changes proposed in this PR:**
- Update Readme
- Change directory and app name embedding->productratings
- tune model and sample dataset
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 19 Apr 2021 11:52:39 +0000 (20:52 +0900)]
[tflite] implement build operations in subgraph
This patch implements build operation in the subgraph
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Tue, 1 Jun 2021 04:47:17 +0000 (13:47 +0900)]
[context/optimizer] Enable plugged optimizer
Enable plugged optimizer with the app_context
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Tue, 1 Jun 2021 02:30:01 +0000 (11:30 +0900)]
[optimizer] Update optimizer setProperty interface
Update optimizer setProperty interface based on the requirement
from the custom optimizer.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Thu, 27 May 2021 07:44:40 +0000 (16:44 +0900)]
[Example] Concat example
This patch adds concat example with embedding
The structure is
(input)
/ \
(embed1) (embed2)
\ /
(concat)
|
(flatten)
|
(fc)
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 1 Jun 2021 04:51:21 +0000 (13:51 +0900)]
[Fix] Prevent creating multiout for split
This patch make an exception for split layer to not create multiout
layer. While fixing trivial build error of sign compare
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Mon, 31 May 2021 09:44:43 +0000 (18:44 +0900)]
[split/test] Added unittests for split layer
Added unittests for split layer covering initialization,
forwarding and backwarding. Corresponding bug fixes are
also added.
This has revealed an issue with concat layer #1226
which will be resolved soon.
Also add split layer to android build
Resolves #1208
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 11:07:23 +0000 (20:07 +0900)]
[split layer] Add forwarding and backwarding
Add forwarding and backwarding for the split layer
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 11:04:52 +0000 (20:04 +0900)]
[split layer] Added split layer scaffolding
Added split layer scaffolding with its properties and initialization
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Thu, 27 May 2021 05:22:06 +0000 (14:22 +0900)]
[App] Make embedding golden data optional
This patch makes embedding golden data optional while changing return
status
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
jijoong.moon [Thu, 13 May 2021 04:03:49 +0000 (13:03 +0900)]
[ LSTM ] Fix implementation & add backwarding testcase
This commits includes:
. fix implementation ( apply actvation )
. add one unittest to check functionality of backwarding
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
jijoong.moon [Tue, 11 May 2021 04:18:03 +0000 (13:18 +0900)]
[ LSTM ] Backwarding Implementation
This commit includes
. calDerivative & calGradient of LSTM Layer
. Modification of Forwarding of LSTM Layer
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: jijoong.moon <jijoong.moon@samsung.com>
Jihoon Lee [Fri, 30 Apr 2021 04:06:35 +0000 (13:06 +0900)]
[VarGrad] Add clone Transpose
This patch adds clone transpose to `var_grad`, this function clones the
current `var_grad` but transpose and save
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Fri, 16 Apr 2021 08:09:08 +0000 (17:09 +0900)]
[Tflite] Add model input, output
This patch add model to track input and output
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 27 May 2021 07:35:07 +0000 (16:35 +0900)]
[Fix/graph] fix index after removing node
**Changes proposed in this PR:**
- After removing last node, adj node after the target node becomes not
correct, this patch fixes the issue
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 20 May 2021 04:18:41 +0000 (13:18 +0900)]
[Test/Model] Prepare addition model
This patch add addition model test
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 24 May 2021 11:21:25 +0000 (20:21 +0900)]
[Fix] Output layer setup correctly
There was a bug that output layer is not set correctly because of the
timing issue and overlapping checker issue.
This patch sets output layer correctly.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 24 May 2021 10:14:33 +0000 (19:14 +0900)]
[LayerNode] Add print function
This patch adds simple print function to be used for debugging
Note that, input_layers are from `layer_internal` for now, but it's
private so it is commented out
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 18 May 2021 12:18:37 +0000 (21:18 +0900)]
[Test/models] prepare to support non-linear models
**Changes proposed in this PR:**
- Make `transLayer` from proxy to a legit layer
- Add output map so that in each layer can locate it's output from model
- Support non-linear output generation
- Add support for multi input, multi output
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Mon, 17 May 2021 10:09:53 +0000 (19:09 +0900)]
[graph] Add non-const iterators
Add non-const iterators for the graph.
Most of the locations use const-iterators.
This will be updated when layer_node is updated to use its
properties than layer.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Mon, 17 May 2021 06:50:52 +0000 (15:50 +0900)]
[graph] Graph cleanup getNodes()
Graph remove support for getNodes() but rather
use iterators to iterator over the graph.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Mon, 17 May 2021 05:19:58 +0000 (14:19 +0900)]
[graph] Cleanup graph usage
Cleanup graph usage
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Mon, 17 May 2021 05:07:43 +0000 (14:07 +0900)]
[graph] Migrate to graph core
Migrate neural network independent and generic sections of the graph
to graph core. This is not yet complete and will be done over a few commits.
This will cleanup NetworkGraph class and will allow optimizations to
be done on the GraphCore/NetworkGraph class easily, and simplify
the classes as well.
Now, graph related structures can move out from layer to layer node.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
hyeonseok lee [Tue, 25 May 2021 09:19:56 +0000 (18:19 +0900)]
[Addition] fix forwarding
Correct initialization of output
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
Jihoon Lee [Wed, 14 Apr 2021 11:02:18 +0000 (20:02 +0900)]
[Tflite] Fix tf shape building
This patch fixes tf shape building, by adding `eff_dim_flag` and
`dyn_dim_flag`.
`eff_dim_flag` checks which dimension are actually used so that to be
squeezed.
`dyn_dim_flag` checks which dimension should be set to -1 (meaning it is
not fixed)
With those flag set, our tensor dim is able to convert to the dimension
representation that supports `-1` and not fixed size
Those fixes are apply to fc layer for now
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 24 May 2021 07:35:37 +0000 (16:35 +0900)]
[Fix] Add missing header
This patch adds missing header for logger when `enable_logging=false`
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Fri, 14 May 2021 09:13:14 +0000 (18:13 +0900)]
[Props] Add Name validator and unittest
**Changes proposed in this PR:**
- Add name validator
- Add source file for `common_properties`
- Change name of `unittest_properties.cpp` ->
`unittest_base_properties.cpp`
- Add `unittest_common_properties.cpp`
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 10 May 2021 06:33:39 +0000 (15:33 +0900)]
[Conv2d/Test] Add more test
This patch adds test suggested at #1042
Resolves #1054
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 10 May 2021 03:57:22 +0000 (12:57 +0900)]
[Conv2d] Clean up conv2d relates
This patch handles issue left at #1042
**Changes proposed in this PR:**
- [x] move commented code upward
- [x] remove channel argument
- [x] Add conv negative test
- [ ] Add more test
See also: #1042, #1054
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Wed, 14 Apr 2021 08:21:16 +0000 (17:21 +0900)]
[Tflite] Implement `BuildTensors`
This patch add `BuildTensors` which build tensors into *.tflite file.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 06:11:46 +0000 (15:11 +0900)]
[fc] Make bias derivative in-place
Make bias derivative in-place for fc layer
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Fri, 21 May 2021 06:01:14 +0000 (15:01 +0900)]
[tensor] Update tensor sum
Update tensor sum to support in-place sum when done over
multiple dimensions.
Also update arguments order to have output tensor as a latter
argument.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Wed, 14 Apr 2021 06:27:26 +0000 (15:27 +0900)]
[tflite] Implement `buildBuffers`
This patch implements buildBuffers, now our generated tflite file has
buffers attached.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Tue, 18 May 2021 03:41:39 +0000 (12:41 +0900)]
[android] Fix android build
Fix android build error for file not found
add tensorflow new version to .gitignore
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Tue, 18 May 2021 01:08:56 +0000 (10:08 +0900)]
[time_dist] setProperty for time distribution layer
Added setProperty for time distribution layer, which passes
the properties to its underlying layer.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Tue, 18 May 2021 01:15:21 +0000 (10:15 +0900)]
[model] Model inference should not catch throw
Model inference should not catch throw, and must throw errors
so that the callers can catch it and detect errors.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Wed, 12 May 2021 04:39:33 +0000 (13:39 +0900)]
[graph] Add graph core class
Add graph core class
This is mainly separating the existing implementation of core part
of the graph from NetworkGraph.
This patch does not contain new implementation but mostly contain
borrowed implementation from existing graph.
See Also #1176
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Mon, 3 May 2021 08:37:49 +0000 (17:37 +0900)]
[Props] Add vector/array handler
This patch add vector property handler.
vectored property have sementics that number of size is not defined
arrayed property have sementics that number of size must match
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 18 May 2021 07:22:49 +0000 (16:22 +0900)]
[Svace] Fix dangling reference issue
This patch fixes dangling reference caused from Sorted.pop_back();
tracking id: 1229992
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Wed, 14 Apr 2021 04:47:12 +0000 (13:47 +0900)]
[Tflite] Implement serializing opcode
This patch implements implementing serialize opcode by
`buildOperatorCodes`
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 13 Apr 2021 13:16:11 +0000 (22:16 +0900)]
[TfLite] Implement TfOpIdxMap
This patch implments TfOpIdxMap
Please note that graph::initialize has been extracted for modularity and
testability within this patch.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 13 Apr 2021 09:45:51 +0000 (18:45 +0900)]
[Tflite] Implement TfOpNode
This patch implements TfOpNode which will be used to deserialize layer
node to a mere chunk of informations. Please note that those methods are
tentative and subject to change wile implementing other methods
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 3 May 2021 06:10:51 +0000 (15:10 +0900)]
[Props] Add dimension property
This patch add dimension property
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 13 May 2021 06:12:56 +0000 (15:12 +0900)]
[Update] update daily build badge
Daily build has been fixed and badge has been reset. This patch update
badge path and update the information.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Tue, 11 May 2021 07:25:05 +0000 (16:25 +0900)]
[graph] Bug fix for addLossLayer
Removing the last activation is guaranteed to be the last
layer in the Sorted list, but not in the adj graph.
This patch fixes the way the last node is removed from the adj.
Also add some cleanup.
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Parichay Kapoor [Thu, 8 Apr 2021 10:30:22 +0000 (19:30 +0900)]
[graph] Update graph node
Update graph node to use the updated LayerNode
Also add minor bug fix for the graph
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Wed, 12 May 2021 04:51:59 +0000 (13:51 +0900)]
[Fix] Add compiler complaining types
This patch fixes compiler complaning types
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 13 Apr 2021 07:58:05 +0000 (16:58 +0900)]
[tflite] implement serialize
This patch implements serialize with bunch of NYI functions, structures
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Parichay Kapoor [Wed, 12 May 2021 02:17:28 +0000 (11:17 +0900)]
[test] Resolve golden data of size 0
This patch resolves the issue of golden data of size 0.
This happened as a tensor of size 0 was trying to load the data.
As the size was 0, no data was loaded.
Further, this size was used for comparison as well, which led to
faulty testcases being passed as well.
Also batchnormalization layers test were not loading the data.
That is also resolved here.
Resolves #769 #1172
See Also #1180
**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Jihoon Lee [Tue, 13 Apr 2021 02:05:39 +0000 (11:05 +0900)]
[Tf/Skeleton] Add basic meta data
This patch adds basic meta data to tflite file for startup
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 6 May 2021 04:36:22 +0000 (13:36 +0900)]
[Props] Change is_valid function signature
**Changes proposed in this PR:**
- s/is_valid/isValid
- change the function to const
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 6 May 2021 02:41:15 +0000 (11:41 +0900)]
[Props] Add cast operator
**Changes proposed in this PR:**
- Add cast operator to property base for easier use
- Add corresponding test
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 3 May 2021 05:08:47 +0000 (14:08 +0900)]
[Props] Separate base_propeties to a source
This patch separate base_properties into some specialization to source
file
The purpose is to save compile time and redundant doxygen, and clean up
length header.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
hyeonseok lee [Mon, 10 May 2021 08:26:46 +0000 (17:26 +0900)]
Handle PARAMETER_HIDDEN, NULL_RETURNS issue
1. Check return value of malloc function
2. Rename function parameter of lambda function
resolve: 1216568,
12126575, 1222077, 1222080, 1227326, 1227327
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
Jihoon Lee [Mon, 12 Apr 2021 11:15:30 +0000 (20:15 +0900)]
[Skeleton] Add Tflite interpreter skeleton
This patch adds tflite interpreter skeleton
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 12 Apr 2021 10:33:36 +0000 (19:33 +0900)]
[Trivial] Add tflite schema
This patch add tflite schema and corresponding skeleton.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
hyeonseok lee [Fri, 7 May 2021 04:27:59 +0000 (13:27 +0900)]
Added try catch statement
Added try catch on getLoss, readModel, loadFile function
resolve: 1143556
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
hyeonseok lee [Thu, 6 May 2021 12:47:45 +0000 (21:47 +0900)]
Handle Uncaught exception issue
Added try catch statement
resolve: 1143556
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
Jihoon Lee [Mon, 12 Apr 2021 09:33:10 +0000 (18:33 +0900)]
[IniSerializer] Add `serialize` to ini
**Changes proposed in this PR:**
- implements ini interpreter::serialize
- add corresponding test (reference shoud be equal to
serialize->deserialized graph)
- Fix some const correctness
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
hyeonseok lee [Tue, 4 May 2021 08:28:22 +0000 (17:28 +0900)]
Handle Uninitialized pointer field issue
Initialize pointer
resolve: 1227126
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
hyeonseok lee [Tue, 4 May 2021 08:13:54 +0000 (17:13 +0900)]
Handle Uncaught exception issue
Added try catch statement
resolves: 1143556, 1144840
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
hyeonseok lee [Tue, 4 May 2021 06:16:20 +0000 (15:16 +0900)]
Handle NO_EFFECT issue
Delete not effective condition
The type of variable i is unsigned int so i < 0 always false
resolves: 461267, 461268
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
hyeonseok lee [Mon, 3 May 2021 06:13:36 +0000 (15:13 +0900)]
Handle GTEST.NO_ASSERTION issue
Added EXPECT_NO_THROW to handle No Assert Statement Found issue
Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
Jihoon Lee [Mon, 12 Apr 2021 06:06:54 +0000 (15:06 +0900)]
[Layer/props] Convert name to props.
**Changes proposed in this PR:**
- Convert name to props
- Add std::string specialization for property
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Thu, 29 Apr 2021 09:54:11 +0000 (18:54 +0900)]
[TensorDim/Tensor] Update transpose relates
**Changes proposed in this PR:**
- Add tensorDim::transpose(out)
- Add tensor::transpose
- Add test about tensor::transpose
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 12 Apr 2021 03:40:15 +0000 (12:40 +0900)]
[NDK] Add frtti to application build
As real time type information is used in nntrainer, frtti flag is turned
on to fix build issue
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Fri, 9 Apr 2021 13:46:58 +0000 (22:46 +0900)]
[Props] Implement load properties
This patch implement `load_properties` which helps loading properties
for a tuple of properties.
Please note that `getKeyVal` is taken from `parse_util` because there is
a build option issue with android build
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Tue, 27 Apr 2021 12:16:03 +0000 (21:16 +0900)]
[Doxygen] Add doxygen to tensordim
This patch adds doxygen to tensordim.
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
Jihoon Lee [Mon, 26 Apr 2021 08:59:55 +0000 (17:59 +0900)]
[Fix] handle edge case for countNonTrainable
**Changes proposed in this PR:**
- Handle edge case when every layer is non trainable
for `countNonTrainableLayersAtBegin`
- Trivial code cleans on simpleshot task_runner / neuralnetwork
**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped
Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>