Lennart Poettering [Tue, 6 Nov 2018 14:44:24 +0000 (17:44 +0300)]
Merge pull request #10597 from toanju/fix-networkd-l3-loss
networkd: don't remove ip address or route
Lennart Poettering [Tue, 6 Nov 2018 13:46:25 +0000 (16:46 +0300)]
Merge pull request #10650 from yuwata/udevadm-trigger-use-write-string-file
udevadm: use write_string_file() helper function
Tobias Jungel [Tue, 6 Nov 2018 08:55:35 +0000 (09:55 +0100)]
networkd: cleanup for #10542
fixes: 53b1f7d
Lennart Poettering [Tue, 6 Nov 2018 13:41:48 +0000 (16:41 +0300)]
Merge pull request #10652 from yuwata/lldp-ndisc-string-table
lldp,ndisc: update debug logs
Giuseppe Scrivano [Mon, 5 Nov 2018 22:06:14 +0000 (23:06 +0100)]
core, sysctl: skip ENOENT for /proc/sys/net/unix/max_dgram_qlen
sysctl is disabled for /proc mounted from an user namespace thus entries like
/proc/sys/net/unix/max_dgram_qlen do not exist. In this case, skip the error
and do not try to change the default for the AF_UNIX datagram queue length.
Lennart Poettering [Tue, 6 Nov 2018 11:34:01 +0000 (12:34 +0100)]
ask-password: fix minor memory leak on error path
CID 1396557
Tobias Jungel [Tue, 6 Nov 2018 12:28:12 +0000 (13:28 +0100)]
networkd: don't remove route
In case networkd is restarted this prevents a removal of an already existing
route that would be configured using networkd. With the proposed changes the
route will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.
Tobias Jungel [Wed, 31 Oct 2018 12:33:54 +0000 (13:33 +0100)]
networkd: don't remove ip address
In case networkd is restarted this prevents a removal of an already existing IP
address that would be configured using networkd. With the proposed changes the
IP address will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.
Yu Watanabe [Tue, 6 Nov 2018 12:23:52 +0000 (21:23 +0900)]
sd-device: use write_string_file() helper to write sysattr
Yu Watanabe [Tue, 6 Nov 2018 12:23:03 +0000 (21:23 +0900)]
fileio: introduce WRITE_STRING_FILE_NOFOLLOW flag for write_string_file() and friends
Yu Watanabe [Tue, 6 Nov 2018 12:00:07 +0000 (21:00 +0900)]
tree-wide: set WRITE_STRING_FILE_DISABLE_BUFFER flag when we write files under /proc or /sys
Yu Watanabe [Tue, 6 Nov 2018 11:28:25 +0000 (20:28 +0900)]
udevd: use set_oom_score_adjust() to set OOM score
Yu Watanabe [Tue, 6 Nov 2018 03:58:29 +0000 (12:58 +0900)]
udevadm: use write_string_file() helper function
Yu Watanabe [Tue, 6 Nov 2018 05:15:33 +0000 (14:15 +0900)]
test: add tests for string tables for lldp and ndisc events
Yu Watanabe [Tue, 6 Nov 2018 05:07:19 +0000 (14:07 +0900)]
ndisc: improve debug log message
Yu Watanabe [Tue, 6 Nov 2018 04:59:48 +0000 (13:59 +0900)]
lldp: improve debug log message
Lennart Poettering [Tue, 6 Nov 2018 09:28:00 +0000 (12:28 +0300)]
Merge pull request #10611 from yuwata/udev-watch-log
udev-watch: update log levels and messages
Yu Watanabe [Fri, 26 Oct 2018 23:24:25 +0000 (08:24 +0900)]
udev-watch: adjust level of log messages
Yu Watanabe [Fri, 26 Oct 2018 23:19:51 +0000 (08:19 +0900)]
udev-watch: make udev_watch_lookup() return 1 when device found
Yu Watanabe [Fri, 26 Oct 2018 23:06:40 +0000 (08:06 +0900)]
udev: drop redundant log message and fix returned error code
Lennart Poettering [Mon, 5 Nov 2018 20:14:42 +0000 (23:14 +0300)]
Merge pull request #10606 from yuwata/udev-tests
test: mask hwdb-update.services in most tests
Lennart Poettering [Mon, 5 Nov 2018 14:37:25 +0000 (17:37 +0300)]
Merge pull request #10618 from yuwata/fix-10615
network: fix several issues in config parser
Lennart Poettering [Mon, 5 Nov 2018 13:11:50 +0000 (16:11 +0300)]
Merge pull request #10641 from yuwata/fix-10639
network: check the value of prefix length
Yu Watanabe [Mon, 5 Nov 2018 06:38:46 +0000 (15:38 +0900)]
test: add tests for config_parse_address()
Yu Watanabe [Mon, 5 Nov 2018 07:21:38 +0000 (16:21 +0900)]
network: use in_addr_default_prefix_from_string_auto() in config_parse_address()
Yu Watanabe [Mon, 5 Nov 2018 07:20:08 +0000 (16:20 +0900)]
test: add tests for in_addr_default_prefix_from_string() or friend
Yu Watanabe [Mon, 5 Nov 2018 07:18:17 +0000 (16:18 +0900)]
util: introduce in_addr_default_prefix_from_string() and friends
It is similar to in_addr_prefix_from_string() but it determines
the prefix length from address if it is not specified.
Yu Watanabe [Mon, 5 Nov 2018 06:55:45 +0000 (15:55 +0900)]
util: use strndup() instead of strndupa()
As the input string may be comes from command line or config files.
Evgeny Vereshchagin [Mon, 5 Nov 2018 03:47:38 +0000 (06:47 +0300)]
tests: also use lsmod to check whether modules are available (#10634)
It's not entirely impossible to screw something up playing with
kernel modules on a Saturday evening :-) This PR fixes a scenario
where a module has been loaded into the kernel but the module itself
has been removed from the disk.
```
$ lsmod | grep wireg
wireguard 225280 0
ip6_udp_tunnel 16384 1 wireguard
udp_tunnel 16384 1 wireguard
$ modprobe wireguard
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64
$ sudo ./systemd-networkd-tests.py NetworkdNetDevTests.test_wireguard
...
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64
test_wireguard (__main__.NetworkdNetDevTests) ... unexpected success
----------------------------------------------------------------------
Ran 1 test in 5.152s
FAILED (unexpected successes=1)
```
This is a follow-up to https://github.com/systemd/systemd/pull/10625.
Lucas Werkmeister [Mon, 5 Nov 2018 03:47:09 +0000 (04:47 +0100)]
man: locale.conf: fix file name (#10637)
A simple copy+paste mistake, since the reference to
systemd-localed.service was added to both locale.conf(5) and
vconsole.conf(5) in the same commit (
8968e36f21).
Evgeny Vereshchagin [Sat, 3 Nov 2018 17:03:43 +0000 (20:03 +0300)]
tests: add a basic test for wireguard (#10631)
Yu Watanabe [Sat, 3 Nov 2018 07:30:32 +0000 (16:30 +0900)]
vlan-util: add assertions to parse_vlanid()
Yu Watanabe [Sat, 3 Nov 2018 07:29:49 +0000 (16:29 +0900)]
network: add missing .sections element for vcan and vrf
Fixes #10629.
Yu Watanabe [Sat, 3 Nov 2018 06:44:34 +0000 (15:44 +0900)]
network: fix memleak abot Address.label
Also fix possible memleak about Address.section.
Fixes #10628.
Yu Watanabe [Fri, 2 Nov 2018 09:13:14 +0000 (18:13 +0900)]
test: UseRoutes= and UseTimezone= need to be in [DHCP] section
Yu Watanabe [Fri, 2 Nov 2018 08:48:44 +0000 (17:48 +0900)]
test-network: wait after removing links
After
ec6a47044a2ab321ae6427ce0d9fa3f6a17544a8, networkd starts
soon after removing links used by previous test. That causes
some racy situation of removing links and detecting links by networkd.
Yu Watanabe [Fri, 2 Nov 2018 08:36:50 +0000 (17:36 +0900)]
network: drop error cause in log message
Fixes for
21486d9e99463b0dc1f3ff9b9f3846aa67ffca6d.
Yu Watanabe [Fri, 2 Nov 2018 08:14:05 +0000 (17:14 +0900)]
network: fix memleak in static prefix
The fix by
744faf5e4e64e26181f03d1d9fa292ce6fb1456a is not perfect,
as the section leaks if `hashmap_put()` in `prefix_new_static()` fails.
Yu Watanabe [Fri, 2 Nov 2018 07:59:06 +0000 (16:59 +0900)]
netdev: also support GENEVE.UDP6ZeroChecksum{Tx,Rx}=
After
53c06862c12918ec717ea70918039765212eee95, we prefer Checksum
instead of CheckSum. Let's do so for GENEVE netdev.
Yu Watanabe [Fri, 2 Nov 2018 07:38:17 +0000 (16:38 +0900)]
man: drop duplicated line in systemd.netdev(5)
Yu Watanabe [Fri, 2 Nov 2018 07:20:54 +0000 (16:20 +0900)]
network: fix worng offset for .network parser
Yu Watanabe [Thu, 1 Nov 2018 18:25:22 +0000 (03:25 +0900)]
network: fix memleak in config_parse_hwaddr()
Fixes #10615.
Yu Watanabe [Thu, 1 Nov 2018 18:24:57 +0000 (03:24 +0900)]
network: improve readability of config_parse_ifalias()
Yu Watanabe [Thu, 1 Nov 2018 18:17:55 +0000 (03:17 +0900)]
network: fix possible memleak caused by multiple setting of Bridge=, Bond= or VRF=
Yu Watanabe [Thu, 1 Nov 2018 18:15:54 +0000 (03:15 +0900)]
test: add test for radv_prefix_delegation_{from,to}_string()
Yu Watanabe [Thu, 1 Nov 2018 18:15:25 +0000 (03:15 +0900)]
network: introduce radv_prefix_delegation_{from,to}_string()
Yu Watanabe [Thu, 1 Nov 2018 18:14:07 +0000 (03:14 +0900)]
network: fix indentation
Yu Watanabe [Thu, 1 Nov 2018 18:13:03 +0000 (03:13 +0900)]
network: invert the order in comparison
Yu Watanabe [Thu, 1 Nov 2018 18:12:02 +0000 (03:12 +0900)]
network: shorten code a bit
Yu Watanabe [Fri, 2 Nov 2018 01:27:56 +0000 (10:27 +0900)]
test: drop 'After=multi-user.target' from most of testsuite.service
Yu Watanabe [Thu, 1 Nov 2018 08:26:36 +0000 (17:26 +0900)]
test: mask several unnecessary services
This may make CIs run faster.
Yu Watanabe [Thu, 1 Nov 2018 10:54:48 +0000 (19:54 +0900)]
test: increase timeout for TEST-17-UDEV-WANTS
As the test randomly fails with timeout.
This may fix #10274.
Yu Watanabe [Mon, 29 Oct 2018 17:12:13 +0000 (02:12 +0900)]
test: also run compile tests for libudev.h
Felix Yan [Sat, 3 Nov 2018 08:38:41 +0000 (16:38 +0800)]
docs: Fix a typo in CODING_STYLE.md (#10630)
Yu Watanabe [Sat, 3 Nov 2018 08:02:21 +0000 (17:02 +0900)]
Merge pull request #10625 from evverx/test_routing_policy_rule
tests: make NetworkdNetWorkTests.test_routing_policy_rule pass on CentOS
Evgeny Vereshchagin [Fri, 2 Nov 2018 21:08:30 +0000 (22:08 +0100)]
tests: mark a few tests as expected failures when the required modules aren't available
Closes https://github.com/systemd/systemd/issues/10617.
Evgeny Vereshchagin [Fri, 2 Nov 2018 16:03:45 +0000 (17:03 +0100)]
tests: make NetworkdNetWorkTests.test_routing_policy_rule pass on CentOS
Depending on the content of /etc/iproute2/rt_dsfield, ip can print either
`0x08` or `throughput` as was shown in https://github.com/systemd/systemd/issues/10617#issuecomment-
435200859.
Zbigniew Jędrzejewski-Szmek [Fri, 2 Nov 2018 14:05:00 +0000 (15:05 +0100)]
Merge pull request #10624 from splantefeve/fr-translation
po: update French translation and drop copyright
Sylvain Plantefève [Fri, 2 Nov 2018 13:39:19 +0000 (14:39 +0100)]
po: drop my copyright (fr.po)
Sylvain Plantefève [Fri, 2 Nov 2018 13:33:32 +0000 (14:33 +0100)]
po: update French translation
Franck Bui [Fri, 2 Nov 2018 12:24:35 +0000 (13:24 +0100)]
coredump: only install coredump.conf when ENABLED_COREDUMP=true
Tobias Jungel [Fri, 2 Nov 2018 01:31:20 +0000 (02:31 +0100)]
networkd: add missing bonding options (#10542)
Add support for bonding options system prio, port key and actor system mac.
These options exist in the linux kernel since 4.2
(torvalds/linux@
171a42c38c6e1)
Details:
https://www.kernel.org/doc/Documentation/networking/bonding.txt
Evgeny Vereshchagin [Thu, 1 Nov 2018 23:52:53 +0000 (02:52 +0300)]
Merge pull request #10607 from yuwata/fix-10605
network: fix segfault in manager_free()
Yu Watanabe [Thu, 1 Nov 2018 14:41:29 +0000 (23:41 +0900)]
network: drop white space in log message
Yu Watanabe [Thu, 1 Nov 2018 14:40:56 +0000 (23:40 +0900)]
network: fix hash function for routing policy rule
Yu Watanabe [Thu, 1 Nov 2018 14:38:01 +0000 (23:38 +0900)]
network: fix return value of routing_policy_rule_get()
To distinguish source of rule.
Yu Watanabe [Thu, 1 Nov 2018 14:24:17 +0000 (23:24 +0900)]
network: fix memleak in routing policy
As set_put() may fail if input is duplicated.
Yu Watanabe [Thu, 1 Nov 2018 12:46:36 +0000 (21:46 +0900)]
network: fix memleak in static prefix
Fixes #10608.
Yu Watanabe [Thu, 1 Nov 2018 11:21:26 +0000 (20:21 +0900)]
network: fix segfault in manager_free()
Fixes #10605.
Matthew Leeds [Wed, 31 Oct 2018 17:09:41 +0000 (10:09 -0700)]
man: Fix a couple grammatical errors
Lennart Poettering [Wed, 31 Oct 2018 12:04:20 +0000 (13:04 +0100)]
nspawn: beef up netns checking a bit, for compat with old kernels
Fixes: #10544
Xiang Fan [Wed, 24 Oct 2018 10:34:04 +0000 (18:34 +0800)]
ask-password: check keyring in ask_password_tty and ask_password_agent
A race condition happens when calling ask_password_auto() multiple times
to unlock several disks on boot and effectively no password caching is
utilized. This patch fixes it by polling the cache when waiting for
the password.
Lennart Poettering [Wed, 31 Oct 2018 17:26:25 +0000 (18:26 +0100)]
Merge pull request #10010 from msekletar/cryptsetup-generator-keydev-followups
cryptsetup-generator: keydev support - followups
Lennart Poettering [Wed, 31 Oct 2018 15:17:22 +0000 (16:17 +0100)]
nspawn: add proper error message if setns() on network namespace fd fails
Addresses: https://github.com/systemd/systemd/pull/10589#issuecomment-
434670595
Lennart Poettering [Wed, 31 Oct 2018 14:15:41 +0000 (15:15 +0100)]
Merge pull request #10573 from faheel/master
Convert remaining docs to Markdown
welaq [Wed, 31 Oct 2018 13:53:46 +0000 (15:53 +0200)]
l10n: Add Lithuanian translation (#10590)
Create lt.po
Yu Watanabe [Wed, 31 Oct 2018 11:35:06 +0000 (20:35 +0900)]
po: drop my copyright
Lennart Poettering [Wed, 31 Oct 2018 11:10:12 +0000 (12:10 +0100)]
Merge pull request #10556 from yuwata/udev-event-cleanup-2
udev-event: several fixes for previous PR
Yu Watanabe [Wed, 31 Oct 2018 03:35:25 +0000 (12:35 +0900)]
network: also monitor udev 'change' event for network interfaces
If networkd starts earlier than all network interfaces are initialized,
then uninitialized interfaces are staying in pending state and cannot
become up.
With this, such interfaces are started after receiving 'change' event.
Joerg Behrmann [Tue, 30 Oct 2018 15:01:43 +0000 (16:01 +0100)]
core: apply WorkingDirectory after enforce_user
If WorkingDirectory is on NFS, root might only have the privileges of
nobody and the chdir to the WorkingDirectory might fail, even if the
user running the service would have the proper privileges to chdir to
that directory.
Fixes #10568
Alan Jenkins [Wed, 31 Oct 2018 09:49:29 +0000 (09:49 +0000)]
units: remove unused busnames.target
I found zero references to busnames.target, using git grep "busnames".
(And we do not install using a wildcard units/*.*. There is no
busnames.target installed on my Fedora 28 system).
Yu Watanabe [Wed, 31 Oct 2018 10:04:41 +0000 (19:04 +0900)]
Merge pull request #10586 from keszybz/more-copyright-and-license-cleanup
More copyright and license cleanup
Zbigniew Jędrzejewski-Szmek [Wed, 31 Oct 2018 08:29:11 +0000 (09:29 +0100)]
po: drop duplicate "This file is distributed under..." lines
The header already says "LGPL-2.1+", so there is no need to repeat
the same thing more ambiguously.
Zbigniew Jędrzejewski-Szmek [Wed, 31 Oct 2018 08:30:01 +0000 (09:30 +0100)]
Drop copyright for Marius Vollmer
Ack in #9320.
Zbigniew Jędrzejewski-Szmek [Wed, 31 Oct 2018 08:27:22 +0000 (09:27 +0100)]
Drop copyright for Piotr Drąg
Ack in #9320.
Also drop some lines with my name.
Muhammet Kara [Tue, 30 Oct 2018 21:20:03 +0000 (00:20 +0300)]
po: Update Turkish translation
Yu Watanabe [Mon, 29 Oct 2018 13:57:38 +0000 (22:57 +0900)]
dissect: do not store unused devnum
Yu Watanabe [Mon, 29 Oct 2018 13:37:14 +0000 (22:37 +0900)]
udev-event: fix timeout log messages
Follow-up for
e81c3a4c5fbbea89fe6c1e3d0ace669b8130aa92.
Yu Watanabe [Mon, 29 Oct 2018 13:45:14 +0000 (22:45 +0900)]
udev-event: do not store unused devnum
Yu Watanabe [Mon, 29 Oct 2018 03:38:40 +0000 (12:38 +0900)]
udev-event: check whether device has devnum before calling udev_node_remove()
This fixes a bug in 'remove' event handling, which was introduced by
eb1f9e30ec603ab34631cc3adba1def49485b505, as 'devnum' variable may
not be initialized.
scootergrisen [Wed, 31 Oct 2018 00:10:06 +0000 (01:10 +0100)]
danish to Danish (#10584)
Piotr Drąg [Mon, 29 Oct 2018 15:44:07 +0000 (16:44 +0100)]
catalog: update Polish translation
Zbigniew Jędrzejewski-Szmek [Tue, 30 Oct 2018 22:55:39 +0000 (23:55 +0100)]
Merge pull request #10569 from poettering/various-doc-fixes
various man page fixes
Faheel Ahmad [Tue, 30 Oct 2018 17:31:20 +0000 (23:01 +0530)]
docs: Update links to updated docs
Insun [Sun, 28 Oct 2018 12:26:13 +0000 (21:26 +0900)]
core: don't drop timer expired but not yet processed when system date is changed
There is difference between time set by the user and real elapsed time because of accuracy feature.
If you change the system date(or time) between these times, the timer drops.
You can easily reproduce it with the following command.
-----------------------------------------------------------
$ systemd-run --on-active=3s ls; sleep 3; date -s "`date`"
-----------------------------------------------------------
In the following command, the problem is rarely reproduced. But it exists.
---------------------------------------------------------------------------------------------
$ systemd-run --on-active=3s --timer-property=AccuracySec=1us ls ; sleep 1; date -s "`date`"
---------------------------------------------------------------------------------------------
Note : Global AccuracySec value.
----------------------------------------------------------------------
$ cat /etc/systemd/system.conf
DefaultTimerAccuracySec=1min
----------------------------------------------------------------------
Lennart Poettering [Tue, 30 Oct 2018 14:36:52 +0000 (15:36 +0100)]
Merge pull request #10559 from yuwata/sd-device-prototype-change
sd-device: change prototype of sd_device_get_is_initialized()
Lennart Poettering [Mon, 29 Oct 2018 20:09:57 +0000 (21:09 +0100)]
man: document what "in-memory" units means
Fixes: #10338
Lennart Poettering [Mon, 29 Oct 2018 19:49:41 +0000 (20:49 +0100)]
man: document that "list-dependencies --reverse" is pretty incomplete
Fixes: #9681
Lennart Poettering [Mon, 29 Oct 2018 19:45:04 +0000 (20:45 +0100)]
man: emphasize the ReadOnlyPaths= mount propagation "hole"
This changes the ProtectSystem= documentation to refer in more explicit
words to the restrictions of ReadOnlyPath=, as sugegsted in #9857.
THis also extends the paragraph in ReadOnlyPath= that explains the hole.
Fixes: #9857
Lennart Poettering [Mon, 29 Oct 2018 19:24:06 +0000 (20:24 +0100)]
man: document that various sandboxing settings are not available in --user services
This is brief and doesn't go into detail, but should at least indicate
to those searching for it that some stuff is not available.
Fixes: #9870