platform/upstream/llvm.git
8 years agoMove helpers into anonymous namespaces. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 11:21:04 +0000 (11:21 +0000)]
Move helpers into anonymous namespaces. NFC.

llvm-svn: 277918

8 years ago[StaticAnalyzer] Remove dead code.
Benjamin Kramer [Sat, 6 Aug 2016 11:20:59 +0000 (11:20 +0000)]
[StaticAnalyzer] Remove dead code.

llvm-svn: 277917

8 years agoMove helpers into anonymous namespaces. NFC.
Benjamin Kramer [Sat, 6 Aug 2016 11:13:10 +0000 (11:13 +0000)]
Move helpers into anonymous namespaces. NFC.

llvm-svn: 277916

8 years ago[CodeGen] Fix a -Wdocumentation warning
David Majnemer [Sat, 6 Aug 2016 08:37:12 +0000 (08:37 +0000)]
[CodeGen] Fix a -Wdocumentation warning

A parameter was documented with the wrong name.
No functionality change is intended.

llvm-svn: 277915

8 years ago[ValueTracking] Teach computeKnownBits about [su]min/max
David Majnemer [Sat, 6 Aug 2016 08:16:00 +0000 (08:16 +0000)]
[ValueTracking] Teach computeKnownBits about [su]min/max

Reasoning about a select in terms of a min or max allows us to derive a
tigher bound on the result.

llvm-svn: 277914

8 years ago[CallGraphSCCPass] Use an ArrayRef instead of a pair of iterators
David Majnemer [Sat, 6 Aug 2016 06:21:02 +0000 (06:21 +0000)]
[CallGraphSCCPass] Use an ArrayRef instead of a pair of iterators

No functional change is intended.

llvm-svn: 277913

8 years ago[ADT] Make the triple test 1000x faster through more focused test cases.
Chandler Carruth [Sat, 6 Aug 2016 06:00:50 +0000 (06:00 +0000)]
[ADT] Make the triple test 1000x faster through more focused test cases.

The current approach isn't a long-term viable pattern. Given the set of
architectures A, vendors V, operating systems O, and environments E, it
does |A| * |V| * |O| * |E| * 4! tests. As LLVM grows, this test keeps
getting slower, despite my working very hard to make it get some
"optimizations" even in -O0 builds in order to lower the constant
factors. Fundamentally, we're doing an unreasonable amount of work.i

Looking at the specific thing being tested -- the goal seems very
clearly to be testing the *permutations*, not the *combinations*. The
combinations are driving up the complexity much more than anything else.

Instead, test every possible value for a given triple entry in every
permutation of *some* triple. This really seems to cover the core goal
of the test. Every single possible triple component is tested in every
position. But because we keep the rest of the triple constant, it does
so in a dramatically more scalable amount of time. With this model we do
(|A| + |V| + |O| + |E|) * 4! tests.

For me on a debug build, this goes from running for 19 seconds to 19
milliseconds, or a 1000x improvement. This makes a world of difference
for the critical path of 'ninja check-llvm' and other extremely common
workflows.

Thanks to Renato, Dean, and David for the helpful review comments and
helping me refine the explanation of the change.

Differential Revision: https://reviews.llvm.org/D23156

llvm-svn: 277912

8 years ago[ELF][MIPS] Produce a correct and complete set of MIPS ELF header flags
Simon Atanasyan [Sat, 6 Aug 2016 05:11:41 +0000 (05:11 +0000)]
[ELF][MIPS] Produce a correct and complete set of MIPS ELF header flags

The patch extends the `getMipsEFlags` function. Now in that function
we iterate over all object files, parse ELF header flags and merge them.
If a file is incompatible with previously analyzed ones we show an error
or warning. That can happen if, for example, we try to link files with
incompatible ABI, ISA, NAN encoding etc.

There is an alternative solution. We can check and merge flags and
reject incompatible input modules in the `isCompatible` function which
is called from the `SymbolTable::addFile` method. But in that case we
have to save and keep somewhere a merged ELF flags combination to use it
later in the writer.

Differential Revision: http://reviews.llvm.org/D23161

llvm-svn: 277911

8 years ago[InstCombine] Don't coerce non-integral pointers to integers
Sanjoy Das [Sat, 6 Aug 2016 02:58:48 +0000 (02:58 +0000)]
[InstCombine] Don't coerce non-integral pointers to integers

Reviewers: majnemer

Subscribers: mcrosier, llvm-commits

Differential Revision: https://reviews.llvm.org/D23231

llvm-svn: 277910

8 years agoRevert "(refs/bisect/bad) GVN-hoist: enable by default"
Matthias Braun [Sat, 6 Aug 2016 02:23:15 +0000 (02:23 +0000)]
Revert "(refs/bisect/bad) GVN-hoist: enable by default"

GVN-Hoist appears to miscompile llvm-testsuite
SingleSource/Benchmarks/Misc/fbench.c at the moment.

I filed http://llvm.org/PR28880

This reverts commit r277786.

llvm-svn: 277909

8 years agoPart 4c: Coroutine Devirtualization: Devirtualize coro.resume and coro.destroy.
Gor Nishanov [Sat, 6 Aug 2016 02:16:35 +0000 (02:16 +0000)]
Part 4c: Coroutine Devirtualization: Devirtualize coro.resume and coro.destroy.

Summary:
This is the 4c patch of the coroutine series. CoroElide pass now checks if PostSplit coro.begin
is referenced by coro.subfn.addr intrinsics. If so replace coro.subfn.addrs with an appropriate coroutine
subfunction associated with that coro.begin.

Documentation and overview is here: http://llvm.org/docs/Coroutines.html.

Upstreaming sequence (rough plan)
1.Add documentation. (https://reviews.llvm.org/D22603)
2.Add coroutine intrinsics. (https://reviews.llvm.org/D22659)
3.Add empty coroutine passes. (https://reviews.llvm.org/D22847)
4.Add coroutine devirtualization + tests.
ab) Lower coro.resume and coro.destroy (https://reviews.llvm.org/D22998)
c) Do devirtualization <= we are here
5.Add CGSCC restart trigger + tests.
6.Add coroutine heap elision + tests.
7.Add the rest of the logic (split into more patches)

Reviewers: majnemer

Subscribers: mehdi_amini, llvm-commits

Differential Revision: https://reviews.llvm.org/D23229

llvm-svn: 277908

8 years agoRevert r277896.
Nico Weber [Sat, 6 Aug 2016 02:00:45 +0000 (02:00 +0000)]
Revert r277896.

It breaks ExecutionEngine/OrcLazy/weak-function.ll on most bots.

Script:
--
...
--
Exit Code: 1

Command Output (stderr):
--
Could not find main function.

llvm-svn: 277907

8 years ago[NFC] Silence noisy -Wreturn-type warnings
Erik Pilkington [Sat, 6 Aug 2016 01:54:50 +0000 (01:54 +0000)]
[NFC] Silence noisy -Wreturn-type warnings

llvm-svn: 277906

8 years agoCodeGen: If Convert blocks that would form a diamond when tail-merged.
Kyle Butt [Sat, 6 Aug 2016 01:52:37 +0000 (01:52 +0000)]
CodeGen: If Convert blocks that would form a diamond when tail-merged.

The following function currently relies on tail-merging for if
conversion to succeed. The common tail of cond_true and cond_false is
extracted, and this then forms a diamond pattern that can be
successfully if converted.

If this block does not get extracted, either because tail-merging is
disabled or the threshold is higher, we should still recognize this
pattern and if-convert it.
define i32 @t2(i32 %a, i32 %b) nounwind {
entry:
%tmp1434 = icmp eq i32 %a, %b ; <i1> [#uses=1]
br i1 %tmp1434, label %bb17, label %bb.outer

bb.outer: ; preds = %cond_false, %entry
%b_addr.021.0.ph = phi i32 [ %b, %entry ], [ %tmp10, %cond_false ]
%a_addr.026.0.ph = phi i32 [ %a, %entry ], [ %a_addr.026.0, %cond_false ]
br label %bb

bb: ; preds = %cond_true, %bb.outer
%indvar = phi i32 [ 0, %bb.outer ], [ %indvar.next, %cond_true ]
%tmp. = sub i32 0, %b_addr.021.0.ph
%tmp.40 = mul i32 %indvar, %tmp.
%a_addr.026.0 = add i32 %tmp.40, %a_addr.026.0.ph
%tmp3 = icmp sgt i32 %a_addr.026.0, %b_addr.021.0.ph
br i1 %tmp3, label %cond_true, label %cond_false

cond_true: ; preds = %bb
%tmp7 = sub i32 %a_addr.026.0, %b_addr.021.0.ph
%tmp1437 = icmp eq i32 %tmp7, %b_addr.021.0.ph
%indvar.next = add i32 %indvar, 1
br i1 %tmp1437, label %bb17, label %bb

cond_false: ; preds = %bb
%tmp10 = sub i32 %b_addr.021.0.ph, %a_addr.026.0
%tmp14 = icmp eq i32 %a_addr.026.0, %tmp10
br i1 %tmp14, label %bb17, label %bb.outer

bb17: ; preds = %cond_false, %cond_true, %entry
%a_addr.026.1 = phi i32 [ %a, %entry ], [ %tmp7, %cond_true ], [ %a_addr.026.0, %cond_false ]
ret i32 %a_addr.026.1
}

Without tail-merging or diamond-tail if conversion:
LBB1_1:                                 @ %bb
                                        @ =>This Inner Loop Header: Depth=1
        cmp     r0, r1
        ble     LBB1_3
@ BB#2:                                 @ %cond_true
                                        @   in Loop: Header=BB1_1 Depth=1
        subs    r0, r0, r1
        cmp     r1, r0
        it      ne
        cmpne   r0, r1
        bgt     LBB1_4
LBB1_3:                                 @ %cond_false
                                        @   in Loop: Header=BB1_1 Depth=1
        subs    r1, r1, r0
        cmp     r1, r0
        bne     LBB1_1
LBB1_4:                                 @ %bb17
        bx      lr

With diamond-tail if conversion, but without tail-merging:
@ BB#0:                                 @ %entry
        cmp     r0, r1
        it      eq
        bxeq    lr
LBB1_1:                                 @ %bb
                                        @ =>This Inner Loop Header: Depth=1
        cmp     r0, r1
        ite     le
        suble   r1, r1, r0
        subgt   r0, r0, r1
        cmp     r1, r0
        bne     LBB1_1
@ BB#2:                                 @ %bb17
        bx      lr

llvm-svn: 277905

8 years agoIfConverter: Split ScanInstructions into 2 functions.
Kyle Butt [Sat, 6 Aug 2016 01:52:34 +0000 (01:52 +0000)]
IfConverter: Split ScanInstructions into 2 functions.

ScanInstructions is now 2 functions:
AnalyzeBranches and ScanInstructions. ScanInstructions also now takes a
pair of arguments delimiting the instructions to be scanned. This will
be used for forked diamond support to re-scan only a portion of the
block.

llvm-svn: 277904

8 years agoIfConversion: Document countDuplicatedInstructions. NFC
Kyle Butt [Sat, 6 Aug 2016 01:52:33 +0000 (01:52 +0000)]
IfConversion: Document countDuplicatedInstructions. NFC

llvm-svn: 277903

8 years agoIfConversion: factor out 2 functions to skip debug instrs. NFC
Kyle Butt [Sat, 6 Aug 2016 01:52:31 +0000 (01:52 +0000)]
IfConversion: factor out 2 functions to skip debug instrs. NFC

Skipping debug instructions occurrs repeatedly, factor it out.

llvm-svn: 277902

8 years agoRevert "[LoopSimplify] Fix updating LCSSA after separating nested loops."
Michael Zolotukhin [Sat, 6 Aug 2016 01:48:51 +0000 (01:48 +0000)]
Revert "[LoopSimplify] Fix updating LCSSA after separating nested loops."

This reverts commit r277877.
Try to appease clang-x64-ninja-win7 buildbot.

llvm-svn: 277901

8 years agoFix typos from r277797 and unused variable from r277889.
Richard Trieu [Sat, 6 Aug 2016 01:44:06 +0000 (01:44 +0000)]
Fix typos from r277797 and unused variable from r277889.

llvm-svn: 277900

8 years ago[sanitizer] allocator: move TransferBatch into SizeClassAllocator64/SizeClassAllocato...
Kostya Serebryany [Sat, 6 Aug 2016 01:24:11 +0000 (01:24 +0000)]
[sanitizer] allocator: move TransferBatch into SizeClassAllocator64/SizeClassAllocator32 because we actually need different iplementations for the 64- and 32-bit case. NFC; the following patches will make the TransferBatch implementations differ

llvm-svn: 277899

8 years agoTry to fix the ill.cc test on Linux
Reid Kleckner [Sat, 6 Aug 2016 00:57:58 +0000 (00:57 +0000)]
Try to fix the ill.cc test on Linux

llvm-svn: 277898

8 years agoThe lack of classes in the hash table is not an error - it's very legitimately possib...
Enrico Granata [Sat, 6 Aug 2016 00:57:07 +0000 (00:57 +0000)]
The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging /bin/ls

llvm-svn: 277897

8 years ago[ORC] Add (partial) weak symbol support to the CompileOnDemand layer.
Lang Hames [Sat, 6 Aug 2016 00:54:43 +0000 (00:54 +0000)]
[ORC] Add (partial) weak symbol support to the CompileOnDemand layer.

This adds partial support for weak functions to the CompileOnDemandLayer by
modifying the addLogicalModule method to check for existing stub definitions
before building a new stub for a weak function. This scheme is sufficient to
support ODR definitions, but fails for general weak definitions if strong
definition is encountered after the first weak definition. (A more extensive
refactor will be required to fully support weak symbols).

This patch does *not* add weak symbol support to RuntimeDyld: I hope to add
that in the near future.

llvm-svn: 277896

8 years agoFix Windows build - add return statement in SBThread::StepUsingScriptedThreadPlan.
Oleksiy Vyalov [Sat, 6 Aug 2016 00:42:23 +0000 (00:42 +0000)]
Fix Windows build - add return statement in SBThread::StepUsingScriptedThreadPlan.

llvm-svn: 277895

8 years agoUse %stdcxx11 instead of -std=c++11 so the test passes with VS 2015
Reid Kleckner [Sat, 6 Aug 2016 00:37:14 +0000 (00:37 +0000)]
Use %stdcxx11 instead of -std=c++11 so the test passes with VS 2015

llvm-svn: 277894

8 years agoFix a -Wunused-const-variable due to a bug in clang.
Zachary Turner [Sat, 6 Aug 2016 00:13:32 +0000 (00:13 +0000)]
Fix a -Wunused-const-variable due to a bug in clang.

llvm-svn: 277893

8 years ago[IRCE] Remove unused headers; NFC
Sanjoy Das [Sat, 6 Aug 2016 00:02:01 +0000 (00:02 +0000)]
[IRCE] Remove unused headers; NFC

llvm-svn: 277892

8 years ago[IRCE] Preserve loop-simplify form
Sanjoy Das [Sat, 6 Aug 2016 00:01:56 +0000 (00:01 +0000)]
[IRCE] Preserve loop-simplify form

Fixes PR28764.  Right now there is no way to test this, but (as
mentioned on the PR) with Michael Zolotukhin's yet to be checked in
LoopSimplify verfier, 8 of the llvm-lit tests for IRCE crash.

llvm-svn: 277891

8 years agoMention the scripted thread plans in the python reference.
Jim Ingham [Fri, 5 Aug 2016 23:35:26 +0000 (23:35 +0000)]
Mention the scripted thread plans in the python reference.

llvm-svn: 277890

8 years agoFix two false positives in -Wreturn-stack-address
Richard Trieu [Fri, 5 Aug 2016 23:24:47 +0000 (23:24 +0000)]
Fix two false positives in -Wreturn-stack-address

If the return type is a pointer and the function returns the reference to a
pointer, don't warn since only the value is returned, not the reference.

If a reference function parameter appears in the reference chain, don't warn
since binding happens at the caller scope, so addresses returned are not
to local stack.  This includes default arguments as well.

llvm-svn: 277889

8 years agoResubmit "Make YAML support SmallVector"
Zachary Turner [Fri, 5 Aug 2016 23:12:31 +0000 (23:12 +0000)]
Resubmit "Make YAML support SmallVector"

This resubmits a3770391c5fb64108d565e12f61dd77ce71b5b4f,
which was reverted due to breakages on non-Windows machines.

Due to differences in template instantiation rules on Microsoft
and non-Microsoft platforms, a member access restriction was
triggering on non-Microsoft compilers.  Previously, a friend
declaration for std::vector<> had been introduced into the
DebugMap class to make the member access restriction pass,
but the introduction of support for SmallVector<> meant that
an additional friend declaration would need to be added.

This didn't really make a lot of sense since the user of the
macro is probably only using one type (SmallVector<>, vector<>,
etc) and we could in theory add support for even more types
to this macro in the future (e.g. std::deque), so rather than
add another friend declaration, I just made the type being
referenced a public nested typedef instead of a private nested
typedef.

llvm-svn: 277888

8 years ago[NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl
Erik Pilkington [Fri, 5 Aug 2016 22:59:03 +0000 (22:59 +0000)]
[NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl

Differential revision: https://reviews.llvm.org/D23221

llvm-svn: 277887

8 years agoDisable a few more flaky asan64 tests.
Nico Weber [Fri, 5 Aug 2016 22:51:10 +0000 (22:51 +0000)]
Disable a few more flaky asan64 tests.

llvm-svn: 277886

8 years ago[clang-tblgen] Remove unused #include (NFC)
Vedant Kumar [Fri, 5 Aug 2016 22:48:53 +0000 (22:48 +0000)]
[clang-tblgen] Remove unused #include (NFC)

llvm-svn: 277885

8 years agoMention is_stale in the scripted step doc.
Jim Ingham [Fri, 5 Aug 2016 22:47:43 +0000 (22:47 +0000)]
Mention is_stale in the scripted step doc.

llvm-svn: 277884

8 years ago[InstCombine] refactor ctlz/cttz folds (NFCI)
Sanjay Patel [Fri, 5 Aug 2016 22:42:46 +0000 (22:42 +0000)]
[InstCombine] refactor ctlz/cttz folds (NFCI)

Note that this fold really belongs in InstSimplify.
Refactoring here anyway as an intermediate step because
there's a planned addition to this function in D23134.

Differential Revision: https://reviews.llvm.org/D23223

llvm-svn: 277883

8 years agoDisable a few win asan64 tests that don't reliably pass, https://reviews.llvm.org...
Nico Weber [Fri, 5 Aug 2016 22:36:30 +0000 (22:36 +0000)]
Disable a few win asan64 tests that don't reliably pass, https://reviews.llvm.org/D23230

llvm-svn: 277882

8 years agoRevert "Make YAML support SmallVector"
Justin Bogner [Fri, 5 Aug 2016 22:32:33 +0000 (22:32 +0000)]
Revert "Make YAML support SmallVector"

This breaks building dsymutil, causing my local build and many bots to
fail.

This reverts r277870.

llvm-svn: 277881

8 years ago[MSSA] Use depth first iterator instead of custom version.
Daniel Berlin [Fri, 5 Aug 2016 22:09:14 +0000 (22:09 +0000)]
[MSSA] Use depth first iterator instead of custom version.

Summary:
Originally the plan was to use the custom worklist to do some block popping,
and because we don't actually need a visited set. The custom one we have
here is slightly broken, and it's not worth fixing vs using depth_first_iterator since we aren't going to go the route we originally
were.

Fixes PR28874
Reviewers: george.burgess.iv

Subscribers: llvm-commits, gberry

Differential Revision: https://reviews.llvm.org/D23187

llvm-svn: 277880

8 years agoAdd a few more needed bits to the scripted thread plans.
Jim Ingham [Fri, 5 Aug 2016 22:06:12 +0000 (22:06 +0000)]
Add a few more needed bits to the scripted thread plans.

llvm-svn: 277879

8 years agoCodeView: Remove an unused variable
Justin Bogner [Fri, 5 Aug 2016 21:57:10 +0000 (21:57 +0000)]
CodeView: Remove an unused variable

It was breaking the -Werror build.

llvm-svn: 277878

8 years ago[LoopSimplify] Fix updating LCSSA after separating nested loops.
Michael Zolotukhin [Fri, 5 Aug 2016 21:52:58 +0000 (21:52 +0000)]
[LoopSimplify] Fix updating LCSSA after separating nested loops.

This fixes PR28825. The problem was that we only checked if a value from
a created inner loop is used in the outer loop, and fixed LCSSA for
them. But we missed to fixup LCSSA for values used in exits of the outer
loop.

llvm-svn: 277877

8 years agoFix non portable include path.
Zachary Turner [Fri, 5 Aug 2016 21:50:02 +0000 (21:50 +0000)]
Fix non portable include path.

llvm-svn: 277876

8 years agoPowerPC: Add a triple to this test
Justin Bogner [Fri, 5 Aug 2016 21:49:54 +0000 (21:49 +0000)]
PowerPC: Add a triple to this test

This is running opt without specifying a triple, which isn't correct.

llvm-svn: 277875

8 years agoFix two tests in Win64 ASan
Reid Kleckner [Fri, 5 Aug 2016 21:47:46 +0000 (21:47 +0000)]
Fix two tests in Win64 ASan

Go back to intercepting kernel32!RaiseException, and only go for
ntdll!RtlRaiseException if that fails. Fixes throw_and_catch.cc test.

Work around an issue in LLVM's win64 epilogues. We end up with an
epilogue that looks like this, and it drives the Win64 unwinder crazy
until stack overflow:
        call    ill_cc!__asan_handle_no_return
        xor     eax,eax
        add     rsp,40h // epilogue starts
        pop     rbp     // CSR
        ud2             // Trap here
        ret             // Ret?
        nop     word ptr [rax+rax]
        sub     rsp,28h // Next function

Will file a PR soon.

llvm-svn: 277874

8 years ago[MSSA] Match assert vs llvm_unreachable style in verification functions.
Daniel Berlin [Fri, 5 Aug 2016 21:47:20 +0000 (21:47 +0000)]
[MSSA] Match assert vs llvm_unreachable style in verification functions.

llvm-svn: 277873

8 years agoRewrite domination verifier to handle local domination as well.
Daniel Berlin [Fri, 5 Aug 2016 21:46:52 +0000 (21:46 +0000)]
Rewrite domination verifier to handle local domination as well.

Summary:
Rewrite domination verifier to handle local domination as well.
This catches a bug Geoff Berry noticed.

Reviewers: george.burgess.iv

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23184

llvm-svn: 277872

8 years ago[CodeView] Decouple record deserialization from visitor dispatch.
Zachary Turner [Fri, 5 Aug 2016 21:45:34 +0000 (21:45 +0000)]
[CodeView] Decouple record deserialization from visitor dispatch.

Until now, our use case for the visitor has been to take a stream of bytes
representing a type stream, deserialize the records in sequence, and do
something with them, where "something" is determined by how the user
implements a particular set of callbacks on an abstract class.

For actually writing PDBs, however, we want to do the reverse. We have
some kind of description of the list of records in their in-memory format,
and we want to process each one. Perhaps by serializing them to a byte
stream, or perhaps by converting them from one description format (Yaml)
to another (in-memory representation).

This was difficult in the current model because deserialization and
invoking the callbacks were tightly coupled.

With this patch we change this so that TypeDeserializer is itself an
implementation of the particular set of callbacks. This decouples
deserialization from the iteration over a list of records and invocation
of the callbacks.  TypeDeserializer is initialized with another
implementation of the callback interface, so that upon deserialization it
can pass the deserialized record through to the next set of callbacks. In
a sense this is like an implementation of the Decorator design pattern,
where the Deserializer is a decorator.

This will be useful for writing Pdbs from yaml, where we have a
description of the type records in Yaml format. In this case, the visitor
implementation would have each visitation callback method implemented in
such a way as to extract the proper set of fields from the Yaml, and it
could maintain state that builds up a list of these records. Finally at
the end we can pass this information through to another set of callbacks
which serializes them into a byte stream.

Reviewed By: majnemer, ruiu, rnk
Differential Revision: https://reviews.llvm.org/D23177

llvm-svn: 277871

8 years agoMake YAML support SmallVector
Zachary Turner [Fri, 5 Aug 2016 21:45:19 +0000 (21:45 +0000)]
Make YAML support SmallVector

Currently YAML sequences require std::vectors. All of the methods that the
YAML parser accesses though are present in SmallVector, so there's no
reason we can't support SmallVector inherently. This patch does that.

Reviewed By: majnemer
Differential Revision: https://reviews.llvm.org/D23213

llvm-svn: 277870

8 years agoExportTrie nodes need to be visisted in order.
Pete Cooper [Fri, 5 Aug 2016 21:37:12 +0000 (21:37 +0000)]
ExportTrie nodes need to be visisted in order.

The export trie was being emitted in the order the nodes were
added to the vector, but instead needs to be visited in the order
that the nodes are traversed.  This matches the behaviour of ld64.

llvm-svn: 277869

8 years agounwind: disable executable stacks
Saleem Abdulrasool [Fri, 5 Aug 2016 21:35:28 +0000 (21:35 +0000)]
unwind: disable executable stacks

Similar to compiler-rt, ensure that we disable executable stacks for the custom
assembly.

llvm-svn: 277868

8 years agoAMDGPU/SI: Increase SGPR limit to 96 on Tonga/Iceland
Marek Olsak [Fri, 5 Aug 2016 21:23:29 +0000 (21:23 +0000)]
AMDGPU/SI: Increase SGPR limit to 96 on Tonga/Iceland

Summary:
This is the setting of the Vulkan closed source driver.

It decreases the max wave count from 10 to 8.

26010 shaders in 14650 tests
Totals:
VGPRS: 829593 -> 808440 (-2.55 %)
Spilled SGPRs: 81878 -> 42226 (-48.43 %)
Spilled VGPRs: 367 -> 358 (-2.45 %)
Scratch VGPRs: 1764 -> 1748 (-0.91 %) dwords per thread
Code Size: 36677864 -> 35923932 (-2.06 %) bytes

There is a massive decrease in SGPR spilling in general and -7.4% spilled
VGPRs for DiRT Showdown (= SGPRs spilled to scratch?)

Reviewers: arsenm, tstellarAMD, nhaehnle

Subscribers: arsenm, llvm-commits, kzhuravl

Differential Revision: https://reviews.llvm.org/D23034

llvm-svn: 277867

8 years agoFix false positive in -Wunsequenced and templates.
Richard Trieu [Fri, 5 Aug 2016 21:02:34 +0000 (21:02 +0000)]
Fix false positive in -Wunsequenced and templates.

For builtin logical operators, there is a well-defined ordering of argument
evaluation.  For overloaded operator of the same type, there is no argument
evaluation order, similar to other function calls.  When both are present,
uninstantiated templates with an operator&& is treated as an unresolved
function call.  Unresolved function calls are treated as normal function calls,
and may result in false positives when the builtin logical operator is used.
Have the unsequenced checker ignore dependent expressions to avoid this
false positive.  The check also happens in template instantiations to catch
when the overloaded operator is used.

llvm-svn: 277866

8 years ago[ARM] Constant Materialize: imms with specific value can be encoded into mov.w
Weiming Zhao [Fri, 5 Aug 2016 20:58:29 +0000 (20:58 +0000)]
[ARM] Constant Materialize: imms with specific value can be encoded into mov.w

Summary: Thumb2 supports encoding immediates with specific patterns into mov.w by splatting the low 8 bits into other bytes.

I'm resubmitting this patch. The test case in the original commit
r277610 does not specify triple, so builds with differnt default triple
will have different output.

This patch fixed trile as thumb-darwin-apple.

Reviewers: john.brawn, jmolloy, bruno

Subscribers: jmolloy, aemerson, rengolin, samparker, llvm-commits

Differential Revision: https://reviews.llvm.org/D23090

llvm-svn: 277865

8 years ago[FlattenCFG] Simplify + remove unused variable. NFCI.
Davide Italiano [Fri, 5 Aug 2016 20:53:35 +0000 (20:53 +0000)]
[FlattenCFG] Simplify + remove unused variable. NFCI.

llvm-svn: 277864

8 years agoRemove cold callsite heuristic that is not necessary because of cold callee heuristic.
Dehao Chen [Fri, 5 Aug 2016 20:49:04 +0000 (20:49 +0000)]
Remove cold callsite heuristic that is not necessary because of cold callee heuristic.

llvm-svn: 277863

8 years ago[sanitizers] remove failing test.
Mike Aizatsky [Fri, 5 Aug 2016 20:48:48 +0000 (20:48 +0000)]
[sanitizers] remove failing test.

The test often fails on Windows because there are more branches
in the code that is generated.

llvm-svn: 277862

8 years ago[SCEV] Un-grep'ify tests; NFC
Sanjoy Das [Fri, 5 Aug 2016 20:33:49 +0000 (20:33 +0000)]
[SCEV] Un-grep'ify tests; NFC

llvm-svn: 277861

8 years agoReplace hot-callsite based heuristic to use its own threshold parameter instead of...
Dehao Chen [Fri, 5 Aug 2016 20:28:41 +0000 (20:28 +0000)]
Replace hot-callsite based heuristic to use its own threshold parameter instead of share inline-hint parameter

Summary: Hot callsites should have higher threshold than inline hints. This patch uses separate threshold parameter for hot callsites.

Reviewers: davidxl, eraman

Subscribers: Prazek, llvm-commits

Differential Revision: https://reviews.llvm.org/D22368

llvm-svn: 277860

8 years ago[sanitizers] trace buffer API to use user-allocated buffer.
Mike Aizatsky [Fri, 5 Aug 2016 20:09:53 +0000 (20:09 +0000)]
[sanitizers] trace buffer API to use user-allocated buffer.

Differential Revision: https://reviews.llvm.org/D23185

llvm-svn: 277859

8 years ago[sanitizers] trace buffer API to use user-allocated buffer.
Mike Aizatsky [Fri, 5 Aug 2016 20:09:42 +0000 (20:09 +0000)]
[sanitizers] trace buffer API to use user-allocated buffer.

Subscribers: kubabrecka

Differential Revision: https://reviews.llvm.org/D23186

llvm-svn: 277858

8 years agoUpdate outdated comments in the new PM internals (NFC)
Mehdi Amini [Fri, 5 Aug 2016 19:51:00 +0000 (19:51 +0000)]
Update outdated comments in the new PM internals (NFC)

The analysis manager was made not optional and turned into a
reference instead of a pointer in r272978. Some comments were
still refering to the previous behavior.

llvm-svn: 277857

8 years agoWholeProgramDevirt: print remarks with devirtualized method names.
Ivan Krasin [Fri, 5 Aug 2016 19:45:16 +0000 (19:45 +0000)]
WholeProgramDevirt: print remarks with devirtualized method names.

Summary:
Chrome on Linux uses WholeProgramDevirt for speed ups, and it's
important to detect regressions on both sides: the toolchain,
if fewer methods get devirtualized after an update, and Chrome,
if an innocently looking change caused many hot methods become
virtual again.

The need to track devirtualized methods is not Chrome-specific,
but it's probably the only user of the pass at this time.

Reviewers: kcc

Differential Revision: https://reviews.llvm.org/D23219

llvm-svn: 277856

8 years ago[ADCE] Refactoring for new functionality (NFC)
David Callahan [Fri, 5 Aug 2016 19:38:11 +0000 (19:38 +0000)]
[ADCE] Refactoring for new functionality (NFC)

Summary:
This is another refactoring to break up the one function into three logical components functions.
Another non-functional change before we start added in features.

Reviewers: nadav, mehdi_amini, majnemer

Subscribers: twoh, freik, llvm-commits

Differential Revision: https://reviews.llvm.org/D23102

llvm-svn: 277855

8 years ago[ConstantFolding] Don't create illegal (non-integral) inttoptrs
Sanjoy Das [Fri, 5 Aug 2016 19:23:29 +0000 (19:23 +0000)]
[ConstantFolding] Don't create illegal (non-integral) inttoptrs

Reviewers: majnemer, arsenm

Subscribers: mcrosier, llvm-commits

Differential Revision: https://reviews.llvm.org/D23182

llvm-svn: 277854

8 years agofix documentation comments; NFC
Sanjay Patel [Fri, 5 Aug 2016 19:09:25 +0000 (19:09 +0000)]
fix documentation comments; NFC

llvm-svn: 277853

8 years agoPR26423: Assert on valid use of using declaration of a function with an undeduced...
David Blaikie [Fri, 5 Aug 2016 19:03:01 +0000 (19:03 +0000)]
PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

For now just disregard the using declaration in this case. Suboptimal,
but wiring up the ability to have declarations of functions that are
separate from their definition (we currently only do that for member
functions) and have differing return types (we don't have any support
for that) is more work than seems reasonable to at least fix this crash.

llvm-svn: 277852

8 years agofix random typos [NFC]
Etienne Bergeron [Fri, 5 Aug 2016 18:49:08 +0000 (18:49 +0000)]
fix random typos [NFC]

llvm-svn: 277850

8 years ago[AutoFDO] Fix handling of empty profiles
David Callahan [Fri, 5 Aug 2016 18:38:19 +0000 (18:38 +0000)]
[AutoFDO] Fix handling of empty profiles

Summary:
If a profile has no samples for a function, then the function "entry count" is set to the value 0. Several places in the code test that if the Function::getEntryCount is defined at all. Here we change to treat a 0 entry count the same as undefined.

In particular, this fixes a problem in getLayoutSuccessorProbThreshold in MachineBlockPlacement.cpp where we use a different and inferior heuristic for laying out basic blocks.

Reviewers: danielcdh, dnovillo

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23082

llvm-svn: 277849

8 years ago[SCEV] Don't infinitely recurse on unreachable code
Sanjoy Das [Fri, 5 Aug 2016 18:34:14 +0000 (18:34 +0000)]
[SCEV] Don't infinitely recurse on unreachable code

llvm-svn: 277848

8 years ago[ORC] Change LogicalDylib::LogicalModuleHandle from an iterator to an index.
Lang Hames [Fri, 5 Aug 2016 18:26:56 +0000 (18:26 +0000)]
[ORC] Change LogicalDylib::LogicalModuleHandle from an iterator to an index.

This prevents handles from being invalidated (through iterator invalidation)
when new modules are added.

No test-case yet: This bug was uncovered during work on an upcoming patch for
weak symbol support and the testcase for that feature will implicitly test for
correct behavior here.

llvm-svn: 277847

8 years agoCOFF ARM: Apply an existing offset in MOV32T relocations
Saleem Abdulrasool [Fri, 5 Aug 2016 18:20:31 +0000 (18:20 +0000)]
COFF ARM: Apply an existing offset in MOV32T relocations

Don't blindly OR in the new value, but clear the existing one, since it can be
nonzero. Read out the existing value before, and add into the desired offset.
(The add is done outside of the applyMOV, to handle potential overflow between
the two.)

Patch by Martin Storsjö!

llvm-svn: 277846

8 years agoAdd the first of what will be a long line of additional error checks for invalid...
Kevin Enderby [Fri, 5 Aug 2016 18:19:40 +0000 (18:19 +0000)]
Add the first of what will be a long line of additional error checks for invalid Mach-O files.

This is where an LC_SEGMENT load command has a fileoff field that
extends past the end of the file.

Also fix llvm-nm and llvm-size to remove the errorToErrorCode() call so error messages are printed.
And needed to update a few test cases now that they do print the error messages just a
bit differently.

llvm-svn: 277845

8 years agoTweaks to the reporting of "missing dyld shared cached" that make it easier to grab...
Enrico Granata [Fri, 5 Aug 2016 18:09:50 +0000 (18:09 +0000)]
Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the user messaging to make it easier to pinpoint an investigation avenue early on

llvm-svn: 277844

8 years agoDo not assign new discriminator for all intrinsics.
Dehao Chen [Fri, 5 Aug 2016 17:56:49 +0000 (17:56 +0000)]
Do not assign new discriminator for all intrinsics.

Summary: We do not care about intrinsic calls when assigning discriminators.

Reviewers: davidxl, dnovillo

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23212

llvm-svn: 277843

8 years agoFix dumping of process module list and test it
Reid Kleckner [Fri, 5 Aug 2016 17:55:00 +0000 (17:55 +0000)]
Fix dumping of process module list and test it

I probably broke this a year ago in r243895.

llvm-svn: 277842

8 years agoGlobalISel: clear pending phis after MachineFunction translated
Tim Northover [Fri, 5 Aug 2016 17:50:36 +0000 (17:50 +0000)]
GlobalISel: clear pending phis after MachineFunction translated

Test is just reordering the existing functions (it would trigger for any
function after one with a phi).

llvm-svn: 277841

8 years ago[SemaOpenMP] Some miscellaneous cleanups
David Majnemer [Fri, 5 Aug 2016 17:44:54 +0000 (17:44 +0000)]
[SemaOpenMP] Some miscellaneous cleanups

Clean up some typos, follow the coding style a little more rigorously.

No functionality change is intended.

llvm-svn: 277840

8 years ago[X86][SSE] Add initial support for 2 input target shuffle combining.
Simon Pilgrim [Fri, 5 Aug 2016 17:36:14 +0000 (17:36 +0000)]
[X86][SSE] Add initial support for 2 input target shuffle combining.

At the moment only the INSERTPS matching can actually use 2 inputs but the plumbing is now in place.

llvm-svn: 277839

8 years agoCOFF ARM: Error out if 24 bit thumb branches are out of range
Saleem Abdulrasool [Fri, 5 Aug 2016 17:33:24 +0000 (17:33 +0000)]
COFF ARM: Error out if 24 bit thumb branches are out of range

In the ELF linker, the same situation already errors out with "relocation
R_ARM_THM_CALL out of range".

Patch by Martin Storsjö!

llvm-svn: 277838

8 years ago[asan] Remove unused include (NFC)
Vedant Kumar [Fri, 5 Aug 2016 17:28:28 +0000 (17:28 +0000)]
[asan] Remove unused include (NFC)

llvm-svn: 277837

8 years agoCOFF ARM: Clear the J1 and J2 bits when applying relocations to 24 bit branches
Saleem Abdulrasool [Fri, 5 Aug 2016 17:28:21 +0000 (17:28 +0000)]
COFF ARM: Clear the J1 and J2 bits when applying relocations to 24 bit branches

The opcode for the bl branches can initially be F000 F800, i.e.
the J1 and J2 bits are already set. Therefore mask these bits out
before or'ing in the new bits.

Patch by Martin Storsjö!

llvm-svn: 277836

8 years agoGlobalISel: IRTranslate PHI instructions
Tim Northover [Fri, 5 Aug 2016 17:16:40 +0000 (17:16 +0000)]
GlobalISel: IRTranslate PHI instructions

llvm-svn: 277835

8 years agobuiltins: windows has only one flavour on ARM
Saleem Abdulrasool [Fri, 5 Aug 2016 16:53:05 +0000 (16:53 +0000)]
builtins: windows has only one flavour on ARM

Windows on ARM is a hard-float only environment.  Don't try to build two copies
of the same library.

llvm-svn: 277834

8 years agoFix gdb pretty printers to work with Python 3.
Igor Kudrin [Fri, 5 Aug 2016 16:48:31 +0000 (16:48 +0000)]
Fix gdb pretty printers to work with Python 3.

Differential Revision: https://reviews.llvm.org/D23202

llvm-svn: 277833

8 years ago[CodeGen] Use MapVector instead of DenseMap.
Michael Kruse [Fri, 5 Aug 2016 16:45:51 +0000 (16:45 +0000)]
[CodeGen] Use MapVector instead of DenseMap.

The map is iterated over when generating the values escaping the SCoP. The
indeterministic iteration order of DenseMap causes the output IR to change at
every compilation, adding noise to comparisons.

Replace DenseMap by a MapVector to ensure the same iteration order at every
compilation.

llvm-svn: 277832

8 years agoFix TargetParser unit tests for ARM / AArch64.
Zachary Turner [Fri, 5 Aug 2016 16:45:07 +0000 (16:45 +0000)]
Fix TargetParser unit tests for ARM / AArch64.

String pooling is not guaranteed by the standard, so if
you're comparing two different string literals for equality,
you have to use strcmp.

llvm-svn: 277831

8 years agoRevert "[Sema] Add sizeof diagnostics for bzero"
Bruno Cardoso Lopes [Fri, 5 Aug 2016 16:41:00 +0000 (16:41 +0000)]
Revert "[Sema] Add sizeof diagnostics for bzero"

This reverts commit r277787, which caused PR28870.

llvm-svn: 277830

8 years agoopt: Adding -O0 to opt tool
Gor Nishanov [Fri, 5 Aug 2016 16:27:33 +0000 (16:27 +0000)]
opt: Adding -O0 to opt tool

Summary:
Having -O0 in opt allows testing that -O0 optimization
pipeline is built correctly.

Reviewers: majnemer

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23208

llvm-svn: 277829

8 years agobuiltins: better categorisation of Thumb1 builtins
Saleem Abdulrasool [Fri, 5 Aug 2016 16:24:56 +0000 (16:24 +0000)]
builtins: better categorisation of Thumb1 builtins

Adjust the builtins to better annotate the Thumb1 routines and their purpose.
Exclude the remaining thumb1 sources on Windows ARM.

llvm-svn: 277828

8 years ago[StreamExecutor] Add kernel types
Jason Henline [Fri, 5 Aug 2016 16:05:44 +0000 (16:05 +0000)]
[StreamExecutor] Add kernel types

Summary: Add StreamExecutor kernel types.

Reviewers: jlebar, tra

Subscribers: parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D23138

llvm-svn: 277827

8 years agoPrint a more useful BP value from MSVC-built ASan runtimes
Reid Kleckner [Fri, 5 Aug 2016 16:01:57 +0000 (16:01 +0000)]
Print a more useful BP value from MSVC-built ASan runtimes

MSVC doesn't have an exact equivalent for __builtin_frame_address, but
_AddressOfReturnAddress() + sizeof(void*) should be equivalent for all
frames build with -fno-omit-frame-pointer.

llvm-svn: 277826

8 years agoFixed x2APIC discovery for 256-processor architectures.
Andrey Churbanov [Fri, 5 Aug 2016 15:59:11 +0000 (15:59 +0000)]
Fixed x2APIC discovery for 256-processor architectures.

Mask for value read from ebx register returned by CPUID expanded to 0xFFFF.

Differential Revision: https://reviews.llvm.org/D23203

llvm-svn: 277825

8 years agoAMDGPU : Add Clang builtin intrinsics for compare with the full
Wei Ding [Fri, 5 Aug 2016 15:38:46 +0000 (15:38 +0000)]
AMDGPU : Add Clang builtin intrinsics for compare with the full
wavefront result.

Differential Revision: http://reviews.llvm.org/D22934

llvm-svn: 277824

8 years ago[PowerPC] Wrong fast-isel codegen for VSX floating-point loads
Ulrich Weigand [Fri, 5 Aug 2016 15:22:05 +0000 (15:22 +0000)]
[PowerPC] Wrong fast-isel codegen for VSX floating-point loads

There were two locations where fast-isel would generate a LFD instruction
with a target register class VSFRC instead of F8RC when VSX was enabled.
This can ccause invalid registers to be used in certain cases, like:
   lfd 36, ...
instead of using a VSX load instruction.  The wrong register number gets
silently truncated, causing invalid code to be generated.

The first place is PPCFastISel::PPCEmitLoad, which had multiple problems:

1.) The IsVSSRC and IsVSFRC flags are not initialized correctly, since they
are computed from resultReg, which is still zero at this point in many cases.
Fixed by changing the helper routines to operate on a register class instead
of a register and passing in UseRC.

2.) Even with this fixed, Is64VSXLoad is still wrong due to a typo:

bool Is32VSXLoad = IsVSSRC && Opc == PPC::LFS;
bool Is64VSXLoad = IsVSSRC && Opc == PPC::LFD;

The second line needs to use isVSFRC (like PPCEmitStore does).

3.) Once both the above are fixed, we're now generating a VSX instruction --
but an incorrect one, since generation of an indexed instruction with null
index is wrong. Fixed by copying the code handling the same issue in
PPCEmitStore.

The second place is PPCFastISel::PPCMaterializeFP, where we would emit an
LFD to load a constant from the literal pool, and use the wrong result
register class. Fixed by hardcoding a F8RC class even on systems
supporting VSX.

Fixes: https://llvm.org/bugs/show_bug.cgi?id=28630

Differential Revision: https://reviews.llvm.org/D22632

llvm-svn: 277823

8 years ago[SystemZ] Add missing classes and instructions
Zhan Jun Liau [Fri, 5 Aug 2016 15:14:34 +0000 (15:14 +0000)]
[SystemZ] Add missing classes and instructions

Summary:
Add instruction formats E, RSI, SSd, SSE, and SSF.

Added BRXH, BRXLE, PR, MVCK, STRAG, and ECTG instructions to test out
those formats.

Reviewers: uweigand

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D23179

llvm-svn: 277822

8 years agoActually, r277337 was fine. Just kill the DAGs that made the test allow nondeterminism.
Benjamin Kramer [Fri, 5 Aug 2016 14:58:34 +0000 (14:58 +0000)]
Actually, r277337 was fine. Just kill the DAGs that made the test allow nondeterminism.

llvm-svn: 277821

8 years ago[SimplifyCFG] Make range reduction code deterministic.
Benjamin Kramer [Fri, 5 Aug 2016 14:55:02 +0000 (14:55 +0000)]
[SimplifyCFG] Make range reduction code deterministic.

This generated IR based on the order of evaluation, which is different
between GCC and Clang. With that in mind you get bootstrap miscompares
if you compare a Clang built with GCC-built Clang vs. Clang built with
Clang-built Clang. Diagnosing that made my head hurt.

This also reverts commit r277337, which "fixed" the test case.

llvm-svn: 277820

8 years agoreduce tests; auto-generate checks
Sanjay Patel [Fri, 5 Aug 2016 14:50:11 +0000 (14:50 +0000)]
reduce tests; auto-generate checks

llvm-svn: 277819

8 years ago[OpenMP] Sema and parsing for 'teams distribute' pragma
Kelvin Li [Fri, 5 Aug 2016 14:37:37 +0000 (14:37 +0000)]
[OpenMP] Sema and parsing for 'teams distribute' pragma

This patch is to implement sema and parsing for 'teams distribute' pragma.

Differential Revision: https://reviews.llvm.org/D23189

llvm-svn: 277818