Tristan Van Berkom [Tue, 12 Mar 2013 12:34:36 +0000 (21:34 +0900)]
EBookBackendSqliteDB: Fixed configurable summary indexes
A previous commit cause all declared summary fields to also be indexed,
this tiny commit fixes the problem. Only summary fields with explicitly
set indexes should be indexed in the SQLite (i.e. "CREATE INDEX ..." should
only ever be called for a specified subset of summary fields).
Vadim Rutkovsky [Tue, 12 Mar 2013 12:00:44 +0000 (13:00 +0100)]
Correct names for im_jabber_work variables
https://bugzilla.gnome.org/show_bug.cgi?id=690553
Milan Crha [Tue, 12 Mar 2013 09:07:01 +0000 (10:07 +0100)]
[IMAPX] Fix a memory leak around imapx_untagged_vanished()
Matthew Barnes [Mon, 11 Mar 2013 19:28:15 +0000 (15:28 -0400)]
e_cal_client_get_attachment_uris: Forgot to embed the AsyncContext.
Matthew Barnes [Mon, 11 Mar 2013 19:19:58 +0000 (15:19 -0400)]
e_data_cal_respond_get_attachment_uris: Fix a typo.
Kind of an important typo, but a typo nonetheless...
Matthew Barnes [Mon, 11 Mar 2013 18:59:56 +0000 (14:59 -0400)]
EBookClient: Remove direct access checks from asynchronous methods.
The asynchronous methods call the synchronous methods, so let the
synchronous methods handle it. Helps avoid unnecessary complexity.
Matthew Barnes [Mon, 11 Mar 2013 18:44:28 +0000 (14:44 -0400)]
tests: Remove unnecessary thread-default context manipulation.
Мирослав Николић [Mon, 11 Mar 2013 10:17:28 +0000 (11:17 +0100)]
Updated Serbian translation
Tristan Van Berkom [Fri, 8 Mar 2013 07:42:22 +0000 (16:42 +0900)]
EBookBackendSqliteDB: Add new overall revision to the contacts DB
Previous upgrades overlooked the fact that we normalized the contact
data in the summary columns, this added revision ensures that all
contact data is normalized (something that was already done for a
change in phone number normalizations, but only for version 4 -> 5).
For some added safety, this patch changes the normalization
routine to be nested into a transaction.
Fixes bug 695145
Rūdolfs Mazurs [Sun, 10 Mar 2013 21:56:01 +0000 (23:56 +0200)]
Updated Latvian translation
Matthew Barnes [Sat, 9 Mar 2013 23:41:40 +0000 (18:41 -0500)]
ESourceRegistry: Fix a typo.
Matthew Barnes [Fri, 8 Mar 2013 15:03:15 +0000 (10:03 -0500)]
CamelSubscribable: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 15:00:19 +0000 (10:00 -0500)]
CamelStore: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:51:45 +0000 (09:51 -0500)]
CamelFolder: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:45:39 +0000 (09:45 -0500)]
ECalBackend: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:43:59 +0000 (09:43 -0500)]
ECalClientView: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:38:27 +0000 (09:38 -0500)]
ECalClient: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:32:21 +0000 (09:32 -0500)]
EBookClientView: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:26:33 +0000 (09:26 -0500)]
EBookClient: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Matthew Barnes [Fri, 8 Mar 2013 14:20:23 +0000 (09:20 -0500)]
ESourceRegistry: Use weak references in signal closures.
Helps prevent the object from surviving beyond its natural life.
Duarte Loreto [Thu, 7 Mar 2013 23:31:53 +0000 (23:31 +0000)]
Updated Portuguese translation and converted to New Spelling (Novo AO)
Matej Urbančič [Thu, 7 Mar 2013 16:33:20 +0000 (17:33 +0100)]
Updated Slovenian translation
Mathias Hasselmann [Thu, 7 Mar 2013 12:25:01 +0000 (13:25 +0100)]
libebook: Report missing phone number support by GError
Add GError arguments to e_phone_number_get_default_region() and
e_phone_number_get_country_code_for_region() to properly report
missing phone number: Warnings cannot be handled programatically
and make GTest based unit tests failed.
Mathias Hasselmann [Thu, 7 Mar 2013 11:23:29 +0000 (12:23 +0100)]
libebook-contacts: Always use the C linker
Ensure that libebook-contacts always gets linked using the C linker,
instead of the C++ automake would prefer, because of the optional
e-phone-number-private.cpp file. Without this change linking with
explicitly disabled phone number support (--without-phonenumber)
would fail because no C++ linker is know. Similarly the library
would depend on the C++ standard library if phone number was
disabled automatically, because libphonenumber was not found.
Ihar Hrachyshka [Thu, 7 Mar 2013 12:04:58 +0000 (15:04 +0300)]
Updated Belarusian translation.
Milan Crha [Thu, 7 Mar 2013 11:56:06 +0000 (12:56 +0100)]
Bug #695308 - Migration of broken signature breaks whole migration
Gheyret Kenji [Thu, 7 Mar 2013 11:38:50 +0000 (20:38 +0900)]
Updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Nilamdyuti Goswami [Thu, 7 Mar 2013 09:52:33 +0000 (15:22 +0530)]
Assamese translation updated for gnome 3.8
Marián Čavojský [Wed, 6 Mar 2013 22:25:00 +0000 (23:25 +0100)]
Updated slovak translation
Mathias Hasselmann [Tue, 5 Mar 2013 23:03:09 +0000 (00:03 +0100)]
sqlitedb: Update attr_list_indexes during introspection
This is needed to properly reopen addressbooks without
specifying the full custom summary a second time.
Mathias Hasselmann [Tue, 5 Mar 2013 13:28:38 +0000 (14:28 +0100)]
sqlitedb: Only create indexes after introspection
This avoids errors of the kind "e-book-backend-file.c:1478: Failed to open
sqlitedb: table folder_id has no column named file_as" when opening an
addressbook with customized summary a second time, but with default
settings.
Mathias Hasselmann [Fri, 1 Mar 2013 13:05:28 +0000 (14:05 +0100)]
sqlitedb: Improve national phone number matching
The sqlitedb backend and e_phone_number_compare() showed different
behavior for a few cases of national and short number matching.
This syncs the behavior.
Mathias Hasselmann [Thu, 28 Feb 2013 22:46:39 +0000 (23:46 +0100)]
libedata-book: Avoid setlocale()
It is not thread-safe at it changes the entire program's locale
settings. As a side effect also permit locale strings for functions
like e_phone_number_get_country_code_for_region().
Mathias Hasselmann [Fri, 1 Mar 2013 11:49:44 +0000 (12:49 +0100)]
libedata-book: Improve national phone number matching
e_phone_number_compare() and e_phone_number_compare_strings()
had different opinion how well "1234" and "234" match within
NANP regions. First considered them a national significant
number match as it interpreted the leading "1" as country
calling code, the later didn't. The former interpretion fits
better our E.164 normalization we do in the SQLite backend,
therefore we adopted that approach.
This also introduces e_phone_number_compare_strings_for_region().
https://bugs.freedesktop.org/show_bug.cgi?id=59571
Chao-Hsiung Liao [Wed, 6 Mar 2013 10:55:35 +0000 (18:55 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Mathias Hasselmann [Tue, 5 Mar 2013 10:01:37 +0000 (11:01 +0100)]
test-server-utils: Allow to keep sources
Don't call e_client_remove() and such when keep_work_directory
is set. This aids reuse and debugging of sources.
Mathias Hasselmann [Thu, 28 Feb 2013 21:55:39 +0000 (22:55 +0100)]
test-client-custom-summary: Include <config.h>
Enrico Nicoletto [Tue, 5 Mar 2013 21:36:48 +0000 (18:36 -0300)]
Updated Brazilian Portuguese translation
Matthew Barnes [Tue, 5 Mar 2013 15:48:46 +0000 (10:48 -0500)]
goa: Add missing linker flag (for real).
Put the libcamel-1.2 line in the wrong spot.
Simon McVittie [Mon, 4 Mar 2013 20:11:57 +0000 (20:11 +0000)]
EBookClient: be more introspectable
This is mostly a matter of clarifying whose responsibility it is to
free things, in a machine-readable way.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=695151
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Matthew Barnes <mbarnes@redhat.com>
Matthew Barnes [Mon, 4 Mar 2013 21:26:41 +0000 (16:26 -0500)]
Define an enum for 'contacts-reminder-units' setting.
The enum values correspond to EDurationType in Evolution.
Daniel Mustieles [Mon, 4 Mar 2013 13:51:05 +0000 (14:51 +0100)]
Updated Spanish translation
Kjartan Maraas [Mon, 4 Mar 2013 13:48:35 +0000 (14:48 +0100)]
Updated Norwegian bokmål translation
Fran Diéguez [Mon, 4 Mar 2013 12:06:41 +0000 (13:06 +0100)]
Updated Galician translations
Matthew Barnes [Sun, 3 Mar 2013 16:28:14 +0000 (11:28 -0500)]
goa: Add missing linker flag.
Needed when using GOA >= 3.7.90.
Mario Blättermann [Sun, 3 Mar 2013 15:17:49 +0000 (16:17 +0100)]
[l10n] Updated German translation
Matthew Barnes [Sun, 3 Mar 2013 11:49:10 +0000 (06:49 -0500)]
Post-release version bump.
Matthew Barnes [Sun, 3 Mar 2013 11:46:11 +0000 (06:46 -0500)]
NEWS update for 3.7.91 release.
Gheyret Kenji [Sun, 3 Mar 2013 06:59:24 +0000 (15:59 +0900)]
Updated Uyghur translation
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
Matthew Barnes [Sat, 2 Mar 2013 16:35:26 +0000 (11:35 -0500)]
Update API documentation.
Matthew Barnes [Fri, 1 Mar 2013 16:11:06 +0000 (11:11 -0500)]
Coding style and whitespace cleanup.
Matthew Barnes [Sat, 2 Mar 2013 14:47:09 +0000 (09:47 -0500)]
private: Silence compiler warnings in generated source files.
Aurimas Černius [Sat, 2 Mar 2013 16:13:03 +0000 (18:13 +0200)]
Updated Lithuanian translation
Nguyễn Thái Ngọc Duy [Sat, 2 Mar 2013 13:31:59 +0000 (20:31 +0700)]
Updated Vietnamese translation
Nguyễn Thái Ngọc Duy [Sat, 2 Mar 2013 13:05:35 +0000 (20:05 +0700)]
po/vi: import from Damned Lies
Dimitris Spingos [Sat, 2 Mar 2013 11:27:41 +0000 (13:27 +0200)]
Updated Greek translation
Piotr Drąg [Sat, 2 Mar 2013 00:51:43 +0000 (01:51 +0100)]
Updated Polish translation
Piotr Drąg [Fri, 1 Mar 2013 18:35:40 +0000 (19:35 +0100)]
Updated POTFILES.in
Matthew Barnes [Fri, 1 Mar 2013 17:05:00 +0000 (12:05 -0500)]
Make gtk-doc happy about EBookQuery definitions.
gtk-doc interprets
typedef struct EBookQuery EBookQuery;
as multiple definitions of EBookQuery and freaks out.
The usual way to work around this is to mutate the struct name:
typedef struct _EBookQuery EBookQuery;
Matthew Barnes [Fri, 1 Mar 2013 16:56:24 +0000 (11:56 -0500)]
tests: Silence compiler warnings.
Silence compiler warnings in tests which are already partially disabled.
Most of these still haven't been updated since the ESource API changes.
Matthew Barnes [Fri, 1 Mar 2013 16:35:38 +0000 (11:35 -0500)]
Fix a compiler warning when using an older GOA.
Matthew Barnes [Fri, 1 Mar 2013 16:28:56 +0000 (11:28 -0500)]
Makefile.am cleanups.
Мирослав Николић [Fri, 1 Mar 2013 10:11:44 +0000 (11:11 +0100)]
Updated Serbian translation
Matthew Barnes [Thu, 28 Feb 2013 21:45:49 +0000 (16:45 -0500)]
Add EGoaPasswordBased.
This is the GOA-equivalent to ESignonSessionPassword for UOA: a custom
EAuthenticationSession subclass that obtains passwords from the Online
Accounts service. This class does not use a password prompt.
Matthew Barnes [Fri, 1 Mar 2013 00:22:46 +0000 (19:22 -0500)]
source_registry_call_authenticate_for_source: New corner case.
My assumption about all sources in a collection sharing the same
password has been proven wrong by GOA's new "imap_smtp" provider,
which stores IMAP and SMTP passwords separately.
Mathias Hasselmann [Thu, 28 Feb 2013 19:44:28 +0000 (20:44 +0100)]
test-server-utils: Permit custom source names
This is needed for testing behavior after reopening a source.
Milan Crha [Thu, 28 Feb 2013 18:07:28 +0000 (19:07 +0100)]
Bug #694734 - Relative URI in Location on PUT confuses WebDAV
Matthew Barnes [Thu, 28 Feb 2013 15:29:18 +0000 (10:29 -0500)]
ECollectionBackend: Synchronize display-names on mail sources.
Keep display names of mail-related child sources synchronized with the
collection source's display name. This is needed to support GOA's new
"imap_smtp" provider, but all known collection backend implementations
are already doing it on their own anyway.
Seems like a reasonable default behavior given our current use cases.
Matthew Barnes [Thu, 28 Feb 2013 15:50:55 +0000 (10:50 -0500)]
yahoo-backend: Remove display-name synchronization on mail sources.
ECollectionBackend does this now when we chain up in child_added().
Matthew Barnes [Thu, 28 Feb 2013 15:47:30 +0000 (10:47 -0500)]
google-backend: Remove display-name synchronization on mail sources.
ECollectionBackend does this now when we chain up in child_added().
Matthew Barnes [Thu, 28 Feb 2013 14:24:22 +0000 (09:24 -0500)]
goa: Populate imap/smtp details if using GOA >= 3.8.
GOA 3.8 adds "imap-use-ssl" and "smtp-use-ssl" properties to its Mail
interface, which is sufficient to populate mail account and transport
sources since we can now determine the right port number and the type
of transport-layer security (if any) to use.
This is needed to support the new "imap_smtp" provider.
Matthew Barnes [Thu, 28 Feb 2013 11:52:21 +0000 (06:52 -0500)]
module-gnome-online-accounts.c cleanups.
Matthew Barnes [Thu, 28 Feb 2013 02:27:17 +0000 (21:27 -0500)]
ECalClientView: Don't block in dispose().
Matthew Barnes [Thu, 28 Feb 2013 02:24:46 +0000 (21:24 -0500)]
EBookClientView: Don't block in dispose().
Matthew Barnes [Wed, 27 Feb 2013 23:42:46 +0000 (18:42 -0500)]
ECalClient: Create view objects in the D-Bus thread.
Flip-flop the sync/async implementations. The view object should be
instantiated from the dedicated D-Bus thread so its underlying proxy
object shares the same main loop context as the client's proxy.
Have the view object schedule idle callbacks on the client object's
main loop context to emit change notification signals, so as not to
expose the dedicated D-Bus thread to external signal handlers.
Matthew Barnes [Thu, 28 Feb 2013 01:42:32 +0000 (20:42 -0500)]
EBookClient: Create view objects in the D-Bus thread.
Flip-flop the sync/async implementations. The view object should be
instantiated from the dedicated D-Bus thread so its underlying proxy
object shares the same main loop context as the client's proxy.
Have the view object schedule idle callbacks on the client object's
main loop context to emit change notification signals, so as not to
expose the dedicated D-Bus thread to external signal handlers.
Matthew Barnes [Wed, 27 Feb 2013 20:39:53 +0000 (15:39 -0500)]
CamelIMAPXServer: Hold weak references on selected/pending folders.
Because GWeakRef is thread-safe, only need to use the 'select_lock'
when manipulating both the selected and pending folders at once.
Matthew Barnes [Wed, 27 Feb 2013 20:33:54 +0000 (15:33 -0500)]
CamelIMAPXServer: Add a mutex to guard selected/pending folders.
Technically an ABI break, but only affects evolution-kolab so we'll skip
the shared object name bump. Sooner or later all this public crud needs
to be moved to the CamelIMAPXServerPrivate struct.
Piotr Drąg [Wed, 27 Feb 2013 18:54:19 +0000 (19:54 +0100)]
Updated Polish translation
Tristan Van Berkom [Wed, 27 Feb 2013 15:20:39 +0000 (00:20 +0900)]
Added EDS_TESTING env var to silence messages
This commit avoids initializing GTK+ in a 'make check' environment,
as well as avoiding printing of any non-critical messages from
the services running in a 'make check' environment.
Tristan Van Berkom [Wed, 27 Feb 2013 11:09:41 +0000 (20:09 +0900)]
test-client-custom-summary enhancements.
o Added an invalid phone number to custom-6.vcf
o Added a query test ensuring that E_CLIENT_ERROR_INVALID_QUERY is
reported for a completely bogus query 'sexp' string.
o Added a query test ensuring that E_CLIENT_ERROR_INVALID_QUERY is
reported for a phone number query where an invalid phone number term
is provided.
o Added a query test ensuring that an invalid phone number string
can still be matched using a normal E_BOOK_QUERY_BEGINS_WITH query
on the E_CONTACT_TEL field (matching the invalid number in custom-6.vcf).
Tristan Van Berkom [Wed, 27 Feb 2013 11:08:45 +0000 (20:08 +0900)]
EBookBackendFile: Properly translate E_BOOK_SDB_ERROR_QUERY_INVALID errors
Tristan Van Berkom [Wed, 27 Feb 2013 11:02:08 +0000 (20:02 +0900)]
Add E_BOOK_SDB_ERROR_INVALID_QUERY
The invalid query is reported for queries where e_sexp_parse() fails,
or for any queries of the E_BOOK_QUERY_EQUALS_*_PHONE_NUMBER type
where the query term is not a recognized phone number.
Additionally, this patch removes the g_warnings() fired when
invalid phone number values are added to the summary columns
indexed with the E_BOOK_INDEX_PHONE index type (since it's a
perfectly normal use case to set invalid phone number values in
contact phone number fields, we don't want warnings printed
for that).
Chao-Hsiung Liao [Wed, 27 Feb 2013 14:37:02 +0000 (22:37 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Mathias Hasselmann [Tue, 26 Feb 2013 15:06:56 +0000 (16:06 +0100)]
build: Support (and prefer) libboost_thread-mt
Google's libphonenumber uses the Boost Thread library but somehow fails
to let its shared library express that dependency. Therefore we must
manually link that library. Now Fedora only installs libboost_thread-mt,
but not libboost_thread. This patch checks for both build variants of
the threads library and prefers libboost_thread-mt.
The change in preference is because it doesn't make much sense to use
a thread support library that isn't thread-safe, does it?
https://bugzilla.gnome.org/show_bug.cgi?id=694749
Mathias Hasselmann [Wed, 27 Feb 2013 13:39:46 +0000 (14:39 +0100)]
tests: Always create E_BOOK_INDEX_PHONE summary
We also should test the E_BOOK_INDEX_PHONE path in test-client-custom-summary
if full phone number support is disabled.
Daniel Mustieles [Wed, 27 Feb 2013 13:10:39 +0000 (14:10 +0100)]
Updated Spanish translation
Anish A [Wed, 27 Feb 2013 06:35:39 +0000 (10:35 +0400)]
Updated Malayalam Localization
Milan Crha [Tue, 26 Feb 2013 16:13:41 +0000 (17:13 +0100)]
Bug #693345 - dngettext should be used instead of ngettext
Matthew Barnes [Tue, 26 Feb 2013 15:22:03 +0000 (10:22 -0500)]
Make e_contact_photo_copy() public.
Mathias Hasselmann [Tue, 26 Feb 2013 15:02:15 +0000 (16:02 +0100)]
build: Make --without-phonenumber work
Explicitly initialize the am__fastdepCXX conditional if needed.
Apparently autoconf/automake forgets that if AC_PROG_CXX doesn't
get called.
Tristan Van Berkom [Tue, 26 Feb 2013 11:56:33 +0000 (20:56 +0900)]
test-client-custom-summary.c: Test unsupported phone number queries
This patch ensures that the phone number queries report
E_CLIENT_ERROR_NOT_SUPPORTED if EDS was compiled without phonenumber
support.
It also adds an additional test query ensuring that nested queries
are properly detected.
Tristan Van Berkom [Tue, 26 Feb 2013 11:55:28 +0000 (20:55 +0900)]
EBookBackendFile: Propagate correct errors.
Propagate the right E_DATA_BOOK_STATUS code in the case that
E_BOOK_SDB_ERROR_NOT_SUPPORTED is reported from the underlying
EBookBackendSqliteDB
Tristan Van Berkom [Tue, 26 Feb 2013 11:54:17 +0000 (20:54 +0900)]
EBookBackendSqliteDB: added E_BOOK_SDB_ERROR_NOT_SUPPORTED error code
This error code is reported if an unsupported query is given to
->search_contacts() or ->search_contacts_uids().
Tristan Van Berkom [Tue, 26 Feb 2013 11:52:20 +0000 (20:52 +0900)]
Fixed error reporting for direct access apis
When e_data_book_get_contacts[_uids]_finish() is called, the return
value is FALSE if there is any error reported, otherwise it returns
TRUE even if there are no results.
Tristan Van Berkom [Tue, 26 Feb 2013 09:31:08 +0000 (18:31 +0900)]
Moving user-prompter test to noinst_PROGRAMS
This is not a unit test, it cannot be run as a part of make check
because it relies on user input to complete.
Dimitris Spingos [Tue, 26 Feb 2013 08:58:25 +0000 (10:58 +0200)]
Updated Greek translation
Fran Diéguez [Mon, 25 Feb 2013 23:23:10 +0000 (00:23 +0100)]
Updated Galician translations
Kjartan Maraas [Mon, 25 Feb 2013 16:40:01 +0000 (17:40 +0100)]
Updated Norwegian bokmål translation
Kjartan Maraas [Mon, 25 Feb 2013 16:33:25 +0000 (17:33 +0100)]
Updated Norwegian bokmål translation