Mike Blumenkrantz [Wed, 27 Mar 2019 18:34:48 +0000 (14:34 -0400)]
build: fix meson vnc-server option text
Summary: thx @vtorri for reporting
Reviewers: devilhorns, vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, vtorri, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8480
Mike Blumenkrantz [Wed, 27 Mar 2019 18:34:43 +0000 (14:34 -0400)]
build: fix meson pixman dependency name
Summary: thx @vtorri for reporting
Reviewers: devilhorns, vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, vtorri, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8479
Vincent Torri [Wed, 27 Mar 2019 14:59:31 +0000 (10:59 -0400)]
eina benchmark: fix warnings on Windows 64 bits
Summary: long is always a 32 bits type on Windows
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8482
Wonki Kim [Wed, 27 Mar 2019 14:18:41 +0000 (10:18 -0400)]
test: add a test case for elm_entry
Summary:
behaviors of elm_entry has been changed
so that this patch provides usages to keep as a test case.
Reviewers: zmike, Hermet, YOhoho
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8483
Wonki Kim [Wed, 27 Mar 2019 14:18:33 +0000 (10:18 -0400)]
entry: move a point to do 'auto_save' to another place
Summary:
By reworking on efl_file, logic flow for entry has been changed.
and it causes autosave making a file that is passed to elm_entry_file_set empty.
Test Plan:
1. call elm_entry_file_set for a file.
2. check the file is not empty after calling the function.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8362
Change-Id: Icb8202fb9cf55401c26c628358fa39e2947b2f7b
Woochanlee [Wed, 27 Mar 2019 04:11:15 +0000 (13:11 +0900)]
evas_render: Process deferred callback in the sync render case.
Summary:
The EVAS_CALLBACK_RENDER_POST callback has been deferred when the callback is registered during the render(inside_post_render flag on).
In the sync render case, the logic to call deferred callbacks is missing, and callbacks are not being called in certain cases.
@fix
Reviewers: ManMower, Hermet
Reviewed By: Hermet
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8478
Yeongjong Lee [Wed, 27 Mar 2019 07:37:03 +0000 (16:37 +0900)]
efl.spec : add --enable-install-eo-files option
Becuase tizen use eo beta apis, it is needed to install eo files.
Change-Id: Ie6729733ae3fe96e0a4542775dfe6c9266c9222a
Yeongjong Lee [Wed, 27 Mar 2019 07:35:58 +0000 (16:35 +0900)]
Elementary : fix migration build errors
@tizen_fix
Change-Id: Iad251f98ec2706deb69262ef721d526b9fcbe4b1
Yeongjong Lee [Wed, 27 Mar 2019 07:33:56 +0000 (16:33 +0900)]
migration: remove beta tags.
It will fix build error
@tizen_fix
Change-Id: I87a3905bd0f81af5f6182f8f96f29a71679169d3
Vitor Sousa [Mon, 25 Mar 2019 20:14:32 +0000 (17:14 -0300)]
eolian_csharp: hide struct native representation inside the managed struct
Summary:
Rework the struct binding generator to declare the native struct nested inside
the managed one.
This way native structs are less likely to cause confusion; for example
with an IDE that supports automatic completion.
Get rid of struct conversion class methods in favor of using (the already
generated) implicit conversion operators.
Depends on D8469
Reviewers: segfaultxavi, lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8470
Vitor Sousa [Fri, 22 Mar 2019 21:47:27 +0000 (18:47 -0300)]
eolian_csharp: make struct generator use indentation level from context
Summary:
Make the struct generator (the first one to) extract indentation information
from the context, an effort for a future overall consistency in white space
generation.
Depends on D8468
Reviewers: lauromoura, segfaultxavi, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8469
Vitor Sousa [Fri, 22 Mar 2019 21:37:50 +0000 (18:37 -0300)]
eolian_csharp: add indentation context
Summary:
Also, use new context class for cleaner constructs.
Also, make functions receive context objects by reference to avoid
unnecessary object copies (since context objects are bigger now).
This commit contains preparation structures for a future overhaul of
white space generation.
Depends on D8467
Test Plan: ninja test
Reviewers: felipealmeida, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8468
Vitor Sousa [Fri, 22 Mar 2019 21:34:29 +0000 (18:34 -0300)]
eolian_cxx: rework context code, also more flexible scope indentation generator
Summary:
Context management classes now store constant copies of the tags they
are supposed to hold. So, they are immutable objects now.
Functions that manipulate context create new object copies as needed.
`constexpr` was added for class constructor and functions.
Indentation generator now used four space by default.
Also, the amount of desired spaces can now be specified at call site.
Added helper methods to return 'indented' and 'unindented' version of a
given indentation generator object.
Test Plan: ninja test
Reviewers: felipealmeida, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8467
Lauro Moura [Tue, 26 Mar 2019 17:45:18 +0000 (14:45 -0300)]
efl-csharp: Remove spaces from type strings in generator.
Summary:
Previously, the type_impl and marshall_type_impl generators relied on a
type mismatch in the match table to fallback to the else branch in the
match check to actually print the type string. This was achieved by
adding the " " prefix to the type.
This commit changes this behavior to invoke a proper visitor just to
print and makes both generators return trimmed type strings.
This will help conforming to the C# coding conventions.
Test Plan: run test suite
Reviewers: felipealmeida, vitor.sousa
Reviewed By: felipealmeida, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8441
Cedric BAIL [Tue, 26 Mar 2019 16:05:40 +0000 (12:05 -0400)]
elementary: fix ATSPI reflection API warning.
Summary: Depends on D8451
Reviewers: zmike, bu5hm4n, stefan_schmidt, devilhorns
Reviewed By: devilhorns
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8452
Cedric BAIL [Tue, 26 Mar 2019 16:05:02 +0000 (12:05 -0400)]
eina: always initialize i.
Reviewers: zmike, bu5hm4n, stefan_schmidt, devilhorns
Reviewed By: devilhorns
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8451
Vincent Torri [Tue, 26 Mar 2019 14:10:54 +0000 (10:10 -0400)]
evil : remove mkstemp, which is already defined in mingw-w64
Summary: mkstemp is already defined in mingw-w64
Test Plan: compilation
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8454
Marcel Hollerbach [Tue, 26 Mar 2019 14:09:42 +0000 (10:09 -0400)]
evas_3d: stop just segfaulting straight away
Summary:
there have been wrong function calls, that did not work at all, since
the function pointer had the wrong type. This fixes the segfaulting
examples of evas3d. However, they still do not render, at least, they
don't crash anymore.
Depends on D8381
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8382
Bowon Ryu [Tue, 26 Mar 2019 05:20:27 +0000 (14:20 +0900)]
efl_ui_tab_pager: fixed issue where tab_pager does not work
Summary:
I fixed the tab_pager behavior problem caused by changing efl interface.
and I have also fixed some sample code errors.
- using efl_file_load for efl_file_set
- using efl_del for unpacked tab_page
- disable unimplemented features
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8471
Mike Blumenkrantz [Thu, 21 Mar 2019 17:24:47 +0000 (13:24 -0400)]
tests: add function to do "real" timers
in very specific cases it's necessary to match the exact timing of
internal functionality, so add a function to provide that capability
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8439
Mike Blumenkrantz [Thu, 21 Mar 2019 17:08:56 +0000 (13:08 -0400)]
tests: make elm_win visible during tests
elm_win has some internal locking to avoid doing sizing and visibility
changes until pre-render to save some calculations. this makes triggering
ui events on objects impossible, as they will not be visible.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8438
Vincent Torri [Mon, 25 Mar 2019 14:10:47 +0000 (10:10 -0400)]
meson build : remove duplicate check of dirent.h
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8460
Vincent Torri [Mon, 25 Mar 2019 14:10:37 +0000 (10:10 -0400)]
meson build : remove duplicate check of strerror_r
Summary: strerror_r is checked twice in headers_check
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8453
WooHyun Jung [Mon, 25 Mar 2019 12:52:10 +0000 (08:52 -0400)]
elm_entry: fix a bug in moving the magnifier
Summary:
When moving the magnifier in elm_entry, _magnifier_move
function occured infinite loop problem by calling
evas_object_move twice with different positions.
So, I changed it to call evas_object_move once.
ref T7202
Test Plan:
1. Set profile to "mobile"
2. elementary_test
3. entry
4. long press mouse button on elm_entry
5. when the magnifier is shown, try to move it
Reviewers: zmike, bu5hm4n, bowonryu, id213sin
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7202
Differential Revision: https://phab.enlightenment.org/D8462
Hermet Park [Mon, 25 Mar 2019 10:46:24 +0000 (19:46 +0900)]
efl_ui_image: remove job in sizing calc.
Originally, this job task was introduced for trick optimization to avoid
unnecessary duplicated compuation.
But this introduced a regression bug as well, image geometry updation was
delayed by this.
So, we remove the job here.
@fix T7360
Change-Id: I6a11744777186b486e81b87ea5293fa564c732ed
Jaehyun Cho [Mon, 25 Mar 2019 09:58:03 +0000 (18:58 +0900)]
efl_mono: remove unnecessary external function import
ecore_init, ecore_shutdown, elm_init, elm_policy_set, elm_shutdown,
elm_exit are imported in efl_all.cs.
Moreover, efl_csharp_application.cs is using Efl.UnsafeNativeMethods.
Therefore, the unnecessary external function import is removed in
efl_all.cs.
Yeongjong Lee [Mon, 25 Mar 2019 09:56:41 +0000 (09:56 +0000)]
efl_ui_container_layout: use correct property
The `if` condition check whether horizontal, vertical aspect are greater than 0.
`aspect` is correct here.
this patch fixes T7756
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8461
Marcel Hollerbach [Fri, 15 Mar 2019 13:12:04 +0000 (14:12 +0100)]
elm_gengrid: speed up update order calls
update order can be quite expensive, so this here tries to skip it as
often as possible.
ref T7384
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8367
Change-Id: I750d4ac6ebbb03f43a6727786316dd313021a87c
Marcel Hollerbach [Fri, 15 Mar 2019 12:37:33 +0000 (13:37 +0100)]
elm_gengrid: rework focus registration
before just everything has been registered, now only the realized items
are registered.
ref T7384
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8366
Change-Id: I15fe4b231ba5660c4edffceaadd199d7c31ba96f
Shilpa Singh [Thu, 21 Mar 2019 06:16:52 +0000 (06:16 +0000)]
efl_access: add test cases for reading_info_type_set/get API
Add test cases for efl_access_object_reading_info_type_set and efl_access_object_reading_info_type_get
APIs
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8427
Shilpa Singh [Mon, 25 Mar 2019 01:11:39 +0000 (10:11 +0900)]
efl_access: if 0 is set as reading_info_type, remove existing reading_info
Summary:
if 0 is set as reading_info_type, remove existing reading_info and
allow default reading info types (name, role, state and description)
to be read.
Do not set reading info again in reading_info_type_set API if new
value matches the old value.
Test Plan:
If application does not set reading_info_type or set 0 reading_info_type,
All four reading info types of an accessible object should be read on highlight.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
Reviewers: kimcinoo, jsuya, bu5hm4n, lukasz.stanislawski
Subscribers: prasoonsingh16, rajeev.jnnce, #reviewers, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8435
Change-Id: I5258ad5c6a1210c4880aa822ed1c504cf838b8ca
Mike Blumenkrantz [Fri, 22 Mar 2019 13:50:57 +0000 (09:50 -0400)]
evas_clip: check for object validity before adding fallback damage rect
this path should not be triggered for objects which are being deleted,
which was the case in all of the referenced bug reportst
fix T4904, T7100, T7421
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8445
Christopher Michael [Thu, 21 Mar 2019 18:14:57 +0000 (14:14 -0400)]
evas drm: Implement support for outbuf_idle_flush
Christopher Michael [Fri, 22 Mar 2019 16:41:47 +0000 (12:41 -0400)]
evas drm: Implement support for damage_region_set
Summary:
This patch implements engine support for outbuf_damage_region_set that
we can use to mark a framebuffer as being dirty, and to set the dirty
regions on that framebuffer.
ref T7690
Depends on D8403
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8404
Christopher Michael [Fri, 22 Mar 2019 16:41:43 +0000 (12:41 -0400)]
evas drm: Fix software output rotation
Summary:
Don't use redraws_clear to handle buffer swapping. Buffer swapping
should be done on outbuf_flush. This patch fixes evas drm software
output rotation (along with other patches in the series).
ref T7690
@fix
Depends on D8402
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8403
Christopher Michael [Fri, 22 Mar 2019 16:41:38 +0000 (12:41 -0400)]
evas drm: Don't use eng_output_resize or redraws clear
Summary:
We don't need to use eng_output_resize in this engine as
eng_output_update will take care of that. Also, don't use
redraws_clear to handle buffer swapping. This is part one of software
rotation fixes.
ref T7690
@fix
Depends on D8116
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8402
Christopher Michael [Fri, 22 Mar 2019 16:41:28 +0000 (12:41 -0400)]
ecore-evas-drm: Enable rotation to work again
Summary:
This patch removes the ability to do hardware rotation (it's broken
anyway), and refactors the _drm_rotation_do function to just use
software (ecore_evas & evas) rotation.
ref T7690
Depends on D8115
Reviewers: raster, cedric, zmike
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8116
Christopher Michael [Fri, 22 Mar 2019 16:41:25 +0000 (12:41 -0400)]
ecore-drm2: Factor in output rotation when getting output info
Summary:
Enlightenment uses this function to get information about a given
output, so we should be accounting for output rotation when returning
width/height values.
ref T7690
@fix
Depends on D8114
Reviewers: raster, cedric, zmike
Reviewed By: cedric
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8115
Christopher Michael [Fri, 22 Mar 2019 16:41:21 +0000 (12:41 -0400)]
ecore-drm2: Add API function to return output rotation
Summary:
Small patch to add an API function which can be used to return a given
output's rotation value
ref T7690
@feature
Depends on D8113
Reviewers: raster, cedric, zmike, stefan_schmidt, bu5hm4n
Reviewed By: cedric
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8114
Christopher Michael [Fri, 22 Mar 2019 16:41:16 +0000 (12:41 -0400)]
ecore-drm2: Set output rotation value
Summary:
When we call ecore_drm2_output_rotation_set we need to store that
value in the Output structure so that it can be checked later when
needed.
ref T7690
Depends on D8112
Reviewers: raster, cedric, zmike
Reviewed By: cedric
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8113
Christopher Michael [Fri, 22 Mar 2019 16:41:11 +0000 (12:41 -0400)]
ecore-drm2: Disable hardware rotation for outputs
Summary:
Setting output primary plane rotation is broken at the moment, so this
commit will disable that for now until this can be investigated
ref T7690
Depends on D8111
Reviewers: raster, cedric, zmike
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8112
Christopher Michael [Fri, 22 Mar 2019 16:41:08 +0000 (12:41 -0400)]
ecore-drm2: Update plane state values based on FB
Summary:
When we are trying to set an FB onto a plane, we need to update the
plane state values to reflect any changes in the FB. Failure to do
this will result in Atomic Commit failures as the plane state values
will not match what the FB is.
ref T7690
@fix
Depends on D8110
Reviewers: raster, cedric, zmike
Reviewed By: cedric
Subscribers: cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8111
Christopher Michael [Fri, 22 Mar 2019 16:41:03 +0000 (12:41 -0400)]
ecore-drm2: Don't use AtomicAddProperty for plane rotation
Summary:
Apparently something has been changed recently in libdrm
that causes AtomicAddProperty to fail when trying to set plane rotation. Until
this can be found & fixed, let's just disable trying to rotate
hardware planes with atomic commits.
ref T7690
@fix
Reviewers: raster, cedric, zmike
Subscribers: zmike, cedric
Tags: #efl, #do_not_merge
Maniphest Tasks: T7690
Differential Revision: https://phab.enlightenment.org/D8110
Xavi Artigas [Fri, 22 Mar 2019 15:25:22 +0000 (16:25 +0100)]
docs: Add @since 1.22 to all stable classes' EO docs
Summary: Previous @since tags have already been removed from eo files.
Test Plan: Everything builds, but stable classes now have Since tags in the docs.
Reviewers: zmike, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8446
Vincent Torri [Fri, 22 Mar 2019 13:09:14 +0000 (09:09 -0400)]
evil: fix wrong values in timeval
Summary: time values are of type long, but a double values was used
Test Plan: compilation
Reviewers: raster, zmike, q66, simotek
Reviewed By: zmike, simotek
Subscribers: simotek, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8444
Lauro Moura [Thu, 21 Mar 2019 17:38:45 +0000 (14:38 -0300)]
efl-csharp: Add back I prefix for interfaces.
Summary:
Conforming to C# coding conventions.
For properties, now we only generate a wrapper if its name does not
clash with the name of the class that would be implementing it.
Fixes T7751
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: vitor.sousa, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7751
Differential Revision: https://phab.enlightenment.org/D8397
Lauro Moura [Thu, 21 Mar 2019 16:32:17 +0000 (17:32 +0100)]
csharp: Export correct headers and files
Summary:
Some headers and test files were not being exported in autotools.
Also reordered the headers for better tracking.
Test Plan: run make dist and check if resulting tarball builds with --enable-csharp-bindings
Reviewers: stefan_schmidt, zmike, bu5hm4n, segfaultxavi, cedric, devilhorns
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8324
Xavi Artigas [Thu, 21 Mar 2019 16:20:13 +0000 (17:20 +0100)]
mono-tests: Fix after latest changes to eolian
Summary: Event payload checking is more strict now.
Test Plan: Check that master can be built
Reviewers: lauromoura, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8437
Daniel Kolesa [Thu, 21 Mar 2019 15:46:55 +0000 (16:46 +0100)]
eolian: assume requires section is legitimate dependencies
Previously these were not considered, which resulted in false
positive warnings.
Daniel Kolesa [Thu, 21 Mar 2019 15:17:06 +0000 (16:17 +0100)]
eolian: disallow @owned on events
This is never used anywhere and it does not make sense with the
new type rules for events.
Daniel Kolesa [Thu, 21 Mar 2019 14:55:43 +0000 (15:55 +0100)]
eolian: add event type call convention checks for non-beta classes
Vincent Torri [Thu, 21 Mar 2019 10:26:15 +0000 (11:26 +0100)]
Windows, meson build : use posix *printf family function
Summary: the Windows libc has different format flags for the *printf functions, fix this by using the posix version provided with mingw
Test Plan: compilation
Reviewers: zmike, raster, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8432
Marcel Hollerbach [Wed, 20 Mar 2019 14:14:02 +0000 (15:14 +0100)]
eolian: enable event redef checking by default
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D8425
Mike Blumenkrantz [Tue, 19 Mar 2019 18:00:54 +0000 (14:00 -0400)]
ci: disable exit-on-error during configure and also grab stderr
this should resolve some issues where ci was not correctly detecting
changes in env and clearing the config cache during autotools build
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8416
Prasoon Singh [Thu, 21 Mar 2019 09:07:43 +0000 (10:07 +0100)]
elm_gesture_layer: Use flag returned by gesture callbacks
Summary:
Instead of flag returned by gesture callbacks, always EVAS_EVENT_FLAG_NONE
flag was being used.
Test Plan:
As event flag was not being appropriately updated, in some cases expected
behaviour was not seen.
Reviewers: shilpasingh, cedric, Hermet, segfaultxavi
Reviewed By: shilpasingh, segfaultxavi
Subscribers: segfaultxavi, #reviewers, rajeev.jnnce, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8421
Mike Blumenkrantz [Tue, 19 Mar 2019 14:00:21 +0000 (10:00 -0400)]
efl_ui_win: avoid triggering legacy forbidden path during window finalize
this (unintentionally) revealed some bugs where apps/examples were mixing
eo and legacy code for elm_win which breaks things pretty badly. I'm only
here so I don't get fined.
ref T7713
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8401
Mike Blumenkrantz [Tue, 19 Mar 2019 13:59:01 +0000 (09:59 -0400)]
efl_ui_win: mark legacy forbidden during bg part load always
calling this function indicates legacy is forbidden, not successfully
loading a file. this is functionally meaningless, as the only way to
trigger the previous codepath would be to have previously set legacy
as forbidden, but perhaps it will be slightly easier to read now
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8400
Mike Blumenkrantz [Mon, 18 Mar 2019 18:03:17 +0000 (14:03 -0400)]
elm_test: set accel for all glview tests
these otherwise require the user to set ELM_ACCEL or manually change
the config which is cumbersome
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8392
Mike Blumenkrantz [Mon, 18 Mar 2019 17:27:57 +0000 (13:27 -0400)]
elm_test: move gl api creation to glview init function
this needs to happen when the gl context is current to avoid a billion
errors and overall general failure
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8390
Mike Blumenkrantz [Mon, 18 Mar 2019 13:27:14 +0000 (09:27 -0400)]
efl_ui_win: fix hw accel detection
the ordering of priority here is supposed to be:
1. env vars
2. global override config
3. window config
4. global config
in the case where 1 and 3 were not set, however, this would end up
mangling the global config values and not using the gl options
@fix
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8389
Mike Blumenkrantz [Mon, 18 Mar 2019 13:26:19 +0000 (09:26 -0400)]
elm_test: use legacy api for glview gears test
mixing interfaces api with legacy api is bad for elm_win
ref T7713
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8388
Xavi Artigas [Wed, 20 Mar 2019 18:46:44 +0000 (19:46 +0100)]
docs: Remove obsolete @since tags from EO files
Summary:
All legacy @since tags have already moved to the *.legacy.h files.
EO files are now devoid of @since tags (except some eldbus still
needed for legacy).
Upcoming patches will add @since 1.22 to those APIs which come out
of beta in this release.
APIs marked @beta do not need @since tags.
Test Plan: Everything builds, EO docs (like DocFX) have no Since tags.
Reviewers: zmike, bu5hm4n, lauromoura, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8430
Marcel Hollerbach [Wed, 20 Mar 2019 07:36:21 +0000 (08:36 +0100)]
efl_ui_tab_bar: the type of this event is annotated as object
however, efl_ui_tab_bar does pass in there a int. For now i decided that
we just pass NULL here, if this is not accaptable then we can still add
another event to the object itself.
fix T7758
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8418
Lauro Moura [Wed, 20 Mar 2019 17:29:25 +0000 (17:29 +0000)]
csharp: Remove test about conflicting events.
Conflictings events won't be allowed anymore on eolian-based classes.
For manually subclassed C# classes that eventually have conflicts, this
should be dealt with in T7744.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8426
Christopher Michael [Thu, 14 Mar 2019 16:36:11 +0000 (12:36 -0400)]
efl_canvas_vg_object: Fix dereference after null check
Coverity reports that both pname & file variables can be null here,
and that we are potentially passing NULL to strcmp. Check for valid
variables before passing to strcmp
Fixes Coverity CID1399423, CID1399421
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8350
Marcel Hollerbach [Wed, 20 Mar 2019 14:01:23 +0000 (15:01 +0100)]
efl_ui_selection: give this event a better name
this event does not get emitted when selection per se changes, it gets
emitted when the selection in the window manager changes. we should
prefix this even with that.
ref T7476
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8424
Marcel Hollerbach [Wed, 20 Mar 2019 13:57:11 +0000 (14:57 +0100)]
efl_ui_list_view: remove not used event
this event is not used here, and if it ever is used, then it should
probebly be using efl.ui.selectable.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8423
Marcel Hollerbach [Wed, 20 Mar 2019 15:24:43 +0000 (11:24 -0400)]
build: codegen generation should depend on elementary_codegen
Summary:
otherwise buildfailures like :
/usr/bin/env EFL_RUN_IN_TREE=1 /Users/travis/build/Enlightenment/efl/build/src/bin/elementary/elementary_codegen -p=codegen_example src/examples/elementary/codegen_example.edj elm/example/mylayout/default src/examples/elementary/codegen_example_generated.c src/examples/elementary/codegen_example_generated.h
Can appear.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8428
Yeongjong Lee [Wed, 20 Mar 2019 14:28:45 +0000 (10:28 -0400)]
ui.box_stack: refactor layout_update
Summary:
This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.
Depends on D8214
Test Plan:
1. make check
2. elementary_test -to 'efl.ui.box_stack'
Reviewers: zmike, Jaehyun_Cho, cedric
Reviewed By: zmike, Jaehyun_Cho, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8094
Shilpa Singh [Wed, 20 Mar 2019 14:16:11 +0000 (14:16 +0000)]
efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs
Add attribute_del API, currently there is no provision to delete a particular attribute(key-value pair)
from the attribute list of a widget.
Add test cases for efl_access_attribute_append, efl_access_attributes_get, efl_access_attribute_del and efl_access_attributes_clear API
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Shinwoo Kim <cinoo.kim@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8386
Marcel Hollerbach [Wed, 20 Mar 2019 07:34:33 +0000 (08:34 +0100)]
efl_con: fixup copy'n paste error
please see https://phab.enlightenment.org/D8411#151797, it appears here
was a copy and paste error. This fixes the ecore_con test suite
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8419
Lauro Moura [Wed, 20 Mar 2019 13:12:35 +0000 (14:12 +0100)]
efl: Add missing docs to parameters.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8422
Yeongjong Lee [Wed, 20 Mar 2019 11:45:00 +0000 (12:45 +0100)]
efl.pack_table: inherit efl.pack instead of efl.pack_linear
Summary:
>>! In T5301#110572, @jpeg wrote:
> Quick recap before I leave.
> ...
> ...
> - Pack interfaces - T5328
>
> Table does not need to inherit from "linear" (1d) layout: this brings unnecessary complexity, for a dubious use case.
We don't have linear layout policy of table(2d) layout. furthermore, i don't
think it will be clearly defined. it is enough for Efl.Pack_Table to support
`efl_pack` which work the same as `efl_pack_end`.
ref T5719, T5328
Test Plan:
- make
- elementary_test -to 'efl.ui.table'
- elementary_test -to 'efl.ui.table(linear api)'
Reviewers: zmike, woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, jpeg, #committers
Tags: #efl
Maniphest Tasks: T5719, T5328
Differential Revision: https://phab.enlightenment.org/D8420
Lauro Moura [Wed, 20 Mar 2019 10:26:49 +0000 (11:26 +0100)]
csharp: Remove missing doc warning by filling them.
Summary:
Added basic documentation for things that were missing.
Some other files are silent due to a pragma disabling CS1591. They
should be handled later.
Also, removed `Efl.Io.Positioner` from the blacklist as it is referenced
from the `Efl.Io.Reader.eos` event documentation.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: felipealmeida, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8370
Xavi Artigas [Wed, 20 Mar 2019 10:24:05 +0000 (11:24 +0100)]
Remove dead code
Xavi Artigas [Wed, 20 Mar 2019 09:47:22 +0000 (10:47 +0100)]
mono-docs: Use @since tags properly
Summary:
Only the number was being used, and in places were it should not be.
Now the Since version appears only in <summary> tags, with proper
context (Since EFL 1.22).
Test Plan: make && gendoc should produce DocFX pages which make more sense.
Reviewers: lauromoura, zmike, bu5hm4n
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8012
Jaehyun Cho [Wed, 20 Mar 2019 02:24:51 +0000 (11:24 +0900)]
eolian_mono: apply indentation of if scope
Mike Blumenkrantz [Tue, 19 Mar 2019 20:32:02 +0000 (16:32 -0400)]
efl_io_*: apply new event calling convention
Summary:
ref T7758
Depends on D8409
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8410
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:55 +0000 (16:31 -0400)]
efl_ui_focus_object: apply new event calling convention
Summary:
ref T7758
Depends on D8408
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8409
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:50 +0000 (16:31 -0400)]
evas: apply new event calling convention
Summary:
ref T7758
Depends on D8407
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8408
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:45 +0000 (16:31 -0400)]
efl_ui_tags: apply new event calling convention
Summary:
it appears that this event calling is a bit fishy, the value of the
second callback call was never set, i think the shrink flag here is what
we want to return here.
T7758
Depends on D8406
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8407
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:39 +0000 (16:31 -0400)]
efl_ui_win: apply new event calling convention
Summary:
ref T7758
Depends on D8405
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8406
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:34 +0000 (16:31 -0400)]
efl_ui_focus_manager_sub: apply new event calling convention
Summary: ref T7758
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8405
Marcel Hollerbach [Tue, 19 Mar 2019 20:30:19 +0000 (16:30 -0400)]
efl_ui: rename select and unselected of efl_ui_selectable
Summary:
this was conflicting with a model event. Prefixing it with "item,"
resolves this, and describes better what it does.
Depends on D8413
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8414
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:45 +0000 (16:29 -0400)]
elm: do not use eo events here
Summary:
we want to rename it, and this would break legacy behaviour, so better
this way.
Depends on D8412
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8413
Change-Id: Iab72a30628e5864c64e7059434f11e19d5576c05
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:39 +0000 (16:29 -0400)]
Revert "efl_ui_selectable: namespace events to avoid conflicts"
Summary:
This reverts commit
f629f11bedad7b137b012d36102ad5bb1f2b4b4f.
This breaks legacy events. As the selected event is used in legacy
widgets. Also this commits mixed up two different concepts, selection in
a entry etc. and selection of a item.
Depends on D8411
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8412
Change-Id: Ia3b3ce930bb5b46dfa4a2beaa26ddb201d494f02
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:34 +0000 (16:29 -0400)]
efl_net: resolve cases where we passed something as event_info
Summary: but the event was annotated to *not* contain any event_info.
Reviewers: cedric, segfaultxavi, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8411
Marcel Hollerbach [Tue, 19 Mar 2019 20:28:10 +0000 (16:28 -0400)]
efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8415
Stefan Schmidt [Tue, 19 Mar 2019 19:10:33 +0000 (20:10 +0100)]
release: Update NEWS and bump version for 1.22.0-beta2 release
Yeongjong Lee [Fri, 15 Mar 2019 10:52:32 +0000 (10:52 +0000)]
efl_ui_text_alert_popup: use correct theme klass name
text_alert_popup is not scroll_alert_popup.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8364
Mike Blumenkrantz [Mon, 18 Mar 2019 18:13:39 +0000 (14:13 -0400)]
elm_code: add theme alias for layout group
with the rename of this (beta) widget, the efl/ group name is set so
add this to the theme for now until more work can be done here to resolve
the rest of the theme namespacing issues which will only be an issue
if the widget is ever made stable
ref T7713
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8393
Xavi Artigas [Tue, 19 Mar 2019 15:50:13 +0000 (16:50 +0100)]
Revert "efl_ui_widget: resolve warning about multiple defines"
This reverts commit
9012742f9a6e0ac09f34b7df23b1ac8d166239e1.
I landed this too hastily.
Marcel Hollerbach [Tue, 19 Mar 2019 15:39:59 +0000 (16:39 +0100)]
efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.
Depends on D8394
Reviewers: zmike, segfaultxavi, cedric, devilhorns
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8395
Lauro Moura [Tue, 19 Mar 2019 14:50:50 +0000 (15:50 +0100)]
csharp: rename add/remove event handler
Summary:
Conform to C# API conventions.
Ref T7752
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7752
Differential Revision: https://phab.enlightenment.org/D8396
Christopher Michael [Tue, 19 Mar 2019 12:57:59 +0000 (08:57 -0400)]
eldbus: Fix resource leak
Summary:
Coverity reports that we leak 'data' here (which can happen if we
error on 'eina_value_dup(value)'). Iniitalize 'data' to NULL, and add a
'free' call to cleanup 'data' before we return a rejected future.
Fixes Coverity CID1399097
@fix
Depends on D8350
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8352
Christopher Michael [Tue, 19 Mar 2019 12:33:01 +0000 (08:33 -0400)]
efl_ui_widget: Remove duplicate definition of ELM_WIDGET_DATA_GET
Patch
28400e3260b3c6af56ce6b added a define for ELM_WIDGET_DATA_GET
which is available for all widgets so we do not need to redefine it
here.
Christopher Michael [Tue, 19 Mar 2019 12:31:03 +0000 (08:31 -0400)]
elm_entry: Add missing EINA_UNUSED
'sd' is an unused parameter here so add missing EINA_UNUSED
Christopher Michael [Mon, 18 Mar 2019 19:19:21 +0000 (15:19 -0400)]
elementary: Use efl_data_scope_safe_get when trying to get widget data
As per bu5hm4n, these macros should be using efl_data_scope_safe_get
when trying to get widget data
Christopher Michael [Mon, 18 Mar 2019 19:13:36 +0000 (15:13 -0400)]
elementary: Add ELM_WIDGET_DATA_GET macro
There are cases, such as
2abe5ad9bc6d30f0c29381dca7e where we do not
always want to return if we fail to get the elm widget data (as we may
have to cleanup leaks, etc). As such, add a macro we can call which
will just try to fetch the elm_widget data.
Ali Alzyod [Mon, 18 Mar 2019 18:40:10 +0000 (19:40 +0100)]
Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string
Summary:
Fix issue where **_entry_has_new_line** will not detect '<br>' or '<ps>' inside markup text as new lines indicators.
this functionlity effect following public function:
**elm_entry_single_line_set()**
Reviewers: woohyun, bowonryu, ManMower, cedric, raster, segfaultxavi
Reviewed By: bowonryu, segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8323
projects / platform / upstream / efl.git / log