platform/upstream/dotnet/runtime.git
5 years agoDelete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)
Jeremy Koritzinsky [Fri, 7 Jun 2019 02:58:08 +0000 (19:58 -0700)]
Delete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)

* Delete CoreFX tests of COM lifetime control methods.

* Remove deleted files from project file.

Commit migrated from https://github.com/dotnet/corefx/commit/500e6882a78c92ecfd584bd4d8ba8e49f4410eb7

5 years agoSimplify loop add with UnionWith method. (dotnet/corefx#38300)
Tim [Fri, 7 Jun 2019 02:56:56 +0000 (21:56 -0500)]
Simplify loop add with UnionWith method. (dotnet/corefx#38300)

Commit migrated from https://github.com/dotnet/corefx/commit/78c4949d341dc51739e4027611f267700e58b60e

5 years agoRemove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals...
wcontayon [Fri, 7 Jun 2019 02:51:38 +0000 (02:51 +0000)]
Remove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals (dotnet/corefx#38325)

Commit migrated from https://github.com/dotnet/corefx/commit/29c88546923bca1cdfba6091098c5d25bd09fd00

5 years agoNullable annotate System.Private.Uri (dotnet/corefx#38113)
Stephen Toub [Fri, 7 Jun 2019 01:57:41 +0000 (21:57 -0400)]
Nullable annotate System.Private.Uri (dotnet/corefx#38113)

* Nullable annotate System.Private.Uri

* Address PR feedback

* Fix unit tests project

Commit migrated from https://github.com/dotnet/corefx/commit/df452f1ee61004dd1d61811fdd80ab165c2d8b1b

5 years agoAdd nullable attributes to partial facade implementations (dotnet/corefx#38309)
Stephen Toub [Fri, 7 Jun 2019 01:54:11 +0000 (21:54 -0400)]
Add nullable attributes to partial facade implementations (dotnet/corefx#38309)

* Add nullable attributes to partial facade implementations

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3ea7b55e275fb6367f67e7fb0432be4bb3902f09

5 years agoThrowing Jsonexception when trying to convert a value into a Dictionary (dotnet/coref...
Anirudh Agnihotry [Thu, 6 Jun 2019 23:32:42 +0000 (16:32 -0700)]
Throwing Jsonexception when trying to convert a value into a Dictionary (dotnet/corefx#38183)

* improving exception

* adding immutable check and moving check to proper place

* adding poco dictionary tests

* combining if conditions

Commit migrated from https://github.com/dotnet/corefx/commit/05171beb453577b516caa051ce2bea2ae48d4b83

5 years agoExpose SecurityDescriptor as protected (dotnet/corefx#38283)
Jeremy Kuhne [Thu, 6 Jun 2019 22:16:53 +0000 (15:16 -0700)]
Expose SecurityDescriptor as protected (dotnet/corefx#38283)

* Expose SecurityDescriptor as protected

Classes derived from ObjectSecurity depended on seeing the _securityDescriptor field, which is marked internal. Internal visibility no longer works as types have split into different assemblies and is causing failures, such as dotnet/corefx#35993.

This change also ran the UpdateVSConfigurations target on the changed libraries.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7570445805fe57966ff6494fcd582de8b79088a0

5 years agoMerge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311
Dustin Campbell [Thu, 6 Jun 2019 22:13:53 +0000 (15:13 -0700)]
Merge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311

Allow ReflectPropertyDescriptor to reflect over non-public members

Commit migrated from https://github.com/dotnet/corefx/commit/8dc48fad4eac24fd2997f6e73751fd7317e2b19b

5 years agoUpdate Reflection.Emit and String tests after changes due to nullable review (dotnet...
Santiago Fernandez Madero [Thu, 6 Jun 2019 21:01:05 +0000 (14:01 -0700)]
Update Reflection.Emit and String tests after changes due to nullable review (dotnet/corefx#38269)

* Update Reflection.Emit and String tests after changes due to nullable review

* Run darc update to update coreclr dependencies

* Add missing assert

Commit migrated from https://github.com/dotnet/corefx/commit/bdbdfaa286b94c44fadb2abd64e858b2e533a2cf

5 years agoRemove NetNative uapaot support (dotnet/corefx#38170)
Viktor Hofer [Thu, 6 Jun 2019 19:39:46 +0000 (21:39 +0200)]
Remove NetNative uapaot support (dotnet/corefx#38170)

* Remove NetNative uapaot support

* Remove uapaot assets from packages

* Disable emit lightweight and ilgen version check

Commit migrated from https://github.com/dotnet/corefx/commit/ab58ff6e649852b85fdb99b15992a2fa3a7d8834

5 years agoClean up code style in PropertyDescriptorTests.cs
Dustin Campbell [Thu, 6 Jun 2019 19:31:12 +0000 (12:31 -0700)]
Clean up code style in PropertyDescriptorTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/bce319455d8a71bc422249ffb5b1bed89cbffaa8

5 years agoAllow ReflectPropertyDescriptor to reflect over non-public members
Dustin Campbell [Thu, 6 Jun 2019 18:49:43 +0000 (11:49 -0700)]
Allow ReflectPropertyDescriptor to reflect over non-public members

Fixes dotnet/corefx#38311

On .NET Framework, ReflectPropertyDescriptor can access non-public members,
but has been disabled on .NET Core since ReflectPropertyDescriptor was ported.
Most PropertyDescriptor runtime scenarios don't require this behavior, but
design-time scenarios do. Component/Control designers can (and do) create new
PropertyDescriptors that expose non-public properties from runtime components
for design-time (e.g. for display in the Property Browser). In addition,
designers often create "shadow" properties which are used at design-time in place
of the actual properties on the runtime components. A shadowed property is normally
declared as private, but ReflectPropertyDescriptor still needs to be able to find
it.

Commit migrated from https://github.com/dotnet/corefx/commit/7cfe839e1d076b55fb14d5fa519f1b86d8833fa4

5 years agoMerge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1
Matt Galbraith [Thu, 6 Jun 2019 17:00:01 +0000 (10:00 -0700)]
Merge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1

Fix Debian 10 image

Commit migrated from https://github.com/dotnet/corefx/commit/a5eec2c658782103e5baf2a42f2112d5be063c66

5 years agoFix Debian 10 image
Matt Galbraith [Thu, 6 Jun 2019 16:47:22 +0000 (09:47 -0700)]
Fix Debian 10 image

Older image had missing home/helixbot folder which broke reporting;  tested and fixed in run e395a455-344e-411b-9ac2-1b3b89671ca3

@safern , @wfurt FYI

Commit migrated from https://github.com/dotnet/corefx/commit/e9bc423c0455a9c12702382e6f5cd7d0eeed7973

5 years agoImprove ReadOnlySequence.Slice docs (dotnet/corefx#38150)
Bradley Grainger [Thu, 6 Jun 2019 13:29:10 +0000 (06:29 -0700)]
Improve ReadOnlySequence.Slice docs (dotnet/corefx#38150)

* Improve ReadOnlySequence.Slice docs. Fixes dotnet/corefx#32021

* Synchronise documentation with dotnet-api-docs.

Commit migrated from https://github.com/dotnet/corefx/commit/7626863d5a48f771513f7d22977189aab14dcd0b

5 years agofix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)
Vladislav Richter [Thu, 6 Jun 2019 09:05:53 +0000 (11:05 +0200)]
fix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)

ReadResult result = await ReadAsync(cancellationToken).ConfigureAwait(false); should be before the try/finally block because if you cancel the read operation the finally clause will try to advance reader that is not in reading state and instead of OperationCancelledException you will end up with InvalidOperationException.

There is a bug either in PipeReader.CopyToAsyncCore() or ReadOnlySequence.TryGet():

When ReadOnlySequence.TryGet() reaches final segment it will return true and this final memory but it will also set position as default(SequencePosition) - I don't know if this is by design but CopyToAsyncCore() method does not take it in consideration and it will copy the memory but not advance the reader - this will cause it to repeat this data indefinitely.

* Fixed test CopyToAsyncWorks() to make sure that multiple separate reads from the reader produce expected result.
Added test to verify that cancellation between reads from the Reader throws OperationCancelledException.

Commit migrated from https://github.com/dotnet/corefx/commit/71aec681dd1247979e7956372abae8bbc02c9546

5 years agoRe-generate System.Threading.Overlapped ref assembly against implementation (dotnet...
Santiago Fernandez Madero [Thu, 6 Jun 2019 06:28:39 +0000 (23:28 -0700)]
Re-generate System.Threading.Overlapped ref assembly against implementation (dotnet/corefx#38282)

Commit migrated from https://github.com/dotnet/corefx/commit/4e0c8ec7b124e2a1c5294bee24e61ef42bbd79ec

5 years agoRe-generate System.Memory ref assembly against implementation (dotnet/corefx#38287)
Santiago Fernandez Madero [Thu, 6 Jun 2019 04:11:32 +0000 (21:11 -0700)]
Re-generate System.Memory ref assembly against implementation (dotnet/corefx#38287)

Commit migrated from https://github.com/dotnet/corefx/commit/7b87ec99d747478ddcb1eba048411be24e9b9b87

5 years agoRe-generate System.Runtime.Loader ref assembly against implementation (dotnet/corefx...
Santiago Fernandez Madero [Thu, 6 Jun 2019 04:11:11 +0000 (21:11 -0700)]
Re-generate System.Runtime.Loader ref assembly against implementation (dotnet/corefx#38286)

Commit migrated from https://github.com/dotnet/corefx/commit/9f3032395582f2abd33cee8fa8bba25f7576774b

5 years agoUpdate JsonSerializer and JsonElement APIs - drop "As" and parameter re-ordering...
Ahson Khan [Wed, 5 Jun 2019 21:49:59 +0000 (14:49 -0700)]
Update JsonSerializer and JsonElement APIs - drop "As" and parameter re-ordering (dotnet/corefx#38270)

* Update JsonSerializer and JsonElement APIs

* Fix the test since the call became ambiguous and overload resolution
picked the different overload.

Commit migrated from https://github.com/dotnet/corefx/commit/5c2ba765f55462dcc5e00179a34398fc70bf37b7

5 years agoAdd missing APIs for OleDb (dotnet/corefx#38235)
Maryam Ariyan [Wed, 5 Jun 2019 20:27:50 +0000 (13:27 -0700)]
Add missing APIs for OleDb (dotnet/corefx#38235)

Commit migrated from https://github.com/dotnet/corefx/commit/c63e5ebecc5449a360b6293ecdbf151bfd11a1a6

5 years agoFix digest authentication on SocketsHttpHandler (dotnet/corefx#38225)
Marco Rossignoli [Wed, 5 Jun 2019 18:33:31 +0000 (20:33 +0200)]
Fix digest authentication on SocketsHttpHandler (dotnet/corefx#38225)

* fix digest

* improve test

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/94c5f1384c9b6477d164050de964cf6dcf99b2a9

5 years agoMoving the JsonSerializer to the root namespace - System.Text.Json (dotnet/corefx...
Ahson Khan [Wed, 5 Jun 2019 18:18:50 +0000 (11:18 -0700)]
Moving the JsonSerializer to the root namespace - System.Text.Json (dotnet/corefx#38120)

* CHanging namespace for json serializer

* Update ref and namespace to react to recent changes.

* Auto-gen the ref.

* Remove unnecessary using directive that got added recently.

Commit migrated from https://github.com/dotnet/corefx/commit/7e0c5dd1927981131c370141c4ef44c0ebd26c05

5 years agoRe-generate reference source against impl for System.Threading.Tasks (dotnet/corefx...
Santiago Fernandez Madero [Wed, 5 Jun 2019 16:28:23 +0000 (09:28 -0700)]
Re-generate reference source against impl for System.Threading.Tasks (dotnet/corefx#38231)

Commit migrated from https://github.com/dotnet/corefx/commit/cb603ed5ec0249da022a96f9ec583f24c5a50fae

5 years agoEnable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost (dotnet...
Dustin Campbell [Wed, 5 Jun 2019 14:58:02 +0000 (07:58 -0700)]
Enable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost (dotnet/corefx#38244)

* Enable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost

Fixes dotnet/corefx#38241

TypeDescriptor.GetAssociation(...) is supposed to have a fallback in the case
that the primary object passed to it is a sited IComponent in design-mode. In
that case, it tries to acquire an IDesignerHost from the component site and
calls IDesignerHost.GetDesigner(...). Unfortunately, this code path has been
disabled since TypeDescriptor was introduced in the corefx code base 3 years
ago.

This change enables that code path and adds a test for the scenario.

This is currently blocking WinForms Designer work.

* Code review feedback for TypeConverterTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/d6a3b78f3fa2b636621f6030fc3f8b99e08474bb

5 years agoReenable BuildInvalidSignatureTwice with better diagnostics
Jeremy Barton [Wed, 5 Jun 2019 14:48:22 +0000 (07:48 -0700)]
Reenable BuildInvalidSignatureTwice with better diagnostics

Commit migrated from https://github.com/dotnet/corefx/commit/09c3160b52e1e47b3a92c837337672d1b426e170

5 years agoIncrease sample size for random tests.
Kevin Jones [Wed, 5 Jun 2019 14:41:29 +0000 (10:41 -0400)]
Increase sample size for random tests.

Commit migrated from https://github.com/dotnet/corefx/commit/3d007d3084713f7b9644545e7b7450c69c3ee4a1

5 years agoAdd Debian 10 "Buster" test execution
Matt Galbraith [Wed, 5 Jun 2019 14:40:07 +0000 (07:40 -0700)]
Add Debian 10 "Buster" test execution

Add test leg to full matrix using debian-10-helix-amd64-f55606d-20190521154431

Commit migrated from https://github.com/dotnet/corefx/commit/c8a3f3241265f1b287f3acd81ddabf2c5dfb9a53

5 years agoOpen pdb files with FileShare.Read and FileShare.Delete (dotnet/corefx#38214)
David Fowler [Wed, 5 Jun 2019 13:44:29 +0000 (06:44 -0700)]
Open pdb files with FileShare.Read and FileShare.Delete (dotnet/corefx#38214)

* Added test to verify PDB isn't locked

Commit migrated from https://github.com/dotnet/corefx/commit/a1940826e89c4c333bca45459b25ba009e869ff6

5 years agoFix XmlSerializer fails to serialize Type with special character in string
Carol Wang [Wed, 5 Jun 2019 13:16:54 +0000 (21:16 +0800)]
Fix XmlSerializer fails to serialize Type with special character in string

Commit migrated from https://github.com/dotnet/corefx/commit/1b081bbfb8cfb7b4d9e56928e44bf5393d5a1f67

5 years agoIgnore indexer properties (dotnet/corefx#38133)
Marco Rossignoli [Wed, 5 Jun 2019 09:28:59 +0000 (11:28 +0200)]
Ignore indexer properties (dotnet/corefx#38133)

* fix indexer

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/656ccfbbef3a0d75c02e17b7477122a658b92557

5 years agoMove System.Threading.Channels into Microsoft.NetCore.App (dotnet/corefx#38207)
David Fowler [Wed, 5 Jun 2019 00:11:53 +0000 (17:11 -0700)]
Move System.Threading.Channels into Microsoft.NetCore.App (dotnet/corefx#38207)

* Move System.Threading.Channels into Microsoft.NetCore.App

* Update packageIndex to make Channels inbox

Commit migrated from https://github.com/dotnet/corefx/commit/10fc6eee0683524006ce5c8260059865e00fefac

5 years agoMerge pull request dotnet/corefx#35363 from Wraith2/sqlperf-managedsmux
Gary Zhang [Tue, 4 Jun 2019 22:26:18 +0000 (15:26 -0700)]
Merge pull request dotnet/corefx#35363 from Wraith2/sqlperf-managedsmux

SqlClient managed networking improvements, all test passed

Commit migrated from https://github.com/dotnet/corefx/commit/2469a91c2aa68f9cb6b0f18f75dffc673a1f7895

5 years agoAdd missing PlatformSpecific attribute to ProcessStart_OnLinux_UsesSpecifiedProgram...
Stephen Toub [Tue, 4 Jun 2019 22:15:59 +0000 (18:15 -0400)]
Add missing PlatformSpecific attribute to ProcessStart_OnLinux_UsesSpecifiedProgram test (dotnet/corefx#38228)

Commit migrated from https://github.com/dotnet/corefx/commit/88c5a3e317dd2edadc95adedc764c1acad5e3541

5 years agoUpdate ProjectNTfs to beta-27804-00 (dotnet/corefx#38220)
dotnet-maestro-bot [Tue, 4 Jun 2019 21:12:40 +0000 (14:12 -0700)]
Update ProjectNTfs to beta-27804-00 (dotnet/corefx#38220)

Commit migrated from https://github.com/dotnet/corefx/commit/d5a4975994a1b825b4c40a9fdcbd8a367f198177

5 years agoDisable JSON LookupOverflow test (dotnet/corefx#38222)
Stephen Toub [Tue, 4 Jun 2019 20:54:02 +0000 (16:54 -0400)]
Disable JSON LookupOverflow test (dotnet/corefx#38222)

Commit migrated from https://github.com/dotnet/corefx/commit/f7ace29a0089e2089a4309fe1bda1344a34cbea2

5 years agoHttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT...
Martin Baulig [Tue, 4 Jun 2019 20:52:27 +0000 (16:52 -0400)]
HttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT request. (dotnet/corefx#38129)

* HttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT request.

* Update HttpMethod.cs

* Address feedback.

* Cleanup.

* Update HttpRequestMessageTest.cs

Commit migrated from https://github.com/dotnet/corefx/commit/73e610f847f9c5100a0cec4a80692969836ff35d

5 years agoFix catch block for cancellation in ConnectHelper.ConnectAsync (dotnet/corefx#38211)
Stephen Toub [Tue, 4 Jun 2019 20:03:25 +0000 (16:03 -0400)]
Fix catch block for cancellation in ConnectHelper.ConnectAsync (dotnet/corefx#38211)

There are logic errors in ConnectHelper's catch blocks regarding cancellation.  It's catching all exceptions and then trying to decide whether it should wrap the exception in an OperationCanceledException (based on whether cancellation was requested), but it's ignoring the possibility that the exception already is an OperationCanceledException.

Commit migrated from https://github.com/dotnet/corefx/commit/80252bbc5cf2f933aef1f30d6bec7deaa3064f54

5 years agoLoopbackProxyServer cleanup (dotnet/corefx#38038)
Cory Nelson [Tue, 4 Jun 2019 18:04:49 +0000 (11:04 -0700)]
LoopbackProxyServer cleanup (dotnet/corefx#38038)

* Resolves dotnet/corefx#32808.

Ensure all connections are finished prior to Dispose() returning.
Shutdown CONNECT sessions properly.
Dispose sockets rather than relying on finalizers.
Eat fewer errors automatically.
Send errors to an event source to assist with troubleshooting.

Commit migrated from https://github.com/dotnet/corefx/commit/055dd469f7d402f496fcab31ae91e80efd474fa9

5 years agoProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using...
Tom Deseyn [Tue, 4 Jun 2019 16:25:45 +0000 (18:25 +0200)]
ProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using 'sleep' instead of 'vi' (dotnet/corefx#38158)

* ProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using 'sleep' instead of 'vi'

Fixes https://github.com/dotnet/corefx/issues/38114

* PR feedback

* Match sleep time with RemoteExecutor.FailWaitTimeoutMilliseconds

* Move Assert out of finally block to keep exception

Commit migrated from https://github.com/dotnet/corefx/commit/6efdb0fc21c5eb559657a85a62a14d0907f6eff4

5 years agoDisable TurkishI_Is_Differently_LowerUpperCased_In_Turkish_Culture on uap (dotnet...
Stephen Toub [Tue, 4 Jun 2019 16:24:44 +0000 (12:24 -0400)]
Disable TurkishI_Is_Differently_LowerUpperCased_In_Turkish_Culture on uap (dotnet/corefx#38209)

Commit migrated from https://github.com/dotnet/corefx/commit/3e360f03d0ef21873276a3488046de97687bfce0

5 years agoBetter handle resx scenarios (dotnet/corefx#38012)
Eric StJohn [Tue, 4 Jun 2019 15:38:33 +0000 (08:38 -0700)]
Better handle resx scenarios (dotnet/corefx#38012)

* Better handle resx scenarios

There were two resx scenarios that we weren't handling well.

1. BinaryFormatted data that is missing the type information

BinaryFormatted data never takes the type into account, it's only used
to check the deserialized data after it's read.  In the old resx reader
it would deserialize the data in the build task, only to reserialize it
back, recording the type information.  Since we're eliminating build
time deserialziation we cannot do this, so just permit the payload to
flow through without recording the type information.  This is
effectively what happened before since the user never recorded the
type information in the resx so it isn't introducing any new opportunity
for inconsistencies.  To implement this I used the existing ResX format
with a sentinel type to indicate that the BinaryFormatter payload type
was unknown.

2. Primitive types stored as string

ResX reader deserialized all types during the build, we're trying to
eliminate this as it results in build time / cross-framework type
loading.  In doing so we lose the ability to handle primitive types
since the only way we currently write primitive types is when they
are passed in as live objects.  To fix this, we'll make the string-based
type converter method aware of primitive types, and permit it to
deserialize those primitive types (IOW: parse the string via
typeconverter) so that we still write these as primitive resources.
We'll rename this method to AddResource to indicate it is more
generic than just handling pre-serialized data.  To identify primitive types
we use a string comparer to match the type name written in the resx,
and map it to a known type (in the build framework).

* Respond to feedback

* Apply suggestions from code review

Co-Authored-By: Rainer Sigwald <raines@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/00c7405a3b079e1641d32c50831d3f5053d9419e

5 years agoRe-generate System.Threading ref assembly against implementation (dotnet/corefx#38190)
Santiago Fernandez Madero [Tue, 4 Jun 2019 04:42:10 +0000 (21:42 -0700)]
Re-generate System.Threading ref assembly against implementation (dotnet/corefx#38190)

Commit migrated from https://github.com/dotnet/corefx/commit/6d5959cbc7d489406f8f85dba0a42f06d4a0ea9b

5 years agoProcessNameMatchesScriptName: add some asserts for debugging (dotnet/corefx#38175)
Tom Deseyn [Tue, 4 Jun 2019 03:25:08 +0000 (05:25 +0200)]
ProcessNameMatchesScriptName: add some asserts for debugging (dotnet/corefx#38175)

Commit migrated from https://github.com/dotnet/corefx/commit/b6c814e0d0da3b3251b518f2d9445174e4fc1979

5 years agoFix deletion tests on Windows 10 1903. (dotnet/corefx#38186)
Jeremy Kuhne [Tue, 4 Jun 2019 03:17:15 +0000 (20:17 -0700)]
Fix deletion tests on Windows 10 1903. (dotnet/corefx#38186)

In the 1903 release of Windows 10 the deletion behavior has changed. Previously, the filename would be reserved until all open handles were closed after being marked for deletion. Now the filename is immediately released.

Commit migrated from https://github.com/dotnet/corefx/commit/a4cf9a480b34a00e11201e932f7152c63b99b85f

5 years agoPersist InterfaceTypeAttribute in ref assemblies (dotnet/corefx#38182)
Eric StJohn [Tue, 4 Jun 2019 01:53:57 +0000 (18:53 -0700)]
Persist InterfaceTypeAttribute in ref assemblies (dotnet/corefx#38182)

Commit migrated from https://github.com/dotnet/corefx/commit/37b09ac0fc37c77bb9e1ff2320bf3149411f1c55

5 years agoAdds JsonElement.ValueEquals / JsonProperty.NameEquals APIs, (dotnet/corefx#37911)
Maryam Ariyan [Tue, 4 Jun 2019 00:21:10 +0000 (17:21 -0700)]
Adds JsonElement.ValueEquals / JsonProperty.NameEquals APIs, (dotnet/corefx#37911)

* - Rename Utf8JsonReader.TextEquals to Utf8JsonReader.ValueTextEquals
- Implement JsonElement.ValueEquals and add code coverage
- Reuse logic for JsonProperty and add code coverage
- improve header documentation
- cleanup tests

Commit migrated from https://github.com/dotnet/corefx/commit/f09135a373caa94eca1566f7ad497aaf19587140

5 years agoFix RegexCultureTests by moving it out-of-proc (dotnet/corefx#38166)
Stephen Toub [Mon, 3 Jun 2019 18:34:34 +0000 (14:34 -0400)]
Fix RegexCultureTests by moving it out-of-proc (dotnet/corefx#38166)

All of our tests that manipulate current culture currently need to be run out-of-proc.

Commit migrated from https://github.com/dotnet/corefx/commit/55950a7c733de83f2efbafd3b5cad23e3ea6873a

5 years agofix tests (dotnet/corefx#38096)
Marco Rossignoli [Mon, 3 Jun 2019 15:25:09 +0000 (17:25 +0200)]
fix tests (dotnet/corefx#38096)

Commit migrated from https://github.com/dotnet/corefx/commit/c84b3861a3ff8f0843b1da64ae88fb712f4af57d

5 years agoUse fallbacks when link() fails (dotnet/corefx#36957)
Alexis Christoforides [Mon, 3 Jun 2019 15:05:00 +0000 (08:05 -0700)]
Use fallbacks when link() fails (dotnet/corefx#36957)

System.IO.Filesystem's MoveFile() and ReplaceFile() use the link() syscall under some conditions to avoid a copy. This fixes two problems with that:

* MoveFile()'s fall-back does not recognize a possible Android error as non-critical, and bails out on the fall-back with an exception. From logs we know that 'strerror_r(android_error)' = 'Permission denied' so the Android error should be EACCES (we already check for EPERM)
* While MoveFile() was using a fall-back, ReplaceFile() wasn't.

Commit migrated from https://github.com/dotnet/corefx/commit/f6aed7b177580ed3953e6e23dccbe2de57850729

5 years agoX509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root (dotnet...
Tom Deseyn [Mon, 3 Jun 2019 14:09:49 +0000 (16:09 +0200)]
X509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root (dotnet/corefx#38162)

* X509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root

Fixes https://github.com/dotnet/corefx/issues/30162

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/de1748bb797ee079c5592ed035b18fded0a96e27

5 years agoUpdate ProjectNTfs to beta-27803-00 (dotnet/corefx#38155)
dotnet-maestro-bot [Mon, 3 Jun 2019 08:05:21 +0000 (01:05 -0700)]
Update ProjectNTfs to beta-27803-00 (dotnet/corefx#38155)

Commit migrated from https://github.com/dotnet/corefx/commit/0eed4042f056b4d9f6f4d1bf2918e234d67a6f88

5 years agoaddress PR feedback (dotnet/corefx#38147)
Marco Rossignoli [Mon, 3 Jun 2019 00:26:42 +0000 (02:26 +0200)]
address PR feedback (dotnet/corefx#38147)

Commit migrated from https://github.com/dotnet/corefx/commit/a42e890c3af1069a52b75b5728444bf29c421703

5 years agoFix tests to match exception output change (dotnet/corefx#38145)
Dan Moseley [Mon, 3 Jun 2019 00:25:38 +0000 (17:25 -0700)]
Fix tests to match exception output change (dotnet/corefx#38145)

Commit migrated from https://github.com/dotnet/corefx/commit/360621af9620de205193f627ae84c41ddec60551

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#38134)
dotnet-maestro[bot] [Sun, 2 Jun 2019 18:21:11 +0000 (18:21 +0000)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#38134)

* Update dependencies from https://github.com/dotnet/arcade build 20190531.5

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19281.5
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19281.5
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19281.5
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19281.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19281.5
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19281.5
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19281.5
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19281.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19281.5
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19281.5
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19281.5

* Update dependencies from https://github.com/dotnet/arcade build 20190601.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19301.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19301.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19301.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19301.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19301.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19301.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19301.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19301.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19301.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19301.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19301.2

* Remove dotnet-root option

Commit migrated from https://github.com/dotnet/corefx/commit/aa0c037c1f64c91f73698d0607dea16904d08da8

5 years agoUse LoopbackServer for HttpWebRequestTests (dotnet/corefx#37451)
Viktor Hofer [Sun, 2 Jun 2019 16:13:13 +0000 (18:13 +0200)]
Use LoopbackServer for HttpWebRequestTests (dotnet/corefx#37451)

* Use LoopbackServer for HttpWebRequestTests

Commit migrated from https://github.com/dotnet/corefx/commit/d57a1a29f1237f2691daa8eac29eb4581a4eaf88

5 years agoFix CustomValidationAttribute.TypeId (dotnet/corefx#38140)
Marco Rossignoli [Sun, 2 Jun 2019 04:20:35 +0000 (06:20 +0200)]
Fix CustomValidationAttribute.TypeId (dotnet/corefx#38140)

* fix TypeId

* nit

Commit migrated from https://github.com/dotnet/corefx/commit/9813f2de83c5f4b270b7cbb34f7117f80d402f4d

5 years agoChange use of AllowRenegotiation in HttpConnectionPool (dotnet/corefx#38127)
Stephen Toub [Sat, 1 Jun 2019 19:27:50 +0000 (15:27 -0400)]
Change use of AllowRenegotiation in HttpConnectionPool (dotnet/corefx#38127)

* Change use of AllowRenegotation in HttpConnectionPool

* Address PR feedback

Fix typos in comments

Co-Authored-By: David Shulman <david.shulman@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/cada442a1385e4ecaf9139eb9f98e522776043e2

5 years agoFix downlevel build-break in System.Net.WebSockets.WebSocketProtocol (dotnet/corefx...
Stephen Toub [Sat, 1 Jun 2019 13:44:24 +0000 (09:44 -0400)]
Fix downlevel build-break in System.Net.WebSockets.WebSocketProtocol (dotnet/corefx#38138)

Commit migrated from https://github.com/dotnet/corefx/commit/dfd3eb6b0c4786b8b4a70a1ea6c6bed8bfb919a0

5 years agoTest for Exception.ToString() calling derived implementation (dotnet/corefx#37960)
Dan Moseley [Fri, 31 May 2019 23:38:29 +0000 (16:38 -0700)]
Test for Exception.ToString() calling derived implementation (dotnet/corefx#37960)

* Test for Exception.ToString()

* Ensure Message is not present

Commit migrated from https://github.com/dotnet/corefx/commit/0d2ee6c1db6038adb776565af81ff944423a6fb3

5 years agoEnsure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)
Cory Nelson [Fri, 31 May 2019 23:25:33 +0000 (16:25 -0700)]
Ensure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)

* Resolves dotnet/corefx#30747 ensuring pointer alignment.

* Make mods unsigned so optimizer will translate them to AND. Use BitOperations.RotateRight rather than custom implementation.

* Reduce code size; improve perf on unaligned data.

* Fix length check.

* Address review suggestions:

Use MemoryMarshal.GetReference rather than pinning the span directly.
Add Debug.Assert() to improve maintainability.
Prefer a larger indent mountain over goto.

Commit migrated from https://github.com/dotnet/corefx/commit/9ec6bfa8c5045fb2c0affe8870ea238ca5f57f37

5 years agoAdded test cases for Activator.CreateInstance<T> (dotnet/corefx#38032)
Yoh Deadfall [Fri, 31 May 2019 23:24:39 +0000 (02:24 +0300)]
Added test cases for Activator.CreateInstance<T> (dotnet/corefx#38032)

Commit migrated from https://github.com/dotnet/corefx/commit/0837ff6ca8e494ac7a8c64316b2ce28744f42223

5 years agoFix mutating static issue (dotnet/corefx#38124)
Jeremy Kuhne [Fri, 31 May 2019 22:34:21 +0000 (15:34 -0700)]
Fix mutating static issue (dotnet/corefx#38124)

The default options static was getting mutated. Moving to ReadStack which doesn't have this issue.

Commit migrated from https://github.com/dotnet/corefx/commit/a39a2bf44291880935121c9e656cffd35b1ef250

5 years agoadd support for 100-continue for H/2 (dotnet/corefx#36884)
Tomas Weinfurt [Fri, 31 May 2019 21:39:12 +0000 (14:39 -0700)]
add support for 100-continue for H/2 (dotnet/corefx#36884)

* expect100

* updates

* remove dead code

* fix tests

* use configured value for allowExpect100ToContinue timer

* feedback from review

* dispose expect100Timer

* feedback from review

* feedback from review

* feedback from review

* small updates to sync up with master changes

* add concurent send/recive and more tests

* fix netfx

* feedback from review

* feedback from review

* feedback from review

* feedback from review

* feedback from review

* kick ci

Commit migrated from https://github.com/dotnet/corefx/commit/b4fa2006c2e9757e4446e3fdad413bdbf265eedc

5 years ago Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection...
Santiago Fernandez Madero [Fri, 31 May 2019 21:31:55 +0000 (14:31 -0700)]
 Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet/corefx#35772)" (dotnet/corefx#38115)

* Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet/corefx#35772)"

This reverts commit dotnet/corefx@b705522753f09d501762cca6c45d6bd031c112d7.

* Baseline API Compat errors

* Fix baseline vs netstandard

Commit migrated from https://github.com/dotnet/corefx/commit/d2506266dffcf6d83af11d192fa87435048614cb

5 years agoAdd support for immutable dictionaries (dotnet/corefx#37710)
Layomi Akinrinade [Fri, 31 May 2019 20:59:08 +0000 (16:59 -0400)]
Add support for immutable dictionaries (dotnet/corefx#37710)

* Add support for immutable dictionaries

* Some clean up

* Address review comments

* Address review comments

* Remove commented out code

* Move object property infos to JsonSerializerOptions

* Re-add immutable test

* Cache IsImmutableDict bool

* More immutable support

* Modify processing enumerable or dictionary check

* Correct handle end dictionary checks

* Re-add dict tests

* React to changes from master

Commit migrated from https://github.com/dotnet/corefx/commit/616b849f801f3124b2f64919b03601233eaa9124

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38099)
dotnet-maestro[bot] [Fri, 31 May 2019 20:25:15 +0000 (13:25 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38099)

* Update dependencies from https://github.com/dotnet/coreclr build 20190530.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19280.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19280.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19280.2

* Expose, test, and use Environment.TickCount64

* Back out change to WinInetProxyHelper.cs

Commit migrated from https://github.com/dotnet/corefx/commit/06f25eaa8592b49c65373d0cdcbdac9a4bdf0f35

5 years agofixing image Convertion from icon (dotnet/corefx#38108)
Anirudh Agnihotry [Fri, 31 May 2019 19:02:41 +0000 (12:02 -0700)]
fixing image Convertion from icon (dotnet/corefx#38108)

Commit migrated from https://github.com/dotnet/corefx/commit/fd90e2845c688115d1ddb54a05a2c16a7f8710a5

5 years agoAdd JsonSerializer overload that takes Utf8JsonReader. (dotnet/corefx#38088)
Ahson Khan [Fri, 31 May 2019 18:57:15 +0000 (11:57 -0700)]
Add JsonSerializer overload that takes Utf8JsonReader. (dotnet/corefx#38088)

* Initial commit of serializer overload that takes reader.

* Move utf8jsonreader api to a new file.

* Add more reader tests and update some exception cases.

* Add start of WriteValue API.

* Add the new files that were missed in previous commit.

* Remove writer related changes.

Commit migrated from https://github.com/dotnet/corefx/commit/1c1b78f7ec1d04aeac059d3d4e4c975d3a3ad23e

5 years agoAdd (de)serialization support for Base64 string as Byte array (dotnet/corefx#38106)
Steve Harter [Fri, 31 May 2019 18:55:12 +0000 (11:55 -0700)]
Add (de)serialization support for Base64 string as Byte array (dotnet/corefx#38106)

* Add (de)serialization for Base64 string as Byte array

* Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/a7ad25c7749cbd8ede10119a2e0ab43276192d8e

5 years agoCheck regex timeout in loops and repetitions (dotnet/corefx#38091)
Viktor Hofer [Fri, 31 May 2019 18:51:09 +0000 (20:51 +0200)]
Check regex timeout in loops and repetitions (dotnet/corefx#38091)

* Check regex timeout in loops and repetitions

Check the regex timeout in SetLoop and SetRepetition opcodes to avoid
the timeout not being handled.

* PR feedback and fix OOM

Commit migrated from https://github.com/dotnet/corefx/commit/40f031a7c7a8241f92a9f6d7f269dc99228d2893

5 years agoUpdate package index and harvest props to reflect WinHttpHandler update (dotnet/coref...
Santiago Fernandez Madero [Fri, 31 May 2019 18:50:12 +0000 (11:50 -0700)]
Update package index and harvest props to reflect WinHttpHandler update (dotnet/corefx#38083)

* Update package index and harvest props to reflect WinHttpHandler updte

* Fix packageIndex

* Update Package index for missing stable package 4.3.3 entry

Commit migrated from https://github.com/dotnet/corefx/commit/e7987803c5b9b5d57d3f98b242839a826a19a00d

5 years agoAdd tests for double-encoded URLs to both UrlDecode() methods (dotnet/corefx#37881)
William Godbe [Fri, 31 May 2019 18:48:31 +0000 (11:48 -0700)]
Add tests for double-encoded URLs to both UrlDecode() methods (dotnet/corefx#37881)

* Add tests for double-encoded URLs to both UrlDecode() methods

* Make test cases more clear

Commit migrated from https://github.com/dotnet/corefx/commit/b2fd315c40330e09d34d269792884f6544ab3fe6

5 years agoAdding net461 target to Microsoft.Bcl.* packages (dotnet/corefx#38104)
Jose Perez Rodriguez [Fri, 31 May 2019 18:43:52 +0000 (11:43 -0700)]
Adding net461 target to Microsoft.Bcl.* packages (dotnet/corefx#38104)

* Adding net461 target to Microsoft.Bcl.* packages

* Adding System.Text.Json net461 target as well

Commit migrated from https://github.com/dotnet/corefx/commit/fdab38c206fe545b53d043f81be574cdbe9b5b8c

5 years agoRemoving the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41...
Tanner Gooding [Fri, 31 May 2019 18:40:07 +0000 (11:40 -0700)]
Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class (dotnet/corefx#38102)

* Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class

* Adding a MatchingRefApiCompatBaseline for System.Runtime.Intrinsics

Commit migrated from https://github.com/dotnet/corefx/commit/39c1f79962039f605cf00700df003e26788757c2

5 years ago[System.Text.Json]Improve error output for unsupported scenarios in System.Text.Json...
Marco Rossignoli [Fri, 31 May 2019 18:33:00 +0000 (20:33 +0200)]
[System.Text.Json]Improve error output for unsupported scenarios in System.Text.Json.Serialization (dotnet/corefx#38061)

* custom exception for parameterless constructors

* add polymorphic interface exception

* fix ReflectionMaterializer

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/792eb85f70a7060777b7cc0c0ef860a3e6f69090

5 years agoFix IPv6Address parsing (dotnet/corefx#37734)
William Godbe [Fri, 31 May 2019 16:34:10 +0000 (09:34 -0700)]
Fix IPv6Address parsing (dotnet/corefx#37734)

* Fix IPv6Address parsing

* Update src/System.Net.Primitives/src/System/Net/IPAddressParser.cs

Co-Authored-By: Karel Zikmund <karelz@microsoft.com>
* Use System.Diagnostics, Remove duplicate function, fix method header in Fake

* Fix deletion of call to Parse()

* Fix call to Parse()

* Fix tests to account for NetFx runs

* Fix Syntax

Commit migrated from https://github.com/dotnet/corefx/commit/f8c382f76955e8da9f0cf314d5945a5af34d72b7

5 years ago Fix Loop in System.Private.Uri (dotnet/corefx#38076)
William Godbe [Fri, 31 May 2019 16:33:19 +0000 (09:33 -0700)]
 Fix Loop in System.Private.Uri (dotnet/corefx#38076)

* Fix Loop in System.Private.Uri

* Mark variables in test project as private

* Disable test on NetFx

Commit migrated from https://github.com/dotnet/corefx/commit/0f2fa63930a26fbb70fbb6601c6d23c9c263d08b

5 years agoskip oledb for outerloop failures (dotnet/corefx#38090)
Maryam Ariyan [Fri, 31 May 2019 15:36:59 +0000 (08:36 -0700)]
skip oledb for outerloop failures (dotnet/corefx#38090)

Commit migrated from https://github.com/dotnet/corefx/commit/8b590bc41ebbb7f51f733f40e04e03e8619ca23a

5 years agoDisable ObjectTests.Write test (dotnet/corefx#38101)
Stephen Toub [Fri, 31 May 2019 15:27:03 +0000 (11:27 -0400)]
Disable ObjectTests.Write test (dotnet/corefx#38101)

Commit migrated from https://github.com/dotnet/corefx/commit/24e256f364e4a2133b03dbe9b0a3ee0069eb77b9

5 years agousing double to avoild multplication overflow (dotnet/corefx#38079)
Anirudh Agnihotry [Fri, 31 May 2019 15:17:45 +0000 (08:17 -0700)]
using double to avoild multplication overflow (dotnet/corefx#38079)

Commit migrated from https://github.com/dotnet/corefx/commit/655be420da4094ffed95ffa661a37225a3d7c6c9

5 years agoUpdate ProjectNTfs to beta-27731-00 (dotnet/corefx#38089)
dotnet-maestro-bot [Fri, 31 May 2019 13:13:21 +0000 (06:13 -0700)]
Update ProjectNTfs to beta-27731-00 (dotnet/corefx#38089)

Commit migrated from https://github.com/dotnet/corefx/commit/0d09364875814e037304dc783516600498ca553b

5 years agoMerge pull request dotnet/corefx#38013 from lmolkova/lmolkova/fixActivityIdWorngFlags
Noah Falk [Fri, 31 May 2019 09:59:01 +0000 (02:59 -0700)]
Merge pull request dotnet/corefx#38013 from lmolkova/lmolkova/fixActivityIdWorngFlags

Fix wrong Activity.Id serialization - flags are not inherited from parent

Commit migrated from https://github.com/dotnet/corefx/commit/46ed80dc71d2b449a7db8c86f9cf14d175f8fead

5 years agoAdd Base64 APIs to Utf8JsonReader, Utf8JsonWriter, and JsonElement (dotnet/corefx...
Ahson Khan [Fri, 31 May 2019 05:13:31 +0000 (22:13 -0700)]
Add Base64 APIs to Utf8JsonReader, Utf8JsonWriter, and JsonElement (dotnet/corefx#38048)

* Add Utf8JsonWriter Base64 APIs.

* Add Utf8JsonReader Base64 APIs.

* Add JsonElement Base64 APIs.

* Update API shape based on review.

* Auto-generate the ref assembly.

* Address PR feedback so far.

* Add escaping step and update length counters accordingly.

* Add JsonWriter API tests.

* Add JsonReader and JsonElement tests.

Commit migrated from https://github.com/dotnet/corefx/commit/82408cd90f4d4573d502e8df2ca437b35e6a37f7

5 years agoAdd read ahead logic for streams. (dotnet/corefx#38039)
Jeremy Kuhne [Fri, 31 May 2019 05:00:36 +0000 (22:00 -0700)]
Add read ahead logic for streams. (dotnet/corefx#38039)

* Add read ahead logic for streams.

When reading a jaon object or array from a stream into an object we need to TrySkip to ensure that we have all the needed data for the JsonDocument to create a JsonElement. This is only necessary  if we haven't already drained the stream.

* Track state correctly

We need to track consumed separately so we can requeue the reader properly after skipping. Add more stream tests.

* Clarify comments and other feedback.

* Fix comment

Commit migrated from https://github.com/dotnet/corefx/commit/f6b010d2a0bdab94953d519a60d882ff805eea36

5 years agoSimplify DbProviderFactory feature detection code. (dotnet/corefx#38070)
Bradley Grainger [Fri, 31 May 2019 02:43:33 +0000 (19:43 -0700)]
Simplify DbProviderFactory feature detection code. (dotnet/corefx#38070)

Commit migrated from https://github.com/dotnet/corefx/commit/5a611ecf50891df3201a94372a4f622a9d4cfa30

5 years agoSystem.Text.Json is not inbox on netfx (dotnet/corefx#38077)
William Godbe [Fri, 31 May 2019 00:50:28 +0000 (17:50 -0700)]
System.Text.Json is not inbox on netfx (dotnet/corefx#38077)

Commit migrated from https://github.com/dotnet/corefx/commit/40983e222a2fe12156360550275f89155a3cfc9c

5 years agoMerge pull request dotnet/corefx#37972 from ViktorHofer/NSTestRemoval
Viktor Hofer [Thu, 30 May 2019 22:26:01 +0000 (00:26 +0200)]
Merge pull request dotnet/corefx#37972 from ViktorHofer/NSTestRemoval

Replace netstandard test project tfms with implementations

Commit migrated from https://github.com/dotnet/corefx/commit/30ca4113ed07fc78060a0c9d3f95eee4fe8f8ee3

5 years agoMerge remote-tracking branch 'upstream/master' into NSTestRemoval
Viktor Hofer [Thu, 30 May 2019 22:21:15 +0000 (00:21 +0200)]
Merge remote-tracking branch 'upstream/master' into NSTestRemoval

Commit migrated from https://github.com/dotnet/corefx/commit/1743e47216aa698ffe91148f4db2078accf6030a

5 years agoPR feedback nits
Viktor Hofer [Thu, 30 May 2019 22:19:45 +0000 (00:19 +0200)]
PR feedback nits

Commit migrated from https://github.com/dotnet/corefx/commit/13ad3d0b841a611e775f51bd66375c9587584a72

5 years agoChange JsonException.Path to be a json-based path (dotnet/corefx#37938)
Steve Harter [Thu, 30 May 2019 21:44:37 +0000 (14:44 -0700)]
Change JsonException.Path to be a json-based path (dotnet/corefx#37938)

Commit migrated from https://github.com/dotnet/corefx/commit/02f649e60f3a8ea0b947ea0eaf64f2fa3c287816

5 years agoFixing issue where assemblies would build againsta lower version of a contract than...
Jose Perez Rodriguez [Thu, 30 May 2019 21:30:02 +0000 (14:30 -0700)]
Fixing issue where assemblies would build againsta lower version of a contract than what their package depends on. (dotnet/corefx#37993)

Commit migrated from https://github.com/dotnet/corefx/commit/8ce7c476a07f4f9d753906927beac93981aff301

5 years agoUsing reflection to add handler for user preference events (dotnet/corefx#37853)
Anirudh Agnihotry [Thu, 30 May 2019 20:15:16 +0000 (13:15 -0700)]
Using reflection to add handler for user preference events (dotnet/corefx#37853)

* using reflection to add handler for user preference events

* adding comments, correcting typo and using GetType

* adding debug.asserts

* pushing down color translator

* using open unbound delegate pointing directly to getter method of the eventargs category property

* No longer using colorTable on netcoreapp 2.1 in system.Drawing.Common

* reverting the use of extension method.

* doing  s_color check first and adding null check for category getter

* missing semicolon

* improving comments and adding tests

* removing extra using

* using already defined known color

* skipping the test on nano and non-windows platform

* introducing a custom property

Commit migrated from https://github.com/dotnet/corefx/commit/d24b3e33e66bfd0733f9c01fa810336d76a8872f

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38057)
dotnet-maestro[bot] [Thu, 30 May 2019 19:15:38 +0000 (15:15 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38057)

* Update dependencies from https://github.com/dotnet/coreclr build 20190529.4

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19279.4
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19279.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19279.4

* Expose TrimEndingDirectorySeparator

* Disable new tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/88f4967b84d20f6ea6da037cef6fd82119e76900

5 years agoAddress leftover feedback related to Skip/TrySkip APIs. (dotnet/corefx#38044)
Ahson Khan [Thu, 30 May 2019 19:14:53 +0000 (12:14 -0700)]
Address leftover feedback related to Skip/TrySkip APIs. (dotnet/corefx#38044)

* Address leftover feedback related to Skip/TrySkip APIs.

* Add some more commas.

* Fix comment nit.

Commit migrated from https://github.com/dotnet/corefx/commit/0aad50252f0f6e3e62fc050f2c4e6225005b6b63

5 years agoUpdate float converter and related tests (dotnet/corefx#37894)
Steve Harter [Thu, 30 May 2019 14:35:25 +0000 (07:35 -0700)]
Update float converter and related tests (dotnet/corefx#37894)

Commit migrated from https://github.com/dotnet/corefx/commit/adc16f3d53b18467d5ed92fd1b988b0c21901ab9

5 years agoHarden failing EventLog.Clear test
Viktor Hofer [Thu, 30 May 2019 13:14:44 +0000 (15:14 +0200)]
Harden failing EventLog.Clear test

Commit migrated from https://github.com/dotnet/corefx/commit/97d29c9a1a4a23607b328925fbd5b2cfca7eb0b4

5 years agoDisable building tests on uapaot
Viktor Hofer [Thu, 30 May 2019 10:04:19 +0000 (12:04 +0200)]
Disable building tests on uapaot

Commit migrated from https://github.com/dotnet/corefx/commit/32086409d0ca7441048ac4790496195765d1b583

5 years agoAdd validation target for netstandard
Viktor Hofer [Thu, 30 May 2019 03:02:40 +0000 (05:02 +0200)]
Add validation target for netstandard

Commit migrated from https://github.com/dotnet/corefx/commit/7c51e15fab50e8b3492d80dbc6b8a15db744dfa1

5 years agoReplace netstandard test projects with tfms
Viktor Hofer [Mon, 27 May 2019 23:01:17 +0000 (01:01 +0200)]
Replace netstandard test projects with tfms

Netstandard test projects are broken by design and don't support the
Microsoft.Net.Test.SDK. Replacing the netstandard tfm with the concrete
implementation tfms.

Commit migrated from https://github.com/dotnet/corefx/commit/d29c16c99c6045ee67444a7a693dd4476861c463