platform/upstream/gst-plugins-good.git
7 years agortpsource: fix warning message
Miguel París Díaz [Thu, 16 Mar 2017 13:58:45 +0000 (14:58 +0100)]
rtpsource: fix warning message

https://bugzilla.gnome.org/show_bug.cgi?id=780105

7 years agoflacparse: fix playback if sample number does not start at 0
Vincent Penquerc'h [Thu, 16 Mar 2017 13:54:54 +0000 (13:54 +0000)]
flacparse: fix playback if sample number does not start at 0

https://bugzilla.gnome.org/show_bug.cgi?id=777738

7 years agortpsource: get clock-rate from pt if needed to generate SR
Miguel París Díaz [Wed, 15 Mar 2017 17:58:55 +0000 (18:58 +0100)]
rtpsource: get clock-rate from pt if needed to generate SR

https://bugzilla.gnome.org/show_bug.cgi?id=780105

7 years agosouphttpsrc: Include GStreamer souphttpsrc version in default User-Agent string
Sebastian Dröge [Thu, 16 Mar 2017 11:52:48 +0000 (13:52 +0200)]
souphttpsrc: Include GStreamer souphttpsrc version in default User-Agent string

7 years agortph264depay: fix crash with empty sprops-parameters
Tim-Philipp Müller [Thu, 16 Mar 2017 00:41:44 +0000 (00:41 +0000)]
rtph264depay: fix crash with empty sprops-parameters

https://bugzilla.gnome.org/show_bug.cgi?id=780040

7 years agoatomsrecovery: also handle extra atoms after 'mdia' in a 'trak'
Thiago Santos [Sun, 12 Mar 2017 05:20:40 +0000 (21:20 -0800)]
atomsrecovery: also handle extra atoms after 'mdia' in a 'trak'

Take into account the atoms at the end of the 'trak' atom when
recovering it. So that its size (already computed and added in the trak
size) isn't making offsets wrong.

https://bugzilla.gnome.org/show_bug.cgi?id=771478

7 years agoqtmux: avoid fallthrough to moovrecovery failure section
Thiago Santos [Sat, 11 Mar 2017 20:56:33 +0000 (12:56 -0800)]
qtmux: avoid fallthrough to moovrecovery failure section

Return before that to preserve our successfull results, otherwise no
moov recovery information would be written

https://bugzilla.gnome.org/show_bug.cgi?id=771478

7 years agoatomsrecovery: expect more atom types at the headers
Thiago Santos [Sat, 11 Mar 2017 20:27:28 +0000 (12:27 -0800)]
atomsrecovery: expect more atom types at the headers

Skip more atoms at the header until it finds the 'mdat' to continue the
moov recovery

https://bugzilla.gnome.org/show_bug.cgi?id=771478

7 years agopulse example: Remove
Olivier Crête [Tue, 14 Mar 2017 20:42:25 +0000 (16:42 -0400)]
pulse example: Remove

That example only tested the property probe interface, which has been removed.
The same kind of thing can now be done with the generic gst-device-monitor tool.

7 years agov4l2: Remove unused macro
Olivier Crête [Tue, 14 Mar 2017 20:38:02 +0000 (16:38 -0400)]
v4l2: Remove unused macro

7 years agov4l2: Remove unused definitions
Olivier Crête [Tue, 14 Mar 2017 20:35:25 +0000 (16:35 -0400)]
v4l2: Remove unused definitions

7 years agoqtmux: add CineForm support
Emeric Grange [Tue, 14 Mar 2017 09:10:19 +0000 (10:10 +0100)]
qtmux: add CineForm support

https://bugzilla.gnome.org/show_bug.cgi?id=780024

7 years agoqtmux: Only create new chunks if we have more than a single stream
Sebastian Dröge [Tue, 14 Mar 2017 13:09:44 +0000 (15:09 +0200)]
qtmux: Only create new chunks if we have more than a single stream

There's no point in creating multiple chunks otherwise, it only wastes
some bytes for storing the chunk offsets.

7 years agoqtdemux: add S16L support
Emeric Grange [Tue, 14 Mar 2017 09:09:46 +0000 (10:09 +0100)]
qtdemux: add S16L support

https://bugzilla.gnome.org/show_bug.cgi?id=780022

7 years agosplitmux test: Use passed first/last timestamps
Jan Schmidt [Tue, 14 Mar 2017 04:48:08 +0000 (15:48 +1100)]
splitmux test: Use passed first/last timestamps

Don't hard-code the expected timestamp range, use the
values the caller is passing in.

7 years agoAdd old plugin names to cruft list
Nicolas Dufresne [Sun, 12 Mar 2017 15:42:25 +0000 (11:42 -0400)]
Add old plugin names to cruft list

This will help fixing uninstalled setup. Also fix missing path
correction in one of the plugin xml.

https://bugzilla.gnome.org/show_bug.cgi?id=779344

7 years agortph264depay, rtph265depay: remove stray g_debug()
Michael Dutka [Thu, 15 Dec 2016 11:38:40 +0000 (12:38 +0100)]
rtph264depay, rtph265depay: remove stray g_debug()

https://bugzilla.gnome.org/show_bug.cgi?id=779858

7 years agoqtmux: init fourcc
Wim Taymans [Fri, 10 Mar 2017 10:24:14 +0000 (11:24 +0100)]
qtmux: init fourcc

Initialize the fourcc to 0 so that we can detect failure later.

7 years agotests: Add missing LDADD for libm in tests using math.h
Nicolas Dufresne [Thu, 9 Mar 2017 03:50:52 +0000 (22:50 -0500)]
tests: Add missing LDADD for libm in tests using math.h

Also, remove the math.h include for the one that just prentend to need
it.

7 years agoFix shout2 plugin doc generation
Nicolas Dufresne [Thu, 9 Mar 2017 03:15:46 +0000 (22:15 -0500)]
Fix shout2 plugin doc generation

In the previous patch, we also renamed shout2send to shout2, so it does
not clash with it's feature. Though we forgot to rename it in the doc
reference. This patch also add a cruft detection on the xml that made me
miss this error.

https://bugzilla.gnome.org/show_bug.cgi?id=779344

7 years agoFix plugin filenames to match plugin names
Nicolas Dufresne [Sat, 4 Mar 2017 15:52:47 +0000 (10:52 -0500)]
Fix plugin filenames to match plugin names

- libgstpulse.so becomes libgstpulseaudio.so
- libgstsouphttpsrc.so becomes libgstsoup.so
- libgstoss4audio.so becomes libgstoss4.so

https://bugzilla.gnome.org/show_bug.cgi?id=779344

7 years agoqtmux: Free EDTS instead of just clearing it and setting it to NULL
Sebastian Dröge [Wed, 8 Mar 2017 14:01:02 +0000 (16:01 +0200)]
qtmux: Free EDTS instead of just clearing it and setting it to NULL

7 years agoqtmux: Fix some memory leaks related to timecode tracks
Sebastian Dröge [Wed, 8 Mar 2017 13:27:32 +0000 (15:27 +0200)]
qtmux: Fix some memory leaks related to timecode tracks

7 years agosplitmux: Add unit test for reverse playback
Jan Schmidt [Fri, 3 Mar 2017 13:34:44 +0000 (00:34 +1100)]
splitmux: Add unit test for reverse playback

Ensure that reverse playback works and generates the range
of timestamps (0-3s) we expect, in monotonically descending order.

7 years agosplitmuxsrc: Fix reverse playback
Jan Schmidt [Tue, 28 Feb 2017 00:50:45 +0000 (11:50 +1100)]
splitmuxsrc: Fix reverse playback

Fix the check for whether the start time of the segment has
been reached when playing in reverse. Otherwise, playback
stops after reaching the start of any file part, instead of
continuing until all parts within the segment have played

7 years agoqtdemux: Don't lose crypto info on a new moof
Jan Schmidt [Tue, 21 Feb 2017 16:01:31 +0000 (03:01 +1100)]
qtdemux: Don't lose crypto info on a new moof

We parse the next moof in advance of having pushed
all samples from the previous one in some cases, and
we'll still need the crypto info from the previous
fragment so keep around any unused crypto info entries
when adding new ones

7 years agoqtmux: Update modification times when sending the moov
Sebastian Dröge [Mon, 27 Feb 2017 11:55:58 +0000 (13:55 +0200)]
qtmux: Update modification times when sending the moov

https://bugzilla.gnome.org/show_bug.cgi?id=779422

7 years agosbcparse: Fix up values for allocation enumeration.
Michael Smith [Thu, 2 Mar 2017 00:11:47 +0000 (16:11 -0800)]
sbcparse: Fix up values for allocation enumeration.

https://bugzilla.gnome.org/show_bug.cgi?id=779389

7 years agortprtxreceive: fix potential leak of old, unassociated, association requests
George Kiagiadakis [Tue, 28 Feb 2017 11:10:50 +0000 (13:10 +0200)]
rtprtxreceive: fix potential leak of old, unassociated, association requests

https://bugzilla.gnome.org/show_bug.cgi?id=722560

7 years agoavidemux: Don't increment -1 / unset indices
Sebastian Dröge [Tue, 28 Feb 2017 13:47:23 +0000 (15:47 +0200)]
avidemux: Don't increment -1 / unset indices

CID 1398545

7 years agoqtdemux: Protect against NULL pointer dereference for streams without caps
Sebastian Dröge [Tue, 28 Feb 2017 13:20:31 +0000 (15:20 +0200)]
qtdemux: Protect against NULL pointer dereference for streams without caps

CID 1363332

7 years agortph263pay: Free mac on errors
Sebastian Dröge [Tue, 28 Feb 2017 10:57:02 +0000 (12:57 +0200)]
rtph263pay: Free mac on errors

CID 1212149

7 years agortpvorbispay: Add missing break to for loop
Sebastian Dröge [Tue, 28 Feb 2017 10:45:24 +0000 (12:45 +0200)]
rtpvorbispay: Add missing break to for loop

7 years agocheck: Fix splitmux test CFLAGS
Edward Hervey [Tue, 28 Feb 2017 10:02:54 +0000 (11:02 +0100)]
check: Fix splitmux test CFLAGS

Needs to know where the gstapp headers are

7 years agoqtdemux: Fix compilation with gcc 7
Sebastian Dröge [Mon, 27 Feb 2017 19:02:51 +0000 (21:02 +0200)]
qtdemux: Fix compilation with gcc 7

qtdemux.c: In function ‘qtdemux_parse_samples’:
qtdemux.c:8450:39: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
         if (stream->samples_per_frame * stream->bytes_per_frame) {
             ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

7 years agompegaudioparse: Fix compilation with gcc 7
Sebastian Dröge [Mon, 27 Feb 2017 19:01:23 +0000 (21:01 +0200)]
mpegaudioparse: Fix compilation with gcc 7

gstmpegaudioparse.c: In function ‘gst_mpeg_audio_parse_reset’:
gstmpegaudioparse.c:209:3: error: ‘memset’ used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size]
   memset (mp3parse->xing_seek_table_inverse, 0, 256);
   ^~~~~~
gstmpegaudioparse.c: In function ‘gst_mpeg_audio_parse_handle_first_frame’:
gstmpegaudioparse.c:951:7: error: ‘memset’ used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size]
       memset (mp3parse->xing_seek_table_inverse, 0, 256);
       ^~~~~~

7 years agortpvorbispay: When getting new headers, replace the old version of them
Sebastian Dröge [Mon, 27 Feb 2017 17:31:39 +0000 (19:31 +0200)]
rtpvorbispay: When getting new headers, replace the old version of them

This prevents storing an infinite amount of e.g. comment headers if they
come without a new initialization header in front of them. There can
only be one header of each type.

7 years agortp-payloading: Add new test for Vorbis renegotiation
Sebastian Dröge [Mon, 27 Feb 2017 17:25:35 +0000 (19:25 +0200)]
rtp-payloading: Add new test for Vorbis renegotiation

Check if encoding, payloading, depayloading and decoding works if the
stream configuration (and thus the headers) change.

7 years agovorbispay: Only replace headers when receiving a new config header
Sebastian Dröge [Mon, 27 Feb 2017 17:24:07 +0000 (19:24 +0200)]
vorbispay: Only replace headers when receiving a new config header

If we also replace all headers when receiving any possibly following
comments header, we would throw away the config header before being able
to make use of it.

7 years agotests: splitmux: add unit test for content with sparse streams
George Kiagiadakis [Thu, 23 Feb 2017 10:11:15 +0000 (12:11 +0200)]
tests: splitmux: add unit test for content with sparse streams

https://bugzilla.gnome.org/show_bug.cgi?id=761086

7 years agosplitmuxpartreader: ignore sparse streams when calculating the end offset of a part
George Kiagiadakis [Wed, 22 Feb 2017 09:23:19 +0000 (11:23 +0200)]
splitmuxpartreader: ignore sparse streams when calculating the end offset of a part

A sparse stream's ending timestamp can be considerably smaller
than the ending timestamps of the other streams, which can lead
to skipping considerable time from the next part.

https://bugzilla.gnome.org/show_bug.cgi?id=761086

7 years agosplitmuxpartreader: identify sparse streams
George Kiagiadakis [Wed, 22 Feb 2017 09:21:06 +0000 (11:21 +0200)]
splitmuxpartreader: identify sparse streams

7 years agoUpdate Edgard Lima's email
Edgard Lima [Sun, 26 Feb 2017 00:47:03 +0000 (21:47 -0300)]
Update Edgard Lima's email

https://bugzilla.gnome.org/show_bug.cgi?id=779230

7 years agortpjitterbuffer: Don't always reset PTS to 0 after a gap
Andrew [Wed, 8 Feb 2017 13:36:00 +0000 (13:36 +0000)]
rtpjitterbuffer: Don't always reset PTS to 0 after a gap

In function rtp_jitter_buffer_calculate_pts: If gap in incoming RTP
timestamps is more than (3 * jbuf->clock_rate) we call
rtp_jitter_buffer_reset_skew which resets pts to 0. So components down
the pipeline (playes, mixers) just skip frames/samples until pts becomes
equal to pts before gap.

In version 1.10.2 and before this checking was bypassed for packets with
"estimated dts", and gaps were handled correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=778341

7 years agomeson: Update version
Sebastian Dröge [Fri, 24 Feb 2017 13:59:41 +0000 (15:59 +0200)]
meson: Update version

7 years agoBack to development
Sebastian Dröge [Fri, 24 Feb 2017 13:37:36 +0000 (15:37 +0200)]
Back to development

7 years agoRelease 1.11.2
Sebastian Dröge [Fri, 24 Feb 2017 13:07:23 +0000 (15:07 +0200)]
Release 1.11.2

7 years agoUpdate .po files
Sebastian Dröge [Fri, 24 Feb 2017 10:50:21 +0000 (12:50 +0200)]
Update .po files

7 years agopo: Update translations
Sebastian Dröge [Fri, 24 Feb 2017 10:44:58 +0000 (12:44 +0200)]
po: Update translations

7 years agosouphttpsrc: Extract redirection uri on libsoup's restarted callback
Seungha Yang [Fri, 10 Feb 2017 11:50:17 +0000 (20:50 +0900)]
souphttpsrc: Extract redirection uri on libsoup's restarted callback

Let libsoup handle redirection automatically.
And then, to figure out redirection uri, extract it on "restarted"
callback which will be fired before soup_session_send() is returned.

https://bugzilla.gnome.org/show_bug.cgi?id=778428

7 years agov4l2object: Update image size when extrapolating
Nicolas Dufresne [Tue, 3 Jan 2017 00:29:04 +0000 (19:29 -0500)]
v4l2object: Update image size when extrapolating

Update the image size according the amount of data we are going to
read/write. This workaround bugs in driver where the sizeimage provided
by TRY/S_FMT represent the buffer length (maximum size) rather then the expected
bytesused (buffer size).

https://bugzilla.gnome.org/show_bug.cgi?id=775564

7 years agov4l2: fix typo in _acquire_format() error messages
Reynaldo H. Verdejo Pinochet [Fri, 17 Feb 2017 23:50:32 +0000 (15:50 -0800)]
v4l2: fix typo in _acquire_format() error messages

Fixes:

https://bugzilla.gnome.org/show_bug.cgi?id=778815

7 years agotests: matroskamux, qtmux: don't add codec_data buffers to template caps
Guillaume Desmottes [Tue, 7 Feb 2017 16:27:56 +0000 (17:27 +0100)]
tests: matroskamux, qtmux: don't add codec_data buffers to template caps

streamheader and codec_data buffers fields are only meant to be
in the negotiated caps, not the template caps.

Fixes false-positive leaks of those buffers detected by the leaks
tracer, as template caps are static, and we decided to not include
code in gstreamer core to handle this unusual case of template caps
having buffers in them.

https://bugzilla.gnome.org/show_bug.cgi?id=768762

7 years agortpvorbispay: Update and send out headers when new headers are received
Jochen Henneberg [Thu, 9 Feb 2017 12:46:54 +0000 (12:46 +0000)]
rtpvorbispay: Update and send out headers when new headers are received

The payloader needs to reset and update the vorbis config data which is
pushed on the network if it receives new headers, or at least, it may
have to do so.

Without this, the stream configuration could change without the
payloader sending the new configuration to the other side.

7 years agosplitmuxsink: Change files on incompatible caps
Olivier Crête [Wed, 15 Feb 2017 19:48:58 +0000 (14:48 -0500)]
splitmuxsink: Change files on incompatible caps

https://bugzilla.gnome.org/show_bug.cgi?id=761761

7 years agosplitmuxsink: Reset ready_for_output on state change
Olivier Crête [Wed, 15 Feb 2017 21:35:01 +0000 (16:35 -0500)]
splitmuxsink: Reset ready_for_output on state change

https://bugzilla.gnome.org/show_bug.cgi?id=761761

7 years agosplitmuxsink: Remove unused next_max_out_running_time
Olivier Crête [Wed, 15 Feb 2017 20:09:06 +0000 (15:09 -0500)]
splitmuxsink: Remove unused next_max_out_running_time

https://bugzilla.gnome.org/show_bug.cgi?id=761761

7 years agosplitmuxsink: Remove unused muxed_out_time
Olivier Crête [Wed, 15 Feb 2017 20:07:32 +0000 (15:07 -0500)]
splitmuxsink: Remove unused muxed_out_time

https://bugzilla.gnome.org/show_bug.cgi?id=761761

7 years agoRevert "qtdemux: Always snap to the start of the keyframe"
Jan Schmidt [Fri, 17 Feb 2017 02:07:05 +0000 (13:07 +1100)]
Revert "qtdemux: Always snap to the start of the keyframe"

This reverts commit 107902ec514bd826aa29d2298107e2c091e1c779.

This commit intended to ensure that keyframe seeks land at the
start timestamp of a keyframe, rather than in the middle of one,
but they cause trouble on files with sparse streams, or with
JPEG 'cover art' tracks that have only one or a few JPEG samples
with very long durations.

That's still desirable for doing seamless cutting of videos,
but needs a rethink for implementation.

https://bugzilla.gnome.org/show_bug.cgi?id=778690

7 years agoaudiofx/echo: added surround-delay and surround-mask
Jan Schmidt [Thu, 16 Feb 2017 14:22:11 +0000 (01:22 +1100)]
audiofx/echo: added surround-delay and surround-mask

Add a new boolean surround-delay property that makes
audioecho just apply a delay to certain channels to create
a surround effect, rather than an echo on all
channels. This is useful when upmixing from stereo - for example.

Add a surround-mask property to control which channels
are considered surround sound channels when adding a
delay with surround-delay = true

Original patch from Jochen Henneberg <jh@henneberg-systemdesign.com>

7 years agoudpsrc: Use IP_MULTICAST_ALL for filtering IPv4 packets if available
Sebastian Dröge [Tue, 14 Feb 2017 22:13:30 +0000 (00:13 +0200)]
udpsrc: Use IP_MULTICAST_ALL for filtering IPv4 packets if available

This goes around the inefficient control message based filtering and
does all the filtering kernel-side. Unfortunately this is Linux-only and
there is no IPv6 variant of it (yet).

7 years agomeson: dist meson build files
Tim-Philipp Müller [Tue, 14 Feb 2017 19:53:30 +0000 (19:53 +0000)]
meson: dist meson build files

Ship meson build files in tarballs, so people who use tarballs
in their builds can start playing with meson already.

7 years agoicydemux: reset tags on empty value
Søren Juul [Fri, 10 Feb 2017 09:53:05 +0000 (10:53 +0100)]
icydemux: reset tags on empty value

Some radio streams uses StreamTitle='' to reset the title after a
track stopped playing, e.g. while the host talks between tracks or
during news segments.
This change forces an empty tag object to be distributed if
StreamTitle or StreamUrl is received with empty value, thus allowing
downstream elements to get notified about this.

https://bugzilla.gnome.org/show_bug.cgi?id=778437

7 years agortspsrc: Properly notify missing elements
Edward Hervey [Mon, 13 Feb 2017 10:17:25 +0000 (11:17 +0100)]
rtspsrc: Properly notify missing elements

If the srtp elements are not present, post a message on the bus
informing about the missing plugins.

7 years agov4l2object: mark singleton caps as "may be leaked" objects.
Juan Pablo Ugarte [Fri, 10 Feb 2017 13:32:57 +0000 (10:32 -0300)]
v4l2object: mark singleton caps as "may be leaked" objects.

Set MAY_BE_LEAKED flag on static pads returned by gst_v4l2_object_get_*_caps()
functions. Made functions thread safe by using g_once_init[enter|leave]
funtions.

https://bugzilla.gnome.org/show_bug.cgi?id=778453

7 years agoimagefreeze: Remove now unused done label
Sebastian Dröge [Thu, 9 Feb 2017 12:18:30 +0000 (14:18 +0200)]
imagefreeze: Remove now unused done label

7 years agoimagefreeze: do not cache caps
Nick Kallen [Thu, 9 Feb 2017 11:55:32 +0000 (12:55 +0100)]
imagefreeze: do not cache caps

Upstream elements like videoflip can transform caps, such as changing width and height.
When an imagefreeze downstream receives an ACCEPT_CAPS query it will NOW return
all caps that it can accept.

https://bugzilla.gnome.org/show_bug.cgi?id=778389

7 years agoqtmux: Add a comment about how atom_trak_set_elst_entry() works
Jan Schmidt [Thu, 9 Feb 2017 00:29:43 +0000 (11:29 +1100)]
qtmux: Add a comment about how atom_trak_set_elst_entry() works

7 years agoqtdemux: demote some log messages to TRACE level
Tim-Philipp Müller [Fri, 22 Aug 2014 08:55:43 +0000 (09:55 +0100)]
qtdemux: demote some log messages to TRACE level

Don't spam debug log with uninteresting stuff.

7 years agoqtmux: Clear edit lists every time we recalculate them
Sebastian Dröge [Wed, 8 Feb 2017 15:24:26 +0000 (17:24 +0200)]
qtmux: Clear edit lists every time we recalculate them

We recalculate them, so any old information has to be forgotten.
Otherwise we write invalid edit lists when writing headers multiple
times.

https://bugzilla.gnome.org/show_bug.cgi?id=778330

7 years agosplitmuxsrc: Allow for buffers before the segment when measuring
Jan Schmidt [Tue, 7 Feb 2017 02:10:18 +0000 (13:10 +1100)]
splitmuxsrc: Allow for buffers before the segment when measuring

Used signed calculations when measuring the max_ts of an input
fragment, so as to calculate the correct duration and offset
when buffers have timestamps preceding their segment

7 years agortpsession: relate received FIRs and PLIs to source
Miguel París Díaz [Thu, 2 Feb 2017 11:55:25 +0000 (12:55 +0100)]
rtpsession: relate received FIRs and PLIs to source

This is needed in order to:
 - Avoid ignoring requests for different media sources.
 - Add SSRC field in the GstForceKeyUnit event.

https://bugzilla.gnome.org/show_bug.cgi?id=778013

7 years agoqtdemux: sanity check number of segments in edit list
Tim-Philipp Müller [Mon, 30 Jan 2017 20:20:08 +0000 (20:20 +0000)]
qtdemux: sanity check number of segments in edit list

Fixes crash with fuzzed file.

https://bugzilla.gnome.org/show_bug.cgi?id=777940

7 years agoqtdemux: Skip seeking query if upstream format is time
Seungha Yang [Mon, 2 Jan 2017 13:16:39 +0000 (22:16 +0900)]
qtdemux: Skip seeking query if upstream format is time

Don't need to querying byte-format seeking for time-format
upstream case

https://bugzilla.gnome.org/show_bug.cgi?id=776715

7 years agoqtdemux: Use upstream's StreamFlags if there are
Seungha Yang [Thu, 1 Dec 2016 03:47:08 +0000 (12:47 +0900)]
qtdemux: Use upstream's StreamFlags if there are

When multiple demuxer's are used, upstream might want to indicate
default streams using GST_STREAM_FLAG_{SELECT, UNSELECT}

https://bugzilla.gnome.org/show_bug.cgi?id=775440

7 years agoqtmux: Timecode track fixes for STSD entry
Vivia Nikolaidou [Fri, 27 Jan 2017 14:14:16 +0000 (16:14 +0200)]
qtmux: Timecode track fixes for STSD entry

The n_frames field (frames per second) should follow the nominal frame
rate for drop-frame timecodes.

Also, the trak's timescale (and duration, accordingly) should follow the
STSD entry's timescale and frame duration (fps_n and fps_d accordingly),
not the other way around.

https://bugzilla.gnome.org/show_bug.cgi?id=777832

7 years agosouphttpsrc: retry request on early termination from the server
Arnaud Vrac [Thu, 19 Jan 2017 10:08:11 +0000 (11:08 +0100)]
souphttpsrc: retry request on early termination from the server

Fix a regression introduced by commit 183695c61a54f1 (refactor to use
Soup's sync API). The code previously attempted to reconnect when the
server closed the connection early, for example when the stream was put
in pause for some time.

Reintroduce this feature by checking if EOS is received before the
expected content size is downloaded. In this case, do the request
starting at the previous read position.

https://bugzilla.gnome.org/show_bug.cgi?id=776720

7 years agortspsrc: find_stream_by_channel should ignore unconfigured streams
Matt Staples [Tue, 10 Jan 2017 16:40:56 +0000 (09:40 -0700)]
rtspsrc: find_stream_by_channel should ignore unconfigured streams

https://bugzilla.gnome.org/show_bug.cgi?id=777101

7 years agoqtmux: Fix debug typo and remove misleading warning
Brendan Shanks [Wed, 25 Jan 2017 18:43:00 +0000 (18:43 +0000)]
qtmux: Fix debug typo and remove misleading warning

https://bugzilla.gnome.org/show_bug.cgi?id=777362

7 years agortp: Remove unused variable in example
Sebastian Dröge [Wed, 25 Jan 2017 18:56:24 +0000 (20:56 +0200)]
rtp: Remove unused variable in example

client-PCMA.c:84:22: warning: unused variable 'isrc' [-Wunused-variable]
  GObject *session, *isrc, *osrc;
                     ^

7 years agowavparse: check for not NULL before clearing adapter
Rahul Bedarkar [Mon, 9 Jan 2017 06:02:35 +0000 (11:32 +0530)]
wavparse: check for not NULL before clearing adapter

In case wavparse receives a manually injected FLUSH_STOP event
while operating in pull mode we get criticals because we'd try
to clear a NULL adapter.

https://bugzilla.gnome.org/show_bug.cgi?id=777123

7 years agomeson: Properly use ':' for defining keywords
Thibault Saunier [Tue, 24 Jan 2017 22:23:44 +0000 (19:23 -0300)]
meson: Properly use ':' for defining keywords

7 years agov4l2allocator: reference memory before the buffer is queued
Jean-Christophe Trotin [Tue, 17 Jan 2017 15:41:58 +0000 (16:41 +0100)]
v4l2allocator: reference memory before the buffer is queued

In gst_v4l2_allocator_qbuf(), the memory is referenced after the
buffer is queued. Once queued (VIDIOC_QBUF), the buffer might be handled
by the V4L2 driver (e.g. decoded) and dequeued (gst_v4l2_allocator_dqbuf),
through a different thread, before the memory is referenced (gst_memory_ref).
In this case, in gst_v4l2_allocator_dqbuf(), the memory is unreferenced
(gst_memory_unref) before having been referenced: the memory refcount
reaches 0, and the memory is freed.
So, to avoid this crossing case, in gst_v4l2_allocator_qbuf(), the
memory shall be referenced before the buffer is queued.

https://bugzilla.gnome.org/show_bug.cgi?id=777399

7 years agoqtmux: Only write 4 byte zero padding to the Video Sample Description in MOV
Sebastian Dröge [Tue, 24 Jan 2017 15:59:59 +0000 (17:59 +0200)]
qtmux: Only write 4 byte zero padding to the Video Sample Description in MOV

For MP4 this is not defined, and it actually breaks things for MSE in
Chrome if we do this. For MOV this is required by some broken software
but the official specification says it's optional:
https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html

https://bugzilla.gnome.org/show_bug.cgi?id=777540

7 years agortpstats: Keep number of nacks sent/received per source
Santiago Carot-Nemesio [Mon, 2 Jan 2017 12:42:04 +0000 (13:42 +0100)]
rtpstats: Keep number of nacks sent/received per source

Currently, the nack packets sent or received are kept at session level,
which makes it impossible to distinguish how many of these packages were
sent/received per ssrc when several sources are in the same session. This
patch is aligned with the https://www.w3.org/TR/webrtc-stats/#dom-rtcrtpstreamstats

https://bugzilla.gnome.org/show_bug.cgi?id=776714

7 years agortph265pay: Fix handling of config-interval
Jonas Holmberg [Thu, 8 Dec 2016 14:59:33 +0000 (15:59 +0100)]
rtph265pay: Fix handling of config-interval

Insert VPS/SPS/PPS before the first NAL unit containing an I-frame in an
access unit only. If an access unit consists of several such NAL units
(tiles) VPS/SPS/PPS should only be inserted before the first of them so
that parameters are only updated between frames.

Do not insert VPS/SPS/PPS before P-frames when config-interval is -1.

https://bugzilla.gnome.org/show_bug.cgi?id=775817

7 years agosouphttpsrc: report a useful error message when soup_session_send fails
Arnaud Vrac [Thu, 19 Jan 2017 11:29:44 +0000 (12:29 +0100)]
souphttpsrc: report a useful error message when soup_session_send fails

This helps to understand cases where libsoup doesn't set the message
status code after running soup_session_send.

https://bugzilla.gnome.org/show_bug.cgi?id=777222

7 years agosouphttpsrc: properly check that seek range was respected
Arnaud Vrac [Thu, 19 Jan 2017 10:05:00 +0000 (11:05 +0100)]
souphttpsrc: properly check that seek range was respected

This check must be done only when we are sure the request was
successfully sent. soup_session_send() might fail without setting the
status code. In this case status code is 0 so we would only catch the
error after the seek range check. In this case we would report an error
saying that the seek range was not respected, instead of reporting the
underlying error that triggered the soup_session_send() failure.

https://bugzilla.gnome.org/attachment.cgi?bugid=777222

7 years agogdkpixbufoverlay: add a positioning coefficient pair
Mark Nauwelaerts [Mon, 9 Jan 2017 20:04:51 +0000 (21:04 +0100)]
gdkpixbufoverlay: add a positioning coefficient pair

... so as to allow one clearly defined (absolute) positioning mode
that can cater for a variety of absolute but also relative positioning
with respect to edge or center.

7 years agogdkpixbufoverlay: update composition in _before_transform
Mark Nauwelaerts [Sat, 21 Jan 2017 19:48:22 +0000 (20:48 +0100)]
gdkpixbufoverlay: update composition in _before_transform

... since we need to determine passthrough mode for buffer preparation before
calling into _transform_ip.

7 years agogdkpixbufoverlay: handle setting NULL gdkpixbuf
Mark Nauwelaerts [Sat, 7 Jan 2017 19:11:13 +0000 (20:11 +0100)]
gdkpixbufoverlay: handle setting NULL gdkpixbuf

... which is a clearer way to clear any current overlay, other than
fiddling with alpha or positioning properties to make it virtually go away.

7 years agoavidemux: Stop reading a ncdt sub-tag if it goes behind the surrounding tag
Sebastian Dröge [Fri, 20 Jan 2017 15:16:10 +0000 (17:16 +0200)]
avidemux: Stop reading a ncdt sub-tag if it goes behind the surrounding tag

https://bugzilla.gnome.org/show_bug.cgi?id=777532

7 years agoavidemux: Fix various out of bounds reads when parsing ncdt tags
Sebastian Dröge [Fri, 20 Jan 2017 05:58:26 +0000 (07:58 +0200)]
avidemux: Fix various out of bounds reads when parsing ncdt tags

https://bugzilla.gnome.org/show_bug.cgi?id=777500

7 years agoqtdemux: Increment current stts index whenever we finished one stts entry
Sebastian Dröge [Thu, 19 Jan 2017 11:46:58 +0000 (13:46 +0200)]
qtdemux: Increment current stts index whenever we finished one stts entry

Otherwise we could read more chunks than there are available, doing an
out of bounds read and potentially crash.

https://bugzilla.gnome.org/show_bug.cgi?id=777469

7 years agoRevert "qtdemux: Increment current stts index in all code paths after reading one...
Sebastian Dröge [Thu, 19 Jan 2017 11:25:53 +0000 (13:25 +0200)]
Revert "qtdemux: Increment current stts index in all code paths after reading one chunk"

This reverts commit 99d5d7570d0b53dad3bc8eb653b1320ee422aace. It broke
playback of various valid files.

7 years agoqtdemux: Increment current stts index in all code paths after reading one chunk
Sebastian Dröge [Thu, 19 Jan 2017 05:52:33 +0000 (07:52 +0200)]
qtdemux: Increment current stts index in all code paths after reading one chunk

Otherwise we could read more chunks than there are available, doing an
out of bounds read and potentially crash.

https://bugzilla.gnome.org/show_bug.cgi?id=777469

7 years agosouphttpsrc: Initialize return variable
Edward Hervey [Thu, 19 Jan 2017 07:37:37 +0000 (08:37 +0100)]
souphttpsrc: Initialize return variable

In the normal use-case we would end up with ret being unitialized
causing havoc.

https://bugzilla.gnome.org/show_bug.cgi?id=777222

7 years agoqtdemux: avoid XMP tag parsing fatal error.
David Warman [Fri, 13 Jan 2017 12:27:40 +0000 (12:27 +0000)]
qtdemux: avoid XMP tag parsing fatal error.

qtdemux_handle_xmp_taglist() requires a writable taglist,
but qtdemux->tag_list can become non-writable, specifically
after sending global tags (qtdemux.c:958), which adds a
second reference.  Ensure the list is made writable before
calling (make_writable will copy the list if necessary).

https://bugzilla.gnome.org/show_bug.cgi?id=766177

7 years agoqtdemux: rework taglist handling
Thiago Santos [Tue, 31 May 2016 16:17:45 +0000 (13:17 -0300)]
qtdemux: rework taglist handling

Keep taglist around during element existance to avoid having to
create it at different places before usage. Makes code simpler to handle.

https://bugzilla.gnome.org/show_bug.cgi?id=766177

7 years agosouphttpsrc: make flow return values handling clearer
Arnaud Vrac [Mon, 16 Jan 2017 10:58:02 +0000 (11:58 +0100)]
souphttpsrc: make flow return values handling clearer

The flow return values was stored in the element before because the
result had to be set from callbacks. This is not the case anymore, we
can return the flow result directly from functions, making the code
easier to understand.

https://bugzilla.gnome.org/show_bug.cgi?id=777222