platform/upstream/coreclr.git
6 years agoMerge pull request #16308 from sdmaclea/PR-JIT.SIMD.VectorUtil.CheckValue
Carol Eidt [Fri, 9 Feb 2018 22:59:54 +0000 (14:59 -0800)]
Merge pull request #16308 from sdmaclea/PR-JIT.SIMD.VectorUtil.CheckValue

Fix JIT.SIMD.VectorUtil.CheckValue<T>

6 years ago[Arm64] Implement Simd.Insert
Steve MacLean [Tue, 30 Jan 2018 21:11:39 +0000 (16:11 -0500)]
[Arm64] Implement Simd.Insert

6 years agoEOL Removals:
Matt Galbraith [Fri, 9 Feb 2018 21:13:49 +0000 (13:13 -0800)]
EOL Removals:

Fedora 23
RedHat 7.2
Ubuntu 16.10

Additions:
OSX 10.13
Ubuntu.17.10
Ubuntu 18.04
OpenSuse 42.3
SLES 12

6 years agoFix JIT.SIMD.VectorUtil.CheckValue<T>
Steve MacLean [Fri, 9 Feb 2018 21:01:05 +0000 (16:01 -0500)]
Fix JIT.SIMD.VectorUtil.CheckValue<T>

6 years agoRemove an old JIT64 thread suspend work around (#16304)
Brian Sullivan [Fri, 9 Feb 2018 21:07:51 +0000 (13:07 -0800)]
Remove an old JIT64 thread suspend work around (#16304)

JIT64 isn't ever used for CoreCLR

6 years agoFix T[]->ArraySegment cast to return default for null (#16301)
Stephen Toub [Fri, 9 Feb 2018 20:31:22 +0000 (15:31 -0500)]
Fix T[]->ArraySegment cast to return default for null (#16301)

6 years agoMerge pull request #16248 from briansull/fix-16065
Brian Sullivan [Fri, 9 Feb 2018 19:15:06 +0000 (11:15 -0800)]
Merge pull request #16248 from briansull/fix-16065

Fixes GitHub Issue 16065

6 years agoMerge pull request #16217 from adamsitnik/eventPipeAssert
Adam Sitnik [Fri, 9 Feb 2018 17:51:41 +0000 (18:51 +0100)]
Merge pull request #16217 from adamsitnik/eventPipeAssert

fix the Incorrect EventPipe Assert, fixes #16158

6 years agoMerge pull request #16300 from jkotas/revert
Jan Kotas [Fri, 9 Feb 2018 17:45:48 +0000 (09:45 -0800)]
Merge pull request #16300 from jkotas/revert

 Revert "Debugger api to set a breakpoint on offset 0 of all methods"

6 years agoRevert "Debugger api to set a breakpoint on offset 0 of all methods (#15819)"
Jan Kotas [Fri, 9 Feb 2018 17:40:42 +0000 (09:40 -0800)]
Revert "Debugger api to set a breakpoint on offset 0 of all methods (#15819)"

This reverts commit 3d689d00843618105e735c5647e1cb64e721a333.

6 years agoRevert "fix for issue #16289 (#16291)"
Jan Kotas [Fri, 9 Feb 2018 17:40:36 +0000 (09:40 -0800)]
Revert "fix for issue #16289 (#16291)"

This reverts commit cd3f6e77757729d3d02dfbec4af21cdfe83f5435.

6 years agoFix GC reporting for slow tail calls with by-ref-like args (#16264)
Koundinya Veluri [Fri, 9 Feb 2018 16:28:59 +0000 (08:28 -0800)]
Fix GC reporting for slow tail calls with by-ref-like args (#16264)

Fix GC reporting for slow tail calls with by-ref-like args

Fixes https://github.com/dotnet/coreclr/issues/16229:
- Offsets recorded in the GC layout are intended to be offsets from the top of the stack, fixed by calculating the proper offset

6 years agoChange compliement to complement
Tanner Gooding [Thu, 8 Feb 2018 15:57:49 +0000 (07:57 -0800)]
Change compliement to complement

6 years agoFixing up the emitOutput handling for RR/RRR instructions
Tanner Gooding [Thu, 8 Feb 2018 00:47:04 +0000 (16:47 -0800)]
Fixing up the emitOutput handling for RR/RRR instructions

6 years agoEnabling the named intrinsic support on SSE4.1 hardware for Math.Round, Math.Ceiling...
Tanner Gooding [Wed, 7 Feb 2018 04:38:51 +0000 (20:38 -0800)]
Enabling the named intrinsic support on SSE4.1 hardware for Math.Round, Math.Ceiling, and Math.Floor

6 years agoUpdating the emitter to more generally handle 4-Byte SSE4 instructions.
Tanner Gooding [Wed, 7 Feb 2018 04:38:24 +0000 (20:38 -0800)]
Updating the emitter to more generally handle 4-Byte SSE4 instructions.

6 years agofix for issue #16289 (#16291)
David Mason [Fri, 9 Feb 2018 08:30:02 +0000 (00:30 -0800)]
fix for issue #16289 (#16291)

6 years agoMerge pull request #15595 from mikedn/rc-binop
Brian Sullivan [Fri, 9 Feb 2018 01:57:04 +0000 (17:57 -0800)]
Merge pull request #15595 from mikedn/rc-binop

Remove useless RangeCheck::Limit::keArray

6 years agoChange corefx test process (#16263)
Bruce Forstall [Fri, 9 Feb 2018 01:00:10 +0000 (17:00 -0800)]
Change corefx test process (#16263)

Instead of using the `/p:CoreCLROverridePath` switch when building
corefx, to bring in coreclr, build corefx normally. This builds
against the coreclr packages that corefx has already been validated
against in the CI, so the build should always work. Then, copy
over our built coreclr bits before testing. This method is expected
to have better behavior in most breaking change scenarios.

6 years agoMerge pull request #16281 from alpencolt/clr-extra-args-4-cmake
Wes Haggard [Fri, 9 Feb 2018 00:53:25 +0000 (16:53 -0800)]
Merge pull request #16281 from alpencolt/clr-extra-args-4-cmake

[Unix] Passing extra CMake args

6 years agoMerge pull request #16278 from BredPet/fix_cfi_unwind_info
Bruce Forstall [Thu, 8 Feb 2018 23:25:17 +0000 (15:25 -0800)]
Merge pull request #16278 from BredPet/fix_cfi_unwind_info

[RyuJIT/ARM32] Fix crash while generating CFI unwind info

6 years agoAdjust expected file size if ZapDisable is true (#16240)
Victor "Nate" Graf [Thu, 8 Feb 2018 23:07:20 +0000 (15:07 -0800)]
Adjust expected file size if ZapDisable is true (#16240)

6 years agoMerge pull request #15673 from tannergooding/generatelayout-switch
Jarret Shook [Thu, 8 Feb 2018 22:43:24 +0000 (14:43 -0800)]
Merge pull request #15673 from tannergooding/generatelayout-switch

Updating build.cmd to support 'generatelayout' when 'skiptests' is specified.

6 years agoDebugger api to set a breakpoint on offset 0 of all methods (#15819)
David Mason [Thu, 8 Feb 2018 22:35:01 +0000 (14:35 -0800)]
Debugger api to set a breakpoint on offset 0 of all methods (#15819)

* Debugger api to set a breakpoint on offset 0 of all methods

* code review feedback

* more code review feedback

* respect IsIl in CorDbFunctionBreakoint()

* change SIMPLIFYING_ASSERT to SIMPLIFYING_ASSUMPTION_SUCCEEDED for hrs, it outputs a much better diagnostic message

6 years agoUpdating runtime version for tests (#16271)
Noah Falk [Thu, 8 Feb 2018 21:59:26 +0000 (13:59 -0800)]
Updating runtime version for tests (#16271)

Change 93ec62347a4e97b920513296eefb27bdacbecfe9 removed Span.NonPortableCast from System.Private.CoreLib.dll requiring tests
to use an updated version of System.Memory.dll that no longer refers to it.

6 years agoExplictly initialize EventData.Reserved for System.Private.CoreLib. (#16283)
Brian Robbins [Thu, 8 Feb 2018 21:24:52 +0000 (13:24 -0800)]
Explictly initialize EventData.Reserved for System.Private.CoreLib. (#16283)

6 years agoExtra semicolons left at the end of Combine function taking 4 paths. (#16284)
Anirudh Agnihotry [Thu, 8 Feb 2018 21:03:50 +0000 (13:03 -0800)]
Extra semicolons left at the end of Combine function taking 4 paths. (#16284)

6 years agoAdd tests for Sse2 memory fence instructions
Jacek Blaszczynski [Wed, 7 Feb 2018 22:29:30 +0000 (23:29 +0100)]
Add tests for Sse2 memory fence instructions

6 years agoImplement Sse2 memory fence instructions
Jacek Blaszczynski [Wed, 7 Feb 2018 22:28:38 +0000 (23:28 +0100)]
Implement Sse2 memory fence instructions

6 years agoMerge pull request #16268 from CarolEidt/Fix16254
Carol Eidt [Thu, 8 Feb 2018 19:43:00 +0000 (11:43 -0800)]
Merge pull request #16268 from CarolEidt/Fix16254

Check mismatched types for SIMD copy

6 years agoMerge pull request #16260 from sdmaclea/PR-ARM64-Remove-SIMD-hacks
Carol Eidt [Thu, 8 Feb 2018 17:35:31 +0000 (09:35 -0800)]
Merge pull request #16260 from sdmaclea/PR-ARM64-Remove-SIMD-hacks

[Arm64] Remove SIMD hacks to get*TypeForStruct

6 years ago[Unix] Passing extra CMake args
Alexander Soldatov [Thu, 8 Feb 2018 17:26:59 +0000 (20:26 +0300)]
[Unix] Passing extra CMake args

Added support for compiler and linker additional arguments in CMake.
By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS
it's possible to pass toolchain options without changing Makefile.

6 years agoMerge pull request #16279 from BruceForstall/FixArmCorefxAbsolutePaths
Bruce Forstall [Thu, 8 Feb 2018 16:40:00 +0000 (08:40 -0800)]
Merge pull request #16279 from BruceForstall/FixArmCorefxAbsolutePaths

Make paths used by ARM corefx test script absolute

6 years agoMake paths used by ARM corefx test script absolute
Bruce Forstall [Thu, 8 Feb 2018 16:31:09 +0000 (08:31 -0800)]
Make paths used by ARM corefx test script absolute

6 years agoCleanup redundant stale COR header definition (#16261)
Jan Kotas [Thu, 8 Feb 2018 13:48:59 +0000 (05:48 -0800)]
Cleanup redundant stale COR header definition (#16261)

6 years ago[RyuJIT/ARM32] Fix crash while generating CFI unwind info
Petr Bred [Thu, 8 Feb 2018 12:04:44 +0000 (15:04 +0300)]
[RyuJIT/ARM32] Fix crash while generating CFI unwind info

Signed-off-by: Petr Bred <bredpetr@gmail.com>
6 years agoThrowing IO Related exception only on FileStream.Dispose(disposing:true) (#16250)
Maryam Ariyan [Thu, 8 Feb 2018 06:55:11 +0000 (01:55 -0500)]
Throwing IO Related exception only on FileStream.Dispose(disposing:true) (#16250)

* Making Unix and Windows FileStream Dispose behavior more consistent and throwing IO related exception only on Dispose(true)

Fixes: #26734

* Commenting out SecurityException, also providing reason

6 years agoMake it possible to Reflection.Emit default interface methods (#16257)
Michal Strehovský [Thu, 8 Feb 2018 06:54:39 +0000 (07:54 +0100)]
Make it possible to Reflection.Emit default interface methods (#16257)

Fixes #15648.

6 years agoAgruments -> Arguments (#16273)
John Doe [Thu, 8 Feb 2018 06:05:32 +0000 (22:05 -0800)]
Agruments -> Arguments (#16273)

6 years agoFixes GitHub Issue 16065
Brian Sullivan [Wed, 7 Feb 2018 02:27:52 +0000 (18:27 -0800)]
Fixes GitHub Issue 16065
Bug in the CSE phase when a CSE use contains a CSE def

For the error cases we could unmark or discard a CSE def. This CSE def might be needed when
 performing a subsequent CSE replacement.  This could lead to an uninitialized value being
 used for the CSE use.

Changed optUnmarkCSE method to return a bool instead of a void.
Changed optValuenumCSE_UnmarkCSEs  to take a write-back mutable wbKeepList argument
Removed an unreachable code block in fgRemoveStmt and replaced it with a noway_assert
Added method headers for optUnmarkCSE and optUnmarkCSEs
Removed the code that allowed unmarking of a CSE def, instead we return false
Retyped the second arguments to optUnmarksCSEs and optValueNumCSE_UnmarkCSEs
 to support appending new nodes to keep using wbKeepList
Code modifications to PerformCSE() to support collecting both persistent side effects and
 any nested CSE defs found in CSE uses.  Move the location of the call to
optValueNumCSE_UnmarkCSEs so that it comes before the decision to create a GT_COMMA node
 for the cse use.

6 years agoCheck mismatched types for SIMD copy
Carol Eidt [Thu, 8 Feb 2018 01:31:34 +0000 (17:31 -0800)]
Check mismatched types for SIMD copy

If we have a block copy from an enregisterable struct (today, that's just SIMD) to a different type target, it needs to be makred as address-taken, because the destination type is what's used for the copy, and all non-enregisterable destination types expect their source in memory.

Fix #16254

6 years agoUpdate BuildTools, CoreClr to preview2-02507-02, preview2-26207-11, respectively...
dotnet-maestro-bot [Thu, 8 Feb 2018 01:06:29 +0000 (19:06 -0600)]
Update BuildTools, CoreClr to preview2-02507-02, preview2-26207-11, respectively (#16256)

6 years agoRemoves Extra allocations for corner cases in CombineNochecks (#16255)
Anirudh Agnihotry [Thu, 8 Feb 2018 00:49:31 +0000 (16:49 -0800)]
Removes Extra allocations for corner cases in CombineNochecks (#16255)

* Added String Overload

6 years agoInitialize stack allocated data structures. (#16259)
Brian Robbins [Wed, 7 Feb 2018 22:47:25 +0000 (14:47 -0800)]
Initialize stack allocated data structures. (#16259)

6 years ago[Arm64] Remove SIMD hacks to get*TypeForStruct
Steve MacLean [Wed, 7 Feb 2018 14:47:39 +0000 (09:47 -0500)]
[Arm64] Remove SIMD hacks to get*TypeForStruct

6 years agoFix various typos in the readme (#16251)
Martin Andersen [Wed, 7 Feb 2018 17:16:38 +0000 (18:16 +0100)]
Fix various typos in the readme (#16251)

6 years agoAdd configuration to options to submission.py (#16127)
Michelle McDaniel [Wed, 7 Feb 2018 17:10:13 +0000 (09:10 -0800)]
Add configuration to options to submission.py (#16127)

6 years agoFix publishing errors (#16253)
Matt Mitchell [Wed, 7 Feb 2018 16:49:54 +0000 (08:49 -0800)]
Fix publishing errors (#16253)

Fix two errors:
    * Remove unneeded signed symbol catalog injection
    * Build definition is not importing becuase of duplicated task name.

6 years agoArchive CI perf results (#16230)
Noah Falk [Wed, 7 Feb 2018 10:10:28 +0000 (02:10 -0800)]
Archive CI perf results (#16230)

* Archive CI perf results

I need to diagnose a failure that only reproes in CI but the CI scripts don't archive the logs on failure. This change should fix that.

* Adding pipeline build per feedback

6 years agoFix Hebrew calendar month names list (#16247)
Tarek Mahmoud Sayed [Wed, 7 Feb 2018 04:40:10 +0000 (20:40 -0800)]
Fix Hebrew calendar month names list (#16247)

* Fix Hebrew calendar month names list

6 years agoDisable crossgen for types containing intrinsic types (#16213)
Steve MacLean [Wed, 7 Feb 2018 03:00:01 +0000 (22:00 -0500)]
Disable crossgen for types containing intrinsic types (#16213)

6 years agoMerge pull request #16241 from BruceForstall/FixJobNames
Bruce Forstall [Wed, 7 Feb 2018 02:01:06 +0000 (18:01 -0800)]
Merge pull request #16241 from BruceForstall/FixJobNames

Fix name of OSX10.12 and Ubuntu innerloop jobs

6 years agoFix stacktrace formatting to make it work on CoreRT as well (#16245)
Sung Yoon Whang [Wed, 7 Feb 2018 01:57:46 +0000 (17:57 -0800)]
Fix stacktrace formatting to make it work on CoreRT as well (#16245)

6 years agoAdd test case for contstructor devirtualization example (#16239)
Andy Ayers [Wed, 7 Feb 2018 00:05:00 +0000 (16:05 -0800)]
Add test case for contstructor devirtualization example (#16239)

See #16198 for discussion.

6 years agoFix GC reproting for by-ref-like structs (#16231)
Koundinya Veluri [Tue, 6 Feb 2018 23:59:42 +0000 (15:59 -0800)]
Fix GC reproting for by-ref-like structs (#16231)

Fix GC reproting for by-ref-like structs

Fixes https://github.com/dotnet/coreclr/issues/16044:
- Divide by pointer size was removed to produce the proper offset
- Fixed some assertion failures seen in https://github.com/dotnet/coreclr/issues/16229

6 years agoMerge pull request #16200 from fiigii/loadstore
Carol Eidt [Tue, 6 Feb 2018 22:51:23 +0000 (14:51 -0800)]
Merge pull request #16200 from fiigii/loadstore

Implement AVX/AVX2/SSE3 Load* intrinsics

6 years agoImplement AVX2 LoadAlignedVector256/128NonTemporal
Fei Peng [Mon, 5 Feb 2018 20:14:52 +0000 (12:14 -0800)]
Implement AVX2 LoadAlignedVector256/128NonTemporal

6 years agoImplement SSE3 LoadAndDuplicateToVector128 and LoadDquVector128
Fei Peng [Sun, 4 Feb 2018 19:33:51 +0000 (11:33 -0800)]
Implement SSE3 LoadAndDuplicateToVector128 and LoadDquVector128

6 years agoImplement AVX LoadAlignedVector256, LoadDquVector256, and LoadVector256
Fei Peng [Sun, 4 Feb 2018 07:40:04 +0000 (23:40 -0800)]
Implement AVX LoadAlignedVector256, LoadDquVector256, and LoadVector256

6 years agoMerge pull request #16228 from fiigii/store
Carol Eidt [Tue, 6 Feb 2018 20:58:38 +0000 (12:58 -0800)]
Merge pull request #16228 from fiigii/store

Implement AVX/SSE2 Store* intrinsics

6 years agoMerge pull request #16235 from CarolEidt/FixPrefetchBuildBreak
Carol Eidt [Tue, 6 Feb 2018 20:55:13 +0000 (12:55 -0800)]
Merge pull request #16235 from CarolEidt/FixPrefetchBuildBreak

Disable prefetch instructions for LEGACY_BACKEND

6 years agoFix name of OSX10.12 and Ubuntu innerloop jobs
Bruce Forstall [Tue, 6 Feb 2018 19:33:33 +0000 (11:33 -0800)]
Fix name of OSX10.12 and Ubuntu innerloop jobs

6 years agoMerge pull request #16006 from BruceForstall/AddWindowsArmCoreFxTesting
Bruce Forstall [Tue, 6 Feb 2018 19:28:09 +0000 (11:28 -0800)]
Merge pull request #16006 from BruceForstall/AddWindowsArmCoreFxTesting

Enable Windows ARM32 corefx testing

6 years agoDon't remove the first non-internal block that has profile weight. (#16227)
Eugene Rozenfeld [Tue, 6 Feb 2018 19:19:32 +0000 (11:19 -0800)]
Don't remove the first non-internal block that has profile weight. (#16227)

When using profile weights, fgComputeEdgeWeights expects the first non-internal block to have profile weight.
Make sure we don't break that invariant when removing an empty block.

This fixes VSO 546031.

6 years agoFix handling of return code for system() calls (#16225)
Jan Kotas [Tue, 6 Feb 2018 19:11:47 +0000 (11:11 -0800)]
Fix handling of return code for system() calls (#16225)

The value returned from system() is encoded bag of bits that gets
misinterpretted once it starts propagate through the system. Normalize
it to 0/1.

6 years agoEnable Windows ARM32 corefx testing
Bruce Forstall [Thu, 25 Jan 2018 00:27:52 +0000 (16:27 -0800)]
Enable Windows ARM32 corefx testing

We create a flow job for each arm32 corefx mode, e.g.
arm_cross_checked_windows_nt_corefx_jitstress1_flow_prtest. This
depends on a build job that is specific to the stress mode, e.g.
arm_cross_checked_windows_nt_corefx_jitstress1_bld_prtest, which
(on x64) builds CoreCLR, then clones and builds CoreFX using run-corefx-tests.py.
In particular, it only builds the CoreFX tests; it doesn't run them.
Note that because the CoreFX test build embeds the stress mode environment
variables in its generated RunTests.cmd scripts, we need a different
corefx build dependency for each corefx test run; we can't share the
builds. The build script then ZIPs up the CoreFX tests and generated
CoreFX runtime (which will include the coreclr runtime because we built
CoreFX with the `/p:CoreCLROverridePath` argument), and archives these.

The test job, which runs on an arm64 machine, then copies the ZIPed
tests and runtime, unzips them, and runs a batch script to run each
RunTests.cmd file. Note that we don't use any existing mechanism to
run each test (such as msbuild), and I believe the CoreFX msbuild
harness doesn't have any mechanism to just run a previously built set of tests.

There is a very simple test exclusion mechanism: an entire test assembly
can be excluded by putting its name (e.g., System.IO.Ports.Tests), in
a file (e.g., tests\arm\corefx_test_exclusions.txt).

Note that this corefx testing mechanism is only enabled for arm
(aka arm32), not armlb or arm64.

6 years agoReplace comment inadvertently removed
Carol Eidt [Tue, 6 Feb 2018 18:17:16 +0000 (10:17 -0800)]
Replace comment inadvertently removed

6 years agoDisable prefetch instructions for LEGACY_BACKEND
Carol Eidt [Tue, 6 Feb 2018 17:53:00 +0000 (09:53 -0800)]
Disable prefetch instructions for LEGACY_BACKEND

6 years agoMove String.Manipulation.cs to shared (#16226)
Jan Kotas [Tue, 6 Feb 2018 08:22:13 +0000 (00:22 -0800)]
Move String.Manipulation.cs to shared (#16226)

6 years agoImplement SSE2 Store* intrinsics
Fei Peng [Tue, 6 Feb 2018 07:15:12 +0000 (23:15 -0800)]
Implement SSE2 Store* intrinsics

6 years agoImplement AVX Store* intrinsics
Fei Peng [Tue, 6 Feb 2018 06:25:07 +0000 (22:25 -0800)]
Implement AVX Store* intrinsics

6 years agoAdding tests for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.
Tanner Gooding [Sat, 3 Feb 2018 17:30:11 +0000 (09:30 -0800)]
Adding tests for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.

6 years agoAdding support for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.
Tanner Gooding [Sat, 3 Feb 2018 17:28:56 +0000 (09:28 -0800)]
Adding support for the StoreFence/Prefetch* APIs and the new Sse scalar overloads.

6 years agoReimplement string.Replace in managed code (#16214)
Jan Kotas [Tue, 6 Feb 2018 05:24:50 +0000 (21:24 -0800)]
Reimplement string.Replace in managed code (#16214)

6 years agoRemoving the Sse2.LoadScalarVector128 overloads that are invalid.
Tanner Gooding [Tue, 6 Feb 2018 00:45:46 +0000 (16:45 -0800)]
Removing the Sse2.LoadScalarVector128 overloads that are invalid.

6 years agoImplementation of GetFullPath(string path, string basePath) (#15579)
Anirudh Agnihotry [Tue, 6 Feb 2018 01:39:37 +0000 (17:39 -0800)]
Implementation of GetFullPath(string path, string basePath) (#15579)

GetFullPathAPI Overload

6 years agoMoving a number of the Sse2 hwintrinsic tests to use the test template.
Tanner Gooding [Sat, 3 Feb 2018 22:32:27 +0000 (14:32 -0800)]
Moving a number of the Sse2 hwintrinsic tests to use the test template.

6 years agoAdding tests for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector12...
Tanner Gooding [Sat, 3 Feb 2018 18:06:54 +0000 (10:06 -0800)]
Adding tests for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector128 intrinsics.

6 years agoAdding support for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector...
Tanner Gooding [Sat, 3 Feb 2018 17:53:54 +0000 (09:53 -0800)]
Adding support for the SSE2 LoadVector128, LoadAlignedVector128, and LoadScalarVector128 intrinsics.

6 years agoRemove FEATURE_ACTIVITYSAMPLING and associated code. (#16185)
Brian Robbins [Tue, 6 Feb 2018 00:15:55 +0000 (16:15 -0800)]
Remove FEATURE_ACTIVITYSAMPLING and associated code. (#16185)

6 years agoMerge pull request #16218 from briansull/revert-15910
Brian Sullivan [Mon, 5 Feb 2018 23:08:55 +0000 (15:08 -0800)]
Merge pull request #16218 from briansull/revert-15910

Revert #15910 [R2R] add a virtualStubParamInfo as an argument

6 years agoRevert #15910 [R2R] add a virtualStubParamInfo as an argument
Brian Sullivan [Mon, 5 Feb 2018 21:36:31 +0000 (13:36 -0800)]
Revert #15910 [R2R] add a virtualStubParamInfo as an argument

6 years agofix the Incorrect EventPipe Assert, fixes #16158
Adam Sitnik [Mon, 5 Feb 2018 20:57:33 +0000 (21:57 +0100)]
fix the Incorrect EventPipe Assert, fixes #16158

6 years agoAdded a factory to FileStreamCompletionSource (#16190)
David Fowler [Mon, 5 Feb 2018 20:52:08 +0000 (12:52 -0800)]
Added a factory to FileStreamCompletionSource (#16190)

* Merged FileStreamCompletionSource and MemoryCompletionSource
- Change FileStreamCompletionSource to take a ReadOnlyMemory<byte> instead of byte[]
- Delegate to memory.Retain if the underlying ReadOnlyMemory<byte> is backed by an array that isn't the stream's internal buffer.

* Brought back MemoryFileStreamCompletionSource
- Added a factory method to FileStreamCompletionSource that
picks the an impl or FileStreamCompletionSource or MemoryFileStreamCompletionSource based on the buffer matching the underlying stream's internal buffer.

* PR feedback
- Cleanup the condition
- Flip to Debug.Assert in FileStreamCompletionSource

* Check for null before using the PreAllocatedOverlapped

6 years agoMerge pull request #16103 from mikedn/xorps
Brian Sullivan [Mon, 5 Feb 2018 18:00:36 +0000 (10:00 -0800)]
Merge pull request #16103 from mikedn/xorps

Use xorps instead of xorpd

6 years agoUpdate CoreClr to preview2-26205-05 (#16205)
dotnet-maestro-bot [Mon, 5 Feb 2018 16:22:11 +0000 (10:22 -0600)]
Update CoreClr to preview2-26205-05 (#16205)

6 years agoUse stackalloc in string.Split (#15435)
Alex [Mon, 5 Feb 2018 04:17:03 +0000 (06:17 +0200)]
Use stackalloc in string.Split (#15435)

* Use stackalloc in string.Split

* Added initial usage of ValueListBuilder

* Added usage of list builder to string separator Split overloads

6 years agoMerge pull request #16199 from dotnet/revert-15944-CorefxTestUseCorrectVersion
Jan Kotas [Sun, 4 Feb 2018 22:34:11 +0000 (14:34 -0800)]
Merge pull request #16199 from dotnet/revert-15944-CorefxTestUseCorrectVersion

Revert "For corefx testing, use a matching corefx repo version git hash"

6 years agoRevert "For corefx testing, use a matching corefx repo version git hash"
Jan Kotas [Sun, 4 Feb 2018 19:08:05 +0000 (11:08 -0800)]
Revert "For corefx testing, use a matching corefx repo version git hash"

6 years agoUpdate CoreClr to preview2-26204-05 (#16191)
dotnet-maestro-bot [Sun, 4 Feb 2018 18:21:46 +0000 (12:21 -0600)]
Update CoreClr to preview2-26204-05 (#16191)

6 years agoMerge pull request #16182 from CarolEidt/FixDD543057
Carol Eidt [Sun, 4 Feb 2018 15:23:01 +0000 (07:23 -0800)]
Merge pull request #16182 from CarolEidt/FixDD543057

Consider specialPutArgs for jitStressRegs

6 years agoFix failfast stacktrace (#15895)
Sung Yoon Whang [Sat, 3 Feb 2018 23:58:22 +0000 (15:58 -0800)]
Fix failfast stacktrace (#15895)

* attempt to fix stacktrace getting printed twice

* Fix some default parameter issues, and wrong commit from last commit

* Fix build errors, switch call from Debug.Assert to new FailFast FCall

* Fix signature to allow more types of exception title

* cleanup

* Addressing comments from PR

* More PR comments

* remove useless using

* Address comments on GC hole and few naming changes

6 years agoJitBench harness improvements (#15151)
Noah Falk [Sat, 3 Feb 2018 23:03:30 +0000 (15:03 -0800)]
JitBench harness improvements (#15151)

* Improvements to JitBench perf test

1) More of the scenario setup is delegated to the scripts in the JitBench repo. The run now consists of (a) acquire source (b) RunBenchmark.ps1 -SetupOnly (c) run dotnet MusicStore.dll over and over to get measurements.
2) A specific last known good framework version is used instead of an open-ended latest version. This should make the test more reliable day-to-day at the cost that we have to bump the version when breaking changes occur.
3) Added an option to test with a local copy of JitBench instead of acquiring one from github. This is useful to for testing simultaneous changes in both repos.
4) Updated the output parsing to account for the changes I made in MusicStore's console spew.

* Code review feedback

* Don't use precompiled views by default

In order to match the previous benchmark results we should avoid
using precompiled views.

* Fixed JitBench local repo issue

In my earlier change I accidentally broke the normal scenario when you do not use a local copy of JitBench repo. This case was failing with an exception in SetupStatics because the null directory didn't exist.

6 years agoUpdating the templated x86 hwintrinsic tests to validate Load and LoadAligned
Tanner Gooding [Sat, 3 Feb 2018 08:13:27 +0000 (00:13 -0800)]
Updating the templated x86 hwintrinsic tests to validate Load and LoadAligned

6 years agoUpdating the HWIntrinsic codegen to support marking LoadVector128 and LoadAlignedVect...
Tanner Gooding [Tue, 30 Jan 2018 05:20:08 +0000 (21:20 -0800)]
Updating the HWIntrinsic codegen to support marking LoadVector128 and LoadAlignedVector128 as contained.

6 years agoRemove AsyncMethodBuilder from shared partition (#16149)
Ben Adams [Sat, 3 Feb 2018 05:29:30 +0000 (05:29 +0000)]
Remove AsyncMethodBuilder from shared partition (#16149)

* Remove AsyncMethodBuilder from shared partition

* AsyncMethodBuilder => AsyncMethodBuilderCore

6 years agoChanging Span/Memory to return default on null instead of throwing. (#16186)
Ahson Khan [Sat, 3 Feb 2018 03:30:25 +0000 (19:30 -0800)]
Changing Span/Memory to return default on null instead of throwing. (#16186)

* Additional changes based on feedback (bounds checks)

* Adding remaining bounds checks

6 years agoUpdate BuildTools, CoreClr, CoreFx to preview2-02502-01, preview2-26203-01, preview2...
dotnet-maestro-bot [Sat, 3 Feb 2018 03:27:20 +0000 (21:27 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02502-01, preview2-26203-01, preview2-26202-05, respectively (#16180)

6 years agoDictionary exposes internal type comparer (#16151)
Marco Rossignoli [Sat, 3 Feb 2018 03:08:43 +0000 (04:08 +0100)]
Dictionary exposes internal type comparer (#16151)

Fixes dotnet/corefx#26033

6 years agoDelete unused SSA_FEATURE_USEDEF ifdefs (#15654)
mikedn [Sat, 3 Feb 2018 02:58:33 +0000 (04:58 +0200)]
Delete unused SSA_FEATURE_USEDEF ifdefs (#15654)