Yu Watanabe [Wed, 19 Jun 2019 13:03:42 +0000 (22:03 +0900)]
table: introduce FORMAT_BPS type
Yu Watanabe [Wed, 19 Jun 2019 00:52:45 +0000 (09:52 +0900)]
test: add tests for format_bytes()
Yu Watanabe [Wed, 19 Jun 2019 01:05:30 +0000 (10:05 +0900)]
util: make format_bytes() support e.g. 3.0E
Yu Watanabe [Mon, 17 Jun 2019 07:08:24 +0000 (16:08 +0900)]
util: introduce format_bytes_full()
And move it into format-util.c.
Yu Watanabe [Mon, 17 Jun 2019 06:31:20 +0000 (15:31 +0900)]
ethtool-util: introduce ethtool_get_link_info()
Will be used in later commits.
Yu Watanabe [Wed, 19 Jun 2019 00:09:58 +0000 (09:09 +0900)]
ethtool-util: make ethtool_connect() warn on failure
Yu Watanabe [Mon, 17 Jun 2019 05:57:54 +0000 (14:57 +0900)]
ethtool-util: use structured initializers
Yu Watanabe [Mon, 17 Jun 2019 05:52:55 +0000 (14:52 +0900)]
ethtool-util: move from src/udev/net/ to src/shared/
Lennart Poettering [Tue, 18 Jun 2019 13:56:07 +0000 (15:56 +0200)]
journald: use memdup_suffix0() when copying string from potentially binary data
Fixes: #12484
Markus Felten [Tue, 18 Jun 2019 08:11:28 +0000 (10:11 +0200)]
fix(journal-gatewayd): use relative urls (not starting with '/')
if journal-gatewayd http is not mounted at '/' (proxy request)
the request lose their initial path component
Frantisek Sumsal [Tue, 18 Jun 2019 09:25:16 +0000 (11:25 +0200)]
hashmap: avoid using TLS in a destructor
Using C11 thread-local storage in destructors causes uninitialized
read. Let's avoid that using a direct comparison instead of using
the cached values. As this code path is taken only when compiled
with -DVALGRIND=1, the performance cost shouldn't matter too much.
Fixes #12814
Lennart Poettering [Tue, 18 Jun 2019 11:17:14 +0000 (13:17 +0200)]
Merge pull request #12758 from fbuihuu/nspawn-console-tty
Create nspawn console tty in the child
Yu Watanabe [Tue, 18 Jun 2019 02:18:46 +0000 (11:18 +0900)]
dhcp: fix comparison with previous lease
Follow-up for
f8862395e8f802e4106a07ceaaf02b6a1faa5a6d.
Fixes #12816.
Franck Bui [Fri, 7 Jun 2019 08:27:18 +0000 (10:27 +0200)]
nspawn: make use of openpt_allocate()
Franck Bui [Fri, 7 Jun 2019 08:17:11 +0000 (10:17 +0200)]
terminal-util: introduce openpt_allocate()
Allocating a pty is done in a couple of places so let's introduce a new helper
which does the job.
Also the new function, as well as openpt_in_namespace(), returns both pty
master and slave so the callers don't need to know about the pty slave
allocation details.
For the same reasons machine_openpt() prototype has also been changed to return
both pty master and slave so callers don't need to allocate a pty slave which
might be in a different namespace.
Finally openpt_in_namespace() has been renamed into
openpt_allocate_in_namespace().
Zbigniew Jędrzejewski-Szmek [Tue, 18 Jun 2019 06:57:26 +0000 (08:57 +0200)]
Merge pull request #12805 from yuwata/test-network-cleanups
test: further test-network cleanups
Franck Bui [Thu, 6 Jun 2019 08:05:33 +0000 (10:05 +0200)]
nspawn: allocate the pty used for /dev/console within the container
The console tty is now allocated from within the container so it's not
necessary anymore to allocate it from the host and bind mount the pty slave
into the container. The pty master is sent to the host.
/dev/console is now a symlink pointing to the pty slave.
This might also be less confusing for applications running inside the container
and the overall result looks cleaner (we don't need to apply manually the
passed selinux context, if any, to the allocated pty for instance).
Franck Bui [Thu, 6 Jun 2019 13:58:14 +0000 (15:58 +0200)]
nspawn: use correct error variable when logging errors returned by send_one_fd()
Franck Bui [Fri, 7 Jun 2019 05:36:11 +0000 (07:36 +0200)]
namespace-util: make use of TAKE_FD()
No functional changes.
Franck Bui [Thu, 6 Jun 2019 12:05:27 +0000 (14:05 +0200)]
fs-util: no need for fchmod_and_chown() to access /proc/self/fd directly
fstat(2) is fine with O_PATH fds.
For changing owership of a file opened with O_PATH, there's fchownat(2).
Only changing permissions is problematic but we introduced fchmod_opath() for
that purpose.
Yu Watanabe [Mon, 17 Jun 2019 02:21:45 +0000 (11:21 +0900)]
test-network: change default sleep time of start_networkd()
Yu Watanabe [Mon, 17 Jun 2019 02:06:01 +0000 (11:06 +0900)]
test-network: use wait-online in NetworkdBridgeTests
Yu Watanabe [Tue, 18 Jun 2019 04:09:06 +0000 (13:09 +0900)]
network: do not configure routing policy rule if it is already configured
Yu Watanabe [Tue, 18 Jun 2019 04:08:20 +0000 (13:08 +0900)]
network: make routing_policy_rule_get() require Manager
Yu Watanabe [Mon, 17 Jun 2019 01:52:16 +0000 (10:52 +0900)]
test-network: use wait-online in NetworkdBondTests
Yu Watanabe [Mon, 17 Jun 2019 02:09:25 +0000 (11:09 +0900)]
test-network: use setUp() and tearDown() to clear routing policy rule tables
Yu Watanabe [Tue, 18 Jun 2019 03:02:41 +0000 (12:02 +0900)]
Merge pull request #12807 from keszybz/net-naming-scheme-yet-again
Extend naming scheme to mac address policy and introduce NAMING_STABLE_VIRTUAL_MACS
Yu Watanabe [Mon, 17 Jun 2019 02:11:30 +0000 (11:11 +0900)]
test-network: rename l2tp_tunnel_remove -> remove_l2tp_tunnels
Yu Watanabe [Mon, 17 Jun 2019 10:57:54 +0000 (19:57 +0900)]
test-network: remove all routing policy rules in specified table
Jan Pokorný [Mon, 17 Jun 2019 18:49:28 +0000 (20:49 +0200)]
docs: CGROUP_DELEGATION: fix a typo in "that"
Evgeny Vereshchagin [Mon, 17 Jun 2019 17:08:48 +0000 (19:08 +0200)]
travis: turn on all default UBSan checks except for pointer-overflow, object-size and float-cast-overflow
Lennart Poettering [Mon, 17 Jun 2019 08:51:25 +0000 (10:51 +0200)]
core: set fs.file-max sysctl to LONG_MAX rather than ULONG_MAX
Since kernel 5.2 the kernel thankfully returns proper errors when we
write a value out of range to the sysctl. Which however breaks writing
ULONG_MAX to request the maximum value. Hence let's write the new
maximum value instead, LONG_MAX.
/cc @brauner
Fixes: #12803
Lennart Poettering [Mon, 17 Jun 2019 12:54:18 +0000 (14:54 +0200)]
Merge pull request #12810 from evverx/nonnull-attribute
travis: turn on nonnull-attribute on Fuzzit
Zbigniew Jędrzejewski-Szmek [Mon, 17 Jun 2019 07:42:46 +0000 (09:42 +0200)]
udev: introduce NAMING_STABLE_VIRTUAL_MACS (retroactively)
This is for
6d3646406560. It turns out that this is causing more problems than
expected. Let's retroactively introduce naming scheme v241 to conditionalize
this change.
Follow-up for #12792 and
6d36464065601f7. See also
https://bugzilla.suse.com/show_bug.cgi?id=1136600.
$ SYSTEMD_LOG_LEVEL=debug NET_NAMING_SCHEME=v240 build/udevadm test-builtin net_setup_link /sys/class/net/br11
$ SYSTEMD_LOG_LEVEL=debug NET_NAMING_SCHEME=v241 build/udevadm test-builtin net_setup_link /sys/class/net/br11
...
@@ -20,11 +20,13 @@
link_config: could not set ethtool features for br11
Could not set offload features of br11: Operation not permitted
br11: Device has name_assign_type=3
-Using interface naming scheme 'v240'.
+Using interface naming scheme 'v241'.
br11: Policy *keep*: keeping existing userspace name
br11: Device has addr_assign_type=1
-br11: No stable identifying information found
-br11: Could not generate persistent MAC: No data available
+br11: Using "br11" as stable identifying information
+br11: Using generated persistent MAC address
+Could not set Alias=, MACAddress= or MTU= on br11: Operation not permitted
+br11: Could not apply link config, ignoring: Operation not permitted
Unload module index
Unloaded link configuration context.
ID_NET_DRIVER=bridge
Zbigniew Jędrzejewski-Szmek [Mon, 17 Jun 2019 11:38:40 +0000 (13:38 +0200)]
libsystemd-network: rename net_get_name() to net_get_name_persistent()
This reflect its role better.
(I didn't use …_persistent_name(), because which name is actually used
depends on the policy. So it's better not to make this sound like it returns
*the* persistent name.)
Zbigniew Jędrzejewski-Szmek [Mon, 17 Jun 2019 07:21:57 +0000 (09:21 +0200)]
man: clean up naming scheme description a bit
This is in preparation for later changes. Let's change the documentation of
net.naming-scheme= to also say that it applies to MAC addresses. This commit
doesn't actually implement that though.
Lennart Poettering [Mon, 17 Jun 2019 09:31:06 +0000 (11:31 +0200)]
sleep: properly pass verb to sleep script
Another fall-out from our rewriting of argv[] now.
Fixes: #12782
Evgeny Vereshchagin [Mon, 17 Jun 2019 10:49:07 +0000 (12:49 +0200)]
fuzzit: sort UBSan checks alphabetically
to make it easier to make sense of them
Yu Watanabe [Mon, 17 Jun 2019 01:22:54 +0000 (10:22 +0900)]
meson: fix error message
Yu Watanabe [Mon, 17 Jun 2019 01:19:50 +0000 (10:19 +0900)]
Merge pull request #12802 from irtimmer/fix-openssl
resolved: fix DNS-over-TLS when using OpenSSL
Evgeny Vereshchagin [Sat, 15 Jun 2019 21:12:24 +0000 (23:12 +0200)]
travis: turn on nonnull-attribute on Fuzzit
Iwan Timmer [Sat, 15 Jun 2019 20:05:00 +0000 (22:05 +0200)]
resolved: make no changes to OpenSSL BUF_MEM struct
Fix crash when using OpenSSL 1.1.1c
Fixes: #12763
Iwan Timmer [Sat, 15 Jun 2019 19:56:45 +0000 (21:56 +0200)]
Revert "resolved: Fix incorrect use of OpenSSL BUF_MEM"
This reverts commit
18bddeaaf225d5becfc10cd2c6a1d037c90574a2.
Revert this because it does not take the OpenSSL internal read pointer
into considoration. Resulting in padding in packetdata and therefore
broken SSL connections.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Jun 2019 15:50:37 +0000 (17:50 +0200)]
Merge pull request #12753 from jrouleau/fix/hibernate-resume-timeout
hibernate-resume: fix resume device timeout
Yu Watanabe [Fri, 14 Jun 2019 00:42:51 +0000 (09:42 +0900)]
network: read link specific sysctl value
This introduce link_sysctl_ipv6_enabled() and replaces
manager_sysctl_ipv6_enabled() with it.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Jun 2019 12:53:04 +0000 (14:53 +0200)]
Merge pull request #12796 from yuwata/test-network-use-wait-online
test-network: several cleanups
Zbigniew Jędrzejewski-Szmek [Sat, 15 Jun 2019 12:50:41 +0000 (14:50 +0200)]
Merge pull request #12794 from yuwata/network-configure-without-carrier
network: skip to check dynamic addresses when ConfigureWithoutCarrier=yes
Evgeny Vereshchagin [Sat, 15 Jun 2019 03:46:38 +0000 (06:46 +0300)]
Merge pull request #12761 from evverx/try-fuzzit
Turn on UBSan on Fuzzit
Evgeny Vereshchagin [Sat, 15 Jun 2019 00:07:17 +0000 (02:07 +0200)]
travis: add more ASan options
Evgeny Vereshchagin [Fri, 14 Jun 2019 23:16:07 +0000 (01:16 +0200)]
travis: clean up bash variables a bit
in preparation for adding more ASan options
Evgeny Vereshchagin [Fri, 14 Jun 2019 22:44:27 +0000 (00:44 +0200)]
travis: use UBSan checks from OSS-Fuzz
This should help to silence UBSan reports mentioned in
https://github.com/systemd/systemd/pull/12771#issuecomment-
502139157
for now.
Evgeny Vereshchagin [Fri, 14 Jun 2019 22:09:15 +0000 (00:09 +0200)]
travis: turn on UBSan on Fuzzit
Evgeny Vereshchagin [Fri, 14 Jun 2019 20:28:56 +0000 (23:28 +0300)]
Merge pull request #12799 from evverx/fuzzit-follow-up
travis: run Coverity after Fuzzit-Fuzzing
Evgeny Vereshchagin [Fri, 14 Jun 2019 19:47:31 +0000 (21:47 +0200)]
travis: add 5 more fuzz targets
Evgeny Vereshchagin [Fri, 14 Jun 2019 19:16:41 +0000 (21:16 +0200)]
travis: always run the "Build & test" stage first
Now that the other stages are explicitly listed in the "stages"
section, we should include "Built & test" there to make sure
it's run first.
Evgeny Vereshchagin [Fri, 14 Jun 2019 18:56:10 +0000 (20:56 +0200)]
travis: skip the Fuzzit-Sanity stage when it's run by cron
Evgeny Vereshchagin [Fri, 14 Jun 2019 18:42:19 +0000 (20:42 +0200)]
travis: run Coverity after Fuzzit-Fuzzing
Coverity is unpredictable and, according to a notification I received
yeserday, it will be upgraded on June 17. During the upgrade
it might be offline for 3 days, af far as I understand. Anyway, Travis
stops as soon as a stage fails so it makes sense to put stages that
are likely to fail at the end so that the others have a chance to
do what they are supposed to do.
https://community.synopsys.com/s/topic/0TO2H0000001CN7WAM/coverity-scan-status
Jeka Pats [Tue, 11 Jun 2019 06:25:45 +0000 (09:25 +0300)]
Continuous Fuzzing Integration with Fuzzit
includes two travis ci steps:
1) Every pull-request/push all fuzzing targets will do a quick
sanity run on the generated corpus and crashes (via Fuzzit)
2) On a daily basis the fuzzing targets will be compiled (from
master) and will and their respectible fuzzing job on Fuzzit
will be updated to the new binary.
Yu Watanabe [Fri, 14 Jun 2019 14:15:55 +0000 (23:15 +0900)]
NEWS: add more hint about MACAddressPolicy= change
C.f. https://bugzilla.suse.com/show_bug.cgi?id=1136600
Yu Watanabe [Fri, 14 Jun 2019 07:50:07 +0000 (16:50 +0900)]
test-network: drop redundant operstate checking
Yu Watanabe [Fri, 14 Jun 2019 07:49:39 +0000 (16:49 +0900)]
test-network: replace check_link_exists() with wait_online()
Yu Watanabe [Fri, 14 Jun 2019 07:47:06 +0000 (16:47 +0900)]
test-network: explicitly set sleep time
Yu Watanabe [Fri, 14 Jun 2019 07:45:50 +0000 (16:45 +0900)]
test-network: suppress error message in cleanup process
Yu Watanabe [Thu, 13 Jun 2019 20:25:00 +0000 (05:25 +0900)]
test-network: add test for ConfigureWithoutCarrier=
Yu Watanabe [Thu, 13 Jun 2019 20:16:11 +0000 (05:16 +0900)]
network: skip to check dynamic addresses when ConfigureWithoutCarrier=yes
Otherwise, the interface cannot be in "configured" state, as ipv6 link local
addressing is enabled by default. Note that even if ConfigureWithoutCarrier=
is set, all dynamic configurations are checked when the interface has
carrier.
Arian van Putten [Wed, 12 Jun 2019 17:18:04 +0000 (19:18 +0200)]
Document that gpt-auto-generator supports decrypting rootfs
When systemd is running in initrd, we actually support decrypting a LUKS rootfs.
Fixes #12786
Yu Watanabe [Thu, 13 Jun 2019 04:27:42 +0000 (13:27 +0900)]
networkctl: fix use of uninitialized value
Yu Watanabe [Wed, 12 Jun 2019 22:45:01 +0000 (07:45 +0900)]
Merge pull request #12777 from yuwata/libudev-enumerate-issue-12776
libudev: rescan devices when filter is updated
Frantisek Sumsal [Wed, 12 Jun 2019 17:52:48 +0000 (17:52 +0000)]
Merge pull request #12783 from keszybz/a-few-unrelated-fixes
A few unrelated fixes
Zbigniew Jędrzejewski-Szmek [Wed, 12 Jun 2019 15:24:22 +0000 (17:24 +0200)]
journal: also disable memory tricks when hashing under msan
Might help with #11738.
Zbigniew Jędrzejewski-Szmek [Wed, 12 Jun 2019 15:23:32 +0000 (17:23 +0200)]
test-bus-marshall: add a hopefully helpful comment
Zbigniew Jędrzejewski-Szmek [Tue, 11 Jun 2019 06:52:42 +0000 (08:52 +0200)]
zsh: add completion for systemctl preset-all
Zbigniew Jędrzejewski-Szmek [Fri, 7 Jun 2019 09:49:03 +0000 (11:49 +0200)]
system-update-generator: do not emit bogus warning if no /system-update symlink
We only need to check for the kernel cmdline override our symlink is there.
Yu Watanabe [Wed, 12 Jun 2019 06:15:06 +0000 (15:15 +0900)]
libudev: hide definition of struct udev_device
Yu Watanabe [Wed, 12 Jun 2019 02:10:52 +0000 (11:10 +0900)]
libudev: rescan devices when filter is updated
Fixes #12776.
Yu Watanabe [Wed, 12 Jun 2019 06:06:24 +0000 (15:06 +0900)]
libudev: re-implement libudev-list with LIST and hashmap
Yu Watanabe [Wed, 12 Jun 2019 04:03:19 +0000 (13:03 +0900)]
libudev: hide definition of struct udev_list from other libudev components
In the later commit, udev_list will be just a wrapper of hashmap or LIST.
So, allocating udev_list does not increase much cost.
Zbigniew Jędrzejewski-Szmek [Wed, 12 Jun 2019 12:28:09 +0000 (14:28 +0200)]
Merge pull request #12424 from poettering/logind-brightness
logind: add SetBrightness() bus call as minimal API for setting "leds" and "backlight" kernel class device brightness
Zbigniew Jędrzejewski-Szmek [Wed, 12 Jun 2019 12:20:32 +0000 (14:20 +0200)]
Merge pull request #12779 from pwithnall/minor-fixes
Minor fixes
Philip Withnall [Wed, 12 Jun 2019 07:24:45 +0000 (08:24 +0100)]
service: Fix typo in warning message
The directive is `RuntimeMaxSec=`, not `MaxRuntimeSec=`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Philip Withnall [Wed, 12 Jun 2019 08:43:47 +0000 (09:43 +0100)]
pam_systemd: Fix some option names in error messages
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Philip Withnall [Wed, 12 Jun 2019 08:08:53 +0000 (09:08 +0100)]
man: Add missing <literal> tags in various man pages
A minor formatting improvement brought to you by the wonders of `git
grep`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Philip Withnall [Wed, 12 Jun 2019 07:03:35 +0000 (08:03 +0100)]
man: Fix typo in sd_notify man page
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Yu Watanabe [Wed, 12 Jun 2019 03:30:05 +0000 (12:30 +0900)]
libudev: drop unused variable
Yu Watanabe [Wed, 12 Jun 2019 05:46:00 +0000 (14:46 +0900)]
Merge pull request #12774 from yuwata/network-ignore-ipv6-settings-when-sysctl-disable-ipv6
network: ignore ipv6 settings when sysctl disable ipv6
Tomas Mraz [Tue, 11 Jun 2019 13:10:21 +0000 (15:10 +0200)]
resolved: Fix incorrect use of OpenSSL BUF_MEM
Fixes: #12763
Yu Watanabe [Wed, 12 Jun 2019 02:01:32 +0000 (11:01 +0900)]
test-network: add more test cases when ipv6 is disabled
Yu Watanabe [Tue, 11 Jun 2019 14:33:22 +0000 (23:33 +0900)]
network: ignore requested ipv6 fdb entry when ipv6 is disabled by sysctl
Yu Watanabe [Tue, 11 Jun 2019 14:29:57 +0000 (23:29 +0900)]
network: ignore requested ipv6 routing policy rule when ipv6 is disabled by sysctl
Yu Watanabe [Tue, 11 Jun 2019 14:26:11 +0000 (23:26 +0900)]
network: ignore requested ipv6 route when ipv6 is disabled by sysctl
Yu Watanabe [Tue, 11 Jun 2019 14:20:56 +0000 (23:20 +0900)]
network: ignore requested ipv6 addresses when ipv6 is disabled by sysctl
Peter A. Bigot [Sun, 9 Jun 2019 17:15:09 +0000 (12:15 -0500)]
man: fix reference to sd_bus_add_fallback_vtable
Zbigniew Jędrzejewski-Szmek [Tue, 11 Jun 2019 07:52:26 +0000 (09:52 +0200)]
Merge pull request #12685 from yuwata/network-dhcp-assign-adn-remove-12676
network: assign new DHCP address before removing old lease address
Karel Zak [Mon, 10 Jun 2019 13:18:47 +0000 (15:18 +0200)]
systemd-mount: don't check for non-normalized WHAT for network FS
The WHAT string could be whatever for many filesystems. The common
example are network filesystems.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1708996
Theo Ouzhinski [Sat, 8 Jun 2019 21:43:59 +0000 (17:43 -0400)]
man/systemd-veritysetup-generator: Fix grammar
Yu Watanabe [Fri, 7 Jun 2019 06:31:07 +0000 (15:31 +0900)]
network: assign new DHCP address before removing old lease address
Closes #12676.
Yu Watanabe [Fri, 7 Jun 2019 06:04:11 +0000 (15:04 +0900)]
network: ignore callback calls when link is in failed state
Yu Watanabe [Fri, 7 Jun 2019 05:28:09 +0000 (14:28 +0900)]
network: drop unnecessary link_enter_failed() calls
As the function called soon later anyway.
Yu Watanabe [Fri, 7 Jun 2019 05:22:13 +0000 (14:22 +0900)]
network: check earlier the existence of lifetime in lease
Yu Watanabe [Fri, 7 Jun 2019 05:18:55 +0000 (14:18 +0900)]
network: make all failures in route configuration fatal