platform/upstream/efl.git
4 years agoci: travis: stop osx builds until build failures are solved on Travis
Stefan Schmidt [Fri, 6 Mar 2020 11:01:46 +0000 (12:01 +0100)]
ci: travis: stop osx builds until build failures are solved on Travis

This looks like problems on the TravisCI side, but this is going on for
to long. Stop osx builds to have our on CI in a sane state again.

4 years agoelc_naviframe: fix to delete item once by elm_object_item_del in pop_cb
Jaehyun Cho [Fri, 6 Mar 2020 04:25:04 +0000 (13:25 +0900)]
elc_naviframe: fix to delete item once by elm_object_item_del in pop_cb

If elm_object_item_del is called in pop_cb and pop_cb returns
EINA_FALSE, then the given item is destructed by _item_noref when
efl_unref is called after pop_cb.

After the above destruction, efl_del is called after the above efl_unref
and it deletes the item again.

Not to delete item after the item is destructed, efl_del after pop_cb is
removed.

4 years agoelm_code: Avoid moving to non-existent line.
Alastair Poole [Fri, 6 Mar 2020 01:23:35 +0000 (01:23 +0000)]
elm_code: Avoid moving to non-existent line.

Check for line existence before moving cursor.

4 years agoevas: Fix dereferenceing null pointer
Christopher Michael [Wed, 4 Mar 2020 19:20:47 +0000 (14:20 -0500)]
evas: Fix dereferenceing null pointer

Coverity reports a forward null here. If we do not get obj from
efl_data_scope_get then we should return. Also fixes some formatting

Fixes CID1420216

4 years agoevas: Fix mouse event info for legacy events.
Hosang Kim [Wed, 4 Mar 2020 14:35:30 +0000 (09:35 -0500)]
evas: Fix mouse event info for legacy events.

Summary:
Legacy event info have canvas and output coordinates.
Output coordinates have information of original position.
Canvas coordinates have information of transformed position.
So keep backward compatibility, fix filling legacy information.

This reverts commit 7f724f6c5db1127a6dd5786791f495b58910e9a9

Reviewers: Hermet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11445

4 years agoelm_code: Improve efficiency of the widget.
Alastair Poole [Wed, 4 Mar 2020 01:41:43 +0000 (01:41 +0000)]
elm_code: Improve efficiency of the widget.

For now, only create textgrids when needed. Also improve other
regions of the widget. This will improve large file support and
also some rendering of the widget.

This improves performance 1-2 times. However, there must be a
reasonable redesign regarding the current use of textgrids.

4 years agoedje: Change the order of Edje_Action_Type enum members 82/227082/1
JunsuChoi [Mon, 9 Mar 2020 11:01:33 +0000 (20:01 +0900)]
edje: Change the order of Edje_Action_Type enum members

The tizen version of tizen studio has not been updated yet,
so we should keep EDJE_ACTION_TYPE_RUN_PLUGIN equal to 25.

@tizen_only

Change-Id: I4233471f830569b04c1df1723d7e06013131e1df

4 years agoEcore_Wl2: Fix doc. 64/227064/2
Woochanlee [Mon, 9 Mar 2020 09:31:45 +0000 (18:31 +0900)]
Ecore_Wl2: Fix doc.

Add @brief.
Modify some of the doc.
Delete wrong indexing.

Change-Id: I6fd79fbaa3603977fbe1b87484f8f7939f02fae1

4 years agoEfl.Ui.Image: Modify current frame to start at 1 61/227061/1
JunsuChoi [Mon, 9 Mar 2020 08:54:33 +0000 (17:54 +0900)]
Efl.Ui.Image: Modify current frame to start at 1

Summary:
3dc3deb patch was changed to start at 1 rather than 0.
gif image starts at 1, not 0.

Test Plan: N/A

Reviewers: Hermet, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11474

Change-Id: I28140bcf343b24a039f3b83fccead03099c3edc4

4 years agoEcore_Wl2: Introduce ecore_wl2_window_native_surface_get API. 25/227025/2 submit/tizen/20200309.064055
Woochanlee [Mon, 9 Mar 2020 06:18:50 +0000 (15:18 +0900)]
Ecore_Wl2: Introduce ecore_wl2_window_native_surface_get API.

This API to support some apps may using native surface handle.

@tizen_only

Change-Id: Ica07a97dfe75d226e8a6dbec2dd7230002dadc00

4 years agoefl_wl: Prevent a null pointer dereference. 14/227014/1
Woochanlee [Mon, 9 Mar 2020 05:34:56 +0000 (14:34 +0900)]
efl_wl: Prevent a null pointer dereference.

Change-Id: Ie11cdc246e2551864ca8ab6e0ab7cba3b9bef96c
CID:1133579

4 years agoelc_naviframe: fix to delete item once by elm_object_item_del in pop_cb 00/227000/1
Jaehyun Cho [Fri, 6 Mar 2020 04:25:04 +0000 (13:25 +0900)]
elc_naviframe: fix to delete item once by elm_object_item_del in pop_cb

If elm_object_item_del is called in pop_cb and pop_cb returns
EINA_FALSE, then the given item is destructed by _item_noref when
efl_unref is called after pop_cb.

After the above destruction, efl_del is called after the above efl_unref
and it deletes the item again.

Not to delete item after the item is destructed, efl_del after pop_cb is
removed.

Change-Id: Icc3716e543d8f017f054bac62c2b24809b76e8da

4 years agoecore_ipc: remove efl_loop_fd_set before finishing the unix sockect connection 99/226799/2
Yeongjong Lee [Thu, 5 Mar 2020 10:03:17 +0000 (19:03 +0900)]
ecore_ipc: remove efl_loop_fd_set before finishing the unix sockect connection

For Efl.Net.Dialer_Unix, fd should be set when the socket is finished connecting.

efl_loop_fd_set is called in the `_efl_net_dialer_unix_connected` which is
called at the end of connection thread named `_efl_net_connect_async_end`.
That means we don't need to set fd right after `efl_add(EFL_NET_DIALER_UNIX_CLASS`.

Also, this will fix intermittent efl-test-suite failure related to ecore_evas_extn.

@tizen_fix

Change-Id: I2f884e3de49be109cc945c76f42d22c206e10c1b

4 years agoManual cherry-pick from here, cause of fetch network issue...
Hermet Park [Sun, 8 Mar 2020 11:42:16 +0000 (20:42 +0900)]
Manual cherry-pick from here, cause of fetch network issue...

commit b2bd0c548f03b8178e40e0cfa6e9c31c4bff38b1 (HEAD -> master, origin/master, origin/HEAD)
Author: Hermet Park <chuneon.park@samsung.com>
Date:   Sun Mar 8 20:20:43 2020 +0900

    evas gl: clip rect with proper size.

    gc width/height indicates the main output size,
    if the target surface(fbo) is larger than this, rect won't be drawn.

    We should clip this with current context size.

    @fix

Change-Id: Ida057ce7561b8cfe60b5d3339a7e095bf1a1b94c

4 years agocanvas grid: fix inifinite loop dead.
Hermet Park [Fri, 6 Mar 2020 14:48:43 +0000 (23:48 +0900)]
canvas grid: fix inifinite loop dead.

Here parent smart del() call occurs inifinite loop for member deletion,

Maybe we need a better clean and neat solution here.

Change-Id: I67155aa916243c03306cd82eeb7d58fcb4491703

4 years agoelm/atspi_bridge: fix memory leak 11/226811/5
Kamil Konieczny [Thu, 5 Mar 2020 10:50:23 +0000 (11:50 +0100)]
elm/atspi_bridge: fix memory leak

Fix memory leak in function elm_atspi_bridge_utils_say,
as function _elm_util_mkup_to_text return allocated memory.
This also fixes functional bug in text markup removal from
original text. Also while at this, add error checks.

Change-Id: Ife37a0ae66caf677174bef7bd7f5bc9b633b9357

4 years agoFix the bug of eglSync for EvasGL 45/226645/2 submit/tizen/20200306.082439
Wonsik Jung [Wed, 4 Mar 2020 09:10:01 +0000 (18:10 +0900)]
Fix the bug of eglSync for EvasGL

eglWaitSync is called with the destoried eglSync handle, sometimes.
This patch is for the case.

Change-Id: Iad2f7d5332c4b635d98f7ee72152b4accb773a3c

4 years agoelm_genlist: check viewport height to calculate for item show 01/226801/3 submit/tizen/20200305.112415
Jaehyun Cho [Thu, 5 Mar 2020 09:30:44 +0000 (18:30 +0900)]
elm_genlist: check viewport height to calculate for item show

To show item in the correct position, viewport height should be
calculated correctly.

Since the default height of viewport is 1, correctly calculated viewport
height is bigger than 1.

Therefore, viewport height is checked if it is bigger than 1 to
calculate for item show.

Change-Id: If78db939fa2fb0bcca8be9ffe7e23c297c7852a0

4 years agoRevert "elm/image: restore legacy behavior of elm_image_file_get" 90/226790/3
Bowon Ryu [Thu, 5 Mar 2020 09:38:03 +0000 (18:38 +0900)]
Revert "elm/image: restore legacy behavior of elm_image_file_get"

This reverts commit dec742a9357050bcd29a9eed0e9e49320d9c146d.

This patch returns an absolute path even if user file_set is a relative path.
This causes compatibility issues.

Change-Id: If0304569418f9f00c344d5e8a4a8ae373fc163a8

4 years agoelementary: use array instead of list for subchildren 15/226615/2
Marcel Hollerbach [Mon, 17 Feb 2020 12:56:06 +0000 (13:56 +0100)]
elementary: use array instead of list for subchildren

this safes in the runtime of elm_test round about 9kb (*).
Additionally, using a array here is jumping way fewer times arround in
memory, as we do not need to jump from node to node in a list.

Additionally, this commit replaces a few abort disabler macros with a
error checking macro. (which cleans the log).

*: explanation: we have round about 600 widgets in elm_test, every
widget is normally refered once, every list node has 4 pointer, makes
round about 9600 bytes or rougly 9 KB. So the messured savings are more
or less explaining the reality.

Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com>
Differential Revision: https://phab.enlightenment.org/D11374

Change-Id: Ib906697a1ba71277e1fbdebedbdc0c05cb44d53a

4 years agoelementary: Remove internal flag of Elm_Win_Aux_Message structure 68/226768/1
Doyoun Kang [Thu, 5 Mar 2020 07:36:17 +0000 (16:36 +0900)]
elementary: Remove internal flag of Elm_Win_Aux_Message structure

@tizen_only

Change-Id: I25884f7e67dbfbebb576dc1af392a9ba3c04210c
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
4 years agoEcore_Wl2: Add dox and rearrange API list. 60/226660/2
Woochanlee [Wed, 4 Mar 2020 11:16:51 +0000 (20:16 +0900)]
Ecore_Wl2: Add dox and rearrange API list.

Change-Id: Ief34bd68508c03254ff527d171cf6e811d145548

4 years agoRemove internal flag of elm_win_aux_msg APIs 52/226552/2
Doyoun Kang [Tue, 3 Mar 2020 05:42:53 +0000 (14:42 +0900)]
Remove internal flag of elm_win_aux_msg APIs

- elm_win_aux_msg_key_get
- elm_win_aux_msg_val_get
- elm_win_aux_msg_options_get

@tizen_only

Change-Id: I61fcc31753d02cde1cc30c60cfe169e54f9cf027
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
4 years agoevas_object_main: add checking delete_me when submit/tizen/20200303.214157
Hosang Kim [Tue, 3 Mar 2020 09:58:02 +0000 (18:58 +0900)]
evas_object_main: add checking delete_me when
_evas_object_pointer_data_get is called.

Sometimes Eo object is already deleted, but
_evas_object_pointer_data_get is called.
So add checking delete_me for protecting crash.

Change-Id: I682a7095df1744745ce29e2af8d7be04781aaf4e

4 years agogenlist: refactoring item deletion process
SangHyeon Jade Lee [Mon, 2 Mar 2020 09:35:09 +0000 (18:35 +0900)]
genlist: refactoring item deletion process

sd->items must be cleaned before some item deletion process,
so that adjust item cannot find deleted item on sd->items list.

Change-Id: I3f862cc9d5b39291d7febcfcdfb4efbfe3937753

4 years ago[access] Handle case where last highlighted object is in different window
Prasoon Singh [Wed, 27 Nov 2019 11:17:16 +0000 (16:47 +0530)]
[access] Handle case where last highlighted object is in different window

When highlight_grab is called simultaneously fo different window object
highlight frame remains on last window.

Change-Id: I60dbfefda83a68aaa641aa289e92d3b99f6add26
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
4 years agoecore_timer: keep backward compatibility on freeze/thaw behavior
Hosang Kim [Tue, 25 Feb 2020 05:54:27 +0000 (14:54 +0900)]
ecore_timer: keep backward compatibility on freeze/thaw behavior

Legacy timer is thawed when ecore_timer_thaw is called even if freeze
and thaw pairs don't match.

Change-Id: I33bcb973a3f1d990e212cd09bdc36530bfcfbe19

4 years agoecore_wl2_input: fix repeat key window.
Hosang Kim [Mon, 24 Feb 2020 12:00:10 +0000 (21:00 +0900)]
ecore_wl2_input: fix repeat key window.

when window is removing, key repeat timer should be removed also.

Change-Id: I8971aa04b57379d89f117b4b9b4332a33561436c

4 years agoedje_message_queue: add checking number of messages.
Hosang Kim [Fri, 21 Feb 2020 09:51:37 +0000 (18:51 +0900)]
edje_message_queue: add checking number of messages.

Sometimes edje_message_del is called while processing edje message.
It makes double free corruption.

Change-Id: I06f01a8670d4220b20503790990ff8d751e47ff2

4 years agoedje_message_queue: decrease number of messages when message is removed.
Hosang Kim [Fri, 21 Feb 2020 07:02:07 +0000 (16:02 +0900)]
edje_message_queue: decrease number of messages when message is removed.

Reviewers: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11393

Change-Id: Ia7ba6de2061432bd503557a987e073504d4e3664
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
4 years agoRevert "elementary: use array instead of list for subchildren"
Jongmin Lee [Thu, 20 Feb 2020 22:06:01 +0000 (07:06 +0900)]
Revert "elementary: use array instead of list for subchildren"

This reverts commit cf583498a72be5f18b2dd6a4fb10ff1f1dbca53f.

4 years agoelementary: use array instead of list for subchildren
Marcel Hollerbach [Mon, 17 Feb 2020 12:56:06 +0000 (13:56 +0100)]
elementary: use array instead of list for subchildren

this safes in the runtime of elm_test round about 9kb (*).
Additionally, using a array here is jumping way fewer times arround in
memory, as we do not need to jump from node to node in a list.

Additionally, this commit replaces a few abort disabler macros with a
error checking macro. (which cleans the log).

*: explanation: we have round about 600 widgets in elm_test, every
widget is normally refered once, every list node has 4 pointer, makes
round about 9600 bytes or rougly 9 KB. So the messured savings are more
or less explaining the reality.

Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com>
Differential Revision: https://phab.enlightenment.org/D11374

Change-Id: I8653d875ab8bd7db4a48910dc2ed08cee1e76623

4 years agoavahi - let's disable by default as there doesn't seem to be a use
Carsten Haitzler (Rasterman) [Mon, 2 Mar 2020 19:02:09 +0000 (19:02 +0000)]
avahi - let's disable by default as there doesn't seem to be a use

i asked why we should have it by default etc. and what it's needed
for. i cant't find any... and no answer soc off by default to trim efl
down.

4 years agoefl-wl: add toplevel_added event for adding a new toplevel surface
Mike Blumenkrantz [Tue, 3 Mar 2020 18:42:47 +0000 (13:42 -0500)]
efl-wl: add toplevel_added event for adding a new toplevel surface

Summary: Depends on D11443

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11444

4 years agoefl-wl: ensure that child_added event is called only when a parent is set
Mike Blumenkrantz [Tue, 3 Mar 2020 18:42:43 +0000 (13:42 -0500)]
efl-wl: ensure that child_added event is called only when a parent is set

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11443

4 years agodoxygen docs: Fix several group problems
Xavi Artigas [Tue, 3 Mar 2020 17:46:36 +0000 (18:46 +0100)]
doxygen docs: Fix several group problems

@ingroup before @addgroup, circular group dependencies...

4 years agodoxygen docs: fix insufficiently namespaced group names
Xavi Artigas [Tue, 3 Mar 2020 16:49:23 +0000 (17:49 +0100)]
doxygen docs: fix insufficiently namespaced group names

These led to clashes, since group names must be globally unique.

4 years agodoxygen docs: fix multiple defined @section's
Xavi Artigas [Tue, 3 Mar 2020 10:09:47 +0000 (11:09 +0100)]
doxygen docs: fix multiple defined @section's

Section names must be globally unique.
We rarely reference sections so we don't actually need to use @section
and a simple header suffices.

4 years agoefl-wl: add function to get pid of a surface
Mike Blumenkrantz [Tue, 3 Mar 2020 17:27:43 +0000 (12:27 -0500)]
efl-wl: add function to get pid of a surface

Summary: this is useful for tracking surfaces of specific clients

Reviewers: bu5hm4n, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11438

4 years agotests_: elementary: remove not used allocation in collection view test
Stefan Schmidt [Mon, 2 Mar 2020 15:46:19 +0000 (16:46 +0100)]
tests_: elementary: remove not used allocation in collection view test

Allocated but never used (and never freed). Seems like a copy and paste
bug to me.

CID: 1412363

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11442

4 years agotests_: elementary: free memory in error path
Stefan Schmidt [Mon, 2 Mar 2020 15:40:38 +0000 (16:40 +0100)]
tests_: elementary: free memory in error path

Make sure we free the iterator here as well.

CID: 1409658

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11441

4 years agotests/gesture: add test for gesture sequence
Mike Blumenkrantz [Mon, 2 Mar 2020 15:23:31 +0000 (10:23 -0500)]
tests/gesture: add test for gesture sequence

ensure that tap continues working after complex gestures

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11440

4 years agoefl/gesture: deduplicate some code
Mike Blumenkrantz [Thu, 20 Feb 2020 18:55:40 +0000 (13:55 -0500)]
efl/gesture: deduplicate some code

also remove a misleading comment

no functional changes

Differential Revision: https://phab.enlightenment.org/D11395

4 years agotests/gesture: add a couple rotate gesture tests
Mike Blumenkrantz [Thu, 20 Feb 2020 18:48:14 +0000 (13:48 -0500)]
tests/gesture: add a couple rotate gesture tests

these end up triggering a lot of corner cases in other recognizers too,
but the tests themselves are fairly minimal

Differential Revision: https://phab.enlightenment.org/D11391

4 years agotests/gesture: verify rotate gesture event counting in existing tests
Mike Blumenkrantz [Wed, 19 Feb 2020 17:57:26 +0000 (12:57 -0500)]
tests/gesture: verify rotate gesture event counting in existing tests

these magically pass already

Differential Revision: https://phab.enlightenment.org/D11390

4 years agotests/elm: add util function for doing a multi-press drag around
Mike Blumenkrantz [Thu, 20 Feb 2020 18:24:52 +0000 (13:24 -0500)]
tests/elm: add util function for doing a multi-press drag around

same as existing function, but takes a finger id

Differential Revision: https://phab.enlightenment.org/D11389

4 years agotests/elm: fix drag_around helper to handle negative angles
Mike Blumenkrantz [Thu, 20 Feb 2020 18:16:51 +0000 (13:16 -0500)]
tests/elm: fix drag_around helper to handle negative angles

oops

Differential Revision: https://phab.enlightenment.org/D11388

4 years agoefl/gesture: fix flick internal touch id tracking
Mike Blumenkrantz [Thu, 20 Feb 2020 18:47:33 +0000 (13:47 -0500)]
efl/gesture: fix flick internal touch id tracking

need to always make sure we set this when a gesture is being tracked so
we know which touch point we're watching

Differential Revision: https://phab.enlightenment.org/D11387

4 years agoefl/gesture: fix momentum gesture recognizer to properly continue its gestures
Mike Blumenkrantz [Thu, 20 Feb 2020 18:22:47 +0000 (13:22 -0500)]
efl/gesture: fix momentum gesture recognizer to properly continue its gestures

it's not enough to just check the value for this in the recognizer; we need to
always modify the recognizer property here to correctly manage object lifetimes
and generate the correct events (e.g., not emitting momentum gestures while
multiple fingers are moving simultaneously)

also update a couple existing unit test checks which were wrong

Differential Revision: https://phab.enlightenment.org/D11386

4 years agoefl/gesture: correctly filter tap events based on the processing touch point
Mike Blumenkrantz [Thu, 20 Feb 2020 18:20:32 +0000 (13:20 -0500)]
efl/gesture: correctly filter tap events based on the processing touch point

if the recognizer is processing using a touch point other than the first finger,
e.g., in the case where multiple fingers are pressed simultaneously, then
the recognizer needs to also detect distance based on that finger

more fixes for triggering tap events while fingers are moving

Differential Revision: https://phab.enlightenment.org/D11385

4 years agoefl/gesture: fix internal gesture object management
Mike Blumenkrantz [Thu, 20 Feb 2020 18:17:58 +0000 (13:17 -0500)]
efl/gesture: fix internal gesture object management

when a gesture ends and is not set to continue, the gesture object must
be preserved until the entire touch sequence ends in order to ensure that
all the touch point states are accurately detected and updated and so
additional instances of that gesture are not accidentally triggered

this fixes weird corner cases where you could tap with two fingers and
then get a long press event while dragging the second finger around as
long as you did it quickly enough

Differential Revision: https://phab.enlightenment.org/D11384

4 years agoefl/gesture: port 'rotate' gesture from elm to new gesture framework
Mike Blumenkrantz [Wed, 19 Feb 2020 15:24:04 +0000 (10:24 -0500)]
efl/gesture: port 'rotate' gesture from elm to new gesture framework

this is a 1:1 port with minimal changes other than what's necessary to
integrate into the new framework

Differential Revision: https://phab.enlightenment.org/D11383

4 years agoefl/gesture: move some internal recognizer functions to be reusable
Mike Blumenkrantz [Wed, 19 Feb 2020 14:49:08 +0000 (09:49 -0500)]
efl/gesture: move some internal recognizer functions to be reusable

no functional changes

Differential Revision: https://phab.enlightenment.org/D11382

4 years agoefl/gesture: rename long_tap -> long_press
Mike Blumenkrantz [Tue, 18 Feb 2020 15:16:51 +0000 (10:16 -0500)]
efl/gesture: rename long_tap -> long_press

this is consistent with the rest of efl naming

ref T8503

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11376

4 years agoefl/gesture: remove empty efl.object implementations from gesture objects
Mike Blumenkrantz [Fri, 14 Feb 2020 14:40:55 +0000 (09:40 -0500)]
efl/gesture: remove empty efl.object implementations from gesture objects

these are no longer needed

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11354

4 years agoefl/gesture: remove 'type' member from Efl_Canvas_Gesture_Data
Mike Blumenkrantz [Fri, 14 Feb 2020 14:36:53 +0000 (09:36 -0500)]
efl/gesture: remove 'type' member from Efl_Canvas_Gesture_Data

this is no longer used

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11353

4 years agotests/gesture: add custom gesture to custom recognizer test
Mike Blumenkrantz [Fri, 14 Feb 2020 13:50:13 +0000 (08:50 -0500)]
tests/gesture: add custom gesture to custom recognizer test

this adds a simple custom gesture implementation with basic motion
accumulator properties to verify (and give an example of) the custom
gesture capability that can be used by apps alongside custom recognizers

Differential Revision: https://phab.enlightenment.org/D11352

4 years agoefl_ui_spotlight_scroll: improve scroll behaviour
Marcel Hollerbach [Sat, 22 Feb 2020 16:25:27 +0000 (17:25 +0100)]
efl_ui_spotlight_scroll: improve scroll behaviour

when the mouse motion was used, we need to mark this event as processed.
Otherwise a click event will be emitted which is wrong.

Additionally, we should only scroll when we are definitly not clicking.
Right now, the scrolling animation would dance arround on a real TS.

Additionally², this commit introduces a little macro which calculates
the distance of a position.

4 years agoexactness: check success of mkdir
Stefan Schmidt [Wed, 26 Feb 2020 14:07:12 +0000 (15:07 +0100)]
exactness: check success of mkdir

Evaluate return code of mkdir() and print error if it fails.

CID: 1419844

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11429

4 years agoRevert "elm_label: sizing eval is called _on_label_resize to ensure label size."
Stefan Schmidt [Mon, 2 Mar 2020 15:46:06 +0000 (16:46 +0100)]
Revert "elm_label: sizing eval is called _on_label_resize to ensure label size."

This reverts commit 3d57fc0c92d10337c441ec830361751de510e9b1.

The change broke elementary tests on my local machine as well as on CI.
Please redo the change and bring it back after testing with the test
suites we have.

4 years agoecore_wl: removes unreachable statements
Wonki Kim [Mon, 2 Mar 2020 09:26:39 +0000 (18:26 +0900)]
ecore_wl: removes unreachable statements

Summary: this patch removes unreachable statements

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11437

4 years agofreeq - up numbers for fq blocks and other limits to defer big batches
Carsten Haitzler (Rasterman) [Fri, 28 Feb 2020 18:47:50 +0000 (18:47 +0000)]
freeq - up numbers for fq blocks and other limits to defer big batches

this should improve some perf by upping the max a free queu can baloon
up to 256k items and 32m of data (whichever is hit first).

4 years agodocs: Give some doc love to Evas_Object_Vg
Xavi Artigas [Fri, 28 Feb 2020 11:36:57 +0000 (12:36 +0100)]
docs: Give some doc love to Evas_Object_Vg

4 years agodoxygen: fix missing @p tag
Xavi Artigas [Fri, 28 Feb 2020 11:08:51 +0000 (12:08 +0100)]
doxygen: fix missing @p tag

4 years agodoxygen: fix invalid anchor names
Xavi Artigas [Fri, 28 Feb 2020 11:07:45 +0000 (12:07 +0100)]
doxygen: fix invalid anchor names

4 years agodoxygen: fix missing endcond tag
Xavi Artigas [Fri, 28 Feb 2020 11:05:26 +0000 (12:05 +0100)]
doxygen: fix missing endcond tag

4 years agodoxygen: fix missing titles in addgroup
Xavi Artigas [Fri, 28 Feb 2020 10:43:52 +0000 (11:43 +0100)]
doxygen: fix missing titles in addgroup

4 years agodoxygen: fix invalid eolian_main_intro ref
Xavi Artigas [Fri, 28 Feb 2020 10:39:23 +0000 (11:39 +0100)]
doxygen: fix invalid eolian_main_intro ref

4 years agodoxygen: fix duplicated toc sections
Xavi Artigas [Fri, 28 Feb 2020 10:01:56 +0000 (11:01 +0100)]
doxygen: fix duplicated toc sections

4 years agodoxygen: remove deprecated (and unused) configuration
Xavi Artigas [Fri, 28 Feb 2020 10:01:37 +0000 (11:01 +0100)]
doxygen: remove deprecated (and unused) configuration

4 years agodoxygen: remove duplicated sections
Xavi Artigas [Fri, 28 Feb 2020 10:01:03 +0000 (11:01 +0100)]
doxygen: remove duplicated sections

Unified widgets simply copied elm's headers, duplicating doxygen sections.

4 years agodoxygen: fix missing end group tag
Xavi Artigas [Fri, 28 Feb 2020 09:53:49 +0000 (10:53 +0100)]
doxygen: fix missing end group tag

4 years agodoxygen: fix duplicated intro sections
Xavi Artigas [Fri, 28 Feb 2020 09:52:59 +0000 (10:52 +0100)]
doxygen: fix duplicated intro sections

4 years agoexactness: inspect: use logical OR instead bitwise XOR
Stefan Schmidt [Wed, 26 Feb 2020 16:18:07 +0000 (17:18 +0100)]
exactness: inspect: use logical OR instead bitwise XOR

Coverity pointed these out as we deferences after null check.
Looking into it showed these use of a bitwise operator on vars where it
does not make any sense (to me). They look like wrongly done NULL
checks. Switchign them over to a logical OR operator.

CID: 1419876, 1419869, 1419868, 1419862, 1419854, 1419849

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11432

4 years agoexactness: inspect: remove unreachable code
Stefan Schmidt [Wed, 26 Feb 2020 14:46:22 +0000 (15:46 +0100)]
exactness: inspect: remove unreachable code

If dt equals EX_FONTS_DIR we would have returned already.

CID: 1419879

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11430

4 years agoexactness: handle error cases for saving an image
Stefan Schmidt [Wed, 26 Feb 2020 14:02:23 +0000 (15:02 +0100)]
exactness: handle error cases for saving an image

Handle the error case and propagate the error upwards.

CID: 1419855

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11428

4 years agoexactness: use eina_strdup() to avoid extra NULL checking
Stefan Schmidt [Wed, 26 Feb 2020 10:35:20 +0000 (11:35 +0100)]
exactness: use eina_strdup() to avoid extra NULL checking

strdup() would not be happy about a NULL to copy, but we have
eina_strdup in place already to handle this gracefully.

CID: 1419846

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11421

4 years agoexactness: check return code from ecore_evas_init
Stefan Schmidt [Wed, 26 Feb 2020 09:38:54 +0000 (10:38 +0100)]
exactness: check return code from ecore_evas_init

Check if we can initialize correctly and return failure if not.

CID: 1419872, 1419864, 1419867, 1419850

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11420

4 years agoexactness: avoid leak on leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 10:42:17 +0000 (11:42 +0100)]
exactness: avoid leak on leaving scope

Before we leave the fucntion here we need to free our temporaray paths
variable.

CID: 1419860

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11411

4 years agoexactness: player: allow space for the terminating null
Stefan Schmidt [Tue, 25 Feb 2020 10:20:21 +0000 (11:20 +0100)]
exactness: player: allow space for the terminating null

Allocate extra space for the terminating null byte and / of the string.
Switch to snprintf() as well.

CID: 1419863

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11410

4 years agoelm_slider: Add return value check
JunsuChoi [Wed, 26 Feb 2020 07:35:28 +0000 (16:35 +0900)]
elm_slider: Add return value check

Summary:
Calling eina_value_get() without checking return value.
CID: 1400991

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho, CHAN

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11416

4 years agotest/suite_helpers : Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:34:44 +0000 (16:34 +0900)]
test/suite_helpers : Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/tests/elementary/suite_helpers.c:779:86: warning: ?idy2? may be used uninitialized in this function [-Wmaybe-uninitialized].
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11417

4 years agoelementary_test/ui_spotlight: Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:33:21 +0000 (16:33 +0900)]
elementary_test/ui_spotlight: Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/bin/elementary/test_ui_spotlight.c:1126:9: warning: 'view' may be used uninitialized in this function [-Wmaybe-uninitialized]
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11418

4 years agoexactness: injector: free local buffers
Stefan Schmidt [Tue, 25 Feb 2020 11:34:18 +0000 (12:34 +0100)]
exactness: injector: free local buffers

Make sure we free local resources before we break.

CID: 1419845

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11414

4 years agoexactness: inspect: free image before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 11:29:01 +0000 (12:29 +0100)]
exactness: inspect: free image before leaving scope

We need to amke sure we free this images before we return.

CID: 1419848

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11413

4 years agoexactness: close file we opened
Stefan Schmidt [Tue, 25 Feb 2020 10:59:51 +0000 (11:59 +0100)]
exactness: close file we opened

We only opened it read only, but this should still be closed before
leaving.

CID: 1419853

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11412

4 years agoexactness: inspect: free local allocation before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 09:51:29 +0000 (10:51 +0100)]
exactness: inspect: free local allocation before leaving scope

Before we leave the scope here this needs to get free'd up or it will
leak.

CID: 1419877

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11408

4 years agoexactness: inspect: fix memory leak of buffer in error path
Stefan Schmidt [Tue, 25 Feb 2020 09:36:39 +0000 (10:36 +0100)]
exactness: inspect: fix memory leak of buffer in error path

If we hit this error path we need to release the allocated buffer.

CID: 1419878

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11407

4 years agoEcore_Win32: free 'compose' field when needed, fix memory leak
Vincent Torri [Tue, 25 Feb 2020 15:27:14 +0000 (10:27 -0500)]
Ecore_Win32: free 'compose' field when needed, fix memory leak

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11415

4 years agoEvil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32
Vincent Torri [Tue, 25 Feb 2020 14:23:48 +0000 (09:23 -0500)]
Evil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32

Summary: use existing utf-16 to utf-8 conversion function in Ecore_Win32. Add API to convert utf-8 to utf-16 in Evil for copy'n paste on Windows

Test Plan: compilation

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11406

4 years agotests/elm: verify image file_set -> memfile_set -> file_set
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:46 +0000 (09:23 -0500)]
tests/elm: verify image file_set -> memfile_set -> file_set

Summary:
ref D11392
Depends on D11397

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11398

4 years agotests/elm: fix elm_icon test
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:44 +0000 (09:23 -0500)]
tests/elm: fix elm_icon test

Summary:
* this was left as a duplicated efl_ui_image test
* elm_image doesn't have a legacy api for setting icons
* elm_icon doesn't actually have any tests for icon loading
Depends on D11396

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11397

4 years agotest_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf
Yeongjong Lee [Tue, 25 Feb 2020 11:23:30 +0000 (12:23 +0100)]
test_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf

Test Plan: compile with `-Wformat-truncation`

Reviewers: raster, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11405

4 years agoelm/image: restore legacy behavior of elm_image_file_get
Mike Blumenkrantz [Tue, 25 Feb 2020 03:17:12 +0000 (12:17 +0900)]
elm/image: restore legacy behavior of elm_image_file_get

Summary:
this should operate on the internal image object to reflect the file
state there instead of the outer object

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11396

4 years agoefl_ui/image_zoomable: add icon setting fallback for fdo icons
Mike Blumenkrantz [Mon, 24 Feb 2020 14:34:45 +0000 (15:34 +0100)]
efl_ui/image_zoomable: add icon setting fallback for fdo icons

Summary:
same as D11381
ref 697308a16f77e3e7b7dac6e74293850a3950e3d3

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11403

4 years agoEfl.Ui.Image: Add fallback when icon is not found in default theme
Xavi Artigas [Mon, 24 Feb 2020 14:02:30 +0000 (09:02 -0500)]
Efl.Ui.Image: Add fallback when icon is not found in default theme

Summary:
If _icon_standard_set() fails, _icon_freedesktop_set() is tried.

This was causing missing icons in the homescreen example, which uses
application icons which are obviously not present in the default theme.

Thanks to @bu5hm4n!

Test Plan: The homescreen sample application from the examples repository now correctly shows all missing icons.

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11381

4 years agoelm : move unrealize callback call before the content caching.
SangHyeon Jade Lee [Mon, 24 Feb 2020 13:52:09 +0000 (08:52 -0500)]
elm : move unrealize callback call before the content caching.

Summary:
item edje and contents are cached for performance improvement in genlist & gengrid.
but to provide elm_genlist(gengrid)_all_contents_unset method before the contents
are being cached, unrealize callback must be come before the unrealize process.

currently,
item_unrealize
1.unrealize process
2.contents cached
3.unrealize callback
4.all_contents_unset : nothing to unset in the item.

by this patch,
item_unrealize
1.unrealize callback
2.all_contents_unset : contents are unset.
3.unrealize process
4.contents(null) cached

Reviewers: bu5hm4n, cedric, eagleeye, zmike

Reviewed By: zmike

Subscribers: zmike, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11402

4 years agoRevert "elm_spinner: Fixed to apply the %d format."
Jaehyun Cho [Fri, 21 Feb 2020 09:07:13 +0000 (09:07 +0000)]
Revert "elm_spinner: Fixed to apply the %d format."

This reverts commit b8a24679a6f7995ccc1da19eb86c6c2ef6826d1a.

Differential Revision: https://phab.enlightenment.org/D11394

4 years agoeina: Fix warnings about unused variables on Windows
Christopher Michael [Sun, 23 Feb 2020 12:38:05 +0000 (07:38 -0500)]
eina: Fix warnings about unused variables on Windows

NB: Patch from vtorri

4 years agoci: travis: ensure we update brew as well to avoid a problem on Travis
Stefan Schmidt [Fri, 21 Feb 2020 08:15:53 +0000 (09:15 +0100)]
ci: travis: ensure we update brew as well to avoid a problem on Travis

We normally did not use update as it could take up a few minutes for
every macos build and the packages have been recent enough. Since a few
hours we see build problems now on Travis:
Error: Unknown command: bundle

A way to get them fixed (until Travis updates their images for macos) is
to use the update command.
https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/9

Also moving to a newer osx image here to avoid falling further behind on
the dependencies.