platform/upstream/dotnet/runtime.git
5 years agoAdded code for removing oleHeader (dotnet/corefx#36891)
Anirudh Agnihotry [Mon, 22 Apr 2019 22:14:35 +0000 (15:14 -0700)]
Added code for removing oleHeader (dotnet/corefx#36891)

* added code for removing oleHeader and modifiying it to use span

* updating the testdata version and reading only the header signature first

* removing size check on the size of object header as welll as we are catching ArgumentOutOfRangeException

* Updating verison numbers

Commit migrated from https://github.com/dotnet/corefx/commit/eb9b565f13905624ba01464c876dc06a83a3d9e2

5 years agoMerge pull request dotnet/corefx#37027 from Wraith2/sqltest-concurrentload
Afsaneh Rafighi [Mon, 22 Apr 2019 20:09:20 +0000 (13:09 -0700)]
Merge pull request dotnet/corefx#37027 from Wraith2/sqltest-concurrentload

SqlClient add concurrent load tests

Commit migrated from https://github.com/dotnet/corefx/commit/a3ab91e10045bb298f48c1d1f9bd5b0782a8ac46

5 years agowrite Host header first if we need to add it (dotnet/corefx#37007)
Tomas Weinfurt [Mon, 22 Apr 2019 19:28:16 +0000 (12:28 -0700)]
write Host header first if we need to add it (dotnet/corefx#37007)

* write Host header first if we need to add it

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/724d8f73e66b747e079875d431d4c1fa546119e1

5 years agoInitial port of Microsoft.VisualBasic.Devices and Microsoft.VisualBasic.MyServices...
Charles Stoner [Mon, 22 Apr 2019 18:32:16 +0000 (11:32 -0700)]
Initial port of Microsoft.VisualBasic.Devices and Microsoft.VisualBasic.MyServices (dotnet/corefx#37085)

Commit migrated from https://github.com/dotnet/corefx/commit/37703f186d593425418a7fcf705173c707da30d4

5 years agoFix conditional fact in ArrayBufferWriter tests (dotnet/corefx#37086)
Stephen Toub [Mon, 22 Apr 2019 16:03:51 +0000 (12:03 -0400)]
Fix conditional fact in ArrayBufferWriter tests (dotnet/corefx#37086)

Commit migrated from https://github.com/dotnet/corefx/commit/3bda413dc3ae242a7f47967dceb9ffbc13024c78

5 years agoRevise and fix CreateInstanceAssemblyResolve (dotnet/corefx#37080)
Steve MacLean [Mon, 22 Apr 2019 14:06:21 +0000 (10:06 -0400)]
Revise and fix CreateInstanceAssemblyResolve (dotnet/corefx#37080)

dotnet/coreclrdotnet/corefx#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.

Commit migrated from https://github.com/dotnet/corefx/commit/ea10af28f44e473f3f71934c6bfa9a2830403153

5 years agoAdd ContextualReflection tests (dotnet/corefx#37052)
Steve MacLean [Sun, 21 Apr 2019 20:19:00 +0000 (16:19 -0400)]
Add ContextualReflection tests (dotnet/corefx#37052)

* Add ContextualReflection tests

Commit migrated from https://github.com/dotnet/corefx/commit/b96247e76506e81ff6eb28dd2a14914a59e2a257

5 years agoAdd Dictionary support to JsonSerializer (dotnet/corefx#37070)
Steve Harter [Sun, 21 Apr 2019 16:13:09 +0000 (09:13 -0700)]
Add Dictionary support to JsonSerializer (dotnet/corefx#37070)

* Add Dictionary support to JsonSerializer

This partially addresses https://github.com/dotnet/corefx/issues/36024.
For the intial version, only `Dictionary<string, [some concrete type]>`
is supported.

* Refactor

* Add more tests

Commit migrated from https://github.com/dotnet/corefx/commit/431f6557d0089e07c953934583e1decca3c90831

5 years agoFix DefaultLoadContextTest (dotnet/corefx#37071)
Steve MacLean [Sun, 21 Apr 2019 15:09:43 +0000 (11:09 -0400)]
Fix DefaultLoadContextTest (dotnet/corefx#37071)

Move clear of olc.LoadedFromContext earlier before System.Runtime is loaded.

Commit migrated from https://github.com/dotnet/corefx/commit/0ac3306ffe66327ec6360694579fe1fe786816e1

5 years agoAdd EnumeratorCancellationAttribute (dotnet/corefx#37064)
Stephen Toub [Sat, 20 Apr 2019 20:07:52 +0000 (16:07 -0400)]
Add EnumeratorCancellationAttribute (dotnet/corefx#37064)

* Update ChannelReader.ReadAllAsync for EnumeratorCancellationAttribute

* Add EnumeratorCancellationAttribute

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/13cd96122c25328a1b180a6289923657180a7b69

5 years agoSquash fix for process name. (dotnet/corefx#36913)
Peter Stevenson [Sat, 20 Apr 2019 15:40:41 +0000 (16:40 +0100)]
Squash fix for process name. (dotnet/corefx#36913)

Handle long process names on Linux

See: https://github.com/2E0PGS/corefx/commit/dotnet/corefx@56e73858adb046b57165eae44af111d64e2fcd98

* add test

* update test

* update test

* address PR feedback

* fix alpine ci

* fix compilation

* add some log for alpine fail

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8b515adcd4ea0b8233f018f9e87ef946ce0e7c42

5 years agoskip GetAsync_IPv6LinkLocalAddressUri_Success if address is not available (dotnet...
Tomas Weinfurt [Sat, 20 Apr 2019 13:36:43 +0000 (06:36 -0700)]
skip GetAsync_IPv6LinkLocalAddressUri_Success if address is not available (dotnet/corefx#37051)

Commit migrated from https://github.com/dotnet/corefx/commit/8e2e72b2683a4b4b983b184f1e703a3174b8566c

5 years agoPort Microsoft.VisualBasic.Conversion class (dotnet/corefx#37047)
Charles Stoner [Sat, 20 Apr 2019 06:31:00 +0000 (23:31 -0700)]
Port Microsoft.VisualBasic.Conversion class (dotnet/corefx#37047)

Commit migrated from https://github.com/dotnet/corefx/commit/c608ddaa2a024dde2510f3c1122c89ba07b4325d

5 years agoAddress and fix ArrayBufferWriter and Utf8JsonWriter feedback and nits (dotnet/corefx...
Ahson Khan [Sat, 20 Apr 2019 00:35:24 +0000 (17:35 -0700)]
Address and fix ArrayBufferWriter and Utf8JsonWriter feedback and nits (dotnet/corefx#37017)

* Address ABW and Utf8JsonWriter feedback and nits.

* Address ABW init and test feedback.

* Fix up JsonWriter usage of ABW and update tests.

* Address PR feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/4a25e4b03bcb5b9b1b2319b4178d2dfcfe05b3b1

5 years agoFix doc comment for Utf8JsonReader.ValueSequence (dotnet/corefx#37038)
Stephan Tolksdorf [Fri, 19 Apr 2019 22:05:14 +0000 (00:05 +0200)]
Fix doc comment for Utf8JsonReader.ValueSequence (dotnet/corefx#37038)

Fixes issue dotnet/corefx#37036.

Commit migrated from https://github.com/dotnet/corefx/commit/c0cd09bb7fb1d40e51e4fdab1822a50a2b322260

5 years agoremove commented code and address feedback
Wraith2 [Fri, 19 Apr 2019 21:52:40 +0000 (22:52 +0100)]
remove commented code and address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/23a78c29abb05724c69fb81603542aeefb617f78

5 years agoUpdate windows instructions to encourage VS 2019 preview explicitly (dotnet/corefx...
Zachary Danz [Fri, 19 Apr 2019 21:38:42 +0000 (14:38 -0700)]
Update windows instructions to encourage VS 2019 preview explicitly  (dotnet/corefx#37013)

* Update windows instructions to encourage 16 preview

* Update windows-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/feb534bfdf8695068cfd85a6e39e57ecb6373371

5 years agoMore porting of vbruntime (dotnet/corefx#37010)
Charles Stoner [Fri, 19 Apr 2019 20:11:39 +0000 (13:11 -0700)]
More porting of vbruntime (dotnet/corefx#37010)

Commit migrated from https://github.com/dotnet/corefx/commit/432a34fed6f0db6d76d5b3f8bbc8297fb0aa5f6b

5 years agoSupport XmlKnownDtds in XmlPreloadedResolver (dotnet/corefx#36971)
Ian Griffiths [Fri, 19 Apr 2019 17:44:08 +0000 (18:44 +0100)]
Support XmlKnownDtds in XmlPreloadedResolver (dotnet/corefx#36971)

* Support XmlKnownDtds in XmlPreloadedResolver

The XmlPreloadedResolver class purports to provide certain well-known DTDs - its constructor accepts a value from the XmlKnownDtds enumeration, and if you specify either of the supported DTD sets (sXHTML 1.0, and RSS 0.91) it is meant to make the relevant DTDs available.

In desktop .NET, this works as advertised. In .NET Core, it does not, for the reasons described in https://github.com/dotnet/corefx/issues/36929

This was missed because there are no tests to verify that the XmlPreloadedResolver makes the relevant DTDs available when asked to. (In fact, the tests that existed seemed to be based on a misunderstanding of how this class works.) This adds tests that verify that the known DTDs are provided when requested. And it reinstates the relevant EmbeddedResource entries required to enable the functionality. (The code for this has been in .NET Core's XmlPreloadedResolver all along. It was only the absence of the necessary embedded resources preventing it from working.)

* Completed refactoring that was half-complete

In the previous commit I introduced the NormalizeContent method to avoid duplication of various calls to string.Replace but I left in one such call. This replaces it with a call to the new NormalizeContent, as intended.

* Replace \ with / in test paths

Tests failed on Linux with this:

Could not find a part of the path '/root/helix/work/workitem/Utils\\DTDs\\/XHTML10\

I'm hoping that replacing the backslashes with forward slashes will get the tests passing.

* Replaced fixed / and \ with Path.Combine

Although using / everywhere did seem to work, the preferred way to generate paths is Path.Combine.

Note that this still uses string concatenation for the system ID URI because that's not a path, it's just an identifier.

Commit migrated from https://github.com/dotnet/corefx/commit/eb63183901fbe6afc2be4e1ff0f365fe20cefbf5

5 years agoRenaming the Sse2.StoreLow(ulong/long*, ...) methods to Sse2.StoreScalar (dotnet...
Tanner Gooding [Fri, 19 Apr 2019 16:33:54 +0000 (09:33 -0700)]
Renaming the Sse2.StoreLow(ulong/long*, ...) methods to Sse2.StoreScalar (dotnet/corefx#37029)

Commit migrated from https://github.com/dotnet/corefx/commit/9ca73f6b6ab92a977e6191e64ae09baf7d0bf131

5 years agoFix IDN Tests to support Unicode 11 (dotnet/corefx#37011)
Tarek Mahmoud Sayed [Fri, 19 Apr 2019 15:46:25 +0000 (08:46 -0700)]
Fix IDN Tests to support Unicode 11 (dotnet/corefx#37011)

Windows 19H1  upgraded the IDN data to Unicode 11. The change here is to to use the new Unicode 11 IDN test data  in our tests.

Commit migrated from https://github.com/dotnet/corefx/commit/3679699457b7cf7ece9c6f82f214346cfb07eff9

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37023)
dotnet-maestro[bot] [Fri, 19 Apr 2019 15:09:12 +0000 (15:09 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37023)

* Update dependencies from https://github.com/dotnet/coreclr build 20190418.74

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27618-74
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27618-74
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27618-74

* Fix StackTrace.ToString with null frame test

Commit migrated from https://github.com/dotnet/corefx/commit/8fa3e3c3624967a4049070791788f0602b2581e1

5 years agoadd concurrent load tests
Wraith2 [Fri, 19 Apr 2019 13:48:22 +0000 (14:48 +0100)]
add concurrent load tests

Commit migrated from https://github.com/dotnet/corefx/commit/7e89b7e3f4d4fd6a706e6878c0b9132c1b32e96f

5 years agoImplement server-side of NegotiateStream on Unix (dotnet/corefx#36827)
Chris Ross [Fri, 19 Apr 2019 05:27:38 +0000 (22:27 -0700)]
Implement server-side of NegotiateStream on Unix (dotnet/corefx#36827)

Commit migrated from https://github.com/dotnet/corefx/commit/0a9a366e290aded3e9bf5d082d6beee5ff560177

5 years agoadd test for connection timeouts (dotnet/corefx#36990)
Tomas Weinfurt [Fri, 19 Apr 2019 04:15:37 +0000 (21:15 -0700)]
add test for connection  timeouts (dotnet/corefx#36990)

* add test for connection  timeouts

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/2a6ee34edd98c1746c11c9354bef12654822f5ee

5 years agoPerformance improvements in EmailAddressAttribute (dotnet/corefx#36994)
Ponant [Fri, 19 Apr 2019 04:14:10 +0000 (06:14 +0200)]
Performance improvements in EmailAddressAttribute (dotnet/corefx#36994)

* performance improvements by a factor of 2 to 10

I get a perf improvement by using IndexOf which ranges from a a factor of two for an email address having 20 char to nearly 10 for 60 char.

* Update src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/EmailAddressAttribute.cs

force explicit type

* Simplify code

Commit migrated from https://github.com/dotnet/corefx/commit/556e080cce3bbd075f7199286b33842f5c0a0c61

5 years agoAdd missing method
Sung Yoon Whang [Fri, 19 Apr 2019 01:04:39 +0000 (18:04 -0700)]
Add missing method

Commit migrated from https://github.com/dotnet/corefx/commit/c150a145990a662258e685ea204a8e83a7333111

5 years agoI'm stupid
Sung Yoon Whang [Fri, 19 Apr 2019 00:56:07 +0000 (17:56 -0700)]
I'm stupid

Commit migrated from https://github.com/dotnet/corefx/commit/d64827a410909d18d90c0fa2b25c52f65ce59e2c

5 years agosplitting implementation of EventCounter to non-uap/uap
Sung Yoon Whang [Fri, 19 Apr 2019 00:49:51 +0000 (17:49 -0700)]
splitting implementation of EventCounter to non-uap/uap

Commit migrated from https://github.com/dotnet/corefx/commit/2d1e2ff48e61a70ef990f48e677f6237b044fe52

5 years agotry to exclude new counters for uap
Sung Yoon Whang [Thu, 18 Apr 2019 23:39:08 +0000 (16:39 -0700)]
try to exclude new counters for uap

Commit migrated from https://github.com/dotnet/corefx/commit/c29c7b4a5630b896bbbb73f18f0de2dea9e0d123

5 years agodisable exposing new counter types on ProjectN until they are propagated through...
Sung Yoon Whang [Thu, 18 Apr 2019 22:50:48 +0000 (15:50 -0700)]
disable exposing new counter types on ProjectN until they are propagated through the targetingpack

Commit migrated from https://github.com/dotnet/corefx/commit/33724212beccbdca43d020f595dce88e38eaab31

5 years agosome type annotation stuff
Sung Yoon Whang [Thu, 18 Apr 2019 06:33:42 +0000 (23:33 -0700)]
some type annotation stuff

Commit migrated from https://github.com/dotnet/corefx/commit/c478c7c2d86b31917e6bd8dd62c66d8f00cac10a

5 years agoremove extra nl
Sung Yoon Whang [Thu, 18 Apr 2019 06:32:41 +0000 (23:32 -0700)]
remove extra nl

Commit migrated from https://github.com/dotnet/corefx/commit/0955fc31dfd9fca8b200aa5f1c59a453c01ca0ef

5 years agoExposing the new counter APIs in System.Diagnostics.Tracing
Sung Yoon Whang [Thu, 18 Apr 2019 06:16:47 +0000 (23:16 -0700)]
Exposing the new counter APIs in System.Diagnostics.Tracing

Commit migrated from https://github.com/dotnet/corefx/commit/c042b3aa7de95332624f3d725e8abdb4d3d043f5

5 years agoFix Json Source package not includding ArrayBufferWriter (dotnet/corefx#37009)
Jose Perez Rodriguez [Thu, 18 Apr 2019 23:21:48 +0000 (16:21 -0700)]
Fix Json Source package not includding ArrayBufferWriter (dotnet/corefx#37009)

Commit migrated from https://github.com/dotnet/corefx/commit/c1b0a40964253b1bc48dd3be734eb2e1cf716db3

5 years agoPort StringType (dotnet/corefx#36951)
Charles Stoner [Thu, 18 Apr 2019 21:23:40 +0000 (14:23 -0700)]
Port StringType (dotnet/corefx#36951)

Commit migrated from https://github.com/dotnet/corefx/commit/d69b4f7864a76a375d4178b1afa8c9e97ee549b8

5 years agoHashcode calculation update (dotnet/corefx#37002)
buyaa-n [Thu, 18 Apr 2019 19:46:20 +0000 (12:46 -0700)]
Hashcode calculation update (dotnet/corefx#37002)

Seems packaging failure is not related, merging, thank you all for feedback

Commit migrated from https://github.com/dotnet/corefx/commit/e816593d49d87ec2a5815e34b82c5c8ba86aa85f

5 years agoallow Http2 loopback test be unencrypted (dotnet/corefx#36968)
Tomas Weinfurt [Thu, 18 Apr 2019 19:10:31 +0000 (12:10 -0700)]
allow Http2 loopback test be unencrypted (dotnet/corefx#36968)

* fix tests with http/2

* make SSL on Loopback server configurable via environment

* update variable names

Commit migrated from https://github.com/dotnet/corefx/commit/95987e3e3aa95b2ae6386b17271a172d20fe50cc

5 years agoHandle concurrent dispose and WriteAsync calls (dotnet/corefx#36988)
David Fowler [Thu, 18 Apr 2019 17:32:55 +0000 (10:32 -0700)]
Handle concurrent dispose and WriteAsync calls (dotnet/corefx#36988)

- lock the entire Write operation
- Added a test that Completes both reader and writer in the middle of writing a large buffer

Commit migrated from https://github.com/dotnet/corefx/commit/90d98b9abb87743c2340506a7823e452c757767c

5 years agohandle bad Expires better (dotnet/corefx#36908)
Tomas Weinfurt [Thu, 18 Apr 2019 12:42:24 +0000 (05:42 -0700)]
handle bad Expires better (dotnet/corefx#36908)

* handle bad Expires better

* update tests

* internal -> private

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/82eedbff6b767c0bd9297d3dd27c89d925a28e93

5 years agoRe-design Utf8JsonWriter as a regular class rather than a ref struct. (dotnet/corefx...
Ahson Khan [Thu, 18 Apr 2019 06:57:50 +0000 (23:57 -0700)]
Re-design Utf8JsonWriter as a regular class rather than a ref struct. (dotnet/corefx#36961)

* Add an in-box array-backed IBufferWriter<T>

* Update Utf8JsonWriter ref and main writer file.

* Fix JsonWriter WriteValue APIs.

* Use Environment.NewLine static and invert some stream conditions.

* Update JsonWriter properties and fix serializer build breaks.

* Update JsonWriter unit tests.

* Add xml comments, clean up, and improve test coverage.

* Update JsonDocument and JsonSerializer to react to JsonWriter changes.

* Normalize the reference assembly.

* Do not escape/validate comments and update issue number.

* Do not escape comments and validate they don't contain embedded
delimiter

* Remove dead code and update issue number in comments.

* Throw InvalidOEx instead of ArgEx if IBW doesn't give requested memory.

* Fix test build breaks for netfx.

* Remove dead code and fix source packaging.

* Address PR feedback.

* Disable writing floats test on windows

* 8 digit floats don't work well on older TFMs. Reduce to 7.

Commit migrated from https://github.com/dotnet/corefx/commit/1f9b84a0804e868c7e0f37a3c10fbaf7c735ae14

5 years agoFix SocketsHttpHandler streams to do sync I/O in sync methods (dotnet/corefx#36946)
Stephen Toub [Thu, 18 Apr 2019 04:01:04 +0000 (00:01 -0400)]
Fix SocketsHttpHandler streams to do sync I/O in sync methods (dotnet/corefx#36946)

* Fix SocketsHttpHandler response streams to do sync I/O in sync methods

SocketsHttpHandler hands back response Streams for reading response body content.  While we encourage developers to use the async Stream APIs, Stream does expose synchronous APIs, yet the current implementations are just wrapping the async ones and doing sync-over-async.

This fixes the response stream synchronous APIs to be sync down to the underlying networking stream.

It also fixes a couple other minor issues, e.g. Flush{Async} on read-only stream should be nops rather than throwing, we should include an error message about a stream being read-only when trying to write to it, etc.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/315fd00cb2465390900209919cdb2bf6bc44ae0e

5 years agoFix ClientWebSocket closing handshake logic (dotnet/corefx#36975)
David Shulman [Thu, 18 Apr 2019 03:33:23 +0000 (20:33 -0700)]
Fix ClientWebSocket closing handshake logic (dotnet/corefx#36975)

An HttpListener websocket test was failing after the change from PR dotnet/corefx#36928. That PR made changes
to tighten up the transition to the Closed state after the closing handshake had completed.

That PR missed some additional changes needed especially in cases where a server (such as loopback)
sends the close frame almost concurrently with the client sending the close frame.

This PR fixes the close frame handshake logic and also makes some optimizations in cases where the
websocket has already transitioned to the Aborted state during the closing handshake. In that case,
the websocket should not wait for a close frame to be received but should simply proceed to closing
the connection.

Fixes dotnet/corefx#36963

Commit migrated from https://github.com/dotnet/corefx/commit/1824535f95defea3ba464599ee4b9937a82eaaf9

5 years agoImprove System.Native build experience for new platforms (dotnet/corefx#36926)
Adeel Mujahid [Thu, 18 Apr 2019 03:02:55 +0000 (04:02 +0100)]
Improve System.Native build experience for new platforms (dotnet/corefx#36926)

Commit migrated from https://github.com/dotnet/corefx/commit/65f07a9cf6e3d53cbd77c52d5ecffe00be0ff804

5 years agoAdd extra tests for UTF-16 validation of random 8-char data (dotnet/corefx#36903)
Levi Broderick [Thu, 18 Apr 2019 02:35:56 +0000 (19:35 -0700)]
Add extra tests for UTF-16 validation of random 8-char data (dotnet/corefx#36903)

Commit migrated from https://github.com/dotnet/corefx/commit/60aee3575e21af1070e7b834905d1864a401828d

5 years agoFix SDK downgrading Platforms package (dotnet/corefx#36981)
Eric StJohn [Thu, 18 Apr 2019 01:11:05 +0000 (18:11 -0700)]
Fix SDK downgrading Platforms package (dotnet/corefx#36981)

Commit migrated from https://github.com/dotnet/corefx/commit/dcd80906ded9fee765d7ce4de4d992d5108df63c

5 years agoManually updating dependencies in order to get the new coreclr packages. (dotnet...
Jose Perez Rodriguez [Thu, 18 Apr 2019 00:48:24 +0000 (17:48 -0700)]
Manually updating dependencies in order to get the new coreclr packages. (dotnet/corefx#36976)

* Update the Index and Range interfaces and tests

* Fix api compat failure with utf8string

* Fix the test to use Assert.Throws

* Update dependencies manually

Commit migrated from https://github.com/dotnet/corefx/commit/d5a5f3c9eb96adf38115cbc04e5664abf328b02d

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)
dotnet-maestro[bot] [Wed, 17 Apr 2019 23:18:59 +0000 (16:18 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)

* Update dependencies from https://github.com/dotnet/coreclr build 20190415.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190416.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72

* Update CoreCLR dependencies to 3.0.0-preview5-27616-73

* Fixing the Min/Max and MinMagnitude/MaxMagnitude for System.Math and System.MathF to expect NaN propagation

Commit migrated from https://github.com/dotnet/corefx/commit/818355a02ec70c72d44e4ad2b1b95943350d55bb

5 years agoAdd Json serializer property name related features (dotnet/corefx#36940)
Steve Harter [Wed, 17 Apr 2019 22:52:49 +0000 (15:52 -0700)]
Add Json serializer property name related features (dotnet/corefx#36940)

Commit migrated from https://github.com/dotnet/corefx/commit/bc8c22291049b2626ec5b102869685fc95fa41cc

5 years agoUse NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)
Adeel Mujahid [Wed, 17 Apr 2019 18:44:46 +0000 (19:44 +0100)]
Use NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)

Commit migrated from https://github.com/dotnet/corefx/commit/fbc748b93e65600a68b217ec59fc4522d5df4ffb

5 years agoRegenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)
Tanner Gooding [Wed, 17 Apr 2019 17:07:51 +0000 (10:07 -0700)]
Regenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)

Commit migrated from https://github.com/dotnet/corefx/commit/fa25b86d6789440f42ba391deda428e302f584f9

5 years agoDisable asserting HttpListener web socket test (dotnet/corefx#36964)
Stephen Toub [Wed, 17 Apr 2019 15:15:40 +0000 (11:15 -0400)]
Disable asserting HttpListener web socket test (dotnet/corefx#36964)

Commit migrated from https://github.com/dotnet/corefx/commit/18cd561127e35841db2775dc7a85adad70363e18

5 years agoadding default encoder as png when we are not able to find encoder (dotnet/corefx...
Anirudh Agnihotry [Wed, 17 Apr 2019 06:22:12 +0000 (23:22 -0700)]
adding default encoder as png when we are not able to find encoder (dotnet/corefx#36937)

Commit migrated from https://github.com/dotnet/corefx/commit/dbbabfbf3e5a355b9bde2a01f2effde96631242a

5 years agoRun IBCMerge on Linux build (dotnet/corefx#36924)
Michal Strehovský [Wed, 17 Apr 2019 04:47:15 +0000 (06:47 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36924)

This reverts commit dotnet/corefx@8e843314e1dbd3b3f26abb1f285349be8920cce4.

Commit migrated from https://github.com/dotnet/corefx/commit/f9f88bd7fd774ce433a764b6d388517c6460164a

5 years agofix tests with http/2 (dotnet/corefx#36945)
Tomas Weinfurt [Wed, 17 Apr 2019 04:00:27 +0000 (21:00 -0700)]
fix tests with http/2 (dotnet/corefx#36945)

Commit migrated from https://github.com/dotnet/corefx/commit/f80cf8c360ef00c9a5fdc990e3abd7df23ee0015

5 years agoUpdate testdata versions (dotnet/corefx#36938)
Viktor Hofer [Wed, 17 Apr 2019 00:40:30 +0000 (02:40 +0200)]
Update testdata versions (dotnet/corefx#36938)

* Update testdata versions

* Bump versions in projects and group in TestData

* Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/e5d2b5291277dbd7444d0a17a2bff4784265d917

5 years agoFix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)
David Shulman [Wed, 17 Apr 2019 00:15:30 +0000 (17:15 -0700)]
Fix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)

When the client websocket was going through a proxy, it would sometimes transition to the
'Aborted' state and not the 'Closed' state after a successful closing handshake.

I first opened this bug a year ago but finally was able to get back to it and root cause the
problem. The problem only occured with the managed websocket. The .NET Framework did not have
this problem. And some proxies didn't cause a problem with managed websocket (such as Fiddler).

The root cause is a misinterpretation of RFC 6455, Section 7.1.1. This describes the behavior
of how the websocket's TCP connection should be closed. The most graceful way is to wait for
the server to initiate the close of the socket. In cases where it is taking too long to wait
for the server to start the TCP close, then the client can start the TCP close of the socket.

But no matter how the socket is finally closed, the websocket state should transition to 'Closed'
as soon as a valid closing handshake was performed (i.e. close frames both sent and received).
And this occurs before any logic for closing the TCP connection.

The code in managed websocket has a timer to wait 1 second for the server to start a close. If
the timer finishes, then the managed websocket calls an Abort() method to close the socket. This
ends up transitioning the websocket to an 'Aborted' state which is incorrect. The state should
only be moved to the 'Aborted' state if a closing handshake was not completed.

I added a new test to support this change and moved the LoopbackProxyServer code to Common.

Fixes dotnet/corefx#28027

Commit migrated from https://github.com/dotnet/corefx/commit/0c9684c2c4057908cf697a366a3b1527326e507d

5 years agoFix VB.Core SLN configurations (dotnet/corefx#36934)
Eric StJohn [Tue, 16 Apr 2019 23:06:39 +0000 (16:06 -0700)]
Fix VB.Core SLN configurations (dotnet/corefx#36934)

Commit migrated from https://github.com/dotnet/corefx/commit/39cc91592c3d9c8fe7700a6323755cd7747c34ab

5 years agoadd tests for invalid HTTP headers (dotnet/corefx#36898)
Tomas Weinfurt [Tue, 16 Apr 2019 21:53:07 +0000 (14:53 -0700)]
add tests for invalid HTTP headers (dotnet/corefx#36898)

* add SendAsync_InvalidHeader_Throw

* fix tests

* move SendAsync_InvalidHeader_Throw

Commit migrated from https://github.com/dotnet/corefx/commit/18e1fabd13b40eb6ea88c1b7bae8c4e14a927019

5 years agoUpdate owners (dotnet/corefx#36936)
Carlos Sanchez Lopez [Tue, 16 Apr 2019 21:24:34 +0000 (14:24 -0700)]
Update owners (dotnet/corefx#36936)

Updating ownership in the System.Net area (removing Max and Caesar).
URI - Will.

Commit migrated from https://github.com/dotnet/corefx/commit/c3c0efd9029370ab9762ee254e3db8b8e3dddf34

5 years agoMove EventSource to shared CoreLib partition
Filip Navara [Sun, 14 Apr 2019 20:50:50 +0000 (22:50 +0200)]
Move EventSource to shared CoreLib partition

Commit migrated from https://github.com/dotnet/corefx/commit/00279f8fd11a96f57b8a56855d313f9e2c9bb513

5 years agosupport HTTP/2 without TLS (dotnet/corefx#36753)
Tomas Weinfurt [Tue, 16 Apr 2019 18:54:24 +0000 (11:54 -0700)]
support HTTP/2 without TLS (dotnet/corefx#36753)

* support HTTP/2 without ssl

* feedback from review

* revert changes GetAsync->SendAsync

* remove unused variable

* feedback from review

* feedback from review

* add missong Trace().

Commit migrated from https://github.com/dotnet/corefx/commit/7ed0c5338941346a3cacb4e18f19aaddb283da90

5 years agoReact to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)
Viktor Hofer [Tue, 16 Apr 2019 17:41:48 +0000 (19:41 +0200)]
React to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)

* Manual darc update from build '20190415.12'

* React to RunTests CLI changes

Commit migrated from https://github.com/dotnet/corefx/commit/53f9e9e7fc87cbc08449307fbb0fbe567516e38f

5 years agoRemove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)
Hugh Bellamy [Tue, 16 Apr 2019 14:59:12 +0000 (15:59 +0100)]
Remove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)

* Cleanup System.Runtime.InteropServices code

- Move public classes/enums to their own file
- Use summary instead of devdoc
- Misc

Commit migrated from https://github.com/dotnet/corefx/commit/8d79b6117e9d584eebb8b6933bba83dd514010ca

5 years agoUpdate SDK requirement in windows-instructions
Viktor Hofer [Tue, 16 Apr 2019 11:59:00 +0000 (13:59 +0200)]
Update SDK requirement in windows-instructions

Commit migrated from https://github.com/dotnet/corefx/commit/e2ecd2c33aed216f9a1062044aedf10e25ee8ca4

5 years agoUpgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)
Viktor Hofer [Tue, 16 Apr 2019 07:19:21 +0000 (09:19 +0200)]
Upgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)

* Upgrade SDK to 3.0

* Remove asp and desktop framework references

* Manual darc update from build '20190415.1'

* Suppress type overlap with ns2.1

* Make SDK use output of core-setup for both ref and runtime

SDK is ignoring RuntimeFrameworkVersion for ref packs.  Set TargetingPackVersion
on KnownFrameworkReference instead.

https://github.com/dotnet/sdk/issues/3129

Commit migrated from https://github.com/dotnet/corefx/commit/66bcc2d2b1248ed5384393adf5f3a647d18b75f1

5 years agoRef Assembly and Units for Span.Trim (dotnet/corefx#35576)
Grant [Tue, 16 Apr 2019 01:24:04 +0000 (18:24 -0700)]
Ref Assembly and Units for Span.Trim (dotnet/corefx#35576)

* Units for Trim

* Add ref assembly

* Bug

* Add char units

* Bugs

* CR fixes - 1

* CR fixes - 2

* CR fixes - 3

* CR fixes - 4

* CR fixes - 5

* Revert formatting

* unfo formatting

* Get MemberData working

* Normalize ref

* Manual revert changes

* CR fixes

* Undo code cleanup

* Fixes

* Update ref

* Update ref

* Update ref

* Move memory tests

* Revert StringTests

* Remove redundant unit code

* Add missing refs

* Bug

* dotnet msbuild /t:GenerateReferenceSource

* Revert unintended changes

* POC : Check if fix works

* Fix units

* Revert temp test

* Update ApiCompatBaseline.uapaot.txt

Commit migrated from https://github.com/dotnet/corefx/commit/2191763a765654710df5317dc65dc7cd935bc8c1

5 years agoadd test for lower casing header name logic (dotnet/corefx#36708)
Tomas Weinfurt [Mon, 15 Apr 2019 22:15:32 +0000 (15:15 -0700)]
add test for lower casing header name logic  (dotnet/corefx#36708)

* add test for 35164

* update SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2

* fix uwp tests

* change port from 123 to 443

Commit migrated from https://github.com/dotnet/corefx/commit/4e3b46c22cec88a1f0deaa2f594634e5553412e1

5 years agoRemove null coalescing assignment operator to avoid build-from-source compile issues...
Steve Harter [Mon, 15 Apr 2019 21:44:04 +0000 (14:44 -0700)]
Remove null coalescing assignment operator to avoid build-from-source compile issues (dotnet/corefx#36890)

Commit migrated from https://github.com/dotnet/corefx/commit/f78e9881bd8ef1def0227569d822693b944378a7

5 years agoClose the socket if bind() fails (dotnet/corefx#36769)
Omair Majid [Mon, 15 Apr 2019 20:55:02 +0000 (16:55 -0400)]
Close the socket if bind() fails (dotnet/corefx#36769)

When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.

Commit migrated from https://github.com/dotnet/corefx/commit/03ae543d4da4e539b9915a5f38f36a69739fa9d9

5 years agoJson deserializer collection perf improvements by avoiding boxing (dotnet/corefx...
Steve Harter [Mon, 15 Apr 2019 17:58:03 +0000 (10:58 -0700)]
Json deserializer collection perf improvements by avoiding boxing (dotnet/corefx#36865)

Commit migrated from https://github.com/dotnet/corefx/commit/6bfaf4116b5180c857bf6ad531f0655fd57c5eef

5 years agoRemove myget publish entirely (dotnet/corefx#36886)
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:55:42 +0000 (12:55 -0500)]
Remove myget publish entirely (dotnet/corefx#36886)

Commit migrated from https://github.com/dotnet/corefx/commit/d601d2e7602c9dbb6ae0d95c450bce2db027f78d

5 years agoAdd guard for runtimes that support large arrays (dotnet/corefx#36883)
Filip Navara [Mon, 15 Apr 2019 16:46:18 +0000 (18:46 +0200)]
Add guard for runtimes that support large arrays (dotnet/corefx#36883)

Commit migrated from https://github.com/dotnet/corefx/commit/679dba7531d3be10b387203c9a9f350f39ea3a8a

5 years agoRestore internal tools using .net core restore (dotnet/corefx#36840)
Santiago Fernandez Madero [Mon, 15 Apr 2019 16:03:58 +0000 (11:03 -0500)]
Restore internal tools using .net core restore (dotnet/corefx#36840)

* Restore internal tools using .net core restore

* Restore internal tools from dnceng-internal

Bump TestILC version

* Manual Darc update from build '20190414.2'

* Add buildExtraArguments to common

Commit migrated from https://github.com/dotnet/corefx/commit/10d7d6f812295a572eb148aedb19efd2f96fbe17

5 years agoAdd more number converter tests (dotnet/corefx#36653)
Hugh Bellamy [Mon, 15 Apr 2019 14:15:24 +0000 (15:15 +0100)]
Add more number converter tests (dotnet/corefx#36653)

* Add more number converter tests

* Fix if bug in BaseNumberConverter

* Address PR feedback

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/25c10204a69c09afd0701740d1555eba04496c71

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively...
dotnet-maestro-bot [Mon, 15 Apr 2019 04:10:26 +0000 (21:10 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively (dotnet/corefx#36867)

Commit migrated from https://github.com/dotnet/corefx/commit/81e0e2cb79e272e6e270c6562017b64f9c773e99

5 years agoSocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx...
Tom Deseyn [Mon, 15 Apr 2019 01:48:56 +0000 (03:48 +0200)]
SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx#36721)

* SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling

DangerousGetHandle was used here for performance. SafeHandle marshalling is
faster now, and preferable to avoid using invalid handles.

* Socket.Windows: replace DangerousGetHandle with SafeHandle marshalling for async operations

Commit migrated from https://github.com/dotnet/corefx/commit/88b6ebe8faaadb027c1378132dc9767c13912159

5 years agoCleanup SocketOptionNameTest (dotnet/corefx#36864)
David Shulman [Mon, 15 Apr 2019 01:34:25 +0000 (18:34 -0700)]
Cleanup SocketOptionNameTest (dotnet/corefx#36864)

One of the oldest issues dotnet/corefx#4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.

At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.

As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.

Closes dotnet/corefx#29929
Closes dotnet/corefx#21327
Closes dotnet/corefx#4887

Commit migrated from https://github.com/dotnet/corefx/commit/f389a14d375ef90f971bc15095b925f73845a7d3

5 years agoRemove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet...
Tanner Gooding [Mon, 15 Apr 2019 00:46:34 +0000 (17:46 -0700)]
Remove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet/corefx#36866)

Commit migrated from https://github.com/dotnet/corefx/commit/7336f57f745e7399803902efca8fd085ff6ca326

5 years agoImplement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)
Ganbarukamo41 [Sun, 14 Apr 2019 23:34:34 +0000 (00:34 +0100)]
Implement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)

* Implement IEquatable to Memory and ReadOnlyMemory

* Add equality tests using IEquatable of ReadOnlyMemory and Memory

* Fix and add tests for Memory and ReadOnlyMemory
* Fixed where IEquatable interface tests were using object.Equals(object) instead of T.Equals(T)
* Added IEquatable interface tests for Memory of different types (char, string)

* Fix IEquatable tests for Memory and ReadOnlyMemory
* Fix tests that were missed in the previous commit (IEquatable tests calling object.Equals(object))
* Should use ReadOnlyMemory in ReadOnlyMemory tests

* Update uapaot baseline for dotnet/corefx#36497

Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)

* Update uapaot baseline for dotnet/corefx#36497

Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Remove baselines added to System.Runtime by mistake
* Add baselines to System.Memory

* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Add removed baselines to System.Runtime again

Commit migrated from https://github.com/dotnet/corefx/commit/68920bb0764fb13257f710f44dd08e85e4a35c7c

5 years agoFix build (dotnet/corefx#36862)
Krzysztof Wicher [Sun, 14 Apr 2019 19:31:59 +0000 (12:31 -0700)]
Fix build (dotnet/corefx#36862)

Commit migrated from https://github.com/dotnet/corefx/commit/822da3133d02da072843ffe7715c6af29d0c4192

5 years agoRemove myget feeds (dotnet/corefx#36797)
Santiago Fernandez Madero [Sun, 14 Apr 2019 17:31:01 +0000 (12:31 -0500)]
Remove myget feeds (dotnet/corefx#36797)

* Remove myget feeds

* Bump compression testdata package version

Commit migrated from https://github.com/dotnet/corefx/commit/0aa6ccc261165e9e045a6aab6218f3e71f99e0f4

5 years agoImprove HttpClient POST with REDIRECT tests (dotnet/corefx#36848)
David Shulman [Sun, 14 Apr 2019 03:16:43 +0000 (20:16 -0700)]
Improve HttpClient POST with REDIRECT tests (dotnet/corefx#36848)

This PR is similar to dotnet/corefx#36801 and dotnet/corefx#36828 which improved upload tests stability.

Modify the POST with REDIRECT test to use the VerifyUpload endpoint which avoids
having to echo back the large request body.

Closes dotnet/corefx#36220

Commit migrated from https://github.com/dotnet/corefx/commit/52d4723aaa8e561a6f36589a6d1e112287c0308b

5 years agoAdd Assembly.LoadWithPartialName cases (dotnet/corefx#36803)
Steve MacLean [Sun, 14 Apr 2019 01:57:06 +0000 (21:57 -0400)]
Add Assembly.LoadWithPartialName cases (dotnet/corefx#36803)

* Add Assembly.LoadWithPartialName cases

Cover hole reported in dotnet/coreclrdotnet/corefx#19817

* Verify argument parameter name

* Disable new test on .NetFramework

Commit migrated from https://github.com/dotnet/corefx/commit/5ae3c5655cd84bf3c7f9568477153642fdd7c95e

5 years agoContextual reflection (dotnet/corefx#36845)
Steve MacLean [Sun, 14 Apr 2019 01:56:49 +0000 (21:56 -0400)]
Contextual reflection (dotnet/corefx#36845)

* Add ContextualReflection facade

* Update ApiCompatBaseline.uapaot

Commit migrated from https://github.com/dotnet/corefx/commit/3e2be4796df626d7f4e73c0018992c4f4aa60627

5 years agoFix bad null check in pal_dsa.c
Omair Majid [Mon, 8 Apr 2019 14:40:49 +0000 (10:40 -0400)]
Fix bad null check in pal_dsa.c

The code calls DSA_new() and then, only after assigning the value from
DSA_new to a pointer, tries to check that the pointer was not null.
Assigning to a null pointer leads to undefined behaviour and a compiler
can assume that assignment-to-a-null-pointer wont happen. Subsequently,
the compiler can remove the entire check because the pointer can't be
null.

Fix that by:

1. Moving the check for whether the pointer is null before dereferncing
   the pointer.

2. Checking the return value of DSA_new() spearately after it has been
   called.

Commit migrated from https://github.com/dotnet/corefx/commit/e7fd1669eafafd16de85cd90b558d54abb3a3343

5 years agoJsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)
Steve Harter [Sat, 13 Apr 2019 22:32:49 +0000 (15:32 -0700)]
JsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)

Commit migrated from https://github.com/dotnet/corefx/commit/b06250eb9ef50bca50cf7676e87753dbd8b5470a

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)
dotnet-maestro[bot] [Sat, 13 Apr 2019 18:53:57 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73
- Also react to changes in the UTF-8 transcoding logic (dotnet/corefx#36712)

Commit migrated from https://github.com/dotnet/corefx/commit/4c3d4a083488b9f89676926a8b75aa5f7572f67f

5 years agoaddress feedback from 36775 (dotnet/corefx#36839)
Krzysztof Wicher [Sat, 13 Apr 2019 17:46:05 +0000 (10:46 -0700)]
address feedback from 36775 (dotnet/corefx#36839)

Commit migrated from https://github.com/dotnet/corefx/commit/c3981ca2455f8a6593301bac1adb363d02934954

5 years agoFix LsaOpenPolicy interop definition
Hugh Bellamy [Sat, 13 Apr 2019 16:52:14 +0000 (17:52 +0100)]
Fix LsaOpenPolicy interop definition

* Move Lsa handles to Interop code

* Fix implementation of LsaOpenPolicy

* Move LSA_STRING and LSA_UNICODE_STRING to Advapi32

* Consolidate LSA_UNICODE_STRING and UNICODE_STRING

Commit migrated from https://github.com/dotnet/corefx/commit/f5e2679e76c102aea8218ae290ffb7f4d97e9cc2

5 years agoFix encoding of Digest authentication headers (dotnet/corefx#36627)
Filip Navara [Sat, 13 Apr 2019 16:07:10 +0000 (18:07 +0200)]
Fix encoding of Digest authentication headers (dotnet/corefx#36627)

* Fix encoding of Digest authentication headers for servers that don't understand RFC 5987 encoding

* Quote-prefix special characters when encoding Digest headers

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/cce7870129dcca472f4e6108e21e87bc9573b8d2

5 years agoAllow cookies with spaces in the name (dotnet/corefx#36566)
Paito Anderson [Sat, 13 Apr 2019 15:28:21 +0000 (11:28 -0400)]
Allow cookies with spaces in the name (dotnet/corefx#36566)

* Allow cookies with spaces in the name

* Apply suggestions from code review

Co-Authored-By: PaitoAnderson <pj.paito@gmail.com>
* Added supporting HttpClient functional cookie test

* Updated UWP cookie class and added additional tests

* Prevent cookies with spaces at the start or end

* Forgot UWP

* Fix could allocate on trim

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Better cookie space start/end check

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Bring checks into line

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Skip test on .net framework

* Skip additional tests on .net framework

* Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/8a22438a1af870cdd04eaf798b155b8a1ab04cb4

5 years agoRead system proxy information on macOS (dotnet/corefx#36177)
Filip Navara [Sat, 13 Apr 2019 15:19:53 +0000 (17:19 +0200)]
Read system proxy information on macOS (dotnet/corefx#36177)

* Read system proxy information on macOS

* Replace CFRunLoopRemoveSource with CFRunLoopSourceInvalidate to mimic recommended flow from Chromium / WebKit

Commit migrated from https://github.com/dotnet/corefx/commit/2aa2518a47c541148e2dc3f9d040942e44395acd

5 years agoFix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)
Alexander Köplinger [Sat, 13 Apr 2019 04:47:30 +0000 (06:47 +0200)]
Fix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)

It was a Theory instead of a Fact and the method parameter wasn't being used.

Commit migrated from https://github.com/dotnet/corefx/commit/1a83ff9b6d6d3406a6ef800dbe2bc7a74e4d5d3c

5 years agooverwrite -> overwriteFiles (dotnet/corefx#36831)
Maira Wenzel [Sat, 13 Apr 2019 04:46:42 +0000 (21:46 -0700)]
overwrite -> overwriteFiles (dotnet/corefx#36831)

Commit migrated from https://github.com/dotnet/corefx/commit/326246059f3e7422e39dd71f2e1541c0288777d0

5 years agoPort ErrObject and CreateProjectError (dotnet/corefx#36808)
Charles Stoner [Sat, 13 Apr 2019 04:45:11 +0000 (21:45 -0700)]
Port ErrObject and CreateProjectError (dotnet/corefx#36808)

* Port ErrObject and CreateProjectError

* PR feedback

* Add FilterDefaultMessage test

Commit migrated from https://github.com/dotnet/corefx/commit/e2ab05d35f00f9cd9a92a94284698cc241f8380d

5 years agoAdd support for generic interface-based collections in JsonSerializer (dotnet/corefx...
Layomi Akinrinade [Sat, 13 Apr 2019 01:44:18 +0000 (21:44 -0400)]
Add support for generic interface-based collections in JsonSerializer (dotnet/corefx#36756)

* Add support for generic interface-based collections in JsonSerializer

Specifically, add enumerable converters for:

* IEnumerable<T>
* ICollection<T>
* IList<T>
* IReadOnlyCollection<T>
* IReadOnlyList<T>

This partially addresses https://github.com/dotnet/corefx/issues/36643

* Address review comments

* Add serialization tests for generic interface collection as members of class objects

Commit migrated from https://github.com/dotnet/corefx/commit/cc01ec9a781c4af5afd495c5b80a1f7d9616bed2

5 years agoCipherSuitePolicy implementation (dotnet/corefx#36775)
Krzysztof Wicher [Sat, 13 Apr 2019 01:23:31 +0000 (18:23 -0700)]
CipherSuitePolicy implementation (dotnet/corefx#36775)

* CipherSuitePolicy implementation (Linux)

* SSL_CIPHER_find

* do not call TLS1.3 APIs on platforms which don't support it

* Non-TLS1.3 specific tests are skipped when not enough cipher suites is enabled

* clean ups

* attempt to fix OSX

* another attempt to fix OSX

* missing define

* address some feedback, try to fix test failures

* portable build fix

* do not call old set ciphers API when only TLS 1.3 is requested

* apply feedback

* add OSX implementation

* fixes to OSX

* explicit convert

* use explicit SSLCipherSuite instead of uint16_t

* random change to trigger CI

* s/unsafe/fixed

* fixes

* random change to trigger CI

* client ordering does not have to win

* tests: AllowedCipherSuites, new CipherSuitesPolicy(null)

* run AllowedCipherSuites tests only when CSP is supported

* add summary on CipherSuitesPolicy

* address feedback

* move OS specific files to CipherSuitesPolicyPal

* FALLBACK->LIGHTUP and remove local_

* do not call 1.1.1 function on non-portable build when lower openssl version is installed

* get rid of warning that arg is unused

* make CipherSuitesPolicyPal public members internal

Commit migrated from https://github.com/dotnet/corefx/commit/07f443b6c9f27dd050ffb5eb3afa126a2b1bdddd

5 years agoAdd JsonElement.Clone to make a long-term persistable copy
Jeremy Barton [Sat, 13 Apr 2019 00:37:52 +0000 (17:37 -0700)]
Add JsonElement.Clone to make a long-term persistable copy

Commit migrated from https://github.com/dotnet/corefx/commit/cd020c11b563b51f439324bcefc559d1408f4e09

5 years agoImprove WebClient upload tests stability (dotnet/corefx#36828)
David Shulman [Sat, 13 Apr 2019 00:27:40 +0000 (17:27 -0700)]
Improve WebClient upload tests stability (dotnet/corefx#36828)

This PR is a follow-up to PR dotnet/corefx#36801 which improved HttpClient tests stability.

Some of the WebClient tests were failing with WebExceptions being caused by the
Azure remote endpoint returning 500 status code. Similar to the fixes done to
the HttpClient tests, this PR updates some of the WebClient upload tests to use
the VerifyUpload endpoint which doesn't have to echo back the request body payload.

Some of the WebClient tests upload more complex multi-part formats and can't be
easily changed to use the VerifyUpload endpoint. But those tests aren't using large
data sets so it should be ok.

Closes dotnet/corefx#36226

Commit migrated from https://github.com/dotnet/corefx/commit/00e9390eb0e9b95a410bd3e91b2c58cf9ec85d95