platform/upstream/efl.git
6 years agocanvas render: stop render_pre/post cb if it didn't render.
Hermet Park [Thu, 12 Jul 2018 13:14:32 +0000 (09:14 -0400)]
canvas render: stop render_pre/post cb if it didn't render.

Summary:
Basically, render_pre/post should be called only if rendering happens.
Unfortunately, this behavior had been broken by some mistakes.

As far as I understand after reading history carefully,
this issue introduced for fixing unpair of pre/post cbs.

In case of async render, the post callback would be triggered in
evas_render_pipe_wakeup(), it means POST callbake shouldn't be tiggered in
evas_render_updates_internal(). If that post callback were removed in
evas_render_updates_internal(), then in case of sync_render,
POST callback won't be triggered. So previously, the PRE/POST couldn't get
paired.

I guess cedric put a mistake that nothing2rendering which brought
the pre/post pair issue, even he said that patch fix the unpair of them.
(But actually that patch brought the issue!)

See this: dc841ed9b2ccf880df2d7590ea46d95e03e8752f

Whatever it was intented or not, that patch totally insane, even
non-descripting.

If we just trigger post cb only if sync render or no_rendered case,
We could make satisfication for both cases.

@fix

Reviewers: #committers, devilhorns, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6573

Change-Id: I267072faf71838b0ff4902b5c45e499a3f2af423

6 years agoecore_wl2_dnd: Supporting copy and paste for cbhm
Taehyub Kim [Thu, 26 Jul 2018 06:15:45 +0000 (15:15 +0900)]
ecore_wl2_dnd: Supporting copy and paste for cbhm

- cbhm needs multiple mimetypes when selection occurs

Change-Id: I4b80e8df2615a5904cb122e8af5aaeae48e9385e

6 years agoefl_selection_manager, ecore_wl2_dnd: Supporting Drag and Drop
Taehyub Kim [Thu, 26 Jul 2018 06:04:17 +0000 (15:04 +0900)]
efl_selection_manager, ecore_wl2_dnd: Supporting Drag and Drop

- There is a problem that the visibility of drag_win(ELM_WIN_DND) depends on the order of show and resize.
  Normally, The order should not be matter, but drag_win is visible in show and resize order not resize and show order.
  So It should be fixed later.
- Ecore_Wl2_Event_Dnd_End is changed to Ecore_Wl2_Event_Data_Source_End in efl_selection_manager.c to make it consistency.
- Serial logic in efl_selection_manager.c is not stable now, so disable it.

Change-Id: I67aa5a4fb4f4c26192a2a638ca45063dc2457c49

6 years agoRevert "Revert "efl_ui_win: add missing wayland interface for setting role of winodw""
Taehyub Kim [Thu, 26 Jul 2018 08:09:16 +0000 (17:09 +0900)]
Revert "Revert "efl_ui_win: add missing wayland interface for setting role of winodw""

This reverts commit 95b7a0938871585491ebe10e53ed04f53b3afde9.

Change-Id: I7d54541fa2403c64f1d4752add898ef741d1707b

6 years agoevas : apply tizen only for evas gl thread support
SangHyeon Jade Lee [Wed, 1 Aug 2018 05:30:34 +0000 (14:30 +0900)]
evas : apply tizen only for evas gl thread support

Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
6 years agoelm/bg: call color_set up the class chain internally
Mike Blumenkrantz [Tue, 31 Jul 2018 22:49:57 +0000 (18:49 -0400)]
elm/bg: call color_set up the class chain internally

Summary:
this ensures that the color_set call is propagated correctly, resulting
eventually in a call to the smart clipped class method for color_set which
will change the opacity of the edje object in addition to the bg widget's
internal rect object

this seems to have been a regression created during the move to the interfaces
version of the bg widget

fix T7232

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7232

Differential Revision: https://phab.enlightenment.org/D6716

6 years agoelementary: Check for valid object before calling smart calculate
Chris Michael [Tue, 31 Jul 2018 21:23:46 +0000 (17:23 -0400)]
elementary: Check for valid object before calling smart calculate

Summary:
Small patch fixes an issue where evas_object_smart_calculate was being
called with a NULL box.

ref T7030
Depends on D6704

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6710

6 years agoecore_evas: Make sure a manual render does a manual render
Derek Foreman [Tue, 31 Jul 2018 21:02:39 +0000 (17:02 -0400)]
ecore_evas: Make sure a manual render does a manual render

Summary:
If we call ecore_evas_manual_render() during an async render, it does
nothing.

This is harmful if we've added render post callbacks during that async
render and expect them to fire.

Force a sync and another render if we're in an async render.

ref T7156
Depends on D6714

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7156

Differential Revision: https://phab.enlightenment.org/D6715

6 years agoecore_evas: Sync evas on manual_render_set
Derek Foreman [Tue, 31 Jul 2018 21:02:17 +0000 (17:02 -0400)]
ecore_evas: Sync evas on manual_render_set

Summary:
Make sure any ongoing async rendering is finished before manual_render_set
returns.
Depends on D6711

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6714

6 years agoevas: Defer render post callbacks added during async render
Derek Foreman [Tue, 31 Jul 2018 21:02:12 +0000 (17:02 -0400)]
evas: Defer render post callbacks added during async render

Summary:
To take screenshots, Enlightenment makes a new snapshot object, performs
a manual render, and uses the snapshot results.

Turns out if this happens while an async render is in progress, the
async render's completion triggers a render post callback on the snapshot
object even though it's never been involved in a render.

We need to defer new render post callbacks until any currently running
render completes, then add them during that render's post.

Fix T7156

Reviewers: devilhorns, zmike

Reviewed By: devilhorns, zmike

Subscribers: devilhorns, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7156

Differential Revision: https://phab.enlightenment.org/D6711

6 years agoeina: Add doxygen in/out tags for value and value_util
Bryce Harrington [Tue, 31 Jul 2018 20:40:43 +0000 (16:40 -0400)]
eina: Add doxygen in/out tags for value and value_util

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6713

6 years agoeina: Add doxygen in/out tags for rbtree
Bryce Harrington [Tue, 31 Jul 2018 19:27:08 +0000 (15:27 -0400)]
eina: Add doxygen in/out tags for rbtree

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6709

6 years agoeina: Add doxygen in/out tags for quaternion
Bryce Harrington [Tue, 31 Jul 2018 19:16:39 +0000 (15:16 -0400)]
eina: Add doxygen in/out tags for quaternion

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6708

6 years agoefl_model: fix redefine warning
Marcel Hollerbach [Tue, 31 Jul 2018 15:26:19 +0000 (11:26 -0400)]
efl_model: fix redefine warning

Summary:
The struct definition here is not needed as it will be redefined anyways
later in the efl_model.eo.h header.
Depends on D6705

Reviewers: zmike, #committers, lauromoura, felipealmeida

Reviewed By: zmike, #committers

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6706

6 years agoelm_multibuttonentry: do not define multiple times the same structs
Marcel Hollerbach [Tue, 31 Jul 2018 15:26:17 +0000 (11:26 -0400)]
elm_multibuttonentry: do not define multiple times the same structs

Summary: There is no reason to typedef Elm_Multibuttonentry multiple times, the header file can be included, there is no cyclic dependency.

Reviewers: CHAN, zmike, #committers

Reviewed By: zmike, #committers

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6705

6 years agoregion_add: Fix copying wrong rect during smart merge
Yeshwanth Reddivari [Tue, 31 Jul 2018 12:29:03 +0000 (07:29 -0500)]
region_add: Fix copying wrong rect during smart merge

Summary:
When testing partial rendering on TV, found this bug.
Probably this was caused because of wrong copy/paste.
When region1 completely subsumes region2, region2 should be ignored.
But currently region2 is copied to region1 which makes region1 rect completly wrong.
This was causing lot of visual defects because of wrong rects.
This patch will fix those visual defects when partial rendering is enabled.

Test Plan: Tested with the patch on TV after enabling partial rendering.

Reviewers: raster, cedric, Hermet, ManMower

Reviewed By: ManMower

Subscribers: bu5hm4n, ajwillia.ms, ManMower, devilhorns, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6696

6 years agoeina: Add doxygen in/out tags for promise
Bryce Harrington [Tue, 31 Jul 2018 06:51:02 +0000 (02:51 -0400)]
eina: Add doxygen in/out tags for promise

Summary: Also, add some missing param docs, and fix some incorrect ones.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6698

6 years agobuild: disable eolian implicit rules in subdir builds
Mike Blumenkrantz [Fri, 20 Jul 2018 23:22:59 +0000 (19:22 -0400)]
build: disable eolian implicit rules in subdir builds

the ../ rules override the global rules to block actions which would
force eolian to generate files which should be managed by a higher
level makefile

this cuts a substantial amount of time out of distcheck from example
builds

Differential Revision: https://phab.enlightenment.org/D6660

6 years agobuild: use $(@D) for eolian directory name
Mike Blumenkrantz [Fri, 20 Jul 2018 23:21:31 +0000 (19:21 -0400)]
build: use $(@D) for eolian directory name

this is cosmetic; $(@D) is the standard automatic variable set to the directory
part of the target

https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html

Differential Revision: https://phab.enlightenment.org/D6659

6 years agoci: disable dependency tracking in ci builds
Mike Blumenkrantz [Fri, 20 Jul 2018 22:37:16 +0000 (18:37 -0400)]
ci: disable dependency tracking in ci builds

ci builds are only built once, so tracking dependencies is just a waste
of build time

Differential Revision: https://phab.enlightenment.org/D6658

6 years agobuild: disable dependency tracking in distcheck builds
Mike Blumenkrantz [Fri, 20 Jul 2018 22:35:49 +0000 (18:35 -0400)]
build: disable dependency tracking in distcheck builds

files are only built once during distcheck, so tracking file changes
is just a waste of build time

Differential Revision: https://phab.enlightenment.org/D6657

6 years agoefl_selection: reintroduce missing ELM_CNP_EVENT_SELECTION_CHANGED symbol.
Alastair Poole [Mon, 30 Jul 2018 15:42:28 +0000 (11:42 -0400)]
efl_selection: reintroduce missing ELM_CNP_EVENT_SELECTION_CHANGED symbol.

Summary:
During the 1.21 development cycle the symbol ELM_CNP_EVENT_SELECTION_CHANGED was lost.

The commit which introduced this:  e88bbaa1e314751e5c1a04dec7f1f179188428ae

This patch re-introduced the symbol and expected behaviour.

Reviewers: #committers, zmike, bu5hm4n, herb

Reviewed By: #committers, zmike

Subscribers: herb, ManMower, segfaultxavi, stefan_schmidt, cedric, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6689

6 years agoci: use gold linker for linux builds
Mike Blumenkrantz [Fri, 20 Jul 2018 18:24:10 +0000 (14:24 -0400)]
ci: use gold linker for linux builds

this is a substantially faster linker which should yield some speedups
for our builds

Differential Revision: https://phab.enlightenment.org/D6655

6 years agoci: disable tests on macos
Mike Blumenkrantz [Fri, 20 Jul 2018 18:12:27 +0000 (14:12 -0400)]
ci: disable tests on macos

these all fail currently due to some dbus issues

ref T7174

Differential Revision: https://phab.enlightenment.org/D6654

6 years agotests/ecore: remove tolerance threshold from ecore_timer_reset test case
Mike Blumenkrantz [Fri, 20 Jul 2018 15:46:41 +0000 (11:46 -0400)]
tests/ecore: remove tolerance threshold from ecore_timer_reset test case

unit tests should test one thing only: testing timer accuracy and the
effectiveness of resetting a timer in the same test leads to timing issues,
so remove the timing component from the test

ref T6878

Differential Revision: https://phab.enlightenment.org/D6653

6 years agoci: attempt to print the test logs if distcheck fails
Mike Blumenkrantz [Fri, 20 Jul 2018 15:40:58 +0000 (11:40 -0400)]
ci: attempt to print the test logs if distcheck fails

distcheck failures from test failures are hard to debug since distcheck
is more complicated than a regular build, this is a first step in providing
info for that debugging

Differential Revision: https://phab.enlightenment.org/D6652

6 years agoci: disable built-in make rules and variables
Mike Blumenkrantz [Fri, 20 Jul 2018 15:26:05 +0000 (11:26 -0400)]
ci: disable built-in make rules and variables

these slow down build times and don't benefit us

Differential Revision: https://phab.enlightenment.org/D6651

6 years agobuild: fix rpath for binaries which use ecore-x dependencies
Mike Blumenkrantz [Thu, 19 Jul 2018 23:42:57 +0000 (19:42 -0400)]
build: fix rpath for binaries which use ecore-x dependencies

somehow ecore-x explicitly pulls in ${libdir}/libX11.so at link-time,
which causes libtool to add ${libdir} to the rpath executable wrappers
before the remainder of the in-tree efl paths. this causes binaries run
from these wrappers (e.g., tests, built-time tools such as codegens) to
use system libraries instead of in-tree libraries

@fix

Differential Revision: https://phab.enlightenment.org/D6635

6 years agobuild: use $() for automake variables, not ${}
Mike Blumenkrantz [Thu, 19 Jul 2018 23:42:27 +0000 (19:42 -0400)]
build: use $() for automake variables, not ${}

this is not a functional change, just increasing consistency
https://www.gnu.org/software/make/manual/html_node/Reference.html#Reference

Differential Revision: https://phab.enlightenment.org/D6634

6 years agoelm_entry: make the hoversel not focusable
Marcel Hollerbach [Mon, 30 Jul 2018 12:18:02 +0000 (13:18 +0100)]
elm_entry: make the hoversel not focusable

Summary:
the hoversel is added to a entry while entrys are not build for handling
children focus. Disabling this prevents wrong focus operations.

fix T7163

Reviewers: zmike, #committers, netstar

Reviewed By: netstar

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7163

Differential Revision: https://phab.enlightenment.org/D6695

6 years agoeina: Add doxygen in/out tags for mmap and module
Bryce Harrington [Sat, 28 Jul 2018 15:50:49 +0000 (11:50 -0400)]
eina: Add doxygen in/out tags for mmap and module

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6691

6 years agoeina: Add doxygen in/out tags for log
Bryce Harrington [Sat, 28 Jul 2018 00:20:44 +0000 (20:20 -0400)]
eina: Add doxygen in/out tags for log

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6690

6 years agoelm_code_widget: fix keyboard and scrolling with active selection.
Alastair Poole [Fri, 27 Jul 2018 14:20:24 +0000 (15:20 +0100)]
elm_code_widget: fix keyboard and scrolling with active selection.

Summary:
This adds some attributes to the selectiont type in elm_code.
Including the type (whether it is mouse or keyboard) and also whether
a selection is in progress. Thus we can reliably select around the
file and also move/scroll when there is an active selection.

Test Plan:
Drag and select text with mouse. Also the same with keyboard (hold shift and select).
Leave selection active and scroll around the file. The selection should remain and
full movement is possible while retaining the active selection. This could really
be refactored for a next major release.

Reviewers: #committers, ajwillia.ms, cedric

Reviewed By: ajwillia.ms

Subscribers: zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6676

6 years agoeina: Add doxygen in/out tags for lalloc and list
Bryce Harrington [Fri, 27 Jul 2018 07:59:44 +0000 (03:59 -0400)]
eina: Add doxygen in/out tags for lalloc and list

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6688

6 years agoevas: handle all failure cases with error messages in evas_init
Mike Blumenkrantz [Thu, 26 Jul 2018 12:43:50 +0000 (21:43 +0900)]
evas: handle all failure cases with error messages in evas_init

Summary: fix T7026

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T7026

Differential Revision: https://phab.enlightenment.org/D6677

6 years agoedje: handle all failure cases with error messages in init
Mike Blumenkrantz [Thu, 26 Jul 2018 12:30:03 +0000 (21:30 +0900)]
edje: handle all failure cases with error messages in init

Summary:
fix T7025
Depends on D6677

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T7025

Differential Revision: https://phab.enlightenment.org/D6678

6 years agoelm: handle all failure cases with error messages in init
Mike Blumenkrantz [Thu, 26 Jul 2018 12:13:46 +0000 (21:13 +0900)]
elm: handle all failure cases with error messages in init

Summary:
fix T7021
Depends on D6678

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T7021

Differential Revision: https://phab.enlightenment.org/D6679

6 years agoeina: Add doxygen in/out tags for inlist and iterator
Bryce Harrington [Thu, 26 Jul 2018 11:04:46 +0000 (20:04 +0900)]
eina: Add doxygen in/out tags for inlist and iterator

Reviewers: segfaultxavi

Subscribers: segfaultxavi, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6686

6 years agoevas: don't call filter shutdown twice in evas shutdown 77/185277/1
Youngbok Shin [Fri, 27 Jul 2018 07:14:31 +0000 (16:14 +0900)]
evas: don't call filter shutdown twice in evas shutdown

The above filter shutdown call is remained by wrong conflict resolution

Change-Id: I4479f335a394cf89cde844e4d0e157096716ab6a

6 years agoRevert "spec: Disable neon temporally"
Wonki Kim [Thu, 26 Jul 2018 04:31:02 +0000 (13:31 +0900)]
Revert "spec: Disable neon temporally"

This reverts commit 0ee57f3b6f17bae02e127463133f1f35e9be3e51.

Change-Id: Ic71a0fb36e736451003d49c128d9a04fe3e9830c
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agoecore_main: check ecore_event generated by _ecore_main_prepare_handlers
Youngbok Shin [Thu, 26 Jul 2018 09:29:30 +0000 (18:29 +0900)]
ecore_main: check ecore_event generated by _ecore_main_prepare_handlers

   For thread-safet related with wayland, below code was added.
   https://review.tizen.org/gerrit/#/c/64820/
   after this code, ecore_event related with wayland can be generated by prehandler.
   so before waiting the select function, we need to check one more time
   that ecore event was generated by prepare handler.

Change-Id: I1f3d5c4431bc277583b12a2754c35c79e308cc77
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
6 years agoFix for missing move-out signal, when scrolling genlist
Youngbok Shin [Thu, 26 Jul 2018 09:27:55 +0000 (18:27 +0900)]
Fix for missing move-out signal, when scrolling genlist

Change-Id: Idbe8db804eafd350841bb4384b4337c0060d7177

6 years agoevas canvas: fix not to trigger unnecessary events.
Hermet Park [Tue, 24 Jul 2018 16:04:11 +0000 (12:04 -0400)]
evas canvas: fix not to trigger unnecessary events.

Summary:
Here comparision is logically wrong because it compares
the coordinates(cur, prev) of the different spaces.

As you can see just above the conditions,
Cur coordinates could be transformed into the map space (if objs have)
on the otherhands, prev is not. These wrong condition could occur
embarassing event trigger.

@fix

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6674

Change-Id: I401deade25fe890a3e2bddafd1b0a68f4e388dd2

6 years ago[evas_gl_tbm] do not use hash
Joogab Yun [Mon, 16 Jul 2018 10:30:19 +0000 (19:30 +0900)]
[evas_gl_tbm] do not use hash

    The newly created address of buffer may be rarely the
    same as the previous value.
    So, the hash returns the wrong image.

    do not use hash as a workaround.

Change-Id: I10400b5d704619ca114324236b96d8006ff6e143

6 years agogenlist: check item validation in ELM_GENLIST_ITEM_CHECK
SangHyeon Jade Lee [Mon, 23 Jul 2018 07:49:20 +0000 (16:49 +0900)]
genlist: check item validation in ELM_GENLIST_ITEM_CHECK

Change-Id: Ic29a036858cd0c82e2185c9d457e97d912af0e21

6 years agoFixes several issues with cleanup in accessibility
Radoslaw Cybulski [Wed, 18 Jul 2018 10:42:15 +0000 (12:42 +0200)]
Fixes several issues with cleanup in accessibility

Change-Id: I01dcafb562a5ba82746174148133e819fd5c8541

6 years agoevas_events: add storing last mouse device
Youngbok Shin [Thu, 26 Jul 2018 09:09:51 +0000 (18:09 +0900)]
evas_events: add storing last mouse device

@tizen_fix
Change-Id: I113326bbf659d4cf72189697b3ed381b27126f80

6 years agoecore_evas: when window resized in ecore_evas, check evas rotate state.
Umesh Tanwar [Wed, 18 Jul 2018 12:10:21 +0000 (08:10 -0400)]
ecore_evas: when window resized in ecore_evas, check evas rotate state.

Summary:
when ecore_evas is resized, get evas' size,
but angle not checked, so put a check.

@fix

Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: Hermet, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6627

Change-Id: I3342cbb5948f03825345dd42e60a906f998ceec9

6 years agotests/eio: increase monitoring test timeout to 1s
Mike Blumenkrantz [Tue, 17 Jul 2018 21:17:12 +0000 (17:17 -0400)]
tests/eio: increase monitoring test timeout to 1s

this should only affect CI builds, allowing more time for tests to
process on the insanely slow virtual hw

Differential Revision: https://phab.enlightenment.org/D6623

6 years agoci: disable tests on misc builds
Mike Blumenkrantz [Sat, 14 Jul 2018 04:46:58 +0000 (00:46 -0400)]
ci: disable tests on misc builds

these tests have some crazy options which cause tests to fail at present

ref T7151

Differential Revision: https://phab.enlightenment.org/D6620

6 years agoci: make check -> make check-TESTS
Mike Blumenkrantz [Sat, 14 Jul 2018 04:45:05 +0000 (00:45 -0400)]
ci: make check -> make check-TESTS

the tests have all been compiled at this point using the check-build
target (separately) in order to split out test compile failures from
runtime failures, so use the check-TESTS target to run the tests without
checking whether the tests are built first

Differential Revision: https://phab.enlightenment.org/D6619

6 years agoci: run make check in build
Mike Blumenkrantz [Fri, 13 Jul 2018 22:31:03 +0000 (18:31 -0400)]
ci: run make check in build

this adds a script to run make check after the build has finished,
repeating tests 3 times to try and reduce false positives from intermittent
failure tests

ref T7094

Differential Revision: https://phab.enlightenment.org/D6617

6 years agoci: add folding for travis logs
Mike Blumenkrantz [Fri, 13 Jul 2018 22:29:25 +0000 (18:29 -0400)]
ci: add folding for travis logs

make the build a bit nicer to read

the build output is still insanely verbose, so this isn't super useful as
the 'pretty' view still takes so long to load that it's almost always better
to just read the raw text log

Differential Revision: https://phab.enlightenment.org/D6616

6 years agoci: use manual autoreconf && configure calls
Mike Blumenkrantz [Fri, 13 Jul 2018 20:08:42 +0000 (16:08 -0400)]
ci: use manual autoreconf && configure calls

our autogen.sh stupidly destroys all the autotools cache files, so ensure that
we keep them around to speed up configure

Differential Revision: https://phab.enlightenment.org/D6615

6 years agoci: make release-ready not allow failures
Mike Blumenkrantz [Fri, 13 Jul 2018 18:37:04 +0000 (14:37 -0400)]
ci: make release-ready not allow failures

this should no longer fail

Differential Revision: https://phab.enlightenment.org/D6612

6 years agoci: disable make on release builds
Mike Blumenkrantz [Thu, 12 Jul 2018 23:21:15 +0000 (19:21 -0400)]
ci: disable make on release builds

make is no longer required for distcheck, so stop doing 2 full tree builds
on this build type

fixes release builds on travis

Differential Revision: https://phab.enlightenment.org/D6611

6 years agoci: build tests on macos
Mike Blumenkrantz [Thu, 12 Jul 2018 18:25:42 +0000 (14:25 -0400)]
ci: build tests on macos

this enables test building on macos (previously disabled)

Differential Revision: https://phab.enlightenment.org/D6584

6 years agoci: add osx homebrew packages to cache
Mike Blumenkrantz [Thu, 12 Jul 2018 14:05:09 +0000 (10:05 -0400)]
ci: add osx homebrew packages to cache

this adds the downloaded homebrew package files to a cache in order to
avoid needing to separately download each file at the start of each build

not sure we can do better here unless we buy the enterprise-level travis
package which allows building with custom osx images which we could pre-install
all these dependencies on

ref T7096

Differential Revision: https://phab.enlightenment.org/D6610

6 years agoci: disable app build on osx
Mike Blumenkrantz [Thu, 12 Jul 2018 00:58:16 +0000 (20:58 -0400)]
ci: disable app build on osx

this isn't currently working, disable for now

Differential Revision: https://phab.enlightenment.org/D6609

6 years agoci: add autoconf caching
Mike Blumenkrantz [Wed, 11 Jul 2018 23:00:47 +0000 (19:00 -0400)]
ci: add autoconf caching

this enables caching of the autoreconf and ./configure stages of the build
using autotools-provided caching mechanisms in order to speed up these steps

fix T7136

Differential Revision: https://phab.enlightenment.org/D6608

6 years agoci: don't cd / when building example app
Mike Blumenkrantz [Tue, 17 Jul 2018 18:52:45 +0000 (14:52 -0400)]
ci: don't cd / when building example app

this gets deleted after the build, so just build it in the efl directory
to avoid permission errors when building on osx

Differential Revision: https://phab.enlightenment.org/D6607

6 years agoci: add ccache support
Mike Blumenkrantz [Tue, 10 Jul 2018 22:43:55 +0000 (18:43 -0400)]
ci: add ccache support

this enables and implements full support for ccache on travis builds

fix T7126

Differential Revision: https://phab.enlightenment.org/D6605

=also includes previously-submitted patches=

ci: split out ccache config setup into separate script

this provides a more unified place to set ccache options

also enable ccache compression to cut down on cache upload/download overhead

ref D6613

ci: zero ccache stats before build and add some comments for options used

zeroing the stats before each build will provide more insight into the cache
performance for each build

ref D6621

ci: break out ccache stat printing into separate script

continue to make travis.yml more readable

ref D6622

ci: add more ccache config options to improve cache direct hits

ci: disable second cpp run for ccache

this should avoid running cpp twice for files

https://ccache.samba.org/manual.html#_the_preprocessor_mode

6 years agoci: refactor all build steps into separate build scripts
Mike Blumenkrantz [Tue, 10 Jul 2018 16:14:27 +0000 (12:14 -0400)]
ci: refactor all build steps into separate build scripts

this moves each step of the ci build into a separate script with the build
type passed as an argument, allowing for easier modification of each individual
step as necessary and making travis.yml more readable

Differential Revision: https://phab.enlightenment.org/D6604

also includes:
ci: break out make commands into travis.yml from build scripts

this simplifies the platform-specific build scripts to only perform
the configure stage of the build (and any additional setup) and then
uses standardized commands for the build

in addition to being simpler, this will also provide more/better info
about build timings

ref D6603

6 years agoee_wayland: Update maximize and fullscreen state after configure
Derek Foreman [Wed, 25 Jul 2018 20:47:52 +0000 (15:47 -0500)]
ee_wayland: Update maximize and fullscreen state after configure

Summary:
If the compositor drops fullscreen or maximize for us the CSD to change
that state would become broken, as ecore_wl2 thought the window state
was whatever we last set it to from the client side.

Update that state on configure event.

fix T7211

Reviewers: devilhorns, zmike, eagleeye

Reviewed By: devilhorns, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7211

Differential Revision: https://phab.enlightenment.org/D6684

6 years agoelementary: Check for valid resize object
Chris Michael [Wed, 25 Jul 2018 18:57:52 +0000 (14:57 -0400)]
elementary: Check for valid resize object

Summary:
Fix an issue where elm_slider was passing NULL to eo functions due to
wd->resize_obj being NULL. Discovered via Enlightenment mixer popup
dialog

ref T7030
Depends on D6639

Reviewers: zmike

Reviewed By: zmike

Subscribers: Hermet, bu5hm4n, cedric, #committers

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6640

6 years agoelementary: Check for valid resize object before calling
Chris Michael [Wed, 25 Jul 2018 18:57:41 +0000 (14:57 -0400)]
elementary: Check for valid resize object before calling

Summary:
efl_layout_signal_emit

This patch fixes an issue where NULL was passed to
efl_layout_signal_emit due to wd->resize_obj being NULL. This was
discovered in Enlightenment by clicking on the mixer module and trying
to close the popup window

ref T7030
Depends on D6638

Reviewers: zmike

Reviewed By: zmike

Subscribers: Hermet, cedric, #committers

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6639

6 years agoelementary: Check for valid frame object
Chris Michael [Wed, 25 Jul 2018 18:57:14 +0000 (14:57 -0400)]
elementary: Check for valid frame object

Summary:
Make sure we have a valid frame object before calling edje & evas
functions on it. This patch fixes an issue where NULL is being passed
to eo functions

ref T7030

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6637

6 years agotests: check WIFEXITED to determine if test exited before using exit status
Mike Blumenkrantz [Wed, 25 Jul 2018 15:56:23 +0000 (10:56 -0500)]
tests: check WIFEXITED to determine if test exited before using exit status

Summary:
the exit status value is not valid unless the process has terminated normally
by calling exit() or _exit(), so only use the status if this is true. otherwise
mark the process as a failed test
Depends on D6597

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl_tests

Differential Revision: https://phab.enlightenment.org/D6600

6 years agorelease: Update NEWS and bump version for 1.21.0-beta1 release
Stefan Schmidt [Wed, 25 Jul 2018 12:51:05 +0000 (14:51 +0200)]
release: Update NEWS and bump version for 1.21.0-beta1 release

6 years agotests: limit per-suite forks to cpu count
Mike Blumenkrantz [Tue, 17 Jul 2018 14:45:15 +0000 (10:45 -0400)]
tests: limit per-suite forks to cpu count

this is mostly fine to thrash the cpus on beefy desktop computers, but
it completely destroys travis's wimpy 2cpu/2gb ram configurations and causes
all the tests to fail

instead, restrict forking to the number of cpus detected and wait until a fork
exits before beginning a new one

ref T7151

Differential Revision: https://phab.enlightenment.org/D6597

6 years agoevas canvas: fix not to trigger unnecessary events.
Hermet Park [Tue, 24 Jul 2018 16:04:11 +0000 (12:04 -0400)]
evas canvas: fix not to trigger unnecessary events.

Summary:
Here comparision is logically wrong because it compares
the coordinates(cur, prev) of the different spaces.

As you can see just above the conditions,
Cur coordinates could be transformed into the map space (if objs have)
on the otherhands, prev is not. These wrong condition could occur
embarassing event trigger.

@fix

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6674

6 years agoelm/list: remove max size setting on item contents
Mike Blumenkrantz [Tue, 24 Jul 2018 15:05:13 +0000 (11:05 -0400)]
elm/list: remove max size setting on item contents

Summary:
this was added in a giant block commit in 2009 without direct explanation;
it doesn't seem to make functional sense in the original patch and it
definitely doesn't make sense now

this greatly improves list performance by causing fewer edje recalcs on
list items resulting from list fighting with item content objects over
max size hint

fix T7176

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7176

Differential Revision: https://phab.enlightenment.org/D6669

6 years agoefl_ui_win: reset first_draw flag if window is resized while hidden
Mike Blumenkrantz [Tue, 24 Jul 2018 14:18:53 +0000 (09:18 -0500)]
efl_ui_win: reset first_draw flag if window is resized while hidden

Summary:
this indicates that the window's internal object sizes will have changed,
requiring a full window recalc. if the window is not visible, defer all
recalcs until pre-render to avoid unnecessary calcs and use the same
codepath as the initial window show

ref T7172
Depends on D6646

Reviewers: kimcinoo, eagleeye, ManMower

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7172

Differential Revision: https://phab.enlightenment.org/D6647

6 years agoefl_ui_win: show internal objects again on show if first_draw flag is set
Mike Blumenkrantz [Tue, 24 Jul 2018 14:18:50 +0000 (09:18 -0500)]
efl_ui_win: show internal objects again on show if first_draw flag is set

Summary:
in this case, a window is being shown again after being hidden, so it's safe
to immediately show these objects as the size will not have changed since
they were last visible

fix T7172
ref fa02f16a3fcf24ac32ea0d1e07fbcb145b0da565

Reviewers: kimcinoo, eagleeye

Reviewed By: kimcinoo

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7172

Differential Revision: https://phab.enlightenment.org/D6646

6 years agoeina: Add doxygen in/out tags for evlog, file, fp, freeq
Bryce Harrington [Tue, 24 Jul 2018 12:30:08 +0000 (08:30 -0400)]
eina: Add doxygen in/out tags for evlog, file, fp, freeq

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6673

6 years agoci: add some line breaks in travis.yml for readability
Mike Blumenkrantz [Tue, 10 Jul 2018 16:02:51 +0000 (12:02 -0400)]
ci: add some line breaks in travis.yml for readability

no functional changes

Differential Revision: https://phab.enlightenment.org/D6602

6 years agoci: always force eio to use fallback monitoring method
Mike Blumenkrantz [Tue, 10 Jul 2018 15:59:48 +0000 (11:59 -0400)]
ci: always force eio to use fallback monitoring method

inotify is not available in docker containers, so disable this for now
as it will always cause codepaths relying on it to time out

Differential Revision: https://phab.enlightenment.org/D6601

6 years agobuild: make object rule for eolian tests a versioned conditional
Mike Blumenkrantz [Tue, 17 Jul 2018 19:38:57 +0000 (15:38 -0400)]
build: make object rule for eolian tests a versioned conditional

automake 1.16 changed the naming of object files:

- When subdir-objects is in effect, Automake will now construct
    shorter object file names when no programs and libraries name
    clashes are encountered.  This should make the discouraged use of
    'foo_SHORTNAME' unnecessary in many cases.
https://lists.gnu.org/archive/html/info-gnu/2018-02/msg00008.html

this requires that object-specific rules must be changed to match the new
naming scheme if newer automake is being used. the $am__api_version contains
the version string of the automake version used during autoreconf, so this
should be checked during configure time in order to generate the correct
makefile rule for that automake version

other similar rules should be changed in the same way

note that this conditional speculates on behavior of automake versions past
1.16, which are not yet released and thus may change, meaning that this issue may
reoccur in future automake versions

Differential Revision: https://phab.enlightenment.org/D6594

6 years agoelm_code_widget: resize cursor at time of font change.
Alastair Poole [Tue, 24 Jul 2018 09:07:42 +0000 (10:07 +0100)]
elm_code_widget: resize cursor at time of font change.

Summary:
This ensures the cursor changes to meet the font size change
when a font change is made in an Elm_Code_Widget.

@fix T6470

Test Plan:
Run ecrire or Edi. Open a text file and change the font settings.
Cursor should resize with the font when it is changed.

Reviewers: #committers, ajwillia.ms

Reviewed By: #committers, ajwillia.ms

Subscribers: cedric, zmike

Tags: #efl

Maniphest Tasks: T6470

Differential Revision: https://phab.enlightenment.org/D6596

6 years agoelm_code_widget: fix select and drag (scrolling).
Alastair Poole [Tue, 24 Jul 2018 09:02:30 +0000 (10:02 +0100)]
elm_code_widget: fix select and drag (scrolling).

Summary:
Currently when selecting with the mouse and scrollling,
the selection will only continue in one direction. With
this patch, the selection can move freely between "pages".

Test Plan: select text and drag up and down in elm_code widget (Edi).

Reviewers: #committers, ajwillia.ms

Reviewed By: ajwillia.ms

Subscribers: cedric, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6632

6 years agoelm test - expand --help to also do -h and -help
Carsten Haitzler (Rasterman) [Tue, 24 Jul 2018 04:21:02 +0000 (13:21 +0900)]
elm test - expand --help to also do -h and -help

6 years agoelm test - unbreak elm test ...
Carsten Haitzler (Rasterman) [Tue, 24 Jul 2018 04:18:35 +0000 (13:18 +0900)]
elm test - unbreak elm test ...

7ebcb710d2776a0bbd905552226dc1141a18ef7d / D6668 breaks elm test. a
fix actually that breaks it even more. before only --help didn't
work... now -to/--test-win-only is broken which is the actually useful
option... :)

6 years agoecore x - fix vsync to not block amdgpu drivers
Carsten Haitzler (Rasterman) [Wed, 18 Jul 2018 02:52:09 +0000 (11:52 +0900)]
ecore x - fix vsync to not block amdgpu drivers

amdgpu vsync works so don't block is so those drivers get proper
vsynced rendering as well.

@fix

6 years agoecore/signal: use a volatile int to prevent further SIGPIPE during shutdown
Mike Blumenkrantz [Mon, 23 Jul 2018 21:30:56 +0000 (17:30 -0400)]
ecore/signal: use a volatile int to prevent further SIGPIPE during shutdown

Summary:
attempt to prevent any access of the signal pipe once signal handlers are
removed in order to avoid triggering a SIGPIPE which would kill the app
Depends on D6670

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl_main_loop

Differential Revision: https://phab.enlightenment.org/D6672

6 years agoecore/signal: delete signal pipe after unsetting signal handlers
Mike Blumenkrantz [Mon, 23 Jul 2018 21:30:54 +0000 (17:30 -0400)]
ecore/signal: delete signal pipe after unsetting signal handlers

Summary:
if a signal is already in the signal pipe when close() is called,
this will trigger a SIGPIPE. if the signal handler exists, this will
cause the signal handler to infinitely recurse when trying to print
the error messages from write()ing the signal data to the close()d
pipe

fix T7158

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: cedric, #committers

Tags: #efl_main_loop

Maniphest Tasks: T7158

Differential Revision: https://phab.enlightenment.org/D6670

6 years agomacos: allow text to be selected.
Alastair Poole [Mon, 23 Jul 2018 19:48:28 +0000 (15:48 -0400)]
macos: allow text to be selected.

Summary: This gives us basic clipboard handling for MacOS after the refactor was done.

Test Plan:
Open an entry test. select text with mouse or keyboard.
Text can be cut. Text can be copied. Text can be pasted.

Reviewers: ajwillia.ms, zmike, jayji

Reviewed By: zmike

Subscribers: jayji, herdsman, cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6599

6 years agoelm_test: fix arg parsing
Mike Blumenkrantz [Mon, 23 Jul 2018 17:34:48 +0000 (13:34 -0400)]
elm_test: fix arg parsing

Summary:
recent changes to ecore changed arg numbering again and no callers
outside of test suites were updated

ref 9c8749b99a03d3601321da6d16071dd7b631d1ae

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6668

6 years agoevas clip: more strict comparison.
Hermet Park [Mon, 23 Jul 2018 12:18:00 +0000 (08:18 -0400)]
evas clip: more strict comparison.

Summary: just improvement from D6645

Reviewers: zmike, #committers

Reviewed By: zmike, #committers

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6650

6 years agoEfl.Ui.Calendar, elm_calendar: Code fixed to support auto repeat feature.
Woochan Lee [Mon, 23 Jul 2018 06:49:10 +0000 (15:49 +0900)]
Efl.Ui.Calendar, elm_calendar: Code fixed to support auto repeat feature.

Summary:
1.  Why there is a edje signal callback in elm_calendar? and do we need to maintain?

 We used edje part like a button before (3 years ago?), So there is a callbacks to get edje signal.

 Im pretty sure it is not use anymore. but we need to maintain backward compatibility.

2. elm_calendar using using repeat feature in efl_ui_button for it. why did i change it to manual timer?

 We opend elm_calendar_interval_set() APIs. Support this API the manual timer is proper then using button's feature.

3. why scroll freeze? and why only elm_calendar does it?

 When the user long press calendar button area and then move the scroll will be activated. it can prevent that weird action.

 efl_ui_calendar using button's feature. i not sure scroll freeze is deserve to attached in button side as a feature or not.

 So i will consider more for this case.

4. Why efl_ui_calendar doesn't have year buttons (double spinner case)

 After interface work, we don't accept style change in the runtime. so that featrue will be supported as API.

 The year_button_set/get() property should be added. but i dont know is it really needed...

 If the app developer want use year inc/dec button for efl_ui_calendar. they can inherit the class and make it easily.

Test Plan:
View, Action, API test in the elementary-test sample App.

Ps. The issue of the calendar2 crash when it closed. It's not relative with this commit. its focus. i will look around.

Reviewers: Hermet, zmike, ManMower, segfaultxavi, devilhorns

Reviewed By: Hermet

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6626

6 years agoelm_code: (cherry-pick) Fix cusor pos after newline when indenting with tabs
Andy Williams [Sat, 24 Mar 2018 10:40:14 +0000 (10:40 +0000)]
elm_code: (cherry-pick) Fix cusor pos after newline when indenting with tabs

@fix

6 years agoelm_code: (cherry-pick) Support indentation styles that are purely tab based
Andy Williams [Sat, 24 Mar 2018 10:39:32 +0000 (10:39 +0000)]
elm_code: (cherry-pick) Support indentation styles that are purely tab based

read: Allow non-EFL style indentation.
This is off by default but is switched on if you turn 'tabs insert spaces' off

6 years agoCtxpopup super slow with some more items
Dave Andreoli [Sat, 21 Jul 2018 07:48:05 +0000 (09:48 +0200)]
Ctxpopup super slow with some more items

If you put some (like 100) items in a ctxpopup it will take 5 seconds
to show up and throw all kind of errors on console.

This is an example that show the issue, I opened T7176 to track this issue

6 years agoecore: remove exit_signal_received conditional from windows build
Mike Blumenkrantz [Fri, 20 Jul 2018 19:21:28 +0000 (15:21 -0400)]
ecore: remove exit_signal_received conditional from windows build

Summary:
windows does not include ecore_signal.c, so this is not a defined symbol

lib/ecore/.libs/lib_ecore_libecore_la-ecore_anim.o: In function `timer_tick_notify':D:\Documents\MSYS2\home\vtorri\gitroot\efl3\src/lib/ecore/ecore_anim.c:372: undefined reference to `exit_signal_received'lib/ecore/.libs/lib_ecore_libecore_la-ecore_anim.o: In function `ecore_animator_custom_tick':D:\Documents\MSYS2\home\vtorri\gitroot\efl3\src/lib/
ecore/ecore_anim.c:940: undefined reference to `exit_signal_received'

ref 6405a5a68c0ad618e8b8ab169a0ac85bf43c65c1

Reviewers: vtorri, devilhorns

Reviewed By: vtorri

Subscribers: cedric, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D6648

6 years agoefl: fix some warnings in examples
Xavi Artigas [Fri, 20 Jul 2018 14:36:38 +0000 (10:36 -0400)]
efl: fix some warnings in examples

Summary:
- Check return vaule of fread()
- Uninitialized var (seriously!)
- Weird struct assignment

Still one warning remains, pending evaluation of T7166.

Fixes T6718

Test Plan:
Those 3 warnings have disappeared and the related example still works
as expected.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers

Tags: #efl

Maniphest Tasks: T6718

Differential Revision: https://phab.enlightenment.org/D6631

6 years agoeina: Add doxygen in/out tags for cow, cpu, and debug
Bryce Harrington [Fri, 20 Jul 2018 14:36:24 +0000 (10:36 -0400)]
eina: Add doxygen in/out tags for cow, cpu, and debug

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6642

6 years agoevas clip: stop move events feeds.
Hermet Park [Fri, 20 Jul 2018 14:36:00 +0000 (10:36 -0400)]
evas clip: stop move events feeds.

Summary:
there is no point to feeding mouse events
if clipped object is invisible because
previsou/current situation won't be different.

fyi, move events won't be triggered if prev/cur coordinates
are same.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6645

6 years agoelementary list: add a todo comment.
Hermet Park [Thu, 19 Jul 2018 08:04:42 +0000 (17:04 +0900)]
elementary list: add a todo comment.

6 years agoelm/list: block recursive recalc loops
Mike Blumenkrantz [Thu, 19 Jul 2018 08:01:05 +0000 (17:01 +0900)]
elm/list: block recursive recalc loops

Summary:
this size hints callback is triggered by both list objects and list
item objects, meaning that setting size hints on the item objects during
recalc will trigger a recursive recalc, potentially infinitely

this blocks recursive recalcs unless triggered by size hint changes
from a main list object, since those will eventually resolve themselves

fix T7121

Reviewers: devilhorns, Hermet

Reviewed By: Hermet

Subscribers: netstar, DaveMDS, cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7121

Differential Revision: https://phab.enlightenment.org/D6572

6 years agoecore_main: silence warning when compiling.
Alastair Poole [Thu, 19 Jul 2018 06:53:49 +0000 (15:53 +0900)]
ecore_main: silence warning when compiling.

Summary:
Silence compilation warning.
There is an ifdef'd block of code which accesses obj but
I don't think it's in use in production?

Test Plan: Build EFL and watch for warning.

Reviewers: #committers, zmike, Hermet

Reviewed By: #committers, Hermet

Subscribers: cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6628

6 years agoeina: Fix doxygen in/out tags for eina_bezier
Bryce Harrington [Thu, 19 Jul 2018 06:51:53 +0000 (15:51 +0900)]
eina: Fix doxygen in/out tags for eina_bezier

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6630