streamline SkRasterPipeline::run()

This used to need to be complicated to check for unimplemented stages,
but now that SkJumper rules the world, we can make this a lot simpler
and move a lot of the tricky stage selection logic into an SkOnce.

This should decrease the overhead of SkRasterPipeline::run().

Change-Id: I79d73f3315c7a1a52ab02747a5f17ce27d8cb9a4
Reviewed-on: https://skia-review.googlesource.com/17440
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Revert "dither copies when decreasing precision"

This reverts commit 766f9cd5553ab091b85d287a79f47cbb91ad7989.

Reason for revert: unit test failures, I think on bots running portable code path

Original change's description:
> dither copies when decreasing precision
>
> Still seeing the same 4444 diffs on copyTo4444 and all_bitmap_configs,
> and now also 565 in all_bitmap_configs.
>
> BUG=chromium:720105
>
> Change-Id: I19406f57aa6d2b2f98d98c093da302b004c7cd8b
> Reviewed-on: https://skia-review.googlesource.com/17419
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Matt Sarett <msarett@google.com>
>

TBR=mtklein@chromium.org,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:720105

Change-Id: Ia9ece7dccef325233b870102ab38fbed2336b95d
Reviewed-on: https://skia-review.googlesource.com/17442
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

dither copies when decreasing precision

Still seeing the same 4444 diffs on copyTo4444 and all_bitmap_configs,
and now also 565 in all_bitmap_configs.

BUG=chromium:720105

Change-Id: I19406f57aa6d2b2f98d98c093da302b004c7cd8b
Reviewed-on: https://skia-review.googlesource.com/17419
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>

SkWebpEncoder: use bgra for lossless and yuv for lossy

Previosuly, we would (accidentally) always use just yuv.

Bug: 713862
Change-Id: I00acc6ca2841ba0636494119b7b4f46a9deee401
Reviewed-on: https://skia-review.googlesource.com/17406
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/2537c8c2d9fb1b2aa5def9315e0d48da41e93871 chromite: Stop setting LANG to a known value. (dgarrett@google.com)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa98070323e03a8f3c887ae064d3585a879e14c5
Reviewed-on: https://skia-review.googlesource.com/17417
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/31b834a0e849ce66bd5a7c8544071dce1276ef2f Closure: turn down the old GYP format (dbeam@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb053a1f28af1bd6825b26187a30630b5c9dde95
Reviewed-on: https://skia-review.googlesource.com/17414
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Update Porter Duff analysis to match LCD logic.

Bug: skia:
Change-Id: Ib222c37f7ebb307752806829742a3b6278dbae3d
Reviewed-on: https://skia-review.googlesource.com/17410
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Remove debug flag for ios bots

TBR=borenet
Bug: skia:
Change-Id: I791ad92203ca8cdd6da8abe7c9f45fde528cb7b9
Reviewed-on: https://skia-review.googlesource.com/17409
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>

Improve test coverage of image decode modes

Summary of the new world...

--image

CodecSrc and ImageGenSrc tests run on:
(1) 8888 with kIgnore transfer fn behavior
(2) srgb with kRespect transfer fn behavior
(3) f16

AndroidCodecSrc and BRDCodecSrc tests run on:
(1) 8888, since SkAndroidCodec always uses kIgnore
(2) f16, since android uses f16

--colorImage

ColorCodecSrc tests run on:
(1) 8888 in kBaseline mode, so we can see what the raw pixels look like
(2) srgb in color correct modes
(3) f16 in color correct modes

Bug: skia:
Change-Id: I65d1a04051da6f94bf5e48f7bc610f482870dc75
Reviewed-on: https://skia-review.googlesource.com/17396
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

stage version of vertices

This CL, just to limit its size/complexity, only handles
colors but not textures. Future CLs will cover everything.

Performance is pretty exciting. Its faster than the old code-path,
and when we fix a bug in pathutils to preserve opaqueness, it gets
a lot faster (8 -> 5)

Bug: skia:
Change-Id: I4113060e25fe25fe4e6a0ea59bd4fa5e33abc668
Reviewed-on: https://skia-review.googlesource.com/17276
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>

minor skslc bugfixes

This fixes the attributes on sk_VertexID, and a backwards test on
SkSL::String::startsWith and ::endsWith.

Change-Id: Icfddfc8ca95454d8646a1771761685c2525b296e
Reviewed-on: https://skia-review.googlesource.com/17398
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/0104dcd6b327b06880b9020f1cb2ca2b93d08a5d Fix recipe typo (martiniss@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I167a43ad87b66295d479d1012512e2a79d9f5a86
Reviewed-on: https://skia-review.googlesource.com/17400
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Comment out lcd assert to make GLPrograms test happy

TBR=bsalomon@google.com

Bug: skia:6661
Change-Id: I944d05c31d3d5511f3c1679c9eb689dbcfbbb109
Reviewed-on: https://skia-review.googlesource.com/17399
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Remove transitional parts from iOS job names

Bug: skia:
Change-Id: If19e5a956d3f10448cfe889127c2f79d9c42926e
Reviewed-on: https://skia-review.googlesource.com/17372
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>

Fix gpu lcd blending to semi-correctly handle alpha coverage

Bug: skia:6606
Change-Id: I16ccd97f5d047eb7fddfed5310bf669e7435ccdd
Reviewed-on: https://skia-review.googlesource.com/17370
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Temporarily use default webp encode method for bzl

I suspect that this will fix the failing golden image tests.

Bug: skia:
Change-Id: I9f88206ae782e6a04817e72cdfcb3e0c4bdaa293
Reviewed-on: https://skia-review.googlesource.com/17393
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>

Update NexusPlayers to O Preview 2

This may help with NexusPlayers flaking out.

Bug: skia:6045
NOTRY=true
Change-Id: I1ac1bf3cb5e17d26069082da7cb0f420865c9630
Reviewed-on: https://skia-review.googlesource.com/17388
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

detect (and preserve) if patch colors are opaque

Bug: skia:
Change-Id: Ida3a1ff3f78db2498a6dfc655d8be4de8ad912c7
Reviewed-on: https://skia-review.googlesource.com/17380
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Mike Reed <reed@google.com>

SkDocument: remove deprecated function

I meant to land this after https://crrev.com/2726103006 ,
but got sidetracked.

Change-Id: I4f0397302d41e89d2394bec545190cb024929bd8
Reviewed-on: https://skia-review.googlesource.com/17390
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

Updated workaround for Intel 6xxx clear to 0/1 bug

The previous workaround only handled the glClearColor(0,0,0,1) case,
it turns out we need to work around any glClearColor made up of entirely
0s and 1s.

R=bsalomon@google.com
Bug: 710443
Change-Id: I78a75559fc11811ad9a218436231354d66d2ad51
Reviewed-on: https://skia-review.googlesource.com/17327
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Eric Karl <ericrk@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/c33bbcee5e1f89a78814b7b9ebbc7cdbe19eddc8 Dart: Increase timeout for IE bots, use fewer processors (whesse@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8993e271c3252b57ce723f1f7095f38ceb5b50d7
Reviewed-on: https://skia-review.googlesource.com/17389
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac [cronet] Don't use is_official_build universally on cronet bots. (jbudorick@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8408708568bebc62682439f9322a4684550b46b5
Reviewed-on: https://skia-review.googlesource.com/17385
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/00749f571ff265c29cc9f2be07120364b00fcda8 Dart: Add "debug" and "unittests" options to dart2js recipe. (whesse@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d8bcf28eaf04733eae8fcd587fb24b9b2beb652
Reviewed-on: https://skia-review.googlesource.com/17384
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/28ebfb41f178f521e9187108c7b6ddd66b8e4a85 V8: Bump shards on PPC and S390 bots (machenbach@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I669307e2e1b10f2fb5e2f66781d3bb12839bff70
Reviewed-on: https://skia-review.googlesource.com/17383
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 Refactor PRESUBMIT support for tags (agable@chromium.org)
  https://crrev.com/064f6f4a9d2932ae699dbf4355bc63359e599026 gclient flatten: first pass (phajdan.jr@chromium.org)
  https://crrev.com/063814f82efdda25a0d1737395172faa88a5fd0f Remove "url" recipe module. (dnj@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I85f0df7d2de9782fc8c66e827c53eb16c03edf34
Reviewed-on: https://skia-review.googlesource.com/17382
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/e99a7805ce3c1fef96b428fb542d23fe975e8c5c Fix bot config for battor non linux builders (martiniss@chromium.org)
  https://crrev.com/cdf1ebd83441bc4bb54899e3f94d92d7953b8c66 Remove Android Swarming Tester (martiniss@chromium.org)
  https://crrev.com/9d08858e8f2f3aa0c556c1339eeca3d88bb44d46 Add four more slaves to N5 bot on chromium.swarm (bpastene@google.com)
  https://crrev.com/16c52aa6473518cf6751a9503a6e0b0d684979f8 CrOS: Update Chromite pin. (nodir@google.com)
  https://crrev.com/2cc4e2912d055df545a22801adaae8d16fbcb216 Convert Android One Perf builder to swarming (martiniss@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I75e3e2f14548081e5dfb585b22aec25f48a81e76
Reviewed-on: https://skia-review.googlesource.com/17374
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f347ca1f531aad4cfb60ac6f23b4a8d8426195db ios/try: add regression test for patch application failure (phajdan.jr@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a296e258c78850341874b8698242ec75260f5ba
Reviewed-on: https://skia-review.googlesource.com/17373
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Revert "Update clearOp for split-OpList world"

This reverts commit 7f1ce29c9bb9be8b2d8dbf9a99f14f74d5dc6d80.

Reason for revert: Maybe causing problems in imagemakewithfilter & dropshadowimagefilter

Original change's description:
> Update clearOp for split-OpList world
>
> It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it.
>
> Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2
> Reviewed-on: https://skia-review.googlesource.com/17323
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>

TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ib23ce4515d9427759ebd2b6d4c9d3a670f00a153
Reviewed-on: https://skia-review.googlesource.com/17326
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Revert "Revert "Disable resource cache in shadow_utils GM for now""

This reverts commit 0b58ef7b525e5325ecd194c4b470e4c924cbb56a.

Reason for revert: Wasn't actually fixed.

Original change's description:
> Revert "Disable resource cache in shadow_utils GM for now"
>
> This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f.
>
> Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/.
>
> Original change's description:
> > Disable resource cache in shadow_utils GM for now
> >
> > This should make the GMs more stable in tiled mode.
> >
> > Change-Id: I72996b1305fc99e60626af35267952d0a5c38624
> > Reviewed-on: https://skia-review.googlesource.com/17275
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Jim Van Verth <jvanverth@google.com>
> >
>
> TBR=jvanverth@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583
> Reviewed-on: https://skia-review.googlesource.com/17304
> Reviewed-by: Jim Van Verth <jvanverth@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
>

TBR=mtklein@google.com,jvanverth@google.com,reviews@skia.org,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: If606795bfeb4e6ed78f199fcb86ee2767bde5216
Reviewed-on: https://skia-review.googlesource.com/17371
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

comment SK_API and add fix params

I thought that SK_API on operator== was
redundant with SK_API on the enclosing class,
and was not needed. Turns out for mac_chromium_debug_ng
it is needed. Added comments for history.

Meanwhile, bookmaker found some missing and
mis-named parameters, so all is not lost.

R=reed@google.com

Change-Id: I88645666a9d06ec90c5ac133673460d6e6c75528
Reviewed-on: https://skia-review.googlesource.com/17277
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Mike Reed <reed@google.com>

Remove ambient and spot mask filters.

Also remove a deprecated interface in SkShadowUtils.

Change-Id: I32e67271be953f11071c512cb39a47ea1e7dcaaf
Reviewed-on: https://skia-review.googlesource.com/17266
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

Update clearOp for split-OpList world

It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it.

Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2
Reviewed-on: https://skia-review.googlesource.com/17323
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Add microbench for shadows

Based on Android's shadowgrid2.

Change-Id: I33209b6b84fc63a762405c4988afbdbffcc170d6
Reviewed-on: https://skia-review.googlesource.com/17360
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/09b389732d01bbeb2bfb17f5de06e15a952f0cbb buildbot: log path where pruning is happening (nodir@google.com)
  https://crrev.com/e13406ec6a3459b6dccd3eca4be5bdcd5325682e Remove Win10 experimental bots (hinoka@google.com)
  https://crrev.com/745e8d9fbc8344d522a84131ffa9b43472dbb06d Revert "Reland: zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja" (agrieve@chromium.org)
depot_tools:
  https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac bot_update: fix regression with swallowed exception (phajdan.jr@chromium.org)
recipe_engine:
  https://crrev.com/2f2d5c663eddcd8b6924a8775aaf88f3600d2ac8 [step_runner] expand try/catch to cover all step preparation functionality (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0dfbef52e05e67b967846b91813ca1c6ee3abf15
Reviewed-on: https://skia-review.googlesource.com/17366
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Revert "Remove GrSurfaceDesc member from GrSurface."

This reverts commit 84911546b9535a2fff6c5e07f588f175d5a04f45.

Reason for revert: Breaking bots possibly?

Original change's description:
> Remove GrSurfaceDesc member from GrSurface.
>
> Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771
> Reviewed-on: https://skia-review.googlesource.com/17273
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
>

TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I404e509fcd3e3d5527b3bc6e286b7d436c12e879
Reviewed-on: https://skia-review.googlesource.com/17364
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Hide SkPerlinNoiseShader impl details

Move the shader impl to a private class, leave SkPerlinNoiseShader as
a factory class only (similar to e.g. SkLightingShader).

Change-Id: Ic1180db8f5dfd3d8f6fba133c6bf6bbdfa4f97a4
Reviewed-on: https://skia-review.googlesource.com/17318
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

Use persistent checkout for UpdateMetaConfig bot

Bot is failing without this.

BUG=skia:6591

Change-Id: I29cf5e18a7fa240d3e45bdadf83c1f91060f45f5
Reviewed-on: https://skia-review.googlesource.com/17319
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

Remove GrSurfaceDesc member from GrSurface.

Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771
Reviewed-on: https://skia-review.googlesource.com/17273
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

Switch over GrDiscardOp to IORef-ing the GrRenderTargetProxy

This cannot land until after https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) sticks.

This is because, prior to that CL, the SurfaceProxies have a ref on the last OpList that wrote to them. Since this CL adds a IORef from a discardOp in an opList to the SurfaceProxy this can result in a loop. After the required CL sticks, opLists have a IORef on the SurfaceProxy to which they wrote and the SurfaceProxy just has a raw back pointer so there will be no loop.

Change-Id: I198035f5dd5a8fad549052dea6aaa61477a89844
Reviewed-on: https://skia-review.googlesource.com/16663
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

CQ_INCLUDE_CHROMIUM_TRYBOTS: add optional trybots

Change-Id: Id1bc86592a3006b00dfd313bf48488e038f3a041
Reviewed-on: https://skia-review.googlesource.com/17317
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

Add drawArraysBaseVertexIsBroken flag

A non-zero base vertex in glDrawArrays appears to not always work on
Adreno.

Bug: skia:6650
Change-Id: I301eaba8c7790ed814a2ab8d8c53dd2b9e0d77d1
Reviewed-on: https://skia-review.googlesource.com/17083
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

Add check for incorrect opList splits

This CL relies on: https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3))

We can't/don't want to close the opList in the GrSurfaceContext dtor because we, semi-often, wrap a proxy in a utility SurfaceContext in order to upload data to it (e.g., when creating a proxy w/ data or in the texture strip atlas).

In the current set up, the "temporary fixes" in newRTOpList and newTextureOpList should prevent any out of order execution.

Change-Id: I8189db6ed59096d7b8c1704028df395f84e4a681
Reviewed-on: https://skia-review.googlesource.com/14187
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Revert "Revert "Remove GrSurface::desc() method.""

This reverts commit c96da1e51e1ca72d54dda49f32891bd41530ad31.

Bug: skia:
Change-Id: I8242400a137413c01c7ef614b4fa733be7dcf939
Reviewed-on: https://skia-review.googlesource.com/17311
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

Expand small tables in SkColorSpaceXform_A2B

Bug: 722855
Change-Id: Id3661be1e9747ac0de1e35b60d334ee8187a5be5
Reviewed-on: https://skia-review.googlesource.com/17312
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>

Pre-cache SkPath's genID in PreCachedPath too

SkPath::getGenerationID() calls SkPathRef's, which is where the race is.

Change-Id: I71296b32148c8cda2d2b2fe249ef6b9ef84fcfe0
Reviewed-on: https://skia-review.googlesource.com/17316
Reviewed-by: Jim Van Verth <jvanverth@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/1929522b5629bc18495781feaf794bef80db81f4 Nitfix follow up for https://chromium-review.googlesource.com/c/507128 (tandrii@chromium.org)
  https://crrev.com/feefbde597dd2c76463f51ad35e555922ce2c93f Bootstrap "authorize_adb_devices". (dnj@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24c8fc5e7c1e5a141ace50e9a8a17b079e397afe
Reviewed-on: https://skia-review.googlesource.com/17314
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Fix SkImage::onMakeColorSpace() for subset lazy images

Bug: 723149
Change-Id: Ib56a77958fc1b7e026ee5ca98a46e8f014fe75d4
Reviewed-on: https://skia-review.googlesource.com/17309
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/df8a4659dcb826adfeb1f1534f124db33cda13e8 Revert "Remove debug output during recipe training." (tandrii@chromium.org)
  https://crrev.com/589e5267097f76224e0ac2e2ea554aff635d979f Revert "Turtles all the way down = aka debugging chromium_tests 2." (tandrii@chromium.org)
  https://crrev.com/af07a8d4dd8b3525570758f551c386dd680e0bf2 Revert "Turtles all the way down = aka debugging chromium_tests." (tandrii@chromium.org)
  https://crrev.com/81ae4cac09270557f27b650e4a19239d16ae9fde Revert "Add debug marker for ease text search for debugging info." (tandrii@chromium.org)
  https://crrev.com/208399a7f37deab314244d1c990570c0fd630a6a Revert "Log masked exception in test utils" (tandrii@chromium.org)
  https://crrev.com/8e9cb844bc627074c4aa50e1255cb468241dc2f6 V8: Add concurrent marking tsan bots (machenbach@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5823023f3b6910011055136ff603d3579482a690
Reviewed-on: https://skia-review.googlesource.com/17310
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Remove unused SkZeroShaderContext

Change-Id: I3e9d9cb9c2f948b0bb363871e038ade1cf2f3d67
Reviewed-on: https://skia-review.googlesource.com/17308
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

Bot to update buildbucket.config daily

Bug: skia:6591
Change-Id: Ic2ec5b033965ca073a00e272693b1c5e1d0ad69f
Reviewed-on: https://skia-review.googlesource.com/16541
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>

Move MIP color mode from GrSurfaceProxy to GrTextureProxy

Change-Id: I76bc7f551ea4052fc611cf01e0ce81102c9c3395
Reviewed-on: https://skia-review.googlesource.com/17263
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

Revert "Remove GrSurface::desc() method."

This reverts commit 9ac995354428a916df81253e0c0c3f582db18976.

Reason for revert: Lots of broken gold images

Original change's description:
> Remove GrSurface::desc() method.
>
> Change-Id: If158dee90b3b0f80aa9c674180fbe6abd5b27d3f
> Reviewed-on: https://skia-review.googlesource.com/17268
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>
>

TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I5608c0e287e301aeac81dd3249a5c34d4603fcc6
Reviewed-on: https://skia-review.googlesource.com/17306
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/5e7db1588c5a375b1e77c074896ec1d28e5c2717 Bootstrap 'gsutil_cp_dir.py'. (dnj@chromium.org)
  https://crrev.com/d12c5d4da0acff399a59b9fab33c26f4f83201b3 Bootstrap "find_xcode.py". (dnj@chromium.org)
  https://crrev.com/5903d958fa5b792df25a290bc8e3f2437da75f28 chromite: Explicitly fetch depot_tools and put in path. (dgarrett@google.com)
  https://crrev.com/548cbb2161cccbba8e0c8f6e5e91a959ecbede3b Bootstrap 'upload_perf_dashboard_results' (dnj@chromium.org)
  https://crrev.com/72e5b727a9aaa51e36c1a43a048933a2d477e2fb Bootstrap "taskkill" and "runhooks_wrapper". (dnj@chromium.org)
  https://crrev.com/5d416e2d7d87bb5b3348fddfedda09619b9070d9 Bootstrap 'chromium_codesearch' Python calls. (dnj@chromium.org)
  https://crrev.com/5f35f05f0059fe1a742f26e4e3419e17e24d61d4 buildbot: prune files asynchronously (nodir@google.com)
  https://crrev.com/59b2a19535187b885ced88a997587ae54cb8a379 Bootstrap "archive_webkit_test_results". (dnj@chromium.org)
  https://crrev.com/13eedbe79cab4bdfb588eae57453d1bac57465ef Bootstrap chromium recipe module through runit.py (dnj@chromium.org)
  https://crrev.com/48e7709a6985dca0691e7d8be35f54c54d0dac92 chromite: Use cros_git_cache cache entry, not fixed path. (dgarrett@google.com)
  https://crrev.com/e8ac15dd482fba8f81b9c25bb5e0885db7bb5bc1 Bootstrap "gsutil_download". (dnj@chromium.org)
  https://crrev.com/dd7c881ce81e4530ad0158988c1f952dbe746aef chromite: Revise git-cache cache name to be standard. (dgarrett@google.com)
  https://crrev.com/a820eec0c2f3b2cb88b4d660613e9c92212af46a Bootstrap "nacl_sdk_buildbot_run". (dnj@chromium.org)
  https://crrev.com/d4e3bd5598f8a51a843723d5da136ad452d7db8b Bootstrap "archive_build.py". (dnj@chromium.org)
  https://crrev.com/469eb2aa0ebc7882ca7ad20d26add15a3d4c632c chromite: Set LANG to a known value. (dgarrett@google.com)
  https://crrev.com/9ec76523bb3629ab4874cd834c44dfa992929fc7 Bootstrap "transfer_files.py". (dnj@chromium.org)
  https://crrev.com/a3b6bc4351f05643d535938e6e7f1bfaf1bfdfc7 Turn off swarming for the linux layout tests temporarily. (dpranke@chromium.org)
  https://crrev.com/53a6b44b40dade4da9546b3f976313f1cd3f0cbe Bisect - Push gerrit changes to prod. (simonhatch@chromium.org)
  https://crrev.com/8f8aee589409a3a4b09cd2df307268baa517be98 Bootstrap "daemonizer.py". (dnj@chromium.org)
  https://crrev.com/5eb5de9c8c3da08fa9a1d546955e237ac719f912 [codesearch] Refactor chromium_codesearch.py by adding recipe modules (shenghuazhang@google.com)
  https://crrev.com/74b36c2301966a939024a8f240a7896c5d9b0b87 Revert "Turtles all the way down = aka debugging chromium_tests 3." (tandrii@chromium.org)
  https://crrev.com/ad3ec490aaa7742ff98c5c84ed79f0e59fa3bf2d Remove "Chromium Linux Precise Goma LinkTest" from recipes. (yyanagisawa@chromium.org)
recipe_engine:
  https://crrev.com/cae7fab7b53f5c739176e95a116401592ff2b9e2 [step_runner] fix error text (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0a17c3580ddb1e80d8df38200e923b008281e805
Reviewed-on: https://skia-review.googlesource.com/17301
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Revert "Disable resource cache in shadow_utils GM for now"

This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f.

Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/.

Original change's description:
> Disable resource cache in shadow_utils GM for now
>
> This should make the GMs more stable in tiled mode.
>
> Change-Id: I72996b1305fc99e60626af35267952d0a5c38624
> Reviewed-on: https://skia-review.googlesource.com/17275
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
>

TBR=jvanverth@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583
Reviewed-on: https://skia-review.googlesource.com/17304
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

SkPath -> PreCachedPath

SkPath is not threadsafe.  Gotta use PreCachedPath.

TSAN is showing a race in SkPathRef::genID() to write the fGenerationID.

Change-Id: I42d6ecadaa754a3c6796ca465981de430a0abb84
Reviewed-on: https://skia-review.googlesource.com/17279
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/2c49b178c275e8e65b5d9b76e8ff3cefdb549f4e Remove Android Release (Pixel C) from GPU.FYI (ynovikov@google.com)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I51c75b6755abdb9104da65730b368b0830da85be
Reviewed-on: https://skia-review.googlesource.com/17278
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Disable resource cache in shadow_utils GM for now

This should make the GMs more stable in tiled mode.

Change-Id: I72996b1305fc99e60626af35267952d0a5c38624
Reviewed-on: https://skia-review.googlesource.com/17275
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/87753a94fd84ebdb8f94eb5e81be88cfde258f3c Bisect - Use patch_storage. (simonhatch@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I645a58ed5ca96192a620eb3f35bfcaa16de130ff
Reviewed-on: https://skia-review.googlesource.com/17274
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

SkColorSpace_ICC: classify two entry tables as linear

The bug linked in this CL was caused by the switch to SkJumper -
where we decided to stop interpolating table-lookups.

In this case, the image has tables with two entries: 0, 1.

This fixes the bug by optimizing away the table lookup for
these trivial no-op tables.  I think this is a good change
on its own.  We see these tables fairly regularly.

A more robust fix would expand "small" tables into larger
ones through interpolation.  Should we also do this?

Bug: 722855
Change-Id: I3881734c6f28b5519cbe593dd05cc7b6b1b8a9d0
Reviewed-on: https://skia-review.googlesource.com/17272
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Matt Sarett <msarett@google.com>

Remove GrSurface::desc() method.

Change-Id: If158dee90b3b0f80aa9c674180fbe6abd5b27d3f
Reviewed-on: https://skia-review.googlesource.com/17268
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

Add GM to verify that drawX == (path.addX, drawPath)

This demonstrates a new kind of hybrid unit test/GM.
It creates a grid of cells. In each cell, we do two
renders that are expected to produce the same result.
For each cell, we render the two results overlaid,
and highlight any differing pixels in red. Assuming
there is a diff, the area around the largest diff
is drawn zoomed in from both images.

Matching cells are outlined in green, failing cells
are outlined in red. Triaging this GM just involves
answering the question: "Are there any red boxes?"

"Good" example: https://screenshot.googleplex.com/909P3tvS55f.png
"Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png

To get more tests to pass, (and fix an assert
in Ganesh), I've gone ahead and enforced that user
supplied rects (in drawRect and drawOval) are
always sorted once they hit the canvas virtuals.
Currently, drawArc rejects empty ovals, but I added
the same assert to onDrawArc, if we decide to change
the strategy there.

Re-land of: https://skia-review.googlesource.com/c/16983/

Bug: skia:
Change-Id: I48f85de5f2bcb7fdc9558c2fd80cb1f20800b244
Reviewed-on: https://skia-review.googlesource.com/17270
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/eb7bab7bbcce65bf06842413025d611c62acb454 Update emulator bot master and builder. (jbudorick@chromium.org)
recipe_engine:
  https://crrev.com/a819ab06fa3974b0fdee796aa4dd883274f4df2f [step_runner] do not immediately bail when START_DIR is gone. (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idf274aca3f6b41dbd19b07fdb8e08d0e1cd344e8
Reviewed-on: https://skia-review.googlesource.com/17267
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Revert "Add GM to verify that drawX == (path.addX, drawPath)"

This reverts commit 78d1b428a8e8a0b76e88e9266d2893136acd5906.

Reason for revert: break preabandongpu bot

Original change's description:
> Add GM to verify that drawX == (path.addX, drawPath)
>
> This demonstrates a new kind of hybrid unit test/GM.
> It creates a grid of cells. In each cell, we do two
> renders that are expected to produce the same result.
> For each cell, we render the two results overlaid,
> and highlight any differing pixels in red. Assuming
> there is a diff, the area around the largest diff
> is drawn zoomed in from both images.
>
> Matching cells are outlined in green, failing cells
> are outlined in red. Triaging this GM just involves
> answering the question: "Are there any red boxes?"
>
> "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png
> "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png
>
> To get more tests to pass, (and fix an assert
> in Ganesh), I've gone ahead and enforced that user
> supplied rects (in drawRect and drawOval) are
> always sorted once they hit the canvas virtuals.
> Currently, drawArc rejects empty ovals, but I added
> the same assert to onDrawArc, if we decide to change
> the strategy there.
>
> Bug: skia:
> Change-Id: I021a18c85e234298e1d29f333662683d996dd42c
> Reviewed-on: https://skia-review.googlesource.com/16983
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Reed <reed@google.com>
>

TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: skia:

Change-Id: Id1ead4e22115c49cad5d0adb6151ede81734b4d3
Reviewed-on: https://skia-review.googlesource.com/17269
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Replace most uses of GrSurface::desc() with conifg(), width(), etc.

Change-Id: Ic283c0ddf9efa0a467e97e10f5413ba9dfcb414f
Reviewed-on: https://skia-review.googlesource.com/17211
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/31287b7fc427b15bca8f05b987e4045742b2b157 Bootstrap "archive_layout_test_retry_summary". (dnj@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I995f9838878418f84d4a3f30796724306726f901
Reviewed-on: https://skia-review.googlesource.com/17264
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/f855de86ca9fc39081e10e7941b2a007e3f501a4 Use is_official_build=true for cronet builds. (mef@chromium.org)
depot_tools:
  https://crrev.com/7adb584516fd5dbde62d7e1d7156806977331acb [bot_update] Remove retry logic. (dnj@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I85fc58c0d8a6212dc0f71b8ce399d77dbca0003d
Reviewed-on: https://skia-review.googlesource.com/17262
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Remove GrSurfaceDesc member from GrSurfaceProxy.

Stores the config, origin, and dimensions in GrSurfaceProxy, sample count in GrRenderTargetProxy, and "was constructed with mip maps" in GrTextureProxy.

Change-Id: Iee058674dce49107a991cca9d083cd33e3572809
Reviewed-on: https://skia-review.googlesource.com/17209
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

Add tool to create test images with interesting color profiles

Bug: skia:
Change-Id: Ia4f892368fceda4a99490f5bd29851837a7a6927
Reviewed-on: https://skia-review.googlesource.com/17212
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

Add GM to verify that drawX == (path.addX, drawPath)

This demonstrates a new kind of hybrid unit test/GM.
It creates a grid of cells. In each cell, we do two
renders that are expected to produce the same result.
For each cell, we render the two results overlaid,
and highlight any differing pixels in red. Assuming
there is a diff, the area around the largest diff
is drawn zoomed in from both images.

Matching cells are outlined in green, failing cells
are outlined in red. Triaging this GM just involves
answering the question: "Are there any red boxes?"

"Good" example: https://screenshot.googleplex.com/909P3tvS55f.png
"Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png

To get more tests to pass, (and fix an assert
in Ganesh), I've gone ahead and enforced that user
supplied rects (in drawRect and drawOval) are
always sorted once they hit the canvas virtuals.
Currently, drawArc rejects empty ovals, but I added
the same assert to onDrawArc, if we decide to change
the strategy there.

Bug: skia:
Change-Id: I021a18c85e234298e1d29f333662683d996dd42c
Reviewed-on: https://skia-review.googlesource.com/16983
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>

skslc SPIR-V mod support

Change-Id: I2df761ff0d25712dc48d367585d4b639e46d5d97
Reviewed-on: https://skia-review.googlesource.com/17243
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/6685fe37889919448bfa3bbf3d93e15026680e0a Bisect - Check for gerrit patch properties. (simonhatch@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb2b1d0029950de9dbd30d8a7064c89cc951c6b6
Reviewed-on: https://skia-review.googlesource.com/17240
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Adjust start and end points of arcs based on CTM

GPU was effectively ignoring rotation and scale when drawing arcs. Found
this with a new GM I'll be adding. Hoping to land that separately.

Bug: skia:
Change-Id: I14d36ceaa478193c1a75fb2d06704e7d51f46d02
Reviewed-on: https://skia-review.googlesource.com/17218
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

Fix for amd copy as draws on vulkan

Our copies as draws have the same bug on amd as normal bugs where we need
to start a new command buffer before binding a pipeline to it.

Bug: skia:
Change-Id: If9cade2e069bf09758c5328bf606c9bd5b5aab9c
Reviewed-on: https://skia-review.googlesource.com/17213
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/b8526d5091832eff8dadd54a21967ba7fa3c51ba Turn the 'archive_profile_database' errors into warnings. (sebmarchand@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8db0bb0ade49b80b14e29a86acaba9e541fc6c98
Reviewed-on: https://skia-review.googlesource.com/17217
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

skslc comma operator and optimizer fixes

Bug: skia:
Change-Id: I732d4fba843c06af570d4a56cadfaa1cc565808c
Reviewed-on: https://skia-review.googlesource.com/17125
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/fa05f0c918ae03a5b0595b44e7bf0b378404d0b0 Turtles all the way down = aka debugging chromium_tests 3. (tandrii@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib4142bf510444462a73e97f21475df503859ad41
Reviewed-on: https://skia-review.googlesource.com/17216
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

scalarize SkGradientShader stop setup

One of Clankium's GCC 4.9 builds is crashing when compiling the
existing Sk4f version, so let's try ordinary scalar math.

BUG=chromium:721682

Change-Id: Ie37bf530ada537363119acd31814ae46cd3adf73
Reviewed-on: https://skia-review.googlesource.com/17210
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

Delete legacy image generator API flag

Bug: skia:6620
Change-Id: I7ecdb5b162d8d468d91d4c8dbe276fabe349dc15
Reviewed-on: https://skia-review.googlesource.com/17215
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/6693edfe68b50da94228077969ef3fe1af3becf4 Turtles all the way down = aka debugging chromium_tests. (tandrii@chromium.org)
  https://crrev.com/c69c5e6e2a2d11156e8adf2dab4a9052d63ccf1b Turtles all the way down = aka debugging chromium_tests 2. (tandrii@chromium.org)
  https://crrev.com/d9baad869a80389fbe6796415ae5596ccf0bbdd3 Remove debug output during recipe training. (tandrii@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7513d133502918f52aa38acbc1dd38e59e2362ea
Reviewed-on: https://skia-review.googlesource.com/17214
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Remove RenderTarget pointer from GrRenderTargetOpList::RecordedOp
Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec

Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec
Reviewed-on: https://skia-review.googlesource.com/17117
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

Remove static initializer of GrProcessorSet::gEmpty

Change-Id: I9d4cb34c54458ad42a413f251d1018217de26b90
Reviewed-on: https://skia-review.googlesource.com/17206
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/591dc20cf87064d636e8921448ba8a5d00e97039 WebRTC: Add gerrit tryjob expectation to the recipes. (ehmaldonado@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3033b157238261cef31c7423f6d22bf9aed5aadb
Reviewed-on: https://skia-review.googlesource.com/17208
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

remove some stray semicolons

Change-Id: I00db78597f6c19b309569e771a5ff843365f7850
Reviewed-on: https://skia-review.googlesource.com/17207
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>

move shadows to device virtual

This CL keeps the impl for each device backend in the
utils file for simplicity (shared helpers). Future CLs
may move into their respective impl as they become
more specialized.

Bug: skia:
Change-Id: I97ce6cdcc5106ebf4c84778f943cc32d0b7613c1
Reviewed-on: https://skia-review.googlesource.com/15893
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>

Remove GrSurfaceProxy::desc()

Adds a numStencilSamples() getter.

Bug: skia:
Change-Id: I1e57f19b3cb490a6214ea436622ed8128a5a9303
Reviewed-on: https://skia-review.googlesource.com/16994
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/c0087564f11b6a1b68d5027cf093c31f4abf2186 Add debug marker for ease text search for debugging info. (tandrii@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib27213efbb87a05d4dcae7b37a485a44f397c310
Reviewed-on: https://skia-review.googlesource.com/17204
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Fix inset for ambient tessellated shadows

Ambient shadows were showing a little space between
the path and the shadow -- this covers that up.

Change-Id: Ib7076748dc6c77a3643ce6d925c79fb8a468e502
Reviewed-on: https://skia-review.googlesource.com/17130
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

Revert "Convert DstTexture to DstProxy"

This reverts commit 87f7f1c3ce519115141b40f1d8faede437c8f357.

Reason for revert: grumble, grumble

Original change's description:
> Convert DstTexture to DstProxy
>
> The last GrTexture-based TextureSampler::reset call must be removed before the TextureSamplers can become purely GrTextureProxy-backed
>
> Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))
>
> Change-Id: Ic1435177d8b5d9bd3fc38b4903c9baae8205cfb0
> Reviewed-on: https://skia-review.googlesource.com/16908
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>

TBR=egdaniel@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I9af52bb222bd2d8cc696250a9efb62afb80edba1
Reviewed-on: https://skia-review.googlesource.com/17203
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/bc4aedb9281865224a85b08442cdbee891ce2c07 Add gsubtreed builder for aosp/platform/system/core. (tandrii@chromium.org)
  https://crrev.com/050b9f74f78395ca1f5b15502e55a9534c61b4ce Log masked exception in test utils (machenbach@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I164bba8cfa50216acec82b601e7a61288ed64e7a
Reviewed-on: https://skia-review.googlesource.com/17200
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Convert DstTexture to DstProxy

The last GrTexture-based TextureSampler::reset call must be removed before the TextureSamplers can become purely GrTextureProxy-backed

Split out of: https://skia-review.googlesource.com/c/10484/ (Omnibus: Push instantiation of GrTextures later (post TextureSampler))

Change-Id: Ic1435177d8b5d9bd3fc38b4903c9baae8205cfb0
Reviewed-on: https://skia-review.googlesource.com/16908
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

Revert "add guard for extra includes"

This reverts commit 037d78f84134de6f24ad0df2faa4d6ff0e185790.

Reason for revert: did not help, will fix caller

Original change's description:
> add guard for extra includes
>
> Bug: skia:
> Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
> Reviewed-on: https://skia-review.googlesource.com/17162
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Reed <reed@google.com>
>

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: skia:

Change-Id: I6d7dd1c51ca81a6c24604ff509b31c2171b26314
Reviewed-on: https://skia-review.googlesource.com/17163
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

remove SK_API from namespaced enum

try to fix roll

Bug: skia:
Change-Id: I3022f23486e5c077f46711de520366f3ea90ef8d
Reviewed-on: https://skia-review.googlesource.com/17161
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

add guard for extra includes

Bug: skia:
Change-Id: Id500cb6ac6c2f4a925135a8e83ed4f2a07b73661
Reviewed-on: https://skia-review.googlesource.com/17162
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3b8a0585e3c7390a7c1c339c6b70d042de8f913c [engine] make all ad-hoc steps properly colored (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e3011f3e90f4c038bfe8e69e0e2f1738724cb18
Reviewed-on: https://skia-review.googlesource.com/17160
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/632d231c826e13b02ade64d77ed2a41e25aa6fb3 [step_runner] Add a Placeholder Exception step when rendering placeholders raises a StepFailure. (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab504ed66501a140a306abfe44ed43a958162003
Reviewed-on: https://skia-review.googlesource.com/17138
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

Fix shadow_utils light position for SampleApp tiling

Change-Id: Icddc82a095aa698bdba9004641acdc411392632f
Reviewed-on: https://skia-review.googlesource.com/17044
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

Add support for webp lossless compression

Bug: 713862
Change-Id: I8dcc6506338f3c54fb14a78620e7daaadadfedde
Reviewed-on: https://skia-review.googlesource.com/17073
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

Enable vulkan copies as draws for everything but qualcomm

Bug: skia:
Change-Id: I9fe2593460e2ff83ba4f9471e384f506c16544f9
Reviewed-on: https://skia-review.googlesource.com/17109
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
  https://crrev.com/88f0382b399586b171806af18ba0f88d46cf0a1e Add target_os=['fuchsia'] to fyi bot .gclient (scottmg@chromium.org)
  https://crrev.com/b9841c873eb172e8bc3522cc7c6984dad4f2e6ff Switch chromedriver and emulator recipes to devil provisioning. (jbudorick@chromium.org)
  https://crrev.com/83993d2461f62f12d0a64ffa45b4c22c15da9e04 [chromium_android] Deprecate detect_and_setup_devices. (jbudorick@chromium.org)
  https://crrev.com/0b92ca117dfab6ef5c78977c98c65803c828a5a2 Move --isolate file into the isolate root. (dnj@chromium.org)
  https://crrev.com/a1029142e5c37e0ca6ffa1c48681eea8e17c67e6 Update v8 rollers to not call pycurl (dnj@chromium.org)
depot_tools:
  https://crrev.com/7f8c775571a15f7d9dc25fb59a3361b119eec117 Revert "gclient: return non-zero exit code on unknown command" (machenbach@chromium.org)
  https://crrev.com/90e958b3b882b4d0c4457f8c86398bbde10a5208 bot_update: set fake user.{name,email} when running rebase. (tandrii@chromium.org)
  https://crrev.com/052034967a2daf32bc718aa576e0fea8ead5a0b8 Modernize gclient-new-workdir.py by using argparse (wychen@chromium.org)
  https://crrev.com/704be878162e5e0f776d77b182f4969103aa886b Add reflink support for gclient-new-workdir.py (wychen@chromium.org)
  https://crrev.com/d105249ddaa338aa8b4d090646c05102f9169f3b Don't add WATCHLIST CCs on private CLs (agable@chromium.org)
recipe_engine:
  https://crrev.com/3343170e687e1cfa402e70c6e90019f9f88f913f [package.py] prevent overriding undeclared repo dependency. (iannucci@chromium.org)
  https://crrev.com/c2d0f5d807793894df762930bc5d2729297658bf [bundle] do not include the main repo in the overrides. (iannucci@chromium.org)

TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I942ff7263b866b859b42cc94ec46a95bcd366335
Reviewed-on: https://skia-review.googlesource.com/17135
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

try Herb's new to_srgb

This was 6-8% faster than the previous code on my Trashcan.

Change-Id: I70081009e233c83226d6d302f871fb7e86cdc438
Reviewed-on: https://skia-review.googlesource.com/16986
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>