Fred Riss [Fri, 22 May 2020 02:21:51 +0000 (19:21 -0700)]
[lldb] Try harder to find the __NSCFBoolean addresses
It looks like recent CoreFoundation builds strip the non-public symbol
that we were looking for to find the 2 boolean "classes". The public
symbol is of course there, and it contains the address of the private
one. If we don't find the private symbol directly, go through a memory
read at the public symbol's location instead.
Amara Emerson [Fri, 6 Aug 2021 19:42:03 +0000 (12:42 -0700)]
Change TargetLowering::canMergeStoresTo() to take a MF instead of DAG.
DAG is unnecessary and we need this hook to implement store merging on GlobalISel too.
Dimitry Andric [Fri, 6 Aug 2021 19:06:08 +0000 (21:06 +0200)]
[libomptarget][amdgpu] don't declare Elf_Note on FreeBSD
On FreeBSD, the system `<libelf.h>` already declares `struct Elf_Note`
indirectly (via `<sys/elf_common.h>`). This results in compile errors
when building the libomptarget amdgpu plugin. Avoid redeclaring `struct
Elf_Note` on FreeBSD to fix the errors.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D107661
Davide Italiano [Fri, 6 Aug 2021 19:37:06 +0000 (12:37 -0700)]
[MachO] Introduce chained fixups related load commands.
Thomas Johnson [Fri, 6 Aug 2021 08:56:54 +0000 (10:56 +0200)]
[ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend
Differential Revision: https://reviews.llvm.org/D107611
Zahira Ammarguellat [Fri, 6 Aug 2021 19:01:47 +0000 (12:01 -0700)]
Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on"
This reverts commit
48ad446a0fb2c9b98cb7047e4daf8a84c29cef8f.
Asher Mancinelli [Fri, 6 Aug 2021 16:47:18 +0000 (10:47 -0600)]
[flang] Lift -Werror checks into local functions
Lift checks for -Werror into local functions.
Reviewed By: awarzynski
Differential Revision: https://reviews.llvm.org/D101261
Michał Górny [Fri, 6 Aug 2021 08:56:54 +0000 (10:56 +0200)]
[llvm] [cmake] Export LLVM_ENABLE_NEW_PASS_MANAGER into LLVMConfig.cmake
Include the vaue of LLVM_ENABLE_NEW_PASS_MANAGER in generated
LLVMConfig.cmake since it is needed by clang's build system. This fixes
test failures when the new pass manager is enabled (i.e. by default)
by having clang's CMake files correctly detect that and skip relevant
tests.
Differential Revision: https://reviews.llvm.org/D107628
Alexander Belyaev [Fri, 6 Aug 2021 13:34:30 +0000 (15:34 +0200)]
[mlir] Add patterns for vector.transfer_read/write to Linalg bufferization.
Differential Revision: https://reviews.llvm.org/D107643
Artem Belevich [Tue, 20 Jul 2021 21:37:06 +0000 (14:37 -0700)]
[CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.
Attempt to enable MemCpyOpt unconditionally in D104801 uncovered the fact that
there are users that do not expect LLVM to materialize `memset` intrinsic.
While other passes can do that, too, MemCpyOpt triggers it more frequently and
breaks sanitizers and some downstream users.
For now introduce a flag to force-enable the flag and opt-in only CUDA
compilation with NVPTX back-end.
Differential Revision: https://reviews.llvm.org/D106401
Petr Hosek [Fri, 6 Aug 2021 08:47:38 +0000 (01:47 -0700)]
[CMake] Check the builtins library value first
When the builtins library isn't found, find_compiler_rt_library
returns NOTFOUND so we'll end up linking against -lNOTFOUND. We need
to check the return value before adding it to the list.
Differential Revision: https://reviews.llvm.org/D107627
Sean Fertile [Fri, 6 Aug 2021 16:53:25 +0000 (12:53 -0400)]
Revert "[PowerPC][AIX] Limit attribute aligned to 4096."
This reverts commit
5181be344adbf7ba7dffc73526893d4e7750d34c.
Break libcxx type_traits header which uses aligned storage with
alignments greater than 4096. Reverting untill we can fix the header.
Paul Robinson [Fri, 6 Aug 2021 17:49:22 +0000 (10:49 -0700)]
2nd Speculative fix for MachO lld test after "Have REQUIRES support the target triple"
See: http://45.33.8.238/macm1/15677/step_10.txt
Follow-up to f88ad8d as it appears the lld invocations both emit an
error message; so, try adding 'not' to the RUN lines.
Michael Jones [Thu, 5 Aug 2021 21:27:29 +0000 (21:27 +0000)]
[libc][nfc] move ctype_utils and FPUtils to __support
Some ctype functions are called from other libc functions (e.g. isspace
is used in atoi). By moving ctype_utils.h to __support it becomes easier
to include just the implementations of these functions. For these
reasons the implementation for isspace was moved into
ctype_utils as well.
FPUtils was moved to simplify the build order, and to clarify which
files are a part of the actual libc.
Many files were modified to accomodate these changes, mostly changing
the #include paths.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D107600
LLVM GN Syncbot [Fri, 6 Aug 2021 16:59:24 +0000 (16:59 +0000)]
[gn build] Port
4ad9ec8a328c
Sam McCall [Thu, 5 Aug 2021 12:27:40 +0000 (14:27 +0200)]
[clangd] Rename Features.h -> Feature.h to avoid confilct with libstdc++
Fixes https://github.com/clangd/clangd/issues/835
Differential Revision: https://reviews.llvm.org/D107624
Markus Böck [Fri, 6 Aug 2021 16:53:49 +0000 (18:53 +0200)]
[mlir][NFC] Fix typos in DataLayoutInterfaces.td
Zheng Chen [Fri, 6 Aug 2021 16:29:47 +0000 (16:29 +0000)]
[LoopCacheAnalysis]: handle mismatch type for Numerator and CacheLineSize
fix an assertion due to mismatch type for Numerator and CacheLineSize in loop cache analysis pass.
Reviewed By: bmahjour
Differential Revision: https://reviews.llvm.org/D107618
Jon Roelofs [Thu, 5 Aug 2021 21:57:44 +0000 (14:57 -0700)]
[GlobalISel][KnownBits] Implement G_CTPOP
Implementation copied almost verbatim from ValueTracking.
Differential revision: https://reviews.llvm.org/D107606
Michael Liao [Thu, 5 Aug 2021 20:48:49 +0000 (16:48 -0400)]
[MemCpyOpt] Teach memcpyopt to handle loads from the constant memory.
- Loads from the constant memory (either explicit one or as the source
of memory transfer intrinsics) won't alias any stores.
Reviewed By: asbirlea, efriedma
Differential Revision: https://reviews.llvm.org/D107605
Craig Topper [Fri, 6 Aug 2021 16:31:05 +0000 (09:31 -0700)]
[LegalizeTypes] Add a simple expansion for SMULO when a libcall isn't available.
This isn't optimal, but prevents crashing when the libcall isn't
available. It just calculates the full product and makes sure the high bits
match the sign of the low half. Each of the pieces should go through their own
type legalization.
This can make D107420 unnecessary.
Needs tests, but I wanted to start discussion about D107420.
Reviewed By: FreddyYe
Differential Revision: https://reviews.llvm.org/D107581
David Green [Fri, 6 Aug 2021 16:35:11 +0000 (17:35 +0100)]
[ARM] Define ComplexPatternFuncMutatesDAG
Some of the Arm complex pattern functions call canExtractShiftFromMul,
which can modify the DAG in-place. For this to be valid and handled
successfully we need to define ComplexPatternFuncMutatesDAG.
Differential Revision: https://reviews.llvm.org/D107476
Paul Robinson [Fri, 6 Aug 2021 16:23:32 +0000 (09:23 -0700)]
Speculative fix for MachO lld test after "Have REQUIRES support the target triple"
See: http://45.33.8.238/macm1/15677/step_10.txt
This is a test that has `REQUIRES: x86` which means it never ran
before; I don't have a MachO environment but based on the FileCheck
output it looks like it should be sufficient to remove one CHECK line.
Pirama Arumuga Nainar [Tue, 3 Aug 2021 05:17:53 +0000 (22:17 -0700)]
[llvm-objcopy] [COFF] Do not patch debug entries if PointerToRawData is zero
Fix an edge case missed by https://reviews.llvm.org/D78921. For e.g.,
the Repro debug entry (generated with the /Brepro linker flag) does not
have a debug-directory payload. Do not attempt to patch Debug entries
without a payload.
Differential Revision: https://reviews.llvm.org/D107324
Paul Robinson [Fri, 6 Aug 2021 16:14:27 +0000 (09:14 -0700)]
Disable a dataflow fuzz test after "Have REQUIRES support the target triple"
See: https://lab.llvm.org/buildbot/#/builders/75/builds/8095/steps/8/logs/stdio
which shows:
unsupported option '-fsanitize=dataflow' for target 'i386-unknown-linux-gnu'
The other dataflow tests in the same directory were already disabled,
so I think it's fine to disable this one as well.
Jonas Devlieghere [Fri, 6 Aug 2021 16:01:52 +0000 (09:01 -0700)]
[lldb] Fix TestFunctionStarts.py on AS
The tests strips the binary which invalidates the code signature. Skip
code signing for this test.
Geoffrey Martin-Noble [Thu, 5 Aug 2021 22:45:35 +0000 (15:45 -0700)]
[MLIR][std] Introduce bitcast operation
This patch introduces a bitcast operation to the standard dialect.
RFC: https://llvm.discourse.group/t/rfc-introduce-a-bitcast-op/3774
Reviewed By: silvas
Differential Revision: https://reviews.llvm.org/D105376
Kazu Hirata [Fri, 6 Aug 2021 15:26:55 +0000 (08:26 -0700)]
[CodeGen] Remove computeDefOperandLatency (NFC)
The last use was removed on Oct 9, 2016 in commit
5c924d71173afc93aa0f0d115bd445a7496f4294.
Alex Zinenko [Wed, 28 Jul 2021 19:42:25 +0000 (21:42 +0200)]
[mlir] support collapsed loops in OpenMP-to-LLVM translation
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D105706
Paul Robinson [Fri, 6 Aug 2021 15:07:51 +0000 (08:07 -0700)]
Fix test failure found by "Have REQUIRES support the target triple"
Jake Egan [Fri, 6 Aug 2021 14:42:18 +0000 (10:42 -0400)]
[AIX] Define _ARCH_PPC64 macro for 32-bit
%%%
The macro _ARCH_PPC64 is already defined for 64-bit, but this patch defines it for 32-bit on AIX to follow xlc. See: https://www.ibm.com/docs/en/xl-c-and-cpp-aix/13.1.0?topic=features-macros-related-architecture-settings
Note: This change creates a discrepancy between GCC, which defines _ARCH_PPC64 only for 64-bit mode.
Tested with SPEC.
%%%
Reviewed By: cebowleratibm
Differential Revision: https://reviews.llvm.org/D107244
Jake Egan [Fri, 6 Aug 2021 14:39:47 +0000 (10:39 -0400)]
[AIX] Define __HOS_AIX__ macro
%%%
This patch defines __HOS_AIX__ macro for AIX in case of a cross compiler implementation.
%%%
Tested with SPEC.
Reviewed By: cebowleratibm
Differential Revision: https://reviews.llvm.org/D107242
Paul Robinson [Fri, 30 Jul 2021 13:54:58 +0000 (06:54 -0700)]
[lit] Have REQUIRES support the target triple
Currently the UNSUPPORTED and XFAIL clauses support specifying
substrings of the target triple; but REQUIRES does not, which can trip
people up or lead to hacking config files to insert substitute feature
names. Consistency across all three lit clauses seems preferable.
Differential Revision: https://reviews.llvm.org/D107162
Corentin Jabot [Fri, 6 Aug 2021 14:29:28 +0000 (10:29 -0400)]
Implement P1937 consteval in unevaluated contexts
In an unevaluated contexts, consteval functions should not be
immediately evaluated.
Corentin Jabot [Fri, 6 Aug 2021 14:26:39 +0000 (10:26 -0400)]
Disallow narrowing conversions to bool in noexcept specififers
Completes the support for P1401R5.
Jake Egan [Fri, 6 Aug 2021 13:49:53 +0000 (09:49 -0400)]
[AIX] Define __THW_PPC__ macro
%%%
This patch defines the macro __THW_PPC__ for AIX.
%%%
Tested with SPEC.
Reviewed By: cebowleratibm
Differential Revision: https://reviews.llvm.org/D107243
Jake Egan [Fri, 6 Aug 2021 13:46:14 +0000 (09:46 -0400)]
[AIX] Define __THW_BIG_ENDIAN__ macro
%%%
This patch defines the macro __THW_BIG_ENDIAN__ for AIX.
%%%
Tested with SPEC.
Reviewed By: cebowleratibm
Differential Revision: https://reviews.llvm.org/D107241
Jay Foad [Fri, 6 Aug 2021 10:05:42 +0000 (11:05 +0100)]
[GlobalISel] Improve widening of cttz/cttz_zero_undef
Differential Revision: https://reviews.llvm.org/D107631
Arthur O'Dwyer [Fri, 6 Aug 2021 13:20:59 +0000 (09:20 -0400)]
[libc++] IWYU to fix Modules complaints about _LIBCPP_ASSERT. NFCI.
This fixes all places that used _LIBCPP_ASSERT without including <__debug>.
git grep -l _LIBCPP_ASSERT | xargs git grep -L __debug
Kadir Cetinkaya [Fri, 6 Aug 2021 11:25:14 +0000 (13:25 +0200)]
[clangd] Canonicalize inputs provided with `--`
We already strip all the inputs provided without `--`, this patch also
handles the cases with `--`.
Differential Revision: https://reviews.llvm.org/D107637
Kadir Cetinkaya [Fri, 6 Aug 2021 10:52:41 +0000 (12:52 +0200)]
[clangd] Strip mutliple arch options
This patch strips all the arch options in case of multiple ones. As it
results in multiple compiler jobs, which clangd cannot handle.
It doesn't pick any over the others as it is unclear which one the user wants
and defaulting to host architecture seems less surprising. Users also have the
ability to explicitly specify the architecture they want via clangd config
files.
Fixes https://github.com/clangd/clangd/issues/827.
Differential Revision: https://reviews.llvm.org/D107634
Dmitry Preobrazhensky [Fri, 6 Aug 2021 12:49:52 +0000 (15:49 +0300)]
[AMDGPU][MC][NFC][DOC] Updated AMD GPU assembler syntax description.
Corrected sendmsg description (bug https://bugs.llvm.org/show_bug.cgi?id=49648).
Jan Svoboda [Fri, 6 Aug 2021 12:46:41 +0000 (14:46 +0200)]
[clang] Remove misleading assertion in FullSourceLoc
D31709 added an assertion was added to `FullSourceLoc::hasManager()` that ensured a valid `SourceLocation` is always paired with a `SourceManager`, and missing `SourceManager` is always paired with an invalid `SourceLocation`.
This appears to be incorrect, since clients never cared about constructing `FullSourceLoc` to uphold that invariant, or always checking `isValid()` before calling `hasManager()`.
The assertion started failing when serializing diagnostics pointing into an explicit module. Explicit modules don't have valid `SourceLocation` for the `import` statement, since they are "imported" from the command-line argument `-fmodule-name=x.pcm`.
This patch removes the assertion, since `FullSourceLoc` was never intended to uphold any kind of invariants between the validity of `SourceLocation` and presence of `SourceManager`.
Reviewed By: arphaman
Differential Revision: https://reviews.llvm.org/D106862
Andrzej Warzynski [Thu, 5 Aug 2021 09:17:37 +0000 (09:17 +0000)]
[flang][docs] Document the `flang` wrapper script
Differential Revision: https://reviews.llvm.org/D107543
Rainer Orth [Fri, 6 Aug 2021 12:04:11 +0000 (14:04 +0200)]
[profile] Only use NT_GNU_BUILD_ID if supported
The Solaris buildbots have been broken for some time by the unconditional
use of `NT_GNU_BUILD_ID`, e.g. Solaris/sparcv9
<https://lab.llvm.org/staging/#/builders/50/builds/4910> and Solaris/amd64
<https://lab.llvm.org/staging/#/builders/101/builds/3751>. Being a GNU
extension, it is not defined in `<sys/elf.h>`. However, providing a
fallback definition doesn't help because the code also relies on
`__ehdr_start`, another unportable GNU extension that most likely never
will be implemented in Solaris `ld`. Besides, there's reallly no point in
supporting build ids since they aren't used on Solaris at all.
This patch fixes this by making the relevant code conditional on the
definition of `NT_GNU_BUILD_ID`.
Tested on `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`.
Differential Revision: https://reviews.llvm.org/D107556
Mircea Trofin [Thu, 5 Aug 2021 19:29:27 +0000 (12:29 -0700)]
[NFC][MLGO] Make logging more robust
1) add some self-diagnosis (when asserts are enabled) to check that all
features have the same nr of entries
2) avoid storing pointers to mutable fields because the proto API
contract doesn't actually guarantee those stay fixed even if no further
mutation of the object occurs.
Differential Revision: https://reviews.llvm.org/D107594
Luna Kirkby [Fri, 6 Aug 2021 11:08:17 +0000 (07:08 -0400)]
Split 'qualifier on reference type has no effect' out into a new flag
This introduces a new flag ignored-reference-qualifiers for the
existing "'A' qualifier on reference type B has no effect" diagnostic,
as a child of ignored-qualifiers.
Rationale:
This particular diagnostic is enabled by default, but other parts of
ignored-qualifiers are not. Anecdotally, a user may encounter this
diagnostic in the wild, and, seeing it to be valuable, might try to
raise it to error with -Werror=ignored-qualifiers, whereupon the other
diagnostics the flag covers will also be raised, to the user's surprise
and confusion. By splitting this diagnostic out into a separate flag,
and marking it as a child of ignored-qualifiers, we allow the user more
granular control of the diagnostics they care about, while maintaining
backwards compatibility with existing build scripts.
Reshabh Sharma [Fri, 6 Aug 2021 09:56:12 +0000 (15:26 +0530)]
[AMDGPU] Handle functions in llvm's global ctors and dtors list
This patch introduces a new code object metadata field, ".kind"
which is used to add support for init and fini kernels.
HSAStreamer will use function attributes, "device-init" and
"device-fini" to distinguish between init and fini kernels from
the regular kernels and will emit metadata with ".kind" set to
"init" and "fini" respectively.
To reduce the number of init and fini kernels, the ctors and
dtors present in the llvm's global.ctors and global.dtors lists
are called from a single init and fini kernel respectively.
Reviewed by: yaxunl
Differential Revision: https://reviews.llvm.org/D105682
Simon Pilgrim [Fri, 6 Aug 2021 10:21:19 +0000 (11:21 +0100)]
[ARM] Fold insert_subvector to concat_vectors
D107068 fixed the same problem on aarch64 but the arm variant wasn't exposed in existing test coverage.
I've copied the arm64-neon-copy tests (and stripped the intrinsic test from it) for testing on arm neon builds as well.
Simon Pilgrim [Fri, 6 Aug 2021 09:46:22 +0000 (10:46 +0100)]
[X86][AVX] Extract SUBV_BROADCAST constant bits from just the lower subvector range (PR51281)
As reported on PR51281, an internal fuzz test encountered an issue when extracting constant bits from a SUBV_BROADCAST node from a constant pool source larger than the broadcasted subvector width.
The getTargetConstantBitsFromNode was assuming that the Constant would the same size as the subvector, resulting in the incorrect packing of the per-element bits data.
This patch attempts to solve this by using the SUBV_BROADCAST node to determine the subvector width, and then ensuring we extract only the lowest bits from Constant of that subvector bitsize.
Differential Revision: https://reviews.llvm.org/D107158
Alexander Belyaev [Fri, 6 Aug 2021 09:28:11 +0000 (11:28 +0200)]
[linalg] Expose `rewriteAsPaddedOp` function.
Differential Revision: https://reviews.llvm.org/D107629
Justas Janickas [Thu, 5 Aug 2021 11:42:53 +0000 (12:42 +0100)]
[C++4OpenCL] Introduces __remove_address_space utility
This change provides a way to conveniently declare types that have
address space qualifiers removed.
Since OpenCL adds address spaces implicitly even when they are not
specified in source, it is useful to allow deriving address space
unqualified types.
Fixes llvm.org/PR45326
Differential Revision: https://reviews.llvm.org/D106785
Stefan Gränitz [Fri, 6 Aug 2021 09:15:54 +0000 (11:15 +0200)]
[Orc][examples] Temporarily disable tests for the C API due to failures on sanitizer bots
These tests were added while the OrcV2Example tests had been disabled:
https://reviews.llvm.org/rGe5d8cfb2f134fcf0235ec1a35eec875a9cd36b21
Failures on sanitizer bots:
https://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/7992/testReport/
Cullen Rhodes [Fri, 6 Aug 2021 08:16:07 +0000 (08:16 +0000)]
[AArch64] NFC: drop unnecessary llvm:: namespace prefix on MCInst
Sven van Haastregt [Fri, 6 Aug 2021 09:21:26 +0000 (10:21 +0100)]
[OpenCL][Docs] Adding builtins requires adding to both now
As we are trying to reach parity between opencl-c.h and
-fdeclare-opencl-builtins, ensure the documentation mentions that new
builtins should be added to both.
Reviewed by: Anastasia Stulova
David Sherwood [Fri, 30 Jul 2021 07:41:31 +0000 (08:41 +0100)]
[LoopVectorize] Improve vectorisation of some intrinsics by treating them as uniform
This patch adds more instructions to the Uniforms list, for example certain
intrinsics that are uniform by definition or whose operands are loop invariant.
This list includes:
1. The intrinsics 'experimental.noalias.scope.decl' and 'sideeffect', which
are always uniform by definition.
2. If intrinsics 'lifetime.start', 'lifetime.end' and 'assume' have
loop invariant input operands then these are also uniform too.
Also, in VPRecipeBuilder::handleReplication we check if an instruction is
uniform based purely on whether or not the instruction lives in the Uniforms
list. However, there are certain cases where calls to some intrinsics can
be effectively treated as uniform too. Therefore, we now also treat the
following cases as uniform for scalable vectors:
1. If the 'assume' intrinsic's operand is not loop invariant, then we
are free to treat this as uniform anyway since it's only a performance
hint. We will get the benefit for the first lane.
2. When the input pointers for 'lifetime.start' and 'lifetime.end' are loop
variant then for scalable vectors we assume these still ultimately come
from the broadcast of an alloca. We do not support scalable vectorisation
of loops containing alloca instructions, hence the alloca itself would
be invariant. If the pointer does not come from an alloca then the
intrinsic itself has no effect.
I have updated the assume test for fixed width, since we now treat it
as uniform:
Transforms/LoopVectorize/assume.ll
I've also added new scalable vectorisation tests for other intriniscs:
Transforms/LoopVectorize/scalable-assume.ll
Transforms/LoopVectorize/scalable-lifetime.ll
Transforms/LoopVectorize/scalable-noalias-scope-decl.ll
Differential Revision: https://reviews.llvm.org/D107284
Vladislav Vinogradov [Tue, 3 Aug 2021 14:23:31 +0000 (17:23 +0300)]
[mlir] Allow to override type/attr aliases from various hooks
Use new return type for `OpAsmDialectInterface::getAlias`:
* `AliasResult::NoAlias` if an alias was not provided.
* `AliasResult::OverridableAlias` if an alias was provided, but it might be overriden by other hook.
* `AliasResult::FinalAlias` if an alias was provided and it should be used (no other hooks will be checked).
In that case `AsmPrinter` will use either the first alias with `FinalAlias` result or
the last alias with `OverridableAlias` result (it depends on dialect array order).
Used `OverridableAlias` result for `BuiltinOpAsmDialectInterface`.
Use case: provide more informative alias for built-in attributes like `AffineMapAttr`
instead of generic "map<N>".
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D107437
Chuanqi Xu [Fri, 6 Aug 2021 07:10:02 +0000 (15:10 +0800)]
[FuncSpec] Return changed if function is changed by tryToReplaceWithConstant
The may get changed before specialization by RunSCCPSolver. In other
words, the pass may change the function without specialization happens.
Add test and comment to reveal this.
And it may return No Changed if the function get changed by
RunSCCPSolver before the specialization. It looks like a potential bug.
Test Plan: check-all
Reviewed By: https://reviews.llvm.org/D107622
Differential Revision: https://reviews.llvm.org/D107622
Esme-Yi [Fri, 6 Aug 2021 08:54:02 +0000 (08:54 +0000)]
[llvm-readobj][XCOFF] Warn about invalid offset
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D107398
David Sherwood [Fri, 6 Aug 2021 07:33:44 +0000 (08:33 +0100)]
Revert "[LoopVectorize] Add support for replication of more intrinsics with scalable vectors"
This reverts commit
95800da914938129083df2fa0165c1901909c273.
Jay Foad [Tue, 3 Aug 2021 16:11:08 +0000 (17:11 +0100)]
[AMDGPU][GlobalISel] Better legalization of 32-bit ctlz/cttz
Differential Revision: https://reviews.llvm.org/D107474
Jay Foad [Wed, 4 Aug 2021 10:55:29 +0000 (11:55 +0100)]
[AMDGPU][GlobalISel] Improve regbankselect for 64-bit VGPR ctlz_zero_undef/cttz_zero_undef
We can improve on the generic splitting by using ffbh/ffbl, which have a
defined result when the input is zero.
Differential Revision: https://reviews.llvm.org/D107442
Jay Foad [Wed, 4 Aug 2021 08:14:25 +0000 (09:14 +0100)]
[AMDGPU][GlobalISel] Add G_AMDGPU_FFBL_B32
This is the counterpart to G_AMDGPU_FFBH_U32 which already exists. These
instructions have a defined result of -1 when the input is zero.
Differential Revision: https://reviews.llvm.org/D107441
Jay Foad [Wed, 4 Aug 2021 13:37:45 +0000 (14:37 +0100)]
[GlobalISel] Improve legalization of narrow CTTZ
Differential Revision: https://reviews.llvm.org/D107457
Chuanqi Xu [Fri, 6 Aug 2021 08:38:20 +0000 (16:38 +0800)]
[NFC] [FuncSpec] Remove unused variables in isArgumentInteresting
Chuanqi Xu [Fri, 6 Aug 2021 07:38:06 +0000 (15:38 +0800)]
[FuncSpec] Move invariant computation for spec cost out of loop (NFC-ish)
Noticed that the computation for function specialization cost of a
function wouldn't change during the traversal of the arguments for the
function. We could hoist the computation out of the traversal. I
observed about ~1% improvement on compile time for spec2017. But I guess
it may not be precise. This should be NFC and fine.
Reviewed By: Sjoerd Meijer
Differential Revision: https://reviews.llvm.org/D107621
Serge Pavlov [Thu, 5 Aug 2021 11:12:18 +0000 (18:12 +0700)]
Introduce intrinsic llvm.isnan
This is recommit of the patch
16ff91ebccda1128c43ff3cee104e2c603569fb2,
reverted in
0c28a7c990c5218d6aec47c5052a51cba686ec5e because it had
an error in call of getFastMathFlags (base type should be FPMathOperator
but not Instruction). The original commit message is duplicated below:
Clang has builtin function '__builtin_isnan', which implements C
library function 'isnan'. This function now is implemented entirely in
clang codegen, which expands the function into set of IR operations.
There are three mechanisms by which the expansion can be made.
* The most common mechanism is using an unordered comparison made by
instruction 'fcmp uno'. This simple solution is target-independent
and works well in most cases. It however is not suitable if floating
point exceptions are tracked. Corresponding IEEE 754 operation and C
function must never raise FP exception, even if the argument is a
signaling NaN. Compare instructions usually does not have such
property, they raise 'invalid' exception in such case. So this
mechanism is unsuitable when exception behavior is strict. In
particular it could result in unexpected trapping if argument is SNaN.
* Another solution was implemented in https://reviews.llvm.org/D95948.
It is used in the cases when raising FP exceptions by 'isnan' is not
allowed. This solution implements 'isnan' using integer operations.
It solves the problem of exceptions, but offers one solution for all
targets, however some can do the check in more efficient way.
* Solution implemented by https://reviews.llvm.org/D96568 introduced a
hook 'clang::TargetCodeGenInfo::testFPKind', which injects target
specific code into IR. Now only SystemZ implements this hook and it
generates a call to target specific intrinsic function.
Although these mechanisms allow to implement 'isnan' with enough
efficiency, expanding 'isnan' in clang has drawbacks:
* The operation 'isnan' is hidden behind generic integer operations or
target-specific intrinsics. It complicates analysis and can prevent
some optimizations.
* IR can be created by tools other than clang, in this case treatment
of 'isnan' has to be duplicated in that tool.
Another issue with the current implementation of 'isnan' comes from the
use of options '-ffast-math' or '-fno-honor-nans'. If such option is
specified, 'fcmp uno' may be optimized to 'false'. It is valid
optimization in general, but it results in 'isnan' always returning
'false'. For example, in some libc++ implementations the following code
returns 'false':
std::isnan(std::numeric_limits<float>::quiet_NaN())
The options '-ffast-math' and '-fno-honor-nans' imply that FP operation
operands are never NaNs. This assumption however should not be applied
to the functions that check FP number properties, including 'isnan'. If
such function returns expected result instead of actually making
checks, it becomes useless in many cases. The option '-ffast-math' is
often used for performance critical code, as it can speed up execution
by the expense of manual treatment of corner cases. If 'isnan' returns
assumed result, a user cannot use it in the manual treatment of NaNs
and has to invent replacements, like making the check using integer
operations. There is a discussion in https://reviews.llvm.org/D18513#387418,
which also expresses the opinion, that limitations imposed by
'-ffast-math' should be applied only to 'math' functions but not to
'tests'.
To overcome these drawbacks, this change introduces a new IR intrinsic
function 'llvm.isnan', which realizes the check as specified by IEEE-754
and C standards in target-agnostic way. During IR transformations it
does not undergo undesirable optimizations. It reaches instruction
selection, where is lowered in target-dependent way. The lowering can
vary depending on options like '-ffast-math' or '-ffp-model' so the
resulting code satisfies requested semantics.
Differential Revision: https://reviews.llvm.org/D104854
Florian Hahn [Fri, 6 Aug 2021 07:12:54 +0000 (08:12 +0100)]
[LV] Move reduction PHI node fixup to VPlan::execute (NFC).
All information to fix-up the reduction phi nodes in the vectorized loop
is available in VPlan now. This patch moves the code to do so, to make
this clearer. Fixing up the loop exit value still relies on other
information and remains outside of VPlan for now.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D100113
Stella Laurenzo [Fri, 6 Aug 2021 04:10:03 +0000 (04:10 +0000)]
[mlir][python] Make a number of imports relative.
Avoiding absolute imports allows the code to be relocatable (which is used for out of tree integrations).
Differential Revision: https://reviews.llvm.org/D107617
Amara Emerson [Fri, 6 Aug 2021 07:06:13 +0000 (00:06 -0700)]
[GlobalISel] Make GLoadStore::getMemSize[InBits]() const.
Christian Kühnel [Fri, 6 Aug 2021 07:00:38 +0000 (07:00 +0000)]
[doc] added links to discord and discourse
Some folks are not aware that we have a Discourse server in addition to the mailing lists and a Discord server in addition to IRC. So I think we should add that.
These were announced on the mailing list a while ago: https://lists.llvm.org/pipermail/llvm-dev/2019-November/136880.html
Differential Revision: https://reviews.llvm.org/D100943
Chuanqi Xu [Fri, 6 Aug 2021 06:41:46 +0000 (14:41 +0800)]
[NFC] [FuncSpec] Update the Todo list for recursive functions
Now the recursive functions may get specialized many times when
`func-specialization-max-iters` increases. See discussion in
https://reviews.llvm.org/D106426 for details.
luxufan [Fri, 6 Aug 2021 06:18:29 +0000 (14:18 +0800)]
[JITLink][RISCV] Add relocation fixup test
This patch add R_RISCV_HI20, R_RISCV_LO12 and R_RISCV_CALL relocation test
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D107327
Adrian Kuegel [Thu, 5 Aug 2021 09:30:09 +0000 (11:30 +0200)]
[mlir][MemRef] Fix canonicalization of BufferCast(TensorLoad).
CastOp::areCastCompatible does not check whether casts are definitely compatible.
When going from dynamic to static offset or stride, the canonicalization cannot
know whether it is really cast compatible. In that case, it can only canonicalize
to an alloc plus copy.
Differential Revision: https://reviews.llvm.org/D107545
Amara Emerson [Fri, 6 Aug 2021 06:21:08 +0000 (23:21 -0700)]
Delete copy-ctor of MachineFrameInfo.
I just hit a nasty bug when writing a unit test after calling MF->getFrameInfo()
without declaring the variable as a reference.
Deleting the copy-constructor also showed a place in the ARM backend which was
doing the same thing, albeit it didn't impact correctness there from the looks of it.
Kai Luo [Fri, 6 Aug 2021 06:00:57 +0000 (06:00 +0000)]
[PowerPC] Fix shift amount of xxsldwi when performing vector int_to_double
POC
```
// main.c
#include <stdio.h>
#include <altivec.h>
extern vector double foo(vector int s);
int main() {
vector int s = {0, 1, 0, 4};
vector double vd;
vd = foo(s);
printf("%lf %lf\n", vd[0], vd[1]);
return 0;
}
// poc.c
vector double foo(vector int s) {
int x1 = s[1];
int x3 = s[3];
double d1 = x1;
double d3 = x3;
vector double x = { d1, d3 };
return x;
}
```
Compiled with `poc.c main.c -mcpu=pwr8 -O3` on BE machine.
Current clang gives
```
4.000000 1.000000
```
while xlc gives
```
1.000000 4.000000
```
Xlc's output should be correct.
Reviewed By: shchenz, #powerpc
Differential Revision: https://reviews.llvm.org/D107428
Martin Storsjö [Fri, 6 Aug 2021 05:51:21 +0000 (08:51 +0300)]
[fuzzer] Fix building on case sensitive mingw platforms
Include windows.h with an all lowercase filename; Windows SDK headers
aren't self consistent so they can't be used in an entirely
case sensitive setting, and mingw headers use all lowercase names
for such headers.
This fixes building after
881faf41909b47376595e8d7bb9c9a109182d20b.
Arthur Eubanks [Fri, 6 Aug 2021 04:18:53 +0000 (21:18 -0700)]
[GCov] Emit memset instead of stores in __llvm_gcov_reset
For a very large module, __llvm_gcov_reset can become very large.
__llvm_gcov_reset previously emitted stores to a bunch of globals in one
huge basic block. MemCpyOpt would turn many of these stores into
memsets, and updating MemorySSA would be extremely slow.
Verified that this makes the compile time of certain files go down
drastically (20min -> 5min).
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D107538
Ryan Prichard [Fri, 6 Aug 2021 04:55:23 +0000 (21:55 -0700)]
Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC.
The intent of the negative #{{.*}} checks is to verify that the line
declaring/defining a function has no attribute, but they could restrict
later function declarations instead.
The 2008-09-02-FunctionNotes.ll check had allowed @fn3 to have an
attribute, because there is only a single "define void @fn3()" in the
output.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D107614
Serge Bazanski [Fri, 6 Aug 2021 04:08:09 +0000 (21:08 -0700)]
[Lanai] fix lowering wide returns
This implements LanaiTargetLowering::CanLowerReturn, thereby ensuring
all return values conform to the RetCC and get sret-demoted as
necessary.
A regression test is also added that exercises this functionality.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D107086
Arthur O'Dwyer [Fri, 6 Aug 2021 03:29:53 +0000 (23:29 -0400)]
[libc++] s/_VSTD::_IsSame/_IsSame/. NFCI.
Jinsong Ji [Fri, 6 Aug 2021 02:58:50 +0000 (02:58 +0000)]
[PowerPC] Fix copy/paste error in scalar_to_vector patterns
https://reviews.llvm.org/D100478 refactoring added a copy/paste error
for v8i16 patterns.
Reviewed By: #powerpc, shchenz
Differential Revision: https://reviews.llvm.org/D107609
Jacques Pienaar [Fri, 6 Aug 2021 02:51:48 +0000 (19:51 -0700)]
[mlir] std.call reference function return types in failure
Makes it easier to see type mismatch from failure locally.
Differential Revision: https://reviews.llvm.org/D107288
Vitaly Buka [Fri, 6 Aug 2021 02:50:42 +0000 (19:50 -0700)]
[NFC][sanitizer] clang-format sem related block
Kai Luo [Fri, 6 Aug 2021 02:37:18 +0000 (02:37 +0000)]
[PowerPC] Pre-commit test for D107428. NFC.
Shilei Tian [Fri, 6 Aug 2021 02:31:42 +0000 (22:31 -0400)]
[NFC] Clean up and clang-format openmp/libomptarget/plugins/cuda/src/rtl.cpp
Jason Molenda [Fri, 6 Aug 2021 02:27:55 +0000 (19:27 -0700)]
Revert "[LLDB][GUI] Refactor form drawing using subsurfaces"
Temporarily revert this patch to unbreak the bots/builds
until we can understand what was intended; is_pad() call
isn't defined.
This reverts commit
2b89f40a411cb9717232df61371b24d73ae84cb8.
Matt Jacobson [Fri, 6 Aug 2021 02:12:00 +0000 (10:12 +0800)]
[AVR][clang] Pass '-fno-use-init-array' to cc1 as default
On AVR, '.ctors' is used, not '.init_array'. Make this the default
unless specifically overridden by driver argument.
This matches gcc, and it matches the behavior in (e.g.) the NetBSD
driver (for certain OS variants).
Reviewed by: MaskRay
Differential Revision: https://reviews.llvm.org/D107610
Matthias Springer [Fri, 6 Aug 2021 01:28:12 +0000 (10:28 +0900)]
[mlir] Cleanup: Fix warnings in MLIR
Tested with gcc-10. Other compilers may generate additional warnings. This does not fix all warnings. There are a few extra ones in LLVMCore and MLIR.
* `OpEmitter::getAttrNameIndex`: -Wunused-function (function is private and not used anywhere)
* `PrintOpPass` copy constructor: -Wextra ("Base class should be explicitly initialized in the copy constructor")
* `LegalizeForLLVMExport.cpp`: -Woverflow (overflow is expected, silence warning by making the cast explicit)
Differential Revision: https://reviews.llvm.org/D107525
Jessica Paquette [Thu, 5 Aug 2021 21:26:36 +0000 (14:26 -0700)]
[AArch64][GlobalISel] Overhaul G_INSERT legalization
Similar cleanup to G_EXTRACT (
51bd4e874fa51412e7399fe7f863169b4f4829bc).
Also swap the order of clamp/widen to avoid unnecessary complex merges.
Add a bunch of missing testcases to legalize-inserts while we're at it.
Differential Revision: https://reviews.llvm.org/D107601
Jessica Paquette [Thu, 5 Aug 2021 21:48:18 +0000 (14:48 -0700)]
[AArch64][GlobalISel] Widen G_IMPLICIT_DEF and G_FREEZE before clamping
Similar to other cleanup commits which widen instructions before clamping
during legalization. Purpose of this is to avoid weird type breakdowns.
In terms of G_IMPLICIT_DEF, this simplifies legalization for other instructions.
The legalizer has to emit G_IMPLICIT_DEF to legalize certain instructions, so
this can help with emitting merges elsewhere.
Differential Revision: https://reviews.llvm.org/D107604
Sean Fertile [Fri, 14 May 2021 17:55:13 +0000 (13:55 -0400)]
[PowerPC][AIX] Create multiple constant sections.
Fixes issue where late materialized constants can be more strictly
aligned then their containing csect.
Differential Revision: https://reviews.llvm.org/D103103
Jon Roelofs [Fri, 6 Aug 2021 00:46:33 +0000 (17:46 -0700)]
Revert "[GlobalISel][KnownBits] Implement G_CTPOP"
This reverts commit
ce6eb4f15a159e652bdccf92a9d3da8a972d1596.
It's broken on the windows bots: https://reviews.llvm.org/D107606#2930121
Amara Emerson [Thu, 29 Jul 2021 00:30:06 +0000 (17:30 -0700)]
[GlobalISel] Allow the ArtifactValueFinder to return the best available register on failure.
In some cases, like with inserts, we may have a matching size register already,
but still decide to try to look further. This change adds a CurrentBest
register to the value finder state, and any time a method fails to make progress,
returns that register (which may just be an empty Register).
To facilitate this, add a new entry point to the findValueFromDef() function
which initializes this state.
Also fix the build vector finder to return the current build_vector if all
sources are being requested.
Differential Revision: https://reviews.llvm.org/D107017
Jon Roelofs [Thu, 5 Aug 2021 21:57:44 +0000 (14:57 -0700)]
[GlobalISel][KnownBits] Implement G_CTPOP
Implementation copied almost verbatim from ValueTracking.
Differential revision: https://reviews.llvm.org/D107606
wlei [Thu, 5 Aug 2021 03:20:58 +0000 (20:20 -0700)]
[llvm-profgen] Fix bug of loop scope mismatch
One performance issue happened in profile generation and it turned out the line 525 loop is the bottleneck.
Moving the code outside of loop scope can fix this issue. The run time is improved from 30+mins to ~30s.
Reviewed By: hoy, wenlei
Differential Revision: https://reviews.llvm.org/D107529
Omar Emara [Thu, 5 Aug 2021 23:50:50 +0000 (16:50 -0700)]
[LLDB][GUI] Refactor form drawing using subsurfaces
This patch adds a new method SubSurface to the Surface class. The method
returns another surface that is a subset of this surface. This is
important to further abstract away drawing from the ncurses objects. For
instance, fields could previously be drawn on subpads only but can now
be drawn on any surface. This is needed to create the file search
dialogs and similar functionalities.
There is an opportunity to refactor window drawing in general using
surfaces, but we shall consider this separately later.
Reviewed By: clayborg
Differential Revision: https://reviews.llvm.org/D107182
Ryan Prichard [Thu, 5 Aug 2021 23:35:02 +0000 (16:35 -0700)]
Mark getc_unlocked as unavailable by default
Before D45736, getc_unlocked was available by default, but turned off
for non-Cygwin/non-MinGW Windows. D45736 then added 9 more unlocked
functions, which were unavailable by default, but it also:
* left getc_unlocked enabled by default,
* removed the disabling line for Windows, and
* added code to enable getc_unlocked for GNU, Android, and OSX.
For consistency, make getc_unlocked unavailable by default. Maybe this
was the intent of D45736 anyway.
Reviewed By: MaskRay, efriedma
Differential Revision: https://reviews.llvm.org/D107527
Jessica Paquette [Thu, 5 Aug 2021 18:25:41 +0000 (11:25 -0700)]
[AArch64][GlobalISel] Widen extloads before clamping during legalization
Allows us to avoid awkward type breakdowns on types like s88, like the other
commits.
Differential Revision: https://reviews.llvm.org/D107587
Stanislav Mekhanoshin [Thu, 5 Aug 2021 21:25:18 +0000 (14:25 -0700)]
[AMDGPU] Improve v2i32/v2f32 insertelt patterns
Using REG_SEQUENCE produces better code than INSERT_SUBREG,
we can omit one move instruction in many cases.
Fixes: SWDEV-298028
Differential Revision: https://reviews.llvm.org/D107602