Hermet Park [Fri, 17 Apr 2020 09:14:48 +0000 (18:14 +0900)]
canvas svg: fix memory leak.
free svg node commands & points data after usage.
@fix
Ali [Thu, 16 Apr 2020 15:51:31 +0000 (15:51 +0000)]
evas_textblock: prevent segfault if there are no style
```
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *textblock;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("", "");
elm_win_autodel_set(win, EINA_TRUE);
textblock = evas_object_textblock_add(win);
evas_object_resize(textblock, 360, 360);
evas_object_show(textblock);
evas_object_textblock_text_markup_set(textblock, "<b>b</b>");
evas_object_resize(win, 360, 360);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
this application will crash.
Any font format specified in text, if there are now style will cause the crash.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11686
Mike Blumenkrantz [Thu, 16 Apr 2020 14:44:03 +0000 (10:44 -0400)]
eina/value: use correct time types when comparing time types
these functions all expect struct timeval, as the name implies
../src/lib/eina/eina_value.c: In function ‘_eina_value_type_tm_compare’:
../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds]
3358 | struct timeval ret = *input;
| ^~~
../src/lib/eina/eina_value.c:3569:11: note: while referencing ‘ta’
3569 | time_t ta, tb;
| ^~
../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds]
3358 | struct timeval ret = *input;
| ^~~
../src/lib/eina/eina_value.c:3569:15: note: while referencing ‘tb’
3569 | time_t ta, tb;
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11715
Marcel Hollerbach [Fri, 17 Apr 2020 08:49:30 +0000 (10:49 +0200)]
eina_content: free eina content in the test:
Fix the unbelievable High prioritized CID 1420314
Mike Blumenkrantz [Thu, 16 Apr 2020 16:10:52 +0000 (12:10 -0400)]
elm/win: declare prototype for ecore_evas_dnd_mark_motion_used
../src/lib/elementary/efl_ui_win.c: In function ‘_motion_cb’:
../src/lib/elementary/efl_ui_win.c:9271:14: warning: implicit declaration of function ‘ecore_evas_dnd_mark_motion_used’ [-Wimplicit-function-declaration]
9271 | ecore_evas_dnd_mark_motion_used(ee, seat);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Differential Revision: https://phab.enlightenment.org/D11717
Stefan Schmidt [Thu, 16 Apr 2020 14:25:29 +0000 (16:25 +0200)]
exactness: limit length for font_path to stay in buffer
We get fonts_dir from a getenv() without and length check. Make sure
that we stay in the given buffer size when stitching the file path
together.
CID: 1422195
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11718
Stefan Schmidt [Thu, 16 Apr 2020 13:35:36 +0000 (15:35 +0200)]
exactness: fix typo in function name
Simple spelling mistake. overlay instead of overloay.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11714
Stefan Schmidt [Thu, 16 Apr 2020 13:32:58 +0000 (15:32 +0200)]
exactness: remove no longer used code since move to preload
This has been around for prg handling before we switched to preload. No
need for it anymore. Found when looking for a Coverity issue, which also
got fixed now by luck. :-)
CID: 1421994
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11713
Ali [Fri, 17 Apr 2020 05:26:14 +0000 (14:26 +0900)]
evas_textblock: remove special treat for variation sequence text run
Summary:
Now there are no need for special care for variation sequence text run break.
General method will care about all types of characters\
this is also related to D11096
Reviewers: woohyun, bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11602
Ali Alzyod [Fri, 17 Apr 2020 03:28:41 +0000 (12:28 +0900)]
evas_textblock: pick textrun fonts
Summary:
Picking font on textrun, will now give priority into font picked by the user, regardless of script type.
picking font due script can cause many inconvenient results
Example of wrong results: (User font is **NotoColorEmoji**)
{
F3847118} -> add 'a' at the end (notice how text render is wrong) {
F3847119} -> add tab before 'a' (text rendering now is right) {
F3847120}
After Change results: (User font is **NotoColorEmoji**)
{
F3847118} -> add 'a' at the end -> {
F3847122}-> add tab before 'a' -> {
F3847123}
Also now the following lines will be shown exactly the same, regardless of characters order
```
"가123A321"
"A321가123"
"123가A321"
"A가123321"
```
Test Plan:
```
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *en;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("", "");
elm_win_autodel_set(win, EINA_TRUE);
en = elm_entry_add(win);
elm_entry_scrollable_set(en, EINA_TRUE);
evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'");
elm_object_text_set(en, "☪123456a");
evas_object_show(en);
elm_object_content_set(win, en);
evas_object_resize(win, 400, 200);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: woohyun, bowonryu, tasn, raster, cedric
Reviewed By: tasn
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8556
Differential Revision: https://phab.enlightenment.org/D11302
Ali [Thu, 16 Apr 2020 16:03:23 +0000 (12:03 -0400)]
evas_test: change START_TEST to EFL_START_TEST
Summary: evas_test: change START_TEST to EFL_START_TEST
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11716
Marcel Hollerbach [Thu, 16 Apr 2020 09:32:35 +0000 (09:32 +0000)]
ecore_evas: fix fallback code
this was using a stringshare reference that was deleted. While that is
true, the stringshare reference will always be alive, because 2 people
took a reference. Anyways, this code is now searching the other way
arround, which makes the code also easier.
fixes: CID1420331
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11712
Mike Blumenkrantz [Wed, 8 Apr 2020 17:21:27 +0000 (13:21 -0400)]
tests/elm: explicitly destroy hoversel while active
verify that there's no errors when this happens
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11704
Mike Blumenkrantz [Fri, 3 Apr 2020 15:50:19 +0000 (11:50 -0400)]
tests/elm: add hoversel test to verify edge of canvas positioning
ensure that T8642 doesn't reoccur
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11647
Mike Blumenkrantz [Fri, 3 Apr 2020 15:38:11 +0000 (11:38 -0400)]
elm/hoversel: force calc on internal hover object during activate
hoversel can't accurately determine its location until the hover object
has been calculated, so this needs to always happen before the hoversel
is made visible in order to correctly position the hover
fix T8642
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11646
Mike Blumenkrantz [Thu, 2 Apr 2020 17:59:28 +0000 (13:59 -0400)]
tests/elm: add hoversel behavior tests
this verifies all smart callbacks for a hoversel to ensure they're triggered
as expected
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11644
Mike Blumenkrantz [Thu, 2 Apr 2020 17:58:26 +0000 (13:58 -0400)]
elm/hoversel: remove unnecessary internal callback deletion
this already happens automatically on every item destruction and passes
the item data through there to ensure the correct callback is removed
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11643
Mike Blumenkrantz [Thu, 2 Apr 2020 17:57:21 +0000 (13:57 -0400)]
elm/hoversel: use a wref to accurately track internal hover object
this pointer is never unset, which can cause errors when attempting to
access it after the hoversel has been deactivated
Differential Revision: https://phab.enlightenment.org/D11642
Mike Blumenkrantz [Mon, 13 Apr 2020 16:43:21 +0000 (12:43 -0400)]
tests/elm: add callback tests for elm_list
basic tests to verify behavior for triggering callbacks when selecting items
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11703
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:33:37 +0000 (13:33 +0100)]
efreet - disable strict as this makes things less functional...
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:19:36 +0000 (13:19 +0100)]
efreet - also look in lib in /usr/local/share/pixmaps too
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:03:45 +0000 (13:03 +0100)]
efreet - look in /usr/local/share/pixmaps too
Ali [Thu, 16 Apr 2020 11:03:31 +0000 (20:03 +0900)]
evas_textblock : fix text insertion & selection with ps in single line
Summary:
when we have text that contains <ps> (example "p1<ps>p2") in a single line mode
and the cursor position is after the ps tag
then we try to insert any character using the keyboard it will show segmentation fault.
also with the same text if we try to select the text we will notice that it is corrupted.
this should resolve https://phab.enlightenment.org/T8594
Test Plan:
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Eina.h>
#include <Elementary.h>
#include <Efl_Ui.h>
static void
_gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
{
efl_exit(0);
}
static void
_gui_setup()
{
Eo *win, *box;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
efl_text_set(efl_added, "Hello World"),
efl_ui_win_autodel_set(efl_added, EINA_TRUE));
// when the user clicks "close" on a window there is a request to delete
efl_event_callback_add(win, EFL_UI_WIN_EVENT_DELETE_REQUEST, _gui_quit_cb, NULL);
box = efl_add(EFL_UI_BOX_CLASS, win,
efl_content_set(win, efl_added),
efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(360, 240)));
Eo *text = efl_add(EFL_UI_TEXTBOX_CLASS, box,
efl_gfx_hint_weight_set(efl_added, 1.0, 1.0),
efl_gfx_hint_align_set(efl_added, 1.0, 1.0),
efl_pack(box, efl_added));
efl_text_interactive_selection_allowed_set(text, EINA_TRUE);
efl_text_multiline_set(text,EINA_FALSE);
efl_text_markup_set(text, "p1<ps>p2");
}
EAPI_MAIN void
efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
_gui_setup();
}
EFL_MAIN()
Reviewers: ali.alzyod, woohyun, zmike, bu5hm4n, segfaultxavi, stefan_schmidt
Reviewed By: ali.alzyod, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11621
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 08:58:02 +0000 (09:58 +0100)]
toolbar - dont create icon objects then del if icon is null
if icon is null just never create an icon obj.. but if it's not null
it's intended so even if blank, don't delete it - so things line up.
Stefan Schmidt [Thu, 16 Apr 2020 09:12:50 +0000 (11:12 +0200)]
Revert "evas: text_cursor: check return value and print error"
This reverts commit
c6df676a70b0e66f67d053982a46b030805b956b.
Thsi is failing the evas testsuite. My bad in not checking this locally
before commiting.
Ali [Wed, 15 Apr 2020 10:30:15 +0000 (10:30 +0000)]
evas_common_font: prevent leaking RGBA_Font
prevent leaking RGBA_Font in the for loop,
CID: 1382852
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11709
Ali [Wed, 15 Apr 2020 07:58:17 +0000 (07:58 +0000)]
evas: text_cursor: check return value and print error
Make sure we check the return of evas_textblock_cursor_geometry_bidi_get() and print an error if needed.
CID:1425191
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11707
Bo Anderson [Wed, 11 Mar 2020 00:34:28 +0000 (00:34 +0000)]
ecore_cocoa: fix compile error using 10.15 SDK
SangHyeon Jade Lee [Tue, 14 Apr 2020 08:09:34 +0000 (17:09 +0900)]
genlist : deffer on focus update to find proper focus item
Change-Id: I6315c42075eb1ec6b60714c93ca6de633ef070fd
JunsuChoi [Tue, 14 Apr 2020 02:38:27 +0000 (11:38 +0900)]
Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation.
Summary:
If Vg.Container has transparency, this is calculated by _evas_vg_render
in Efl.Canvas.Vg.Object. Therefore, there is no need to propagate
the transparency of the container to the child. _evas_vg_render pre-draws
all children and calculates transparency in batches for avoid duplicate calculation.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11692
Change-Id: I6e5ddcc7067c9c063918cd6ca545aa8679d66a5b
JunsuChoi [Mon, 13 Apr 2020 04:41:17 +0000 (13:41 +0900)]
Ector: Refer to visibility of Ector_Renderer when doing rle_update.
Summary:
An object with visibility false may not have a normal path or data.
It can cause invalid access or affect other ector renderers.
This is a patch to prevent them.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11689
Change-Id: I6b587be1a24cf3208d749564fc9e24ce25ae299a
hyunseok yang [Mon, 13 Apr 2020 08:31:52 +0000 (17:31 +0900)]
[Gengrid] Circular Gengrid
Change-Id: I8cc34390cfc1d496fd75806b12bb2289108d2189
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
SangHyeon Jade Lee [Mon, 13 Apr 2020 09:18:42 +0000 (18:18 +0900)]
genlist : apply show_center_align internal API to support wearable OneUi
Change-Id: I17fca8b5f139b5ddc12ea68d98909d9107bebce7
SangHyeon Jade Lee [Mon, 13 Apr 2020 06:41:01 +0000 (15:41 +0900)]
genlist: fix wrong return type
Change-Id: Ie559847ca82d5d999148458916c4d58e99efc914
HyukSoon Choi [Mon, 13 Apr 2020 06:14:47 +0000 (15:14 +0900)]
index: Change dot's color on bezel rotation
Change-Id: Ib97249bc205229f4333ea0f9b048fc94c4603f40
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
hyunseok yang [Fri, 10 Apr 2020 07:05:53 +0000 (16:05 +0900)]
[naviframe] Add signal for text sliding on genlist title item.
[Model] Tizen5.5
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Problem] Add signal for text sliding on genlist title item.
[Measure] N/A
[Checking Method] N/A
[Team] UIFW
[Developer] hyunseok yang
[Change Type] Commit Propagation
Change-Id: I94fcfb0573f64adfc9a5eb42216545b0f3c2e45a
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
HyukSoon Choi [Mon, 13 Apr 2020 01:54:12 +0000 (10:54 +0900)]
efl_ui_clock: remove unused API - field_value_apply
Change-Id: I5b63a4ebd515683e35a5d8717346d3618aac30bb
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
hyunseok yang [Fri, 10 Apr 2020 03:57:45 +0000 (12:57 +0900)]
Clear highlight here to increase performance instead of push finished
Change-Id: Ice8d23ad2887228d9aaa772e0ec96ed1618da313
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
HyukSoon Choi [Thu, 9 Apr 2020 09:59:31 +0000 (18:59 +0900)]
update po
- add new msgid : WDS_DB_TBBODY_DOUBLE_TAP_TO_VIEW_DETAILS
Change-Id: Ica93d2c803579c28682f717173940ebf6c687cba
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Seungwan woo [Wed, 8 Apr 2020 06:11:16 +0000 (15:11 +0900)]
edje_legacy: emit text changed signal
Change-Id: I4df5d41615a778059bb9bed3617d6fd78e94fd35
Signed-off-by: Seungwan woo <s-w.woo@samsung.com>
godlytalias14573465 [Thu, 9 Apr 2020 11:11:41 +0000 (16:41 +0530)]
Genlist: Avoid highlight animation on opening of genlist / item show
Change-Id: I5877a6c3e626440cdb452793338dec193b72adaf
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
HyukSoon Choi [Tue, 7 Apr 2020 09:55:12 +0000 (18:55 +0900)]
efl_ui_check - Handle any non-zero value
Change-Id: Iff6ccce26b9b826a1c46dd7fcc2b3515bcbf639f
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Seungwan woo [Wed, 8 Apr 2020 05:00:46 +0000 (14:00 +0900)]
edje_calc: adding null pointer exception to avoid crash
Change-Id: I917e5f392b4382775ed9939063a210f4553ca36d
Signed-off-by: Seungwan woo <s-w.woo@samsung.com>
HyukSoon Choi [Wed, 8 Apr 2020 01:20:47 +0000 (10:20 +0900)]
Change tizen_vector for progress according to OneUI1.5
Change-Id: I062f401a8d4ff5702ce26b9b03e4e8b39ce5b337
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
godlytalias14573465 [Thu, 9 Apr 2020 05:21:24 +0000 (10:51 +0530)]
Gesture Layer: Fix return type
Change-Id: Ibcc70983d189e0fff11afd20c976c907dc771120
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Taehyub Kim [Thu, 9 Apr 2020 05:25:19 +0000 (14:25 +0900)]
popup: add safe code for notify position
when calculating scroller size, notify position y value is used.
If parent position of notify is changed, the position of notify should be recalculated
for calculating correct scroller size.
Change-Id: I58a4f51ab39ab13844a0354cff761b8dc237ffc4
HyukSoon Choi [Fri, 3 Apr 2020 07:22:26 +0000 (16:22 +0900)]
datetime - Added a hook to get the current value of fields
Change-Id: I525ad767c5f3b11459bc8b3ec53556665b1e2701
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Jongmin Lee [Wed, 15 Apr 2020 23:09:20 +0000 (08:09 +0900)]
spec: resolve migration build error
8cb3113...meson: do not install namespace problem legacy files
This commit skip installing some of eo files, so that modify spec
file accordingly.
Change-Id: I6fffca56dcf7f4176ca50cb87b4ff7a4bbc66410
Mike Blumenkrantz [Wed, 15 Apr 2020 14:44:09 +0000 (10:44 -0400)]
tests/efl: use alloca for composite model test future to avoid leak
CID 1407236
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11711
Carsten Haitzler (Rasterman) [Wed, 15 Apr 2020 12:02:54 +0000 (13:02 +0100)]
elm menu - fix segv on deletion/shutdown where parent was not done ok
@fix
Stefan Schmidt [Wed, 15 Apr 2020 11:50:55 +0000 (13:50 +0200)]
release: Update NEWS and bump version for 1.24.0-beta2 release
Xavi Artigas [Wed, 15 Apr 2020 09:33:15 +0000 (11:33 +0200)]
doxygen docs: Fix invalid doxygen output
This particular line produces mismatched XML and HTML tags:
"force a <b>rendering update on <code>ee</b></code>"
Xavi Artigas [Tue, 14 Apr 2020 16:44:45 +0000 (18:44 +0200)]
doxygen docs: Define a couple missing ELM_WIN types
Xavi Artigas [Tue, 14 Apr 2020 16:24:43 +0000 (18:24 +0200)]
doxygen docs: Fix Elm_Toolbar groups
Xavi Artigas [Tue, 14 Apr 2020 16:13:12 +0000 (18:13 +0200)]
doxygen docs: Fix several invalid refs in Elm
Xavi Artigas [Tue, 14 Apr 2020 15:58:13 +0000 (17:58 +0200)]
doxygen docs: Fix missing docs in Edje
Xavi Artigas [Tue, 14 Apr 2020 14:53:25 +0000 (16:53 +0200)]
doxygen docs: Fix misplaced Evas_Font group tags
Putting things in the wrong group really messes up the organization.
Xavi Artigas [Tue, 14 Apr 2020 14:11:04 +0000 (16:11 +0200)]
doxygen docs: Proper usage of @ingroup and @addtogroup
This patch brings in a lot of docs which were missing before.
Unfortunately, this brings along their warnings so this ends up adding
more warnings than it fixes. Still, a step in the right direction.
@ingroup puts the current block into the specified group, but IT DOES NOT
allow opening groups with @{.
This was used in lots of places, resulting in misplaced or ignored documentation.
@ingroup should be used only in individual docs. For groups we use @defgroup and
@addtogroup.
Also,this patch adds some small missing docs.
Xavi Artigas [Tue, 14 Apr 2020 10:49:53 +0000 (12:49 +0200)]
doxygen docs: Fix double group
And missing group title in one of them.
Marcel Hollerbach [Tue, 14 Apr 2020 16:29:57 +0000 (12:29 -0400)]
efl_ui_focus_manager: correct check
Summary:
this check was checking for focus_manager to be window_root. This is not
correct, it should check for the root element.
ref D11667
Depends on D11705
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11706
Marcel Hollerbach [Tue, 14 Apr 2020 15:34:43 +0000 (17:34 +0200)]
ecore_evas_x: fix typo'ed function name
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11705
Marcel Hollerbach [Sat, 11 Apr 2020 17:09:21 +0000 (19:09 +0200)]
elm_dnd: complete the list of text types
the text types added here were present as "TEXT" in selection manager,
so add them here again.
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11684
Marcel Hollerbach [Tue, 14 Apr 2020 15:32:45 +0000 (11:32 -0400)]
build: fix libraries of efreet-mime -trash
Summary:
the dependencies were simply wrong.
Depends on D11684
Reviewers: zmike, stefan_schmidt, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11696
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:50 +0000 (11:29 -0400)]
ecore_evas_x: add safety check for data in converter
Summary:
since the existance of seleciton manager, the converter callbacks from
ecore_x are expecting custom struct pointers. However, enlightenment
never updated to use the elm dnd API for client side usages. Which
results in the fact that sometimes, when a client sents Notify, and
e_dnd is active, that this converter is executed with the wrong data.
With this commit the data passed in is ensured to have the correct magic
number. The proper solution for this would either be registering the
correct converters in enlightenment, or update to elm_drag. However,
since the continues cried river over the last 5 days has raised enough
hydro power to add these changes. This leaves us with just one question:
How was it possible to generate so many messages about a problem that
can be solved in a fraction of charaters that have been written?
fixes <a-issue-that-was-never-created>
Depends on D11700
Reviewers: zmike, stefan_schmidt, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11701
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:46 +0000 (11:29 -0400)]
ecore_evas_x: reject the promise instead of return
Summary:
this is needed in order to tell the API user that this is not going to
be completed.
Depends on D11699
Reviewers: zmike, raster, stefan_schmidt
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11700
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:43 +0000 (11:29 -0400)]
ecore_evas: add API for finding out if event is used
Summary:
ecore_x_dnd_send_status can be used to indicate if a item can be dropped
on a client or not. However, we should only indicate that this can be
dropped, if there is a object we signaled that a drop is in.
Long story short: there is no assertion that after indicating that
things can be dropped, that a notify for the data is sent. A drag
implementation should always listen to a mouse up event, and abort the
drag if no further operations are sent.
Depends on D11698
Reviewers: zmike, stefan_schmidt, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11699
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:39 +0000 (11:29 -0400)]
elm_dnd: support target setting on none evas_objects
Summary:
before this only worked for elm widgets. This however is the same
behaviour as in efl_ui_selection_manager.c. So this restores the
behaviour prior to selection_manager.
Depends on D11697
Reviewers: zmike, stefan_schmidt, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11698
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:32 +0000 (11:29 -0400)]
ecore_evas_x: allow parsing of links form the link list
Summary:
this is needed in order to return the data the same way the legacy impl
did. This however has the annoying sideeffect that ecore_evas_x now
depends on efreet, and we had to change the build order.
Depends on D11696
Reviewers: zmike, stefan_schmidt, raster
Reviewed By: zmike
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11697
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:28 +0000 (11:29 -0400)]
elm_slider: create timer for hiding later
Summary:
_popup_show deletes the hide timer, hence we need to create the timer
later on, or this will not automatically hide the indicator.
Reviewers: stefan_schmidt, zmike, Jaehyun_Cho
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11679
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:25 +0000 (11:29 -0400)]
efl_ui_focus_layer: correctly dismantle redirect chain
Summary:
when a redirect manager is unset, all focus managers in the chain upper
to the set manager must be unset. The code uses redirect manager == NULL
as an check for the manager to be active or not.
ref D11667
Depends on D11671
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11672
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:18 +0000 (11:29 -0400)]
efl_ui_focus_manager: do not magically set focus to new elements
Summary:
otherwise this focus manager might get activated again.
ref D11667
Depends on D11670
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11671
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:12 +0000 (11:29 -0400)]
efl_ui_focus_manager: do not fallback to the same object
Summary:
when redirect gets unset, we shound search for a fallback. However, we
should never fallback to the value we have unset.
ref D11667
Depends on D11669
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11670
Marcel Hollerbach [Tue, 14 Apr 2020 15:29:05 +0000 (11:29 -0400)]
efl_ui_focus_manager: refactor _request_subchild_except
Summary:
this is more usefull with a focusable and not a node, since the node can
be already freed in some cases.
ref D11667
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11669
Mike Blumenkrantz [Wed, 8 Apr 2020 13:47:53 +0000 (09:47 -0400)]
efl/wl: fix namespacing conflict in rotation enum
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11667
Marcel Hollerbach [Tue, 7 Apr 2020 11:19:10 +0000 (13:19 +0200)]
meson: do not install namespace problem legacy files
these files are not required for the unified API, but they have
namespace problems, so for now, do not install them
Differential Revision: https://phab.enlightenment.org/D11665
Marcel Hollerbach [Tue, 7 Apr 2020 11:53:18 +0000 (13:53 +0200)]
efl_input_text: rename namespace
Efl.Input_Text is a namespace which should not be a interface in the
same moment. So rename this to Efl.Input_Text.Entity
ref T8648
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11664
Xavi Artigas [Tue, 7 Apr 2020 11:11:13 +0000 (11:11 +0000)]
Fix namespace clashes for Efl.Text.Cursor
Three renames are applied here:
Efl.Text.Cursor -> Efl.Text_Cursor.Object (class)
Efl.Text.Cursor_Type -> Efl.Text_Cursor.Type (enum)
Efl.Text.Cursor_Move_Type -> Efl.Text_Cursor.Move_Type (enum)
Nothing changes for the enums on the C side. For the class... Well,
the method names are a bit more verbose now.
These renames are required to avoid clashing with the Efl.Text interface.
This did not cause trouble to C# because interfaces are prefixed with "I",
but it did cause trouble to Eolian when the EO files were installed and
somebody tried to use them.
Ref T8648
Differential Revision: https://phab.enlightenment.org/D11663
Marcel Hollerbach [Tue, 7 Apr 2020 10:05:15 +0000 (12:05 +0200)]
efl_text_formatter: rename from Efl.Text.Formatter to Efl.Text_Formatter
this is needed in order to not collide with the Efl.Text Interface.
Theoretically eolian should have ordered on that, however, the checks
are buggy and only work out of tree.
ref T8648
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11662
JunsuChoi [Tue, 14 Apr 2020 02:38:27 +0000 (11:38 +0900)]
Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation.
Summary:
If Vg.Container has transparency, this is calculated by _evas_vg_render
in Efl.Canvas.Vg.Object. Therefore, there is no need to propagate
the transparency of the container to the child. _evas_vg_render pre-draws
all children and calculates transparency in batches for avoid duplicate calculation.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11692
Change-Id: If1ffe9e6f4799cc42189b55bf515698e4ecbf84c
WooHyun Jung [Mon, 13 Apr 2020 23:49:42 +0000 (08:49 +0900)]
evas_main: add null check for safety
Change-Id: I6cc353ef2f88ec626c5564bd148801d6eb0a2ca2
WooHyun Jung [Mon, 13 Apr 2020 01:39:34 +0000 (10:39 +0900)]
edje_calc: add null check after eet_read
Yeongjong Lee [Mon, 13 Apr 2020 10:50:43 +0000 (19:50 +0900)]
eo: null check for vtable allocation
Reviewers: bu5hm4n, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11687
Change-Id: I305262499dc0af9d9de96ad2daf5335a3b8e1cf0
SangHyeon Jade Lee [Mon, 13 Apr 2020 06:41:01 +0000 (15:41 +0900)]
genlist: fix wrong return type
Change-Id: Ie559847ca82d5d999148458916c4d58e99efc914
(cherry picked from commit
0df97e7a1de61cb25c79abc15cb269d62b7575fe)
JunsuChoi [Mon, 13 Apr 2020 04:41:17 +0000 (13:41 +0900)]
Ector: Refer to visibility of Ector_Renderer when doing rle_update.
Summary:
An object with visibility false may not have a normal path or data.
It can cause invalid access or affect other ector renderers.
This is a patch to prevent them.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11689
Change-Id: Iac4a85be912076bd4eb6b36add07b988532112d6
Taehyub Kim [Mon, 13 Apr 2020 06:16:04 +0000 (15:16 +0900)]
elm_cnp: fix memory leaks
Summary:
In copy and paste logic, there are some memory leaks logic.
so fixed.
@fix
Reviewers: bu5hm4n, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11690
Change-Id: I60cd000315dfdc194e980d241c7d83d4be5eeb6b
Hermet Park [Mon, 13 Apr 2020 05:43:00 +0000 (14:43 +0900)]
evas text: fix memory leak.
Summary: free used memory properly.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11691
Change-Id: I92dd3c482970f81b0a88d78a3027e4ede4634ec6
Shinwoo Kim [Mon, 13 Apr 2020 02:17:19 +0000 (11:17 +0900)]
elm_atspi_bridge: fix memory leak
Summary:
Dynamic memory is allocated by calling function
'eldbus_message_iter_container_new' and lost by returning without free.
Reviewers: Hermet, woohyun, jsuya, herb
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11688
Change-Id: I738496e452f1b75ff491f8bd4bccb0f4213847fa
Bowon Ryu [Mon, 13 Apr 2020 03:34:06 +0000 (12:34 +0900)]
edje_entry: fix wrong parentheses
Change-Id: I1503383f5bb5fd574dcbc452db48d51e5c60eb1c
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Shinwoo Kim [Fri, 10 Apr 2020 12:45:22 +0000 (08:45 -0400)]
evas: fix dereference after null check
Summary:
Static analysis tool reports passing a null pointer 'im->gc' to
_evas_gl_image_cache_add which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to cache_add
Reviewers: Hermet, jsuya, herb, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11676
Change-Id: I19652a95320216c141a7b7acd64e1de5403107cc
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 18:20:13 +0000 (19:20 +0100)]
fix buid on bsd
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 17:30:36 +0000 (18:30 +0100)]
ecore con - clean up file lock andunlock on failed bind
didnt do this if bind failed... so do it now.
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 12:21:56 +0000 (13:21 +0100)]
ecore-evas - x dnd/cnp - handle null data content and not segv
Shinwoo Kim [Fri, 10 Apr 2020 12:45:22 +0000 (08:45 -0400)]
evas: fix dereference after null check
Summary:
Static analysis tool reports passing a null pointer 'im->gc' to
_evas_gl_image_cache_add which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to cache_add
Reviewers: Hermet, jsuya, herb, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11676
Carsten Haitzler (Rasterman) [Thu, 9 Apr 2020 23:15:30 +0000 (01:15 +0200)]
efreetd - ensure on bsd where connects succed despite daemon being gone
just get it to work... getting unamused with this.
Carsten Haitzler (Rasterman) [Thu, 9 Apr 2020 19:45:57 +0000 (20:45 +0100)]
efreet - try less chaotic efreetd restart and delay 0.5-1.0 rand sec
try work on T8490
Alastair Poole [Thu, 9 Apr 2020 10:44:27 +0000 (11:44 +0100)]
tests: popup
I missed this warning on this machine apologies for the
unnecessary noise.
Alastair Poole [Thu, 9 Apr 2020 10:41:05 +0000 (11:41 +0100)]
tests: Add case to match ephoto behaviour.
Taehyub Kim [Thu, 9 Apr 2020 05:25:19 +0000 (14:25 +0900)]
popup: add safe code for notify position
when calculating scroller size, notify position y value is used.
If parent position of notify is changed, the position of notify should be recalculated
for calculating correct scroller size.
Change-Id: I58a4f51ab39ab13844a0354cff761b8dc237ffc4
Bartlomiej Grzelewski [Wed, 8 Apr 2020 14:54:50 +0000 (16:54 +0200)]
flipselector: returns invalid widget
Widget returned by flip selector does not contains
x,y coordinates.
Change-Id: Id9df8a683909403d3a8d7e02afb90f4ce8971038
Yeongjong Lee [Wed, 8 Apr 2020 10:53:17 +0000 (10:53 +0000)]
elm_dnd: null check for safety
Also, it needs to keep backward compatibility.
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11666