platform/upstream/gstreamer.git
4 years agowasapi2: Activate device asynchronously if required
Seungha Yang [Fri, 24 Jul 2020 15:17:29 +0000 (00:17 +0900)]
wasapi2: Activate device asynchronously if required

In case of UWP, documentation from MS is saying that
ActivateAudioInterfaceAsync() method should be called from UI thread.
And the resulting callback might not happen until user interaction
has been made.
So we cannot wait the activation result on constructed() method.
and therefore we should return gst_wasapi2_client_new()
immediately without waiting the result if wasapi2 elements are
running on UWP application.
In addition to async operation fix, this commit includes COM object
reference counting issue around ActivateAudioInterfaceAsync() call.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1466>

4 years agowasapi2: Add a new property for ICoreDispatcher setting
Seungha Yang [Fri, 24 Jul 2020 12:53:37 +0000 (21:53 +0900)]
wasapi2: Add a new property for ICoreDispatcher setting

... so that ensure device activation on UI thread.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1466>

4 years agomfvideosrc: Only device activation needs to be running on UI thread
Seungha Yang [Fri, 24 Jul 2020 15:24:45 +0000 (00:24 +0900)]
mfvideosrc: Only device activation needs to be running on UI thread

... and the other operations does not have the thread constraint.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1466>

4 years agomfvideosrc: Add a new property for ICoreDispatcher setting
Seungha Yang [Fri, 24 Jul 2020 11:48:20 +0000 (20:48 +0900)]
mfvideosrc: Add a new property for ICoreDispatcher setting

Since the commit c29c71ae9d46cc70e29e0cca2313917f319ef6f2,
device activation method will be called from an internal thread.

A problem is that, CoreApplication::GetCurrentView()
method will return nullptr if it was called from non-UI thread,
and as a result, currently implemented method for accessing ICoreDispatcher
will not work in any case. There seems to be no robust way for
accessing ICoreDispatcher other then setting it by user.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1466>

4 years agomfvideosrc: Suppress more spammy debug messages
Seungha Yang [Sat, 25 Jul 2020 20:42:27 +0000 (05:42 +0900)]
mfvideosrc: Suppress more spammy debug messages

The failure on compressed format (e.g., MJPG, H264 subtypes) is expected.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1468>

4 years agodirectfb: suppress compiler warning from directfb headers
Tim-Philipp Müller [Sat, 25 Jul 2020 18:36:10 +0000 (19:36 +0100)]
directfb: suppress compiler warning from directfb headers

On debian sid, directfb 1.7.7

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1467>

4 years agod3d11window: Remove timeout and wait a task if possible
Seungha Yang [Thu, 23 Jul 2020 16:56:27 +0000 (01:56 +0900)]
d3d11window: Remove timeout and wait a task if possible

If the run_async() method is expected to be called from streaming
thread and not from application thread, use INFINITE as timeout value
so that d3d11window can wait UI dispatcher thread in any case.

There is no way to get a robust timeout value from library side.
So the fixed timeout value might not be optimal and therefore
we should avoid it as much as possible.

Rule whether a timeout value can be INFINITE or not is,
* If the waiting can be cancelled by GstBaseSink:unlock(), use INFINITE.
  GstD3D11Window:on_resize() is one case for example.
* Otherwise, use timeout value
  Some details are, GstBaseSink:start() and GstBaseSink:stop() will be called
  when NULL to READY or READY to NULL state change, so there will be no
  chance for GstBaseSink:unlock() and GstBaseSink:unlock_stop()
  to be called around them. So there is no other way then timeout way.
  GstD3D11Window:consturcted() and GstD3D11Window:unprepare() are the case.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1461>

4 years agod3d11window: Increase timeout to 10 sec for WinRT window implementations
Seungha Yang [Thu, 23 Jul 2020 16:43:16 +0000 (01:43 +0900)]
d3d11window: Increase timeout to 10 sec for WinRT window implementations

No strong reason for this number, but we can follow other well known
UWP implementation ANGLE.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1461>

4 years agocodecs: vp8decoder: Sync up with h264decoder implementation
Seungha Yang [Thu, 23 Jul 2020 08:45:03 +0000 (17:45 +0900)]
codecs: vp8decoder: Sync up with h264decoder implementation

Pass GstVideoCodecFrame with GstVp8Picture to new_picture() and
output_picture() methods for subclass to be able to reference
it directly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1458>

4 years agov4l2codecs: vp8dec: Remove white space
Seungha Yang [Thu, 23 Jul 2020 08:26:37 +0000 (17:26 +0900)]
v4l2codecs: vp8dec: Remove white space

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1458>

4 years agomeson: add a plugin summary
Stéphane Cerveau [Thu, 23 Jul 2020 15:00:52 +0000 (17:00 +0200)]
meson: add a plugin summary

This summary displays a list of plugins which
have been enabled.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1460>

4 years agoiqa: Add a 'mode' property
Thibault Saunier [Mon, 29 Jun 2020 21:31:15 +0000 (17:31 -0400)]
iqa: Add a 'mode' property

This property currently only supports a 'strict' that checks that
all the input streams have the exact same number of frames.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1424>

4 years agoiqa: Implement child proxy
Thibault Saunier [Mon, 29 Jun 2020 21:28:30 +0000 (17:28 -0400)]
iqa: Implement child proxy

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1424>

4 years agocodecs: vp9decoder: Sync up with h264decoder implementation
Seungha Yang [Tue, 21 Jul 2020 14:08:15 +0000 (23:08 +0900)]
codecs: vp9decoder: Sync up with h264decoder implementation

* Pass GstVideoCodecFrame to new_picture() and output_picture()
* Pass the last reference of GstVp9Picture to subclass if possible

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1455>

4 years agowasapi2: Fix broken debug log
Seungha Yang [Thu, 23 Jul 2020 14:01:03 +0000 (23:01 +0900)]
wasapi2: Fix broken debug log

I hope that MSVC is smart enought to warn this at build time

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1459>

4 years agov4l2codecs: h264dec: Remove outdated comment
Seungha Yang [Thu, 23 Jul 2020 09:03:23 +0000 (18:03 +0900)]
v4l2codecs: h264dec: Remove outdated comment

... and unnecessary user data clear on GstVideoCodecFrame

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1457>

4 years agov4l2codecs: h264dec: Fix leak on decoding failure
Seungha Yang [Thu, 23 Jul 2020 08:48:56 +0000 (17:48 +0900)]
v4l2codecs: h264dec: Fix leak on decoding failure

Given GstVideoCodecFrame and GstH264Picture should be cleared,
and the return must be GST_FLOW_ERROR, not boolean value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1457>

4 years agod3d11decoder: Disable array-of-texture
Seungha Yang [Tue, 21 Jul 2020 17:20:07 +0000 (02:20 +0900)]
d3d11decoder: Disable array-of-texture

Some 4K VP9 + super frame enabled streams would be broken with
array-of-texture configuration (i.e., allowing runtime texture registration
for DPB).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1456>

4 years agomfutils: Suppress spammy debug print
Seungha Yang [Wed, 22 Jul 2020 08:50:58 +0000 (17:50 +0900)]
mfutils: Suppress spammy debug print

Remove FIXME debug print. It seems to be spammy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1452>

4 years agomfvideosrc: Expose sorted caps
Seungha Yang [Tue, 21 Jul 2020 07:52:33 +0000 (16:52 +0900)]
mfvideosrc: Expose sorted caps

Sort the list of supported caps for downstream to be able to select
the best image in terms of quality (resolution and framerate) by default.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1452>

4 years agomfvideosrc: Don't expose unsupported formats
Seungha Yang [Tue, 21 Jul 2020 06:48:08 +0000 (15:48 +0900)]
mfvideosrc: Don't expose unsupported formats

Some UVC cameras support H.264 stream but we don't support it yet.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1452>

4 years agodocs: update plugins doc cache
Víctor Manuel Jáquez Leal [Tue, 14 Jul 2020 11:18:25 +0000 (13:18 +0200)]
docs: update plugins doc cache

Add va plugin

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1387>

4 years agova: documentation since tag
Víctor Manuel Jáquez Leal [Mon, 20 Jul 2020 14:37:35 +0000 (16:37 +0200)]
va: documentation since tag

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1387>

4 years agovah264dec: add documentation caps for pad templates
Víctor Manuel Jáquez Leal [Tue, 14 Jul 2020 11:17:35 +0000 (13:17 +0200)]
vah264dec: add documentation caps for pad templates

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1387>

4 years agod3d11window: Disable d3d11 video processor for HDR10 stream.
Seungha Yang [Tue, 21 Jul 2020 14:44:03 +0000 (23:44 +0900)]
d3d11window: Disable d3d11 video processor for HDR10 stream.

d3d11 video processor is showing buggy behaviors in various cases.
And this HDR10 is one case of them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1454>

4 years agocodecs: h264decoder: Fix wrong annotations
Seungha Yang [Tue, 21 Jul 2020 13:36:14 +0000 (22:36 +0900)]
codecs: h264decoder: Fix wrong annotations

What intended was GstH264Decoder actually.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1453>

4 years agocodecs: h264decoder: Update document with Since marks
Seungha Yang [Tue, 21 Jul 2020 09:17:09 +0000 (18:17 +0900)]
codecs: h264decoder: Update document with Since marks

To make documentation CI happy with the newly added APIs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agocodecs: h264decoder: Rename API arguments
Seungha Yang [Tue, 21 Jul 2020 08:53:29 +0000 (17:53 +0900)]
codecs: h264decoder: Rename API arguments

Although it's not public ones, make them consistent with vfunc
for them to be nicer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agov4l2codecs: h264dec: Use the new picture lookup
Nicolas Dufresne [Mon, 20 Jul 2020 20:55:10 +0000 (16:55 -0400)]
v4l2codecs: h264dec: Use the new picture lookup

This will avoid having to create a reference chain from CodecFrame
to GstH264Picture to GstV4l2Request.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agoh264decoder: Add ability to lookup by system_frame_number
Nicolas Dufresne [Mon, 20 Jul 2020 20:48:32 +0000 (16:48 -0400)]
h264decoder: Add ability to lookup by system_frame_number

This is to avoid having to create a reference chain in decoders from
GstVideoCodecFrame to GstH264PIcture to implementation wrapper.

So this change introduces:

 - gst_h264_dpb_remove_outputed (dpb)
 - gst_h264_dpb_get_picture(dpb, system_frame_num)
 - gst_h264_decoder_get_picture (dec, system_frame_num)

In order to ensure that frames can be looked up during the draining
process, we now first remove all (including reference) frames that
have been outputed but are still in the DPB. Then for each remaining
buffers, we remove it from the DPB to reach reference 1 and output it.

Previously we could take all not outputed outside of the DPB which would
prevent lookup by the base class.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agocodecs: h264decoder: Make GstVideoCodecFrame hold the last reference of the buffer
Seungha Yang [Mon, 20 Jul 2020 10:13:29 +0000 (19:13 +0900)]
codecs: h264decoder: Make GstVideoCodecFrame hold the last reference of the buffer

... when gst_video_decoder_finish_frame() is called.

Some subclasses attach GstBuffer to GstH264Picture as an user data
which will increase reference count of the buffer. It would result
to buffer copy per every frame.

Background here is, GstVideoDecoder wants writable output buffer for
GstMeta handling, and if the output buffer is not writable
(i.e., reference count is not one), the buffer will be copied.
Even if underlying GstMemory wouldn't be copied, buffer copy operation
will introduce extra memory allocation overhead which is not optimal.

By this modification, subclass might be able to receive the last
reference to GstH264Picture

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agocodecs: h264decoder: Pass GstVideoCodecFrame to output_picture()
Seungha Yang [Mon, 20 Jul 2020 09:24:09 +0000 (18:24 +0900)]
codecs: h264decoder: Pass GstVideoCodecFrame to output_picture()

All subclasses are retrieving list to get target output frame, which
can be done by baseclass. And pass the ownership of the GstH264Picture
to subclass so that subclass can clear implementation dependent resources
before finishing the frame.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agocodecs: h264decoder: Don't attach extra ref of GstH264Picture to GstVideoCodecFrame
Seungha Yang [Mon, 20 Jul 2020 08:45:12 +0000 (17:45 +0900)]
codecs: h264decoder: Don't attach extra ref of GstH264Picture to GstVideoCodecFrame

The lifecycle of GstH264Picture is being managed by our DPB
implementation. If it's still required, subclass can do that
by itself in the new_picture() method.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1449>

4 years agomfvideosrc: Don't error out when if we've found supported format
Seungha Yang [Mon, 20 Jul 2020 16:05:47 +0000 (01:05 +0900)]
mfvideosrc: Don't error out when if we've found supported format

While retrieving supported formats by device, the last return might
not be S_OK in case that it's not supported one by us (e.g., H264, JPEG or so).
But if we've found at least one supported raw video format,
we can keep going on.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1451>

4 years agocodecs: h264decoder: Drop non-decodable frames
Seungha Yang [Mon, 20 Jul 2020 11:54:26 +0000 (20:54 +0900)]
codecs: h264decoder: Drop non-decodable frames

Otherwise GstVideoDecoder baseclass will hold the corresponding broken frames
until new reset event happens such as FLUSH or downwards state change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1450>

4 years agowebrtc: remove private properties/signals from the now public ice object
Matthew Waters [Fri, 17 Jul 2020 05:14:48 +0000 (15:14 +1000)]
webrtc: remove private properties/signals from the now public ice object

We don't want to expose all of the webrtcbin internals to the world.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1444>

4 years agoplugins: Use g_win32_error_message for HRESULT to string conversion
Seungha Yang [Thu, 16 Jul 2020 10:26:55 +0000 (19:26 +0900)]
plugins: Use g_win32_error_message for HRESULT to string conversion

We don't need to duplicate a method for HRESULT error code to string
conversion. This patch is intended to
* Remove duplicated code
* Ensure FormatMessageW (Unicode version) and avoid FormatMessageA
  (ANSI version), as the ANSI format is not portable at all.
  Note that if "UNICODE" is not defined, FormatMessageA will be aliased
  as FormatMessage by default.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1442>

4 years agowasapi2util: Fix wrong use of debug category
Seungha Yang [Fri, 17 Jul 2020 06:58:16 +0000 (15:58 +0900)]
wasapi2util: Fix wrong use of debug category

Haven't noticed so far since there is no debug statement in the source file.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1445>

4 years agoavtp: Update documentation
Ederson de Souza [Thu, 16 Jul 2020 20:32:56 +0000 (13:32 -0700)]
avtp: Update documentation

 - Mention that a new capability is required by "avtpsink" element;
 - Use "clockselect" element to change pipeline clock, instead of a
   gst-launch option that never saw the light of day.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1443>

4 years agowasapi: added missing lock release in case of error in gst_wasapi_xxx_reset
Silvio Lazzeretti [Wed, 15 Jul 2020 08:39:33 +0000 (10:39 +0200)]
wasapi: added missing lock release in case of error in gst_wasapi_xxx_reset

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1440>

4 years agowaylandsink: use GstMemory instead of GstBuffer for cache lookup
Damian Hobson-Garcia [Wed, 15 Jul 2020 04:30:48 +0000 (13:30 +0900)]
waylandsink: use GstMemory instead of GstBuffer for cache lookup

The GstMemory objects contained in a GstBuffer could be replaced
by an upstream element, which would break the association beteen
the GstBuffer and the wayland wl_buffer, make the cache lookup
results incorrect.
This patch changes the cache lookup to use the first GstMemory
in a buffer instead.  For multi-plane buffers, this assumes that
all of the GstMemory(s) will always be moved together as a set,
and that the same (first) GstMemory isn't used with different
combinations of other GstMemory(s).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1401>

4 years agowaylandsink: Keep per display wayland buffer caches
Damian Hobson-Garcia [Wed, 8 Jul 2020 10:06:38 +0000 (19:06 +0900)]
waylandsink: Keep per display wayland buffer caches

Instead of attaching a single wayland wl_buffer to each GStBuffer as qdata,
keep a separate cache for each display.
A unique wl_buffer and associated metadata is created for each display.
This allows for sharing of GstBuffer objects between multiple
displays, such as when using tee elements.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1401>

4 years agov4l2codecs: Enable 32x32 tiled NV12 support
Nicolas Dufresne [Wed, 15 Jul 2020 01:49:33 +0000 (21:49 -0400)]
v4l2codecs: Enable 32x32 tiled NV12 support

This is used by Cedrus driver to support Allwinner VPU, also known as the
sunxi platforms.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1437>

4 years agodocs: update for new pixel formats
Tim-Philipp Müller [Wed, 15 Jul 2020 11:43:20 +0000 (12:43 +0100)]
docs: update for new pixel formats

https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/753
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/754

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1441>

4 years agoopencv: suppress another warning about non-existent include dirs
Jordan Petridis [Fri, 10 Jul 2020 18:58:23 +0000 (21:58 +0300)]
opencv: suppress another warning about non-existent include dirs

Ammend to 92456967d0fbdb57f7bf089b06d930b7d30bc417 !1427

The .pc file of opencv4 seems to be broken

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1438>

4 years agomsdkh265enc: add the missing comma
Haihao Xiang [Wed, 15 Jul 2020 00:37:39 +0000 (08:37 +0800)]
msdkh265enc: add the missing comma

Otherwise main-444 and main-444-10 are concatenated

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1436>

4 years agodoc: Updated cache file for the new pixel format
Nicolas Dufresne [Tue, 14 Jul 2020 21:06:59 +0000 (17:06 -0400)]
doc: Updated cache file for the new pixel format

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agortpsrc: Add domain name support
Nicolas Dufresne [Sat, 11 Jul 2020 19:41:51 +0000 (15:41 -0400)]
rtpsrc: Add domain name support

This add domain name resolution (similar to udpsrc does) to the rtpsrc
element.

Fixes 1352

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agoristsrc: Add support for domain name
Nicolas Dufresne [Sat, 11 Jul 2020 19:40:40 +0000 (15:40 -0400)]
ristsrc: Add support for domain name

This add domain name resolution (similar to udpsrc does) to the ristsrc
element.

Fixes 1352

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agortpsrc: Always set rtcp socket address
Nicolas Dufresne [Sat, 11 Jul 2020 19:16:53 +0000 (15:16 -0400)]
rtpsrc: Always set rtcp socket address

Regardless if it's multicast or not, set the address property to match
the element address. This is the address of the interface to listen to,
which is expected to be ANY in most cases, but should be honnored even
for RTCP non-multicast case.

This also fixes an assertion if the address is not a parsable IPv4 or
IPv6 string.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agortpsink: Fix error handling on bad DNS
Nicolas Dufresne [Sat, 11 Jul 2020 19:21:33 +0000 (15:21 -0400)]
rtpsink: Fix error handling on bad DNS

This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agoristsink: Fix error handling on bad DNS
Nicolas Dufresne [Fri, 10 Jul 2020 22:03:20 +0000 (18:03 -0400)]
ristsink: Fix error handling on bad DNS

This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

4 years agomfvideosrc: Enable WinRT capture impl. for desktop target
Seungha Yang [Tue, 14 Jul 2020 10:59:09 +0000 (19:59 +0900)]
mfvideosrc: Enable WinRT capture impl. for desktop target

... if target OS version was specified as Windows 10.
When enabled, desktop application can select target capture
implementation between WinRT and Win32
via GST_USE_MF_WINRT_CAPTURE environment
(e,g., GST_USE_MF_WINRT_CAPTURE=1 for WinRT impl.).
Default is Win32 implementation in case of desktop target.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1434>

4 years agoh265parser: Fix possible invalid memory access
Seungha Yang [Thu, 25 Jun 2020 08:51:11 +0000 (17:51 +0900)]
h265parser: Fix possible invalid memory access

... and do more strict validation for num_tile_columns_minus1 and
num_tile_rows_minus1.

As per specification Table A.8, allowed maximum number of tile rows
and tile columns are 22 and 20, respectively. So we should adjust the size
of each array.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1372>

4 years agod3d11decoder: Disable zero-copy for Qualcomm devices
Seungha Yang [Sat, 11 Jul 2020 16:22:55 +0000 (01:22 +0900)]
d3d11decoder: Disable zero-copy for Qualcomm devices

Qualcomm driver looks buggy in zero-copy scenario. Even if we disable
zero-copy, device-to-device memory copy will be used with d3d11videosink
which should be fast enough.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1432>

4 years agomsdkh265enc: add support for screen content coding extension
Haihao Xiang [Mon, 29 Jun 2020 07:12:47 +0000 (15:12 +0800)]
msdkh265enc: add support for screen content coding extension

Because the valid input formats for screen content coding extension is
a subset of input formats for range extension, user must specify the
profile for screen content coding extension in the caps filter

Example:
gst-launch-1.0 videotestsrc ! video/x-raw,format=NV12 ! msdkh265enc
low-power=1 ! video/x-h265,profile=screen-extended-main ! fakesink

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1389>

4 years agomsdkh265enc: allow user to choose profile
Haihao Xiang [Tue, 23 Jun 2020 05:12:55 +0000 (13:12 +0800)]
msdkh265enc: allow user to choose profile

Example:
gst-launch-1.0 videotestsrc ! video/x-raw,format=NV12 ! msdkh265enc !
video/x-h265,profile=main-444 ! fakesink

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1389>

4 years agomsdkenc: support tune property in msdkh264enc and msdkh265enc
Haihao Xiang [Thu, 9 Jul 2020 06:46:58 +0000 (14:46 +0800)]
msdkenc: support tune property in msdkh264enc and msdkh265enc

Introduce a new property for encoding mode selection, the default value
for this new property allows the SDK to decide what to do. In addition,
low-power is marked as deprecated since this fix

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1426>

4 years agoRevert "msdkh265enc: let MSDK select the encoding mode by default"
Haihao Xiang [Thu, 9 Jul 2020 01:01:23 +0000 (09:01 +0800)]
Revert "msdkh265enc: let MSDK select the encoding mode by default"

This reverts commit 9e977832c1761e3ad002fdfe14a9c3881a60bd45.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1426>

4 years agoavtp: rename tstamp-mode to timestamp-mode
Tim-Philipp Müller [Wed, 1 Jul 2020 17:42:18 +0000 (18:42 +0100)]
avtp: rename tstamp-mode to timestamp-mode

I thnk w cn spre the xtra lttrs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1397>

4 years agobasetsmux: make use of gst_aggregator_finish_buffer_list
Mathieu Duponchelle [Fri, 10 Jul 2020 15:13:47 +0000 (17:13 +0200)]
basetsmux: make use of gst_aggregator_finish_buffer_list

Fixes #1276

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1429>

4 years agodocs: fix element names in section headers
Tim-Philipp Müller [Fri, 10 Jul 2020 14:26:27 +0000 (15:26 +0100)]
docs: fix element names in section headers

Hopefully that'll make hotdoc pick up the docs for these elements.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1428>

4 years agoopencv: suppress warnings about non-existent include dirs
Tim-Philipp Müller [Fri, 10 Jul 2020 13:56:50 +0000 (14:56 +0100)]
opencv: suppress warnings about non-existent include dirs

Looks like opencv4 ships with a broken .pc file.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1427>

4 years agodocs: fix up for errorignore convert-error signal removal
Tim-Philipp Müller [Wed, 8 Jul 2020 18:56:13 +0000 (19:56 +0100)]
docs: fix up for errorignore convert-error signal removal

The commit that added that was reverted. Need to remove this
from docs cache manually.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1422>

4 years agod3d11: Disable D3D11Debug and DXGIDebug layer for UWP build
Seungha Yang [Wed, 8 Jul 2020 15:13:03 +0000 (00:13 +0900)]
d3d11: Disable D3D11Debug and DXGIDebug layer for UWP build

WACK (Windows App Certification Kit) doesn't seem to be happy with
the DXGIGetDebugInterface1 symbol.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1421>

4 years agomeson: set release date from .doap file for releases
Tim-Philipp Müller [Wed, 8 Jul 2020 16:16:46 +0000 (17:16 +0100)]
meson: set release date from .doap file for releases

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1420>

4 years agocccombiner: Update segment according to video sink pad
Vivia Nikolaidou [Wed, 8 Jul 2020 15:24:06 +0000 (18:24 +0300)]
cccombiner: Update segment according to video sink pad

Otherwise the following pipeline would preroll after 1000 hours:
gst-launch-1.0 videotestsrc ! x264enc ! cccombiner ! fakesink silent=0 sync=1 -v

Fixes #1355

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1419>

4 years agompegtsmux: Don't assume English for ISO-639 language descriptor
Andreas Frisch [Tue, 30 Jun 2020 11:40:28 +0000 (13:40 +0200)]
mpegtsmux: Don't assume English for ISO-639 language descriptor

Previously, "en" (should have actually been "eng") was assumed
for the ISO-639 language descriptor if no language was explicitely given.
Neither ETSI EN 300 468 nor ATSC A/52 mandate for a language descriptor,
so we should simply not set it, if it's unknown.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1386>

4 years agompegtsmux: Fix handling of MPEG-2 AAC
Jan Schmidt [Wed, 17 Jun 2020 18:03:59 +0000 (04:03 +1000)]
mpegtsmux: Fix handling of MPEG-2 AAC

The audio/mpeg,mpegversion=2 caps in GStreamer refer to
MPEG-2 AAC (ISO 13818-7), not to the extended MP3 (ISO 13818-3),
which is audio/mpeg,mpegversion=1,mpegaudioversion=2/3

Fix the caps, and add handling for MPEG-2 AAC in both ADTS and raw
form, adding ADTS headers for the latter.

4 years agomeson: Fix up update-orc-dist target for the case where there are no orc targets
Tim-Philipp Müller [Wed, 8 Jul 2020 10:39:58 +0000 (11:39 +0100)]
meson: Fix up update-orc-dist target for the case where there are no orc targets

All those plugins might have been disabled, in which case meson
would complain about alias_target() needing at least two arguments.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1418>

4 years agopkgconfig: fix meson warning about waylandlib not being in the config data
Tim-Philipp Müller [Wed, 8 Jul 2020 09:54:49 +0000 (10:54 +0100)]
pkgconfig: fix meson warning about waylandlib not being in the config data

meson.build:58: WARNING: The variable(s) 'waylandlibdir' in the input file 'subprojects/gst-plugins-bad/pkgconfig/gstreamer-plugins-bad-uninstalled.pc.in' are not present in the given configuration data.

We don't provide a .pc file for this lib nor install its headers,
so no need for this path to be in the uninstalled .pc file really.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1417>

4 years agortmp, transcodebin: fix i18n header includes
Tim-Philipp Müller [Tue, 7 Jul 2020 18:55:00 +0000 (19:55 +0100)]
rtmp, transcodebin: fix i18n header includes

Fixes #1351

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1416>

4 years agorist: Use g_signal_connect_object()
Nicolas Dufresne [Tue, 7 Jul 2020 14:03:42 +0000 (10:03 -0400)]
rist: Use g_signal_connect_object()

rtpbin can still emit signals when it is being disposed, and while
rtpbin is inside ristsrc/ristsink it can still live longer.

So we either have disconnect all signals at some point, or let GObject
take care of that automatically.

Related to !1412

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1413>

4 years agoscenechange: use orc to compute score
Josep Torra [Tue, 4 Feb 2020 17:23:03 +0000 (09:23 -0800)]
scenechange: use orc to compute score

Add an orc implementation for SAD operation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1024>

4 years agortpsrc/sink: Use g_signal_connect_object()
Sebastian Dröge [Tue, 7 Jul 2020 11:43:50 +0000 (14:43 +0300)]
rtpsrc/sink: Use g_signal_connect_object()

rtpbin can still emit signals when it is being disposed, and while
rtpbin is inside rtpsrc/rtpsink it can still live longer.

So we either have disconnect all signals at some point, or let GObject
take care of that automatically.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1412>

4 years agotests: mpegtsmux: Test we don't crash releasing unused pad
Jan Alexander Steffens (heftig) [Tue, 7 Jul 2020 12:02:06 +0000 (14:02 +0200)]
tests: mpegtsmux: Test we don't crash releasing unused pad

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1411>

4 years agotests: mpegtsmux: Avoid use-after-unref
Jan Alexander Steffens (heftig) [Tue, 7 Jul 2020 12:01:31 +0000 (14:01 +0200)]
tests: mpegtsmux: Avoid use-after-unref

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1411>

4 years agompegtsmux: Avoid crash releasing pad with NULL prog
Jan Alexander Steffens (heftig) [Tue, 7 Jul 2020 11:33:53 +0000 (13:33 +0200)]
mpegtsmux: Avoid crash releasing pad with NULL prog

If we release a pad while the muxer is running which has never been used
for aggregation (thus it does not have an assigned program), `prog` is
NULL.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1411>

4 years agomsdkh265enc: let MSDK select the encoding mode by default
Haihao Xiang [Wed, 1 Jul 2020 02:18:24 +0000 (10:18 +0800)]
msdkh265enc: let MSDK select the encoding mode by default

MSDK may support lowpower and non-lowpower modes, some features are
available only under one of the two modes, which is hard to know for
user, so let MSDK select the mode by default.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1405>

4 years agobuild: remove obsolete 'bad-transcoder' pc file
Matthew Waters [Mon, 6 Jul 2020 05:05:07 +0000 (15:05 +1000)]
build: remove obsolete 'bad-transcoder' pc file

Replaced by 'transcoder' pc files.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1409>

4 years agomeson: add update-orc-dist target
Tim-Philipp Müller [Sat, 4 Jul 2020 11:10:23 +0000 (12:10 +0100)]
meson: add update-orc-dist target

Add target to update backup orc -dist.[ch] files.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1408>

4 years agovideoparseutils: Only add a single closed caption meta
Vivia Nikolaidou [Wed, 1 Jul 2020 17:27:14 +0000 (20:27 +0300)]
videoparseutils: Only add a single closed caption meta

Otherwise, having a stream go through a parser multiple times would
result in duplicate closed caption meta.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1396>

4 years agodecklinkvideosink: write the cdp timecode data correctly
Matthew Waters [Fri, 3 Jul 2020 03:02:33 +0000 (13:02 +1000)]
decklinkvideosink: write the cdp timecode data correctly

We were mixing up the tens part with the unit parts all over the place.

e.g. 12 seconds would be encoded as 0x21 instead of the correct 0x12

Aligns the code with the same change applied to ccconverter.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1400>

4 years agoccconverter: write the cdp timecode data correctly
Matthew Waters [Thu, 2 Jul 2020 14:47:09 +0000 (00:47 +1000)]
ccconverter: write the cdp timecode data correctly

We were mixing up the tens part with the unit parts all over the place.

e.g. 12 seconds would be encoded as 0x21 instead of the correct 0x12

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1400>

4 years agoccconverter: output warning log if parsing a cdp packet fails
Matthew Waters [Thu, 2 Jul 2020 02:47:27 +0000 (12:47 +1000)]
ccconverter: output warning log if parsing a cdp packet fails

Simplifies figuring out why there may be no output from ccconverter with
a cdp input.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1400>

4 years agoccconverter: fix cdp timecode parsing
Matthew Waters [Thu, 2 Jul 2020 02:45:44 +0000 (12:45 +1000)]
ccconverter: fix cdp timecode parsing

The first reserved bits are in the most significant bit.

i.e. 0xc0 vs 0x0c

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1400>

4 years agoavtp: Use g_strerror instead of strerror
Ederson de Souza [Thu, 2 Jul 2020 23:17:01 +0000 (16:17 -0700)]
avtp: Use g_strerror instead of strerror

It should avoid some implicit declaration errors (and be utf-8 friendly).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1404>

4 years agoBack to development
Tim-Philipp Müller [Fri, 3 Jul 2020 01:03:56 +0000 (02:03 +0100)]
Back to development

4 years agoRelease 1.17.2
Tim-Philipp Müller [Thu, 2 Jul 2020 23:31:17 +0000 (00:31 +0100)]
Release 1.17.2

4 years agowpe: Update plugin's doc cache
Philippe Normand [Thu, 2 Jul 2020 11:37:47 +0000 (12:37 +0100)]
wpe: Update plugin's doc cache

This was forgotten in !1392.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1402>

4 years agov4l2decoder: Track pending request
Nicolas Dufresne [Wed, 1 Jul 2020 16:28:05 +0000 (12:28 -0400)]
v4l2decoder: Track pending request

With the asynchronous slice decoding, we only queue up to 2 slices
per frames. That side effect is that now we are dequeuing bitstream
buffers in both decoding and presentation order. This would lead to
a bitstream buffer from a previous frame being dequeued instead of
the expected last slice buffer and lead to us trying to queue an
already queued bitstream buffer.

We now fix this by tracking pending requests. As request are executed
in decoding order, we marking a request done, we can effectively
dequeue bitstream buffer from all previous request, as they have been
executed already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2decoder: Improve debug tracing
Nicolas Dufresne [Wed, 1 Jul 2020 16:26:36 +0000 (12:26 -0400)]
v4l2decoder: Improve debug tracing

Add some missing traces and move per-slice operation to TRACE level to
reduce the noise level.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2decoder: Convert request pool to GstQueueArray
Nicolas Dufresne [Wed, 1 Jul 2020 16:23:49 +0000 (12:23 -0400)]
v4l2decoder: Convert request pool to GstQueueArray

The decoder is not being access from multiple threads, instead it is
always protected by the streaming lock. For this reason, a
GstAtomicQueue for the request pool is overkill and may even introduce
unneeded overhead. Use a GstQueueArray in replacement, the
GstQueueArray is a good fit since the number of item is predictable and
unlikely to vary at run-time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Wait on previous pending request in slice mode
Nicolas Dufresne [Mon, 29 Jun 2020 17:27:32 +0000 (13:27 -0400)]
v4l2slh264dec: Wait on previous pending request in slice mode

In slice mode, we'll do one request per slice. In order to recycle
bitstream buffer, and not run-out, wait for the last pending
request to complete and mark it done.

We only wait after having queued the current slice in order to reduce
that potential driver starvation and maintain performance (using dual
buffering).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Renew bitstream buffer after submitting slice
Nicolas Dufresne [Mon, 29 Jun 2020 17:25:39 +0000 (13:25 -0400)]
v4l2slh264dec: Renew bitstream buffer after submitting slice

Submitting a slice actually clears the bitstream buffer. Ensure we
have a newly allocated bitstream buffer for the next slice.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Factor out bitstream allocation
Nicolas Dufresne [Mon, 29 Jun 2020 17:23:12 +0000 (13:23 -0400)]
v4l2slh264dec: Factor out bitstream allocation

No functional changes.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Add a helper to ensure output buffer
Nicolas Dufresne [Mon, 29 Jun 2020 17:04:56 +0000 (13:04 -0400)]
v4l2slh264dec: Add a helper to ensure output buffer

In preparation of multi-slice decoding, we will decode multiple
slices into the same buffer. This will ensure we have a buffer to
decode to, queued into the driver.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Factor out request wait
Nicolas Dufresne [Mon, 29 Jun 2020 16:39:08 +0000 (12:39 -0400)]
v4l2slh264dec: Factor out request wait

This will be reused to wait for previous slices to be complete
when dealing with following slices (in slice decoding mode).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Remove double return in submit_bitstream()
Nicolas Dufresne [Mon, 29 Jun 2020 16:14:36 +0000 (12:14 -0400)]
v4l2slh264dec: Remove double return in submit_bitstream()

This is code cleanup, no functional changes.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Fix typo in debug trace
Nicolas Dufresne [Mon, 29 Jun 2020 16:06:34 +0000 (12:06 -0400)]
v4l2slh264dec: Fix typo in debug trace

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>