Youngsoo Choi [Tue, 3 Mar 2015 10:11:04 +0000 (19:11 +0900)]
[tizen v3.0] changes of smack rule as per instruction from tizen v3.0
On Tizen v3.0, most of smack rules are removed.
So, current smack rules need to be changed,
as per the smack instruction from Tizen v3.0.
This changes are confirmed by Tizen platform team.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11716
Reviewed by: Antonio Gomes, KC Park
Change-Id: Id01dbcfaf25dc9f145d832a51c946428c9ad270a
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 3 Feb 2015 05:29:40 +0000 (14:29 +0900)]
Added tizen v2.2.1 hawkp gbs repository
Until tizen v3.0 build is fully ready,
We need to support tizen v2.2.1 hawkp.
bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11069
Reviewed by: Antonio Gomes, KC Park
Reviewed by: Antonio Gomes, KC Park, SeungSeop Park, Sungsik Han, commitbot
Change-Id: Id2912f55182ab295462ebda44cbb848a4bcb9ae5
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Antonio Gomes [Tue, 12 May 2015 19:21:23 +0000 (15:21 -0400)]
[dev/m42][uBrowser] Wrong output on double tap.
RWHVEfl makes use of chromium's GestureRecognizer class
in order to provide gestures support. GestureRecognizer
itself is abstract and gets concrete by its child,
GestureRecognizerImpl, which holds and encapsulates
a GestureProviderAura instance. Problem is that GestureProviderAura
has 'double tap' support disabled by default.
Patch provides the following solution:
- Specialize GestureRecognizerImpl into a class called
GestureRecognizerImplEfl. The later overrides and makes
::GetGestureProviderForConsumer public, granting access to
its GestureProviderAura instance.
- Override GestureRecognizer::Create method, and instantiate
a GestureRecognizerImplEfl object (instead of GestureRecognizerImplEfl).
Once accessible, calling GestureProviderAura::SetDoubleTapSupportForPlatformEnabled
fixes the problem.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12717
Change-Id: I81d5a06b80a453acd5b58d68a38e55648822a8b3
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Youngsoo Choi [Mon, 11 May 2015 07:29:59 +0000 (16:29 +0900)]
[tizen v3.0] Use app_get_data_path (instead of app_get_data_directory)
Tizen v2.4 and v3.0 do not support the deprecated
API 'app_get_data_directory'.
The API 'app_get_data_path' is suggested to use instead.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12956
Change-Id: Id5784a19c6df8f4286cf66dd3ba14b35ac289f84
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Antonio Gomes [Tue, 12 May 2015 18:25:32 +0000 (14:25 -0400)]
[dev/m42][uBrowser] One point touch.
Up to now, single point gestures (including panning, fling,
clicking) were handled through a Mouse->to->Pointer
events conversion solution. It happens on the RWHVEfl level,
and benefits both EWK and content apps.
However, multi touch gestures (e.g. pinch zoom) were not functional.
Patch fixes that by start listening to EVAS_CALLBACK_MULTI_{DOWN,MOVE,UP}
events, and forward them to chromium's (Aura) the existing gesture
recognition machinery to get them handled.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12716
Change-Id: I1662c611af8ceba5ba20398adbad9b9bb5ada844
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Tue, 12 May 2015 18:22:42 +0000 (14:22 -0400)]
[Clean up]Remove unused UpdateWebTouchEventAfterDispatch helper
SSIA.
Change-Id: I7e83b1fbb073a78c116aec5510ea81cc6f321fa6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Tue, 5 May 2015 23:30:58 +0000 (16:30 -0700)]
Move text_encoding_map_efl outside of ewk public directory
In addition, we make TextEncodingMapEfl a singleton class.
And also, we optimize the search by using a hash set instead of a list.
Search time in now constant time.
Change-Id: I22d8830b2d04c6bd4d4d4ba56fadb42950479d59
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 6 May 2015 22:45:09 +0000 (15:45 -0700)]
fixup! Use system request url getter for AccessTokenStore
Remove unneeded code.
Change-Id: Ia6200bcb392c1a192ffb298b81c97bea15fa59d3
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 5 May 2015 21:19:11 +0000 (14:19 -0700)]
Remove tw_webview_delegate
Use WebViewDelegateEwk directly instead of
tizen_webview::WebViewDelegate
Additionally, this patch moves WebViewEvasEventHandler out of
tizen_webview namespace, where it doesn't belong.
So we can now get totally rid of tizen_webview
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: Idd9fdc5a007921422c27affe5fd61652442b3d18
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 6 May 2015 22:55:37 +0000 (15:55 -0700)]
Fixes various compiler warnings
Fixes an unused variable and a suggested parentheses warning.
Also, WrtUrlParseBase is a virtual class. So, it needs a virtual
destructor.
Change-Id: I363167fd6dc49ef68886a274442f80718a0071da
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Umesh Kumar Patel [Thu, 16 Apr 2015 10:11:01 +0000 (15:41 +0530)]
[M40 Merge][MM] GStreamer 1.2 Multimedia Support
Following are the m40 patches merged
MM Common:
GST 1.2 Up version
http://165.213.202.130/gerrit/#/c/75366/
Video corruption issue with AppSink
http://165.213.202.130/gerrit/#/c/75610/
ME:
Replace playbin with uridecodebin and fimcconvert
http://165.213.202.130/gerrit/#/c/75740/
Buffered data indication is incorrect for Media Element.
http://165.213.202.130/gerrit/#/c/75819/
HTML5 Video loadstart / progress event TCT fails
http://165.213.202.130/gerrit/#/c/76213/
Use S/W codec for Media Element
http://165.213.202.130/gerrit/#/c/76681/
MSE:
S/W codec support for MSE
http://165.213.202.130/gerrit/#/c/75777/
Fix video corruption when video resolution is changed
http://165.213.202.130/gerrit/#/c/75828/
Youtube playback is not working with PIXMAP
http://165.213.202.130/gerrit/#/c/76137/
Enabling MSE for desktop
http://165.213.202.130/gerrit/#/c/76860/
WebRTC:
Enable H/W accelerated H.264 support for WebRTC on Tizen
http://165.213.202.130/gerrit/#/c/73796/
Change OMX control-rate from VBR to CBR
http://165.213.202.130/gerrit/#/c/74361/
OMX codec integration on m0 target
http://165.213.202.130/gerrit/#/c/75671/
Appsink implementation with fimcconvert
http://165.213.202.130/gerrit/#/c/75791/
Memory leak fixes
http://165.213.202.130/gerrit/#/c/76561/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12536
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12777
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: Icc88734422b24f684a49a3f27bb324ba6370f8fc
Signed-off-by: Umesh Kumar Patel <umeshk.patel@samsung.com>
sonal.g1@samsung.com [Tue, 5 May 2015 07:50:01 +0000 (13:20 +0530)]
[M40-Merge][WebRTC] Fix audio crash fix by passing ecore Display open
There is some problem with ecore_x_display_get() in chromium-efl.
So replacing the call with XOpenDisplay() as M34 does to fix the
browser crash during webRTC audio enabled.
Original gerrit: http://165.213.202.130/gerrit/#/c/75331/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9217
Change-Id: I13fc3e56d56b0ffcf4d00c6c4295f56ee54b7909
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
Suneel Kota [Fri, 24 Apr 2015 10:06:11 +0000 (15:36 +0530)]
Revert "[Workaround] Disable EFL version of GPUInfoCollector" This commit reverts the workaround to disable EFL version of GPUInfoCollector
BUG: http://107.108.218.239/bugzilla/show_bug.cgi?id=12551
This reverts commit
119b241911714e6f1de6daf25c750c0c553fbb04.
Reviewed by: Antonio Gomes, DaeHyun Ko, Siba Samal
Change-Id: Ia3f6da5dababf377c02844aff033ced013cd09f2
Signed-off-by: Suneel Kota <suneel.kota@samsung.com>
Taeho Kim [Thu, 7 May 2015 05:02:01 +0000 (14:02 +0900)]
Modify DEPS.xwalk configuration
Fetch dev/m42_2311 branch instead of exp/dev/m42_2311 from s-chromium
Change-Id: I8333ed69ea0677bb427ada365c71dcd99ac5eb94
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Arnaud Renevier [Wed, 6 May 2015 19:49:58 +0000 (12:49 -0700)]
Implement vibration in ubrowser
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10491
Reviewed by: Antonio Gomes, Hyunhak Kim
Change-Id: I544499034703130f027edad6008ab9c0abc2ec55
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 6 May 2015 21:03:48 +0000 (14:03 -0700)]
Bringup ewk_view_history_get
ewk_view_history_get is guarded by EWK_BRINGUP.
But actually, it is implemented, and unittests work fine.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12675
Change-Id: I12727434e747da3a8f304a82ce21408d63510171
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 6 May 2015 00:24:11 +0000 (17:24 -0700)]
fixup! Remove tw_webview
restore correct EWK_VIEW_IMPL_GET_OR_RETURN
Change-Id: Ic4521134ca159e2d619b7dfa0499bf048773f00c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 4 May 2015 22:52:04 +0000 (15:52 -0700)]
Remove tw_webview
Use EWebView directly
We need to make EWebView destructor and constructor public so they can
be used from CreateWebViewAsEvasObject
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: I90dc26c0d6ffec593d9abf30df3ea87634278516
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Fri, 24 Apr 2015 05:43:57 +0000 (22:43 -0700)]
Remove tw_web_context
Use Ewk_Context directly
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: Ica1a38660a38fdc2ac778d25989a2a798553cb89
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Mon, 4 May 2015 22:24:32 +0000 (18:24 -0400)]
Crash @WebContentsDelegateEfl::DidFinishLoad
When a new window is being opened, it might happen that
about:blank is loaded first, and the actual target URL load
is triggered later.
When that happens, two calls to WebContentsDelegateEfl::DidFinishLoad
are made during the load.
When the first call is made (associated to about:blank) no entry
is added to the NavigationController control, and GetVisibleEntry
returns NULL.
Our implementation wrongly assumed that calling this method would
always return non-null values, and an DCHECK was added.
Patch fixes that assumption by replacing the DCHECK by a null-check.
Note the the signature of the associated NavigationController method
also clearly states that it can return a NULL value:
https://goo.gl/RBiSEu
"
NOTE: This can be nullptr if no entry has committed!
"
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12867
Change-Id: Ie2f2253c7ec14e15f0b67910023a59d96f71b6f6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Thu, 23 Apr 2015 21:52:33 +0000 (14:52 -0700)]
WebViewEvasEventHandler does not rely on tizen_webview::WebView anymore
WebViewEvasEventHandler will use EWebView directly
This patch also renames SelectionControllerEfl::HideHandle to
SelectionControllerEfl::HideHandles (because there are two handles)
Change-Id: I47e5729c6918ec3188b837c93af7be693a073f80
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 15 Apr 2015 22:19:34 +0000 (15:19 -0700)]
Remove tw_settings and tw_touch_point
We use Ewk_Touch_Point instead of tw::touch_point
tw::Settings was the webview settings member of Ewk_Settings. It's the
object sent from browser process to render process. So this patch
renames it to WebViewSettings, and puts in common/ folder.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: I62ff5383accb3065d67a3b22e2d3ac85ec7cce8c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Thu, 23 Apr 2015 17:30:28 +0000 (10:30 -0700)]
Forward events to ewk
To match previous behaviour, events (focus, key and mouse) are forwarded
to ewk. If they are handled by the application, they are not forwarded
to chromium anymore.
motion events will be handled in a later patch
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12031
Change-Id: I67d0bf3599e918353b04d8f753dc29b3fad13583
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Tworek [Thu, 30 Apr 2015 12:22:38 +0000 (14:22 +0200)]
uBrowser: Use slider elementary widget to change zoom level
This solution is much more user friendly compared to previous solution.
The user can now change page zoom level by simply dragging the slider
left, or right.
Change-Id: Iac769a47f001ae42d099bc1e670e3d3b7480583b
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 30 Apr 2015 11:42:22 +0000 (13:42 +0200)]
Handle ui::TEXT_INPUT_TYPE_NONE in im_context_efl.cc
Without this the NOTREACHED() assert in default case can fail in certain
test scenarios.
Change-Id: Icbf9cefc8c9dc30f6f645b399c35ee1df6c8e6dd
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 30 Apr 2015 11:39:42 +0000 (13:39 +0200)]
uBrowser: Don't rely on specific layout of EFL popups.
The popup handling code relied on the specific layout of elm popups to
find the root widget of the element. This is rather fragile and actually
stopped working on 2.4 images recently. Instead of finding popup
elementary widget manually simply store a pointer to the currently
opened popup in the WindowUI object. This should be much more reliable.
Change-Id: Iecfcdf1105d0f5cd61940b31bba7a7214798818d
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 29 Apr 2015 14:10:38 +0000 (16:10 +0200)]
uBrowser: Add menu option to toggle EWK auto fitting setting.
This was requested by SRPOL QA. Apparently some of the tests they plan
to perform on the uBrowser require this feature. The feature is also known
as overview mode.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12737
Reviewed by: Hyunhak Kim, arno renevier
Change-Id: I141fbff5395bc0324b3b342efaf257cceeca2763
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Grzegorz Spryszynski [Tue, 28 Apr 2015 08:16:22 +0000 (10:16 +0200)]
Page rotation look weird
[Problem] In landscape mode pages looks inproper
(rotation and scale are invalid).
[Solution] Old rotation mechanism require matrixes
describing texture transformations. Now it is enougth
to use one matrix regardles of rotation.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12721
Signed-off-by: Grzegorz Spryszynski <g.spryszynsk@samsung.com>
Change-Id: Ib8dd3472ed0b322d79308a9a96744354d566810a
Piotr Tworek [Wed, 29 Apr 2015 13:39:09 +0000 (15:39 +0200)]
uBrowser: Add support for EWK tracing feature.
This is one of the features that is currently available in mini_browser,
but is not exposed in uBrowser. This patch bridges the gap.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12849
Change-Id: I0bb293794cebaede96776839fc8093843851e097
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 29 Apr 2015 13:10:14 +0000 (15:10 +0200)]
uBrowser: Refactor extra actions menu to use Elementary ctxpopup
Unfortunately the previous elementary menu object did not work correctly
on 2.4 targets. It was shown, but with an transparent background making
it difficult to use. This patch changes uBrowser to use elementary
ctxpopup widget as the basis of extra actions menu. This widget is
rendered properly all currently supported platforms.
While at this the patch also changes the menu options a bit. On the
refactoring branch stuff like zoom in/out does work on desktop so the patch
exposes it there. Since window resizing is also much more reliable, menu options
for resizing windows are not longer needed.
Change-Id: Ibf09267a81854b5e49f17fa79ba827275459246f
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Wed, 29 Apr 2015 20:28:27 +0000 (16:28 -0400)]
fixup! Enable sound effect when tapping on a link
In order to closely match follow our adjustment logic, patch
performs a hit test "for tap" (instead of a point based one)
using the same "padding" as the original tap event.
That way, as long as touch adjustment picks up a link for clicking,
we will emit a click sound.
Change-Id: Ia481fdd5b7e02ff3f433480bd5e8c1de32dedc06
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Wed, 29 Apr 2015 18:25:06 +0000 (11:25 -0700)]
fixup! Refactor async window creation feature to avoid chromium modifications.
WebContentsEflDelegate needs a virtual destructor
Change-Id: I1f4594e61ce10c5bc9052f0acaf6a023188bbe7a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 28 Apr 2015 20:37:11 +0000 (13:37 -0700)]
Bringup mime type override
ShouldOverrideMimeType works correctly. We just need to remove thing
bringup guards
Change-Id: Ia6e66d369c0fab3cbb8a375aa69df61d853d7ffb
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 28 Apr 2015 20:14:33 +0000 (13:14 -0700)]
Bringup ewk_view_not_found_error_page_load
We Send EwkFrameMsg_LoadNotFoundErrorPage and handle it in ewk instead
of doing that in chromium
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12675
Change-Id: I0803df5c0f6353266bdbd7d308421583518765e9
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
uzair.jaleel [Tue, 28 Apr 2015 07:45:47 +0000 (13:15 +0530)]
[M40 Merge] Fixed that webview is crushed on resizing viewport.
webView is crushed when creating/removing IME and rotating device.
It is caused by diffrence between the size of egl surface rendered
and glViewport arguments. The arguments were set by evas geometry size,
but it was different from the size of rendered surface.
M40 patch: http://165.213.202.130/gerrit/#/c/75627/
Bug: http://168.219.209.56/jira/browse/TNEF-190
Reviewed by: DaeHyun Ko, Siba Samal
Change-Id: I9ef7d67f3d05ce1744489dbd14f83fa46772046c
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Antonio Gomes [Tue, 28 Apr 2015 16:23:44 +0000 (09:23 -0700)]
[dev/m42] Wrong confirm sign on keyboard
RenderWidgetHostViewEfl needs to filter in and handle
message 'ViewHostMsg_TextInputInFormStateChanged' in order
to handle the 'Done' x 'Go' label on Tizen. Basically, when
VKB is shown and focus is in a widget within a <form> tag,
"Go" label should be used.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12727
Change-Id: I5388be90f186e8c126f97c0f34ef30e319e32a9e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Mon, 27 Apr 2015 02:28:28 +0000 (19:28 -0700)]
[dev/m42][uBrowser]Select picker doesn't work
In RenderFrameImpl::OnSelectPopupMenuItems, 'external_popup_menu'
is reset when an item is selected.
This is not how the Tizen browser is supposed to behave: due to
compatibility reasons with webkit browser (kiran), chromium-efl
only close the popup when user actually dismisses it (by either
pressing "DONE" or back button). Thus, the custom behavior
is implemented on RenderFrameObserverEfl::OnSelectPopupMenuItems.
Patch fixes our select implement by making use of a
hack: in order to have access to RenderFrameImpl::external_popup_menu_
it "defines" private as public before including the associated
header. This works because RenderFrameObserver (the base class) is
declared as 'friend' to RenderFrameImpl. Thus we get access to its
private members.
Associated EWK_BRINGUP macros are also removed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12720
Change-Id: I3f2384d79da5ea7e5a2d3d696527aa19cc7d700d
Antonio Gomes [Thu, 23 Apr 2015 18:31:33 +0000 (14:31 -0400)]
Make popup implementation also available on desktop builds.
At this point, there is nothing OS_TIZEN specific
in our popup (<select>) implementation anymore.
Patch makes it also available on desktop for the good.
Change-Id: Iaca6fb6d40865b6fc5f489a1304d1c23f2275abd
sonal.g1@samsung.com [Wed, 22 Apr 2015 16:30:58 +0000 (22:00 +0530)]
[Tizen][WebRTC][m42] Enable Camera for Odroid using CAPI
Camera was not enabled for Tizen 3.0(TV) in gyp and Video CAPI files.
Made appropriate changes for enabling it.
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Ib83c5bbc5820e0b54373aa9680284b4d167ba56f
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
Piotr Tworek [Tue, 28 Apr 2015 09:24:37 +0000 (11:24 +0200)]
fixup! Refactor async window creation feature to avoid chromium modifications.
Since we decided to avoid adding new fields to WebContents::CreateParams
we need to invoke WebContetntsImplEfl constructor directly and give it a
pointer to platform specific data (EWebView wrapping the WebContents)
pointer as an argument. Without it the newly created WebContents won't
know it's EWK parent.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12774
Change-Id: I67cbea770ef452af071c0ea2ee4227a814753466
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Mon, 27 Apr 2015 18:43:36 +0000 (11:43 -0700)]
fixup! Introduce WebContentsViewEflDelegate interface.
WebContentsViewEflDelegate needs a virtual destructor
Change-Id: I215ad06d356e4bfe96a2bd4f6cddb142e8791720
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Tworek [Mon, 27 Apr 2015 11:59:44 +0000 (13:59 +0200)]
Adjust EWK notifications implementation to dev/m42 changes.
During the weekend dev/m42 branch gained some more notification related
patches which broke EWK. This patch aims to make them compatible once
again.
Change-Id: I586f73747cbbf796884270ca10a5cc243c801628
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
yh106.jung [Wed, 22 Apr 2015 10:31:41 +0000 (19:31 +0900)]
Upgrade EFL version for desktop to 1.13.1
_Evas_Event_Key_Down provides keycode as member variable since EFL 1.10.
So we need to upgrade EFL version for desktop in order to use it on both
tizen targets and desktop.
Change-Id: I94dc850ed0e034a313c4eeee391df3a7f65041e9
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Piotr Tworek [Fri, 24 Apr 2015 13:27:31 +0000 (15:27 +0200)]
Refactor async window creation feature to avoid chromium modifications.
The goal is to competely get rid of chromium src patch and contain the
feature entirely in tizen_src. To do this we need to create our own
custom WebContentsDelegate class only used by EFL implementation of
WebContentsImpl. Additionally we can no longer use WebContents::Create
call to instantiate the class. Instead, a direct call to
WebContentsImplEfl constructor followed by Init call has to be used.
This makes EWK usage of content API a bit non standard, but allows us to
get by without any modifications to the upstream code.
Change-Id: I2f1397842e7194afc331514986d12b13705af71c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 24 Apr 2015 11:20:00 +0000 (13:20 +0200)]
Introduce WebContentsViewEflDelegate interface.
The idea is to avoid the need to modify upstrem WebContentsViewDelegate
interface. WebContentsViewEflDelagate is supposed to hold only extra EFL
specific extensions we'd otherwise have to put in the non Efl
counterpart of the interface. The downside is WebCotnentsViewEfl
implementation has two delegates now and care has to be taken to call
function from the correct one. Still it's probably preferable to do it
this way instead of patching chromium.
Change-Id: I6cdb0c966b11be33bf71ab3f45f172259cf063ae
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Thu, 16 Apr 2015 20:32:25 +0000 (13:32 -0700)]
[Rebase][dev/m42] Vibration changes
Vibration is not signaled by ipc messages anymore. Instead, mojo is
used to call methods of a VibrationManager object living in the browser
process.
This patch implements this interface. It also provides a virtual
interface device::VibrationProviderClient
On ewk side, things are simplified: instead of having
Ewk_Vibration_Client and VibrationProviderClient. There is only one
class: VibrationProviderClientEwk, which implements
device::VibrationProviderClient
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10491
Change-Id: Ifef41e504cb0b9ea3dec8e7f9703a325c1fb3e7d
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Tworek [Thu, 23 Apr 2015 16:16:19 +0000 (18:16 +0200)]
Place usage of FrameHostMsg_LoadNotFoundErrorPage in EWK_BRINGUP ifdefs.
The feature requires additional patches in chromium that we don't want
to push to dev/m42_2311 until we're sure the same functionality can't be
implemented entirely in tizen_src.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12675
Change-Id: I46e145fa4ed67b0384c0bc0db9284f2fdf5d6748
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Thu, 23 Apr 2015 15:27:03 +0000 (17:27 +0200)]
Change async window creation code to simplify chromium patch.
The goal here is to minimize the change done to upstream chromium code.
The solution may have a hacky feeling to it (#define private protected),
but hopefully it should ease s-chromium maintenance burden.
Change-Id: I07d32643db4a9686027dfa6cfa93591e2c083aa1
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 22 Apr 2015 15:24:23 +0000 (17:24 +0200)]
Adjust the code to dev/m42 platform notification changes
dev/m42_2311 branch contains some additional patches changing
PlatformNotificationData structure. Since the goal is to make
experimental/dev/master build on top dev/m42_2311 adjust our code
accordingly.
Together with: I55a0b1d3d919a1ebfa83855e9056d6253fa70fdf
Change-Id: I208a2d85e016fc661da18a4d7f5e018635de61e5
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Antonio Gomes [Wed, 22 Apr 2015 15:57:40 +0000 (08:57 -0700)]
Override content::CreateInProcessGpuThread for EFL port.
Patch makes use of the same override technique used by
RenderThemeChromiumDefault to override the theme method.
Basically, we "redefined" the method we want to override
and include the original source file containing its definition
(.cc or .cpp). Additionally, we exclude the original
implementation file from the build (in GYP).
Then we can have our own implementation of this method
from our efl specific method.
Together with: Iac24e6d38174d7dc8f0d1bb1c37bc8dac05d83c5
Change-Id: Ib7c2aeedbf76de576a25ad95d5437919fec09d3c
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Tworek [Wed, 22 Apr 2015 14:50:53 +0000 (16:50 +0200)]
Alias EwkMsgStart to ShellMsgStart
Since no content_shell code is being used in libchromium-ewk we can
safely reuse Shell IPC message ID for EWK specific messages. The goal
here is to minimize the amount of changes to upstream code.
Change-Id: I646018f8c9050f32d1d2851eedeedc347b08be38
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Wed, 15 Apr 2015 21:32:43 +0000 (14:32 -0700)]
Handle notification silent option
Add ewk api ewk_notification_silent_get
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10487
Change-Id: Ia4ed78ab2ad82a6b976b2e391d2b9230afb4d440
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Tworek [Tue, 21 Apr 2015 09:50:20 +0000 (11:50 +0200)]
Reuse ui_events_helper.cc implementation in EFL port.
Normally the file is excluded from build when use_aura is set to 0.
Since we're interested in reusing it lets add it back.
Change-Id: Ib552f3bd2839deef07172ca0953164f6853032e6
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Tue, 14 Apr 2015 22:20:24 +0000 (15:20 -0700)]
Bring up notifications
Most of the api has been pushed to ContentBrowserClientEfl to an
interface PlatformNotificationService.
https://code.google.com/p/chromium/issues/detail?id=439950
We implement PlatformNotificationService with NotificationControllerEfl
Since embedder API for notifications change a lot on chromium side, we
guard notifications with a compile flag. That way, it will be easier to
disable notifications temporarily if needed next time we update
chromium.
NotificationControllerEfl::SetPermissions is removed because it wasn't
used.
http://107.108.218.239/bugzilla/show_bug.cgi?id=10487
Change-Id: If155b5d5b8c7fc99ebe0ef75a0b5388e849bd1dd
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Mon, 20 Apr 2015 17:55:56 +0000 (13:55 -0400)]
fixup! fixup! [Rebase][dev/m41_2272] API changes in GestureRecognizer
In
4bae880d, patch adapted our obsolete touch handling
implementation of "acked async" touch events by replacing
::ProcessTouchEventOnAsyncAck by a "sync" variant (which is
not what was intended): ::AckSyncTouchEvent.
That caused the processing events' queue to enter in a state
where it got stuck, and no further events could get processed.
On debug builds, an assert was hit @GestureProviderAura::OnSyncTouchEventAck.
Patch fixes it by making a call to the proper "async" replacement
of ::ProcessTouchEventOnAsyncAck, namely ::AckSyncTouchEvent.
Upstream reference:
https://chromium.googlesource.com/chromium/src/+/
8879cfca3b19c304004e34e6dec9629752cd3%5E!/#F6
PS: It is worth mentioning that, later on the first argument of
::AckAsyncTouchEvent was removed in
https://chromium.googlesource.com/chromium/src/+/
b1663498ac1d59fc3baa085c155f84a1726ca87d%5E!/#F9
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10493
Change-Id: I2f5a671c4ff2dd5184ce175f7bc4d54aef663f33
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Mon, 13 Apr 2015 22:32:06 +0000 (15:32 -0700)]
Fixes utc_blink_cb_form_submit.NonSubmit
Right now, utc_blink_cb_form_submit.NonSubmit ends with timeout. But the
expected value is Failure. This is erroneous.
Change-Id: I1544c73d6b1b1de168ed2d1cac98b3ace807213a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 13 Apr 2015 21:34:04 +0000 (14:34 -0700)]
Fix form,submit callback
EwkHostMsg_FormSubmit is Send on the RenderFrame. So it's not handled in
WebContentsDelegate anymore. It is handled in
WebViewBrowserMessageFilter now.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10490
Change-Id: Iafd138bbbb198f32481e68f312ec178e008846a8
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Fri, 17 Apr 2015 20:01:12 +0000 (13:01 -0700)]
Bringup devtools
DevToolsHttpHandler::Stop has been removed. Instead, cleanup is done in
destructor.
Change-Id: Ie059ad9735f95bea0cb848f3f11d91e19580c565
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 20 Apr 2015 16:20:12 +0000 (09:20 -0700)]
Remove unused forward class declarations
Many forward class declarations are actually not needed. This patch
cleans them up.
Change-Id: I880039161b8415d36568bda5d646b150dfce8227
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
yh106.jung [Thu, 16 Apr 2015 12:44:59 +0000 (21:44 +0900)]
Enable EWebView::ExitFullscreen()
ExitFullscreen() was moved from RVH to WCI on M42.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Change-Id: I94ce408e41b64c8eadcc5978c2b6b5c03e0078b4
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
hh4813.kim [Thu, 16 Apr 2015 10:29:36 +0000 (19:29 +0900)]
[EWK_REFACTOR] Remove SelectRange() in EWebView
To remove dependency with EWebView in SelectionControllerEfl,
modify to call WebContentsImpl::SelectRange() directly and remove
SelectRange() in EWebView.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Change-Id: Ie7bf812b25740319a5e1ee503d6709f3b719eb3b
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
hh4813.kim [Fri, 17 Apr 2015 10:27:55 +0000 (19:27 +0900)]
fixup! Remove tw_selection_controller and tw_context_menu_controller
Change-Id: I41d7a04f1f1d8ec4548f87dc2782cd6014b87a44
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Arnaud Renevier [Tue, 14 Apr 2015 18:57:24 +0000 (11:57 -0700)]
Remove tw_selection_controller and tw_context_menu_controller
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: I8d8f68391143070ba0798130f55456b601cce4b2
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
hh4813.kim [Thu, 16 Apr 2015 11:12:32 +0000 (20:12 +0900)]
[EWK_REFACTOR] Move IsIMEShow() and GetIMERect() from EWebView to RWHV
To remove dependency with EWebView in SelectionControllerEfl,
move IsIMEShow() and GetIMERect() from EWebView to RWHV so that they can
call directly without EWebView.
Also, remove im_context() in RWHV since there's no caller any more.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Change-Id: I22784d116f6e2176541c4bfd70484f7b65bb0673
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Antonio Gomes [Thu, 16 Apr 2015 15:00:07 +0000 (08:00 -0700)]
fixup! Update our fetch procedure to point to src/DEPS
Although repositories sync'ed via DEPS file are
being updated fine, our custom deps are not.
The reason is because we are rebasing them
against themselves, not against a remote branch.
Patch fixes it by adding 'origin/' to each custom
deps branch we sync.
As a drawback, it ties us to a remote named 'origin'
but it should not affect normal developers' workflow
negatively.
Change-Id: Ifeba7fc09155aa5f6eeb38d82bf9b504061b1802
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Tworek [Thu, 16 Apr 2015 14:01:26 +0000 (16:01 +0200)]
Remove some of the NOTIMPLEMENTED() logs we don't have any interest in.
1. We're not interested in implementing our own overscroll controller.
We already have support for overscroll effect implemented via
EdgeEffect object in RWHV_EFL.
2. The AcceleratedSurfaceInitialized function was added mostly for
android port. We have no use for it in EFL and it's not even pure
virtual so we don't have to provide an empty implementation.
This should make our app startup contain a little bit less spam.
Change-Id: I47321dd729eb98d12b1ab72b7cd98fcc90bb5176
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
yh106.jung [Thu, 16 Apr 2015 12:09:39 +0000 (21:09 +0900)]
Fix IME keyboard issue for url bar of mini browser
There are 2 issues:
1. When IME keyboard is hidden by the outside, focus of url bar is not
removed. So when user tries to tap on url bar, IME keyboard is not
shown.
For resolving it, we should remove focus of url bar when callback of
ECORE_IMF_INPUT_PANEL_STATE_HIDE is called without hide_imf_panel()
call.
2. Sometimes IME is closed before it is hidden. So We cannot move tool
box and remove focus of url bar.
Solution is that move tool box and remove focus when IME close callback
is called.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12566
Change-Id: I019ed98513f3308fe9d80b8696a5b3adaff059f5
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Piotr Tworek [Thu, 16 Apr 2015 08:57:37 +0000 (10:57 +0200)]
Remove conformant object fron WebContentsViewEfl.
Elementary conformat widget is supposed to account for space taken up by
virtual keyboard and indicator widgets. It's an important element, but
it should be instantiated only once for each elementary window. If it's
instantiated several times the app layout may add extra padding at
window edges more than once. Such extra unnecessary pading was the root
cause behind bug #12564.
Currently uBrowser, Reference borwser and mini_browser instantiate
conformant widgets on the application level. The only app that does not
do it is efl_webview_app. The app is not exactly a good example on how
EWK apps should be implemented. It seems the standard practise is to
inject conformant widget at the app level. Doing it in the engine may
not be obvious and can lead to a subtle bugs that are only visible for
some elm layouts.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12564
Change-Id: I768c350a7a246ea5e6d79864f4d7916c46096f05
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 15 Apr 2015 16:37:02 +0000 (18:37 +0200)]
Make sure disambiguation popup parent is a elementary widget.
Elementary widgets require to have other elm widgets as their parents.
When this requirement is not met elementary focus chain is broken.
Since disambiguation popup uses elementary widgets we need to make sure
the parent we give it is also an elm widget.
This patch fixes a couple of EFL runtime errors seen on Tizen 2.4 mobile
target during ubrowser/efl_webview_app startup.
Change-Id: I36a9b9920f5ca61aedc7ef1ca1420a04cbc2f6f8
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Wed, 15 Apr 2015 19:37:46 +0000 (12:37 -0700)]
Refactor _Ewk_Security_Origin
_Ewk_Security_Origin constructor only allows GURL
Also, if port is unspecified, GetPort returns 0 instead of -1. This
fixes utc_blink_ewk_notification_security_origin_get unit test.
Change-Id: I4c1633a4ff75d6962afef222514b33be86b20bd4
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 14 Apr 2015 18:03:19 +0000 (11:03 -0700)]
Remove tw_callbacks.h
We can also remove chromium_glue and api_static_check now.
Change-Id: Id9d23111224cfcba34ada147f701b4bf51afa603
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 13 Apr 2015 18:19:57 +0000 (11:19 -0700)]
Remove tw_hit_test
There were two distinct classes: Ewk_Hit_Test and _Ewk_Hit_Test.
Ewk_Hit_Test was a subclass of tizen_webview::Hit_Test _Ewk_Hit_Test
owned an Ewk_Hit_Test and accessed it's properties.
This patch simplifies everything: there is now only _Ewk_Hit_Test, and
Ewk_Hit_Test is an alias to it.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Change-Id: I885c5c8350f306b44c2d8ed19ab1c9a2ff43894a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
hh4813.kim [Thu, 16 Apr 2015 05:44:42 +0000 (14:44 +0900)]
[EWK_REFACTOR] Move IsLastAvailableTextEmpty() from EWebView to RWHV
To remove dependency with EWebView in ContextMenuControllerEfl and
SelectionControllerEfl, move IsLastAvailableTextEmpty() from EWebView
to RWHV so that they can call directly without EWebView
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Change-Id: Iccf6a6e1f7706d9092732dc9b77cd8916e93bb61
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Antonio Gomes [Wed, 15 Apr 2015 08:20:43 +0000 (17:20 +0900)]
Enable builtin gold linker for both Tizen 2.4 and 3.0 builds.
In early stages, there were a need to have home-built
64bit statically linked gold binary in order to link
chromium-efl.so.
Some stuff have changed since then:
- our binary became much smaller once when
merged chromium-efl and chromium-ewk libs
- our platform now supports gold.
Patch switches to builtin gold. As a result
binary became 1Mb smaller. Next step is to enabled
LTO (Link time optimization) and fuse-linker-plugin
and a further binary size reduction is expected.
Change-Id: Ib414be3e97892a6379d89919783cdb1159044524
Arnaud Renevier [Wed, 15 Apr 2015 22:59:39 +0000 (15:59 -0700)]
Fixes: cannot build mobile with --ccache
building mobile with --ccache results in the following error:
build/ccache_env.sh: No such file or directory
We need to fix the script path in chromium-efl.spec
Change-Id: Ia0c580082b3653c7e7e590ec0babc412a85a9f22
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 15 Apr 2015 22:57:03 +0000 (15:57 -0700)]
Fixes: cannot build mobile without --include-all
Since packaging folder is a link, it is not handled by git. Then, gbs
needs --include-all parameter. Otherwise, mobile build will fail with
error: No source package found at /path/to/directory/src
error: <gbs>some packages failed to be built
Change-Id: I8638d03d2ff6d80e037fcd121642708bf89fd67c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
hh4813.kim [Wed, 15 Apr 2015 08:29:51 +0000 (17:29 +0900)]
fixup! Merge efl-port POC code into tizen_src
It has included render_widget_host_impl.h twice, so remove one.
Change-Id: I5d9d1238f88b63d3994d12891d954c298a57c79a
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
hh4813.kim [Wed, 15 Apr 2015 07:48:57 +0000 (16:48 +0900)]
[EWK_REFACTOR bug] Remove EWebView::ScrollFocusedEditableNode()
IMContextEfl calls RWHV::ScrollFocusedEditableNode() directly, not via EWebView.
So, we don't need EWebView::ScrollFocusedEditableNode() any more.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Change-Id: I7c7a5b979d7ff12ef5a036bc36361248c209764a
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Antonio Gomes [Wed, 15 Apr 2015 03:08:56 +0000 (12:08 +0900)]
Fix 'nodebug' GBS option
On current TV and Mobile GBS builds, our CFLAGS and CXXFLAGS
are set with -g2 option (for debug symbols control) and our
current regex to cut the off are poor.
Patch robusty it by some, and make it possible to have
nodebug GBS builds again. On TV GBS builds, for instance,
libchromium-ewk.so went down from 1.4Gb to 50Mb.
Change-Id: Ic518c3d3db5051a2c78b1d7830f9d34b1f2c2f2b
Arnaud Renevier [Fri, 10 Apr 2015 22:25:51 +0000 (15:25 -0700)]
Enable sound effect when tapping on a link
Previously, we were handling tap event in browser process. So, we had to
send a hit test request to the render process, which replied with a hit
test result.
In order to avoid that, we perform that hit test in the render process,
in RenderViewObserver::DidHandleGestureEvent method. If we tap on a
link, we ask the browser process to play a link effect sound.
Change-Id: I74710c8eff2f60bca831b1545832348c332ee269
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Tue, 14 Apr 2015 10:18:35 +0000 (19:18 +0900)]
Update our fetch procedure to point to src/DEPS
Now that chromium switched over to Git, the old
SVN based .DEPS.git does not exist anymore.
This should also fix out fetch/pull procedure
through gclient sync.
Change-Id: Ib576ddd1ff1d46f56067203e6910c49dd69340b6
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Arnaud Renevier [Tue, 31 Mar 2015 18:53:35 +0000 (11:53 -0700)]
Settings are not applied if set before an url is loaded
When applying settings (for example by calling
ewk_settings_scripts_window_open_set) before an url has been set, the
settings are not applied. This is because RenderView has not been
created in the render process. And therefore, the ipc messages are not
catched.
This patch fixes the problem by using using a set of delayed messages in
EWebView. Those messages will be send once RenderView is created.
ewk_view_mode_set also has the same issue, and the patch fixes the
problem.
Some actions do not make sense if no url is loaded (for example setting
scroll position). For some other actions, I don't have an opinion at the
moment (for example setting scale).
Change-Id: I4940d25a998c3f1bd7d940285a851dbd645e27bf
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Mon, 13 Apr 2015 20:47:54 +0000 (13:47 -0700)]
[beta-merge] Unify build_mobile.sh and build_desktop.sh arguments
With this patch, build_mobile.sh (and build_tv.sh) now support
--skip-gyp, --skip-ninja and --debug arguments.
gbs --debug option is renamed to --gbs-debug. It shouldn't have much
impact since gbs --debug is rarely used by developers.
Beta review: http://165.213.202.130/gerrit/#/c/75908/
Change-Id: I4a960a402152e51b82ba5c97415113866722b533
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Tworek [Mon, 13 Apr 2015 09:06:13 +0000 (11:06 +0200)]
[Workaround] Disable EFL version of GPUInfoCollector
EFL version of GPUInfoCollector currently causes a crash when
running on Tizen targets. Use plain linux version until EFL
version is fixed.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12551
Change-Id: I7392fbe94abea6da157cf801ee17ea85300eed4b
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Arnaud Renevier [Fri, 10 Apr 2015 22:32:05 +0000 (15:32 -0700)]
simplify GetRequestContext and GetResourceContext
In BrowserContext, GetRequestContext is GetStoragePartition(this,
NULL)->GetURLRequestContext(). The rational is that this call should
call CreateRequestContext if needed, which would allow us to set
request_context_getter_ and return it. This patch makes it clear that
it's what's happening.
It also simplifies GetResourceContextEfl which was confusing.
Change-Id: I0b8109334a2ece8f053abc75fd9cb0b7eb0121d3
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Fri, 27 Mar 2015 22:11:21 +0000 (15:11 -0700)]
fixup! Use system request url getter for AccessTokenStore
For now, system request getter is only used when geolocation is needed.
So it makes sense to create the object only as needed, instead of
creating it at startup unconditionally.
Change-Id: I6b970617cc97332394b893a8b86037b4c62d2876
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Thu, 26 Mar 2015 23:56:19 +0000 (16:56 -0700)]
Refactor default context handling
It's better to put default context access as a static method of
Ewk_Context/tizen_webview::WebContext.
Indeed, without a method DefaultContextRelease, we have to call
ewk_context_delete(ewk_context_default_get()) in ewk_shutdown. But some
applications, like efl_webview_app when launched in incognito mode, do
no use the default context. In such case, we end up creating a context,
just for the sake of deleting it. To avoid that, it's better to have a
DefaultContextRelease method that will check for the existence of
default_context before deleting it.
In addition, default context was AddRefed for each call to
ewk_context_default_get. This made the context to be never released, and
resulted in a crash at ubrowser exit.
Change-Id: I57d8bbc750f5e14a305386b799d48c93def2a34c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 1 Apr 2015 21:53:54 +0000 (14:53 -0700)]
Factorize efl_webview_app.sh and ubrowser.sh
Create a file launch_exec.sh which contains all the logic which was
duplicated in efl_webview_app.sh and ubrowser.sh
In addition, the script now uses readlink instead of the weird
hack: $(cd $dir; pwd)
Also, the bashisms have been removed, and the scripts are now posix
compatible.
Change-Id: I9c63cfde0e163a9cd01a5f712c39b0c02de8ae14
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Taeho Kim [Sun, 12 Apr 2015 07:10:04 +0000 (16:10 +0900)]
Modify DEPS.xwalk configuration to use s-webrtc & s-libjingle
Change-Id: I75bfddd222a962be54fc2712e93ecc1eb630e021
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Antonio Gomes [Sun, 12 Apr 2015 08:02:03 +0000 (04:02 -0400)]
fixup! [Rebase][dev/m41_2272] API changes in GestureRecognizer
Patch replaces the old GestureRecognizer API named
::ProcessTouchEventOnAsyncAck by the new one, ::AckSyncTouchEvent.
It fixes the touch gesture handling.
Change-Id: I469997973f019ce32bd4105e5d8d76a44e63738e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Taeho Kim [Sun, 12 Apr 2015 05:04:45 +0000 (14:04 +0900)]
Switch xwalk repo from bgerrit to github
Let's switch back crosswalk-efl repo to github for staging
chromium-efl so we can have compitable version of crosswalk.
Change-Id: I70d3f9f42206e1a56358197a1916a9d8e58a3dcd
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Antonio Gomes [Sat, 11 Apr 2015 12:39:23 +0000 (05:39 -0700)]
Allow reference browser to build with the latest dev/m42 branch.
Patch declares EWK_CONTEXT_MENU_ITEM_TAG_OPEN_IMAGE_IN_CURRENT_WINDOW,
public enum value relied on by the reference browser.
Note that, the functionality associated with it is related to
context menu which is still disabled in the refactor branch
(and then also in the dev/ branch based on it), so the rest of
original patch [1] is not merged.
[1] http://165.213.202.130/gerrit/#/c/76946/
Change-Id: Iedd9d46e2baae06b737a2dc996e489677c24d938
Arnaud Renevier [Wed, 8 Apr 2015 19:39:19 +0000 (12:39 -0700)]
fixup! Use Hit_Test_Param to pass hit test infos between processes.
For some reason, I hadn't uploaded a finished patch.
Change-Id: I9d0b31fa1984d7448d87b2e25989fd59eb938b11
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Wed, 1 Apr 2015 17:42:10 +0000 (10:42 -0700)]
Allow building date picker on desktop
To build date picker, we need to include two files from chromium
content/ directory. Since we want to build it on all efl platforms, we
can include those files directly into chromium-efl.gyp. That removes the
need to modify one upstream gyp file.
Together with: I03e0cfc91fbf06d65f08b6a97735b4a378ed3315
Change-Id: I1bb5f86fb6a95a8efa45678f757d7c962010caa1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Tue, 31 Mar 2015 22:09:24 +0000 (15:09 -0700)]
Declare ewk_home_directory_get as extern "C"
Building unit tests fail with error: undefined reference to
'ewk_home_directory_get()'
We need to declare ewk_home_directory_get as extern "C"
Change-Id: If7f749b9319fdaac14094f154bbf66d0614eeeb8
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Thu, 9 Apr 2015 05:50:42 +0000 (22:50 -0700)]
fixup! Enable IMContextEfl
initialize im_context_
Right now, im_context_ can be left initialized. So, in the case of a
popup, delete im_context_ can cause a crash. This patch fixes the issue.
Change-Id: Ic6ba085106ac68de7009cde085e3e0cea3e95cc1
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Arnaud Renevier [Thu, 9 Apr 2015 00:16:20 +0000 (17:16 -0700)]
Use freedesktop repository instead of code.entropywave.com in jhbuild
orc is available on freedesktop. So we don't need to use
code.entropywave.com
Change-Id: Ic485cb13abb9d8370f9304ca47fd8d876d6644db
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Antonio Gomes [Fri, 10 Apr 2015 07:52:02 +0000 (16:52 +0900)]
[Rebase][dev/m41_2272] API changes in GestureRecognizer
Patch fixes the basic touch handling after the M41 rebase.
Basically, our code was adapted to the API changes made
in Chromium/Aura, in order to unify the touch handling
code.
Changes are based on two upstream chromium patches:
- https://chromium.googlesource.com/chromium/src/+/
62bb8d3ff2322ed11a11913c3414c3a2f4d4e60f%5E!/#F0
- https://chromium.googlesource.com/chromium/src/+/
8879cfca3b19c304004e34e6dec9629752cd3068%5E!/#F22
http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10493
Change-Id: I2fb40ba2f407d953b061c7f22d13832463ec1736
Taeho Kim [Fri, 10 Apr 2015 04:12:59 +0000 (13:12 +0900)]
Remove sync_repos.sh and update README.md
1. Now that we use gclient sync directly, sync_repos.sh is obsolete.
2. Instruction in README.md was out-dated.
Change-Id: I2535531dac57f287d764762ee961caa85f0cd01b
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Youngcheol Kang [Fri, 10 Apr 2015 04:44:24 +0000 (13:44 +0900)]
Remove trailing slashes ("/") in include lines.
Modern RPM versions still ship a bug that causes
the "path canonicalization" step to fail if there is
a "trailing" slash ("\") character in a include line.
e.g.:
\#include "path//to/my/header."
This is a long standing problem tracked by RedHat in
https://bugzilla.redhat.com/show_bug.cgi?id=304121
Error:
[XXs] /usr/lib/rpm/debugedit: canonicalization unexpectedly shrank by
one character
[XXs] error: Bad exit status from /var/tmp/rpm-tmp.dFqmJQ (%install)
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12528
Change-Id: I75685712fb3a56180df36a66272ce52dbc63ad54
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>