jamesr@google.com [Thu, 17 May 2012 18:41:27 +0000 (18:41 +0000)]
[chromium] Convert GraphicsLayerChromium to use WebLayer types
https://bugs.webkit.org/show_bug.cgi?id=86269
Reviewed by Adrienne Walker.
Source/Platform:
Adds some new WebLayer / WebContentLayer APIs that WebCore::GraphicsLayerChromium needs.
* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebKit::WebLayer::isNull):
(WebLayer):
* chromium/public/WebTransformationMatrix.h:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
Fix a memory leak - WebPrivateOwnPtr<>s have to be explicitly cleared.
(WebTransformationMatrix):
Source/WebCore:
This converts GraphicsLayerChromium over to use WebLayer and WebContentLayer. The conversion is not completely
as the Web*Layer APIs are not yet quite complete enough to use everywhere, and the PlatformLayer typedef is not
changed in this patch. The places where we have to punch out through API layer are marked by
unwrap<*LayerChromium>() calls and FIXME's in the Web*Layer.h files. There aren't many.
Refactor only, existing tests apply.
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit):
(WebKit::WebTransformationMatrix::reset):
(WebKit::WebTransformationMatrix::projectPoint):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::hostLayerForChildren):
(WebCore::GraphicsLayerChromium::layerForParent):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
(WebCore::GraphicsLayerChromium::primaryLayer):
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
Source/WebKit/chromium:
* WebKit.gyp:
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::clearClient):
(WebKit):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebLayer.cpp:
(WebKit::WebLayer::setSublayerTransform):
(WebKit):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::setIsDrawable):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setDoubleSided):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setContentsScale):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 17 May 2012 18:34:37 +0000 (18:34 +0000)]
remove bit rotted comment about css properties
https://bugs.webkit.org/show_bug.cgi?id=86750
Reviewed by Alexis Menard.
It's not clear to me what the first block was even referring to.
Aural doesn't seem to exist anymore. It might be worth keeping,
"All the CSS properties are not supported by the renderer at the
moment.", but it seems obvious to me.
No new tests, just removing a comment.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 17 May 2012 18:33:33 +0000 (18:33 +0000)]
[chromium] Remove unnecessary expectations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=86698
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 17 May 2012 18:22:38 +0000 (18:22 +0000)]
Insert source file and line number for v8 function calls into tracing
https://bugs.webkit.org/show_bug.cgi?id=84613
Reviewed by Kentaro Hara.
The trace for v8 function calls doesn't include any information about
what function is being called. Pass this information along so it can
be less opaque.
* bindings/v8/V8Proxy.cpp:
(WebCore::resourceInfo):
(WebCore):
(WebCore::resourceString):
(WebCore::V8Proxy::instrumentedCallFunction):
* platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 18:21:02 +0000 (18:21 +0000)]
[EFL] Gardening, unskip some tests after r117426.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 18:09:37 +0000 (18:09 +0000)]
[EFL] Add API for Web Database handling
https://bugs.webkit.org/show_bug.cgi?id=85178
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17
Reviewed by Antonio Gomes.
Source/WebKit:
Added the new Web Database API to the buildsystem.
* PlatformEfl.cmake:
Source/WebKit/efl:
Add API for Web Database. This API will allow a browser
to query information about size, name, filename and remove
databases based on the origin. It will be also possible to
list all databases for a given origin.
* ewk/EWebKit.h:
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_get_all):
* ewk/ewk_security_origin.h:
* ewk/ewk_settings.cpp:
* ewk/ewk_settings.h:
* ewk/ewk_web_database.cpp: Added.
(_Ewk_Web_Database):
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_name_get):
(ewk_web_database_security_origin_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
(ewk_web_database_free):
(ewk_web_database_list_free):
(ewk_web_database_new):
* ewk/ewk_web_database.h: Added.
* ewk/ewk_web_database_private.h: Copied from Source/WebKit/efl/ewk/EWebKit.h.
(WebCore):
Tools:
Use the newly introduced Web Database API in EFL's DRT.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllDatabases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 17 May 2012 17:54:40 +0000 (17:54 +0000)]
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802
Reviewed by Ryosuke Niwa.
Source/WebCore:
Timeout was caused by an infinite in the outer loop of
pushDownInlineStyleAroundNode(). The outer loop variable 'current' should point at the
node containing 'targetNode'. The inner loop traverse the children of 'current'
and discover the children that contains 'targetNode'.
However, before the inner loop, we call removeInlineStyleFromElement() that can
potentially remove the 'current' node from the tree, moving its children to
'current' former parent. For that reason 'child' and 'lastChild' are collected
before this call.
The tricky part is that changing the 'current' children parent, we might trigger
further side-effects, that can remove either 'child' or 'lastChild' from the tree
too. The infinite loop was due to 'child' being off the document, so it's
nextSibling() is 0, and we go another run of outer loop without changing
'current' because the 'targetNode' wasn't in the first child that inner loop
couldn't reach.
When testing Qt on Mac, there was also a crash in RenderTextControl when the font
family was empty, this patch fixes it as well.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Use NodeVector
instead of relying on first/last child being valid after
removeInlineStyleFromElement() is called. Skip the child if it has no parent,
this is an indication that it was removed from the tree.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hasValidAvgCharWidth): Empty AtomicStrings aren't
supported by HashSet, so we have to early return in this case.
LayoutTests:
* platform/qt/Skipped: Unskipped. Note that it is still skipped for wk2 because
setEditingBehavior is not implemented for WebKitTestRunner yet.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 17 May 2012 17:52:33 +0000 (17:52 +0000)]
Web Inspector: implement Go To selector for stylesheet files.
https://bugs.webkit.org/show_bug.cgi?id=86751
Reviewed by Yury Semikhatsky.
StyleSheetOutlineDialog is introduced.
* English.lproj/localizedStrings.js:
* inspector/front-end/FilteredItemSelectionDialog.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._generateTabId):
(WebInspector.TabbedEditorContainer.prototype.currentFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 17:50:30 +0000 (17:50 +0000)]
REGRESSION (r117449): Unreviewed, rolling out r117449.
https://bugs.webkit.org/show_bug.cgi?id=86753
Broke many unskipped tests which lack expectations
* platform/efl/Skipped:
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 17 May 2012 17:27:50 +0000 (17:27 +0000)]
REGRESSION (r117428): WebKit API/SPI was removed
https://bugs.webkit.org/show_bug.cgi?id=86748
Reverted r117428.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/chromium:
* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDomainRelaxationForbidden):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
* WebKit.order:
* WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
* WebView/WebViewPrivate.h:
Source/WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
* WebView.h:
(WebView):
Source/WebKit2:
* win/WebKit2.def:
Tools:
* DumpRenderTree/LayoutTestController.cpp:
(setDomainRelaxationForbiddenForURLSchemeCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
LayoutTests:
* http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 17:25:58 +0000 (17:25 +0000)]
[EFL] Fix link error caused by not directly linking with edbus
https://bugs.webkit.org/show_bug.cgi?id=86747
Unreviewed build fix.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17
.:
* Source/cmake/FindEFL.cmake:
Source/WebKit:
* PlatformEfl.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 17 May 2012 17:20:07 +0000 (17:20 +0000)]
[BlackBerry] Build fix, SelectionHandler extra debug logs
https://bugs.webkit.org/show_bug.cgi?id=86743
Reviewed by Antonio Gomes.
Add include for BlackBerryPlatformLog to SelectionHandler.cpp
* WebKitSupport/SelectionHandler.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 17 May 2012 17:05:36 +0000 (17:05 +0000)]
Unreviewed, adding GTK baselines for new tests added in r115641, r116975 and r117339.
* platform/gtk/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/gtk/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/gtk/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
* platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 16:35:33 +0000 (16:35 +0000)]
[Qt] Unreviewed gardening.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 17 May 2012 16:05:41 +0000 (16:05 +0000)]
Web Inspector: create SourceFrames with content providers.
https://bugs.webkit.org/show_bug.cgi?id=86742
Reviewed by Vsevolod Vlasov.
Simple refactoring.
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.get resource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 17 May 2012 16:00:36 +0000 (16:00 +0000)]
Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/console/inspect-html-all-collection.html
* inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"
when checking if object resolved by id is valid.
LayoutTests:
Test that RemoteObject.callFunctionOn can be successfully invoked on a
remote object representing HTMLAllCollection instance.
* inspector/console/inspect-html-all-collection-expected.txt: Added.
* inspector/console/inspect-html-all-collection.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 17 May 2012 15:57:40 +0000 (15:57 +0000)]
Unreviewed build fix attempt. Changing class to struct in forward declaration.
* fileapi/File.h:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 17 May 2012 15:51:11 +0000 (15:51 +0000)]
Web Inspector: convert styles panel into UISourceCodeProvider in the scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=86734
Reviewed by Vsevolod Vlasov.
This change also makes Scripts render ans Source Code under that experiment.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get toolbarItemLabel):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype._initialize):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.canEditSource):
(WebInspector.StyleSourceFrame.prototype.requestContent):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.StyleSourceFrame.prototype._contentChanged):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
* inspector/front-end/UISourceCode.js:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 17 May 2012 15:42:17 +0000 (15:42 +0000)]
Frame flattening should not expand tiny frames
https://bugs.webkit.org/show_bug.cgi?id=86736
Source/WebCore:
Reviewed by Kenneth Rohde Christiansen.
If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably
not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame
may end up looking like a rendering error.
The patch prevents expansion of frames that have fixed width or height less than 8px.
Test: fast/frames/flattening/iframe-tiny.html
* rendering/RenderFrameBase.cpp:
(WebCore::shouldExpandFrame):
(WebCore):
(WebCore::RenderFrameBase::layoutWithFlattening):
LayoutTests:
Reviewed by Kenneth Rohde Christiansen.
* fast/frames/flattening/iframe-tiny-expected.txt: Added.
* fast/frames/flattening/iframe-tiny.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 17 May 2012 15:21:08 +0000 (15:21 +0000)]
[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
https://bugs.webkit.org/show_bug.cgi?id=86726
Reviewed by Pavel Feldman.
No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.
* inspector/WorkerDebuggerAgent.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 15:19:03 +0000 (15:19 +0000)]
[EFL] Gardening failure test cases.
https://bugs.webkit.org/show_bug.cgi?id=86728
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17
* platform/efl/Skipped: removing tests related to editing callbacks functionality.
* platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.
Merging tests with particular bugs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 15:17:20 +0000 (15:17 +0000)]
[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=86576
Reviewed by Adam Barth.
As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am planning to refactor a series of confusing throwError()s into
throwError() and throwTypeError().
This patch supports an optional 'message' argument for V8Proxy::throwTypeError().
Also this patch replaces throwError("message", V8Proxy::TypeError) in custom bindings
with V8Proxy::throwTypeError("message").
No tests. No change in behavior.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwTypeError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 17 May 2012 14:21:41 +0000 (14:21 +0000)]
Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
https://bugs.webkit.org/show_bug.cgi?id=86659
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.
* inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.
(iframe.extension):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 14:08:58 +0000 (14:08 +0000)]
[chromium] run-webkit-tests can't work on ubuntu 12.04
https://bugs.webkit.org/show_bug.cgi?id=86565
Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kent Tamura.
On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf
* DumpRenderTree/chromium/TestShellLinux.cpp:
(checkAndLoadFontFile):
(setupFontconfig):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 13:54:13 +0000 (13:54 +0000)]
Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
https://bugs.webkit.org/show_bug.cgi?id=86711
Changed color values with background on hover over breakpoints.
Patch by Sam D <dsam2912@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.
UI change, No new tests.
* inspector/front-end/inspector.css:
(.breakpoint-list li:hover):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 17 May 2012 13:35:29 +0000 (13:35 +0000)]
Unreviewed GTK gardening, adding platform-specific baselines for
two tests affected by r117339.
* platform/gtk/fast/repaint/float-overflow-expected.txt: Added.
* platform/gtk/fast/repaint/float-overflow-right-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
epoger@chromium.org [Thu, 17 May 2012 13:35:10 +0000 (13:35 +0000)]
Add setting of additional_expectations option to
chromium_unittest.test_overrides_and_builder_names(),
so we can test order in which the base and chromium expectations files
are combined.
https://bugs.webkit.org/show_bug.cgi?id=86642
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_overrides_and_builder_names):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 13:32:09 +0000 (13:32 +0000)]
Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
https://bugs.webkit.org/show_bug.cgi?id=86716
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.
Added a new context menu to provide Remove All DOM breakpoint option.
UI Feature. Tests not required.
* English.lproj/localizedStrings.js:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 13:29:51 +0000 (13:29 +0000)]
[Qt] Unreviewed gardening. Added platform specific expectation.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17
* platform/qt-5.0-wk2/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
* platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt: Added after r117289.
* platform/qt/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Update after r117429.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 13:26:27 +0000 (13:26 +0000)]
Patch by Tsarko Yaroslav <eriktsarko@googlemail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.
Bug 71271: [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during
https://bugs.webkit.org/show_bug.cgi?id=71271
Web Inspector should not belong to any other page groups since it is a specialized debugger window.
The reason for this change is when debugger pauses web page it pauses all the pages in the page group of debuggee.
This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271).
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 13:07:02 +0000 (13:07 +0000)]
[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632
Unskip the now passing test after Qt5 fix.
* platform/qt-5.0-wk1/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 12:52:38 +0000 (12:52 +0000)]
[Qt] svg/zoom/page/zoom-svg-float-border-padding.xml crashes
https://bugs.webkit.org/show_bug.cgi?id=79631
* platform/qt/Skipped: Try to unskip them.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 17 May 2012 12:48:07 +0000 (12:48 +0000)]
Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
https://bugs.webkit.org/show_bug.cgi?id=86718
The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array.
Due to nature of nodeIndex values the original array was sparsed.
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 17 May 2012 12:39:19 +0000 (12:39 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
Reviewed by Csaba Osztrogonác.
Tools:
Reenable TestNetscapePlugin with Qt 4.
* Tools.pro:
LayoutTests:
Don't disable plugin tests for Qt 4.
* platform/qt-5.0/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 12:30:11 +0000 (12:30 +0000)]
[Qt][WK2] fast/events/page-visibility-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=83263
Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-17
Reviewed by Kenneth Rohde Christiansen.
Tools:
Handle "preview" state and avoid string conversion.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPageVisibility):
LayoutTests:
Unskip two page-visibility tests: iframe-propagation-test.html
and transition-test.html.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 12:27:44 +0000 (12:27 +0000)]
[Qt] Unreviewed gardening, unksip one more now passing test.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 12:24:29 +0000 (12:24 +0000)]
[Qt] Unreviewed gardening, unksip a now passing test.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 17 May 2012 12:07:55 +0000 (12:07 +0000)]
Allow FileSystem API implementation to pass snapshot metadata at File creation time
https://bugs.webkit.org/show_bug.cgi?id=78879
Reviewed by Jian Li.
Source/WebCore:
We query File metadata (e.g. size and modifiedTime) when File.size,
lastModifiedTime or webkitSlice() is accessed / called, but in some
platform-specific filesystems it may not be feasible since synchronous
metadata query could take very long time.
This patch adds new File constructor which takes metadata argument
to allow each FileSystem API implementation to pass snapshot metadata
so that File object could cache the given metadata not to make
synchronous query.
We only call this constructor if the filesystem type is neither
Temporary nor Persistent, therefore this patch should not affect
existing code behavior.
Test: fast/filesystem/file-read-after-write.html
* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile):
* Modules/filesystem/DOMFileSystemSync.cpp:
* fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice): Updated implementation.
* fileapi/Blob.h:
* fileapi/File.cpp:
(WebCore::File::File): Added new constructor.
(WebCore::File::lastModifiedDate): Updated implementation.
(WebCore::File::size): Updated implementation.
(WebCore::File::captureSnapshot): Updated implementation.
* fileapi/File.h:
(WebCore::File::createForFileSystemFile): Added.
* platform/AsyncFileSystem.h:
(AsyncFileSystem): Updated comment.
LayoutTests:
Added tests for making sure metadata is not cached in the regular
temporary filesystem.
* fast/filesystem/file-metadata-after-write-expected.txt: Added.
* fast/filesystem/file-metadata-after-write.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 17 May 2012 11:55:42 +0000 (11:55 +0000)]
Unreviewed, updating chrome test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 11:37:28 +0000 (11:37 +0000)]
[Performance test] Add a micro benchmark for div.firstChild getter
https://bugs.webkit.org/show_bug.cgi?id=86582
Reviewed by Ryosuke Niwa.
We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
In this bug, we add a micro benchmark for div.firstChild getter.
This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and
'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes
that return a Node object.
Multiple test results in my Linux desktop:
RESULT Bindings: first-child= 798.
157160346 runs/s
median= 798.
004987531 runs/s, stdev= 1.
52006063407 runs/s, min= 796.
019900498 runs/s, max= 801.
001251564 runs/s
RESULT Bindings: first-child= 797.
603608554 runs/s
median= 797.
872340426 runs/s, stdev= 2.
2522621261 runs/s, min= 791.
556728232 runs/s, max= 801.
001251564 runs/s
RESULT Bindings: first-child= 798.
656295468 runs/s
median= 798.
004987531 runs/s, stdev= 1.
79367478063 runs/s, min= 797.
01120797 runs/s, max= 803.
011292346 runs/s
RESULT Bindings: first-child= 797.
812784267 runs/s
median= 798.
004987531 runs/s, stdev= 2.
31766523191 runs/s, min= 791.
100123609 runs/s, max= 802.
005012531 runs/s
RESULT Bindings: first-child= 797.
963311597 runs/s
median= 798.
004987531 runs/s, stdev= 2.
53014907337 runs/s, min= 789.
14919852 runs/s, max= 801.
001251564 runs/s
* Bindings/first-child.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 11:35:58 +0000 (11:35 +0000)]
[Qt] Unreviewed gardening. Test expectation update.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-17
* platform/qt/fast/block/float/overhanging-tall-block-expected.png:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:After 117310.
* platform/qt/fast/repaint/float-overflow-expected.png:
* platform/qt/fast/repaint/float-overflow-expected.txt: After r117339.
* platform/qt/fast/repaint/float-overflow-right-expected.png:
* platform/qt/fast/repaint/float-overflow-right-expected.txt: After r117339.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Thu, 17 May 2012 11:14:27 +0000 (11:14 +0000)]
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
https://bugs.webkit.org/show_bug.cgi?id=86704
Reviewed by Eric Seidel.
.:
* Source/autotools/symbols.filter: Add setDomainRelaxationForbiddenForURLScheme symbol filter.
Source/WebCore:
Add setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way by means of the InternalSettings interface.
No new tests, since we are improving here the infra-structure for testing
a specific method.
* testing/InternalSettings.cpp:
(WebCore):
(WebCore::InternalSettings::setDomainRelaxationForbiddenForURLScheme):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/chromium:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/gtk:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* WebKit.order:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
Source/WebKit/qt:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
* WebView.h:
(WebView):
Source/WebKit2:
* win/WebKit2.def: Add setDomainRelaxationForbiddenForURLScheme symbol filter.
Tools:
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Invoke setDomainRelaxationForbiddenForURLScheme functions from internalSettings, because it is able to work in the
cross-port way via the InternalSettings interface.
* http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 17 May 2012 11:09:07 +0000 (11:09 +0000)]
[Qt] Unreviewed gardening. Skip failing reftests.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 11:06:21 +0000 (11:06 +0000)]
[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=84835
Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-05-17
Reviewed by Eric Seidel.
Source/WebKit/efl:
* WebCoreSupport/EditorClientEfl.cpp: Call appropriate callbacks for editing actions.
(WebCore::EditorClientEfl::shouldDeleteRange):
(WebCore::EditorClientEfl::shouldBeginEditing):
(WebCore::EditorClientEfl::shouldEndEditing):
(WebCore::EditorClientEfl::shouldInsertText):
(WebCore::EditorClientEfl::shouldChangeSelectedRange):
(WebCore::EditorClientEfl::shouldApplyStyle):
(WebCore::EditorClientEfl::didBeginEditing):
(WebCore::EditorClientEfl::didEndEditing):
(WebCore::EditorClientEfl::shouldInsertNode):
* WebCoreSupport/EditorClientEfl.h: Add structures needed by editing callbacks.
(Ewk_Should_Insert_Node_Event):
(Ewk_Should_Insert_Text_Event):
(Ewk_Should_Change_Selected_Range_Event):
(Ewk_Should_Apply_Style_Event):
Tools:
Added editing callbacks implementation.
* DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
(DumpRenderTreeChrome::createView):
* DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
(dumpPath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):
* DumpRenderTree/efl/EditingCallbacks.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Thu, 17 May 2012 11:03:42 +0000 (11:03 +0000)]
Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 10:16:49 +0000 (10:16 +0000)]
Unreviewed attempt to fix a Windows build breakage.
* public/WebIntent.h:
(WebIntent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 10:09:59 +0000 (10:09 +0000)]
[Performance test] In perftest.py, do not include 'description' in 'results'
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Csaba Osztrogoná.
'results' in perftest.py should not include any data that is not expected
by the perf bot server. We do not need to send 'description' to the perf bot
server since 'description' is always the same.
Thus this patch just removes 'description' from 'results'.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Thu, 17 May 2012 09:55:59 +0000 (09:55 +0000)]
ShadowRoot.selection should be ShadowRoot.getSelection()
https://bugs.webkit.org/show_bug.cgi?id=86598
Reviewed by Hajime Morita.
Source/WebCore:
In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the implementation.
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:
LayoutTests:
In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the tests.
* editing/shadow/selection-of-orphan-shadowroot.html:
* editing/shadow/selection-of-shadowroot.html: Removed unnecessary code to
call ShadowRoot.selection by using ShadowRoot.getSelection(). Now ShadowRoot.getSelection()
can be called directly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Thu, 17 May 2012 09:30:51 +0000 (09:30 +0000)]
[Refactoring] Remove TreeScopeAdjuster
https://bugs.webkit.org/show_bug.cgi?id=86599
Reviewed by Hajime Morita.
It seems the right place of the method of TreeScopeAdjuster are in VisibleSelection
and TreeScope. So we can remove TreeScopeAdjuster.
No new tests, no change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/TreeScope.cpp:
(WebCore::TreeScope::ancestorInThisScope):
(WebCore):
* dom/TreeScope.h:
(TreeScope):
* dom/TreeScopeAdjuster.cpp: Removed.
* dom/TreeScopeAdjuster.h: Removed.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustPositionBefore):
(WebCore):
(WebCore::VisibleSelection::adjustPositionAfter):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
* editing/VisibleSelection.h:
(VisibleSelection):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::shadowAdjustedNode):
(WebCore::DOMSelection::shadowAdjustedOffset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 17 May 2012 09:12:54 +0000 (09:12 +0000)]
NEON intrinsic should be used with arithmetic mode of composite filter
https://bugs.webkit.org/show_bug.cgi?id=86622
Reviewed by Nikolas Zimmermann.
Rewrite hand written assembly code to increase portability and readibility
of the code. Remove the unnecessary FECompositeArithmeticNEON.cpp from the
project
Existing tests cover this issue.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FEComposite.cpp:
(WebCore):
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Removed.
* platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 09:03:20 +0000 (09:03 +0000)]
showNodePath will be useful for debugging purpose.
https://bugs.webkit.org/show_bug.cgi?id=86450
This patch implements showNodePath, which outputs node information in
a xpath-like format, e.g. /HTML/BODY/DIV[@id="test" and position()=0]/P[0]
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-17
Reviewed by Hajime Morita.
No new tests, just adding debugging interface.
* dom/Node.cpp:
(WebCore::Node::showNodePathForThis):
(WebCore):
(showNodePath):
* dom/Node.h:
(Node):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 08:58:10 +0000 (08:58 +0000)]
Unreviewed, marking tests which need rebaselining after r117412.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 08:48:44 +0000 (08:48 +0000)]
Unreviewed, marking acid3-test-77.html as fail.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
g.czajkowski@samsung.com [Thu, 17 May 2012 08:21:51 +0000 (08:21 +0000)]
[EFL] Do not check NULL pointer allocated by new.
https://bugs.webkit.org/show_bug.cgi?id=86610
Reviewed by Ryosuke Niwa.
WebKit-Efl doesn't check pointers that are initialized by new.
Those checks are not needed because new operator doesn't return NULL.
Only an overloaded version of new returns NULL pointer.
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_entry_new):
* ewk/ewk_view.cpp:
(_ewk_view_core_frame_new):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 08:18:59 +0000 (08:18 +0000)]
REGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)
https://bugs.webkit.org/show_bug.cgi?id=85991
Source/WebCore:
Fix for regression failures on deprecated flex box test cases.
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.
Test: fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
Fix to use intrinsic width when the fixed width:0 , for deprecated flex boxes.
LayoutTests:
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.
* fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt: Added.
* fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 08:14:33 +0000 (08:14 +0000)]
CSS3 Multicolumn: Content in normal flow extending into column gaps should be clipped at middle of column-gap
https://bugs.webkit.org/show_bug.cgi?id=86441
Patch by Uday Kiran <udaykiran@motorola.com> on 2012-05-17
Reviewed by Eric Seidel.
Source/WebCore:
Content in the normal flow that extends into column gaps (e.g., long words or images)
is clipped in the middle of the column gap.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements
Test: fast/multicol/overflow-into-columngap.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
LayoutTests:
Test for content in normal flow that extends into column gaps.
http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements
* fast/multicol/overflow-into-columngap-expected.html: Added.
* fast/multicol/overflow-into-columngap.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 08:06:38 +0000 (08:06 +0000)]
[Worker] Web Worker lacks test to check the name attribute of SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=86714
Patch by Li Yin <li.yin@intel.com> on 2012-05-17
Reviewed by Kentaro Hara.
Spec: http://www.w3.org/TR/2012/CR-workers-
20120501/#sharedworkerglobalscope
The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
but it doesn't cover this.
* fast/workers/resources/shared-worker-common.js:
(handleMessage):
* fast/workers/resources/shared-worker-name.js:
(test11.worker.port.onmessage):
(test11):
* fast/workers/shared-worker-name-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 07:46:04 +0000 (07:46 +0000)]
[Performance test] Always fill results['description'] in perftest.py
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Ryosuke Niwa.
This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills results['description'] always.
* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 07:30:03 +0000 (07:30 +0000)]
[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=85879
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-17
Reviewed by Noam Rosenthal.
Source/WebKit/efl:
_ewk_frame_smart_del() is considering now that the frame can be present in cache.
loader()->detachFromParent() is only applied for the main frame.
loader()->cancelAndClear() is not used anymore.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del):
LayoutTests:
* platform/efl/test_expectations.txt: Removed fast/frames/frame-crash-with-page-cache.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 07:27:40 +0000 (07:27 +0000)]
Unreviewed, marking input-appearance-range.html as fail.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 07:10:28 +0000 (07:10 +0000)]
Unreviewed, marking backgr_position-table.html and some others as fail.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 07:07:23 +0000 (07:07 +0000)]
[Qt] Unreviewed gardening after r117339.
https://bugs.webkit.org/show_bug.cgi?id=84167
* platform/qt/Skipped:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/qt/editing/selection/iframe-expected.png:
* platform/qt/editing/selection/iframe-expected.txt:
* platform/qt/editing/selection/inline-table-expected.png:
* platform/qt/editing/selection/inline-table-expected.txt:
* platform/qt/editing/selection/table-caret-3-expected.png:
* platform/qt/editing/selection/table-caret-3-expected.txt:
* platform/qt/fast/css-generated-content/inline-display-types-expected.png:
* platform/qt/fast/css-generated-content/inline-display-types-expected.txt:
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/qt/fast/inline-block/001-expected.png:
* platform/qt/fast/inline-block/001-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 06:54:35 +0000 (06:54 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
* platform/qt/Skipped: Skip failing tests after r117288.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 06:53:07 +0000 (06:53 +0000)]
Unreviewed, rolling out r117372.
http://trac.webkit.org/changeset/117372
https://bugs.webkit.org/show_bug.cgi?id=86710
"triggerring crashes" (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
Source/WebCore:
* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::context):
(WebCore::AudioParam::hasSampleAccurateValues):
(WebCore::AudioParam::AudioParam):
(AudioParam):
LayoutTests:
* webaudio/audioparam-connect-audioratesignal.html:
* webaudio/audioparam-summingjunction-expected.txt: Removed.
* webaudio/audioparam-summingjunction.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 17 May 2012 06:40:13 +0000 (06:40 +0000)]
Unreviewed GTK gardening after r117373.
* platform/gtk/fast/forms/input-align-image-expected.txt:
* platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 06:36:29 +0000 (06:36 +0000)]
Unreviewed, rolling out r117396.
http://trac.webkit.org/changeset/117396
https://bugs.webkit.org/show_bug.cgi?id=86709
"breaks chromium tree" (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
* WebKit.gyp:
* public/WebTextInputInfo.h: Removed.
* public/WebTextInputType.h:
* public/WebWidget.h:
(WebKit::WebWidget::textInputType):
* src/WebTextInputInfo.cpp: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 17 May 2012 06:22:13 +0000 (06:22 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
* platform/qt/Skipped: Skip failing tests after r117288.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 06:20:43 +0000 (06:20 +0000)]
Unreviewed expectations update.
* fast/repaint/float-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.png.
* fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
* fast/repaint/float-overflow-right-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.png.
* fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-mac/fast/repaint/float-overflow-expected.png: Added.
* platform/chromium-mac/fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-expected.txt.
* platform/chromium-mac/fast/repaint/float-overflow-right-expected.png: Added.
* platform/chromium-mac/fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-right-expected.txt.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/repaint/float-overflow-expected.png: Removed.
* platform/gtk/fast/repaint/float-overflow-right-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 06:17:07 +0000 (06:17 +0000)]
[EFL] Restore accidentally changed copyrights.
https://bugs.webkit.org/show_bug.cgi?id=86471
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-16
Reviewed by Antonio Gomes.
Restore accidentally changed copyrights.
* ewk/ewk_js_private.h:
* ewk/ewk_security_origin_private.h:
* ewk/ewk_view_private.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 05:18:28 +0000 (05:18 +0000)]
[chromium] Get text direction at the start and end of selection.
https://bugs.webkit.org/show_bug.cgi?id=86573
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-16
Reviewed by Adam Barth.
Add an interface to get text direction at the start and end of
selection for Android, as on Android different selection delimiters
are needed for RTL text. Unlike other platforms, the start and end
delimiters of selection are different, so we need determine the shape
of delimiter based on text direction.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::selectionTextDirection):
* src/WebViewImpl.cpp:
(WebKit):
(WebKit::WebViewImpl::selectionTextDirection):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 05:16:14 +0000 (05:16 +0000)]
[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Ryosuke Niwa.
We want to add some description for each PerfTestRunner.run and
PerfTestRunner.runPerSecond, so that people can know what each
run is testing.
Output example:
$ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
Running Bindings/first-child.html (1 of 1)
DESCRIPTION: Benchmark for DOM attributes that return a Node object.
RESULT Bindings: first-child= 788.
359076534 runs/s
median= 797.
508097751 runs/s, stdev= 19.
0972905207 runs/s, min= 746.
666666667 runs/s, max= 801.
001251564 runs/s
PerformanceTests:
* resources/runner.js:
(PerfTestRunner.logStatistics):
(PerfTestRunner.printStatistics):
(PerfTestRunner.runPerSecond):
Tools:
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 17 May 2012 05:03:57 +0000 (05:03 +0000)]
[Chromium] Implement WebViewImpl::textInputInfo() for Android
https://bugs.webkit.org/show_bug.cgi?id=86440
Reviewed by Darin Fisher.
This patch adds WebView::textInputInfo(), which describes the text
input that currently has focus. Android is planning to use this to
determine what sort of keyboard or text entry UI to show. This API
subsumes the textInputType() API, which will be removed once the
clients have been updated.
* WebKit.gyp:
* public/WebTextInputInfo.h: Added.
(WebKit):
(WebTextInputInfo):
(WebKit::WebTextInputInfo::WebTextInputInfo):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebTextInputType.h:
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::textInputInfo):
(WebKit::WebWidget::textInputType):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit):
(WebKit::WebViewImpl::textInputType):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 04:53:32 +0000 (04:53 +0000)]
[EFL] Fix bug number for video-controls-drag.html in the test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86607
Unreviewed EFL gardening.
Change BUGWK number to point to right patch.
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 17 May 2012 04:37:46 +0000 (04:37 +0000)]
Implement a Shadow DOM spec's section 6 'Events'.
https://bugs.webkit.org/show_bug.cgi?id=78586
Reviewed by Dimitri Glazkov.
Source/WebCore:
This implements a Shadow DOM spec's section 6 'Events', introducing a new
algorithm so that event dispatching use a composed shadow DOM tree,
instead of normal DOM tree, in dispatching events to each node.
The spec is here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events
Summary of changes:
- Attaching shadow DOM does not affect an event dispatching
behavior of enclosing DOM tree. This applies even if some nodes
are distributed to insertion points. We keep a compatibility of
existing event dispatching mechanism so that we won't break Web.
- Event ancestors, which are used in dispatching events in capture (or
bubble) phase, are now the result of traversing ancestors in composed
shadow DOM tree order, instead of normal DOM tree order.
- Event's target and related-target are correctly adjusted so that
we don't leak any node which is inaccessible from the event's
current-target node. We enforce both upper and lower boundary
encapsulation of Shadow DOM in event dispatching
Here is an example of event dispatching. Suppose we have the following DOM tree, which
includes some nested shadow hosts and insertion points
A
`--B-----[SR-B]
|-C `--G--------------[SR-G]
| `-D |-<H select=C> |--J---------------[SR-J]
`-E `-<I select=E> | `-<K select=H> `-<N select=K>
`-F |
`--L---------------[SR-L]
`-<M select=I> `-<O select=M>
Notation: [SR-X]: Shadow Root
<X select=Y>: Insertion Point, called X, which selects Y.
If a mouse moves from node '#F' to node '#D', the following
'mouseover' events are dispatched in each ancestor node:
[currentTarget] [target] [related-target]
#D #D #F
#C #D #F
#H #H #I
#K #K #M
#N #N #M
#SR-J #N #M
#J #K #M
#SR-G #K #M
#G #H #I
#SR-B #H #I
#B #D #F
#A #D #F
Details are:
- Insertion points, such as <content> or <shadow>, are resolved correctly
in calculating event ancestors. That means if a node is distributed to
an insertion point, the insertion point is now an ancestor of the node in
bubbling (or capturing) events.
- Both insertion points and shadow roots now can receive events. We can add
event listeners to insertion points and shadow roots.
- Dispatched event's target is now adjusted correctly using the re-targeting
algorithm. The algorithm is now fully aware of insertion points.
- Dispatched event's related-target can now differ in each tree scope of
event ancestors. We choose the most appropriate related-target using the
related target resolution algorithm for each node.
Performance consideration:
This patch can achieve the competitive performance. The results of
./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html for
before/after this patch are:
Before applying this patch:
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 270.
310714286 ms
median= 269.75 ms, stdev= 2.
0042397663 ms, min= 267.
357142857 ms, max= 276.5 ms
After applying this patch:
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 268.
108333333 ms
median= 267.5 ms, stdev= 2.
41883157195 ms, min= 263.625 ms, max= 273.
142857143 ms
I've also conducted a micro benchmark using both
Shadow-Free-DOM-Tree and DOM-Tree-With-Shadow-Host.
See https://bugs.webkit.org/show_bug.cgi?id=78586#c40 for the results.
It seems that the new implementation has more capabilities, but
doesn't sacrifice a performance of event dispatching in either cases.
Test: fast/dom/shadow/shadow-dom-event-dispatching.html
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
* dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
(WebCore::EventContext::handleLocalEvents):
* dom/EventContext.h:
(EventContext):
(WebCore::EventContext::relatedTarget):
(WebCore):
(WebCore::EventContext::setRelatedTarget):
* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::EventRelatedTargetAdjuster):
(WebCore):
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::determineDispatchBehavior):
* dom/EventDispatcher.h:
(WebCore):
(EventRelatedTargetAdjuster):
(EventDispatcher):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(WebCore::toMouseEvent):
(WebCore):
LayoutTests:
* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Added.
* fast/dom/shadow/shadow-dom-event-dispatching.html: Added.
* platform/efl/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 17 May 2012 04:09:47 +0000 (04:09 +0000)]
Moving caret up or down skips lines when there's a non-editable line
https://bugs.webkit.org/show_bug.cgi?id=81490
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition
skipping leaf nodes that constitute a new line and belong to the same editable region because block elements
that separate lines are not editable so it looked as if all editable lines belong to a single line as far as
those two functions are concerned.
Fixed the bug by using the first leaf node that belongs to the same editable region but does not belong in
the same as the start node.
This patch is based on a patch authored by Yi Shen (Nokia).
Test: editing/selection/move-between-lines-of-different-editabilities.html
* editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
LayoutTests:
Added a regression test.
* editing/selection/move-between-lines-of-different-editabilities.html: Added.
* editing/selection/move-by-word-visually-mac-expected.txt: Rebaselined a test case. It failed
before this change and still fails after this change.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 03:58:23 +0000 (03:58 +0000)]
Unreviewed attempt to fix Mac SL build.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Thu, 17 May 2012 03:55:41 +0000 (03:55 +0000)]
Add tests for CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=86575
Reviewed by Dimitri Glazkov.
* fast/css/variables/colors-test-expected.html: Added.
* fast/css/variables/colors-test.html: Added.
* fast/css/variables/complex-cycle-expected.html: Added.
* fast/css/variables/complex-cycle.html: Added.
* fast/css/variables/computed-style-expected.html: Added.
* fast/css/variables/computed-style.html: Added.
* fast/css/variables/inherited-values-expected.html: Added.
* fast/css/variables/inherited-values.html: Added.
* fast/css/variables/inline-styles-expected.html: Added.
* fast/css/variables/inline-styles.html: Added.
* fast/css/variables/invalid-shorthand-expected.html: Added.
* fast/css/variables/invalid-shorthand.html: Added.
* fast/css/variables/invalid-variable-value-expected.html: Added.
* fast/css/variables/invalid-variable-value.html: Added.
* fast/css/variables/multi-level-cycle-expected.html: Added.
* fast/css/variables/multi-level-cycle.html: Added.
* fast/css/variables/redefinition-expected.html: Added.
* fast/css/variables/redefinition.html: Added.
* fast/css/variables/shorthand-expected.html: Added.
* fast/css/variables/shorthand.html: Added.
* fast/css/variables/simple-cycle-expected.html: Added.
* fast/css/variables/simple-cycle.html: Added.
* fast/css/variables/undefined-expected.html: Added.
* fast/css/variables/undefined.html: Added.
* fast/css/variables/use-before-defined-expected.html: Added.
* fast/css/variables/use-before-defined.html: Added.
* fast/css/variables/var-inside-shorthand-expected.html: Added.
* fast/css/variables/var-inside-shorthand.html: Added.
* fast/css/variables/variable-chain-expected.html: Added.
* fast/css/variables/variable-chain.html: Added.
* platform/chromium/test_expectations.txt: Skip tests until variables implementation lands.
* platform/efl/test_expectations.txt: Skip tests until variables implementation lands.
* platform/gtk/test_expectations.txt: Skip tests until variables implementation lands.
* platform/mac/test_expectations.txt: Skip tests until variables implementation lands.
* platform/qt/test_expectations.txt: Skip tests until variables implementation lands.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 03:52:17 +0000 (03:52 +0000)]
Unreviewed, marking failing test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 17 May 2012 03:37:21 +0000 (03:37 +0000)]
Use pixelSnappedLogicalHeight for TableSection layout
https://bugs.webkit.org/show_bug.cgi?id=86665
Reviewed by Eric Seidel.
We do table layout using integers to ensure we follow the spec (see
https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
flooring the logical height used in layoutRows. This caused us to mis-
calculate the intrinsic padding and grow cells beyond their proper height.
No new tests. Fully covered by existing tests with sub-pixel enabled.
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
methods.
(WebCore::RenderBox::pixelSnappedLogicalWidth):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 03:35:39 +0000 (03:35 +0000)]
Unreviewed, marking failing test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 17 May 2012 03:24:40 +0000 (03:24 +0000)]
Unreviewed, marking cross-fade-background-image.html as failing.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 17 May 2012 03:19:31 +0000 (03:19 +0000)]
rename display:-webkit-flexbox to display:-webkit-flex
https://bugs.webkit.org/show_bug.cgi?id=86529
Reviewed by Eric Seidel.
Source/WebCore:
Also renames -webkit-inline-flexbox to -webkit-inline-flex.
No new tests. Covered by existing tests.
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in: Update keyword values.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderObject.h:
(RenderObject):
* rendering/style/RenderStyleConstants.h: Rename const values.
LayoutTests:
* css3/flexbox/anonymous-block-merge-crash.html:
* css3/flexbox/anonymous-block.html:
* css3/flexbox/auto-height-dynamic.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/columns-auto-size.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/display-flexbox-set-get-expected.txt:
* css3/flexbox/display-flexbox-set-get.html:
* css3/flexbox/flex-algorithm-min-max.html:
* css3/flexbox/flex-algorithm-with-margins.html:
* css3/flexbox/flex-algorithm.html:
* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-end.html:
* css3/flexbox/flex-align-max.html:
* css3/flexbox/flex-align-percent-height.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/flex-flow-border.html:
* css3/flexbox/flex-flow-margins-auto-size.html:
* css3/flexbox/flex-flow-margins.html:
* css3/flexbox/flex-flow-orientations.html:
* css3/flexbox/flex-flow-overflow.html:
* css3/flexbox/flex-flow-padding.html:
* css3/flexbox/flex-flow.html:
* css3/flexbox/flex-item-child-overflow.html:
* css3/flexbox/flex-no-flex.html:
* css3/flexbox/flex-order.html:
* css3/flexbox/flex-pack.html:
* css3/flexbox/flexbox-overflow-auto-expected.html:
* css3/flexbox/flexbox-overflow-auto.html:
* css3/flexbox/floated-flexbox.html:
* css3/flexbox/insert-text-crash.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-column-auto.html:
* css3/flexbox/multiline-line-pack-horizontal-column.html:
* css3/flexbox/multiline-line-pack.html:
* css3/flexbox/multiline-pack.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/multiline-reverse-wrap-overflow.html:
* css3/flexbox/multiline-shrink-to-fit.html:
* css3/flexbox/multiline.html:
* css3/flexbox/nested-stretch.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/preferred-widths-orthogonal.html:
* css3/flexbox/preferred-widths.html:
* css3/flexbox/repaint-rtl-column.html:
* css3/flexbox/repaint.html:
* css3/flexbox/true-centering.html:
* css3/flexbox/writing-modes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 03:17:02 +0000 (03:17 +0000)]
IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634
Patch by Greg Billock <gbillock@google.com> on 2012-05-16
Reviewed by Adam Barth.
Source/WebCore:
The delivered intent has some extra fields and methods (extras,
postResult, postFailure) from the invocation intent. It is implemented
as a subclass. Responses from the service JS are passed to an embedder
client object provided when the intent is delivered.
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
Test: webintents/web-intents-delivery.html
* Modules/intents/DOMWindowIntents.cpp: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(WebCore::DOMWindowIntents::DOMWindowIntents):
(WebCore::DOMWindowIntents::~DOMWindowIntents):
(WebCore::DOMWindowIntents::from):
(WebCore::DOMWindowIntents::webkitIntent):
(WebCore::DOMWindowIntents::deliver):
* Modules/intents/DOMWindowIntents.h: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(DOMWindowIntents):
* Modules/intents/DOMWindowIntents.idl:
* Modules/intents/DeliveredIntent.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::DeliveredIntent::create):
(WebCore::DeliveredIntent::DeliveredIntent):
(WebCore::DeliveredIntent::ports):
(WebCore::DeliveredIntent::getExtra):
(WebCore::DeliveredIntent::postResult):
(WebCore::DeliveredIntent::postFailure):
* Modules/intents/DeliveredIntent.h: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(DeliveredIntent):
(WebCore::DeliveredIntent::~DeliveredIntent):
* Modules/intents/DeliveredIntent.idl: Copied from Source/WebCore/Modules/intents/Intent.h.
* Modules/intents/Intent.h:
(WebCore::Intent::~Intent):
(Intent):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/v8/custom/V8DeliveredIntentCustom.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::V8DeliveredIntent::portsAccessorGetter):
Source/WebKit/chromium:
The embedder will implement the WebDeliveredIntentClient interface, which
will get notifications of postResult/postFailure from the service page.
* public/WebDeliveredIntentClient.h:
* public/WebFrame.h:
(WebKit):
(WebFrame):
* src/WebDeliveredIntentClient.cpp:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::deliverIntent):
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 03:14:09 +0000 (03:14 +0000)]
[V8][Refactoring] Replace throwError("message", XXXError)
with throwError(XXXError, "message")
https://bugs.webkit.org/show_bug.cgi?id=86579
Reviewed by Adam Barth.
This is one of a series of refactoring commented in
https://bugs.webkit.org/show_bug.cgi?id=84074#c5
Currently there are two equivalent throwError()s; i.e. throwError("message", XXXError)
and throwError(XXXError, "message"). In this bug we replace
throwError("message", XXXError) with throwError(XXXError, "message")
(except for the case where XXXError == TypeError. This is because
throwError("message", TypeError) will be replaced with throwTypeError("message")
in a follow-up patch).
No tests. No change in behavior.
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 02:59:02 +0000 (02:59 +0000)]
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 02:21:10 +0000 (02:21 +0000)]
[V8] Pass Isolate to remaining toV8()
https://bugs.webkit.org/show_bug.cgi?id=86570
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().
No tests. No change in behavior.
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Thu, 17 May 2012 02:18:46 +0000 (02:18 +0000)]
Add new build slave for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=86567
Reviewed by Ryosuke Niwa.
Add a build slave for EFL 32-bit linux build.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 17 May 2012 02:18:41 +0000 (02:18 +0000)]
GraphicsContext3D interface should not be aware of CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=86550
Reviewed by Darin Adler.
Source/WebCore:
GraphicsContext3D is a WebCore/platform API construct. CanvasRenderingContext is a WebCore/html concept. Thus,
the former shouldn't depend on the latter. In turns out that all everyone ever wants from a
CanvasRenderingContext in GraphicsContext3D is its underlying ImageBuffer, which is a WebCore/platform concept,
so this just updates the APIs and implementations to use that instead.
Refactor only, no new tests.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
Source/WebKit/chromium:
Updates chromium implementation of GraphicsContext3D for API change and removes a bunch of unnecessary
#includes.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 02:09:16 +0000 (02:09 +0000)]
[EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
Reviewed by Chang Shu.
.:
Add dependency check for e_ukit package which is in the e_dbus library.
* Source/cmake/FindEFL.cmake:
Source/WebKit:
Add e_ukit library and include directory to get battery status of device.
* PlatformEfl.cmake:
Source/WebKit/efl:
The set of e_dbus libraries, e_ukit library in particular, enables to support all types of battery status events (e.g., charging, chargingTime, dischargingTime, level).
* WebCoreSupport/BatteryClientEfl.cpp:
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
* WebCoreSupport/BatteryClientEfl.h:
(WebCore::BatteryClientEfl::batteryStatus):
(BatteryClientEfl):
Tools:
Add e_dbus libraries to jhbuild's modules list.
* efl/jhbuild.modules:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Thu, 17 May 2012 01:36:11 +0000 (01:36 +0000)]
SerializedScriptValue: lazy initialization of static nullValue not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=70833
Reviewed by Kentaro Hara.
Remove unsafe lazy initialization of static |null| SSV. None of the callers
appeared to be in performance-critical areas - most were preparing an event to
be dispatched to script - so no per-call-site caching was added.
No new tests - no functional changes.
* bindings/js/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
* bindings/js/SerializedScriptValue.h: Return via PassRefPtr.
* bindings/v8/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
* bindings/v8/SerializedScriptValue.h: Return via PassRefPtr.
(SerializedScriptValue):
* dom/Document.cpp:
(WebCore::Document::statePopped): Change to PassRefPtr to maintain refcount.
* dom/Document.h:
(Document):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 17 May 2012 01:31:14 +0000 (01:31 +0000)]
CachedImage does not clear the ImageObserver pointer when dropping its Image ref
https://bugs.webkit.org/show_bug.cgi?id=86689
Reviewed by Eric Seidel.
Image instances keep a weak pointer to their ImageObserver, which may be null. CachedImage is an ImageObserver
and holds a RefPtr<Image> m_image. When CachedImage initializes its m_image to either an SVGImage or BitmapImage,
it sets itself as that Image's ImageObserver. However, CachedImage never clears the ImageObserver pointer, even
when dropping its reference to the Image. This means if other code holds a RefPtr<Image> there is no promise
that calls on that Image will be valid. This patch clears the CachedImage::m_image's ImageObserver pointer
whenever the CachedImage drops its reference. Image already has null checks for its m_imageObserver so this is
always a safe operation.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::~CachedImage):
(WebCore::CachedImage::clear):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 01:28:22 +0000 (01:28 +0000)]
[V8] Fix a broken copyright of V8SVGElementCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=86569
Reviewed by Nate Chapin.
This patch just fixes a broken copyright of V8SVGElementCustom.cpp.
Blame changeset: r54153
No tests. No change in behavior.
* bindings/v8/custom/V8SVGElementCustom.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 01:19:31 +0000 (01:19 +0000)]
[V8] Pass Isolate to convertEventTargetToV8Object()
https://bugs.webkit.org/show_bug.cgi?id=86566
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to convertEventTargetToV8Object().
I made the 'isolate' argument optional, since
convertEventTargetToV8Object() can be called from the WebCore context.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 17 May 2012 01:17:46 +0000 (01:17 +0000)]
Correctly display malformed GIFs which specify bogus extension block
sizes.
https://bugs.webkit.org/show_bug.cgi?id=86531
Reviewed by James Robinson.
This was broken by r117333, which was an attempt to avoid memory errors
on GIFs that were malformed in a similar way. It turns out some GIFs
in the wild (i.e. "our LayoutTests directory") relied on some of the
effects of the old code. This refixes in a way that doesn't break
these.
No new tests, covered by existing tests.
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 17 May 2012 01:14:23 +0000 (01:14 +0000)]
AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/audioparam-summingjunction.html
* Modules/webaudio/AudioParam.cpp:
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.
(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.
(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.
LayoutTests:
* webaudio/audioparam-connect-audioratesignal.html:
* webaudio/audioparam-summingjunction-expected.txt: Added.
* webaudio/audioparam-summingjunction.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 00:46:10 +0000 (00:46 +0000)]
[V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper()
https://bugs.webkit.org/show_bug.cgi?id=86558
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to createV8HTMLWrapper() and createV8SVGWrapper().
Basically 'isolate' has been implemented as the last argument
but before 'forceNewObject' argument, because 'forceNewObject' is an optional
argument and omitted in most cases. Due to the convention,
this patch puts 'isolate' before 'forceNewObject'.
No tests. No change in behavior.
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 17 May 2012 00:30:35 +0000 (00:30 +0000)]
Move showStyle from CSSStyleDeclaration to StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=86675
Reviewed by Andreas Kling.
Moved the function. Also deleted CSSStyleDeclaration.cpp since it's no longer needed.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/CSSStyleDeclaration.cpp:
(WebCore):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
* css/StylePropertySet.cpp:
(WebCore):
(WebCore::StylePropertySet::showStyle):
* css/StylePropertySet.h:
(StylePropertySet):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 17 May 2012 00:28:28 +0000 (00:28 +0000)]
Fix the indexed database build for GTK+.
* GNUmakefile.list.am: Add missing files to the build.
* bindings/gobject/GNUmakefile.am: Be smarter about filtering out deactivating indexed database.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Always skip attributes that return indexed database types.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 17 May 2012 00:19:13 +0000 (00:19 +0000)]
Unreviewed gardening after r117339 (table baseline computation change).
* fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/
20110323: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-001-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-002a-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/
20110323/inline-table-003-expected.txt: Removed.
* platform/chromium-linux/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-linux/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-linux/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/iframe-expected.png:
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
* platform/chromium-mac/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/chromium-mac/editing/selection/iframe-expected.png:
* platform/chromium-mac/editing/selection/iframe-expected.txt: Added.
* platform/chromium-mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/chromium-win-vista/editing/selection: Removed.
* platform/chromium-win-vista/fast/css-generated-content: Added.
* platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-vista/fast/inline-block: Added.
* platform/chromium-win-vista/fast/inline-block/001-expected.png: Added.
* platform/chromium-win-xp/fast/css-generated-content: Added.
* platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Added.
* platform/chromium-win-xp/fast/inline-block: Added.
* platform/chromium-win-xp/fast/inline-block/001-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-001-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-001-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-002a-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-002a-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-003-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/inline-table-003-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-win/editing/selection/iframe-expected.png:
* platform/chromium-win/editing/selection/inline-table-expected.png:
* platform/chromium-win/editing/selection/table-caret-3-expected.png:
* platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/chromium-win/fast/inline-block/001-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 17 May 2012 00:09:07 +0000 (00:09 +0000)]
Animated GIFs in page cache get updated
https://bugs.webkit.org/show_bug.cgi?id=86668
<rdar://problem/
11395549>
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/loader/image-in-page-cache.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): When we are notified by the CachedImage that the image has
changed, we check to see if the document is in the page cache. If so, we should not be updating,
so we bail out early.
LayoutTests:
This test loads pages with subframes that display the same animated gif. When one of
the pages goes into the page cache, we want to make sure that we do not crash as a
side effect of the page's images getting updated.
* fast/loader/image-in-page-cache-expected.txt: Added.
* fast/loader/image-in-page-cache.html: Added.
* fast/loader/resources/animated-image-subframe.html: Added.
* fast/loader/resources/animated-image.html: Added.
* fast/loader/resources/animated-image2.html: Added.
* fast/loader/resources/animated-image3.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc