Father Chrysostomos [Sat, 11 Jun 2011 21:44:32 +0000 (14:44 -0700)]
[perl #90130] Allow CORE::* without feature.pm
This commit allows feature.pm-enabled keywords to work with CORE::*
even outside the scope of ‘use feature’.
Father Chrysostomos [Sat, 11 Jun 2011 21:11:35 +0000 (14:11 -0700)]
Correct file references in switch.t
Father Chrysostomos [Sat, 11 Jun 2011 20:40:59 +0000 (13:40 -0700)]
Remove TODO markers from Devel::Peek tests
These all pass now as of commit
b56985536ef7.
Father Chrysostomos [Sat, 11 Jun 2011 20:22:45 +0000 (13:22 -0700)]
Remove x bit from rt-16221.t
Father Chrysostomos [Sat, 11 Jun 2011 20:21:49 +0000 (13:21 -0700)]
Increase Math::BigInt’s version
Father Chrysostomos [Sat, 11 Jun 2011 20:20:39 +0000 (13:20 -0700)]
Increase Math::BigFloat’s version
Ton Hospel [Sat, 11 Jun 2011 19:28:00 +0000 (12:28 -0700)]
[perl #85026] Iterate hashes by hand during do_sv_dump
A further note: while debugging this issue it was annoying that
Devel::Peek::Dump doesb't actually dump the HASH elements when an
iterator is active. Also added is a patch that does the iteration to
dump the HASH contents by iterating over it by hand (not disturbing
any active iterator). With that it also doesn't activate hash magic
during iteration, which I think is a feature
Father Chrysostomos [Sat, 11 Jun 2011 19:22:52 +0000 (12:22 -0700)]
Revert "Perl_do_sv_dump: alert when skipping elements"
This reverts commit
002beaef76a1595af2e39ffd4cd55c595bd6c271.
I am about to apply the manual-iteration patch from ticket #85026.
It conflicts with
002beaef, but it also renders
002beaef unnecessary.
Salvador Fandino [Sat, 11 Jun 2011 19:20:56 +0000 (12:20 -0700)]
allow features inside interactive debugger
Father Chrysostomos [Sat, 11 Jun 2011 19:26:35 +0000 (12:26 -0700)]
Add dist/Math-BigInt/t/rt-16221.t to MANIFEST
Peter John Acklam [Mon, 7 Mar 2011 10:45:38 +0000 (11:45 +0100)]
Fix Math::BigFloat->numify().
Math::BigFloat->numify() shall, according to the documentation and to be
consistent with Math::BigInt->numify() and Math::BigRat->numify(),
return a Perl scalar number, not a string.
- dist/Math-BigInt/lib/Math/BigFloat.pm:
- Fix objectify().
- dist/Math-BigInt/t/bigfltpm.inc:
- Remove no longer relevant tests.
- Modify existing tests and add new tests to verify correct behaviour.
This fix closes RT #66732.
Peter John Acklam [Mon, 7 Mar 2011 10:45:38 +0000 (11:45 +0100)]
Fix objectify()'s handling of "foreign objects".
- Fix handling of "foreign objects" so they are converted to the
appropriate class (Math::BigInt or Math::BigFloat).
- Avoid code duplication by using only one loop.
- Loop over indexes rather than array elements to make code cleaner.
- Fix incorrect code comments, add more code comments and clearify
existing ones.
- Correct handling of undefs to make the code consistent. objectify()
gave different output when the initial "shortcut" was removed.
- Add test file verifying that RT#16221 is fixed.
This fix closes RT #16221 and RT #52124. This patch supersedes Perl #86146.
Peter John Acklam [Mon, 7 Mar 2011 10:45:38 +0000 (11:45 +0100)]
Add sign function bsgn() as a complement to babs().
This is the standard mathematical signum function. It sets the
invocand to -1, 0, or 1, if it is real, and NaN otherwise.
Documentation and tests are included.
Father Chrysostomos [Fri, 13 May 2011 15:32:24 +0000 (08:32 -0700)]
Remove another bug workaround
Father Chrysostomos [Fri, 13 May 2011 15:31:16 +0000 (08:31 -0700)]
Remove workaround for fixed bug
Father Chrysostomos [Fri, 13 May 2011 15:30:50 +0000 (08:30 -0700)]
Revert "Revert "Make untie check the FAKE flag on globs""
This reverts commit
84b9ac853508aaff52254b6cf2b95a2a6783ff00.
Father Chrysostomos [Fri, 13 May 2011 15:30:25 +0000 (08:30 -0700)]
Revert "Revert "[perl #77688] tie $scalar can tie a handle""
This reverts commit
7850f4d6b732ab5f426cd3bcd9757c70a46cfda1.
Father Chrysostomos [Fri, 13 May 2011 15:29:42 +0000 (08:29 -0700)]
Revert "Revert "[perl #77496] tied gets scalars and globs confused""
This reverts commit
b029825916bf29623e00b45fa4226fab0d52d217.
Father Chrysostomos [Fri, 13 May 2011 15:24:16 +0000 (08:24 -0700)]
Revert ‘Deprecate tie $handle without *’
This reverts commit
7c7df8124bbdd7a0091f8ed82589548c8182f624,
except for the perldiag entry, which we still need for splain’s sake.
Nicholas Clark [Sat, 11 Jun 2011 17:21:01 +0000 (19:21 +0200)]
Add Porting/make_modlib_cpan.pl to MANIFEST.
Also -x it, as it doesn't have a suitable #! line, and its peers are all -x.
Karl Williamson [Wed, 4 May 2011 15:03:43 +0000 (09:03 -0600)]
regexec.c: Remvove unnecessary special handling for \xDF
regcomp.c has been changed, so the case that this handled no longer
comes up.
Craig A. Berry [Sat, 11 Jun 2011 16:25:30 +0000 (11:25 -0500)]
Typo in VMS-specific realclean target from
6f83ef0e5a45c465f83de3304c5818ba44492250.
David Golden [Sat, 11 Jun 2011 16:24:57 +0000 (12:24 -0400)]
Added Alan Haggai Alavi to AUTHORS
Alan Haggai Alavi [Sat, 11 Jun 2011 15:14:48 +0000 (20:44 +0530)]
perlvar.pod: fixed typo
Signed-off-by: David Golden <dagolden@cpan.org>
Nicholas Clark [Sun, 15 May 2011 16:20:42 +0000 (17:20 +0100)]
Correct errors in the use of multiple targets, which could break parallel make.
This was fixed in Makefile.SH in commit
0f13ebd5d71f8177.
Nicholas Clark [Sun, 15 May 2011 15:33:02 +0000 (16:33 +0100)]
Sort magic and magic vtable names in files generated by mg_vtable.pl
Magic is sorted case insensitively, with upper case before lower case.
vtable names are all lowercase letters.
Nicholas Clark [Sun, 15 May 2011 15:25:34 +0000 (16:25 +0100)]
Generate magic_names in dump.c using mg_vtable.pl.
Nicholas Clark [Sun, 15 May 2011 14:53:08 +0000 (15:53 +0100)]
Generate the PERL_MAGIC_* defines using mg_vtable.pl.
Nicholas Clark [Sun, 15 May 2011 13:45:53 +0000 (14:45 +0100)]
In PL_magic_data flag whether magic can be added to a readonly value.
Use this to simplify the logic in Perl_sv_magic().
This introduces a small change of behaviour for error cases involving unknown
magic types. Previously, if Perl_sv_magic() was passed a magic type unknown to
it, it would
1: Croak "Modification of a read-only value attempted" if read only
2: Return without error if the SV happened to already have this magic
3: otherwise croak "Don't know how to handle magic of type \\%o"
Now it will always croak "Don't know how to handle magic of type \\%o", even
on read only values, or SVs which already have the unknown magic type.
Nicholas Clark [Sun, 15 May 2011 12:54:19 +0000 (13:54 +0100)]
Store a flag for container/value magic in PL_magic_data.
Use this to replace S_is_container_magic() in mg.c with a direct lookup.
Nicholas Clark [Sun, 15 May 2011 12:21:09 +0000 (13:21 +0100)]
Create a lookup table for magic vtables from magic type, PL_magic_data.
Use it to eliminate the large switch statement in Perl_sv_magic().
As the table needs to be keyed on magic type, which is expressed as C character
constants, the order depends on the compiler's character set. Frustratingly,
EBCDIC variants don't agree on the code points for '~' and ']', which we use
here. Instead of having (at least) 4 tables, get the local runtime to sort the
table for us. Hence the regen script writes out the (unsorted) mg_raw.h, which
generate_uudmap sorts to generate mg_data.h
Nicholas Clark [Sun, 15 May 2011 11:02:28 +0000 (12:02 +0100)]
Refactor generate_uudmap.c to use a helper function to output init blocks.
In future, this will allow it to generate other output formats without
duplicating code.
Nicholas Clark [Sat, 14 May 2011 11:26:37 +0000 (12:26 +0100)]
Provide the names of the magic vtables in PL_magic_vtable_names[].
As it's a 1 to 1 mapping with the vtables in PL_magic_vtables[], refactor
Perl_do_magic_dump() to index into it directly to find the name for an
arbitrary mg_virtual, avoiding a long switch statement.
Nicholas Clark [Sat, 14 May 2011 08:41:18 +0000 (09:41 +0100)]
Replace references to PL_vtbl_{bm,fm} in the code with PL_vtbl_regexp.
Also, in Perl_sv_magic() merge the case for PERL_MAGIC_dbfile with the others
that return a NULL vtable.
Nicholas Clark [Sat, 14 May 2011 08:16:30 +0000 (09:16 +0100)]
PL_vtbl_{bm,fm} can be aliases to PL_vtbl_regexp, instead of copies.
They became copies in
488344d27a84a21a, which merged Perl_magic_setbm() and
Perl_magic_setfm() into Perl_magic_setregexp().
Nicholas Clark [Fri, 13 May 2011 20:21:49 +0000 (21:21 +0100)]
Refactor Perl_get_vtbl() to a small array lookup from a large switch statement.
Provide magic_vtable_max, the number of elements in PL_magic_vtables[].
Nicholas Clark [Fri, 13 May 2011 20:06:29 +0000 (21:06 +0100)]
Tests for Perl_get_vtbl()
Nicholas Clark [Fri, 13 May 2011 19:24:34 +0000 (20:24 +0100)]
Replace PL_vtbl_* with an array PL_magic_vtables.
Define each PL_vtbl_* name as a macro which expands to the correct array
element. Using a single array instead of multiple named variables will allow
the simplification of various pieces of code.
Nicholas Clark [Fri, 13 May 2011 17:02:08 +0000 (18:02 +0100)]
Generate the enum for want_vtbl_* with regen/mg_vtable.pl
Nicholas Clark [Fri, 13 May 2011 16:29:09 +0000 (17:29 +0100)]
Remove want_vtbl_{glob,symtab}, which aren't used and don't do anything useful.
Nothing visible on CPAN uses either. Passing either to Perl_get_vtbl() will
currently return NULL (as a runtime error, rather than a compile time error).
The case for want_vtbl_glob was removed from the switch in Perl_get_vtbl() in
c0c446747ad6c5bd (which eliminated the need for magic on typeglobs).
want_vtbl_symtab was added to the enum in perl.h with
8d2f45362e368d7d, but
no code was added to Perl_get_vtbl() as there is no corresponding vtable.
Nicholas Clark [Fri, 13 May 2011 15:50:51 +0000 (16:50 +0100)]
Move the work of MGVTBL_SET() from the C pre-processor to mg_vtable.pl
Generating mg_vtable.h with MGVTBL_SET() effectively pre-expanded makes things
clearer. This eliminates use of the macro MGVTBL_SET(), which can be deleted
as nothing outside the core is relying on it.
Nicholas Clark [Fri, 13 May 2011 15:35:59 +0000 (16:35 +0100)]
Move the cast for a magic vtable with const get into mg_vtable.h
Putting the cast inside the initialiser (the only initialiser using it)
eliminates use of the macro MGVTBL_SET_CONST_MAGIC_GET(), which can be deleted
as nothing outside the core is relying on it.
Nicholas Clark [Fri, 13 May 2011 13:17:22 +0000 (14:17 +0100)]
Generate the definitions for magic vtables from data in a regen script.
Previously perl.h contained a long section of MGVTBL_SET() macros declaring
the core's various magic vtables. Convert the information into data structures
in a new script regen/mg_table.pl, and use this to generate a new file
mg_vtable.h, included by perl.h
This is the first step in reducing the number of places that data relating to
magic vtables is declared (and has to be kept in sync), and will allow more
flexibility in parts of the core's implementation.
Nicholas Clark [Fri, 13 May 2011 11:36:44 +0000 (12:36 +0100)]
Abolish PL_vtbl_sig. It's been all 0s since it was added in 5.0 alpha 2.
Magic with a NULL vtable is equivalent to magic with a vtable of all 0s.
On CPAN, only Apache::Peek's code for 5.005 is referencing it.
Nicholas Clark [Fri, 13 May 2011 10:39:18 +0000 (11:39 +0100)]
Don't even declare PL_vtbl_sigelem under -DPERL_MICRO
This turns out to be a simpler solution than
9ba75e3cf905a6e6.
Nicholas Clark [Tue, 24 May 2011 14:11:53 +0000 (15:11 +0100)]
Store FBMs in PVMGs, instead of GVs.
This should reduce the complexity of code dealing with GVs, as they no longer
try to play several different incompatible roles.
(As suggested by Ben Morrow. However, it didn't turn out to be as
straightforward as one might have hoped).
Nicholas Clark [Wed, 18 May 2011 10:45:22 +0000 (11:45 +0100)]
Store the BM table in mg_ptr instead of after SvCUR().
Previously the 256 byte Boyer-Moore table was stored in the buffer of SvPVX()
after the raw string by extending the buffer.
Given that the scalar is alway upgraded to add PERL_MAGIC_bm magic, to clear
the table and other flags, there's no extra memory cost in using mg_ptr in the
MAGIC struct to point directly to the table.
I believe that this removes the last place in the core that stores data beyond
SvCUR().
Nicholas Clark [Wed, 18 May 2011 09:49:43 +0000 (10:49 +0100)]
Exit early from Perl_fbm_compile() if the SV is already "compiled".
I believe that this can only happen if a constant subroutine is used more than
once as the second argument to index.
Nicholas Clark [Tue, 17 May 2011 12:16:57 +0000 (13:16 +0100)]
In Perl_fbm_instr(), use a switch() statement for the special case code.
Previously the special-case code for lengths 0, 1 and 2 was in a nested set
of if() statements, which was slightly cryptic to read.
Nicholas Clark [Tue, 17 May 2011 11:28:36 +0000 (12:28 +0100)]
In Perl_fbm_compile(), use STRLEN instead of U32 to calculate BmPREVIOUS().
This should fix a theoretical bug on strings longer than 2**32 bytes where the
byte referenced by BmRARE() is at an offset beyond 2**32. I'm not sure how to
test this, as I think to trigger it one would need to have one of
a: the second argument to index as a string literal, longer than 2**32 bytes
b: a fixed string in a regex, longer than 2**32 bytes
Nicholas Clark [Tue, 17 May 2011 09:26:49 +0000 (10:26 +0100)]
Abolish xbm_rare. Move BmUSEFUL() to union _xnvu and BmPREVIOUS() to the UV.
This reduces the complexity of the union declarations in sv.h.
As B.xs is accessing the structures/unions directly, instead of using the
macros, it needs a patch too.
Nicholas Clark [Mon, 9 May 2011 15:53:28 +0000 (16:53 +0100)]
Use SvTAIL() instead of BmFLAGS(). The core no longer uses BmFLAGS().
Nicholas Clark [Mon, 9 May 2011 11:07:17 +0000 (12:07 +0100)]
Emulate the value of BmFLAGS() using SvTAIL().
Don't set BmFLAGS() in Perl_fbm_compile()
Originally fbm_compile() had an I32 flags argument, which seems to have been
part of case folding/locale improvements.
bbce6d69784bf43b removed this.
SvTAIL() was only used in once place until
c277df42229d99fe.
2779dcf1a3ceec16
added the U32 flags argument to fbm_compile(), not used until
cf93c79d660ae36c.
That commit also added FBMcf_TAIL and FBMcf_TAIL{z,Z,DOLLAR} but didn't use the
last three. Additionally, it stored the BmFLAGS as part of the compiled table:
+ table[-1] = flags; /* Not used yet */
f722798beaa43749 added FBMcf_TAIL_DOLLARM, renumbered FBMcf_TAIL{z,Z,DOLLAR},
but still didn't use anything other than FBMcf_TAIL.
The core, nothing on CPAN, and nothing visible to Google codesearch, has ever
used the 4 specialist flags. The only use is 0 or FBMcf_TAIL, which is in
lockstep with SvTAIL() of 0 or non-0.
Nicholas Clark [Tue, 24 May 2011 10:17:13 +0000 (11:17 +0100)]
Use 0x40008000 in SvFLAGS() for SVpad_NAME, not 0x40000000
This eliminates potential confusion between SVpad_NAME and SVpbm_VALID.
Nicholas Clark [Tue, 24 May 2011 09:59:01 +0000 (10:59 +0100)]
Test that SvFLAGS() & SVpad_NAME is SVpad_NAME, not just non-zero.
In Perl_find_rundefsv() and PAD_COMPNAME_FLAGS_isOUR(), replace longhand flags
test with SvPAD_OUR().
Nicholas Clark [Mon, 23 May 2011 20:52:40 +0000 (21:52 +0100)]
Don't fbm_compile() studied scalars, to give more flexibility in SV flag usage.
No real-world code would ever end up using a studied scalar as a compile-time
second argument to index, so this isn't a real pessimisation.
Nicholas Clark [Mon, 23 May 2011 20:36:06 +0000 (21:36 +0100)]
Don't allow study on an FBM scalar, to give more flexibility in SV flag usage.
No real-world code would ever end up studying an FBM scalar, so this isn't a
real pessimisation.
Nicholas Clark [Mon, 23 May 2011 20:18:51 +0000 (21:18 +0100)]
Test dumping studied scalars.
Nicholas Clark [Mon, 23 May 2011 20:01:37 +0000 (21:01 +0100)]
Perl_do_sv_dump() shouldn't show "IV" for a FBM, as it's not valid.
The memory is used for part of the FBM state.
Tidy the order of conditions in the if() determining whether the IV/UV should
be shown.
Nicholas Clark [Mon, 23 May 2011 17:14:45 +0000 (18:14 +0100)]
In Perl_sv_2[inu]v_flags(), use the non-caching code whenever SvVALID() is true
Previous the non-caching code was only used when SvVALID() was true on a PVGV.
However, PVLVs can also perform all the roles of a PVGV, so could conceivably
be acting as FBMs. As it's safe to test SvVALID() on any scalar SV, do so, as
the compiler can combine the flag test for SvVALID() with that for
SvGMAGICAL(), producing tighter object code.
Nicholas Clark [Tue, 7 Jun 2011 11:17:40 +0000 (13:17 +0200)]
In IPC::Open3, inline xfork() and xclose_on_exec(), and delete xpipe_anon().
All three functions are private, undocumented, unexported, and un(ab)used by
any code on CPAN. The first two are used in only one place, so inline them.
The third was added in
8960aa876f446ad2, without adding any code which used it,
and it has remained unused ever since.
Nicholas Clark [Tue, 7 Jun 2011 11:00:33 +0000 (13:00 +0200)]
In IPC::Open3::_open(), refactor the DO_SPAWN code to loop over @handles.
Nicholas Clark [Tue, 7 Jun 2011 10:37:28 +0000 (12:37 +0200)]
In IPC::Open3::_open(), refactor the fork/exec code to loop over @handles.
Nicholas Clark [Mon, 6 Jun 2011 18:45:13 +0000 (20:45 +0200)]
In IPC::Open3::_open(), refactor the common code into loops over @handles.
As fh_is_fd() is now used in only one location, inline it. (This function isn't
exported, isn't documented, and isn't (ab)used by anything on CPAN.)
Nicholas Clark [Mon, 6 Jun 2011 17:48:03 +0000 (19:48 +0200)]
In IPC::Open3::_open(), switch from 'r' and 'w' to '<' and '>'.
IO::Handle accepts either, but open only accepts the latter.
In spawn_with_handles(), hoist the C<require Fcntl> into the only block that
needs it - this avoids loading Fcntl on Win32.
Nicholas Clark [Mon, 6 Jun 2011 17:19:29 +0000 (19:19 +0200)]
Use $handles[2]{dup_of_out} for the special case code for shared STD{OUT,ERR}.
As C<dup_of_out> is never set on the other two members of @handles, this will
allow code simplification.
Nicholas Clark [Mon, 6 Jun 2011 16:26:35 +0000 (18:26 +0200)]
In IPC::Open3::_open3(), move $kid_{rdr,wtr,err} to @handles.
Switch to 3-arg open where code is changing.
Nicholas Clark [Mon, 6 Jun 2011 16:02:33 +0000 (18:02 +0200)]
In IPC::Open3::_open3(), move $dup_{wtr,rdr,err} to @handles.
Nicholas Clark [Mon, 6 Jun 2011 15:11:35 +0000 (17:11 +0200)]
In IPC::Open3::_open3(), move $dad_{wtr,rdr,err} to @handles.
Switch to 3-arg open where code is changing. Additionally, @_ can now be used
in place of @cmd.
Nicholas Clark [Mon, 6 Jun 2011 13:02:22 +0000 (15:02 +0200)]
Move the table describing file handles near to the top of IPC::Open::open3().
Also convert fileno BAREWORD to fileno \*BAREWORD. These will aid future
refactoring.
Nicholas Clark [Mon, 6 Jun 2011 12:43:56 +0000 (14:43 +0200)]
Move the autovivification emulation code to the top of IPC::Open3::_open3().
This avoids having to re-assign to the scalars $dad_wtr and $dad_rdr.
Nicholas Clark [Mon, 6 Jun 2011 12:29:19 +0000 (14:29 +0200)]
Refactor IPC::Open3::_open3() to find the caller's package itself.
Previously it was passed in as a parameter by IPC::Open2::open2() and
IPC::Open3::open3(), each of which used C<calller> to find it. Move the use of
caller to one place.
It would also be possible to use C<caller> to eliminate the first parameter to
_open3(), but this would add more code than it removes, so doesn't seem wise.
Nicholas Clark [Sun, 5 Jun 2011 17:47:32 +0000 (19:47 +0200)]
IPC::Open3::open3() couldn't duplicate numeric file descriptors on Windows.
Nicholas Clark [Sun, 5 Jun 2011 14:31:02 +0000 (16:31 +0200)]
Avoid an uninitialized hash key in IPC::Open::spawn_with_handles().
Nicholas Clark [Sun, 5 Jun 2011 13:58:39 +0000 (15:58 +0200)]
IPC::Open3::open3() shouldn't fail if any of *STD{IN,OUT,ERR} are localized.
Previously it would fail on Win32, because spawn_with_handles() would attempt
to duplicate all three, ignoring failures at this point, but then report
failure to close any as a fatal error, even if this was because the earlier
dup-ing had failed.
Also avoid a warning in the *nix code path in open3() if STDERR is localized
(and hence fileno STDERR is undefined).
Nicholas Clark [Sun, 5 Jun 2011 13:01:13 +0000 (15:01 +0200)]
Add debug code to test IPC::Open3::spawn_with_handles() on *nix.
This allows testing of the (normally) Win32 and OS/2 specific code paths in
IPC::Open3::open3().
Nicholas Clark [Mon, 6 Jun 2011 20:45:46 +0000 (22:45 +0200)]
In IPC::Open3::_open(), use 3 argument open to avoid a special case for STDERR.
The code for STDIN and STDOUT never ends up needing to duplicate a reference.
The code for STDERR can, because of the earlier special case code to save
STDOUT. It was special-cased to use fileno in commit
8b3e92c60014b4e7, in 1998.
This was before 3 argument open. With 3 argument open the special case can be
avoided.
Nicholas Clark [Mon, 6 Jun 2011 14:16:37 +0000 (16:16 +0200)]
Generalise IPC::Open3::xopen() to $n-argument open.
Previously it could only perform 2 argument open.
Nicholas Clark [Sun, 5 Jun 2011 15:06:14 +0000 (17:06 +0200)]
Simplify the test for IPC::Open bug RT #72016.
The original bug was a request that errors be reported in the parent process,
with a TODO test, and then a patch that added the feature for the !DO_SPAWN
case, and removed the TODO. The *implication* of the bug report and the way the
original test was only TODO for the !DO_SPAWN case was that errors were
reported inconsistently between the two code paths of open3().
However, this is not the case - the DO_SPAWN path through open3() return a
(pseudo) PID (and no error) when asked to run a non-existent program. Hence
there is now a feature discrepancy between the alternative implementations,
which feels like a bug that should (ultimately) be addressed.
The original test could have expressed that more directly with one code path
and a TODO. The refactoring of
bd29e8c290c68f4f failed to spot this, and
introduced new logic errors in the DO_SPAWN path - waitpid() should not be
called if $@ is set.
Set $pid outside the eval {} - this makes sure it is (re)set to undef if the
eval fails, instead of holding its previous (now bogus) value.
Father Chrysostomos [Fri, 10 Jun 2011 20:31:43 +0000 (13:31 -0700)]
Revert "Regenerate known_pod_issues.dat"
This reverts commit
a15bfc9e2304470503968445191dc51fa75f3b82.
I was two hours too late. Commit
2592f3b8 solved this before I
pushed that change.
Leon Brocard [Fri, 10 Jun 2011 20:28:21 +0000 (21:28 +0100)]
Merge branch 'blead' of ssh://perl5.git.perl.org/gitroot/perl into blead
Leon Brocard [Fri, 10 Jun 2011 20:28:08 +0000 (21:28 +0100)]
Update the list of CPAN mirrors in pod/perlmodlib.PL
Father Chrysostomos [Fri, 10 Jun 2011 20:27:21 +0000 (13:27 -0700)]
Correct example commit in release_managers_guide.pod; add example
The
8891dd8d commit mentioned in the perlNNNdelta section is actually
an example of a perl version bump. So I’ve copied it to that section
and replaced the commit id in the perlNNNdelta section with dd885b5,
which *is* a perlNNNdelta TOC update.
Father Chrysostomos [Fri, 10 Jun 2011 20:20:23 +0000 (13:20 -0700)]
Regenerate known_pod_issues.dat
I think there’s a bug in podchecker, as it seems to be counting octets
instead of characters in README.tw.
Leon Brocard [Fri, 10 Jun 2011 20:27:29 +0000 (21:27 +0100)]
Add program which generates the list of registered CPAN sites in perlmodlib.PL
Robin Barker [Fri, 10 Jun 2011 05:47:54 +0000 (06:47 +0100)]
unused variable tmpgv
gcc reports an unused variable 'tmpgv', this was left
behind by commit
0e21945565eb4664d843bb819fb032cedee4d5a6.
Deleting the declaration has no consequences.
Signed-off-by: David Golden <dagolden@cpan.org>
David Golden [Fri, 10 Jun 2011 15:55:56 +0000 (11:55 -0400)]
Show diagnostic link format in perldelta template
David Golden [Fri, 10 Jun 2011 17:54:35 +0000 (13:54 -0400)]
podcheck.t: decode verbatim paragraphs before checking length
David Golden [Fri, 10 Jun 2011 16:59:26 +0000 (12:59 -0400)]
Partial perldelta update through 9603df1
Additional documentation related entries have not yet been added
David Golden [Fri, 10 Jun 2011 15:53:16 +0000 (11:53 -0400)]
git-deltatool: show progress only for interactive modes
Father Chrysostomos [Fri, 10 Jun 2011 17:54:20 +0000 (10:54 -0700)]
Suppress proto warning from attrs.t
attributes::get was being called before attributes.pm was loaded.
Why this did not warn before I know not. Maybe that’s another bug....
Father Chrysostomos [Fri, 10 Jun 2011 16:48:06 +0000 (09:48 -0700)]
perldata: Link directly to $;
Father Chrysostomos [Fri, 10 Jun 2011 16:46:37 +0000 (09:46 -0700)]
Add another address for Ian Goodacre
Ian Goodacre [Fri, 10 Jun 2011 09:47:38 +0000 (21:47 +1200)]
Document multi-dimensional array emulation.
Jesse Vincent [Fri, 10 Jun 2011 14:36:41 +0000 (10:36 -0400)]
We'll no longer add RCs to perlhist.pod
Chia-liang Kao [Fri, 10 Jun 2011 11:36:38 +0000 (19:36 +0800)]
Update irc and tw mongers links.
Chia-liang Kao [Fri, 10 Jun 2011 11:31:21 +0000 (19:31 +0800)]
convert README.tw to utf-8
David Mitchell [Fri, 10 Jun 2011 13:07:28 +0000 (14:07 +0100)]
Benchmart.t: improved diagnostics
use diag() to show absolutely all variables on failing the
notorious test 15. Maybe this will help nail it one day...
Leon Brocard [Fri, 10 Jun 2011 09:34:41 +0000 (10:34 +0100)]
Update Porting/core-cpan-diff to use HTTP::Tiny
Father Chrysostomos [Fri, 10 Jun 2011 04:24:01 +0000 (21:24 -0700)]
Scalar keys assignment through lvalue subs
This used not to work:
sub foo :lvalue { keys %wallet }
foo = 37;
Now it does. It was just a matter of following the right code path in
op_lvalue when the parent op is a leavesublv instead of a sassign.