mmassi@chromium.org [Wed, 19 Sep 2012 12:48:49 +0000 (12:48 +0000)]
Fixed minus zero test (fixes v8:2133).
BUG=v8:2133
Review URL: https://chromiumcodereview.appspot.com/
10937013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12548
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 19 Sep 2012 11:52:33 +0000 (11:52 +0000)]
Fix setting array length to zero for slow elements.
R=verwaest@chromium.org
BUG=chromium:146910
TEST=mjsunit/regress/regress-crbug-146910
Review URL: https://codereview.chromium.org/
10937026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12547
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 19 Sep 2012 11:09:07 +0000 (11:09 +0000)]
Remove whitespace
Review URL: https://chromiumcodereview.appspot.com/
10949018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12546
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 19 Sep 2012 10:06:02 +0000 (10:06 +0000)]
Use NumberOfOwnDescriptors/EnumLength for counting properties on fast objects.
Also split CNLT into small functions.
Review URL: https://chromiumcodereview.appspot.com/
10950023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12545
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 19 Sep 2012 09:54:10 +0000 (09:54 +0000)]
Reduce space usage of simple transitions and descriptors holders.
Review URL: https://chromiumcodereview.appspot.com/
10915260
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12544
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 19 Sep 2012 08:13:46 +0000 (08:13 +0000)]
Fix lost arguments dropping in HLeaveInlined.
This fixes HleaveInlined to correctly drop pushed arguments on all code
paths and addresses a corner case where the arguments stack height
mismatched at an OSR entry point.
R=jkummerow@chromium.org
BUG=chromium:150545
TEST=mjsunit/regress/regress-crbug-150545
Review URL: https://codereview.chromium.org/
10938016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12543
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 19 Sep 2012 08:08:02 +0000 (08:08 +0000)]
Clear EnumIndices as well on CNLT.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10944011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12542
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 18 Sep 2012 13:52:18 +0000 (13:52 +0000)]
MIPS: Do not go to slow mode and back to fast in initializer blocks.
Port r12534 (
4acfb92e)
BUG=
TEST=
Committed: https://code.google.com/p/v8/source/detail?r=12539
Review URL: https://chromiumcodereview.appspot.com/
10905313
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12541
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 18 Sep 2012 13:51:01 +0000 (13:51 +0000)]
Revert due to invalid description / CL combination.
Revert "MIPS: Do not go to slow mode and back to fast in initializer blocks."
This reverts commit
9b05931ec130e831f7496aed6f7ae32e8f2da934.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10939018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12540
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 18 Sep 2012 13:40:24 +0000 (13:40 +0000)]
MIPS: Do not go to slow mode and back to fast in initializer blocks.
Port r12534 (
4acfb92e)
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10905313
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12539
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 18 Sep 2012 13:25:12 +0000 (13:25 +0000)]
Preallocate space in descriptor arrays.
Review URL: https://chromiumcodereview.appspot.com/
10916336
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12538
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 18 Sep 2012 11:06:05 +0000 (11:06 +0000)]
Fix printing of HCallKnownGlobal.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
10941009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12537
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 18 Sep 2012 08:04:31 +0000 (08:04 +0000)]
Improve the assembly code for power function with integer exponential on x64
The change removes one unused multiply and reschedules
the shift, multiply and jump instructions to reduce
stall. Experiment shows it improve about 20% performance
on x64 for exponetials from about 100 to 2000.
Review URL: https://chromiumcodereview.appspot.com/
10939013
Patch from Xi Qian <xi.qian@intel.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12535
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 17 Sep 2012 17:18:27 +0000 (17:18 +0000)]
Do not go to slow mode and back to fast in initializer blocks.
Review URL: https://chromiumcodereview.appspot.com/
10905308
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12534
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 17 Sep 2012 14:50:51 +0000 (14:50 +0000)]
Add jsfunfuzz to gitignore file.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
10918273
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12532
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 17 Sep 2012 14:39:10 +0000 (14:39 +0000)]
Fix casting error for receiver of interceptors.
This fixes a casting error that occured when the receiver of a missed
or uninitialized CallIC is a Smi and there is an interceptor installed
on the prototype chain.
R=yangguo@chromium.org
BUG=chromium:149912
TEST=cctest/test-api/Regress149912
Review URL: https://codereview.chromium.org/
10914317
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12531
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 17 Sep 2012 14:19:11 +0000 (14:19 +0000)]
Tentatively reenable previous failing test.
R=mstarzinger@chromium.org
BUG=v8:2261
Review URL: https://chromiumcodereview.appspot.com/
10907254
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12530
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 17 Sep 2012 13:21:59 +0000 (13:21 +0000)]
Change regress-2318 to trigger more quickly and reliably.
BUG=v8:2336
Review URL: https://chromiumcodereview.appspot.com/
10913294
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12529
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 17 Sep 2012 11:38:24 +0000 (11:38 +0000)]
Fix misplaced assert in heap.cc.
Bug=2336
Review URL: https://chromiumcodereview.appspot.com/
10911334
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12528
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Mon, 17 Sep 2012 10:54:26 +0000 (10:54 +0000)]
Consistently use named getters for Lithium operands on ARM.
Removed a dead Lithium instruction on the way.
Review URL: https://codereview.chromium.org/
10907234
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12527
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 17 Sep 2012 10:04:39 +0000 (10:04 +0000)]
Integrate map marking into static marking visitor.
This refactors the specialized marking of map contents to be done by the
static marking visitor shared between full and incremental marking. This
also fixes an issue where some maps weren't accounted for in the object
stats tracker. But more importantly, it simplifies the code base.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
10919294
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12526
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Mon, 17 Sep 2012 09:58:22 +0000 (09:58 +0000)]
Throw a more descriptive exception when blocking 'eval' via CSP.
BUG=140191
R=svenpanne@chromium.org,mkwst@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10837358
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12525
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 17 Sep 2012 07:56:15 +0000 (07:56 +0000)]
Fix build on OpenBSD/i386.
BUG=v8:1445
Review URL: https://chromiumcodereview.appspot.com/
10919314
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12522
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 17 Sep 2012 07:45:54 +0000 (07:45 +0000)]
Improve the assembly code for power function with integer exponential.
The change removes one unused multiply and reschedules
the shift, multiply and jump instructions to reduce
stall. Experiment shows it improve about 20% performance
on x86 for exponetials from about 100 to 2000.
Review URL: https://chromiumcodereview.appspot.com/
10916311
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12521
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 14 Sep 2012 16:13:23 +0000 (16:13 +0000)]
Let the embedder store arbitrary Values via Context::SetData
In WebKit, we would like to store a void* to a data structure that contains
lots of exciting per-context data. The current API restricts us to storing only
Strings, which is less useful.
I've also cleaned up the implementation of GetData to be less convoluted.
Review URL: https://codereview.chromium.org/
10907189
Patch from Adam Barth <abarth@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12520
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 14 Sep 2012 15:10:31 +0000 (15:10 +0000)]
Moving the WhitenessWitness back to DescriptorArray.
TransitionArrays never allocate while being created.
Review URL: https://chromiumcodereview.appspot.com/
10908237
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12519
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 14 Sep 2012 13:40:32 +0000 (13:40 +0000)]
Fix debugger's eval when close to stack overflow.
R=verwaest@chromium.org
BUG=v8:2318
Review URL: https://chromiumcodereview.appspot.com/
10914290
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12518
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 14 Sep 2012 13:37:41 +0000 (13:37 +0000)]
Only count the descriptor array if it's owned by the map.
Review URL: https://chromiumcodereview.appspot.com/
10918245
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12517
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 14 Sep 2012 13:31:11 +0000 (13:31 +0000)]
Add checks to live edit.
BUG=v8:2297
Review URL: https://chromiumcodereview.appspot.com/
10914262
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12515
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 14 Sep 2012 13:19:42 +0000 (13:19 +0000)]
Fix test failures on nosnap builder.
Review URL: https://chromiumcodereview.appspot.com/
10915277
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12513
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 14 Sep 2012 13:15:43 +0000 (13:15 +0000)]
CNLT with descriptors but no valid enum fields has to clear the EnumCache.
Review URL: https://chromiumcodereview.appspot.com/
10928204
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12512
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 14 Sep 2012 12:01:12 +0000 (12:01 +0000)]
Microoptimization to regexps.
Review URL: https://chromiumcodereview.appspot.com/
10917260
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12511
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 14 Sep 2012 11:55:49 +0000 (11:55 +0000)]
Consistently use named getters for Lithium operands on ia32.
With this CL we clearly distinguish two different views on Lithium
instructions: For register allocation, the actual instruction/operand
is irrelevant, so it has only an iterator/indexed view on the
instruction operands. All other places, most importantly code
generation, use named getters for the operands now, making it easy to
see where each one is used.
Review URL: https://codereview.chromium.org/
10919261
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12510
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 14 Sep 2012 11:48:31 +0000 (11:48 +0000)]
Fix compile errors on Win64.
Review URL: https://chromiumcodereview.appspot.com/
10913273
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12509
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 14 Sep 2012 11:46:01 +0000 (11:46 +0000)]
Consistently use named getters for Lithium operands on x64
Review URL: https://codereview.chromium.org/
10933087
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12508
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 14 Sep 2012 11:43:46 +0000 (11:43 +0000)]
Replace r12503. Explicitly check toString() for exception in d8's print().
R=jkummerow@chromium.org
BUG=v8:2317
Review URL: https://chromiumcodereview.appspot.com/
10911305
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12507
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 14 Sep 2012 11:38:45 +0000 (11:38 +0000)]
Switch on code compaction on incremental GCs.
Review URL: https://chromiumcodereview.appspot.com/
10928203
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12506
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 14 Sep 2012 11:16:56 +0000 (11:16 +0000)]
Refactoring of snapshots. This simplifies and improves
the speed of deserializing code. The current startup
time improvement for V8 is around 6%, but code deserialization
is speeded up disproportionately, and we will soon have more
code in the snapshot.
* Removed support for deserializing into large object space.
The regular pages are 1Mbyte now and that is plenty. This
is a big simplification.
* Instead of reserving space for the snapshot we actually
allocate it now. This removes some special casing from
the memory management and simplifies deserialization since
we are just bumping a pointer rather than calling the
normal allocation routines during deserialization.
* Record in the snapshot how much we need to boot up and
allocate it instead of just assuming that allocations in
a new VM will always be linear.
* In the snapshot we always address an object as a negative
offset from the current allocation point. We used to
sometimes address from the start of the deserialized data,
but this is less useful now that we have good support for
roots and repetitions in the deserialization data.
* Code objects were previously deserialized (like other
objects) by alternating raw data (deserialized with memcpy)
and pointers (to external references, other objects, etc.).
Now we deserialize code objects with a single memcpy,
followed by a series of skips and pointers that partially
overwrite the code we memcopied out of the snapshot.
The skips are sometimes merged into the following
instruction in the deserialization data to reduce dispatch
time.
* Integers in the snapshot were stored in a variable length
format that gives a compact representation for small positive
integers. This is still the case, but the new encoding can
be decoded without branches or conditional instructions,
which is faster on a modern CPU.
Review URL: https://chromiumcodereview.appspot.com/
10918067
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12505
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 14 Sep 2012 10:41:31 +0000 (10:41 +0000)]
Fix caching of optimized code for OSR.
This makes sure we do not share optimized code across closures that were
optimized using OSR (for a particular OSR entry AST id) even if caching
of optimized code kicks in.
R=danno@chromium.org
BUG=v8:2326
TEST=mjsunit/regress/regress-2326
Review URL: https://codereview.chromium.org/
10933088
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12504
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 14 Sep 2012 08:13:57 +0000 (08:13 +0000)]
Not mask exception thrown by toString in String::UtfValue etc.
R=jkummerow@chromium.org
BUG=v8:2317
Review URL: https://chromiumcodereview.appspot.com/
10917236
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12503
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 14 Sep 2012 07:44:28 +0000 (07:44 +0000)]
Skip version 3.13.8 and fast-forward to 3.14.0
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
10907230
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12502
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 14 Sep 2012 07:41:55 +0000 (07:41 +0000)]
Replace VFP by VFP2 in common.gypi
This fixes an omission in cl
10818026.
Patch by Nathan Rajlich.
Review URL: https://chromiumcodereview.appspot.com/
10913256
Patch from Bert Belder <bertbelder@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12501
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 13 Sep 2012 16:48:31 +0000 (16:48 +0000)]
Directly set the value in the descriptors pointer to avoid checks.
This is the only place from where we are allowed to modify the value of
the descriptors pointer.
Review URL: https://chromiumcodereview.appspot.com/
10905266
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12500
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 13 Sep 2012 15:06:15 +0000 (15:06 +0000)]
Fix printf formatting in test-compiler.
R=jkummerow@chromium.org
BUG=v8:2319
Review URL: https://chromiumcodereview.appspot.com/
10928182
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12499
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 13 Sep 2012 14:36:51 +0000 (14:36 +0000)]
Clear the EnumLength fields of maps that lose their enumeration cache.
Review URL: https://chromiumcodereview.appspot.com/
10905262
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12498
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 13 Sep 2012 09:36:56 +0000 (09:36 +0000)]
Fix API check for length of external arrays.
R=jkummerow@chromium.org
BUG=chromium:148896
TEST=cctest/test-api/ExternalArrayLimits
Review URL: https://codereview.chromium.org/
10914257
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12495
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Thu, 13 Sep 2012 08:52:55 +0000 (08:52 +0000)]
Ensure correct enumeration indices in the dict
BUG=chromium:148376
Review URL: https://chromiumcodereview.appspot.com/
10908216
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12494
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mmassi@chromium.org [Wed, 12 Sep 2012 17:00:25 +0000 (17:00 +0000)]
Fixed bounds check removal by restricting it to int32 indexes (and reenabled both ABCR and index dehoisting).
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10905232
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12493
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 12 Sep 2012 16:43:57 +0000 (16:43 +0000)]
Sharing of descriptor arrays.
This CL adds multiple things:
Transition arrays do not directly point at their descriptor array anymore, but rather do so via an indirect pointer (a JSGlobalPropertyCell).
An ownership bit is added to maps indicating whether it owns its own descriptor array or not.
Maps owning a descriptor array can pass on ownership if a transition from that map is generated; but only if the descriptor array stays exactly the same; or if a descriptor is added.
Maps that don't have ownership get ownership back if their direct child to which ownership was passed is cleared in ClearNonLiveTransitions.
To detect which descriptors in an array are valid, each map knows its own NumberOfOwnDescriptors. Since the descriptors are sorted in order of addition, if we search and find a descriptor with index bigger than this number, it is not valid for the given map.
We currently still build up an enumeration cache (although this may disappear). The enumeration cache is always built for the entire descriptor array, even if not all descriptors are owned by the map. Once a descriptor array has an enumeration cache for a given map; this invariant will always be true, even if the descriptor array was extended. The extended array will inherit the enumeration cache from the smaller descriptor array. If a map with more descriptors needs an enumeration cache, it's EnumLength will still be set to invalid, so it will have to recompute the enumeration cache. This new cache will also be valid for smaller maps since they have their own enumlength; and use this to loop over the cache. If the EnumLength is still invalid, but there is already a cache present that is big enough; we just initialize the EnumLength field for the map.
When we apply ClearNonLiveTransitions and descriptor ownership is passed back to a parent map, the descriptor array is trimmed in-place and resorted. At the same time, the enumeration cache is trimmed in-place.
Only transition arrays contain descriptor arrays. If we transition to a map and pass ownership of the descriptor array along, the child map will not store the descriptor array it owns. Rather its parent will keep the pointer. So for every leaf-map, we find the descriptor array by following the back pointer, reading out the transition array, and fetching the descriptor array from the JSGlobalPropertyCell. If a map has a transition array, we fetch it from there. If a map has undefined as its back-pointer and has no transition array; it is considered to have an empty descriptor array.
When we modify properties, we cannot share the descriptor array. To accommodate this, the child map will get its own transition array; even if there are not necessarily any transitions leaving from the child map. This is necessary since it's the only way to store its own descriptor array.
Review URL: https://chromiumcodereview.appspot.com/
10909007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12492
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 12 Sep 2012 15:26:43 +0000 (15:26 +0000)]
Correctly initialize regexp global cache.
R=ulan@chromium.org
BUG=148378
Review URL: https://chromiumcodereview.appspot.com/
10905239
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12491
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 12 Sep 2012 14:11:37 +0000 (14:11 +0000)]
Fix compilation issue in r12489.
R=svenpanne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10909190
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12490
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 12 Sep 2012 12:28:42 +0000 (12:28 +0000)]
Fix arguments object materialization during deopt.
This fixes materialization of arguments objects for strict mode functions during
deoptimization. We materialize arguments from the stack area where optimized
code pushes the arguments when entering the inlined environment. For adapted
invocations we use the arguments adaptor frame for materialization.
R=svenpanne@chromium.org
BUG=v8:2261
TEST=mjsunit/regress/regress-2261,mjsunit/compiler/inline-arguments
Review URL: https://chromiumcodereview.appspot.com/
10908194
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12489
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 12 Sep 2012 11:29:50 +0000 (11:29 +0000)]
Introduce new API to expose external string resource regardless of encoding.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10917211
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12488
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 12 Sep 2012 11:15:20 +0000 (11:15 +0000)]
Shorten code path in string allocation.
This was part of r12430 (http://codereview.chromium.org/
10857030/) which has been reverted.
R=ulan@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10913220
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12487
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 12 Sep 2012 08:37:47 +0000 (08:37 +0000)]
Fixed CHECK failure in LCodeGen::DoWrapReceiver when --deopt-every-n-times flag is present
BUG=148389
Review URL: https://chromiumcodereview.appspot.com/
10914222
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12486
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 11 Sep 2012 14:16:56 +0000 (14:16 +0000)]
Fix edge case of extension with NULL as source string.
BUG=144649
Review URL: https://chromiumcodereview.appspot.com/
10914201
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12485
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mmassi@chromium.org [Tue, 11 Sep 2012 14:14:32 +0000 (14:14 +0000)]
Fix array index dehoisting.
BUG=141395
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10919214
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12484
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 11 Sep 2012 14:01:39 +0000 (14:01 +0000)]
Fix invariant so that we cannot record relocation slots for
white objects when compacting. Add flag for incremental code
compaction.
Review URL: https://chromiumcodereview.appspot.com/
10907174
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12483
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 11 Sep 2012 13:19:02 +0000 (13:19 +0000)]
Prepare push to trunk. Now working on version 3.13.8.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10911208
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12480
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 11 Sep 2012 12:43:17 +0000 (12:43 +0000)]
Fix TypeError message for Date builtins.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10928108
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12479
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Tue, 11 Sep 2012 11:36:48 +0000 (11:36 +0000)]
Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM.
BUG=v8:2314
R=yangguo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10908195
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12478
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Mon, 10 Sep 2012 23:17:04 +0000 (23:17 +0000)]
Introduce InternalProperty type and expose internal properties for bound functions
Committed: https://code.google.com/p/v8/source/detail?r=12346
Review URL: https://chromiumcodereview.appspot.com/
10834376
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12477
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 10 Sep 2012 13:38:21 +0000 (13:38 +0000)]
Add more checks for native callback results.
R=svenpanne@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10928083
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12474
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 10 Sep 2012 11:05:17 +0000 (11:05 +0000)]
Fix deoptimizer for shared optimized code.
The deoptimizer searched the stack for activations of the same function to
determine whether to trigger lazy deopting. Since we share optimized code we
actually need to search for activations of the same code (but potentially
different functions).
R=jkummerow@chromium.org
BUG=chromium:147475
TEST=mjsunit/regress/regress-crbug-147475
Review URL: https://chromiumcodereview.appspot.com/
10917162
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12473
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 10 Sep 2012 09:24:17 +0000 (09:24 +0000)]
Enable/disable LiveEdit using the (C++) debug API.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10875072
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12472
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 10 Sep 2012 08:35:26 +0000 (08:35 +0000)]
Add checks to runtime functions.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10915062
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12471
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 7 Sep 2012 09:01:54 +0000 (09:01 +0000)]
Fixed deoptimization of inlined getters.
It is necessary to explicitly handle the internal frame lying between the caller
of the getter and the getter itself in the deoptimizer: When the getter is
inlined, leaving the internal frame restores the correct context.
BUG=http://crbug/134609
TEST=mjsunit/regress/regress-crbug-134609
Review URL: https://chromiumcodereview.appspot.com/
10910110
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12470
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Thu, 6 Sep 2012 15:01:20 +0000 (15:01 +0000)]
Add support for running low level profiler on Android.
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10908122
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12469
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 6 Sep 2012 13:45:58 +0000 (13:45 +0000)]
Prepare push to trunk. Now working on version 3.13.7.
R=yangguo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10928026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12464
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 6 Sep 2012 11:05:40 +0000 (11:05 +0000)]
Loosen up code logging test that was sensitive to GC timing.
Review URL: https://chromiumcodereview.appspot.com/
10918096
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12463
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 5 Sep 2012 16:23:01 +0000 (16:23 +0000)]
Extend grokdump.py with [u]nassemble command
R=mstarzinger@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10910091
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12447
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 5 Sep 2012 16:08:13 +0000 (16:08 +0000)]
Check the return value of API calls on ia32 and x64.
This implies that the return value of native getters is checked. The nice part
is that one can even see the name of the property in question in the abort
output when the check failed.
Under some circumstances even the return value of interceptors gets checked, but
I'm not 100% sure about this, because the interceptor code is basically tuned to
death.
The change seems to have very low overhead, so it might be feasible to keep this
check enabled unconditionally.
Review URL: https://chromiumcodereview.appspot.com/
10918071
Patch from Sven Panne <svenpanne@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12446
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 5 Sep 2012 16:06:53 +0000 (16:06 +0000)]
Add empty-handle checks to API functions (#ifdef ENABLE_EXTRA_CHECKS)
Review URL: https://chromiumcodereview.appspot.com/
10917088
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12445
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 5 Sep 2012 16:06:07 +0000 (16:06 +0000)]
Disable accessor inlining (due to broken deopts)
BUG=134609
Review URL: https://chromiumcodereview.appspot.com/
10908093
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12444
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Wed, 5 Sep 2012 12:30:49 +0000 (12:30 +0000)]
Push stacktrace and die if the receiver is of unknown type.
Review URL: https://chromiumcodereview.appspot.com/
10917086
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12443
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 5 Sep 2012 11:45:58 +0000 (11:45 +0000)]
Fix binding in new Function().
Review URL: https://chromiumcodereview.appspot.com/
10916114
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12442
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 5 Sep 2012 09:29:15 +0000 (09:29 +0000)]
Fix missing colon in common.gypi
R=yangguo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10912092
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12441
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 5 Sep 2012 09:24:37 +0000 (09:24 +0000)]
Add build system infrastructure for ENABLE_EXTRA_CHECKS flag (not used yet)
Review URL: https://chromiumcodereview.appspot.com/
10905093
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12440
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 5 Sep 2012 08:19:49 +0000 (08:19 +0000)]
Fix some corner cases in skipping native methods using caller.
Review URL: https://chromiumcodereview.appspot.com/
10911063
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12439
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 4 Sep 2012 12:23:22 +0000 (12:23 +0000)]
Revert r12430, r12432, r12433 (basic support for Latin1).
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10905075
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12438
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 4 Sep 2012 09:54:36 +0000 (09:54 +0000)]
Fixed test expectation.
Review URL: https://chromiumcodereview.appspot.com/
10913062
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12435
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Tue, 4 Sep 2012 09:35:43 +0000 (09:35 +0000)]
Support register as right operand in min/max support.
R=jkummerow@chromium.org
BUG=chromium:145961
TEST=mjsunit/regress/regress-crbug-145961.js
Review URL: https://chromiumcodereview.appspot.com/
10914072
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12434
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 3 Sep 2012 15:50:24 +0000 (15:50 +0000)]
Fix more windows build warnings.
TBR=ulan@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10917065
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12433
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 3 Sep 2012 15:40:00 +0000 (15:40 +0000)]
Fix windows compile errors introduced by r12430.
R=ulan@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10907049
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12432
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 3 Sep 2012 15:15:32 +0000 (15:15 +0000)]
Do not generate new enumeration indices for global objects.
Review URL: https://chromiumcodereview.appspot.com/
10911058
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12431
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 3 Sep 2012 15:06:36 +0000 (15:06 +0000)]
Add basic support for Latin1 to the API.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10857030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12430
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 3 Sep 2012 15:05:08 +0000 (15:05 +0000)]
Use local variable for getter function in Error.stack
R=verwaest@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10911056
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12429
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 3 Sep 2012 14:23:00 +0000 (14:23 +0000)]
Fix FindSharedFunctionInfoInScript to not optimize.
This prevents a corner case in FindSharedFunctionInfoInScript that would cause
functions to be optimized because an intermittent GC would clear the flag
indicating whether breakpoints are present. Above method was also moved into the
Debug class because it is only used by the debugger.
R=verwaest@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10914065
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12428
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 3 Sep 2012 13:27:17 +0000 (13:27 +0000)]
If we are trimming the whole array, just return the empty fixed array.
Review URL: https://chromiumcodereview.appspot.com/
10911054
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12427
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 3 Sep 2012 12:31:24 +0000 (12:31 +0000)]
Optimize dictionary enum generation.
Review URL: https://chromiumcodereview.appspot.com/
10916076
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12426
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Mon, 3 Sep 2012 11:27:09 +0000 (11:27 +0000)]
Fix android.gypi to provide correct include and library paths when using standalone Android toolchain.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10910062
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12425
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Mon, 3 Sep 2012 08:37:47 +0000 (08:37 +0000)]
Directly use %ObjectKeys in json stringify.
BUG=2312
Review URL: https://chromiumcodereview.appspot.com/
10905059
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12424
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Mon, 3 Sep 2012 06:36:19 +0000 (06:36 +0000)]
MIPS: First steps towards named Litihium operands.
Port r12383 (
881d7d4d)
Original commit message:
Accessing Lithium operands via position is fragile and makes it impossible to
statically find all uses of a given operand. This CL is a step towards cleaning
this up, more to come...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10911021
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12423
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 31 Aug 2012 18:12:25 +0000 (18:12 +0000)]
Only regenerate enumeration indices if properties were deleted.
This indicated by the NextEnumerationIndex diverging from the actual
NumberOfElements.
Review URL: https://chromiumcodereview.appspot.com/
10912049
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12422
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 31 Aug 2012 17:10:44 +0000 (17:10 +0000)]
Clear descriptor pointer when normalizing properties.
Review URL: https://chromiumcodereview.appspot.com/
10909029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12421
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 31 Aug 2012 14:45:31 +0000 (14:45 +0000)]
Fix VS2005 build.
R=jkummerow@chromium.org
BUG=v8:2313
Review URL: https://chromiumcodereview.appspot.com/
10907029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12420
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Fri, 31 Aug 2012 13:31:09 +0000 (13:31 +0000)]
Add option to build using a standalone Android toolchain without Android NDK.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10908034
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12419
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 31 Aug 2012 12:02:02 +0000 (12:02 +0000)]
Disable test that triggers known bug.
BUG=v8:2261
Review URL: https://chromiumcodereview.appspot.com/
10910029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12418
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 31 Aug 2012 09:50:27 +0000 (09:50 +0000)]
MIPS: Use a special EnumLength field to indicate number of valid enum cache values.
Port r12400 (
03ae62de)
Original commit message:
This is preparatory work for sharing Enum Caches.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10914025
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12417
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 31 Aug 2012 09:28:01 +0000 (09:28 +0000)]
Cache results in SearchRegExpMultiple.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
10837290
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12416
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00