Fix acceleration structure vertex and index flushes

Flush the whole allocation when updating vertex and index buffers during
ray tracing acceleration structure builds. The code currently does not
track both the offset and size align to nonCoherentAtomSize, and most
vertex and index buffer allocations are actually on coherent memory.
Flushing the whole allocation allows us to avoid several validation
errors like VUID-VkMappedMemoryRange-size-01390.

Affected tests:
dEQP-VK.ray_tracing*
dEQP-VK.ray_query*

Components: Vulkan
VK-GL-CTS issue: 3656

Change-Id: I5edbbc3b67ab46eaea568842f06dc53664e78e42

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Iab357d9f9a46d2bbe710bd116003c8da423c9709

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I4378bcd20e3ec3e88838dbf9a2f6d6372ba463b6

Increase tolerance in fp64 mat3determinant compute

On QNX, the library function `strtod` has different behavior
from other platforms. It would convert string to a double value
slightly different. So increasing the tolerance slightly would
solve the problem.

Affected tests:
    dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3

VK-GL-CTS issue: 3642
Components: Vulkan

Change-Id: I2c30029d0d6297b660e2900217d6aeb5d3bf3186

Fix extension data for EXT_texel_buffer_alignment

Only the properties structure was promoted for
VK_EXT_texel_buffer_alignment, the feature structure was not
promoted. This change removes specification of "core" attribute
from "register_extension" tag for this extension as only fully
promoted extensions can have it defined.

VK-GL-CTS issue: 3564

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: If1873b8292f1e79ef557876ebb7d8d9cf9d7de83

Support VK_KHR_portability_enumeration

The portability enumeration extension needs to be enabled if it is
present to allow for CTS to enumerate portability devices.

This commit refactors createDefaultInstance so that it only enumerates
the available instance extensions once instead of twice.

It fixees #3644 by adding VK_KHR_portability_enumeration to the list
of known extensions with the addition of a corresponding json file.

Components: Vulkan

Affected Tests:
All vulkan tests

Change-Id: Ib828ee9f385f2eb2e68e03a6b3b3632443da10df

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ia788a27e2bb8cf6ca92e09e378af26db6f50f68f

Reduce advertised sys mem on 32 bit Android

This CL reduces the advertised system memory amount in 32 bit Android
builds to address some memory fragmentation issues in certain tests
that rely on the advertised memory amount.

Affects:

dEQP-VK.api.buffer.suballocation.*
dEQP-VK.api.buffer.dedicated_alloc.*
dEQP-VK.api.object_management.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.pipeline.render_to_image.*.small.*
dEQP-VK.pipeline.render_to_image.*.huge.*

Components: Framework, Vulkan

VK-GL-CTS issue: 3586

Change-Id: I15ef027e3f69ddbb87e8704d0cff479782b6bda6

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Iba260ee0d9195e18e2e41ee3ec525cf5e66faa0d

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Iaeb3f5ee3ef401ef4c0d4d7db27703e8f5b6012d

Don't alias image views in separate_channels subpass dependency tests

This is not allowed by the Vulkan spec:

> Multiple attachments that alias the same memory must not be used in a
> single subpass.

Instead we should have the input attachment and color attachment point
to the same attachment, which is allowed.

Components: Vulkan

Affects:
dEQP-VK.renderpass.suballocation.subpass_dependencies.separate_channels.*
dEQP-VK.renderpass2.suballocation.subpass_dependencies.separate_channels.*

VK-GL-CTS Issue: 3052

Change-Id: Iddb1111be5147f9816104fa879e023a9a3445555
(cherry picked from commit a3e659e828a535582207149cf58a8580d45a0342)

Fix DeqpTestRunnerTest

Component: Android

Google bug: b/206657494
Google bug: b/201652781

Change-Id: I3438b200105bc04ee63b0454a7ce32e4acd4de4b

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I4dbdafea321464fe25499e0a7d415488729d77ce

Synchronize input attachment reads in IO chains

Each subpass in the render pass IO chain tests attempts to read the
output of the previous subpass as an input attachment, but the subpass
dependencies are missing VK_ACCESS_INPUT_ATTACHMENT_READ_BIT from the
flags in dstAccessMask.

Affected tests:
dEQP-VK.renderpass*.attachment_allocation.*

Components: Vulkan
VK-GL-CTS issue: 3643

Change-Id: I63b49709ee8cb03e364050253dc2a8a48c5b58cd

Wait for idle queue after submitting an empty job

The test below imports an external signaled semaphore and submits to the
queue an empty job that waits on that signaled sempahore, but the test
returns without any further wait, which means the external sempahore may
be destroyed before the driver has had a chance to use it.

Affected tests:
dEQP-VK.api.external.semaphore.sync_fd.import_signaled_temporary

Components: Vulkan
VK-GL-CTS issue: 3636

Change-Id: I3e8daa9146f6fd542ad20539a7e9b6c9f0242978

Limit dimensionality of arrays-of-arrays in random SSBO tests

One of these tests used a 5 dimensional array-of-arrays, resulting
in thousands of instructions that caused issues on devices with low
ram. This change limits the total dimensionality to prevent this.

Components: Vulkan

VK-GL-CTS issue: 1829

Solves:
dEQP-VK.ssbo.layout.random.scalar.75

Affects:
dEQP-VK.ssbo.*.random.*

Change-Id: Ibee39ccb0bd1543dafce7c498f56def1e05b4815

Fix 32-bit compilation warning

There was a call to new[] in vktSpvAsmTrinaryMinMaxTests.cpp that used
a 64-bit values as an allocation size, which is not the type the
new operator expects when compiling for a 32-bit target.

Add a cast to fix the warning.

Affects:

dEQP-VK.spirv_assembly.instruction.amd_trinary_minmax.*

Components: Vulkan
Change-Id: I0941033614d67530f6cc157b5923e47bdca5c5a9

Update known conformance version for 1.3.2.0

Components: Framework, Vulkan
VK-GL-CTS Issue: 3628

Affects:
dEQP-VK.api.driver_properties.conformance_version

Change-Id: I5d099f42fd1cc68f8a667ec368fc635ab41f8906

Use getDevice() instead of m_logicalDevice.get() so it works in both paths

This CL fixes a regression introduced with CL9062. For the non-dynamic
paths of the test the m_logicalDevice does not contain a valid
device handle. The newly added getDevice() already handles both
the dynamic and non-dynamic paths, so use that instead of
m_logicalDevice.get().

Affects:

dEQP-VK.memory.binding.*

Components: Vulkan

VK-GL-CTS Issue: 3627

Change-Id: I4ebf74a000553d70db86035ac50b2d4f3257d6ac

Fix GLES CTS mustpass files moved after GPL merge

While performing merge from master to graphics_pipeline_library
dev branch two mustpass files were merged incorrectly. They
were somehow moved and this change restores those files.

Components: AOSP, OpenGL

VK-GL-CTS issue: 3633

Affects:
dEQP-GL*

Change-Id: I488e9f98decc434928dd64156ef4d81904b397e5

Avoid using unsupported rasterization order feature struct

Rasterization order attachment tests with explicit synchronization
mechanisms were chaining the features structure, but these tests are run
on implementations not supporting the extension.

Affected tests:
dEQP-VK.rasterization.rasterization_order_attachment_access.*

Components: Vulkan
VK-GL-CTS issue: 3617

Change-Id: Ia3d3fac2960d1588007c320ed1b92bb6160527fb

Fixed non zero mip compressed texture tests failure

Fixed non zero mip compressed texture tests failure
when sampling coordinates at the edge of pixels.

Components: Vulkan

VK-GL-CTS Issue: 3619

Affects:
dEQP-VK.texture.compressed*_npot_mip1

Change-Id: I4bbc80831233ebcecc34612b7fa488e94dde630a

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ieaa4503461360290f485df78a83ba2422a6b0dfa

Fix accidentally removed extension

VK_KHR_global_priority was accidentally removed from the list of allowed
extensions.

Affects:
dEQP-VK.info.device_extensions
dEQP-VK.info.device_mandatory_features

Components: vulkan

VK-GL-CTS issue: 3639

Change-Id: I3173fa11c27358ad04fb970518b53ecf0e917865

Update known conformance version for 1.3.1.1

Components: Framework, Vulkan
VK-GL-CTS Issue: 3628

Affects:
dEQP-VK.api.driver_properties.conformance_version

Change-Id: I3aa80d23caf74db9a5b00be19f3e80013c6d5a5a

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I3e2c87a50425072269106efb75c250d0cc0be061

Fix dEQP-VK.image.sample_texture.* tests write out-of-bounds bug

Compute shader writing to the view is now made by using block size
instead of pixel count.

Components: Vulkan

VK-GL-CTS Issue: 3442

Affects: dEQP-VK.image.sample_texture.*
Change-Id: Ie351fb1d2730c5377c8110453bc34629c20b5d82

Fix one more missed extension promotion

VK_EXT_extended_dynamic_state2 was not marked as having been promoted,
which meant that the CTS code which uses the core function names
exclusively doesn't work on versions that support 1.2 + the extension.

Components: Vulkan
VK-GL-CTS issue: 3631
Affects: dEQP-VK.*

Change-Id: Ia942b96f778d57337fa087042f176086d5bde608

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I786f14d2785e81098664f94cac78ac635da571fd

Fix dEQP-VK.image.sample_texture.* tests write out-of-bounds bug

Compute shader writing to the view is now made by using block size
instead of pixel count.

Components: Vulkan

VK-GL-CTS Issue: 3595

Affects: dEQP-VK.image.sample_texture.*

Change-Id: I50879fd7bb48f623e565c8972e7a517fb26f0ed0

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Id90879713fa5388ab2a4ebdd6811b454b0675763

Fix extension promotions

VK_EXT_shader_image_atomic_int64 was promoted instead of
VK_KHR_shader_atomic_int64.
VK_KHR_external_semaphore lost its promotion.
VK_KHR_vulkan_memory_model was promoted to the wrong core version.

VK-GL-CTS issue: 3631

Affects:
dEQP-VK.*

Change-Id: I78712093945796adf4076e75f6f3e5c07a4ec832

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Ie2a23e7c3811d6cebc0b7ace2351d5a4779bd7d0

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I6ab43b2abea09721ad28bdba33565c7c0f0be5fd

Fix warnings with clang and GCC

Affected tests:
No test result should be affected by these changes.

Components: OpenGL, Vulkan
VK-GL-CTS issue: 3602

Change-Id: If2eb0736d296add732aaff53c80a705cc306d7a3

vulkan: KHR_format_feature_flags2 modifier coverage

Components: Vulkan

New tests:

dEQP-VK.drm_format_modifiers.list_modifiers_fmt_features2.*
dEQP-VK.drm_format_modifiers.create_list_modifiers_fmt_features2.*
dEQP-VK.drm_format_modifiers.export_import_fmt_features2.*

VK-GL-CTS issue: 3579

Change-Id: I9aa850ea60171523dd5097910e6d3104f7a86cf4

Keep track which SBT records are needed and initialize all needed ones

This fixes using uninitialized memory for SBT records, when
prepareShaderBindingTable() prepares them with flags == 0.

New boolean field is added to SBT description, marked as true when
SBT is needed according to prepareShaderBindingTable()  and needs to
be copied to device memory.

Components: Vulkan

VK-GL-CTS Issue: 3598

Affects: dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*

Change-Id: I5a0a4f6137cece312f7474e1c47c76eb358f62a4

Use queues and entrypoints from custom device

This fixes the test to submit to the queue from same
device, that the command buffers where created from.

Moreover, this fixes the test to use entrypoints get from
the same device that is in use.

Components: Vulkan

VK-GL-CTS Issue: 3592

Affects: dEQP-VK.memory.binding.priority_dynamic.*

Change-Id: Ieca1f6843e31fd5dbf0ad31f4d5b4f3ce3c44453

Fix freeing custom device in dynamic state tests

Some dynamic state tests use a custom device that was not being properly
freed when existing a test group that used the device. This sometimes
caused crashes on program termination.

No tests should be affected by this change. This fix only touches the
test hierarchy. However, to check the fix doesn't break anything:

dEQP-VK.dynamic_state.*

Components: Vulkan
VK-GL-CTS issue: 3602

Change-Id: I6bf97900497b6e795c1fbacef5b3fc68619a9ff4

Check extension support before using its image extended usage bit

Components: Vulkan
VK-GL-CTS issue: 3523

Fix:

   dEQP-VK.image.extended_usage_bit_compatibility.*

Change-Id: I5339402896320eee4434cf80679aa986ba882100
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Fix bad merge affecting create_device_unsupported_features test

This CL fixes the dEQP-VK.api.device_init.create_device_unsupported_features
test from reporting a false error with the pageableDeviceLocalMemory
feature.

Affects:

dEQP-VK.api.device_init.create_device_unsupported_features

Components: Vulkan

VK-GL-CTS issue: 3607

Change-Id: If14a1e2d90c2d5d8d11d47f40590c35048f4b8a0

Check for graphics pipeline library support in FSR tests

Fragment shading rate test variants using graphics pipeline library
were not checking for the extension to be supported.

Affected tests:
dEQP-VK.fragment_shading_rate.*.pipeline_library.*
dEQP-VK.fragment_shading_rate.*.fast_linked_library.*

Components: Vulkan
VK-GL-CTS issue: 3605

Change-Id: Iaa825424f4801ed0a38a78dfdacff533877506fb

Restore the default pipeline layout creation flag

Setting the VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT flag
in the core framework makePipelineLayout() function means that all
tests, even tests that aren't testing VK_EXT_graphics_pipeline_library,
are creating pipeline layouts optimized for independent
partial pipelines.

This flag should only be set when actually testing that feature
since it can be less optimal than the regular pipeline layout,
and is not the default all applications currently use.

This CL restores the default flag and updates the tests that
need it to override the default flag.

Affects:

dEQP-VK.*
dEQP-VK.pipeline.pipeline_library.graphics_library.*

Components: Vulkan

VK-GL-CTS issue: 3609

Change-Id: Iabc8643707f03878426c9bbe87bc0c9ee856bfb3

vulkan: Templatize the DRM format modifier tests

Components: Vulkan

Affected tests:

dEQP-VK.drm_format_modifiers.list_modifiers.*
dEQP-VK.drm_format_modifiers.create_list_modifiers.*
dEQP-VK.drm_format_modifiers.export_import.*

VK-GL-CTS issue: 3579

Change-Id: Id8720806840433a8860550e504646718e5127ce3

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I569c33579928f5ecef8f0a402261b2e2112b345c

Add tests for surfaceless queries

This change adds tests for the VK_GOOGLE_surfaceless_query
extension.

New tests:
dEQP-VK.wsi.*.surface.query_formats_surfaceless
dEQP-VK.wsi.*.surface.query_formats2_surfaceless
dEQP-VK.wsi.*.surface.query_present_modes_surfaceless

Components: Vulkan
VK-GL-CTS issue: 3557

Change-Id: I6febafc855b500052e8dedcba810dd80fb5c1e71

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I7a3dfef17070866462056327110f798dde9f119d

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I35b6b6a32a0ef4bb72d628f26b96a1ac8df46858

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I2c051a776b06d23239eb3ce501a999088cd0c1de

Rework extensions_data and mandatory_features

Data from mandatory_features.txt was split to multiple json files
one per extension/vulkan_version. Those files now also include data
that was previously stored in extensions_data.txt .

VK-GL-CTS issue: 3197

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I9756237829366ff4140dcf59dc7548a8f4328cb7

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I69f0b9b087df9c33b26ddd014fc1a291fc50dbdd

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I4a1b44642747f72803ff97dafd55f4ba3fabad9e

Use associated physical device from custom instance

Some of the API feature info tests created a custom instance,
but still used the default physical device. This is fixed by
choosing a physical device using the custom instance.

Comparison of VkPhysicalDeviceMemoryProperties was also
changed to only check the active memoryTypes and memoryHeaps
array elements instead of doing one large deMemCmp.

VK-GL-CTS Issue: 3590

Affects:

dEQP-VK.api.info.*

Components: Vulkan
Change-Id: I2378bcd1e97b7f85e533d34c5b5f6ac3e4fa9b93

Wait for deferred operations before obtaining RT pipeline handle

The ray tracing utils, when creating ray tracing pipelines and using
deferred operations, were using the VkPipeline pointer and handler
before the deferred operation had completed, which is against the spec.

Affected tests:
dEQP-VK.ray_tracing_pipeline.pipeline_library.configurations.multithreaded_compilation_dho.*
dEQP-VK.ray_tracing_pipeline.large_shader_set.cpu_ht*

Components: Vulkan
VK-GL-CTS issue: 3588

Change-Id: Ied8f443c01e99878180130963b8988852171b8a0

Fix subgroup size control failure logging

One of the failure messages was missing the message terminator, which
prevented it from ever being logged.

Affects:
dEQP-VK.subgroups.size_control*

Components: Vulkan
VK-GL-CTS issue: 3596

Change-Id: If649a11e0f6cf0f5e69e438d46b385b26e57dfe4

Parse test case result version when converting to XML

When parsing QPA files, extract the test case result version so it can
be later used to print the proper version when converting to XML files.

Components: Framework
VK-GL-CTS issue: 3573
VK-GL-CTS public issue: 287

Change-Id: I34d005621685b0ef31a7092ec7c40e6626bf20e3

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I25f8f2f56ab07a9c3f04e8cfa54f2efc11bfd80a

Add queue ownership release in modifier tests

Queue ownership transfers require a release operation and an acquire
operation. Before this patch, this test only performed the acquire
operation.

Components: Vulkan

VK-GL-CTS issue: 3575

Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I2998d7928d1042d6a159e1173257ee551c1120a5

Fix incorrect layout transition in modifier tests

The queue family ownership acquire operation specifies a layout
transition from the pre-initialized layout. The image isn't in the
pre-initialized layout however, it's in the transfer dst optimal layout.
Align with the Vulkan spec, which says:

When performing a layout transition on an image subresource, the
old layout value must either equal the current layout of the
image subresource (at the time the transition executes), or else
be VK_IMAGE_LAYOUT_UNDEFINED (implying that the contents of the
image subresource need not be preserved).

Components: Vulkan

VK-GL-CTS issue: 3575

Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I76dbb54c699ed7d34e964de17f71ef01bc9e98a5

Fix lossy layout transitions in modifier tests

The test performs several layout transitions that use
VK_IMAGE_LAYOUT_UNDEFINED for the initial layout. The spec says that
these transitions cause images to become undefined. The test expects
defined data from these images however. Replace these initial layouts
with layouts that don't cause data loss.

Components: Vulkan

VK-GL-CTS issue: 3575

Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I5e57dd197d461fba800d50239803d525c5334ac4

Fixes pipeline library merge

Components: Vulkan, Framework
VK-GL-CTS Issue: 3606

Change-Id: I0c14e4dac195977ac6bc13a5cc817e9089b65266

Merge changes I12ee2542,Ic8530cb6 into main

* changes:
  Merge vk-gl-cts/dev/VK_EXT_pipeline_library into vk-gl-cts/main
  Merge vk-gl-cts/dev/VK_EXT_primitives_generated_query into vk-gl-cts/main

Add more video exclusions to gen_framework.py

Prevents build errors.

Components: Vulkan

VK-GL-CTS issue: 3551

Change-Id: I2b59ef06a3bcfbb8d328db748152ef3e4a7bf7bf

Remove a wrong qualityWarning for fbo completeness test

Components: OpenGL
VK-GL-CTS public issue: 296

Affects:
dEQP-GLES2.functional.fbo.completeness.attachment_combinations.*

Change-Id: Ic0ebb0d861cf9e5503d2be1368050a88d2b4d9b7

Merge vk-gl-cts/dev/VK_EXT_pipeline_library into vk-gl-cts/main

Change-Id: I12ee2542aa31e0942a3827ea59abc64e20624daf

Merge vk-gl-cts/dev/VK_EXT_primitives_generated_query into vk-gl-cts/main

Change-Id: Ic8530cb607cee5062611ccf40f409549edfa94aa

Merge vk-gl-cts/main into vk-gl-cts/dev/VK_EXT_primitives_generated_query

Change-Id: Id9a4afa9f27f79bc0c2fe5023197e82ca979157a

Fixes Conditional Rendering local memory tests

Commit was not up to date with android CTS
update

Components: Vulkan

Affects:
dEQP-VK.conditional_rendering.*

Change-Id: Idd3b56426888e788cd255f44ef6ba35672310944

Merge main into VK_KHR_graphics_pipeline_library

Components: Vulkan

VK-GL-CTS issue: 3310

Affects:
dEQP-VK.dynamic_state.*
dEQP-VK.pipeline.*
dEQP-VK.fragment_shading_rate.*

Change-Id: I93de4c5a0c029b67484c1c23cf285649ff12189c

Reduce framebuffer size on some graphicsfuzz tests

Many graphicsfuzz tests are using a 256x256 framebuffer even though all
pixels or almost all pixels are generating the same results. This CL
reduces the framebuffer size to 16x16 for a some of the tests that are
causing problems in some of our test builds.

Components: Vulkan
Affects: dEQP-VK.graphicsfuzz.cov-dfdx-dfdy-after-nested-loops
         dEQP-VK.graphicsfuzz.cov-nested-loop-large-array-index-using-vector-components
         dEQP-VK.graphicsfuzz.cov-nested-loops-different-iteration-rates-function-copy-array-elements
         dEQP-VK.graphicsfuzz.cov-nested-loops-set-struct-data-verify-in-function

Change-Id: I25fbbb09473d86140a23b1218db344484b563653

Simplify isDeviceFunctionalitySupported

Add comments explaining the two parts of the check and simplify the
checking of extensions that the device reports are supported -- the
feature bits are compulsory when the extension is supported.

Components: Vulkan
VK-GL-CTS issue: 3149
Affects: dEQP-VK.*

Change-Id: Iec81cdf588146d2adb07871b5950024d3cdcf189

Extend conditional rendering tests to use buffer with device local memory

Components: Vulkan

Affects:
dEQP-VK.conditional_rendering.*

Change-Id: I3ce597cf8850ff6cebf5f3e2db0b7fbe68d476b0

Actually test compatible depth/stencil attachment formats

These tests claimed to test "compatible" depth resolve formats, i.e.,
resolving to a depth-only format from a depth/stencil format.  However,
it only set the depth-only format on the renderpass and not on the
single-sampled image.  This meant it was in violation of the following
VU because the image view and attachment format didn't match:

    VUID-VkRenderPassBeginInfo-framebuffer-03216

    If framebuffer was created with a VkFramebufferCreateInfo::flags
    value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each
    element of the pAttachments member of a
    VkRenderPassAttachmentBeginInfo structure included in the pNext
    chain must be a VkImageView of an image created with a value of
    VkImageViewCreateInfo::format equal to the corresponding value of
    VkAttachmentDescription::format in renderPass

Unfortunately, once I fixed the format, it turned into a bit of a rabbit
hole because aspects were also messed up various places and then layouts
as well.

Components: Vulkan
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*

Change-Id: I34f5dd2cbccae2a695cbe05a22908ba544b0a6a6

Add a GraphicsFuzz coverage test

Adds a GraphicsFuzz coverage test which has been separated by request.

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.cov-global-loop-counter-accumulate-integer-condition-large-array-elements

Change-Id: I3c90c09743f50f6ab23d271706f54269d703416d

Add coverage for depth bias with polygon topologies and fill modes

In these test we are applying the depth bias by using
depthBiasConstantFactor. Polygon topologies with fill, line and point
polygon modes are tested.

Components: Vulkan

VK-GL-CTS Issue: 3055

New tests: dEQP-VK.draw.renderpass.depth_bias.depth_bias_*

Change-Id: I5cb5a1c8ee13fa0f6c56edaf21eda4e19b6d144c

Fix feature checks in rasterization order attachment tests

This commit fixes the following issues:

* Do not filter the extension by default.
* Do not require Vulkan 1.2 in the tests.
* Chain the features struct in the right place when requesting it.
* Choose a supported depth/stencil format at runtime.
* Do not require the extension in explicit synchronization variants.
* Add missing VK_DEPENDENCY_BY_REGION_BIT in some barriers.

Affected tests:
dEQP-VK.rasterization.rasterization_order_attachment_access.*

Components: Vulkan
VK-GL-CTS issue: 3528

Change-Id: If8b96227174689e834efd5c71620082d389f4f80

Add a batch of GraphicsFuzz coverage tests

This commit adds a batch of GraphicsFuzz coverage tests.

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.cov-function-nested-loops-limit-uniform-xor-uniform
dEQP-VK.graphicsfuzz.cov-loop-array-index-decrement-never-negative
dEQP-VK.graphicsfuzz.cov-loop-condition-filter-some-iterations-never-discard
dEQP-VK.graphicsfuzz.cov-loop-increase-iterator-condition-uniform-copy-array-elements
dEQP-VK.graphicsfuzz.cov-loop-iterator-plus-one-variable-outside-index-array
dEQP-VK.graphicsfuzz.cov-loop-limiter-min-findlsb
dEQP-VK.graphicsfuzz.cov-loop-limiter-uniform-bitwise-and-one-always-break
dEQP-VK.graphicsfuzz.cov-loop-replace-output-color-restore-original
dEQP-VK.graphicsfuzz.cov-negative-integer-bitwise-or-uniform-increment-loop
dEQP-VK.graphicsfuzz.cov-nested-loops-copy-array-elements-skip-first
dEQP-VK.graphicsfuzz.cov-nested-loops-fragcoord-never-return-descending-loop
dEQP-VK.graphicsfuzz.cov-nested-loops-global-loop-counter-output-color-from-backup
dEQP-VK.graphicsfuzz.cov-nested-loops-identical-iterator-names-multiply-divide
dEQP-VK.graphicsfuzz.cov-two-functions-modify-struct-array-element-return-from-loop
dEQP-VK.graphicsfuzz.cov-vec2-dot-max-uniform

Change-Id: I3694d496c3e26f4fc429ac69161bb49d1cb6e9b8

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main

Change-Id: Id0703e74d7bb5553e60e33bfeedf35f1941ae797

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Ie7c9018ebfa517b331f6e48ca68abc0cfc4d171d

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I31de5eca8b8354c5dbc80545d89e63be98d2509a

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I4713730ea2497ef56f0c939a5e73a6bdc0cdcb6e

Fix memory leaks when creating test hierarchy

The lack of a virtual destructor in one of the classes used as part of
some test parameters made createDescriptorValveMutableTests() leak
memory whenever it was called, in the moment the test hierarchy is being
destroyed. The leak will happen not only when running mutable descriptor
test, but when the binding_model test group needs to be generated for
any reason, including running tests in adjacent groups.

Hence, the change has no specific list of affected tests. At the same
time, no test result should be affected by the change.

Components: Vulkan
VK-GL-CTS issue: 3583

Change-Id: I7e847b5927359cef27f9992cd53991dd1a7cb781

Use proper image tiling in synchronization test support checks

Some test variants use LINEAR instead of OPTIMAL tiling and the proper
tiling mode features need to be checked.

Affected tests:
dEQP-VK.synchronization.*

Components: Vulkan
VK-GL-CTS issue: 3572

Change-Id: I16042ace7fb3a2f93b1503e539a5bbe59e03ae14

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I5e73a149353915a09697633abab737ee8a38fdca

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I4624140325b398fc901142f54425375b5ffa3d66

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Ibcfcfa0cf5ad247b4c80017ad298d15a5139868f

modifiers: Use dedicated memory consistently

When a dedicated allocation device memory object
is exported, it must be imported as a dedicated
allocation created with a compatible resource as
well.  This change makes the DRM format modifier
tests self-consistent in that regard.

Components: Vulkan

Affected tests: dEQP-VK.drm_format_modifiers.export_import.*

VK-GL-CTS issue: 3544

Change-Id: I93a35180b9a5a1b98e0d4fa1f2934258134cef1b

dEQP-VK.pipeline.graphics_library

Include VkGraphicsPipelineLibraryCreateInfoEXT into chain
for empty flags.

Affected test:
 * dEQP-VK.pipeline.graphics_library.*

Components: Vulkan

VK-GL-CTS issue: 3553

Change-Id: I93a5a4dcc4dacc8a57cbb57834c4faa5f9485f16

Test pSetLayouts in graphics_pipeline_library

VK_EXT_graphics_pipeline_library allows the entrys in
VkPipelineLayoutCreateInfo::pSetLayouts to be nullptr if
VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT is set.
This change adds test that use nullptrs in various combinations
of pSetLayouts.

Components: Vulkan

VK-GL-CTS issue: 3567

Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.*

New tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*

Change-Id: I3d8958a1e234e4d47e4f65d31c09fe3f4ddb3b54

Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main

Change-Id: I0fcff18bc616b1509a7780d9a589d4dd400443eb

Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/opengl-cts-4.6.2

Change-Id: Ie1f7f2f793568ae79ccbb11f9678bb74cd7c1c82

Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/opengl-cts-4.6.1

Change-Id: I02e16a1b389011005aebf279c6e689ca0a457ad5

Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main

Change-Id: I2e3552647e64792f3f76fc8abcbcc7fac72bfe76

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/opengl-es-cts-3.2.8

Change-Id: Ie3bbc30b0ff206922ea5c2640467cf5b6dc219ba

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: I52ff340b949967f446fd61423f6294f09106e492

Fix Zlib depedency

Use newer version of Zlib as older is no longer available to download from the zlib.net page

Components: Framework

Affects:

None

VK-GL-CTS Issue: 3587

Change-Id: Ie166dc897b0d1318c1ae73434bfa19687b579691
(cherry picked from commit ec1804831b654ac55bd2a7a5dd27a556afe05030)

Fix Zlib depedency

Use newer version of Zlib as older is no longer available to download from the zlib.net page

Components: Framework

Affects:

None

VK-GL-CTS Issue: 3587

Change-Id: Ie166dc897b0d1318c1ae73434bfa19687b579691
(cherry picked from commit ec1804831b654ac55bd2a7a5dd27a556afe05030)

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main

Change-Id: Iaf0a20b1b2a7d41797cf080ce30c8f67c4e187b2

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I5cf16d79906b53790ceb0362d6763ed07ff6462f

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I7d9aa638cac5bfb8c73848b5aa1b698f12e170c6