RM fix for JIRA issue [1342]

https://jira.iotivity.org/browse/IOT-1342

Change-Id: I80a8d442f93ac0f197029f32bc0918b668c2d708
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12325
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ae853c37baacf270d2ca1de192f21dbe63b1384e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12383

[IOT-1354] Multiple APIs crashed instead of returning OC_STACK_INVALID_PARAM while endpoint is kept NULL

Change-Id: Ie04acb860f5c06d298940db9944086eb929baf05
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12337
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1332] support multi network state changed callback in base layer.

Change-Id: I1027bb11d276d1daceafea1673ceaa5f2d9b4411
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12131
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1324] Fix crash issue which call getPlatformInfo with QoS.

The Listener for getPlatformInfo with QoS used DeviceInfoListener.
So, it replace with PlatformInfoListener.
(it was occurred in Android Platform)

Change-Id: Ia9f0530465267a6f338dc67ba42a8c5b396271ef
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12293
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Exposing CASelectCipherSuite to OC layer

Select the cipher suite for TLS/DTLS handshake

Change-Id: Idb346fc2c5eb3bfa7f624562ef72a02c37db821b
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4536668a99c836329753e75a17c479ff81e7d4a8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12031

Added CASelectCipherSuite for android

Change-Id: I073d1191e6a114c3c34f67f48d1ab7c7443bf1d6
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
(cherry picked from commit 7c4dd58b07c1b0f5c349bab2b6e8e93eb8fef543)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12327

Fixed account server TC

1. DB reset for each test case

Change-Id: I7cc9d46af2ffe6136b13231d9b0e015ee6799dcf
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

[IOT-1331] Arduino with SECURED=1 prints build failure

Arduino does not support security at all. The crypto
stack is not avalible. If the SECURED=1 option is
provided the build will instantly fail.

Change-Id: I2fd72b5debf05d214b606a1ff95da1161b6da4a9
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12225
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

InProcServerWrapper null pointer dereference

clientResponse is redundant or null pointer dereference

https://jira.iotivity.org/browse/IOT-1311

Change-Id: Id1f0d7088443bc875c6a99a20a4e30cdcbc4b4a0
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12239
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: avoid en_speedpython for Tizen:2.4

May be squashed into:
https://review.tizen.org/gerrit/#/c/82272/3/packaging/iotivity.spec

Change-Id: I2d0e8b5e8b9404760ce58ee634348ef6bc3ade1d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12053
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Close tls session with tcp session

[Patch #2] Move it before socket close

Change-Id: I5bede5ab75b4e67faff932e77c30565062916c95
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Print Acl Id & minor updates

Change-Id: Ib6b48be6e9f5da3dafb27632b2b93a986b6da2ab
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12217
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Svace fix for cloud Client functionality

Change-Id: Ib2ae875106422654635ee02e7fa89e3cf37b57cd
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12223
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

svace issue fixes

Change-Id: I7832bab14a433e3a6b55c378ae0000b5e24882a5
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12205
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

refactoring RD server

Change-Id: Icd024741fabdfd518dac7236a82f78607905270a
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12279
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Delete Client callback when receive observe cancel response.

Bug: https://jira.iotivity.org/browse/IOT-1317
Change-Id: I4e5ef2a1c848b963c036efe4ddf73dfd76b2b262
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 888bc96303a22443ab4d75e225803268267956b0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12213
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Fix index out of bounds in sample

1. Fix array reference in cloud sample.

Change-Id: I2e3a0df8eca20bf178edc962ef3384b125b11d2d
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12277
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>

coap-http-proxy: Fix coap headers path

It failed to build on Tizen:2.3.1:Wearable

Change-Id: I1069ab17f11a946605093454b89205a6c208c902
Origin: https://gerrit.iotivity.org/gerrit/#/c/12061/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12061
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix strcpy in occlientcoll

occlientcoll was using strcpy, changed it with OICStrcpy.

https://jira.iotivity.org/browse/IOT-1310

Change-Id: I51b6c46ea3095eea60c225953c38dfbe65985e7c
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12237
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Allow multiple calls on OCResource::observe().

Remove check against m_observeHandle in OCResource::observe().
This will allow mutliple calls on observe with different query
parameters.

Bug: https://jira.iotivity.org/browse/IOT-1115
Change-Id: I1bae9e8db8999bf6e805eec75ebcbe9f4af8b3c7
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11735
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit 66b4b024a7d317913c377949d94a298a4a224c42)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11993

Enable Tizen build for proxy

Change-Id: Id5a8091ae5d1544581bb9991e18d20dd5b67e292
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12207
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit f2ac9f727348d48062fe7a8ab2ba08563ccb0071)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12215

Add generic APIs for set/get header option.

These APIs should be applicable for setting/getting
header option operations for version number and proxy-uri.

Bug: https://jira.iotivity.org/browse/IOT-1223
Change-Id: Ifd2d1b6ad30dff3a247c84b63d139c9552bfb32f
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit b3bde9b3efd85ae9ec0ef00b2dfef232ed36ad20)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12219

[IOT-1295] remove wrong step related Security in Tizen gbs build.

the stop related secure mode should not be trigerred by default.

Change-Id: I4cf684b4af392fdd5b428028ade1479066ae6809
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 12eeb22020f4603ee1789065aa92ef9c3cbd8e22)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12129
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>

tizen: Use upstream packaging file as aligned

Note, for dependencies libraries.
It's easier to maintain them as patches over upstream git.

More details on downstream maintenance at:
https://wiki.iotivity.org/tizen

Change-Id: Id630e6a06bff11c750a106e8fc0cffb9a154f87b
Bug: https://review.tizen.org/gerrit/#/c/82260/
Origin: https://github.com/tizenteam/iotivity/tree/sandbox/pcoval/on/master/tizen
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Disable SECURED by default

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: I22e14a601d30b29005352a5154f617ed66ce1903
Origin: https://gerrit.iotivity.org/gerrit/#/c/12101/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add option to create proxy as secured resource

Modify CHPInitialize() api to allow secured
mode. Also minor code formating optimizations.

Change-Id: I4041c506d8ce41769b9c55d4850d551fae87ad2e
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12071
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 58d543419f76b030ae06ca7fd4ff6be28f050d78)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12209
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

tizen: Introduce speedpython macro to speedup build

revise build time

Change-Id: I674157a6b446c8fad54cb7c8a2a937007f04db8a
Author: Youngjae Shin <yj99.shin@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/82272/3
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix for IOT-1214: Incorrect use of tinyCBOR API in security code

mapSize is consistently larger than the actual size of doxmMap.
This results in an erroneous parse of the resulting payload wherein
the last key-value pair is truncated.

When creating containers, we must specify CborIndefiniteLength unless
we know the exact length the container.

Change-Id: I8beb6bc45ae41531e8a7528d9dbd254a27e14be9
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10455
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit a909e871afe8a9ea7e0a779302e4d47dac74649d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11711
Reviewed-by: David Antler <david.a.antler@intel.com>

yocto: Updated scons build configuration for Yocto

* Added i686 to the list of supported target architectures
  for a Yocto build.

Change-Id: I2b5b3191807ab7229cb3457f42a21a94a1d1611e
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Author: Kishen Maloor <kishen.maloor@intel.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/2873/
Signed-off-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12147
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

[IOT-1329] Include OCResetDevice in header

Include OCResetDevice in ocprovisioningmanager.h

Change-Id: I3f7c5be85d81a7fac75ad66fb945c8e23c41e343
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

tizen: Disable TCP by default

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Icd0973c3bc0140d2320b2018de85ba589eae51fc
Origin: https://gerrit.iotivity.org/gerrit/#/c/12099/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

tizen: Disable WITH_CLOUD by default

Even if the code is building, I have disabled it by default,
 to align default values set in ./build_common/SConscript

If needed it can be enabled, but make sure a value is set to it.

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Id075b0479185aea2e13396df51ffecd56a9e183f
Origin: https://gerrit.iotivity.org/gerrit/#/c/11305/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11737
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

[IOT-1337] Exception handling added in cloud client sample

- Exception handling added in group_invite and MQ samples

Change-Id: Ic94c78c1b457794f78eabc37e3c134b9ea31cb59
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12195
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

[IOT-1319] Resolved potential buffer overflow case

Change-Id: Ic5779a529085514a9269321c60770cd13c8fcd25
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12137
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
(cherry picked from commit 1eaa05e4bb9c3b18087f908dfb88f37514091eac)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12191

tizen: Use 1/0 for booleans

To prevent ambuiguity of low/up/case.

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Ic918e0c95f13462cab85ade3828e635f47ee7484
Origin: https://gerrit.iotivity.org/gerrit/#/c/12097/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12097
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Solve build issue

fatal error: coap/uri.h: No such file or directory

Change-Id: I2713ad5d3906fb498cd5d26dad8375ec075da5a0
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12033
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

provisioning: Support older g++ (for Tizen)

It was successfully tested with gcc-4.6.4
 on Tizen:2.3.1:Wearable.

Change-Id: Ib97c4bfe73d1d40ee8a029a016b7d69e2b3e3d99
Origin: https://gerrit.iotivity.org/gerrit/#/c/12059/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12059
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

fixed android build fail with SECURED flag.

 associated with https://gerrit.iotivity.org/gerrit/#/c/11331/25

Change-Id: I7b2aa38167d5573bd9b845c1d2e604c9ec23a3f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12153
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1309] Remove potential buffer overflow

Change-Id: I4804381daf85003929a2d8f96945b170083c2ab4
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12125
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit be118d87c84e995b70fbbd9f546546e97c3a1740)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12141

provisioning: Fix type mismatch for sessionObject.expiresin

Failure to build was observed on Tizen:Common (armv7l):

  cloudAuth.cpp:127:59: error: cannot convert 'long int*' to 'int64_t* \
  {aka long long int*}' for argument '3' to \
  'bool OCRepPayloadGetPropInt(const OCRepPayload*, const char*, int64_t*)'

Change-Id: I3feaea196d91e22d29cc0a2b1d5fc859ecb6ea6c
Origin: https://gerrit.iotivity.org/gerrit/#/c/12049/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12049
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Modified c++ provisioning to support cert provisioning

Change-Id: I98b41b2b65d4f3ee52e3cabdbe3fab35789f555b
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10999
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 1b4f12e1fdd602cd521b82754c907d630e6a0a67)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12121

Check parsing response from cjson

Prevent crash if invalid json response received from server.

Change-Id: I339796be64ca4ec46d2e68a02b7f128a8c2fcdab
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
(cherry picked from commit 4815e501d2af69d9b19fd28e866134c61b0dd981)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12119
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify subscriber list in Invite resource

- modify Invite resource to make multiple devices(for each user)
  can get observe notification about invitation info.

Change-Id: I4afa8cf0e4da5c68c3478cb7903afd3bf14dc97b
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12001
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
(cherry picked from commit 558d3f1b6287f139ec75361b3e0cdfdebec38b08)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12113

Added client sample for proxy

Removed proxy changes from csdk sample and
added separate sample for proxy.

Change-Id: I45b31b46ee61eee7dd440dad0b2957345a75b1d0
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11869
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
(cherry picked from commit 02488c95057b3cf160ad60feea3b960352b36c70)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11989
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fixed observe exception, when channel is disconnected

Change-Id: I51383ad7d18611b8cc986af875e5e30574fc1749
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12027
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

relocate singleton object(getInstance) to GroupManager

Change-Id: I3c263e0edd69e92d17fa4bf49e15d797054e7c8f
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11241
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11981

Update a logic to convert a string UUID to oicuuid type

The previous convertStringToUUID function does not works well, which
can not convert from string UUID to oicuuid one, properly. Instead of it,
we use an existing API for that in srmutility, i.e. ConvertStrToUuid.

Change-Id: I09f407e8af1a4395bf1b406bdb0f1a729e75f1fe
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 3215cc92a7bccfe2dc2d6e2403b068fe38721554)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11779
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Heewon Park <h_w.park@samsung.com>

Create build_linux_secure_with_tcp and cleanup build_android job

- build_linux_secure_with_tcp
  flag: SECURED=1, WITH_TCP=1, WITH_CLOUD=1
- clean up build_android
  place the android armeabi build job only
  TRANSPORT=All is applied which will verify all transports.

This will not affect currently running Jenkins build trigger.
So related yaml file should be modified for this change effective

Change-Id: Id77f4fb23d45316b876356ba9b1e062c9f1e7f79
Reviewed-on: https://gerrit.iotivity.org/gerrit/12023
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Merge remote-tracking branch 'origin/notification-service'

Android wrapper service is updated.

Change-Id: Iec12e1b9f48b60913e5915e9b3a8bfcf7c4bd891
Signed-off-by: cc <ch79.cho@samsung.com>
(cherry picked from commit 23d997e80a1d6f23da6c5e345ed77c30a1595861)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11865
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Delete Device logic fixed in the account server

1. When a device is deleted, the device ID in each group is removed.
2. The device ID is added only in the resource publish case
3. footnote added

Change-Id: Ifdff14f0f3132a753b2a05cd4e1691657a8b3560
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11137
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11979

Modify SRPSaveTrustCertChain

When saved CertCahin as PEM format in SVR_DB file, null termination is required.

Change-Id: Icdb15c447f91c42b98a665ed82c169052245e61e
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11939
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Configure resource security

A provider is able to create the secured resources
if the provider config is set by enabling resource security.

Change-Id: I007c0e115e8cc2841ca7203994fa81c54a545276
Signed-off-by: cc <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11729
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 2a851346faa28b61abef56ef5bdbbeb48a67ccde)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11931

yocto: Use tools from sysroot before system PATH

To ensure reproductibily Scons avoids to rely on environment
 but some systems like Yocto are defining their own cross compiling env.

To deal with those orthogonal paradigms,
 a new CONFIG_ENVIRONMENT_IMPORT variable has been introduced,
 It enables import of needed variables (PATH and pkg-config's ones).

Without this change, system tools might be used by scons
 instead of looking into yocto's sysroot.
 This is not not wanted and may be less reproductible.

This problem was noticed when building Ostro OS
 (on a system without all Yocto dependencies)
 reported error messages were:

  | sh: gdbus-codegen: command not found
  | /bin/sh: 1: pkg-config: not found

More information about using SCONS along Yocto, check some notes at:

https://bitbucket.org/scons/scons/wiki/Notes

Bug: https://jira.iotivity.org/browse/IOT-1219
Change-Id: I6af59a590f8be489398623d29cf85c2f568dd6a3
Origin: https://github.com/TizenTeam/iotivity/tree/sandbox/pcoval/on/master/mine
Thanks-to: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify AccountManager to support Google OAuth2 Provider
and Token Refresh

Change-Id: Ie4c430ecfbf6ae4620e0490a82e2ef237a569ed9
Signed-off-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11375
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yeonghun Nam <yeonghun.nam@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
(cherry picked from commit f4c2bf41a3fe18d5cda53ccacc4698ee587bd777)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11983
Tested-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Add Google OAuth2 Provider

Change-Id: Ib2062996074621b80da1acbb1e7fd3b8f3dbf687
Signed-off-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11271
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
(cherry picked from commit 2c4f2d3be6cc402bb7aec8d5d8c2939b07c3d935)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11985
Reviewed-by: Yeonghun Nam <yeonghun.nam@samsung.com>
Tested-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Unit test development.
1. CSR update(update for new specification)
2. CSR unit test update for new specification.
3. Code refactoring.
4. Update CRL pubdatatype and express RCSN as Arralist of Strings
   as in specification.
5. Fix issues for CRL table, add new unit tests, add docs for
   CertificateConstants, CertificateManager, CertificateStorage.
6. Fix issue with subjectDN and issuerDN for CA certificate and for personal one.
   please remove cloud/account/keystore folder
7. Fix last update CRL issue.
8. Fix issuer name for CRL.
9. Fix issue with basic-constraints. Code refactoring.
10. Fix issue with CRL re-creation after account restart.
11. Fix issue with CRL subject name.
12. Replace Base64 to Der coding for CRL GET. Code refactoring.
13. Put CRL to db as BinaryData and remove CRL file.
14. Add new unit tests for CRL.
15. Add new unit tests for CSR and add documentation.

Change-Id: Iadef163d6cde2ca671b70a0cc05d9a73cbf9b8a3
Signed-off-by: Andrii Androsov <a.androsov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11973
Tested-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Cloud ACL Management (cherry-pick conflict solve)

Resolve conflicts between cloud-interface, master and 1.2-rel

Change-Id: I1a6c1a8059befdcea1017c826ae77a1900a4d2db
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11943
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Token refresh logic in the sample device (thin_room_light)

1. Token refresh logic is added to the sample device (thin_room_light)

Change-Id: I4fbeab1a3f665e065c3297e808a0145f751631d6
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11403
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
(cherry picked from commit f04dc53a73ed5369f6718fd81174d87ab51c712c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11961

fixed create response in message builder

when create response message, it is unnecessary to set observe option.

Change-Id: I293843dac9bdbcc3d1b88724d15c89f229649fde
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
(cherry picked from commit fef945f09258318fc799210618c7115648df51b3)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11959

Add C++ Cloud provisioning

[#1]: Initial version of header
[#2]: APIs definition
Added Unit Tests.
Added cloudClient, based on the C cloudClient.
Only the focus APIs are changed to C++

Change-Id: I482f19b80e674ebccae44731a9927ab19c2b4a80
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1097d2acfbf5098a04c3d007f11a0717951f07b1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11965
Tested-by: Randeep Singh <randeep.s@samsung.com>

Set defines before including platform_features.h

This is needed since platform_features.h uses some of the ifdefs set in
iotivity_config.h

Change-Id: I93aa075f910ed9a4548a30d6a3fa5a6d0692ad9c
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11895
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Resolve secure tcp build issue for Tizen

Build is failing for tizen if both SECURED and WITH_TCP is enabled.

Change-Id: Ib67fb59fe0ef37d7a0be7c157bfe4b6b86f652bf
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 736b3bd6b91358ceeed0b1d33414e07488d92eaf)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11901

IOT-1072 Unfork libcoap: update forked headers

Make the .h files compatible between the forked libcoap and the official
libcoap, so that no breaking changes (only additions) are done to the
official libcoap, which other projects depend on the current
types/prototypes in.

Make any additions (that are beyond the official libcoap, but that are
already used by IoTivity code) to libcoap .h files follow the conventions of
libcoap, to make it more likely they'll be accepted back into the upstream
libcoap.  E.g., coap_transport_type -> coap_transport_t, etc.

Leaving WITH_UPSTREAM_LIBCOAP off by default on all OS's in this change.
Turning it on by default in certain OS's will be done as part of a
separate change.

Change-Id: I373ef818b8aeb7608c5e3511dc9880047946fbe0
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
(cherry picked from commit 4c49d8fbd634398f5f16addb9331a4683b939068)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11891

IOT-1072 Unfork libcoap: add build flag

* Add WITH_UPSTREAM_LIBCOAP command line option for SCons
* Add libcoap downloader, starting on public 'develop' branch
* Move resource\csdk\connectivity\lib\SConscript to extlibs\libcoap
* Restructured forked libcoap to resemble GitHub version, using a
  separate include directory and #include "coap/file.h" where needed
* Modify tizen build scripts
* Note - most platforms will not yet build with WITH_UPSTREAM_LIBCOAP

Change-Id: I51a59701d903adb63ba73e09afd230b9a7fd8696
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Signed-off-by: David Antler <david.a.antler@intel.com>
Signed-off-by: Ajay Saini <ajay.saini@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11873

[IOT-1294] install libraries when building WITH_RA_IBB flag

When building with the TEST option the libraries will be picked
up at run time.

Changed the order of libraries to prevent linker error related
to the pthread library.

Change-Id: I39e70dc33b774dcf46559306df0c5558975ec451
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>

Add Copyright header.

Change-Id: I84b2af8096ac67b583c220dffc42fede8c3ca86a
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11829
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Fix for Jira issues [IOT-1157, IOT-1194]

[IOT-1157]: Added default case for mentioned switch statements.
[IOT-1194]: Removed unused structures and made
g_GatewayID in routingmanager.c as static.

Change-Id: I03ff080867d28e3d32a18bb74fa7a9a26e465774
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 075e7cf10b7f5e3cf1f2afbbc6c5d2d7c4a17005)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11801

[IOT-1294] Fixed build failure for WITH_RA_IBB flags

When building code with the WITH_RA_IBB=1 the build
would fail with undefined references to code found in the external
code found in extlibs/libstrophe and extlibs/wksxmppxep.

The code was already being built but was not properly linked by the
linker. This commit adds the library paths and libraries needed to
pass the build.

Change-Id: Ia9a1a6c40f6eeed174caaeb428224b97ffb6b59d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11715
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Optimize stack for Arduino.

In RI, headeroptions are maintained as array with default size as this macro.
A default 100 headeroptions are too high and results in a structure size of 3KB+.
Moreover any vendor will not add 100 CoAP options.
Also optimized few clonings.

Change-Id: I65860c44ec1ba0c3ef2800a88f27ecad0f483568
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit a40e07bb0634b61a810ff1b0faf2c8b51f53cca2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11777

Cloud Acl Management for master branch

Cloud Acl Management moved from cloud-interface to master

Change-Id: Ib35221c06e5dc409dddeed641124d0505fea55a4
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11733
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 7a9211a856c5236420cc84e6aeafdda40a6408a8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11767
Tested-by: Randeep Singh <randeep.s@samsung.com>

Added jni/android implementation for trust cert chain
Provisioning client modified for save and provision cert chain

Change-Id: Iad4b7286ed9076026399d7f7088c4fc39d58c624
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11001
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 98ca376871d06d2ddaf80e0375e4072a3e2f5878)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11721
Tested-by: Randeep Singh <randeep.s@samsung.com>

Fix windows build in master (2)

[Patch #2] Removed duplicate sqlite parse-config for tizen
[Patch #3] Fix typo that causes tizen build fail

Change-Id: I75f6cadc3120d37357278f556ab44eecd7682a01
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11689
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11719

The wrapper unittest is not required"

Change-Id: I3646b0da24192b6a34ceef64f2b4fd602a9a99c8
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11675
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix warning caleadapter and fragmentation

Change-Id: Ib6a83e0c59f2dde92881eb077d7575658deffbb4
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Send normal GET response for register request to
non-observablbe resource(s).

Bug: https://jira.iotivity.org/browse/IOT-1279
Change-Id: I93be3d3dc79bfc782e98ded57ef6cc0122077d7c
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11635
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Cloud Client

Implemented:
1. Cloud Client itself with menu and folders structure
2. CRL/ACL requests according latest spec

[Patch #2] Remove OCPayload to ACL/CRL convertion.
           Convert OCpayload back to char * and
           Use ACL/CRL resource functions to parse and update DB
[Patch #3] Add sync to menu and start userRequests as thread
[Patch #4] Save minor changes before merge both clients
[Patch #5] Merge CSR to this cloud client
[Patch #6] Clean-up changes. Merged cloud client works
[Patch #7] Save minor changes before move to cloud-interface branch
[Patch #8] Store private data
[Patch #9] Implement CRL on device according latest spec
[Patch #10] Minor Crl on device fixes
[Patch #11] Handle review comments
[Patch #12] Implement ACL get info on device according spec
            Remove OC_EXPORT from headers
[Patch #13] Fix CBOR encoding
[Patch #14] Crl last update, crl db changes, fix build error
[Patch #15] Crl Get/Post are fully implemented
[Patch #16] Acl fix uri path'es
[Patch #17] PKIX interface to SRM
[Patch #18] CRL rcsn fix (use String Array instead of String)
[Patch #19] ACL callbacks implemetation (parse and print recv data)
[Patch #20] Complete ACL callbacks
[Patch #21] Update Menu UI
[Patch #22] ACL uid's length fixes
[Patch #23] ACL ace request + CRL encoding fix
[Patch #24] Fix crash when receive empty aclist
[Patch #25] Set public data default encoding to DER
            Fix CRL initialization
[Patch #26, 27] Restore #24
[Patch #28] Fix build error related to PKIX
[Patch #29] ACL few fixes, clean-up code, add comments
[Patch #32] Clean-up csr + handle all review comments
[Patch #34] Revert ocpayload.c changes
[Patch #35] Fix build without WITH_TCP, CRL/ACL clean-up, error on exit
[Patch #37] Fix private data encoding
[Patch #38] Test build on Windows
[Patch #40] Remove accidental changes
[Patch #41] TLS sample fix
[Patch #42] CRL changes to use CBORPayload() functions
[Patch #43] ACL changes to use CBORpayload() + printAcl() + minor fixes
[Patch #44] Added extern C for external linkage to C++
[Patch #45] Revert #44 + acl fix
[Patch #47] Implement OC_LOG_PAYLOAD to show nested objects and arrays
[Patch #48] Fix review comments
            Add dynamic cipher based on SVR
            Change close notify to alert
[Patch #49] Add rootcer.crt and SaveTrustCert in cloudClient sample
[Patch #50] Change cipher priority and add choose cipher option in sample
[Patch #51] Remove accidental changes
[Patch #52] Add RSA cipher selection
[Patch #53] Huge changes in API and handlers to provide it to external team
[Patch #54] Minor fix, clean-up, add comments
[Patch #55] Resoved issue for save TrustCert with PEM in cloudClient sample
[Patch #56] UpdateACE fix, add CoAPs selection to Menu
[Patch #57] Few ACL requests fix, now all of them are working
[Patch #58] Add db file to command-line args + few fixes
[Patch #60] Add alert messages
[Patch #61] Fix cipher selection
[Patch #62] Fix Svace warnings
[Patch #63] Fix acl db issue. Create CBORpayloadToAcl2() for cloud response
            Because in latest spec its wrong we need this workaround
[Patch #64] Fix service folder build error when secured enabled
[Patch #65] Implement responses to cloud cpp wrapper API
[Patch #66] Minor fix to cloud cpp wrapper responses
[Patch #67] Fix Cbor allocation when credresource increase
[Patch #68] Revert wrong changes made in Patch #64
[Patch #69] Remove wrong changes in other SConscript files
[Patch #70] Fix minor build error
[Patch #71] Remove wrong changes from 2 source files + clean-up Sconscripts
[Patch #72] Return back credresource.c + fix crlresource.c for tizen
[Patch #73] Return back richdk scons
[Patch #74] Disable build stack samples without SECURED=1
[Patch #75] Fix OTM PIN
[Patch #76] Fix conflict
[Patch #77,78] Fix tizen build error
[Patch #80] Remove changes in secure stack samples
[Patch #81] Add ours headers to doxygen, update comments, add static
[Patch #83] Fix conflicts with master
[Patch #84] Add Discovery + Get/Put/Post device-to-device requests
            Separate most sample source code to cloud folder
[Patch #86] Arduino build fix
[Patch #87] Resolve merge conflict

Change-Id: Ib83b14a40d49df3b62dd5a1863777c8a5504a4e5
Signed-off-by: Jonsgung Lee<js126.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10785
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>

SimpleBase code clean up

Remove warning and change main page

Change-Id: I1535fe015414462d9320fccddee6ddea9bb7a530
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fixed multicast presence for sample related c-sdk.

Change-Id: I011b0575b34b957ef776a3ca56db0b3f2d751f2b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11329
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1248] Fix multiple APIs throwing wrong exception

Change-Id: Ide5d534e301492bfd5499fa6d1cc7778bf5e7611
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11671
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>

add empty parameter checking in OCAccountManager

Since empty parameter checking for APIs in OCAccountManager is missing,
I added.

And modified signUp API according to the OCF cloud specification.

Change-Id: I23ecc376d3ac6522d411b7a0a9408d79f11fab24
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

remove warning for keepalive

- check return value for OCDoresource

Change-Id: Ia3efa0d8365dd60ecb0c0e7dc751d242bcffa97d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11633
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

add deleteLocalRef for findResource callback

since findResource callback is called for several times.
it is better to call DeleteLocalRef after the variables is used.

Change-Id: I4d7e7eee7bda8ecba2880371fcc1bc87a90e32c1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Enable IPv6 Interface for Android, Tizen

Enable IPv6 Interface for Android, Tizen

Change-Id: Ic92d724556240e4a9f5f77ea2c4b546dc93c2226
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Development of CoAP-HTTP Proxy

Wiki page: https://wiki.iotivity.org/coap-http_proxy
JIRA Issue: https://jira.iotivity.org/browse/IOT-1128

Change-Id: I12a6c53589a428bdc1f94ea6d48a692ac07aabfe
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Update a policy of successful cloud provisioning

If an enrollee already has an ACL and certificate for communication
with Cloudserver, a mediator does not need to provide them.
That is, ACL and certificate provisioning can be skipped for this case.

Change-Id: Id22566e21c22f92b552a3861a41f0de83959dcf3
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11655
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix SetDoxmDeviceId()

Fix SetDoxmDeviceId()
PT check removed
sqlite3 linking removed

Change-Id: I3bced8ba7c8e65ef3b97bea7113eee5cdbde9168
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge "Merge remote-tracking branch 'origin/notification-service' Updated with static analysis."

resource-container: Change file permission of SampleResource sources

Removed the execute permission for the SampleResourceClient.cpp and
SampleResourceServer.cpp files in service/resource-encapsulation/examples/linux

Change-Id: I2ac6381ada31d76aead5e7139ea62d888d1a2877
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Author: Ravi Nanjundappa <nravi.n@samsung.com>
Origin: 1.0.1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11485
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-encapsulation: Avoid reinterpret_cast in const_expr

As unsupported in C++11 standard and g++-6 or clang

Reported error message is:

  service/resource-encapsulation/src/serverBuilder/unittests/RCSResourceObjectTest.cpp:368:13:
  error: reinterpret_cast from integer to pointer
  reinterpret_cast<OCRequestHandle>(0x1234);

Problem was observed while building for Yocto with generic toolchain:
  i586-poky-linux-g++ (GCC) 6.2.0

For reference see p125 of:

  http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3797.pdf

Change-Id: I20b21ad1bdac40c2aec44706501343ae1d9d7b69
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/meta-oic
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

security: Improve with more specific error core and log of it

This improvement has been suggested by Randeep Singh at :

 https://gerrit.iotivity.org/gerrit/#/c/9521/

Also reducing presence of "goto:" is always welcome ;)

Change-Id: I2ca21c37105c530c92e2cfd4b6ae9e3cfbc06231
Origin: https://gerrit.iotivity.org/gerrit/#/c/9543/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge remote-tracking branch 'origin/notification-service'
Updated with static analysis.

Change-Id: I73120da7cafc810f613fd2d9b265366ff773bbd3
Signed-off-by: cc <ch79.cho@samsung.com>

Add setCredID to mediator sample application

To tranfer a certificate to Enrollee, you need to specify a credential ID
corresponding to the certificate.

Change-Id: I79c39ff1a6f0f90175cfe11c6ca7ed719f3cf222
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues(IOT-1263)

IOT-1263:
  [ES][Linux] Get Location API can not get expected location
  (https://jira.iotivity.org/browse/IOT-1263)

Change-Id: Ifc0a088c3d7c8166fdc093976bebb3e84d036295
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues(IOT-1268)

IOT-1268:
  [ES][Android] APIs crashed with null parameter
  (https://jira.iotivity.org/browse/IOT-1268)

Change-Id: I7b3bb5b9eb78df12b60e852a878ee73cb0d1c189
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11521
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add a dependency in building notification-service for android.

After libnotification_provider_wrapper.so is created, its android SDK
should be built.

Change-Id: I6df993e6ccd60f29017cd2e47fe75b2d3cc78892
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11657
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove logs with non-LOGGING build option.

When notification service build on non-Logging mode, log is removed.
For the above reason, newly appeared warning is resolved.

Change-Id: Ibc7a1ee32e3063934ad5fccdaf363707ef5a247c
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11621
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Remove unused task type on consumer service.

Named TASK_CONSUMER_GET_TOPIC_LIST task is remove reason by unused.

Change-Id: Id65cca0a284a4c0d3f216fc74bc9c0d4bcc4edfa
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11631
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for result of static analysis.

Pointer value casting is fixed for valid size.
If statement is fixed.

Change-Id: I4e6304769c683f78caca8eea4f4dc1da5c369a59
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11619
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>

Fix bug for select topic.

When consumer service get topic to provider, consumer id is excepted.
Consumer id is added on request get topic.
linux sample app is updated for print topic.

Change-Id: I383c2032856e034e80241cc49b1601fece04d230
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11625
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>

Add sendMessage for NSProviderSetConsumerTopic and bug fixes for API.

1. Add sendmessage when call NSProviderSetConsumerTopic function.
2. Add bug fixes for API ('\0' case)

Change-Id: If5c204909cb37220ea0c2f007e9224aae0c494b2
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11627
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>