Gert Wollny [Wed, 24 May 2023 15:44:07 +0000 (17:44 +0200)]
virgl: Submit drawid_offset if is not zero
This is needed in the case of multi-draw to evaluate the right gl_DrawID
in the shader.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23196>
Gert Wollny [Wed, 24 May 2023 15:43:57 +0000 (17:43 +0200)]
virgl: Fix IB upload when a start >0 is given
We don't need to add an offset in the buffer, because we submit
the offset where the data was written to to the host. The
correction of this offset is also not needed and results in draw
errors.
Fixes:
0cf5d1f22620d67659bbd632a2400c3a6956a011
gallium: remove PIPE_CAP_INFO_START_WITH_USER_INDICES and fix all drivers
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23196>
Lionel Landwerlin [Thu, 25 May 2023 10:14:56 +0000 (13:14 +0300)]
anv: opportunistically align VMA to 2Mb
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Lionel Landwerlin [Tue, 23 May 2023 07:55:59 +0000 (10:55 +0300)]
anv: further reduce pool alignments
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Lionel Landwerlin [Tue, 23 May 2023 07:00:20 +0000 (10:00 +0300)]
intel: reduce minimum memory alignment on Gfx12.5
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Lionel Landwerlin [Tue, 23 May 2023 06:58:25 +0000 (09:58 +0300)]
anv: update aux-tt alignment requirements for MTL
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Lionel Landwerlin [Tue, 23 May 2023 06:57:20 +0000 (09:57 +0300)]
iris: add a comment about aux-tt alignment requirements
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Lionel Landwerlin [Tue, 23 May 2023 07:10:21 +0000 (10:10 +0300)]
intel: add alignment helper for aux map
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23198>
Mike Blumenkrantz [Thu, 25 May 2023 19:39:50 +0000 (15:39 -0400)]
zink: don't propagate psiz in quads emulation gs
this is pointless
haha.
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23240>
Mike Blumenkrantz [Thu, 25 May 2023 19:37:45 +0000 (15:37 -0400)]
zink: don't remove psiz from linked shaders if the consumer reads it
it's valid for psiz to be piped through successive stages, so don't
delete it unnecessarily
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23240>
Eric Engestrom [Thu, 13 Apr 2023 20:39:37 +0000 (21:39 +0100)]
meson: simplify another "any of" check
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22491>
Eric Engestrom [Wed, 12 Apr 2023 21:06:04 +0000 (22:06 +0100)]
ci/intel: reuse iris_file_list instead of copying its definition
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22456>
Eric Engestrom [Wed, 24 May 2023 21:44:08 +0000 (22:44 +0100)]
bin/ci: fix mistakenly hardcoded repo name in get_gitlab_project()
It didn't matter so far because all callers always pass "mesa".
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23223>
Eric Engestrom [Thu, 25 May 2023 17:01:15 +0000 (18:01 +0100)]
ci/amd: only define AMDGPU_GPU_ID for the duration of the call
This avoids the risk of accidentally forgetting to overwrite it again in
a later call.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23249>
Eric Engestrom [Thu, 25 May 2023 17:00:03 +0000 (18:00 +0100)]
ci/amd: move AMD-specific LD_PRELOAD to AMD config
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23249>
Samuel Pitoiset [Mon, 22 May 2023 07:16:22 +0000 (09:16 +0200)]
ci: uprev vkd3d-proton to 2.9
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23162>
Samuel Pitoiset [Thu, 25 May 2023 08:44:11 +0000 (10:44 +0200)]
radv: fix copying 2D to 3D images
CTS is testing 2D to 3D image copies but the checks are incomplete and
we used to only copy the first slice.
This should fix
dEQP-GLES31.functional.copy_image.non_compressed.*.texture2d_array_to_texture3d
with ANGLE.
Cc: mesa-stable
Suggested-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23231>
Samuel Pitoiset [Fri, 26 May 2023 06:55:18 +0000 (08:55 +0200)]
zink/ci: skip arb_texture_buffer_object@texture-buffer-size-clamp* with RADV
These tests can run OOM and might hang.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23248>
Sergi Blanch Torne [Wed, 8 Feb 2023 14:56:21 +0000 (15:56 +0100)]
ci: Allow zink-radv jobs to be manual when uprev piglit
It is required for the automatic uprev of piglit in mesa to have the
"^zink-radv-.*-valve" jobs in the pipeline that checks an uprev candidate. So,
when there is a change in the file where the revision of piglit is set, those
jobs will be listed as manual.
Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Reviewed-by: Martin Roukala <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21193>
Boyuan Zhang [Tue, 2 May 2023 16:47:00 +0000 (12:47 -0400)]
frontends/va: add default intra idr period
Use default value in case h264->intra_idr_period is not set by app.
Also to avoid dividing by 0 for later calculations in case it's not set.
Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Acked-by: Leo Liu <leo.liu@amd.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22803>
Eric Engestrom [Wed, 24 May 2023 21:58:28 +0000 (22:58 +0100)]
ci_run_n_monitor: add ability to specify the pipeline to use, instead of auto-detecting it
The auto-detection code currently looks for a repo called "mesa" in the
current user's fork (ie. the user providing the api token), which is great for
the common use case, but sometimes needs to be able to be overridden, such as
when running a pipeline in another fork than one's own, when working with
someone else in their fork.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23230>
Rohan Garg [Thu, 15 Dec 2022 16:52:20 +0000 (17:52 +0100)]
util: move pot functions to use existing macros
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Fri, 2 Dec 2022 17:32:26 +0000 (23:02 +0530)]
util: revert back to ALIGN since it moved to util
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Fri, 2 Dec 2022 17:00:15 +0000 (22:30 +0530)]
util: migrate alignment functions and macros to use ALIGN_POT
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Fri, 2 Dec 2022 09:46:25 +0000 (15:16 +0530)]
util: fix ROUND_DOWN_TO alignment type
Alignments can only be unsigned. Cast alignment to uint64_t to keep MSVC
happy.
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Fri, 20 Jan 2023 10:33:16 +0000 (11:33 +0100)]
freedreno: set alignment to next POT
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Tue, 20 Dec 2022 15:19:24 +0000 (16:19 +0100)]
ac/surface: make sure alignment is a POT
Signed-off-by: Rohan Garg <rohan@garg.io>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Rohan Garg [Fri, 2 Dec 2022 15:39:33 +0000 (21:09 +0530)]
iris: correctly set alignment to next power of two for struct size
We're currently aligning the offset to the size of the data structure
itself when the upload manager actually expects a POT. Ideally this
would be the next POT that's greater than the size of the structure.
Fixes:
c24a574e6c78 ("iris: Don't allocate a BO per query object")
Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20153>
Eric Engestrom [Thu, 25 May 2023 21:15:30 +0000 (22:15 +0100)]
docs/relnotes: add sha256sum for 23.1.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23241>
Eric Engestrom [Thu, 25 May 2023 20:01:46 +0000 (21:01 +0100)]
docs: add release notes for 23.1.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23241>
Eric Engestrom [Thu, 25 May 2023 20:04:25 +0000 (21:04 +0100)]
docs: update calendar for 23.1.1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23241>
Jesse Natalie [Wed, 24 May 2023 21:33:48 +0000 (14:33 -0700)]
wsi/win32: Handle acquiring an image while one is already acquired
In the case where the app is attempting to acquire both (since the
min/max num images is 2) swapchain images, we need to wait on the
fence for the next image in the chain.
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23222>
Eric Engestrom [Wed, 24 May 2023 19:39:16 +0000 (20:39 +0100)]
v3dv: fix align() computation for pixel formats with non-POT block sizes
Fixes hundreds of dEQP-VK.api.copy_and_blit.* tests when including the
assert that the alignment in align() is valid, as added in !20153.
Fixes:
3ba839bf734f37f50dfc ("v3dv: align compressed image regions to block size")
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23224>
Konstantin Seurer [Sat, 20 May 2023 12:18:04 +0000 (14:18 +0200)]
radv: Stop using radv_get_int_debug_option
We can use debug_get_num_option instead. Bool options are changed to use
debug_get_bool_option.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23146>
Alyssa Rosenzweig [Sat, 8 Apr 2023 20:31:41 +0000 (16:31 -0400)]
nir: Add intrinsics for multisampling on AGX
sample_mask_agx maps to the AGX instruction used to write out a sample mask.
api_sample_mask_agx is a system value that returns the value of glSampleMask
(or its Vulkan equivalent), used to lower glSampleMask (etc).
This is distinct from sample_mask_in, which we map to the hardware thing and
AND with this as a lowering.
sample_positions_agx is a system value returning the sample positions in a
packed fixed-point format matching the hardware register, used to lower
gl_SamplePositions.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23040>
Eric Engestrom [Thu, 25 May 2023 08:36:37 +0000 (09:36 +0100)]
ci/zink: document new zink-radv-navi10-valve failures
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23234>
Rhys Perry [Fri, 14 Apr 2023 16:50:15 +0000 (17:50 +0100)]
aco/tests: add fix_derivs_in_divergent_cf tests
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Tue, 9 May 2023 18:59:50 +0000 (19:59 +0100)]
aco/tests: improve performance of declaration parsing
Unlike \S, \w only matches characters which are valid in identifiers. This
seems to be much faster, especially for longer identifier names.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Fri, 14 Apr 2023 16:50:04 +0000 (17:50 +0100)]
radv: use fix_derivs_in_divergent_cf
fossil-db (navi21):
Totals from 3256 (2.40% of 135636) affected shaders:
MaxWaves: 65430 -> 64366 (-1.63%)
Instrs: 3517336 -> 3517724 (+0.01%); split: -0.12%, +0.13%
CodeSize:
18963788 ->
18946904 (-0.09%); split: -0.14%, +0.05%
VGPRs: 172464 -> 175872 (+1.98%); split: -0.02%, +2.00%
Latency:
33643792 ->
33643179 (-0.00%); split: -0.12%, +0.12%
InvThroughput: 5912965 -> 5934404 (+0.36%); split: -0.09%, +0.46%
VClause: 60268 -> 60275 (+0.01%); split: -0.12%, +0.13%
SClause: 125227 -> 125241 (+0.01%); split: -0.09%, +0.10%
Copies: 253452 -> 254638 (+0.47%); split: -1.29%, +1.76%
Branches: 100951 -> 100953 (+0.00%); split: -0.00%, +0.00%
PreSGPRs: 186403 -> 185641 (-0.41%)
PreVGPRs: 153751 -> 156915 (+2.06%); split: -0.06%, +2.12%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Fri, 14 Apr 2023 16:49:46 +0000 (17:49 +0100)]
aco: implement texture samples with strict WQM coordinates
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Fri, 14 Apr 2023 14:44:43 +0000 (15:44 +0100)]
aco: implement strict_wqm_coord_amd
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Tue, 21 Mar 2023 14:44:09 +0000 (14:44 +0000)]
aco: add MIMG_instruction::strict_wqm
This lets us use linear VGPRs for part of the texture sample's address.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Fri, 17 Mar 2023 16:44:25 +0000 (16:44 +0000)]
aco: let p_start_linear_vgpr take an operand
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Tue, 21 Mar 2023 14:47:45 +0000 (14:47 +0000)]
aco: remove unused RegType
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Mon, 24 Apr 2023 11:21:04 +0000 (12:21 +0100)]
ac/nir: add fix_derivs_in_divergent_cf
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Tue, 25 Apr 2023 14:37:32 +0000 (15:37 +0100)]
nir/lower_tex: remove lower_array_layer_round_even
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Thu, 6 Apr 2023 10:43:29 +0000 (11:43 +0100)]
radv,radeonsi: use ac_nir_lower_tex
fossil-db (navi21):
Totals from 17279 (12.74% of 135636) affected shaders:
MaxWaves: 270015 -> 269991 (-0.01%)
Instrs:
24847385 ->
24843807 (-0.01%); split: -0.02%, +0.00%
CodeSize:
133215364 ->
133198744 (-0.01%); split: -0.02%, +0.01%
VGPRs: 1217632 -> 1217872 (+0.02%); split: -0.00%, +0.02%
Latency:
405347021 ->
404971784 (-0.09%); split: -0.09%, +0.00%
InvThroughput:
75386590 ->
75350344 (-0.05%); split: -0.07%, +0.03%
VClause: 426986 -> 426821 (-0.04%); split: -0.04%, +0.01%
SClause: 966751 -> 966971 (+0.02%); split: -0.01%, +0.03%
Copies: 1738510 -> 1737970 (-0.03%); split: -0.08%, +0.05%
PreSGPRs: 1169070 -> 1169120 (+0.00%); split: -0.00%, +0.00%
PreVGPRs: 1136102 -> 1136183 (+0.01%); split: -0.00%, +0.01%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Tue, 25 Apr 2023 14:37:02 +0000 (15:37 +0100)]
ac/nir: round layer in ac_nir_lower_tex
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Wed, 5 Apr 2023 15:58:43 +0000 (16:58 +0100)]
ac/nir: add pass for lowering 1d/cube coordinates
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Wed, 5 Apr 2023 14:52:40 +0000 (15:52 +0100)]
nir,vtn,aco,ac/llvm: make cube_face_coord_amd more direct
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Rhys Perry [Wed, 12 Apr 2023 19:12:26 +0000 (20:12 +0100)]
nir/fold_16bit_tex_image: skip tex instructions with backend1
This will be used for RADV/ACO in the future, and I don't want to and
don't have to deal with 16-bit.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22636>
Georg Lehmann [Wed, 5 Apr 2023 09:55:51 +0000 (11:55 +0200)]
util: fix stack dynarray used by multiple tus
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23106>
Alyssa Rosenzweig [Thu, 25 May 2023 12:54:40 +0000 (08:54 -0400)]
panfrost/ci: Skip hanging test
Reported as both slowest test (60s) and a flake in a deqp-runner double-whammy.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23235>
Alyssa Rosenzweig [Thu, 25 May 2023 12:07:43 +0000 (08:07 -0400)]
panfrost/ci: Skip Piglit tests known to crash
A bunch of Piglits cause crashes, at least when run with PAN_MESA_DEBUG=sync.
For many, the crashes are due to faults. Although Piglits are nominally
process-isolated, faults can leak across processes to subpar recovery, meaning
these crashes are liable to cause robust passing tests to flakes. So, skip any
tests known to crash to make sure the coverage is solid.
Given that we run piglit on panfrost in pre-merge CI, but there's nobody
actively working on fixing piglits for panfrost, I think this is the best
compromise. It means we get to keep the coverage (and ensure we don't regress
piglits that are currently passing) but we don't risk flaking CI. Currently
deqp-runner is eating massive numbers of piglit flakes. While it's really great
that the infrastructure is robust in that way, it'd be better to not have those
flakes in CI in the first place (for run time, if not robustness).
If someone starts hacking on Bifrost + desktop OpenGL again for some reason and
fixes these tests locally, they can reenable them then.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23235>
David Heidelberg [Wed, 24 May 2023 10:37:50 +0000 (12:37 +0200)]
ci/llvmpipe: document intel_shader_atomic_float_minmax@execution@ssbo-atomic*
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:40:53 +0000 (12:40 +0200)]
ci/lavapipe: zink failures
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 09:41:34 +0000 (11:41 +0200)]
ci/lavapipe: document subgroups.shuffle.compute.subgroupshuffleup_double_constant crash
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Mon, 22 May 2023 11:29:23 +0000 (13:29 +0200)]
ci: do not fail when SHA1 impl. produce stringop-overreads warning
When SHA1 gets purged from Mesa, drop the override.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Fri, 17 Mar 2023 15:08:07 +0000 (16:08 +0100)]
ci: disable bogus GCC warning with -Warray-bounds
Reported: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109744
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Sat, 20 May 2023 22:47:05 +0000 (00:47 +0200)]
ci: enable shellcheck on whole .gitlab-ci
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Sat, 20 May 2023 20:46:31 +0000 (22:46 +0200)]
ci/zink: disable flaking anv traces
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Mon, 15 May 2023 23:43:08 +0000 (00:43 +0100)]
ci/virpipe: add flakes introduced with CI uprev to Debian 12
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Mon, 15 May 2023 23:32:00 +0000 (00:32 +0100)]
ci/venus: add fail after CI uprev to the Debian 12
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Mon, 15 May 2023 23:12:50 +0000 (00:12 +0100)]
ci/mingw: disable as it's broken
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
Corentin Noël [Mon, 15 May 2023 15:20:58 +0000 (17:20 +0200)]
build-crosvm: Use the pkg-config crate 0.3.27
The support of pkgconf is available since this version.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Tue, 2 May 2023 23:26:29 +0000 (01:26 +0200)]
ci: drop gallium-aux test on msan builds, renable freedreno
gallium-aux test cannot work properly without msan libc,
which we don't have available right now.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 26 Apr 2023 11:16:43 +0000 (13:16 +0200)]
ci/skqp: skqp can't live with compiler named clang-15, provide symlink
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Sat, 25 Mar 2023 12:41:09 +0000 (13:41 +0100)]
ci: add clang-15 and clang++-15 wrapper script
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Sun, 19 Mar 2023 05:01:49 +0000 (06:01 +0100)]
ci/crosvm: install libelogind0 and sysvinit-core for poweroff functionality
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Fri, 17 Mar 2023 00:51:07 +0000 (01:51 +0100)]
ci/apitrace: install win64 apitrace only on x86_64
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Thu, 16 Mar 2023 17:16:29 +0000 (18:16 +0100)]
ci: bump from Debian 11 (bullseye) to 12 (bookworm)
Already in hard-freeze, so we don't have to worry about breaking changes.
Significant changes:
- LLVM 15 is used instead of 11 or 13
- /dev/shm has to be manually mounted
- Debian 12 uses libdrm 2.4.114
- reworked creating of rootfs, from debootstrap to mmdebstrap
- split `create-rootfs.sh` into `lava_build.sh`, `setup-rootfs.sh`, and `strip-rootfs.sh`
- dropped winehq repository for now (Debian wine is up-to-date enough)
- we use wine now, no need to call explicitly call wine64
- bumped libasan from version 6 to 8
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Thu, 25 May 2023 12:36:59 +0000 (14:36 +0200)]
ci: VVL uprev (temporary until new release will be published)
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:27:30 +0000 (12:27 +0200)]
ci: libwayland from 1.18 to 1.21 and wayland protocols from 1.24 to 1.31
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:26:24 +0000 (12:26 +0200)]
ci: bump gfxreconstruct revision up to compatible version with Debian 12
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:18:23 +0000 (12:18 +0200)]
ci: install stock android-libext4-utils (available in 12, bookworm)
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:11:51 +0000 (12:11 +0200)]
ci: bump libdrm from 2.4.110 to 2.4.114 present in Debian 12
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Wed, 24 May 2023 10:03:39 +0000 (12:03 +0200)]
ci: use meson setup and meson install instead of meson and invoking ninja directly
Not primary scope of relevant MR, just some incremental changes.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
David Heidelberg [Thu, 16 Mar 2023 17:05:35 +0000 (18:05 +0100)]
ci: move from pkg-config to pkgconf
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21977>
Eric Engestrom [Thu, 25 May 2023 13:04:56 +0000 (14:04 +0100)]
docs: fix release date of 23.1.0
I forgot to generate this doc when I made the release, and this was the
date when I actually did generate them.
Fixes:
7fe482d4ce48c5d800ca ("docs: add release notes for 23.1.0")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23237>
Iago Toral Quiroga [Wed, 24 May 2023 07:58:31 +0000 (09:58 +0200)]
broadcom/compiler: use scoped barriers
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23228>
Iago Toral Quiroga [Thu, 25 May 2023 06:45:40 +0000 (08:45 +0200)]
broadcom/compiler: flag use of control barriers
We have been relying on NIR's gather info pass for this
but it is not safe unless we are certain we are always
calling it after any other pass that may emit a control
barrier.
As it stands, nir_zero_initialize_shared_memory can emit a
control barrier and we don't call the gather info pass after
it, which is problematic. The only reason this is not really
a problem right now is because for non-scoped barriers (which
is what we currently use) it doesn't emit a scoped barrier, just
a regular memory barrier (which is probably a bug in the pass!),
but as soon as we move to scoped barriers, this is going
to be a problem, since we need to know when we emit a control
barrier to ensure supergroup calculations prevent deadlocks at
the barrier op.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23228>
Alyssa Rosenzweig [Tue, 23 May 2023 16:22:57 +0000 (12:22 -0400)]
zink: Switch to scoped barriers
Rather than translate piles of discrete memory_barrier/control_barrier
instructions, translate the unified scoped_barrier which maps almost directly to
SPIR-V's barrier. Yes, this means I cheated off vtn for the implementation.
v2: Use existing scope translation.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23186>
Erik Faye-Lund [Mon, 15 May 2023 13:53:50 +0000 (15:53 +0200)]
docs: move obsolete extensions to their own list
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Erik Faye-Lund [Mon, 15 May 2023 13:48:25 +0000 (15:48 +0200)]
docs: mark MESA_texture_array as obsolete
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Erik Faye-Lund [Mon, 15 May 2023 13:47:26 +0000 (15:47 +0200)]
docs: mark MESA_swap_frame_usage as obsolete
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Erik Faye-Lund [Mon, 15 May 2023 13:45:26 +0000 (15:45 +0200)]
docs: mark MESA_shader_debug as obsolete
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Erik Faye-Lund [Mon, 15 May 2023 13:41:21 +0000 (15:41 +0200)]
docs: mark MESA_multithread_makecurrent as obsolete
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Erik Faye-Lund [Mon, 15 May 2023 13:39:07 +0000 (15:39 +0200)]
docs: explicitly mark extensions as obsolete
We explicitly mark the other extensions in the OLD-folder as obsolete,
so let's be consistent here.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23029>
Samuel Pitoiset [Thu, 4 May 2023 13:29:39 +0000 (15:29 +0200)]
vulkan/pipeline_cache: remove a bogus assert when inserting objects
If two threads deserialize the raw object at the same time, the
refcount could be more than 1 temporarily.
This can be reproduced with Granite during the multi-threaded pipeline
cache pre-warm on startup, and also with Dota2.
Fixes:
cbab396f549 ("vulkan/pipeline_cache: replace raw data objects on cache insertion of real objects")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22853>
Erik Faye-Lund [Mon, 8 May 2023 08:28:45 +0000 (10:28 +0200)]
radeonsi,radv: use nir_format_linear_to_srgb
There's little point in open-coding this, when we already have a helper
for it.
This adds an fsat to both code-paths. Not sure if that's good or bad, or
if it even matters at all.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23201>
Lionel Landwerlin [Tue, 2 May 2023 21:06:32 +0000 (00:06 +0300)]
iris: rework Wa_14017076903 to only apply with occlusion queries
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes:
415b824bc6 ("iris: implement occlusion query related Wa_14017076903")
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22807>
Eric Engestrom [Wed, 24 May 2023 11:35:17 +0000 (12:35 +0100)]
mailmap: update @mupuf's name
There were a number of variants in the git history:
Martin Peres <martin.peres@linux.intel.com>
Martin Peres <martin.peres@mupuf.org>
Martin Roukala (néé Peres) <martin.roukala@mupuf.org>
Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Last one is the current one, so let's normalize the rest to that.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23229>
Thomas H.P. Andersen [Wed, 3 May 2023 18:50:04 +0000 (20:50 +0200)]
st: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:56 +0000 (20:49 +0200)]
lavapipe: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:48 +0000 (20:49 +0200)]
zink: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:42 +0000 (20:49 +0200)]
virgl: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:35 +0000 (20:49 +0200)]
vc4: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:28 +0000 (20:49 +0200)]
v3d: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:21 +0000 (20:49 +0200)]
svga: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>
Thomas H.P. Andersen [Wed, 3 May 2023 18:49:11 +0000 (20:49 +0200)]
softpipe: remove unused tgsi includes
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22838>