dotnet-bot [Thu, 14 Nov 2019 04:54:42 +0000 (05:54 +0100)]
Merge branch 'master' of /home/vihofer/consolidation/artifacts/coreclr
Viktor Hofer [Thu, 14 Nov 2019 07:03:43 +0000 (08:03 +0100)]
Remove obsolete benchmark projs (dotnet/coreclr#27869)
* Remove obsolete benchmark projects
* Remove myget feed
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9f3fc16483eecfc47fb79c362811d870be02249
dotnet-bot [Thu, 14 Nov 2019 03:38:27 +0000 (04:38 +0100)]
Merge branch 'master' of /home/vihofer/consolidation/artifacts/corefx
Bruce Forstall [Thu, 14 Nov 2019 02:38:59 +0000 (18:38 -0800)]
Fix format job; build with the same dotnet CLI that jitutils uses (dotnet/coreclr#27871)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0dd1f6cb8c0267f214ace5704ffef7a4a8d055eb
Vladimir Sadov [Thu, 14 Nov 2019 02:22:27 +0000 (18:22 -0800)]
Unifying the type used for number of heaps/locks/threads (dotnet/coreclr#27846)
Unifying the type used for number of heaps/locks/threads
It is the same small number and should be just int.
NOTE: Initial number of allocated blocks per generation is also the same as number of heaps.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7405e434daa7341a87f5d5d046b2cc8b26fbb075
Sergey Andreenko [Thu, 14 Nov 2019 01:15:18 +0000 (01:15 +0000)]
Return compGetTieringName printing. (dotnet/coreclr#27873)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dd02c6d34e054eb6b43a5cadfef1ab107c43bfd1
Tomas Weinfurt [Thu, 14 Nov 2019 00:54:26 +0000 (16:54 -0800)]
disable unstable test (dotnet/corefx#42588)
Commit migrated from https://github.com/dotnet/corefx/commit/
5cee7c97d602f294e27c582d4dab81ec388f1d7b
Tomas Weinfurt [Thu, 14 Nov 2019 00:52:58 +0000 (16:52 -0800)]
initial support for serial port on FreeBSD (dotnet/corefx#42519)
* initial support for serial port on FreeBSD
* adjust port name selection
* update packaging
* feedback from review
* fix PortHelper
* update include with AnyOS
Commit migrated from https://github.com/dotnet/corefx/commit/
7a4822f323bcaa18e184cf2403eb68cf1f8c9d28
marcnet80 [Thu, 14 Nov 2019 00:49:54 +0000 (02:49 +0200)]
DictionaryKeyPolicy not applied to keys that contain non primitive ty… (dotnet/corefx#41691)
* DictionaryKeyPolicy not applied to keys that contain non primitive types dotnet/corefx#41176
https://github.com/dotnet/corefx/issues/41176#event-
2697607085
* dotnet/corefx#41176: DictionaryKeyPolicy not applied to keys that contain non primitive types
https://github.com/dotnet/corefx/issues/41176
* add unit tests
https://github.com/dotnet/corefx/pull/41691
* Remove check for JsonExtensionDataAttribute to avoid reflection.
Commit migrated from https://github.com/dotnet/corefx/commit/
d9dd0dac4285368002740333d6772d4db79d82c1
David Mason [Thu, 14 Nov 2019 00:47:10 +0000 (16:47 -0800)]
Add ability to patch corefx binaries from a locally built enlistment for coreclr tests (dotnet/coreclr#27422)
Adds the "localcorefxpath" argument to build-test.cmd
Commit migrated from https://github.com/dotnet/coreclr/commit/
216a3b7fb55c10cfde63397f9f2ba411a6a61518
dotnet-bot [Thu, 14 Nov 2019 00:31:08 +0000 (01:31 +0100)]
Merge branch 'master' of /home/vihofer/consolidation/artifacts/core-setup
Davis Goodin [Thu, 14 Nov 2019 00:38:25 +0000 (18:38 -0600)]
Add automatic SDL validation (dotnet/core-setup#8846)
Commit migrated from https://github.com/dotnet/core-setup/commit/
130c63e15de3227ddad89f8a9b4a24a249e678e8
dotnet-bot [Thu, 14 Nov 2019 00:26:19 +0000 (01:26 +0100)]
Initial runtime repository structure
Krzysztof Wicher [Thu, 14 Nov 2019 00:23:19 +0000 (16:23 -0800)]
HKDF implementation (dotnet/corefx#42567)
* HKDF implementation
* Fix CreateMacProvider on OSX
* apply review feedback
* improve error message in case of test failure
Commit migrated from https://github.com/dotnet/corefx/commit/
c14fc5636bdb9141f69eaeaf0e5812b80af525b1
Jarret Shook [Thu, 14 Nov 2019 00:16:44 +0000 (16:16 -0800)]
Add generatelayoutonly build-test.cmd (dotnet/coreclr#27861)
* Add generatelayoutonly build-test.cmd
* address feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc0ca5071bedfeca58eebdb71a71ea5a750155d0
buyaa-n [Thu, 14 Nov 2019 00:14:46 +0000 (16:14 -0800)]
Large json serialization/deserialization tests (dotnet/corefx#39668)
* Test large json serializaiton/deserialization
* Fixing test failure, applying feedback
* Add circular dependency test with large object
* Added test writing an object right at threshold level, removed unnecessary test cases
* Fixing typo
* Using VS generated POCO for test
* Addressing feedback
* Applying feedback
* Applying feedback
* Applying feedback
* Refactored the test Json schema
* Commenting failing case
* Applying feedback
* Applying feedback
* Enabling fixed tests
Commit migrated from https://github.com/dotnet/corefx/commit/
20334125a70444b5e8cf35f3f661911cd85a78b5
Katarzyna Bułat [Thu, 14 Nov 2019 00:14:02 +0000 (16:14 -0800)]
JSON DOM refactor (dotnet/corefx#41041)
* work on review comments, documentation changes included
* work on including review comments
* work on including review comments
* StringComparison methods improvements
* work on adressing review comments
* helping comment added
* StringComparison tests improved to check all enum values
* setting CurrentCulture test added
* review comments included
* build fixes
* CurrentCulture test removed
* Address nits and react to recent API changes.
Commit migrated from https://github.com/dotnet/corefx/commit/
a0f71fa14ecd17c6aee146b8ef76aaec0dd389ed
mikedn [Wed, 13 Nov 2019 23:50:08 +0000 (01:50 +0200)]
Improve dominator tree building & walking (dotnet/coreclr#27282)
* Delete unused SsaBuilder code
* Delete BasicBlock::bbDfsNum
bbPostOrderNum serves the same purpose
* Improve dominator tree building & walking
- Change the dominator tree data structure to a simple array of nodes
- Adapt fgBuildDomTree so it can be used by SsaBuilder
- Add a dominator tree visitor class
- Reuse the dominator tree built by SsaBuilder for copy propagation
* Move bbNatLoopNum to fill a padding hole
Commit migrated from https://github.com/dotnet/coreclr/commit/
9251ceff0395f989253b7874862feb396b7bddd3
Sinan Kaya [Wed, 13 Nov 2019 23:44:53 +0000 (18:44 -0500)]
ARM32 compilation fixes with GCC (dotnet/coreclr#27795)
* Suppress on clang only
* Fix integer conversion
* Extra qualifier
* Suppress warning
* Extra qualifier
* Signedness issues
* Correct offsetof
* Offsetof doesn't support non-constant values
* Conversion errors
* Move the comment too
* Fix assembly warning
* size is not constant
* Fix comment type
* Fix endmacro name
* Use OFFSET_NONE constant
Commit migrated from https://github.com/dotnet/coreclr/commit/
e8bbcf18be67b864d16e12c13d16f1bea4a9c76e
Tanner Gooding [Wed, 13 Nov 2019 23:41:01 +0000 (15:41 -0800)]
Adding tests for the new apis to convert between S.Numerics and S.R.Intrinsic vectors (dotnet/coreclr#27481)
* Updating Vector128.AsVector3 to have a functioning implementation
* Adding test template metadata covering the new methods for converting between S.Numerics and S.R.Intrinsics
* Regenerating the existing tests
* Generating the new Vector conversion tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
4b902f244e529b7596b1501eea6fdf27753b91ca
Elinor Fung [Wed, 13 Nov 2019 23:32:21 +0000 (15:32 -0800)]
Fix naming in AssemblyLoadFromResolveHandlerInvoked user data template (dotnet/coreclr#27859)
Commit migrated from https://github.com/dotnet/coreclr/commit/
92a61c430e2b433f2b42190cb8ee5ee9170ad365
Peter Sollich [Wed, 13 Nov 2019 23:24:20 +0000 (00:24 +0100)]
Bgc suspension fixes (dotnet/coreclr#27729)
* Changes to set gen0 bricks always. This reduces the time spent in find_first_object when finding the start of objects for marking interior pointers.
* Revert "Changes to set gen0 bricks always. This reduces the time spent in find_first_object when finding the start of objects for marking interior pointers."
This reverts commit dotnet/coreclr@
9d53ff910ceb5482c67350a88e6687b8f94d5634.
* Two fixes to speed up suspension for foreground GCs while background GC is in progress:
- In background_mark_simple1, check g_fSuspensionPending and if it is set, save the state of the work and restart the loop - this will call allow_fgc() and thus allow a foreground GC to take place.
- In revisit_written_page, call allow_fgc() at the end - this allow a foreground GC to happen whenever we are done with revisiting a written page.
* Addressed code review feedback - use counter instead of testing g_fSuspensionPending directly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a7678f5d8e14ad0edc8d996ae4048079c7b2d575
Eric StJohn [Wed, 13 Nov 2019 22:46:42 +0000 (14:46 -0800)]
Make UriTypeConverter better handle relative URIs (dotnet/corefx#42580)
We missed one case in handling relative URIs:
ConvertTo(..., relativeUri, typeof(Uri))
Fix this, add tests, and share the UriKind calculation.
Commit migrated from https://github.com/dotnet/corefx/commit/
136dba176f62308d701b992857d76ea790fd4631
Jeremy Koritzinsky [Wed, 13 Nov 2019 22:14:57 +0000 (14:14 -0800)]
Fix RHEL6 build (dotnet/coreclr#27863)
* Make stripping symbols overridable at install_clr invocation to avoid double-stripping symbols.
* Add SKIP_STRIP option to install_clr parameter list comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
2b9559b69dc0375e42966a96e874a6b81b6334d1
Roman Marusyk [Wed, 13 Nov 2019 22:10:55 +0000 (23:10 +0100)]
Use Strings.resx file for the exception messages (dotnet/corefx#40402)
* Use Strings.resx file for the exception messages within System.Windows.Extensions
* Use Strings resx file for the exception messages within System.Threading
* Use Strings resx file for the exception messages within System.Security.Cryptography.Xml
* Use Strings resx file for the exception messages within System.Runtime.WindowsRuntime
* Use Strings resx file for the exception messages within System.Reflection.Metadata
* Use Strings resx file for the exception messages within System.Private.Xml
* Use Strings resx file for the exception messages within System.Private.DataContractSerialization
* Use Strings resx file for the exception messages within System.Numerics.Tensors
* Use Strings resx file for the exception messages within System.IO.Packaging
* Use Strings resx file for the exception messages within System.IO.FileSystem
* Use Strings resx file for the exception messages within System.Drawing.Common
* Use Strings resx file for the exception messages within System.DirectoryServices
* Use Strings resx file for the exception messages within System.Diagnostics.DiagnosticSource
* Use Strings resx file for the exception messages within System.Composition.Hosting
* Update ExportDescriptorPromise.cs
* Fix build
Commit migrated from https://github.com/dotnet/corefx/commit/
1518fdc5cc94571bf3ce1bb95e1a60f789a67f18
Tomas Weinfurt [Wed, 13 Nov 2019 21:50:57 +0000 (13:50 -0800)]
propagate TLS alerts from OS layers (dotnet/corefx#41967)
* initial alerts with openssl
* get alerts from schannel
* update tests to work with openssl 1.1.x
* fix ClientAsyncAuthenticate_ServerNoEncryption_NoConnect to work properly with Tls13
* remove extra comment
* feedback from review
* feedback from review
* remove unused variable
Commit migrated from https://github.com/dotnet/corefx/commit/
784cb6b5b7e947d3a69c7183847652a0e9335ff0
Tomas Weinfurt [Wed, 13 Nov 2019 21:50:14 +0000 (13:50 -0800)]
Improve diag tracing for NameResolution (dotnet/corefx#42428)
* WIP
* update
* update
* update
* cleanup
* fix windows
* disable GetHostEntryAsync_InvalidHost_LogsError on Windows
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
fe68ec506c7e2c5c104f912d8899778d022905d0
Cody [Wed, 13 Nov 2019 21:18:42 +0000 (13:18 -0800)]
PrintingServices.Unix.cs thread safety, Issue dotnet/corefx#24268 (dotnet/corefx#37724)
* Fix thread-safety of LoadPrinters in PrintingServices.Unix.cs
* Restructure lazy initialization in PrintingServices.Unix.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
cf64918877d98577363bb40d5eafac52beb80a79
Jan Vorlicek [Wed, 13 Nov 2019 21:05:06 +0000 (22:05 +0100)]
Remove exclusion of two runtime assemblies from build in SuperILC (dotnet/coreclr#27857)
The System.Private.CoreLib builds fine using crossgen2 now (I've been
building it locally for a couple of weeks already).
I've also tried to remove exclusion of the
Microsoft.Diagnostics.Tracing.TraceEvent and it is passing now as well.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1fae9e35c6fbd831db551543bc0be32e37fc4e11
Carlos Sanchez Lopez [Wed, 13 Nov 2019 20:26:12 +0000 (12:26 -0800)]
Fix NetStandard issue in System.IO.FileSystem.AccessControl in 5.0 (dotnet/corefx#42546)
Fix NetStandard issue in System.IO.FileSystem.AccessControl
We built the fix incorrectly so that it would only apply for netcoreapp3.0 but customer needs it on netstandard2.0 (desktop + core). Customer impact is that they’ll see a PlatformNotSupported exception rather than the new API.
Commit migrated from https://github.com/dotnet/corefx/commit/
70150e6750c35c9a67803e9cddfda7b1db2ec487
Viktor Hofer [Wed, 13 Nov 2019 19:48:15 +0000 (20:48 +0100)]
Update CoreLib path for consolidation (dotnet/corefx#42577)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc6136f34c7d4ebbc493a7bb6cf1d15bc82250e6
Emmanuel André [Wed, 13 Nov 2019 19:47:18 +0000 (20:47 +0100)]
Add span-based CopyTo and CopyToAsync methods (dotnet/coreclr#27639)
* Add span-based CopyTo and CopyToAsync methods
* Update according to feedback
* Add span-based CopyTo overrides for MemoryStream
* Improve span-based CopyTo arguments validation
To avoid code duplication
* Update according to second review
Stream API is changed
* Resolve InternalReadSpan/Memory inlining
* Refactor ValidateCopyToArgs
* Update according to third review
* Update after fourth review
* Override span CopyTo for UnmanagedMemoryStream
* Apply suggestions from code review
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update after fifth review
* Add cross sync/async support for span-based CopyTo
* Call sync action directly in async context
* Rework cross sync/async support for span-based CopyTo
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
6abc099d4a798dc9a267d04bc025efbcbf148473
Viktor Hofer [Wed, 13 Nov 2019 19:46:54 +0000 (20:46 +0100)]
Update CoreLib sources path and import runtime (dotnet/coreclr#27858)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f2dda30f315b7047f4ec8a5276d888d82f06941
Jan Vorlicek [Wed, 13 Nov 2019 19:40:58 +0000 (20:40 +0100)]
Fix SIMD intrinsics handling in crossgen2 (dotnet/coreclr#27853)
* Fix SIMD intrinsics handling in crossgen2
Crossgen2 was compiling methods that call SIMD intrinsics
(System.Numerics.Vector<T>). This is not correct, as the size of the
vector is a runtime specific detail - e.g. when running on devices
without SSE2 support, the size is 4 and when running on devices with
SSE2 support, the size is 8.
This fixes runtime errors in 6 coreclr pri 0 tests.
* Reflect PR feedback
Create a IsVectorOfT method and use it at all places where we were
previously checking the namespace and type name of Vector<T>
Commit migrated from https://github.com/dotnet/coreclr/commit/
0f9814cc4e25ee4060d8f3ae2305210aef94f1bc
dotnet-maestro[bot] [Wed, 13 Nov 2019 19:31:28 +0000 (19:31 +0000)]
[master] Update dependencies from 4 repositories (dotnet/corefx#42511)
* Update dependencies from https://github.com/dotnet/arcade build
20191108.11
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19558.11
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19558.11
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19558.11
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19558.11
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19558.11
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19558.11
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19558.11
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19558.11
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19558.11
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19558.11
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19558.11
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19558.11
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19558.11
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19558.11
* Update dependencies from https://github.com/dotnet/core-setup build
20191108.7
- Microsoft.NETCore.App - 5.0.0-alpha.1.19558.7
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha.1.19558.7
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha.1.19558.7
* Update dependencies from https://github.com/dotnet/corefx build
20191109.1
- runtime.native.System.IO.Ports - 5.0.0-alpha.1.19559.1
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19559.1
* Update dependencies from https://github.com/dotnet/standard build
20191108.1
- NETStandard.Library - 2.2.0-prerelease.19558.1
* Update dependencies from https://github.com/dotnet/core-setup build
20191109.5
- Microsoft.NETCore.App - 5.0.0-alpha.1.19559.5
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha.1.19559.5
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha.1.19559.5
* Update dependencies from https://github.com/dotnet/corefx build
20191109.6
- runtime.native.System.IO.Ports - 5.0.0-alpha.1.19559.6
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19559.6
* Update dependencies from https://github.com/dotnet/standard build
20191109.1
- NETStandard.Library - 2.2.0-prerelease.19559.1
* Update dependencies from https://github.com/dotnet/standard build
20191110.1
- NETStandard.Library - 2.2.0-prerelease.19560.1
* Update dependencies from https://github.com/dotnet/arcade build
20191111.8
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19561.8
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19561.8
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19561.8
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19561.8
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19561.8
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19561.8
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19561.8
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19561.8
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19561.8
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19561.8
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19561.8
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19561.8
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19561.8
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19561.8
* Update dependencies from https://github.com/dotnet/core-setup build
20191111.10
- Microsoft.NETCore.App - 5.0.0-alpha.1.19561.10
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha.1.19561.10
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha.1.19561.10
* Update dependencies from https://github.com/dotnet/corefx build
20191112.1
- runtime.native.System.IO.Ports - 5.0.0-alpha.1.19562.1
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19562.1
* React to SourceLink package rename
* Update dependencies from https://github.com/dotnet/arcade build
20191112.5
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19562.5
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19562.5
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19562.5
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19562.5
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19562.5
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19562.5
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19562.5
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19562.5
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19562.5
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19562.5
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19562.5
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19562.5
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19562.5
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19562.5
* Update dependencies from https://github.com/dotnet/core-setup build
20191112.8
- Microsoft.NETCore.App - 5.0.0-alpha.1.19562.8
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha.1.19562.8
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha.1.19562.8
* Update dependencies from https://github.com/dotnet/corefx build
20191112.8
- runtime.native.System.IO.Ports - 5.0.0-alpha.1.19562.8
- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19562.8
* Update dependencies from https://github.com/dotnet/standard build
20191112.1
- NETStandard.Library - 2.2.0-prerelease.19562.1
* Fix SQLClient MatchingRefApiCompatBaselines
Now that SQL client no longer builds a netstandard2.0 ref we can't fix
API compat issues with it. Baseline them instead. Rename the file
since this is the only active configuration which requires baselining.
Commit migrated from https://github.com/dotnet/corefx/commit/
e1bd638024a09174c3de6d5ddc0b4f018372d006
Eriawan Kusumawardhono [Wed, 13 Nov 2019 19:23:52 +0000 (02:23 +0700)]
Remove unused locals in System.Data.OleDb (dotnet/corefx#42485)
* emove unused locals in System.Data.OleDband keep some logic using discard. Partially fix issue dotnet/corefx#39962
* Update src/System.Data.OleDb/src/OleDbDataReader.cs
update as suggested (OleDbDataReader)
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update src/System.Data.OleDb/src/OleDbTransaction.cs
Done update as suggested
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update src/System.Data.OleDb/src/RowBinding.cs
Done update as suggested (RowDataBinding)
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update src/System.Data.OleDb/src/RowBinding.cs
Done as suggested
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update src/System.Data.OleDb/src/SafeHandles.cs
Done updating as suggested (SafeHandles)
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
eceea8b4284ca42d8bd0134414b43c835bd80e4c
John [Wed, 13 Nov 2019 19:20:23 +0000 (19:20 +0000)]
Fix Vector128 and Vector256 WithUpper documentation (dotnet/coreclr#27274)
* Update Vector128.cs
* Update Vector256.cs
* Update Vector128.cs
* Update Vector128.cs
* Update Vector256.cs
* Update Vector128.cs
* Update Vector256.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
081243009eacfd7a4bda37dd6d4668cc977c9c18
Jarret Shook [Wed, 13 Nov 2019 17:42:15 +0000 (09:42 -0800)]
Run the format job in a temp dir (dotnet/coreclr#27852)
This will allow us to use whatever version of dotnet we want.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4fe26a4653b5dcc1259b26a7439f96f452cb0d9e
Jan Vorlicek [Wed, 13 Nov 2019 17:04:37 +0000 (18:04 +0100)]
Make SuperILC to execute .cmd/.sh only (dotnet/coreclr#27854)
Until now, SuperILC was executing both .cmd/.sh files of tests and .exe
files it has found in the test folders that didn't match the .cmd/.sh
file names. This is different from how coreclr tests are run in regular
test runs. Only the .cmd/.sh files should be executed, the .exe files
with names not matching the .cmd/.sh files are always just helper
applications used by the tests and not the main test executables.
This change updates SuperILC to execute only the .cmd / .sh, thus
getting rid of about 5 failures from the coreclr pri 1 test runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
76751786c52895a96dac39e83570d14bb2b42b49
Carol Eidt [Wed, 13 Nov 2019 16:00:28 +0000 (08:00 -0800)]
Fix assert when extending lifetimes (dotnet/coreclr#27839)
This assert was added in the prework for EH write-thru. In the case where we're extending lifetimes for stress, we should ignore the locations of these. Note that they aren't reported to codegen anyway.
Fix dotnet/coreclr#27804
Commit migrated from https://github.com/dotnet/coreclr/commit/
1fd33a734290138da009fbd0682f1f4399172b8f
Tom Deseyn [Wed, 13 Nov 2019 15:56:41 +0000 (16:56 +0100)]
SmtpConnection: add _aborted field for debugging SmtpClientTest.TestZeroTimeout hang (dotnet/corefx#42557)
Commit migrated from https://github.com/dotnet/corefx/commit/
7d3a7b7fb8fe648c1f402bb63b55f623c3065e42
Jarret Shook [Wed, 13 Nov 2019 11:51:51 +0000 (03:51 -0800)]
Revert "Upload the final modified version of the tests that is sent to helix (dotnet/coreclr#27826)" (dotnet/coreclr#27851)
This reverts commit dotnet/coreclr@
f46c7a6240bea3f7aac1f5c858204cd5e4940fbd.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3324cea03f7710a9dc57c6dd7823d1a394ce35bb
Leslie Zhai [Wed, 13 Nov 2019 11:07:00 +0000 (19:07 +0800)]
[interpreter] Fix error: use of undeclared identifier 'g_pExecuteBackoutCodeHelperMethod' (dotnet/coreclr#27850)
https://github.com/dotnet/coreclr/issues/27848
Commit migrated from https://github.com/dotnet/coreclr/commit/
25343654668bfa83a280a4b2eec0e6d71c3aa55e
Elinor Fung [Wed, 13 Nov 2019 09:11:41 +0000 (01:11 -0800)]
Add tracing for handling of dependencies for Assembly.LoadFrom (dotnet/coreclr#27833)
Commit migrated from https://github.com/dotnet/coreclr/commit/
80557919596be103e60ce1c90ed4860e0708ff56
Layomi Akinrinade [Wed, 13 Nov 2019 07:08:32 +0000 (23:08 -0800)]
Set values of array and immutable collection properties directly (dotnet/corefx#42420)
* Set values of array and immutable collection properties directly
* Address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
a528006b4536e5b73227285b57d2a56116532506
Santiago Fernandez Madero [Wed, 13 Nov 2019 06:01:54 +0000 (22:01 -0800)]
Move arm jobs to new ArmArch helix queue (dotnet/corefx#42568)
Commit migrated from https://github.com/dotnet/corefx/commit/
d62c8fe5a32ba889017cdc1f69984bb59a9ee5c0
buyaa-n [Wed, 13 Nov 2019 05:59:33 +0000 (21:59 -0800)]
Annotate System.Transactions.Local for nullable (dotnet/corefx#42465)
* Annotate System.Transactions.Local for nullable
* Reverting assert on Transaction.State property and make it nullabe
* Small udpates
* Applying feedback
* Applying feedback
* Update src/System.Transactions.Local/src/System/Transactions/Transaction.cs
Co-Authored-By: Santiago Fernandez Madero <safern@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
8f8b895f843e2b659c8a722c3e38548cfecdb271
Layomi Akinrinade [Wed, 13 Nov 2019 05:25:46 +0000 (21:25 -0800)]
Fix exception tests where we are asserting against the literal message (dotnet/corefx#42569)
* Fix up exception tests where we are asserting against the literal message
* Remove null assignments
Commit migrated from https://github.com/dotnet/corefx/commit/
dd1892dc53e28b481bfab364a08573214d3df462
Jeremy Koritzinsky [Wed, 13 Nov 2019 01:52:49 +0000 (17:52 -0800)]
Update CoreCLR override to use the sharedFramework output folde… (dotnet/core-setup#8842)
* Override the files coming from CoreCLR in the shared framework via the shared-framework folder (no package needed).
* Fix PDB issues. Correctly place cross-targeting files in the correct target path.
* Use NormalizePath to build up paths other than the globs themselves.
* Fix typo missed by rename.
* Normalize as directory. Fix naming.
Commit migrated from https://github.com/dotnet/core-setup/commit/
9af1be8a0a3f3127bbe136908593ce9c3f790169
Ganbarukamo41 [Wed, 13 Nov 2019 01:02:51 +0000 (10:02 +0900)]
Add more test data for str.Replace(char, char) (dotnet/corefx#42521)
* Add more test data for str.Replace(char, char)
* Add longer strings to verify correctness of vectorised implementation
* Add more test cases for coverage
* Add more test cases for coverage
* Fix test data
* Add test data for different Vector<T> counts
Commit migrated from https://github.com/dotnet/corefx/commit/
c43fae9412ed389f20badfa3ed51d5a42251dba2
Jeremy Koritzinsky [Wed, 13 Nov 2019 00:18:18 +0000 (16:18 -0800)]
Install binaries that are part of shared framework into separa… (dotnet/coreclr#27841)
* Change the install_clr command to use cmake_parse_arguments to make it easier to extend and easier to read.
Add additional install_clr commands to install the files that go into the shared framework into the sharedFramework folder.
* Install SOS README.
* Collapse conditions. Output message explaining that we're reading the native version out of the native version header so in the case that the header doesn't exist we get something actionable.
Commit migrated from https://github.com/dotnet/coreclr/commit/
03b7b318ab6641c20baeb37f963c4599a97d9276
Ahson Khan [Wed, 13 Nov 2019 00:10:30 +0000 (16:10 -0800)]
Add test to verify that JsonEncodedText and Utf8JsonWriter use upper-case hex digits when escaping (2). (dotnet/corefx#42566)
* Add test to verify that JsonEncodedText and Utf8JsonWriter use
upper-case hex digits when escaping.
* Add test to verify that JsonEncodedText and Utf8JsonWriter use
upper-case hex digits when escaping.
* Fix spacing issue in expected text.
Commit migrated from https://github.com/dotnet/corefx/commit/
6878693e4bdeb509abfdf51ad40a5a1aae46e2e4
Fadi Hanna [Tue, 12 Nov 2019 23:32:30 +0000 (15:32 -0800)]
Fix an AV in crossgen caused by invalid profiling data (dotnet/coreclr#27842)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e40384b6dfcbd8db3a817528f5619de31dab4e0b
Jeremy Barton [Tue, 12 Nov 2019 23:28:59 +0000 (15:28 -0800)]
Add HashAlgorithm.ComputeHashAsync
Commit migrated from https://github.com/dotnet/corefx/commit/
ac02476cfd31e0aed74e5ea4c9dd0af3d7b1ef7f
Davis Goodin [Tue, 12 Nov 2019 23:26:47 +0000 (17:26 -0600)]
Fix the validation channel's variable name (dotnet/core-setup#8844)
Commit migrated from https://github.com/dotnet/core-setup/commit/
6fab00563d09dca0d2b777a4f0dbda59d19c8546
Anton Landor [Tue, 12 Nov 2019 22:42:27 +0000 (23:42 +0100)]
Support For Getting base-64 String as Byte Array (dotnet/corefx#41467)
* Implemented support for getting Base64 as an equivalent byte array
* New implementation for base-64 support as suggested in review. Added new test cases for it.
* Changed comment
in -> and
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Updated minimum length for TryGetBytesFromBase64 to match minimum length of base-64 string
Co-Authored-By: Günther Foidl <gue@korporal.at>
* Added old Convert.FromBase64String implementation for older platforms. arrayReturnToPool is now cleared before return. Added test cases for edge cases and full branch coverage. Changed magic number to predefined constant.
* Changed catch-all to only catch FormatException. Removed try-finally since it is most likely unnecessary. Now only clears the sliced buffer.
* Changed back to a try-finally solution for readability.
* Using JsonConstants.StackallocThreshold instead of magic number
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Added test to validate TryGetBytesFromBase64(...) gives the corrresulting bytes.
* Allocate to JsonConstants.StackallocThreshold when doing stackalloc
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
6a591b2d24869657094816418c46593337550a32
Geoff Kizer [Tue, 12 Nov 2019 21:52:38 +0000 (13:52 -0800)]
add QuicConnection.NegotiatedApplicationProtocol stub (dotnet/corefx#42563)
Commit migrated from https://github.com/dotnet/corefx/commit/
e717081e0074a0933a24182917c4c45739b85268
Layomi Akinrinade [Tue, 12 Nov 2019 21:15:10 +0000 (13:15 -0800)]
Provide more specific exception message when an enumerable or dictionary cannot be instantiated (dotnet/corefx#42497)
* Provide more specific exception message when an enumerable or dictionary cannot be instantiated
* Address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
961bb667a056bb3b9a5f32e22aed8bb64eaddcad
Jonathan Marler [Tue, 12 Nov 2019 21:05:00 +0000 (14:05 -0700)]
Changes to DBG_printf (dotnet/coreclr#20383)
1. will now restore the original errno in all cases
2. combine the snprintf calls in the if(bHeader) block, the only difference was the file/function string
3. we now check the return value of snprintf and _vsnprintf_s instead of ignoring them. When sprintf fails for the header, we just drop the header, when _vsnprintf_s fails for the message itself, we print an error.
4. replaced an alloca with a statically sized buffer
Commit migrated from https://github.com/dotnet/coreclr/commit/
cec441660fb12bd48dab3e4f234d5a6315121aa0
303248153 [Tue, 12 Nov 2019 20:57:10 +0000 (05:57 +0900)]
Fix out of range access in GetRecycleMemoryInfo (dotnet/coreclr#26873) (dotnet/coreclr#26912)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c2bbb50280edcc03fbf946d89ebc01dfff62d76
Jan Kotas [Tue, 12 Nov 2019 20:24:07 +0000 (21:24 +0100)]
Delete unused Enum.InternalCompareTo (dotnet/coreclr#27837)
Commit migrated from https://github.com/dotnet/coreclr/commit/
012c53ba4644ace6997dec0d608b5fd00a77983c
Geoff Kizer [Tue, 12 Nov 2019 20:00:52 +0000 (12:00 -0800)]
QUIC: Change constructor overloads for passing QuicImplementationProvider (dotnet/corefx#42542)
* change constructor overloads for passing QuicImplementationProvider
* add and use QuicImplementationProviders.Default
* Update src/System.Net.Quic/src/System/Net/Quic/QuicImplementationProviders.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
460c422dc82f2a80cba8f1a900000e199f1bf02a
Tomáš Rylek [Tue, 12 Nov 2019 19:00:59 +0000 (11:00 -0800)]
Pre-consolidation mop up fixes dotnet/coreclr#3 (dotnet/coreclr#27836)
This change contains the remaining fixes I made while digging
through the PR run in the runtime repo:
1) Some more repo-relative vs. coreclr-relative repo adjustments
reflecting the migration process;
2) Make sure that XunitTestBinBase always ends with a directory
separator, otherwise my recent fix for Common folder exclusion
doesn't work;
3) Opportunistically shorten project names of two native interop
test components - as the project name is repeated about 3-4 times
in some intermediate paths, it quickly exceeds the standard
Windows path length limit. Please note there's no functional
change in the test.
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
35e54e804f48ccb8ec4b852fa67a9f88850d214b
Jeremy Barton [Tue, 12 Nov 2019 18:39:41 +0000 (10:39 -0800)]
Re-enable PKCSdotnet/corefx#1 decryption tests
Commit migrated from https://github.com/dotnet/corefx/commit/
08f186eefe3272a5668775e4c47f19f3e390557f
mikedn [Tue, 12 Nov 2019 18:33:18 +0000 (20:33 +0200)]
Some GT_BLK/GT_OBJ related cleanup (dotnet/coreclr#27053)
* Display class layout name in dumps
* Delete unused gtNewBlkOpNode size parameter
* gtNewObjNode always returns a GenTreeObj
* Can't have GTF_VAR_DEATH on a GT_OBJ node
* Delete unnecessary uses of gtNewCpObjNode
* Delete unnecessary uses of gtNewBlockVal
* Delete fgMorphBlkToInd
Modifying nodes in place is the norm in JIT, there's no need for a function to abstract that.
* Delete unused RewriteSIMDOperand keepBlk parameter
* Cleanup Rationalizer::RewriteSIMDOperand
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f9eb95bb1df95911c121fdafd65c3fe8d490a75
devtwogenies [Tue, 12 Nov 2019 17:53:17 +0000 (20:53 +0300)]
add MaskedTextProviderTests (dotnet/corefx#7758) (dotnet/corefx#42513)
* add MaskedTextProviderTests(dotnet/corefx#7758)
* Code review issues are fixed
Commit migrated from https://github.com/dotnet/corefx/commit/
ff3e0409ea6f626696e0d440d05a8d44fefdc344
Vladimir Sadov [Tue, 12 Nov 2019 15:02:02 +0000 (07:02 -0800)]
Fixing an assert in card stealing. (dotnet/coreclr#27822)
* Fixing an assert in card stealing.
* use ifdef to be consistent with other cases in the file
* PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
7aa67a90a682cf885ebab8e450eb845356cd2f1d
Dotnet-GitSync-Bot [Tue, 12 Nov 2019 08:09:19 +0000 (00:09 -0800)]
Fix build breaks (dotnet/coreclr#27832)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
d5bb8bf2437d447750cf0203dd55bb5160ff36b8
Jarret Shook [Tue, 12 Nov 2019 06:25:39 +0000 (22:25 -0800)]
Upload the final modified version of the tests that is sent to helix (dotnet/coreclr#27826)
* Upload the final modified version of the tests that is sent to helix
* Add final test name
Commit migrated from https://github.com/dotnet/coreclr/commit/
f46c7a6240bea3f7aac1f5c858204cd5e4940fbd
Elinor Fung [Tue, 12 Nov 2019 03:55:30 +0000 (19:55 -0800)]
Add tracing for Resolving/AssemblyResolve event handler invocation (dotnet/coreclr#27788)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ba0ab50cccb1e04f4e209cb426fcf05952c4fad0
Stephen Toub [Mon, 11 Nov 2019 23:49:48 +0000 (18:49 -0500)]
Fix StyleCop rule SA1129 ("Do not use default value type constructor") (dotnet/coreclr#42531)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
24aa9ed911fdab705f1337f233afa5985998f761
Santiago Fernandez Madero [Tue, 12 Nov 2019 03:41:12 +0000 (19:41 -0800)]
Fix all configurations build break on SqlClient (dotnet/corefx#42548)
Commit migrated from https://github.com/dotnet/corefx/commit/
63c85b9de80d101262be231ec9c33a915b2013c4
Jarret Shook [Tue, 12 Nov 2019 02:49:33 +0000 (18:49 -0800)]
Fix runincontext path in helixpublish (dotnet/coreclr#27824)
Commit migrated from https://github.com/dotnet/coreclr/commit/
45b667d68b39f80adddfd3980d99cbdeb17d8cd0
David Wrighton [Tue, 12 Nov 2019 00:30:58 +0000 (16:30 -0800)]
Non virtual calls to instance methods non-virtual dispatch on instance interface methods (dotnet/coreclr#27756)
* est for non_virtual_calls_to_instance_methods
* Fix handling of callvirt to instance methods on interface types that are not virtual
- Use call type to indicate if its non-virtual or not, instead of opcode
* Use ilproj to protect against future C# compiler changes
- This test needs to test the use of specific opcodes, and so an IL proj is required
Commit migrated from https://github.com/dotnet/coreclr/commit/
638f59b8bd99af456d21c6a4b64da88025d2ff7d
Jarret Shook [Tue, 12 Nov 2019 00:18:12 +0000 (16:18 -0800)]
runtest changes and cleanup (dotnet/coreclr#27815)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c42b8ce0c62e971cea5790abf256bc34ed2242c9
Günther Foidl [Mon, 11 Nov 2019 23:57:25 +0000 (00:57 +0100)]
HTTP/2 code sharing shell sync-script (dotnet/corefx#42425)
Commit migrated from https://github.com/dotnet/corefx/commit/
cb5be3e9c76c337cb1752b206a50ffc71947aba1
Stephen Toub [Mon, 11 Nov 2019 23:49:48 +0000 (18:49 -0500)]
Fix StyleCop rule SA1129 ("Do not use default value type constructor") (dotnet/corefx#42531)
Commit migrated from https://github.com/dotnet/corefx/commit/
88f40addc220c73794f962f10d288c20c416ede1
David Shulman [Mon, 11 Nov 2019 23:49:41 +0000 (15:49 -0800)]
Fix NegotitateStream (server) on Linux for NTLM (dotnet/corefx#42522)
This PR is a follow up to PR dotnet/corefx#36827 which added support for Linux server-side
GSS-API (AcceptSecContext). This enabled NegotitateStream AuthenticateAsServer*
support. It also provided support for ASP.NET Core to allow Kestrel server to have
Negotiate authentication on Linux.
This PR fixes some problems with Negotiate (SPNEGO) fallback from Kerberos to NTLM.
Notably it passes in a correct GSS Acceptor credential so that fallback will work
correctly. As part of fixing that, I noticed some other problems with returning the
user-identity when NTLM is used.
This was tested in a separate enterprise testing environment that I have created.
It builds on technologies that we have started using like docker containers and Azure
pipelines (e.g. HttpStress). The environment is currently here:
https://dev.azure.com/systemnetncl/Enterprise%20Testing. The extra Kerberos tests
and container support is here: https://github.com/davidsh/networkingtests
When the repo merge is completed, I will work with the infra team to see what things
can be merged back into the main repo/CI pipeline and migrate the test sources to an
appropriate place in the new repo.
Contributes to dotnet/corefx#10041
Contributes to dotnet/corefx#24707
Contributes to dotnet/corefx#30150
Commit migrated from https://github.com/dotnet/corefx/commit/
1054f1fba1b7222c138dcd20d8da80cd893fdd01
ts2do [Mon, 11 Nov 2019 23:35:28 +0000 (17:35 -0600)]
Address bugs in BigInteger (dotnet/coreclr#27280)
* Method Add(ref BigInteger lhs, uint value, ref BigInteger result) would store most of the result blocks into lhs instead of result.
* Method ShiftLeft(ulong input, uint shift, ref BigInteger output) with a shift argument exceeding 32 would generally compute the higher blocks incorrectly.
* Multiply(ref BigInteger lhs, uint value, ref BigInteger result) would not set result._length in some cases.
* IsZero() would incorrectly return false for non-canonical zeros with _length > 0.
Fix:
* Inline Add(ref BigInteger, uint, ref BigInteger) into Add(uint).
* Inline ShiftLeft(ulong, uint, ref BigInteger) into Pow2.
* Inline ExtendBlock and ExtendBlocks into Pow2.
* Properly handle 0 in SetUInt32 and SetUInt64.
Commit migrated from https://github.com/dotnet/coreclr/commit/
65a7947491685a6a3479525334e4178f8eab4b75
Brian Sullivan [Mon, 11 Nov 2019 22:59:36 +0000 (14:59 -0800)]
Implement alive across call for CSE candidates (dotnet/coreclr#27449)
* Added the implementation of CSE live across call algorithm
Fix CSE dataflow for Zero Diffs
Perform backward walk of statements in optValnumCSE_InitDataFlow()
Code Review feedback
- Rename cseTraits to cseLivenessTraits
- Move initialization of cseMaskTraits to optCSE_canSwap
- Rework GT_CALL backwards walk for bbCseGen
- Correct comments
Rename cseBit to cseAvailBit and cseBit2 to cseAvailCrossCallBit
Update CSE_DataFlow to handle calls that kill CSE for live across calls
* Code review feedback, added lots of comments
Fixes printing of EXP_SET BitVecs with more than 64 bits
Commit migrated from https://github.com/dotnet/coreclr/commit/
470910864eca8172e6f8a3c58beb85176b9a4008
Jeremy Barton [Mon, 11 Nov 2019 21:52:25 +0000 (13:52 -0800)]
Rewind the Windows 10 PFX unreadable key point to RS1.
Commit migrated from https://github.com/dotnet/corefx/commit/
6d111f30bc014793f4a676dee5b2451fcd25e4eb
Jeremy Barton [Mon, 11 Nov 2019 20:52:44 +0000 (12:52 -0800)]
Fix a "data too small" error in PasswordBasedEncryption
Found during the Unix PFX reader/writer work, but wasn't directly relevant to that change.
Commit migrated from https://github.com/dotnet/corefx/commit/
2d713265d5aecd5fe34099042e13fe7ba54dcdd1
Anirudh Agnihotry [Mon, 11 Nov 2019 19:53:58 +0000 (11:53 -0800)]
moping up the 10.0.16300 version (dotnet/corefx#42537)
Commit migrated from https://github.com/dotnet/corefx/commit/
5683beb656f8ea3d24635445258662abdcd3de22
Stephen Toub [Mon, 11 Nov 2019 19:10:20 +0000 (14:10 -0500)]
Use Stream's BeginReadInternal from FileStream (dotnet/coreclr#27737)
FileStream has two modes, decided upon at construction time. When it's created in non-async mode, the Read/WriteAsync methods end up queueing work items to invoke the synchronous Read/Write methods. To do this, the base methods on Stream delegate to Begin/EndRead/Write (since they were around first) and then the resulting IAsyncResult is wrapped. However, Stream has an optimization that checks to see whether the derived stream actually overrides Begin/EndXx, and if it doesn't, then it skips using those and goes straight to queueing a work item to Read/Write. However, FileStream does override those, but when it delegates to the base implementation because it's in non-async mode (rather than because it's a type derived from FileStream), going through Begin/EndXx is just unnecessary overhead. So, in the right circumstances, we can call to Stream's special helper instead.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2741eb3358768e823d17f853bf17b08fda6bf58
Anirudh Agnihotry [Mon, 11 Nov 2019 18:43:58 +0000 (10:43 -0800)]
Bumping the assembly version to 5.0.0.0 (dotnet/corefx#41723)
* bumping the assembly Version
* correcting the resx file
* keeping netfx for oleDb
* fiixing the netfx tests as well
* fixing the DataSetExtensionsVersion
* removing netstandard2.0 from ref in datasetextensions
Commit migrated from https://github.com/dotnet/corefx/commit/
9a4ed0d00bc642b015974684c32b00650426429f
Brian Robbins [Mon, 11 Nov 2019 18:36:00 +0000 (10:36 -0800)]
Raw EventListener Design Document (dotnet/coreclr#19941)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab6b7097abe676f62d47efddd43ff3eb012e7882
Eric StJohn [Mon, 11 Nov 2019 18:24:28 +0000 (10:24 -0800)]
Validate member attributes (dotnet/corefx#42427)
* Fix APICompat issues for member attributes
* Addressing more member attribute diffs
* Fix SQLClient build
Commit migrated from https://github.com/dotnet/corefx/commit/
33d0499898434aa2d57e8326317e3d6f6c6401ac
Adeel Mujahid [Mon, 11 Nov 2019 16:55:54 +0000 (18:55 +0200)]
Read ParentProcessId from kinfo_proc for FreeBSD (dotnet/corefx#42517)
* Read ParentProcessId from kinfo_proc for FreeBSD
* Update src/System.Diagnostics.Process/src/System/Diagnostics/Process.FreeBSD.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
* Update src/System.Diagnostics.Process/src/System/Diagnostics/Process.FreeBSD.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
7ff22479f523ea468577daf6819005458f475064
Tanner Gooding [Mon, 11 Nov 2019 16:20:37 +0000 (08:20 -0800)]
Fixing an assert around Avx.ExtractVector128 and Avx2.ExtractVector128 (dotnet/coreclr#27807)
Commit migrated from https://github.com/dotnet/coreclr/commit/
df5c582c89ca17136d99c94643d29d6a7a1fd2fc
Viktor Hofer [Mon, 11 Nov 2019 15:54:10 +0000 (16:54 +0100)]
Avoid importing an Arcade extension point (dotnet/core-setup#8823)
Commit migrated from https://github.com/dotnet/core-setup/commit/
e08174840adbd6ed0d1b5737b1d92333fa7d7e11
Omair Majid [Mon, 11 Nov 2019 15:12:57 +0000 (10:12 -0500)]
Add runtime id for Arch Linux
Like gentoo, Arch Linux is a rolling release and doesn't have explicit
version numbers.
$ cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="0;36"
HOME_URL="https://www.archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux
Commit migrated from https://github.com/dotnet/corefx/commit/
1f08b57bfd197a5492fe2ed0e0c5b2e6de9bf642
Jan Jahoda [Mon, 11 Nov 2019 15:09:04 +0000 (16:09 +0100)]
Remove unnecessary assert in File_Move_Multiple_From_Watched_To_Unwatched_Mac (dotnet/corefx#42527)
* Remove unnecessary check
* re-enable tests
Commit migrated from https://github.com/dotnet/corefx/commit/
42c12be146397e671dd54509e824a79a1f8cc3f7
Adeel Mujahid [Mon, 11 Nov 2019 14:36:16 +0000 (16:36 +0200)]
Deduplicate some build configuration code (dotnet/coreclr#27636)
* Deduplicate some build configuration code
While working on another PR, noticed that currently it requires
updating two places to add a new platform/compiler/architecture
configuration. This PR tries to consolidate the code.
Changes:
* replace `read_array` custom function with a simple `grep -v` call.
* remove `$__PortableLinux` from build-test.sh, as it is unused.
* move argument parsing and few common functions in `build.sh` and
`build-test.sh` in `_build-commons.sh` and sourced it.
* combine the long case-esac block and sort cases alphabetically.
* add missing `hyphen-less|hyphened)` variants.
* sort `CPUName` and `OSName` list.
* changed `__CommonMSBuildArgs` from array to string in
`build-test.sh`, as it is in `build.sh`.
* sort local argument names in build/build-test alphabetically at
declaration site.
* merge `locate_llvm_exec` and `locate_gcc_exec` into a single
`locate_toolchain_exec` cmake function.
* this enables overriding individual llvm tool via `CLR_<TOOLNAME>`
environment variable, as it was supported by `locate_gcc_exec`
today.
* Merge dotnet/master to fix/deduplicate-configs
* Merge conflict
* Move __CrossBuild check back to build.sh
Commit migrated from https://github.com/dotnet/coreclr/commit/
a15413fd520f7f25273b92d1087b5f7964801dba
Stephen Toub [Mon, 11 Nov 2019 14:08:53 +0000 (09:08 -0500)]
Fix StyleCop rule SA1129 ("Do not use default value type constructor") (dotnet/coreclr#27716)
Will enable the rule in corefx once these changes have propagated.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5fd4e7055571f3200b64cf6272c81ede96b6fc8b
Konstantin Baladurin [Mon, 11 Nov 2019 12:47:05 +0000 (15:47 +0300)]
Explicitly enable relro (dotnet/coreclr#25473)
* Explicitly enable relro
We need to enable relro explicitly because in some cases it isn't enabled by
default. For example, clang does it only for openSUSE, ubuntu, alpine and android.
Commit migrated from https://github.com/dotnet/coreclr/commit/
dbe8ee6b5150af9180c1873b962695f0e7802b57
Pieter-Jan Briers [Mon, 11 Nov 2019 12:30:18 +0000 (13:30 +0100)]
Implement SetThreadName in PAL for Linux. (dotnet/coreclr#27182)
* Implement SetThreadName in PAL for Linux.
This means thread names will now show up in gdb, htop, etc... on Linux.
I did not implement this for any other platforms:
I did not have anything to test them with,
and pthread_setname_np's API varies wildly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f5f9606a6eef78256536f667c2df7b2495a8c3d
Sinan Kaya [Mon, 11 Nov 2019 08:20:03 +0000 (03:20 -0500)]
Suppress ms_struct warnings for non-Intel arches (dotnet/coreclr#27801)
* Suppress ms_struct warnings
* Enable for x86 only
Commit migrated from https://github.com/dotnet/coreclr/commit/
a5e90c90d5255a795285ba05163bf0d7878a985e
Stephen Toub [Mon, 11 Nov 2019 08:17:26 +0000 (03:17 -0500)]
Remove unused argument from GetRegionDisplayName (dotnet/coreclr#27806)
* Remove unused argument from GetRegionDisplayName
* Address race conditions in CultureData
While most of the race conditions in this file are benign, in these cases, a thread could end up returning an intermediate value due to multiple potential writes to the same field.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7d8fed40324e45e41ef6a09c98c3dda9490e4fb
Nelson Chen [Sun, 10 Nov 2019 17:25:19 +0000 (10:25 -0700)]
Update SOS_README.md (dotnet/coreclr#27799)
Correct to "out of band"
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b261216c6be2fd9ae0d7a8250604349f404e760
Tomas Weinfurt [Sun, 10 Nov 2019 04:45:23 +0000 (20:45 -0800)]
fix sockets tests on FreeBSD (dotnet/corefx#42518)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc115700c3ece60acd6b8dbe4b0bdb8f6f80c756