Behdad Esfahbod [Wed, 8 Aug 2012 18:33:37 +0000 (14:33 -0400)]
Minor renaming
Behdad Esfahbod [Wed, 8 Aug 2012 18:26:36 +0000 (14:26 -0400)]
Fix cast
https://bugs.freedesktop.org/show_bug.cgi?id=53233
Behdad Esfahbod [Wed, 8 Aug 2012 05:20:45 +0000 (01:20 -0400)]
[OT] Implement fallback positioning
Implemented for Arabic, Hebrew, and generic marks.
Activated if no GPOS table present.
Behdad Esfahbod [Wed, 8 Aug 2012 03:44:47 +0000 (23:44 -0400)]
[hb-old] Fix warnings
Behdad Esfahbod [Wed, 8 Aug 2012 02:41:38 +0000 (22:41 -0400)]
[OT] Start adding fallback positioning
Used when there is no GPOS.
Behdad Esfahbod [Wed, 8 Aug 2012 02:32:23 +0000 (22:32 -0400)]
Minor
Behdad Esfahbod [Wed, 8 Aug 2012 02:25:24 +0000 (22:25 -0400)]
[GSUB] Generalize would_apply()
Fixes logic also, where before we were always matching if glyphs_len==1
and a ligature started with the glyph.
Behdad Esfahbod [Wed, 8 Aug 2012 02:13:25 +0000 (22:13 -0400)]
Add hb_font_glyph_from/to_string
Behdad Esfahbod [Wed, 8 Aug 2012 01:44:25 +0000 (21:44 -0400)]
Minor
Behdad Esfahbod [Wed, 8 Aug 2012 01:12:49 +0000 (21:12 -0400)]
[OT] Apply 'rclt' feature in horizontal mode
'rclt' is "Required Contextual Forms" being proposed by Microsoft.
It's like 'calt', but supposedly always on. We apply 'calt' anyway,
and now apply this too.
Behdad Esfahbod [Tue, 7 Aug 2012 20:57:48 +0000 (16:57 -0400)]
Fix warnings
Behdad Esfahbod [Tue, 7 Aug 2012 20:57:02 +0000 (16:57 -0400)]
More refactoring
Behdad Esfahbod [Tue, 7 Aug 2012 20:51:48 +0000 (16:51 -0400)]
Minor refactoring
Behdad Esfahbod [Tue, 7 Aug 2012 20:45:27 +0000 (16:45 -0400)]
Add Hebrew presentation forms shaping
Lifted from https://bugzilla.mozilla.org/show_bug.cgi?id=728866
Behdad Esfahbod [Tue, 7 Aug 2012 18:11:16 +0000 (14:11 -0400)]
[Graphite] Minor
Behdad Esfahbod [Tue, 7 Aug 2012 17:01:12 +0000 (13:01 -0400)]
Remove enum trailing comma
...again.
Behdad Esfahbod [Tue, 7 Aug 2012 03:06:04 +0000 (23:06 -0400)]
Minor
Behdad Esfahbod [Tue, 7 Aug 2012 02:42:47 +0000 (19:42 -0700)]
[util] Fix leaks
Behdad Esfahbod [Tue, 7 Aug 2012 02:35:04 +0000 (19:35 -0700)]
[Graphite] Fix graphite2 backend with RTL text
Patch from Martin Hosken.
Behdad Esfahbod [Tue, 7 Aug 2012 02:25:39 +0000 (19:25 -0700)]
[Graphite] Port graphite2 backend to new shaper infrastructure
Behdad Esfahbod [Tue, 7 Aug 2012 00:07:19 +0000 (17:07 -0700)]
Remove unnecessary lifecycle bits
We already set recount to INVALID when destroying.
This block was not necessary.
Behdad Esfahbod [Mon, 6 Aug 2012 18:44:10 +0000 (11:44 -0700)]
Fix compiler warnings
Behdad Esfahbod [Mon, 6 Aug 2012 04:16:26 +0000 (21:16 -0700)]
[Indic] Minor, move 'blwf' after 'half'
We don't apply them together anyway. Should not make any difference
right now.
Behdad Esfahbod [Sun, 5 Aug 2012 01:04:57 +0000 (18:04 -0700)]
Speed up hb_set_digest_lowest_bits_t calcs
Behdad Esfahbod [Sun, 5 Aug 2012 00:42:28 +0000 (17:42 -0700)]
Speed up hb_set_digest_common_bits_t calcs
Behdad Esfahbod [Sun, 5 Aug 2012 00:08:38 +0000 (17:08 -0700)]
Enlarge glyph_name buffer
Lohit Devanagari has a glyph named:
u0924_u094D.half_u0930_u094D.blwf.vatu
Behdad Esfahbod [Sat, 4 Aug 2012 23:43:18 +0000 (16:43 -0700)]
Rewrite ARRAY_LENGTH as a template function
Such it wouldn't apply to pointers accidentally.
Behdad Esfahbod [Sat, 4 Aug 2012 01:54:54 +0000 (18:54 -0700)]
[Indic] Fix consonant position font lookup logic
Oops. I broken this badly and the test suite did not notice. That
worries me. Have to investigate.
Behdad Esfahbod [Sat, 4 Aug 2012 01:45:05 +0000 (18:45 -0700)]
Minor
Behdad Esfahbod [Sat, 4 Aug 2012 01:21:13 +0000 (18:21 -0700)]
Fix leak
Behdad Esfahbod [Sat, 4 Aug 2012 00:40:07 +0000 (17:40 -0700)]
[OT] Use general-category, not GDEF class, to decide to zero mark advances
At this point, the GDEF glyph synthesis looks pointless. Not that I
have many fonts without GDEF lying around.
As for mark advance zeroing when GPOS not available, that also is being
replaced by proper fallback mark positioning soon.
Behdad Esfahbod [Sat, 4 Aug 2012 00:23:40 +0000 (17:23 -0700)]
Dn't use gint
Behdad Esfahbod [Thu, 2 Aug 2012 18:21:40 +0000 (14:21 -0400)]
[Indic] Add per-script configuration tables
This concludes the Indic shape_plan work. May do for Arabic also...
Behdad Esfahbod [Thu, 2 Aug 2012 16:21:44 +0000 (12:21 -0400)]
[Indic] Move more stuff to the shape_plan
Almost done. Need to add per-script static tables.
Behdad Esfahbod [Thu, 2 Aug 2012 15:03:39 +0000 (11:03 -0400)]
[Indic] Move more repeated work into shape_plan
Behdad Esfahbod [Thu, 2 Aug 2012 14:46:34 +0000 (10:46 -0400)]
[OT] Add per-complex-shaper shape_plan data
Hookup some Indic data to it. More to come.
Behdad Esfahbod [Thu, 2 Aug 2012 14:07:58 +0000 (10:07 -0400)]
[OT] Pipe shape_plan down to pause_callbacks
Behdad Esfahbod [Thu, 2 Aug 2012 13:44:18 +0000 (09:44 -0400)]
More massaging
Behdad Esfahbod [Thu, 2 Aug 2012 13:38:28 +0000 (09:38 -0400)]
[OT] Port complex_shaper to planner/plan
Behdad Esfahbod [Thu, 2 Aug 2012 13:24:35 +0000 (09:24 -0400)]
[OT] Minor refactoring
Behdad Esfahbod [Thu, 2 Aug 2012 12:42:11 +0000 (08:42 -0400)]
[Indic] Move consonant-position-setting into initial_reordering()
Behdad Esfahbod [Thu, 2 Aug 2012 12:36:40 +0000 (08:36 -0400)]
[GSUB] Wire the font, not just the face, down to substitute()
We need the font for glyph lookup during GSUB pauses in Indic shaper.
Could perhaps be avoided, but at this point, we don't mean to support
separate substitute()/position() entry points (anymore), so there is
no point in not providing the font to GSUB.
Behdad Esfahbod [Thu, 2 Aug 2012 12:11:14 +0000 (08:11 -0400)]
[OT] Hide some API
It was impossible to meaningfully use them from the outside these days.
Behdad Esfahbod [Thu, 2 Aug 2012 12:08:04 +0000 (08:08 -0400)]
Minor
Behdad Esfahbod [Thu, 2 Aug 2012 11:53:18 +0000 (07:53 -0400)]
[Indic] More refactoring of consonant position peeking in the font
To be moved to initial_reordering next...
Behdad Esfahbod [Thu, 2 Aug 2012 11:37:46 +0000 (07:37 -0400)]
[Indic] Refactor
Move all the logic that needs to eventually move into the indic table
into hb-ot-shape-complex-indic-private.hh.
Behdad Esfahbod [Thu, 2 Aug 2012 11:13:55 +0000 (07:13 -0400)]
[Indic] Rename
Behdad Esfahbod [Thu, 2 Aug 2012 09:27:46 +0000 (05:27 -0400)]
[Indic] Streamline feature would_apply()
Comes with some 10% speedup for Devanagari even!
Behdad Esfahbod [Thu, 2 Aug 2012 09:01:11 +0000 (05:01 -0400)]
[Indic] Minor
Behdad Esfahbod [Thu, 2 Aug 2012 08:00:31 +0000 (04:00 -0400)]
[GSUB/GPOS] Check array size before accessing digests
Behdad Esfahbod [Thu, 2 Aug 2012 07:51:51 +0000 (03:51 -0400)]
Use Coverage digests in would_apply
Behdad Esfahbod [Thu, 2 Aug 2012 07:45:53 +0000 (03:45 -0400)]
Minor
Behdad Esfahbod [Thu, 2 Aug 2012 02:17:48 +0000 (22:17 -0400)]
Use wider set digests on 64-bit archs
Behdad Esfahbod [Thu, 2 Aug 2012 01:56:35 +0000 (21:56 -0400)]
[GSUB/GPOS] Remove unused get_coverage() methods
Behdad Esfahbod [Thu, 2 Aug 2012 01:46:36 +0000 (21:46 -0400)]
[GSUB/GPOS] Use Coverage digests as gatekeeper
Gives me a good 10% speedup for the Devanagari test case. Less so
for less lookup-intensive tests.
For the Devanagari test case, the false positive rate of the GSUB digest
is 4%.
Behdad Esfahbod [Thu, 2 Aug 2012 01:18:54 +0000 (21:18 -0400)]
[GSUB/GPOS] Add add_coverage()
Behdad Esfahbod [Thu, 2 Aug 2012 01:06:27 +0000 (21:06 -0400)]
Add hb_set_digest_t
Implement two set digests, and one that combines the two.
Behdad Esfahbod [Thu, 2 Aug 2012 01:05:57 +0000 (21:05 -0400)]
[OT] Templatize Coverage::add_coverage()
Behdad Esfahbod [Wed, 1 Aug 2012 23:03:46 +0000 (19:03 -0400)]
Inline font getters
Behdad Esfahbod [Wed, 1 Aug 2012 22:07:42 +0000 (18:07 -0400)]
Use a lookup table for modified_combining_class
Behdad Esfahbod [Wed, 1 Aug 2012 21:13:10 +0000 (17:13 -0400)]
Inline Unicode callbacks internally
Behdad Esfahbod [Wed, 1 Aug 2012 21:01:59 +0000 (17:01 -0400)]
Move unicode accessors around
Behdad Esfahbod [Wed, 1 Aug 2012 20:23:44 +0000 (16:23 -0400)]
Add hb_unicode_combining_class_t
Behdad Esfahbod [Wed, 1 Aug 2012 17:32:39 +0000 (13:32 -0400)]
Add commentary on the compatibility decomposition in the normalizer
Behdad Esfahbod [Wed, 1 Aug 2012 04:21:09 +0000 (00:21 -0400)]
[hb-old] Adjust mark positioning parameters
Fallback mark positioning works now... With hb-ft and hb-view /
hb-shape at least.
Behdad Esfahbod [Wed, 1 Aug 2012 04:03:41 +0000 (00:03 -0400)]
[old] Implement fontMetrics
Behdad Esfahbod [Wed, 1 Aug 2012 03:41:06 +0000 (23:41 -0400)]
[GPOS] Adjust mark advance-width zeroing logic
If there is no GPOS, zero mark advances.
If there *is* GPOS and the shaper requests so, zero mark advances for
attached marks.
Fixes regression with Tibetan, where the font has GPOS, and marks a
glyph as mark where it shouldn't get zero advance.
Behdad Esfahbod [Wed, 1 Aug 2012 03:10:11 +0000 (23:10 -0400)]
Remove some TODO items
Behdad Esfahbod [Wed, 1 Aug 2012 03:08:25 +0000 (23:08 -0400)]
[OT] Zero mark advances if the shaper desires so
Enabled for all shapers except for Indic.
Behdad Esfahbod [Wed, 1 Aug 2012 02:48:38 +0000 (22:48 -0400)]
[OT] Synthesize glyph classes
Behdad Esfahbod [Wed, 1 Aug 2012 02:43:58 +0000 (22:43 -0400)]
[GSUB] Minor
Behdad Esfahbod [Wed, 1 Aug 2012 02:43:32 +0000 (22:43 -0400)]
[hb-old] Implement getGlyphMetrics()
Still working on it.
Behdad Esfahbod [Wed, 1 Aug 2012 01:36:16 +0000 (21:36 -0400)]
Implement Unicode compatibility decompositions
Based on patch from Philip Withnall.
https://bugs.freedesktop.org/show_bug.cgi?id=41095
Behdad Esfahbod [Wed, 1 Aug 2012 01:10:16 +0000 (21:10 -0400)]
Remove unused function
Behdad Esfahbod [Tue, 31 Jul 2012 18:51:36 +0000 (14:51 -0400)]
[buffer] Minor
Behdad Esfahbod [Tue, 31 Jul 2012 01:08:51 +0000 (21:08 -0400)]
[OT] Streamline complex shaper enumeration
Add a shaper class struct.
Behdad Esfahbod [Mon, 30 Jul 2012 23:54:50 +0000 (19:54 -0400)]
Minor
Behdad Esfahbod [Mon, 30 Jul 2012 23:47:53 +0000 (19:47 -0400)]
More refactoring glyph class access
Behdad Esfahbod [Mon, 30 Jul 2012 23:37:44 +0000 (19:37 -0400)]
[OT] Don't crash if no GDEF available
Behdad Esfahbod [Mon, 30 Jul 2012 23:31:17 +0000 (19:31 -0400)]
Minor
Behdad Esfahbod [Mon, 30 Jul 2012 23:30:01 +0000 (19:30 -0400)]
[GSUB/GPOS] Move glyph props matching around
Behdad Esfahbod [Mon, 30 Jul 2012 22:46:41 +0000 (18:46 -0400)]
[GSUB] Don't erase glyph classes if GDEF does not have glyph classes
Behdad Esfahbod [Mon, 30 Jul 2012 22:40:27 +0000 (18:40 -0400)]
Minor
Behdad Esfahbod [Mon, 30 Jul 2012 22:36:42 +0000 (18:36 -0400)]
[GSUB] Minor
Behdad Esfahbod [Mon, 30 Jul 2012 21:54:38 +0000 (17:54 -0400)]
[Uniscribe] Clean up a bit
Behdad Esfahbod [Mon, 30 Jul 2012 21:48:04 +0000 (17:48 -0400)]
[CoreText] Port to shape_plan infrastructure
Behdad Esfahbod [Mon, 30 Jul 2012 21:22:17 +0000 (17:22 -0400)]
Fix build on Mac
Behdad Esfahbod [Mon, 30 Jul 2012 18:53:41 +0000 (14:53 -0400)]
Unbreak Hangul jamo composition
When we removed the separate Hangul shaper, the specific normalization
preference of Hangul was lost. Fix that. Also, the Thai shaper was
copied from Hangul, so had the fully-composed normalization behavior,
which was unnecessary. So, fix that too.
Behdad Esfahbod [Mon, 30 Jul 2012 17:54:46 +0000 (13:54 -0400)]
[Indic] Recategorize Telugu length marks
Fixes 8 more Telugu tests. Failures at 15 (0.
00154548%).
Behdad Esfahbod [Mon, 30 Jul 2012 16:40:18 +0000 (12:40 -0400)]
Add Hebrew test
Behdad Esfahbod [Mon, 30 Jul 2012 14:50:57 +0000 (10:50 -0400)]
[hb-old] Fix misc leaks
Backport (forward-port?!) from upstream:
commit
3ab7b37bdebf0f8773493a1fee910b151c4de30f
Author: Behdad Esfahbod <behdad@behdad.org>
Date: Mon Jul 30 10:50:22 2012 -0400
Fix misc leaks
https://bugs.freedesktop.org/show_bug.cgi?id=31992
https://bugs.freedesktop.org/show_bug.cgi?id=31993
https://bugs.freedesktop.org/show_bug.cgi?id=31994
https://bugs.freedesktop.org/show_bug.cgi?id=31995
Behdad Esfahbod [Mon, 30 Jul 2012 14:06:42 +0000 (10:06 -0400)]
Don't lock user_data set during destruction if empty
Behdad Esfahbod [Mon, 30 Jul 2012 13:53:06 +0000 (09:53 -0400)]
Fix leak
Behdad Esfahbod [Mon, 30 Jul 2012 06:38:39 +0000 (02:38 -0400)]
[OT] Gain back some lost speed
Behdad Esfahbod [Mon, 30 Jul 2012 06:36:46 +0000 (02:36 -0400)]
[OT] Remove hb_ot_layout_ensure()
I didn't like it from the beginning.
Behdad Esfahbod [Mon, 30 Jul 2012 06:35:07 +0000 (02:35 -0400)]
Minor
Behdad Esfahbod [Mon, 30 Jul 2012 05:46:34 +0000 (01:46 -0400)]
[GSUB] Further adjustments to mark-attachment vs ligation interaction
The
d1d69ec52e75a78575b620a1c456d528b6078170 change broke Kannada badly,
since it was ligating consonants, pushing matra out, and then ligating
with the matra. Adjust for that. See comments.
Behdad Esfahbod [Mon, 30 Jul 2012 04:55:15 +0000 (00:55 -0400)]
[GSUB] Minor
Behdad Esfahbod [Mon, 30 Jul 2012 04:51:47 +0000 (00:51 -0400)]
[GSUB] Don't ligate glyphs attached to different components of ligatures
This concludes the mark-attachment vs ligating interaction fixes (for now).
Behdad Esfahbod [Mon, 30 Jul 2012 04:42:07 +0000 (00:42 -0400)]
Minor