review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 14:55:39 +0000 (14:55 +0000)]

Move SkShader::fLocalMatrix into SkShader constructor.

As a first step towards removing SkShader::setLocalMatrix, which will make
SkShader thread-safe, remove calls to setLocalMatrix that happen immediately
after the shader is being created. Instead, pass the matrix into the constructor
or factory method.

BUG=skia:1976
R=scroggo@google.com, reed@google.com, skyostil@google.com, mtklein@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/245963010

git-svn-id: http://skia.googlecode.com/svn/trunk@14401 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 14:44:54 +0000 (14:44 +0000)]

Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU (https://codereview.chromium.org/248613004/)

Reason for revert:
Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio

Original issue's description:
> Fast path for blurred round rects -- blur a small 9patch rect on the CPU
> And nonlinearly stretch the resulting texture across proxy geometry.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14392

R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/258893010

git-svn-id: http://skia.googlecode.com/svn/trunk@14400 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 14:07:10 +0000 (14:07 +0000)]

Revert of fix contents of render_pictures JSON summary (https://codereview.chromium.org/259703002/)

Reason for revert:
This appears to have caused regressions such as this one: http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release/builds/2117/steps/CheckForRegressions/logs/stdio

Original issue's description:
> fix contents of render_pictures JSON summary
>
> BUG=skia:2043,skia:2044,skia:1942
>
> Committed: http://code.google.com/p/skia/source/detail?r=14391

R=scroggo@google.com, epoger@google.com
TBR=epoger@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2043,skia:2044,skia:1942

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/251103004

git-svn-id: http://skia.googlecode.com/svn/trunk@14399 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 28 Apr 2014 14:06:01 +0000 (14:06 +0000)]

Add missing include for r14397.

git-svn-id: http://skia.googlecode.com/svn/trunk@14398 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 28 Apr 2014 13:58:35 +0000 (13:58 +0000)]

Create SkGlyphCache globals with SkOnce.

VC++ will have magic statics with VS2014, but does not currently have them.
The thread unsafe implementation was causing the DirectWrite bots to randomly
crash when running multi-threaded tests, as gGlobals could be seen as NULL.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/252713002

git-svn-id: http://skia.googlecode.com/svn/trunk@14397 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:39:47 +0000 (13:39 +0000)]

git-sync-deps - handle symbolic links to directories

NOTRY=true
R=mtklein@google.com, borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/258053005

git-svn-id: http://skia.googlecode.com/svn/trunk@14396 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:26:53 +0000 (13:26 +0000)]

Xfermode: SSE2 implementation of darken&lighten mode

With SSE2 optimization, performance of the related two benchmarks will
improve about 45% on desktop i7-3770. Here are the data:
before:
Xfermode_Lighten   8888:  cmsecs =     33.60   565:  cmsecs =     48.84
Xfermode_Darken   8888:  cmsecs =     34.16   565:  cmsecs =     48.99
after:
Xfermode_Lighten   8888:  cmsecs =     18.71   565:  cmsecs =     25.41
Xfermode_Darken   8888:  cmsecs =     18.39   565:  cmsecs =     25.40

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/234653002

git-svn-id: http://skia.googlecode.com/svn/trunk@14395 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:19:40 +0000 (13:19 +0000)]

roll DEPS/android/jpeg to current master.

R=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/255953003

git-svn-id: http://skia.googlecode.com/svn/trunk@14394 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:19:34 +0000 (13:19 +0000)]

gpuveto tool

This CL adds a command line tool to report the suitableForGpuRasterization status of a single skp file.

R=bsalomon@google.com, rmistry@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/259663004

git-svn-id: http://skia.googlecode.com/svn/trunk@14393 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:19:23 +0000 (13:19 +0000)]

Fast path for blurred round rects -- blur a small 9patch rect on the CPU
And nonlinearly stretch the resulting texture across proxy geometry.

BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/248613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14392 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 28 Apr 2014 13:18:39 +0000 (13:18 +0000)]

fix contents of render_pictures JSON summary

BUG=skia:2043,skia:2044,skia:1942
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/259703002

git-svn-id: http://skia.googlecode.com/svn/trunk@14391 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 27 Apr 2014 19:21:51 +0000 (19:21 +0000)]

teach TSAN about SkSpinlock, SkRefCnt, and SkOnce

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14353

NOTRY=true
NOTREECHECKS=true

Committed: http://code.google.com/p/skia/source/detail?r=14354

R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14390 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 27 Apr 2014 19:14:46 +0000 (19:14 +0000)]

Revert of teach TSAN about SkSpinlock, SkRefCnt, and SkOnce (https://codereview.chromium.org/247813005/)

Reason for revert:
breaks blink in roll

Original issue's description:
> teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14353
>
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=14354

R=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/258783005

git-svn-id: http://skia.googlecode.com/svn/trunk@14389 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 27 Apr 2014 15:19:34 +0000 (15:19 +0000)]

Whitespace change to test new 50 GCE compile bots.

TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:2449

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/257993002

git-svn-id: http://skia.googlecode.com/svn/trunk@14388 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 26 Apr 2014 03:04:35 +0000 (03:04 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14387 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 22:03:39 +0000 (22:03 +0000)]

Tune bench expectation algorithm parameters.

BUG=skia:2225
NOTRY=true
NOTREECHECKS=true
R=bsalomon@google.com
TBR=bsalomon@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/251813003

git-svn-id: http://skia.googlecode.com/svn/trunk@14386 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 19:59:44 +0000 (19:59 +0000)]

rebaseline_server unittests: output tkdiff lines when actuals don't match expectations

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/252583005

git-svn-id: http://skia.googlecode.com/svn/trunk@14385 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Fri, 25 Apr 2014 15:37:00 +0000 (15:37 +0000)]

Re-add SkPictureStateTree::Iterator::draw() SaveFlags.

This is a SkPictureStateTree-only revert of r14253.

https://codereview.chromium.org/241453003

(It introduced ChromeOS regressions and the later r14319 fix got
reverted for different reasons).

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/250803006

git-svn-id: http://skia.googlecode.com/svn/trunk@14384 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 15:13:27 +0000 (15:13 +0000)]

Revert of Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag. (https://codereview.chromium.org/246893005/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=366889

Original issue's description:
> Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
>
> The current implementation relies on soon-to-be-deprecated
> kClip_SaveFlag behavior. Updated to use default save flags
> (kMatrixClip_SaveFlag) and stop assuming that the matrix survives
> restore() calls.
>
> R=junov@chromium.org,robertphillips@chromium.org,reed@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14319

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/250733007

git-svn-id: http://skia.googlecode.com/svn/trunk@14383 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 14:03:52 +0000 (14:03 +0000)]

one more tsan fix

BUG=skia:2460
R=mtklein@google.com
TBR=mtklein

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/255893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14382 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 13:59:27 +0000 (13:59 +0000)]

Add TSAN suppressions.

BUG=skia:1792,skia:2459
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/259843002

git-svn-id: http://skia.googlecode.com/svn/trunk@14381 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 13:54:53 +0000 (13:54 +0000)]

bench rebase test cc9dbfb
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/257893002

git-svn-id: http://skia.googlecode.com/svn/trunk@14380 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 13:42:21 +0000 (13:42 +0000)]

pathops debug globals use atomic increment

R=mtklein@google.com
TBR=mtklein
BUG=skia:2460

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/257773007

git-svn-id: http://skia.googlecode.com/svn/trunk@14379 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 12:59:11 +0000 (12:59 +0000)]

fix minor skp-found bugs

remove globals from pathops_unittest

BUG=skia:2460
TBR=mtklein

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/239563004

git-svn-id: http://skia.googlecode.com/svn/trunk@14378 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 09:44:53 +0000 (09:44 +0000)]

Xfermode: SSE2 implementation of colordodge&colorburn modes

With SSE2 optimization, performance of the related benchmarks will improve
about 45% for Xfermode_ColorDodge and little for Xfermode_ColorBurn on
desktop i7-3770. The little performance improvement for
Xfermode_ColorBurn is due to the portable version may mostly go the fast
if branch while the SSE2 version do the calculation for all the three
if-else branches. Here are the data:
before:
Xfermode_ColorDodge   8888:  cmsecs =  73.71   565:  cmsecs =  82.88
Xfermode_ColorBurn   8888:  cmsecs =  46.46   565:  cmsecs =  52.23
after:
Xfermode_ColorDodge   8888:  cmsecs =  39.70   565:  cmsecs =  47.45
Xfermode_ColorBurn   8888:  cmsecs =  45.02   565:  cmsecs =  51.15

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/224823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14377 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 08:34:41 +0000 (08:34 +0000)]

Xfermode: SSE2 implementation of softlight_modeproc

With SSE2 optimization, performance of Xfermode_SoftLight will improve
about 30% on desktop i7-3770. Here are the data:
before:
Xfermode_SoftLight 8888: cmsecs = 379.44 565: cmsecs = 387.74
after:
Xfermode_SoftLight 8888: cmsecs = 272.29 565: cmsecs = 284.31

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/236363012

git-svn-id: http://skia.googlecode.com/svn/trunk@14376 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 07:41:18 +0000 (07:41 +0000)]

Xfermode: SSE2 implementation of difference_modeproc

With SSE2 optimization, performance of Xfermode_Difference will improve
about 60% on desktop i7-3770. Here are the data:
before:
Xfermode_Difference 8888: cmsecs = 51.10 565: cmsecs = 66.39
after:
Xfermode_Difference 8888: cmsecs = 21.10 565: cmsecs = 29.33

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/234433003

git-svn-id: http://skia.googlecode.com/svn/trunk@14375 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 06:21:30 +0000 (06:21 +0000)]

Use EXT_direct_state_access for path matrix manipulation

Use EXT_direct_state_access for path matrix manipulation when using
NV_path_rendering extension. This makes Chromium command buffer
integration easier, since the current matrix mode does not need to be
exposed as state and fewer function calls and enums are needed.

BUG=chromium:344330
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/245963009

git-svn-id: http://skia.googlecode.com/svn/trunk@14374 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 05:23:51 +0000 (05:23 +0000)]

Xfermode: SSE2 implementation of hardlight mode

With SSE2 optimization, performance of Xfermode_HardLight will improve
about 45% on desktop i7-3770. Here are the data:
before:
Xfermode_HardLight 8888: cmsecs = 48.43 565: cmsecs = 63.11
after:
Xfermode_HardLight 8888: cmsecs = 25.71 565: cmsecs = 33.46

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/229003004

git-svn-id: http://skia.googlecode.com/svn/trunk@14373 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 25 Apr 2014 03:05:58 +0000 (03:05 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14372 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 02:59:04 +0000 (02:59 +0000)]

Xfermode: SSE2 implementation of exclusion_modeproc

With SSE2 optimization, performance of Xfermode_Exclusion will improve
about 50% on desktop i7-3770. Here are the data:
before:
Xfermode_Exclusion 8888: cmsecs = 40.17 565: cmsecs = 55.22
after:
Xfermode_Exclusion 8888: cmsecs = 18.53 565: cmsecs = 26.55

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/233733005

git-svn-id: http://skia.googlecode.com/svn/trunk@14371 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 25 Apr 2014 02:08:31 +0000 (02:08 +0000)]

Xfermode: SSE2 implementation of overlay_modeproc

With SSE2 optimization, performance of Xfermode_Overlay will improve
about 35% on desktop i7-3770. Here are the data:
before:
Xfermode_Overlay 8888: cmsecs = 44.17 565: cmsecs = 59.27
after:
Xfermode_Overlay 8888: cmsecs = 28.30 565: cmsecs = 35.84

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/232783002

git-svn-id: http://skia.googlecode.com/svn/trunk@14370 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 25 Apr 2014 00:02:12 +0000 (00:02 +0000)]

Fix r14368 (First pass at GPU veto) for non-GPU builds

https://codereview.chromium.org/255733002/

git-svn-id: http://skia.googlecode.com/svn/trunk@14369 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 21:53:13 +0000 (21:53 +0000)]

First pass at GPU veto

As a short term solution this CL collects information during the recording process for use in suitableForGpuRasterization.

BUG=366495
R=bsalomon@google.com, reed@google.com, alokp@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/251533004

git-svn-id: http://skia.googlecode.com/svn/trunk@14368 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 21:51:58 +0000 (21:51 +0000)]

Deprecate SaveFlags use in the public SkCanvas API.

Because we still have internal users for now (to support the deprecated
mode), this CL introduces an external-only variant of deprecation.

Chromium is no longer using the deprecated methods, but Android may need
to suppress SK_ATTR_EXTERNALLY_DEPRECATED warnings.

R=reed@google.com, robertphillips@google.com, scroggo@google.com, bungeman@google.com, mtklein@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246023008

git-svn-id: http://skia.googlecode.com/svn/trunk@14367 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Apr 2014 21:23:37 +0000 (21:23 +0000)]

Fix int->scalar warning on windows

Review URL: https://codereview.chromium.org/257693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14366 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 21:03:00 +0000 (21:03 +0000)]

Add GM that exercises SkCanvas::discard()

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/252443007

git-svn-id: http://skia.googlecode.com/svn/trunk@14365 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 20:17:24 +0000 (20:17 +0000)]

Revert of Add nanosecond timer. (https://codereview.chromium.org/250243002/)

Reason for revert:
breaks EVERYTHING

Original issue's description:
> Add nanosecond timer.
>
> I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14362

R=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/258703002

git-svn-id: http://skia.googlecode.com/svn/trunk@14364 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 24 Apr 2014 20:12:38 +0000 (20:12 +0000)]

Rework ATI driver suppressions for bench valgrind

Review URL: https://codereview.chromium.org/256623003

git-svn-id: http://skia.googlecode.com/svn/trunk@14363 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 20:04:20 +0000 (20:04 +0000)]

Add nanosecond timer.

I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures.

BUG=skia:2378
R=bsalomon@google.com, mtklein@google.com, bungeman@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/250243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14362 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 19:30:16 +0000 (19:30 +0000)]

Remove unused include.

vector is not used by this file (and this breaks the Android framework
build).

R=sugoi@google.com, bungeman@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/251483004

git-svn-id: http://skia.googlecode.com/svn/trunk@14361 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 18:55:13 +0000 (18:55 +0000)]

Reland "Properly set alpha type in webp decode."

Also use the newer setConfig function.

Add a test to confirm that we set the alpha type properly.

Add some images with alpha for testing. (These images are also
beneficial for the compare_unpremul test, which was previously
not meaningful on 100% opaque images.)

All of the added images are in the public domain. They were
taken from https://developers.google.com/speed/webp/gallery2:

yellow_rose:
"Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers"
Image Author: Jon Sullivan
This file is in the public domain.
http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg

baby_tux:
"baby tux for my user page"
Image Author: Fizyplankton
This file is in the public domain.
http://www.minecraftwiki.net/images/8/85/Fizyplankton.png

NOTRY=true

TBR=halcanary@google.com

BUG=skia:2388

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/252423008

git-svn-id: http://skia.googlecode.com/svn/trunk@14360 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 18:45:17 +0000 (18:45 +0000)]

Fix build: these asserts are always now true, which GCC warns about

R=mtklein@google.com
TBR=reed
NOTRY=true
NOTREECHECKS=true

BUG=skia:

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/256453007

git-svn-id: http://skia.googlecode.com/svn/trunk@14359 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 18:36:36 +0000 (18:36 +0000)]

Fix android_gdbserver script to work with changes from a137675.

Also stop assuming ANDROID_ARCH one of x86 or arm.

NOTRY=true
R=mtklein@google.com, djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/256413006

git-svn-id: http://skia.googlecode.com/svn/trunk@14358 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 18:17:30 +0000 (18:17 +0000)]

fix int/size_t warnings in pipe

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/256443002

git-svn-id: http://skia.googlecode.com/svn/trunk@14357 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 18:16:13 +0000 (18:16 +0000)]

simplify tools/xsan_build now that make runs ninja

BUG=skia:
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/257613004

git-svn-id: http://skia.googlecode.com/svn/trunk@14356 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 16:54:46 +0000 (16:54 +0000)]

Remove support for inheriting the paint color from SkColorShader

BUG=skia:2453
R=reed@google.com, mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/248033003

git-svn-id: http://skia.googlecode.com/svn/trunk@14355 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 15:40:46 +0000 (15:40 +0000)]

teach TSAN about SkSpinlock, SkRefCnt, and SkOnce

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14353

NOTRY=true
NOTREECHECKS=true
R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14354 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 15:33:54 +0000 (15:33 +0000)]

teach TSAN about SkSpinlock, SkRefCnt, and SkOnce

BUG=skia:
R=bsalomon@google.com, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247813005

git-svn-id: http://skia.googlecode.com/svn/trunk@14353 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 15:33:48 +0000 (15:33 +0000)]

Proof of adoption in SkRecord::replace.

It used to be an unenforced requirement that callers take ownership of
the command which was replaced when calling SkRecord::replace.  Now we
can enforce it, by splitting replace into two modes:
  - T* replace(i): always destroys the existing command for you
  - T* replace(i, proofOfAdoption): proofOfAdoption is checked to make
    sure the caller has adopted the existing command before replacing it.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/248053008

git-svn-id: http://skia.googlecode.com/svn/trunk@14352 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 15:22:55 +0000 (15:22 +0000)]

Rearrange SkRecord public API to fit better with cc/resources/picture

BUG=skia:2378
R=reed@google.com, danakj@chromium.org, enne@chromium.org, mtklein@google.com, robertphillips@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/248033002

git-svn-id: http://skia.googlecode.com/svn/trunk@14351 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 15:16:32 +0000 (15:16 +0000)]

android scripts respect SKIA_OUT, if already set.

R=scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/250303002

git-svn-id: http://skia.googlecode.com/svn/trunk@14350 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 24 Apr 2014 13:59:18 +0000 (13:59 +0000)]

Restore SkPicture-related guard flags for Chrome

https://codereview.chromium.org/255543004/

git-svn-id: http://skia.googlecode.com/svn/trunk@14349 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 13:55:16 +0000 (13:55 +0000)]

Whitespace change to trigger the new GCE compile bots.

BUG=skia:2449
TBR=
NOTRY=True
NOTREECHECKS=True

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/257593005

git-svn-id: http://skia.googlecode.com/svn/trunk@14348 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 12:51:19 +0000 (12:51 +0000)]

Remove 2 SkPicture-related flags Chrome should be able to live without

R=bsalomon@google.com
TBR=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/252403003

git-svn-id: http://skia.googlecode.com/svn/trunk@14347 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 24 Apr 2014 03:05:07 +0000 (03:05 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14346 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 24 Apr 2014 00:42:23 +0000 (00:42 +0000)]

Fix for r14341 Chrome build error

https://codereview.chromium.org/252393003/

git-svn-id: http://skia.googlecode.com/svn/trunk@14345 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 24 Apr 2014 00:23:20 +0000 (00:23 +0000)]

remove unused functions

R=scroggo@google.com
TBR=scroggo@google.com

BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/251393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14344 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 23 Apr 2014 23:07:00 +0000 (23:07 +0000)]

Add a missing SK_API to SkImageFilter::Cache.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/251353003

git-svn-id: http://skia.googlecode.com/svn/trunk@14343 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 22:53:02 +0000 (22:53 +0000)]

fix x86 emulator for Android framework.

The emulator is the one case where the android framework can be
compiled without SSSE3 but be expected to run on a device with
SSS3. In that case we just disable all SSSE3 options to be safe.

R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/249883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14342 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 22:35:42 +0000 (22:35 +0000)]

First step in pulling SkPicturePlayback & SkPictureRecord out of SkPicture

This CL begins the process of making SkPicturePlayback & SkPictureRecord independent of SkPicture. It just moves the PathHeap into SkPicture to get a feel for where all this is going to lead.

Some items of note:

SkTimedPicture (debugger/QT) should wind up being just an SkPicturePlayback-derived object.

All the flattening & unflattening should migrate out of SkPicturePlayback and into SkPicture.

SkPicture::initForPlayback should eventually become something just SkPictureRecorder::endRecording calls.

SkPicture is passed into SkPicturePlayback's & SkPictureRecord's constructors. SkPicturePlayback only
holds onto a "const SkPicture*". The SkPicturePlayback:: CreateFromStream & CreateFromBuffer methods pass a non-const
SkPicture* down the call stack.

BUG=skia:2315
R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/249453002

git-svn-id: http://skia.googlecode.com/svn/trunk@14341 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 21:55:28 +0000 (21:55 +0000)]

add one-channel output support to webp encoder

BUG=
R=halcanary@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/249853003

git-svn-id: http://skia.googlecode.com/svn/trunk@14340 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Apr 2014 21:21:48 +0000 (21:21 +0000)]

rebaseline filltypespersp on ubuntu for nvprmsaa4

BUG=skia:

Review URL: https://codereview.chromium.org/249693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14339 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 21:03:45 +0000 (21:03 +0000)]

Rename benchmark classes, hopefully less confusing to valgrid?

I was able to reproduce the problem, but Valgrind was giving me a very odd
report, pointing to a particular line in QuadTreeBench.cpp from a stack that
was running RTreeBench.

Whenever Valgrind complains, it's always about switch(fQuery), line 109 in
QuadTreeBench or 119 in RTreeBench.  I can't see any way that fQuery is not
initialized.

I believe we've just confused Valgrind by linking together  classes with
identical names.  This CL gives them all unique names.

BUG=skia:2455
R=bungeman@google.com, mtklein@google.com, bsalomon@google.com, borenet@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247913003

git-svn-id: http://skia.googlecode.com/svn/trunk@14338 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Apr 2014 20:25:04 +0000 (20:25 +0000)]

Add valgrind suppressions for fglrx

BUG=skia:2450
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/248963005

git-svn-id: http://skia.googlecode.com/svn/trunk@14337 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 20:07:19 +0000 (20:07 +0000)]

Revert of Properly enable S32_D16_filter_DX_SSE2 optimization. (https://codereview.chromium.org/239453010/)

Reason for revert:
Broke GMs in 565 mode. To repro:
out/Debug/gm --match filterbitmap_image_mandrill -w . --config 565
open filterbitmap_image_mandrill_512.png_565.png

Original issue's description:
> Properly enable S32_D16_filter_DX_SSE2 optimization.
>
> Currently, the S32_D16_filter_DX_SSE2 optimization is only used in
> configurations where the maximum SSE level is SSE2.
> This patch enables it for higher levels, as well.
> Also, refactored the function a bit, to make future modifications
> less error-prone.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14333

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com
TBR=djsollen@google.com, henrik.smiding@intel.com, joakim.landberg@intel.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/246393013

git-svn-id: http://skia.googlecode.com/svn/trunk@14336 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:26:38 +0000 (19:26 +0000)]

Use default save() flags in SkBlurDrawLooper.

SkBlurDrawLooper::BlurDrawLooperContext::next() is explicitely saving
the matrix - but it doesn't rely on any clip changes persisting after
restore().

Use the default flags instead (previous internal SaveFlags cleanup
missed this user).

R=robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/249733002

git-svn-id: http://skia.googlecode.com/svn/trunk@14335 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:26:26 +0000 (19:26 +0000)]

Use fixed function pipeline only when drawing paths

Use fixed function pipeline only when drawing paths. Previously FF
vertex shader was used when drawing normal geometry if path rendering
was enabled.

This is required to make Chromium integration easier. This way
fixed function vertex shading, including vertexshader-less programs,
need not be implemented in the Chromium command buffer.

Removes FF TexGen functionality, as it is not used anymore. Likewise
removes the fixedFunctionSupport GL capability flag.

BUG=chromium:344330
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/212753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14334 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:26:15 +0000 (19:26 +0000)]

Properly enable S32_D16_filter_DX_SSE2 optimization.

Currently, the S32_D16_filter_DX_SSE2 optimization is only used in
configurations where the maximum SSE level is SSE2.
This patch enables it for higher levels, as well.
Also, refactored the function a bit, to make future modifications
less error-prone.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/239453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14333 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:19:44 +0000 (19:19 +0000)]

fix size_t/int warnings

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/247753003

git-svn-id: http://skia.googlecode.com/svn/trunk@14332 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:18:15 +0000 (19:18 +0000)]

Use textContent instead of innerText.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/249113004

git-svn-id: http://skia.googlecode.com/svn/trunk@14331 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:18:09 +0000 (19:18 +0000)]

stop using deprecated bitmap::config for gpu

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/248473006

git-svn-id: http://skia.googlecode.com/svn/trunk@14330 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:18:03 +0000 (19:18 +0000)]

Remove guards Chromium no longer needs

Note: Android still needs these guards.

Committed: http://code.google.com/p/skia/source/detail?r=14299

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/246403004

git-svn-id: http://skia.googlecode.com/svn/trunk@14329 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 19:10:51 +0000 (19:10 +0000)]

Revert of Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/249643002/)

Reason for revert:
Chromium side change landed along side DEPS roll that includes r14323.

Original issue's description:
> Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/)
>
> Reason for revert:
> This is blocking the DEPS roll into Chromium. Failures can be seen here:
>
> http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/174333
>
> Original issue's description:
> > Extract most of the mutable state of SkShader into a separate Context object.
> >
> > SkShader currently stores some state during draw calls via setContext(...).
> > Move that mutable state into a separate SkShader::Context class that is
> > constructed on demand for the duration of the draw.
> >
> > Calls to setContext() are replaced with createContext() which returns a context
> > corresponding to the shader object or NULL if the parameters to createContext
> > are invalid.
> >
> > TEST=out/Debug/dm
> > BUG=skia:1976
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14216
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14323
>
> TBR=scroggo@google.com,skyostil@chromium.org,tomhudson@chromium.org,senorblanco@chromium.org,reed@google.com,bungeman@google.com,dominikg@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14326

R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com, dominikg@chromium.org
TBR=bungeman@google.com, dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/246403013

git-svn-id: http://skia.googlecode.com/svn/trunk@14328 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Wed, 23 Apr 2014 18:05:36 +0000 (18:05 +0000)]

Disable cgimage GM

TBR=reed@google.com

Review URL: https://codereview.chromium.org/249873002

git-svn-id: http://skia.googlecode.com/svn/trunk@14327 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 16:16:55 +0000 (16:16 +0000)]

Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/)

Reason for revert:
This is blocking the DEPS roll into Chromium. Failures can be seen here:

http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/174333

Original issue's description:
> Extract most of the mutable state of SkShader into a separate Context object.
>
> SkShader currently stores some state during draw calls via setContext(...).
> Move that mutable state into a separate SkShader::Context class that is
> constructed on demand for the duration of the draw.
>
> Calls to setContext() are replaced with createContext() which returns a context
> corresponding to the shader object or NULL if the parameters to createContext
> are invalid.
>
> TEST=out/Debug/dm
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14216
>
> Committed: http://code.google.com/p/skia/source/detail?r=14323

R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com, dominikg@chromium.org
TBR=bungeman@google.com, dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/249643002

git-svn-id: http://skia.googlecode.com/svn/trunk@14326 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 16:12:52 +0000 (16:12 +0000)]

Rebaselines for 2pt Conical Gradients
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/249523003

git-svn-id: http://skia.googlecode.com/svn/trunk@14325 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 14:52:14 +0000 (14:52 +0000)]

Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)

Reason for revert:
Causes some layout_test failures around texture backed bitmaps. Test names and crash logs accessible via: https://storage.googleapis.com/chromium-layout-test-archives/linux_layout/13845/layout-test-results/results.html

Original issue's description:
> eliminate config param -- it was always self's config
>
> BUG=skia:
> R=bsalomon@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=14303

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/249373003

git-svn-id: http://skia.googlecode.com/svn/trunk@14324 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 09:11:58 +0000 (09:11 +0000)]

Extract most of the mutable state of SkShader into a separate Context object.

SkShader currently stores some state during draw calls via setContext(...).
Move that mutable state into a separate SkShader::Context class that is
constructed on demand for the duration of the draw.

Calls to setContext() are replaced with createContext() which returns a context
corresponding to the shader object or NULL if the parameters to createContext
are invalid.

TEST=out/Debug/dm
BUG=skia:1976

Committed: http://code.google.com/p/skia/source/detail?r=14216

R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/207683004

git-svn-id: http://skia.googlecode.com/svn/trunk@14323 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 05:35:24 +0000 (05:35 +0000)]

comment out SkDebugf (only needed for local testing)

TBR=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/248713003

git-svn-id: http://skia.googlecode.com/svn/trunk@14322 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 23 Apr 2014 04:00:17 +0000 (04:00 +0000)]

Make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)"

associated chrome change (to be committed with DEPS roll)
https://codereview.chromium.org/248693002/

This reverts commit bfaceb53f58c9625b5471fcff35b5ca9ca3ae29c.

TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/248083002

git-svn-id: http://skia.googlecode.com/svn/trunk@14321 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 23 Apr 2014 03:04:11 +0000 (03:04 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14320 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 23 Apr 2014 02:46:20 +0000 (02:46 +0000)]

Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.

The current implementation relies on soon-to-be-deprecated
kClip_SaveFlag behavior. Updated to use default save flags
(kMatrixClip_SaveFlag) and stop assuming that the matrix survives
restore() calls.

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246893005

git-svn-id: http://skia.googlecode.com/svn/trunk@14319 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 21:24:22 +0000 (21:24 +0000)]

Fix double to SkScalar issues in SkTwoPointConicalGradient_gpu.cpp
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/247833003

git-svn-id: http://skia.googlecode.com/svn/trunk@14318 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 21:13:45 +0000 (21:13 +0000)]

Factor out common template code. Send stdout back to web page.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14317 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 20:56:37 +0000 (20:56 +0000)]

Add gpu fast path for two point conical gradients.

Also shader changes should help numerical issues on certain android gpus

BUG=179264
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/238443006

git-svn-id: http://skia.googlecode.com/svn/trunk@14316 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 20:24:33 +0000 (20:24 +0000)]

expose CGImage -> SkBitmap

BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243463005

git-svn-id: http://skia.googlecode.com/svn/trunk@14315 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 20:07:30 +0000 (20:07 +0000)]

Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)

Reason for revert:
need to test more the code-path where we don't opt into the new virtuals

Original issue's description:
> make drawText calls non-virtual, to ease SkFont and TextBlob
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14307

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/247983003

git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 20:05:35 +0000 (20:05 +0000)]

gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja

BUG=skia:2442
R=caryclark@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/247143003

git-svn-id: http://skia.googlecode.com/svn/trunk@14313 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Apr 2014 19:58:58 +0000 (19:58 +0000)]

Change valgrind suppresion names for bug 2455.

BUG=skia:2455

Review URL: https://codereview.chromium.org/248063002

git-svn-id: http://skia.googlecode.com/svn/trunk@14312 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 22 Apr 2014 19:53:25 +0000 (19:53 +0000)]

Reverting Skia r14299 ( Remove guards Chromium no longer needs - https://codereview.chromium.org/246403004)

git-svn-id: http://skia.googlecode.com/svn/trunk@14311 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 19:32:06 +0000 (19:32 +0000)]

Adding the ability to click on the images in the history and have that load the code and image back into the editor space.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14310 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Apr 2014 19:30:16 +0000 (19:30 +0000)]

Update valgrind suppression names for bug 2453

BUG=skia:2453

Review URL: https://codereview.chromium.org/246653004

git-svn-id: http://skia.googlecode.com/svn/trunk@14309 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Apr 2014 19:17:54 +0000 (19:17 +0000)]

Mark bench suppressions with bug #

BUG=skia:2452

Review URL: https://codereview.chromium.org/246513005

git-svn-id: http://skia.googlecode.com/svn/trunk@14308 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 19:03:02 +0000 (19:03 +0000)]

make drawText calls non-virtual, to ease SkFont and TextBlob

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243853006

git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Apr 2014 18:47:02 +0000 (18:47 +0000)]

Add Valgrind suppression file for bench

BUG=skia:2450
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/246313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14306 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 18:32:58 +0000 (18:32 +0000)]

Fix build: Windows has dibs on IGNORE

Also, make sure to undef macros after we're done with them.

BUG=skia:

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247573003

git-svn-id: http://skia.googlecode.com/svn/trunk@14305 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 22 Apr 2014 18:31:55 +0000 (18:31 +0000)]

Increase range for skp that triggers a perf regression periodically

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/247073004

git-svn-id: http://skia.googlecode.com/svn/trunk@14304 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 22 Apr 2014 18:22:30 +0000 (18:22 +0000)]

eliminate config param -- it was always self's config

BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/246513002

git-svn-id: http://skia.googlecode.com/svn/trunk@14303 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 22 Apr 2014 17:54:29 +0000 (17:54 +0000)]

fix size_t/int warnings in pictures

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/244273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14302 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;