Panu Matilainen [Thu, 11 Nov 2010 12:33:01 +0000 (14:33 +0200)]
Remove superfluous dbiSync() call (refactoring thinko or such)
Florian Festi [Wed, 10 Nov 2010 12:59:53 +0000 (13:59 +0100)]
Switch fsync off while building indexes
Florian Festi [Wed, 10 Nov 2010 12:16:10 +0000 (13:16 +0100)]
Fix index auto creation
Florian Festi [Tue, 9 Nov 2010 10:59:34 +0000 (11:59 +0100)]
Rename rpm.ii.offsets() to .instances() to match name of mi.instance()
Guido Grazioli [Wed, 10 Nov 2010 15:21:02 +0000 (15:21 +0000)]
l10n: Updated Italian (it) translation to 100%
New status: 741 messages complete with 0 fuzzies and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
Panu Matilainen [Wed, 10 Nov 2010 11:44:02 +0000 (13:44 +0200)]
Don't restore db file atime/mtime after rebuild
- The files are regenerated from scratch, involving header record
numbers moving around, possibly removing broken headers and all.
Don't pretend nothing changed when some changes almost certainly,
occurred, various API users rely on rpmdb mtime for determining
whether the db has changed since they last accessed it.
Panu Matilainen [Tue, 9 Nov 2010 13:56:12 +0000 (15:56 +0200)]
Kill broken --rebuilddbpath popt alias
- It's been broken because of a typo for the last ten years and nobody
noticed, doesn't seem like a particularly useful switch...
Panu Matilainen [Tue, 9 Nov 2010 10:04:06 +0000 (12:04 +0200)]
Eliminate silly "I am about to create a directory now" debug logging
Panu Matilainen [Tue, 9 Nov 2010 09:59:17 +0000 (11:59 +0200)]
Simplify the dbpath shuffle in db rebuilds a bit
- We already have the non-prefixed dbpath at hand, use that instead
of recalculating the path from the prefixed version
Panu Matilainen [Tue, 9 Nov 2010 09:45:31 +0000 (11:45 +0200)]
Dont bother NULL'ing local variables on exit
Panu Matilainen [Tue, 9 Nov 2010 07:54:31 +0000 (09:54 +0200)]
Eliminate pointless (and racy) test for rebuilddb directory existence
- mkdir() will error out with a reasonable error message of its
own, no point doing separate, buggy test with access()
Florian Festi [Tue, 9 Nov 2010 08:52:33 +0000 (09:52 +0100)]
Remove unused local variable
Panu Matilainen [Tue, 9 Nov 2010 07:30:47 +0000 (09:30 +0200)]
Hide --aid and --nosuggest switches for now
- These have been no-ops since rpm 4.6, but might resurface one day so
leaving them around but out of sight...
Panu Matilainen [Tue, 9 Nov 2010 07:27:55 +0000 (09:27 +0200)]
Lose useless --fileconflicts cli-switch
- We always detect file conflicts (duh!) unless forced, no need for this
Panu Matilainen [Tue, 9 Nov 2010 07:18:10 +0000 (09:18 +0200)]
Move --dbpath into common rpm popt options table
- This ensures its available in all our executables without adding
umphteen copies into rpmpopt (after the cli splits, this was missing
in eg rpmdb executable...)
Panu Matilainen [Tue, 9 Nov 2010 07:02:21 +0000 (09:02 +0200)]
Eliminate stillborn code
Florian Festi [Fri, 5 Nov 2010 08:27:21 +0000 (09:27 +0100)]
Fix IndexIterator to not open an private dbi that never gets closed
Panu Matilainen [Fri, 5 Nov 2010 08:18:41 +0000 (10:18 +0200)]
Const-correctness: rpmdsRpmlib() doesn't (and must not) modify tblp
Panu Matilainen [Thu, 4 Nov 2010 13:55:19 +0000 (15:55 +0200)]
Lose the remaining dbapi references in code + configuration
- Changing db_api to db_ver to force breakage on anything using the
value, db_ver containing the BDB major version just to put something
in the error messages where the dbapi version used to be.
Panu Matilainen [Thu, 4 Nov 2010 13:45:27 +0000 (15:45 +0200)]
Eliminate useless dbapi version to internal openDatabase()
Panu Matilainen [Thu, 4 Nov 2010 13:38:25 +0000 (15:38 +0200)]
Eliminate useless dbapi argument to rpmdbRemoveDatabase()
Panu Matilainen [Thu, 4 Nov 2010 13:34:59 +0000 (15:34 +0200)]
Start eliminating dbapi leftovers
- We've only one dbapi and new ones are not around the corner. It
doesn't get tested and is likely broken at this point anyway,
better just kill it completely. We'll need a new mechanism
one day but lets worry about it when the day actually comes.
- Starting with eliminating dbapi arguments to the internal database
move helper
Panu Matilainen [Thu, 4 Nov 2010 12:09:33 +0000 (14:09 +0200)]
Eliminate unused strlen() calls 'n stuff from skipInstallFiles()
- These were used by the netsharedpath calculations which used
to be inline here, but that's now in a function of their own. Also
move the temporary variables to the scope where they're actually used.
Panu Matilainen [Thu, 4 Nov 2010 11:49:07 +0000 (13:49 +0200)]
Remove nicely misleading #ifndef NOTYET case from skipInstallFiles()
- No point "documenting" with reverse ifdef's what somebody was
considering to implement eight years ago, as it is directory and
file iterations can't be mixed as they both mess with fi->j.
- Also eliminate pointless "can't happen" check - this never gets
called with NULL fi in an element (which is already a cant happen)
Yuri Chornoivan [Wed, 3 Nov 2010 20:41:24 +0000 (20:41 +0000)]
l10n: Updated Ukrainian (uk) translation to 100%
New status: 741 messages complete with 0 fuzzies and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
Florian Festi [Wed, 3 Nov 2010 09:58:41 +0000 (10:58 +0100)]
Merge rpmdbIndexIteratorKey and rpmdbIndexIteratorKeySize into rpmdbIndexIteratorNext
Florian Festi [Wed, 3 Nov 2010 09:35:42 +0000 (10:35 +0100)]
Make ints in IndexIterator API unsigned as the interal types are
Florian Festi [Sun, 24 Oct 2010 17:39:42 +0000 (19:39 +0200)]
Rename rpmdbKeyIterator to rpmdbIndexIterator
Florian Festi [Sun, 24 Oct 2010 17:10:35 +0000 (19:10 +0200)]
Give access to the pkg offset and tag num of the index entry the key iterator is pointing to
Panu Matilainen [Sat, 30 Oct 2010 08:37:06 +0000 (11:37 +0300)]
Const-correctness: source is a pointer to fullSource and must not be freed
Panu Matilainen [Fri, 29 Oct 2010 17:30:07 +0000 (20:30 +0300)]
Const-correctness: rpmCharCheck() doesn't modify field, make it const
Panu Matilainen [Fri, 29 Oct 2010 12:14:01 +0000 (15:14 +0300)]
Add rough-cut man-pages for our new executables
- Chainsaw relevant information out of rpm.8 and tweak a little bit,
adding cross-references etc. These will need a lot more love though...
Panu Matilainen [Fri, 29 Oct 2010 10:55:22 +0000 (13:55 +0300)]
More ancient cruft removal from the repository
Panu Matilainen [Fri, 29 Oct 2010 07:40:25 +0000 (10:40 +0300)]
Lose ancient lclint remnants from the repository
Panu Matilainen [Fri, 29 Oct 2010 07:21:45 +0000 (10:21 +0300)]
Eliminate unused truncStringBuf() function
- This has been unused at least as far back as rpm 4.4 actually...
Panu Matilainen [Fri, 29 Oct 2010 07:12:53 +0000 (10:12 +0300)]
Eliminate unused spectag and speclines goo from spec
- These were used, back in the day, to implement a hidden --specedit
switch, which in all its glory did: print a copy of a spec file,
with group, summary and description looked up from specspo.
This huge pile of junk was left behind from kicking out the
useless "feature" in commits
7b95061d3b77d8e6b3c80e856b66f49b393511ba and
0f991a14209054da7c45c46e96750738fc62874d.
Alexey Gladkov [Wed, 27 Oct 2010 21:11:38 +0000 (01:11 +0400)]
elfdeps: Fix version definitions processing
The elfdeps doesn't parse the whole .gnu.version_d section.
For example:
$ readelf -V /lib/libbz2.so.1 | grep -A3 .gnu.version_d
Version definition section '.gnu.version_d' contains 2 entries:
Addr: 0x0000000000000884 Offset: 0x000884 Link: 4 (.dynstr)
000000: Rev: 1 Flags: BASE Index: 1 Cnt: 1 Name: libbz2.so.1
0x001c: Rev: 1 Flags: none Index: 2 Cnt: 1 Name: BZLIB_1.0
Before changes:
$ echo /lib/libbz2.so.1.0.6 | /usr/lib/rpm/elfdeps -P
libbz2.so.1
After changes:
$ echo /lib/libbz2.so.1.0.6 | /usr/lib/rpm/elfdeps -P
libbz2.so.1(BZLIB_1.0)
libbz2.so.1
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
Panu Matilainen [Thu, 28 Oct 2010 09:01:42 +0000 (12:01 +0300)]
Fix the remaining enum abuse over rpmParseState in librpmbuild
- rpmParseState uses might actually qualify for a true enum here
but changing it would require changing half of librpmbuild and
many of them mix the parse states, other error codes and whatnot
in their types... just not worth the trouble, so use an int.
Panu Matilainen [Thu, 28 Oct 2010 08:48:49 +0000 (11:48 +0300)]
Now, make getStringBuf() return const char * for correctness sake
Panu Matilainen [Thu, 28 Oct 2010 08:47:29 +0000 (11:47 +0300)]
parseScript() const pedantry
- The string from getStringBuf() is not modified, so use a const
variable for it, and a separate variable for the temporary
line splitting for triggers
Panu Matilainen [Thu, 28 Oct 2010 08:39:28 +0000 (11:39 +0300)]
Use ARGV_t instead of stringbuf in changelog parsing
- addChangelog() is a bad boy and modifies the string it grabs
from getStringBuf(), be clean about it and grab a copy through
argvJoin() instead
- addChangelog() would be better off walking and parsing over the
argv directly instead of a joined string of it all, but leaving
that exercise for some other rainy day
Panu Matilainen [Thu, 28 Oct 2010 08:01:39 +0000 (11:01 +0300)]
Use ARGV_t for temporary line storage directly
- Similar to commit
1e3db59b568b1ff7f7e1f3285fc9b18567f2f2d6,
no point using temporary string buffer when only end up splitting
it into an argv for processing. Incidently this would've been
a much less intrusive fix to RhBug:573339 than introducing
a whole new argvSplitString() function... oh well. Take care not
to introduce extra newlines in the process as argvSplitString() was
eating them before - need to use appendStringBuf() for spec->prep now.
Panu Matilainen [Thu, 28 Oct 2010 07:51:00 +0000 (10:51 +0300)]
Pass the script to doScript() as const char *
- doScript() doesn't do anything special with the script buffer,
this lets us use const for the argument.
Panu Matilainen [Thu, 28 Oct 2010 07:45:35 +0000 (10:45 +0300)]
Argument passing hysteria in doScript()
- Callers know perfectly well which part they're passing to doScript()
so they can just as well pass in the name and the scriptlet to run,
avoiding silly stuff in the switch-case
Panu Matilainen [Thu, 28 Oct 2010 07:38:40 +0000 (10:38 +0300)]
Handle NULL sb in getStringBuf() cleanly
Panu Matilainen [Thu, 28 Oct 2010 07:24:20 +0000 (10:24 +0300)]
Use ARGV_t for package fileFile, fileList and policyList
- Similar to commit
1e3db59b568b1ff7f7e1f3285fc9b18567f2f2d6,
all these end up being passed to argvSplit() to process them line
by line in the end, collect them in the argv to start with saving
a whole lotta huffing and puffing in the process
Panu Matilainen [Thu, 28 Oct 2010 06:54:53 +0000 (09:54 +0300)]
Eliminate splitString() leftover braindamage in processSourceFiles()
- Collect the filenames directly into the ARGV_t files instead of
putting them to a StringBuf first and then argvSplit()'ing the
result, doh. Leftover stupidity from eliminating splitString()
usage in commit
94ff22b129aeb31c38848231e40f87aa4a5613a1
Panu Matilainen [Tue, 26 Oct 2010 20:39:14 +0000 (23:39 +0300)]
Bury stripTrailingChar() inside the only remaining user
- There used to be some other callers too but seems they've passed
away, leaving just the relocation code in rpmte.c. Which means we
can get this ugly bit out of the API.
Panu Matilainen [Tue, 26 Oct 2010 20:36:46 +0000 (23:36 +0300)]
Bury StringBuf inside librpmbuild internals
Panu Matilainen [Tue, 26 Oct 2010 20:28:39 +0000 (23:28 +0300)]
Make rpmfcExec() internal
- Nobody in their right mind is likely to be calling what's really
an internal helper function in the build code. Simply missed in
the first round of librpmbuild API butchery.
- This eliminates the last remaining exposure of StringBuf in the API
Panu Matilainen [Tue, 26 Oct 2010 20:20:58 +0000 (23:20 +0300)]
Eliminate the sole StringBuf user in librpm side
- Using ARGV_t here might not be exactly optimal but then manifest
parsing isn't exactly performance critical either.
Panu Matilainen [Tue, 26 Oct 2010 08:29:17 +0000 (11:29 +0300)]
Fix BDB version check in configure to work with >= 5 too
Panu Matilainen [Tue, 26 Oct 2010 06:54:55 +0000 (09:54 +0300)]
Separate match iterator allocation vs initialization
- There's exactly one spot within rpm which needs the former behavior
of rpmdbInitIterator() on a secondary index with keyp of NULL:
rpmFindBaseNamesInDB(): it wants an empty iterator on RPMDBI_BASENAMES,
which is then extended as it progresses. Starting with commit
c70e076e088589f65160c05ee7cc8db0b3db6d7e, rpmdbInitIterator()
however returns the actual index in that case, which is not
optimal for rpmFindBaseNamesInDB(). Handle the basenames in db
as the special case it is, and have it explicitly create an
empty iterator with the new call.
Panu Matilainen [Mon, 25 Oct 2010 12:03:56 +0000 (15:03 +0300)]
Create less draconian loops for grouped collections
- Instead of creating a completely unresolvable tangle of pre-requisites
between all collection members and their requirements, just add
a single relation loop of all the packages in a (grouped) collection,
effectively turning it into a strongly connected component. The
loop-cutting algorithm has slightly better chances of surviving this
while still enforcing the collection members to be installed in one
lump. Also only process each collection just once.
Panu Matilainen [Mon, 25 Oct 2010 09:44:34 +0000 (12:44 +0300)]
Only specific cases of collections need extra ordering
- Add a crude flags system to allow selectively enabling the extra
grouping during ordering: currently only sepolicy collection needs
this, and its very harmful when applied to more regular collections
as it creates truly gigantic dependency loops that rpm has no chance
of sorting out sanely.
Piotr DrÄ…g [Sat, 23 Oct 2010 10:07:31 +0000 (10:07 +0000)]
l10n: Updated Polish (pl) translation to 100%
New status: 741 messages complete with 0 fuzzies and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
Panu Matilainen [Fri, 22 Oct 2010 15:28:08 +0000 (18:28 +0300)]
Eek.. librpmsign sources went missing in the move
- Re-adding the files that should've gotten moved (not removed) in
commit
9f2c1bd9096cbf382c864737a6565e5487767ce2
- Mild wtf ... probably user (not git) error though. Too bad the
broken state got pushed already :-/
Panu Matilainen [Fri, 22 Oct 2010 12:51:36 +0000 (15:51 +0300)]
Bah, couple of missed places for librpmsign moving
Panu Matilainen [Fri, 22 Oct 2010 12:45:58 +0000 (15:45 +0300)]
Teach python about the new RPMDBI_* tags
Panu Matilainen [Fri, 22 Oct 2010 12:02:14 +0000 (15:02 +0300)]
Update translations to pick recent changes + files moving about
Panu Matilainen [Fri, 22 Oct 2010 12:00:49 +0000 (15:00 +0300)]
Move librpmsign to its own subdirectory in the sources
Panu Matilainen [Fri, 22 Oct 2010 10:46:14 +0000 (13:46 +0300)]
Brute-force s/rpmTag/rpmTagVal/ in entire librpmbuild
- Many of these cases would be true enums from preambleList & similar,
except for the list terminating sentinel. Just switch all the
remaining rpmTag's to rpmTagVals to bring our enum-whacking to
a grande finale.
Panu Matilainen [Fri, 22 Oct 2010 10:31:34 +0000 (13:31 +0300)]
Fix invalid uses of rpmTag/rpmSigTag in pack.c
Panu Matilainen [Fri, 22 Oct 2010 10:23:09 +0000 (13:23 +0300)]
Replace remaing rpmSigTag uses with rpmTagVal
- Some of these might actually be "correct" but about one case from
librpmbuild cascades down here ... just not worth the trouble to
keep the as rpmSigTags.
Panu Matilainen [Fri, 22 Oct 2010 09:59:53 +0000 (12:59 +0300)]
Use header datatype for hash algo instead of pgpHashAlgo enum
- The digest algo can come from macro numeric expansion which is
not an enum. Just use uint32_t which is how it'll end up in the header
Panu Matilainen [Fri, 22 Oct 2010 09:58:09 +0000 (12:58 +0300)]
Eliminate pgpHashAlgo uses in librpm side
- In all these cases the value comes from a non-enum source so
just use an int instead
Panu Matilainen [Fri, 22 Oct 2010 09:39:04 +0000 (12:39 +0300)]
Fix (ie eliminate) rpmSigTag uses in rpmchecksig
- The sigtags originating from headers are not enums but integers
- 0 is not a valid rpmSigTag value while the other cases would be in
bestSig() and friends
Panu Matilainen [Fri, 22 Oct 2010 09:35:56 +0000 (12:35 +0300)]
Meh, one missed rpmTag -> rpmTagVal change in query
- While the initial assignment is to true rpmTag, rpmTagGetValue()
returns rpmTagVal, not rpmTag.
Panu Matilainen [Fri, 22 Oct 2010 09:31:08 +0000 (12:31 +0300)]
Couple of enum craziness fixes to package.c
- 0 is not a valid rpmSigTag, just use rpmTagVal instead
- use int instead of pgpHashAlgo for temporary variables, the
originating data is not "pure" enum
Panu Matilainen [Fri, 22 Oct 2010 09:22:44 +0000 (12:22 +0300)]
Eliminate use of pgpHashAlgo in rpmio interface arguments
- While its use would seem kinda obvious here, in rpm context this
information often comes from header tags which are plain integers
and would require conversion/casting to the enum. What matters is
the integral value, not it being actual enum.
Panu Matilainen [Fri, 22 Oct 2010 09:13:49 +0000 (12:13 +0300)]
Couple of previously missed type changes in rpmdb code
Panu Matilainen [Fri, 22 Oct 2010 09:07:57 +0000 (12:07 +0300)]
Switch lowelevel header internals to use rpm_tagtype_t for tag type data
Panu Matilainen [Fri, 22 Oct 2010 08:57:38 +0000 (11:57 +0300)]
Switch python bindings to use rpm(Dbi)TagVal as appropriate
- None of these are true enum uses as the value typically originates
from python integers etc.
Panu Matilainen [Fri, 22 Oct 2010 08:49:52 +0000 (11:49 +0300)]
Change all internal uses of rpmtsInitIterator() to use DBI tags
Panu Matilainen [Fri, 22 Oct 2010 08:43:10 +0000 (11:43 +0300)]
Switch lone rpmTag use in query to rpmTagVal
Panu Matilainen [Fri, 22 Oct 2010 08:39:53 +0000 (11:39 +0300)]
Switch psm and rpmscript to use rpmTagVal where appropriate
- There are a few true rpmTag uses though, leaving them as they are...
Panu Matilainen [Fri, 22 Oct 2010 08:33:32 +0000 (11:33 +0300)]
Change rpmfiNew() tag argument to rpmTagVal
- The argument is actually unused, but that only makes it even more
stupid to require C++ callers to potentially having to cast.
Panu Matilainen [Fri, 22 Oct 2010 08:31:36 +0000 (11:31 +0300)]
Switch rpmte API and internals to use rpmTagVal instead of rpmTag
- Except for rpmteColorDS(), these can get called with intergral
value instead of the actual enumeration
Panu Matilainen [Fri, 22 Oct 2010 08:27:01 +0000 (11:27 +0300)]
Switch rpmds API and internals to use rpmTagVal instead of rpmTag
- None of these require passing "true enum", the value is what counts.
In general, enums as function argument types are just a royal PITA
from C++, avoid when not strictly necessary.
Panu Matilainen [Fri, 22 Oct 2010 08:07:48 +0000 (11:07 +0300)]
Change rpmdb internals and iterator APIs to use the appropriate tag types
- The actual indexes are rpmDbiTags, and the tag passed to
rpmtsInitIterator() and rpmdbInitIterator() always refers to a
database index, not arbitrary header tag. The tag passed to
rpmdbSetIteratorRE() however /does/ refer to a header tag. This rather
important distinction can actually be expressed in the API.
- As the indexes are generated from header tags of the same value,
most of these need to use the TagVal types instead of actual enums
to avoid mismatches - the value is what counts, not it being an enum.
- Several places still have variables misleadingly named "rpmtag" when
they refer to dbi tags, but leaving them for now to avoid excessive
changes at once.
Panu Matilainen [Fri, 22 Oct 2010 07:17:55 +0000 (10:17 +0300)]
Document our supported rpmdb indexes in the API via an enum of their own
- Now that our indexes are actually hardwired in the code we can
properly separate rpmtag vs db index names.
- Defined similarly to rpmTags, with rpmDbiTag being the "true enum"
and rpmDbiTagVal the integral type they present. As many of the
indexes are defined via RPMTAG values (and need to remain that
way to avoid breaking every single API user) we need to have a
compatible type with rpmTags.
- These would logically belong to rpmdb.h but keeping in rpmtag.h
to have them available "everywhere", we can't go including rpmdb.h
from rpmtag.h so keeping them here avoids potential unnecessary breakage.
Panu Matilainen [Fri, 22 Oct 2010 06:55:49 +0000 (09:55 +0300)]
Change all the legacy interfaces to use the "concrete" integer tag types
- More compatible with the 4.4.x definitions (should've been this way
all this time) and none of these are "true" enum uses anyway
Panu Matilainen [Fri, 22 Oct 2010 06:48:24 +0000 (09:48 +0300)]
Switch header APIs to use rpmTagVal instead of rpmTag
- The header getters are used for both signature header and the "normal"
header, and even beyond that there's no requirement for a tag in
the header to be part of rpmTag enum. The headerPutFoo() variants
technically do require the tag to be found in the tag table (ie be
an rpmTag) but they still operate on the integer value, they dont
require it to be a "true" enum.
- Inside tagexts.c there are a few "true" enum uses in the
internal helper functions, leave them be.
- While this technically changes some the most commonly used API's,
this wont affect callers really: if the callers were using an enum
before, enum can always be cast naturally to an integer. The other
way around was the problematic part (ie the braindamage we're fixing
here now...)
Panu Matilainen [Fri, 22 Oct 2010 06:40:43 +0000 (09:40 +0300)]
rpmTagFoo() getters take arbitrary integers, not rpmTag enums
- Another step to clean up the enum braindamage...
- rpmTag values are the only values that will be found, but it doesn't
mean the values passed are rpmTag enum members - eg anything from
a header is not. rpmTagGetValue() does come close to returning true
enums, but there's RPMDBI_PACKAGES and then RPMTAG_NOT_FOUND, neither
of which are actually tags.
- Introducing a new rpmTagVal typedef. It's just an alias for the
"lowlevel" rpm_tag_t type but visually more in line with the other
rpmTagFoo bits - to be used with the "higher level" tags whereas
rpm_tag_t is the "physical" type. Not that it makes any difference...
Panu Matilainen [Fri, 22 Oct 2010 06:37:20 +0000 (09:37 +0300)]
Use concrete integer types for entryInfo and rpmtd members
- Start undoing self-introduced enum braindamage from 2007: the lowlevel
tag data in header structures are NOT rpmTag/rpmTagType enums, but a
32bit integer of any arbitrary value. While these can be legally mixed in
C the same is not true of C++ and even in C using enum here is not "correct"
Panu Matilainen [Fri, 22 Oct 2010 06:36:43 +0000 (09:36 +0300)]
Couple of doxygen argument mismatch fixes
Panu Matilainen [Fri, 22 Oct 2010 06:36:29 +0000 (09:36 +0300)]
Eliminate silly cast
Panu Matilainen [Fri, 22 Oct 2010 06:19:42 +0000 (09:19 +0300)]
Drop unused pubkeys index too
- This isn't expensive to create but unused is unused is useless junk.
Rpm < 4.6.0 did use this a lot, but nowadays we preload the keyring
and do key lookups from meory so this isn't needed for anything.
- 'freedata' argument of td2key() is now unused, but leaving it there
as we might need tag data -> index data transformations in the future.
Panu Matilainen [Fri, 22 Oct 2010 06:02:43 +0000 (09:02 +0300)]
Drop filedigests index
- Now that the sole "user" is gone, kill the stupid index. Speeds
things up considerably: eg on database rebuild, the file digests
index generation amounts to roughly one third (!) of the entire time.
Panu Matilainen [Fri, 22 Oct 2010 05:58:06 +0000 (08:58 +0300)]
Eliminate useless --fileid query selector
- Finding out which package provides a file with a given digest
is just .. useless functionality. Being next to useless is one
thing, but we pay a high price for this particular uselessness:
the index needed for this is one of the biggest and most expensive
indexes we have.
Florian Festi [Thu, 21 Oct 2010 09:59:14 +0000 (11:59 +0200)]
Fix Python bindings and raise KeyError when there is no index for the given tag
Florian Festi [Thu, 21 Oct 2010 08:41:49 +0000 (10:41 +0200)]
Fix typo / erroneously deleted line
Florian Festi [Tue, 15 Dec 2009 12:15:10 +0000 (13:15 +0100)]
rpmdbKeyIterator: loop over keys in the database indexes
Panu Matilainen [Wed, 20 Oct 2010 13:38:46 +0000 (16:38 +0300)]
Hardwire the fundamental BDB access method configuration inside rpm
- The different access methods have different capabilities and are not
interchangeable in all situations. Currently we can use either
hash and btree but this might not be always the case for all indexes.
- We'll eventually want to force-switch the index types to our liking,
but for now follow these simple rules:
1) For existing databases, we accept both btree and hash
2) For newly created databases, the main Packages database remains
a hash, all indexes are btrees.
- Rip out nearly all the rest of the remaining macro configuration.
Panu Matilainen [Wed, 20 Oct 2010 12:23:54 +0000 (15:23 +0300)]
Eliminate now unnecessary db rebuild macro goo and other leftovers
- Rpm knows how to handle db rebuilds by itself, no need to expose
these bits to configuration.
- Also rip out a pile of other leftover "documentation" about BDB
internal switches.
Panu Matilainen [Wed, 20 Oct 2010 12:11:20 +0000 (15:11 +0300)]
Lift fsync enable/disable configuration handling to rpmdb layer
- Add a fsync disable/enable function in the backend, call from
rpmdb layer: on initial database creation (including database
rebuild), it's "safe enough" to disable fsync as there's no former
data to protect. Considerably speeds up initial install to eg chroots.
- Always re-enable fsync when closing a read-write database - at that
point there /is/ data to protect.
Panu Matilainen [Wed, 20 Oct 2010 11:16:29 +0000 (14:16 +0300)]
Hardwire the fundamental BDB subsystem configuration inside rpm
- BDB subsystems are not something that can be just switched on and
off like that. If we want to support different configurations they
need to be rpm-specific settings such as transactional/concurrent
setting, not an arbitrary pile of flags that cause stuff to blow
up when abused.
- Eliminate dbi->dbi_eflags completely, the environment opening flags
can be fetched from BDB where needed. Subsystem configuration from
macros is no longer looked at or honored, but leaving the option
table there for debugging output at least for now.
Panu Matilainen [Wed, 20 Oct 2010 09:46:37 +0000 (12:46 +0300)]
Lift missing index detection to rpmdb layer
- Avoids unnecessarily modifying the parent rpmdb from backend layer
and since its the rpmdb layer that needs to deal with creating
indexes anyway...
- Also avoids bumping the counter in case of errors (eg permission denied)
Panu Matilainen [Wed, 20 Oct 2010 09:36:38 +0000 (12:36 +0300)]
Avoid umphteen unnecessary calls to rpmTagGetName()
- These aren't exactly hotpaths, but since the dbi always knows
its name already there's no point going through rpmTagGetName()
bsearch()'es and all for these.
Panu Matilainen [Wed, 20 Oct 2010 09:23:14 +0000 (12:23 +0300)]
Add a getter for dbi name