platform/upstream/libusb.git
8 years agoWindows: Fix possible false error message during device enumeration
Chris Dickens [Wed, 14 Sep 2016 05:09:50 +0000 (22:09 -0700)]
Windows: Fix possible false error message during device enumeration

During early phases of enumeration, it is possible for a device to be
enumerated before its parent. When this occurs, the device assigned as
the parent will actually be a grandparent. During later phases of
enumeration, the parent device will in fact exist but will not match
what has already been assigned to the device.

This commit adds code to check for and update the parent device when
this situation occurs.

Closes #206

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoon to 1.0.21-rc6
Nathan Hjelm [Sat, 1 Oct 2016 12:49:09 +0000 (06:49 -0600)]
on to 1.0.21-rc6

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agodarwin: fix OSAtomicAdd32Barrier argument ordering
Nathan Hjelm [Wed, 21 Sep 2016 15:01:38 +0000 (09:01 -0600)]
darwin: fix OSAtomicAdd32Barrier argument ordering

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoon to 1.0.21-rc5
Nathan Hjelm [Wed, 14 Sep 2016 18:32:54 +0000 (12:32 -0600)]
on to 1.0.21-rc5

Signed-off-by: Nathan Hjelm <hjelmn@me.gov>
8 years agoFixed Obj-C GC support; fix pthread name
Sean McBride [Wed, 14 Sep 2016 16:50:09 +0000 (12:50 -0400)]
Fixed Obj-C GC support; fix pthread name

Fixed some recent regressions:
- Always call pthread_setname_np. Recent change removed this if > 10.8.
- Always call objc_registerThreadWithCollector(), except if deploying to 10.12 or later, which GC is removed anyway.

NTH: Note, the header in macOS 10.12 documents that the auto-release
feature was removed and "does nothing" since 10.8. The source code
available from 10.8-10.11 clearly shows that the
objc_registerThreadWithCollector call does something so we will leave
it enabled for this version range. More details are needed from Apple
to interpret the meaning of the deprecation message in 10.12.

Closes #210

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoREADME: fix my email address
Nathan Hjelm [Tue, 13 Sep 2016 04:04:22 +0000 (22:04 -0600)]
README: fix my email address

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agodarwin: fix typo
Nathan Hjelm [Tue, 13 Sep 2016 04:00:04 +0000 (22:00 -0600)]
darwin: fix typo

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoon to 1.0.21-rc4
Nathan Hjelm [Tue, 13 Sep 2016 03:42:23 +0000 (21:42 -0600)]
on to 1.0.21-rc4

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agodarwin: do not use deprecated OSAtomicIncrement32Barrier in 10.12
Nathan Hjelm [Tue, 13 Sep 2016 03:38:44 +0000 (21:38 -0600)]
darwin: do not use deprecated OSAtomicIncrement32Barrier in 10.12

This commit fixes a warning introduced by macOS 10.12 Sierra when
using the OS atomics. These atomics have been deprecated in favor
of the ones provided by C11 (stdatomic.h). On older versions of
OS X we still use the OS atomics (now OSAtomicAdd32Barrier) and
on 10.12.0 and newer we use atomic_fetch_add.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agodarwin: do not use objc_registerThreadWithCollector where deprecated
Nathan Hjelm [Thu, 8 Sep 2016 00:50:43 +0000 (18:50 -0600)]
darwin: do not use objc_registerThreadWithCollector where deprecated

This commit updates the check around objc_registerThreadWithCollector
to enable the call only between 10.6 (introduced) and 10.8 (deprecated).

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agodarwin: work around devices with buggy endpoint descriptors
Nathan Hjelm [Thu, 8 Sep 2016 00:47:25 +0000 (18:47 -0600)]
darwin: work around devices with buggy endpoint descriptors

This commit adds a workaround for devices that have buggy endpoint
descriptors but are otherwise functional. These devices will have
endpoints that fail the GetPipeProperties call. Since we only care
about the endpoint address we can read it from the descriptor
itself.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agorelease: on to 1.0.21-rc3
Nathan Hjelm [Mon, 22 Aug 2016 02:32:39 +0000 (20:32 -0600)]
release: on to 1.0.21-rc3

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agocore: Document why we drop the flying_transfers_lock before submit_transfer
Hans de Goede [Thu, 11 Aug 2016 09:12:56 +0000 (11:12 +0200)]
core: Document why we drop the flying_transfers_lock before submit_transfer

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agolinux_usbfs: Deal with receiving POLLERR before all transfers have completed
Hans de Goede [Tue, 7 Jun 2016 10:12:38 +0000 (12:12 +0200)]
linux_usbfs: Deal with receiving POLLERR before all transfers have completed

The linux kernel will set its internal device state to USB_STATE_NOTATTACHED
as soon as it detects the disconnect, and then start a worker thread to
deal with the actual disconnection, kill outstanding urbs, etc.

The usbfs poll implementation will return POLL_ERR as soon as
ps->dev->state == USB_STATE_NOTATTACHED. The kernel will not wakeup
the poll until it is done with processing the disconnection. But if
we happen to call poll() between the state change and the disconnection
being fully processed, we may not be able to reap all outstanding transfers,
even on kernels with the USBFS_CAP_REAP_AFTER_DISCONNECT capability.

This commit deals with this by trying to reap as many transfers as possible
on disconnect on USBFS_CAP_REAP_AFTER_DISCONNECT capable kernels and then
calling usbi_handle_disconnect(handle) to deal with any remaining ones.
On USBFS_CAP_REAP_AFTER_DISCONNECT capable kernels this will be a no-op
unless we hit the race.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Move calculate_timeout call to add_to_flying_transfers
Hans de Goede [Wed, 8 Jun 2016 08:34:05 +0000 (10:34 +0200)]
core: Move calculate_timeout call to add_to_flying_transfers

This cleans-up libusb_submit_transfer a bit by avoiding an error
exit path with unlock calls.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Fix unlocked access to timeout_flags
Hans de Goede [Mon, 6 Jun 2016 15:43:23 +0000 (17:43 +0200)]
core: Fix unlocked access to timeout_flags

There is a race between handle_timeout() and the completion functions.
When one thread is in handle_timeout() and another thread wakes
up from a poll(), there exists a window where the transfer has been
cancelled, but USBI_TRANSFER_TIMED_OUT is not yet set in timeout_flags.
Therefore, usbi_handle_transfer_completion() is sometimes called
with LIBUSB_TRANSFER_CANCELLED instead of the expected
LIBUSB_TRANSFER_TIMED_OUT.

timeout_flags is protected by the flying_transfers_lock, this commit
makes usbi_handle_transfer_cancellation() take that lock before
checking for USBI_TRANSFER_TIMED_OUT in timeout_flags, fixing this.

Reported-by: Joost Muller <joostmuller@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Fix do_close locking
Hans de Goede [Mon, 6 Jun 2016 15:42:12 +0000 (17:42 +0200)]
core: Fix do_close locking

Put the lock / unlock calls around the part of the code which actually
checks the flags which the lock protect.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Test for LIBUSB_SUCCESS instead of 0 in handle_timeout()
Hans de Goede [Mon, 6 Jun 2016 14:54:42 +0000 (16:54 +0200)]
core: Test for LIBUSB_SUCCESS instead of 0 in handle_timeout()

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Do not arm timer-fd for transfers where the os handles timeout
Hans de Goede [Mon, 6 Jun 2016 14:53:53 +0000 (16:53 +0200)]
core: Do not arm timer-fd for transfers where the os handles timeout

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agocore: Refactor code related to transfer flags and timeout handling
Chris Dickens [Mon, 26 Oct 2015 13:18:33 +0000 (14:18 +0100)]
core: Refactor code related to transfer flags and timeout handling

Commit a886bb02 sped up the library a bit by removing the serialization
of transfer submission with respect to the flying_transfers list, but
it introduced two separate issues.

1) A deadlock scenario is possible given the following sequence:

   - Thread A submits transfer with very short timeout (say 1ms)
     -> takes transfer->lock
     -> adds transfer to flying_transfers list and arms timerfd
     -> actually calls backend to submit transfer, but it fails
   <context switch>
   - Thread B is doing event handling and sees the timerfd trigger
     -> takes ctx->flying_transfers_lock
     -> finds the transfer above on the list
     -> calls libusb_cancel_transfer() for this transfer
       --> takes transfer->lock
   <context switch>
   - Thread A sees the transfer failed to submit
     -> removes transfer from flying_transfers list
       --> takes ctx->flying_transfers_lock (still holding transfer->lock)
   ** DEADLOCK **

2) The transfer state flags (e.g. submitting, in-flight) were protected
    by transfer->flags_lock, but the timeout-related flags were OR'ed in
    during timeout handling operations outside of the lock. This leads to
    the possibility that transfer state might get overwritten.

This change corrects these issues and simplifies the transfer submission
code a bit by separating the state and timeout flags into their own flag
variables. The state flags are protected by the transfer lock. The timeout
flags are protected by the flying_transfers_lock.

The transfer submission code sheds some weight because it no longer needs
to worry about the timing of events that modify the transfer state flags.
These flags are always viewed and modified under the protection of the
transfer lock. Since libusb_submit_transfer() holds the transfer lock for
the entire duration of the operation, the other code paths that would
possibly touch the transfer (e.g. usbi_handle_disconnect() and
usbi_handle_transfer_completion()) have to wait for transfer submission
to fully complete. This eliminates any possible race conditions.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
[hdegoede@redhat.com: Reworked libusb_submit_transfer changes so that in
 case both flying_transfer_lock and itransfer->lock are taken
 flying_transfers_lock is always taken first]
[hdegoede@redhat.com: Removed some unrelated changes (will be submitted
 as separate patches)]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agowinnt: Do not differ between cancel / timeout ourselves
Hans de Goede [Mon, 6 Jun 2016 14:43:18 +0000 (16:43 +0200)]
winnt: Do not differ between cancel / timeout ourselves

(itransfer->flags & USBI_TRANSFER_TIMED_OUT) is already checked by
usbi_handle_transfer_cancellation(), make windows_transfer_callback()
call usbi_handle_transfer_cancellation() when
status == LIBUSB_TRANSFER_CANCELLED like all other os backends do, and
leave USBI_TRANSFER_TIMED_OUT handling up to the core, so that future
changes to timeout handling do no break winnt.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Note: untested

8 years agowince: Do not differ between cancel / timeout ourselves
Hans de Goede [Mon, 6 Jun 2016 14:40:54 +0000 (16:40 +0200)]
wince: Do not differ between cancel / timeout ourselves

(itransfer->flags & USBI_TRANSFER_TIMED_OUT) is already checked by
usbi_handle_transfer_cancellation(), which wince_transfer_callback()
will call when status == LIBUSB_TRANSFER_CANCELLED. Leave this up
to the core, so that future changes to timeout handling do no break
wince.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Note: untested

8 years agocore: Change event handling lock to traditional (non-recursive) type
Chris Dickens [Mon, 26 Oct 2015 13:11:53 +0000 (14:11 +0100)]
core: Change event handling lock to traditional (non-recursive) type

The event handling lock was previously required to be of the recursive
type because the libusb_close() path requires the lock and may be
called by a thread that is handling events (e.g. from within a
transfer or hotplug callback). With commit 960a6e75, it is possible to
determine whether the current function is being called from an event
handling context, thus the recursive lock type is no longer necessary.

References:
* http://libusb.org/ticket/82
74282582cc879f091ad1d847411337bc3fa78a2b
c775c2f43037cd235b65410583179195e25f9c4a

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
[hdegoede@redhat.com: rebase on top of current master]
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agoRevert "io: Fix race condition in handle_timeout()"
Hans de Goede [Wed, 10 Aug 2016 10:17:00 +0000 (12:17 +0200)]
Revert "io: Fix race condition in handle_timeout()"

This reverts commit bd8d5b5019b72b2dc2d074d96c9992e2f6e7e0b7.

Chris Dickens and me have been working on a patch-set refactoring
the transfer flag handling which fixes this differently. Revert
this commit so that the refactoring changes can be merged cleanly.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
8 years agoon to 1.0.21-rc2
Nathan Hjelm [Mon, 25 Jul 2016 02:04:34 +0000 (20:04 -0600)]
on to 1.0.21-rc2

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoUpdated TODO link
Anil Nair [Sun, 24 Jul 2016 15:42:26 +0000 (21:12 +0530)]
Updated TODO link

Closes #198

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agochangelog: add entry for new solaris backend
Nathan Hjelm [Mon, 25 Jul 2016 02:01:15 +0000 (20:01 -0600)]
changelog: add entry for new solaris backend

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoSolaris backend
Lei Chen [Fri, 19 Feb 2016 03:58:39 +0000 (11:58 +0800)]
Solaris backend

Closes #177

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agochangelog: add missing entry
Nathan Hjelm [Fri, 22 Jul 2016 12:38:09 +0000 (06:38 -0600)]
changelog: add missing entry

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agowindows: use appropriate version for VS2015 solution files
Pete Batard [Fri, 22 Jul 2016 11:57:40 +0000 (12:57 +0100)]
windows: use appropriate version for VS2015 solution files

* Closes #193

8 years agolibusb 1.0.21-rc1
Nathan Hjelm [Fri, 22 Jul 2016 05:12:56 +0000 (23:12 -0600)]
libusb 1.0.21-rc1

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoio: Fix race condition in handle_timeout()
Joost Muller [Wed, 20 Jul 2016 08:58:57 +0000 (10:58 +0200)]
io: Fix race condition in handle_timeout()

There is a race between handle_timeout() the completion functions.
When one thread is in handle_timeout() and another thread wakes
up from a poll(), there exists a window where the transfer has been
cancelled, but its USBI_TRANSFER_TIMED_OUT flag is not set yet.
Therefore, usbi_handle_transfer_completion() is sometimes called
with LIBUSB_TRANSFER_CANCELLED instead of the expected
LIBUSB_TRANSFER_TIMED_OUT.

This change adds transfer and flag locks to the handle_timeout()
function.

Closes #197

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoexamples: add missing include to dpfp_threaded
Nathan Hjelm [Fri, 22 Jul 2016 04:38:32 +0000 (22:38 -0600)]
examples: add missing include to dpfp_threaded

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agofix nano
Nathan Hjelm [Fri, 22 Jul 2016 04:31:09 +0000 (22:31 -0600)]
fix nano

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoexamples: make dpfp_threaded work on OS X
Nathan Hjelm [Fri, 22 Jul 2016 04:26:19 +0000 (22:26 -0600)]
examples: make dpfp_threaded work on OS X

OS X does not support unnamed semaphores so the example has been
updated to use a named semaphore instead.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoExamples: Ported testlibusb from libus-0.1 to libusb-1.0
Anil Nair [Sat, 2 Apr 2016 00:59:11 +0000 (06:29 +0530)]
Examples: Ported testlibusb from libus-0.1 to libusb-1.0

This commit is based on Nathan's branch
https://github.com/hjelmn/libusb-darwin/blob/master/examples/testlibusb1.c

Closes #178

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoAdd support for Intel Alpine Ridge USB 3.1 Controller on Windows 7.
Jeffrey Nichols [Mon, 21 Mar 2016 17:53:11 +0000 (13:53 -0400)]
Add support for Intel Alpine Ridge USB 3.1 Controller on Windows 7.

Closes #176

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoWindows: Clean up referenced devices when memory allocation fails
Chris Dickens [Mon, 30 May 2016 02:44:29 +0000 (19:44 -0700)]
Windows: Clean up referenced devices when memory allocation fails

Similar to commit adb6e39b68699b5d849836f9aaff7640b0f16173, drop the
use of usbi_reallocf() as the memory would be freed, thereby leaking
device references.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoClean failure in discovered_devs_append.
FTDI Dev [Wed, 2 Mar 2016 16:29:27 +0000 (16:29 +0000)]
Clean failure in discovered_devs_append.

Closes #161

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Fix usbi_os_backend structure initialization
Chris Dickens [Mon, 30 May 2016 02:51:48 +0000 (19:51 -0700)]
Misc: Fix usbi_os_backend structure initialization

Backends not using named initializers were broken by the recent
addition of commit a283c3b5a3dce8f6f33331b9aa1d95d41c8f241c.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Add .amend to .gitignore
Chris Dickens [Mon, 30 May 2016 02:19:51 +0000 (19:19 -0700)]
Misc: Add .amend to .gitignore

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoAdd support for persistent device memory.
Steinar H. Gunderson [Sat, 20 Feb 2016 11:26:12 +0000 (12:26 +0100)]
Add support for persistent device memory.

Add a function to allocate memory belonging to a specific device,
so that the operating system can DMA straight into it for zerocopy,
and also avoid some clearing. Also, this allows up-front memory
allocation in the kernel at program startup; memory allocation is
otherwise done per-transfer, which can fail in a system where memory has become
fragmented over time).

This mirrors new functionality going into Linux' USB stack (recently
reviewed and acked upstream); only Linux is supported as a backend
currently.

[Chris Dickens] Modified to fix doxygen documentation, correct parameter
naming, reposition function declarations, and address a missing request
during the patch review process.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoWindows: Fix false assertion failure message during enumeration
Chris Dickens [Mon, 30 May 2016 00:35:09 +0000 (17:35 -0700)]
Windows: Fix false assertion failure message during enumeration

Commit 1d54ee1b6687c532eca75925f56eb12e2a34ce42 addressed a device
reference leak but introduced a false warning message that occurs
for devices detected in early enumeration passes (e.g. hubs). The
assertion is meant to warn of a mismatch between parent devices but
fails to account for the fact that some devices that are allocated
early do not have a parent device assigned until the later
enumeration passes.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoAUTHORS: update my copyright
Nathan Hjelm [Sun, 20 Mar 2016 15:48:06 +0000 (09:48 -0600)]
AUTHORS: update my copyright

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoAppVeyor: add cygwin and minGW support
hacker2490 [Thu, 3 Mar 2016 11:31:37 +0000 (17:01 +0530)]
AppVeyor: add cygwin and minGW support

- Changes in platform configuration, x86 breaks the build
- Solution file does not contain platform for Any CPU, fixing it to Win32
- Added Multiple solutions to appveyor configuration file
- Added batch script for VS2010 builds
- Added fixes to appveyor.bat file and appveyor.yml
- Fixes for Platform and Configuration in appveyor.bat
- Fixed windows exit code, Appveyor reports exit on succesful build
- Multiple Builds in same platform and configuration, fixed it
- Added appveyor configuration to compile using MinGW 32-bit and 64-bits
- Minor Fixes for batch file and Added cygwin build script

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agofix nano version
Nathan Hjelm [Sat, 12 Mar 2016 14:31:45 +0000 (07:31 -0700)]
fix nano version

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoautogen: remove --enable-maintainer-mode
Nathan Hjelm [Sat, 12 Mar 2016 14:29:55 +0000 (07:29 -0700)]
autogen: remove --enable-maintainer-mode

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoconfigure: bump autoconf version and remove obsolete AM_MAINTAINER_MODE
Nathan Hjelm [Thu, 10 Mar 2016 19:57:50 +0000 (12:57 -0700)]
configure: bump autoconf version and remove obsolete AM_MAINTAINER_MODE

This commit bumps the minimum autoconf version to 2.69. This only
affects maintainers and will ensure libusb tarballs have up-to-date
configure scripts. At the same time we are removing the
AM_MAINTAINER_MODE macro as even its creator recommends against
using it.

Closes #122

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agocore: re-add one more conditional
Nathan Hjelm [Sun, 6 Mar 2016 22:04:02 +0000 (15:04 -0700)]
core: re-add one more conditional

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agocore: revert some of prior patch
Nathan Hjelm [Sun, 6 Mar 2016 22:00:31 +0000 (15:00 -0700)]
core: revert some of prior patch

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoREADME.md: update AppVeyor badge (again)
Ludovic Rousseau [Sun, 6 Mar 2016 21:51:46 +0000 (22:51 +0100)]
README.md: update AppVeyor badge (again)

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agofree can handle NULL ptr.
Gaurav [Fri, 19 Jun 2015 03:23:59 +0000 (08:53 +0530)]
free can handle NULL ptr.

free(NULL) is no operation.

Contributed by @ya1gaurav.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoAppVeyor: use a .bat file now
hacker2490 [Thu, 3 Mar 2016 11:31:37 +0000 (17:01 +0530)]
AppVeyor: use a .bat file now

- Changes in platform configuration, x86 breaks the build
- Solution file does not contain platform for Any CPU,fixing it to Win32
- Added Multiple solutions to appveyor configuration file
- Added batch script for VS2010 builds
- Added fixes to appveyor.bat file and appveyor.yml
- Fixes for Platform and Configuration in appveyor.bat
- Fixed windows exit code, Appveyor reports exit on succesful build
- Multiple Builds in same platform and configuration,fixed it

8 years agoandroid: update README
William Skellenger [Sun, 3 Jan 2016 22:04:54 +0000 (17:04 -0500)]
android: update README

Added other $ARCH

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoandroid: Fix typo in README
William Skellenger [Mon, 4 Jan 2016 02:46:50 +0000 (21:46 -0500)]
android: Fix typo in README

Remove the /sdcard copy and not the /system/lib copy

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoREADME.md: update AppVeyor badge
Ludovic Rousseau [Sun, 6 Mar 2016 20:37:00 +0000 (21:37 +0100)]
README.md: update AppVeyor badge

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoexamples: fix 3 compiler warnings
Ludovic Rousseau [Sun, 6 Mar 2016 12:42:13 +0000 (13:42 +0100)]
examples: fix 3 compiler warnings

examples/hotplugtest.c:76:28: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        vendor_id  = (argc > 1) ? strtol (argv[1], NULL, 0) : 0x045a;
                   ~              ^~~~~~~~~~~~~~~~~~~~~~~~~
examples/hotplugtest.c:77:28: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        product_id = (argc > 2) ? strtol (argv[2], NULL, 0) : 0x5005;
                   ~              ^~~~~~~~~~~~~~~~~~~~~~~~~
examples/hotplugtest.c:78:28: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        class_id   = (argc > 3) ? strtol (argv[3], NULL, 0) : LIBUSB_HOTPLUG_MATCH_ANY;
                   ~              ^~~~~~~~~~~~~~~~~~~~~~~~~

8 years agodarwin: build hotplugtest sample in Xcode
Ludovic Rousseau [Sun, 6 Mar 2016 12:37:14 +0000 (13:37 +0100)]
darwin: build hotplugtest sample in Xcode

The Xcode project now also builds the hotplugtest (from examples/hotplugtest.c)
target.

8 years agodarwin: fix occasional dead-lock on libusb_exit
parafin [Thu, 15 Oct 2015 17:12:42 +0000 (20:12 +0300)]
darwin: fix occasional dead-lock on libusb_exit

CFRunLoopStop() isn't thread-safe, see for example this bugreport:
https://github.com/joyent/libuv/issues/799
Use CFRunLoopSource instead

Closes #112

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoxusb: fix typo
Nathan Hjelm [Sat, 5 Mar 2016 15:00:11 +0000 (08:00 -0700)]
xusb: fix typo

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoReplace obsolete usleep with nanosleep
Stefan Tauner [Mon, 18 Jan 2016 23:02:16 +0000 (00:02 +0100)]
Replace obsolete usleep with nanosleep

This fixes compiling libusb with uclibc.

Closes #141, #165

Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
8 years agoREADME.md: add AppVeyor badge
Ludovic Rousseau [Thu, 3 Mar 2016 20:50:15 +0000 (21:50 +0100)]
README.md: add AppVeyor badge

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoAppVeyor: initial configuration file
hacker2490 [Thu, 3 Mar 2016 20:11:20 +0000 (21:11 +0100)]
AppVeyor: initial configuration file

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoWindows: Fix MinGW build
Chris Dickens [Thu, 3 Mar 2016 08:20:33 +0000 (00:20 -0800)]
Windows: Fix MinGW build

The integration of UsbDk moved the windows_error_str() function to
windows_nt_common.c, but the definition of FACILITY_SETUPAPI (which
MinGW headers do not provide) did not follow the move.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agotravis-CI: fails compilation on warning
Ludovic Rousseau [Sat, 27 Feb 2016 16:17:24 +0000 (17:17 +0100)]
travis-CI: fails compilation on warning

The travis-autogen.sh script enable some extra warnings not used by
default. The idea is to detect problem as early as possible.

8 years agoexamples: fix 3 compiler warnings
Ludovic Rousseau [Sat, 27 Feb 2016 16:52:05 +0000 (17:52 +0100)]
examples: fix 3 compiler warnings

fxload.c:202:17: warning: comparison of integers of different signs: 'int' and
      'unsigned long' [-Wsign-compare]
  ...for (j=0; j<ARRAYSIZE(known_device); j++) {
               ~^~~~~~~~~~~~~~~~~~~~~~~~
fxload.c:222:12: warning: comparison of integers of different signs: 'int' and
      'unsigned long' [-Wsign-compare]
                                        if (j < ARRAYSIZE(known_device)) {
                                            ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
fxload.c:263:13: warning: comparison of integers of different signs: 'int' and
      'unsigned long' [-Wsign-compare]
        for (i=0; i<ARRAYSIZE(path); i++) {
                  ~^~~~~~~~~~~~~~~~

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoexamples: fix 2 compiler warnings
Ludovic Rousseau [Sat, 27 Feb 2016 16:49:55 +0000 (17:49 +0100)]
examples: fix 2 compiler warnings

sam3u_benchmark.c:54:17: warning: comparison of integers of different signs:
      'unsigned int' and 'int' [-Wsign-compare]
                for (i = 0; i < xfr->num_iso_packets; i++) {
                            ~ ^ ~~~~~~~~~~~~~~~~~~~~
sam3u_benchmark.c:67:16: warning: comparison of integers of different signs:
      'unsigned int' and 'int' [-Wsign-compare]
        for (i = 0; i < xfr->actual_length; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoexamples: fix 2 compiler warnings
Ludovic Rousseau [Sat, 27 Feb 2016 16:47:12 +0000 (17:47 +0100)]
examples: fix 2 compiler warnings

ezusb.c:136:13: warning: comparison of integers of different signs: 'int' and
      'size_t' (aka 'unsigned long') [-Wsign-compare]
        if (status != len) {
            ~~~~~~ ^  ~~~
ezusb.c:159:13: warning: comparison of integers of different signs: 'int' and
      'size_t' (aka 'unsigned long') [-Wsign-compare]
        if (status != len) {
            ~~~~~~ ^  ~~~

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agodarwin: fix 1 compiler warning
Ludovic Rousseau [Sat, 27 Feb 2016 16:42:55 +0000 (17:42 +0100)]
darwin: fix 1 compiler warning

os/darwin_usb.c:248:18: warning: comparison of integers of different signs:
      'CFIndex' (aka 'long') and 'size_t' (aka 'unsigned long')
      [-Wsign-compare]
      if (length < size) {
          ~~~~~~ ^ ~~~~

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agocore: fix 2 compiler warnings
Ludovic Rousseau [Sat, 27 Feb 2016 16:37:49 +0000 (17:37 +0100)]
core: fix 2 compiler warnings

core.c:2361:35: warning: comparison of integers of different signs: 'int' and
      'unsigned long' [-Wsign-compare]
        if (header_len < 0 || header_len >= sizeof(buf)) {
                              ~~~~~~~~~~ ^  ~~~~~~~~~~~
core.c:2370:44: warning: comparison of integers of different signs: 'int' and
      'unsigned long' [-Wsign-compare]
        if (text_len < 0 || text_len + header_len >= sizeof(buf)) {
                            ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoREADME.md: add Coverity badge
Ludovic Rousseau [Wed, 2 Mar 2016 13:12:04 +0000 (14:12 +0100)]
README.md: add Coverity badge

The libusb project is available on Coverity at https://scan.coverity.com/projects/libusb-libusb

Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr>
8 years agoWindows: Fix faulty logic that can pick the wrong config descriptor
Chris Dickens [Wed, 2 Mar 2016 08:16:16 +0000 (00:16 -0800)]
Windows: Fix faulty logic that can pick the wrong config descriptor

The WinUSB backend caches the bConfigurationValue of the currently
active configuration when the device is enumerated. In some parts of
the code, the config descriptor is fetched to correlate interfaces
and endpoints by calling libusb_get_config_descriptor() using the
cached bConfigurationValue. This is incorrect usage of the function
as the input parameter is the zero-based configuration index, which
can differ in some devices from the bConfigurationValue.

See discussion: http://marc.info/?l=libusb-devel&m=144355607228333

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoWindows: Add backend support for get_config_descriptor_by_value()
Chris Dickens [Wed, 2 Mar 2016 08:14:50 +0000 (00:14 -0800)]
Windows: Add backend support for get_config_descriptor_by_value()

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoWindows: Fix dev_interface_path memory leak when reusing device ref
Angus Gratton [Tue, 28 Apr 2015 06:49:57 +0000 (16:49 +1000)]
Windows: Fix dev_interface_path memory leak when reusing device ref

windows_get_device_list was leaking dev_interface_path (in either of two
possible places) when a pre-existing device reference was reused.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoWindows: Fix parent USB device reference leak
Angus Gratton [Tue, 28 Apr 2015 06:46:37 +0000 (16:46 +1000)]
Windows: Fix parent USB device reference leak

If windows_get_device_list() found a device that already existed, it
would erronenously increment the parent_dev refcount and cause a
reference leak - the parent device would never be released.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agobootstrap: use autoreconf
Nathan Hjelm [Thu, 25 Feb 2016 20:35:36 +0000 (13:35 -0700)]
bootstrap: use autoreconf

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: one more fix. need packages under apt
Nathan Hjelm [Fri, 26 Feb 2016 04:51:10 +0000 (21:51 -0700)]
travis: one more fix. need packages under apt

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: sources line is needed
Nathan Hjelm [Fri, 26 Feb 2016 04:45:15 +0000 (21:45 -0700)]
travis: sources line is needed

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: bah. remove tabs
Nathan Hjelm [Fri, 26 Feb 2016 04:40:30 +0000 (21:40 -0700)]
travis: bah. remove tabs

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: use addons to install packages
Nathan Hjelm [Fri, 26 Feb 2016 04:36:26 +0000 (21:36 -0700)]
travis: use addons to install packages

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoMisc: Link README to README.md to satisfy autotools
Chris Dickens [Thu, 25 Feb 2016 22:13:43 +0000 (14:13 -0800)]
Misc: Link README to README.md to satisfy autotools

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Add markdown references for COPYING and PORTING files
Chris Dickens [Thu, 25 Feb 2016 21:53:05 +0000 (13:53 -0800)]
Misc: Add markdown references for COPYING and PORTING files

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Convert README to README.md
Chris Dickens [Thu, 25 Feb 2016 21:49:16 +0000 (13:49 -0800)]
Misc: Convert README to README.md

This allows markdown, including displaying Travis build status.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMerge pull request #154 from hjelmn/darwin_gettime_fix
Nathan Hjelm [Thu, 25 Feb 2016 20:39:46 +0000 (13:39 -0700)]
Merge pull request #154 from hjelmn/darwin_gettime_fix

threads_posix: use backend clock_gettime()

8 years agotravis: test xcode project
Nathan Hjelm [Thu, 25 Feb 2016 20:23:19 +0000 (13:23 -0700)]
travis: test xcode project

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agothreads_posix: use backend clock_gettime()
Nathan Hjelm [Thu, 25 Feb 2016 17:05:49 +0000 (10:05 -0700)]
threads_posix: use backend clock_gettime()

Some platforms do not implement the optional clock_gettime(). Need
to use the backend implementation instead.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: Add sudo to apt-get commands
Chris Dickens [Thu, 25 Feb 2016 18:56:16 +0000 (10:56 -0800)]
travis: Add sudo to apt-get commands

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agotravis: Update config file
Chris Dickens [Thu, 25 Feb 2016 18:25:19 +0000 (10:25 -0800)]
travis: Update config file

Use 'script' instead of 'install' to specify build command.
Add linux build option with udev disabled.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agotravis: fix typo
Nathan Hjelm [Thu, 25 Feb 2016 17:25:07 +0000 (10:25 -0700)]
travis: fix typo

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agotravis: ensure udev is installed
Nathan Hjelm [Thu, 25 Feb 2016 17:12:55 +0000 (10:12 -0700)]
travis: ensure udev is installed

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agoAdd Travis CI configuration
Nathan Hjelm [Thu, 25 Feb 2016 16:55:25 +0000 (09:55 -0700)]
Add Travis CI configuration

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
8 years agocore: Remove POSIX threads influence from synchronization code
Chris Dickens [Sat, 30 Jan 2016 10:24:39 +0000 (02:24 -0800)]
core: Remove POSIX threads influence from synchronization code

This commit changes the signatures of the synchronization functions
to reflect the needs of the library rather than the signature of the
pthreads API. The mutex and condition variable attributes parameters
have been removed as no part of the core library makes use of them.

In addition, the condition variable timed-wait function has been modified
to accept the relative time passed in via libusb_wait_for_event(). This
allows the implementation-specific code to handle conversion to absolute
time as necessary, rather than forcing this to occur.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Remove unused definitions for usbi_cond_signal()
Chris Dickens [Sat, 30 Jan 2016 10:24:38 +0000 (02:24 -0800)]
Misc: Remove unused definitions for usbi_cond_signal()

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Document the return code for control transfers that are too large
Chris Dickens [Wed, 24 Feb 2016 09:50:40 +0000 (01:50 -0800)]
Misc: Document the return code for control transfers that are too large

Closes #110

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Add libusb_interrupt_event_handler() to API docs page
Chris Dickens [Wed, 24 Feb 2016 09:21:52 +0000 (01:21 -0800)]
Misc: Add libusb_interrupt_event_handler() to API docs page

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Prefix doxygen references in order to namespace libusb
Chris Dickens [Wed, 24 Feb 2016 09:07:20 +0000 (01:07 -0800)]
Misc: Prefix doxygen references in order to namespace libusb

This change add "libusb_" to every group and page definition (and
updates all references accordingly) so that generated man pages
are namespaced for libusb, thus avoiding possible conflict with
other packages.

Closes #131

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agoMisc: Make API parameter names consistent and sensible
Chris Dickens [Wed, 24 Feb 2016 08:23:49 +0000 (00:23 -0800)]
Misc: Make API parameter names consistent and sensible

Prior to this commit, API functions taking a libusb_device_handle
argument had the parameter named dev, handle, or dev_handle. This
commit changes the name of all libusb_device_handle parameters to
dev_handle in both the documentation and actual code.

Closes #132

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agosync: Allow transferred argument to be optional in bulk APIs
Chris Dickens [Wed, 24 Feb 2016 07:45:51 +0000 (23:45 -0800)]
sync: Allow transferred argument to be optional in bulk APIs

Closes #139

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agowindows: Fix compilation for MSYS2
Evan Hunter [Fri, 8 Jan 2016 13:53:42 +0000 (13:53 +0000)]
windows: Fix compilation for MSYS2

Closes #140

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>
8 years agolinux_netlink: Add message authentication and clean up parsing
Chris Dickens [Thu, 28 Jan 2016 22:29:42 +0000 (14:29 -0800)]
linux_netlink: Add message authentication and clean up parsing

This commit adds credentials checking to ensure that we only process
messages received from the kernel. In addition, the parsing logic
was cleaned up and slightly optimized.

Signed-off-by: Chris Dickens <christopher.a.dickens@gmail.com>