platform/core/uifw/dali-toolkit.git
3 years ago(TextController) Fixed SVACE errors in EventHandler 92/262992/2
Adeel Kazmi [Tue, 24 Aug 2021 09:12:06 +0000 (10:12 +0100)]
(TextController) Fixed SVACE errors in EventHandler

Change-Id: I71b617bca81576d478f2eaae794d45ca9fd3f1b8

3 years agoMerge "Add SelectionChanged signal" into devel/master
Bowon Ryu [Mon, 23 Aug 2021 08:33:54 +0000 (08:33 +0000)]
Merge "Add SelectionChanged signal" into devel/master

3 years agoAdd SelectionChanged signal 91/262091/13
abdullah [Mon, 2 Aug 2021 15:48:39 +0000 (18:48 +0300)]
Add SelectionChanged signal

added signal which will be called when selection has been changed

void OnSelectionChanged(TextEditor textEditor, uint32_t oldStart, uint32_t oldEnd)

Change-Id: I2f769fe11f487462309d8a474fd8ac5aa5c1f2d8

3 years agoMerge "CanvasView: Change Process to be called as PostProcessor" into devel/master
junsu choi [Mon, 23 Aug 2021 01:22:58 +0000 (01:22 +0000)]
Merge "CanvasView: Change Process to be called as PostProcessor" into devel/master

3 years agoMerge "DALi Version 2.0.40" into devel/master
Adeel Kazmi [Fri, 20 Aug 2021 11:20:40 +0000 (11:20 +0000)]
Merge "DALi Version 2.0.40" into devel/master

3 years agoDALi Version 2.0.40 43/262843/1 dali_2.0.40
David Steele [Fri, 20 Aug 2021 11:18:46 +0000 (12:18 +0100)]
DALi Version 2.0.40

Change-Id: I5898f5f1e8cfb8ffaf5ca4e9ed405552184b2727

3 years agoCanvasView: Change Process to be called as PostProcessor 27/262827/3
JunsuChoi [Fri, 20 Aug 2021 07:49:35 +0000 (16:49 +0900)]
CanvasView: Change Process to be called as PostProcessor

Size is set first and then Process Rasterizes.

Change-Id: I11f8806d63acd55dc611114fdfbacee0dc72aa1f

3 years agoMerge "Add CursorPositionChanged Signal" into devel/master
Bowon Ryu [Fri, 20 Aug 2021 06:32:43 +0000 (06:32 +0000)]
Merge "Add CursorPositionChanged Signal" into devel/master

3 years ago(Vector) Reduce unnecessray loop 14/262714/2
Heeyong Song [Wed, 18 Aug 2021 08:28:55 +0000 (17:28 +0900)]
(Vector) Reduce unnecessray loop

Change-Id: I8b39d4d21e8a397bed8f06dbf03fd85ac2cec6fd

3 years agoAdd CursorPositionChanged Signal 62/262362/10
abdullah [Sun, 8 Aug 2021 08:42:39 +0000 (11:42 +0300)]
Add CursorPositionChanged Signal

added signal which will be called when cursor(caret) position has been changed.

void OnCursorPositionChanged(TextEditor textEditor, uint32_t oldPosition)

Change-Id: I5cb768e1a7ae55840fed1d5c320b48ad8731f30d

3 years agoMerge "Support line spacing & min line size in texteditor" into devel/master
Bowon Ryu [Fri, 20 Aug 2021 02:21:37 +0000 (02:21 +0000)]
Merge "Support line spacing & min line size in texteditor" into devel/master

3 years agoIf parent is hidden, the child cannot be focused. 53/262753/2
joogab.yun [Thu, 19 Aug 2021 06:41:48 +0000 (15:41 +0900)]
If parent is hidden, the child cannot be focused.

Change-Id: I4b8fc1d81099583805c3bfc7ab4fd33231bc9f16

3 years agoDisconnect relationship with VisualUrl and VisualFactory 55/262455/11
Eunki Hong [Wed, 11 Aug 2021 06:42:00 +0000 (23:42 -0700)]
Disconnect relationship with VisualUrl and VisualFactory

When VisualFactory destory,
VisualFactoryCache also destroy, and TextureManager also destory.
At this time, mTextureInfoContainer clear, and TextureInfo's VisualUrl destroy.

When VisualUrl destuctor called, we call VisaulFactory::Get() and try to get TextureManager.
But We are now on VisualFactory's destroy called...

This is why image-view-encoded-image-buffer.example make Segfault.

This patch move previous VisualUrl's job
to TextureManager and ImageVisual.

Change-Id: Iefc6fe7f8bda6cee08fdaafded4979935cbc87a2
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
3 years agoMerge "Fixed IsCandidate bug" into devel/master
joogab yun [Tue, 17 Aug 2021 01:03:37 +0000 (01:03 +0000)]
Merge "Fixed IsCandidate bug" into devel/master

3 years agoMerge "Change raw pointer to unique_ptr" into devel/master
Bowon Ryu [Tue, 17 Aug 2021 01:03:23 +0000 (01:03 +0000)]
Merge "Change raw pointer to unique_ptr" into devel/master

3 years agoMerge "DALi Version 2.0.39" into devel/master
David Steele [Fri, 13 Aug 2021 13:03:57 +0000 (13:03 +0000)]
Merge "DALi Version 2.0.39" into devel/master

3 years agoDALi Version 2.0.39 91/262591/1 dali_2.0.39
Adeel Kazmi [Fri, 13 Aug 2021 12:46:37 +0000 (13:46 +0100)]
DALi Version 2.0.39

Change-Id: Ia024d79423aef61658cba1f8d9cb1162f472c2e4

3 years agoChange raw pointer to unique_ptr 83/262583/5
Bowon Ryu [Fri, 13 Aug 2021 09:20:00 +0000 (18:20 +0900)]
Change raw pointer to unique_ptr

The mPlaceholderFont pointer is allocated memory once only
when the text-controller uses a placeholder.
This will persist until mEventData is destroyed.
Changed to a smart pointer suitable for maintenance.

Additionally,
In SetPlaceholderTextFontWidth() and SetPlaceholderTextFontSlant(), mPlaceholderFont can not be NULL.

Even if there is no value in SetFontStyleProperty, it is always set to None,
This is because an instance of mPlaceholderFont is created through SetPlaceholderTextFontWeight(), which is called first.

So this causes coverage issues.
Replace the duplicate code with CreatePlaceholderFont() solves this problem.

Change-Id: Ibd11b02f22e505be8643c9360b5d5e5e2de1b318
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoMerge "CanvasView: Change CanvasRenderer::GetSize() method to const" into devel/master
junsu choi [Fri, 13 Aug 2021 00:14:52 +0000 (00:14 +0000)]
Merge "CanvasView: Change CanvasRenderer::GetSize() method to const" into devel/master

3 years agoMerge "Fix comments about CornerRadiusPolicy and BorderlineColor" into devel/master
Eunki Hong [Tue, 10 Aug 2021 04:41:58 +0000 (04:41 +0000)]
Merge "Fix comments about CornerRadiusPolicy and BorderlineColor" into devel/master

3 years agoSupport line spacing & min line size in texteditor 00/261800/7
abdullah [Mon, 26 Jul 2021 06:42:30 +0000 (09:42 +0300)]
Support line spacing & min line size in texteditor

support texteditor to have properties like textlabel.

line spacing set the space between lines.
min line size set the total line size (we internally take the max between line size vs font line size)

Change-Id: I2cccc910406db181561ff5e7274b997b60b44737

3 years agoFix comments about CornerRadiusPolicy and BorderlineColor 60/262360/1
Eunki, Hong [Mon, 9 Aug 2021 05:26:55 +0000 (14:26 +0900)]
Fix comments about CornerRadiusPolicy and BorderlineColor

When CornerRadiusPolicy is Relative, the maximum value is 0.5f.
If value is bigger than 0.5f, it will be clampled internally.
But we cannot notificate that informations only by documents.
Now fix it.
+
We add some more informations about borderline color;
It will be affected by visual opacity

Change-Id: Ic8afc5de3fd92b9cefcb1378959cb9ff4ab8102d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 years agoMerge "Add TextSelect()" into devel/master
Bowon Ryu [Mon, 9 Aug 2021 04:38:35 +0000 (04:38 +0000)]
Merge "Add TextSelect()" into devel/master

3 years agoMerge "fix wrong behaviour of SelectWholeText()" into devel/master
Bowon Ryu [Mon, 9 Aug 2021 04:38:31 +0000 (04:38 +0000)]
Merge "fix wrong behaviour of SelectWholeText()" into devel/master

3 years agoMerge "Fix SetPrimaryCursorPosition() behaviour when no focus" into devel/master
Bowon Ryu [Mon, 9 Aug 2021 04:38:20 +0000 (04:38 +0000)]
Merge "Fix SetPrimaryCursorPosition() behaviour when no focus" into devel/master

3 years agoFixed IsCandidate bug 01/262301/1
joogab.yun [Fri, 6 Aug 2021 15:54:27 +0000 (00:54 +0900)]
Fixed IsCandidate bug

Change-Id: Ibaa8a6412f28acf60011173487123f0d9dc6ec08

3 years agoMerge "DALi Version 2.0.38" into devel/master
Adeel Kazmi [Fri, 6 Aug 2021 10:28:07 +0000 (10:28 +0000)]
Merge "DALi Version 2.0.38" into devel/master

3 years agoDALi Version 2.0.38 15/262315/1 dali_2.0.38
Richard Huang [Fri, 6 Aug 2021 09:47:51 +0000 (10:47 +0100)]
DALi Version 2.0.38

Change-Id: Id8fc11eea89453a28282de08ba8635d0df8006e6

3 years agoMerge "[ATSPI] Fix for SCREEN coordinate type in GetExtents" into devel/master
Eunki Hong [Fri, 6 Aug 2021 03:46:40 +0000 (03:46 +0000)]
Merge "[ATSPI] Fix for SCREEN coordinate type in GetExtents" into devel/master

3 years agoMerge "[AT-SPI] enhance SHOWING state decision logic" into devel/master
Shinwoo Kim [Fri, 6 Aug 2021 00:41:17 +0000 (00:41 +0000)]
Merge "[AT-SPI] enhance SHOWING state decision logic" into devel/master

3 years agoFixed bug 59/262259/1
joogab.yun [Thu, 5 Aug 2021 17:11:27 +0000 (02:11 +0900)]
Fixed bug

Change-Id: Ib1f9d1ebbab42399dd8437247adea2072061b30c

3 years agoFix to build incrementally with gbs 86/259386/3
Daekwang Ryu [Thu, 3 Jun 2021 06:27:49 +0000 (15:27 +0900)]
Fix to build incrementally with gbs

Incremental build with gbs calls the prep section in the rpm spec once.
It doesn't execute the section from second.

Change-Id: I5eaa375566013bd91de206a34fd0acee937a4e6b

3 years agoCheck if actor can be focused. 96/262196/3
joogab.yun [Wed, 4 Aug 2021 03:05:34 +0000 (12:05 +0900)]
Check if actor can be focused.

Change-Id: I7066fae12059dbdb29e333dd2aac653bf7656ba7

3 years agoAdd TextSelect() 09/261509/6
Bowon Ryu [Tue, 20 Jul 2021 08:39:16 +0000 (17:39 +0900)]
Add TextSelect()

This api can replace the SELECTED_TEXT_START and SELECTED_TEXT_END properties.
The feature to select a range of text should be provided as a method like SelectWholeText(), SelectNone().

Currently, the SELECTED_TEXT_START and SELECTED_TEXT_END properties are causing several problems.
1. User can not set start and end at the same time.
2. Since it is not an event method, it does not work if it is called before text is rendered.

This patch adds SelectText().
And I will make a separate patch to remove the property.

Change-Id: I5a050cd88b9597b939766e1a6ec0e39edf96e2d4
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoCanvasView: Change CanvasRenderer::GetSize() method to const 50/262250/1
JunsuChoi [Thu, 5 Aug 2021 06:19:27 +0000 (15:19 +0900)]
CanvasView: Change CanvasRenderer::GetSize() method to const

Change-Id: Ia75ec89ae37ef457102e124eb4ad186dcee480b3

3 years agofix wrong behaviour of SelectWholeText() 53/261153/6
Bowon Ryu [Mon, 12 Jul 2021 10:56:15 +0000 (19:56 +0900)]
fix wrong behaviour of SelectWholeText()

When there are multiple text controls,
there is a problem that the selection is keeped even if the text control loses focus
due to another text control's SelectWholeText().

This patch prevents wrong selection updates via flags.

// example
DevelTextField::SelectWholeText(field1);
DevelTextField::SelectWholeText(field2);
DevelTextField::SelectWholeText(field3);
DevelTextField::SelectWholeText(field4);

In the case of above example, all TextFields display a selection.

Change-Id: I96f87d0b12e4a91493831ca55e0f8b662391456e
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoFix SetPrimaryCursorPosition() behaviour when no focus 37/260837/8
Bowon Ryu [Mon, 5 Jul 2021 11:12:31 +0000 (20:12 +0900)]
Fix SetPrimaryCursorPosition() behaviour when no focus

If TextField does SetPrimaryCursorPosition() before CONNECTED_TO_SCENE,
there is an issue that the caret renders regardless of focus.

Also, SetPrimaryCursorPosition() always sets focus to the Text Control regardless of the user's intent.
This creates unintended bugs in the app.

This patch only updates the value of PrimaryCursorPosition when there is no focus.
When there is focus, the behaviour is the same.

Change-Id: I2bc5851c36e2c08976e7ca4656bfe38f6afe0653
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[ATSPI] Fix for SCREEN coordinate type in GetExtents 63/261963/10
Lukasz Oleksak [Thu, 29 Jul 2021 13:58:34 +0000 (15:58 +0200)]
[ATSPI] Fix for SCREEN coordinate type in GetExtents

Change-Id: I9c030b9cd7d153e19de13d381778ab1750c71cb3

3 years agoMerge "PositionSize API at dali-toolkit-test-utils/toolkit-window.cpp" into devel...
Eunki Hong [Tue, 3 Aug 2021 11:10:06 +0000 (11:10 +0000)]
Merge "PositionSize API at dali-toolkit-test-utils/toolkit-window.cpp" into devel/master

3 years agoPositionSize API at dali-toolkit-test-utils/toolkit-window.cpp 73/262173/2
Eunki, Hong [Tue, 3 Aug 2021 09:44:08 +0000 (18:44 +0900)]
PositionSize API at dali-toolkit-test-utils/toolkit-window.cpp

Previous version don't use Window.RenderSurface's PositionSize information
I add some interface that toolkit UTC can use it.

Change-Id: I59aae83bdf84c71dcc936b076b424eb0fcc8df9e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 years agoRemove VisualFactory::Get() code at AsyncImageLoader 49/262049/2
Eunki, Hong [Mon, 2 Aug 2021 05:29:12 +0000 (14:29 +0900)]
Remove VisualFactory::Get() code at AsyncImageLoader

Make to send EncodedImageBuffer from TextureManager to AsyncImageLoader directly.
Now we don't need to get standalone factory at AsyncImageLoader.
So we don't need fearful exception check

Change-Id: I9b903c6a446fc167d11bdf7e22e6c7e19d085cc5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 years ago[AT-SPI] enhance SHOWING state decision logic 13/258813/6
Shinwoo Kim [Wed, 26 May 2021 05:11:14 +0000 (14:11 +0900)]
[AT-SPI] enhance SHOWING state decision logic

To define SHOWING state, using CULLED and VISIBLE property is not enough.
If a child is clipped out by its parent, then CULLED property is not TRUE.
We need to use similar logic as EFL does.

./src/lib/elementary/efl_ui_widget.c > _elm_widget_onscreen_is
is used for calculating SHOWING state using parents geometry information.

So this patch set is using parents extent information for SHOWING state.

Change-Id: I5eecf93c66ce199bd0ca88f3ad3ff471c1ff79a5

3 years agoRemove Unnecessary Doxygen PREDEFINED 78/262078/2
Eunki, Hong [Mon, 2 Aug 2021 10:58:44 +0000 (19:58 +0900)]
Remove Unnecessary Doxygen PREDEFINED

This typoerror exist since 2014-11-14. And today, It fixed.

Change-Id: I51d71ca119ea061bf369b97535fed7526c2d9419
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 years agoMerge "Set TapGesture only if there is an anchor." into devel/master
joogab yun [Sun, 1 Aug 2021 23:52:33 +0000 (23:52 +0000)]
Merge "Set TapGesture only if there is an anchor." into devel/master

3 years agoSet TapGesture only if there is an anchor. 51/261851/10
joogab.yun [Tue, 27 Jul 2021 18:40:45 +0000 (03:40 +0900)]
Set TapGesture only if there is an anchor.

Change-Id: I3787911cbedda12b5d781e8de6b16902c23186e7

3 years agoDALi Version 2.0.37 03/262003/1 dali_2.0.37
Adam Bialogonski [Fri, 30 Jul 2021 10:21:48 +0000 (11:21 +0100)]
DALi Version 2.0.37

Change-Id: Ifb9bf35a343400030e3731d3d2506ed30d8b0cad

3 years agoMerge "Add transition headers in dali-toolkit.h" into devel/master
Adeel Kazmi [Thu, 29 Jul 2021 11:19:13 +0000 (11:19 +0000)]
Merge "Add transition headers in dali-toolkit.h" into devel/master

3 years agoAdd transition headers in dali-toolkit.h 88/261888/3
seungho [Wed, 28 Jul 2021 08:13:49 +0000 (17:13 +0900)]
Add transition headers in dali-toolkit.h

Change-Id: I76cc0118a6312c81d4477d47a14ee849bfdf3e92
Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years agoCanvasView: Add RemoveAllDrawables() API 81/261181/7
JunsuChoi [Tue, 13 Jul 2021 03:00:12 +0000 (12:00 +0900)]
CanvasView: Add RemoveAllDrawables() API

Add an API that removes the all drawables registered with AddDrawable().

Change-Id: I6a47c4ce980cdebb374acfe8dfb87b0a815de138

3 years agoCanvasView: Add RemoveDrawable() API 77/261177/5
JunsuChoi [Tue, 13 Jul 2021 02:05:56 +0000 (11:05 +0900)]
CanvasView: Add RemoveDrawable() API

Add an API that removes the Drawable registered with AddDrawable().

Change-Id: Icf5796ca03093d20f13e5fe12db8c75aa5965a7e

3 years agoCanvasView: Add Property::VIEW_BOX 11/261111/9
JunsuChoi [Mon, 12 Jul 2021 05:55:09 +0000 (14:55 +0900)]
CanvasView: Add Property::VIEW_BOX

Add VIEW_BOX property to change canvas's viewbox value.

Change-Id: I4b23049f390158b232d1055703968637ebcbc3fa

3 years agoAdd CanvasView::New() API that can be created without viewbox. 81/261081/7
JunsuChoi [Fri, 9 Jul 2021 09:29:31 +0000 (18:29 +0900)]
Add CanvasView::New() API that can be created without viewbox.

This is provided in case the viewBox argument is not absolutely necessary.

Change-Id: Ic955b4cacb93620c1f48b62f82ef5cc16c335f59

3 years agoMerge "Add CanvasView thread rasterization" into devel/master
junsu choi [Thu, 29 Jul 2021 04:10:13 +0000 (04:10 +0000)]
Merge "Add CanvasView thread rasterization" into devel/master

3 years agoFix SVACE error caused by recent ATSPI change 07/261907/1
Adeel Kazmi [Wed, 28 Jul 2021 15:56:23 +0000 (16:56 +0100)]
Fix SVACE error caused by recent ATSPI change

Change-Id: I150b9d4a0afd74081baa92fddf153824dd44faa6

3 years ago[ATSPI] Blocking unwanted emission of "MoveOuted" signal 38/261238/10
Lukasz Oleksak [Tue, 13 Jul 2021 16:31:24 +0000 (18:31 +0200)]
[ATSPI] Blocking unwanted emission of "MoveOuted" signal

This patch is blocking unwanted emission of "MoveOuted" signal to dbus
when auto-scroll feature moves highlighted object into the screen.

This patch requires following dali-adaptor patch:
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/261237/

Change-Id: I43115faf0e9a061436d6751069ca1541ff0d4017

3 years agoGenerate url and load texture from encoded image buffer 15/259415/24
Eunki, Hong [Tue, 8 Jun 2021 06:07:20 +0000 (15:07 +0900)]
Generate url and load texture from encoded image buffer

Make some way to load image from raw-buffer stream.
This raw-buffer will alive when some actor contain this buffer.

Limitation : animated-image, vector-image, animated-vector-image not working now. Will support another patch

1. Generate url from encoded raw buffer like this
  ImageUrl url = Toolkit::Image::GenerateUrl(const EncodedImageBuffer &);
2. When we use URL as this string, we can load it like normal LOCAL file.
  ImageView imageView = Toolkit::ImageView::New(url.GetUrl());
3. Buffer will automatically removed when ImageUrl scope is out-of-date, and no actor use it.

NOTE : even ImageUrl lifecycle is done, cached texture can use internally.

Change-Id: I517d9526d13a6b761792dcb7054864643f209b67
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
3 years agoAdd CanvasView thread rasterization 50/259050/33
JunsuChoi [Mon, 31 May 2021 05:44:59 +0000 (14:44 +0900)]
Add CanvasView thread rasterization

When a rasterize request occurs, create a task and rasterize on thread.

Change-Id: I8f9117490fb242c91d0124759e0a1f7df9ed701a

3 years agoMerge "Reduce the number of conversion between std::string <-> VisaulUrl at interal...
Eunki Hong [Mon, 26 Jul 2021 05:49:33 +0000 (05:49 +0000)]
Merge "Reduce the number of conversion between std::string <-> VisaulUrl at interal" into devel/master

3 years agoFix SVACE errors in accessibility code in control-data-impl 53/261753/2
Adeel Kazmi [Fri, 23 Jul 2021 11:06:41 +0000 (12:06 +0100)]
Fix SVACE errors in accessibility code in control-data-impl

Change-Id: I08d2e79b19cb269ed48db198ebd04a45f9f89d18

3 years agoMerge "DALi Version 2.0.36" into devel/master
David Steele [Fri, 23 Jul 2021 10:33:01 +0000 (10:33 +0000)]
Merge "DALi Version 2.0.36" into devel/master

3 years agoDALi Version 2.0.36 37/261737/1 dali_2.0.36
Richard Huang [Fri, 23 Jul 2021 09:28:32 +0000 (10:28 +0100)]
DALi Version 2.0.36

Change-Id: I4aad1dc9a06436b74dd92396c2e0cf7bf3436ef6

3 years agoMerge "Implement WebView::GetPlainTextAsynchronously" into devel/master
JIYUN YANG [Fri, 23 Jul 2021 08:44:58 +0000 (08:44 +0000)]
Merge "Implement WebView::GetPlainTextAsynchronously" into devel/master

3 years agoMerge "[ATSPI] Check higlight area using PropertyNotification" into devel/master
Shinwoo Kim [Thu, 22 Jul 2021 22:51:48 +0000 (22:51 +0000)]
Merge "[ATSPI] Check higlight area using PropertyNotification" into devel/master

3 years agoImplement WebView::GetPlainTextAsynchronously 89/261689/2
Jiyun Yang [Thu, 22 Jul 2021 13:07:20 +0000 (22:07 +0900)]
Implement WebView::GetPlainTextAsynchronously

Change-Id: I6691a877ec987dc9971216a43a34bb6daa2ba95d
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoAdded missing initialization in text layout-engine 84/261684/1
Bowon Ryu [Thu, 22 Jul 2021 10:01:17 +0000 (19:01 +0900)]
Added missing initialization in text layout-engine

Change-Id: Ie9c22749be2d2bf9a362db03ccb1d09f411f055f
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoFix coverity issue in text layout-engine 80/261680/1
Bowon Ryu [Thu, 22 Jul 2021 09:14:32 +0000 (18:14 +0900)]
Fix coverity issue in text layout-engine

middleLineIndex is always bigger than 0u by the while condition (0u < middleLineIndex).
therefore execution cannot reach the expression 0u inside the statement below.
: ellipsisLineIndex = middleLineIndex > 0u ? middleLineIndex - 1u : 0u;

Change-Id: I1f2f85768ba638d3493f62a22b3d89a75ef462ae
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years agoMerge "Fix to do not remove entity inside loop.(Transition)" into devel/master
Seungho BAEK [Wed, 21 Jul 2021 06:30:11 +0000 (06:30 +0000)]
Merge "Fix to do not remove entity inside loop.(Transition)" into devel/master

3 years agoMerge "Add ApplyCustomFragmentPrefix" into devel/master
Seungho BAEK [Wed, 21 Jul 2021 06:30:00 +0000 (06:30 +0000)]
Merge "Add ApplyCustomFragmentPrefix" into devel/master

3 years ago[ATSPI] Check higlight area using PropertyNotification 42/260342/18
Shinwoo Kim [Wed, 23 Jun 2021 11:29:30 +0000 (20:29 +0900)]
[ATSPI] Check higlight area using PropertyNotification

Move highlight to next or prev if highlighted object goes out of screen.
This patch is using PropertyNotification only for highlighted object.

Change-Id: Idaea158fa9e9a1eb569ab619210d2aa916f28f22

3 years agoAdd Timer at TapGestureRecognizer 08/260808/8
Joogab Yun [Mon, 5 Jul 2021 03:05:23 +0000 (12:05 +0900)]
Add Timer at TapGestureRecognizer

Change-Id: Iea2b71b2eb9020cd71067554cdea621e86ae8f7b

3 years agoMerge "Users can implement focus movement by SetCustomAlgorithm." into devel/master
joogab yun [Mon, 19 Jul 2021 01:07:03 +0000 (01:07 +0000)]
Merge "Users can implement focus movement by SetCustomAlgorithm." into devel/master

3 years agoFix SVACE error in bidirectional-support.cpp 12/261412/1
Adeel Kazmi [Fri, 16 Jul 2021 11:05:29 +0000 (12:05 +0100)]
Fix SVACE error in bidirectional-support.cpp

Change-Id: I732e088e83a76642a4e4bce1bd3f54a04adcd992

3 years agoMerge "DALi Version 2.0.35" into devel/master
Adeel Kazmi [Fri, 16 Jul 2021 09:33:40 +0000 (09:33 +0000)]
Merge "DALi Version 2.0.35" into devel/master

3 years agoDALi Version 2.0.35 95/261395/1 dali_2.0.35
David Steele [Fri, 16 Jul 2021 09:29:09 +0000 (10:29 +0100)]
DALi Version 2.0.35

Change-Id: I16146a5047a3099ee0f57c5687f0e715112ba309

3 years agoUsers can implement focus movement by SetCustomAlgorithm. 22/261222/6
Joogab Yun [Tue, 13 Jul 2021 10:13:36 +0000 (19:13 +0900)]
Users can implement focus movement by SetCustomAlgorithm.

So User implemented focus movement by SetCustomAlgorithm(AutoFocusAlgorithm.Instance);

And if user do SetCustomAlgorithm(null), the user expects the focus not to move.

this is for backward-compatibility.

Add EnableDefaultAlgorithm() and IsDefaultAlgorithmEnabled() for enable/disable the default algorithm

Change-Id: I231508ace0f378edc268731e80ac7878af5cd650

3 years agoAdd ImageUrl Class and reference count for external texture 98/259398/34
Sunghyun Kim [Mon, 7 Jun 2021 07:42:25 +0000 (16:42 +0900)]
Add ImageUrl Class and reference count for external texture

1.Add ImageUrl Class
ImageUrl is a class for wrapping url that is get from external buffer
the purpose of this class is that manage this external buffer

2.Add reference count for external texturea

Change-Id: I3eb0bb3280d84035db9d981ae73807847e5b74bc

3 years agoMerge "(Vector) Fix tc random failure" into devel/master
Heeyong Song [Fri, 16 Jul 2021 00:49:16 +0000 (00:49 +0000)]
Merge "(Vector) Fix tc random failure" into devel/master

3 years agoMerge "Replace Signal with std::function." into devel/master
JIYUN YANG [Thu, 15 Jul 2021 09:45:26 +0000 (09:45 +0000)]
Merge "Replace Signal with std::function." into devel/master

3 years agoMerge "Fixed doxygen error in web-view.h" into devel/master
David Steele [Thu, 15 Jul 2021 09:37:32 +0000 (09:37 +0000)]
Merge "Fixed doxygen error in web-view.h" into devel/master

3 years ago(Vector) Fix tc random failure 25/261325/1
Heeyong Song [Thu, 15 Jul 2021 09:02:03 +0000 (18:02 +0900)]
(Vector) Fix tc random failure

Change-Id: I7a64a22da07ae9975f31db11c1ede41219a7654a

3 years agoMerge "Support Ellipsis Position Property" into devel/master
Bowon Ryu [Thu, 15 Jul 2021 06:51:59 +0000 (06:51 +0000)]
Merge "Support Ellipsis Position Property" into devel/master

3 years agoMerge "Add Tab key focus movement." into devel/master
joogab yun [Thu, 15 Jul 2021 04:37:11 +0000 (04:37 +0000)]
Merge "Add Tab key focus movement." into devel/master

3 years agoFixed doxygen error in web-view.h 36/261236/1
Adeel Kazmi [Tue, 13 Jul 2021 14:20:51 +0000 (15:20 +0100)]
Fixed doxygen error in web-view.h

Change-Id: I4aaf2b56485946c42376a7b1ca771c743c2ea2ba

3 years agoSupport Ellipsis Position Property 60/259560/33
Shrouq Sabah [Wed, 9 Jun 2021 21:39:31 +0000 (00:39 +0300)]
Support Ellipsis Position Property

Added new property Ellipsis to TextEditor
Added new property Ellipsis_Position to TextLabel, TextField and TextEditor

Example:
textLabel.SetProperty(DevelTextLabel::Property::ELLIPSIS_POSITION, DevelText::EllipsisPosition::START);

Handled Ellipsis location for below cases:
Positions: END, START and MIDDLE
TextController: TextLabel, TextField and TextEditor
SingleLine and Muilt-lines with differnat LineWrap modes
Text direction LTR and RTL

END algorithm already exits
START and MIDDLE algorithms added according to END one

Change-Id: If059878f7128141169e95cf237b690ce900c70b3

3 years agoChange default value of WebView::Property::VIDEO_HOLE_ENABLED to false 24/261224/2
Jiyun Yang [Tue, 13 Jul 2021 10:21:52 +0000 (19:21 +0900)]
Change default value of WebView::Property::VIDEO_HOLE_ENABLED to false

Change-Id: I5d3cd11ea1ce5a0b510b45a316c17aae16c0a82b
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoAdd Tab key focus movement. 56/261056/3
Joogab Yun [Fri, 9 Jul 2021 06:41:24 +0000 (15:41 +0900)]
Add Tab key focus movement.

If the focus group is not changed, Move the focus towards right, "Shift-Tap" key moves the focus towards left.
Still if the focus is not moved, Move the focus towards down, "Shift-Tap" key moves the focus towards up.

Change-Id: Iecfbe8a94ca96caff580714ef94ead7002e01e4b

3 years agoReplace Signal with std::function. 03/260903/5
huayong.xu [Tue, 6 Jul 2021 02:52:40 +0000 (10:52 +0800)]
Replace Signal with std::function.

Originally Signal is used to notify webview when callback of web
engine is called. If Signal is called with a std::shared_ptr<X>,
lifecyle of object X would be managed by Signal only in
csharp-binder. So if Signal are destroyed, object X would be
destroyed too. This might cause some problem.
This patch is to replace Signal with std::fuction, and replace
std:shared_ptr with unique_ptr. Lifecycle of object X would not
be associated with that of Signal.

Change-Id: I3878d3a4a9bacc64d94e3dd2b55479da85980e90

3 years agoMerge "Add WebView SetTtsFocus" into devel/master
JIYUN YANG [Mon, 12 Jul 2021 11:28:37 +0000 (11:28 +0000)]
Merge "Add WebView SetTtsFocus" into devel/master

3 years agoMerge "Add borderline features at transition effect" into devel/master
Eunki Hong [Mon, 12 Jul 2021 06:46:41 +0000 (06:46 +0000)]
Merge "Add borderline features at transition effect" into devel/master

3 years agoFix to do not remove entity inside loop.(Transition) 07/261107/2
seungho [Mon, 12 Jul 2021 05:16:58 +0000 (14:16 +0900)]
Fix to do not remove entity inside loop.(Transition)

 - Fix a problem caused by removing entity inside loop

Change-Id: Id12c66ec287c451451005c3c2d0d33b570d4c984
Signed-off-by: seungho <sbsh.baek@samsung.com>
3 years agoMerge "DALi Version 2.0.34" into devel/master
Adeel Kazmi [Fri, 9 Jul 2021 09:28:11 +0000 (09:28 +0000)]
Merge "DALi Version 2.0.34" into devel/master

3 years agoDALi Version 2.0.34 62/261062/1 dali_2.0.34
Adam Bialogonski [Fri, 9 Jul 2021 08:44:38 +0000 (09:44 +0100)]
DALi Version 2.0.34

Change-Id: I67bc21a7418d5e8cd708326fe74bbcc12ee16704

3 years agoMerge "Makes the LTR/RTL alignment of text follow the system language by default...
joogab yun [Fri, 9 Jul 2021 01:54:24 +0000 (01:54 +0000)]
Merge "Makes the LTR/RTL alignment of text follow the system language by default." into devel/master

3 years agoMerge "Reflection GetSamplers() returns const ref" into devel/master
David Steele [Thu, 8 Jul 2021 09:52:48 +0000 (09:52 +0000)]
Merge "Reflection GetSamplers() returns const ref" into devel/master

3 years agoMerge "Revert "Call SetCurrentFocusActor()"" into devel/master
joogab yun [Thu, 8 Jul 2021 09:25:39 +0000 (09:25 +0000)]
Merge "Revert "Call SetCurrentFocusActor()"" into devel/master

3 years agoRevert "Call SetCurrentFocusActor()" 14/261014/1
Joogab Yun [Thu, 8 Jul 2021 09:28:50 +0000 (18:28 +0900)]
Revert "Call SetCurrentFocusActor()"

Change-Id: I4a3e0a68ae3e93ead855ab21e1ee33067ae2e2c9

3 years agoMerge "Fix corrupted markup background" into devel/master
Bowon Ryu [Thu, 8 Jul 2021 07:25:25 +0000 (07:25 +0000)]
Merge "Fix corrupted markup background" into devel/master

3 years agoMerge "Call SetCurrentFocusActor()" into devel/master
joogab yun [Thu, 8 Jul 2021 06:35:29 +0000 (06:35 +0000)]
Merge "Call SetCurrentFocusActor()" into devel/master

3 years agoFix corrupted markup background 51/260851/12
abdullah [Mon, 5 Jul 2021 13:40:44 +0000 (16:40 +0300)]
Fix corrupted markup background

sometimes(random issue) when markup enabled for label,
the background color is corrupted with random incorrect color pixels.
because the background image was not initialized in some cases.

plus made some code more clear.

Change-Id: Iab93822addb9a790153df45a6f619ae93054ada6

3 years agoCall SetCurrentFocusActor() 36/260936/4
Joogab Yun [Wed, 7 Jul 2021 07:47:29 +0000 (16:47 +0900)]
Call SetCurrentFocusActor()

If the TextField/TextEditor has "Focusable = true",
the focus cannot be moved by the keyboard after tapping.

Fixed this bug.

Change-Id: I395d492bd048a758d25dae28ba3fffec4fae7317