sgjesse@chromium.org [Wed, 4 Aug 2010 09:30:55 +0000 (09:30 +0000)]
Prepare push to trunk. We are now working on 2.3.6.
Review URL: http://codereview.chromium.org/3078024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5171
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 2 Aug 2010 15:27:25 +0000 (15:27 +0000)]
VirtualAlloc on Windows 7 does not currently provide sufficient randomization to protect JIT code from being aligned in large regions at a predictable location.
This patch manually randomizes the allocation address for PAGE_EXECUTE_READWRITE regions between kAllocationRandomAddressMin and kAllocationRandomAddressMax.
BUG=none
TEST=allocate lots of javascript code and check for contiguous allocations
Patch by Paul Mehta <pmehta@chromium.org>
Review URL: http://codereview.chromium.org/2832095
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5169
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 2 Aug 2010 15:08:17 +0000 (15:08 +0000)]
Revert r5147 due to failing assert, with no simple solution. Issue 808.
Review URL: http://codereview.chromium.org/3087001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5167
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Mon, 2 Aug 2010 12:09:10 +0000 (12:09 +0000)]
Added support for ES5's propertyname production.
Object initialisers and dot-notation property access allows keywords in ES5.
Also allowed non-identifiers after "get" or "set" in an object initialiser.
Review URL: http://codereview.chromium.org/3047038
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5165
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 2 Aug 2010 11:02:38 +0000 (11:02 +0000)]
Prepare push to trunk. Now working on version 2.3.5.
Review URL: http://codereview.chromium.org/3040030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5163
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 2 Aug 2010 09:14:44 +0000 (09:14 +0000)]
Fix issue 806.
Ensure that we are not using r12 as a receiver in inlined NamedStore code.
Review URL: http://codereview.chromium.org/3081007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5162
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 30 Jul 2010 12:59:57 +0000 (12:59 +0000)]
Unicode: Reduced size of tables.
Review URL: http://codereview.chromium.org/3043032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5161
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Fri, 30 Jul 2010 11:58:43 +0000 (11:58 +0000)]
Roll over again fixed 3029033 Fix 'step in' after live edit stack manipulation
Review URL: http://codereview.chromium.org/3066018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5160
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 30 Jul 2010 07:10:22 +0000 (07:10 +0000)]
Updated unicode library.
Added Nl category to letters predicate (as requried for JS identifiers).
Changed/simplified representation of canonicalization ranges.
Truncated tables to code points in the BMP (all that is used by JS).
Reformatted tables to avoid excessively long lines.
Removed duplicate entries from multi-character mapping result tables.
Review URL: http://codereview.chromium.org/3030026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5155
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 29 Jul 2010 21:46:19 +0000 (21:46 +0000)]
Roll back all step-in-fix-related changes
Review URL: http://codereview.chromium.org/3012035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5154
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 29 Jul 2010 21:29:45 +0000 (21:29 +0000)]
Fix failing tests and rollback two from Testing change for failing unit test
Review URL: http://codereview.chromium.org/3052026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5153
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 29 Jul 2010 20:32:14 +0000 (20:32 +0000)]
Rollback one from Testing change for failing unit test
Review URL: http://codereview.chromium.org/2870083
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5152
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 29 Jul 2010 20:23:19 +0000 (20:23 +0000)]
Testing change for failing unit test
Review URL: http://codereview.chromium.org/3031032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5151
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 29 Jul 2010 16:40:14 +0000 (16:40 +0000)]
Fix 'step in' after live edit stack manipulation
Review URL: http://codereview.chromium.org/3029033
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5150
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 29 Jul 2010 08:31:36 +0000 (08:31 +0000)]
Fix XCode build.
Review URL: http://codereview.chromium.org/3056028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5149
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
podivilov@chromium.org [Wed, 28 Jul 2010 15:50:05 +0000 (15:50 +0000)]
Add debugger protocol request for setting global flags.
Review URL: http://codereview.chromium.org/2880011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5148
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Wed, 28 Jul 2010 15:08:32 +0000 (15:08 +0000)]
Cache maps for slow case objects.
Review URL: http://codereview.chromium.org/3032028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5147
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
podivilov@chromium.org [Wed, 28 Jul 2010 13:02:03 +0000 (13:02 +0000)]
Breakpoint position should be inside function body.
Review URL: http://codereview.chromium.org/2883042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5145
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 28 Jul 2010 12:50:27 +0000 (12:50 +0000)]
Fix error in optimized x.apply(y, arguments) code generation on ARM. Fixes issue 784. Adds regression test.
Review URL: http://codereview.chromium.org/3048035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5144
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Wed, 28 Jul 2010 12:35:46 +0000 (12:35 +0000)]
Use hashlib module instead of md5 if it is present.
md5 module is deprecated since Python 2.5 and we'd better off using hashlib instead.
Review URL: http://codereview.chromium.org/3026030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5143
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Wed, 28 Jul 2010 12:34:41 +0000 (12:34 +0000)]
Releasing allocated chunks in Pool's destructor.
That should make it not leak if v8 wasn't intialized at all.
Review URL: http://codereview.chromium.org/3048034
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5142
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Wed, 28 Jul 2010 09:36:53 +0000 (09:36 +0000)]
Port faster callbacks invocation to x64.
It's a port of http://code.google.com/p/v8/source/detail?r=3209 to x64 platform.
That allows invocation of callbacks without going into runtime.
Review URL: http://codereview.chromium.org/2801008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5141
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 27 Jul 2010 12:02:21 +0000 (12:02 +0000)]
X64: Fix order of operands on movq(reg, xmm).
Fixes bug 792, and the Transcendental cache is the only use of this operation.
Review URL: http://codereview.chromium.org/2806080
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5138
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 27 Jul 2010 09:20:21 +0000 (09:20 +0000)]
Fix some bugs in Function.prototype.bind implementation.
Correctly handle not passing thisArg.
Fixes to NewObjectFromBound to use correct argument count, not leak memory,
and handle constructors that throw exceptions.
Review URL: http://codereview.chromium.org/2878057
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5137
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 27 Jul 2010 06:18:32 +0000 (06:18 +0000)]
Remove global.print from v8natives.js (fixes issue 791)
Review URL: http://codereview.chromium.org/3045016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5135
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 26 Jul 2010 10:45:46 +0000 (10:45 +0000)]
Prepare push to trunk. Now working on version 2.3.4.
Review URL: http://codereview.chromium.org/3058009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5132
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Fri, 23 Jul 2010 17:21:55 +0000 (17:21 +0000)]
Fix break position not to be outside of the script
Review URL: http://codereview.chromium.org/3017021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5131
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 23 Jul 2010 11:55:03 +0000 (11:55 +0000)]
Fix aliasing problem in inlined stores on x64 and ia32. The receiver
and the value can share a register. We need to remove this aliasing
before modifying the registers.
I haven't managed to generate a stand-alon test case for this
yet. I'll do that as a separate change. This was found while loading
Wave.
Review URL: http://codereview.chromium.org/3039025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5127
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 23 Jul 2010 11:20:59 +0000 (11:20 +0000)]
Fix bug in r5123, Comparison(), by unusing results before unconditional jump to smi comparison JumpTarget.
Review URL: http://codereview.chromium.org/3026019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5126
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Fri, 23 Jul 2010 10:15:21 +0000 (10:15 +0000)]
Fix presubmit errors.
Review URL: http://codereview.chromium.org/3009017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5125
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Fri, 23 Jul 2010 10:08:55 +0000 (10:08 +0000)]
Implement Function.prototype.bind (ES5 15.3.4.5).
Please note that we do not implement correctly the setting of caller
and arguments on the returned objects, since we already have these
properties on function objects (and they are non-configurable).
Also corrects indention in DefineOwnProperty.
Review URL: http://codereview.chromium.org/3046010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5124
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 23 Jul 2010 09:05:46 +0000 (09:05 +0000)]
Use static type information when creating the inlined code for comparison operators.
Review URL: http://codereview.chromium.org/3017025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5123
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 23 Jul 2010 08:47:15 +0000 (08:47 +0000)]
Fixed a couple of issues with store inlining on arm.
Spill and merge virtual frames explicitly in the deferred code.
Account for the fact that the inlined write barrier size depends on
the size of the new space masks.
Review URL: http://codereview.chromium.org/3018015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5122
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 23 Jul 2010 08:25:48 +0000 (08:25 +0000)]
Change asserts to STATIC_ASSERT if they can be checked at compilation time. Just in the codegen-xxx.cc files on all platforms.
Review URL: http://codereview.chromium.org/3017018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5121
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Thu, 22 Jul 2010 13:39:18 +0000 (13:39 +0000)]
Properly propagate failures from helper methods.
Otherwise failures are not reported and callback may fail to setup.
Review URL: http://codereview.chromium.org/3035017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5120
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 22 Jul 2010 12:57:48 +0000 (12:57 +0000)]
Add ARM_LINK_FLAGS when build d8 with arch=arm to make
cross-compiling d8 easier.
Review URL: http://codereview.chromium.org/3062002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5119
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Thu, 22 Jul 2010 12:55:14 +0000 (12:55 +0000)]
Fix d8 build error on a fresh checkout.
Review URL: http://codereview.chromium.org/2809069
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5118
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 22 Jul 2010 09:01:00 +0000 (09:01 +0000)]
Fix Win64 build.
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/3017024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5117
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 22 Jul 2010 08:17:40 +0000 (08:17 +0000)]
Port inlined in-object property stores to ARM.
Review URL: http://codereview.chromium.org/2878043
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5116
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 22 Jul 2010 06:31:49 +0000 (06:31 +0000)]
Port inline in-object property stores from ia32 to x64.
Review URL: http://codereview.chromium.org/3008017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5115
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Thu, 22 Jul 2010 06:28:47 +0000 (06:28 +0000)]
Support object literal map caching for literals with keys that are array indices.
The caching code used to require that all keys in the literal were symbol strings
in order to be able to cache object literal maps.
Relaxed this requirement to allow array indices as well (as in { "1": "one", two: "two" }).
Changed the way 'number_of_properties' is calculated so that redundant property slots are not
allocated for array indices.
Review URL: http://codereview.chromium.org/2858064
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5114
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 21 Jul 2010 15:16:01 +0000 (15:16 +0000)]
Remove VirtualFrame::CallStoreIC(void) and CallCommonStoreIC from virtual-frame-x64.cc. Make implementations of CallStoreIC(key, is_contextual) and CallKeyedStoreIC() the same on x64 and ia32. Make ia32 and x64 implementations more alike by moving some functions and changing comments.
Review URL: http://codereview.chromium.org/3060002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5113
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 21 Jul 2010 11:52:57 +0000 (11:52 +0000)]
Add EmitKeyedStore and EmitKeyedPropertyAssignment to x64. Removal of Reference class from VisitAssignment complete on all platforms.
Review URL: http://codereview.chromium.org/3028015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5112
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 21 Jul 2010 10:53:38 +0000 (10:53 +0000)]
Prepare push to trunk. Now working on version 2.3.3.
Review URL: http://codereview.chromium.org/3053006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5109
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 21 Jul 2010 10:31:52 +0000 (10:31 +0000)]
Add EmitNamedStore and CallStoreIC(name, is_contextual) to x64 platform.
Review URL: http://codereview.chromium.org/3050008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5108
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 21 Jul 2010 08:50:57 +0000 (08:50 +0000)]
Add EmitSlotAssignment to x64 platform.
Review URL: http://codereview.chromium.org/2878042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5107
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 21 Jul 2010 07:42:51 +0000 (07:42 +0000)]
Landing for Rodolph Perfetta.
Add support for saturation instruction (ARMv6 or above).
The byte array clamping code has been updated accordingly.
Review URL: http://codereview.chromium.org/3036008/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5106
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 21 Jul 2010 06:59:34 +0000 (06:59 +0000)]
Inline in-object property stores on ia32 when in loop and not in top-level code.
Review URL: http://codereview.chromium.org/3046006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5105
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 20 Jul 2010 12:41:43 +0000 (12:41 +0000)]
Stop pushing arguments onto the stack in CompareStub until just before calling runtime.
This is a fixed version of change 5097, which had the problem that LoadFloatOperands tried to load the arguments from the stack.
Review URL: http://codereview.chromium.org/3040010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5103
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 20 Jul 2010 10:59:00 +0000 (10:59 +0000)]
Output time spent in code flushing in GC NVP trace.
Add support for flushcode scope and cumulative stats into gc-nvp-trace-processor.
Review URL: http://codereview.chromium.org/3054003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5102
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 20 Jul 2010 07:14:19 +0000 (07:14 +0000)]
Update inheritance hierarchy in Objects.h to better reflect the actual hierarchy.
We do not have a GlobalContext class.
We do, however, have a SerializedScopeInfo class that inherits FixedArray.
Starting comment is also slightly misleading, since not all objects in the hierarchy is described in objects.h (e.g., Context is described in contexts.h).
Review URL: http://codereview.chromium.org/2811057
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5101
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 20 Jul 2010 06:23:36 +0000 (06:23 +0000)]
Update Code::NUMBER_OF_KINDS to include binary op ICs.
Review URL: http://codereview.chromium.org/3027013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5100
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 20 Jul 2010 05:51:10 +0000 (05:51 +0000)]
Land for Victor Wang.
Add direct_dependent_settings for v8 dll so targets that depend on v8
has USING_V8_SHARED defined.
Review URL: http://codereview.chromium.org/2946014/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5099
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 19 Jul 2010 14:26:51 +0000 (14:26 +0000)]
Revert 5097 on ia32 platform until problem is diagnosed.
Review URL: http://codereview.chromium.org/3018009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5098
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 19 Jul 2010 13:35:41 +0000 (13:35 +0000)]
Delay the pushing of arguments until just before calling runtime in CompareStub.
This will allow jumps to runtime that skip useless tests.
Review URL: http://codereview.chromium.org/3016004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5097
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 19 Jul 2010 13:26:25 +0000 (13:26 +0000)]
Add a check that weak object handle is not in NEAR_DEATH state after weak callback invocation.
If object enters NEAR_DEATH state, it must be explicitly cleared and/or disposed, otherwise
it would retain JS object forever. Note as well that parameter is reset to NULL on first
invocation so weak handle callback would be in hard situation.
Review URL: http://codereview.chromium.org/3011009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5096
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 19 Jul 2010 12:45:21 +0000 (12:45 +0000)]
Fix issue 785. For-in now works on strings: for (var i in "asdf") now works
all the time, not just the first time it is run.
Review URL: http://codereview.chromium.org/3037008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5095
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 19 Jul 2010 10:02:11 +0000 (10:02 +0000)]
Landing for pmehta.
Changed a static cast from static_cast<int> to static_cast<size_t>
that previously introduced a signed/unsigned comparison issue in the
main allocator for V8 (MemoryAllocator::AllocateRawMemory) that could
be used to bypass the V8 allocation limitations or trigger integer
overflows.
Review URL: http://codereview.chromium.org/3027006/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5094
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 19 Jul 2010 09:51:33 +0000 (09:51 +0000)]
Landing for hans@chromium.org.
TYPE_CHECK in v8.h should assign to volatile qualified null-pointer.
Unless the pointer is volatile qualified, Clang will warn that LLVM
removes the assignment during optimization. This is not a problem as
that code should never execute, but the warning is treated as an error
when building Chromium, and thus stops the build.
Code review URL: http://codereview.chromium.org/3005010/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5093
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 19 Jul 2010 07:33:05 +0000 (07:33 +0000)]
Prepare push to trunk. Now working on version 2.3.2.
Review URL: http://codereview.chromium.org/2811055
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5090
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 19 Jul 2010 06:29:30 +0000 (06:29 +0000)]
Reorder SharedFunctionInfo setup in lazy compile, quick fix for crbug.com/49099
This fixes issue 49099 (http://crbug.com/49099) that makes chromium
crash if a gc is triggered by setting the scopeinfo in CompileLazy. If
this gc triggers code flushing the compiled function could be flushed,
causing the ASSERT(shared->is_compiled()) to fail. By reordering the
two methods we make sure that no allocation happens before the end of
the method.
Review URL: http://codereview.chromium.org/3035006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5089
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Fri, 16 Jul 2010 11:21:08 +0000 (11:21 +0000)]
Refactor type checks in v8natives.js and runtime.js.
This includes adding a new inline IsSpecObject method to the code
generator. The old approach was somehow ineffecient since we would
call both IsObject, IsUndetectable and IsFunction to determine if
something was an object according to the spec. This change introduces
a new macro that determines if something is an object according to the
spec (and this does not include null).
This change also corrects a few places where undetectable objects was
not allowed even when they should be (priorly they would use only
IS_SPEC_OBJECT_OR_NULL, which would return false on an undetectable
object, the new IS_SPEC_OBJECT returns true on an undetectable object.
Review URL: http://codereview.chromium.org/2877018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5087
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Fri, 16 Jul 2010 10:07:57 +0000 (10:07 +0000)]
StringDictionary::FindEntry optimized for symbol strings.
Review URL: http://codereview.chromium.org/3020003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5086
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 16 Jul 2010 08:20:39 +0000 (08:20 +0000)]
Fix compilation errors on X64. Error from r5080 is constructor Operand(register) with too few arguments, while constructing a dummy return value in unreachable code to avoid compiler errors. Also added explicit cast from intptr_t to int in profile-generator.cc to avoid compiler warnings, introduced in r5078.
Review URL: http://codereview.chromium.org/3030002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5084
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 15 Jul 2010 15:41:05 +0000 (15:41 +0000)]
Fix TestHeapEntryIdsAndGC test. The assert was wrong.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/2861051
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5082
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 15 Jul 2010 15:01:42 +0000 (15:01 +0000)]
Fix presubmit errors in test-heap-profiler.cc
I tried adding CheckNonEqualsHelper for int64_t, but this causes
another avalanche of function resolving ambuguities. So, I ended
up fooling linter.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/3024001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5081
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 15 Jul 2010 14:31:49 +0000 (14:31 +0000)]
Remove unnecessary formatting differences between ia32 and x64 code generators. Mainly just typographical changes.
Review URL: http://codereview.chromium.org/3023001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5080
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 15 Jul 2010 14:28:52 +0000 (14:28 +0000)]
Fix compile errors on Linux x64 and Windows.
Will fix test-heap-profiler in the next change.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/2877019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5079
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 15 Jul 2010 13:21:50 +0000 (13:21 +0000)]
Heap profiler: implement diffing of snapshots.
To trace objects between snapshots, an external map of object tags is
maintained. After the first heap snapshot has been taken, the map is
updated by reporting object moves from the GC. If no snapshots were
taken, there is no overhead (except for flag checking).
I considered graph comparison algorithms that doesn't require using
object tags, but they are all of a high computational complexity, and
will still fail to detect object moves properly, even for trivial
cases, so using tags looks like unavoidable.
Review URL: http://codereview.chromium.org/3020002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5078
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 15 Jul 2010 10:34:08 +0000 (10:34 +0000)]
Avoid a smi check when comparing an unknown to a constant smi for equality on ia32 and x64 platforms.
Review URL: http://codereview.chromium.org/2897013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5077
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 15 Jul 2010 10:31:30 +0000 (10:31 +0000)]
Fix compilation and linking with V8_INTERPRETED_REGEXP flag.
Review URL: http://codereview.chromium.org/2836051
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5076
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 15 Jul 2010 08:50:01 +0000 (08:50 +0000)]
Prepare push to trunk. Now working on version 2.3.1.
Review URL: http://codereview.chromium.org/2805081
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5073
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Thu, 15 Jul 2010 07:51:14 +0000 (07:51 +0000)]
Implement ES5 Object.seal and Object.isSealed.
This change adds the ES5 Object.seal 15.2.3.8 and Object.isSealed 15.2.3.11 methods.
Review URL: http://codereview.chromium.org/2993006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5072
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Thu, 15 Jul 2010 06:17:45 +0000 (06:17 +0000)]
Fix GenerateNegativeLookup to work with non-symbols as a dictionary key.
Review URL: http://codereview.chromium.org/2928009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5071
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 14 Jul 2010 13:22:47 +0000 (13:22 +0000)]
Fix error in x64 fast smi loops, change 4998.
Review URL: http://codereview.chromium.org/2925012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5069
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 14 Jul 2010 13:15:43 +0000 (13:15 +0000)]
Fix bug in Object.isFrozen which always classifies non-extensible objects as frozen.
Since out internal representation of a property descriptor does not have configurable and writable
attributes Object.isFrozen returns true whenever an object is not extensible.
This change makes use of the right method calls on our internal representation (isWritable() and
isConfigurable()). Tests added directly to the mjsunit test.
Review URL: http://codereview.chromium.org/2904015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5068
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Wed, 14 Jul 2010 11:18:09 +0000 (11:18 +0000)]
Create a separate class to encapsulate ScopeInfo serialization.
The static ScopeInfo members moved into this class.
The new class is named ScopeInfoObject which I am not proud of,
better ideas are very welcome.
Also got rid of the sentinels in the serialized scope info which saves 3 words per function
and is not slower.
Review URL: http://codereview.chromium.org/2908009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5067
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 14 Jul 2010 09:45:08 +0000 (09:45 +0000)]
Remove check for heap allocated locals from code flushing.
Since bleeding edge revision 5056 we no longer need to check that
there are no heap allocated locals in the scope info, since these will
be preserved after the scope info was moved to the SharedFunctionInfo
class.
Review URL: http://codereview.chromium.org/2931016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5066
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Wed, 14 Jul 2010 08:23:35 +0000 (08:23 +0000)]
Debugger: introduce parametrized debug break, the parameter is passed
back to EventListener to be able to dynamically specify behavior
on asynchronously enforced VM breakouts.
Review URL: http://codereview.chromium.org/2962007/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5063
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 13 Jul 2010 20:54:06 +0000 (20:54 +0000)]
Landing for Rodolph Perfetta.
Allow compareStub on ARM to take register in reverse order optionally.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2850046/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5059
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 13 Jul 2010 20:24:16 +0000 (20:24 +0000)]
Prepare push to trunk. Now working on version 2.3.0.
Review URL: http://codereview.chromium.org/2981005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5058
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Tue, 13 Jul 2010 13:06:33 +0000 (13:06 +0000)]
Move serialized scope info from Code object to SharedFunctionInfo.
The scope info is now stored in a FixedArray referenced from SharedFunctionInfo.
Review URL: http://codereview.chromium.org/2918001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5056
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 13 Jul 2010 12:58:02 +0000 (12:58 +0000)]
Add ES5 Object.freeze and Object.isFrozen methods.
This change adds ES5 15.2.3.9 Object.freeze and
15.2.3.12 Object.isFrozen
Review URL: http://codereview.chromium.org/2944016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5055
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 13 Jul 2010 11:38:30 +0000 (11:38 +0000)]
Fix presubmit.
Review URL: http://codereview.chromium.org/2974008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5053
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 13 Jul 2010 11:31:47 +0000 (11:31 +0000)]
Fix memory leaks in test-api.cc to make valgrind happy.
The memory leaks are all from the tests, not actually in V8.
I will put a nightly valgrind run on the fuzzer.
Review URL: http://codereview.chromium.org/2944015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5052
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 13 Jul 2010 10:57:45 +0000 (10:57 +0000)]
Fix JSON.parse typo which causes the input not to be string converted.
Review URL: http://codereview.chromium.org/2981004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5051
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 13 Jul 2010 10:29:31 +0000 (10:29 +0000)]
Fix preparsing from a source string that is not external.
This fixes issue 775.
Review URL: http://codereview.chromium.org/2959007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5050
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Tue, 13 Jul 2010 10:02:11 +0000 (10:02 +0000)]
Simplifying GenerateDictionaryNegativeLookup by making the 'extra' parameter mandatory.
Review URL: http://codereview.chromium.org/2982001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5049
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 13 Jul 2010 08:55:06 +0000 (08:55 +0000)]
Fix compilation error on 64-bit MacOS V8 compilation. ASSERT_EQ macro needs unambiguous similar integer types as arguments.
Review URL: http://codereview.chromium.org/2982005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5048
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 13 Jul 2010 08:05:10 +0000 (08:05 +0000)]
Virtually dispatched scavengers
Use virtually dispatched specialized scavengers instead of single generic ScavengeObjectSlow implementation.
Rollback of r5041 with assertion checking callback alignment removed. Map space is iterated in a special fashion during scavenges so special callback alignment is not required.
Review URL: http://codereview.chromium.org/2950003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5047
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 12 Jul 2010 16:57:07 +0000 (16:57 +0000)]
Revert revisions 5041 and 5042 introducing virtual scavenge
behavior. It breaks debug builds with snapshots on my machine.
TBR=vegorov@chromium.org
Review URL: http://codereview.chromium.org/2983001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5046
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 12 Jul 2010 15:29:25 +0000 (15:29 +0000)]
Remove the special error message for overflows when using
Function.prototype.apply. This avoids having more than one error
message for stack overflow situations which makes testing a pain.
Review URL: http://codereview.chromium.org/2967003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5045
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Mon, 12 Jul 2010 13:23:42 +0000 (13:23 +0000)]
Port prototype-call-stubs for normal objects (codereview.chromium.org/2801018).
Review URL: http://codereview.chromium.org/2860049
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5044
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Mon, 12 Jul 2010 13:17:27 +0000 (13:17 +0000)]
Allow to capture stack trace for uncaught exceptions
Review URL: http://codereview.chromium.org/2961003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5043
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 12 Jul 2010 13:11:42 +0000 (13:11 +0000)]
Fix Win64 build problem introduced by r5041.
Review URL: http://codereview.chromium.org/2893009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5042
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 12 Jul 2010 12:47:09 +0000 (12:47 +0000)]
Use virtually dispatched specialized scavengers instead of single generic ScavengeObjectSlow implementation.
Review URL: http://codereview.chromium.org/2895008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5041
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 9 Jul 2010 13:20:12 +0000 (13:20 +0000)]
Code cleanup: reorder functions in codegen-x64.cc to agree with the order in codegen-ia32.cc. If svn blame shows this change, run svn blame on the previous version of the file to find the actual author of the lines.
Review URL: http://codereview.chromium.org/2955004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5040
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 8 Jul 2010 13:50:13 +0000 (13:50 +0000)]
Second half of number alloc change accidentally omitted from
last change.
Review URL: http://codereview.chromium.org/2919001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5039
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 8 Jul 2010 13:16:51 +0000 (13:16 +0000)]
Add number allocation call to runtime.cc instead of misusing
UnaryMinus.
Review URL: http://codereview.chromium.org/2899004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5038
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 8 Jul 2010 12:38:02 +0000 (12:38 +0000)]
ARM: Add support for the VFP mov literal instruction and mov
between single VFP registers. Math.pow implementation has
been updated with the new instructions. This is a commit
of http://codereview.chromium.org/2813046/show for Rodolph
Perfetta.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5037
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00