Pavel Labath [Thu, 30 Dec 2021 14:02:23 +0000 (15:02 +0100)]
[lldb/qemu] More flexible emulator specification
This small patch adds two useful improvements:
- allows one to specify the emulator path as a bare filename, and have
it be looked up in the PATH
- allows one to leave the path empty and have the filename be derived
from the architecture.
Nuno Lopes [Thu, 30 Dec 2021 12:33:27 +0000 (12:33 +0000)]
[NFC] Pre-commit test for InstSimplify phi(poison)
Sjoerd Meijer [Thu, 30 Dec 2021 11:17:22 +0000 (11:17 +0000)]
[LoopFlatten] Move it to a LoopPassManager
In D109958 it was noticed that we could optimise the pipeline and avoid
rerunning LoopSimplify/LCSSA for LoopFlatten by moving it to a LoopPassManager.
Differential Revision: https://reviews.llvm.org/D110057
Nuno Lopes [Thu, 30 Dec 2021 12:08:07 +0000 (12:08 +0000)]
[NewGVN][NFC] Add test for x + poison -> poison
Nuno Lopes [Thu, 30 Dec 2021 11:44:51 +0000 (11:44 +0000)]
[InstSimplify] add 'x + poison -> poison' (needed for NewGVN)
Pavel Labath [Thu, 30 Dec 2021 10:22:26 +0000 (11:22 +0100)]
[lldb] Remove lldbtest.getBuildFlags
It was being used only in some very old tests (which pass even without
it) and its implementation is highly questionable.
These days we have different mechanisms for requesting a build with a
particular kind of c++ library (USE_LIB(STD)CPP in the makefile).
Roman Lebedev [Thu, 30 Dec 2021 10:42:11 +0000 (13:42 +0300)]
[Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization
The bitcode reader expected that the pointers are typed,
so that it can extract the function type for the assembly
so `bitc::CST_CODE_INLINEASM` did not explicitly store said function type.
I'm not really sure how the upgrade path will look for existing bitcode,
but i think we can easily support opaque pointers going forward,
by simply storing the function type.
Reviewed By: #opaque-pointers, nikic
Differential Revision: https://reviews.llvm.org/D116341
Roman Lebedev [Thu, 30 Dec 2021 10:39:39 +0000 (13:39 +0300)]
[BitcodeReader] `bitc::CST_CODE_INLINEASM`: un-hardcode offsets
jacquesguan [Mon, 27 Dec 2021 13:13:24 +0000 (21:13 +0800)]
[RISCV] Teach VSETVLInsert to eliminate redundant vsetvli for vmv.s.x and vfmv.s.f.
Differential Revision: https://reviews.llvm.org/D116307
Sjoerd Meijer [Thu, 30 Dec 2021 09:13:04 +0000 (09:13 +0000)]
Revert "[AArch64] Add a tablegen pattern for UZP2."
This reverts commit
ada028c32f47ca84a0b7be5d1ab4e3c943f859a3.
A performance regression was reported that we need to investigate:
https://github.com/llvm/llvm-project/issues/52919
Fangrui Song [Thu, 30 Dec 2021 09:12:55 +0000 (01:12 -0800)]
[IROutliner] Move global namespace cl::opt inside llvm::
jacquesguan [Mon, 27 Dec 2021 13:03:45 +0000 (21:03 +0800)]
[RISCV] Pre-commit test for Teach VSETVLInsert to eliminate redundant vsetvli for vmv.s.x and vfmv.s.f.
Differential Revision: https://reviews.llvm.org/D116306
Fangrui Song [Thu, 30 Dec 2021 08:30:47 +0000 (00:30 -0800)]
[MC][test] Improve section_names.s
Add missing coverage like .tdata/.data1/.rodata1
Fangrui Song [Thu, 30 Dec 2021 08:16:03 +0000 (00:16 -0800)]
[ELFAsmParser] Optimize hasPrefix with StringRef::consume_front
Serge Pavlov [Wed, 29 Dec 2021 04:40:03 +0000 (11:40 +0700)]
[ConstantFolding] Use ICmpInst::Predicate instead of plain integer
The function `ConstantFoldCompareInstruction` uses `unsigned short` to
represent compare predicate, although all usesrs of the respective
include file use definition of CmpInst also. This change replaces
predicate argument type in this function to `ICmpInst::Predicate`,
which allows to make code a bit clearer and simpler.
No functional changes.
Differential Revision: https://reviews.llvm.org/D116379
John Ericson [Thu, 30 Dec 2021 07:00:50 +0000 (07:00 +0000)]
[cmake] Tweak warning in `extend_path` helper function
There was one more reference the word "install" I forgot to remove.
Follow-up to
bde561c4813952847112600e5efe72d9015556f7 /
https://reviews.llvm.org/D115746
John Ericson [Tue, 14 Dec 2021 19:52:02 +0000 (14:52 -0500)]
[compiler-rt][cmake] Factor out extend_install_path function
It is likely to become used again, if other projects want their own per-project
install directory variables. `install` is removed from the name since it is not inherently about installing.
Reviewed By: stephenneuendorffer
Differential Revision: https://reviews.llvm.org/D115746
Shilei Tian [Thu, 30 Dec 2021 04:22:37 +0000 (23:22 -0500)]
[OpenMP] Add missing `tt_hidden_helper_task_encountered` along with `tt_found_proxy_tasks`
In most cases, hidden helper task behave similar as detached tasks. That means,
for example, if we have to wait for detached tasks, we have to do the same thing
for hidden helper tasks as well. This patch adds the missing condition for hidden
helper task accordingly along with detached task.
Reviewed By: AndreyChurbanov
Differential Revision: https://reviews.llvm.org/D107316
jacquesguan [Wed, 29 Dec 2021 07:29:40 +0000 (15:29 +0800)]
[RISCV] Use vmv.s.x instead of vfmv.s.f when the floating point scalar is 0.
Use integer vector scalar move instruction when move 0 to avoid add a integer-float move instruction.
Differential Revision: https://reviews.llvm.org/D116365
Qiu Chaofan [Thu, 30 Dec 2021 02:13:41 +0000 (10:13 +0800)]
[NFC] Specify targets for clang stack-protector-guard.c
The run line of stack-protector-guard.c doesn't specify the triple,
which means it depends on the platform running the test. This makes
some failure hidden.
Reviewed By: nickdesaulniers
Differential Revision: https://reviews.llvm.org/D116003
Chenbing.Zheng [Thu, 30 Dec 2021 01:31:01 +0000 (09:31 +0800)]
[RISCV] Refactor immediate comparison instructions patterns
The patterns of the immediate comparison instruction is rewrite here, and put similar code to a class.
Do not change any function of the original code, making the code more concise.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D116215
David Blaikie [Thu, 30 Dec 2021 00:45:00 +0000 (16:45 -0800)]
Couple of post-commit tweaks on
4d58d1d5af31 based on maskray's feedback
Mehdi Amini [Wed, 29 Dec 2021 23:08:37 +0000 (23:08 +0000)]
Fix build of llvm-prettyprinters/gdb/mlir-support.cpp test
This is just fixing the build itself, the test won't pass right now.
David Blaikie [Wed, 29 Dec 2021 22:47:43 +0000 (14:47 -0800)]
DWARFVerifier: fix remaining tests and compact/rephrase the output
David Blaikie [Wed, 29 Dec 2021 22:04:38 +0000 (14:04 -0800)]
DWARFDie: don't try to compute a full template name for a template parameter packs
Otherwise these look a lot like actual templates (they have a name and
they have template parameters) but they don't participate in naming
(this doesn't come up in practice because a template parameter pack DIE
is never referenced from another DIE (so we don't do full name
rebuilding for it) or the subject of simplified template name rebuilding
(never has the _STN prefix)) - it could be tested with some hand crafted
DWARF but doesn't seem important/useful to do so.
This change is just for performance - to avoid trying to parse more
DIEs, etc, when it's not needed when computing the name in the DWARF
verifier.
David Blaikie [Wed, 29 Dec 2021 22:00:40 +0000 (14:00 -0800)]
DWARFVerifier: Print the CU name and CU count to help visualize progress
Arthur O'Dwyer [Wed, 29 Dec 2021 19:17:26 +0000 (14:17 -0500)]
[libc++] [NFC] Remove an unused parameter from `__sift_down`.
Differential Revision: https://reviews.llvm.org/D116382
David Blaikie [Wed, 29 Dec 2021 21:11:16 +0000 (13:11 -0800)]
DWARFVerifier: Delay loading nested types in type dumping to improve performance
Avoid trying to resolve nested types that may not be needed because the name is
already provided by the outer DIE.
Sanjay Patel [Wed, 29 Dec 2021 20:53:56 +0000 (15:53 -0500)]
[InstCombine] add more folds for unsigned overflow checks
((Op1 + C) & C) u< Op1 --> Op1 != 0
((Op1 + C) & C) u>= Op1 --> Op1 == 0
Op0 u> ((Op0 + C) & C) --> Op0 != 0
Op0 u<= ((Op0 + C) & C) --> Op0 == 0
https://alive2.llvm.org/ce/z/iUfXJN
https://alive2.llvm.org/ce/z/caAtjj
define i1 @src(i8 %x, i8 %y) {
; the add/mask must be with a low-bit mask (0x01ff...)
%y1 = add i8 %y, 1
%pop = call i8 @llvm.ctpop.i8(i8 %y1)
%ismask = icmp eq i8 %pop, 1
call void @llvm.assume(i1 %ismask)
%a = add i8 %x, %y
%m = and i8 %a, %y
%r = icmp ult i8 %m, %x
ret i1 %r
}
define i1 @tgt(i8 %x, i8 %y) {
%r = icmp ne i8 %x, 0
ret i1 %r
}
I suspect this can be generalized in some way, but this
is the pattern I'm seeing in a motivating test based on
issue #52851.
Sanjay Patel [Wed, 29 Dec 2021 20:16:11 +0000 (15:16 -0500)]
[InstCombine] add tests for unsigned overflow of bitmask offset; NFC
Sanjay Patel [Tue, 28 Dec 2021 21:59:53 +0000 (16:59 -0500)]
[InstCombine] add tests for lshr(add(shl())); NFC
MaheshRavishankar [Wed, 29 Dec 2021 18:48:02 +0000 (10:48 -0800)]
[mlir][MemRef] Deprecate unspecified trailing offset, size, and strides semantics of `OffsetSizeAndStrideOpInterface`.
The semantics of the ops that implement the
`OffsetSizeAndStrideOpInterface` is that if the number of offsets,
sizes or strides are less than the rank of the source, then some
default values are filled along the trailing dimensions (0 for offset,
source dimension of sizes, and 1 for strides). This is confusing,
especially with rank-reducing semantics. Immediate issue here is that
the methods of `OffsetSizeAndStridesOpInterface` assumes that the
number of values is same as the source rank. This cause out-of-bounds
errors.
So simplifying the specification of `OffsetSizeAndStridesOpInterface`
to make it invalid to specify number of offsets/sizes/strides not
equal to the source rank.
Differential Revision: https://reviews.llvm.org/D115677
Krzysztof Parzyszek [Wed, 29 Dec 2021 19:00:01 +0000 (11:00 -0800)]
[Hexagon] Don't build two halves of HVX vector in parallel
There can only be one permute operations per packet, so this actually
pessimizes the code (due to the extra "or").
Joshua Herrera [Wed, 29 Dec 2021 18:18:21 +0000 (10:18 -0800)]
[Hexagon] Improve BUILD_VECTOR codegen
For vectors with repeating values, old codegen would rotate and insert
every duplicate element. This patch replaces that behavior with a splat
of the most common element, vinsert/vror only occur when needed.
William S. Moses [Wed, 29 Dec 2021 08:08:01 +0000 (03:08 -0500)]
[MLIR][LLVM] Expose powi intrinsic to MLIR
Expose the powi intrinsic to the LLVM dialect within MLIR
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116364
Florian Hahn [Wed, 29 Dec 2021 18:00:41 +0000 (19:00 +0100)]
[LV] Replace redundant tail-fold check with assert (NFC).
The code path can only be reached when folding the tail, so turn the
check into an assertion.
Craig Topper [Wed, 29 Dec 2021 17:14:32 +0000 (09:14 -0800)]
[RISCV] Add a few more instructions to hasAllNBitUsers.
Krzysztof Parzyszek [Wed, 29 Dec 2021 16:46:26 +0000 (08:46 -0800)]
[Hexagon] Calling conventions for floating point vectors
They are the same as for the other HVX vectors, but types need to be
listed explicitly. Also, add a detailed codegen testcase.
Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
Kazu Hirata [Wed, 29 Dec 2021 16:55:37 +0000 (08:55 -0800)]
[Basic] Drop unnecessary const from return types (NFC)
Identified with readability-const-return-type.
Kazu Hirata [Wed, 29 Dec 2021 16:34:20 +0000 (08:34 -0800)]
[clang] Use nullptr instead of 0 or NULL (NFC)
Identified with modernize-use-nullptr.
Kazu Hirata [Wed, 29 Dec 2021 16:27:29 +0000 (08:27 -0800)]
[clang] Remove unused "using" (NFC)
Nuno Lopes [Wed, 29 Dec 2021 15:48:30 +0000 (15:48 +0000)]
[NewGVN] Use poison instead of undef to represent unreachable values
This enables more simplifications and gets us closer to removing undef.
ping @alinas
Krzysztof Parzyszek [Wed, 29 Dec 2021 14:52:24 +0000 (06:52 -0800)]
[Hexagon] Handle floating point splats
Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
Krzysztof Parzyszek [Wed, 29 Dec 2021 13:45:43 +0000 (05:45 -0800)]
[Hexagon] Handle floating point vector loads/stores
Nuno Lopes [Wed, 29 Dec 2021 12:38:14 +0000 (12:38 +0000)]
[NewGVN] Prefer poison to undef when ranking operands
ping @alinas
Mariya Podchishchaeva [Wed, 29 Dec 2021 10:46:15 +0000 (13:46 +0300)]
[SYCL] Diagnose uses of zero length arrays
Adds diagnosing on attempt to use zero length arrays, pointers, refs, arrays
of them and structs/classes containing all of it.
In case a struct/class with zero length array is used this emits a set
of notes pointing out how zero length array got into used struct, like
this:
```
struct ContainsArr {
int A[0]; // note: field of illegal type declared here
};
struct Wrapper {
ContainsArr F; // note: within field of type ContainsArr declared here
// ...
}
// Device code
Wrapper W;
W.use(); // error: zero-length arrays are not permitted
```
Total deep check of each used declaration may result in double
diagnosing at the same location.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D114080
Sam McCall [Wed, 29 Dec 2021 12:18:11 +0000 (13:18 +0100)]
Fix lit feature name in
9dc4af327b12d
Sam McCall [Wed, 29 Dec 2021 11:07:42 +0000 (12:07 +0100)]
Re-land "[clang] Add early exit when checking for const init of arrays."
This reverts commit
6d09aaecdfe51e13fc64d539aa7c9a790de341d7.
The test uses ulimit and ran into problems on some bots. Run on linux only.
There's nothing platform-specific about the code we're testing, so this
should be enough to ensure correctness.
Sjoerd Meijer [Thu, 23 Dec 2021 15:22:46 +0000 (15:22 +0000)]
[AArch64] Remove outdated FIXME in test arm64-csel.ll. NFC.
Pavel Labath [Wed, 29 Dec 2021 09:54:46 +0000 (10:54 +0100)]
[lldb/linux] Fix a bug in wait status handling
The MonitorCallback function was assuming that the "exited" argument is
set whenever a thread exits, but the caller was only setting that flag
for the main thread.
This patch deletes the argument altogether, and lets MonitorCallback
compute what it needs itself.
This is almost NFC, since previously we would end up in the
"GetSignalInfo failed for unknown reasons" branch, which was doing the
same thing -- forgetting about the thread.
PoYao Chang [Mon, 27 Dec 2021 04:34:23 +0000 (12:34 +0800)]
[lldb] Fix PR52702 by fixing bool conversion of Mangled
Remove the Mangled::operator! and Mangled::operator void* where the
comments in header and implementation files disagree and replace them
with operator bool.
This fix PR52702 as https://reviews.llvm.org/D106837 used the buggy
Mangled::operator! in Symbol::SynthesizeNameIfNeeded. For example,
consider the symbol "puts" in a hello world C program:
// Inside Symbol::SynthesizeNameIfNeeded
(lldb) p m_mangled
(lldb_private::Mangled) $0 = (m_mangled = None, m_demangled = "puts")
(lldb) p !m_mangled
(bool) $1 = true # should be false!!
This leads to Symbol::SynthesizeNameIfNeeded overwriting m_demangled
part of Mangled (in this case "puts").
In conclusion, this patch turns
callq 0x401030 ; symbol stub for: ___lldb_unnamed_symbol36
back into
callq 0x401030 ; symbol stub for: puts .
Differential Revision: https://reviews.llvm.org/D116217
Pavel Labath [Wed, 29 Dec 2021 09:00:00 +0000 (10:00 +0100)]
[lldb] Adjust TestModuleCacheSimple for D115951
Now that we are caching the dwarf index as well, we will always have
more than one cache file (when not using accelerator tables). I have
adjusted the test to check for the presence of one _symtab_ index.
Pavel Labath [Tue, 21 Dec 2021 12:59:14 +0000 (13:59 +0100)]
[lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe
Multithreaded applications using fork(2) need to be extra careful about
what they do in the fork child. Without any special precautions (which
only really work if you can fully control all threads) they can only
safely call async-signal-safe functions. This is because the forked
child will contain snapshot of the parents memory at a random moment in
the execution of all of the non-forking threads (this is where the
similarity with signals comes in).
For example, the other threads could have been holding locks that can
now never be released in the child process and any attempt to obtain
them would block. This is what sometimes happen when using tcmalloc --
our fork child ends up hanging in the memory allocation routine. It is
also what happened with our logging code, which is why we added a
pthread_atfork hackaround.
This patch implements a proper fix to the problem, by which is to make
the child code async-signal-safe. The ProcessLaunchInfo structure is
transformed into a simpler ForkLaunchInfo representation, one which can
be read without allocating memory and invoking complex library
functions.
Strictly speaking this implementation is not async-signal-safe, as it
still invokes library functions outside of the posix-blessed set of
entry points. Strictly adhering to the spec would mean reimplementing a
lot of the functionality in pure C, so instead I rely on the fact that
any reasonable implementation of some functions (e.g.,
basic_string::c_str()) will not start allocating memory or doing other
unsafe things.
The new child code does not call into our logging infrastructure, which
enables us to remove the pthread_atfork call from there.
Differential Revision: https://reviews.llvm.org/D116165
Chuanqi Xu [Wed, 29 Dec 2021 08:22:26 +0000 (16:22 +0800)]
[clang] Fix crash in bug52905
The root cause for the crash is the incorrect use of `cast`.
The actual type and cast-to type is different. This patch fixes the
crash by converting the `cast` to `dyn_cast`.
Kazu Hirata [Wed, 29 Dec 2021 08:16:40 +0000 (00:16 -0800)]
[clang] Fix header guards (NFC)
Identified with llvm-header-guard.
Kazu Hirata [Wed, 29 Dec 2021 07:47:25 +0000 (23:47 -0800)]
[Hexagon] Use range-based for loops (NFC)
Johannes Doerfert [Wed, 29 Dec 2021 07:29:07 +0000 (01:29 -0600)]
[OpenMP][OpenACC] Update test after encoding change in D113126
Johannes Doerfert [Wed, 29 Dec 2021 07:07:53 +0000 (01:07 -0600)]
Reapply "[OpenMP][NFCI] Embed the source location string size in the ident_t"
This reverts commit
73ece231ee0cf048d56841f47915beb1db6afc26 and
reapplies
7bfcdbcbf368cea14a5236080af975d5878a46eb with mlir changes.
Also reverts commit
423ba12971bac8397c87fcf975ba6a4b7530ed28 and
includes the unit test changes of
16da2140045808b2aea1d28366ca7d326eb3c809.
Mehdi Amini [Wed, 29 Dec 2021 07:08:58 +0000 (07:08 +0000)]
Revert "[OpenMP][FIX] Also update unit test after API change"
This reverts commit
16da2140045808b2aea1d28366ca7d326eb3c809.
Revert unit-test API update after previous revert of the API change.
Mehdi Amini [Wed, 29 Dec 2021 06:57:36 +0000 (06:57 +0000)]
Revert "[OpenMP][NFCI] Embed the source location string size in the ident_t"
This reverts commit
7bfcdbcbf368cea14a5236080af975d5878a46eb.
Broke MLIR build
Kazu Hirata [Wed, 29 Dec 2021 06:52:56 +0000 (22:52 -0800)]
[AST] Fix a warning
This patch fixes:
mlir/include/mlir/Tools/PDLL/AST/Types.h:54:3: error: definition of
implicit copy assignment operator for 'Type' is deprecated because
it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
Johannes Doerfert [Wed, 29 Dec 2021 05:59:35 +0000 (23:59 -0600)]
[Attributor] Look through allocated heap memory
AAPointerInfo, and thereby other places, can look already through
internal global and stack memory. This patch enables them to look
through heap memory returned by functions with a `noalias` return.
In the future we can look through `noalias` arguments as well but that
will require AAIsDead to learn that such memory can be inspected by the
caller later on. We also need teach AAPointerInfo about dominance to
actually deal with memory that might not be `null` or `undef`
initialized. D106397 is a first step in that direction already.
Reviewed By: kuter
Differential Revision: https://reviews.llvm.org/D109170
Johannes Doerfert [Wed, 29 Dec 2021 05:55:32 +0000 (23:55 -0600)]
[OpenMP] Simplify all stores in the device code
Similar to loads, we want to be aggressive when it comes to store
simplification. Not everything in LLVM handles dead stores well when
address space casts are involved, we can simply ask the Attributor to do
it for us though.
Reviewed By: tianshilei1992
Differential Revision: https://reviews.llvm.org/D109998
Johannes Doerfert [Wed, 29 Dec 2021 06:16:56 +0000 (00:16 -0600)]
[OpenMP][FIX] Also update unit test after API change
Johannes Doerfert [Thu, 4 Nov 2021 13:48:19 +0000 (08:48 -0500)]
[OpenMP][NFC] Extract assumption helpers into own header file
Johannes Doerfert [Wed, 3 Nov 2021 17:28:11 +0000 (12:28 -0500)]
[OpenMP][NFCI] Embed the source location string size in the ident_t
One of the unused ident_t fields now holds the size of the string
(=const char *) field so we have an easier time dealing with those
in the future.
Differential Revision: https://reviews.llvm.org/D113126
Johannes Doerfert [Sat, 11 Sep 2021 23:15:53 +0000 (18:15 -0500)]
[Attributor][FIX] Ensure store uses are correlated with reloads
While we skipped uses in stores if we can find all copies of the value
when the memory is loaded, we did not correlate the use in the store
with the use in the load. So far this lead to less precise results in the
offset calculations which prevented deductions. With the new
EquivalentUseCB callback argument the user of checkForAllUses can be
informed of the correlation and act on it appropriately.
Differential Revision: https://reviews.llvm.org/D109662
Johannes Doerfert [Tue, 28 Dec 2021 22:03:16 +0000 (16:03 -0600)]
[OpenMP][FIX] Make AAExecutionDomain deterministic
Johannes Doerfert [Sun, 26 Dec 2021 20:33:37 +0000 (14:33 -0600)]
[OpenMP][FIX] Make heap2shared deterministic
Issue #52875 reported non-determinism, this is the first step to avoid
it. We iterate over MallocCalls so we should keep the order stable.
Johannes Doerfert [Wed, 3 Nov 2021 17:57:43 +0000 (12:57 -0500)]
[OpenMP][NFC] Move address space enum into OMPConstants header
Johannes Doerfert [Wed, 3 Nov 2021 16:58:05 +0000 (11:58 -0500)]
[OpenMP][NFC] Move headers into include folder
William S. Moses [Tue, 28 Dec 2021 23:40:54 +0000 (18:40 -0500)]
[MLIR] Expose atomicrmw and/or
LLVM (dialect and IR) have atomics for and/or. This patch enables atomic_rmw ops in the standard dialect for and/or that lower to these (in addition to the existing atomics such as addi, etc).
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D116345
William S. Moses [Mon, 27 Dec 2021 21:07:11 +0000 (16:07 -0500)]
[MLIR] Add constant folder for fptosi and friends
This patch adds constant folds for FPToSI/FPToUI/SIToFP/UIToFP
Reviewed By: mehdi_amini, bondhugula
Differential Revision: https://reviews.llvm.org/D116321
Joe Loser [Wed, 22 Dec 2021 17:30:09 +0000 (12:30 -0500)]
[libcxx][test] Remove redundant semiregular checks for CPOs
Some individual test files verify the CPO under test satisfies
`semiregular` concept. This is redundant since it is already part of the test
in verifying whether the entity is indeed a CPO in
`libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp`.
Differential Revision: https://reviews.llvm.org/D116173
Craig Topper [Wed, 29 Dec 2021 02:28:23 +0000 (18:28 -0800)]
[RISCV] Add more div by constant test cases.
Some constants require more instructions than others. This adds
additional test for each variation. UDIV has 2 variations, SDIV has
4 variations.
Some of these sequence may have gotten worse on RV32 when we started
doing the div by constant optimization before type legalization. We
materialized a smaller constant, but we require more instructions
to emulate 8 or 16 bit right shifts. This was hidden by the lack
of test coverage.
I've also added Zba and Zbb test cases to show the affect of sext.b,
sext.h, zext.h, and zext.w on some of the shifts. In some cases
we end up generating more code after the multiply because we use
a zext.h+srli and sext.h+srai where without Zbb we share a slli
between a srli and srai.
Fangrui Song [Wed, 29 Dec 2021 02:03:28 +0000 (18:03 -0800)]
[llvm-profdata][docs] Use `` instead of `
Kyungwoo Lee [Wed, 29 Dec 2021 01:31:36 +0000 (17:31 -0800)]
[llvm-profdata] Make -debug-info visible
Add the option comment in .rst.
Reviewed By: ellis
Differential Revision: https://reviews.llvm.org/D116348
Fangrui Song [Wed, 29 Dec 2021 00:40:51 +0000 (16:40 -0800)]
[ELF] --gc-sections: Work around SHT_PROGBITS .init_array.N for Rust
See https://github.com/rust-lang/rust/issues/92181
Mike Hommey [Wed, 29 Dec 2021 00:01:01 +0000 (19:01 -0500)]
[lld-macho] Fix alignment of TLV data sections
References from thread-local variable sections are treated as offsets
relative to the start of the thread-local data memory area, which is
initialized via copying all the TLV data sections (which are all
contiguous). If later data sections require a greater alignment than
earlier ones, the offsets of data within those sections won't be
guaranteed to aligned unless we normalize alignments. We therefore use
the largest alignment for all TLV data sections.
Reviewed By: #lld-macho, int3
Differential Revision: https://reviews.llvm.org/D116263
modimo [Tue, 28 Dec 2021 22:48:15 +0000 (14:48 -0800)]
[CodeView] Clamp Frontend version
D43002 introduced a test debug-info-objname.cpp that outputted the current compiler version into CodeView. Internally we appended a date to the patch version and overflowed the 16-bits allocated to that space. This change clamps the Frontend version outputted values to 16-bits like rGd1185fc081ead71a8bf239ff1814f5ff73084c15 did for the Backend version.
Testing:
ninja check-all
newly added tests correctly clamps and no longer asserts when trying to output the field
Reviewed By: aganea
Differential Revision: https://reviews.llvm.org/D116243
Krzysztof Parzyszek [Tue, 28 Dec 2021 21:47:42 +0000 (13:47 -0800)]
[Hexagon] Support BUILD_VECTOR of floating point HVX vectors
Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
Co-authored-by: Ankit Aggarwal <aankit@quicinc.com>
Shilei Tian [Tue, 28 Dec 2021 22:42:31 +0000 (17:42 -0500)]
[OpenMP][CUDA] Add resource pool for CUevent
Following D111954, this patch adds the resource pool for CUevent.
Reviewed By: ye-luo
Differential Revision: https://reviews.llvm.org/D116315
Ellis Hoag [Tue, 28 Dec 2021 21:34:36 +0000 (13:34 -0800)]
[InstrProf] Prevent duplicate functions in correlated data
When using debug info for profile correlation, avoid adding duplicate
functions in the synthetic Data section.
Before this patch, n duplicate function entries in the Data section would
cause counter values to be a factor of n larger. I built instrumented
clang with and without debug info correlation and got these summaries.
```
# With Debug Info Correlate
$ llvm-profdata show default.profdata
Instrumentation level: IR entry_first = 0
Total functions: 182530
Maximum function count: 52034
Maximum internal block count: 5763
# Without
$ llvm-profdata show default.profdata
Instrumentation level: IR entry_first = 0
Total functions: 183212
Maximum function count: 52034
Maximum internal block count: 5766
```
The slight difference in counts seem to be mostly from FileSystem and
Map functions and the difference in the number of instrumented functions
seems to come from missing debug info like destructors without source.
Reviewed By: kyulee
Differential Revision: https://reviews.llvm.org/D116051
Craig Topper [Tue, 28 Dec 2021 22:05:40 +0000 (14:05 -0800)]
[TargetLowering] Remove workaround for old behavior of getShiftAmountTy. NFC
getShiftAmountTy used to directly return the shift amount type from
the target which could be too small for large illegal types. For
example, X86 always returns i8.
The code here detected this and used i32 instead if it won't fit. This
behavior was added to getShiftAmountTy in D112469 so we no longer need
this workaround.
Nick Desaulniers [Tue, 28 Dec 2021 20:48:30 +0000 (12:48 -0800)]
[clang][ARM] re-use arm::isHardTPSupported for hardware TLS check
This conditional check for -mstack-protector-guard=tls got out of sync
with the conditional check for -mtp=cp15 by me in D114116, because I
forgot about the similar check added in D113026.
Re-use the code in arm::isHardTPSupported so that these aren't out of
sync.
Interestingly, our CI reported this when testing
-mstack-protector-guard=tls; it was only reproducible with Debian's LLVM
and not upstream LLVM due to this out of tree patch:
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/snapshot/debian/patches/930008-arm.diff
Fixes: https://github.com/ClangBuiltLinux/linux/issues/1502
Reviewed By: ardb
Differential Revision: https://reviews.llvm.org/D116233
Shilei Tian [Tue, 28 Dec 2021 21:10:49 +0000 (16:10 -0500)]
[OpenMP][Plugin] Minor adjustments to ResourcePool
This patch makes some minor adjustments to `ResourcePool`:
- Don't initialize the resources if `Size` is 0 which can avoid assertion.
- Add a new interface function `clear` to release all hold resources.
- If initial size is 0, resize to 1 when the first request is encountered.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D116340
Renato Golin [Tue, 28 Dec 2021 11:59:54 +0000 (11:59 +0000)]
Documentation for the process of adding new targets
Plenty of new targets nowadays and I found myself repeating the same
thing over and over, so this is more or less what we said over the last
few years, but condensed in an ordered fashion and easy to digest.
This does not change any of the recommendations, only documents what we
have been saying for years.
Krzysztof Parzyszek [Tue, 28 Dec 2021 19:36:07 +0000 (11:36 -0800)]
[Hexagon] Delete unused declaration of LowerHvxMul, NFC
Brian Cain [Tue, 28 Dec 2021 19:23:50 +0000 (11:23 -0800)]
[Hexagon] Add testcase for arch flags
Rob Suderman [Fri, 24 Dec 2021 00:25:53 +0000 (16:25 -0800)]
[mlir][tosa] Resubmit split tosa-to-linalg named ops out of pass
Includes dependency fix that resulted in canonicalizer pass not linking in.
Linalg named ops lowering are moved to a separate pass. This allows TOSA
canonicalizers to run between named-ops lowerings and the general TOSA
lowerings. This allows the TOSA canonicalizers to run between lowerings.
Differential Revision: https://reviews.llvm.org/D116057
Krzysztof Parzyszek [Tue, 28 Dec 2021 19:20:03 +0000 (11:20 -0800)]
[Hexagon] Move testcase accidentally committed to wrong directory
llvm/test/DebugInfo/Hexagon/zreg-post-inc.s -> llvm/test/MC/Hexagon/zreg-post-inc.s
Michael Benfield [Tue, 28 Dec 2021 19:10:27 +0000 (19:10 +0000)]
[clang] Fix AttrDocs.td formatting.
This should fix the builder clang-sphinx-docs.
David Green [Tue, 28 Dec 2021 19:10:01 +0000 (19:10 +0000)]
[AArch64] Minor AArch64MIPeepholeOpt cleanup. NFC
We should always be in SSA form when running the pass, so turn a check
into an assert.
Roman Lebedev [Tue, 28 Dec 2021 18:58:31 +0000 (21:58 +0300)]
[BitcodeReader] propagateAttributeTypes(): fix opaque pointer handling
Can't get the pointee type of an opaque pointer,
but in that case said attributes must already be typed,
so just don't try to rewrite them if they already are.
Greg Clayton [Tue, 28 Dec 2021 19:02:50 +0000 (11:02 -0800)]
Fix "settings set -g" so it works again.
When we switched options over to use the Options.td file, a bug was introduced that caused the "-g" option for "settings set" to require a filename arguemnt. This patch fixes this issue and adds a test so this doesn't regress.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D116012
Greg Clayton [Tue, 28 Dec 2021 18:49:59 +0000 (10:49 -0800)]
Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.
This patch add the ability to cache the manual DWARF indexing results to disk for faster subsequent debug sessions. Manual DWARF indexing is time consuming and causes all DWARF to be fully parsed and indexed each time you debug a binary that doesn't have an acceptable accelerator table. Acceptable accelerator tables include .debug_names in DWARF5 or Apple accelerator tables.
This patch breaks up testing by testing all of the encoding and decoding of required C++ objects in a gtest unit test, and then has a test to verify the debug info cache is generated correctly.
This patch also adds the ability to track when a symbol table or DWARF index is loaded or saved to the cache in the "statistics dump" command. This is essential to know in statistics as it can help explain why a debug session was slower or faster than expected.
Reviewed By: labath, wallace
Differential Revision: https://reviews.llvm.org/D115951
Fangrui Song [Tue, 28 Dec 2021 18:49:52 +0000 (10:49 -0800)]
[CMake] Remove unneeded CLANG_DEFAULT_PIE_ON_LINUX canonicalization after D115751
Kazu Hirata [Tue, 28 Dec 2021 18:01:39 +0000 (10:01 -0800)]
Drop unnecessary const from return types (NFC)
Identified with readability-const-return-type.
Brian Cain [Tue, 28 Dec 2021 17:51:27 +0000 (09:51 -0800)]
[Hexagon] Add HexagonMCInstrInfo::IsABranchingInst, NFC
Brian Cain [Thu, 6 Sep 2018 16:53:00 +0000 (11:53 -0500)]
[Hexagon] Fix for producer operands search w/z-reg
Z-register does not show up in defs, so checks searching
for the def operand must look for a different def index
than they would normally.