platform/upstream/efl.git
4 years agoelm_config: fix a missing of free after using
Wonki Kim [Mon, 16 Sep 2019 13:57:36 +0000 (09:57 -0400)]
elm_config: fix a missing of free after using

Summary: safed_bindings will leak by going out the function without freeing.

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9966

4 years agoeolian: drop @ctor_param and the associated APIs
Daniel Kolesa [Mon, 16 Sep 2019 13:27:04 +0000 (15:27 +0200)]
eolian: drop @ctor_param and the associated APIs

This has been unused for a while, and has been just lingering
around the code, so drop it so it doesn't make it into a release.

4 years agorelease: Update NEWS and bump version for 1.23.0-beta2 release
Stefan Schmidt [Mon, 16 Sep 2019 11:48:37 +0000 (13:48 +0200)]
release: Update NEWS and bump version for 1.23.0-beta2 release

4 years agoefl_ui_slider: improve docs
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:36 +0000 (12:56 +0200)]
efl_ui_slider: improve docs

Summary: Depends on D9964

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9965

4 years agoefl_ui_check: improve docs
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:35 +0000 (12:56 +0200)]
efl_ui_check: improve docs

Summary: Depends on D9963

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9964

4 years agoefl_ui_button: improve docs
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:27 +0000 (12:56 +0200)]
efl_ui_button: improve docs

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9963

4 years agoefl_ui_widget: remove misleading comments
Xavi Artigas [Mon, 16 Sep 2019 10:37:59 +0000 (12:37 +0200)]
efl_ui_widget: remove misleading comments

Summary:
We settled for the focus_allow name.
The other APIs are not internal, they are protected, and this is
noted, no need to say that again.
Additionally it is not helpfull to have commented out c_prefix
definitions.
Depends on D9936

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9937

4 years agoefl_ui_widget: remove wrong docs
Marcel Hollerbach [Mon, 16 Sep 2019 10:28:33 +0000 (12:28 +0200)]
efl_ui_widget: remove wrong docs

Summary:
this is not true anymore, this has been reverted due to how legacy
works. *yey*
Depends on D9935

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9936

4 years agoefl_ui_widget: improve docs
Marcel Hollerbach [Mon, 16 Sep 2019 10:22:28 +0000 (12:22 +0200)]
efl_ui_widget: improve docs

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9935

4 years agodocs: Update docs for Efl.Pack_Layout
Xavi Artigas [Mon, 16 Sep 2019 10:13:45 +0000 (12:13 +0200)]
docs: Update docs for Efl.Pack_Layout

4 years agoefl.ui.scrollable: fix event name for scrollable
Hosang Kim [Mon, 16 Sep 2019 09:50:12 +0000 (11:50 +0200)]
efl.ui.scrollable: fix event name for scrollable

Summary:
Event name is applied in the past tense.
Meaning of 'stop' is 'stop it early', so I changed it to 'finish'

Test Plan: elementary_test -> efl.ui.scroller

Reviewers: segfaultxavi, woohyun

Reviewed By: segfaultxavi

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9859

4 years agoeina: fix spelling in new eina_file_statgen API
Stefan Schmidt [Mon, 16 Sep 2019 07:42:03 +0000 (09:42 +0200)]
eina: fix spelling in new eina_file_statgen API

Introduced in 9b294d6284f the new eina_file_statgen_* API has a typo in
its disable function. Fixing this before it gets out into a release.

Thanks goes to the https://abi-laboratory.pro service for offering their
great API/ABI reports to the open source communities to help finding such
things!

Differential Revision: https://phab.enlightenment.org/D9962

4 years agoci: travis: let Coverity scan run be executed every night until release
Stefan Schmidt [Mon, 16 Sep 2019 09:09:02 +0000 (11:09 +0200)]
ci: travis: let Coverity scan run be executed every night until release

Normally we only have this running on Saturday, which is fine for the
normal development cycle. Being close to a release now I would like to
get result updates every day. This will be switched back to weekly after
the 1.23 release.

4 years agoefl/image: Efl.Gfx.Border_Fill_Mode -> Efl.Gfx.Center_Fill_Mode
Mike Blumenkrantz [Mon, 16 Sep 2019 09:08:23 +0000 (11:08 +0200)]
efl/image: Efl.Gfx.Border_Fill_Mode -> Efl.Gfx.Center_Fill_Mode

Summary:
rename this to match its function

ref T7926, T7875
Depends on D9932

Subscribers: cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7926, T7875

Differential Revision: https://phab.enlightenment.org/D9933

4 years agoefl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method
Xavi Artigas [Mon, 16 Sep 2019 09:06:02 +0000 (11:06 +0200)]
efl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method

ref T7927, T7875
Depends on D9931

4 years agoefl/image: add size event info for image,resized event
Mike Blumenkrantz [Mon, 16 Sep 2019 09:01:01 +0000 (11:01 +0200)]
efl/image: add size event info for image,resized event

Summary:
this saves a manual lookup

ref T7875
Depends on D9930

Reviewers: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D9931

4 years agoefl/image: image,resize -> image,resized
Mike Blumenkrantz [Mon, 16 Sep 2019 08:58:24 +0000 (10:58 +0200)]
efl/image: image,resize -> image,resized

Summary:
events should always be past tense verbs

ref T7875
Depends on D9929

Reviewers: segfaultxavi

Subscribers: kimcinoo, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D9930

4 years agoefl/image: improve docs
Mike Blumenkrantz [Mon, 16 Sep 2019 08:42:27 +0000 (10:42 +0200)]
efl/image: improve docs

Summary:
this adds more docs for the overall interface as well as improvements to
existing docs

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9929

4 years agoevas - rsvg loader - comment out deprecated func from rsvg we don't need
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:47:05 +0000 (01:47 +0100)]
evas - rsvg loader - comment out deprecated func from rsvg we don't need

it seesm we don't need this. unref should shut down the rsvg obj
anyway, and rsvg_handle_close() has been deprecated since 2.46

4 years agoedje - physics - remove warning of unused arg if physics disabled
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:26:16 +0000 (01:26 +0100)]
edje - physics - remove warning of unused arg if physics disabled

simple warning removal. no core changes.

4 years agoefl_access_text: enable EFL_BETA_API_SUPPORT define to use beta apis 72/213872/3 submit/tizen/20190916.075039
Yeongjong Lee [Mon, 16 Sep 2019 06:04:57 +0000 (15:04 +0900)]
efl_access_text: enable EFL_BETA_API_SUPPORT define to use beta apis

since 4c531e262a440b79fc8e210d945bb8e7614aec2f,
Efl.Access.Text_Attribute and Efl.Access.Text_Range struct marked @beta.
EFL_BETA_API_SUPPORT is needed to use `Efl_Access_Text_Attribute`,
`Efl_Access_Text_Attribute` struct.

@tizen_fix

Change-Id: I0d49a63f7b76199c7e1b714252895fc1ec0310b1

4 years agoector: removed cairo backend. 52/213752/3
Hermet Park [Wed, 11 Sep 2019 04:12:08 +0000 (13:12 +0900)]
ector: removed cairo backend.

For reducing maintainability burden,
We drop supporting cairo backend.

The default backend is to software implementation from now.
It's well maintained so far and works good.x

Change-Id: Ia512df505f91e7918878afd690da178632308fc4

4 years agoector: don't alloc memory if the size is 0. 45/213745/3
Hermet Park [Wed, 11 Sep 2019 03:00:28 +0000 (12:00 +0900)]
ector: don't alloc memory if the size is 0.

Change-Id: I3c55022dfeca81fb328cbdcdc20d080922617e59

4 years agoector: code refactoring. 44/213744/3
Hermet Park [Wed, 11 Sep 2019 02:59:21 +0000 (11:59 +0900)]
ector: code refactoring.

more neat and clean code, no logical changes.

Change-Id: I0bfcb2c8cb6ad0a76fc9f186b83152dbb98472e7

4 years agobump up to 1.23.0
Yeongjong Lee [Mon, 16 Sep 2019 01:13:54 +0000 (10:13 +0900)]
bump up to 1.23.0

Change-Id: I95b8525f42d1ed7ee31a92fe5c59ecfc05a29733

4 years agoefl_ui_widget: fix eo build error of tizen only type
Yeongjong Lee [Mon, 16 Sep 2019 01:00:25 +0000 (10:00 +0900)]
efl_ui_widget: fix eo build error of tizen only type

@tizen_fix

Change-Id: I29d3e140df8cd6715ef94d9eea37d75bf3cf8dc6

4 years agoefl_ui_win: remove needless legacy keyword
Yeongjong Lee [Sun, 15 Sep 2019 23:40:21 +0000 (08:40 +0900)]
efl_ui_win: remove needless legacy keyword

@tizen_fix

Change-Id: If70d22b1d6622a3fdbdb8aed83e87fcf0404e0f4

4 years agocsharp: Fix Hash.DelByValue
Lauro Moura [Fri, 13 Sep 2019 22:22:39 +0000 (19:22 -0300)]
csharp: Fix Hash.DelByValue

Summary:
The C function `eina_hash_del_by_data` requires the same value that was
passed to the `add` function. As C# hashes store stuff through pointers
due to marshalling, this makes it hard to pass the same pointer for it.

So this functionality is implemented at C# level instead of relying on
the native function directly.

Fixes T8198

Thanks to @brunobelo and @singh.amitesh for the test case.

Reviewers: singh.amitesh, felipealmeida, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers, singh.amitesh, brunobelo

Tags: #efl

Maniphest Tasks: T8198

Differential Revision: https://phab.enlightenment.org/D9853

4 years agotests/edje: handle file modifications properly on windows
Mike Blumenkrantz [Fri, 13 Sep 2019 18:13:33 +0000 (14:13 -0400)]
tests/edje: handle file modifications properly on windows

Summary: we don't have access to utimensat and I'm too busy to figure out why

Reviewers: vtorri, bu5hm4n, devilhorns

Reviewed By: vtorri

Subscribers: cedric, #reviewers, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D9914

4 years agoefl_ui/scrollable_content: be more explicit about scrollable_content_get()
Mike Blumenkrantz [Fri, 13 Sep 2019 16:49:03 +0000 (18:49 +0200)]
efl_ui/scrollable_content: be more explicit about scrollable_content_get()

Summary:
always return NULL when an internal text object exists to avoid exposing
internal objects; this is an abstraction mechanism which should not be
extended or relied upon

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9910

4 years agodoc: improve single line descriptions
Myoungwoon Roy, Kim [Fri, 13 Sep 2019 12:04:46 +0000 (14:04 +0200)]
doc: improve single line descriptions

Summary: this patch improves single line descriptions described on T7717

Reviewers: woohyun, Hermet, myoungwoon, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9795

4 years agodocs: nicer formatting for Efl.Pack_Linear
Xavi Artigas [Fri, 13 Sep 2019 15:57:37 +0000 (17:57 +0200)]
docs: nicer formatting for Efl.Pack_Linear

4 years agomeson.build: allow to disable tiff evas loader
Boris Faure [Fri, 13 Sep 2019 15:26:19 +0000 (11:26 -0400)]
meson.build: allow to disable tiff evas loader

Summary:
@fix

eina benchmarks: ssize_t is defined in <sys/types.h>

Reviewers: #reviewers, bu5hm4n, zmike, stefan_schmidt

Reviewed By: zmike

Subscribers: vtorri, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9927

4 years agoeolian: support complex monospace syntax $[...]
Daniel Kolesa [Fri, 13 Sep 2019 14:56:43 +0000 (16:56 +0200)]
eolian: support complex monospace syntax $[...]

This is to allow monospace bits with periods, commas and other
non-alphabetical characters. Newlines are not supported (they end
the block) and escapes are supported (for ]).

Fixes T8213.

4 years agoefl_ui_slider: correct to a multiple of step when drag is finished
Marcel Hollerbach [Fri, 13 Sep 2019 14:14:37 +0000 (10:14 -0400)]
efl_ui_slider: correct to a multiple of step when drag is finished

Summary:
this is needed in order to support the value to be a multiple of the
step when drag has finished. The normal changed event is still emitted
with non-multiple of step, but the steady event only contains the
correct values now.

ref T8187

Reviewers: zmike, segfaultxavi, woohyun

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8187

Differential Revision: https://phab.enlightenment.org/D9928

4 years agoeolian_gen: add missing param doc for event raising
Xavi Artigas [Fri, 13 Sep 2019 12:26:21 +0000 (14:26 +0200)]
eolian_gen: add missing param doc for event raising

4 years agoeolian: Remove the EOLIAN_PROPERTY_DOC_WARN envvar
Xavi Artigas [Fri, 13 Sep 2019 10:41:16 +0000 (12:41 +0200)]
eolian: Remove the EOLIAN_PROPERTY_DOC_WARN envvar

This test is now always enabled, so ALL properties should have property-level
documentation. Setter and getter docs are optional.

4 years agodocs: Move property docs to property level instead of set/get
Xavi Artigas [Fri, 13 Sep 2019 10:25:49 +0000 (12:25 +0200)]
docs: Move property docs to property level instead of set/get

Eolian @properties should be documented at the property level, and
documentation at the setter or getter level should be left to setter-
or getter-specific comments. There is usually no need at all to have
setter- or getter- specific comments.
Also, a property is not a method so descriptions should match that.

This patch removes lots of duplicated text, and will allow enabling
by default the eolian check that ensures that properties have proper
property-level docs.

No functional changes.

4 years agoefl_app_test_promise: fix warning (no returned value)
Vincent Torri [Thu, 12 Sep 2019 18:46:06 +0000 (14:46 -0400)]
efl_app_test_promise: fix warning (no returned value)

Test Plan: compilation

Reviewers: cedric, zmike, raster

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9926

4 years agoeio: fix warning
Vincent Torri [Thu, 12 Sep 2019 18:45:58 +0000 (14:45 -0400)]
eio: fix warning

Test Plan: compillation

Reviewers: raster, cedric, zmike

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9925

4 years agomeson: make sure evas buffer engine is built before edje_cc
Marcel Hollerbach [Thu, 12 Sep 2019 18:45:47 +0000 (14:45 -0400)]
meson: make sure evas buffer engine is built before edje_cc

Summary:
ensure that the evas buffer engine is available.

fix T8220

Reviewers: zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8220

Differential Revision: https://phab.enlightenment.org/D9918

4 years agoEvil: fix mmap() and define HAVE_MMAP
Vincent Torri [Thu, 12 Sep 2019 14:01:33 +0000 (10:01 -0400)]
Evil: fix mmap() and define HAVE_MMAP

Summary: add size of file mapping to fix invalid parameter

Test Plan: compilation (edje succeeds) and elm_test

Reviewers: zmike, cedric, raster

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9913

4 years agoefl_ui_calendar_item: document this class a little bit more
Marcel Hollerbach [Thu, 12 Sep 2019 11:29:12 +0000 (13:29 +0200)]
efl_ui_calendar_item: document this class a little bit more

Summary: Depends on D9923

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9924

4 years agoefl_ui_image: insert @ to link docs proberly
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:39 +0000 (13:26 +0200)]
efl_ui_image: insert @ to link docs proberly

Summary: Depends on D9922

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9923

4 years agoefl_gfx_path: insert @ to link docs proberly
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:33 +0000 (13:26 +0200)]
efl_gfx_path: insert @ to link docs proberly

Summary: Depends on D9921

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9922

4 years agoefl_ui_scrollable: insert @ to link docs proberly
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:28 +0000 (13:26 +0200)]
efl_ui_scrollable: insert @ to link docs proberly

Summary: Depends on D9920

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9921

4 years agoefl_object: insert @ to link docs proberly
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:24 +0000 (13:26 +0200)]
efl_object: insert @ to link docs proberly

Summary: Depends on D9919

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9920

4 years agoefl_part: insert @ to link docs proberly
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:20 +0000 (13:26 +0200)]
efl_part: insert @ to link docs proberly

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9919

4 years agoefl/arrangement: improve docs
Mike Blumenkrantz [Thu, 12 Sep 2019 09:00:03 +0000 (11:00 +0200)]
efl/arrangement: improve docs

Summary:
this adds full docs for the class and properties

ref T7717
ref T7864

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7864, T7717

Differential Revision: https://phab.enlightenment.org/D9912

4 years agoefl/hint: fix hint_align docs
Mike Blumenkrantz [Thu, 12 Sep 2019 08:55:15 +0000 (10:55 +0200)]
efl/hint: fix hint_align docs

Summary:
the docs should not assume that the current language is LTR and should
instead specify that the horizontal direction depends on the language
reading direction

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9911

4 years agoefl_ui_timepicker/datepicker : change event name properly
WooHyun Jung [Thu, 12 Sep 2019 08:24:51 +0000 (10:24 +0200)]
efl_ui_timepicker/datepicker : change event name properly

Summary:
This changes the event name from "changed" to "date(or time),changed"

@ref T7869 T7901

Reviewers: segfaultxavi, zmike, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7901, T7869

Differential Revision: https://phab.enlightenment.org/D9905

4 years agocsharp: Minor change to D9692
Bruno da Silva Belo [Thu, 12 Sep 2019 02:17:39 +0000 (23:17 -0300)]
csharp: Minor change to D9692

Summary: Changing Evt to Event from some files that it wasn't catch on D9692

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, felipealmeida, #reviewers, lauromoura, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9904

4 years agocsharp: Registering events when using Components.Basic.
Bruno da Silva Belo [Wed, 11 Sep 2019 20:21:02 +0000 (17:21 -0300)]
csharp: Registering events when using Components.Basic.

Summary:
With `Components.Basic`, it isn't registering events,
while `Components.Ui` do with `elm_init`

Fixes T7770
Thanks @lauromoura

Test Plan: Look T7770

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers

Tags: #efl

Maniphest Tasks: T7770

Differential Revision: https://phab.enlightenment.org/D9909

4 years agoeolian_mono: fix documentation warning by using "<" and ">"
Jaehyun Cho [Wed, 11 Sep 2019 14:46:51 +0000 (11:46 -0300)]
eolian_mono: fix documentation warning by using "<" and ">"

Summary:
If type A: list<B>; is written in eo, then documentation warning
occurs because list<B> is written in the documentation without string
conversion.

To fix the warning, "<" and ">" are converted into "&lt;" and "&gt;".

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9891

4 years agoefl_ui_collection: fix the insertion of the first element with pack_at
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:48 +0000 (13:38 -0400)]
efl_ui_collection: fix the insertion of the first element with pack_at

Summary:
before pack_at with no element failed because the list element has been
NULL.
This fixes the insertion, the codepath also works without the error.
Depends on D9871

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9890

4 years agoefl_ui/scrollable_content: handle null cases for scrollable_*_get
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:41 +0000 (13:38 -0400)]
efl_ui/scrollable_content: handle null cases for scrollable_*_get

Summary: these are valid calls and should be handled correctly

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9880

4 years agotests/edje: reduce chances of cascading test failures in non-forked mode
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:35 +0000 (13:38 -0400)]
tests/edje: reduce chances of cascading test failures in non-forked mode

Summary:
move evas_free() into the global shutdown fixture to ensure that edje_shutdown
actually does call internal shutdown methods since evas_free() will not be
reached if it is at the end of a failing test

Depends on D9878

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9879

4 years agotests/edje: add comprehensive edje reloading test
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:28 +0000 (13:38 -0400)]
tests/edje: add comprehensive edje reloading test

Summary:
this verifies:
* successfully loading a file
* emission of "load" signal when performing a file load
* swallowing an object
* no-op of file load operation on same file if mtime is unchanged
* successfully reloading the same file if the mtime has changed
* preserving user-defined data across file reloads

Depends on D9877

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9878

4 years agoefl: check file's mtime in efl.file::file_set to determine if file is the same
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:21 +0000 (13:38 -0400)]
efl: check file's mtime in efl.file::file_set to determine if file is the same

Summary:
historically, if the mtime of an edj file changes after being loaded,
the edje file should be reloaded. this needs to occur in a single call
with the previous user definitions intact, so verify that the mtime is
the same in efl.file::file_set when using the same file name

@fix

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9877

4 years agointroduce test file for Efl.Ui.Group_Item
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:20 +0000 (13:38 -0400)]
introduce test file for Efl.Ui.Group_Item

Summary:
this tests that the tree structure which is defined by the group and
child item hirachy is correctly transformed into a linear list.
This also checks that the bug from the revision before is not happening.

Depends on D9890

Reviewers: segfaultxavi, zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9872

4 years agoefl_ui_group_item: fix insertion of item at the end
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:13 +0000 (13:38 -0400)]
efl_ui_group_item: fix insertion of item at the end

Summary:
in this case here, eina list count already returns the count *including*
the subobject, the case in pack_at below (where also +1 is added) is
different to that, as count is the value *before* the list add.
Depends on D9870

Reviewers: segfaultxavi, zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9871

4 years agoefl_ui_test_list_collection: add test for item placement
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:07 +0000 (13:38 -0400)]
efl_ui_test_list_collection: add test for item placement

Summary:
this test checks if the placement of the items is correct with and
without scrolling, with and without groups.
Depends on D9869

Reviewers: segfaultxavi, zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9870

4 years agoevas_textblock: fix warning
ali [Wed, 11 Sep 2019 15:07:51 +0000 (11:07 -0400)]
evas_textblock: fix warning

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9903

4 years agoevas_callbacks: make the callback protection a little bit safer
Marcel Hollerbach [Wed, 4 Sep 2019 19:18:18 +0000 (21:18 +0200)]
evas_callbacks: make the callback protection a little bit safer

the problem here is that we might subscribe to an event before
evas_object_callbacks_init has happened. This sounds like something
which might not happen. However, with the interfaces project this
definitly will start to happen because someone will some day overwrite
the evas object and do something before the constructor, which will not
raise a error or something but will simply just not work.

With this commit we are not listening to the event callbacks via event
emission but rather via inheritance. With this there is no "earlier than
we listend" point, and the issue in the task is solved by itself.

fix T8202

Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9841

4 years agoevas vg: optimize memory in layer blending.
Hermet Park [Wed, 11 Sep 2019 06:12:35 +0000 (15:12 +0900)]
evas vg: optimize memory in layer blending.

Same method to 321035d1e7d58fb9165b7ee55c1962d39c859caa

By far, with previous memory optimization,

The memory usage is reduced to half of composition buffer size.

4 years agocanvas vg: optimize memory usage in composition.
Hermet Park [Wed, 11 Sep 2019 05:27:47 +0000 (14:27 +0900)]
canvas vg: optimize memory usage in composition.

Ector buffer allocates memory in default,
We don't need to allocate buffer memory additionally to handle over outside.
We can map/unmap ector buffer for reusing this.

4 years agoector: removed cairo backend.
Hermet Park [Wed, 11 Sep 2019 04:12:08 +0000 (13:12 +0900)]
ector: removed cairo backend.

For reducing maintainability burden,
We drop supporting cairo backend.

The default backend is to software implementation from now.
It's well maintained so far and works good.x

4 years agoector: don't alloc memory if the size is 0.
Hermet Park [Wed, 11 Sep 2019 03:00:28 +0000 (12:00 +0900)]
ector: don't alloc memory if the size is 0.

4 years agoector: code refactoring.
Hermet Park [Wed, 11 Sep 2019 02:59:21 +0000 (11:59 +0900)]
ector: code refactoring.

more neat and clean code, no logical changes.

4 years agocsharp: remove unused delegate and struct
Yeongjong Lee [Wed, 11 Sep 2019 02:41:42 +0000 (23:41 -0300)]
csharp: remove unused delegate and struct

Summary: cleanup workaround.cs

Test Plan: ninja test

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9895

4 years agoefl_ui_widget: refactor constructor
Marcel Hollerbach [Wed, 11 Sep 2019 01:43:08 +0000 (10:43 +0900)]
efl_ui_widget: refactor constructor

Summary:
first of all, in efl-ui we should probebly ensure that a widget is
always created in a window object. Otherwise we are looking for trouble.

Additionally, calling efl_ui_win_shared_data_get on anything else than a
window object will result in a returned NULL value.
If we are not having a widget parent, there is also not much point in
calling a API that is only defined on the widget base class, so we also
move that away

Reviewers: kimcinoo, raster

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9762

4 years agocsharp: Add test for static interface members
Lauro Moura [Tue, 10 Sep 2019 23:15:59 +0000 (20:15 -0300)]
csharp: Add test for static interface members

For the checks added in D9893

4 years agocsharp: skip static members from interfaces
Yeongjong Lee [Tue, 10 Sep 2019 22:47:47 +0000 (19:47 -0300)]
csharp: skip static members from interfaces

Summary:
Static methods of eo-interface are generated in c# interface-concrete. there are
4 methods
`efl_access_object_access_root_get`, `efl_access_object_event_emit`,
`efl_access_object_event_handler_add`, `efl_access_object_event_handler_del`

If a class that inherits that interface, static method can't be called via
classname.

This commit changes eolian_mono by removing those static members from the C#
interface-concretes. If a generated class implements the interface, the static
member is generated as static member of the class directly.

Depends on D9800

Test Plan: Check that `Efl.Ui.Widget` has `public static Efl.Object AccessRoot` property.

Reviewers: lauromoura, felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9893

4 years agocsharp: Skip non-public members from interfaces
Lauro Moura [Tue, 10 Sep 2019 22:30:46 +0000 (19:30 -0300)]
csharp: Skip non-public members from interfaces

Summary:
Eolian allows non-public members in interfaces and mixins (usually
@protected). As both kinds are converted to C# interfaces, this
causes problem as non-public members are forbidden in C# interfaces.

This commit changes eolian_mono by removing those members from the C#
interfaces. If a generated class implements the interface, the method is
generated as if it were a protected member of the class directly.

For mixed properties like `Efl.Io.Reader.CanRead { get; set @protected; }`,
the interface has only the public getter and the the implementing class has both
the public getter and the protected setter.

With this, C# devs won't be able to directly implement protected Eo
methods from interfaces. (But this really does not make sense from the
C# point of view).

ref T7494

Reviewers: segfaultxavi, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, brunobelo, Jaehyun_Cho, #reviewers, woohyun, #committers

Tags: #efl

Maniphest Tasks: T7494

Differential Revision: https://phab.enlightenment.org/D9800

4 years agoefl task - change exit method to use normal event for multiple listeners
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 22:01:19 +0000 (23:01 +0100)]
efl task - change exit method to use normal event for multiple listeners

we couldn't have multilpe listeners before. now we can. better this
way. have to do this now because i can't mark efl task as @beta
without taking out massive wads of efl with it.

4 years agoCSharp: Cleanup test that inserts idle event and do not remove it
Felipe Magno de Almeida [Tue, 10 Sep 2019 21:58:31 +0000 (18:58 -0300)]
CSharp: Cleanup test that inserts idle event and do not remove it

Summary: Remove idle event after running test so it doesn't impact with other tests that run after it

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9887

4 years agocsharp: Adding ToString methods to Strbuf and custommarshaler.
Bruno da Silva Belo [Tue, 10 Sep 2019 20:42:19 +0000 (17:42 -0300)]
csharp: Adding ToString methods to Strbuf and custommarshaler.

Summary:
WIN32 should use a allocator and deallocator different from EFL, sometimes, when
freeing a pointer, it should use win32_free. To stardardize, A custommarshaler
is used to fix this problem.

Fixes T8201

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers

Tags: #efl

Maniphest Tasks: T8201

Differential Revision: https://phab.enlightenment.org/D9842

4 years agoeolian-mono: Changing order of scope and modifier.
Bruno da Silva Belo [Tue, 10 Sep 2019 20:06:17 +0000 (17:06 -0300)]
eolian-mono: Changing order of scope and modifier.

Summary: sealed public is now public sealed and virtual public is public virtual

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers

Tags: #refactoring, PHID-PROJ-uhnmnvlvunw6jgoqdnd4, #efl_language_bindings

Maniphest Tasks: T8172

Differential Revision: https://phab.enlightenment.org/D9725

4 years agobuild: unbreak destructors
Mike Blumenkrantz [Tue, 10 Sep 2019 18:03:04 +0000 (15:03 -0300)]
build: unbreak destructors

Summary:
the following commits did not correctly add super calls to the destructor,
resulting in a massive number of build errors as well as some unit test failures

ref e51699afbc6094fcfc0f62ca2071ae7b8c6e313b
ref 38be95b0b6fd93df01636ae0a7c974b32ed694a1

Reviewers: raster, lauromoura

Reviewed By: lauromoura

Subscribers: lauromoura, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9902

4 years agoefl task - go back to non beta... this breaks the world
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:53:59 +0000 (17:53 +0100)]
efl task - go back to non beta... this breaks the world

4 years agoeo beta - mark task, io classes as beta because they are...
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:43:02 +0000 (17:43 +0100)]
eo beta - mark task, io classes as beta because they are...

4 years agoefl core cmommand line - implement destructor and thus fix leak
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:29:01 +0000 (17:29 +0100)]
efl core cmommand line - implement destructor and thus fix leak

4 years agoefl gfx path - implement destructor and thus fix leak
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:28:40 +0000 (17:28 +0100)]
efl gfx path - implement destructor and thus fix leak

4 years agoefl_ui/alert_popup: More documentation nitpicks
Xavi Artigas [Tue, 10 Sep 2019 15:14:33 +0000 (17:14 +0200)]
efl_ui/alert_popup: More documentation nitpicks

4 years agoefl_ui/alert_popup: improve docs
Mike Blumenkrantz [Tue, 10 Sep 2019 15:08:44 +0000 (17:08 +0200)]
efl_ui/alert_popup: improve docs

Summary:
class and property docs

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9883

4 years agodocs: nicer formatting of the NULL keyword, everywhere
Xavi Artigas [Tue, 10 Sep 2019 14:05:44 +0000 (16:05 +0200)]
docs: nicer formatting of the NULL keyword, everywhere

4 years agoefl_ui/popup: improve docs
Mike Blumenkrantz [Tue, 10 Sep 2019 13:44:29 +0000 (15:44 +0200)]
efl_ui/popup: improve docs

Summary:
this provides full documentation for the class and all properties

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9882

4 years agoefl_ui_suite: resolve focus errors
Marcel Hollerbach [Tue, 10 Sep 2019 13:21:56 +0000 (09:21 -0400)]
efl_ui_suite: resolve focus errors

Summary:
unregsiter shound never call unprotected eo API on the object,
unregister can be called with a object that is dead.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9898

4 years agoefl_ui_widget: make Efl_Ui_Scrollable_On_Show_Region legacy
Yeongjong Lee [Tue, 10 Sep 2019 13:09:00 +0000 (09:09 -0400)]
efl_ui_widget: make Efl_Ui_Scrollable_On_Show_Region legacy

Summary:
`Efl_Ui_Scrollable_On_Show_Region` is only used for legacy EAPI. it moved to
elm_widget.h from eo file. also, it renamed `Elm_Widget_On_Show_Region_Cb`.

Reviewers: Jaehyun_Cho, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9896

4 years agoeolian: hard ban usage of ptr() in stable API
Daniel Kolesa [Tue, 10 Sep 2019 12:35:41 +0000 (14:35 +0200)]
eolian: hard ban usage of ptr() in stable API

4 years agoefl: replace usage of ptr() in all stable APIs
Daniel Kolesa [Tue, 10 Sep 2019 12:29:06 +0000 (14:29 +0200)]
efl: replace usage of ptr() in all stable APIs

4 years agoeolian: fix default value handling for @by_ref types
Daniel Kolesa [Tue, 10 Sep 2019 12:25:03 +0000 (14:25 +0200)]
eolian: fix default value handling for @by_ref types

We must check all pointerness first, and append NULL as default
when that applies, because @by_ref is not carried in the typedecl
info. Therefore, it would result in a false positive and try to
make a zeroed struct, which we don't want.

4 years agoeolian: account for @by_ref when serializing return types
Daniel Kolesa [Tue, 10 Sep 2019 12:17:25 +0000 (14:17 +0200)]
eolian: account for @by_ref when serializing return types

This fixes cases such as missing const when having a @by_ref
return type. The const should not be avoided there because it
is not returning the whole type as const, just what the pointer
dereferences to.

4 years agoeolian: consider @by_ref marked elements ownable
Daniel Kolesa [Tue, 10 Sep 2019 12:10:10 +0000 (14:10 +0200)]
eolian: consider @by_ref marked elements ownable

4 years agoeolian: add an optional warning for ptr() usage in stable API
Daniel Kolesa [Tue, 10 Sep 2019 12:06:46 +0000 (14:06 +0200)]
eolian: add an optional warning for ptr() usage in stable API

4 years agoevas_vg_cache: Hashkey in cache uses evas
JunsuChoi [Tue, 10 Sep 2019 11:06:18 +0000 (20:06 +0900)]
evas_vg_cache: Hashkey in cache uses evas

Summary:
Vg_entry is shared by different child windows.
When two or more objects load the same file
When resizing, cache_vg_entry_render can delete an active entry
while creating a new entry and deleting an existing entry.
Therefore, use cache data added evas

Test Plan:
[enable json loader]
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -203,7 +203,7 @@ option('evas-loaders-disabler',
   type : 'array',
   description : 'List of modular image/vector load  .....
   choices : ['gst', 'pdf', 'ps', 'raw', 'svg', 'rs  .....
-  value : ['webp', 'json']
+  value : ['webp']

[Test]
elementary_test -> Animation View click -> play -> Animation View click again -> ...

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9740

4 years agoefl_task/exe: Further update docs
Xavi Artigas [Tue, 10 Sep 2019 10:26:03 +0000 (12:26 +0200)]
efl_task/exe: Further update docs

4 years agoefl_exe: Enhance class description
Wonki Kim [Tue, 10 Sep 2019 10:11:06 +0000 (12:11 +0200)]
efl_exe: Enhance class description

Summary: This patch ehnance the description of efl_exe, regarding task T7717.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9889

4 years agoefl_ui/box_flow: Improve docs a bit further
Xavi Artigas [Tue, 10 Sep 2019 09:34:50 +0000 (11:34 +0200)]
efl_ui/box_flow: Improve docs a bit further

4 years agoefl_ui/flox_box: improve docs
Mike Blumenkrantz [Tue, 10 Sep 2019 09:25:55 +0000 (11:25 +0200)]
efl_ui/flox_box: improve docs

Summary:
expand the description for the class a bit

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9885