Marcel Holtmann [Thu, 3 Sep 2009 02:48:02 +0000 (19:48 -0700)]
Parse and use Address and Port options from modem.conf
Marcel Holtmann [Thu, 3 Sep 2009 02:40:17 +0000 (19:40 -0700)]
Fixing missing vendor.h in distribution
Marcel Holtmann [Thu, 3 Sep 2009 02:37:55 +0000 (19:37 -0700)]
Parse and use Device option from modem.conf
Marcel Holtmann [Thu, 3 Sep 2009 02:30:21 +0000 (19:30 -0700)]
Remove generic_at plugin
Marcel Holtmann [Thu, 3 Sep 2009 02:27:47 +0000 (19:27 -0700)]
Fix some broken DOS newline messup
Marcel Holtmann [Thu, 3 Sep 2009 02:24:09 +0000 (19:24 -0700)]
Update the modem.conf example one more time
Marcel Holtmann [Thu, 3 Sep 2009 02:18:41 +0000 (19:18 -0700)]
Remove the async TTY open helper and just use a blocking one
Andres Salomon [Wed, 2 Sep 2009 23:35:40 +0000 (19:35 -0400)]
G1: Add an SMS quirk for CNMI mode
The G1 doesn't support mode2, despite advertising it.
The G1 chokes w/ an "Error 303" when we specify NMI mode 2. Adding a
quirk to drop that mode from the supported list (just use mode 1) allows
the G1 to properly deal with SMS.
Marcel Holtmann [Thu, 3 Sep 2009 02:04:21 +0000 (19:04 -0700)]
Use proper debug calls for pure debugging output
Marcel Holtmann [Thu, 3 Sep 2009 01:56:46 +0000 (18:56 -0700)]
Add a separate plugin for connection to phone simulator
Marcel Holtmann [Thu, 3 Sep 2009 01:53:14 +0000 (18:53 -0700)]
Update modem.conf example
Denis Kenzior [Thu, 3 Sep 2009 00:48:33 +0000 (19:48 -0500)]
Fix emitting Modems Property in the wrong place
Marcel Holtmann [Wed, 2 Sep 2009 23:20:17 +0000 (16:20 -0700)]
Mention Andres' contributions
Andres Salomon [Tue, 25 Aug 2009 22:07:28 +0000 (18:07 -0400)]
G1: Add a G1 syntax for parsing
This is based on the generic_at parser, with unnecessary stuff removed.
The G1 routinely screws up CRLFs, so the parser needs to account for
that. This parser ignores leading CRLFs (which is what reference-ril
does as well), as well as trailing LFs (which are sometimes left out).
CRs are used as end-of-message indicators. Since we're not bothering
tracking CRLFs, there's also no need for a GARBAGE state, or MULTILINE
stuff.
Andres Salomon [Tue, 25 Aug 2009 20:04:48 +0000 (16:04 -0400)]
G1: Add initial HTC G1 modem support
G1 plugin is based on generic_at, with a bunch of stuff dropped
and simplified. We use AT+CFUN=1 for powering on rather than having
a configurable init string. We also manually set the default state
during init (the G1 appears to start in mode V0 by default). The
device (/dev/smd0) is hardcoded.
Denis Kenzior [Wed, 2 Sep 2009 22:37:28 +0000 (17:37 -0500)]
Squash compiler warning
Denis Kenzior [Wed, 2 Sep 2009 22:37:17 +0000 (17:37 -0500)]
Update modemconf driver to the new ofono_modem_create
Denis Kenzior [Wed, 2 Sep 2009 22:35:29 +0000 (17:35 -0500)]
Change plugins to the new ofono_modem_create api
Denis Kenzior [Wed, 2 Sep 2009 22:35:18 +0000 (17:35 -0500)]
Get rid of node argument in ofono_modem_create
Denis Kenzior [Wed, 2 Sep 2009 22:34:31 +0000 (17:34 -0500)]
Add simple utility to validate paths
Denis Kenzior [Wed, 2 Sep 2009 21:58:34 +0000 (16:58 -0500)]
Add modem property capability
Add ofono_modem_set_string & ofono_modem_get_string
Add ofono_modem_set_integer & ofono_modem_get_integer
Marcel Holtmann [Wed, 2 Sep 2009 22:43:10 +0000 (15:43 -0700)]
Use OFONO_AT_DEBUG even for MBM plugin
Marcel Holtmann [Wed, 2 Sep 2009 22:22:30 +0000 (15:22 -0700)]
Unset the driver data when MBM driver is removed
Marcel Holtmann [Wed, 2 Sep 2009 22:18:10 +0000 (15:18 -0700)]
Add example for modem.conf and install it if requested
Marcel Holtmann [Wed, 2 Sep 2009 21:56:14 +0000 (14:56 -0700)]
Add really simple modem configuration parsing
Marcel Holtmann [Wed, 2 Sep 2009 21:40:50 +0000 (14:40 -0700)]
Add skeleton for plugin to handle static modem configurations
Denis Kenzior [Wed, 2 Sep 2009 19:27:26 +0000 (14:27 -0500)]
Update makefile.am with new doc files
Denis Kenzior [Wed, 2 Sep 2009 19:25:09 +0000 (14:25 -0500)]
Add call-settings api doc
Denis Kenzior [Wed, 2 Sep 2009 19:22:26 +0000 (14:22 -0500)]
Add call-meter api doc
Denis Kenzior [Wed, 2 Sep 2009 19:20:14 +0000 (14:20 -0500)]
Add call-forwarding api doc
Denis Kenzior [Wed, 2 Sep 2009 18:48:40 +0000 (13:48 -0500)]
Add address & netmask properties to GPRS api
Denis Kenzior [Wed, 2 Sep 2009 14:59:41 +0000 (09:59 -0500)]
Update GPRS api with context use type
Marcel Holtmann [Wed, 2 Sep 2009 10:58:27 +0000 (03:58 -0700)]
Add test script for listing all operator details
Marcel Holtmann [Wed, 2 Sep 2009 10:48:46 +0000 (03:48 -0700)]
Add test script to monitor all PropertyChanged signals
Marcel Holtmann [Wed, 2 Sep 2009 10:35:09 +0000 (03:35 -0700)]
Add two extra test programs for modem interface
Marcel Holtmann [Wed, 2 Sep 2009 10:19:02 +0000 (03:19 -0700)]
Add initial plugin for Ericsson MBM devices
Denis Kenzior [Wed, 2 Sep 2009 03:35:14 +0000 (22:35 -0500)]
Rename isi drivers to isimodem
Be more consistent with directory naming
Denis Kenzior [Wed, 2 Sep 2009 03:33:05 +0000 (22:33 -0500)]
Rename generic_at drivers to atmodem
Be more consistent with directory naming
Denis Kenzior [Wed, 2 Sep 2009 03:29:02 +0000 (22:29 -0500)]
populate should return void
Denis Kenzior [Wed, 2 Sep 2009 03:27:08 +0000 (22:27 -0500)]
Make remove functions not return anything
Denis Kenzior [Wed, 2 Sep 2009 02:39:02 +0000 (21:39 -0500)]
change int vendor to unsigned int vendor
Marcel Holtmann [Wed, 2 Sep 2009 01:54:27 +0000 (18:54 -0700)]
Add first steps for a udev based modem detection plugin
Marcel Holtmann [Wed, 2 Sep 2009 01:41:16 +0000 (18:41 -0700)]
Update D-Bus configuration options and check for udev
Denis Kenzior [Wed, 2 Sep 2009 01:09:40 +0000 (20:09 -0500)]
Add ofono_modem_get_powered
Denis Kenzior [Tue, 1 Sep 2009 23:05:11 +0000 (18:05 -0500)]
Add proposed data connection manager API
Denis Kenzior [Tue, 1 Sep 2009 23:04:20 +0000 (18:04 -0500)]
Add stub vendor.h file
Denis Kenzior [Tue, 1 Sep 2009 23:03:52 +0000 (18:03 -0500)]
Add vendor flag capability to voicecalls
Denis Kenzior [Tue, 1 Sep 2009 23:00:58 +0000 (18:00 -0500)]
Add vendor flag capability to ussd
Denis Kenzior [Tue, 1 Sep 2009 22:53:31 +0000 (17:53 -0500)]
Add vendor flag capability to ssn
Denis Kenzior [Tue, 1 Sep 2009 22:39:29 +0000 (17:39 -0500)]
Add vendor flag capability for sms
Denis Kenzior [Tue, 1 Sep 2009 22:36:27 +0000 (17:36 -0500)]
Add vendor flag capability to sim
Denis Kenzior [Tue, 1 Sep 2009 22:32:07 +0000 (17:32 -0500)]
Add vendor flag capability to phonebook
Denis Kenzior [Tue, 1 Sep 2009 22:22:26 +0000 (17:22 -0500)]
Add vendor flag capability to netreg
Denis Kenzior [Tue, 1 Sep 2009 22:18:42 +0000 (17:18 -0500)]
Add vendor flag capability to devinfo
Denis Kenzior [Tue, 1 Sep 2009 22:14:58 +0000 (17:14 -0500)]
Add vendor flag to call-settings
Denis Kenzior [Tue, 1 Sep 2009 22:08:37 +0000 (17:08 -0500)]
Add vendor parameter to call-meter
Denis Kenzior [Tue, 1 Sep 2009 22:03:43 +0000 (17:03 -0500)]
Add vendor flag to call-forwarding
Denis Kenzior [Tue, 1 Sep 2009 21:57:24 +0000 (16:57 -0500)]
Introduce vendor parameter to call-barring
Ismo Puustinen [Tue, 1 Sep 2009 09:07:51 +0000 (12:07 +0300)]
gisi: Getter function for pipe handle
Denis Kenzior [Tue, 1 Sep 2009 03:59:39 +0000 (22:59 -0500)]
Fix being able to set powered after failure
If enable failed, subsequent attempts will also fail.
Denis Kenzior [Tue, 1 Sep 2009 03:59:22 +0000 (22:59 -0500)]
Add PDU listing support
Denis Kenzior [Mon, 31 Aug 2009 20:08:40 +0000 (15:08 -0500)]
Don't return sdn numbers until ready
Denis Kenzior [Mon, 31 Aug 2009 20:06:06 +0000 (15:06 -0500)]
Simplify EFsdn reading code
Denis Kenzior [Mon, 31 Aug 2009 19:14:55 +0000 (14:14 -0500)]
Rename MNCLength to MobileNetworkCodeLength
Denis Kenzior [Mon, 31 Aug 2009 19:13:12 +0000 (14:13 -0500)]
Refactor sim mnc length
Denis Kenzior [Mon, 31 Aug 2009 18:42:54 +0000 (13:42 -0500)]
Style Fix
Denis Kenzior [Mon, 31 Aug 2009 19:33:24 +0000 (14:33 -0500)]
Simplify nested ifs
Denis Kenzior [Mon, 31 Aug 2009 19:24:48 +0000 (14:24 -0500)]
Simplify overly complicated code
Andrzej Zaborowski [Wed, 26 Aug 2009 02:27:04 +0000 (04:27 +0200)]
Expose service dialling numbers stored on SIM through SimManager.
Andrzej Zaborowski [Wed, 26 Aug 2009 01:14:06 +0000 (03:14 +0200)]
Decode and encode alpha-identifier fields
Add identifier argument to sim_adn_parse and sim_adn_build.
Also fix the number length passed to extract_bcd_number in sim_adn_parse.
Andrzej Zaborowski [Wed, 26 Aug 2009 00:36:45 +0000 (02:36 +0200)]
Read EFad and expose the IMSI MNC length (2-3)
Denis Kenzior [Sun, 30 Aug 2009 20:32:08 +0000 (15:32 -0500)]
Reformat comments a little
Andres Salomon [Sun, 30 Aug 2009 20:00:26 +0000 (16:00 -0400)]
driver callback naming
On Sun, 30 Aug 2009 13:45:45 -0500
Denis Kenzior <denkenz@gmail.com> wrote:
> Hi Andres,
>
> > static struct ofono_modem_driver g1_driver = {
> > .name = "HTC G1",
> > .probe = g1_probe,
> > .enable = g1_enable,
> > .disable = g1_disable,
> > .remove = g1_remove,
> > .populate = g1_populate,
> > };
> >
>
> So the current intention:
> .probe - Detect whether device is really supported by the plugin,
> initialize any data structures specific to the device
> .remove - Destroy data structures
> .enable - Perform power up
> .disable - Perform power down
> .populate - Populate the atoms supported by this device (e.g. netreg,
> voicecall, etc) This is called by the core after every power cycle,
> when the device is brought up.
>
Thanks! See patch below.
> >
> > Of course, I'm also wondering why there needs to be two separate
> > layers of calls in the first place. Why not have drivers register
> > everything from within probe, call ofono_set_powered(modem, TRUE)
> > once the device is ready, and be done with it?
>
> The reason for this is e.g. airplane mode, where you physically want
> to turn off the device. Another case is for battery / power reasons,
> e.g. a netbook with a USB modem that is not being used.
>
Fair enough. In the kernel, we have callbacks named suspend/resume
to handle that.
> > The only reason why this doesn't blow up in the generic_at plugin is
> > because the driver_data is leaked. If one were to free it from
> > generic_at_exit in the wrong place (since it's allocated from
> > generic_at_init, it would make sense to free it in generic_at_exit),
> > one would see the same SEGV/SIGBUS/SIGILL errors upon ctrl-c.
>
> So the leak has now been fixed.
>
> I think you're being unnecessarily harsh here. To be fair, the
> generic_at driver does something like this at init:
My criticism is simply w/ the naming. 'enable'/'disable' doesn't imply
anything about power. powerup/powerdown, poweron/poweroff,
suspend/resume would all imply power state changes (at least the latter
would be familiar to those who do kernel stuff). Having comments that
describe what the callbacks do would also work, though.
>From
80a7b54d52201dfd7d8b590457450ae0a4f72888 Mon Sep 17 00:00:00 2001
From: Andres Salomon <dilinger@collabora.co.uk>
Date: Sun, 30 Aug 2009 15:56:16 -0400
Subject: [PATCH] Add comments to ofono_modem_driver struct
Document what all the callbacks do.
Denis Kenzior [Sun, 30 Aug 2009 18:29:11 +0000 (13:29 -0500)]
Fix memory leak in generic_at driver
Denis Kenzior [Sun, 30 Aug 2009 18:28:52 +0000 (13:28 -0500)]
Add debug to modem_create
Denis Kenzior [Wed, 26 Aug 2009 22:08:40 +0000 (17:08 -0500)]
Make history drivers work again
Denis Kenzior [Sat, 29 Aug 2009 15:44:44 +0000 (10:44 -0500)]
Fix a problem with CtrlZ echo
When a PDU is submitted and echoed by the modem, the CtrlZ character
is also echoed back. Fix the parser to handle this case appropriately.
Rémi Denis-Courmont [Fri, 28 Aug 2009 11:53:56 +0000 (14:53 +0300)]
gisi: return GPRS interface index/name
Aki Niemi [Tue, 25 Aug 2009 15:26:24 +0000 (18:26 +0300)]
gisi: Fix indication debugging
Aki Niemi [Tue, 25 Aug 2009 11:04:42 +0000 (14:04 +0300)]
Rename all files under drivers/isimodem/
Aki Niemi [Mon, 24 Aug 2009 16:19:11 +0000 (19:19 +0300)]
Fix typo in technology name
Marcel Holtmann [Tue, 25 Aug 2009 06:49:40 +0000 (23:49 -0700)]
Convert to fully non-recursive build system
Marcel Holtmann [Tue, 25 Aug 2009 02:05:41 +0000 (19:05 -0700)]
Use script to generate list of builtin plugin symbols
Marcel Holtmann [Tue, 25 Aug 2009 01:51:39 +0000 (18:51 -0700)]
Use proper variables for various commands
Aki Niemi [Mon, 24 Aug 2009 12:47:17 +0000 (15:47 +0300)]
Add straw-man for rest of ISI modem driver
Rémi Denis-Courmont [Mon, 24 Aug 2009 10:24:08 +0000 (13:24 +0300)]
Fix broken dependency on include/ofono/*.h files
The fact that the directory exists does not prove that (all of) the
header file symbolic links have been created. This is particularly
annoying when a new header file gets added.
Aki Niemi [Mon, 24 Aug 2009 10:34:53 +0000 (13:34 +0300)]
Fix build warning
Aki Niemi [Mon, 24 Aug 2009 10:13:31 +0000 (13:13 +0300)]
Fix typos
Aki Niemi [Sun, 23 Aug 2009 20:19:03 +0000 (23:19 +0300)]
gisi: Fix warning in g_isi_subscribe()
Save the GIsiModem instance in GIsiClient, so that calling
g_isi_subscribe() doesn't throw a warning.
Aki Niemi [Sun, 23 Aug 2009 20:16:46 +0000 (23:16 +0300)]
Fix memory leak in ISI phonebook driver
Aki Niemi [Sat, 22 Aug 2009 15:01:24 +0000 (18:01 +0300)]
gisi: Add debugging hooks
Aki Niemi [Sat, 22 Aug 2009 15:00:58 +0000 (18:00 +0300)]
Fix memory leak in isimodem.c
Aki Niemi [Sat, 22 Aug 2009 12:37:34 +0000 (15:37 +0300)]
Move dump_msg() to isi.h as static inline
Andrzej Zaborowski [Sat, 22 Aug 2009 02:37:04 +0000 (04:37 +0200)]
Fix getting the offset into sms fragment bitmap.
Otherwise only 64 fragments fit.
Denis Kenzior [Sat, 22 Aug 2009 00:13:19 +0000 (19:13 -0500)]
Add generic_at modem driver
Useful for testing or when the device is extremely 27.007 compliant,
e.g. phonesim
Denis Kenzior [Sat, 22 Aug 2009 00:12:27 +0000 (19:12 -0500)]
Update the isi driver to the new modem driver api
Denis Kenzior [Sat, 22 Aug 2009 00:11:32 +0000 (19:11 -0500)]
Introduce the Modem driver API
Denis Kenzior [Fri, 21 Aug 2009 00:44:23 +0000 (19:44 -0500)]
Remove org.ofono.at.Manager
Denis Kenzior [Fri, 21 Aug 2009 00:43:52 +0000 (19:43 -0500)]
Add CONFIGDIR automake magic
Denis Kenzior [Fri, 21 Aug 2009 00:19:21 +0000 (19:19 -0500)]
Remove unused function