Jean-Philippe Andre [Wed, 3 Aug 2016 09:08:31 +0000 (18:08 +0900)]
widget: Fix propagation of events on hold
Because of the translation between legacy and eo key
events, the on_hold flag state could sometimes be lost.
Symptom:
elementary_test -to Focus
Click on a button inside the scroller
Up/down would jump to the end of the scroller, rather than
the next button.
Thanks a lot to Woohyeon for the very good bug report.
Jean-Philippe Andre [Wed, 3 Aug 2016 07:32:39 +0000 (16:32 +0900)]
glx: Fix black windows in E on nvidia
This fixes calls to glXCreatePixmap that would consistently
fail on nvidia >= 360.
It seems glXCreatePixmapEXT was used instead of glXCreatePixmap,
and that function always returned 0.
One could assume always using the non-EXT version of the
function should be preferred. Unfortunately, doing so for all
the other functions brings back the black windows.
I'm taking a very careful approach by doing this only for drivers
>= 360.
Fixes T3030
@fix
Jean-Philippe Andre [Wed, 3 Aug 2016 02:29:14 +0000 (11:29 +0900)]
gl_x11: Minor code refactor around eglCreateImage
Trying to debug T3030... hitting a brick wall at the moment.
Add better error handling (for EGL).
Carsten Haitzler (Rasterman) [Wed, 3 Aug 2016 08:27:42 +0000 (17:27 +0900)]
elm theme - don't use empty env vars eina_prefix handles anyway
in
14ec825aa9ed9c6ede79d1729fdb291285b3bd6d cedric added trying
ELM_DATA_DIR env var explicitly for looking for themes. first if this
is NULL then we look in a bogus directory (null). secondly eina_prefix
already takes care of env vars like thsi as part of figuring out
prefix with correct namespace etc. so this just is a bug as opposed to
anything useful and the CORRECt implementation is already done in
eina_prefix.
@fix
Davide Andreoli [Tue, 2 Aug 2016 23:53:51 +0000 (16:53 -0700)]
edje: fix color class broken by
b543f4c896d9.
T4270
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Cedric Bail [Tue, 2 Aug 2016 22:28:20 +0000 (15:28 -0700)]
eina: test safepointer in the correct range for 32bits system.
The generation counter on 32bits system is on 8bits, obviously 1024
is more than that.
T4265
Andy Williams [Tue, 2 Aug 2016 22:23:31 +0000 (23:23 +0100)]
Fix text check in Elm_Code T4264
An incorrect assumption in how unused memory may be initialised
@fix
Stefan Schmidt [Tue, 2 Aug 2016 15:32:39 +0000 (17:32 +0200)]
release: Update NEWS and bump version for 1.18.0-beta2 release
Stefan Schmidt [Tue, 2 Aug 2016 20:20:05 +0000 (22:20 +0200)]
tests: eolian_cxx: add define to allow the use of beta APIs like eo
This is needed again now as we put eo back into beta for 1.18.
Jean Guyomarc'h [Tue, 2 Aug 2016 19:08:58 +0000 (21:08 +0200)]
ecore_audio: use the correct module wrapper
This was code for sndfile. sndfile module should have been
used instead of the pulseaudio one.
It led to a build break when having sndfile but not pulseaudio.
Ref:
879d93377b219dca00be63f8139fee79b7938147
Derek Foreman [Tue, 2 Aug 2016 18:24:40 +0000 (13:24 -0500)]
ecore_drm2: Fix a condition where no outputs are enabled
If the first output we test is disconnected but has the crtc of
the primary display assigned then we'll fail to assign the crtc
to the connector it's really connected to later.
This is a quick hack as trying to sort this out properly may be
too invasive for the upcoming 1.18 and isn't really important until
1.19 supports multihead anyway.
Daniel Kolesa [Tue, 2 Aug 2016 16:35:14 +0000 (17:35 +0100)]
docs: put graph before hierarchy
Daniel Kolesa [Tue, 2 Aug 2016 15:47:29 +0000 (16:47 +0100)]
docs: allow rank dir and size to be changed in theme
Tom Hacohen [Tue, 2 Aug 2016 15:14:12 +0000 (16:14 +0100)]
Eo: Move Eo back into beta.
Eo should now be considered beta again. This commit puts it back in beta
and makes it necessary to define EFL_BETA_API_SUPPORT before including
Eo.h.
Daniel Kolesa [Tue, 2 Aug 2016 14:46:03 +0000 (15:46 +0100)]
docs: support for foldable inheritance graphs
Daniel Kolesa [Tue, 2 Aug 2016 14:32:24 +0000 (15:32 +0100)]
docs: add theme loader for graphs
Vitalii Vorobiov [Tue, 2 Aug 2016 13:46:40 +0000 (16:46 +0300)]
edje_edit: delete swallowed object before unswallowing (for part type GROUP)
unswallowing set swallowed_object to NULL inside of
_edje_real_part_swallow_clear
so it is impossible to delete object anymore.
And so, changing sources leaves fantoms and undeleted objects.
@fix
Hermet Park [Tue, 2 Aug 2016 13:38:30 +0000 (22:38 +0900)]
elementary widget: fix a wrong disabled behavior.
This is a corner case bug I spontaneously found.
* Scenario.
A. Disable A widget.
B. Add a child B widget to A.
C. Now B Widget theme will be followed to A that is performed by
elm_widget_theme_apply()
D. This elm_widget_theme_apply() calls elm_widget_disabled_set() (originally.)
E. Now B widget will be logically disabled.
D. Let's enable A widget again.
E. After going through widget disabled sequence, elm_widget_disabled_eval()
will be called in the last
F. In this function, A widget tries to enable its children. But B widget won't
be enabled because its logically disabled!
Acutally, nowhere widget change children's disabled states logically,
but it propagates its state to children within volatile way so that
A widget perfectly keeps the disabled/enabled state with its children and
recover the children's enable/disable state once their relationship is cut off.
@fix
Carsten Haitzler (Rasterman) [Tue, 2 Aug 2016 08:30:34 +0000 (17:30 +0900)]
elm scroller accel was broken by default confgis setting it to 0. fix
now set default wheel scroll accel to 7 as epr the confgi upgrade code
and also improve the acceleration to "rely on itself" and feedback
loop. this is so much better now i can scroll through things in a
whisk with the wheel.
fixes T4263
@fix
Stefan Schmidt [Tue, 2 Aug 2016 07:31:10 +0000 (09:31 +0200)]
tests: ecore_con: make sure info is initialized
One test does init info before passing it to _url_compl_cb while two others
are not. Also test if inof is NULL in callback here to avoid crashes.
tests/ecore_con/ecore_con_test_ecore_con_url.c:194:4: warning: 'info' may be used uninitialized in this function [-Wmaybe-uninitialized]
ecore_event_handler_add(ECORE_CON_EVENT_URL_COMPLETE,
Stefan Schmidt [Tue, 2 Aug 2016 07:29:58 +0000 (09:29 +0200)]
tests: eio: add Eina.h include for eina_init and shutdown functions.
tests/eio/eio_suite.c:33:4: warning: implicit declaration of function 'eina_init' [-Wimplicit-function-declaration]
eina_init();
^
tests/eio/eio_suite.c:38:4: warning: implicit declaration of function 'eina_shutdown' [-Wimplicit-function-declaration]
eina_shutdown();
Stefan Schmidt [Tue, 2 Aug 2016 06:32:13 +0000 (08:32 +0200)]
build: do not dist now longer available files
Another cleanup for commit
dd1d3f0d2d8f7369f7461f54928eac2a4fce99fb. These
makefiles are now longer available better not try to dist them.
Stefan Schmidt [Tue, 2 Aug 2016 06:11:15 +0000 (08:11 +0200)]
build remove now unused eolian subbuild helper makefile
In commit
dd1d3f0d2d8f7369f7461f54928eac2a4fce99fb the consumers of the makefile
have been removed. No need to still have it around.
Carsten Haitzler (Rasterman) [Tue, 2 Aug 2016 02:23:34 +0000 (11:23 +0900)]
efl runtime dynamic lib loading - make errors consistent and useful
so drop trying to appease the openbsd packages and stick to "upstream
so major versions" and let users fix their systems with symlinks. also
report what we are looking for so they have a chance to symlink to
make efl happy.
at some point we should make a single simple runtime lib linker
subsystem in efl so all these errors are reported in the same way,
input libray names are listed in a simple consistent way etc. etc.
for now we have 3 locations in efl that do this and they are roughly
similar. we can unify it later.
Cedric BAIL [Mon, 1 Aug 2016 20:36:47 +0000 (13:36 -0700)]
autotools: since it has been broken for some times and nobody noticed, let's remove per directory support.
Romain Naour [Wed, 27 Jul 2016 20:38:02 +0000 (22:38 +0200)]
elementary: remove *.eo.h files from includesub_HEADERS
Otherwise *.eo.h files will be installed twice, so it can break a
parallel install on fast machines, whereby two make jobs may run
concurently, trying to install the same files.
With elementary 1.17.1:
/usr/bin/install -c -m 644 elm_sys_notify.eo.h
/usr/bin/install -c -m 644 elm_sys_notify.eo.h
usr/bin/install: cannot create regular file 'elm_sys_notify.eo.h': File exists
Fixed in Buildroot:
https://git.busybox.net/buildroot/commit/?id=
bba82cbfe4caaa01366fc74fb3b6f4c41587a28b
While applying the fix on latest master (1.18.0-beta1), the only
remaining *.eo.h file is efl_ui_text.eo.h.
Fixes:
http://autobuild.buildroot.net/results/7e9/
7e9caffe442dcf40ee41da56fd3f55ffedf3a291
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Carsten Haitzler (Rasterman) [Mon, 1 Aug 2016 14:33:58 +0000 (23:33 +0900)]
edje_cc build - link to lua and use ula cflags as edje_cc uses lua
i do not remember it using lua... well that's obvious then - add
cflags/libs.
Carsten Haitzler (Rasterman) [Mon, 1 Aug 2016 12:12:24 +0000 (21:12 +0900)]
ecore-imf - fix stupidity of loading ALL modules even if not needed
eocre-imf loaded all input modules even though an env var was set to
tell it to use a specific one. this just wastes memory and slows down
startup time. this uses the env var to choose ro auto-guesses wayland
or xim input if the right env vars are set, and if it doesnt know
falls back to "load all" as before. this saves 28kb of dirty pages.
this helps address T4227
@fix
Carsten Haitzler (Rasterman) [Mon, 1 Aug 2016 10:04:42 +0000 (19:04 +0900)]
edje - reduce memory footrpint by dlopening ephysics on demand
this saves about another 80Kb or so in dirty pages by only loading
ephysics when needed. This removed ephysics and bullet library dirty
pages from the process space. this is another patch to address T4227.
@fix
Carsten Haitzler (Rasterman) [Mon, 1 Aug 2016 05:37:10 +0000 (14:37 +0900)]
ecore_audio - save 232k of real RAM by dlopening depednecies
so libpuls and libsndfile suck in dependencies. they suck in so much
that by the time linking is done we've written to about 230kb of
PRIVATE MEMORY as dirty pages in symbol tablesm global veriables etc.
etc. - this is just horrible. especially if an app never makes any
sound... it's just wasted memory. this stuff is invisible to normal
memory debug tools. so this begins to address things. please see
T4227. my numbers now put me at:
1780Kb total dirty writable mapped from library file pages. down from
2012Kb.
This fixes some memory bloat reported in the above ticket, but there
is more to fix for sure.
@fix
Subhransu Mohanty [Mon, 1 Aug 2016 04:24:34 +0000 (13:24 +0900)]
edje: throw error when vector resource not found.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4202
Subhransu Mohanty [Mon, 1 Aug 2016 04:23:44 +0000 (13:23 +0900)]
edje: Fix handling of polygon and polyline node.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4203
Jean-Philippe Andre [Fri, 29 Jul 2016 09:20:43 +0000 (18:20 +0900)]
tests: Place inline window inside a box
This shows off how to properly use an inline window.
I tried to add extra smarts inside elementary to handle those
inline windows like normal objects... but it led to more bugs.
The only way that makes sense to use this inline window
is to separately treat the image object and the window
itself. Any other approach is too tricky.
See T1973
Jean-Philippe Andre [Fri, 29 Jul 2016 08:30:25 +0000 (17:30 +0900)]
ecore_evas: Register animators for inline image ee
In ecore_evas_object_image_new, register animator tick del/add
catchers, so that animators can work. This fixes mouse scroll
in an inline window.
Jean-Philippe Andre [Fri, 29 Jul 2016 08:28:27 +0000 (17:28 +0900)]
scrollable: Avoid useless connect to animator
If scrolling Y no need to register X animators. And vice
versa. It's a minor optimization.
Daniel Hirt [Sat, 30 Jul 2016 21:48:12 +0000 (00:48 +0300)]
Canvas text: fix range geometry calculation for RTL
Fixes T3627.
@fix
Carsten Haitzler (Rasterman) [Fri, 29 Jul 2016 23:27:10 +0000 (08:27 +0900)]
data for elm - remove misleading and unused Makefile.am
Gustavo Sverzut Barbieri [Fri, 29 Jul 2016 23:27:43 +0000 (20:27 -0300)]
eo-mode.el: add @nonull and void_ptr.
these were not in the wiki (also fixed), thus I've missed them.
Carsten Haitzler (Rasterman) [Fri, 29 Jul 2016 16:42:15 +0000 (01:42 +0900)]
ecore imf - ibus - fix destroy/disconnect handling that crashes
restart e or have ibus input get destroyed and come back... the ibus
module will do bad things to its pants... because the wrong things
were passed to the signal callbacks... this fixers that along with
ensuring a freed string ptr is NULL.
@fix
Daniel Kolesa [Fri, 29 Jul 2016 13:26:55 +0000 (14:26 +0100)]
elua: add table serializer/deserializer
This is important for docgen use (reading theme configs).
Stefan Schmidt [Fri, 29 Jul 2016 12:59:43 +0000 (14:59 +0200)]
tests: ecore: try to keep constness for Efl_Version
It returns as const so better try to keep this be having the avriable const as
well.
Stefan Schmidt [Fri, 29 Jul 2016 12:55:10 +0000 (14:55 +0200)]
tests: eina: comment out unused test to avoid warning
Just to avoid the unused function warning.
Stefan Schmidt [Fri, 29 Jul 2016 12:53:36 +0000 (14:53 +0200)]
eina: promise: fix memory leak in error path
If we would not get a promise back here the allocated array would leak when we
return. Make sure we also free it in this case.
CID: 1360468
Stefan Schmidt [Fri, 29 Jul 2016 12:20:16 +0000 (14:20 +0200)]
ecore: xcb: make sure length_name is always initialized
lib/ecore_x/xcb/ecore_xcb_icccm.c: In function ‘ecore_x_icccm_name_class_set’:
lib/ecore_x/xcb/ecore_xcb_icccm.c:320:11: warning: ‘length_name’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
s += length_name + 1;
Looking at the code this is indeed possible so better play safe here.
Stefan Schmidt [Fri, 29 Jul 2016 12:17:39 +0000 (14:17 +0200)]
evas: xcb: fix build break of xcb engine
This was broken since commit
ed2e78286b351cd8c3e85e1f6b92f25a54fab027
The variable is named differently in the xlib vs. xcb code
Stefan Schmidt [Thu, 28 Jul 2016 14:52:25 +0000 (16:52 +0200)]
elm: object_item: add guards to include eo and legacy header only when allowed
Make sure the eo and legacy headers are only included when the matching defines
are enabled.
Stefan Schmidt [Thu, 28 Jul 2016 14:50:12 +0000 (16:50 +0200)]
elm: sys_notify: add guards to inlcude eo and legacy header only when allowed
Make sure the eo and legacy headers arte onl yincluded when the matching defines
are enabled.
Stefan Schmidt [Thu, 28 Jul 2016 14:00:31 +0000 (16:00 +0200)]
eldbus: make sure eldbus model is hidden behind the BETA API flag
Make sure we keep this in beta for now until our EO based interfaces are ready.
Woochan Lee [Fri, 29 Jul 2016 05:31:01 +0000 (14:31 +0900)]
multibuttonentry: Fix wrong definitions.
Summary:
There is no "ELM_MULTIBUTTONENTRY_EVENT_CHANGED"
Because of this, MBE's Internal entry did not get a changed callback.
And MBE does not have changed smart callback.
Those things made by someone during EO interface working i think.
Test Plan: elementary_test
Reviewers: Hermet, cedric, jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4195
Gustavo Sverzut Barbieri [Fri, 29 Jul 2016 04:05:17 +0000 (01:05 -0300)]
eo-mode.el for emacs.
This major mode provides colored output, that helps a lot to view and
edit ".eo" and ".eot" files.
It's the first version, I still see some indenting issues with
toplevel blocks such as struct and enums. Nonetheless it's much more
useful than fundamental-mode (pure text).
Cedric Bail [Fri, 29 Jul 2016 04:02:51 +0000 (21:02 -0700)]
eina: add back option lost at some point for debugging.
Cedric Bail [Fri, 29 Jul 2016 03:54:20 +0000 (20:54 -0700)]
eio: add a test for T3237.
I have been trying to reproduce the reported ephoto issue, but couldn't. This
test case reproduce the reported scenario.
Cedric Bail [Fri, 29 Jul 2016 03:53:34 +0000 (20:53 -0700)]
eio: all our tests need eina and we aren't testing eina here, so init once and for all.
Carsten Haitzler (Rasterman) [Fri, 29 Jul 2016 02:57:10 +0000 (11:57 +0900)]
efl - elm genlist - clean up sanghyeon's patch to be less code
use if not while, no first, and timing checkis already done at end so
remove from if/while. cleaner now.
Carsten Haitzler (Rasterman) [Fri, 29 Jul 2016 02:52:02 +0000 (11:52 +0900)]
fix warnings in sanhyeons's patch/fix
Jonghee Choi [Fri, 29 Jul 2016 02:43:38 +0000 (11:43 +0900)]
[CONFIG] call elm_rescale() only when scale value is changed
Summary: it doesn't need to call elm_rescale() in _config_flush_get() when the scale value is not changed.
Reviewers: jaehwan, cedric, raster
Subscribers: minkyu
Differential Revision: https://phab.enlightenment.org/D4186
SangHyeon Lee [Fri, 29 Jul 2016 02:21:27 +0000 (11:21 +0900)]
genlist: fix memory-leak in filter queue and refactoring queue iteration
Summary:
There are critical memory-leak in filter queue process.
It looks typo so I fix it and refactoring queue iteration logic to spend
less time in for and while loop.
Test Plan: Tested by filter elementary test
Reviewers: shashank0990
Reviewed By: shashank0990
Subscribers: raster, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4170
jinwoo.shin [Fri, 29 Jul 2016 02:08:09 +0000 (11:08 +0900)]
Fix memory leak issue on genlist_example_02
Summary: The realized items list should be freed by either eina_list_free() or EINA_LIST_FREE when it is no longer needed
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: minkyu
Differential Revision: https://phab.enlightenment.org/D4193
Carsten Haitzler (Rasterman) [Thu, 28 Jul 2016 22:57:17 +0000 (07:57 +0900)]
evas generic gst loader - handle fwrite return value for coverity
fixes CID 1360467
Carsten Haitzler (Rasterman) [Thu, 28 Jul 2016 15:00:49 +0000 (00:00 +0900)]
evas canvas destruction - detect zombie objs and hack at them with axes
ok. so here's the issue at least now. we have eo objects in the canvas
and they have a refcount of 2 user_refcount is 0. the calls stack does
NOT show we are calling callbacks at that time on these objects. they
are not in the backtrace (the canvas is, the objects themselves are
not).
SOMETHING is keeping 2 eo "internal" refs on these objects and i have
no idea what/how/who. it's a royal pain in the butt to find out as the
only way is lots and lots of logging and you get drowned in the
logging...
so what I have now done is a super ugly workaround that detects these
zombie objects that refuse to die and just FORCES them to die when the
evas canvas frees and clears out layers.
ac10a00acc6bacf01bfd208cc78b4eb2a6a925d8 doesn't really cause the
issue, it just brings it out in the open for all to see far more
easily. but something is deeply wrong SOMEWHERE with SOME objects and
our refcounts.
this fixes T4187
Daniel Kolesa [Thu, 28 Jul 2016 13:18:58 +0000 (14:18 +0100)]
docs: support for writing edge styles for individual connections
Daniel Kolesa [Thu, 28 Jul 2016 13:09:35 +0000 (14:09 +0100)]
docs: initial bits for theming support for graphs
Jean-Philippe Andre [Thu, 28 Jul 2016 11:10:39 +0000 (20:10 +0900)]
tests: Add missing function implementations
In eolian test cases.
Not a problem when EOAPI is defined as weak, but compilation
will fail if the symbols are strong. Eg. on Solaris (it's just
a guess).
Fixes T3889
Amitesh Singh [Thu, 28 Jul 2016 09:48:07 +0000 (15:18 +0530)]
entry: allow force recalc on "size,eval" "elm" signal
Summary:
In some use cases, font (style) of elm.text in elm entry is changed
on focus and unfocus. user must send "size,eval",elm signal to entry to
force recalc, but this was not happening. This patch fixes that issue.
fixes T4233
Reviewers: tasn, herdsman, raster
Subscribers: cedric, seoz, jpeg
Maniphest Tasks: T4233
Differential Revision: https://phab.enlightenment.org/D4196
Jean-Philippe Andre [Thu, 28 Jul 2016 07:30:41 +0000 (16:30 +0900)]
win: Fix evas framespace under X
Mouse inputs would not work if the window is rotated,
because the framespace was invalid.
Fixes T4132
Carsten Haitzler (Rasterman) [Thu, 28 Jul 2016 01:59:15 +0000 (10:59 +0900)]
edje entry - check all minor struct callocs and on fail report + unwind
lots of unchecked malloc/calloc returns, so check these, unwind safely
and complain (highly unlikely to happen unless the system is about to
fall over). this should fix T4230
Vitor Sousa [Fri, 22 Jul 2016 21:43:12 +0000 (18:43 -0300)]
elementary: fix legacy path set/get for Fileselector specializations
Fix legacy functions elm_fileselector_path_get and
elm_fileselector_path_set.
Make these functions call the correct function when called with a
specialization of Elm.Fileselector (instead of the base class function).
Create internal versions of path set/get functions to avoid warnings
about deprecated function calls.
Fix T4198
@fix
Derek Foreman [Wed, 27 Jul 2016 20:23:12 +0000 (15:23 -0500)]
ecore-drm2: Silence compiler warning
We probably can't actually use this variable uninitialized, but
let's init it anyway to keep gcc happy.
Chris Michael [Wed, 27 Jul 2016 19:35:42 +0000 (15:35 -0400)]
ecore-drm2: Fix issue of VT-Switching going blank on returns
As it turns out, when we vt-switch Back to a running Enlightenment,
it ends up processing all outputs and causes Evas to create a giant
canvas to cover all outputs. This new canvas causes a blank screen as
the pageflipping fails (due to fb being too large). As we do not yet
support output on more an one screen anyway, temporarily disable any
output which is not marked as primary.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 27 Jul 2016 17:28:10 +0000 (13:28 -0400)]
ecore-drm2: Add API for vt-switching
This commit adds a function we can call from inside Enlightenment in
order to fix an issue with VT-Switching. The problem was when a client
application is open, the compositor does not pass along the key-combo
for vt-switch but rather sends it to an application. This patch (along
with upcoming Enlightenment one) fixes the issue.
NB: This late API add approved by Stefan ;)
@feature
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 27 Jul 2016 16:02:51 +0000 (12:02 -0400)]
elementary: Reduce variable usage
As we don't use the framespace x, y here then there is really no need
to have them.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 27 Jul 2016 15:12:23 +0000 (11:12 -0400)]
elementary: Fix issue of wrong minimum size for some E dialogs
When we are calculating minimum size hints for the window object, we
should be adding framespace to maximum size, not subtracting it...
Honestly this just looks like a brain-dead typo.
Fixes T44225
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Vitalii Vorobiov [Wed, 27 Jul 2016 12:14:26 +0000 (15:14 +0300)]
edje_edit: avoid such values like 2.77556e-17
using spinner to change double values means that sometimes
if set such weird values while should go to 0.0
@fix
Chris Michael [Wed, 27 Jul 2016 12:08:00 +0000 (08:08 -0400)]
elementary: Avoid possibly setting opaque region twice
Previously, if the window had no frame object, then this could would
have been setting opaque region twice (for the alpha case). We can
avoid this if we move the alpha check to below the frame check.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Jean-Philippe Andre [Wed, 27 Jul 2016 07:31:52 +0000 (16:31 +0900)]
elm: Fix extra mouse,in events in layout_content_unset
Problem: crash in assert() in terminology.
Scenario:
Open Terminology,
Split V by keyboard,
Move mouse to split 2,
Create tab by keyboard
--> abort() in terminology
Cause:
An extra mouse,in event happens during edje_object_unswallow
inside elm_layout_content_unset.
Root cause:
efl_part() in elm_layout had a side effect: edje_recalc on the
edje object. Causing its geometry to be "properly" defined and
the mouse event to trigger callbacks.
Solution:
Avoid calling recalc... somehow.
Conclusion:
Without adding any new API, edje edit provides internally the
information that we want: type of an edje part (for box & table).
Fixes T4221
See T4028
See T3509
Carsten Haitzler (Rasterman) [Wed, 27 Jul 2016 01:32:41 +0000 (10:32 +0900)]
efl - ecore-x - work around e's badness in makeing an x image for all wins
so e is being stupid and creating an ecore-x image forevery single
window if in x11 mode if it needs it or not. this results in having ti
allocate an actual x image and shm segments. work around this and get
bit order from somewhere else than the x image itself thus avoiding
the allocation until a real get or put is done.
@fix
Derek Foreman [Tue, 26 Jul 2016 17:34:27 +0000 (12:34 -0500)]
elput: Use correct filename in unlink
We switched from mkstemp to eina_file_mkstemp() but ended up unlinking
the template filename, which didn't exist on the filesystem.
Derek Foreman [Tue, 26 Jul 2016 17:22:36 +0000 (12:22 -0500)]
wayland_shm: Use correct filename in unlink
We switched from mkstemp to eina_file_mkstemp() but ended up unlinking
the template filename, which didn't exist on the filesystem.
Chris Michael [Tue, 26 Jul 2016 16:43:24 +0000 (12:43 -0400)]
ecore-wl2: Add safety check for valid compositor
As we cannot create a new wl_region without a valid compositor, add a
safety check.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Tue, 26 Jul 2016 10:55:41 +0000 (12:55 +0200)]
release: Update NEWS and bump version for 1.18.0-beta1 release
Chris Michael [Tue, 26 Jul 2016 14:55:31 +0000 (10:55 -0400)]
ecore-wl2: Remove error message during connect/reconnect
Since session recovery can cause apps to constantly try and reconnect
to the display server, we probably should not be filling logs here. On
the other hand, any failures on first connect are now not going to
display any error messages.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Vyacheslav Reutskiy [Tue, 26 Jul 2016 12:25:01 +0000 (15:25 +0300)]
edje_pick: copy block 'data'
Copy global data from files. Main resoan for it - elementary.
Elementary needs data "version" for load widget styles.
@fix
Stefan Schmidt [Tue, 26 Jul 2016 08:26:29 +0000 (10:26 +0200)]
edje: remove now unused variables
Commit
e3ed888aa994d96007da15be89649a92c12bcbae removed the code where these
variables have been used before.
Stefan Schmidt [Mon, 25 Jul 2016 22:08:33 +0000 (00:08 +0200)]
examples: edje: make sure we handle the various corner cases for the po files
Delete the earlier copied files only. Handles out of tree and in tree builds.
Jean-Philippe Andre [Tue, 26 Jul 2016 09:27:24 +0000 (18:27 +0900)]
edje: Remove invalid call to recalc in efl_part
What a mess... Assuming efl_part() had no side effect on the
object it took me hours to figure out that there was a wrong
call to _edje_recalc_do in the efl_part() function itself.
That was bad, and existed because efl_part() used to be
efl_content_get().
efl_part() should not have any side effect.
Also, fix a return value in content_remove.
Fixes T4214 (invalid redraw and crash in terminology).
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 07:49:03 +0000 (16:49 +0900)]
elm cnp windows - remove unused vars
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 07:44:10 +0000 (16:44 +0900)]
elm cnp win32 - do one side at least of unix newlines to windows newln
this PARTLY addresses T3556 ... this handles our own conversion of
makrup to string then to a windows newlined string. this half. i wrote
the conversion code for the other way but it's unused as i am unsure
where exactly to plug in it. following the cnp code makes me not sure
where it goes so for now - not there, but ready to go.
to be clear. out API is unix text. utf8 strings at our api with UNIX
newlines. that is our api. that is the text we accept and produce. if
you deal with another file or interface that does not provide this
then the job of conversion is AT THAT POINT. eg elm_cnp.c has to do
this. as would file loads of text files (and saves) etc. - anything
else like forgivingly handling anything at the api level makes it
totally unclear what our api is and what should go in and come out.
to be portable we have to define what it is and the most portable
thing to do is at the api level within a process we define one and
only one format. UNIX \n format.
@fix - partial
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 06:22:31 +0000 (15:22 +0900)]
efl ui image - fix view size get to NOT apply scaling
this fixes T3254
Subhransu Mohanty [Tue, 26 Jul 2016 05:31:44 +0000 (14:31 +0900)]
edje: fixed issue with applying transformation and stroke width
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4192
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 05:21:21 +0000 (14:21 +0900)]
edje examples - when you cp also just assume success if same file
fix makefiles for examples.... more
@fix
Subhransu Mohanty [Tue, 26 Jul 2016 02:45:13 +0000 (11:45 +0900)]
example/edje: updated vg example with interpolation usecase
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4191
Subhransu Mohanty [Tue, 26 Jul 2016 02:33:26 +0000 (11:33 +0900)]
edje: fixed issue with vector part state inheritance.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4190
Subhransu Mohanty [Tue, 26 Jul 2016 02:33:10 +0000 (11:33 +0900)]
example/evas: update evas vg example.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4189
Subhransu Mohanty [Tue, 26 Jul 2016 02:32:59 +0000 (11:32 +0900)]
efl/interface: fixed the shape interpolation implementation.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4188
Jean-Philippe Andre [Tue, 26 Jul 2016 02:09:43 +0000 (11:09 +0900)]
edje: Minor fix (return proper bool value)
Jean-Philippe Andre [Tue, 26 Jul 2016 01:47:40 +0000 (10:47 +0900)]
edje: Use eo_del instead of eo_unref where needed
This fixes the following error message:
Object '0x40000002f0000030' still has a parent at the time of destruction.
Though I actually wonder why ref == 0 and there was a parent.
Something is still a bit fishy here.
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 05:04:59 +0000 (14:04 +0900)]
edje examples - stop deleting the po files from the src tree!
whatever someones was trying to do.. they just endewd up deleting po
files in the src tree every time you clean! argh! fix!
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 04:59:54 +0000 (13:59 +0900)]
evas software x11 - be agressive with shm cache and keep it low
shm cache size is now 1.5x the total number of pixels in sw x11
outbutf's and that's it. 32 segment max limit too. this should keep
things down
@opt
Carsten Haitzler (Rasterman) [Tue, 26 Jul 2016 04:18:22 +0000 (13:18 +0900)]
evas and ecore_x shm segment management - fix over allocation and perms
so our sysv shm segments were both over-permissive (nothing bad
really, just other users could read and write to/from our pixel data
destined for the screen... they could do this to x11 directly anyway
so no real issue), but be more restrictive and use 0600 as xserver
runs as root so can read/write anyway and we only want our own uid
access. but even more - fix our shm segment flushing to not keep lots
of segments floating about like a bad smell when we don't need them.
we had a cache but it wasnt flushed when it should be since async
rendering turned up. this fixes that and we're back to agressively
flushing them out when idle.
@fix
Shinwoo Kim [Tue, 26 Jul 2016 02:03:32 +0000 (11:03 +0900)]
Revert "access: add an example of elm_object_part_access_object_get"
This reverts commit
f8aa67cd18e0f02368ca3aaedc159872feed459d.