Arun Raghavan [Sat, 17 Nov 2012 05:24:16 +0000 (10:54 +0530)]
build-sys: Bump soname
Arun Raghavan [Fri, 16 Nov 2012 17:43:26 +0000 (23:13 +0530)]
build-sys: Bump BlueZ dependency to 4.99
Since the old UNIX fd IPC mechanism was removed and we rely on the D-Bus
based API, this is the oldest version that is known to reliably work.
Arun Raghavan [Fri, 16 Nov 2012 17:39:15 +0000 (23:09 +0530)]
modules: Micro-optimisation for rewind_requested paths
Since some devices can be chatty with regards to how often they return
from poll(), this adds a PA_UNLIKELY() to all the the rewind_requested
checks in our sink modules to make the general case (no rewind was
requested) the fast path.
Tanu Kaskinen [Thu, 30 Aug 2012 13:50:13 +0000 (16:50 +0300)]
sink: Process rewind requests also when suspended.
When a rewind is requested on a sink input, the request parameters are
stored in the pa_sink_input struct. The parameters are reset during
rewind processing, and if the sink decides to ignore the rewind
request due to being suspended, stale parameters are left in
pa_sink_input. It's particularly problematic if the rewrite_bytes
parameter is left at -1, because that will prevent all future rewind
processing on that sink input. So, in order to avoid stale parameters,
every rewind request needs to be processed, even if the sink is
suspended.
Reported-by: Uoti Urpala
Arun Raghavan [Thu, 15 Nov 2012 10:21:52 +0000 (15:51 +0530)]
sink, source: Prevent unnecessary rate update attempts
We don't need to try a rate update if the desired sample rate is the
same as the one the sink or source is already using.
David Henningsson [Fri, 16 Nov 2012 12:16:04 +0000 (13:16 +0100)]
alsa-mixer: Prefer "Digital Input Source:Digital Mic 1"
...over "Digital Input Source:Analog Input". It makes life a little
easier for users of Dell xps m1330.
Just an old Ubuntu delta I never upstreamed until now.
The patch was originally written by Daniel T Chen <crimsun@ubuntu.com>.
BugLink: https://bugs.launchpad.net/bugs/453966
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Tanu Kaskinen [Mon, 2 Apr 2012 12:01:05 +0000 (15:01 +0300)]
mainloop: Don't care about the mainloop state variable when waking up the mainloop.
If the mainloop is just about to enter polling, but m->state
is not POLLING yet when some other thread calls
pa_mainloop_wakeup(), the mainloop will not be woken up.
It's safe to write to the wakeup pipe at any time, so let's
just remove the check.
Tanu Kaskinen [Mon, 2 Apr 2012 12:01:02 +0000 (15:01 +0300)]
mainloop: Change wakeup_requested type from pa_bool_t to pa_atomic_t.
The variable is accessed from multiple threads, so it should
be atomic.
David Henningsson [Fri, 9 Nov 2012 06:10:24 +0000 (07:10 +0100)]
alsa-mixer: Add "CLFE" and "Bass Speaker" names
These are sometimes being used in the HDA driver and we should
support them.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Arun Raghavan [Mon, 12 Nov 2012 16:54:52 +0000 (22:24 +0530)]
man: Correction for how sample rate switching is disabled
Setting to 0 in the parser causes daemon startup to fail.
Sjoerd Simons [Sat, 10 Nov 2012 16:41:27 +0000 (16:41 +0000)]
build-sys: Correct bluez support error if sbc is missing
David Henningsson [Fri, 9 Nov 2012 11:14:18 +0000 (12:14 +0100)]
alsa-mixer: Add a few more machines to internal mic whitelist
Based on feedback in the bug below (comments 128, 129, 131).
BugLink: https://bugs.launchpad.net/bugs/946232
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Tanu Kaskinen [Wed, 7 Nov 2012 14:52:37 +0000 (16:52 +0200)]
pulse: Fix hole handling in pa_stream_peek().
Previously, if there was a hole in a recording stream,
pa_stream_peek() would crash. Holes could be handled silently inside
pa_stream_peek() by generating silence (wouldn't work for compressed
streams, though) or by skipping any holes. However, I think it's
better to let the caller decide how the holes should be handled, so
in case of holes, pa_stream_peek() will return NULL data pointer and
the length of the hole in the nbytes argument.
This change is technically an interface break, because previously the
documentation didn't mention the possibility of holes that need
special handling. However, since holes caused crashing anyway in the
past, it's not a regression if applications keep misbehaving due to
not handing holes properly.
Some words about when holes can appear in recording streams: I think
it would be reasonable behavior if overruns due to the application
reading data too slowly would cause holes. Currently that's not the
case - overruns will just cause audio to be skipped. But the point is
that this might change some day. I'm not sure how holes can occur
with the current code, but as the linked bug shows, they can happen.
It's most likely due to recording from a monitor source where the
thing being monitored has holes in its playback stream.
BugLink: http://bugs.launchpad.net/bugs/1058200
Arun Raghavan [Thu, 8 Nov 2012 09:23:55 +0000 (14:53 +0530)]
introspect: Minor documentation fix
s/pa_latency_info/pa_timing_info
Pierre-Louis Bossart [Mon, 30 Jul 2012 00:46:59 +0000 (19:46 -0500)]
alsa: get avail, delay, timestamps in a single kernel call
Refactor code to fetch avail, delay and timestamp values
in a single call to snd_pcm_status().
The information reported is exactly the same as before,
however it is extracted in a more atomic manner to
improve timer-based scheduling.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Arun Raghavan [Mon, 5 Nov 2012 12:11:53 +0000 (17:41 +0530)]
Revert "tests: modify alsa-time-test to use 'check' framework"
This reverts commit
1569601864af375c3788fbce429b6773bd48072e.
Rethinking this, it makes more sense to not add this to the check
framework. This is mostly useful for exposing ALSA driver issues, and
it's handy to be able to build this as a standalone executable.
Arun Raghavan [Mon, 5 Nov 2012 12:11:19 +0000 (17:41 +0530)]
alsa: Drop verbosity on UCM message
We don't need to log an error-level message for missing UCM config.
Deng Zhengrong [Thu, 19 Jul 2012 08:41:31 +0000 (16:41 +0800)]
build: fix Mac OS X configure process
The original header file doesn't exist on Lion (10.7.4).
Frédéric Dalleau [Wed, 22 Aug 2012 13:42:16 +0000 (15:42 +0200)]
resampler: Fix crash if 'auto' resampler chooses ffmpeg with variable rate
To reproduce, add resampler-method = ffmpeg in daemon.conf
then start PA, and load module-loopback
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb2f1db40 (LWP 23047)]
0x00000000 in ?? ()
(gdb) bt
0 0x00000000 in ?? ()
1 0xb7c463cb in pa_resampler_set_input_rate (r=0x80e9438, rate=44011) at pulsecore/resampler.c:365
2 0xb7c6321d in pa_sink_input_process_msg (o=0x80e87a0, code=3, userdata=0xabeb, offset=0, chunk=0x0)
at pulsecore/sink-input.c:1833
3 0xb7e9840b in sink_input_process_msg_cb (obj=0x80e87a0, code=3, data=0xabeb, offset=0, chunk=0x0)
at modules/module-loopback.c:538
4 0xb7c2709b in pa_asyncmsgq_dispatch (object=0x80e87a0, code=3, userdata=0xabeb, offset=0, memchunk=0xb2f1d17c)
at pulsecore/asyncmsgq.c:322
5 0xb7c4c6e3 in asyncmsgq_read_work (i=0x80dd580) at pulsecore/rtpoll.c:564
6 0xb7c4b34a in pa_rtpoll_run (p=0x80fb7e0, wait_op=true) at pulsecore/rtpoll.c:238
7 0xb7dd90af in thread_func (userdata=0x80afe88) at modules/alsa/alsa-sink.c:1785
8 0xb7bf3291 in internal_thread_func (userdata=0x8095d08) at pulsecore/thread-posix.c:83
9 0xb7ab9d4c in start_thread (arg=0xb2f1db40) at pthread_create.c:308
10 0xb79f3ace in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130
Tanu Kaskinen [Sat, 6 Oct 2012 11:42:46 +0000 (14:42 +0300)]
build: Add PROTOCOL to EXTRA_DIST.
It's useful documentation, no reason to leave it out of the tarball.
Tanu Kaskinen [Tue, 23 Oct 2012 15:55:42 +0000 (18:55 +0300)]
device-restore: When restoring volume, print the restored volume to the log.
Tanu Kaskinen [Sat, 6 Oct 2012 12:05:08 +0000 (15:05 +0300)]
build: Add .gitignore files to EXTRA_DIST.
As a packager, I want to be able to do "git format-patch
v3.0..origin/master" and I want the generated patches to apply cleanly
against the 3.0 tarball. The patches don't currently apply cleanly if
there are any changes to the .gitignore files, because the .gitignore
files are not shipped in the tarball. This patch fixes that problem.
Wieland Hoffmann [Wed, 31 Oct 2012 17:50:24 +0000 (18:50 +0100)]
man pulse-daemon.conf: Correct typoes
Arun Raghavan [Sat, 3 Nov 2012 10:50:10 +0000 (11:50 +0100)]
build-sys: Document libpulsecommon vs. libpulse duplication
Arun Raghavan [Sat, 3 Nov 2012 09:52:35 +0000 (10:52 +0100)]
i18n: Fix POTFILES for poll changes
poll.c was moved to poll-posix.c and poll-win32.c was added for the
Windows port.
Arun Raghavan [Sat, 3 Nov 2012 09:44:42 +0000 (10:44 +0100)]
build-sys: Bump soname
Arun Raghavan [Sat, 3 Nov 2012 09:29:20 +0000 (10:29 +0100)]
Revert "core: adjust playing_for and underrun_for at rewind"
This reverts commit
5bc6cadcb2e7255fd333ed88cc80b61a7673ddd9.
I wasn't meaning to push this out - just merged for review / testing.
Uoti Urpala [Sat, 28 Jul 2012 20:51:46 +0000 (23:51 +0300)]
core: adjust playing_for and underrun_for at rewind
A rewind may erase data that sink_input counted in playing_for or
underrun_for earlier. Add code adjusting those values after a rewind.
One visible symptom of this bug was problems recovering from an
underrun. When a client calls pa_stream_write() with a large block of
memory, the function can split that into smaller pieces before sending
it to the server. When receiving new data for a stream that had
silence queued due to underrun, the server would do a rewind to
replace the queued-but-not-played silence with the new data. Because
of the bug, this rewind itself would not change underrun_for. It's
possible for multiple rewinds to be done without filling the sink
buffer in between (which is what would eventually reset underrun_for).
In this case, the server rapidly processing the split packets would
rewind the stream for _each_ of them (as underrun_for would stay set),
erasing valid audio as a result.
Arun Raghavan [Tue, 30 Oct 2012 06:34:42 +0000 (12:04 +0530)]
svolume: Fix ARM alignment issues
As Peter Meerwald <p.meerwald@bct-electronic.com> discovered, our ARM
svolume code performance is quite terrible when the incoming samples are
not word-aligned. This can very easily be the case, since the
architecture only requires that the samples be 16-bit aligned, and we
might end up running the innermost loop after processing modulo-4
samples. The performance degradation was ~50x on a Cortex A9
(Pandaboard).
This reworks the svolume logic to first consume enough samples to make
sure the rest is word aligned, and reordering the processing to work
with 4 samples at a time first, and then finally deal with the
remainder.
With this, performance is comparable for arbitrary alignments (~3x
faster than the C code).
Arun Raghavan [Tue, 30 Oct 2012 14:58:24 +0000 (20:28 +0530)]
tests: Minor alignment adjustment fix for cpu-test
Tanu Kaskinen [Thu, 27 Sep 2012 13:41:59 +0000 (16:41 +0300)]
match: Use the SINK_INPUT_FIXATE hook instead of NEW.
The callback relies on the sample spec being finalized, which is not
true with the NEW hook.
In case you're wondering about the "hook EARLY - 1, to match before
stream-restore" comment that was not changed even though the code that
the comment concerned was changed: the comment was apparently written
at a time when module-stream-restore used the NEW hook too, and later
stream-restore has been changed to use the FIXATE hook. So, the
comment was wrong/nonsensical before this patch. Since these two
modules now use the same hook again, the comment makes sense again.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=55135
Tanu Kaskinen [Thu, 20 Sep 2012 06:42:18 +0000 (09:42 +0300)]
combine: Keep the timer active in the null mode only when running.
Previously thread_func() used PA_SINK_IS_OPENED() to check whether
some data should be rendered. process_render_null() used a different
check: it would return immediately if the sink was not in the RUNNING
state. This caused a busy loop when the sink was in the IDLE state,
because process_render_null() didn't update the timestamp, and
thread_func() still kept the timer active using the old timestamp.
pa_rtpoll_run() would return immediately because of the old timestamp.
This is fixed by using the same check in both thread_func() and
process_render_null(). Since the checks are the same, it's actually
redundant to have the check in process_render_null(), so it is now an
assertion.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=54779
Tanu Kaskinen [Wed, 22 Aug 2012 06:00:25 +0000 (09:00 +0300)]
virtual-surround-sink: Fix setting max_request and max_rewind.
The sink has different frame size than the sink input, so
the max_request and max_rewind values of the sink input need
to be converted when setting the sink max_request and
max_rewind values.
The conversion is already done correctly in
sink_input_update_max_request_cb() and
sink_input_update_max_rewind_cb().
Tanu Kaskinen [Tue, 14 Aug 2012 14:08:35 +0000 (17:08 +0300)]
loopback: Don't fix the source output format/rate/channels.
Once the sink input has been routed in pa_sink_input_new(),
the sample spec and channel map have already become fixed.
The sink input and source output must use the same stream
format, because the data is copied as-is.
Tanu Kaskinen [Tue, 14 Aug 2012 14:08:34 +0000 (17:08 +0300)]
loopback: Use the real sample spec once it's known.
When module-loopback is loaded without arguments, the ss and
map variables are initialized with dummy values. This caused
a problem, because also pa_memblockq_new() was called with
the dummy values, making it work incorrectly. The base was
set to 1 instead of the real frame size, which in turn
caused alignment related crashes.
Tanu Kaskinen [Mon, 9 Jul 2012 07:07:05 +0000 (10:07 +0300)]
resampler: Make sure that there are no overflows when multiplying potentially big numbers.
This fixes at least one crash that has been observed. The
multiplication in trivial_resample() overflowed when
resampling from 96 kHz to 48 kHz, causing an assertion
error:
Assertion 'o_index * fz < pa_memblock_get_length(output->memblock)' failed at pulsecore/resampler.c:1521, function trivial_resample(). Aborting.
Without the assertion, the memcpy() after the assertion
would have overwritten some random heap memory.
Tanu Kaskinen [Sat, 28 Apr 2012 15:54:11 +0000 (18:54 +0300)]
memblockq: Fix the order of setting minreq and prebuf.
Thomas Martitz [Tue, 30 Oct 2012 10:35:26 +0000 (11:35 +0100)]
core-util: Don't error out on existing runtime directory.
When compiling without HAVE_SYMLINK the runtime dir is a real directory,
which is attempted to be created. In the case it already exists we shouldn't
error out. The HAVE_SYMLINK-enabled code already does this.
Thomas Martitz [Tue, 30 Oct 2012 10:35:24 +0000 (11:35 +0100)]
core: Proper poll() emulation to fix pacat and friends on Windows
Currently, Windows versions of pacat and friends fail because the current
poll emulation is not sufficient (it only works for socket fds).
Luckily Gnulib has a much better emulation that seems to work good enough.
The implementation has been largely copied (except a few bug fix
regarding timeout handling, to be pushed upstream) and works on pipes
and files as well. The copy has been obtained through their gnulib-tool utility,
which gives a LGPLv2.1+ licensed file.
This fixes the "Assertion (!e->dead) failed" error coming and lets pacat
and friends stream happily to/from a server (I didn't actually test parec).
Arun Raghavan [Tue, 30 Oct 2012 06:08:01 +0000 (11:38 +0530)]
build-sys: Drop -Wvla from compiler flags
Since we mandate C99 support, not reason to keep this around.
Arun Raghavan [Tue, 30 Oct 2012 06:07:06 +0000 (11:37 +0530)]
tests: Fix a cpu-test debug message
We align at sample granularity and not byte granularity (which might
violate arch alignment requirements).
Arun Raghavan [Tue, 30 Oct 2012 06:00:16 +0000 (11:30 +0530)]
tests: Run svolume on different channel counts
This adds checks to run svolume tests with 1, 2 and 3 channels (we don't
run Orc with 3 channels since only 1/2-ch are implemented there).
Arun Raghavan [Tue, 30 Oct 2012 05:54:33 +0000 (11:24 +0530)]
tests: Make cpu-test less verbose
Drops the correctness debug output since we want to run this several
times, and the output becomes much more verbose than required.
Arun Raghavan [Tue, 30 Oct 2012 04:00:32 +0000 (09:30 +0530)]
tests: Run svolume test for various sample alignments
Allows us to make sure that svolume works independently of sample
alignment, and that performance doesn't degrade based on this.
Arun Raghavan [Mon, 29 Oct 2012 12:02:32 +0000 (17:32 +0530)]
core: Fix warning on non-win32 builds
Tanu Kaskinen [Sat, 6 Oct 2012 11:43:07 +0000 (14:43 +0300)]
build: Add a2dp-codecs.h to libbluetooth-util sources.
Arun Raghavan [Mon, 29 Oct 2012 09:10:00 +0000 (14:40 +0530)]
tests: Minor cpu-test fixes for non-NEON builds
The s16->float test is only run on ARM with NEOn at the moment, so we
don't define that code in other cases.
Arun Raghavan [Mon, 29 Oct 2012 07:56:25 +0000 (13:26 +0530)]
tests: Print average outer-loop iteration time in cpu-test
Arun Raghavan [Fri, 26 Oct 2012 11:15:32 +0000 (16:45 +0530)]
tests: Increase sconv cpu-test timeout
This takes longer on ARM CPUs, especially older ones.
Arun Raghavan [Fri, 26 Oct 2012 11:09:11 +0000 (16:39 +0530)]
tests: Allow off-by-one error in sconv test
With some optimised sconv implementations (read NEON), rounding
inaccuracy might lead to a difference of 1 with the reference
implementation. The inaccuracy is worth the performance gain.
Also increases floating-point accuracy while printing errors to make
errors easier to analyse.
Arun Raghavan [Fri, 26 Oct 2012 11:06:49 +0000 (16:36 +0530)]
sconv: Fix NEON sconv rounding code
Rounding with 0.5 causes us to always round up for any value of the form
x.5. IEEE754 specifies round-to-nearest-even as the behaviour in this
case. This might not always be possible with NEON code, but this change
gets us much closer to it.
Peter Meerwald [Sat, 27 Oct 2012 12:59:43 +0000 (14:59 +0200)]
tests: Implement test code for ARM NEON sconv s16_to_float
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Fri, 26 Oct 2012 11:04:47 +0000 (13:04 +0200)]
tests: Fix test description in cpu-test
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Tue, 23 Oct 2012 15:54:57 +0000 (17:54 +0200)]
core: Add ARM NEON optimized sample conversion code
final:
* includes some minor style fixes and build-time changes to allow
building a single binary for neon and non-neon systems
v4:
* fix for sample length < 4
v3:
* convert from intrinsics to inline assembly
v2:
* load and store data with vld1/vld1q and vst1/vst1q, resp., to work
around alignment issues of compiler-generated vldmia instruction
* remove redundant check for NEON flags
Ubuntu/Linaro gcc 4.6.3
arm-linux-gnueabi-gcc -O2 -mcpu=cortex-a8 -mfloat-abi=softfp -mfpu=neon
runtime on beagle-xm:
D: [pulseaudio] sconv_neon.c: checking NEON sconv_s16le_from_float
I: [pulseaudio] sconv_neon.c: NEON: 3754 usec.
I: [pulseaudio] sconv_neon.c: ref: 58594 usec.
D: [pulseaudio] sconv_neon.c: checking NEON sconv_s16le_to_float
I: [pulseaudio] sconv_neon.c: NEON: 1831 usec.
I: [pulseaudio] sconv_neon.c: ref: 10528 usec.
I: [pulseaudio] sconv_neon.c: Initialising ARM NEON optimized conversions.
conversion may be off by one for some samples due to rounding issues
Arun Raghavan [Fri, 26 Oct 2012 03:11:08 +0000 (08:41 +0530)]
build-sys: Add volume code to libpulsecommon
Commit
dd31d652a ("utils: Adding a function to get volume from string")
uses pa_sw_volume_from_dB(), which is part of libpulse, in libpulsecore.
This breaks as-needed builds. We fix this by also building the volume
code in libpulsecommon.
Tanu Kaskinen [Fri, 29 Jun 2012 15:04:55 +0000 (18:04 +0300)]
card: Store a pa_card pointer in pa_card_profile.
Mikel Astiz [Tue, 23 Oct 2012 14:41:59 +0000 (16:41 +0200)]
bluetooth: Add hook to announce late UUIDs
UUIDs might be announced at any time, so a hook is needed to notify any
interested module. In practice, the UUIDs are quite stable with the
exception of the pairing procedure, where the UUIDs are reported by
BlueZ as soon as they are discovered.
Mikel Astiz [Tue, 23 Oct 2012 14:41:56 +0000 (16:41 +0200)]
card: Support adding ports dynamically
Card profiles -specially the ones registered with pa_card_add_profile()-
might need to create new ports during the lifetime of the card.
Mikel Astiz [Tue, 23 Oct 2012 14:41:55 +0000 (16:41 +0200)]
card: Support adding profiles dynamically
Some cards might need to add profiles during their lifetime, that is,
after the card has been created.
Flavio Ceolin [Wed, 24 Oct 2012 19:29:45 +0000 (17:29 -0200)]
utils: Adding a function to get volume from string
The allowed volume formats are dB, % or integer.
For example: 10% or 10db or 10.
Arun Raghavan [Wed, 24 Oct 2012 07:18:02 +0000 (12:48 +0530)]
tests: Run sconv tests with multiple alignments
This allows us to test the sconv code with the incoming samples at
various byte alignments. The test is also now split into correctness and
performance checks.
David Henningsson [Tue, 16 Oct 2012 09:35:00 +0000 (11:35 +0200)]
alsa-mixer: Don't let "Mic Jack Mode" alone create a "Line In" path
The IDT/Sigmatel codec driver often creates a "Mic Jack Mode" for
every mic jack, so it can change functionality between Mic and Line In.
However, as the "Mic Jack" is the standard naming, our current solution
does not make the Line In port unavailable when nothing is plugged in.
This patch makes the "Line In" port not to be created just because there
is a "Mic Jack Mode" that could be set to "Line". This makes the behaviour
consistent with e g "Dock Mic Jack Mode", "Front Mic Jack Mode" etc, where
we don't create a "Dock Line" or "Dock Mic" port either.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Peter Meerwald [Tue, 23 Oct 2012 15:37:24 +0000 (17:37 +0200)]
rtp: Fix warning using pa_assert_not_reached()
modules/rtp/module-rtp-recv.c:462:8: warning: 'r' may be used uninitialized in this function [-Wuninitialized]
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Niels Ole Salscheider [Fri, 5 Oct 2012 19:46:49 +0000 (21:46 +0200)]
virtual-surround: Limit the number of hrir samples.
v2: better log message
Niels Ole Salscheider [Fri, 5 Oct 2012 19:46:48 +0000 (21:46 +0200)]
virtual-surround: Add silence to hrir if necessary.
Otherwise, the hrir might be too short to get completely resampled
v2: take different sample rates into account
Flavio Ceolin [Thu, 9 Aug 2012 18:52:52 +0000 (15:52 -0300)]
pulse: Fix for volume documentation
Fixing the documentation for the function pa_cvolume_dec().
Arun Raghavan [Tue, 23 Oct 2012 12:59:27 +0000 (18:29 +0530)]
tests: Add a basic sanity test to sconv cpu-test
This seems redundant with the previous check in that function, but it
makes sure that the result of the speed comparison is what we think it
is.
Arun Raghavan [Tue, 23 Oct 2012 12:56:39 +0000 (18:26 +0530)]
tests: Reorganise cpu-test to reuse code
This factors out the basic measurement code for each test into a
separate block so that each test can be broken down into a basic
correctness test, and a performance comparison with minimum effort.
Arun Raghavan [Tue, 23 Oct 2012 09:58:47 +0000 (15:28 +0530)]
tests: Factor out core sconv test code in cpu-test
This will let us add tests for non-SSE sconv tests.
Arun Raghavan [Tue, 23 Oct 2012 09:58:26 +0000 (15:28 +0530)]
tests: Add a copyright header to cpu-test
Tanu Kaskinen [Thu, 29 Mar 2012 13:03:59 +0000 (16:03 +0300)]
rtp: Fix rtp_port reading.
pa_atou() return value was not checked, and the cast of a
16-bit variable pointer to a 32-bit variable pointer could
corrupt cseq.
Thomas Martitz [Tue, 23 Oct 2012 10:10:45 +0000 (12:10 +0200)]
gccmacro: Disable printf-like format checking on mingw32 compilers.
Am 23.10.2012 08:25, schrieb Arun Raghavan:
> On Tue, 2012-08-21 at 13:32 +0200, Thomas Martitz wrote:
>> Am 21.08.2012 08:51, schrieb Rémi Denis-Courmont:
>>> Le mardi 21 août 2012 00:50:34 Thomas Martitz, vous avez écrit :
>>>> There are tons of warnings, most of them because the function is not
>>>> recognized as printf-like.
>>> Removing checks looks very fishy.
>>>
>>> To use C99 and/or GNU format specifiers on MingW, you need to use the
>>> gnuprintf attribute instead of printf. With printf, the format string is
>>> validated according to the antiquated MSVC rules.
>>>
>> Interesting, I didn't know about gnuprintf. FWIW, what are those
>> antiquated MSVC rules? I assumed the return value which isn't int for
>> some affected functions?
> Is this one going to be respun?
>
Yes, here you go.
>From
c5f15eec69bf95c9a1261e0d82abbd039156e75e Mon Sep 17 00:00:00 2001
From: Thomas Martitz <kuge@rockbox.org>
Date: Wed, 8 Aug 2012 17:38:04 +0200
Subject: [PATCH 1/3] gccmacro: Work around warnings due to printf redirection
by libintl.
Libintl defines printf as libintl_printf, which breaks the format
attribue. Unfortunately the workaround around provided by libintl
is only enabled for cygwin, but not for mingw builds. Therefore
install the workaround manually.
Mikel Astiz [Mon, 22 Oct 2012 08:46:42 +0000 (10:46 +0200)]
bluetooth: Refactor code to create profile ports
Put the created ports in a hashmap, but not necessarily inside a struct
pa_card_new_data.
Mikel Astiz [Mon, 22 Oct 2012 08:46:41 +0000 (10:46 +0200)]
bluetooth: Refactor code to create card profiles
Use a helper function to create the card profiles, given an UUID.
Peter Meerwald [Mon, 22 Oct 2012 21:48:27 +0000 (23:48 +0200)]
echo-cancel: Fix false warning in webrtc AEC.
CXX libwebrtc_util_la-webrtc.lo
modules/echo-cancel/webrtc.cc: In function 'pa_bool_t pa_webrtc_ec_init(pa_core*, pa_echo_canceller*, pa_sample_spec*, pa_channel_map*, pa_sample_spec*, pa_channel_map*, uint32_t*, const char*)':
modules/echo-cancel/webrtc.cc:196:9: warning: 'rm' may be used uninitialized in this function [-Wuninitialized]
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Mon, 22 Oct 2012 21:43:53 +0000 (23:43 +0200)]
svolume_arm: Fix a const warning.
CC libpulsecore_2.98_la-svolume_arm.lo
pulsecore/svolume_arm.c: In function 'pa_volume_s16ne_arm':
pulsecore/svolume_arm.c:50:8: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Thomas Martitz [Mon, 20 Aug 2012 21:50:39 +0000 (23:50 +0200)]
core: Slightly more helpful pa_cstrerror for unknown errors
On Windows, strerror can actually return "Unknown Error"
(e.g. for large errnums). The code assumes the return value to be helpful.
Make it slightly more helpful by catching the message and appending the
errnum.
Thomas Martitz [Mon, 20 Aug 2012 21:50:38 +0000 (23:50 +0200)]
pacat: Replace read(), write() with pa_* equivalent.
Calling pa_read() and pa_write() seems more appropriate since they deal better
with platform specific issues. This doesn't actually fix any open issue since
only stdio is affected but it seems more future proof.
Thomas Martitz [Mon, 20 Aug 2012 21:50:37 +0000 (23:50 +0200)]
core: Transparently handle non-blocking sockets on Windows
On Windows, fdsem.c:flush() fails because sockets are set to non-blocking
mode, since pa_read() returns -1 (and errno == EWOULDBLOCK). I guess pa_read()
is expected to block in this case so make it actually block by calling poll().
Thomas Martitz [Mon, 20 Aug 2012 21:50:35 +0000 (23:50 +0200)]
pacat: Enable binary mode on Windows.
Without this reading from stdin will eventually end with EOF (if there happens
to be a newline sign in the stream), because read() returns 0.
This patch fixes raw data input and piping to pacat on Windows.
Mikel Astiz [Mon, 22 Oct 2012 08:46:39 +0000 (10:46 +0200)]
bluetooth: Hold device pointer while module loaded
Instead of repeatedly asking the discovery API to find a device given
our device path, let's hold a pointer to the device and make sure we
remove the reference when the hook is fired reporting that the device
has been removed. This makes the code easier to follow and slightly
more efficient.
Mikel Astiz [Mon, 22 Oct 2012 08:46:38 +0000 (10:46 +0200)]
bluetooth: Self unload module-bluetooth-device
If the device has been removed, unload the module without depending on
module-bluetooth-discovery.
Mikel Astiz [Mon, 22 Oct 2012 08:46:37 +0000 (10:46 +0200)]
bluetooth: Add hook to tell device was removed
Add a hook to report that the device was removed, and thus references to
it should be released.
Mikel Astiz [Mon, 22 Oct 2012 08:46:36 +0000 (10:46 +0200)]
bluetooth: Remove const qualifier for device
The internal API in bluetooth-util should not use the const qualifier
for operations involving a device object. After all, the structure
contains many pointers and thus the const qualifier provides no real
protection.
David Henningsson [Mon, 22 Oct 2012 08:53:32 +0000 (10:53 +0200)]
alsa-sink/source: Warn for scheduling delays
Sometimes the kernel does not schedule us in due time, thus causing
an underrun. Adding a detection and a debug message will be a helpful
step in determining the cause of an underrun.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Peter Meerwald [Tue, 10 Jul 2012 12:44:03 +0000 (14:44 +0200)]
daemon: Fix redundant redeclaration warning
CC pulseaudio-dumpmodules.o
daemon/dumpmodules.c:93:27: warning: redundant redeclaration of ‘lt__PROGRAM__LTX_preloaded_symbols’ [-Wredundant-decls]
/usr/include/ltdl.h:106:36: note: previous declaration of ‘lt__PROGRAM__LTX_preloaded_symbols’ was here
the declaration is provided by ltld.h of libtool since version 2.4, require the 2.4 instead of 2.2
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Flavio Ceolin [Tue, 9 Oct 2012 18:16:29 +0000 (15:16 -0300)]
modargs: New function: pa_modargs_get_value_double().
Mikel Astiz [Fri, 19 Oct 2012 08:11:28 +0000 (10:11 +0200)]
bluetooth: Hold transport pointer while profile set
Instead of repeatedly asking the discovery API to find a transport given
our transport path, let's hold a pointer to the transport and make sure
we remove the reference when the hook is fired reporting that the
transport has been removed. This makes the code easier to follow and
slightly more efficient.
Mikel Astiz [Fri, 19 Oct 2012 08:11:27 +0000 (10:11 +0200)]
bluetooth: Set to off instead of failing module load
If the profile setup fails during module load, the fallback should be
setting the profile to off, exactly as it is done in card_set_profile().
Mikel Astiz [Fri, 19 Oct 2012 08:11:26 +0000 (10:11 +0200)]
bluetooth: Set to off if transport removed
The recently added hook can be used to detect that the transport being
used has been removed. In this case, the profile needs to be set to off.
Additionally, the change fixes a significant problem: without this
transition, the transport could be destroyed while the hook slots (i.e.
nrec_changed_slot) were still set. This led to a double free of these
objects in stop_thread().
Mikel Astiz [Fri, 19 Oct 2012 08:11:25 +0000 (10:11 +0200)]
bluetooth: Add hook to tell transport was removed
Add a hook to report that the transport was removed from D-Bus, and thus
references to it should be released.
Mikel Astiz [Fri, 19 Oct 2012 08:11:24 +0000 (10:11 +0200)]
bluetooth: Remove const qualifier for transports
The internal API in bluetooth-util should not use the const qualifier
for operations modifying the transport object. This is specially useful
in order to use the available hooks.
Mikel Astiz [Fri, 19 Oct 2012 08:11:23 +0000 (10:11 +0200)]
bluetooth: Check return value of start_thread()
The function can return an error, so in that case the profile change
should fail.
Mikel Astiz [Fri, 19 Oct 2012 08:11:22 +0000 (10:11 +0200)]
bluetooth: Check return value of init_profile()
If profile could not be successfully initialized, the card should be
set to PROFILE_OFF automatically. If sinks or sources exist, they need
to be destroyed, therefore stop_thread() is called.
Mikel Astiz [Fri, 19 Oct 2012 08:11:21 +0000 (10:11 +0200)]
bluetooth: Use assertions when setting off profile
Setting the card profile to off cannot fail, therefore assertions can be
used when calling pa_card_set_profile().
Arun Raghavan [Thu, 18 Oct 2012 05:13:17 +0000 (10:43 +0530)]
core: Fix a litte-endian bug in ARM svolume code
The old code seems to be written for big-endian code.
Arun Raghavan [Thu, 18 Oct 2012 05:12:48 +0000 (10:42 +0530)]
core: Document ARM-optimised svolume code a bit
Arun Raghavan [Fri, 19 Oct 2012 13:13:17 +0000 (18:43 +0530)]
tests: Minor cpu-test reorganisation
Make volume and conversion tests separate test cases.
Arun Raghavan [Tue, 16 Oct 2012 06:53:19 +0000 (12:23 +0530)]
tests: Factor out ARM svolume test into cpu-test
This allows us to run the testing code separately from the PulseAudio
daemon, which makes developing / regression testing this code a lot
easier.
Arun Raghavan [Tue, 16 Oct 2012 06:30:19 +0000 (12:00 +0530)]
core: Separate ARM CPU detection from initialisation
This separate the ARM CPU feature detection code from the initialisation
so that we can reuse it in tests, like we did for x86 a while back.