Simon Pilgrim [Sat, 12 Feb 2022 11:04:20 +0000 (11:04 +0000)]
[clang-tidy] FunctionASTVisitor::TraverseStmt - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is referenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sat, 12 Feb 2022 10:57:09 +0000 (10:57 +0000)]
[clang-tidy] NoexceptMoveConstructorCheck::check - use castAs<> instead of getAs<> to avoid dereference of nullptr
The pointer is referenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sat, 12 Feb 2022 10:51:48 +0000 (10:51 +0000)]
[clang-tidy] UseNoexceptCheck::check - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is referenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sat, 12 Feb 2022 10:49:54 +0000 (10:49 +0000)]
[clang-tidy] getOutermostNamespace - remove redundant nullptr check
The pointer is always dereferenced
Simon Pilgrim [Sat, 12 Feb 2022 10:43:21 +0000 (10:43 +0000)]
[clang-tidy] ProBoundsConstantArrayIndexCheck::check - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is referenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sat, 12 Feb 2022 10:41:43 +0000 (10:41 +0000)]
[clang-tidy] checkOverridingFunctionReturnType - use castAs<> instead of getAs<> to avoid dereference of nullptr
The pointers are referenced immediately, so assert the cast is correct instead of returning nullptr
Douglas Yung [Sat, 12 Feb 2022 07:42:29 +0000 (23:42 -0800)]
Revert "try to fix windows build after
73e585e44d" and
Revert "Reland "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:""
This reverts commit
0574b5fc657451c9d13d3f6d8fe14ea15c23a681 and
73e585e44d68cf77e2e3274e98c9615156a7d909.
This change is causing the test Driver/cl-options.c to fail on Windows buildbots.
https://lab.llvm.org/staging/#/builders/204/builds/1343
Haocong.Lu [Sat, 12 Feb 2022 07:14:31 +0000 (07:14 +0000)]
[RISCV] LUI used for address computation should not isAsCheapAsAMove
A LUI instruction with flag RISCVII::MO_HI is usually used in conjunction
with ADDI, and jointly complete address computation. To bind the cost
evaluation of address computation, the LUI should not be regarded as a cheap
move separately, which is consistent with ADDI.
In this test case, it improves the unroll-loop code that the rematerialization
of array's base address miss MachineCSE with Heuristics #1 at isProfitableToCSE.
Reviewed By: asb, frasercrmck
Differential Revision: https://reviews.llvm.org/D118216
Haocong.Lu [Sat, 12 Feb 2022 06:28:36 +0000 (06:28 +0000)]
[RISCV][test] Precommit a test of CSE within an unroll loop
Reviewed By: asb, frasercrmck
Differential Revision: https://reviews.llvm.org/D118218
Siva Chandra Reddy [Sat, 12 Feb 2022 06:14:46 +0000 (06:14 +0000)]
[libc][Obvious][NFC] Move CPP tests to the correct nested directory.
Jez Ng [Sat, 12 Feb 2022 03:24:09 +0000 (22:24 -0500)]
[lld-macho] Unset ExportDynamic where possible for LTO
By unsetting this property, we are now able to internalize more symbols
during LTO. I compared the output of `-save-temps` for both LLD and
ld64, and we now match ld64's behavior as far as `lto-internalize.ll` is
concerned.
(Thanks @smeenai for working on an initial version of this diff!)
Fixes https://github.com/llvm/llvm-project/issues/50574.
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D119372
Micah Weston [Sat, 12 Feb 2022 03:11:50 +0000 (03:11 +0000)]
[AArch64] Adds SUBS and ADDS instructions to the MIPeepholeOpt.
Implements ADDS/SUBS 24-bit immediate optimization using the
MIPeepholeOpt pass. This follows the pattern:
Optimize ([adds|subs] r, imm) -> ([ADDS|SUBS] ([ADD|SUB] r, #imm0, lsl #12), #imm1),
if imm == (imm0<<12)+imm1. and both imm0 and imm1 are non-zero 12-bit unsigned
integers.
Optimize ([adds|subs] r, imm) -> ([SUBS|ADDS] ([SUB|ADD] r, #imm0, lsl #12), #imm1),
if imm == -(imm0<<12)-imm1, and both imm0 and imm1 are non-zero 12-bit unsigned
integers.
The SplitAndOpcFunc type had to change the return type to an Opcode pair so that
the first add/sub is the regular instruction and the second is the flag setting
instruction. This required updating the code in the AND case.
Testing:
I ran a two stage bootstrap with this code.
Using the second stage compiler, I verified that the negation of an ADDS to SUBS
or vice versa is a valid optimization. Example V == -0x111111.
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D118663
Chenbing.Zheng [Sat, 12 Feb 2022 02:52:12 +0000 (02:52 +0000)]
[RISCV][NFC] Move some combine patterns to DAG combine.
Move some combine patterns to DAG combine,and
it dealt with fixme left in RISCVInstrInfoZb.td.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D119527
Florian Mayer [Sat, 12 Feb 2022 00:33:01 +0000 (16:33 -0800)]
[HWASAN] regression test we do not instrument dynamic allocas
Reviewed By: browneee
Differential Revision: https://reviews.llvm.org/D119606
Peter Klausler [Tue, 8 Feb 2022 21:39:59 +0000 (13:39 -0800)]
[flang] Fix edge case in USE-associated generics
It is generally an error when a USE-associated name clashes
with a name defined locally, but not in all cases; a generic
interface can be both USE-associated and locally defined.
This works, but not when there is also a local subprogram
with the same name, which is valid when that subprogram is
a specific of the local generic. A bogus error issues at
the point of the USE because name resolution will have already
defined a symbol for the local subprogram.
The solution is to collect the names of local generics when
creating the program tree, and then create their symbols as
well if their names are also local subprograms, prior to any
USE association processing.
Differential Revision: https://reviews.llvm.org/D119566
Roger Kim [Sat, 12 Feb 2022 00:40:53 +0000 (19:40 -0500)]
[Mach-O][NFC] Reorder map file tests
We are just grouping the files and the tests together.
Reviewed By: int3, #lld-macho
Differential Revision: https://reviews.llvm.org/D119456
Roger Kim [Sat, 12 Feb 2022 00:33:23 +0000 (19:33 -0500)]
Print C-string literals in mapfile
This diff has the C-string literals printed into the mapfile in the symbol table like how ld64 does.
Here is what ld64's mapfile looks like with C-string literals:
```
# Path: out
# Arch: x86_64
# Object files:
[ 0] linker synthesized
[ 1] foo.o
# Sections:
# Address Size Segment Section
0x100003F7D 0x0000001D __TEXT __text
0x100003F9A 0x0000001E __TEXT __cstring
0x100003FB8 0x00000048 __TEXT __unwind_info
# Symbols:
# Address Size File Name
0x100003F7D 0x0000001D [ 1] _main
0x100003F9A 0x0000000E [ 1] literal string: Hello world!\n
0x100003FA8 0x00000010 [ 1] literal string: Hello, it's me\n
0x100003FB8 0x00000048 [ 0] compact unwind info
```
Here is what the new lld's Mach-O mapfile looks like:
```
# Path: /Users/rgr/local/llvm-project/build/Debug/tools/lld/test/MachO/Output/map-file.s.tmp/c-string-liter
al-out
# Arch: x86_64
# Object files:
[ 0] linker synthesized
[ 1] /Users/rgr/local/llvm-project/build/Debug/tools/lld/test/MachO/Output/map-file.s.tmp/c-string-literal
.o
# Sections:
# Address Size Segment Section
0x1000002E0 0x0000001D __TEXT __text
0x1000002FD 0x0000001D __TEXT __cstring
# Symbols:
# Address File Name
0x1000002E0 [ 1] _main
0x1000002FD [ 1] literal string: Hello world!\n
0x10000030B [ 1] literal string: Hello, it's me\n
```
Reviewed By: #lld-macho, int3
Differential Revision: https://reviews.llvm.org/D118077
Florian Mayer [Sat, 12 Feb 2022 00:01:37 +0000 (16:01 -0800)]
[NFC] [MTE] Use helpers for stack tagging.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D119503
Florian Mayer [Fri, 11 Feb 2022 23:46:37 +0000 (15:46 -0800)]
[hwasan] keep debug intrinsicts in AllocaInfo.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D119498
AndreyChurbanov [Sat, 12 Feb 2022 00:00:38 +0000 (03:00 +0300)]
[OpenMP] libomp: fix UB when LIBOMP_NUM_HIDDEN_HELPER_THREADS=1.
The __kmp_hidden_helper_threads_num set to N+1 if user requested N threads.
Thus number of worker hidden helper threads corresponds to user request,
main thread of helper team excluded as it does not participate in actual work.
This also fixes divide-by-0 issue in the code.
Fixes #48656
Differential Revision: https://reviews.llvm.org/D119586
Peter Klausler [Tue, 8 Feb 2022 18:08:23 +0000 (10:08 -0800)]
[flang] Avoid bogus error for specification expression
When a scope's symbol has characteriztics whose specification
expressions depend on other non-constant symbols in the same scope,
f18 rightfully emits an error. However, in the case of usage in
specification expressions involving host association, the program is not
invalid. This can arise, for example, in the case of an internal
function whose result's attributes use host-associated variables.
Differential Revision: https://reviews.llvm.org/D119565
Alex Lorenz [Fri, 11 Feb 2022 23:53:09 +0000 (15:53 -0800)]
Revert "[Preprocessor] Reduce the memory overhead of `#define` directives"
This reverts commit
0d9b91524ea4db3760791bba15773c386a26d8ec.
This change broke LLDB's build. I will need to recommit after fixing LLDB.
Peter Steinfeld [Fri, 11 Feb 2022 22:44:42 +0000 (14:44 -0800)]
[flang] Change internal errors in RESHAPE runtime routine to user errors
There are several checks in the runtime routine for the RESHAPE
intrinsic. Some checks verify things that should have been checked at
compile time while others represent user errors.
This update changes the checks for user errors into calls to "Crash"
which include information about the failing check. This identifies them
as user errors rather than compiler errors.
I also verified that the checks that remain as internal errors are also
checked by the front end. I added a test to the front end's RESHAPE
test to complete the checks.
Differential Revision: https://reviews.llvm.org/D119596
Joe Loser [Tue, 8 Feb 2022 02:33:11 +0000 (21:33 -0500)]
[libc++] Use _LIBCPP_NO_UNIQUE_ADDRESS for base in join_view
Despite the comment saying `[[no_unique_address]]` on the `__base_` data member
makes clang crash, this does not seem to be true on CI. So, mark `__base_` with
`_LIBCPP_NO_UNIQUE_ADDRESS`.
Differential Revision: https://reviews.llvm.org/D119208
Jonas Devlieghere [Fri, 11 Feb 2022 23:25:12 +0000 (15:25 -0800)]
[lldb] Pin the shared cache when iterating over its images
Use the dyld_shared_cache_(un)pin_mapping SPI to map the whole shared
cache in memory (if possible) to avoid repeated calls to mmap.
rdar://
81189015
Fangrui Song [Fri, 11 Feb 2022 23:23:18 +0000 (15:23 -0800)]
[tsan] Make __fxstat code path glibc only
This fixes Linux musl build after D118423.
Konstantin Varlamov [Fri, 11 Feb 2022 23:15:10 +0000 (15:15 -0800)]
[libc++][ranges][NFC] Refactor tests for `ranges::{begin,end}`.
- add some test cases for `cbegin`/`cend`;
- make class definitions generally follow the order in which they are
used;
- add a missing include.
Reviewed By: philnik
Differential Revision: https://reviews.llvm.org/D119214
Michael Gottesman [Mon, 7 Feb 2022 21:05:30 +0000 (13:05 -0800)]
[debug-info] If one sees a spill with a dbg.addr use, salvageDebugInfo upon it and don't hoist it.
This ensures that if we have a dbg.addr in a coroutine funclet that is on one of
our function arguments, that the dbg.addr is not mapped to undef and also that
later it isn't hoisted to the front of the basic block. Instead it remains at
its original cloned location.
rdar://
83957028
Differential Revision: https://reviews.llvm.org/D119576
Nico Weber [Fri, 11 Feb 2022 23:04:10 +0000 (18:04 -0500)]
try to fix windows build after
73e585e44d
Paul Kirth [Fri, 11 Feb 2022 22:53:19 +0000 (22:53 +0000)]
[sanitizers] Fix missing header for mac builds
Differential Revision: https://reviews.llvm.org/D119598
Alex Lorenz [Fri, 11 Feb 2022 21:50:30 +0000 (13:50 -0800)]
[Preprocessor] Reduce the memory overhead of `#define` directives
Recently we observed high memory pressure caused by clang during some parallel builds.
We discovered that we have several projects that have a large number of #define directives
in their TUs (on the order of millions), which caused huge memory consumption in clang due
to a lot of allocations for MacroInfo. We would like to reduce the memory overhead of
clang for a single #define to reduce the memory overhead for these files, to allow us to
reduce the memory pressure on the system during highly parallel builds. This change achieves
that by removing the SmallVector in MacroInfo and instead storing the tokens in an array
allocated using the bump pointer allocator, after all tokens are lexed.
The added unit test with 1000000 #define directives illustrates the problem. Prior to this
change, on arm64 macOS, clang's PP bump pointer allocator allocated
272007616 bytes, and
used roughly 272 bytes per #define. After this change, clang's PP bump pointer allocator
allocates
120002016 bytes, and uses only roughly 120 bytes per #define.
For an example test file that we have internally with 7.8 million #define directives, this
change produces the following improvement on arm64 macOS: Persistent allocation footprint for
this test case file as it's being compiled to LLVM IR went down 22% from 5.28 GB to 4.07 GB
and the total allocations went down 14% from 8.26 GB to 7.05 GB. Furthermore, this change
reduced the total number of allocations made by the system for this clang invocation from
1454853 to 133663, an order of magnitude improvement.
Differential Revision: https://reviews.llvm.org/D117348
Evgenii Stepanov [Tue, 8 Feb 2022 23:28:06 +0000 (15:28 -0800)]
[NFC] clang-format one function.
fix code formatting
Differential Revision: https://reviews.llvm.org/D119299
Michael Jones [Fri, 11 Feb 2022 21:17:55 +0000 (13:17 -0800)]
[libc] Fix allocator inclusion
Previously, allocator functions were only available if they were included
from scudo or by using the system libc headers (i.e. by turning off the
full build). This patch changes the logic to include the prototypes for
the allocator functitons in all cases, which allows the linker to link
in the system's allocator.
Reviewed By: sivachandra, abrachet
Differential Revision: https://reviews.llvm.org/D119587
Michael Forney [Fri, 11 Feb 2022 22:49:25 +0000 (14:49 -0800)]
[asan] Always skip first object from dl_iterate_phdr
All platforms return the main executable as the first dl_phdr_info.
FreeBSD, NetBSD, Solaris, and Linux-musl place the executable name
in the dlpi_name field of this entry. It appears that only Linux-glibc
uses the empty string.
To make this work generically on all platforms, unconditionally skip the first
object (like is currently done for FreeBSD and NetBSD). This fixes first DSO
detection on Linux-musl with clang -shared-libsan/-shared-libasan and GCC's
default. It also would likely fix detection on Solaris/Illumos if it were to
gain PIE support (since dlpi_addr would not be NULL).
Additionally, only skip the Linux VDSO on linux.
Finally, use the empty string as the "seen first dl_phdr_info"
marker rather than (char *)-1. If there was no other object, we
would try to dereference it for a string comparison.
Reviewed By: MaskRay, vitalybuka
Differential Revision: https://reviews.llvm.org/D119515
Martin Storsjö [Fri, 11 Feb 2022 22:41:28 +0000 (00:41 +0200)]
[libcxx] Fix a missed instance of _LIBCPP_NO_UNIQUE_ADDRESS
This was missed in
8a0a706f096bf380d81b615c67ab1e1af1c377d3 (added
after that patch was made originally).
Florian Mayer [Fri, 11 Feb 2022 22:41:11 +0000 (14:41 -0800)]
Revert "[hwasan] keep debug intrinsicts in AllocaInfo."
This reverts commit
19fdf85f5858fa0aaae5f28f7140fbf12643993c.
Florian Mayer [Fri, 11 Feb 2022 22:41:03 +0000 (14:41 -0800)]
Revert "[NFC] [MTE] Use helpers for stack tagging."
This reverts commit
8f0e5b4e26a54a3ec347d6499cbb43b15ad6352c.
Fangrui Song [Fri, 11 Feb 2022 22:32:23 +0000 (14:32 -0800)]
Conrad Poelman [Fri, 11 Feb 2022 22:19:01 +0000 (15:19 -0700)]
fix check-clang-tools tests that fail due to Windows CRLF line endings
Running check-clang-tools on Windows produces 5 test failures:
Failed Tests (5):
Clang Tools :: clang-apply-replacements/ClangRenameClassReplacements.cpp
Clang Tools :: clang-apply-replacements/basic.cpp
Clang Tools :: clang-apply-replacements/format.cpp
Clang Tools :: clang-move/move-used-helper-decls.cpp
Clang Tools :: clang-tidy/infrastructure/export-diagnostics.cpp
Four of these failures are simply due to fixed character position
offsets differing on Windows versus Linux, since Windows line endings
take up two characters instead of one:
clang-apply-replacements/ClangRenameClassReplacements.cpp runs clang-rename -offset=254
clang-apply-replacements/Inputs/basic/file[12].yaml specify e.g. FileOffset: 148 and Offset: 298
clang-apply-replacements/Inputs/format/{no,yes}.yaml specify e.g. FileOffset: 94 and Offset: 94
clang-tidy/infrastructure/export-diagnostics.cpp specifies e.g. CHECK-YAML-NEXT: FileOffset: 30
(The move-used-helper-decls.cpp failure seems more complex; clang-move
adds a blank line after void HelperFun1() {} when
clang-move/Inputs/helper_decls_test.cpp has LF line endings, but does
not add a blank line when the input files has CRLF line endings. That
difference in behavior seems like it may be an actual bug, but I have
yet to track it down.)
Differential Revision: https://reviews.llvm.org/D97625
Annika [Fri, 11 Feb 2022 22:11:27 +0000 (06:11 +0800)]
m68k: Support bit shifts on 64-bit integers
As per https://bugs.llvm.org/show_bug.cgi?id=52119.
Reviewed By: myhsu
Differential Revision: https://reviews.llvm.org/D111497
Nico Weber [Fri, 11 Feb 2022 21:26:12 +0000 (16:26 -0500)]
Reland "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"
This relands commit
b3b2538df100ec, except that the new files in Support
are instead in a new library WindowsDriver.
Shubham Sandeep Rastogi [Fri, 11 Feb 2022 19:19:36 +0000 (11:19 -0800)]
Add support for the swift5 reflection section acfuncs
With
bc013b3e4e862da8d0c2d91cf99dcbebf124e4ac a new section called accessible functions was added to swift/include/swift/ABI/ObjectFile.h so this change adds support for dumping it out into the dSYM bundle
Differential Revision: https://reviews.llvm.org/D119569
Paul Kirth [Fri, 11 Feb 2022 21:51:34 +0000 (21:51 +0000)]
[sanitizers] Add missing header to fix Fuchsia builds
Adds missing header to fix sanitizer builds for Fuchsia.
Reviewed By: abrachet
Differential Revision: https://reviews.llvm.org/D119588
Philip Reames [Fri, 11 Feb 2022 21:56:27 +0000 (13:56 -0800)]
Autogen a couple of predicated SCEV tests
Arthur Eubanks [Fri, 11 Feb 2022 21:43:09 +0000 (13:43 -0800)]
[NFC] Remove check for callee parameter elementtype
elementtype is only allowed on caller arguments.
Björn Schäpers [Fri, 5 Nov 2021 20:10:09 +0000 (21:10 +0100)]
[clang-format] Improve require and concept handling
- Added an option where to put the requires clauses.
- Renamed IndentRequires to IndentRequiresClause.
- Changed BreakBeforeConceptDeclaration from bool to an enum.
Fixes https://llvm.org/PR32165, and https://llvm.org/PR52401.
Differential Revision: https://reviews.llvm.org/D113319
Nikolas Klauser [Thu, 10 Feb 2022 23:11:31 +0000 (00:11 +0100)]
[libc++] Prepare string.ops for constexpr
Reviewed By: ldionne, #libc
Spies: libcxx-commits
Differential Revision: https://reviews.llvm.org/D119490
Nico Weber [Fri, 11 Feb 2022 20:09:20 +0000 (15:09 -0500)]
[clang] Expose -fprofile-use in clang-cl
Less typing than `-fprofile-instr-use`, and means the same thing.
Differential Revision: https://reviews.llvm.org/D119574
Dimitry Andric [Fri, 11 Feb 2022 17:07:20 +0000 (18:07 +0100)]
[compiler-rt] Force ABI to libcxxabi when building cxustom libc++
Follow-up to
458ead66dc37, which replaced the bespoke CMakeLists.txt
file for building a custom instrumented libc++ with an invocation of the
runtimes build.
In the the bespoke CMakeLists.txt, the LIBCXX_CXX_ABI setting was forced
to libcxxabi, but this was not done for the CMake invocation for the
runtimes build. This would cause CMake configuration issues on platforms
where the default LIBCXX_CXX_ABI setting is not libcxxabi, such as
FreeBSD.
Add `-DLIBCXX_CXX_ABI=libcxxabi` to that invocation, to make sure the
custom instrumented libc++ always uses the expected ABI.
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D119554
Adrian Prantl [Fri, 11 Feb 2022 21:02:28 +0000 (13:02 -0800)]
Revert "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"
This reverts commit
b3b2538df100ec7f6587b0ee70819a3c8ee2c27e,
it introduced a cycklic module depenency that broke the -DLLVM_ENABLE_MODULES=1 build.
Weverything [Thu, 10 Feb 2022 23:23:43 +0000 (15:23 -0800)]
[Clang][OpaquePtr] Remove deprecated Address constructor calls
Remove most calls to deprcated Address constructor in CGExpr.cpp
Differential Revision: https://reviews.llvm.org/D119496
Florian Mayer [Fri, 11 Feb 2022 20:21:19 +0000 (12:21 -0800)]
[memprof] Fix UB.
An infinite loop without any effects is illegal C++ and can be optimized
away by the compiler.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D119575
Louis Dionne [Thu, 10 Feb 2022 22:10:12 +0000 (17:10 -0500)]
[libc++] Revert the addition of _LIBCPP_HIDE_FROM_ABI and inline in __threading_support
This reverts commit
2722ac65. As explained in D115906, this was actually
unnecessary and it broke the external threading configuration.
Differential Revision: https://reviews.llvm.org/D119484
Louis Dionne [Thu, 10 Feb 2022 20:06:50 +0000 (15:06 -0500)]
[libc++] Disable local submodule visibility in the modules build
Differential Revision: https://reviews.llvm.org/D119468
Florian Hahn [Fri, 11 Feb 2022 20:26:25 +0000 (20:26 +0000)]
[ConstraintElimination] Support add with precondition.
If we can prove that an addition without wrap flags won't wrap, decompse
the operation.
Issue #48253
YASHASVI KHATAVKAR [Fri, 11 Feb 2022 20:18:57 +0000 (15:18 -0500)]
Fix build broken by missing empty line in SourceLevelDebugging.rst
Martin Storsjö [Thu, 10 Feb 2022 11:23:40 +0000 (13:23 +0200)]
[libcxx] Wrap [[no_unique_address]] in a macro, for clang-cl
This should silence all remaining clang-cl build warnings.
Differential Revision: https://reviews.llvm.org/D119430
Sanjay Patel [Fri, 11 Feb 2022 17:05:58 +0000 (12:05 -0500)]
[x86] add test for load ordering; NFC
This is reduced from a test that failed with D118376.
The C source is posted in issue #53695
Sanjay Patel [Thu, 10 Feb 2022 20:18:46 +0000 (15:18 -0500)]
[x86] scrub less memory ops in test; NFC
The addresses matter - we want to verify the splitting
and order of the memops.
Konstantin Varlamov [Fri, 11 Feb 2022 19:56:29 +0000 (11:56 -0800)]
[libc++][NFC] Work around false positive ODR violations from ASan.
This works around a known issue in ASan. ASan doesn't instrument weak
symbols. Because instrumentation increases object size, the binary can
end up with two versions of the same object, one instrumented and one
not instrumented, with different sizes, which ASan will report as an ODR
violation. In libc++, this affects typeinfo for `std::bad_function_call`
which is emitted as a weak symbol in the test executable and as a strong
symbol in the shared library.
The main open issue for ASan appears to be
https://github.com/google/sanitizers/issues/1017.
Differential Revision: https://reviews.llvm.org/D119410
Arthur Eubanks [Fri, 11 Feb 2022 19:50:11 +0000 (11:50 -0800)]
[MSan][OpaquePtr] Use inline asm elementtype instead of getPointerElementType()
Florian Mayer [Fri, 11 Feb 2022 19:27:24 +0000 (11:27 -0800)]
[Sanitizers] Fix build broken by missing import.
Dmitry Vyukov [Fri, 11 Feb 2022 19:35:17 +0000 (20:35 +0100)]
hwasan: fix up includes
Fix up includes after
595d340dceca
("sanitizer_common: make internal/external headers compatible").
Differential Revision: https://reviews.llvm.org/D119570
YASHASVI KHATAVKAR [Fri, 11 Feb 2022 19:38:50 +0000 (14:38 -0500)]
Adding DiBuilder interface for assumed length strings
Philip Reames [Fri, 11 Feb 2022 19:34:30 +0000 (11:34 -0800)]
[SCEVPredicate] Remove getExpr mechanism [NFC]
This mechanism was used for a couple of purposes, but the primary one was keeping track of which predicates in a union might apply to an expression. As these sets are small and agressively deduped, this has little value.
Arthur Eubanks [Fri, 11 Feb 2022 19:30:42 +0000 (11:30 -0800)]
[OpaquePtr][SPARC] Remove getPointerElementType() call in SparcISelLowering
Requires keeping better track of sret types.
Eric Schweitz [Fri, 11 Feb 2022 02:40:13 +0000 (18:40 -0800)]
[flang] Upstream fix to allocmem codegen to deal with missing dimensions
for sequence of character types.
Upstream type test. Upstream test. Fix tests.
Do not run on windows, as that is not an implemented target.
Differential Revision: https://reviews.llvm.org/D119551
Florian Mayer [Fri, 11 Feb 2022 00:15:59 +0000 (16:15 -0800)]
[NFC] [MTE] Use helpers for stack tagging.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D119503
Roman Lebedev [Fri, 11 Feb 2022 18:25:06 +0000 (21:25 +0300)]
[NFCI][SCEV] `SCEVTraversal`: if search terminated, don't push further ops of nary
Even if the search is marked as terminated after only looking at
the first operand, we'd still look at the remaining operands
before actually ending the search.
This seems pointless and wasteful, let's not do that.
Roman Lebedev [Fri, 11 Feb 2022 17:34:46 +0000 (20:34 +0300)]
[SCEV] Generalize umin_seq matching
Since we don't greedily flatten `umin_seq(a, umin(b, c))` into `umin_seq(a, b, c)`,
just looking at the operands of the outer-level `umin` is not sufficient,
and we need to recurse into all same-typed `umin`'s.
Roman Lebedev [Fri, 11 Feb 2022 14:59:09 +0000 (17:59 +0300)]
[SCEV] Recognize `x == 0 ? 0 : umin_seq(..., x, ...) -> umin_seq(x, umin_seq(...))`
Roman Lebedev [Fri, 11 Feb 2022 14:52:11 +0000 (17:52 +0300)]
[SCEV] Recognize `x == 0 ? 0 : umin(..., x, ...) -> umin_seq(x, umin(...))`
That is the canonical expansion for umin_seq,
so we really should roundtrip it.
Roman Lebedev [Fri, 11 Feb 2022 12:48:36 +0000 (15:48 +0300)]
[SCEV] `createNodeForSelectOrPHIInstWithICmpInstCond()`: generalize eq handling
The current logic was: https://alive2.llvm.org/ce/z/j8muXk
but in reality the offset to the Y in the 'true' hand
does not need to exist: https://alive2.llvm.org/ce/z/MNQ7DZ
https://alive2.llvm.org/ce/z/S2pMQD
To catch that, instead of computing the Y's in both
hands and checking their equality, compute Y and C,
and check that C is 0 or 1.
Roman Lebedev [Fri, 11 Feb 2022 12:25:47 +0000 (15:25 +0300)]
[NFC][SCEV] `createNodeForSelectOrPHIInstWithICmpInstCond()`: dedup eq/ne pred handling
Roman Lebedev [Fri, 11 Feb 2022 15:02:47 +0000 (18:02 +0300)]
[NFC][SCEV] Add test more tests for umin_seq recognition
Roman Lebedev [Fri, 11 Feb 2022 12:22:12 +0000 (15:22 +0300)]
[NFC][SCEV] Add some tests for select->umax recognition
Apparently we didn't have any tests for that codepath?
David Green [Fri, 11 Feb 2022 18:57:18 +0000 (18:57 +0000)]
[X86] Replace X86ISD::AVG with generic ISD::AVGCEILU
Pulled out of D106237, this replaces the X86ISD::AVG DAG node with the
generic ISD::AVGCEILU. It doesn't remove the detectAVGPattern method,
but the extra generic ISel matching does alter the existing test.
Differential Revision: https://reviews.llvm.org/D119073
Florian Mayer [Thu, 10 Feb 2022 23:57:47 +0000 (15:57 -0800)]
[hwasan] keep debug intrinsicts in AllocaInfo.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D119498
Peter Steinfeld [Thu, 10 Feb 2022 03:46:34 +0000 (19:46 -0800)]
[flang] Allow mixed association of procedure pointers and targets
Section 10.2.2.4, paragraph 3 states that a procedure pointer with an explicit
interface must have the same characteristics as its target. Previously, we
interpreted this as disallowing such pointers to point to procedures with
implicit interfaces. But several other compilers allow this.
We make an exception for the case where the explicit interface cannot be
called via an implicit interface.
This change makes us allow this, also
Differential Revision: https://reviews.llvm.org/D119404
Peter Kasting [Fri, 11 Feb 2022 18:45:58 +0000 (13:45 -0500)]
[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:
Makes lld-link work in a non-MSVC shell by autodetecting MSVC toolchain. Also
adds support for /winsysroot and a few other switches.
All this is done by refactoring to share code with clang-cl's existing support
for the same.
Differential Revision: https://reviews.llvm.org/D118070
Arthur Eubanks [Fri, 11 Feb 2022 18:51:52 +0000 (10:51 -0800)]
[gn build] Manually port
c7eb84634519e6497
Since the bot is broken due to hwasan issues, it's not auto updating the file lists.
Florian Mayer [Thu, 3 Feb 2022 19:56:42 +0000 (11:56 -0800)]
[nfc] [hwasan] factor out logic to collect info about stack
this is the first step in unifying some of the logic between hwasan and
mte stack tagging. this only moves around code, changes to converge
different implementations of the same logic follow later.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D118947
Paul Robinson [Fri, 11 Feb 2022 18:43:22 +0000 (10:43 -0800)]
[RGT] Refactor environment-specific checks to use GTEST_SKIP()
This allows using GTEST_SKIP() to identify un-executed tests.
Found by the Rotten Green Tests project.
Paul Robinson [Fri, 11 Feb 2022 18:42:38 +0000 (10:42 -0800)]
[RGT] Refactor Windows-specific checks into their own test
This allows using GTEST_SKIP() to identify un-executed tests.
Found by the Rotten Green Tests project.
Paul Robinson [Fri, 11 Feb 2022 18:41:24 +0000 (10:41 -0800)]
[RGT] Exercise both paths through a test
BitcastToGEP had an opaque/typed pointer decision point, make sure it
exercises both sides.
Found by the Rotten Green Tests project.
Johannes Doerfert [Fri, 11 Feb 2022 18:22:51 +0000 (12:22 -0600)]
[OpenMP][FIX] The `llvm.amdgcn.s.barrier` is actually not aligned
If we assume `llvm.amdgcn.s.barrier` is aligned we may remove it and
cause OpenMP GPU applications on the AMD GPU to be stuck or wrongly
synchronized.
Reported by Carlo Bertolli.
Arthur Eubanks [Fri, 11 Feb 2022 18:39:26 +0000 (10:39 -0800)]
[clang][OpaquePtr] Remove call to getPointerElementType() in CodeGenModule::GetAddrOfGlobalTemporary()
Dmitry Vyukov [Fri, 11 Feb 2022 15:11:23 +0000 (16:11 +0100)]
sanitizer_common: make internal/external headers compatible
This is a follow up to
4f3f4d672254
("sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature mismatch")
which fixes a similar problem for msan build.
I am getting the following error compiling a unit test for code that
uses sanitizer_common headers and googletest transitively includes
sanitizer interface headers:
In file included from third_party/gwp_sanitizers/singlestep_test.cpp:3:
In file included from sanitizer_common/sanitizer_common.h:19:
sanitizer_interface_internal.h:41:5: error: typedef redefinition with different types
('struct __sanitizer_sandbox_arguments' vs 'struct __sanitizer_sandbox_arguments')
} __sanitizer_sandbox_arguments;
common_interface_defs.h:39:3: note: previous definition is here
} __sanitizer_sandbox_arguments;
Reviewed By: melver
Differential Revision: https://reviews.llvm.org/D119546
Philip Reames [Fri, 11 Feb 2022 18:37:39 +0000 (10:37 -0800)]
[PSE] Allow duplicate predicates in debug output
This lets us avoid redundant implication work in the constructor of SCEVUnionPredicate which simplifies an upcoming change. If we're actually building a predicate via PSE, that goes through addPredicate which does include the implication check.
Simon Pilgrim [Fri, 11 Feb 2022 18:38:07 +0000 (18:38 +0000)]
[X86] combineVSelectToBLENDV - handle vselect(vXi1,A,B) -> blendv(sext(vXi1),A,B)
For pre-AVX512 targets, attempt to sign-extend a vXi1 condition mask to pass to a X86ISD::BLENDV node
Fixes Issue #53760
Stanislav Mekhanoshin [Fri, 11 Feb 2022 00:30:10 +0000 (16:30 -0800)]
[AMDGPU] Merge AMDGPULDSUtils into AMDGPUMemoryUtils
Differential Revision: https://reviews.llvm.org/D119502
David Green [Fri, 11 Feb 2022 18:28:56 +0000 (18:28 +0000)]
[ISel] Port AArch64 HADD and RHADD to ISel
This ports the aarch64 combines for HADD and RHADD over to DAG combine,
so that they can be used in more architectures (notably MVE in a
followup patch). They are renamed to AVGFLOOR and AVGCEIL in the
process, to avoid confusion with instructions such as X86 hadd. The code
was also rewritten slightly to remove the AArch64 idiosyncrasies.
The general pattern for a AVGFLOORS is
%xe = sext i8 %x to i32
%ye = sext i8 %y to i32
%a = add i32 %xe, %ye
%r = lshr i32 %a, 1
%t = trunc i32 %r to i8
An AVGFLOORU is equivalent with zext. Because of the truncate
lshr==ashr, as the top bits are not demanded. An AVGCEIL also includes
an extra rounding, so includes an extra add of 1.
Differential Revision: https://reviews.llvm.org/D106237
Dávid Bolvanský [Fri, 11 Feb 2022 18:22:51 +0000 (19:22 +0100)]
[AlwaysInliner] Respect noinline call site attribute
```
always_inline foo() { }
bar () {
noinline foo();
}
```
We should prefer call site attribute over attribute on decl. This is fix for AlwaysInliner, similar fix is needed for normal Inliner (follow up).
Related to https://reviews.llvm.org/D119061
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D119553
Reid Kleckner [Fri, 11 Feb 2022 18:20:10 +0000 (10:20 -0800)]
[CodeView] Match any backend version in the new test
This makes the test pass for any LLVM_VERSION_MAJOR/MINOR value. Vendors
override these, and they change every six months.
Nikolas Klauser [Fri, 11 Feb 2022 18:15:18 +0000 (19:15 +0100)]
[libc++] Remove __functional_base
Reviewed By: ldionne, Quuxplusone, #libc
Spies: Mordante, mgorny, libcxx-commits, arichardson, llvm-commits, arphaman
Differential Revision: https://reviews.llvm.org/D119439
Tim Northover [Fri, 11 Feb 2022 18:06:28 +0000 (18:06 +0000)]
Revert "StackProtector: ignore debug insts when splitting blocks."
This reverts commit
7605ca85f1a8e4e61e7de98856630d67da11aaae.
It caused an assertion failure in Fuschia.
Austin Kerbow [Fri, 11 Feb 2022 06:43:45 +0000 (22:43 -0800)]
[InferAddressSpaces] Fix assert on invalid cast ordering
If a cast is needed when replacing uses with newly created values, the
cast must be inserted after the instruction that defines the new value.
Fixes: SWDEV-321215
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D119524
Arthur Eubanks [Fri, 11 Feb 2022 17:52:44 +0000 (09:52 -0800)]
[CoroFrame][OpaquePtr] Remove getPointerElementType() call
Get it from the byval type instead.
Krzysztof Parzyszek [Fri, 11 Feb 2022 17:19:00 +0000 (09:19 -0800)]
[Hexagon] Add patterns for select(i1, Q, Q)
LLVM GN Syncbot [Fri, 11 Feb 2022 17:36:54 +0000 (17:36 +0000)]
[gn build] Port
31f9519d48c2