ChunEon Park [Tue, 10 Mar 2015 07:51:44 +0000 (16:51 +0900)]
popup: correct popup position.
actually popup position should be updated when it's parent is moved.
@fix
ChunEon Park [Tue, 10 Mar 2015 07:56:22 +0000 (16:56 +0900)]
layout: here default content alias can be acceptable.
elm_object_content_set() for layout will be working.
@fix.
woochan lee [Tue, 10 Mar 2015 07:40:53 +0000 (16:40 +0900)]
layout: Add text alias description as default.
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2116
Jee-Yong Um [Tue, 10 Mar 2015 07:21:16 +0000 (16:21 +0900)]
elc_popup: Adjust popup size when its parent is resized
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.
T2082
Test Plan: You can check the effect of this patch in "elementary_test popup".
Reviewers: seoz, Hermet
Subscribers: stefan_schmidt, J5lx, seoz
Differential Revision: https://phab.enlightenment.org/D2121
Stefan Schmidt [Thu, 26 Feb 2015 14:20:31 +0000 (15:20 +0100)]
release: Update NEWS and bump version for 1.13.1 release
Mike Blumenkrantz [Mon, 23 Feb 2015 21:49:24 +0000 (16:49 -0500)]
edgebindings theme now sets align to setup layout as expected
ref T2144
SangHyeon Lee [Mon, 23 Feb 2015 08:57:01 +0000 (17:57 +0900)]
genlist/gengrid : Add upadating 'focus' state in item realized function.
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
Jee-Yong Um [Mon, 23 Feb 2015 08:59:52 +0000 (17:59 +0900)]
elm_box: Fix miscalculated items' size issue in homogeneous box
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.
T2033
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Maniphest Tasks: T2033
Differential Revision: https://phab.enlightenment.org/D2016
woochan lee [Mon, 23 Feb 2015 08:48:37 +0000 (17:48 +0900)]
datetime: Fix elm_datetime_field_limit_set.
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1980
Andy Williams [Wed, 18 Feb 2015 08:46:05 +0000 (08:46 +0000)]
entry: Don't unlink empty files when saving @fix T2122.
Simmple fix where we now only unlink if the object we are saving is NULL.
A null terminated string being null is not an error case.
Mike Blumenkrantz [Tue, 10 Feb 2015 23:09:43 +0000 (18:09 -0500)]
comp theme now allows for modification of focus rect
Carsten Haitzler (Rasterman) [Tue, 10 Feb 2015 10:48:21 +0000 (19:48 +0900)]
elm engine - restore explicit use of ELM_ENGNE env var
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine
@fix
Stefan Schmidt [Mon, 9 Feb 2015 12:39:59 +0000 (13:39 +0100)]
release: Update NEWS and bump version for 1.13.0 release
Stefan Schmidt [Mon, 9 Feb 2015 11:36:01 +0000 (12:36 +0100)]
elm_config: Avoid access of deleted item data.
This belongs to the fixes raster just did here. It was the only one I was able
to trigger after his fixes.
Last one in a row that fixes T2072.
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 11:25:44 +0000 (20:25 +0900)]
elm - list - fix invalid item data scope get
@fix
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 11:21:54 +0000 (20:21 +0900)]
elm config - font selector - avoid accessing invalid data on deld items
@fix
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 09:20:45 +0000 (18:20 +0900)]
elm list - fix access of deleted items in list when recursing
@fix
Youngbok Shin [Mon, 9 Feb 2015 04:09:05 +0000 (13:09 +0900)]
widgets: Apply default return value according to description in .eo or add description too.
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix
Reviewers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1933
kabeer khan [Mon, 9 Feb 2015 01:40:29 +0000 (10:40 +0900)]
elm_widget: added evas smart callback descriptions
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1876
Daniel Juyung Seo [Mon, 9 Feb 2015 01:34:06 +0000 (10:34 +0900)]
test_genlist: Clean up reorder test case.
Igor Murzov [Sat, 7 Feb 2015 12:17:53 +0000 (15:17 +0300)]
Update russian translation
Carsten Haitzler (Rasterman) [Sat, 7 Feb 2015 03:54:11 +0000 (12:54 +0900)]
elm - fix engine config mismatch with new perferred accel vs old engine
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
Sung-Taek Hong [Fri, 6 Feb 2015 12:58:32 +0000 (21:58 +0900)]
elm_slider: modified each slider have its indicator visible mode.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1887
Daniel Juyung Seo [Fri, 6 Feb 2015 06:15:44 +0000 (15:15 +0900)]
doc: Fix typos in documentations.
Daniel Juyung Seo [Fri, 6 Feb 2015 06:11:32 +0000 (15:11 +0900)]
win_example: Fix win example codes.
- return value in ecore event handler callback.
- remove unnecessary variable.
Youngbok Shin [Fri, 6 Feb 2015 06:06:49 +0000 (15:06 +0900)]
win: fix an issue that profile is erased and set to NULL.
Summary:
When ecore_evas_window_profile_supported_get API return EINA_FALSE,
elm_win widget should not get profile from ecore_evas_window_profile_get API.
@fix
Reviewers: woohyun, Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1943
Carsten Haitzler (Rasterman) [Fri, 6 Feb 2015 02:32:55 +0000 (11:32 +0900)]
fix win center trap for elm to pass in h and v params
while this is technically an abi break, it should actually have no
real impact. it will have warnings - sure, but running existing code
will simply not see the extra parammeters on the stack and not use
them so it'll continue to work. if we removed paramms, we'd be in
pain. (same applies to params passed in registers).
this fixes T2031
Carsten Haitzler (Rasterman) [Thu, 5 Feb 2015 11:44:49 +0000 (20:44 +0900)]
elm - win - dont use deprecated func - use new one.
cleanup to match efl 1.13 changes
Jee-Yong Um [Thu, 5 Feb 2015 11:41:16 +0000 (20:41 +0900)]
elm_label: Fixed label disappearing after theme changed
Summary:
There is a bug that text disappears when theme is changed after label shown.
This patch fixed it.
@fix
Reviewers: woohyun, Hermet, Jaehyun, seoz
Subscribers: Jaehyun, seoz
Differential Revision: https://phab.enlightenment.org/D1923
Shinwoo Kim [Thu, 5 Feb 2015 11:02:24 +0000 (20:02 +0900)]
[tooltip] use proper object to set tooltip layer
Summary:
tooltip could be hide by the other object which have lower layer than target object of tooltip.
the layer of content could be changed, when is set to the tooltip as a content.
@fix
Test Plan: check added test lines
Reviewers: cedric, jpeg, seoz, raster
Reviewed By: raster
Subscribers: singh.amitesh, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1889
Jee-Yong Um [Wed, 4 Feb 2015 10:26:06 +0000 (19:26 +0900)]
elm_label: Fixed to prevent slide's autostart before calling elm_label_slide_go()
Summary:
Label should not start sliding before elm_label_slide_go() is called.
However, label starts sliding automatically,
because resize callback emits slide start signal.
This patch prevents label from sliding before calling elm_label_slide_go().
@fix
Reviewers: woohyun, Hermet, seoz
Subscribers: CHAN, woohyun
Differential Revision: https://phab.enlightenment.org/D1906
Jaehwan Kim [Wed, 4 Feb 2015 10:19:45 +0000 (19:19 +0900)]
datetime_module: Fix build warning.
Include the elm_widget.h
Carsten Haitzler (Rasterman) [Wed, 4 Feb 2015 10:04:53 +0000 (19:04 +0900)]
update po
Jaehwan Kim [Wed, 4 Feb 2015 09:52:14 +0000 (18:52 +0900)]
datetime module: include elm_widget_datetime.h instead of elm_priv.h
The external module can't include elm_priv.h.
So Elm_Datetime_Module_Data moves in elm_widget_datetime.h
Daniel Juyung Seo [Wed, 4 Feb 2015 01:27:24 +0000 (10:27 +0900)]
NEWS: Pedantic change of capital letter in NEWS fi.e
Daniel Juyung Seo [Wed, 4 Feb 2015 01:16:57 +0000 (10:16 +0900)]
test_label: Cleanup label wrap test.
- remove unnecessary box.
- use ELM_SCALE_SIZE macro for a better scalability.
VBS [Tue, 3 Feb 2015 23:30:06 +0000 (08:30 +0900)]
Gengrid : Fix memory leak in elm_gengrid_realized_items_update
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
maxerba [Tue, 3 Feb 2015 20:07:45 +0000 (21:07 +0100)]
Updating serbian translation
Stefan Schmidt [Tue, 3 Feb 2015 09:22:43 +0000 (10:22 +0100)]
release: Update NEWS and bump version for 1.13.0-beta3 release
Youngbok Shin [Tue, 3 Feb 2015 09:17:47 +0000 (10:17 +0100)]
elm_image: fix elm_image_memfile_set API fail when elm_image widget is not visible.
Summary:
It could success only when the widget was visible.
The API must return EINA_TRUE if buffer and size has no problem, not visiblity of widget.
@fix
Reviewers: Hermet, woohyun, jpeg
Differential Revision: https://phab.enlightenment.org/D1917
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Amitesh Singh [Tue, 3 Feb 2015 06:47:32 +0000 (15:47 +0900)]
list/genlist/gengrid/toolbar: set focus/unfocus on item when focus is actually set on widget.
Summary: @Fix
Reviewers: raster, Hermet, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1918
woochan lee [Tue, 3 Feb 2015 02:38:21 +0000 (11:38 +0900)]
multibuttonentry: Delete duplicate running code.
Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix
Test Plan:
Run elementary_test.
1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
(layout callback function called view update -> elm_box_unpack called in view update ->
entry lose focus -> on_focus_callback call again)
Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D1902
Youngbok Shin [Fri, 30 Jan 2015 02:04:24 +0000 (11:04 +0900)]
win: Add default return value at elm_win_type_get API according to API description.
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.
Test Plan: None.
Reviewers: woohyun, JackDanielZ, seoz
Differential Revision: https://phab.enlightenment.org/D1907
Daniel Juyung Seo [Fri, 30 Jan 2015 00:10:43 +0000 (09:10 +0900)]
test_label: Use meaningful test name for label test.
kabeer khan [Thu, 29 Jan 2015 23:02:21 +0000 (08:02 +0900)]
Elm_Entry: Removed empty line and added error message
Summary:
Resolved FIXME in utf8_markup_save by adding error messages
for fopen and fputs command
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: devilhorns, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1888
Daniel Juyung Seo [Thu, 29 Jan 2015 22:35:16 +0000 (07:35 +0900)]
NEWS: Clean up news file before release.
Daniel Juyung Seo [Thu, 29 Jan 2015 06:28:08 +0000 (15:28 +0900)]
test_panes: Remove unnecessary align/weight set for panes contents.
Stefan Schmidt [Wed, 28 Jan 2015 12:49:00 +0000 (13:49 +0100)]
edje_externals/elm_video: Fix bug where we override the rememberred position
This bug was there from the initial commit of elm_video. Classical
copy&andpaste bug.
CID: 1267207
Daniel Juyung Seo [Tue, 27 Jan 2015 04:11:05 +0000 (13:11 +0900)]
panes: Fix elm_panes_fixed_set.
@fix
Stefan Schmidt [Mon, 26 Jan 2015 14:02:55 +0000 (15:02 +0100)]
NEWS: Manually fix up a news entry
Stefan Schmidt [Mon, 26 Jan 2015 12:09:54 +0000 (13:09 +0100)]
release: Update NEWS and bump version for 1.13.0-beta2 release
Dave Andreoli [Sun, 25 Jan 2015 17:31:59 +0000 (18:31 +0100)]
Icon: choose the fdo icon size using the evas obj geometry
Use the min between w and h of the evas object to
request the size in the icon theme. Fdo icon are always
square (1:1) so min seems correct.
Also improved the test to include a test that do
not relay on the size_hint_min of the icon.
Now in all the test I have done always the correct
fdo icon are used.
Dave Andreoli [Sun, 25 Jan 2015 15:48:21 +0000 (16:48 +0100)]
Revert "Icon: use size_hint_min instead of image_size to know the wanted size"
This reverts commit
75176a789981bd6b1ef0bfcc95793c896b5bde07.
Was not the correct solution, as min_size can be smaller than
the real wanted size. Need to find another solution.
Thanks TAsn to spot this
Dave Andreoli [Sun, 25 Jan 2015 14:48:41 +0000 (15:48 +0100)]
Icon: use size_hint_min instead of image_size to know the wanted size
This @fix fdo icons to load the correct image for the requested size.
Whitout this the small images (16x16) was never used, because once a big
(64x64 for example) image was loaded, that size was used as min.
See the Icon Standard test for a better explanation
Dave Andreoli [Sun, 25 Jan 2015 14:39:43 +0000 (15:39 +0100)]
Icon: no more reimplement sizing_eval
The code there was trying to reload the icon to have an
image that should match the requested size, this was totally
wrong, the calculation was always resulting in an image bigger
than the needed.
It was also useless as this logic is yet handled in the resize
callback.
Dave Andreoli [Sun, 25 Jan 2015 14:16:51 +0000 (15:16 +0100)]
Improve Standard Icon test
You can now select the size of the icons in the list and
also added a single icon that you can resize.
The size of the icons is important as icon themes usually
provide different images for different sizes.
This test now spot out some errors in elm_icon wrt icon
sizing, will fix soon
Dave Andreoli [Fri, 23 Jan 2015 20:44:15 +0000 (21:44 +0100)]
Add correct fdo name for the last added search icon
Stefan Schmidt [Fri, 23 Jan 2015 11:45:33 +0000 (12:45 +0100)]
elm_image: Add missing semi-colon to terminate line.
No compiler warning for this because the macro was terminated with it.
It still looks wrong without it and does no harm.
Stefan Schmidt [Fri, 23 Jan 2015 11:43:49 +0000 (12:43 +0100)]
elm_image: Fix memory leak in GETDAT macro.
Free data2 on error path.
CID: 1265609, 1265610, 1265611, 1265612
Stefan Schmidt [Fri, 23 Jan 2015 11:32:42 +0000 (12:32 +0100)]
test_disable: Extend button array to fix memory corruption
We are accessing btn[3] in the code so we should make sure the array it big
enough for it.
CID: 1265613
Daniel Juyung Seo [Fri, 23 Jan 2015 05:32:35 +0000 (14:32 +0900)]
transit: Fix read from pointer after free.
This fixes coverity CID 1265738.
Daniel Juyung Seo [Fri, 23 Jan 2015 05:29:15 +0000 (14:29 +0900)]
test_win_state: Add elm_win_center() sample.
Mike Blumenkrantz [Fri, 23 Jan 2015 03:35:28 +0000 (22:35 -0500)]
win centering: unbork!
not centering on an axis does not mean that it needs to be moved to the screen origin.
also clamp to screen x,y, not 0,0
ChunEon Park [Thu, 22 Jan 2015 08:44:09 +0000 (17:44 +0900)]
transit: fix crash issue.
This fixes the side effect that introduced from
1e06309be42fd2b5d0900b16da0178215c111681
Since transit has supported adding a map effect on the previous map status,
transit tried to access object-state map pointer.
but theses map pointer won't be valid if the transit keeps the last state
because it doesn't back up any object-state data.
Daniel Juyung Seo [Fri, 16 Jan 2015 05:45:42 +0000 (14:45 +0900)]
test_gengrid: Dynamically allocate item data.
Do not waste unnecessary memory.
Daniel Juyung Seo [Fri, 16 Jan 2015 05:33:06 +0000 (14:33 +0900)]
test_colorselector: Clean up a little bit.
- Remove unnecessary data set.
- Use ELM_SCALE_SIZE on min set for a better scalability.
Yes this colorselector test needs a looooot of love.
Daniel Juyung Seo [Fri, 16 Jan 2015 05:13:30 +0000 (14:13 +0900)]
colorselector: Remove unnecessary pointer redirection.
Elm_Colorselector_Data pointer is already there.
Daniel Juyung Seo [Thu, 15 Jan 2015 20:00:11 +0000 (05:00 +0900)]
test_icon: Clean up icon standard sample.
- Do not set unnecessary min size for the icons. Just follow list's item
size naturally.
- Do not free unnecessary list which was already freed by
EINA_LIST_FREE.
- Do not set align for the window resize object which is not required to
be set.
- Follow conventional way of pointer declaration.
Mike Blumenkrantz [Wed, 21 Jan 2015 20:15:43 +0000 (15:15 -0500)]
image now implements edje object size functions
Edje.Object.size_min.get;
Edje.Object.size_max.get;
Edje.Object.size_min_calc;
Edje.Object.calc_force;
fixes all image-in-edje sizing issues/errors
Mike Blumenkrantz [Wed, 21 Jan 2015 20:14:20 +0000 (15:14 -0500)]
image animation functions now work as expected for edje images
Mike Blumenkrantz [Tue, 20 Jan 2015 18:03:52 +0000 (13:03 -0500)]
win_example now exits fullscreen on any key press...always
fix T516
Jaeun Choi [Tue, 20 Jan 2015 01:32:06 +0000 (10:32 +0900)]
Elm_Entry: set handler style according to current widget style
Previously, entry set handlers' style as default when they are created
and changed style on theme_apply function. But in usual scenario, users create
entry and set style before handlers are created, so when they are created
the style is set as default regardless of the style users already set.
This patch fixes it.
@fix
Stefan Schmidt [Mon, 19 Jan 2015 14:12:06 +0000 (15:12 +0100)]
release: Update NEWS and bump version for 1.13.0-beta1 release
Stefan Schmidt [Mon, 19 Jan 2015 11:56:50 +0000 (12:56 +0100)]
Revert "genlist: added reorder feature on key events"
This reverts commit
f99be3a1d6bdc63153598b592b5437c33da44bf0.
The API is not ready to be released. Please see the thread on the e-devel
mailing list under this subject. This can get another try in the 1.14
release cycle.
Conflicts:
src/lib/elm_genlist.c
ChunEon Park [Mon, 19 Jan 2015 08:29:20 +0000 (17:29 +0900)]
genlist: fix incorrect grammar.
No allow attaching double definite articles.
Thanks vincent for reporting.
Jaehyun Cho [Mon, 19 Jan 2015 06:35:17 +0000 (15:35 +0900)]
elm_transit: Fix crash issue caused by multiple transit effects.
Summary:
Fix crach issue caused by multiple transit effects on a single object.
This patch prevents deleting obj_data while the obj_data is still used by other transit objects.
This fix is related to commits "Support zoom keeping current map effect."(
60214e6a172e42303fdfc69ef3d1996b25132242)
and "Support rotation keeping current map effect."(
1e06309be42fd2b5d0900b16da0178215c111681).
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1878
ChunEon Park [Mon, 19 Jan 2015 06:26:21 +0000 (15:26 +0900)]
genlist: fix genlist multi-selected problem.
user request was ignored if they calls the genlist_item_selected_set(true)
to another item in an item selected callback. because genlist made
the selected item highlighted after user "selected" callback.
The behavior had been changed on my genlist refactoring,
so the behavior was actually just restored.
This issue resolves T2020
Jaehyun Cho [Mon, 19 Jan 2015 06:30:26 +0000 (15:30 +0900)]
elm_transit: Fix to support zoom rate zero.
Summary:
Fix to support zoom rate zero by using evas_map_util_zoom() instead of evas_map_util_3d_perspective().
@fix
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1877
WooHyun Jung [Sat, 17 Jan 2015 07:29:46 +0000 (16:29 +0900)]
widget: elm_win can be unfocused only when its ecore_evas loses focus.
Stefan Schmidt [Fri, 16 Jan 2015 20:16:04 +0000 (21:16 +0100)]
configure: Fix typo in coverage option help text
Cedric BAIL [Fri, 16 Jan 2015 15:39:37 +0000 (16:39 +0100)]
tests: add coverage support.
And our current score is 19% functions coverage for Elementary.
Cedric BAIL [Fri, 16 Jan 2015 13:29:23 +0000 (14:29 +0100)]
tests: actually run the main loop properly to be able to enter in idle state.
Note that the iterate function will never trigger the idler that are registered
in Ecore. That's by definition. I changed the code to actually use the full
main loop and trigger the change detection on idle enterer. That should be enough
for Elementary as all idler should logically affect the visual aspect of something
at some point and exit idle.
Thanks marcel-hollerbach@t-online.de for helping me debug this issue.
maxerba [Fri, 16 Jan 2015 11:34:13 +0000 (12:34 +0100)]
Updating italian translation
ChunEon Park [Thu, 15 Jan 2015 14:01:00 +0000 (23:01 +0900)]
genlist: code clean up
highlight item with one entry.
ChunEon Park [Thu, 15 Jan 2015 13:36:57 +0000 (22:36 +0900)]
genlist: don't access item after removing it.
ChunEon Park [Thu, 15 Jan 2015 13:36:28 +0000 (22:36 +0900)]
genlist: guard the item deletion problem.
this exceptional code prevents the deletion of the item
in the middle of the callback.
ChunEon Park [Thu, 15 Jan 2015 07:12:37 +0000 (16:12 +0900)]
genlist: fix the access of the invalid items.
still, there were case item or genlist is cleared in the user callback.
don't access the cleared items if they are requested deletion.
Mike Blumenkrantz [Wed, 14 Jan 2015 20:19:48 +0000 (15:19 -0500)]
genlist needs to also highlight items on keyboard select
this should probably just happen in _item_select() to avoid future incidents
ref T1986
Mike Blumenkrantz [Wed, 14 Jan 2015 19:41:50 +0000 (14:41 -0500)]
Revert "genlist: fix a crash when deleting a item in selected callback."
This reverts commit
c80b24baf815e35c160bf0dbe8ecae6ea247aef8.
this broke the selection callback completely and makes every genlist app unusable.
please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
ChunEon Park [Wed, 14 Jan 2015 14:30:43 +0000 (23:30 +0900)]
genlist: fix a crash when deleting a item in selected callback.
if user deletes the item in the callback,
current function(_item_select) would be corrupted.
just leave the callback call in the last of the function.
ChunEon Park [Wed, 14 Jan 2015 14:19:29 +0000 (23:19 +0900)]
genilst: fix regression bug added in
0e7d521151ba93f3b5955caaf9b906e160ab6057
some logic of deleting item were duplicated.
this fixes fileselector crash issue.
Lukasz Stanislawski [Wed, 14 Jan 2015 13:49:41 +0000 (14:49 +0100)]
Do not explicite include atspi headers.
Summary: fixes make check failures on atspi tests.
Reviewers: cedric
Subscribers: seoz
Maniphest Tasks: T2001
Differential Revision: https://phab.enlightenment.org/D1870
ChunEon Park [Wed, 14 Jan 2015 13:07:00 +0000 (22:07 +0900)]
genlist: set missed item reference.
this missing would cause crash of the genlist when it's items are cleared.
ChunEon Park [Wed, 14 Jan 2015 13:04:26 +0000 (22:04 +0900)]
genlist: fix a crash of genlist group tree example.
don't corrupt list pointer.
we can clear items more simply.
Thanks ya-kov for reporting.
ChunEon Park [Wed, 14 Jan 2015 10:50:15 +0000 (19:50 +0900)]
widget: set missing elm_widget_item_magic
Cedric BAIL [Tue, 13 Jan 2015 14:25:10 +0000 (15:25 +0100)]
photocam: force reload of image on file_set.
Thanks, bug reported by thierry@substanciel.fr .
Carsten Haitzler (Rasterman) [Mon, 12 Jan 2015 23:53:14 +0000 (08:53 +0900)]
elm image - fix image rotation in non-common cases
this fixes
d6f4040d0c62c220f2339d2a57126fde43e85e19 for the non-common
path that normalizes then applies new orientation
@fix
Chris Michael [Mon, 12 Jan 2015 17:04:19 +0000 (12:04 -0500)]
elementary: Fix dereference of null return value
Summary: This fixes Coverity CID1261370. strrchr can return NULL here,
so we need to check that 'p' is valid.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Mon, 12 Jan 2015 13:11:43 +0000 (14:11 +0100)]
release: Update NEWS and bump version for 1.13.0-alpha1 release
Tom Hacohen [Mon, 12 Jan 2015 10:13:34 +0000 (10:13 +0000)]
Elm win: Fix added internal parameter to the win constructor.
Internal hacks should not affect user facing API. This commit adds a new
API to do the internal hack. This is still bad, but it's much less than
what was there before.
This fixes the main issue introduced by commit:
63a5cdf0f8516c16a62233da0c2af0e10a13264b