platform/upstream/freerdp.git
7 years agoMerge pull request #4071 from bmiklautz/debian_fixes
David Fort [Thu, 3 Aug 2017 07:32:29 +0000 (09:32 +0200)]
Merge pull request #4071 from bmiklautz/debian_fixes

Fixes from the Debian project

7 years agoFix warning in man pages
Mike Gabriel [Thu, 3 Aug 2017 06:41:50 +0000 (08:41 +0200)]
Fix warning in man pages

"warning: can't find macro file `www.tmac))'""`"

7 years agoFix typos in some error messages
Mike Gabriel [Thu, 3 Aug 2017 06:38:05 +0000 (08:38 +0200)]
Fix typos in some error messages

7 years agoMerge pull request #4066 from akallabeth/input_event_fixes
David Fort [Wed, 2 Aug 2017 09:25:08 +0000 (11:25 +0200)]
Merge pull request #4066 from akallabeth/input_event_fixes

Fixed capability checks for mouse and unicode input.

7 years agoMerge pull request #4069 from yurashek/master
David Fort [Wed, 2 Aug 2017 07:53:38 +0000 (09:53 +0200)]
Merge pull request #4069 from yurashek/master

Build on Solaris

7 years agoFixed capability checks for mouse and unicode input.
Armin Novak [Mon, 31 Jul 2017 10:16:47 +0000 (12:16 +0200)]
Fixed capability checks for mouse and unicode input.

7 years agoMerge pull request #4064 from floppym/gst-detect
David Fort [Sat, 29 Jul 2017 06:33:33 +0000 (08:33 +0200)]
Merge pull request #4064 from floppym/gst-detect

Fix gstreamer-1.0 detection

7 years agoFix gstreamer-1.0 detection
Mike Gilbert [Fri, 28 Jul 2017 20:31:41 +0000 (16:31 -0400)]
Fix gstreamer-1.0 detection

7 years agoMerge pull request #4061 from vakartel/master
David Fort [Thu, 27 Jul 2017 08:55:00 +0000 (10:55 +0200)]
Merge pull request #4061 from vakartel/master

Fix build with LibreSSL

7 years agoFix build with LibreSSL
Valery Kartel [Wed, 26 Jul 2017 14:12:14 +0000 (17:12 +0300)]
Fix build with LibreSSL

7 years agoMerge pull request #4056 from akallabeth/disable_jpeg
Bernhard Miklautz [Mon, 24 Jul 2017 13:47:49 +0000 (15:47 +0200)]
Merge pull request #4056 from akallabeth/disable_jpeg

Disable JPEG codec support if not compiled in.

7 years agoDisable JPEG codec support if not compiled in.
Armin Novak [Mon, 24 Jul 2017 13:23:36 +0000 (15:23 +0200)]
Disable JPEG codec support if not compiled in.

7 years agoMerge pull request #4055 from akallabeth/talos_v3 2.0.0-rc0
Norbert Federa [Mon, 24 Jul 2017 08:46:54 +0000 (10:46 +0200)]
Merge pull request #4055 from akallabeth/talos_v3

Security fixes and code cleanups

7 years agoclipboard: fix possible invalid memory access
Bernhard Miklautz [Mon, 17 Jul 2017 13:21:58 +0000 (15:21 +0200)]
clipboard: fix possible invalid memory access

Fix an possible issue found by Sébastien Duquette.

7 years agoFixed missing include.
Armin Novak [Thu, 13 Jul 2017 11:29:00 +0000 (13:29 +0200)]
Fixed missing include.

7 years agoFixed resource cleanup.
Armin Novak [Thu, 13 Jul 2017 11:28:00 +0000 (13:28 +0200)]
Fixed resource cleanup.

7 years agoFixed uninitialized values.
Armin Novak [Thu, 13 Jul 2017 10:19:10 +0000 (12:19 +0200)]
Fixed uninitialized values.

7 years agoFixed double free.
Armin Novak [Thu, 13 Jul 2017 10:08:25 +0000 (12:08 +0200)]
Fixed double free.

7 years agoFixed wrong type for AuthenticationLevel.
Armin Novak [Thu, 13 Jul 2017 09:42:50 +0000 (11:42 +0200)]
Fixed wrong type for AuthenticationLevel.

Replaced type BOOL with INT32 as according to MSDN they are typedefed.
This keeps the ABI compatible and fixes the wrong data type.

7 years agoFixed use of reserved keywords for include guards.
Armin Novak [Tue, 6 Jun 2017 12:01:41 +0000 (14:01 +0200)]
Fixed use of reserved keywords for include guards.

7 years agoFixed clang malloc integer overflow warnings.
Armin Novak [Tue, 30 May 2017 08:46:43 +0000 (10:46 +0200)]
Fixed clang malloc integer overflow warnings.

7 years agoFix TALOS issues
Armin Novak [Mon, 29 May 2017 08:50:22 +0000 (10:50 +0200)]
Fix TALOS issues

Fix the following issues identified by the CISCO TALOS project:
 * TALOS-2017-0336 CVE-2017-2834
 * TALOS-2017-0337 CVE-2017-2834
 * TALOS-2017-0338 CVE-2017-2836
 * TALOS-2017-0339 CVE-2017-2837
 * TALOS-2017-0340 CVE-2017-2838
 * TALOS-2017-0341 CVE-2017-2839

7 years agoMerge pull request #3956 from dodo040/smartcard
akallabeth [Thu, 20 Jul 2017 06:52:54 +0000 (08:52 +0200)]
Merge pull request #3956 from dodo040/smartcard

redirect specific smartcard readers

7 years agofix format code
dodo040 [Thu, 22 Jun 2017 08:35:51 +0000 (10:35 +0200)]
fix format code

7 years agofix smartcard argument parsing
dodo040 [Tue, 20 Jun 2017 15:59:58 +0000 (17:59 +0200)]
fix smartcard argument parsing

7 years agofix wrong declaration
dodo040 [Mon, 15 May 2017 15:17:08 +0000 (17:17 +0200)]
fix wrong declaration

7 years agoredirect specific smartcard readers
dodo040 [Mon, 15 May 2017 11:43:51 +0000 (13:43 +0200)]
redirect specific smartcard readers

7 years agoMerge pull request #4044 from akallabeth/disable_h264_if_not_compiled
Bernhard Miklautz [Wed, 19 Jul 2017 10:02:53 +0000 (12:02 +0200)]
Merge pull request #4044 from akallabeth/disable_h264_if_not_compiled

Disable h264 if no backend compiled in

7 years agoFixed variable assignment.
Armin Novak [Wed, 19 Jul 2017 09:36:28 +0000 (11:36 +0200)]
Fixed variable assignment.

7 years agoMerge pull request #4047 from akallabeth/win_gfx_fix
Bernhard Miklautz [Wed, 19 Jul 2017 09:24:57 +0000 (11:24 +0200)]
Merge pull request #4047 from akallabeth/win_gfx_fix

Always use software GFX for windows client.

7 years agoAdded warning on GFX channel load that it does not support acceleration.
Armin Novak [Wed, 19 Jul 2017 07:54:42 +0000 (09:54 +0200)]
Added warning on GFX channel load that it does not support acceleration.

7 years agoDon't use an option for WITH_GFX_H264
Bernhard Miklautz [Tue, 18 Jul 2017 14:17:37 +0000 (16:17 +0200)]
Don't use an option for WITH_GFX_H264

CMAKE_DEPENDENT_OPTION the option is initialized on the first run and
then saved. Later configuration changes are not considered anymore.
Therefor use an variable instead of an option here.

7 years agoAlways use software GFX for windows client.
Armin Novak [Tue, 18 Jul 2017 06:27:14 +0000 (08:27 +0200)]
Always use software GFX for windows client.

7 years agoReordered backends with regard to feature completeness.
Armin Novak [Tue, 18 Jul 2017 05:46:51 +0000 (07:46 +0200)]
Reordered backends with regard to feature completeness.

7 years agoMerge pull request #4041 from wayk/PathMakePathA
akallabeth [Mon, 17 Jul 2017 10:26:48 +0000 (12:26 +0200)]
Merge pull request #4041 from wayk/PathMakePathA

Fixed PathMakePathA (returned true even if it can't create the last f…

7 years agoReadded H264 struct pointers, keep API compatible.
Armin Novak [Mon, 17 Jul 2017 09:38:06 +0000 (11:38 +0200)]
Readded H264 struct pointers, keep API compatible.

7 years agoAdd 10.3 capability check.
Armin Novak [Mon, 17 Jul 2017 09:37:53 +0000 (11:37 +0200)]
Add 10.3 capability check.

7 years agoFixed config option.
Armin Novak [Mon, 17 Jul 2017 08:56:45 +0000 (10:56 +0200)]
Fixed config option.

7 years agoMerge pull request #4043 from rjcorrig/kb4020322
David Fort [Mon, 17 Jul 2017 08:45:32 +0000 (10:45 +0200)]
Merge pull request #4043 from rjcorrig/kb4020322

winpr: Updates time zone data to July 2017

7 years agoDeactivated all H264 related code paths.
Armin Novak [Mon, 17 Jul 2017 08:37:15 +0000 (10:37 +0200)]
Deactivated all H264 related code paths.

7 years agoDisable WITH_GFX_H264 if no backend compiled in.
Armin Novak [Mon, 17 Jul 2017 07:32:34 +0000 (09:32 +0200)]
Disable WITH_GFX_H264 if no backend compiled in.

7 years agoRemoved H264 dummy, did not work (crash on use)
Armin Novak [Mon, 17 Jul 2017 07:28:08 +0000 (09:28 +0200)]
Removed H264 dummy, did not work (crash on use)

7 years agoDisable GFX H264 if no backend compiled in.
Armin Novak [Mon, 17 Jul 2017 07:00:57 +0000 (09:00 +0200)]
Disable GFX H264 if no backend compiled in.

7 years agoUpdate time zone data to July 2017
Robert Corrigan [Fri, 14 Jul 2017 21:16:08 +0000 (17:16 -0400)]
Update time zone data to July 2017

7 years agoChange documented source of windowsZones.xml file
Robert Corrigan [Fri, 14 Jul 2017 21:15:32 +0000 (17:15 -0400)]
Change documented source of windowsZones.xml file

7 years agoFixed PathMakePathA (returned true even if it can't create the last folder of the...
François Dubois [Wed, 12 Jul 2017 18:47:08 +0000 (14:47 -0400)]
Fixed PathMakePathA (returned true even if it can't create the last folder of the path)

7 years agoMerge pull request #4039 from nfedera/fix-misc-compiler-warnings
Norbert Federa [Mon, 10 Jul 2017 16:23:01 +0000 (18:23 +0200)]
Merge pull request #4039 from nfedera/fix-misc-compiler-warnings

Fixed a few compiler warnings

7 years agoFixed a few compiler warnings
Norbert Federa [Mon, 10 Jul 2017 13:29:09 +0000 (15:29 +0200)]
Fixed a few compiler warnings

7 years agoMerge pull request #4038 from nfedera/fix-sample-server-pixmap-format
David Fort [Mon, 10 Jul 2017 10:04:02 +0000 (12:04 +0200)]
Merge pull request #4038 from nfedera/fix-sample-server-pixmap-format

Fixed sample server's wrong rfx pixel format

7 years agoFixed sample server's wrong rfx pixel format
Norbert Federa [Mon, 10 Jul 2017 09:31:42 +0000 (11:31 +0200)]
Fixed sample server's wrong rfx pixel format

7 years agoMerge pull request #4021 from scroogie/master
David Fort [Fri, 7 Jul 2017 13:08:06 +0000 (15:08 +0200)]
Merge pull request #4021 from scroogie/master

Fix compilation on RHEL 6.x by macro-guarding two functions

7 years agoMerge pull request #4029 from realjiangms/fix_shadow_fragment_size
David Fort [Fri, 7 Jul 2017 13:07:13 +0000 (15:07 +0200)]
Merge pull request #4029 from realjiangms/fix_shadow_fragment_size

server/shadow: Fix incorrect bitmap fragment update.

7 years agoMerge pull request #4033 from blino/wayland-fullscreen
akallabeth [Fri, 7 Jul 2017 07:14:15 +0000 (09:14 +0200)]
Merge pull request #4033 from blino/wayland-fullscreen

Add fullscreen support in Wayland clients

7 years agoMerge pull request #3992 from johnjmullen/fix-barcode-scanner
akallabeth [Fri, 7 Jul 2017 06:53:21 +0000 (08:53 +0200)]
Merge pull request #3992 from johnjmullen/fix-barcode-scanner

  Fix issue #3229 Barcode Scanner USB - missing double characters

7 years agoMerge pull request #4032 from blino/clipboard-build
David Fort [Wed, 5 Jul 2017 20:00:33 +0000 (22:00 +0200)]
Merge pull request #4032 from blino/clipboard-build

Fix clipboard POSIX build because of basename conflict

7 years agoFix clipboard POSIX build because of basename conflict
Olivier Blin [Mon, 3 Jul 2017 17:57:41 +0000 (19:57 +0200)]
Fix clipboard POSIX build because of basename conflict

FreeRDP/winpr/libwinpr/clipboard/posix.c:397:20: error: conflicting types for ‘basename’
 static const char* basename(const char* name)
                    ^
In file included from FreeRDP/winpr/include/winpr/collections.h:25:0,
                 from FreeRDP/winpr/libwinpr/clipboard/posix.c:37:
/usr/include/string.h:599:14: note: previous declaration of ‘basename’ was here
 extern char *basename (const char *__filename) __THROW __nonnull ((1));

7 years agoSupport fullscreen setting in wayland client
Olivier Blin [Mon, 3 Jul 2017 17:09:01 +0000 (19:09 +0200)]
Support fullscreen setting in wayland client

7 years agoImplement fullscreen for wayland shell surface
Olivier Blin [Mon, 3 Jul 2017 17:03:18 +0000 (19:03 +0200)]
Implement fullscreen for wayland shell surface

7 years agoserver/shadow: Fix incorrect bitmap fragment update.
zihao.jiang [Tue, 4 Jul 2017 15:48:07 +0000 (23:48 +0800)]
server/shadow: Fix incorrect bitmap fragment update.
Legacy bitmap update might fail with 'fast path update size (xxxxx) exceeds the client's maximum request size (xxxxx)'
Original code might update last fragment with exceeded fragment size incorrectly. Fix the logic to prevent it.

7 years agoMerge pull request #4024 from bmiklautz/fix_4022
David Fort [Thu, 29 Jun 2017 09:55:55 +0000 (11:55 +0200)]
Merge pull request #4024 from bmiklautz/fix_4022

Fix a regression introduced with PR #4013

7 years agoFix a regression introduced with PR #4013
Bernhard Miklautz [Thu, 29 Jun 2017 09:24:36 +0000 (11:24 +0200)]
Fix a regression introduced with PR #4013

If numWindowRects/numVisibilityRects is zero a realloc might either
return NULL or a free able memory. In the first case the introduced
regression caused a double free.
As 0 is a possible value that can be received in both cases rail was
broken.

Fixes #4022

7 years agoMerge pull request #4008 from hardening/h264_split
Bernhard Miklautz [Thu, 29 Jun 2017 08:29:03 +0000 (10:29 +0200)]
Merge pull request #4008 from hardening/h264_split

Split h264 subsystems in different files

7 years agoFix compilation on RHEL 6.x by macro-guarding two functions that were
Andre Gemuend [Tue, 27 Jun 2017 15:12:23 +0000 (17:12 +0200)]
Fix compilation on RHEL 6.x by macro-guarding two functions that were
added in gstreamer 0.10.31 (RHEL 6.x being on 0.10.29).

7 years agoMerge pull request #4013 from weizhenwei/master
David Fort [Fri, 23 Jun 2017 15:02:40 +0000 (17:02 +0200)]
Merge pull request #4013 from weizhenwei/master

fix FreeRDP some memory leak problem

7 years agocode format adjustment
weizhenwei [Fri, 23 Jun 2017 01:50:56 +0000 (09:50 +0800)]
code format adjustment

7 years agoremove redundant NULL pointer check
weizhenwei [Fri, 23 Jun 2017 01:44:40 +0000 (09:44 +0800)]
remove redundant NULL pointer check

7 years agoremove duplicate code when freeing drive
weizhenwei [Fri, 23 Jun 2017 01:28:42 +0000 (09:28 +0800)]
remove duplicate code when freeing drive

7 years agoremove useless NULL pointer check before free
weizhenwei [Fri, 23 Jun 2017 01:21:16 +0000 (09:21 +0800)]
remove useless NULL pointer check before free

7 years agoadd NULL pointer check and set freed pointers to NULL afterward
weizhenwei [Thu, 22 Jun 2017 09:53:51 +0000 (17:53 +0800)]
add NULL pointer check and set freed pointers to NULL afterward

7 years agorefactor to remove duplicate code and replace free+malloc with realloc
weizhenwei [Thu, 22 Jun 2017 02:21:20 +0000 (10:21 +0800)]
refactor to remove duplicate code and replace free+malloc with realloc

7 years agorefactor on redundant code copy
weizhenwei [Wed, 21 Jun 2017 14:07:07 +0000 (22:07 +0800)]
refactor on redundant code copy

7 years agofix compile error on win64.vs2010 platform
weizhenwei [Wed, 21 Jun 2017 07:43:41 +0000 (15:43 +0800)]
fix compile error on win64.vs2010 platform

7 years agofix memroy leak of window_icon->iconInfo at update_read_window_icon_order()
weizhenwei [Tue, 13 Jun 2017 09:12:20 +0000 (17:12 +0800)]
fix memroy leak of window_icon->iconInfo at update_read_window_icon_order()

7 years agofix memory leak of pKeys at xf_rail_invalidate_region()
weizhenwei [Tue, 13 Jun 2017 08:49:51 +0000 (16:49 +0800)]
fix memory leak of pKeys at xf_rail_invalidate_region()

7 years agofix memroy leak of fd at FindFirstFileW()
weizhenwei [Tue, 13 Jun 2017 08:46:37 +0000 (16:46 +0800)]
fix memroy leak of fd at FindFirstFileW()

7 years agofix memory leak at update->window->window_state.windowRects/visibilityRects at update...
weizhenwei [Tue, 13 Jun 2017 08:27:28 +0000 (16:27 +0800)]
fix memory leak at update->window->window_state.windowRects/visibilityRects at update_read_window_state_order()

7 years agofix memory leak at update->window->window_state.titleInfo.string at update_read_windo...
weizhenwei [Tue, 13 Jun 2017 08:08:20 +0000 (16:08 +0800)]
fix memory leak at update->window->window_state.titleInfo.string at update_read_window_state_order()

7 years agofix memory leak on rail_virtual_channel_event_data_received() -> StreamNew()
weizhenwei [Tue, 13 Jun 2017 07:51:14 +0000 (15:51 +0800)]
fix memory leak on rail_virtual_channel_event_data_received() -> StreamNew()

7 years agofix memory leak at drive_register_drive_path() and drive_free()
weizhenwei [Tue, 13 Jun 2017 07:26:01 +0000 (15:26 +0800)]
fix memory leak at drive_register_drive_path() and drive_free()

7 years agofix memory leak at rail_client_execute()
weizhenwei [Tue, 13 Jun 2017 07:16:09 +0000 (15:16 +0800)]
fix memory leak at rail_client_execute()

7 years agofix memroy leak on rail_recv_exec_result_order() execResult
weizhenwei [Tue, 13 Jun 2017 06:54:58 +0000 (14:54 +0800)]
fix memroy leak on rail_recv_exec_result_order() execResult

7 years agocode clean on free(update->window->monitored_desktop.windowIds);
weizhenwei [Tue, 13 Jun 2017 06:32:36 +0000 (14:32 +0800)]
code clean on free(update->window->monitored_desktop.windowIds);

7 years agofix memory leak on update->window->monitored_desktop.windowIds which is realloced...
weizhenwei [Fri, 9 Jun 2017 06:39:38 +0000 (14:39 +0800)]
fix memory leak on update->window->monitored_desktop.windowIds which is realloced at update_read_desktop_actively_monitored_order()

7 years agofix a memroy leak on rdpBitmap free
weizhenwei [Fri, 9 Jun 2017 02:31:00 +0000 (10:31 +0800)]
fix a memroy leak on rdpBitmap free

7 years agoFix openh264 backend compilation
David Fort [Tue, 20 Jun 2017 08:01:50 +0000 (10:01 +0200)]
Fix openh264 backend compilation

7 years agoFix variable declaration and win32 compilation
David Fort [Wed, 14 Jun 2017 14:14:19 +0000 (16:14 +0200)]
Fix variable declaration and win32 compilation

7 years agoSplit h264 subsystems in different files
David Fort [Wed, 14 Jun 2017 14:04:54 +0000 (16:04 +0200)]
Split h264 subsystems in different files

7 years agoMerge pull request #4003 from akallabeth/macos_mouse_wheel_shadow
David Fort [Wed, 14 Jun 2017 09:12:03 +0000 (11:12 +0200)]
Merge pull request #4003 from akallabeth/macos_mouse_wheel_shadow

Fixed shadow server mouse wheel mapping on MacOS

7 years agoFixed shadow server mouse wheel mapping on MacOS
Armin Novak [Tue, 13 Jun 2017 12:18:11 +0000 (14:18 +0200)]
Fixed shadow server mouse wheel mapping on MacOS

7 years agoMerge pull request #3989 from akallabeth/avc444_alignment_fix
David Fort [Sat, 10 Jun 2017 11:59:42 +0000 (13:59 +0200)]
Merge pull request #3989 from akallabeth/avc444_alignment_fix

Align width and height for AVC444 decoding to 16.

7 years agoMerge pull request #3996 from akallabeth/drive_size_fix
Martin Fleisz [Fri, 9 Jun 2017 11:33:07 +0000 (13:33 +0200)]
Merge pull request #3996 from akallabeth/drive_size_fix

Fix #3995: File size information

7 years agoFix #3995: File size information
Armin Novak [Fri, 9 Jun 2017 11:02:50 +0000 (13:02 +0200)]
Fix #3995: File size information

7 years agoMerge pull request #3905 from ilammy/x11-cliprdr/file-clipping
David Fort [Wed, 7 Jun 2017 19:20:34 +0000 (21:20 +0200)]
Merge pull request #3905 from ilammy/x11-cliprdr/file-clipping

Local-to-remote file clipping for xfreerdp

7 years agoFix issue #3229 Barcode Scanner USB - missing double characters
John Mullen [Mon, 5 Jun 2017 19:40:43 +0000 (15:40 -0400)]
Fix issue #3229 Barcode Scanner USB - missing double characters

With some usb barcode scanners, repeated characters do not appear in the freerdp session.
It looks like this is because the KeyRelease signal is not sent for the first character.
Removing this if check fixes the problem.

7 years agochannels/cliprdr: avoid possible integer overflow
ilammy [Thu, 1 Jun 2017 13:05:07 +0000 (16:05 +0300)]
channels/cliprdr: avoid possible integer overflow

If the server sends us garbage (or the client provides it) then it is
possible for the multiplication to overflow (as it is performed on
unsigned 32-bit values) which will result in a false positive failure of
the sanity check. Avoid it by rearranging arithmetics a little.

Keep the multiplication in the error message because we are interested
in the number of bytes in the stream and how it compares to the number
we have expected based on the presumed file count.

7 years agoAlign width and height for AVC444 decoding to 16.
Armin Novak [Thu, 1 Jun 2017 11:01:23 +0000 (13:01 +0200)]
Align width and height for AVC444 decoding to 16.

7 years agoMerge pull request #3987 from chipitsine/cppcheck
David Fort [Thu, 1 Jun 2017 08:06:42 +0000 (10:06 +0200)]
Merge pull request #3987 from chipitsine/cppcheck

resolve an issue found by cppcheck

7 years agoresolve an issue found by cppcheck:
Ilya Shipitsin [Wed, 31 May 2017 19:05:51 +0000 (00:05 +0500)]
resolve an issue found by cppcheck:

[libfreerdp/crypto/certificate.c:315] -> [libfreerdp/crypto/certificate.c:316]: (warning) Either the condition 'if(fingerprint&&fprint)' is redundant or there is possible null pointer dereference: fingerprint.

7 years agoMerge pull request #3969 from chipitsine/cppcheck
David Fort [Wed, 31 May 2017 14:48:12 +0000 (16:48 +0200)]
Merge pull request #3969 from chipitsine/cppcheck

resolve issue found by cppcheck

7 years agoMerge pull request #3986 from akallabeth/debug_fix
David Fort [Wed, 31 May 2017 10:02:31 +0000 (12:02 +0200)]
Merge pull request #3986 from akallabeth/debug_fix

Fixed missing external declaration (#3982)