Zhang Zhaolong [Wed, 11 Mar 2015 05:40:20 +0000 (13:40 +0800)]
core: fix incorrect usage of realloc.
realloc can handle the case that its first parameter is NULL.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:37:35 +0000 (12:37 +0800)]
crypto: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:31:50 +0000 (12:31 +0800)]
xf_cliprdr: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:29:37 +0000 (12:29 +0800)]
android_event: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:26:04 +0000 (12:26 +0800)]
cmdline: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:32:51 +0000 (11:32 +0800)]
common/file: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:27:39 +0000 (11:27 +0800)]
wf_cliprdr: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:17:52 +0000 (11:17 +0800)]
rail: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:10:28 +0000 (11:10 +0800)]
audin: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:04:36 +0000 (11:04 +0800)]
tsmf: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Hardening [Tue, 10 Mar 2015 22:36:17 +0000 (23:36 +0100)]
Merge pull request #2455 from WarheadsSE/fix-hostname-matching
Fix case sensitive hostname comparison in tls
Jason Plum [Tue, 10 Mar 2015 20:48:35 +0000 (16:48 -0400)]
Fix case sensitive hostname comparison in tls
To do this I've swapped _strnicmp with memcmp. Seemless, but does lock it to the restrictions of that function.
Signed-off-by: Jason Plum <jplum@archlinuxarm.org>
Martin Fleisz [Fri, 6 Mar 2015 10:33:30 +0000 (11:33 +0100)]
Merge pull request #2435 from llyzs/llyzs
Add openh264 encoder support.
Martin Fleisz [Thu, 5 Mar 2015 10:15:59 +0000 (11:15 +0100)]
Merge pull request #2436 from bmiklautz/warnings
Compiler warnings
Bernhard Miklautz [Tue, 3 Mar 2015 18:36:54 +0000 (19:36 +0100)]
build: fix compiler warnings
warning: redundant redeclaration
Tested with: 4.7.2 and 3.5.0-1~exp1
Bernhard Miklautz [Tue, 3 Mar 2015 18:25:42 +0000 (19:25 +0100)]
build: enable more warnings for gcc
Enable implicit-function-declaration and redundant-decls warnings when
compiling with gcc. redundant-decl useful for exported headers.
Bernhard Miklautz [Tue, 3 Mar 2015 09:29:58 +0000 (10:29 +0100)]
Merge pull request #2433 from abergmeier/master
Added support for finding OpenSLES with CMake + Android.
Vic Lee [Mon, 16 Feb 2015 09:51:20 +0000 (17:51 +0800)]
Add openh264 encoder support.
Martin Fleisz [Mon, 2 Mar 2015 08:36:00 +0000 (09:36 +0100)]
Merge pull request #2428 from akallabeth/ios_color_fix
Fixed bitmap context for 15bit color depth
Andreas Bergmeier [Sun, 1 Mar 2015 20:16:56 +0000 (21:16 +0100)]
Added support for finding OpenSLES with CMake + Android.
Armin Novak [Thu, 26 Feb 2015 17:01:05 +0000 (18:01 +0100)]
Fixed bitmap context for 15bit color depth
Marc-André Moreau [Tue, 24 Feb 2015 14:55:44 +0000 (09:55 -0500)]
Merge pull request #2422 from akallabeth/nmake_warning_fixes
Fixes warning D9025 with NMake
Armin Novak [Mon, 23 Feb 2015 15:48:07 +0000 (16:48 +0100)]
Fixes warning D9025 with NMake
Norbert Federa [Mon, 23 Feb 2015 11:56:26 +0000 (12:56 +0100)]
Merge pull request #2416 from zavadovsky/transport_dead_end_fix
libfreerdp-core: fix dead-end state in transport_read_pdu()
Bernhard Miklautz [Mon, 23 Feb 2015 11:44:40 +0000 (12:44 +0100)]
Merge pull request #2415 from zavadovsky/android_fixes
Android fixes
Zavadovsky Yan [Mon, 23 Feb 2015 10:57:46 +0000 (13:57 +0300)]
libfreerdp-core: add comments for previous fix
Norbert Federa [Mon, 23 Feb 2015 10:00:06 +0000 (11:00 +0100)]
Merge pull request #2409 from bmiklautz/tcp_user_timeout
core/tcp: set TCP_USER_TIMEOUT if available
Zavadovsky Yan [Mon, 23 Feb 2015 08:50:32 +0000 (11:50 +0300)]
client/Android: fix coords calculation in previous commit
Marc-André Moreau [Mon, 23 Feb 2015 01:16:18 +0000 (20:16 -0500)]
Merge pull request #2417 from austin987/master
winpr/asn1: add ASN1_CreateDecoder/ASN1_Decode stubs
Austin English [Mon, 23 Feb 2015 01:11:11 +0000 (19:11 -0600)]
winpr/asn1: add ASN1_Decode stub
Austin English [Mon, 23 Feb 2015 01:09:58 +0000 (19:09 -0600)]
winpr/asn1: add ASN1_CreateDecoder stub
Zavadovsky Yan [Sat, 21 Feb 2015 21:07:25 +0000 (00:07 +0300)]
libfreerdp-core: fix dead-end state in transport_read_pdu()
Situation: we have fragmented TPKT PDU without two last bytes
(or one last byte - for fast-path) in network stack.
First call to transport_read_pdu() works normally, read
available bytes and exit with status 0 - no whole PDU readed.
Before second call this missed bytes arrive.
Optionally with next PDU.
In second call header parsing code unconditionally read this
two bytes(one byte) despite this is not header bytes.
And increase stream position, so stream now contains whole PDU.
This cause (pduLength - Stream_GetPosition(s)) calculation to be 0.
So transport_read_layer_bytes()-->transport_read_layer() return 0
and transport_read_pdu() exits with "not enough data is available"
status.
If next PDU isn't available next calls to transport_read_pdu()
give same result.
If next PDU arrive - (pduLength - Stream_GetPosition(s)) will be
less than 0. Stream position will grow, grow and grow on each call.
And transport_read_pdu() never signals that PDU is readed.
Caught on Android FreeRDP client with high RDP traffic (several MBytes/s).
Zavadovsky Yan [Sat, 21 Feb 2015 20:52:38 +0000 (23:52 +0300)]
client/Android: optimize android_end_paint() logic
1. Don't draw to screen if server sends begin/end paint
messages without any real updates.
2. Redraw only summary region that covers really invalidated
part of screen.
Zavadovsky Yan [Sat, 21 Feb 2015 20:49:29 +0000 (23:49 +0300)]
client/Android: fix bad realloc
Fast and long pointer moves cause app to crash.
Marc-André Moreau [Fri, 20 Feb 2015 20:48:36 +0000 (15:48 -0500)]
Merge pull request #2411 from awakecoding/master
SCardTransmit pioRecvPci Fix
Marc-André Moreau [Fri, 20 Feb 2015 20:39:51 +0000 (15:39 -0500)]
channels/smartcard: fix SCardTransmit return encoding with pioRecvPci
Bernhard Miklautz [Fri, 20 Feb 2015 12:22:01 +0000 (13:22 +0100)]
core/tcp: set TCP_USER_TIMEOUT if available
Keepalive settings are usually (depending on the implementation) only
used if the TCP connection is idle.
If the network is interrupted/disconnected/... click or keyboard input
generates outgoing traffic therefore the connection isn't idle
anymore and keepalives might not be used causing the connection to
stay open and the client to stall.
Linux 2.6.36 added a TCP_USER_TIMEOUT TCP socket option that lets a
program specify the maximum time transmitted data may remain
unacknowledged before TCP will close the corresponding connection with
ETIMEDOUT.
Setting TCP_USER_TIMEOUT allows us to detect a network problem (like
cable disconnect) even if the connection isn't idle.
Marc-André Moreau [Thu, 19 Feb 2015 21:15:35 +0000 (16:15 -0500)]
Merge pull request #2408 from dvincent-devolutions/gateway
TSGateway out channel recycling
Marc-André Moreau [Thu, 19 Feb 2015 21:06:20 +0000 (16:06 -0500)]
libfreerdp-core: improve RTS PDU receiving
Marc-André Moreau [Thu, 19 Feb 2015 20:06:57 +0000 (15:06 -0500)]
libfreerdp-core: cleanup channel recycling
Marc-André Moreau [Thu, 19 Feb 2015 19:11:12 +0000 (14:11 -0500)]
Merge branch 'gateway' of https://github.com/dvincent-devolutions/FreeRDP into gateway
Denis Vincent [Thu, 19 Feb 2015 18:41:00 +0000 (13:41 -0500)]
libfreerdp-core: add TS Gateway out channel recycling support
Marc-André Moreau [Thu, 19 Feb 2015 14:58:18 +0000 (09:58 -0500)]
Merge pull request #2405 from akallabeth/rdpsnd_winmm_silence
Debug messages now use WLog_DBG instead of WLog_ERR.
Marc-André Moreau [Thu, 19 Feb 2015 14:52:20 +0000 (09:52 -0500)]
Merge pull request #2406 from nfedera/fix-wlog-formats
wlog: wrong format specifiers, use LWP id on linux
Norbert Federa [Thu, 19 Feb 2015 13:47:03 +0000 (14:47 +0100)]
wlog: wrong format specifiers, use LWP id on linux
Armin Novak [Thu, 19 Feb 2015 07:45:45 +0000 (08:45 +0100)]
Debug messages now use WLog_DBG instead of WLog_ERR.
Marc-André Moreau [Wed, 18 Feb 2015 20:46:29 +0000 (15:46 -0500)]
Merge pull request #2404 from awakecoding/master
Fix BIO leaks
Marc-André Moreau [Wed, 18 Feb 2015 20:36:57 +0000 (15:36 -0500)]
libfreerdp-core: fix BIO leaks
Marc-André Moreau [Wed, 18 Feb 2015 18:56:25 +0000 (13:56 -0500)]
Merge pull request #2403 from awakecoding/master
Transport, Gateway, Sockets
Marc-André Moreau [Wed, 18 Feb 2015 18:50:03 +0000 (13:50 -0500)]
libfreerdp-core: fix tsg_get_event_handles
Marc-André Moreau [Wed, 18 Feb 2015 18:42:28 +0000 (13:42 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Wed, 18 Feb 2015 18:42:19 +0000 (13:42 -0500)]
Merge pull request #2402 from nfedera/fix-2015-02-18-01
core: fix refreshRect/suppressOutput capabilities
Marc-André Moreau [Wed, 18 Feb 2015 18:35:33 +0000 (13:35 -0500)]
libwinpr-winsock: implement interface listing with WSAIoctl
Norbert Federa [Wed, 18 Feb 2015 18:33:19 +0000 (19:33 +0100)]
core: fix refreshRect/suppressOutput capabilities
refreshRectSupport and suppressOutputSupport of the General
Capability Set (MS-RDPBCGR 2.2.7.1.1) are server-only flags
that indicate whether the Refresh Rect or Suppress Output
PDUs are supported by the server.
Therefore in rdp_read_general_capability_set() we must only
change the respective settings if we are not in server mode.
Marc-André Moreau [Wed, 18 Feb 2015 14:51:11 +0000 (09:51 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Wed, 18 Feb 2015 14:50:46 +0000 (09:50 -0500)]
Merge pull request #2397 from hardening/nego_fix2
Fix disconnection when negociation has failed
Marc-André Moreau [Wed, 18 Feb 2015 14:50:37 +0000 (09:50 -0500)]
Merge pull request #2398 from bjcollins/master
Fix the command line argument array setup for decorations flag
Marc-André Moreau [Wed, 18 Feb 2015 14:49:55 +0000 (09:49 -0500)]
Merge pull request #2401 from bmiklautz/extend_wtsapi
Extend wtsapi with WTSStartRemoteControlSessionEx
Marc-André Moreau [Wed, 18 Feb 2015 02:01:27 +0000 (21:01 -0500)]
libfreerdp-core: cleanup connect error codes, fix Win32 NLA
Marc-André Moreau [Tue, 17 Feb 2015 23:44:09 +0000 (18:44 -0500)]
libwinpr-synch: fix test build on Win32
Marc-André Moreau [Tue, 17 Feb 2015 21:36:01 +0000 (16:36 -0500)]
libfreerdp-core: initial support for tsg silent reauth
Marc-André Moreau [Tue, 17 Feb 2015 21:15:57 +0000 (16:15 -0500)]
libfreerdp-core: refactor TsProxy* calls
Marc-André Moreau [Tue, 17 Feb 2015 19:34:42 +0000 (14:34 -0500)]
libfreerdp-core: improve tsg debug output and reauth sequence
Marc-André Moreau [Tue, 17 Feb 2015 15:54:39 +0000 (10:54 -0500)]
libfreerdp-core: fix tsg buffer flushing
Marc-André Moreau [Mon, 16 Feb 2015 20:35:51 +0000 (15:35 -0500)]
libfreerdp-core: partial tsg reauth support
Bernhard Miklautz [Mon, 16 Feb 2015 11:16:54 +0000 (12:16 +0100)]
wtsapi: add WTSStartRemoteControlSessionEx
WTSStartRemoteControlSession doesn't allow to specify additional flags
therefore add a new extended version WTSStartRemoteControlSessionEx
with an additional "flags" parameter.
The following flags are defined:
REMOTECONTROL_FLAG_DISABLE_KEYBOARD - disable keyboard input
REMOTECONTROL_FLAG_DISABLE_MOUSE - disable mouse input
REMOTECONTROL_FLAG_DISABLE_INPUT - disable input (keyboard and mouse)
Bernhard Miklautz [Mon, 16 Feb 2015 11:14:20 +0000 (12:14 +0100)]
gitignore: ignore clion files
Marc-André Moreau [Sun, 15 Feb 2015 23:22:49 +0000 (18:22 -0500)]
libfreerdp-core: improve TSProxyCreateTunnelRequest
Marc-André Moreau [Sun, 15 Feb 2015 21:04:59 +0000 (16:04 -0500)]
libfreerdp-core: make NLA event-driven
Marc-André Moreau [Sun, 15 Feb 2015 19:54:10 +0000 (14:54 -0500)]
libfreerdp-core: prepare client-side NLA for event-driven structure
Marc-André Moreau [Sun, 15 Feb 2015 16:10:14 +0000 (11:10 -0500)]
libfreerdp-core: NLA cleanup
Marc-André Moreau [Sun, 15 Feb 2015 15:06:17 +0000 (10:06 -0500)]
libfreerdp-core: further abstract multiple connections used internally by tsg from rdpTransport
Marc-André Moreau [Sat, 14 Feb 2015 15:14:13 +0000 (10:14 -0500)]
libfreerdp-core: replace rdpTcp by BufferedSocket BIO
Marc-André Moreau [Fri, 13 Feb 2015 21:51:08 +0000 (16:51 -0500)]
libfreerdp-core: more rdpTcp refactoring
Marc-André Moreau [Fri, 13 Feb 2015 21:02:37 +0000 (16:02 -0500)]
libfreerdp-core: rewrite tls_write_all to use front BIO only
bjcollins [Fri, 13 Feb 2015 20:57:52 +0000 (14:57 -0600)]
Fix the command line argument array setup for decorations argument. The initial value was set for the wrong field in the structure. The decorations is correctly initialized to on
anyways, but this is the correct formatting for the array element.
Marc-André Moreau [Fri, 13 Feb 2015 20:22:27 +0000 (15:22 -0500)]
libfreerdp-core: move wait_read/wait_write operations under BIO layer
Marc-André Moreau [Fri, 13 Feb 2015 19:26:02 +0000 (14:26 -0500)]
libfreerdp-core: move some rdpTcp operations under BIO layer
David FORT [Fri, 13 Feb 2015 17:25:50 +0000 (18:25 +0100)]
Fix disconnection when negociation has failed
This patch fixes a bug with mstsc connecting to a RDP security only FreeRDP server.
It seems like the mstsc shipped with Windows Seven considers packets after the nego_failure
packet as an error. So after trying to do TLS, depending on the timing, mstsc can print an
error message instead of retrying to connect with RDP security. With this patch, we
don't send the MCS disconnect message when the negociation has failed.
Marc-André Moreau [Fri, 13 Feb 2015 14:27:54 +0000 (09:27 -0500)]
libfreerdp-core: fix transport crash, reduce rdpTcp usage
Marc-André Moreau [Fri, 13 Feb 2015 13:41:47 +0000 (08:41 -0500)]
libfreerdp-core: fix server-side transport_attach crash
Marc-André Moreau [Fri, 13 Feb 2015 12:09:39 +0000 (07:09 -0500)]
Merge pull request #2392 from nfedera/fix-2015-02-12-01
winpr: stream ctest and missing read/peek types
Marc-André Moreau [Thu, 12 Feb 2015 21:22:25 +0000 (16:22 -0500)]
libfreerdp-core: remove TlsIn/TlsOut from rdpTransport
Marc-André Moreau [Thu, 12 Feb 2015 19:52:48 +0000 (14:52 -0500)]
Merge pull request #2394 from awakecoding/master
TS Gateway Connection and ADM Refactoring
Marc-André Moreau [Thu, 12 Feb 2015 19:40:26 +0000 (14:40 -0500)]
libfreerdp-core: handle TCP/TLS connection at TSG RPC channel level
Marc-André Moreau [Thu, 12 Feb 2015 19:08:38 +0000 (14:08 -0500)]
libfreerdp-core: more tsg in/out channel refactoring
Marc-André Moreau [Thu, 12 Feb 2015 18:14:43 +0000 (13:14 -0500)]
libfreerdp-core: integrate new RTS pdu functions from denis
Norbert Federa [Thu, 12 Feb 2015 17:13:06 +0000 (18:13 +0100)]
winpr: stream ctest and missing read/peek types
Marc-André Moreau [Thu, 12 Feb 2015 17:03:15 +0000 (12:03 -0500)]
libfreerdp-core: improve TSG virtual connection and channel management
Marc-André Moreau [Thu, 12 Feb 2015 15:15:14 +0000 (10:15 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Thu, 12 Feb 2015 15:14:23 +0000 (10:14 -0500)]
Merge pull request #2386 from bjcollins/master
Fix remote app in xfreerdp.
Marc-André Moreau [Thu, 12 Feb 2015 15:12:01 +0000 (10:12 -0500)]
Merge pull request #2385 from hardening/nego_fix
Fix server-side protocol negociation
Hardening [Thu, 12 Feb 2015 10:21:09 +0000 (11:21 +0100)]
Merge pull request #2377 from bmiklautz/wtsapi_tests
wtsapi: add TestWtsApiExtra
Bernhard Miklautz [Thu, 12 Feb 2015 09:45:43 +0000 (10:45 +0100)]
Merge pull request #2388 from MartinHaimberger/mh-wtsapi-handler
wtsapi: added handler for LogonUser and LogoffUser
Martin Fleisz [Thu, 12 Feb 2015 09:42:55 +0000 (10:42 +0100)]
Merge pull request #2379 from streetdragon/master
Replaced ternary operator with condition only
Martin Haimberger [Thu, 12 Feb 2015 09:31:00 +0000 (01:31 -0800)]
wtsapi: added handler for LogonUser and LogoffUser
bjcollins [Wed, 11 Feb 2015 23:24:06 +0000 (17:24 -0600)]
Fix remote app in xfreerdp.
Remove use of the visibleOffset, this completely breaks the display of all windows except for the main application window. Instead,
just maintain a local offset correction of the windowOffset.
Apply workaround to determining the workArea for remote app mode.
David FORT [Wed, 11 Feb 2015 20:38:32 +0000 (21:38 +0100)]
Fix server-side protocol negociation
Before this patch, RDP security was (wrongly) the fallback when negociating a
security protocol between the client and the server. For example when a client
was claiming TLS-only when connecting to a FreeRDP based-server with RDP security only,
the result of the negociation was that the server started to do RDP security.
The expected behaviour is to send a nego failure packet with error code
SSL_NOT_ALLOWED_BY_SERVER. This patch fixes this.
We also try to handle all cases of failed negociation and return the corresponding
error code.
Marc-André Moreau [Wed, 11 Feb 2015 20:26:22 +0000 (15:26 -0500)]
libfreerdp-core: refactor tsg virtual connection, in/out channels
Marc-André Moreau [Wed, 11 Feb 2015 19:27:29 +0000 (14:27 -0500)]
libfreerdp-core: gateway connection refactoring