platform/upstream/dotnet/runtime.git
7 years agoMerge pull request dotnet/coreclr#7776 from sivarv/lsraStatFix
Sivarv [Mon, 24 Oct 2016 20:44:43 +0000 (13:44 -0700)]
Merge pull request dotnet/coreclr#7776 from sivarv/lsraStatFix

Fix the condition to dump a basic block stats.

Commit migrated from https://github.com/dotnet/coreclr/commit/c537c3f54282fae452f85a3975a39a7ec1c35bba

7 years agoMerge pull request dotnet/coreclr#7775 from ianhays/cfg_arm64
Ian Hays [Mon, 24 Oct 2016 19:58:19 +0000 (12:58 -0700)]
Merge pull request dotnet/coreclr#7775 from ianhays/cfg_arm64

Add CFG flag to ARM64 build

Commit migrated from https://github.com/dotnet/coreclr/commit/31d3cf041eff655d92a9a4925e1e8b1f7cc7f11e

7 years agoMerge pull request dotnet/coreclr#7772 from jkotas/gcinfo-cleanup
Jan Kotas [Mon, 24 Oct 2016 18:51:06 +0000 (11:51 -0700)]
Merge pull request dotnet/coreclr#7772 from jkotas/gcinfo-cleanup

GCInfoDecoder cleanup

Commit migrated from https://github.com/dotnet/coreclr/commit/6c4d3ac8536912009cc6b64ed580a1bc8420f0e5

7 years agoFix the condition to dump a basic block stats.
sivarv [Mon, 24 Oct 2016 18:42:03 +0000 (11:42 -0700)]
Fix the condition to dump a basic block stats.

Commit migrated from https://github.com/dotnet/coreclr/commit/dadc45fdf8fe0a61b0f020046ebfa62485d960f2

7 years agoAdd CFG flag to ARM64 build
Ian Hays [Mon, 24 Oct 2016 18:04:03 +0000 (11:04 -0700)]
Add CFG flag to ARM64 build

Commit migrated from https://github.com/dotnet/coreclr/commit/df09c7b50a0d8f112b67f0525b0620a7dc00355f

7 years agoMerge pull request dotnet/coreclr#7720 from Dmitry-Me/fixBrokenComparison
Pat Gavlin [Mon, 24 Oct 2016 15:54:25 +0000 (08:54 -0700)]
Merge pull request dotnet/coreclr#7720 from Dmitry-Me/fixBrokenComparison

Fix broken range check

Commit migrated from https://github.com/dotnet/coreclr/commit/de41f232a5e90c2a0d663d9f1eb8d3abe7117188

7 years agoReplace LPVOID with void*
Jan Kotas [Mon, 24 Oct 2016 14:59:16 +0000 (07:59 -0700)]
Replace LPVOID with void*

Commit migrated from https://github.com/dotnet/coreclr/commit/8ad166a44d54c2d9a9ef8b7629f361a05bb364dc

7 years agoSimplify GCINFODECODER_CONTRACT
Jan Kotas [Mon, 24 Oct 2016 04:31:29 +0000 (21:31 -0700)]
Simplify GCINFODECODER_CONTRACT

Commit migrated from https://github.com/dotnet/coreclr/commit/c490aa1355fc4db332124c089d787d673cfae9bc

7 years agoDelete DISABLE_EH_VECTORS
Jan Kotas [Mon, 24 Oct 2016 04:11:49 +0000 (21:11 -0700)]
Delete DISABLE_EH_VECTORS

Commit migrated from https://github.com/dotnet/coreclr/commit/3e71169287f5f4deae73151aea0567148a15062a

7 years agoDelete _TARGET_SET_ macro
Jan Kotas [Mon, 24 Oct 2016 01:21:22 +0000 (18:21 -0700)]
Delete _TARGET_SET_ macro

Commit migrated from https://github.com/dotnet/coreclr/commit/2d07bf2e857f22b8303edbd06c545790039a8f3e

7 years agoFixed month calculating issue of calendars(dotnet/coreclr#7666) (dotnet/coreclr#7769)
Jim Ma [Sat, 22 Oct 2016 16:19:57 +0000 (00:19 +0800)]
Fixed month calculating issue of calendars(dotnet/coreclr#7666) (dotnet/coreclr#7769)

Fixed the issue introduced by misunderstanding the precedence of '+' and
'>>'.

fix dotnet/coreclr#7666

Commit migrated from https://github.com/dotnet/coreclr/commit/817c8397e5bcd4592dfaaaea3a03714ba5c3d3d8

7 years agoFix Binder based PInvoke resolution for dynamic assembly (dotnet/coreclr#7770)
Gaurav Khanna [Sat, 22 Oct 2016 16:18:26 +0000 (09:18 -0700)]
Fix Binder based PInvoke resolution for dynamic assembly (dotnet/coreclr#7770)

Commit migrated from https://github.com/dotnet/coreclr/commit/5ff10a5b41d5481e21df9bbf5a4e8b419895530d

7 years agoFixing the StackOverflowException error message. (dotnet/coreclr#4786)
Vijay Ramakrishnan [Sat, 22 Oct 2016 11:51:20 +0000 (04:51 -0700)]
Fixing the StackOverflowException error message. (dotnet/coreclr#4786)

Commit migrated from https://github.com/dotnet/coreclr/commit/24a6c7908f2582fb8628e53fe3d02306f6fba43c

7 years agoFixed typos and format issues on clr-code-guide doc(dotnet/coreclr#7767) (dotnet...
Jim Ma [Sat, 22 Oct 2016 11:13:17 +0000 (19:13 +0800)]
Fixed typos and format issues on clr-code-guide doc(dotnet/coreclr#7767) (dotnet/coreclr#7768)

There're several typos and format issues. Just fixed them.

Fix issue dotnet/coreclr#7767

Commit migrated from https://github.com/dotnet/coreclr/commit/73b4f008866b153a4d86785b648de4a281981c9e

7 years agoPort GC changes from CoreRT (dotnet/coreclr#7764)
Jan Kotas [Sat, 22 Oct 2016 05:07:29 +0000 (22:07 -0700)]
Port GC changes from CoreRT (dotnet/coreclr#7764)

https://github.com/dotnet/corert/pull/2064: Add back limit for maximum object size
https://github.com/dotnet/corert/pull/2061: Fix retail build break

Commit migrated from https://github.com/dotnet/coreclr/commit/a0ae251eed00dfb5f5dc8dd3769c15c300c7502c

7 years agoFix broken #elif (dotnet/coreclr#7756)
Dmitry-Me [Sat, 22 Oct 2016 04:05:09 +0000 (07:05 +0300)]
Fix broken #elif (dotnet/coreclr#7756)

Commit migrated from https://github.com/dotnet/coreclr/commit/6c7bcaf51c9ed8fdf1253e05429291d56fc56509

7 years agoAdd Profiling API callbacks for R2R methods (dotnet/coreclr#7732)
Mukul Sabharwal [Sat, 22 Oct 2016 02:45:06 +0000 (19:45 -0700)]
Add Profiling API callbacks for R2R methods (dotnet/coreclr#7732)

Commit migrated from https://github.com/dotnet/coreclr/commit/ac0cb2fb119f45bd653d44ba9e4a2abed6a23000

7 years agoMerge pull request dotnet/coreclr#7749 from sivarv/VectorIntDot
Sivarv [Sat, 22 Oct 2016 02:36:25 +0000 (19:36 -0700)]
Merge pull request dotnet/coreclr#7749 from sivarv/VectorIntDot

Recognize Vector<int>.Dot on AVX as a JIT intrinsic.

Commit migrated from https://github.com/dotnet/coreclr/commit/437b45edab4d07adc220607a3448624ccfcdab9f

7 years agoImprove ArraySegment's override of GetHashCode (dotnet/coreclr#4654)
James Ko [Sat, 22 Oct 2016 01:21:27 +0000 (21:21 -0400)]
Improve ArraySegment's override of GetHashCode (dotnet/coreclr#4654)

* Improve ArraySegment's override of GetHashCode

* Use new implementation suggested by @VSadov

* Respond to PR feedback

* Remove the workaround for object.GetHashCode

* Respond to HashHelpers changes

* Fix compile errors.

Commit migrated from https://github.com/dotnet/coreclr/commit/15ea0086a7e6f87e8237923684e100e3e1f44698

7 years agoMerge pull request dotnet/coreclr#7739 from pgavlin/DisableGCStressIncompatibleTests
Pat Gavlin [Sat, 22 Oct 2016 01:21:01 +0000 (18:21 -0700)]
Merge pull request dotnet/coreclr#7739 from pgavlin/DisableGCStressIncompatibleTests

Mark tests GCStress-incompatible for x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/940a6f0d7277f368fc2e3d25b527e27242639141

7 years agoMerge pull request dotnet/coreclr#7760 from pgavlin/VSO279832
Pat Gavlin [Sat, 22 Oct 2016 00:24:17 +0000 (17:24 -0700)]
Merge pull request dotnet/coreclr#7760 from pgavlin/VSO279832

Properly initialize the varargs base lclVar.

Commit migrated from https://github.com/dotnet/coreclr/commit/eb6b52c30d616eb1378f30138c0b5115e69515fb

7 years agoMerge pull request dotnet/coreclr#7759 from pgavlin/VSO278367
Pat Gavlin [Sat, 22 Oct 2016 00:22:49 +0000 (17:22 -0700)]
Merge pull request dotnet/coreclr#7759 from pgavlin/VSO278367

Initialize long return type descs in `gtNewCallNode`.

Commit migrated from https://github.com/dotnet/coreclr/commit/cf708032c8c6d4463e3db204d1780700554c43b6

7 years agoInitialize member variable (dotnet/coreclr#7737)
Dmitry-Me [Fri, 21 Oct 2016 23:38:45 +0000 (02:38 +0300)]
Initialize member variable (dotnet/coreclr#7737)

Commit migrated from https://github.com/dotnet/coreclr/commit/5738641d34502b0206c3c09cf85aae75e632994a

7 years agoOptimize Vector<int>.Dot on AVX.
sivarv [Thu, 20 Oct 2016 21:46:00 +0000 (14:46 -0700)]
Optimize Vector<int>.Dot on AVX.

Commit migrated from https://github.com/dotnet/coreclr/commit/1c8f29584f5ddebc4ea412283ca3811a0932ed22

7 years agoMerge pull request dotnet/coreclr#7755 from dotnet-bot/from-tfs
Bruce Forstall [Fri, 21 Oct 2016 22:50:36 +0000 (15:50 -0700)]
Merge pull request dotnet/coreclr#7755 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/91dcfe1d0b529e3999e44029fe14ac428f705fe9

7 years agoMerge pull request dotnet/coreclr#7754 from ramarag/Threading
Rama krishnan Raghupathy [Fri, 21 Oct 2016 22:40:14 +0000 (15:40 -0700)]
Merge pull request dotnet/coreclr#7754 from ramarag/Threading

Exposing Some Threading Apis

Commit migrated from https://github.com/dotnet/coreclr/commit/0a972deb9e3ea53e52e06dbaeb19b95be0879cc2

7 years agoAdding Isafeserializationdata interface
Rama Krishnan Raghupathy [Fri, 21 Oct 2016 22:25:49 +0000 (15:25 -0700)]
Adding Isafeserializationdata interface

Commit migrated from https://github.com/dotnet/coreclr/commit/0bd8f2a02da9092919592231c5bb170f72181864

7 years agoProperly initialize the varargs base lclVar.
Pat Gavlin [Fri, 21 Oct 2016 21:39:18 +0000 (14:39 -0700)]
Properly initialize the varargs base lclVar.

The code that initializes this lclVar was not using the correct helper
to determine whether or not a lclVar was enregistered at the beginning
of a method.

Commit migrated from https://github.com/dotnet/coreclr/commit/dc593b5fc380ef1477ed33ba0356792c3dc5e1b6

7 years agoMerge pull request dotnet/coreclr#7672 from sandreenko/helper-for-corert
sandreenko [Fri, 21 Oct 2016 21:19:18 +0000 (14:19 -0700)]
Merge pull request dotnet/coreclr#7672 from sandreenko/helper-for-corert

Ready to run helper for static base lookups in shared generic code

Commit migrated from https://github.com/dotnet/coreclr/commit/0c77118cb8825163eaa60c9df3e460b9901ebd8b

7 years agoMerge pull request dotnet/coreclr#7743 from sandreenko/frozen_strings
sandreenko [Fri, 21 Oct 2016 21:09:30 +0000 (14:09 -0700)]
Merge pull request dotnet/coreclr#7743 from sandreenko/frozen_strings

fix value numbering for frozen strings.

Commit migrated from https://github.com/dotnet/coreclr/commit/65556875ba1c7cb07360bbbee0008556fd51572a

7 years agoInitialize long return type descs in `gtNewCallNode`.
Pat Gavlin [Fri, 21 Oct 2016 21:03:58 +0000 (14:03 -0700)]
Initialize long return type descs in `gtNewCallNode`.

All long-returning calls (including helper calls) must have a properly
initialized ReturnTypeDesc. Previously, this ReturnTypeDesc was only
initialized by the importer for a subset of long-returning calls
(essentially user calls), which caused asserts whenother long-returning
calls were created by the compiler (e.g. for field accessors). This
change moves the necessary ReturnTypeDesc initialization into
`gtNewCallNode`.

Commit migrated from https://github.com/dotnet/coreclr/commit/b2b0b914a68a9a74c8b8685851afb2f874246428

7 years ago[GDBJIT] Generate more complete debug information (dotnet/coreclr#7617)
kvochko [Fri, 21 Oct 2016 09:17:38 +0000 (12:17 +0300)]
[GDBJIT] Generate more complete debug information (dotnet/coreclr#7617)

* Implement support for classes
* Add support for 'this' argument type
* System.String debug info
* Functions are generated as class members in DWARF, use TypeKey as type key.
* Initial support of references
* Support 'this' artificial argument in gdbjit
* Resolve issue with recursive types in gdbjit
* DWARF classes are terminated even if they don't have children
* Fix System.Char encoding.
* Add support static fields for classes
* Add support for single dimension arrays.
* Simplify signature parsing.
* Preliminary support for multidimensional arrays.
* Add support of value types

Commit migrated from https://github.com/dotnet/coreclr/commit/3a9ee939d1043f8347ce94a49bb38d517e3bb52d

7 years agoMerge pull request dotnet/coreclr#7736 from hseok-oh/fix_7649
Maoni Stephens [Fri, 21 Oct 2016 04:47:19 +0000 (21:47 -0700)]
Merge pull request dotnet/coreclr#7736 from hseok-oh/fix_7649

GC for large object allocation when fail to get new segment

Commit migrated from https://github.com/dotnet/coreclr/commit/59c8c059bd474bf8105059de86bd3b22d92bc5c0

7 years agoMerge pull request dotnet/coreclr#7724 from adiaaida/implementDecomposeRotate
Michelle McDaniel [Fri, 21 Oct 2016 03:50:23 +0000 (23:50 -0400)]
Merge pull request dotnet/coreclr#7724 from adiaaida/implementDecomposeRotate

Implement DecomposeRotate

Commit migrated from https://github.com/dotnet/coreclr/commit/fd13c8956ac768649b41f50fd046dbc3547d36a4

7 years agoMerge pull request dotnet/coreclr#7745 from dotnet-bot/from-tfs
Jan Kotas [Fri, 21 Oct 2016 03:45:43 +0000 (20:45 -0700)]
Merge pull request dotnet/coreclr#7745 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/21f4c8f7440fc2dddca366206356f3b9d57daf79

7 years agoExposing Some Threading Apis
Rama Krishnan Raghupathy [Fri, 21 Oct 2016 02:51:47 +0000 (19:51 -0700)]
Exposing Some Threading Apis

Commit migrated from https://github.com/dotnet/coreclr/commit/c18542c420e2b095bf6e90643bc1738974217d8f

7 years agoMerge pull request dotnet/coreclr#7727 from AndyAyersMS/LateGCStructBailOut
Andy Ayers [Fri, 21 Oct 2016 01:47:38 +0000 (18:47 -0700)]
Merge pull request dotnet/coreclr#7727 from AndyAyersMS/LateGCStructBailOut

Inliner: avoid inlining callees with GC structs on cold paths

Commit migrated from https://github.com/dotnet/coreclr/commit/e70eadba0eb182f046f9be85833a23784c6d675f

7 years agoGC for large object allocation when fail to get new segment
Hyeongseok Oh [Thu, 20 Oct 2016 10:23:53 +0000 (19:23 +0900)]
GC for large object allocation when fail to get new segment

Delete unnecessary line

Commit migrated from https://github.com/dotnet/coreclr/commit/6f09643f0a8d550eaa6e4f5ad131955b6eefdab9

7 years agoUpdating the macro redefinition for _isnanf and _copysignf in floatsingle.cpp. This...
dotnet-bot [Thu, 20 Oct 2016 23:18:59 +0000 (16:18 -0700)]
Updating the macro redefinition for _isnanf and _copysignf in floatsingle.cpp. This is required for the scenario when the system CRT header files are used instead of the newer MSVCRT header files.

[tfs-changeset: 1634419]

Commit migrated from https://github.com/dotnet/coreclr/commit/890e5f93914396ac2cdd502809d15984d2d4db15

7 years agoFix build break
Jan Kotas [Thu, 20 Oct 2016 22:55:30 +0000 (15:55 -0700)]
Fix build break

[tfs-changeset: 1634415]

Commit migrated from https://github.com/dotnet/coreclr/commit/347cc35af5e5676ab57ba23a16624a6d6ce002d6

7 years agofix value numbering for frozen strings
Sergey Andreenko [Thu, 20 Oct 2016 22:49:08 +0000 (15:49 -0700)]
fix value numbering for frozen strings

As Pat found it was value numbering issue.

Commit migrated from https://github.com/dotnet/coreclr/commit/953b945d2d5dac2821e76a59b5ffb5e8fe89d2ad

7 years agoAdd comments describing why these tests are disabled.
Pat Gavlin [Thu, 20 Oct 2016 22:30:29 +0000 (15:30 -0700)]
Add comments describing why these tests are disabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/247d956f4e6231fcda23210feeb0c86d1690c485

7 years agoImplement DecomposeRotate
Michelle McDaniel [Wed, 19 Oct 2016 17:43:15 +0000 (10:43 -0700)]
Implement DecomposeRotate

fgRecognizeAndMorphBitwiseRotation can potentially morph a tree with a
TYP_LONG return type on x86 if the rotate amount is a GT_CNS_INT. This
change implements DecomposeRotate for those rotate instructions. There are
5 cases:

1) Rotate by 0: do nothing.
2) Rotate by 32: swap hi and lo.
3) Rotate by < 32: produce a shld/shld (for GT_ROL) or a shrd/shrd (for
GT_ROR).
4) Rotate by >= 32: swap hi and lo, subtract from the rotate amount 32, and
do option 3.
5) Rotate by >= 64: do rotateAmount % 64 to get the rotate amount between
0 and 63, then do one of options 1-4.

This change also updates CodegenBringUpTests\Rotate.cs to exercise these
paths.

Commit migrated from https://github.com/dotnet/coreclr/commit/d24a3008cd1bbed78dd4e82414228da6e21361d2

7 years agoMerge pull request dotnet/coreclr#7734 from JeremyKuhne/ArrayPool
Jeremy Kuhne [Thu, 20 Oct 2016 18:48:53 +0000 (11:48 -0700)]
Merge pull request dotnet/coreclr#7734 from JeremyKuhne/ArrayPool

Move ArrayPool to System.Private.CoreLib

Commit migrated from https://github.com/dotnet/coreclr/commit/74cbc9e2c42ffb01c84a68adb59a2ff35ae23333

7 years agoMerge pull request dotnet/coreclr#7730 from dotnet-bot/from-tfs
Bruce Forstall [Thu, 20 Oct 2016 18:30:34 +0000 (11:30 -0700)]
Merge pull request dotnet/coreclr#7730 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/9ea3efb93bf965148957274dc3af8bee9a218292

7 years agoMark tests GCStress-incompatible for x86.
Pat Gavlin [Thu, 20 Oct 2016 18:29:37 +0000 (11:29 -0700)]
Mark tests GCStress-incompatible for x86.

These tests time out when GC stress is enabled on x86.

Fixes dotnet/coreclr#7692 and dotnet/coreclr#7695.

Commit migrated from https://github.com/dotnet/coreclr/commit/7862e2c3c090454344e5047f7e5250a81c375d9a

7 years agoreturn add with offset, add version if-defs
Sergey Andreenko [Thu, 20 Oct 2016 17:38:15 +0000 (10:38 -0700)]
return add with offset, add version if-defs

Commit migrated from https://github.com/dotnet/coreclr/commit/ab97fb505212ee3d22ec6e5b7e6885040bd6b753

7 years agoFix Attribute implementations of Equals and GetHashCode to properly deal with derived...
Llewellyn Pritchard [Thu, 20 Oct 2016 17:32:02 +0000 (19:32 +0200)]
Fix Attribute implementations of Equals and GetHashCode to properly deal with derived types. dotnet/coreclr#6232 (dotnet/coreclr#6240)

Commit migrated from https://github.com/dotnet/coreclr/commit/9463e5d384c09fcc0c17a71c616b2bcb3d633c8a

7 years agoAdd cross-reference from test case to inspiring issue
Andy Ayers [Thu, 20 Oct 2016 17:24:54 +0000 (10:24 -0700)]
Add cross-reference from test case to inspiring issue

Commit migrated from https://github.com/dotnet/coreclr/commit/f6a14f199e22c657f394f4dd8c9325e77fffe7a8

7 years agoFixing the reference declarations for System.MathF. (dotnet/coreclr#7735)
Tanner Gooding [Thu, 20 Oct 2016 09:04:15 +0000 (02:04 -0700)]
Fixing the reference declarations for System.MathF. (dotnet/coreclr#7735)

Commit migrated from https://github.com/dotnet/coreclr/commit/e66fca59b40409829eec5dca5da827843dabaeff

7 years agoRemove misleading check (dotnet/coreclr#7654)
Dmitry-Me [Thu, 20 Oct 2016 00:25:48 +0000 (03:25 +0300)]
Remove misleading check (dotnet/coreclr#7654)

Commit migrated from https://github.com/dotnet/coreclr/commit/0e798126fc5c5d5cf045530c73d296e5aacc8b5d

7 years agoCall JIT compiler's shutdown logic from crossgen. (dotnet/coreclr#7663)
Peter Kukol [Wed, 19 Oct 2016 23:28:20 +0000 (17:28 -0600)]
Call JIT compiler's shutdown logic from crossgen. (dotnet/coreclr#7663)

* Call JIT compiler's shutdown logic from crossgen.

Commit migrated from https://github.com/dotnet/coreclr/commit/dcce190472393d828d3fb364e9e5fe5906c42822

7 years agoMerge pull request dotnet/coreclr#7733 from rahku/_appdomain
Rahul Kumar [Wed, 19 Oct 2016 23:16:09 +0000 (16:16 -0700)]
Merge pull request dotnet/coreclr#7733 from rahku/_appdomain

fix assembly.Load bug

Commit migrated from https://github.com/dotnet/coreclr/commit/d6dcbb66bace9a1f3fc081ec0740258b0c9358ea

7 years agoMove ArrayPool to System.Private.CoreLib
Jeremy Kuhne [Wed, 19 Oct 2016 23:02:52 +0000 (16:02 -0700)]
Move ArrayPool to System.Private.CoreLib

Copy ArrayPool source from CoreFX and expose in System.Private.CoreLib.

Commit migrated from https://github.com/dotnet/coreclr/commit/d6eecf7f7848d23f99ebc9d7312a59a7f12d2f16

7 years agofix assembly.Load bug
Rahul Kumar [Wed, 19 Oct 2016 22:09:16 +0000 (15:09 -0700)]
fix assembly.Load bug

Commit migrated from https://github.com/dotnet/coreclr/commit/b3e39e95a917decaf586f325ae66e387a298b50a

7 years agoMerge pull request dotnet/coreclr#7725 from CarolEidt/Fix278372
Carol Eidt [Wed, 19 Oct 2016 21:38:57 +0000 (14:38 -0700)]
Merge pull request dotnet/coreclr#7725 from CarolEidt/Fix278372

RyuJIT/x86: handle must-init multi-reg vars

Commit migrated from https://github.com/dotnet/coreclr/commit/a410ded42ba14ae87efa5e9627a5d300cc9aadc1

7 years agoMerge pull request dotnet/coreclr#7726 from dotnet-bot/from-tfs
Bruce Forstall [Wed, 19 Oct 2016 21:10:41 +0000 (14:10 -0700)]
Merge pull request dotnet/coreclr#7726 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/f18e23891aa657d849d7a30f6d4e423c97c3835c

7 years agoAdd comment to test case and run it through codeformatter.
Andy Ayers [Wed, 19 Oct 2016 20:51:34 +0000 (13:51 -0700)]
Add comment to test case and run it through codeformatter.

Commit migrated from https://github.com/dotnet/coreclr/commit/6bf79f0f1edf2de19175c1275372e782916f56a2

7 years agoRemove the UseLatestBehaviorWhenTFMNotSpecified compat switch (dotnet/coreclr#5708)
AlexGhiondea [Wed, 19 Oct 2016 20:24:40 +0000 (13:24 -0700)]
Remove the UseLatestBehaviorWhenTFMNotSpecified compat switch (dotnet/coreclr#5708)

* Default to latest behavior when a TFM is not specified

Instead of requiring that a compatibility switch is set in order to get the
latest behavior for all AppContext switches that are based on TFM, have that
behavior on by default.

* Remove the UseLatestBehaviorWhenTFMNotSpecified compat switch

Commit migrated from https://github.com/dotnet/coreclr/commit/0e4869a6930cfb6278b51130bbccfc323ef61053

7 years agoBetter Tuple hashing, avoid boxing in Equals/GetHashCode (dotnet/coreclr#6767)
James Ko [Wed, 19 Oct 2016 20:24:01 +0000 (16:24 -0400)]
Better Tuple hashing, avoid boxing in Equals/GetHashCode (dotnet/coreclr#6767)

Commit migrated from https://github.com/dotnet/coreclr/commit/361e6eb85c74b57691955d97dda801d725cd2a59

7 years agoMerge pull request dotnet/coreclr#7612 from BruceForstall/ELT
Bruce Forstall [Wed, 19 Oct 2016 20:14:54 +0000 (13:14 -0700)]
Merge pull request dotnet/coreclr#7612 from BruceForstall/ELT

Enable Enter/Leave/Tailcall hooks for RyuJIT/x86

Commit migrated from https://github.com/dotnet/coreclr/commit/a6c000b2890e28dd3f6a4b1afa30b035b3d2e47a

7 years agoFix arm32 build break
Rahul Kumar [Wed, 19 Oct 2016 20:03:43 +0000 (13:03 -0700)]
Fix arm32 build break

[tfs-changeset: 1634155]

Commit migrated from https://github.com/dotnet/coreclr/commit/d6de1c286130035629e6554ddb2ac2004abc4aad

7 years agocross/build-rootfs.sh: fix default UbuntuPackages for default BuildArch (dotnet/corec...
Steve Desmond [Wed, 19 Oct 2016 19:33:49 +0000 (15:33 -0400)]
cross/build-rootfs.sh: fix default UbuntuPackages for default BuildArch (dotnet/coreclr#7644)

* better default UbuntuPackages for default BuildArch
* Remove multiple sets of _UbuntuPackages to default

Commit migrated from https://github.com/dotnet/coreclr/commit/9f572b68ebbcedfebd05c956c2137492cc403253

7 years agoInliner: avoid inlining callees with GC structs on cold paths
Andy Ayers [Thu, 13 Oct 2016 01:00:13 +0000 (18:00 -0700)]
Inliner: avoid inlining callees with GC structs on cold paths

If an inline introduces a local or temp GC struct, the initialization
of that struct is done in the root method prolog. This can hurt
performance if the inline call site is cold. Detect this during
importation and update the inline policy to back out of the inline if
the inline is an always or discretionary candidate.

Jit diffs shows size wins in the core library with no regressions.
```
Total bytes of diff: -8789 (-0.29 % of base)
    diff is an improvement.
Total byte diff includes 0 bytes from reconciling methods
        Base had    0 unique methods,        0 unique bytes
        Diff had    0 unique methods,        0 unique bytes
Top file improvements by size (bytes):
       -8789 : System.Private.CoreLib.dasm (-0.29 % of base)
1 total files with size differences.
Top method improvements by size (bytes):
        -320 : System.Private.CoreLib.dasm - FrameSecurityDescriptor:CheckDemand2(ref,ref,long,bool):bool:this
        -224 : System.Private.CoreLib.dasm - RuntimeConstructorInfo:CheckCanCreateInstance(ref,bool)
        -214 : System.Private.CoreLib.dasm - RuntimeType:GetMethodBase(ref,long):ref
        -150 : System.Private.CoreLib.dasm - CultureInfo:GetCultureInfoByIetfLanguageTag(ref):ref
        -146 : System.Private.CoreLib.dasm - GC:RegisterForFullGCNotification(int,int)
103 total methods with size differences.
```
Desktop testing shows similar wins in a number of places and only
a few sparse small regressions.

Added a perf test. Thanks to @hypersw for noticing this.

Closes dotnet/coreclr#7569.

Commit migrated from https://github.com/dotnet/coreclr/commit/1e0359ce3e5d25ba4dbbe72336653ea1c94113ac

7 years agoUpdating the new `System.MathF` calls which already existed in `System.Math` to call...
Tanner Gooding [Wed, 19 Oct 2016 19:15:21 +0000 (12:15 -0700)]
Updating the new `System.MathF` calls which already existed in `System.Math` to call the `System.Math` implementation. (dotnet/coreclr#7721)

* Updating the new `System.MathF` calls which already existed in `System.Math` to call the `System.Math` implementation.
* Removing the FCALL entry for MathF.Abs

Commit migrated from https://github.com/dotnet/coreclr/commit/841155bca0f1fe0202fd53833e476980e398dab7

7 years agoRyuJIT/x86: handle must-init multi-reg vars
Carol Eidt [Wed, 19 Oct 2016 18:28:22 +0000 (11:28 -0700)]
RyuJIT/x86: handle must-init multi-reg vars

In the RyuJIT backend, lclVars can occupy multiple registers, and not have a stack location. These should be handled for must-init as for lvRegister. The existing code was doing this oinly for _TARGET_64_BIT_ when it should be !LEGACY_BACKEND.
This fixes DevDiv VSO bug 278372

Commit migrated from https://github.com/dotnet/coreclr/commit/9ed511b7d60853fb32938d9cab252fbfeafce85e

7 years agoMerge pull request dotnet/coreclr#7708 from pgavlin/StackParamUntracked
Pat Gavlin [Wed, 19 Oct 2016 18:23:10 +0000 (11:23 -0700)]
Merge pull request dotnet/coreclr#7708 from pgavlin/StackParamUntracked

Always treat incoming on-stack parameters as GC-untracked.

Commit migrated from https://github.com/dotnet/coreclr/commit/38495badc123a9d9a2d0e1640f5bf23da40d13f7

7 years agoMerge pull request dotnet/coreclr#7718 from dotnet-bot/from-tfs
Jan Kotas [Wed, 19 Oct 2016 18:17:40 +0000 (11:17 -0700)]
Merge pull request dotnet/coreclr#7718 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/59e73762ca23c6d34036ce8b06643efaa47333ed

7 years agoEnable Enter/Leave/Tailcall hooks for RyuJIT/x86
Bruce Forstall [Fri, 14 Oct 2016 01:10:33 +0000 (18:10 -0700)]
Enable Enter/Leave/Tailcall hooks for RyuJIT/x86

Commit migrated from https://github.com/dotnet/coreclr/commit/fba86f9b18cb39195aea1465beed3df90f004524

7 years agofix compilation compilation error without ready to run.
Sergey Andreenko [Wed, 19 Oct 2016 16:37:55 +0000 (09:37 -0700)]
fix compilation compilation error without ready to run.

Commit migrated from https://github.com/dotnet/coreclr/commit/7e51701cf141dacd8e1426dfc1b90118fedb5d39

7 years agoMerge pull request dotnet/coreclr#7714 from gkhanna79/CleanupArm32
Gaurav Khanna [Wed, 19 Oct 2016 16:35:54 +0000 (09:35 -0700)]
Merge pull request dotnet/coreclr#7714 from gkhanna79/CleanupArm32

Cleanup arm32

Commit migrated from https://github.com/dotnet/coreclr/commit/2eefb2d2e64caec9e4c4bbbe805495109e35a1c3

7 years agofix arm64 build break
Rahul Kumar [Wed, 19 Oct 2016 16:12:10 +0000 (09:12 -0700)]
fix arm64 build break

[tfs-changeset: 1634120]

Commit migrated from https://github.com/dotnet/coreclr/commit/43a39ebe216b36b16edc11275c9bfa5bac2679c8

7 years agoMerge pull request dotnet/coreclr#7709 from wtgodbe/publishProj
Stephen Toub [Wed, 19 Oct 2016 12:27:47 +0000 (08:27 -0400)]
Merge pull request dotnet/coreclr#7709 from wtgodbe/publishProj

Only build TargetingPack when building on Windows

Commit migrated from https://github.com/dotnet/coreclr/commit/d8b86d144d337f0f0d698ac1c60cf87e1b9c1011

7 years agoFix broken range check
Dmitry-Me [Wed, 19 Oct 2016 11:55:23 +0000 (14:55 +0300)]
Fix broken range check

Commit migrated from https://github.com/dotnet/coreclr/commit/26b030d304fc9175317047cbe1a6eb4dc02d7e38

7 years agoSupport "offline" initializtion of Tools (dotnet/coreclr#7715)
Matt Ellis [Wed, 19 Oct 2016 08:42:45 +0000 (01:42 -0700)]
Support "offline" initializtion of Tools (dotnet/coreclr#7715)

This change allows init-tools to function in an "offline" mode where
tools are picked up from standalone folders. Specifically, it introduces
support for two new environment variables:

- DOTNET_TOOLSET_DIR
- BUILD_TOOLS_TOOLSET_DIR

If either is set, instead of downloading toolsets, we copy an already
existing one from the folder.  The TOOLSET_DIR is a folder with sub
directories for every version of the tool in question.

For buildtools, we expect a published toolset (sans the "dotnetcli"
folder) not just a set of nuget packages (i.e. the layout of Tools/
after running ./init-tools.sh in "online" mode).

The above varibles are useful for situations where we want to carry
multiple toolsets with us, but are less helpful for places where a
developer has produced their own toolset by hand (since the resulting
folder structure contains extra version information). For these cases,
I've added

- DOTNET_TOOL_DIR
- BUILD_TOOLS_TOOL_DIR

Which work like the above but don't require the nested folder structure.

Commit migrated from https://github.com/dotnet/coreclr/commit/380dd6d4aad88103efa6ae58830be356d20e742d

7 years agoFix passing struct with four floats in registers via reflection (dotnet/coreclr#7716)
Jan Vorlicek [Wed, 19 Oct 2016 06:43:29 +0000 (08:43 +0200)]
Fix passing struct with four floats in registers via reflection (dotnet/coreclr#7716)

This change fixes a bug in the code that copies a struct into the transition
frame. When it contains four floats, the first two are put to the right place,
but the following two are placed to an address that's offset by 8 instead of
by 16.

It also adds regression test for this problem as Pri 1 test.

Commit migrated from https://github.com/dotnet/coreclr/commit/6dc1f30d29893b8bb085523c49cc79d47d13f2b7

7 years agoFix build break
Jan Kotas [Wed, 19 Oct 2016 06:18:24 +0000 (23:18 -0700)]
Fix build break

[tfs-changeset: 1634099]

Commit migrated from https://github.com/dotnet/coreclr/commit/5c7a8bb321980e86517947bf4b7140f375ff3cd7

7 years agoMerge pull request dotnet/coreclr#7712 from dotnet/revert-7494-CoreLib
Jan Kotas [Wed, 19 Oct 2016 05:14:41 +0000 (22:14 -0700)]
Merge pull request dotnet/coreclr#7712 from dotnet/revert-7494-CoreLib

Revert "Delete mscorlib from CoreCLR targeting pack"

Commit migrated from https://github.com/dotnet/coreclr/commit/6a9c0c94484cc9102ef0ec34de372b828a8f05fa

7 years agoCleanup external dependency details
Gaurav Khanna [Wed, 19 Oct 2016 03:28:12 +0000 (20:28 -0700)]
Cleanup external dependency details

Commit migrated from https://github.com/dotnet/coreclr/commit/f3d88b2aec06b00a29a2c6da8ea33624632e82bd

7 years agoMerge pull request dotnet/coreclr#7681 from rahku/_appdomain
Rahul Kumar [Wed, 19 Oct 2016 03:00:14 +0000 (20:00 -0700)]
Merge pull request dotnet/coreclr#7681 from rahku/_appdomain

Expose apis in System.Reflection.Assembly

Commit migrated from https://github.com/dotnet/coreclr/commit/f3374228fd9f978f512a4d2156017b0b6494b90a

7 years agoEnable DateTimeFormatInfo netstandard 1.7 APIs on Linux (dotnet/coreclr#7713)
Tarek Mahmoud Sayed [Wed, 19 Oct 2016 01:28:36 +0000 (18:28 -0700)]
Enable DateTimeFormatInfo netstandard 1.7 APIs on Linux (dotnet/coreclr#7713)

* Enable DateTimeFormatInfo netstandard 1.7 APIs on Linux

* Remove un-necessary return

Commit migrated from https://github.com/dotnet/coreclr/commit/3c4bbb1fd51955ed87b583d25103c436bd3eb5dc

7 years agoExpose apis in System.Reflection.Assembly
Rahul Kumar [Mon, 17 Oct 2016 23:52:57 +0000 (16:52 -0700)]
Expose apis in System.Reflection.Assembly

Commit migrated from https://github.com/dotnet/coreclr/commit/153162f00bff94660b69237bcea341fb11e90926

7 years agoformat fix
Sergey Andreenko [Tue, 18 Oct 2016 23:46:59 +0000 (16:46 -0700)]
format fix

Commit migrated from https://github.com/dotnet/coreclr/commit/04d35297084bf8c8d2bb2c93d969555ab17a9ee0

7 years agohelper address is already known
Sergey Andreenko [Tue, 18 Oct 2016 23:42:42 +0000 (16:42 -0700)]
helper address is already known

Commit migrated from https://github.com/dotnet/coreclr/commit/f35e83864482792785865d3286686d6a5e3dae60

7 years agoCleanup External Dependency references
Gaurav Khanna [Tue, 18 Oct 2016 22:04:48 +0000 (15:04 -0700)]
Cleanup External Dependency references

Commit migrated from https://github.com/dotnet/coreclr/commit/66b9f6796f40e18f0179b018a59cf25e66b3c0a7

7 years agoRemove Arm32 dependency from closed build
Gaurav Khanna [Tue, 18 Oct 2016 22:00:32 +0000 (15:00 -0700)]
Remove Arm32 dependency from closed build

Commit migrated from https://github.com/dotnet/coreclr/commit/724e30463d73b1a297d5205e287f07ef78da0fe4

7 years agoformat fix
Sergey Andreenko [Tue, 18 Oct 2016 21:31:55 +0000 (14:31 -0700)]
format fix

Commit migrated from https://github.com/dotnet/coreclr/commit/fe41679021568d467ad00b79449684be900e9760

7 years agoRevert "Delete mscorlib from CoreCLR targeting pack"
William Godbe [Tue, 18 Oct 2016 21:27:25 +0000 (14:27 -0700)]
Revert "Delete mscorlib from CoreCLR targeting pack"

Commit migrated from https://github.com/dotnet/coreclr/commit/85054b58ce069495a2595a2bafba86777d7ca045

7 years agoMerge pull request dotnet/coreclr#7700 from wtgodbe/1.1
William Godbe [Tue, 18 Oct 2016 21:11:16 +0000 (14:11 -0700)]
Merge pull request dotnet/coreclr#7700 from wtgodbe/1.1

Upgrade build-against-packages frameworks to NetStandard1.1

Commit migrated from https://github.com/dotnet/coreclr/commit/c764a9585625d88922ca92ea0798cd1bbce316c0

7 years agoOnly publish TargetingPack when building on Windows
wtgodbe [Tue, 18 Oct 2016 20:40:35 +0000 (13:40 -0700)]
Only publish TargetingPack when building on Windows

Commit migrated from https://github.com/dotnet/coreclr/commit/88dde249e83a99211ee82df8288da409acd38134

7 years agoFix Link (dotnet/coreclr#7699)
Vance Morrison [Tue, 18 Oct 2016 20:17:28 +0000 (13:17 -0700)]
Fix Link (dotnet/coreclr#7699)

Commit migrated from https://github.com/dotnet/coreclr/commit/4a48315e9924d148d38a6b3ebca4ffa0c1537f1a

7 years agoMerge pull request dotnet/coreclr#7698 from CarolEidt/Fix278371
Carol Eidt [Tue, 18 Oct 2016 20:08:33 +0000 (13:08 -0700)]
Merge pull request dotnet/coreclr#7698 from CarolEidt/Fix278371

Allow non-constant size for rep stos InitBlk on x86

Commit migrated from https://github.com/dotnet/coreclr/commit/6d9184ccaaf86e1a1d627750e3e980fef8f3b8f5

7 years agoAlways treat incoming on-stack parameters as GC-untracked.
Pat Gavlin [Tue, 18 Oct 2016 20:04:28 +0000 (13:04 -0700)]
Always treat incoming on-stack parameters as GC-untracked.

Incoming parameters that are passed on the stack are never reported as
tracked to the GC, but `lvaIsGCTracked` (which is used to determine
whether or not to report liveness for a lclVar's stack slot) still
returned true if the corresponding lclVar was tracked. This caused
problems on x86 when dealing with incoming GC stack parameters in ESP
frames: in this case, writes to a GC stack parameter could incorrectly
change the liveness for a lclVar at the same offset from ESP as the
parameter's offset from EBP.

Fixes dotnet/coreclr#7696.

Commit migrated from https://github.com/dotnet/coreclr/commit/a24d7e9eca0d1d8bf93f854bd9985a8e97526fab

7 years agoMerge pull request dotnet/coreclr#7701 from rahku/arm64fixes
Rahul Kumar [Tue, 18 Oct 2016 20:00:52 +0000 (13:00 -0700)]
Merge pull request dotnet/coreclr#7701 from rahku/arm64fixes

_isnanf is not defined for arm64 use isnan instead

Commit migrated from https://github.com/dotnet/coreclr/commit/1b05f1c2e523ebd88c20f00130ad87954e4f358d

7 years agoheader for getRuntimeContextTree
Sergey Andreenko [Tue, 18 Oct 2016 19:54:51 +0000 (12:54 -0700)]
header for getRuntimeContextTree

Commit migrated from https://github.com/dotnet/coreclr/commit/b0a00ddccdf3a667e39591eaf07e4128b7fee48f

7 years agoreturn break to the previous position,
Sergey Andreenko [Tue, 18 Oct 2016 19:41:11 +0000 (12:41 -0700)]
return break to the previous position,

Commit migrated from https://github.com/dotnet/coreclr/commit/42207e600a621af6a5a4636c8de629e8f67063a7

7 years ago_isnanf is not defined for arm64 use isnan instead
Rahul Kumar [Tue, 18 Oct 2016 18:58:20 +0000 (11:58 -0700)]
_isnanf is not defined for arm64 use isnan instead

Commit migrated from https://github.com/dotnet/coreclr/commit/0229860b530829e3ed2ccbfefa2574a529f9ede4

7 years agoUpgrade build-against-packages dependencies to NetStandard1.1
wtgodbe [Tue, 18 Oct 2016 18:49:19 +0000 (11:49 -0700)]
Upgrade build-against-packages dependencies to NetStandard1.1

Commit migrated from https://github.com/dotnet/coreclr/commit/d809b0a8d135f4a25f3943beef9cd34bded4b7c8

7 years agoAllow non-constant size for rep stos InitBlk on x86
Carol Eidt [Tue, 18 Oct 2016 15:52:38 +0000 (08:52 -0700)]
Allow non-constant size for rep stos InitBlk on x86

Fixes DevDiv VSO bug 278371, and adds a test case.

Commit migrated from https://github.com/dotnet/coreclr/commit/2027a48c8c6f674b0392d74436f192c96f7d6337

7 years agoMerge pull request dotnet/coreclr#7683 from sivarv/VectorByteFix
Sivarv [Tue, 18 Oct 2016 17:18:25 +0000 (10:18 -0700)]
Merge pull request dotnet/coreclr#7683 from sivarv/VectorByteFix

Vector<T>.ctor(T val) is not recognized for ubyte/byte/short/ushort when the arg is a local of small int type (e.g. method args).

Commit migrated from https://github.com/dotnet/coreclr/commit/2a09852cff2a62619d423ad7f5ebf2284981250f