Paul A. Clarke [Thu, 6 Dec 2018 22:11:01 +0000 (22:11 +0000)]
[rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit
Fix general endian issues found in the test cases for thecompatibility
implementations of the x86 vector intrinsics. (The tests had been
inadvertently made to PASS without actually running the test code.
A later patch fixes this issue.)
Additionally, a new <smmintrin.h> is added, as some of the APIs therein are
now used by the test cases. It is _not_ a complete implementation of the
SSE4 interfaces, only the few "extract" interfaces uses by the tests.
2018-12-06 Paul A. Clarke <pc@us.ibm.com>
[gcc]
PR target/88316
* config/rs6000/smmintrin.h: New file.
* config.gcc: Add smmintrin.h to extra_headers for powerpc*-*-*.
[gcc/testsuite]
PR target/88316
* gcc.target/powerpc/mmx-packssdw-1.c: Fixes for big-endian.
* gcc.target/powerpc/mmx-packsswb-1.c: Likewise.
* gcc.target/powerpc/mmx-packuswb-1.c: Likewise.
* gcc.target/powerpc/mmx-pmulhw-1.c: Likewise.
* gcc.target/powerpc/sse-cvtpi32x2ps-1.c: Likewise.
* gcc.target/powerpc/sse-cvtpu16ps-1.c: Likewise.
* gcc.target/powerpc/sse-cvtss2si-1.c: Likewise.
* gcc.target/powerpc/sse-cvtss2si-2.c: Likewise.
* gcc.target/powerpc/sse2-pshufhw-1.c: Likewise.
* gcc.target/powerpc/sse2-pshuflw-1.c: Likewise.
From-SVN: r266869
Paul A. Clarke [Thu, 6 Dec 2018 22:03:25 +0000 (22:03 +0000)]
[rs6000] x86-compat vector intrinsics fixes for BE, 32bit
Fix general endian and 32-bit mode issues found in the
compatibility implementations of the x86 vector intrinsics when running the
associated test suite tests. (The tests had been inadvertently made to PASS
without actually running the test code. A later patch fixes this issue.)
2018-12-03 Paul A. Clarke <pc@us.ibm.com>
PR target/88316
* config/rs6000/mmintrin.h (_mm_unpackhi_pi8): Fix for big-endian.
(_mm_unpacklo_pi8): Likewise.
(_mm_mulhi_pi16): Likewise.
(_mm_packs_pi16): Fix for big-endian. Use preferred API.
(_mm_packs_pi32): Likewise.
(_mm_packs_pu16): Likewise.
* config/rs6000/xmmintrin.h (_mm_cvtss_si32): Fix for big-endian.
(_mm_cvtss_si64): Likewise.
(_mm_cvtpi32x2_ps): Likewise.
(_mm_shuffle_ps): Likewise.
(_mm_movemask_pi8): Likewise.
(_mm_mulhi_pu16): Likewise.
(_mm_sad_pu8): Likewise.
(_mm_sad_pu8): Likewise.
(_mm_cvtpu16_ps): Fix for big-endian. Use preferred API.
(_mm_cvtpu8_ps): Likewise.
(_mm_movemask_ps): Better #else case for big-endian (no functional
change).
(_mm_shuffle_pi16): Likewise.
* config/rs6000/emmintrin.h (_mm_movemask_pd): Fix for big-endian.
Better #else case for big-endian (no functional change).
(_mm_movemask_epi8): Likewise.
(_mm_shufflehi_epi16): Likewise.
(_mm_shufflelo_epi16): Likewise.
(_mm_shuffle_epi32): Likewise.
(_mm_mul_epu32): Fix for big-endian.
(_mm_bsrli_si128): Likewise.
(_mm_cvtps_pd): Better #else case for big endian.
(_mm_mulhi_epi16): Likewise.
(_mm_mul_epu32): Likewise.
(_mm_slli_si128): Likewise.
(_mm_sll_epi16): Likewise.
(_mm_sll_epi32): Likewise.
(_mm_sra_epi16): Likewise.
(_mm_sra_epi32): Likewise.
(_mm_srl_epi16): Likewise.
(_mm_srl_epi32): Likewise.
(_mm_mulhi_epu16): Likewise.
(_mm_sad_epu8): Likewise.
* config/rs6000/pmmintrin.h (_mm_hadd_ps): Fix for big-endian.
(_mm_sub_ps): Likewise.
* config/rs6000/mmintrin.h (_mm_cmpeq_pi8): Fix for 32-bit mode.
* gcc/config/rs6000/tmmintrin.h (_mm_alignr_epi8): Use ENDIAN
macros consistently (no functional changes).
(_mm_alignr_pi8): Likewise.
From-SVN: r266868
Jason Merrill [Thu, 6 Dec 2018 21:17:08 +0000 (16:17 -0500)]
PR c++/88136 - -Wdeprecated-copy false positives
Deprecating the copy operations because the class has a user-provided
destructor turns out to have too many false positives; this patch adjusts
-Wdeprecated-copy to only deprecate if the other copy operation is
user-provided. To get the earlier behavior, people can explicitly request
it with -Wdeprecated-copy-dtor.
gcc/c-family/
* c.opt (Wdeprecated-copy-dtor): New.
(Wdeprecated-copy): Move to -Wextra.
gcc/cp/
* class.c (classtype_has_depr_implicit_copy): Rename from
classtype_has_user_copy_or_dtor.
* method.c (lazily_declare_fn): Adjust.
* decl2.c (cp_warn_deprecated_use): Refer to -Wdeprecated-copy-dtor
if deprecation is due to a destructor.
From-SVN: r266867
Iain Sandoe [Thu, 6 Dec 2018 20:09:26 +0000 (20:09 +0000)]
Darwin - fix PR c++/87380
This is [intentionally] broken C++ ABI, that was catering for a
tool problem that existed in a very old Darwin toolchain.
The issue is not present after Darwin7 (using default system
tools) so confine the fix to that revision or earlier.
2018-12-06 Iain Sandoe <iain@sandoe.co.uk>
PR c++/87380
* config/darwin.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC) Remove; use the
default.
* config/rs6000/darwin7.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC): New.
From-SVN: r266866
Marek Polacek [Thu, 6 Dec 2018 19:43:17 +0000 (19:43 +0000)]
PR c++/88373 - wrong parse error with ~.
* parser.c (cp_parser_template_name): Check tag_type for
none_type.
* g++.dg/cpp2a/fn-template19.C: New test.
From-SVN: r266865
Iain Sandoe [Thu, 6 Dec 2018 19:42:21 +0000 (19:42 +0000)]
Darwin fix libstdc++ build warnings.
GCC does not export construction vtable symbols from shared libraries.
The symbols are marked hidden in the objects; for Darwin that makes
them also external (“private_extern” is Darwin’s hidden) which means
that they show up in the list of possible symbols for export from
libstdc++, and there are sufficiently relaxed match conditions that
they reach the exports list. When Darwin’s static linker encounters
them it generates a warning that they cannot be exported. This patch
prunes them from the list of symbols to be considered, thus
eliminating the warnings. No functional Change inended to the library
exports.
2018-12-06 Iain Sandoe <iain@sandoe.co.uk>
* scripts/make_exports.pl (check names): Don’t try to export
construction vtable symbols.
From-SVN: r266864
Jonathan Wakely [Thu, 6 Dec 2018 19:21:32 +0000 (19:21 +0000)]
Fix PR libstdc++/64883 Darwin headers use always_inline so don't test that
Because darwin system headers use always_inline rather than
__always_inline__ the libstdc++ test will fail, even if our headers only
use the reserved form of the attribute. Don't test it on Darwin, and
assume that testing on other targets will catch any accidental misuses
in libstdc++ headers.
2018-12-06 Jonathan Wakely <jwakely@redhat.com>
Iain Sandoe <iain@sandoe.co.uk>
PR libstdc++/64883
* testsuite/17_intro/headers/c++1998/all_attributes.cc: Don't test
always_inline on Darwin.
* testsuite/17_intro/headers/c++2011/all_attributes.cc: Likewise.
* testsuite/17_intro/headers/c++2014/all_attributes.cc: Likewise.
* testsuite/17_intro/headers/c++2017/all_attributes.cc: Likewise.
* testsuite/17_intro/headers/c++2020/all_attributes.cc: Likewise.
Co-Authored-By: Iain Sandoe <iain@sandoe.co.uk>
From-SVN: r266863
Vladimir Makarov [Thu, 6 Dec 2018 18:41:46 +0000 (18:41 +0000)]
re PR target/88282 (ICE in df_install_refs at gcc/df-scan.c:2379)
2018-12-06 Vladimir Makarov <vmakarov@redhat.com>
PR target/88282
* ira.c (ira_init_register_move_cost): Use info from
hard_regno_mode_ok instead of contains_reg_of_mode.
* ira-costs.c (contains_reg_of_mode): Don't use cost from bigger
hard register class for some fixed hard registers.
From-SVN: r266862
Richard Sandiford [Thu, 6 Dec 2018 18:02:09 +0000 (18:02 +0000)]
Remove bogus test line from vect-over-widen-23.c
I'd cut-&-paste vect-over-widen-23.c in an attempt to get the target
reuirements right, but by doing so carried over an unwanted test for
shifts.
2018-12-06 Richard Sandiford <richard.sandiford@arm.com>
gcc/testsuite/
* gcc.dg/vect/vect-over-widen-23.c: Remove unwanted line.
From-SVN: r266861
Segher Boessenkool [Thu, 6 Dec 2018 17:56:58 +0000 (18:56 +0100)]
asm inline
The Linux kernel people want a feature that makes GCC pretend some
inline assembler code is tiny (while it would think it is huge), so
that such code will be inlined essentially always instead of
essentially never.
This patch lets you say "asm inline" instead of just "asm", with the
result that that inline assembler is always counted as minimum cost
for inlining. It implements this for C and C++, making "inline"
another asm-qualifier (supplementing "volatile" and "goto").
* doc/extend.texi (Using Assembly Language with C): Document asm inline.
(Size of an asm): Fix typo. Document asm inline.
* gimple-pretty-print.c (dump_gimple_asm): Handle asm inline.
* gimple.h (enum gf_mask): Add GF_ASM_INLINE.
(gimple_asm_set_volatile): Fix typo.
(gimple_asm_inline_p): New.
(gimple_asm_set_inline): New.
* gimplify.c (gimplify_asm_expr): Propagate the asm inline flag from
tree to gimple.
* ipa-icf-gimple.c (func_checker::compare_gimple_asm): Compare the
gimple_asm_inline_p flag, too.
* tree-core.h (tree_base): Document that protected_flag is ASM_INLINE_P
in an ASM_EXPR.
* tree-inline.c (estimate_num_insns): If gimple_asm_inline_p return
a minimum size for an asm.
* tree.h (ASM_INLINE_P): New.
gcc/c/
* c-parser.c (c_parser_asm_statement): Detect the inline keyword
after asm. Pass a flag for it to build_asm_expr.
* c-tree.h (build_asm_expr): Update declaration.
* c-typeck.c (build_asm_stmt): Add is_inline parameter. Use it to
set ASM_INLINE_P.
gcc/cp/
* cp-tree.h (finish_asm_stmt): Update declaration.
* parser.c (cp_parser_asm_definition): Detect the inline keyword
after asm. Pass a flag for it to finish_asm_stmt.
* pt.c (tsubst_expr): Pass the ASM_INLINE_P flag to finish_asm_stmt.
* semantics.c (finish_asm_stmt): Add inline_p parameter. Use it to
set ASM_INLINE_P.
gcc/testsuite/
* c-c++-common/torture/asm-inline.c: New testcase.
* gcc.dg/asm-qual-2.c: Test asm inline, too.
From-SVN: r266860
Segher Boessenkool [Thu, 6 Dec 2018 17:47:52 +0000 (18:47 +0100)]
asm qualifiers (PR55681)
PR55681 observes that currently only one qualifier is allowed for
inline asm, so that e.g. "volatile asm" is allowed, "const asm" is also
okay (with a warning), but "const volatile asm" gives an error. Also
"goto" has to be last.
This patch changes things so that only "asm-qualifiers" are allowed,
that is "volatile" and "goto", in any combination, in any order, but
without repetitions.
PR inline-asm/55681
* doc/extend.texi (Basic Asm): Update grammar.
(Extended Asm): Update grammar.
gcc/c/
PR inline-asm/55681
* c-parser.c (c_parser_asm_statement): Update grammar. Allow any
combination of volatile and goto, in any order, without repetitions.
gcc/cp/
PR inline-asm/55681
* parser.c (cp_parser_asm_definition): Update grammar. Allow any
combination of volatile and goto, in any order, without repetitions.
gcc/testsuite/
PR inline-asm/55681
* gcc.dg/asm-qual-1.c: Test that "const" and "restrict" are refused.
* gcc.dg/asm-qual-2.c: New test, test that asm-qualifiers are allowed
in any order, but that duplicates are not allowed.
From-SVN: r266859
Jeff Law [Thu, 6 Dec 2018 15:35:34 +0000 (08:35 -0700)]
re PR testsuite/86540 (pr77445-2.c and ssa-dom-thread-7.c regressions since May 20, 2018)
PR testsuite/86540
* gcc.dg/tree-ssa/ssa-dom-thread-7.c: Skip the post switch conversion
tests on aarch64.
* gcc.dg/tree-ssa/pr77445-2.c: Similarly.
From-SVN: r266857
David Malcolm [Thu, 6 Dec 2018 15:25:12 +0000 (15:25 +0000)]
C++: improvements to diagnostics using %P (more PR c++/85110)
This patch is based on grepping the C++ frontend for %P
i.e. diagnostics that refer to a parameter number. It fixes up
these diagnostics to highlight the pertinent param where appropriate
(and possible), along with various other tweaks, as described in the
ChangeLog.
gcc/cp/ChangeLog:
PR c++/85110
* call.c (conversion_null_warnings): Try to use the location of
the expression for the warnings. Add notes showing the parameter
of the function decl, where available.
(get_fndecl_argument_location): For implicitly-declared functions,
use the fndecl location rather than that of the param.
(maybe_inform_about_fndecl_for_bogus_argument_init): New function.
(convert_like_real): Use it in various places to avoid repetition.
(complain_about_bad_argument): Likewise.
* cp-tree.h (maybe_inform_about_fndecl_for_bogus_argument_init):
New declaration.
* decl2.c (check_default_args): Put all diagnostics for the fndecl
into a diagnostic group. Use the location of the parameter when
complaining about parameters with missing default arguments in
preference to that of the fndecl. Attempt to record the location
of the first parameter with a default argument and emit a note
for the first parameter that's missing one.
* typeck.c (convert_arguments): When complaining about parameters
with incomplete types, attempt to use the location of the
argument. Where available, add a note showing the pertinent
parameter in the fndecl.
(convert_for_assignment): When complaining about bad conversions
at function calls, use the location of the unstripped argument.
(convert_for_initialization): When checking for bogus references,
add an auto_diagnostic_group, and update the note to use the
location of the pertinent parameter, rather than just the callee.
gcc/testsuite/ChangeLog:
PR c++/85110
* g++.dg/diagnostic/missing-default-args.C: New test.
* g++.dg/diagnostic/param-type-mismatch-3.C: New test.
* g++.dg/diagnostic/param-type-mismatch.C: Add tests for invalid
references and incomplete types.
* g++.dg/warn/Wconversion-null-4.C: New test.
From-SVN: r266856
Jeff Law [Thu, 6 Dec 2018 13:46:25 +0000 (06:46 -0700)]
Drop duplicate half of doubly-applied test.
From-SVN: r266854
Iain Sandoe [Thu, 6 Dec 2018 13:36:35 +0000 (13:36 +0000)]
Fix for PR78444 by ensuring 128b alignment at call sites.
2018-12-06 Iain Sandoe <iain@sandoe.co.uk>
PR target/78444
* config/i386/darwin.h (STACK_BOUNDARY): Remove macro.
* config/i386/i386.c (ix86_compute_frame_layout): Ensure at least 128b
stack alignment in non-leaf functions.
From-SVN: r266853
Jakub Jelinek [Thu, 6 Dec 2018 12:20:09 +0000 (13:20 +0100)]
re PR target/87598 (Rejects "%a0" with constant)
PR target/87598
* config/aarch64/aarch64.c (aarch64_print_address_internal): Don't
call output_operand_lossage on VOIDmode CONST_INTs. After
output_operand_lossage do return false.
* gcc.target/aarch64/asm-5.c: New test.
From-SVN: r266852
Richard Biener [Thu, 6 Dec 2018 11:32:52 +0000 (11:32 +0000)]
df-problems.c (df_rd_local_compute): Use bitmap_release.
2018-12-06 Richard Biener <rguenther@suse.de>
* df-problems.c (df_rd_local_compute): Use bitmap_release.
(df_live_free): Likewise.
(df_md_local_compute): Likewise.
(df_md_free): Release df_md_scratch bitmap.
* loop-invariant.c (calculate_loop_reg_pressure): Use
bitmap_release.
* sched-deps.c (true_dependency_cache, output_dependency_cache,
anti_dependency_cache, control_dependency_cache,
spec_dependency_cache): Use bitmap instead of bitmap_head *.
* sched-ebb.c (schedule_ebbs_init): Initialize non-GTY
dont_calc_deps as bitmap allocated from obstack not GC.
(schedule_ebbs_finish): Use bitmap_release.
* sched-rgn.c (schedule_insns): Initialize non-GTY
not_in_df as bitmap allocated from obstack not GC.
Use bitmap_release.
* sel-sched.c (_forced_ebb_heads): Remove premature optimization.
(sel_region_init): Allocate forced_ebb_heads.
(sel_region_finish): Free forced_ebb_heads.
From-SVN: r266851
Richard Biener [Thu, 6 Dec 2018 11:32:09 +0000 (11:32 +0000)]
bitmap.c (bitmap_head::crashme): Define.
2018-12-06 Richard Biener <rguenther@suse.de>
* bitmap.c (bitmap_head::crashme): Define.
* bitmap.h (bitmap_head): Add constexpr default constructor
poisoning the obstack member.
(bitmap_head::crashme): Declare.
(bitmap_release): New function clearing a bitmap and poisoning
the obstack member.
* gengtype.c (main): Make it recognize CONSTEXPR.
* lra-constraints.c (lra_inheritance): Use bitmap_release
instead of bitmap_clear.
* ira.c (ira): Work around class-memaccess warning.
* regrename.c (create_new_chain): Likewise.
From-SVN: r266850
Jakub Jelinek [Thu, 6 Dec 2018 10:45:47 +0000 (11:45 +0100)]
re PR tree-optimization/85726 (div C1 to div C2 match.pd suboptimization)
PR tree-optimization/85726
* generic-match-head.c (optimize_successive_divisions_p): New function.
* gimple-match-head.c (optimize_successive_divisions_p): Likewise.
* match.pd: Don't combine successive divisions if they aren't exact
and optimize_successive_divisions_p is false.
* gcc.dg/tree-ssa/pr85726-1.c: New test.
* gcc.dg/tree-ssa/pr85726-2.c: New test.
* gcc.dg/tree-ssa/pr85726-3.c: New test.
* gcc.dg/tree-ssa/pr85726-4.c: New test.
From-SVN: r266848
Jakub Jelinek [Thu, 6 Dec 2018 10:28:31 +0000 (11:28 +0100)]
re PR fortran/88304 (ICE in use_pointer_in_frame, at tree-nested.c:267)
PR fortran/88304
* tree-nested.c (convert_nonlocal_reference_stmt): Remove clobbers
for non-local automatic decls.
* gfortran.fortran-torture/compile/pr88304.f90: New test.
From-SVN: r266847
Richard Biener [Thu, 6 Dec 2018 10:20:39 +0000 (10:20 +0000)]
re PR middle-end/63184 (Fails to simplify comparison)
2018-12-06 Richard Biener <rguenther@suse.de>
PR middle-end/63184
* c-c++-common/pr19807-2.c: Try link only on x86, add xfailed
optimized dump scanning.
* c-c++-common/pr19807-3.c: Likewise.
From-SVN: r266846
Paolo Carlini [Thu, 6 Dec 2018 08:23:04 +0000 (08:23 +0000)]
decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error message...
/cp
2018-12-06 Paolo Carlini <paolo.carlini@oracle.com>
* decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error message;
print the type too; fix thinko in INDIRECT_TYPE_P use.
/testsuite
2018-12-06 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/parse/bitfield6b.C: New.
* g++.dg/parse/bitfield3.C: Test location and type.
From-SVN: r266841
Iain Sandoe [Thu, 6 Dec 2018 08:14:57 +0000 (08:14 +0000)]
testsuite - handle the -fno-diagnostics-show-line-numbers in compat tests.
2018-12-06 Iain Sandoe <iain@sandoe.co.uk>
* lib/c-compat.exp (compat-use-alt-compiler):
Handle -fno-diagnostics-show-line-numbers.
(compat_setup_dfp): Likewise.
From-SVN: r266840
Jeff Law [Thu, 6 Dec 2018 00:40:08 +0000 (17:40 -0700)]
re PR rtl-optimization/85770 (ICE: in lra_eliminate, at lra-eliminations.c:1439 with -march=nano-1000)
PR rtl-optimization/85770
* gcc.target/i386/pr85770.c: New test.
From-SVN: r266839
David Edelsohn [Thu, 6 Dec 2018 00:36:52 +0000 (00:36 +0000)]
aix72.h (ASM_DEFAULT_SPEC): Match Power7 processor default.
* config/rs6000/aix72.h (ASM_DEFAULT_SPEC): Match Power7 processor
default.
From-SVN: r266838
GCC Administrator [Thu, 6 Dec 2018 00:16:36 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266837
Uros Bizjak [Thu, 6 Dec 2018 00:14:41 +0000 (01:14 +0100)]
dwarf2out.c (field_byte_offset): Remove #ifdef PCC_BITFIELD_TYPE_MATTERS check.
* dwarf2out.c (field_byte_offset): Remove
#ifdef PCC_BITFIELD_TYPE_MATTERS check.
From-SVN: r266834
Jeff Law [Wed, 5 Dec 2018 23:10:08 +0000 (16:10 -0700)]
re PR c/87028 (false positive -Wstringop-truncation strncpy with global variable source string)
PR c/87028
* calls.c (get_attr_nonstring_decl): Avoid setting *REF to
SSA_NAME_VAR.
* gcc/gimple-low.c (lower_stmt): Fold builtin calls here.
* gimplify (maybe_fold_stmt): Avoid folding builtin calls.
PR c/87028
* c-c++-common/Wstringop-truncation.c: Remove xfails.
* gcc.dg/Wstringop-truncation-5.c: New test.
* gcc.dg/strcmpopt_1.c: Adjust.
* gcc.dg/tree-ssa/pr79697.c: Same.
From-SVN: r266833
Ian Lance Taylor [Wed, 5 Dec 2018 23:09:51 +0000 (23:09 +0000)]
runtime: add precise stack scan support
This CL adds support of precise stack scan using stack maps to
the runtime. The stack maps are generated by the compiler (if
supported). Each safepoint is associated with a (real or dummy)
landing pad, and its "type info" in the exception table is a
pointer to the stack map. When a stack is scanned, the stack map
is found by the stack unwinding code by inspecting the exception
table (LSDA).
For precise stack scan we need to unwind the stack. There are
three cases:
- If a goroutine is scanning its own stack, it can unwind the
stack and scan the frames.
- If a goroutine is scanning another, stopped, goroutine, it
cannot directly unwind the target stack. We handle this by
switching (runtime.gogo) to the target g, letting it unwind
and scan the stack, and switch back.
- If we are scanning a goroutine that is blocked in a syscall,
we send a signal to the target goroutine's thread, and let the
signal handler unwind and scan the stack. Extra care is needed
as this races with enter/exit syscall.
Currently this is only implemented on linux.
Reviewed-on: https://go-review.googlesource.com/c/140518
From-SVN: r266832
Iain Sandoe [Wed, 5 Dec 2018 21:57:00 +0000 (21:57 +0000)]
darwin - add configuration support for 'otool'
2018-12-05 Iain Sandoe <iain@sandoe.co.uk>
* configure.ac (NCN_STRICT_CHECK_TOOLS): Check otool.
(ACX_CHECK_INSTALLED_TARGET_TOOL): Likewise
(GCC_TARGET_TOOL): Likewise.
* Makefile.tpl (HOST_EXPORTS): Add OTOOL, OTOOL_FOR_TARGET.
(BASE_TARGET_EXPORTS): OTOOL, export OTOOL_FOR_TARGET.
OTOOL, OTOOL_FOR_TARGET: New substitutions.
(EXTRA_HOST_FLAGS, EXTRA_TARGET_FLAGS): Add OTOOL.
* configure: Regenerate.
* Makefile.in: Likewise.
gcc/
* configure.ac (gcc_cv_otool): Set.
* configure: Regenerate.
From-SVN: r266831
Uros Bizjak [Wed, 5 Dec 2018 20:40:56 +0000 (21:40 +0100)]
cygming.h (PCC_BITFIELD_TYPE_MATTERS): Remove.
* config/i386/cygming.h (PCC_BITFIELD_TYPE_MATTERS): Remove.
(GROUP_BITFIELDS_BY_ALIGN): Ditto.
From-SVN: r266830
Richard Sandiford [Wed, 5 Dec 2018 15:53:03 +0000 (15:53 +0000)]
Use unsigned arithmetic for demoted vector plus/minus/mult (PR 88064)
As Jakub pointed out, if we narrow a plus, minus or mult operation based
on the number of bits that consumers need, we have to convert a signed
operation to an unsigned one in order to avoid new undefined behaviour.
This patch does that and generalises vect_convert_input and
vect_recog_over_widening_pattern to cope with the extra casts.
(The changes to both functions are covered by existing tests.)
2018-12-03 Richard Sandiford <richard.sandiford@arm.com>
gcc/
PR tree-optimization/88064
* tree-vect-patterns.c (vect_convert_input): Convert the result of
an existing cast if it has the right width but the wrong sign.
Do not test the signedness of the required result when
considering whether to split an existing cast; instead split to
a type with the same signedness as the source of the cast, then
convert it to the opposite signedness where necessary.
(vect_recog_over_widening_pattern): Handle sign changes between
the final PLUS_EXPR and the RSHIFT_EXPR.
(vect_recog_average_pattern): Use an unsigned operation when
truncating an addition, subtraction or multiplication. Cast the
result back to the "real" signedness before promoting.
gcc/testsuite/
PR tree-optimization/88064
* gcc.dg/vect/vect-over-widen-23.c: New test.
From-SVN: r266829
David Malcolm [Wed, 5 Dec 2018 15:16:05 +0000 (15:16 +0000)]
testsuite: turn down verbosity of "process-message"
When debugging a failing test, I typically invoke DejaGnu at
verbosity level 2 (via RUNTESTFLAGS="-v -v dg.exp=something"),
so that DejaGnu prints the command line used to invoke the
compiler; specifically these two sites:
target.exp "Invoking the compiler as "
remote.exp "Executing on $hostname"
which are both verbosity level 2.
Unfortunately I run into an O(n^2) issue with logging from
process-message:
verbose "process-message:\n${dg-messages}" 2
where, as each message each processed, it emits the state
of dg-messages, containing the new message and all messages so far,
leading to exponentially-increasing output at level 2 as more test
messages are added.
This patch papers over the problem by moving the
problematic message to verbosity level 3.
gcc/testsuite/ChangeLog:
* lib/gcc-dg.exp (process-message): Change verbosity level of
"verbose" from 2 to 3.
(dg-locus): Likewise.
From-SVN: r266828
Richard Biener [Wed, 5 Dec 2018 14:55:59 +0000 (14:55 +0000)]
re PR middle-end/63184 (Fails to simplify comparison)
2018-12-05 Richard Biener <rguenther@suse.de>
PR middle-end/63184
* c-c++-common/pr19807-2.c: New testcase.
* c-c++-common/pr19807-3.c: Likewise.
From-SVN: r266827
Paul Koning [Wed, 5 Dec 2018 14:25:11 +0000 (09:25 -0500)]
* udivmodhi4.c (__udivmodhi4): Fix loop end check.
From-SVN: r266826
Rainer Orth [Wed, 5 Dec 2018 14:16:08 +0000 (14:16 +0000)]
Provide SPARCv9 MAXALIGN in gcc.target/sparc/attr-aligned.c (PR testsuite/88208)
PR testsuite/88208
* gcc.target/sparc/attr-aligned.c (MAXALIGN) [__sparcv9 ||
__arch64__]: Define.
From-SVN: r266825
Rainer Orth [Wed, 5 Dec 2018 14:10:06 +0000 (14:10 +0000)]
Build gcc.target/sparc/
20181129-?.c as C99
* gcc.target/sparc/
20181129-1.c: Compile with -std=c99.
* gcc.target/sparc/
20181129-2.c: Likewise.
From-SVN: r266824
Richard Biener [Wed, 5 Dec 2018 11:36:03 +0000 (11:36 +0000)]
re PR tree-optimization/86637 (ICE: tree check: expected block, have <invalid tree code> in inlining_chain_to_json, at optinfo-emit-json.cc:293)
2018-12-05 Richard Biener <rguenther@suse.de>
PR tree-optimization/86637
* tree-vectorizer.c (pass_slp_vectorize::execute): Reset
vect_location at the end.
From-SVN: r266821
Jakub Jelinek [Wed, 5 Dec 2018 11:05:59 +0000 (12:05 +0100)]
re PR tree-optimization/87360 (ICE in remove_redundant_iv_tests at gcc/tree-ssa-loop-ivcanon.c:571 since r255467)
PR tree-optimization/87360
* gimple-loop-jam.c (tree_loop_unroll_and_jam): On failure to analyze
data dependencies, don't return false, just continue. Formatting
fixes.
(merge_loop_tree, bb_prevents_fusion_p, unroll_jam_possible_p,
fuse_loops): Formatting fixes.
* g++.dg/opt/pr87360.C: New test.
* gfortran.dg/pr87360.f90: New test.
From-SVN: r266820
Jakub Jelinek [Wed, 5 Dec 2018 08:43:12 +0000 (09:43 +0100)]
re PR c++/87897 (ICE in maybe_constant_value, at cp/constexpr.c:5255 since r265788)
PR c++/87897
* g++.dg/init/const13.C: New test.
From-SVN: r266818
Jakub Jelinek [Wed, 5 Dec 2018 08:26:06 +0000 (09:26 +0100)]
re PR sanitizer/88333 (ice in asan_emit_stack_protection, at asan.c:1574)
PR sanitizer/88333
* cfgexpand.c (expand_stack_vars): If asan_vec is empty, start with
aligning frame offset to ASAN_RED_ZONE_SIZE bytes.
* c-c++-common/asan/pr88333.c: New test.
From-SVN: r266817
Alexandre Oliva [Wed, 5 Dec 2018 06:47:11 +0000 (06:47 +0000)]
[PR85569] skip constexpr target_expr constructor dummy type conversion
The testcase is the work-around testcase for the PR; even that had
started failing. The problem was that, when unqualifying the type of
a TARGET_EXPR, we'd create a variant of the type, then request the
conversion of the TARGET_EXPR_INITIAL to that variant type. Though
the types are different pointer-wise, they're the same_type_p, so the
resulting modified expr compares cp_tree_equal to the original, which
maybe_constant_value flags as an error. There's no reason to
construct an alternate TARGET_EXPR or CONSTRUCTOR just because of an
equivalent type, except for another spot that expected pointer
equality that would no longer be satisfied. Without relaxing the
assert in constexpr_call_hasher::equal, g++.robertl/eb73.C would
trigger an assertion failure.
for gcc/cp/ChangeLog
PR c++/85569
* constexpr.c (adjust_temp_type): Test for type equality with
same_type_p.
(constexpr_call_hasher::equal): Likewise.
for gcc/testsuite/ChangeLog
PR c++/85569
* g++.dg/cpp1z/pr85569.C: New.
From-SVN: r266816
Chenghua Xu [Wed, 5 Dec 2018 03:30:49 +0000 (03:30 +0000)]
[MIPS][TESTSUITE][MSA] Adjusted clti to clei.
* gcc.target/mips/msa.c: Adjusted clti_<su>.df $wn, $wn, 4
to clei_<su>.df $wn, $wn, 4 in test31.
From-SVN: r266815
Xianmiao Qu [Wed, 5 Dec 2018 01:34:15 +0000 (01:34 +0000)]
config.gcc (csky-*-linux-gnu*): Force .init_array support.
2018-12-05 Xianmiao Qu <xianmiao_qu@c-sky.com>
gcc/
* config.gcc (csky-*-linux-gnu*): Force .init_array support.
From-SVN: r266813
Ian Lance Taylor [Wed, 5 Dec 2018 01:11:02 +0000 (01:11 +0000)]
syscall: remove Flock for aix/ppc64
CL 152397 removed it from gc's syscall package.
Updates golang/go#29084
Reviewed-on: https://go-review.googlesource.com/c/152557
From-SVN: r266812
Segher Boessenkool [Wed, 5 Dec 2018 01:04:11 +0000 (02:04 +0100)]
rs6000: Fix AIX aggregate passing fix
David's fix for the AIX aggregate passing from yesterday unfortunately
also triggers on powerpc64-linux. This fixes it.
* config/rs6000/rs6000.c (rs6000_function_arg): Only do the special
aggregate handling on actual AIX, not on somewhat similar systems.
(rs6000_arg_partial_bytes): Ditto.
From-SVN: r266811
GCC Administrator [Wed, 5 Dec 2018 00:16:18 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266810
Paolo Carlini [Tue, 4 Dec 2018 23:48:45 +0000 (23:48 +0000)]
re PR c++/84636 (internal compiler error: Segmentation fault (identifier_p()/grokdeclarator()))
/cp
2018-12-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/84636
* decl.c (grokdeclarator): Avoid crashing on an anonymous bit-field
with function type.
/testsuite
2018-12-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/84636
* g++.dg/parse/bitfield6.C: New.
From-SVN: r266807
Jakub Jelinek [Tue, 4 Dec 2018 23:27:39 +0000 (00:27 +0100)]
re PR tree-optimization/87320 (Last iteration of vectorized loop not executed when peeling for gaps)
PR tree-optimization/87320
* gcc.dg/pr87320.c: New test.
From-SVN: r266805
Jeff Law [Tue, 4 Dec 2018 23:23:03 +0000 (16:23 -0700)]
* gcc.dg/strlenopt-58.c: Handle targets with 2 byte wchar_t.
From-SVN: r266804
Vladimir Makarov [Tue, 4 Dec 2018 22:50:14 +0000 (22:50 +0000)]
re PR rtl-optimization/88317 (ICE: Segmentation fault (in split_reg -> bitmap_set_bit -> bitmap_list_link_element))
2018-12-04 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/88317
* lra-constraints.c (split_reg): Don't set up check_only_regs if
we are outside the inheritance pass.
From-SVN: r266803
Jan Hubicka [Tue, 4 Dec 2018 21:38:01 +0000 (22:38 +0100)]
ipa-prop.c (jump_function_useful_p): New.
* ipa-prop.c (jump_function_useful_p): New.
(ipa_read_node_info): Do not allocated useless jump functions.
From-SVN: r266799
David Malcolm [Tue, 4 Dec 2018 21:33:08 +0000 (21:33 +0000)]
spellcheck.c: add another selftest for PR c/82967
This adds another testcase for overzealous spellchecker suggestions,
reported on IRC.
gcc/ChangeLog:
PR c/82967
* spellcheck.c (selftest::test_suggestions): Add another
assertion.
From-SVN: r266798
Martin Sebor [Tue, 4 Dec 2018 20:14:51 +0000 (20:14 +0000)]
extend.texi (__builtin_has_attribute): Fix typo.
gcc/testsuite/ChangeLog:
* doc/extend.texi (__builtin_has_attribute): Fix typo.
From-SVN: r266796
Martin Sebor [Tue, 4 Dec 2018 20:10:47 +0000 (20:10 +0000)]
attr-aligned-2.c: New test.
gcc/testsuite/ChangeLog:
* gcc.target/i386/attr-aligned-2.c: New test.
* gcc.target/i386/falign-functions-3.c: New test.
From-SVN: r266795
Jakub Jelinek [Tue, 4 Dec 2018 19:41:52 +0000 (20:41 +0100)]
re PR target/88188 (ICE in print_operand, at config/rs6000/rs6000.c)
PR target/88188
* config/rs6000/rs6000.c (ccr_bit): Return -1 instead of assertion
failures.
(print_operand): Use REG_P instead of GET_CODE == REG.
<case 'D'>: Also check CR_REGNO_P (REGNO (x)).
<case 't'>: Likewise. Remove GET_MODE check.
* config/rs6000/rs6000.md (scc patterns): Assert ccr_bit didn't
return -1.
* gcc.target/powerpc/pr88188-2.c: New test.
From-SVN: r266794
Marek Polacek [Tue, 4 Dec 2018 19:28:27 +0000 (19:28 +0000)]
PR c++/88184 - ICE when treating name as template-name.
* pt.c (lookup_template_function): Always build the TEMPLATE_ID_EXPR
with unknown_type_node.
* g++.dg/cpp2a/fn-template17.C: New test.
* g++.dg/cpp2a/fn-template18.C: New test.
From-SVN: r266793
Martin Sebor [Tue, 4 Dec 2018 18:41:40 +0000 (18:41 +0000)]
extend.texi (attribute aligned): Expand.
gcc/ChangeLog:
* doc/extend.texi (attribute aligned): Expand.
From-SVN: r266792
Edward Smith-Rowland [Tue, 4 Dec 2018 16:26:39 +0000 (16:26 +0000)]
PR libstdc++/88341 - Complex norm doesn't compile with C++11
2018-12-03 Edward Smith-Rowland <3dw4rd@verizon.net>
PR libstdc++/88341 - Complex norm doesn't compile with C++11
* include/std/complex (_S_do_it): Make C++20 constexpr.
* testsuite/26_numerics/complex/value_operations/pr88341.cc: New test.
From-SVN: r266788
David Edelsohn [Tue, 4 Dec 2018 15:55:34 +0000 (15:55 +0000)]
* gcc.dg/live-patching-2.c: Require LTO.
From-SVN: r266787
David Edelsohn [Tue, 4 Dec 2018 15:51:51 +0000 (15:51 +0000)]
re PR target/61976 (aix64: Data corruption in struct passed by value)
PR target/61976
* config/rs6000/rs6000.c (rs6000_function_arg): Don't pass aggregates
in FPRs on AIX.
(rs6000_arg_partial_bytes): Same.
From-SVN: r266786
Iain Sandoe [Tue, 4 Dec 2018 15:31:06 +0000 (15:31 +0000)]
testsuite - restore the tests for profiled + partitioned code.
2018-12-04 Iain Sandoe <iain@sandoe.co.uk>
PR testsuite/88310
* lib/target-supports.exp (check_effective_target_freorder):
Suppress warnings for missing profile.
From-SVN: r266785
Vladimir Makarov [Tue, 4 Dec 2018 15:10:46 +0000 (15:10 +0000)]
re PR target/88282 (ICE in df_install_refs at gcc/df-scan.c:2379)
2018-12-04 Vladimir Makarov <vmakarov@redhat.com>
PR target/88282
* ira-costs.c (exec): Try bigger class to use smaller register
move cost.
From-SVN: r266784
Ian Lance Taylor [Tue, 4 Dec 2018 14:29:11 +0000 (14:29 +0000)]
cmd/vet: use default compiler when determining type sizes
Fixes a segfault running vet on alpha.
Patch by Uros Bizjak.
Reviewed-on: https://go-review.googlesource.com/c/152437
From-SVN: r266781
Michael Ploujnikov [Tue, 4 Dec 2018 14:22:09 +0000 (14:22 +0000)]
re PR lto/88297 (Assembler Error: symbol `_Z41__static_initialization_and_destruction_0ii.constprop.0' is already defined)
PR ipa/88297
* ipa-cp.c (create_specialized_node): Track clone counters by
node assembler names.
(ipcp_driver): Change type of clone_num_suffixes key to const
char*.
From-SVN: r266780
Jakub Jelinek [Tue, 4 Dec 2018 13:31:11 +0000 (14:31 +0100)]
typename1.C: Don't expect any diagnostics for C++2a.
* g++.old-deja/g++.oliva/typename1.C: Don't expect any diagnostics
for C++2a.
* g++.old-deja/g++.oliva/typename2.C: Likewise.
From-SVN: r266779
Richard Biener [Tue, 4 Dec 2018 13:23:13 +0000 (13:23 +0000)]
tree-vect-loop.c (vect_transform_loop): Fix epilogue iterations for epilogue vectorization.
2018-12-04 Richard Biener <rguenther@suse.de>
* tree-vect-loop.c (vect_transform_loop): Fix epilogue iterations
for epilogue vectorization.
From-SVN: r266777
Jakub Jelinek [Tue, 4 Dec 2018 13:15:46 +0000 (14:15 +0100)]
re PR tree-optimization/88285 (gcc.dg/predict-22.c fails on arm)
PR tree-optimization/88285
* gcc.dg/predict-22.c: Only compile on freorder targets.
From-SVN: r266776
Julian Brown [Tue, 4 Dec 2018 12:35:06 +0000 (12:35 +0000)]
OpenACC wait list diagnostic change
2018-12-04 James Norris <jnorris@codesourcery.com>
Cesar Philippidis <cesar@codesourcery.com>
Julian Brown <julian@codesourcery.com>
gcc/c/
* c-parser.c (c_parser_oacc_wait_list): Remove dead diagnostic
code.
gcc/cp/
* parser.c (cp_parser_oacc_wait_list): Fix error message and avoid
duplicate diagnostic.
gcc/testsuite/
* c-c++-common/goacc/asyncwait-1: Update expected errors and add a
test for "wait (".
Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
Reviewed-by: Joseph Myers <joseph@codesourcery.com>
From-SVN: r266774
Richard Biener [Tue, 4 Dec 2018 11:26:14 +0000 (11:26 +0000)]
re PR tree-optimization/88301 (Optimization regression with undefined unsigned overflow)
2018-12-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/88301
* tree-vrp.c (register_edge_assert_for_2): Fix sign-conversion
issues in last commit.
From-SVN: r266773
Jakub Jelinek [Tue, 4 Dec 2018 08:44:12 +0000 (09:44 +0100)]
re PR c++/88103 (Wrong value category when conditional expression result is used as object expression)
PR c++/88103
* typeck.c (build_class_member_access_expr): If unary_complex_lvalue
turned xvalue_p into non-xvalue_p, call move on it.
* g++.dg/cpp0x/rv-cond3.C: New test.
From-SVN: r266772
Richard Biener [Tue, 4 Dec 2018 08:23:40 +0000 (08:23 +0000)]
re PR tree-optimization/88315 (SAD and DOT_PROD SLP reductions with initial value != 0 create wrong code)
2018-12-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/88315
* tree-vect-loop.c (get_initial_defs_for_reduction): Simplify
and fix initialization vector for SAD and DOT_PROD SLP reductions.
* gcc.dg/vect/slp-reduc-sad.c: Adjust to provide non-trivial
initial value.
From-SVN: r266771
Sandra Loosemore [Tue, 4 Dec 2018 04:22:37 +0000 (23:22 -0500)]
re PR c/59039 (Undocumented __builtin_longjmp/__builtin_setjmp)
2018-12-03 Sandra Loosemore <sandra@codesourcery.com>
PR c/59039
gcc/
* doc/extend.texi (Nonlocal gotos): New section.
From-SVN: r266770
GCC Administrator [Tue, 4 Dec 2018 00:16:24 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r266769
Jakub Jelinek [Mon, 3 Dec 2018 20:57:14 +0000 (21:57 +0100)]
re PR middle-end/64242 (Longjmp expansion incorrect)
PR middle-end/64242
* gcc.c-torture/execute/pr64242.c (foo, bar): New functions.
(p): Make it void *volatile instead of volatile void *.
(q): New variable.
(main): Add a dummy 32-byte aligned variable and escape its address.
Don't require that the two __builtin_alloca (0) calls return the
same address, just require that their difference is smaller than
1024 bytes.
From-SVN: r266766
Uros Bizjak [Mon, 3 Dec 2018 20:44:37 +0000 (21:44 +0100)]
sse.md (vec_concatv2df): Change (v,xm,C) alternative to (v,vm,c).
* config/i386/sse.md (vec_concatv2df): Change (v,xm,C)
alternative to (v,vm,c).
From-SVN: r266765
Ian Lance Taylor [Mon, 3 Dec 2018 20:25:11 +0000 (20:25 +0000)]
cmd/go: allow buildmode c-archive for gccgo on ppc64
In buildmodeinit, the c-archive buildmode is flagged as invalid
on linux/ppc64 for gccgo when it should be valid. This happens
because the check against the gccgo flag is done after the checks
for valid GOOS/GOARCH pairs instead of before as is done for all
other buildmode cases in this switch. This corrects the problem and
allows several of the gccgo gotools testcases to pass on linux/ppc64.
Updates #29046
Reviewed-on: https://go-review.googlesource.com/c/152137
From-SVN: r266764
Segher Boessenkool [Mon, 3 Dec 2018 19:34:22 +0000 (20:34 +0100)]
Disallow configuring for powerpc*-*-linux*paired
The proper way, that is.
* gcc/config.gcc (Unsupported targets): Add powerpc*-*-linux*paired*.
(powerpc*-*-linux*): Don't handle it here.
From-SVN: r266763
Jeff Law [Mon, 3 Dec 2018 17:13:20 +0000 (10:13 -0700)]
h8300.md (<code>qi3_1): Add gcc_unreachable to keep warnings quiet.
* config/h8300/h8300.md (<code>qi3_1): Add gcc_unreachable to keep
warnings quiet.
From-SVN: r266762
Fritz Reese [Mon, 3 Dec 2018 17:10:50 +0000 (17:10 +0000)]
re PR fortran/87919 (Incorrect fortran handling of -fno-* options)
PR fortran/87919
* options.c (SET_FLAG, SET_BITFLAG, SET_BITFLAG2): New macros.
(set_dec_flags): Set/unset DEC and std flags according to value.
(post_dec_flags, set_init_local_zero): New functions.
(gfc_init_options): Use set_init_local_zero and post_dec_flags.
(gfc_handle_options) <case OPT_fcheck_array_temporaries>: Use
SET_BITFLAG.
<case OPT_finit_local_zero>: Use set_init_local_zero.
<case OPT_fdec>: Pass value to set_dec_flags.
<case OPT_fdec_structure>: Remove.
Co-Authored-By: Mark Eggleston <mark.eggleston@codethink.co.uk>
From-SVN: r266761
Marek Polacek [Mon, 3 Dec 2018 16:06:54 +0000 (16:06 +0000)]
* g++.dg/cpp1y/lambda-generic-83856.C: Use __SIZE_TYPE__.
From-SVN: r266760
Gary Dismukes [Mon, 3 Dec 2018 15:49:56 +0000 (15:49 +0000)]
[Ada] Fixes for various wrong and missing error messages on ACATS B85100[567]
GNAT was missing errors as well as issuing messages on legal lines in
new ACATS tests for illegal renamings of discriminant-dependent
components. Cases that are fixed include object names involving
qualified expressions, dereference cases, and generic formal access and
formal derived types. Better implements the "known to be constrained"
rules in the Ada RM.
Tested by new ACATS tests B85100[567] that are soon to be released.
2018-12-03 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_aux.adb (Object_Type_Has_Constrained_Partial_View): Return
True for an untagged discriminated formal derived type when
referenced within a generic body (augments existing test for
formal private types).
* sem_util.adb (Is_Dependent_Component_Of_Mutable_Type): If the
prefix of the name is a qualified expression, retrieve the
operand of that. Add a test of whether the (possible)
dereference prefix is a variable, and also test whether that
prefix might just be of an access type (occurs in some implicit
dereference cases) rather than being an explicit dereference.
Retrieve the Original_Node of the object name's main prefix and
handle the possibility of that being a qualified expression.
Remove special-case code for explicit dereferences that don't
come from source. Add test for the renaming not being within a
generic body for proper determination of whether a formal access
type is known to be constrained (it is within a generic spec,
but not in the body). Fix an existing incorrect test for
renaming of a discriminant-dependent component of a untagged
generic formal type being within a generic body, adding test of
taggedness and calling In_Generic_Body (now properly checks for
cases where the renaming is in a nongeneric body nested within a
generic). Return False in cases where the selector is not a
component (or discriminant), which can occur for
prefixed-notation calls.
From-SVN: r266759
Ed Schonberg [Mon, 3 Dec 2018 15:49:50 +0000 (15:49 +0000)]
[Ada] Spurious error on dependent expression that is an array
This patch fixes a spurious error on a array expression that is a
dependent expression of an if-expression, when the length of the array
matches that imposed by the context, but the bounds of both differ, in
particular when the expression and the context are both null arrays with
different bounds.
2018-12-03 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_res.adb (Apply_Check): For array types, apply a length
check rather than a qualification, to avoid spurious errors when
the value of a dependend expression has a matching length but
different bounds from those of the type of the contect.
gcc/testsuite/
* gnat.dg/array33.adb: New testcase.
From-SVN: r266758
Hristian Kirtchev [Mon, 3 Dec 2018 15:49:42 +0000 (15:49 +0000)]
[Ada] Add leap seconds for 2015 and 2016
The following patch updates Ada.Calendar and helper utility Xleaps to
include the leap seconds for years 2015 and 2016.
2018-12-03 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* libgnat/a-calend.adb: Update the number of leap seconds. Add
the hard time values for year 2015 and 2016.
From-SVN: r266757
Gary Dismukes [Mon, 3 Dec 2018 15:49:37 +0000 (15:49 +0000)]
[Ada] Spelling fixes and minor reformatting
2018-12-03 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_ch3.adb, libgnarl/s-taasde.adb, libgnarl/s-taenca.adb,
libgnarl/s-tarest.adb, libgnarl/s-tasini.adb,
libgnarl/s-taskin.ads, libgnarl/s-tasren.adb,
libgnarl/s-tassta.adb, libgnarl/s-tasuti.adb: Spelling fixes and
minor reformatting.
From-SVN: r266756
Eric Botcazou [Mon, 3 Dec 2018 15:49:23 +0000 (15:49 +0000)]
[Ada] Fix recent regression on array aggregate with dynamic subtype
This prevents either a crash or an assertion failure in gigi on an array
with dynamic subtype that is wrongly flagged as static by the front-end
because of a recent improvement made in the handling of nested
aggregates.
The patch reuses the existing Static_Array_Aggregate predicate instead
of fixing the problematic test, pluging a few loopholes in the process.
The predicate is conservatively correct but should be good enough in
practice.
2018-12-03 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_aggr.adb (Convert_To_Positional): Use
Static_Array_Aggregate to decide whether to set
Compile_Time_Known_Aggregate on an already flat aggregate.
(Expand_Array_Aggregate): Remove test on
Compile_Time_Known_Aggregate that turns out to be dead and
simplify.
(Is_Static_Component): New predicate extracted from...
(Static_Array_Aggregate): ...here. Test neither Is_Tagged_Type
nor Is_Controlled for the type, but test whether the component
type has discriminants. Use the Is_Static_Component predicate
consistently for the positional and named cases.
gcc/testsuite/
* gnat.dg/array32.adb, gnat.dg/array32.ads: New testcase.
From-SVN: r266755
Eric Botcazou [Mon, 3 Dec 2018 15:49:17 +0000 (15:49 +0000)]
[Ada] Fix internal error on package instantiation on private type
This fixes an assertion failure in gigi triggered by the instantiation
of a generic package, in a visible part of another package, done on a
private type whose full view is a type derived from a scalar or an
access type.
The problem is that the front-end creates and inserts two different
freeze nodes in the expanded tree for the partial and the full views of
the private subtype created by the instantiation, which is not correct:
partial and full views of a given (sub)type must point to the same
freeze node, if any.
The patch also adds an assertion checking this property in the front-end
so as to catch the inconsistency higher in the chain.
2018-12-03 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* freeze.adb (Freeze_Entity): Do not freeze the partial view of
a private subtype if its base type is also private with delayed
freeze before the full type declaration of the base type has
been seen.
* sem_ch7.adb (Preserve_Full_Attributes): Add assertion on
freeze node.
gcc/testsuite/
* gnat.dg/generic_inst2.adb, gnat.dg/generic_inst2.ads,
gnat.dg/generic_inst2_c.ads: New testcase.
From-SVN: r266754
Eric Botcazou [Mon, 3 Dec 2018 15:49:12 +0000 (15:49 +0000)]
[Ada] Fix problematic overloading of operator in Ada 95 mode
The change reverts the test deciding whether an initialization procedure
can be inherited from parent to derived type to the original
implementation, which allowed inheriting a null procedure.
This prevents the creation of another null initialization procedure for
the derived type, which in turn can avoid an artificial overloading
which can wreak havoc in the analysis of private declarations of a
package.
2018-12-03 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch3.adb (Build_Record_Init_Proc): Inherit an
initialization procedure if it is present, even if it is null.
gcc/testsuite/
* gnat.dg/overload2.adb, gnat.dg/overload2_p.adb,
gnat.dg/overload2_p.ads, gnat.dg/overload2_q.adb,
gnat.dg/overload2_q.ads: New testcase.
From-SVN: r266753
Patrick Bernardi [Mon, 3 Dec 2018 15:49:06 +0000 (15:49 +0000)]
[Ada] A task not executing an entry call consumes an Entry_Call slot
This patch resolves the issue where the ATC Level of a task's first
Entry_Call slot corresponds to a task not currently making an entry
call. Consequently, the first slot is never used to record an entry
call. To resolve this, the ATC Level of a such a task is now one less
than the first index of the Entry_Call array (and as result, the ATC
level corresponding to a completed task is now two less than the first
index of this array).
To aid the maintainability of code using ATC levels new constants are
introduced to represent key ATC nesting levels and comments are
introduce for the ATC level definitions.
As a result of this change, the GNAT Extended Ravenscar Profile now
works with the full runtime. The restricted runtime had assumed that the
first Entry_Call slot would be the only slot used for entry calls and
would only initialise this slot (and
System.Tasking.Protected_Objects.Single_Entry was coded this way).
However, Extended Ravenscar uses the native implementation of
System.Tasking.Protected_Objects where this assumption doesn't hold
until the implementation of this patch. Aside from enabling an extra
nested level, this is main functional change of this patch.
The following should compile and execute quietly:
gprbuild -q main.adb
./main
-- main.adb
pragma Profile (GNAT_Extended_Ravenscar);
pragma Partition_Elaboration_Policy (Sequential);
with Tasks;
with GNAT.OS_Lib;
with Ada.Synchronous_Task_Control;
procedure Main is
pragma Priority (30);
begin
Ada.Synchronous_Task_Control.Suspend_Until_True (Tasks.A_SO);
Ada.Synchronous_Task_Control.Suspend_Until_True (Tasks.B_SO);
GNAT.OS_Lib.OS_Exit (0);
end Main;
-- tasks.ads
with Ada.Synchronous_Task_Control;
package Tasks is
A_SO : Ada.Synchronous_Task_Control.Suspension_Object;
B_SO : Ada.Synchronous_Task_Control.Suspension_Object;
task A with Priority => 25;
task B with Priority => 20;
end Tasks;
-- tasks.adb
with Obj;
package body Tasks is
task body A is
begin
for J in 1 .. 5 loop
Obj.PO.Wait;
end loop;
Ada.Synchronous_Task_Control.Set_True (Tasks.A_SO);
end A;
task body B is
begin
for J in 1 .. 5 loop
Obj.PO.Put;
end loop;
Ada.Synchronous_Task_Control.Set_True (Tasks.B_SO);
end B;
end Tasks;
-- obj.ads
package Obj is
protected type PT is
pragma Priority (30);
entry Put;
entry Wait;
private
Wait_Ready : Boolean := False;
Put_Ready : Boolean := True;
end PT;
PO : PT;
end Obj;
-- obj.adb
package body Obj is
protected body PT is
entry Put when Put_Ready is
begin
Wait_Ready := True;
Put_Ready := False;
end Put;
entry Wait when Wait_Ready is
begin
Wait_Ready := False;
Put_Ready := True;
end Wait;
end PT;
end Obj;
2018-12-03 Patrick Bernardi <bernardi@adacore.com>
gcc/ada/
* libgnarl/s-taskin.ads (ATC_Level_Base): Redefine to span from
-1 to Max_ATC_Nesting so that 0 represents no ATC nesting and -1
represented a completed task. To increase readability, new
constants are introduced to represent key ATC nesting levels.
Consequently, Level_No_Pending_Abort replaces
ATC_Level_Infinity. ATC_Level related definitions now
documented.
(Ada_Task_Control_Block): The default initialization of
components ATC_Nesting_Level and Pending_ATC_Level now use new
ATC_Level_Base constants. Comments improved
* libgnarl/s-taskin.adb (Initialize): Improve the initialisation
of the first element of the Entry_Calls array to facilitate
better maintenance.
* libgnarl/s-taasde.ads: Update comment.
* libgnarl/s-taasde.adb, libgnarl/s-taenca.adb,
libgnarl/s-tasren.adb, libgnarl/s-tassta.adb,
libgnarl/s-tasuti.ads, libgnarl/s-tasuti.adb: Use new
ATC_Level_Base constants.
* libgnarl/s-tarest.adb (Create_Restricted_Task): Improve the
initialisation of the first element of the task's Entry_Calls
array to facilitate better maintenance.
* libgnarl/s-tasini.ads (Locked_Abort_To_Level): Update
signature to accept ATC_Level_Base.
* libgnarl/s-tasini.adb (Locked_Abort_To_Level): Update
signature to accept ATC_Level_Base. Use new ATC_Level_Base
constants and only modify the aborting task's Entry_Calls array
if any entry call is happening.
* libgnarl/s-tposen.adb (Protected_Single_Entry_Call): Reference
the first element of the task's Entry_Calls array via 'First
attribute to facilitate better maintenance.
From-SVN: r266752
Eric Botcazou [Mon, 3 Dec 2018 15:49:00 +0000 (15:49 +0000)]
[Ada] Fix assertion failures with -gnatde and -gnatdv
This fixes a couple of assertion failures when using -gnatde and -gnatdv
on a compiler built with assertions enabled. No functional changes.
2018-12-03 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* einfo.adb (Write_Entity_Info): Don't take Scope of Standard
package.
* sem_ch4.adb (Remove_Abstract_Operations): Add missing blank
lines to -gnatdv output.
* sem_type.adb (Write_Overloads): Take Entity of entity names
only.
From-SVN: r266751
Hristian Kirtchev [Mon, 3 Dec 2018 15:48:34 +0000 (15:48 +0000)]
[Ada] Minor reformattings
2018-12-03 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* checks.adb, exp_aggr.adb, exp_attr.adb, exp_ch3.adb,
exp_util.adb, exp_util.ads, repinfo.adb, sem_attr.adb,
sem_ch3.adb, sem_res.adb, sem_util.adb: Minor reformatting.
From-SVN: r266750
Ed Schonberg [Mon, 3 Dec 2018 15:48:03 +0000 (15:48 +0000)]
[Ada] Enhance comment
2018-12-03 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch3.adb (Complete_Private_Subtype): Enhance comment.
From-SVN: r266749
Olivier Hainque [Mon, 3 Dec 2018 15:47:57 +0000 (15:47 +0000)]
[Ada] Gigi support for OpenACC pragmas
Matching front-end bits to support Acc_Kernels, Acc_Parallel,
Acc_Loop and Acc_Data.
2018-12-03 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* gcc-interface/lang.opt (fopenacc): New option for Ada.
* gcc-interface/misc.c (gnat_handle_option): Handle it.
* gcc-interface/trans.c (struct loop_info_d): Add OMP
attributes.
(Iterate_Acc_Clause_Arg, Acc_gnat_to_gnu): New functions,
helpers for OpenACC pragmas processing in Pragma_to_gnu.
(Acc_Var_to_gnu, Acc_Reduc_Var_to_gnu, Acc_Reduc_to_gnu):
Likewise.
(Acc_Size_Expr_to_gnu, Acc_Size_List_to_gnu): Likewise.
(Pragma_Acc_Data_to_gnu): Likewise.
(Pragma_to_gnu): Handle Pragma_Acc_Loop, Pragma_Acc_Data,
Pragma_Acc_Kernels and Pragma_Acc_Parallel.
(Acc_Loop_to_gnu, Regular_Loop_to_gnu): New functions. Helpers
for ...
(Loop_Statement_to_gnu): Rework to handle OpenACC loops.
From-SVN: r266748
Olivier Hainque [Mon, 3 Dec 2018 15:47:52 +0000 (15:47 +0000)]
[Ada] Adjust the default MALLOC_OBSERVABLE_ALIGNMENT to 2 * POINTER_SIZE
Instead of 2 * LONG_TYPE_SIZE. POINTER_SIZE is believed to be the
correct base on more configurations than LONG_TYPE_SIZE and this
adjustment prevents the need for local patches to compensate on
configurations where the latter is inappropriate, for example
x86_64-mingw.
2018-12-03 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* gcc-interface/targtyps.c (MALLOC_OBSERVABLE_ALIGNMENT): Set to
2 * POINTER_SIZE.
From-SVN: r266747
Ed Schonberg [Mon, 3 Dec 2018 15:46:23 +0000 (15:46 +0000)]
[Ada] Missing check on if-expression
This patch fixes a constraint check on a dependent expression of an
if-expression, when the context if given by a slice or the 'Range of
an array. The constraint check is applied if the context is constrained,
but the corresponding flag was not set for the index subtype generated
for a slice (explicit or implicit).
Executing:
gprbuild -P test -q main
./main
Must yield:
raised CONSTRAINT_ERROR : foo.ads:13 range check failed
----
with Types;
generic
Buffer : in out Types.Buffer;
package Foo
is
function Get (Pos : Natural) return Integer;
private
function Get (Pos : Natural) return Integer
is (Buffer ((if Pos in Buffer'Range then Pos else Buffer'First)));
end Foo;
----
with Foo;
with Types;
with Usefoo;
procedure Main is
Z : Types.Buffer := (Natural'Last .. Natural'Last - 1 => 0);
R : Integer;
begin
Usefoo.Do_Something (Z, R);
end Main;
----
pragma SPARK_Mode (On);
pragma Profile (Ravenscar);
pragma Partition_Elaboration_Policy (Sequential);
----
project Test is
package Compiler is
for Default_Switches ("Ada") use ("-gnatws");
for Local_Configuration_Pragmas use "test.adc";
end Compiler;
end Test;
----
package Types
is
subtype Natural_Without_Last is Natural range 1 .. Natural'Last - 1;
type Buffer is array (Natural_Without_Last range <>) of Integer;
end Types;
----
with Foo;
package body Usefoo
is
procedure Do_Something (B : in out Types.Buffer;
R : out Integer)
is
package F is new Foo (B (B'First .. B'First + B'Length / 2 - 1));
begin
R := F.Get (B'First + B'Length / 2 - 1);
end Do_Something;
end Usefoo;
----
with Types;
package Usefoo
is
procedure Do_Something (B : in out Types.Buffer;
R : out Integer)
with Pre => B'First > 0;
end Usefoo;
2018-12-03 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_res.adb (Set_Slice_Subtype): The index type of a slice is
constrained.
From-SVN: r266746
Fritz Reese [Mon, 3 Dec 2018 15:42:51 +0000 (15:42 +0000)]
re PR fortran/87919 (Incorrect fortran handling of -fno-* options)
2018-12-03 Fritz Reese <fritzoreese@gmail.com>
Mark Eggleston <mark.eggleston@codethink.co.uk>
PR fortran/87919
gcc/fortran/ChangeLog:
PR fortran/87919
* options.c (SET_FLAG, SET_BITFLAG, SET_BITFLAG2): New macros.
(set_dec_flags): Set/unset DEC and std flags according to value.
(set_init_local_zero): New helper for -finit-local-zero flag group.
(gfc_init_options): Fix disabling of init flags, array temporaries
check, and dec flags when value is zero (from -fno-*).
gcc/testsuite/ChangeLog:
PR fortran/87919
* gfortran.dg/array_temporaries_5.f90: New test.
* gfortran.dg/dec_bitwise_ops_3.f90: Ditto.
* gfortran.dg/dec_d_lines_3.f: Ditto.
* gfortran.dg/dec_exp_4.f90: Ditto.
* gfortran.dg/dec_exp_5.f90: Ditto.
* gfortran.dg/dec_io_7.f90: Ditto.
* gfortran.dg/dec_structure_24.f90: Ditto.
* gfortran.dg/dec_structure_25.f90: Ditto.
* gfortran.dg/dec_structure_26.f90: Ditto.
* gfortran.dg/dec_structure_27.f90: Ditto.
* gfortran.dg/dec_type_print_3.f90: Ditto.
* gfortran.dg/init_flag_20.f90: Ditto.
Co-Authored-By: Mark Eggleston <mark.eggleston@codethink.co.uk>
From-SVN: r266745
Jeff Law [Mon, 3 Dec 2018 15:21:15 +0000 (08:21 -0700)]
h8300.md (low byte masking peepholes): Only accept nonimmediate_operand for the to-be-masked operand.
* config/h8300/h8300.md (low byte masking peepholes): Only accept
nonimmediate_operand for the to-be-masked operand.
From-SVN: r266744
Jeff Law [Mon, 3 Dec 2018 15:17:03 +0000 (08:17 -0700)]
pr59963-2.c: Make testnames unique.
* gcc.dg/pr59963-2.c: Make testnames unique.
* gcc.dg/tree-ssa/builtin-sprintf-warn-18.c: Likewise.
From-SVN: r266743
Richard Biener [Mon, 3 Dec 2018 15:13:04 +0000 (15:13 +0000)]
tree-ssa-sccvn.c (eliminate_dom_walker::eliminate_stmt): Only allow expected function-pointer cast re-instantiation.
2018-12-03 Richard Biener <rguenther@suse.de>
* tree-ssa-sccvn.c (eliminate_dom_walker::eliminate_stmt): Only
allow expected function-pointer cast re-instantiation.
From-SVN: r266742
Ilya Leoshkevich [Mon, 3 Dec 2018 15:07:36 +0000 (15:07 +0000)]
S/390: Add support for section anchors
gcc/ChangeLog:
2018-12-03 Ilya Leoshkevich <iii@linux.ibm.com>
* common/config/s390/s390-common.c (s390_option_init_struct):
Use section anchors by default.
* config/s390/s390.c (s390_check_symref_alignment): Handle
anchors.
(TARGET_MAX_ANCHOR_OFFSET): Use short displacement.
* output.h (assemble_align): Pass `align' as unsigned int, so
that the value 0x80000000, which corresponds to `aligned(1 <<
28)', would pass the `align > BITS_PER_UNIT' check.
* varasm.c (assemble_align): Likewise.
gcc/testsuite/ChangeLog:
2018-12-03 Ilya Leoshkevich <iii@linux.ibm.com>
* gcc.target/s390/nodatarel-1.c: Expect .LANCHOR0@GOTENT instead
of a@GOTENT.
* gcc.target/s390/section-anchors.c: New test.
* gcc.target/s390/section-anchors2.c: New test.
* gcc.target/s390/section-anchors3.c: New test.
From-SVN: r266741